Project

General

Profile

Activity

From 03/17/2013 to 04/15/2013

04/16/2013

09:35 PM Database Feature #2080: add runtime support for database methods
Vadim Nebogatov wrote:
> BTW, I have fixed one more problem with wrong field order in result (not included to last u...
Eric Faulhaber
09:15 PM Database Feature #1580: upgrade Hibernate to latest level
Stanislav Lomany wrote:
> ...
Eric Faulhaber

04/15/2013

07:58 PM Base Language Feature #1640: implement DOM XML support
I have found next TODOs/issues list:
1) Next methods are not implemented(only stubs):
* com.goldencode.p2j.xml.XEntit...
Evgeny Kiselev
07:08 PM Database Feature #1580: upgrade Hibernate to latest level
Issue 0:
The first issue to fix, the log full of it: ...
Stanislav Lomany
06:03 PM Database Feature #1580: upgrade Hibernate to latest level
Issue 2:
Reproduction:
4 - C - Y - A
Enter data:
I
1029
Stacktrace:...
Stanislav Lomany
04:00 PM Database Feature #1580: upgrade Hibernate to latest level
Issue 1:
Reproduction:
V - O - 1 - W - 2
_Data to enter:_
283338
3.1.5
3.2.2
34000
35000
Stacktrace:
<pre...
Stanislav Lomany
07:04 PM Base Language Feature #1639: implement socket support
Code Review:
1. getByteRange/setByteRange: have you tested these? I don't think they can work properly. For exam...
Greg Shah
03:07 PM Base Language Feature #1639: implement socket support
Added end of the day update.
6. 7. I realize these are just bad implementations, I'll stop including code I finish t...
Costin Savin
02:36 PM Base Language Feature #1613: finish FILE-INFO system handle support
Great! Work with Constantin to get it runtime regression tested. Greg Shah
02:34 PM Base Language Feature #1613: finish FILE-INFO system handle support
Ran conversion, no differences compared to latest from bzr, re-ran file-info and search tests, the results look good. Costin Savin
12:51 PM Base Language Feature #1613: finish FILE-INFO system handle support
It is OK. Get this tested.
Please also retest all the related testcases to prove that the solution is still valid...
Greg Shah
12:27 PM Base Language Feature #1613: finish FILE-INFO system handle support
Added update. I'll start the conversion test if there isn't anything else.
Costin Savin
12:15 PM Base Language Feature #1613: finish FILE-INFO system handle support
Code Review:
1. You have chosen the wrong place to put isPathRelativeToCurrentDir(). FileSystemOps runs on the SE...
Greg Shah
11:02 AM Base Language Feature #1613: finish FILE-INFO system handle support
Added proposed update: moved the isPathRelativeToCurrentDir() method from FileChecker to FileSystemOps, added check t... Costin Savin
10:20 AM Base Language Feature #1613: finish FILE-INFO system handle support
Editing mistake:
Since I couldn't copy/paste the text from the windows 4GL test I had to just write it down and pro...
Costin Savin
10:12 AM Base Language Feature #1613: finish FILE-INFO system handle support
Why was it broken? Greg Shah
09:45 AM Base Language Feature #1613: finish FILE-INFO system handle support
The correct version is:
@SEARCH(".\file.txt"): ?@ Edited it
Costin Savin
09:37 AM Base Language Feature #1613: finish FILE-INFO system handle support
Something is not right in the output you have posted. You posted this:... Greg Shah
07:59 AM Base Language Feature #1613: finish FILE-INFO system handle support
The testcases for using the wrong File separator:... Costin Savin
02:29 PM Base Language Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
> Perhaps I did not document that well. It's about using ? raw literal. Consider the following code:
OK, go with i...
Greg Shah
01:48 PM Base Language Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
Greg,
today I have investigated another point-of view. You mentioned the @DisplayFormat@, and starting to double ch...
Ovidiu Maxiniuc
12:51 PM Base Language Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
Greg Shah wrote:
> More Code Review:
>
> 10. This MathOps method has a typo:
> [...]
Thanks, because of the ran...
Ovidiu Maxiniuc
12:16 PM Base Language Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
Greg Shah wrote:
> Code Review:
>
> 1. The update is missing your BlockManager change.
> 2. DisplayFormat.instan...
Ovidiu Maxiniuc
12:05 PM Base Language Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
More Code Review:
12. What is this code in int64?...
Greg Shah
10:52 AM Base Language Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
More Code Review:
9. CompareOps is fine.
10. This MathOps method has a typo:...
Greg Shah
08:26 AM Base Language Feature #1632 (Closed): implement _MSG() undocumented built-in function
Greg Shah
08:23 AM Base Language Feature #2012 (Closed): runtime support for _MSG() built-in
Greg Shah

04/14/2013

06:48 PM Base Language Feature #2012 (Review): runtime support for _MSG() built-in
Evgeny Kiselev
09:11 PM Base Language Feature #2012 (WIP): runtime support for _MSG() built-in
Evgeny Kiselev
05:33 PM Base Language Feature #1632: implement _MSG() undocumented built-in function
committed evk_upd20130413a.zip in revision 10339 Evgeny Kiselev
10:39 AM Base Language Feature #1632: implement _MSG() undocumented built-in function
It looks good. You can check it in and distribute it. Greg Shah
09:03 PM Base Language Feature #1632: implement _MSG() undocumented built-in function
Corrected javadoc according to №18 comment. Evgeny Kiselev
12:57 PM Base Language Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
> From my research, the -noint64 parameter does not affect in any way the current implementation.
I think you are ...
Greg Shah
10:48 AM Base Language Feature #1650: process launching support for Windows (JNI library changes and any associated modi...
It looks good. Keep going. Greg Shah
09:12 PM Base Language Feature #1980 (WIP): runtime support for DOM XML processing
Evgeny Kiselev

04/13/2013

05:58 PM Base Language Feature #1980: runtime support for DOM XML processing
Please put all history entries into the parent task #1640. Greg Shah
05:57 PM Base Language Feature #1632: implement _MSG() undocumented built-in function
I am fine with the proposed changes.
I do think we need to improve the javadoc. We should explain that the getE...
Greg Shah
08:07 PM Base Language Feature #1632: implement _MSG() undocumented built-in function
Attached update evk_upd20130412c.zip with testcase. Evgeny Kiselev
06:47 AM Database Feature #2080: add runtime support for database methods
BTW, I have fixed one more problem with wrong field order in result (not included to last update I sent). Now fields ... Vadim Nebogatov
06:38 AM Database Feature #2080: add runtime support for database methods
Eric Faulhaber wrote:
> I still think the field names are handled incorrectly. It happens to work in this case, beca...
Vadim Nebogatov

04/12/2013

07:05 PM Base Language Feature #1632: implement _MSG() undocumented built-in function
fixed error with int64 Evgeny Kiselev
06:12 PM Base Language Feature #1632: implement _MSG() undocumented built-in function
Attached update evk_upd20130412a.zip. Implemented getErrorNumberAtIndex method.
Also will provide testcase soon.
Evgeny Kiselev
07:02 PM Base Language Feature #1650: process launching support for Windows (JNI library changes and any associated modi...
> ... Eugenie Lyzenko
06:39 PM Database Feature #2080: add runtime support for database methods
I have attached update vmn_upd20130413a.zip/vmn_upd20130413b.zip as replacement of vmn_upd20130328a.zip/ vmn_upd20130... Vadim Nebogatov
03:18 PM Base Language Feature #1613: finish FILE-INFO system handle support
>> - Unix P2J and 4GL will not find anything when given the path with the opposite separator,
>> - On Windows 4GL yo...
Greg Shah
02:37 PM Base Language Feature #1613: finish FILE-INFO system handle support
> I don't think this is right. For example, why are you appending the \ to ./ in this code: pathName.startsWith("./" ... Costin Savin
01:54 PM Base Language Feature #1613: finish FILE-INFO system handle support
> - Unix P2J and 4GL will not find anything when given the path with the opposite separator,
> - On Windows 4GL you ...
Greg Shah
12:41 PM Base Language Feature #1613: finish FILE-INFO system handle support
Tested with the file separator changed to opposite of what the OS uses,
The results are:
- Unix P2J and 4GL will no...
Costin Savin
09:05 AM Base Language Feature #1613: finish FILE-INFO system handle support
> The resulting code in the FSD.search() method has some blank lines removed where they previously existed. Please pu... Greg Shah
04:58 AM Base Language Feature #1613: finish FILE-INFO system handle support
Added proposed update. Costin Savin
02:59 PM Base Language Feature #1639: implement socket support
Code Feedback:
1. Some of the error messages are still wrong (the host is hard coded to "localhost" but it should ...
Greg Shah
02:06 PM Base Language Feature #1639: implement socket support
End of the day update. Costin Savin
07:04 AM Base Language Feature #1792: implement widget-pool support
Should the runtime task include working on the resources which can be added in a pool or add just the pooling support... Constantin Asofiei
06:02 AM Base Language Feature #1984: make methods to act as "read-only" attributes
From #1920 (note 76):
*GES*
1. The read_only_attribute function in common-progress.rules seems like it will be pain...
Constantin Asofiei
05:45 AM Base Language Feature #1921: implement super-procedures
A resume on what else needs to be done regarding super-procedure chains:
* make the SEARCH-TARGET and SEARCH-SELF em...
Constantin Asofiei
05:32 AM Base Language Bug #1971: emit worker versions for functions to fix source-procedure handle
This has two parts:
# the conversion part, where the worker method is added
# the runtime part, which involves the ...
Constantin Asofiei
05:28 AM Base Language Feature #2123: map the converted method/attribute names to their legacy name
Note 54 from #1920:
About the invalid API calls (when the invoked API is not valid for the current referent). 4GL ...
Constantin Asofiei
05:21 AM Base Language Feature #2123 (New): map the converted method/attribute names to their legacy name
Constantin Asofiei
05:10 AM Base Language Feature #2013: implement the SELF system handle
About the runtime implementation of SELF handles: I don't want to do this in a separate task; instead, each case whic... Constantin Asofiei
04:51 AM Base Language Bug #1968: implement MAP TO actual-name IN handle clause for function definitions
This clause should be easy to integrate in the ControlFlowOps invocation mechanism, as we only need to add a "hook" f... Constantin Asofiei
04:46 AM Base Language Bug #1969: buffer names in get-signature
The unknown part at this time is how the schema can be interogated to get the original buffer name. I expect we alrea... Constantin Asofiei
04:33 AM Base Language Feature #1972: provide full-support for DYNAMIC-FUNCTION set to function parameters
This is a _POLY case which should be solved by #2068 changes for _POLY cases. Estimate 1h to confirm. Constantin Asofiei

04/11/2013

06:17 PM Database Feature #2080: add runtime support for database methods
vmn_upd20130411a.zip is fine. You can check it in and distribute it. It should have no risk to the conversion and s... Greg Shah
05:57 PM Database Feature #2080: add runtime support for database methods
Attached update vmn_upd20130411a.zip is replacement of vmn_upd20130409a.zip, merged with revision 10336
Vadim Nebogatov
05:50 PM Database Feature #2080: add runtime support for database methods
Eric Faulhaber wrote:
> I assume the appropriate @tt1@ record has to be referenced from a previous lookup, like FIND...
Vadim Nebogatov
05:44 PM Database Feature #2080: add runtime support for database methods
Eric Faulhaber wrote:
> Yes, it seems this is converting wrong. We should have another variant of @RecordBuffer.com...
Eric Faulhaber
05:26 PM Database Feature #2080: add runtime support for database methods
Vadim Nebogatov wrote:
> Eric Faulhaber wrote:
> > Vadim Nebogatov wrote:
> > > Will P2J support @SAVE RESULT IN@ ...
Eric Faulhaber
02:50 PM Database Feature #2080: add runtime support for database methods
Greg Shah wrote:
> Code Review for vmn_upd20130409a.zip:
>
> 1. Please remove the recordOrDisplayError() variants...
Vadim Nebogatov
02:20 PM Database Feature #2080: add runtime support for database methods
Eric Faulhaber wrote:
> Vadim Nebogatov wrote:
> > Will P2J support @SAVE RESULT IN@ option in @BUFFER-COMPARE@?
>...
Vadim Nebogatov
01:18 PM Database Feature #2080: add runtime support for database methods
Code Review for vmn_upd20130409a.zip:
1. Please remove the recordOrDisplayError() variants. It is too confusing t...
Greg Shah
10:07 AM Database Feature #2080: add runtime support for database methods
Vadim Nebogatov wrote:
> Will P2J support @SAVE RESULT IN@ option in @BUFFER-COMPARE@?
Yes, we need to support th...
Eric Faulhaber
05:08 PM Base Language Feature #1639: implement socket support
Code Review:
1. Messages that embed the local host's port number must be built dynamically at runtime with the cor...
Greg Shah
03:12 PM Base Language Feature #1639: implement socket support
Added "end of the day" update, this doesn't contain fix for all the issues from review (valid() I must see behavior). Costin Savin
02:18 PM Base Language Feature #1639: implement socket support
> I solved them by using complete name of java.net.Socket
That is fine for now.
Greg Shah
02:17 PM Base Language Feature #1639: implement socket support
More feedback:
This code in SocketListenerImpl.startListening() is wrong:...
Greg Shah
02:12 PM Base Language Feature #1639: implement socket support
The list of things to be done at the moment:
On SOCKET side:
- I modified the read methods because the GET-BYTES-AV...
Costin Savin
02:10 PM Base Language Feature #1639: implement socket support
Code Review for
1. Remember that we do NOT put individual import statements in code unless we are needing to over...
Greg Shah
01:20 PM Base Language Feature #1639: implement socket support
> what is left to be done
I am still waiting to see a detailed list of what is left to be implemented OR investiga...
Greg Shah
04:20 PM Base Language Feature #1650: process launching support for Windows (JNI library changes and any associated modi...
> I would suggest to replace this call with:
> ...
> sb.append(pkgroot.replaceAll("\\.", StringHelper.fixupRegex(fi...
Greg Shah
03:48 PM Base Language Feature #1613: finish FILE-INFO system handle support
Code Review of cs_upd20130410a.zip:
Generally I am fine with this update.
The resulting code in the FSD.searc...
Greg Shah
02:48 PM Base Language Feature #1613: finish FILE-INFO system handle support
> Were any of your changes applied at the time?
Yes the allowDir additional check only but that should not affect an...
Costin Savin
02:42 PM Base Language Feature #1613: finish FILE-INFO system handle support
Which bzr revision of P2J did you use to get the results of note 42?
Were any of your changes applied at the time?...
Greg Shah
01:25 PM Base Language Feature #1613: finish FILE-INFO system handle support
Considering we have the following directory structure:... Costin Savin
03:00 PM Base Language Feature #1634: implement full native library (.so or DLL) support
About the parameter validation: as the native side has no idea of the routine's signature (thanks for the details, it... Constantin Asofiei
12:11 PM Base Language Feature #1634: implement full native library (.so or DLL) support
> How will the native code know to convert a value from "ABL data type" to "ABL DLL type" (better said, if signature ... Greg Shah
11:08 AM Base Language Feature #1634: implement full native library (.so or DLL) support
> I was referring to NativeInvoker.invoke(). I'd like you to take that part. I will handle NativeInvoker.invokeRout... Constantin Asofiei
10:34 AM Base Language Feature #1634: implement full native library (.so or DLL) support
> Looks like I skipped the "native" modifier for the NativeInvoker.invokeRoutine() signature. Idea is this is a nativ... Greg Shah
05:34 AM Base Language Feature #1634: implement full native library (.so or DLL) support
Greg Shah wrote:
> I was planning to build the part of the solution from the NativeInvoker.invokeRoutine() on down t...
Constantin Asofiei
02:43 PM Database Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
In addition to the requirements in note 1, we will have to deal with the following:
* name conversion, to ensure tab...
Eric Faulhaber
01:11 PM Database Feature #2122: add runtime support for dynamically prepared temp-tables
This issue is meant to track hours for implementing runtime support. All history/discussion should be posted to the ... Eric Faulhaber
01:10 PM Database Feature #2122 (Closed): add runtime support for dynamically prepared temp-tables
Eric Faulhaber
12:47 PM Database Feature #1580: upgrade Hibernate to latest level
SO creation error was related to already solved boolean literal rendering issue, it turned out that one file was merg... Stanislav Lomany
12:16 PM Base Language Feature #2121: implement Java runtime support for native libraries
This is just for time tracking. Place all history in parent task #1634. Greg Shah
12:15 PM Base Language Feature #2121 (Closed): implement Java runtime support for native libraries
Greg Shah

04/10/2013

05:57 PM Database Feature #2080: add runtime support for database methods
Will P2J support @SAVE RESULT IN@ option in @BUFFER-COMPARE@? Vadim Nebogatov
05:56 PM Base Language Feature #1634: implement full native library (.so or DLL) support
I was planning to build the part of the solution from the NativeInvoker.invokeRoutine() on down to the OS. It is not... Greg Shah
07:04 AM Base Language Feature #1634: implement full native library (.so or DLL) support
Some ideas on how the code for native proc call should work and what needs to be done:
* determine how the argument v...
Constantin Asofiei
03:34 PM Database Feature #1658: improve database trigger support
My estimates:
1. 3 h - Allow registration for WRITE and FIND schema triggers.
2. 16 h, need to find these proper ...
Stanislav Lomany
02:55 PM Database Feature #1658: improve database trigger support
What needs to be done:
1. Allow registration for WRITE and FIND schema triggers.
2. Fire WRITE and FIND triggers ...
Stanislav Lomany
03:03 PM Base Language Feature #1635: implement MEMPTR/RAW support
The error behavior of all the BinaryData.get/set*() methods will need to be researched before implementation. If all... Greg Shah
02:39 PM Base Language Feature #1635: implement MEMPTR/RAW support
A more detailed look at NIO ByteBuffer makes it clear that it is not a suitable solution for our problem. In particu... Greg Shah
12:28 PM Base Language Feature #1650: process launching support for Windows (JNI library changes and any associated modi...
The issues(related or partially) to discuss so far:
1. The source file com/goldencode/p2j/util/SourceNameMapper.ja...
Eugenie Lyzenko
11:24 AM Base Language Feature #1613: finish FILE-INFO system handle support
After some tests I found some more problems in the search algorithm for example the file.isAbsolute() check should a... Costin Savin
08:09 AM Base Language Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
OK, after you are finished with #1650, you can fix the propath assignment behavior. When that is done we will close ... Greg Shah
07:29 AM Conversion Tools Bug #2114: analyze if there are any other "no reference" use cases which are mis-converted
To search for "no reference" fields, is best to go through the list of all 4GL statements/functions and check if a st... Constantin Asofiei

04/09/2013

07:09 PM Base Language Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
> Is this done?
I have clarified this point. Both Windows and Linux 4GL systems shows the same behavior:...
Eugenie Lyzenko
04:46 PM Base Language Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
The final work with this task was checked in as bzr revision 10152 on January 17, 2013. As far as I know this task m... Greg Shah
05:29 PM Database Feature #1580: upgrade Hibernate to latest level
@lib/hibernate3.jar@ and @lib/ehcache-1.1.jar@ should be removed. Stanislav Lomany
05:05 PM Base Language Feature #1634: implement full native library (.so or DLL) support
Constantin: can you define the native API you will need in order to finish the ControlFlowOps support for native proc... Greg Shah
04:56 PM Base Language Feature #1613: finish FILE-INFO system handle support
While you are working on the final fixes to FSD.search(), I would like to get a safe version of all the other changes... Greg Shah
02:03 PM Base Language Feature #1613: finish FILE-INFO system handle support
These investigations are all going in the right direction. Continue your analysis and make a list of the problems in... Greg Shah
12:37 PM Base Language Feature #1613: finish FILE-INFO system handle support
This part of the previous code ... Costin Savin
09:48 AM Base Language Feature #1613: finish FILE-INFO system handle support
After I retested to see what I've missed (both Unix and Windows) I realized that the behavior of search for files and... Costin Savin
01:29 PM Database Feature #2120: add runtime support for dynamically prepared queries
A prototype will integrate limited conversion support into the runtime environment, such that given a set of buffers ... Eric Faulhaber
01:18 PM Database Feature #2120 (Closed): add runtime support for dynamically prepared queries
Eric Faulhaber
01:28 PM Base Language Feature #1650: process launching support for Windows (JNI library changes and any associated modi...
> Reworked file names to simplify. Unfortunately for now process.h has compilation issue in Windows. So the file is:... Greg Shah
08:30 PM Base Language Feature #1650: process launching support for Windows (JNI library changes and any associated modi...
The next drop includes:
1. Restored missing code for linux process file to handle SIGCHLD
2. Reworked file names to...
Eugenie Lyzenko
11:56 AM Database Bug #2034: correct conversion of CAN-FIND({FIRST|LAST} ... {SHARE-LOCK|EXCLUSIVE_LOCK} [NO-WAIT])
On second thought, as long as the sort phrase is correct, @hasAny@ will find the correct first or last record. So, r... Eric Faulhaber
10:58 AM Database Bug #2083: client-side where-clause leak in FindQuery
Ovidiu, I would like to close out this issue. Please confirm that the test case(s) you were using work correctly wit... Eric Faulhaber
05:11 AM Database Feature #2080: add runtime support for database methods
Greg, please check attached update vmn_upd20130409a.zip merged with revision 10336
I added method recordOrDisplayEr...
Vadim Nebogatov
10:36 PM Database Feature #2118 (Closed): add runtime support for _index and _index-field metadata tables
Eric Faulhaber
10:35 PM Database Feature #2117 (Closed): add runtime support for _lock metadata table
Eric Faulhaber
10:34 PM Database Feature #2116 (Closed): add runtime support for _user metadata table
Eric Faulhaber
10:33 PM Database Feature #2115 (Closed): add runtime support for _file and _field metadata tables
Eric Faulhaber

04/08/2013

07:16 PM Base Language Feature #1650: process launching support for Windows (JNI library changes and any associated modi...
> 2. Please use the "simple" process.h and filesys.h instead of the longer *_helper.h versions.
I had the same ide...
Eugenie Lyzenko
06:59 PM Base Language Feature #1650: process launching support for Windows (JNI library changes and any associated modi...
Code Feedback:
1. Please remove the following from future updates:...
Greg Shah
06:21 PM Database Feature #2080: add runtime support for database methods
Vadim: please prepare a separate update with the ErrorManager related changes. I know you have ongoing work on the b... Greg Shah
09:53 AM Database Feature #2080: add runtime support for database methods
Constantin: I think that Vadim is trying to create an alternate version of ErrorManager.recordOrShowError() that does... Greg Shah
05:10 PM Database Feature #1580: upgrade Hibernate to latest level
Please post an update including your work so far, so I can begin reviewing. Eric Faulhaber
03:19 PM Database Feature #1580: upgrade Hibernate to latest level
At this point I'm aware of the single issue which occurs on SO creation. I'll run regression testing in order to reve... Stanislav Lomany
01:48 PM Base Language Feature #1639: implement socket support
As mentioned in note 58, please document the list of things that still need to be completed, fixed or investigated. ... Greg Shah
01:15 PM Base Language Feature #1639: implement socket support
Added an intermediate update, this is just initial form, there are still many things to implement and bring to a clea... Costin Savin
01:44 PM Conversion Tools Bug #2114: analyze if there are any other "no reference" use cases which are mis-converted
Constantin: please update this task with any ideas on where there may be additional issues lurking. Greg Shah
01:25 PM Conversion Tools Bug #2114: analyze if there are any other "no reference" use cases which are mis-converted
Buffer scoping "no reference" instances are schema references that do not affect buffer scoping. They occur in thing... Greg Shah
01:21 PM Conversion Tools Bug #2114 (New): analyze if there are any other "no reference" use cases which are mis-converted
Greg Shah
01:30 PM Database Feature #2092: add server-side database support for several builtin functions
commited to bzr as revision 10336 Costin Savin
01:22 PM Database Feature #2092: add server-side database support for several builtin functions
updated file header comments
Costin Savin
11:41 AM Database Feature #2092: add server-side database support for several builtin functions
The changes in cs_upd20130405b.zip (a superset of 0405a) look good. Please update the file header comments to reflec... Eric Faulhaber
01:18 PM Conversion Tools Bug #2113: convert/comments.rules should ignore artificial nodes when trying to match comments to...
It is not clear that this is 100% correct, but it is thought that at least some artificial nodes (AST nodes that have... Greg Shah
01:17 PM Conversion Tools Bug #2113 (New): convert/comments.rules should ignore artificial nodes when trying to match comme...
Greg Shah
01:14 PM Conversion Tools Feature #2112 (New): blank lines before and/or after a comment should result in spacers in the co...
Greg Shah
01:13 PM Conversion Tools Feature #2111: improve handling of comments that are related to each other ("sets" of comments)
Sets of comments that match the following rules should be treated differently:
1. There is no code in between the ...
Greg Shah
01:09 PM Conversion Tools Feature #2111 (New): improve handling of comments that are related to each other ("sets" of comme...
Greg Shah
01:07 PM Conversion Tools Feature #2110: improve orphan comment processing
1. Reduce the number of orphan comments by implementing better heuristics for matching comments to the code they refe... Greg Shah
01:05 PM Conversion Tools Feature #2110 (Closed): improve orphan comment processing
Greg Shah
01:00 PM Conversion Tools Bug #2109 (New): a comment that is the first node in a block doesn't have a new-line after it
Greg Shah
12:26 PM Base Language Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
I will be reviewing the 0406 updates shortly.
I assume you are now working on the datetime/datetime_tz changes. P...
Greg Shah
11:40 AM Base Language Feature #2108: event model rationalization
The 4GL event model is inherently "client" oriented. It's primary usage is built around the user-interface and the i... Greg Shah
11:07 AM Base Language Feature #2108 (Closed): event model rationalization
Greg Shah

04/07/2013

01:33 PM Base Language Feature #1650: process launching support for Windows (JNI library changes and any associated modi...
The next drop changes:
1. P2J build.xml file has been changed to pass OS architecture to the makefile for Windows com...
Eugenie Lyzenko

04/06/2013

12:37 PM Base Language Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
I have found that the @int64@ variables (including @extent@) were not correctly initialized to 0. I fixed this.
I ad...
Ovidiu Maxiniuc
10:51 AM Database Feature #2080: add runtime support for database methods
To display a message, use the @LogicalTerminal.message@ API from the business logic (note that each message gets wrap... Constantin Asofiei

04/05/2013

06:08 PM Database Feature #2080: add runtime support for database methods
Constantin Asofiei wrote:
> For cases when ERROR condition is not raised but messages are still shown, the new @di...
Vadim Nebogatov
05:03 AM Database Feature #2080: add runtime support for database methods
> You described how to implement runtime behavior similar to 4GL in each concrete case. But my question was actually ... Constantin Asofiei
02:15 PM Base Language Feature #1639: implement socket support
So far I've completed the connect (including ssl) on socket part and tested it, and also added code for read and wri... Costin Savin
07:44 AM Base Language Feature #1639: implement socket support
Costin: please put details here about what you are doing with the implementation, what is completed and what is left ... Greg Shah
01:44 PM Base Language Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
I checked today and adjusted the code for the function calls (direct calls specially) and database access.
The imple...
Ovidiu Maxiniuc
08:56 AM Base Language Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
> 5 and 6 work fine, I double checked. If pos + len is 33/65 means that the bits involved are the last len bits from ... Greg Shah
08:48 AM Base Language Feature #1650: process launching support for Windows (JNI library changes and any associated modi...
I like it. Keep going in this direction. Greg Shah
08:23 AM Base Language Feature #1626: implement OS-DIR support as an INPUT stream
OK, that is fine. Please put comments into that code to explain this, so that future readers will not accidentally c... Greg Shah
08:11 AM Base Language Feature #1626: implement OS-DIR support as an INPUT stream
Sorry I forgot to mention about that. The reason is when we have a link, getting the canonicalPath of the link file w... Costin Savin
08:01 AM Base Language Feature #1626: implement OS-DIR support as an INPUT stream
Please describe the reasons behind the DirStream.getPathName() change in cs_upd20130404a.zip. Greg Shah
08:21 AM Base Language Feature #1613: finish FILE-INFO system handle support
Code Feedback:
1. See note 52 in #1626.
2. The FSD.search() change to use file.getPath().startsWith(".") is not...
Greg Shah
06:04 AM Database Feature #2092: add server-side database support for several builtin functions
chr also exist in postgress , renamed it to toChr, didn't find anything for the others. Costin Savin
04:47 AM Database Feature #2092: add server-side database support for several builtin functions
Added update Costin Savin
04:13 AM Database Feature #2092: add server-side database support for several builtin functions
It seems "replace" already is a function name in PostgreSql. I will replace "replace" with "replaceText" and search f... Costin Savin
04:58 AM Base Language Feature #1920: implement persistent procedures
You can go ahead and commit/release om_upd20130405a.zip
LE: just runtime changes, no conversion regression testing n...
Constantin Asofiei
04:56 AM Base Language Feature #1920: implement persistent procedures
Comment type changed to single-line. Ovidiu Maxiniuc
04:47 AM Base Language Feature #1920: implement persistent procedures
Review of om_upd20130404a.zip - do not use @/*@ for adding comments, always use @//@ single-line comments. Please mak... Constantin Asofiei

04/04/2013

05:59 PM Database Feature #2080: add runtime support for database methods
Vadim Nebogatov wrote:
> I have attached update vmn_upd20130401a.zip/vmn_upd20130401b.zip
> It contains @FETCH-SELE...
Eric Faulhaber
04:46 PM Database Feature #2080: add runtime support for database methods
You described how to implement runtime behavior similar to 4GL in each concrete case. But my question was actually no... Vadim Nebogatov
03:18 PM Database Feature #2080: add runtime support for database methods
> I still don't understand how ErrorManager will recognize what mode (silent or not) should be used. From examples I ... Constantin Asofiei
02:38 PM Database Feature #2080: add runtime support for database methods
Constantin Asofiei wrote:
> # add the new @ErrorManager.displayOrLogError@ API now, so you can use it for error mess...
Vadim Nebogatov
01:14 PM Base Language Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
I went on with integer-type parameter passing and implemented the same mechanism for @integer@/@int64@ as it was for ... Ovidiu Maxiniuc
01:00 PM Base Language Feature #1920: implement persistent procedures
This update fixes:
* @unknown@ parameter in function/procedure calls. The unknown values for some data types (@date@...
Ovidiu Maxiniuc
07:35 AM Base Language Feature #1613: finish FILE-INFO system handle support
> If the PROPATH is /path1/,/path2/,/path3/,. then a search for relative/path/to/file.txt would find /path1/relative/... Costin Savin

04/03/2013

06:40 PM Base Language Feature #1650: process launching support for Windows (JNI library changes and any associated modi...
Today drop has been uploaded. Includes:
1. Rework for build.xml to separate common native tasks. Adding required com...
Eugenie Lyzenko
09:25 AM Base Language Feature #1650: process launching support for Windows (JNI library changes and any associated modi...
I am generally fine with the build.xml approach. The only thing I see is this:... Greg Shah
08:11 PM Base Language Feature #1650: process launching support for Windows (JNI library changes and any associated modi...
OK. This drop contains only changes in build.xml project build file to review. Plus one small change for filesys.c fo... Eugenie Lyzenko
02:29 PM Base Language Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
Greg,
I have integrated your feedback into the code for notes 1, 2, 3 and 4.
5 and 6 work fine, I double checked. ...
Ovidiu Maxiniuc
01:16 PM Database Feature #2080: add runtime support for database methods
The Text.setTemporaryCaseSensitive (actually the entire class) is extracted from the character.java class. I don't th... Constantin Asofiei
08:23 AM Database Feature #2080: add runtime support for database methods
Eric Faulhaber wrote:
> * Please re-read the JavaDoc for @Text.setTemporaryCaseSensitive@. I'm not sure it was meant...
Vadim Nebogatov
07:17 AM Database Feature #2080: add runtime support for database methods
Vadim Nebogatov wrote:
> Constantin Asofiei wrote:
>
> > Again, the testcase does not help us in determining the ...
Constantin Asofiei
06:13 AM Database Feature #2080: add runtime support for database methods
Constantin Asofiei wrote:
> Again, the testcase does not help us in determining the NO-ERROR behavior, as a runtime ...
Vadim Nebogatov
12:55 PM Base Language Feature #1613: finish FILE-INFO system handle support
Tested by having this structure @/workcs/file.txt@ in the current folder(@/home/costins@)
and setting propath varia...
Costin Savin
09:03 AM Base Language Feature #1613: finish FILE-INFO system handle support
> I removed the check for current directory because I considered it is already checked in the begining with file.exis... Greg Shah
06:08 AM Base Language Bug #2106: Missing runtime error messages in P2J
Moved from #2080, note 74
Example:...
Vadim Nebogatov

04/02/2013

04:11 PM Base Language Bug #2106: Missing runtime error messages in P2J
Moved from #2080, note 74
Example:...
Vadim Nebogatov
01:22 PM Base Language Bug #2106: Missing runtime error messages in P2J
Moved from #2080, note 78
Example:...
Vadim Nebogatov
01:21 PM Base Language Bug #2106: Missing runtime error messages in P2J
Moved from #2080, note 77
Example:...
Vadim Nebogatov
01:19 PM Base Language Bug #2106 (New): Missing runtime error messages in P2J
Vadim Nebogatov
01:29 PM Base Language Feature #1613: finish FILE-INFO system handle support
> 2.
> You are right, the case insensitive path is now broken with your changes. Please fix it.
I'm not sure it's...
Costin Savin
10:37 AM Base Language Feature #1613: finish FILE-INFO system handle support
> 3. This code looks wrong and it definitely breaks behavior that we rely upon today:
>
> // if the path length is...
Costin Savin
07:49 AM Base Language Feature #1613: finish FILE-INFO system handle support
Also, please note that your update zip filename is not matching our standard naming conventions. You don't need to c... Greg Shah
06:58 AM Base Language Feature #1613: finish FILE-INFO system handle support
Code Feedback:
1. This code in filesys.c still needs to close the file descriptor before returning:...
Greg Shah
06:24 AM Base Language Feature #1613: finish FILE-INFO system handle support
> The 4GL bug which sees .. directory as hidden for os dir is described in DirStream class (it happpends because the ... Greg Shah
12:48 PM Database Feature #2080: add runtime support for database methods
> > *class Date, line 1435* - note 70
> Should I fix it directly in CVS without sending special update and regressio...
Constantin Asofiei
12:19 PM Database Feature #2080: add runtime support for database methods
Constantin Asofiei wrote:
> Please edit each case and add the value of the ERROR:NUM-MESSAGES attribute (you can add ...
Vadim Nebogatov
06:09 AM Base Language Feature #1650: process launching support for Windows (JNI library changes and any associated modi...
Feedback:
It is OK so far. Make sure you merge with the latest version of P2J (for example the build.xml that you...
Greg Shah
05:47 AM Base Language Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
Code Feedback:
1. The instantiateUnknownRaw() method should be positioned after the constructors in the raw.java.
...
Greg Shah

04/01/2013

05:58 PM Database Feature #2080: add runtime support for database methods
Eric Faulhaber wrote:
> Code review 20130328a:
>
> * Why have you commented out the re-throwing of the @reason@ T...
Vadim Nebogatov
04:41 PM Database Feature #2080: add runtime support for database methods
I have attached update vmn_upd20130401a.zip/vmn_upd20130401b.zip
It contains @FETCH-SELECTED-ROW()@ conversion, usin...
Vadim Nebogatov
11:46 AM Database Feature #2080: add runtime support for database methods
Please edit each case and add the value of the ERROR:NUM-MESSAGES attribute (you can add it in the same MESSAGE line ... Constantin Asofiei
11:22 AM Base Language Feature #1920: implement persistent procedures
Note 80 from #2080 shows a missing error for function invocation:... Constantin Asofiei
10:53 AM Base Language Feature #1613: finish FILE-INFO system handle support
Added proposed update, with the modified search function, eliminated the change in EnvironmentOps since it wasn't nec... Costin Savin
09:29 AM Base Language Feature #1613: finish FILE-INFO system handle support
> In the Javadoc of EnvironmentOps.searchPath() there is this saying:
I think you mean EnvironmentOps.getSearchPat...
Greg Shah

03/31/2013

05:36 PM Database Feature #2080: add runtime support for database methods
Vadim Nebogatov wrote:
> Duding testing I have found out that @FETCH-SELECTED-ROW()@ conversion requires @BrowseWidg...
Eric Faulhaber
05:35 PM Database Feature #2080: add runtime support for database methods
Code review 20130328a:
* Why have you commented out the re-throwing of the @reason@ Throwable in @BlockManager.pro...
Eric Faulhaber

03/30/2013

06:45 AM Database Feature #2080: add runtime support for database methods

*class <Not found in code>*
Example:...
Vadim Nebogatov
06:42 AM Database Feature #2080: add runtime support for database methods
*class <Not found in code>*
Example:...
Vadim Nebogatov
06:40 AM Database Feature #2080: add runtime support for database methods
*class <Not found in code>*
Example:...
Vadim Nebogatov
06:37 AM Database Feature #2080: add runtime support for database methods
*class ControlFlowOps, line 3519*
Example:...
Vadim Nebogatov
05:57 AM Database Feature #2080: add runtime support for database methods
Moved to #2106, note 2
*class <Not found in code>*
Example:...
Vadim Nebogatov
05:43 AM Database Feature #2080: add runtime support for database methods
Moved to #2106, note 1
*class <Not found in code>*
Example:...
Vadim Nebogatov
05:29 AM Database Feature #2080: add runtime support for database methods
this note should be ignored according note 85
*class HandleOps, line 67*
Example:...
Vadim Nebogatov
05:24 AM Database Feature #2080: add runtime support for database methods
*class handle, line 254*
Example:...
Vadim Nebogatov
05:18 AM Database Feature #2080: add runtime support for database methods
Moved from #2080, notes 3,4
*class BrowseWidget, line 751*
Example:...
Vadim Nebogatov
04:59 AM Database Feature #2080: add runtime support for database methods
*class NumberType, line 3189*
Example:...
Vadim Nebogatov
04:55 AM Database Feature #2080: add runtime support for database methods
*class ControlFlowOps, line 3577*
Example:...
Vadim Nebogatov
04:36 AM Database Feature #2080: add runtime support for database methods
*class ControlFlowOps, line 2991*
Example:...
Vadim Nebogatov

03/29/2013

07:06 PM Base Language Feature #1650: process launching support for Windows (JNI library changes and any associated modi...
This is update just for review to see the approach. It compiles native DLL in Windows 32-bit using mingw32-gcc. Plann... Eugenie Lyzenko
05:32 PM Database Feature #2080: add runtime support for database methods
*class Date, line 1435*
Example:...
Vadim Nebogatov
04:48 PM Database Feature #2080: add runtime support for database methods
In regard to the use of an .odt document for reporting information about the errors, I prefer that you put the inform... Greg Shah
01:44 PM Database Feature #2080: add runtime support for database methods
I have found also that @SESSION:TIMEZONE@ is not supported (but mentioned in code).
Example is ...
Vadim Nebogatov
01:41 PM Base Language Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
This update adds implementation for all TODOs from @int64@ and, since the implementation is mostly the same for the @... Ovidiu Maxiniuc
12:43 PM Database Bug #2093 (Closed): VALEXP support in P2J
Eric Faulhaber
12:42 PM Database Bug #2093: VALEXP support in P2J
At this moment, with the exception of the cases where the expression from the string condition is not valid, I don't ... Ovidiu Maxiniuc
10:36 AM Database Bug #2093: VALEXP support in P2J
Is there anything left to do on this issue or can it be closed? Eric Faulhaber
10:41 AM User Interface Feature #2088 (Closed): add HIDE STREAM statement support
Eric Faulhaber
10:38 AM Conversion Tools Feature #2001 (Closed): reporting v2.5
Eric Faulhaber
10:26 AM Database Bug #2095 (Closed): FIELDS/EXCEPT record phrase options not honored
Eric Faulhaber
09:43 AM Database Bug #2097 (Closed): FOR EACH with multiple, nested CAN-FINDs converts badly
The fix has addressed the original problem and does not appear to have regressed anything else in the customer's serv... Eric Faulhaber
09:19 AM Base Language Bug #2105: BlockManager does not return some datatypes correctly
A first attempt to fix would be to have only one @returnNormal@ static function with a BDT parameter and the value wr... Ovidiu Maxiniuc
09:04 AM Base Language Bug #2105: BlockManager does not return some datatypes correctly
Consider the following 4GL code:... Ovidiu Maxiniuc
08:55 AM Base Language Bug #2105 (New): BlockManager does not return some datatypes correctly
Ovidiu Maxiniuc
09:19 AM Database Bug #2094 (Closed): OUTER-JOIN record phrase option not honored
Eric Faulhaber

03/28/2013

06:59 PM Database Feature #2080: add runtime support for database methods
I have attached update vmn_upd20130328a.zip/vmn_upd20130328b.zip as replacement of vmn_upd20130326a.zip/ vmn_upd20130... Vadim Nebogatov
06:23 PM Database Feature #2080: add runtime support for database methods
Eric, sorry for so dangerous RecordBuffer.java. I think it was wrong bazaar merge with latest bzr revision. I do not ... Vadim Nebogatov
05:10 PM Database Feature #2080: add runtime support for database methods
Document with tests is updated Vadim Nebogatov
03:56 PM Database Feature #2080: add runtime support for database methods
Regarding vmn_upd20130326a.zip: there are hundreds of unnecessary/unwanted format changes in RecordBuffer, which mak... Eric Faulhaber
01:07 PM Database Feature #2080: add runtime support for database methods
Duding testing I have found out that @FETCH-SELECTED-ROW()@ conversion requires @BrowseWidget.fetchSelectedRow()@ wit... Vadim Nebogatov
01:26 PM Base Language Feature #1613: finish FILE-INFO system handle support
I retested the cases from UAST which contained search function or Propath and there weren't any difference,
However ...
Costin Savin
08:53 AM Base Language Feature #1613: finish FILE-INFO system handle support
In the Javadoc of EnvironmentOps.searchPath() there is this saying:... Costin Savin
08:48 AM Base Language Feature #1613: finish FILE-INFO system handle support
I don't understand why the comma is included in the default path. We already have protection against the path being ... Greg Shah
08:37 AM Base Language Feature #1650: process launching support for Windows (JNI library changes and any associated modi...
You are allowed to use Windows in KVM on the same Ubuntu system. It will be allowed in the standards. Thanks for as... Greg Shah
03:22 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
The updates om_upd20130325a.zip and om_upd20130325b.zip were committed to bzr (rev 10330, and rev. 10332) and distrib... Ovidiu Maxiniuc

03/27/2013

06:22 PM Database Feature #2080: add runtime support for database methods
I have attached some first test cases. Is such format would be ok?
Please notice that I found also some cases that ...
Vadim Nebogatov
04:21 PM Base Language Feature #1650: process launching support for Windows (JNI library changes and any associated modi...
The question. I have idea to install The Windows inside the KVM Virtual Machine on my new Ubuntu box. Will it also co... Eugenie Lyzenko
03:17 PM Database Bug #2097: FOR EACH with multiple, nested CAN-FINDs converts badly
The update has passed conversion regression testing and is committed to bzr rev. 10333. Eric Faulhaber
02:20 PM Database Bug #2097: FOR EACH with multiple, nested CAN-FINDs converts badly
A fix candidate is attached. Currently running it through conversion regression testing. Eric Faulhaber
02:58 PM Base Language Feature #1613: finish FILE-INFO system handle support
There seems to be an error in the search() logic of FileSystemDaemon.
If the given paths Array is non null it will s...
Costin Savin
10:11 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
om_upd20130325b.zip passed conversion testing. You can check in and distribute the update. Greg Shah

03/26/2013

05:22 PM Database Feature #2080: add runtime support for database methods
I have attached update vmn_upd20130326a.zip/ vmn_upd20130326b.zip
with current state of BUFFER-COPY() and BUFFER-COM...
Vadim Nebogatov
09:58 AM Database Feature #2080: add runtime support for database methods
I want to resolve this properly as part of this work. This includes any cases of ErrorManager.displayError() that sh... Greg Shah
03:23 PM Database Bug #2097: FOR EACH with multiple, nested CAN-FINDs converts badly
Ovidiu Maxiniuc wrote:
> ...but I wonder if we shouldn't treat the first @each person@ the same like @each w-person@...
Eric Faulhaber
09:57 AM Database Bug #2097: FOR EACH with multiple, nested CAN-FINDs converts badly
I understand. The algorithm is working in fact if you analyze the first clause that works.
And starting from here, I...
Ovidiu Maxiniuc
09:31 AM Database Bug #2097: FOR EACH with multiple, nested CAN-FINDs converts badly
Ovidiu Maxiniuc wrote:
> The reason why the where clause filtered to client-side is probably the @where_clause_prep2...
Eric Faulhaber
04:44 AM Database Bug #2097: FOR EACH with multiple, nested CAN-FINDs converts badly
The reason why the where clause filtered to client-side is probably the @where_clause_prep2.rules@. You can read in i... Ovidiu Maxiniuc
02:53 AM Database Bug #2097: FOR EACH with multiple, nested CAN-FINDs converts badly
I have isolated the #2068 note 272 regression like this:... Constantin Asofiei
11:13 AM Base Language Feature #1613: finish FILE-INFO system handle support
Code Feedback:
1. StreamWrapper has no real changes other than the copyright date and the history entry. Does it ...
Greg Shah
09:49 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
I am fine with the code changes. I will conversion test these now. Greg Shah

03/25/2013

04:31 PM Database Bug #2097 (Review): FOR EACH with multiple, nested CAN-FINDs converts badly
The ecf_upd20130325e.zip update (finally) has passed conversion regression testing; there are some differences in th... Eric Faulhaber
03:56 PM Database Bug #2097: FOR EACH with multiple, nested CAN-FINDs converts badly
Hopefully the final candidate; conversion regression testing it now. Eric Faulhaber
01:39 PM Database Bug #2097: FOR EACH with multiple, nested CAN-FINDs converts badly
Another candidate, in conversion regression testing now. Eric Faulhaber
09:49 AM Database Bug #2097: FOR EACH with multiple, nested CAN-FINDs converts badly
While there are a number of expected differences, there are also still some regressions, though far fewer than the la... Eric Faulhaber
05:37 AM Database Bug #2097: FOR EACH with multiple, nested CAN-FINDs converts badly
Fix candidate for regressions. Testing now. Eric Faulhaber
04:53 AM Database Bug #2097: FOR EACH with multiple, nested CAN-FINDs converts badly
This update regresses many files in Majic; cannot check it in. Eric Faulhaber
03:59 AM Database Bug #2097: FOR EACH with multiple, nested CAN-FINDs converts badly
Missed a bit of cleanup in one of the files. Eric Faulhaber
03:48 AM Database Bug #2097: FOR EACH with multiple, nested CAN-FINDs converts badly
A fix candidate and test cases are attached. I am currently putting the fix through conversion regression testing. ... Eric Faulhaber
04:14 PM Base Language Feature #1626: implement OS-DIR support as an INPUT stream
Added proposed update.The update is for both #1613 and #1626 Costin Savin
04:13 PM Base Language Feature #1613: finish FILE-INFO system handle support
Added proposed update.The update is for both #1613 and #1626 Costin Savin
03:58 PM Database Feature #2080: add runtime support for database methods
OK, I forgot that the ERROR attribute is set for error conditions raised when the NO-ERROR clause is used (this expla... Constantin Asofiei
03:30 PM Database Feature #2080: add runtime support for database methods
Constantin,
I have removed @SESSION:SUPPRESS-WARNINGS = YES.@ and started from command line. But it did not affect ...
Vadim Nebogatov
05:42 AM Database Feature #2080: add runtime support for database methods
I do not understand which line of code generates the 9039 and 12860 messages. Please remove the @SESSION:SUPPRESS-WAR... Constantin Asofiei
02:34 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
This is the fix for the note 178 above, please review.
If some other categories of compiler are found, the constants...
Ovidiu Maxiniuc
12:11 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
om_upd20130325a.zip has passed testing. Please check it in and distribute it. Greg Shah
10:53 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Yes, I agree. Let's implement all of the compiler constants now and do it right. Please create a new function in co... Greg Shah
10:38 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Greg, this is one question for you.
Consider this 4GL code:...
Ovidiu Maxiniuc
08:17 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
This looks good. I will conversion regression test it now. Greg Shah
04:06 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
This is a small signature fix for the following P4GL functions:... Ovidiu Maxiniuc
01:01 PM Database Bug #2095: FIELDS/EXCEPT record phrase options not honored
The current fix doesn't work for all cases, e.g.:
1. REPEAT PRESELECT.
2. DEFINE QUERY.
Note that FIELDS/EXCEP...
Stanislav Lomany
11:42 PM Database Bug #2095 (Review): FIELDS/EXCEPT record phrase options not honored
The update has passed conversion regression testing and I have committed it to bzr rev. 10329. Eric Faulhaber
10:43 PM Database Bug #2095: FIELDS/EXCEPT record phrase options not honored
The update looks good to me. I am running conversion regression testing on it now. Eric Faulhaber
08:00 PM Database Bug #2095: FIELDS/EXCEPT record phrase options not honored
Fixes the cases specified in note #2. Probably fixes all other cases too. Stanislav Lomany
08:40 AM Base Language Feature #1584: add conversion and runtime support for INT64 and DATETIME data types
Ovidiu: your next priority should be completing the runtime work on this task. The first priority is to get the int6... Greg Shah

03/24/2013

05:33 PM Database Bug #2101 (Closed): multi-buffer FOR loop with rowid and to-rowid functions in WHERE clause not c...
I've compared conversions of the customer's server project with and without this fix and it seems correct in all the ... Eric Faulhaber
09:46 PM Database Bug #2101 (Review): multi-buffer FOR loop with rowid and to-rowid functions in WHERE clause not c...
Update ecf_upd20130323a.zip has passed conversion regression testing and is committed to bzr rev. 10325. Eric Faulhaber
08:23 PM Database Bug #2101: multi-buffer FOR loop with rowid and to-rowid functions in WHERE clause not converting...
Although I'm not the assignee, in having to think through the problem for the above post, I took a quick look at the ... Eric Faulhaber
05:27 PM Database Bug #2094: OUTER-JOIN record phrase option not honored
BTW, location of the original problem is pmplan/gapptfn5.p.cache, line 700. Eric Faulhaber
05:25 PM Database Bug #2094 (Review): OUTER-JOIN record phrase option not honored
Passed conversion regression testing, committed to bzr revision 10328. I'll do a separate server folder conversion wi... Constantin Asofiei
05:03 PM Database Bug #2094: OUTER-JOIN record phrase option not honored
Change looks good to me. Please check in and distribute if/when it passes conversion regression testing. Eric Faulhaber
04:04 PM Database Bug #2094 (WIP): OUTER-JOIN record phrase option not honored
Constantin Asofiei
03:47 PM Database Bug #2094: OUTER-JOIN record phrase option not honored
Properly handles the @OUTER-JOIN@ and @LEFT OUTER-JOIN@ to convert the same. Constantin Asofiei
03:37 PM Database Bug #2094: OUTER-JOIN record phrase option not honored
This update adds support for the OUTER-JOIN clause for a record phrase. -The LEFT OUTER-JOIN will not emit anything.-... Constantin Asofiei
10:09 PM Database Bug #2094: OUTER-JOIN record phrase option not honored
The following:... Eric Faulhaber
05:10 PM Database Bug #2097: FOR EACH with multiple, nested CAN-FINDs converts badly
I'm working toward what I think the correct conversion would be:... Eric Faulhaber
04:29 PM Database Feature #2080: add runtime support for database methods
Constantin, I use ErrorManager.recordOrThrowError.
In my example above, 4GL meets errors 9039 and 12860 with differ...
Vadim Nebogatov
07:29 AM Database Feature #2080: add runtime support for database methods
PS: about @SESSION:SUPPRESS-WARNINGS = YES.@. Note that in the 4GL editor, if you run a program which doesn't set the... Constantin Asofiei
07:26 AM Database Feature #2080: add runtime support for database methods
> Another observation. Not all 4GL errors throw “exceptions”, some of them look like not critical errors or warnings,... Constantin Asofiei
07:20 AM Database Feature #2080: add runtime support for database methods
Another observation. Not all 4GL errors throw “exceptions”, some of them look like not critical errors or warnings, e... Vadim Nebogatov
03:53 AM Database Feature #2080: add runtime support for database methods
> Conversion code should also support this option, returning value if ON-ERROR is set (current behaviour) and propaga... Constantin Asofiei
03:51 AM Database Feature #2080: add runtime support for database methods
Constantin: yes, it is just switch in behavior I was looking.
Conversion code should also support this option, retur...
Vadim Nebogatov
03:07 AM Database Feature #2080: add runtime support for database methods
Eric/Vadim: there is another way to supress the 4GL's errors, the @NO-ERROR@ clause. When trying to understand when a... Constantin Asofiei
02:02 AM Database Feature #2080: add runtime support for database methods
Yes, I also think so. Return value has no sense if 4gl propagates its "exceptions". I only thought that maybe this pr... Vadim Nebogatov
09:26 PM Database Feature #2080: add runtime support for database methods
This indicates that the idiom of:... Eric Faulhaber
03:32 PM Conversion Tools Feature #2053 (Closed): create a parameter type lookup facility for built-in functions and handle...
Greg Shah
03:31 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Passed conversion regression testing and is checked int obzr as revision 10327. Runtime regression testing will be r... Greg Shah
12:29 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
And this is the update. Greg Shah
12:29 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
This version clears all the regressions and also fixes note 157. The changes in Majic listed in note 171 are believed... Greg Shah
09:11 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Some unexpected changes were found in regression testing. I suspect these are wrong.... Greg Shah
07:40 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
This case is regressed with GES 0323b (from the server folders):... Constantin Asofiei
08:40 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
This update fixes the regressions in Majic (although there is still 1 change that is expected but will need to be che... Greg Shah
10:11 PM Database Bug #2084 (Closed): Conversion misplaced parameter for can-find statement
Eric Faulhaber
10:10 PM Database Feature #2000 (Closed): add conversion support for table and table handle parameters
Eric Faulhaber
09:49 PM Database Feature #2092 (Closed): add server-side database support for several builtin functions
Eric Faulhaber

03/23/2013

06:54 PM Database Feature #1668: add support for additional (non-dynamic) database attributes
This update has passed conversion regression testing (CA 0323d used deleteRecord for the "quick_delete" loops, instea... Constantin Asofiei
12:58 PM Database Feature #1668: add support for additional (non-dynamic) database attributes
ca_upd20130323d.zip update looks good to me. If it passes conversion regression testing (expect some changes to Maji... Eric Faulhaber
12:52 PM Database Feature #1668: add support for additional (non-dynamic) database attributes
Replaces ca_upd2013023a.zip, and has the changes from note 105. Constantin Asofiei
12:33 PM Database Feature #1668: add support for additional (non-dynamic) database attributes
You are not missing anything, this is the first time I touch embedded sqls, so that's why the questions. Now I have a... Constantin Asofiei
12:30 PM Database Feature #1668: add support for additional (non-dynamic) database attributes
This refers to:... Eric Faulhaber
12:23 PM Database Feature #1668: add support for additional (non-dynamic) database attributes
For embedded SQL, I was referring to this rule in convert/database_access:... Constantin Asofiei
12:19 PM Database Feature #1668: add support for additional (non-dynamic) database attributes
Let's use:... Eric Faulhaber
11:38 AM Database Feature #1668: add support for additional (non-dynamic) database attributes
Eric: the ca_upd20130323a.zip has regressions. I see that the Buffer.delete API is used by other cases, like DELETE s... Constantin Asofiei
10:23 AM Database Feature #1668: add support for additional (non-dynamic) database attributes
This update changes the API for BUFFER-DELETE to deleteRecord, because else will collide with the resource's delete()... Constantin Asofiei
06:53 PM Database Feature #2080: add runtime support for database methods
Also I have noticed the difference in behavior of 4GL and converted code.
I am comparing a lot of tests in the form...
Vadim Nebogatov
06:50 PM Database Bug #2101: multi-buffer FOR loop with rowid and to-rowid functions in WHERE clause not converting...
This issue was first reported in note 192 of #2068.
The following converts badly:...
Eric Faulhaber
06:34 PM Database Bug #2101 (Closed): multi-buffer FOR loop with rowid and to-rowid functions in WHERE clause not c...
Eric Faulhaber
06:40 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
The changes in note 161 did cause some regressions in Majic. I have fixed all but one of them. As soon as that one ... Greg Shah
05:17 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
You are correct, the approach you mentioned from functions.rules matches the not-needed cases too.
> I can't really ...
Constantin Asofiei
05:07 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Part of the issue with note 155 is the over-aggressive setting of ignorecast in annotations/functions.rules:... Greg Shah
04:44 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
The update looks OK, I can't find any obvious flaws in the logic. Constantin Asofiei
04:26 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
About note 157: please see the handle_dyn_func6.p and handle_dyn_func5b.p (the substring issue at note 157 is from he... Constantin Asofiei
04:18 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
The extra ';' might be related to the comments changes. For query-prepare (and dynamic-function as parameter in gener... Constantin Asofiei
04:16 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
In regard to note 155, the same testcase is a bit different after my changes in note 161. Here is the output:
<pr...
Greg Shah
03:04 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Here is the proposed update to resolve notes 135 and 139. This resolves all known cases of these problems.
I will...
Greg Shah
03:18 PM Base Language Bug #2070: BlockManager Action disambiguation
Converting the extent_params_proc.p test on windows fails with this:... Constantin Asofiei
10:04 AM Conversion Tools Bug #2066: brew adds unnecessary comma in method parameter list after comment
ca_upd20130322i.zip was committed to bzr revision 10320. MAJIC conversion regression testing has passed (with comment... Constantin Asofiei

03/22/2013

05:38 PM Database Bug #2095: FIELDS/EXCEPT record phrase options not honored
> I still think the include/exclude call should directly follow the associated addComponent call. I think it is easie... Stanislav Lomany
05:31 PM Database Bug #2095: FIELDS/EXCEPT record phrase options not honored
I guess there's one more option; chain the call, as in:... Eric Faulhaber
05:04 PM Database Bug #2095: FIELDS/EXCEPT record phrase options not honored
So if the full list of options is:
1. Add the list of fields to query c'tor / addComponent
2. include(String ...) -...
Stanislav Lomany
04:34 PM Database Bug #2095: FIELDS/EXCEPT record phrase options not honored
Stanislav Lomany wrote:
> For a multi-table query the buffer should be specified, but as an option we can have quali...
Eric Faulhaber
04:28 PM Database Bug #2095: FIELDS/EXCEPT record phrase options not honored
For a multi-table query the buffer should be specified, but as an option we can have qualified field names:... Stanislav Lomany
03:32 PM Database Bug #2095: FIELDS/EXCEPT record phrase options not honored
OK, but please emit this method immediately after the associated @addComponent@ call.
> ...
Eric Faulhaber
03:07 PM Database Bug #2095: FIELDS/EXCEPT record phrase options not honored
Unless someone has objections, for multi-component queries, I'll make include/exclude methods of the parent query:
<...
Stanislav Lomany
11:42 AM Database Bug #2095: FIELDS/EXCEPT record phrase options not honored
> Removes FIELDS/EXCEPT nodes.
Thanks, I'm starting server folder conversion, hope nothing new will appear.
Constantin Asofiei
11:36 AM Database Bug #2095: FIELDS/EXCEPT record phrase options not honored
Removes FIELDS/EXCEPT nodes. Stanislav Lomany
10:38 AM Database Bug #2095: FIELDS/EXCEPT record phrase options not honored
OK Stanislav Lomany
10:14 AM Database Bug #2095: FIELDS/EXCEPT record phrase options not honored
Stanislav: if it doesn't take you long to build some rules which just drop/hide the FIELDS/EXCEPT nodes (so they will... Constantin Asofiei
04:25 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Ovidiu: please post here all the cases related to LENGTH function which are not converting properly (the cases when t... Constantin Asofiei
02:43 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
OK, I think the case at note 155 here is related to 157. I'll wait for your changes before continuing. Constantin Asofiei
01:39 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
> If think for such cases ECW should return null, if the function's return type and the parameter's type are not comp... Greg Shah
11:24 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
There is a problem in ECW/base_structure. For a case like:... Constantin Asofiei
10:07 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
No, I haven't looked at this case. Greg Shah
09:59 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Greg, have you touched this case:... Constantin Asofiei
09:33 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
ca_upd20130322d.zip committed to bzr revision 10312. Constantin Asofiei
08:20 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
It is good. Check it in and distribute it if it passes testing. Greg Shah
07:23 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
I think I found the problem for the BEGINS operator problem @if h:buffer-value begins ch then message "blah".@. In op... Constantin Asofiei
04:22 PM Conversion Tools Bug #2066: brew adds unnecessary comma in method parameter list after comment
I agree. The approach you have taken is fine for now.
I also agree that we will need to make additional changes t...
Greg Shah
04:09 PM Conversion Tools Bug #2066: brew adds unnecessary comma in method parameter list after comment
This is a quirk for the SWITCH statement comment case. At this time, I think convert/comments.rules might be incomple... Constantin Asofiei
02:32 PM Database Feature #1668: add support for additional (non-dynamic) database attributes
Costin Savin wrote:
> Well theoreticaly it is already there because both Buffer and TempTable extend it, but probabl...
Constantin Asofiei
02:32 PM Database Feature #1668: add support for additional (non-dynamic) database attributes
Well theoreticaly it is already there because both Buffer and TempTable extend it, but probably it's good to see it i... Costin Savin
02:12 PM Database Feature #1668: add support for additional (non-dynamic) database attributes
Costin, regarding cs_upd20130322b.zip - you forgot to add the new interface to HandleCommon. Please put it right afte... Constantin Asofiei
01:43 PM Database Feature #1668: add support for additional (non-dynamic) database attributes
Commited as revision number 10317 Costin Savin
01:07 PM Database Feature #1668: add support for additional (non-dynamic) database attributes
cs_upd20130322b.zip has passed conversion regression testing. Please check it in and distribute. Eric Faulhaber
10:54 AM Database Feature #1668: add support for additional (non-dynamic) database attributes
cs_upd20130322b.zip looks good. I am putting it through conversion regression testing.
It does look like we still...
Eric Faulhaber
08:21 AM Database Feature #1668: add support for additional (non-dynamic) database attributes
Added proposed update for missing addFieldToIndex methods. Moved the defaultBufferHandle() method form the Buffer int... Costin Savin
05:06 AM Database Feature #1668: add support for additional (non-dynamic) database attributes
This class evolved a little. The @defaultBufferHandle()@ (implementation of @DEFAULT-BUFFER-HANDLE@) was at the begin... Ovidiu Maxiniuc
04:35 AM Database Feature #1668: add support for additional (non-dynamic) database attributes
> ADMData was my mistake (should have not added it, as I don't see the ADM-DATA attribute defined for the temp-table ... Constantin Asofiei
02:15 PM Database Feature #2080: add runtime support for database methods
I have noticed from testing in 4GL that error message... Vadim Nebogatov
10:46 AM Database Feature #1947: add conversion support for database methods
CA 0322c.zip was committed to bzr revision 10315 and CA 0322e.zip to 10316. Constantin Asofiei
10:40 AM Database Feature #1947: add conversion support for database methods
Both updates look good, please check them in. Eric Faulhaber
09:30 AM Database Feature #1947: add conversion support for database methods
Both 0322c.zip and 0322e.zip have passed conversion regression testing. Constantin Asofiei
07:42 AM Database Feature #1947: add conversion support for database methods
Adds missing @queryRows(integer)@ API. Constantin Asofiei
06:49 AM Database Feature #1947: add conversion support for database methods
Solved note 151 by always expanding array vars passed to the REPOSITION-TO-ROWID method. This avoids adding an @query... Constantin Asofiei
06:06 AM Database Feature #1947: add conversion support for database methods
I'm working on note 151. Constantin Asofiei
05:23 AM Database Feature #1947: add conversion support for database methods
See note 202 from #2068, which documents a server failure. Note that the @REPOSITION-TO-ROWID@ can accept mixed exten... Constantin Asofiei
10:24 AM Database Feature #2000: add conversion support for table and table handle parameters
ca_upd20130322g.zip committed to bzr revision 10214. Constantin Asofiei
09:15 AM Database Feature #2000: add conversion support for table and table handle parameters
The code looks fine. If it passes testing, check it in and distribute it. Greg Shah
09:11 AM Database Feature #2000: add conversion support for table and table handle parameters
Fixes a regression in the TABLE-HANDLE parameter conversion, introduced by 10293. Constantin Asofiei
08:55 AM Database Feature #2000: add conversion support for table and table handle parameters
OK, I'll look at it. Constantin Asofiei
08:15 AM Database Feature #2000: add conversion support for table and table handle parameters
It has been regressed since revision 10279.
Correct output is:...
Stanislav Lomany
07:38 AM Database Feature #2000: add conversion support for table and table handle parameters
Stanislav: did this convert properly after you added TABLE-HANDLE parameter support?... Constantin Asofiei
09:37 AM Base Language Feature #1920: implement persistent procedures
Merged with latest bzr version, contains both CA 0322a.zip and CA 0322f.zip changes. committed to bzr revision 10313. Constantin Asofiei
08:24 AM Base Language Feature #1920: implement persistent procedures
The code is OK. It can be committed and distributed when it passes testing. Greg Shah
07:54 AM Base Language Feature #1920: implement persistent procedures
Fixes the case when a method param has subscript:... Constantin Asofiei
06:04 AM Base Language Feature #1920: implement persistent procedures
The code is OK. If it passes conversion testing you can check it in and distribute it. Greg Shah
05:31 AM Base Language Feature #1920: implement persistent procedures
Fixed conversion support for HANDLE attribute, when used with system handles:... Constantin Asofiei
08:18 AM Database Feature #2092: add server-side database support for several builtin functions
Go ahead and check this in immediately (and distribute it). It has no effect on conversion and it is already being r... Greg Shah
07:07 AM Database Feature #2092: add server-side database support for several builtin functions
Removed the extra ' character from p2jpl.ddr at line 699 Costin Savin
06:59 AM Base Language Feature #1608: implement full appserver support (from 4GL clients only)
Checked in to bzr as revision 10310. Costin Savin
05:26 AM Base Language Feature #1608: implement full appserver support (from 4GL clients only)
Conversion testing passed. Check it in and distribute it. Greg Shah

03/21/2013

04:10 PM Base Language Feature #1608: implement full appserver support (from 4GL clients only)
Added merged update Costin Savin
01:51 PM Base Language Feature #1608: implement full appserver support (from 4GL clients only)
Code Feedback:
1. The javadoc and formatting of ConnectableServer should be this:...
Greg Shah
01:13 PM Base Language Feature #1608: implement full appserver support (from 4GL clients only)
Added proposed update which fixes connect for AppServer Costin Savin
10:37 AM Base Language Feature #1608: implement full appserver support (from 4GL clients only)
You can force things to be wrapped in that case where there is more than 1 parameter. Greg Shah
10:27 AM Base Language Feature #1608: implement full appserver support (from 4GL clients only)
> [javac] .../server/common/Apitest1.java:134: error: no suitable method found for connect(String,character,character... Costin Savin
03:54 PM Database Feature #1668: add support for additional (non-dynamic) database attributes
From the TEMP-TABLE attributes the following are not implemented in any interface:
AFTER-TABLE, BEFORE-TABLE, DATA...
Costin Savin
01:54 PM Database Feature #1668: add support for additional (non-dynamic) database attributes
Eric/Costin: there is one more thing we should do - identify all attributes which are already defined by interfaces (... Constantin Asofiei
01:49 PM Database Feature #1668: add support for additional (non-dynamic) database attributes
> So, Costin: please remove Buffer and ADMData from the TempTable interface and post here what method stubs are still... Costin Savin
01:42 PM Database Feature #1668: add support for additional (non-dynamic) database attributes
So, Costin: please remove Buffer and ADMData from the TempTable interface and post here what method stubs are still ... Eric Faulhaber
01:39 PM Database Feature #1668: add support for additional (non-dynamic) database attributes
Constantin Asofiei wrote:
> Why is TempTable interface extending Buffer, ADMData and UniqueID interfaces?
Good qu...
Eric Faulhaber
01:38 PM Database Feature #1668: add support for additional (non-dynamic) database attributes
ADMData was my mistake (should have not added it, as I don't see the ADM-DATA attribute defined for the temp-table re... Constantin Asofiei
01:31 PM Database Feature #1668: add support for additional (non-dynamic) database attributes
Eric/Ovidiu/Costin: the interfaces extended by TempTable don't look OK. In the docs, the temp-table resource can acce... Constantin Asofiei
01:30 PM Database Feature #1668: add support for additional (non-dynamic) database attributes
Costin Savin wrote:
> > That's strange, all the TempTable methods should be implemented in TempTableBuilder, AFAIK. ...
Eric Faulhaber
01:25 PM Database Feature #1668: add support for additional (non-dynamic) database attributes
> That's strange, all the TempTable methods should be implemented in TempTableBuilder, AFAIK. I don't know why they a... Costin Savin
12:55 PM Database Feature #1668: add support for additional (non-dynamic) database attributes
Vadim, your 20130321a update has passed conversion regression testing. Please check it in (and the test case) and di... Eric Faulhaber
11:50 AM Database Feature #1668: add support for additional (non-dynamic) database attributes
Ovidiu Maxiniuc wrote:
> > That's strange, all the TempTable methods should be implemented in TempTableBuilder, AFAI...
Eric Faulhaber
11:36 AM Database Feature #1668: add support for additional (non-dynamic) database attributes
Code review 20130321a:
Looks good, I'm putting it through conversion regression test now.
Eric Faulhaber
10:59 AM Database Feature #1668: add support for additional (non-dynamic) database attributes
Update vmn_upd20130321a.zip (vmn_upd20130321b.zip - conversion test) is replacement of vmn_upd20130320a.zip (vmn_upd2... Vadim Nebogatov
09:17 AM Database Feature #1668: add support for additional (non-dynamic) database attributes
> That's strange, all the TempTable methods should be implemented in TempTableBuilder, AFAIK. I don't know why they ... Ovidiu Maxiniuc
06:55 AM Database Feature #1668: add support for additional (non-dynamic) database attributes
> Please post your test case.
I used the pers-addr table from p2j_test and created a temp table like pers-addr and...
Costin Savin
02:20 PM Database Bug #2095: FIELDS/EXCEPT record phrase options not honored
Stanislav Lomany wrote:
> Do I need to ensure that there are no duplicates in the converted list (e.g. if we are con...
Eric Faulhaber
02:01 PM Database Bug #2095: FIELDS/EXCEPT record phrase options not honored
It is possible to reference an element of an extent field. The progress documentation says that "If field is an array... Stanislav Lomany
11:21 AM Database Bug #2095 (WIP): FIELDS/EXCEPT record phrase options not honored
Stanislav Lomany
01:32 PM Base Language Bug #2099 (Closed): "ASSIGN widget." statement does not convert properly in some cases
Greg Shah
12:53 PM Base Language Bug #2099 (Review): "ASSIGN widget." statement does not convert properly in some cases
> Check it in and distribute it.
Committed to bzr revision 10308.
Constantin Asofiei
12:46 PM Base Language Bug #2099: "ASSIGN widget." statement does not convert properly in some cases
This looks good. Check it in and distribute it. Greg Shah
11:41 AM Base Language Bug #2099: "ASSIGN widget." statement does not convert properly in some cases
This update has passed conversion regression testing. There are some changes in MAJIC, but they do not affect runtime... Constantin Asofiei
09:45 AM Base Language Bug #2099: "ASSIGN widget." statement does not convert properly in some cases
I'm still missing something, lots of invalid changes in MAJIC. Constantin Asofiei
08:58 AM Base Language Bug #2099: "ASSIGN widget." statement does not convert properly in some cases
This is a fix attempt for this issue. Looks like the solution was to explicitly set the frame name, in case the "fram... Constantin Asofiei
01:30 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
While working on #2068 note 187, I encountered the following case:... Ovidiu Maxiniuc
09:48 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Here is the final version of the indeterminate cases. I have done 2 equivalent versions: one using buffer-value and ... Greg Shah
11:23 AM Base Language Feature #2089 (Closed): INPUT function returning string value
Greg Shah
10:37 AM Base Language Feature #2089: INPUT function returning string value
Please do check in and distribute the change. Greg Shah
10:14 AM Base Language Feature #2089: INPUT function returning string value
Yes, they all are OK. Stanislav Lomany
09:51 AM Base Language Feature #2089: INPUT function returning string value
Here are the results of the conversion testing:... Greg Shah
08:12 AM Base Language Feature #2089: INPUT function returning string value
Code Review:
It looks good. 1 minor issue: the comment was corrupted in "handle_implicit_input" in the latest com...
Greg Shah
09:51 AM Database Feature #2000 (Review): add conversion support for table and table handle parameters
Stanislav Lomany

03/20/2013

06:55 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
OK, this testcase is close to being done. It shows the really insane variety of possibilities with the truly dynamic... Greg Shah
06:05 PM Database Feature #1668: add support for additional (non-dynamic) database attributes
Code review 20130320a:
All looks good except QueryWrapper: the new @numBuffers@ method implementation should dele...
Eric Faulhaber
05:38 PM Database Feature #1668: add support for additional (non-dynamic) database attributes
Update vmn_upd20130320a.zip (vmn_upd20130320b.zip - conversion test) contains correction of NUM-BUFFERS()(KW_NUM_BUFF... Vadim Nebogatov
02:07 PM Database Feature #1668: add support for additional (non-dynamic) database attributes
Costin Savin wrote:
> Tested this case, The result is a runtime error message: @"Third argument to ADD-INDEX-FIELD m...
Eric Faulhaber
02:05 PM Database Feature #1668: add support for additional (non-dynamic) database attributes
> Write a test case and see what happens if you pass in something other than "asc" or "desc" as the last parameter. D... Costin Savin
01:07 PM Database Feature #1668: add support for additional (non-dynamic) database attributes
Costin Savin wrote:
> there are only these methods defined in the TempTable interface:
> public logical addFieldTo...
Eric Faulhaber
12:37 PM Database Feature #1668: add support for additional (non-dynamic) database attributes
For:... Costin Savin
05:54 PM Base Language Feature #1641: implement SAX XML support
The update evl_upd20130320b.zip has been committed in bzr as 10303. Eugenie Lyzenko
05:46 PM Base Language Feature #1641: implement SAX XML support
> If it passes testing you can check it in and distribute it.
Conversion testing has been passed. I'm going to com...
Eugenie Lyzenko
04:40 PM Base Language Feature #1641: implement SAX XML support
If it passes testing you can check it in and distribute it. Greg Shah
03:11 PM Base Language Feature #1641: implement SAX XML support
This update merged with bzr 10302. Starting the conversion testing. Eugenie Lyzenko
02:46 PM Base Language Feature #1641: implement SAX XML support
Code feedback: everything looks good.
The only issue is that you need to merge with the recent bzr revision. Ple...
Greg Shah
02:36 PM Base Language Feature #1641: implement SAX XML support
The update includes:
1. Changing for constant types.
2. Adding history entries.
3. Fixes for misspelled words in S...
Eugenie Lyzenko
02:38 PM Database Feature #2092: add server-side database support for several builtin functions
Update cs_upd20130320a1.zip has passed conversion regression testing and is committed to bzr rev. 10301. Eric Faulhaber
01:29 PM Database Feature #2092: add server-side database support for several builtin functions
Code review 20130320a:
This one is mostly correct, except for the following:
* @Functions.minimum(Date var1, Date...
Eric Faulhaber
11:55 AM Database Feature #2092: add server-side database support for several builtin functions
Added proposed update, for the testcase it seems you can't define a field as rowid in 4gl so I modified that part.
W...
Costin Savin
05:35 AM Database Feature #2092: add server-side database support for several builtin functions
Costin: the test you've uploaded doesn't work with the repository p2j_test.df schema definition. When modifying the p... Constantin Asofiei
02:16 PM Base Language Feature #2089: INPUT function returning string value
Yes, please do. Greg Shah
02:13 PM Base Language Feature #2089: INPUT function returning string value
> When we search upward for KW_VALIDATE and enable implicit input testing, we must ensure that we are a descendant of... Stanislav Lomany
02:00 PM Base Language Feature #2089: INPUT function returning string value
When we search upward for KW_VALIDATE and enable implicit input testing, we must ensure that we are a descendant of t... Greg Shah
01:49 PM Base Language Feature #2089: INPUT function returning string value
Note that... Stanislav Lomany
12:26 PM Base Language Bug #2099: "ASSIGN widget." statement does not convert properly in some cases
This case was exposed by server folder compilation, in #2068 note 172:... Constantin Asofiei
12:08 PM Base Language Bug #2099 (Closed): "ASSIGN widget." statement does not convert properly in some cases
Constantin Asofiei

03/19/2013

07:46 PM Base Language Feature #2089: INPUT function returning string value
1 compile problem in Majic:... Greg Shah
03:13 PM Base Language Feature #2089: INPUT function returning string value
The code looks good. I will put it into conversion testing here since it will be faster. Greg Shah
02:58 PM Base Language Feature #2089: INPUT function returning string value
Not yet regression-tested. Stanislav Lomany
09:42 AM Base Language Feature #2089: INPUT function returning string value
> Stanislav: when will the update be ready?
I'm writing javadocs / merging it.
Stanislav Lomany
09:17 AM Base Language Feature #2089: INPUT function returning string value
Actually, this should be pretty much done at this point. Let's finish it now.
Stanislav: when will the update be ...
Greg Shah
07:51 AM Base Language Feature #2089: INPUT function returning string value
Greg/Stanislav: we can make this a low priority, as after the latest schema VALEXP changes in #1620, the problematic ... Constantin Asofiei
04:29 PM Database Feature #2092: add server-side database support for several builtin functions
Code review 20130319a:
* common-progress.rules: changes look good, but see comment below about max/min.
* where-...
Eric Faulhaber
02:29 PM Database Feature #2092: add server-side database support for several builtin functions
Re-arranged the code , solved the reviewed problems and merged with latest updates.
Testcase used to check convers...
Costin Savin
01:29 AM Database Feature #2092: add server-side database support for several builtin functions
Costin Savin wrote:
> Added merged update.
> Are there any other functions that need to be added? I saw DATETIME an...
Eric Faulhaber
01:11 PM Database Feature #1668: add support for additional (non-dynamic) database attributes
Constantin Asofiei wrote:
> For this, I think we should add a @P2JQuery.tableCount@ API which returns @integer@ and ...
Eric Faulhaber
07:30 AM Database Feature #1668: add support for additional (non-dynamic) database attributes
Eric,
> * num-buffers [KW_NUM_BUFF] (seems buggy) (I think this should map to P2JQuery.getTableCount, which already ...
Constantin Asofiei
11:41 AM Base Language Feature #1641: implement SAX XML support
> AFAIK any field declared in an interface is by default "static final" (the compiler takes care to put these modifie... Greg Shah
11:08 AM Base Language Feature #1641: implement SAX XML support
> 1. Please make the constants all @public final static@ instead of just @public@ (which is editable, something we do... Constantin Asofiei
09:45 AM Base Language Feature #1641: implement SAX XML support
Code Feedback (Eugenie: you can make the final changes to the code Constantin posted):
1. Please make the constant...
Greg Shah
08:18 AM Base Language Feature #1641: implement SAX XML support
Eugenie: attached you have the runtime support for this; please go ahead with the conversion support.
Greg: the co...
Constantin Asofiei
08:13 AM Base Language Feature #1641: implement SAX XML support
Eugenie, please implement the following:
These constants are recognized by the parser but we do not emit them as l...
Greg Shah
07:57 AM Database Bug #2093: VALEXP support in P2J
The AST is slightly different with last revision from bzr:... Ovidiu Maxiniuc
07:20 AM Database Bug #2093: VALEXP support in P2J
Please check the failed case in the previous note with the latest #1620 fix, if you haven't done already so. Constantin Asofiei
07:09 AM Database Bug #2093: VALEXP support in P2J
Everything seems to work smooth, validation is only generated in @schema-validation@:... Ovidiu Maxiniuc
04:03 AM Database Bug #2093: VALEXP support in P2J
Ovidiu: with the #1620 changes, I can't see any more schema VALEXP problems in the logs (I think P2J was too aggressi... Constantin Asofiei
07:03 AM Base Language Feature #1620: implement EXTENT parameter support
Attached merged update, committed to bzr revision 10298. Constantin Asofiei
07:02 AM Base Language Feature #1620: implement EXTENT parameter support
> If it passes conversion testing AND if you deem the Majic changes to be correct, then go ahead and check in/distrib... Constantin Asofiei
04:22 AM Conversion Tools Bug #2066: brew adds unnecessary comma in method parameter list after comment
wrong task Constantin Asofiei
04:12 AM Conversion Tools Bug #2066: brew adds unnecessary comma in method parameter list after comment
wrong task Constantin Asofiei
04:06 AM Conversion Tools Bug #2066: brew adds unnecessary comma in method parameter list after comment
wrong task Constantin Asofiei

03/18/2013

06:49 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
My changes do not work properly. Interestingly, even Majic has some pretty crazy combinations like this:
def var ...
Greg Shah
05:35 PM Base Language Feature #2089: INPUT function returning string value
Understood. Greg Shah
05:27 PM Base Language Feature #2089: INPUT function returning string value
> Also: this fuzzy matching may have bad side effects on other places we use expressionType(). For this reason, I th... Stanislav Lomany
03:36 PM Base Language Feature #2089: INPUT function returning string value
Yes, that is my point. getSignature(int, int, String[]) should be modified to return the default as the first one de... Greg Shah
03:13 PM Base Language Feature #2089: INPUT function returning string value
> In regard to your idea about a default signature, I am OK with that approach. How about this: if the signature mat... Stanislav Lomany
03:07 PM Base Language Feature #2089: INPUT function returning string value
Greg Shah wrote:
> OK, you have to some some additional things here.
>
> 1. Before you set the implicit_input, yo...
Stanislav Lomany
02:59 PM Base Language Feature #2089: INPUT function returning string value
OK, you have to some some additional things here.
1. Before you set the implicit_input, you must first know the de...
Greg Shah
02:14 PM Base Language Feature #2089: INPUT function returning string value
> Please post the code you are using to implement the implicit_input analysis.... Stanislav Lomany
01:50 PM Base Language Feature #2089: INPUT function returning string value
In regard to your idea about a default signature, I am OK with that approach. How about this: if the signature match... Greg Shah
01:34 PM Base Language Feature #2089: INPUT function returning string value
Please post the code you are using to implement the implicit_input analysis. Greg Shah
01:16 PM Base Language Feature #2089: INPUT function returning string value
> What is the problem with the use of ParmType.BDT (BaseDataType) as the 1st parameter (the way it was originally cod... Stanislav Lomany
12:19 PM Base Language Feature #2089: INPUT function returning string value
What is the problem with the use of ParmType.BDT (BaseDataType) as the 1st parameter (the way it was originally coded)? Greg Shah
11:25 AM Base Language Feature #2089: INPUT function returning string value
Signature of the @LENGTH@ function stored into @SignatureHelper.map_func@ map is @{ ParmType.BDT, ParmType.CHAR }@. A... Stanislav Lomany
04:28 PM Conversion Tools Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...
The evl_upd20130318a.zip has been committed in bzr as 10296. As I note before it passed the conversion testing. Eugenie Lyzenko
04:08 PM Conversion Tools Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...
Check it in and distribute it. Greg Shah
02:11 PM Conversion Tools Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...
The update 20130318a has passed the conversion testing, compared directories are /ddl and /src/aero/timco/majic. Eugenie Lyzenko
12:13 PM Conversion Tools Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...
The new update with scoping support has been added for review. The case when we has separate handling for button, rec... Eugenie Lyzenko
11:40 AM Conversion Tools Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...
Yes, frames are scoped too. Greg Shah
10:26 AM Conversion Tools Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...
I'm testing the implemented approach with dictionary usage. And I have a question. Do we need the same code to be imp... Eugenie Lyzenko
03:39 PM Database Feature #2080: add runtime support for database methods
Update vmn_upd20130318a.zip (vmn_upd20130318b.zip - tests) contains runtime support for BUFFER-COMPARE and some prepa... Vadim Nebogatov
12:30 PM Base Language Feature #1620: implement EXTENT parameter support
This makes sense. I should have read the surrounding code more carefully and I would have seen this.
If it passes...
Greg Shah
11:58 AM Base Language Feature #1620: implement EXTENT parameter support
> My only question is this: the schema_validation.rules includes support for the INSERT statement, but then the FORMA... Constantin Asofiei
11:52 AM Base Language Feature #1620: implement EXTENT parameter support
Code Review:
My only question is this: the schema_validation.rules includes support for the INSERT statement, but ...
Greg Shah
10:42 AM Base Language Feature #1620: implement EXTENT parameter support
New version of the update in which:
# the NO-VALIDATE clause with a frame must affect only the schema validation exp...
Constantin Asofiei
11:36 AM Database Bug #2097: FOR EACH with multiple, nested CAN-FINDs converts badly
This issue stems from note 127 in #2068.
The following code:...
Eric Faulhaber
11:16 AM Database Bug #2097 (Closed): FOR EACH with multiple, nested CAN-FINDs converts badly
Eric Faulhaber
08:23 AM Database Feature #2092: add server-side database support for several builtin functions
Added merged update.
Are there any other functions that need to be added? I saw DATETIME and DATETIME-TZ which fit t...
Costin Savin
06:34 AM Database Feature #2092: add server-side database support for several builtin functions
After some tests it seems that min and max can be applied also to character and date variables, not only numeric valu... Costin Savin
04:31 AM Database Feature #2092 (Review): add server-side database support for several builtin functions
Costin Savin
04:31 AM Database Feature #2092 (WIP): add server-side database support for several builtin functions
Costin Savin
12:12 AM Database Bug #2059 (Closed): CAN-FIND clause for a perm table in the RECORD_PHRASE of a temp table, with a...
Eric Faulhaber

03/17/2013

06:11 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
This set of changes resolves the problems in note 135 (literals.rules, ECW) and 139 (common-progress.rules). I also ... Greg Shah
04:07 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Update for note 142 is at #2068, note 133 Constantin Asofiei
04:34 PM Base Language Feature #1620: implement EXTENT parameter support
I'm OK with the changes. If all of the Majic modifications appear to be correct, we will go ahead with runtime testin... Greg Shah
11:16 AM Base Language Feature #1620: implement EXTENT parameter support
There are lots of changes in MAJIC converted code, here are some examples:
# for extent fields, all elements get the...
Constantin Asofiei
10:03 AM Base Language Feature #1620: implement EXTENT parameter support
Renamed test file. Constantin Asofiei
10:01 AM Base Language Feature #1620: implement EXTENT parameter support
When fixing conversion of schema validation expressions for extent fields, it hit me that the P2J approach using SCHE... Constantin Asofiei
03:42 PM Database Bug #2077 (Closed): fix converted table and field name collisions
Eric Faulhaber
03:32 PM Database Bug #2084 (Review): Conversion misplaced parameter for can-find statement
Eric Faulhaber
03:31 PM Database Bug #2084: Conversion misplaced parameter for can-find statement
The net effect of the cs_upd20130314a.zip update is that the correct Java output is produced, but the change still le... Eric Faulhaber
 

Also available in: Atom