Project

General

Profile

Activity

From 02/15/2013 to 03/16/2013

03/16/2013

04:40 PM Conversion Tools Bug #2066: brew adds unnecessary comma in method parameter list after comment
There is a problem when the comment is emitted after the peer:... Constantin Asofiei
02:06 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
16a.zip was committed to bzr revision 10292. Constantin Asofiei
02:00 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Looks good. Check it in and distribute it. Greg Shah
01:40 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
This update changes the ECW (by moving the ATTR_HANDLE test out of the simpleExpressionType) and the javadocs (I touc... Constantin Asofiei
01:20 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
I had the impression that this was fixed:... Constantin Asofiei
10:31 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
I will take notes 135 and 139. Greg Shah
10:25 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Code Review (for all of the updates including 15c):
I am generally fine with the changes. There are some formatti...
Greg Shah
11:40 AM Conversion Tools Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...
This is the reason we use the dictionary. The example in note 33 has 2 scopes. It will result in a parameter for th... Greg Shah
10:24 AM Database Feature #2092: add server-side database support for several builtin functions
Added proposed update,
For ROWID I didn't knew how a ROWID data type it's represented in the database so I assumed ...
Costin Savin

03/15/2013

05:57 PM Conversion Tools Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...
... Eugenie Lyzenko
05:07 PM Conversion Tools Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...
Ok, I just lost a comment due to "redmine wants me to login again" so here is the short part. Your approach is too ag... Constantin Asofiei
04:04 PM Conversion Tools Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...
> What troubles you? The fact that the procedure's parameter gets promoted and collides with another proc's parameter... Eugenie Lyzenko
11:25 AM Conversion Tools Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...
> The question is do we need to ignore 4GL case sensitivity?
Please test your case in 4GL environment, and you will...
Constantin Asofiei
11:19 AM Conversion Tools Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...
The remaining conversion issue with recent changes is related to the name case sensitivity issue. Consider the follow... Eugenie Lyzenko
05:13 PM Database Feature #2080: add runtime support for database methods
Constantin's advice has gotten you past the immediate handle problem, but please re-read note 9. The runtime impleme... Eric Faulhaber
05:11 PM Database Feature #2080: add runtime support for database methods
Yes, it works, thank you Vadim Nebogatov
04:53 PM Database Feature #2080: add runtime support for database methods
Vadim, I don't think the runtime for the CREATE BUFFER statement is implemented. Try this instead:... Constantin Asofiei
04:41 PM Database Feature #2080: add runtime support for database methods
It seems, ... Vadim Nebogatov
12:09 PM Database Feature #2080: add runtime support for database methods
update [vmn_upd20130314a.zip]
Refs #2080, checked in as bzr revision 10291.
Corrected runtime for BUFFER-COPY (KW_B...
Vadim Nebogatov
11:52 AM Database Feature #2080: add runtime support for database methods
> Constantin: can you just pick up common-progress.rules from bzr and merge your quoter changes in?
OK, I'll wait f...
Constantin Asofiei
11:49 AM Database Feature #2080: add runtime support for database methods
Vadim: the 20130314a update looks good. Please go ahead and commit it to bzr.
Constantin: can you just pick up ...
Eric Faulhaber
11:39 AM Database Feature #2080: add runtime support for database methods
Constantin Asofiei wrote:
> Vadim, have you done the changes at notes #29? If yes, please upload just the common-pro...
Vadim Nebogatov
11:37 AM Database Feature #2080: add runtime support for database methods
Vadim, have you done the changes at notes #29? If yes, please upload just the common-progress.rules file. If not, I c... Constantin Asofiei
11:08 AM Database Feature #2080: add runtime support for database methods
Yes, the pairs parameter is in use. Eric Faulhaber
11:00 AM Database Feature #2080: add runtime support for database methods
What about pairs in RecordBuffer.compare()? Should it be supported? Vadim Nebogatov
10:39 AM Database Feature #2080: add runtime support for database methods
Vadim Nebogatov wrote:
> I am implementing now RecordBuffer.compare(Buffer buffer, character mode, character except,...
Eric Faulhaber
08:46 AM Database Feature #2080: add runtime support for database methods
I am implementing now RecordBuffer.compare(Buffer buffer, character mode, character except, character pairs) similar... Vadim Nebogatov
03:58 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Another case which does not convert properly:... Constantin Asofiei
03:38 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Another update, built on top of 15b:
# fix a NPE during conversion
# fix the MINIMUM/MAXIMUM functions, when used w...
Constantin Asofiei
12:25 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Attached update is on top of 15a.zip and adds:
# field assignment, when the field is date/datetime/datetimetz, to al...
Constantin Asofiei
11:59 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Another case of character c'tor derail:... Constantin Asofiei
10:54 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Another weird issue which needs to be handled by the ECW. Following code is valid 4GL:... Constantin Asofiei
10:24 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
This update fixes:
# HANDLE attribute passed to method/function calls as a parameter (needs to be wrapped in a handl...
Constantin Asofiei
02:40 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
> Also, please do check in your 14b fix if/when it is OK.
Committed to bzr revision 10290, as the server folders conv...
Constantin Asofiei
08:13 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
I've been looking at the chaining problem. We have a model that is already pretty close. The OO features provide ch... Greg Shah
01:27 PM Database Bug #2095: FIELDS/EXCEPT record phrase options not honored
BTW, since multi-table queries also implement P2JQuery indirectly, they should throw UnsupportedOperationException fo... Eric Faulhaber
01:20 PM Database Bug #2095: FIELDS/EXCEPT record phrase options not honored
The runtime API will look like:... Eric Faulhaber
12:41 PM Database Bug #2095: FIELDS/EXCEPT record phrase options not honored
The use cases we must support:... Eric Faulhaber
12:16 PM Database Bug #2095: FIELDS/EXCEPT record phrase options not honored
Paraphrased from #2068:
Looks like P2J doesn't like the FIELDS clause, because with it, the fields get emitted as ...
Eric Faulhaber
12:12 PM Database Bug #2095 (Closed): FIELDS/EXCEPT record phrase options not honored
Eric Faulhaber
12:30 PM Database Bug #2084: Conversion misplaced parameter for can-find statement
Eric: I've put this through conversion regression testing (which has passed) plus server folder conversion, and I don... Constantin Asofiei
12:11 PM Database Bug #2094 (Closed): OUTER-JOIN record phrase option not honored
Eric Faulhaber
12:06 PM Database Bug #2093: VALEXP support in P2J
This issue is dedicated to note 80 from Issue #2068.
> There is this validation expression for the @dvofrsts.dvofr...
Ovidiu Maxiniuc
11:57 AM Database Bug #2093 (Closed): VALEXP support in P2J
Ovidiu Maxiniuc
02:06 AM Database Feature #2092: add server-side database support for several builtin functions
The following builtin functions are used within where clauses in queries and thus need to be supported as database se... Eric Faulhaber
01:14 AM Database Feature #2092 (Closed): add server-side database support for several builtin functions
Eric Faulhaber

03/14/2013

05:44 PM Database Feature #2080: add runtime support for database methods
What methods are priority for now? Vadim Nebogatov
05:43 PM Database Feature #2080: add runtime support for database methods
Attached update vmn_upd20130314a.zip (vmn_upd20130314b.zip - tests).
This update is replacement vmn_upd20130312a.z...
Vadim Nebogatov
03:12 PM Database Feature #2080: add runtime support for database methods
for note 22:
> Constantin: you didn't already do this, right?
No, I have not changed the @Buffer.findXXXX@ APIs
for ...
Constantin Asofiei
05:07 PM Base Language Feature #2089: INPUT function returning string value
... Greg Shah
09:55 PM Base Language Feature #2089: INPUT function returning string value
I have an update posted in #2053. It is in testing, but hopefully you can use it to test your changes. Greg Shah
04:55 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Greg Shah wrote:
> In regard to note 116, I wonder where the extra wrapping is coming from. The h:label case is an A...
Constantin Asofiei
04:39 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
OK. Test your change and check it in if it is OK.
The parser is the best solution for this case. Yes, COLON (and...
Greg Shah
04:31 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Greg Shah wrote:
> 14a causes the issue. I don't have the 14b applied. The testcase is checked in as well.
With 1...
Constantin Asofiei
04:19 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
14a causes the issue. I don't have the 14b applied. The testcase is checked in as well.
But if we are going to f...
Greg Shah
04:14 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Do you mean 14a or 14b? The taks is #1920. Constantin Asofiei
04:13 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Your recent update also causes this issue:... Greg Shah
04:12 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
PS: sorry, the JAST is the wrong one, I'll update the previous note shortly. Constantin Asofiei
04:10 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
The JAST at the time of the move_params is called, for the @h:buffer-field(ch):buffer-value@ part of the note 120's t... Constantin Asofiei
04:03 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
I don't see a problem with this, but honestly, I don't really fully understand the code in move_params. If it works,... Greg Shah
03:59 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
This update fixes case at note 120. I'm putting this back into conversion regression testing and into server folder c... Constantin Asofiei
03:57 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
In regard to note 116, I wonder where the extra wrapping is coming from. The h:label case is an ATTR_CHAR so there i... Greg Shah
03:48 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Urgh... I should have waited 5 more minutes. My ca_upd20130314a.zip update regresses this test, during conversion (LE... Constantin Asofiei
03:40 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
> In regard to your update in note 115, check it in and distribute it.
Committed to bzr revision 10288.
Constantin Asofiei
03:36 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
The problem is that it wraps all parameters passed to the @concat@ API call, as in concat(new character(*"<", handle.... Constantin Asofiei
03:34 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
In regard to your update in note 115, check it in and distribute it.
In regard to note 116, I don't see where the ...
Greg Shah
03:23 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Greg,
I've started per-folder conversion of the server project and I got this regression:...
Constantin Asofiei
03:14 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
The attached update has passed conversion regression testing. Constantin Asofiei
02:11 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
None at all. To make it generate instance method calls, only a few changes are needed in methods_attributes.rules (to... Constantin Asofiei
01:52 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Remind me again: how much of the inversion problem is due to the fact that we use statics in handle for unwrapping in... Greg Shah
01:51 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
The ges_upd20130314d.zip passed conversion testing and checked in as bzr revision 10287. Greg Shah
01:49 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
With this in mind, note 93 looks like an effect of what we've discussed in the last 3 notes. I'll put the fix at note... Constantin Asofiei
01:46 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
> And AFAIK createPeerAst sets the peerid for the current processed node (the this node), right?
Yes.
> I think...
Greg Shah
01:44 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Hmm... I see now what you mean. Note that in methods_attributes.rules, when we convert a METH_ node, the @this@ in th... Constantin Asofiei
01:33 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
The peerid that is added at the STRING node is done after any wrapping would have to take place. I am more concerned... Greg Shah
01:24 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
LE: I see the problem, is related to the fact that when move_params is called by methods_attributes.rules in the seco... Constantin Asofiei
01:08 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
About note 93. See these two ASTs:... Constantin Asofiei
12:56 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
This version fixes both the regression in Majic (hopefully in all cases) as well as the super(?, ?, ?) case. It reso... Greg Shah
11:55 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
> > 2. in expressions.rules:308 - I'm not sure why you are thinking to remove the WHEN. Can you share the case you ha... Constantin Asofiei
11:44 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Good feedback.
> 2. in expressions.rules:308 - I'm not sure why you are thinking to remove the WHEN. Can you share...
Greg Shah
11:05 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Review results:
1. This comment in base_structure.xml:379...
Constantin Asofiei
11:03 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
> Unless I read the diff wrong, the new way is the way of eliminating the getScreenValue and using the widget getter.... Greg Shah
11:00 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
> 1. The new way is more correct?
> 2. The old way may be working (or may not) depending on the format of the var?...
Constantin Asofiei
10:53 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Questions:
1. The new way is more correct?
2. The old way may be working (or may not) depending on the format o...
Greg Shah
10:44 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
> 2. Detection of incompatible types in the comparison operators (which take BDT). A standalone testcase:
> def va...
Constantin Asofiei
10:22 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Here is the final version, with some fixes necessary to convert Majic. Please see #2091 for a Majic change that must... Greg Shah
10:01 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
> Constantin: would you please do a code review of this update?
I'm looking at it now.
Constantin Asofiei
07:57 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
I have fixed some issues (found in my manual testing) with the update.
The conversion testing didn't ever complete...
Greg Shah
09:54 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
This update (hopefully) resolves everything left on this task except for the issue mentioned in note 93. Here is a s... Greg Shah
04:38 PM Conversion Tools Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...
OK. I'll investigate the ScopedSymbolDictionary keeping approach. The next drop implements the Map usage and some min... Eugenie Lyzenko
03:52 PM Conversion Tools Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...
> The conversion test is the comparison for MAJIC converted result before and after update. Is it correct?
Yes.
...
Greg Shah
03:08 PM Conversion Tools Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...
> There are many diffs in Majic. Please review the following and determine if these are correct or not.
I think be...
Eugenie Lyzenko
12:41 PM Conversion Tools Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...
There are many diffs in Majic. Please review the following and determine if these are correct or not. Greg Shah
10:49 AM Conversion Tools Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...
> Do you want me to conversion test this on devsrv01?
Yes, please run this on devsrv01.
Eugenie Lyzenko
10:36 AM Conversion Tools Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...
Do you want me to conversion test this on devsrv01? It is much faster than lightning and will not impact the conversi... Greg Shah
10:31 AM Conversion Tools Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...
> 1. In both files, please start with namesfx = 2. I think this is more natural for the 2nd instance of that var.
...
Eugenie Lyzenko
08:22 AM Conversion Tools Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...
Code Review:
Overall, it is very good. Some minor things:
1. In both files, please start with namesfx = 2. I ...
Greg Shah
03:46 PM Database Bug #2084: Conversion misplaced parameter for can-find statement
Went back and searched for another solution, since the last one started from the wrong premise that can-find BUFFER_S... Costin Savin
03:35 PM Database Bug #2084: Conversion misplaced parameter for can-find statement
Costin, please provide a detailed update of what you have found/done on this today. Eric Faulhaber
12:04 PM Base Language Bug #2065: ambiguity in date/decimal literals that is not handled properly by the ProgressLexer
Committed to bzr revision 10285. Constantin Asofiei
10:27 AM Base Language Bug #2065: ambiguity in date/decimal literals that is not handled properly by the ProgressLexer
The update looks good. You can check it in and distribute it. Greg Shah
09:56 AM Base Language Bug #2065: ambiguity in date/decimal literals that is not handled properly by the ProgressLexer
Correct, good letter, wrong date. Attached is the good one. Constantin Asofiei
08:13 AM Base Language Bug #2065: ambiguity in date/decimal literals that is not handled properly by the ProgressLexer
I think the wrong update is posted here. Greg Shah

03/13/2013

06:14 PM Base Language Feature #2089: INPUT function returning string value
About note 8: no.
You can do the following:
1. Determine the type (wrapper classname: like "integer") of the va...
Greg Shah
06:00 PM Base Language Feature #2089: INPUT function returning string value
Yes, you should work on item 2 and my changes will enable item 1. Please note that I don't want to transform all val... Greg Shah
04:42 PM Base Language Feature #2089: INPUT function returning string value
In regards to #2: should I parent all occurrences of a validated value with FUNC_POLY node as a solution? Stanislav Lomany
02:12 PM Base Language Feature #2089: INPUT function returning string value
OK, I missed that. So your question remains. Constantin Asofiei
02:11 PM Base Language Feature #2089: INPUT function returning string value
Greg was saying that "I am currently working to extend that facility to be more robust, including detecting the case ... Stanislav Lomany
01:53 PM Base Language Feature #2089: INPUT function returning string value
Stanislav Lomany wrote:
> So, am I correct that except checking the runtime part we have two problems:
> 1. It is n...
Constantin Asofiei
01:47 PM Base Language Feature #2089: INPUT function returning string value
So, am I correct that except checking the runtime part we have two problems:
1. It is not properly recognized that a...
Stanislav Lomany
06:06 PM Database Feature #2080: add runtime support for database methods
Vadim Nebogatov wrote:
> Will be ast processing with rules also required with wrapping String to character?
Const...
Eric Faulhaber
04:49 PM Database Feature #2080: add runtime support for database methods
Eric Faulhaber wrote:
> With your next update, please replace the predicate data type of @String@ in all the @Buff...
Vadim Nebogatov
03:23 PM Database Feature #2080: add runtime support for database methods
Vadim Nebogatov wrote:
> Eric Faulhaber wrote:
> > One question: why not just implement @AbstractQuery.queryReposi...
Eric Faulhaber
03:18 PM Database Feature #2080: add runtime support for database methods
Low priority: related to my last note, we are using the wrong data type for the NO-LOBS parameter in our bufferCopy/... Eric Faulhaber
03:16 PM Database Feature #2080: add runtime support for database methods
Eric Faulhaber wrote:
> One question: why not just implement @AbstractQuery.queryReposition(NumberType n)@ as
> [....
Vadim Nebogatov
02:07 PM Database Feature #2080: add runtime support for database methods
The current project never uses the NO-LOBS parameter of BUFFER-COPY and BUFFER-COMPARE, so the variants of @BufferImp... Eric Faulhaber
01:46 PM Database Feature #2080: add runtime support for database methods
Code review 20130312a:
Update looks fine.
Good catch on the @queryReposition@ method. One question: why not j...
Eric Faulhaber
11:10 AM Database Feature #2080: add runtime support for database methods
I suspect that much of the use we will see of this feature will involve expressions resolving to character values (si... Eric Faulhaber
05:40 AM Database Feature #2080: add runtime support for database methods
The FIND-FIRST/LAST/UNIQUE methods can receive a character for the first parameter. Currently, the Buffer.find* imple... Constantin Asofiei
05:48 PM Conversion Tools Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...
The suggested fix has been uploaded. It properly converts the sample:... Eugenie Lyzenko
02:06 PM Conversion Tools Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...
The places to modify:
for frames: rule file annotation/frame_scoping.rules, internal function "process_frame"...
Eugenie Lyzenko
10:17 AM Conversion Tools Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...
The strange thing is that I thought we already did some of this kind of disambiguation.
We don't want this to be s...
Greg Shah
10:09 AM Conversion Tools Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...
Another word we need to decide what are the exact cases when we need special processing for "-" character. For now I ... Eugenie Lyzenko
10:02 AM Conversion Tools Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...
Another name collision, when vars are used:... Constantin Asofiei
07:55 AM Conversion Tools Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...
If we have a substitution that we want to be the default, then we would always want to encode it in P2J and not in th... Greg Shah
04:51 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Constantin: this case:... Greg Shah
01:34 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
The complete list is this (logged from where the ECW.expressionType would throw exception otherwise):... Constantin Asofiei
01:30 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
> When do you think you will have this available?
The server conversion is in the Base Structure phase, with a few f...
Constantin Asofiei
01:14 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
> What I can do is remove the last fallback checks (the _POLY-related checks ), adjust the ECW to log a message inste... Greg Shah
10:44 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
This is the good version, committed to bzr revision 10284.
LE: it passed conversion regression testing.
Constantin Asofiei
10:34 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Yes, you understand correctly. The idea here was this: for the KW_DYN_FUNC node, we don't need to the ControlFlowOps.... Constantin Asofiei
10:32 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
I guess what is happening is that casttype is really meant to be used for the .class emit on a DYNAMIC-FUNCTION invoc... Greg Shah
10:24 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
I don't fully understand the purpose of the "ignorecast" annotation:... Greg Shah
10:01 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
OK, good idea. Constantin Asofiei
10:00 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
How about this: if these cases are already known to return logical, then I will emit the logical.class and not wrap ... Greg Shah
09:55 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
> In regard to the removal of the castLogical(): currently we bypass the emit of the .class instance in this case (wh... Constantin Asofiei
09:49 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
In regard to the removal of the castLogical(): currently we bypass the emit of the .class instance in this case (when... Greg Shah
09:25 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
> I think the only issue here is where the new character() wrapper is emitted.
I think you are right.
> If I unders...
Constantin Asofiei
09:10 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Here is the code that is generated by my current implementation:... Greg Shah
08:52 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Had a problem, forgot to initialize the @ref@ var in base_structure.xml's @parent.type == prog.kw_run@ run (without t... Constantin Asofiei
08:28 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Greg Shah wrote:
> I think there should be some code like this in the example:
The code should be @h = temp-table t...
Constantin Asofiei
08:23 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
I think there should be some code like this in the example:... Greg Shah
07:39 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
And the update... Constantin Asofiei
07:38 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
The attached update fixes this:
# wrapping of handle for a @RUN ... IN DYNAMIC-FUNCTION@ call
# varargs signature pro...
Constantin Asofiei
06:17 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Greg, in the server project there are failures related to the fact that _POLY is used as an operand. The failed opera... Constantin Asofiei
03:15 PM Base Language Bug #2065: ambiguity in date/decimal literals that is not handled properly by the ProgressLexer
The update has passed conversion regression testing. Constantin Asofiei
02:33 PM Base Language Bug #2065: ambiguity in date/decimal literals that is not handled properly by the ProgressLexer
The only remaining problem was with char field initializers, which were not handled (it was parsers fault). The notes... Constantin Asofiei
03:13 PM Database Bug #2084: Conversion misplaced parameter for can-find statement
Tried to replicate the test which failed on update cs_upd20130312a.zip (-where- before I moved the logic from post-ru... Costin Savin
11:09 AM Database Bug #2084: Conversion misplaced parameter for can-find statement
The testcase from note 11 passed, there was another file from conversion regression tests that failed (with the remap... Costin Savin
10:53 AM Database Bug #2084: Conversion misplaced parameter for can-find statement
I haven't looked at this issue in detail nor tried to reproduce the problem yet, but the last update you sent looks w... Eric Faulhaber
08:11 AM Database Bug #2084: Conversion misplaced parameter for can-find statement
There seems to be a problem with some buffers being used in different db schemas,
after the change it seems the buff...
Costin Savin
05:25 AM Database Bug #2084: Conversion misplaced parameter for can-find statement
There are changes in two files with this update, I think they are expected, but Costin is checking them now. Constantin Asofiei
02:14 AM Database Bug #2090 (Closed): correct sorting of DMO properties during schema conversion
Eric Faulhaber

03/12/2013

06:43 PM Conversion Tools Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...
OK. I've found the answer for note #13. The matchlist.xml config file overrides the NameConverter.java internals. The... Eugenie Lyzenko
06:17 PM Conversion Tools Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...
The question. Why adding replacement:... Eugenie Lyzenko
05:20 PM Database Feature #2080: add runtime support for database methods
Current status of methods from ref 1947
Implemented:
GET-CURRENT (KW_GET_CUR)
FIND-LAST (KW_FIND_LST)
FIND-FIRST ...
Vadim Nebogatov
05:19 PM Database Feature #2080: add runtime support for database methods
Attached update vmn_upd20130312a.zip.
Corrected runtime for BUFFER-COPY (KW_BUF_COPY) and BUFFER-COMPARE (KW_BUF_CO...
Vadim Nebogatov
04:40 PM Database Feature #2080: add runtime support for database methods
Yes, I handed my changes off to Constantin a few days ago, based on an older version, to integrate with some other ch... Eric Faulhaber
04:26 PM Database Feature #2080: add runtime support for database methods
Eric, I corrected BufferImpl.bufferCompare according #12, but noticed that you replaced function body with ... Unsupp... Vadim Nebogatov
06:22 AM Database Feature #2080: add runtime support for database methods
Tests
uast/find-with-locks.p
uast/get-with-locks.p
committed revision 991.
Vadim Nebogatov
05:01 AM Database Feature #2080: add runtime support for database methods
vmn_upd20130311c.zip checked in as bzr revision 10278. Vadim Nebogatov
08:58 PM Database Feature #2080: add runtime support for database methods
Update vmn_upd20130311c.zip has passed conversion regression testing. Please commit it to bzr and distribute. Note ... Eric Faulhaber
04:05 PM Base Language Feature #2089: INPUT function returning string value
As Constantin notes, the INPUT function in the 4GL can return either the actual data type of the widget OR it can ret... Greg Shah
03:46 PM Base Language Feature #2089: INPUT function returning string value
Greg, how should correctly converted validation code look like for the following example?... Stanislav Lomany
03:12 PM Base Language Feature #2089: INPUT function returning string value
Copied from #2068:
*CA*
Another problem found in at least rtb/ folder:...
Stanislav Lomany
03:09 PM Base Language Feature #2089 (Closed): INPUT function returning string value
Stanislav Lomany
03:37 PM Database Bug #2083: client-side where-clause leak in FindQuery
This fix looks good to me. I have merged it with the latest bzr revision, re-run conversion regression testing with ... Eric Faulhaber
01:36 PM Database Bug #2083: client-side where-clause leak in FindQuery
I see you found another solution.
I also found one simple and straightforward solution by refining the condition f...
Ovidiu Maxiniuc
12:19 PM Database Bug #2083: client-side where-clause leak in FindQuery
Ovidiu, I was having many similar issues with client-side query substitution parameters and CAN-FIND while fixing #20... Eric Faulhaber
02:33 PM Database Bug #2084: Conversion misplaced parameter for can-find statement
Added proposed update
It seems the problem is in some situation the remap scope is deleted before we get into the <p...
Costin Savin
11:28 AM Database Bug #2084: Conversion misplaced parameter for can-find statement
It seems there are still some weird cases where it fails. Working on reproducing and fixing it Costin Savin
04:54 AM Database Bug #2084: Conversion misplaced parameter for can-find statement
I'm sorry about that, it seems I forgot to save after doing the clean-up, and created the archive with some unwanted ... Costin Savin
09:54 PM Database Bug #2084: Conversion misplaced parameter for can-find statement
Code review 20130311a:
* Do you have a test case that illustrates the problem described by Constantin in notes 5 a...
Eric Faulhaber
02:08 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Attached was committed to bzr revision 10282. Constantin Asofiei
01:55 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
OK, please go ahead and check it in. You can leave the assignments.rules there. I will deal with the merge.
> Wh...
Greg Shah
01:49 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
PS: the conversion regression testing has passed. The only changes are related to:... Constantin Asofiei
01:44 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
> The code looks fine. I have changes in the assignments.rules and I prefer if you don't include that file (it is ju... Constantin Asofiei
01:28 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
The code looks fine. I have changes in the assignments.rules and I prefer if you don't include that file (it is just... Greg Shah
12:48 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
> That makes sense. Are you going to add that?
No, I don't want to add this now.
> In a related note: my changes...
Constantin Asofiei
12:31 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
That makes sense. Are you going to add that?
In a related note: my changes are ready, but I want to test them wit...
Greg Shah
12:15 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
I don't recall seeing "attributes set to unknown"-related errors, but I think we should consider handling the attribu... Constantin Asofiei
09:16 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
OK, I'll fold that into my changes. It will make the result much cleaner.
In regard to your changes, that is grea...
Greg Shah
08:39 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Yes, we can get rid of castLogical and use new logical() instead.
I have an update for which I still need to make ...
Constantin Asofiei
02:06 PM User Interface Feature #2088: add HIDE STREAM statement support
Committed to bzr revision 10281. Constantin Asofiei
01:58 PM User Interface Feature #2088: add HIDE STREAM statement support
This code is fine. It can be checked in without conversion regression testing. Greg Shah
01:17 PM Database Bug #2059: CAN-FIND clause for a perm table in the RECORD_PHRASE of a temp table, with a FOR EACH...
Update has passed conversion regression testing and is committed to bzr rev. 10280. Eric Faulhaber
12:14 PM Database Bug #2059: CAN-FIND clause for a perm table in the RECORD_PHRASE of a temp table, with a FOR EACH...
Fix candidate is attached. I am conversion regression testing this now. Eric Faulhaber
10:15 PM Database Feature #2000: add conversion support for table and table handle parameters
Code looks good, AFAICT, but without test cases and being able to look at the ASTs, the changes were hard to follow, ... Eric Faulhaber

03/11/2013

07:34 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Do we really need BDT.castLogical()? Or can we handle this using new logical(BDT)? If we can avoid the castLogical(... Greg Shah
12:06 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
> In these cases where ptypes[i] is null, I think it default to BaseDataType, right?
Are you asking what the type ...
Greg Shah
10:50 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
> 1. It seems to me that ParmType.typesMatch() should implement a wider range of matching behavior. For example, if ... Constantin Asofiei
10:21 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Code Review:
1. It seems to me that ParmType.typesMatch() should implement a wider range of matching behavior. Fo...
Greg Shah
08:36 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
The case automatically assigns the lower 32-bits of the long to the int. Since oldtype can never be > 2GB, this is s... Greg Shah
08:05 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
> Yes, that was my fix too for Java 1.6. And I don't think there will be losses, as the token type doesn't need 32 bi... Eugenie Lyzenko
06:28 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
This update contains some fixes in ECW.parameterTypeName and base_structure.xml, plus BUFFER-COPY/COMPARE (from Eric)... Constantin Asofiei
05:25 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Yes, that was my fix too for Java 1.6. And I don't think there will be losses, as the token type doesn't need 32 bits... Constantin Asofiei
05:22 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
> Eugenie: what Java are you using ? I haven't got any error on my system or devsrv01.
1.6.X
The long 64 bit ca...
Eugenie Lyzenko
04:30 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Eugenie: what Java are you using ? I haven't got any error on my system or devsrv01. Constantin Asofiei
06:30 PM Database Feature #2080: add runtime support for database methods
Code review 20130311c:
The merge looks fine. The implementation of @BufferImpl.bufferCompare@ doesn't look right. ...
Eric Faulhaber
05:00 PM Database Feature #2080: add runtime support for database methods
Attached update
vmn_upd20130311c.zip
vmn_upd20130311d.zip (corresponding test cases)
is next replacement of vm...
Vadim Nebogatov
04:26 PM Database Feature #2080: add runtime support for database methods
P2JQuery,
** 040 CA 20130311 Added bufferHandle(integer).
It seems wrong number
Vadim Nebogatov
03:08 PM Database Feature #2080: add runtime support for database methods
Code review 20130311a:
The changes all look good.
I noticed on this second review that even the no-arg versions...
Eric Faulhaber
10:01 AM Database Feature #2080: add runtime support for database methods
Attached update
vmn_upd20130311a.zip
vmn_upd20130311b.zip (corresponding test cases)
is replacement of vmn_upd2013...
Vadim Nebogatov
06:20 PM Database Feature #2000: add conversion support for table and table handle parameters
Regression conversion completed without errors. Stanislav Lomany
03:42 PM Database Feature #2000: add conversion support for table and table handle parameters
> Is this merged up to the latest bzr revision?
Yes, it is merged.
Stanislav Lomany
02:59 PM Database Feature #2000: add conversion support for table and table handle parameters
Is this merged up to the latest bzr revision?
If so, please do run conversion regression testing. Eric will do a ...
Greg Shah
02:32 PM Database Feature #2000: add conversion support for table and table handle parameters
Update for TABLE-HANDLE FOR case. Should I regression-test it? Stanislav Lomany
03:32 PM Database Bug #2083: client-side where-clause leak in FindQuery
The @<action>sibref.setHidden(true)</action>@ from @where_clause_post.rules@ at line 438 from my previous update seem... Ovidiu Maxiniuc
11:24 AM Database Bug #2083: client-side where-clause leak in FindQuery
After some more tests, it seems like this update does not fix the issue, in fact it is too restrictive, it will cut m... Ovidiu Maxiniuc
06:07 AM Database Bug #2083: client-side where-clause leak in FindQuery
With help from Constantin, the missing @setHidden@ is now in place. Ovidiu Maxiniuc
01:46 PM Database Bug #2084: Conversion misplaced parameter for can-find statement
Added proposed update which checks if the javaname is marked for remap but not as a generated increment name. Costin Savin
11:09 AM Base Language Feature #1640: implement DOM XML support
Added more missing APIs. Committed to bzr revision 10276 Constantin Asofiei
11:05 AM Base Language Feature #1884: add some of the v10 data types and core built-ins
-Added more missing APIs. Committed to bzr revision 10276- was for task #1640 Constantin Asofiei
11:05 AM Database Feature #1947: add conversion support for database methods
Added missing API bufferHandle(integer). Committed to bzr revision -10276- 10277. Constantin Asofiei

03/10/2013

03:29 PM Database Feature #1668: add support for additional (non-dynamic) database attributes
Update ecf_upd20130308a.zip has passed conversion regression testing and is committed as bzr rev. 10274. Eric Faulhaber
02:36 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
> And the update for note 50.
Constantin, how you compiled the update? I put it on top of the current bzr code and...
Eugenie Lyzenko
10:16 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
And the update for note 50. Constantin Asofiei
10:16 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Attached update contains:
# ParmType - added needed APIs for the enum
# SignatureHelper - fixed the definition for ...
Constantin Asofiei
07:30 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Eugenie: I think KW_SET_BUF should have a BDT_VARARGS instead of BDT_ARRAY, because as I see from the docs, it can re... Constantin Asofiei
07:15 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Constantin Asofiei wrote:
> Greg Shah wrote:
> > Actually, after thinking about it some more, is there a need to ev...
Constantin Asofiei

03/09/2013

05:20 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
New drop uploaded. The function and methods are separated in two different maps. Eugenie Lyzenko
04:52 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Yes, go with that approach. Greg Shah
04:30 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
> This also means we will have to pass the token type (FUNC_*/METH_*) in addition to the keyword.
Yes, we can impl...
Eugenie Lyzenko
03:15 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
This also means we will have to pass the token type (FUNC_*/METH_*) in addition to the keyword. Greg Shah
02:54 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Eugenie Lyzenko wrote:
> > Eugenie: KW_FILL appears twice in the map.
>
> Yes, one for Built-in function, other f...
Constantin Asofiei
02:34 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
> Eugenie: KW_FILL appears twice in the map.
Yes, one for Built-in function, other for method. They both have diff...
Eugenie Lyzenko
02:27 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
> For KW_REPLACE: I see that you've specified two signatures for it, but according to 10.2B docs, it has 3 mandatory ... Eugenie Lyzenko
12:01 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Greg Shah wrote:
> Actually, after thinking about it some more, is there a need to ever wrap the parameters to DYNAM...
Constantin Asofiei
11:44 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Actually, after thinking about it some more, is there a need to ever wrap the parameters to DYNAMIC-FUNCTION? They w... Greg Shah
11:42 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
OK. But we could handle these cases too.
1. SUPER is especially easy to handle, because we can use the same techn...
Greg Shah
11:37 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
> Actually, I think the ECW already handles KW_SUPER fully. It searches up the tree to find the containing function ... Constantin Asofiei
11:31 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Some thoughts:
> The fact that a function can have multiple signatures troubles us at conversion time, as if we do...
Greg Shah
11:02 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Another case of the KW_DYN_FUNC: the handle parameter is optional. I think this should also be explicitly treated by ... Constantin Asofiei
09:40 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
There is another case which is not treated properly. When IF ternary operator has an ? on the else or then branch, as... Constantin Asofiei
08:20 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
About KW_DATETIME:
* how can we disambiguate the signature, if the number of mandatory parameter is the same (1) in ...
Constantin Asofiei
07:53 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Eugenie: KW_FILL appears twice in the map. Constantin Asofiei
05:08 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
The fact that a function can have multiple signatures troubles us at conversion time, as if we don't offer a choice t... Constantin Asofiei
03:57 PM Base Language Bug #2076: DMO setter fails when parameter is BaseDataType
A simple change to ECW fixes this. I am making some other changes to the ECW as well. Then I will conversion test t... Greg Shah
11:25 AM Base Language Bug #2076: DMO setter fails when parameter is BaseDataType
There is a regression related to this update:... Constantin Asofiei
03:56 PM Base Language Feature #2050: ATTR_POLY/METH_POLY used as rvalue or in expressions
Yes, I'm thinking about what is the right solution here. I wonder if I should make the previous solution (the extra ... Greg Shah
03:52 PM Base Language Feature #2050: ATTR_POLY/METH_POLY used as rvalue or in expressions
Hmm... on a second thought, this is similar to the DMO setter case... it should wrap the _POLY/DB_NON_REF in a logica... Constantin Asofiei
03:34 PM Base Language Feature #2050: ATTR_POLY/METH_POLY used as rvalue or in expressions
I'm not sure the problem is in the ECW. Actually, there is never any attempt to call the ECW for these cases. If I ... Greg Shah
11:13 AM Base Language Feature #2050: ATTR_POLY/METH_POLY used as rvalue or in expressions
The strange thing is that I already put in support for all of these cases. I guess it is not working properly. I wi... Greg Shah
07:28 AM Base Language Feature #2050: ATTR_POLY/METH_POLY used as rvalue or in expressions
The ExpressionConversion worker needs to treat the cases when a _POLY is used in a logical test, as in:... Constantin Asofiei
11:11 AM Base Language Feature #2087 (Closed): add support for extent vars/fields used with a PUT statement (stream-only...
Checked in as bzr revision 10273. Greg Shah
04:44 AM Base Language Feature #2087: add support for extent vars/fields used with a PUT statement (stream-only feature)
The ges_upd20130308g.zip update has passed conversion regression testing. Constantin Asofiei
03:01 AM Base Language Feature #2087: add support for extent vars/fields used with a PUT statement (stream-only feature)
Thanks, that did the trick. I'm putting it through conversion regression testing. Constantin Asofiei
11:06 AM Base Language Bug #2065 (Closed): ambiguity in date/decimal literals that is not handled properly by the Progre...
Greg Shah
11:06 AM Base Language Bug #2065: ambiguity in date/decimal literals that is not handled properly by the ProgressLexer
Passed conversion testing and checked in as bzr revision 10272. Greg Shah
09:11 AM Database Bug #2083: client-side where-clause leak in FindQuery
I couldn't get my mind of client_taint and I took a quick look where is used. In where_clause_post.rules, at line 413... Constantin Asofiei
02:55 AM Base Language Feature #1640: implement DOM XML support
Adds two missing APIs in XmlFactory, related to WIDGET-POOL clause. Committed to bzr revision 10271. Constantin Asofiei

03/08/2013

05:25 PM Base Language Feature #2087: add support for extent vars/fields used with a PUT statement (stream-only feature)
Take a look at this. I think this should do the same thing. Greg Shah
03:59 PM Base Language Feature #2087: add support for extent vars/fields used with a PUT statement (stream-only feature)
The good news is that 0308h.zip has passed conversion regression testing - no changes. Constantin Asofiei
03:47 PM Base Language Feature #2087: add support for extent vars/fields used with a PUT statement (stream-only feature)
I had a feeling there was another file where this was done already for some other cases, but my brain chose to ignore... Constantin Asofiei
03:41 PM Base Language Feature #2087: add support for extent vars/fields used with a PUT statement (stream-only feature)
Code Review:
Could we have added this as an additional case in annotations/array_expansion.rules?
Greg Shah
02:58 PM Base Language Feature #2087: add support for extent vars/fields used with a PUT statement (stream-only feature)
Had a regression (didn't handle the case when the PUT used a subscripted field). Back in regression testing. Constantin Asofiei
01:31 PM Base Language Feature #2087: add support for extent vars/fields used with a PUT statement (stream-only feature)
4GL allows extent vars/fields to be used in a PUT statement:... Constantin Asofiei
01:27 PM Base Language Feature #2087 (Closed): add support for extent vars/fields used with a PUT statement (stream-only...
Constantin Asofiei
05:07 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
The first complete drop to review has been uploaded.
PS: Forgot to note. The file SignatureHelper.java contains the ...
Eugenie Lyzenko
04:06 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
> Undocumented functions?
Yes, these are undocumented.
It is our understanding that LOWER is the same thing as ...
Greg Shah
02:59 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Greg,
I'm preparing the final drop to upload and requesting for ability not to follow the 98 column restriction fo...
Eugenie Lyzenko
01:38 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
The remaining questions:
The functions defined in progress.g but not in 4GL reference documentation:...
Eugenie Lyzenko
11:18 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Add CLOB (which is really only the CLOB field case) and LARGE_CHAR_OBJECT which is either LONGCHAR or CLOB.
> SET-...
Greg Shah
10:39 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
> Can you provide an example? A CLOB can only be a field in the database, so I guess the method must take a reference... Eugenie Lyzenko
08:35 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
> There are the methods we do not define in progress.g file:
These are from v11 which we don't support yet.
> D...
Greg Shah
10:04 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
The handle methods has been added. There are the methods we do not define in progress.g file:
ADD-PARENT-ID-RELATION...
Eugenie Lyzenko
05:05 PM Base Language Bug #2065: ambiguity in date/decimal literals that is not handled properly by the ProgressLexer
Fix for empty string used as a date var initializer. It is being conversion tested now. Greg Shah
04:30 PM Base Language Bug #2065: ambiguity in date/decimal literals that is not handled properly by the ProgressLexer
Passed conversion testing and checked in as revision 10269.
I'll handle the date from an empty string next.
Greg Shah
03:38 PM Base Language Bug #2065: ambiguity in date/decimal literals that is not handled properly by the ProgressLexer
Another issue related to dates:... Constantin Asofiei
03:28 PM Base Language Bug #2065: ambiguity in date/decimal literals that is not handled properly by the ProgressLexer
Final version going through conversion testing now. There was an issue with removal of zeros from the year portion o... Greg Shah
02:05 PM Base Language Bug #2065 (WIP): ambiguity in date/decimal literals that is not handled properly by the ProgressL...
How many times am I going to be wrong today? Majic compiled fine with the c update but there are still many unwanted... Greg Shah
12:12 PM Base Language Bug #2065: ambiguity in date/decimal literals that is not handled properly by the ProgressLexer
Another silly mistake, I didn't properly exclude num literals from the trailing zero removal. This updated version i... Greg Shah
10:56 AM Base Language Bug #2065: ambiguity in date/decimal literals that is not handled properly by the ProgressLexer
Fixed a stupid indexing error. Going back into conversion testing. Greg Shah
10:48 AM Base Language Bug #2065: ambiguity in date/decimal literals that is not handled properly by the ProgressLexer
Updated version of the testcase plus the prepared fixes which are going into conversion testing now.
The core solu...
Greg Shah
04:40 PM Database Feature #1668: add support for additional (non-dynamic) database attributes
Fix candidate attached. I'll push this through conversion regression testing.
Vadim: please take note of this up...
Eric Faulhaber
03:56 PM Database Feature #1668: add support for additional (non-dynamic) database attributes
Eric, we've hit this on another occasion (? literal). For now, just handle both cases. The parser changes related to ... Constantin Asofiei
03:43 PM Database Feature #1668: add support for additional (non-dynamic) database attributes
Interesting...outside of the message statement, the NO_LOCK_LITERAL is the child of an intermediate EXPRESSION node, ... Eric Faulhaber
03:24 PM Database Feature #1668: add support for additional (non-dynamic) database attributes
The update doesn't handle this case:... Constantin Asofiei
03:17 PM User Interface Feature #2088: add HIDE STREAM statement support
The HIDE ALL statement can target a stream, as in:... Constantin Asofiei
03:14 PM User Interface Feature #2088 (Closed): add HIDE STREAM statement support
Constantin Asofiei
02:19 PM Conversion Tools Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...
I'm putting this case here, because is a name collision:... Constantin Asofiei
07:39 AM Conversion Tools Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...
Passed conversion regression testing, committed to bzr revision 10265. Constantin Asofiei
04:40 AM Conversion Tools Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...
This converts dots in names to "dot" string. I will put this through conversion. Constantin Asofiei
01:59 PM Database Bug #2084: Conversion misplaced parameter for can-find statement
Sorry, I should have been more explicit. The failures are caused by the fact that, when you have a table named @prodc... Constantin Asofiei
01:53 PM Database Bug #2084: Conversion misplaced parameter for can-find statement
Constantin Asofiei wrote:
> Conversion regression testing has failed, as the tests above have passed because the jav...
Eric Faulhaber
06:53 AM Database Bug #2084: Conversion misplaced parameter for can-find statement
Conversion regression testing has failed, as the tests above have passed because the javaname in these cases is the s... Constantin Asofiei
04:51 AM Database Bug #2084: Conversion misplaced parameter for can-find statement
The changes looks good, also solves other compile errors where wrong buf name was used, in cases like:... Constantin Asofiei
04:01 AM Database Bug #2084: Conversion misplaced parameter for can-find statement
Added proposed update,
In previous comment I didn't understood exactly the process so I assumed there's an addition...
Costin Savin
12:20 PM Database Feature #2000: add conversion support for table and table handle parameters
About the state of work: I changed the parser so TABLE-HANDLE FOR is recognized as a variable reference rather than a... Stanislav Lomany
12:19 PM Database Bug #2083: client-side where-clause leak in FindQuery
At this moment, I use the following simplified testcase:... Ovidiu Maxiniuc
12:09 PM Database Bug #2083: client-side where-clause leak in FindQuery
I'm getting closer. Here what I found:
The extra node (@f1 [FUNC_LOGICAL]@) should be made hidden so it will not b...
Ovidiu Maxiniuc
09:09 AM Database Bug #2083: client-side where-clause leak in FindQuery
In my previous note there the and operator from where clause contains a reference to a buffer other than the one that... Ovidiu Maxiniuc
10:35 AM Database Feature #2086 (Closed): add support for the VALIDATE clause, for the temp-table's fiels defined u...
Greg Shah
10:34 AM Database Feature #2086: add support for the VALIDATE clause, for the temp-table's fiels defined using LIKE...
Committed to bzr 10266. Constantin Asofiei
09:58 AM Database Feature #2086: add support for the VALIDATE clause, for the temp-table's fiels defined using LIKE...
OK, this change looks fine. Commit and distribute it. Greg Shah
09:48 AM Database Feature #2086: add support for the VALIDATE clause, for the temp-table's fiels defined using LIKE...
The update has passed conversion regression testing. There is one additional change in MAJIC, from a @DEFINE TEMP-TAB... Constantin Asofiei
08:37 AM Database Feature #2086: add support for the VALIDATE clause, for the temp-table's fiels defined using LIKE...
Sorry, when you say "VALIDATE clause", I thought you are referring to the option for a TEMP-TABLE (not for a specific... Greg Shah
07:27 AM Database Feature #2086: add support for the VALIDATE clause, for the temp-table's fiels defined using LIKE...
New version of the update, which solves the VALIDATE when used with @DEFINE TEMP-TABLE tt1 LIKE source VALIDATE@. Als... Constantin Asofiei
03:09 AM Database Feature #2086: add support for the VALIDATE clause, for the temp-table's fiels defined using LIKE...
This fix removes the extent annotation from the source field reference in the VALEXP. What is still needed to do:
# ...
Constantin Asofiei
01:41 AM Database Feature #2086: add support for the VALIDATE clause, for the temp-table's fiels defined using LIKE...
Greg, the VALIDATE clause is used in the server project with a field definition. See file pmcon/cjcotdo0.w. There are... Constantin Asofiei
10:35 AM Base Language Feature #1640: implement DOM XML support
Committed to bzr revision 10267 Constantin Asofiei
10:02 AM Base Language Feature #1640: implement DOM XML support
I'm fine with the change. Commit and distribute it. Greg Shah
09:45 AM Base Language Feature #1640: implement DOM XML support
ca_upd20130308d.zip has passed conversion regression testing. Constantin Asofiei
08:15 AM Base Language Feature #1640: implement DOM XML support
Fixed conversion of CREATE statements related to XML support. The correct approach is to pass the handle instance as ... Constantin Asofiei

03/07/2013

06:12 PM Database Feature #2086: add support for the VALIDATE clause, for the temp-table's fiels defined using LIKE...
VALIDATE is NOT used in the server project (in a TEMP-TABLE or WORK-TABLE definition). Only NO-UNDO and RCODE-INFORM... Greg Shah
05:41 PM Database Feature #2086: add support for the VALIDATE clause, for the temp-table's fiels defined using LIKE...
MAJIC has finished conversion and there are changes, expected: validation clauses are dropped for temp-table fields d... Constantin Asofiei
04:55 PM Database Feature #2086: add support for the VALIDATE clause, for the temp-table's fiels defined using LIKE...
The server project exposed a problem with the temp-table fields defined using the LIKE clause, when the target field ... Constantin Asofiei
04:43 PM Database Feature #2086 (Closed): add support for the VALIDATE clause, for the temp-table's fiels defined u...
Constantin Asofiei
05:27 PM Conversion Tools Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...
Go ahead with this change.
> A question: are you sure it's safe to "eat" the "-", "_" and "/" character from the n...
Greg Shah
05:15 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
No, CONFIG-NAME is supposed to be an attribute. It is a bug in our parser. I have some other parser changes I'm mak... Greg Shah
05:01 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Found potential issue in progress.g:
According to Progress doc CONFIG-NAME is an attribute, not a method. But we def...
Eugenie Lyzenko
10:44 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
> If parameter is widget we need to add something: WID mapping to GenerigWidget?
Yes, that is fine.
> Arrays ar...
Greg Shah
09:58 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Greg,
I'm working on the handle based methods adding. It's avout 300 lines. So I'm expecting to finish today-tomor...
Eugenie Lyzenko
09:26 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
The update has been uploaded. All built-in functions are there except so called "fake" web-speed ones. No methods for... Eugenie Lyzenko
05:00 PM Base Language Bug #2076 (Closed): DMO setter fails when parameter is BaseDataType
Greg Shah
04:58 PM Base Language Bug #2076: DMO setter fails when parameter is BaseDataType
Passes conversion testing and is checked into bzr as revision 10264.
Greg Shah
04:46 PM Base Language Bug #2076: DMO setter fails when parameter is BaseDataType
No, that is alright. The difference is not significant at runtime. Thanks.
I will check this in and distribute it.
Greg Shah
04:41 PM Base Language Bug #2076: DMO setter fails when parameter is BaseDataType
> Constantin: what do you think?
The result will not affect runtime, is just some small overhead. I think this is be...
Constantin Asofiei
04:32 PM Base Language Bug #2076: DMO setter fails when parameter is BaseDataType
Conversion testing has finished. There is this one unexpected change:... Greg Shah
02:25 PM Base Language Bug #2076: DMO setter fails when parameter is BaseDataType
This update is fine. I will conversion regression test it.
> Sorry I missed the "rule" directory , what I do when...
Greg Shah
01:14 PM Base Language Bug #2076: DMO setter fails when parameter is BaseDataType
Added proposed update.
Sorry I missed the "rule" directory , what I do when adding an update: I manually create the...
Costin Savin
12:20 PM Base Language Bug #2076: DMO setter fails when parameter is BaseDataType
Code Feedback:
1. Your zip still has the wrong directory name "rule" instead of "rules". How is that even getting...
Greg Shah
06:06 AM Base Language Bug #2076: DMO setter fails when parameter is BaseDataType
Added proposed update (uploaded it first by mistake to #2070) Costin Savin
03:12 PM Database Feature #2080: add runtime support for database methods
Code review 20130307a:
* There is no implementation for @QueryWrapper.getNext(LockType)@. The other @getXXX(LockT...
Eric Faulhaber
11:10 AM Database Feature #2080: add runtime support for database methods
Vadim Nebogatov wrote:
> Does P2J have common module responsible for 4GL errors processing? (I found actually ErrorM...
Eric Faulhaber
11:01 AM Database Feature #2080: add runtime support for database methods
Attached update vmn_upd20130307a.zip. Added runtime support for queryClose, queryForward, queryReposition, queryRepos... Vadim Nebogatov
05:11 AM Database Feature #2080: add runtime support for database methods
Does P2J have common module responsible for 4GL errors processing? (I found actually ErrorManager.recordOrThrowError(... Vadim Nebogatov
02:10 PM Database Bug #2084: Conversion misplaced parameter for can-find statement
The problem seems to be happening in the annotation phase in the following way:
The BUFFER_SCOPE with a bufname" va...
Costin Savin
07:46 AM Database Bug #2084: Conversion misplaced parameter for can-find statement
Example:... Costin Savin
07:44 AM Database Bug #2084 (Closed): Conversion misplaced parameter for can-find statement
Costin Savin
12:42 PM Base Language Feature #2082: add conversion support for 4GL's duplicate variable "feature"
Greg Shah wrote:
> I'm not sure why you switched from a Set to a Map in fixups/variable_definitions.rules (did you p...
Constantin Asofiei
12:29 PM Base Language Feature #2082: add conversion support for 4GL's duplicate variable "feature"
I'm not sure why you switched from a Set to a Map in fixups/variable_definitions.rules (did you plan to use it and th... Greg Shah
12:13 PM Base Language Feature #2082: add conversion support for 4GL's duplicate variable "feature"
The edited file is in task #2085.
This update has passed conversion regression testing (there are changes in two f...
Constantin Asofiei
09:51 AM Base Language Feature #2082: add conversion support for 4GL's duplicate variable "feature"
MAJIC has the case at note 14 in only one file. I've checked the history of this file and this change was introduced ... Constantin Asofiei
08:59 AM Base Language Feature #2082: add conversion support for 4GL's duplicate variable "feature"
Fixed a problem (I was using varDict.getSymbol instead of varDict.getSymbolAtScope(name, 0) to search only in the cur... Constantin Asofiei
08:45 AM Base Language Feature #2082: add conversion support for 4GL's duplicate variable "feature"
This has regressions, one of them relaed to this, as 4GL (v9-only I think) allowed this:... Constantin Asofiei
06:27 AM Base Language Feature #2082: add conversion support for 4GL's duplicate variable "feature"
So the problem was that the parser was adding tempidx to the dupped vars too. The sollution was to not register the d... Constantin Asofiei
05:49 AM Base Language Feature #2082: add conversion support for 4GL's duplicate variable "feature"
I need to rewrite this at the parser side, as the duped var gets ref'ed by the parser:... Constantin Asofiei
05:13 AM Base Language Feature #2082: add conversion support for 4GL's duplicate variable "feature"
Fixed multiple calls like:... Constantin Asofiei
12:02 PM Base Language Bug #2069: Accumulator temp table field disambiguation
Committed to bzr revision 10262. Constantin Asofiei
11:56 AM Base Language Bug #2069: Accumulator temp table field disambiguation
The change looks fine. Check it in and distribute it. Greg Shah
05:51 AM Base Language Bug #2069: Accumulator temp table field disambiguation
This has passed conversion regression testing. Constantin Asofiei
04:53 AM Base Language Bug #2069: Accumulator temp table field disambiguation
I think the sollution was to mark the tables which are weak reference as preferred, when abbreviations are encountere... Constantin Asofiei
03:51 AM Base Language Bug #2069: Accumulator temp table field disambiguation
Another creature of the rabbit hole found at #1985, 120. This fails:... Constantin Asofiei
09:57 AM Database Bug #2083: client-side where-clause leak in FindQuery
I did some patch (removing the extra expression from where node after generating the anonymous inner class needed by ... Ovidiu Maxiniuc
05:33 AM Database Bug #2083: client-side where-clause leak in FindQuery
Another can-find leak:... Constantin Asofiei
08:48 AM Database Feature #2000: add conversion support for table and table handle parameters
> When will the solution be ready for review?
Hopefully will finish it today.
Stanislav Lomany
08:46 AM Database Feature #2000: add conversion support for table and table handle parameters
When will the solution be ready for review? Greg Shah
04:44 AM Database Feature #2000: add conversion support for table and table handle parameters
About @DEF PARAMETER TABLE-HANDLE FOR th@ where @th@ is a regular variable:
1. OUTPUT case will produce compile-ti...
Stanislav Lomany
05:28 AM Base Language Bug #2070: BlockManager Action disambiguation
Added update to wrong task deleting it Costin Savin

03/06/2013

05:13 PM Database Feature #2080: add runtime support for database methods
Please implement all the methods you can, which do not require dynamic database support. For example, FIND-FIRST wit... Eric Faulhaber
04:38 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
OK.
The new datatype under questions:
1. If parameter is widget we need to add something: WID mapping to GenerigW...
Eugenie Lyzenko
04:00 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
OK, get as much done tonight as possible. Then create an update zip and upload it here.
Constantin will be able t...
Greg Shah
03:34 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
> Eugenie: how much more time do you expect this to take?
It is > 100 items left in functions. I guess this is ~10...
Eugenie Lyzenko
03:24 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
> Constantin: We can certainly go ahead with the infrastructure to use the facility. I planned this to be exposed th... Constantin Asofiei
03:14 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Eugenie: how much more time do you expect this to take?
Constantin: We can certainly go ahead with the infrastruct...
Greg Shah
03:10 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Greg: I don't know the order you plan to have this working, but if documenting each signature will take more time, I ... Constantin Asofiei
02:42 PM Conversion Tools Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...
OK, looks like this addition in NamepConverte's static c'tor:... Constantin Asofiei
02:39 PM Conversion Tools Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...
This one did turn and bit us, because the server project has files named like "foo.bar.p", which get converted to "Fo... Constantin Asofiei
02:02 PM Database Bug #2083: client-side where-clause leak in FindQuery
Ovidiu Maxiniuc wrote:
> The parameter is in fact an echo of the content of the client-side WhereExpression: @f1(cus...
Eric Faulhaber
01:59 PM Database Bug #2083: client-side where-clause leak in FindQuery
Here are the converted code for two cases (which attempt to call two new constructors), with and without another join... Ovidiu Maxiniuc
01:50 PM Database Bug #2083: client-side where-clause leak in FindQuery
I tried to simplify the sample. Suppose we have a simple function:... Ovidiu Maxiniuc
01:25 PM Database Bug #2083 (Closed): client-side where-clause leak in FindQuery
Ovidiu Maxiniuc
01:50 PM Base Language Feature #1884: add some of the v10 data types and core built-ins
Committed to bzr revision 10259. Constantin Asofiei
01:45 PM Base Language Feature #1884: add some of the v10 data types and core built-ins
I agree. The code is fine. Check it in and distribute it. Greg Shah
01:30 PM Base Language Feature #1884: add some of the v10 data types and core built-ins
Added missing TextOps.numEntries(String, String). I don't see a reason to put this through conversion regression test... Constantin Asofiei
01:37 PM Database Feature #1947 (Closed): add conversion support for database methods
Vadim committed this update to bzr as revision number 10256. Eric Faulhaber
11:21 AM Database Feature #1947: add conversion support for database methods
I made a minor change to the database_general.rules header. Please check in and distribute the attached version of y... Eric Faulhaber
10:58 AM Database Feature #1947: add conversion support for database methods
I have attached one more variant of the same update, but merged manually Vadim Nebogatov
10:29 AM Database Feature #1947: add conversion support for database methods
Code review 20130306a:
Other than the literal.rules merge issue noted above (which I do think was my mistake), eve...
Eric Faulhaber
09:35 AM Database Feature #1947: add conversion support for database methods
I will merge everything manually and resubmit Vadim Nebogatov
09:25 AM Database Feature #1947: add conversion support for database methods
As I see, update from Eric was not merged with revision you pointed. Maybe I am wrong with time calculation? Vadim Nebogatov
09:21 AM Database Feature #1947: add conversion support for database methods
Update #134 from Eric was attached at 2013-03-05 11:38PM, so I supposed that it was merged with revision 10245 that w... Vadim Nebogatov
08:54 AM Database Feature #1947: add conversion support for database methods
Vadim, literals.rules is not merged with 10245 (evl_upd20130305a.zip). I'll let Eric review the rest of the update. Constantin Asofiei
08:49 AM Database Feature #1947: add conversion support for database methods
Attached update
vmn_upd20130306a.zip / vmn_upd20130306a_test_cases.zip (start/final revisions 10245/10253)
The follow...
Vadim Nebogatov
11:46 PM Database Feature #1947: add conversion support for database methods
Vadim, please note that Ovidiu soon will be committing to bzr some changes to files which will overlap with your upda... Eric Faulhaber
01:25 PM Base Language Bug #2065: ambiguity in date/decimal literals that is not handled properly by the ProgressLexer
The following testcase shows the limits of this ambiguity.
From the header:...
Greg Shah
01:20 PM Base Language Bug #2076: DMO setter fails when parameter is BaseDataType
That crossed my mind too and started in that direction in the morning, but thought about the copy Ast with null paren... Costin Savin
01:09 PM Base Language Bug #2076: DMO setter fails when parameter is BaseDataType
The best thing to do here is to move the current logic for ECW.expressionType(Aast) to a new public worker method ECW... Greg Shah
12:44 PM Base Language Bug #2076: DMO setter fails when parameter is BaseDataType
The AST... Costin Savin
12:39 PM Base Language Bug #2076: DMO setter fails when parameter is BaseDataType
Please post the AST here for the @assign test.int-field = h:BUFFER-FIELD("dsc"):BUFFER-VALUE(2).@. Greg Shah
12:16 PM Base Language Bug #2076: DMO setter fails when parameter is BaseDataType
I'll use this example to explain.... Costin Savin
11:45 AM Base Language Bug #2076: DMO setter fails when parameter is BaseDataType
Code Review:
> I first tried to use ExpresionConversionWorker.expressionType with an ast copy without a parent (be...
Greg Shah
11:24 AM Base Language Bug #2076: DMO setter fails when parameter is BaseDataType
Added proposed update
NOTE
I first tried to use ExpresionConversionWorker.expressionType with an ast copy without...
Costin Savin
12:54 PM Base Language Feature #1920: implement persistent procedures
Added merged update, which was committed to bzr revision 10258. Constantin Asofiei
12:44 PM Base Language Feature #1920: implement persistent procedures
Passed conversion regression testing, no changes in generated sources.
I'll merge the file with latest version and...
Constantin Asofiei
11:35 AM Base Language Feature #1920: implement persistent procedures
Fixed attribute access when there are extent widgets, like:... Constantin Asofiei
12:42 PM Database Bug #2077: fix converted table and field name collisions
Committed to bzr revision 10257. Constantin Asofiei
11:54 AM Database Bug #2077: fix converted table and field name collisions
Check it in and distribute it. Greg Shah
11:40 AM Database Bug #2077: fix converted table and field name collisions
Update has passed conversion regression testing - no changes in generated code. Constantin Asofiei
10:46 AM Database Bug #2077: fix converted table and field name collisions
This solves the collision cases for good. Also, I've added support for buffer names collision check. I'm putting this... Constantin Asofiei
09:12 AM Database Bug #2077: fix converted table and field name collisions
Yes, the fix is pretty simple. I'll provide an update today. Constantin Asofiei
09:00 AM Database Bug #2077: fix converted table and field name collisions
If this is easy enough to fix, please go ahead and put the fix in. That way we don't have to remember there is a pro... Greg Shah
07:38 AM Database Bug #2077: fix converted table and field name collisions
Ovidiu, sorry I hijacked this from you last night. Anyway, this case I don't think is encountered in the server proje... Constantin Asofiei
07:26 AM Database Bug #2077: fix converted table and field name collisions
By chance I prepared a sample test-case for this issue which at this moment is not converted correctly by p2j:... Ovidiu Maxiniuc
01:50 AM Database Bug #2077: fix converted table and field name collisions
Committed to bzr revision 10246. Constantin Asofiei
11:10 AM Base Language Feature #2082 (Closed): add conversion support for 4GL's duplicate variable "feature"
Greg Shah
10:59 AM Base Language Feature #2082: add conversion support for 4GL's duplicate variable "feature"
Committed to bzr revision 10255. Constantin Asofiei
10:54 AM Base Language Feature #2082: add conversion support for 4GL's duplicate variable "feature"
Check it in and distribute it. Greg Shah
10:33 AM Base Language Feature #2082: add conversion support for 4GL's duplicate variable "feature"
The update has passed conversion regression testing. Note that even MAJIC had two cases of duplicated vars, in two fi... Constantin Asofiei
09:10 AM Base Language Feature #2082: add conversion support for 4GL's duplicate variable "feature"
Added comment and fixed the proc/function case. I'm putting it back into conversion regression testing. Constantin Asofiei
09:05 AM Base Language Feature #2082: add conversion support for 4GL's duplicate variable "feature"
Please put a comment into the variable_definitions.rules about the order of the definitions and that we deliberately ... Greg Shah
09:03 AM Base Language Feature #2082: add conversion support for 4GL's duplicate variable "feature"
> 1. Is there any difference in behavior when the non-global define variable is inside a nested scope (e.g. an intern... Constantin Asofiei
08:58 AM Base Language Feature #2082: add conversion support for 4GL's duplicate variable "feature"
The code looks good. I only have 2 questions:
1. Is there any difference in behavior when the non-global define v...
Greg Shah
08:42 AM Base Language Feature #2082 (Review): add conversion support for 4GL's duplicate variable "feature"
Attached update hides all duplicate var defs, only if the first one is DEF NEW GLOBAL SHARED. I'm putting this throug... Constantin Asofiei
08:19 AM Base Language Feature #2082: add conversion support for 4GL's duplicate variable "feature"
4GL allows two vars with the same name, if this construct is encountered:... Constantin Asofiei
08:18 AM Base Language Feature #2082 (Closed): add conversion support for 4GL's duplicate variable "feature"
Constantin Asofiei
08:57 AM Base Language Bug #2070: BlockManager Action disambiguation
Commited to bzr as revision number 10254. Costin Savin
08:35 AM Base Language Bug #2070: BlockManager Action disambiguation
The update has passed conversion regression testing, go ahead and distribute it. Constantin Asofiei
07:36 AM Base Language Bug #2070: BlockManager Action disambiguation
Added update Costin Savin
07:35 AM Base Language Bug #2070: BlockManager Action disambiguation
Please remove the dangling text from the 421 and the other edits I mentioned, and re-upload. I'm putting it through c... Constantin Asofiei
07:11 AM Base Language Bug #2070: BlockManager Action disambiguation
Added fix update Costin Savin
06:50 AM Base Language Bug #2070: BlockManager Action disambiguation
0305d.zip doesn't fully solve the issue, as the package name is computed wrong. It uses the package from the nearest ... Constantin Asofiei
08:47 AM Base Language Bug #2069 (Closed): Accumulator temp table field disambiguation
Greg Shah
08:27 AM Base Language Feature #2079 (Closed): add missing conversion support for format string
Greg Shah
08:26 AM Conversion Tools Bug #2066 (Closed): brew adds unnecessary comma in method parameter list after comment
Greg Shah
07:13 AM Conversion Tools Bug #2066: brew adds unnecessary comma in method parameter list after comment
Committed to bzr revision 10251. Constantin Asofiei
05:18 AM Conversion Tools Bug #2066: brew adds unnecessary comma in method parameter list after comment
The server folders had no errors related to comments. Constantin Asofiei
08:08 AM Base Language Feature #2078 (Closed): provide support for malformed label names
Greg Shah
01:52 AM Base Language Feature #2078: provide support for malformed label names
Committed to bzr revision 10247. Constantin Asofiei
07:14 AM Database Feature #1967: rework DMO class/interface hierarchy
0306b.zip was committed to bzr revision 10253. Constantin Asofiei
04:46 AM Database Feature #1967: rework DMO class/interface hierarchy
ca_upd20130306b.zip has passed conversion regression testing (no changes in generated sources). Constantin Asofiei
02:25 AM Database Feature #1967: rework DMO class/interface hierarchy
Attached update fixes the problem for my 0305d.zip. It brackets the deleteAll with a block only if it's parent is not... Constantin Asofiei
11:36 PM Database Feature #1967: rework DMO class/interface hierarchy
The om_upd20130304b.zip and ecf_upd20130305a.zip updates have gotten through conversion regression testing. However,... Eric Faulhaber
09:50 PM Database Feature #1967: rework DMO class/interface hierarchy
Code review -20130304a- 20130304b:
The code looks fine. The attached update corrects some cut-and-paste errors in t...
Eric Faulhaber
07:14 AM Base Language Feature #1885: fix and add necessary format string support
0306a.zip was Committed to bzr revision 10252. Constantin Asofiei
04:45 AM Base Language Feature #1885: fix and add necessary format string support
0306a.zip has passed conversion regression testing (no changes in generated sources). Constantin Asofiei
02:32 AM Base Language Feature #1885: fix and add necessary format string support
Correct version of progress.g Constantin Asofiei
02:16 AM Base Language Feature #1885: fix and add necessary format string support
This version emits the toStringMessage in case the format is a complex expression, for PUT field. Also, adds a TODO i... Constantin Asofiei
03:03 AM Database Feature #1953: add conversion support for CREATE BUFFER statement
Committed revision 10248. Ovidiu Maxiniuc
09:07 PM Database Feature #1953: add conversion support for CREATE BUFFER statement
Update 20130303a looks fine, except that the zip file is based at the com directory instead of src. Please fix this,... Eric Faulhaber
11:41 PM Database Feature #1933: add conversion support for certain metadata constructs
Conversion regression testing was successful. Please commit and distribute the 20130305b update. Eric Faulhaber
10:15 PM Database Feature #1933: add conversion support for certain metadata constructs
Code review 20130305a:
Changes look good.
Code review 20130305b:
The change is fine, but a slightly tighter ...
Eric Faulhaber
11:39 PM Database Feature #1668: add support for additional (non-dynamic) database attributes
Update 20130304c has passed conversion regression testing. Please correct the FieldReference header as noted above, ... Eric Faulhaber
09:58 PM Database Feature #1668: add support for additional (non-dynamic) database attributes
Code review 20130304c:
Code changes look fine, but please correct the file header numbering for the last 2 entries...
Eric Faulhaber

03/05/2013

06:32 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Generally, I like it. This will work for some of the cases, but not all cases. Still, it is good enough to go with ... Greg Shah
06:18 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
> How about this approach:
> ...
The approach is working but we need to modify the getter this way for example:
...
Eugenie Lyzenko
05:22 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
> If we have multiple versions of the same function with different numbers of different kind of parameters how we dec... Greg Shah
05:00 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Several data type question for this time:
1. If we have multiple versions of the same function with different numbers...
Eugenie Lyzenko
06:20 PM Database Bug #2077: fix converted table and field name collisions
It looks fine. Check it in and distribute it. Greg Shah
05:16 PM Database Bug #2077: fix converted table and field name collisions
Passed conversion regression testing. Constantin Asofiei
04:18 PM Database Bug #2077: fix converted table and field name collisions
I'm putting this through conversion regression testing. Constantin Asofiei
02:39 PM Database Bug #2077: fix converted table and field name collisions
This update solves collisions for dmo, table, property and column names. It adds a numeric suffix, similar to how tem... Constantin Asofiei
02:05 PM Database Bug #2077: fix converted table and field name collisions
In 4GL, it is possible to have two tables names named @p2j_test@ and @p2j-test@. Also, these field names can be in th... Constantin Asofiei
02:02 PM Database Bug #2077 (Closed): fix converted table and field name collisions
Constantin Asofiei
06:02 PM Base Language Feature #2078: provide support for malformed label names
I'm OK with the code. You can check it in and distribute. Greg Shah
05:15 PM Base Language Feature #2078: provide support for malformed label names
Passed conversion regression testing. Constantin Asofiei
04:18 PM Base Language Feature #2078: provide support for malformed label names
I'm putting this through conversion regression testing. Constantin Asofiei
04:09 PM Base Language Feature #2078: provide support for malformed label names
In 4GL, it is possible to support malformed label names, as in:... Constantin Asofiei
04:03 PM Base Language Feature #2078 (Hold): provide support for malformed label names
Constantin Asofiei
05:50 PM Database Feature #2080: add runtime support for database methods
The following static methods should be removed from AbstractQuery:... Eric Faulhaber
05:44 PM Database Feature #2080: add runtime support for database methods
This issue is for adding runtime support for all the database methods added in issue #1947. For the most part, we on... Eric Faulhaber
05:40 PM Database Feature #2080 (Closed): add runtime support for database methods
Eric Faulhaber
05:30 PM Database Feature #1947: add conversion support for database methods
Update 20130305b hit a snag in conversion regression testing. It did not cause a regression per se, because the chan... Eric Faulhaber
03:55 PM Database Feature #1947: add conversion support for database methods
I tried to update code from bzr now (I did not make any changes since the time I sent update).
Please see result - ...
Vadim Nebogatov
03:49 PM Database Feature #1947: add conversion support for database methods
I made fresh check out today morning and merged manually from updates with adding only my changes. Maybe I missed som... Vadim Nebogatov
03:44 PM Database Feature #1947: add conversion support for database methods
Eric, sorry, but I updated code today from bzr minimum 5 times during the day with bzr update command. Last time imme... Vadim Nebogatov
03:38 PM Database Feature #1947: add conversion support for database methods
Code review 20130305a:
The changes all look good, but rules/convert/literals.rules was out of date with bzr (confl...
Eric Faulhaber
09:41 AM Database Feature #1947: add conversion support for database methods
Updated test cases with expressions Vadim Nebogatov
09:31 AM Database Feature #1947: add conversion support for database methods
Yes, it is true. Tests passed in this case too with the results like
query1.getNext(LockType.LT_EXCLUSIVE, plus(7,...
Vadim Nebogatov
07:43 AM Database Feature #1947: add conversion support for database methods
Vadim,
> are even not compilable.
the correct syntax for you tests is this:...
Constantin Asofiei
07:40 AM Database Feature #1947: add conversion support for database methods
Attached update
vmn_upd20130305a.zip / vmn_upd20130305a_test_cases.zip
is next replacement of update vmn_upd20130...
Vadim Nebogatov
05:24 PM Base Language Feature #1885: fix and add necessary format string support
Yes, using toStringMessage() is a great idea. Greg Shah
05:04 PM Base Language Feature #1885: fix and add necessary format string support
This fixes the conversion problem, still need to expand PutField c'tors to accept character for the format... or, can... Constantin Asofiei
04:38 PM Base Language Feature #1885: fix and add necessary format string support
There is at least one format string problem in the server. Looks like PUT fields can have a dynamic format, and any e... Constantin Asofiei
05:16 PM Database Feature #1967: rework DMO class/interface hierarchy
I'm taking this back, wrong task: this has some regressions in terms that is too aggressive when bracketing the delet... Constantin Asofiei
05:15 PM Database Feature #1967: rework DMO class/interface hierarchy
-Passed conversion regression testing.- Constantin Asofiei
04:18 PM Database Feature #1967: rework DMO class/interface hierarchy
I'm putting this through conversion regression testing. Constantin Asofiei
01:48 PM Database Feature #1967: rework DMO class/interface hierarchy
Fix cases of a FOR EACH block converted to a tt.delete call, in case the FOR EACH is enclosed in a statement - in thi... Constantin Asofiei
04:41 PM Base Language Feature #2079: add missing conversion support for format string
This is for tracking the time for adding conversion support. All comments to be added in the parent #1885 task. Constantin Asofiei
04:40 PM Base Language Feature #2079 (Closed): add missing conversion support for format string
Constantin Asofiei
04:35 PM Base Language Bug #2070 (Closed): BlockManager Action disambiguation
Passed conversion testing and checked into bzr as revision 10244. Greg Shah
03:05 PM Base Language Bug #2070: BlockManager Action disambiguation
I'm conversion testing this now. Greg Shah
02:56 PM Base Language Bug #2070: BlockManager Action disambiguation
Added cs_upd20130305d.zip only with changes from previous update Costin Savin
02:55 PM Base Language Bug #2070: BlockManager Action disambiguation
Commited cs_upd20130305c.zip to bzr as revision number 10243.
Costin Savin
02:34 PM Base Language Bug #2070: BlockManager Action disambiguation
In cs_upd20130305d.zip, please remove the unchanged files from cs_upd20130305c.zip and add a history entry to control... Greg Shah
02:32 PM Base Language Bug #2070: BlockManager Action disambiguation
cs_upd20130305c.zip has passed conversion testing. Check it in and distribute it. I will look at cs_upd20130305d.zi... Greg Shah
02:05 PM Base Language Bug #2070: BlockManager Action disambiguation
Added proposed update Costin Savin
01:11 PM Base Language Bug #2070: BlockManager Action disambiguation
This is a problem indeed, the solution would be to explicitly import the DMO class. Costin Savin
12:23 PM Base Language Bug #2070: BlockManager Action disambiguation
Costin, please double check this, because I think we need to disambiguate this in the opposite direction too, as I th... Constantin Asofiei
11:41 AM Base Language Bug #2070: BlockManager Action disambiguation
I'm conversion testing this now. Greg Shah
11:32 AM Base Language Bug #2070: BlockManager Action disambiguation
Copied a wrong update deleted wrong file and uploaded the correct one Costin Savin
11:27 AM Base Language Bug #2070: BlockManager Action disambiguation
merge Costin Savin
11:08 AM Base Language Bug #2070: BlockManager Action disambiguation
The code looks good. Constantin will be checking in 1 more version of common-progress. Merge with that and we will ... Greg Shah
09:37 AM Base Language Bug #2070: BlockManager Action disambiguation
merge Costin Savin
05:07 AM Base Language Bug #2070: BlockManager Action disambiguation
Added proposed update Costin Savin
07:12 PM Base Language Bug #2070: BlockManager Action disambiguation
Code Review:
1. Please merge up to the latest bzr level.
2. This method:...
Greg Shah
03:46 PM Conversion Tools Bug #2066: brew adds unnecessary comma in method parameter list after comment
This update passes conversion regression testing with comments off (no changes in generated sources), and MAJIC does ... Constantin Asofiei
03:34 PM Base Language Bug #2076: DMO setter fails when parameter is BaseDataType
ExpressionConversionWorker never returns the int type (e.g. ATTR_POLY) but instead will return the wrapper class name... Greg Shah
02:36 PM Base Language Bug #2076: DMO setter fails when parameter is BaseDataType
Trying to get the rules to create a new variable with the same field type to apply only for expression type ATTR_POLY... Costin Savin
11:12 AM Base Language Bug #2069: Accumulator temp table field disambiguation
Greg Shah wrote:
> Check it in and distribute.
Committed to bzr revision 10242.

> Should we still test ca_upd20...
Constantin Asofiei
11:02 AM Base Language Bug #2069: Accumulator temp table field disambiguation
Check it in and distribute.
Should we still test ca_upd20130304b.zip by itself or should we include these other ch...
Greg Shah
10:03 AM Base Language Bug #2069: Accumulator temp table field disambiguation
0305b.zip has passed conversion regression testing. Constantin Asofiei
09:17 AM Base Language Bug #2069: Accumulator temp table field disambiguation
Another side-note for this task: we should identify all missing no-reference cases and code them in common-progress.r... Constantin Asofiei
08:47 AM Base Language Bug #2069: Accumulator temp table field disambiguation
I've fixed the history entry in common-progress.rules. Constantin Asofiei
08:39 AM Base Language Bug #2069: Accumulator temp table field disambiguation
Greg Shah wrote:
> Go ahead and check these in and distribute them. If Eric has concerns we will address them in a ...
Constantin Asofiei
08:29 AM Base Language Bug #2069: Accumulator temp table field disambiguation
Another case of no-reference is:... Constantin Asofiei
08:18 AM Base Language Bug #2069: Accumulator temp table field disambiguation
Go ahead and check these in and distribute them. If Eric has concerns we will address them in a separate distributio... Greg Shah
05:14 AM Base Language Bug #2069: Accumulator temp table field disambiguation
In the end, I ended up testing (using 10237 as baseline, but this should make no difference):
# 05a (INPUT function ...
Constantin Asofiei
11:41 PM Base Language Bug #2069: Accumulator temp table field disambiguation
This makes the INPUT function to produce no-references. About 04c.zip: my test was without 04b.zip update, to better ... Constantin Asofiei
10:48 PM Base Language Bug #2069: Accumulator temp table field disambiguation
With these changes, pmcli/ converts fully. Also, MAJIC converts fully, but there is a CAN-FIND change in a single fil... Constantin Asofiei
07:01 PM Base Language Bug #2069: Accumulator temp table field disambiguation
Does this resolve #1985 note 64 or is this just more fixes on the way to the Mad Hatter's tea party? Greg Shah
10:56 AM Database Feature #1933: add conversion support for certain metadata constructs
This update adds a message to standard console when a duplicate dmo name is detected. Ovidiu Maxiniuc
10:11 AM Database Feature #1933: add conversion support for certain metadata constructs
I only want you to add this feature if it is very fast to implement, since this is not in the critical path. Otherwi... Eric Faulhaber
10:04 AM Database Feature #1933: add conversion support for certain metadata constructs
Should I add the verification? What kind should it be? Just a @System.err/out.print()@ or persisted to logging file ?... Ovidiu Maxiniuc
09:13 AM Database Feature #1933: add conversion support for certain metadata constructs
Ovidiu Maxiniuc wrote:
> Shouldn't we use an automated postfixed name change if some name is already taken? Or at le...
Eric Faulhaber
07:52 AM Database Feature #1933: add conversion support for certain metadata constructs
Fixed java package for metadata tables.
Just a question. I know that the problem is solvable by using hints but if...
Ovidiu Maxiniuc

03/04/2013

06:46 PM Base Language Feature #2050: ATTR_POLY/METH_POLY used as rvalue or in expressions
Passed conversion testing and checked in to bzr as revision 10239. Greg Shah
05:04 PM Base Language Feature #2050: ATTR_POLY/METH_POLY used as rvalue or in expressions
New version of the update with another change to the parser that fixes a problem found in testing the server code. I... Greg Shah
03:32 PM Base Language Feature #2050: ATTR_POLY/METH_POLY used as rvalue or in expressions
#1985 note 96 shows a new problem: DB_REF_NON_STATIC needs to be supported. I have added it to the ECW. It uses con... Greg Shah
04:38 PM Base Language Bug #2069: Accumulator temp table field disambiguation
This fix attempt does the following:
# fixes #2059 's ecf_upd20130303b.zip, to include temp-tables too
# fixes a bu...
Constantin Asofiei
03:59 PM Base Language Bug #2069: Accumulator temp table field disambiguation
Constantin Asofiei wrote:
> This code tests only for BUFFER nodes, and excludes tables, temp-tables, work-tables. Wa...
Eric Faulhaber
03:39 PM Base Language Bug #2069: Accumulator temp table field disambiguation
Some news about the field name disambiguation issue. In SchemaDictionary.promoteEntry, there is this test:... Constantin Asofiei
03:17 PM Base Language Bug #2069: Accumulator temp table field disambiguation
Committed to bzr revision 10238.
These files have changes which are not limitted to just buffer scope:...
Constantin Asofiei
03:01 PM Base Language Bug #2069: Accumulator temp table field disambiguation
Check it it and distribute it. I will make sure runtime regression testing is run separately. What programs should ... Greg Shah
02:48 PM Base Language Bug #2069: Accumulator temp table field disambiguation
Conversion regression testing has finished, the note about runtime regression testing still stands, with the addition... Constantin Asofiei
01:52 PM Base Language Bug #2069: Accumulator temp table field disambiguation
The code looks good.
It also fixes all remaining issues in #1985 notes 93, 104-109 and 111. These programs all co...
Greg Shah
01:27 PM Base Language Bug #2069: Accumulator temp table field disambiguation
Looks like the matching in accumulators needs to be done using the bufname too, attached update does this. I'm puttin... Constantin Asofiei
12:25 PM Base Language Bug #2069: Accumulator temp table field disambiguation
> In my example, both fields have a schemaname of "tt.num" but the bufname will differ ("b1" vs "b2"). Actually, the... Constantin Asofiei
12:18 PM Base Language Bug #2069: Accumulator temp table field disambiguation
I don't think schemaname alone will work.
In my example, both fields have a schemaname of "tt.num" but the bufname...
Greg Shah
12:09 PM Base Language Bug #2069: Accumulator temp table field disambiguation
The 0304a.zip passed conversion regression testing, but there are lots of buffer scope-related changes, as the accum ... Constantin Asofiei
11:41 AM Base Language Bug #2069: Accumulator temp table field disambiguation
If the parser gets the schemaname right, in case of unqualified field and compilable 4GL code, I don't think we will ... Constantin Asofiei
11:15 AM Base Language Bug #2069: Accumulator temp table field disambiguation
The changes look good, though we may have to work off something different than only schemaname.... Greg Shah
10:06 AM Base Language Bug #2069: Accumulator temp table field disambiguation
This update:
* makes the field in accum function to be a no-reference.
* fixes CAN-FIND function, when its WHERE cl...
Constantin Asofiei
09:57 AM Base Language Bug #2069: Accumulator temp table field disambiguation
About the ACCUM no_reference: after I let this be a no_reference, then the "refid" annotation will not be emitted for... Constantin Asofiei
09:41 AM Base Language Bug #2069: Accumulator temp table field disambiguation
Please prepare the ACCUM no_reference and CAN-FIND changes and upload the update ASAP. Both of these seem to be corr... Greg Shah
04:03 PM Database Bug #2059: CAN-FIND clause for a perm table in the RECORD_PHRASE of a temp table, with a FOR EACH...
Good point. Actually, the best is probably just to get rid of the @schemaScope@ variable altogether and use the @glo... Eric Faulhaber
03:53 PM Database Bug #2059: CAN-FIND clause for a perm table in the RECORD_PHRASE of a temp table, with a FOR EACH...
LE: actually, I think the correct test is:... Constantin Asofiei
03:45 PM Database Bug #2059: CAN-FIND clause for a perm table in the RECORD_PHRASE of a temp table, with a FOR EACH...
Eric, your fix in SchemaDictionary I don't think it works for temp-tables, as the following code:... Constantin Asofiei
03:12 PM Database Feature #1933: add conversion support for certain metadata constructs
Ovidiu Maxiniuc wrote:
> You mean that we should use @P2OLookup@ instead of the current @SymbolResolver@ calls ?
...
Eric Faulhaber
01:04 PM Database Feature #1933: add conversion support for certain metadata constructs
> I think this is probably best done in P2OLookup (in the schema package), such that P2OLookup.javaPackage(String his... Ovidiu Maxiniuc
11:07 AM Database Feature #1933: add conversion support for certain metadata constructs
Ovidiu Maxiniuc wrote:
> 4GL has a meta set of tables associated with each database and from the user point of view ...
Eric Faulhaber
02:35 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
> Didn't the static import statement work? I wasn't sure if it would work with enums or not. If it doesn't work, then... Eugenie Lyzenko
02:31 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
> We need to create separate class file for ParmType?
Yes.
> In this case we need to declare ParmType.CHAR ins...
Greg Shah
01:35 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Two questions.
1. We need to create separate class file for ParmType? In this case we need to declare ParmType.CHAR ...
Eugenie Lyzenko
10:51 AM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
This is a high priority for milestone 4 so that we can make sure to generate compilable code. Please implement this ... Greg Shah
01:19 PM Database Feature #1947: add conversion support for database methods
Vadim Nebogatove wrote (in email):
> I tried to make tests today with literal constants. Possible I implemented chan...
Eric Faulhaber
09:44 AM Database Feature #1947: add conversion support for database methods
Vadim Nebogatov wrote:
> I have analyzed one more time. Solution you wrote is useful if both parameters are literals...
Eric Faulhaber
04:05 AM Database Feature #1947: add conversion support for database methods
I have analyzed one more time. Solution you wrote is useful if both parameters are literals. But many combined cases ... Vadim Nebogatov
03:04 AM Database Feature #1947: add conversion support for database methods
I did not notice that Ubuntu Nautilus does not show backup files by default... Vadim Nebogatov
09:48 PM Database Feature #1947: add conversion support for database methods
Code review 20130303a:
* As I noted earlier, please don't include backup files (e.g., @QueryWrapper.java~@) in you...
Eric Faulhaber
12:38 PM Base Language Bug #2076: DMO setter fails when parameter is BaseDataType
Example:... Costin Savin
12:34 PM Base Language Bug #2076 (Closed): DMO setter fails when parameter is BaseDataType
Costin Savin
11:32 AM Base Language Bug #2070: BlockManager Action disambiguation
Added the proposed update Costin Savin
10:54 AM Database Feature #1668: add support for additional (non-dynamic) database attributes
Added @FieldInterface@/@FieldReference.value(NumberType)@. This is related to #2068, note 18.1.
This update must be...
Ovidiu Maxiniuc
10:53 AM Base Language Bug #2075: unknown literals in nested expressions
See #2053 where we are creating a parameter type lookup facility for builtin funcs and methods. Greg Shah
10:20 AM Base Language Bug #2075: unknown literals in nested expressions
> One of the things I was interested in using the signature data for was during expression typing (we could know exac... Constantin Asofiei
09:52 AM Base Language Bug #2075: unknown literals in nested expressions
> Go ahead and commit the change and distribute it.
Committed to bzr revision 10237.
> If I understand properly, ...
Constantin Asofiei
09:46 AM Base Language Bug #2075: unknown literals in nested expressions
Go ahead and commit the change and distribute it.
If I understand properly, we are about to have compile issues wi...
Greg Shah
09:28 AM Base Language Bug #2075: unknown literals in nested expressions
> The question: how much code do we have that is dependent upon this unintended result? I prefer to cleanup the pars... Constantin Asofiei
09:07 AM Base Language Bug #2075: unknown literals in nested expressions
Actually, I am worried that the problem is really in how the parser leaves the tree. A pretty important rule about t... Greg Shah
10:47 AM Database Feature #1967: rework DMO class/interface hierarchy
Unfortunately, at some point we might have to rename the APIs in these interfaces too, which are extended by Buffer i... Constantin Asofiei
10:33 AM Database Feature #1967: rework DMO class/interface hierarchy
This update fixes eventual collisions in dmo interfaces because of @WrappedResource@ interface (@isValid()@ & @isUnkn... Ovidiu Maxiniuc
09:37 AM Database Feature #2000: add conversion support for table and table handle parameters
Got it. I was mis-reading the meaning of the syntax. Greg Shah
09:33 AM Database Feature #2000: add conversion support for table and table handle parameters
> Is there any difference in behavior if you switch the order of the DEF SHARED VAR and DEF PARAMETER (if the DEF SHA... Stanislav Lomany
09:31 AM Database Feature #2000: add conversion support for table and table handle parameters
Is there any difference in behavior if you switch the order of the DEF SHARED VAR and DEF PARAMETER (if the DEF SHARE... Greg Shah
05:39 AM Database Feature #2000: add conversion support for table and table handle parameters
I found that @DEF PARAMETER TABLE-HANDLE FOR th@ where @th@ is a [new] shared variable is handled differently that if... Stanislav Lomany
05:15 AM Database Feature #1953: add conversion support for CREATE BUFFER statement
Added missing create() overloads.
Also reformatted and sorted so that they are more visible/countable.
Fixes compil...
Ovidiu Maxiniuc

03/03/2013

03:40 PM Base Language Bug #2069: Accumulator temp table field disambiguation
Some final notes for today:
# the @CREATE real@ statement produces a free reference, same as a @FIND FIRST real@. If...
Constantin Asofiei
12:32 PM Base Language Bug #2069: Accumulator temp table field disambiguation
Good information in note 3.
1. You have proven that the ACCUM() function parameters are not free references, they ...
Greg Shah
06:40 AM Base Language Bug #2069: Accumulator temp table field disambiguation
First of all, looks like ACCUM function should not produce free-references, because if it did produce, then the code ... Constantin Asofiei
03:28 PM Database Feature #1947: add conversion support for database methods
Attached update vmn_upd20130303a.zip with tests vmn_upd20130303a_test_cases.zip is next replacement of update vmn_upd... Vadim Nebogatov
03:22 PM Database Bug #2059: CAN-FIND clause for a perm table in the RECORD_PHRASE of a temp table, with a FOR EACH...
The attached update is an interim workaround to protect against the NPE so we can get further into conversion. Still... Eric Faulhaber
11:46 AM Base Language Bug #2075: unknown literals in nested expressions
The fix has passed conversion regression testing. Constantin Asofiei
08:06 AM Base Language Bug #2075: unknown literals in nested expressions
P2J fails to convert this case:... Constantin Asofiei
07:22 AM Base Language Bug #2075 (WIP): unknown literals in nested expressions
Constantin Asofiei

03/02/2013

06:11 PM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support
The ges_upd20130302b.zip passed conversion testing and checked in as bzr revision 10233. Greg Shah
05:40 PM Base Language Feature #2074: add CAN-QUERY() and CAN-SET() support
This code provides the conversion support for these builtin functions. It also stubs out the methods in HandleOps. ... Greg Shah
05:38 PM Base Language Feature #2074 (Closed): add CAN-QUERY() and CAN-SET() support
Greg Shah
06:11 PM Database Feature #1947: add conversion support for database methods
The ges_upd20130302a.zip passed conversion testing and checked in as bzr revision 10232. Greg Shah
04:52 PM Database Feature #1947: add conversion support for database methods
As found in #1985 (and documented in note 3 of #1655), the DELETE-RESULT-LIST-ENTRY() method should have been added p... Greg Shah
09:34 AM Database Feature #1947: add conversion support for database methods
Vadim Nebogatov wrote:
> Eric Faulhaber wrote:
> > In convert/literals.rules, rewrite the rules regarding lock type...
Eric Faulhaber
05:23 AM Database Feature #1947: add conversion support for database methods
Eric Faulhaber wrote:
> In convert/literals.rules, rewrite the rules regarding lock type literals (added in the last...
Vadim Nebogatov
12:42 PM Database Feature #1933: add conversion support for certain metadata constructs
For identifying the correct package to be imported I went back on the annotation paths for @pkgname@, @bufname@, @sch... Ovidiu Maxiniuc
02:39 AM Database Bug #2071 (Closed): conversion fails to find attach point for QueryWrapper instance variable decl...
Eric Faulhaber
02:36 AM Database Bug #2071: conversion fails to find attach point for QueryWrapper instance variable declaration
A non-promoted OPEN QUERY in an IF-THEN construct fails to find an attach point to which to graft its QueryWrapper de... Eric Faulhaber
01:25 AM Database Bug #2071 (Closed): conversion fails to find attach point for QueryWrapper instance variable decl...
Eric Faulhaber
08:15 PM Base Language Feature #2050: ATTR_POLY/METH_POLY used as rvalue or in expressions
Passed conversion testing and checked in as bzr revision 10230. Greg Shah

03/01/2013

05:17 PM Base Language Feature #2050: ATTR_POLY/METH_POLY used as rvalue or in expressions
This passed testing, but in further processing of the customer code, another (virtually identical) NPE was encountere... Greg Shah
03:29 PM Base Language Feature #2050: ATTR_POLY/METH_POLY used as rvalue or in expressions
Attached is the fix (and testcase updates) for this case. Based on testing in the 4GL, one can indeed have the retur... Greg Shah
04:05 PM Database Feature #1947: add conversion support for database methods
Attached update vmn_upd20130301c.zip with tests vmn_upd20130301c_test_cases.zip is replacement of update vmn_upd20130... Vadim Nebogatov
12:15 PM Database Feature #1947: add conversion support for database methods
Vadim Nebogatov wrote:
> Yes, I hope
If not, please post what you have at the end of the day so we have the optio...
Eric Faulhaber
11:42 AM Database Feature #1947: add conversion support for database methods
Yes, I hope Vadim Nebogatov
11:22 AM Database Feature #1947: add conversion support for database methods
Vadim Nebogatov wrote:
> Changes in *.rules files. OK, will correct. My impression was that it will be needed for ru...
Eric Faulhaber
10:55 AM Database Feature #1947: add conversion support for database methods
Changes in *.rules files. OK, will correct. My impression was that it will be needed for runtime.
Static queryC...
Vadim Nebogatov
09:40 AM Database Feature #1947: add conversion support for database methods
Code review 20130301a:
* The update is incomplete. I provided detailed instructions on the needed changes to rule...
Eric Faulhaber
09:05 AM Database Feature #1947: add conversion support for database methods
Attached update vmn_upd20130301b.zip with tests vmn_upd20130301b_test_cases.zip
containing fixes for # 1947/ #102: ...
Vadim Nebogatov
08:58 AM Database Feature #1947: add conversion support for database methods
Sorry I have not specified, it was Ovidiu's update. Constantin Asofiei
08:57 AM Database Feature #1947: add conversion support for database methods
I think he means 104. I'm reviewing 103 now. It is not ready; I'll provide detail shortly. Eric Faulhaber
08:50 AM Database Feature #1947: add conversion support for database methods
Constantin Asofiei wrote:
> It passed conversion regression testing, please go ahead and checkin/ distribute.
Do ...
Vadim Nebogatov
08:49 AM Database Feature #1947: add conversion support for database methods
It passed conversion regression testing, please go ahead and checkin/ distribute. Constantin Asofiei
07:16 AM Database Feature #1947: add conversion support for database methods
The code looks good, I'm putting this through conversion regression testing. Constantin Asofiei
07:03 AM Database Feature #1947: add conversion support for database methods
This update removes the unneeded @handle:@ token from the chaining like:... Ovidiu Maxiniuc
03:46 AM Database Feature #1947: add conversion support for database methods
Attached update vmn_upd20130301a.zip with tests vmn_upd20130301a_test_cases.zip containing
1) the conversion and runt...
Vadim Nebogatov
03:42 PM Conversion Tools Bug #2066: brew adds unnecessary comma in method parameter list after comment
WOW! That is very cool. Great job! Greg Shah
03:40 PM Conversion Tools Bug #2066: brew adds unnecessary comma in method parameter list after comment
MAJIC has compiled with comments enabled (and AFAIK this was not possible before this update). Constantin Asofiei
02:48 PM Conversion Tools Bug #2066: brew adds unnecessary comma in method parameter list after comment
Conversion has finished, compiled fully, but there are some regressions in terms of:
# new-lines no longer emitted i...
Constantin Asofiei
01:40 PM Conversion Tools Bug #2066: brew adds unnecessary comma in method parameter list after comment
OK, the server's compilable folders do not seem to report any comment-related errors. I'm putting this through conver... Constantin Asofiei
11:53 AM Conversion Tools Bug #2066: brew adds unnecessary comma in method parameter list after comment
Well done. It looks good. Painful, though. I have to think about this problem a bit to see if there is a way to he... Greg Shah
11:41 AM Conversion Tools Bug #2066: brew adds unnecessary comma in method parameter list after comment
I'm testing this version with the server files which had comment errors, if everything is good I move to conversion r... Constantin Asofiei
09:24 AM Conversion Tools Bug #2066: brew adds unnecessary comma in method parameter list after comment
I'm stopping conversion, a server folder has failed with some other comment related issue. I need to get rewrite at l... Constantin Asofiei
09:13 AM Conversion Tools Bug #2066: brew adds unnecessary comma in method parameter list after comment
I'm running conversion now. Constantin Asofiei
09:12 AM Conversion Tools Bug #2066: brew adds unnecessary comma in method parameter list after comment
I am fine with the changes. If they pass conversion testing, let's go with it. Greg Shah
07:53 AM Conversion Tools Bug #2066: brew adds unnecessary comma in method parameter list after comment
Replaced getNextSibling with ignore-star version. Constantin Asofiei
06:57 AM Conversion Tools Bug #2066: brew adds unnecessary comma in method parameter list after comment
Made next-child-rules to be ignorant of star-comment nodes, I'm putting this through conversion regression testing. Constantin Asofiei
03:14 PM Database Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
Update has passed conversion regression test and is committed to bzr rev. 10228. Eric Faulhaber
08:03 AM Database Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
@defaultBufferHandle@ is pushed up from @TempTable@ to @Buffer@ interface. Ovidiu Maxiniuc
03:04 PM Database Feature #1949: add conversion support for database triggers
This update looks good and has passed conversion regression testing. Please check it into bzr and distribute. Eric Faulhaber
08:31 AM Database Feature #1949: add conversion support for database triggers
Constantin's point is a good one. It looks to me like the parser is fine (of course I like saying that :)).
Can w...
Greg Shah
08:16 AM Database Feature #1949: add conversion support for database triggers
2.1 would be OK only if the ON WRITE statement would work only with table names, but looks like it works with buffer ... Constantin Asofiei
07:59 AM Database Feature #1949: add conversion support for database triggers
Option 2.1 seems most correct to me, because it makes the tree accurately reflect the meaning of the code from the be... Eric Faulhaber
03:29 AM Database Feature #1949: add conversion support for database triggers
... Stanislav Lomany
02:10 PM Base Language Bug #2070: BlockManager Action disambiguation
Code Feedback:
In regard to the converted class names, there are several problems that have to be addressed:
1....
Greg Shah
12:20 PM Base Language Bug #2070: BlockManager Action disambiguation
I haven't reviewed your update, but yes, that approach is OK. I was responding to Constantin's idea about maintainin... Eric Faulhaber
12:14 PM Base Language Bug #2070: BlockManager Action disambiguation
I used isDMOInterface(String) in the defined function usedClassName (core_conversion.xml) from the proposed update to... Costin Savin
12:09 PM Base Language Bug #2070: BlockManager Action disambiguation
BTW, if this is called more than once, we will want to optimize it, because it copies large sets of strings. Eric Faulhaber
12:07 PM Base Language Bug #2070: BlockManager Action disambiguation
...and the attachment. Eric Faulhaber
12:06 PM Base Language Bug #2070: BlockManager Action disambiguation
Here, give this a try. Register P2OAccessWorker in TRPL and call @getAllDMOInterfaceNames()@ to return a set of all ... Eric Faulhaber
11:58 AM Base Language Bug #2070: BlockManager Action disambiguation
Added proposed update Costin Savin
11:31 AM Base Language Bug #2070: BlockManager Action disambiguation
Greg, do we have a way of knowing if a certain name is for a converted class name (associated with the external progr... Constantin Asofiei
11:26 AM Base Language Bug #2070: BlockManager Action disambiguation
Please look at the com.goldencode.p2j.schema.P2OAccessWorker as a better solution than manually parsing the dmo_index... Greg Shah
11:22 AM Base Language Bug #2070: BlockManager Action disambiguation
Please do the following and re-upload:
# rename dmoUsedNames to usedClassNames (idea is, to save all generated class...
Constantin Asofiei
11:07 AM Base Language Bug #2070: BlockManager Action disambiguation
Added proposed update. Solution was to parse the dmo_index.xml file and retrieve the existing dmo names in a global H... Costin Savin
10:13 AM Database Feature #1933: add conversion support for certain metadata constructs
I will go on with this issue, as I am now able to see what's wrong using my project. Ovidiu Maxiniuc
07:50 AM Database Feature #1933: add conversion support for certain metadata constructs
Ovidiu Maxiniuc wrote:
> I exported a sample @_File@ structure (.df) and data (.d) from my test database ...
I ca...
Eric Faulhaber
03:28 AM Database Feature #1933: add conversion support for certain metadata constructs
Eric,
I exported a sample @_File@ structure (.df) and data (.d) from my test database but, for some unknown (to me)...
Ovidiu Maxiniuc
01:01 AM Database Feature #1668: add support for additional (non-dynamic) database attributes
FieldReference.value is missing the value(NumberType) version (subscript can be more than int literals).
PS: and Fie...
Constantin Asofiei

02/28/2013

06:48 PM Base Language Bug #2056 (Closed): null value for an annotation while persisting the AST
Greg Shah
06:47 PM Base Language Bug #2056: null value for an annotation while persisting the AST
Passed conversion testing and is checked into bzr as revision 10226. Greg Shah
05:31 PM Base Language Bug #2056: null value for an annotation while persisting the AST
OK, some findings:
1. Generally, @@@ base-field can only be used in a DISPLAY stmt and in the column_spec of a DEF...
Greg Shah
06:10 PM Base Language Feature #2063: Support negative numbers defined with the "-" on the right side
The lexer cannot easily change its behavior in response to feedback from the parser. This is a core limitation of AN... Greg Shah
04:30 PM Base Language Feature #2063: Support negative numbers defined with the "-" on the right side
We have a case where the @999.99-@ literal is converted to @new date("999.99-")@ instead of decimal:... Constantin Asofiei
04:41 PM Database Feature #1947: add conversion support for database methods
I'm posting these here too, from #2068:
More errors related to database methods:...
Constantin Asofiei
04:02 PM Database Feature #1947: add conversion support for database methods
Vadim Nebogatov wrote:
> It works with 0 without errors too; - as far as I understood
>
> ...
Eric Faulhaber
03:11 PM Database Feature #1947: add conversion support for database methods
I tested in 4GL the following... Vadim Nebogatov
02:22 PM Database Feature #1947: add conversion support for database methods
One correction to my last posting:
In the case where the first argument is NOT one of the lock literals, AND we ha...
Eric Faulhaber
02:05 PM Database Feature #1947: add conversion support for database methods
OK, then we must emulate this error handling at runtime, which means we need the following APIs:... Eric Faulhaber
01:13 PM Database Feature #1947: add conversion support for database methods
I have tested in 4GL the following... Vadim Nebogatov
11:59 AM Database Feature #1947: add conversion support for database methods
Constantin Asofiei wrote:
> > Again, if the literals don't match the well-known compiler constants, Progress must de...
Eric Faulhaber
11:36 AM Database Feature #1947: add conversion support for database methods
> Again, if the literals don't match the well-known compiler constants, Progress must default to some lock behavior d... Constantin Asofiei
11:34 AM Database Feature #1947: add conversion support for database methods
Constantin Asofiei wrote:
> You forgot these:
> ...
Eric Faulhaber
11:14 AM Database Feature #1947: add conversion support for database methods
Eric Faulhaber wrote:
> Yes, please hold this update for the moment.
>
> I think we can cover all cases with:
> ...
Constantin Asofiei
11:08 AM Database Feature #1947: add conversion support for database methods
Yes, please hold this update for the moment.
I think we can cover all cases with:...
Eric Faulhaber
10:45 AM Database Feature #1947: add conversion support for database methods
Variant with 100+ methods (integer, int64, long, LockType) is ready
GET-NEXT (KW_GET_NEXT)
GET-PREV (KW_GET_PREV...
Vadim Nebogatov
10:41 AM Database Feature #1947: add conversion support for database methods
> OK, but wouldn't the @i + 1@ expression be converted to @plus(i, 1)@ (which returns an integer wrapper instance), s... Constantin Asofiei
10:36 AM Database Feature #1947: add conversion support for database methods
Constantin Asofiei wrote:
> > Am I missing something?
> yes, you can pass vars/expressions to these parameters, not...
Eric Faulhaber
10:22 AM Database Feature #1947: add conversion support for database methods
> Am I missing something?
yes, you can pass vars/expressions to these parameters, not just literals:...
Constantin Asofiei
10:19 AM Database Feature #1947: add conversion support for database methods
Constantin Asofiei wrote:
> Vadim Nebogatov wrote:
> > If we want to reuse current(LockType lockType) we will need ...
Eric Faulhaber
10:07 AM Database Feature #1947: add conversion support for database methods
Eric Faulhaber wrote:
> I don't understand this. Why can't we use NumberType to reduce the explosion of APIs? We a...
Constantin Asofiei
10:05 AM Database Feature #1947: add conversion support for database methods
Constantin Asofiei wrote:
> where both parameters are optional, and nowait appears only if first is set. We can redu...
Eric Faulhaber
08:51 AM Database Feature #1947: add conversion support for database methods
Vadim Nebogatov wrote:
> If we want to reuse current(LockType lockType) we will need to create LockType from other ty...
Constantin Asofiei
08:49 AM Database Feature #1947: add conversion support for database methods
If we want to reuse current(LockType lockType) we will need to create LockType from other types including long Vadim Nebogatov
08:40 AM Database Feature #1947: add conversion support for database methods
If you set the parameter to java native long, then all native int values will be accepted, so no casting is needed. I... Constantin Asofiei
08:39 AM Database Feature #1947: add conversion support for database methods
Will we cast long to int before using LockType.fromInt(int type)? Vadim Nebogatov
08:33 AM Database Feature #1947: add conversion support for database methods
Vadim Nebogatov wrote:
> LockType aggregates lock and wait statuses, what is the sense of using it with other parame...
Constantin Asofiei
08:26 AM Database Feature #1947: add conversion support for database methods
LockType aggregates lock and wait statuses, what is the sense of using it with other parameters, especially with one ... Vadim Nebogatov
08:14 AM Database Feature #1947: add conversion support for database methods
The syntax for this method would be (example for GET-NEXT):... Constantin Asofiei
08:03 AM Database Feature #1947: add conversion support for database methods
Constantin Asofiei wrote:
> Vadim Nebogatov wrote:
> > OK, good. What do you think about #68 (getNext(LockType lock...
Vadim Nebogatov
07:35 AM Database Feature #1947: add conversion support for database methods
LE: when I say no work needed, I refer to the lock types. You will still need getNext(LockType) version to be added. Constantin Asofiei
07:34 AM Database Feature #1947: add conversion support for database methods
Vadim Nebogatov wrote:
> OK, good. What do you think about #68 (getNext(LockType lockType))?
Actually, NO-LOCK and ...
Constantin Asofiei
06:38 AM Database Feature #1947: add conversion support for database methods
OK, good. What do you think about #68 (getNext(LockType lockType))? Vadim Nebogatov
06:11 AM Database Feature #1947: add conversion support for database methods
> According doc, lock is mandatory, no-wait is optional:
>
> GET-NEXT ( NO-LOCK| SHARE-LOCK [, NO-WAIT] | EXCLUSIV...
Constantin Asofiei
06:00 AM Database Feature #1947: add conversion support for database methods
Eric Faulhaber wrote:
> Ignore my last post; I mis-read the documentation. NO-LOCK is the default if not specified...
Vadim Nebogatov
03:51 AM Database Feature #1947: add conversion support for database methods
I don't understand... stupid chrome or redmine ? Ovidiu Maxiniuc
03:50 AM Database Feature #1947: add conversion support for database methods
I think ... Ovidiu Maxiniuc
03:47 AM Database Feature #1947: add conversion support for database methods
The same question concerning getNext parameters. Do we really need method with signature using P2J type LockType?
...
Vadim Nebogatov
03:40 AM Database Feature #1947: add conversion support for database methods
The question: BUFFER-COMPARE/ BUFFER-COPY support also should be corrected. May I do this in the same update?
BUF...
Vadim Nebogatov
04:15 PM Conversion Tools Bug #2066: brew adds unnecessary comma in method parameter list after comment
The conclusion for today, after trying a scoping approach to solve some nested calls issues is this, in brew phase (a... Constantin Asofiei
09:10 AM Conversion Tools Bug #2066: brew adds unnecessary comma in method parameter list after comment
I still have some regressions in it, I'm testing and will re-upload. Constantin Asofiei
09:09 AM Conversion Tools Bug #2066: brew adds unnecessary comma in method parameter list after comment
The code looks fine. And that is some testcase! It made me laugh to read it. Well done. Greg Shah
08:41 AM Conversion Tools Bug #2066: brew adds unnecessary comma in method parameter list after comment
This fixes these cases:... Constantin Asofiei
05:12 AM Conversion Tools Bug #2066: brew adds unnecessary comma in method parameter list after comment
I believe this was also addressed in the #1450. Unfortunately it was not finalized. Ovidiu Maxiniuc
03:01 AM Conversion Tools Bug #2066: brew adds unnecessary comma in method parameter list after comment
Fix attempt for star comments mixed with children of IF, method arguments, and others. Will test with MAJIC and some ... Constantin Asofiei
01:44 AM Conversion Tools Bug #2066: brew adds unnecessary comma in method parameter list after comment
I suggest to disable comments, run conversion in the good directories and compile again, to uncover non-comment probl... Constantin Asofiei
01:21 AM Conversion Tools Bug #2066 (WIP): brew adds unnecessary comma in method parameter list after comment
Constantin Asofiei
03:33 PM Database Feature #1933: add conversion support for certain metadata constructs
Correct, we need the import.
Ovidiu was looking at this at the end of the day today, I guess he will continue tomo...
Constantin Asofiei
02:49 PM Database Feature #1933: add conversion support for certain metadata constructs
Ah, good point. So, we need to emit an import statement for ...dmo._meta.*, right? Are you taking this, or do you w... Eric Faulhaber
02:43 PM Database Feature #1933: add conversion support for certain metadata constructs
The metadata tables are emitted to the dmo._meta package, but all buffers referring meta tables are still converted t... Constantin Asofiei
03:31 PM Database Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
Note that the defaultBufferHandle API I think it needs to be added to the Buffer interface too, because there are com... Constantin Asofiei
02:51 PM Base Language Bug #2070: BlockManager Action disambiguation
Keep in mind that BUFFER_SCOPE is for DMOs beeing used by the current program, and not all the existing DMOs. I think... Constantin Asofiei
02:35 PM Base Language Bug #2070: BlockManager Action disambiguation
Can the "classname" annotation of BUFFER_SCOPE be used safely to get that checked? Costin Savin
02:12 PM Base Language Bug #2070: BlockManager Action disambiguation
Costin, looks like we need another check: if there is a DMO class with the Action name, then qualify Action with Bloc... Constantin Asofiei
11:47 AM Base Language Bug #2070: BlockManager Action disambiguation
This is fine for now. Ultimately, we will need to do this on a more global scale for all names. Please get it conver... Greg Shah
11:39 AM Base Language Bug #2070: BlockManager Action disambiguation
Added proposed update Costin Savin
10:43 AM Base Language Bug #2070: BlockManager Action disambiguation
Do you think it's better to replace Action.<enum_val> with BlockManager.Action.<enum_val> allways or check file name ... Costin Savin
10:40 AM Base Language Bug #2070: BlockManager Action disambiguation
When we have a progress file named action and it contains a block which will emit a reference to the Action enum of t... Costin Savin
10:35 AM Base Language Bug #2070 (Closed): BlockManager Action disambiguation
Costin Savin
11:02 AM Base Language Bug #2069: Accumulator temp table field disambiguation
After the note 75 in the 1985, looks like this is a true buffer disambiguation problem, which can be duplicated using... Constantin Asofiei
06:09 AM Base Language Bug #2069: Accumulator temp table field disambiguation
For the following testcase we define a temp table fit a field name that already exists in a permanent table and use i... Costin Savin
05:58 AM Base Language Bug #2069 (Closed): Accumulator temp table field disambiguation
If we create a temp table with a field name that coincides with a field from an existent permanent table and use accu... Costin Savin
09:06 AM Database Feature #1949: add conversion support for database triggers
> do you have any idea why this happens ? Is this intentional ?
No. No. I'll take it as my top priority.
Stanislav Lomany
08:25 AM Database Feature #1949: add conversion support for database triggers
During the investigations for #1985, note 69, resulted that a possible bug is in the parser.
The following code:
<p...
Ovidiu Maxiniuc
01:48 AM Database Feature #1588: add conversion and runtime support for embedded SQL
20130227a update has passed regression testing and is committed to bzr rev. 10225. Eric Faulhaber
12:40 AM Database Feature #1588: add conversion and runtime support for embedded SQL
Attached update fixes a defect during annotations processing. Eric Faulhaber

02/27/2013

06:13 PM Base Language Feature #2050: ATTR_POLY/METH_POLY used as rvalue or in expressions
A new context analysis problem has been found in #1985 (see note 63). The 2nd operand of the PLUS is a FIELD_DEC typ... Greg Shah
05:43 PM Base Language Bug #2056: null value for an annotation while persisting the AST
One other point: I think if we get the parser right, the downstream processing may be much simpler. Today, we have t... Greg Shah
05:41 PM Base Language Bug #2056: null value for an annotation while persisting the AST
After looking at this in detail, it is clear that this is something that I need to work on. Both of you should work ... Greg Shah
10:32 AM Base Language Bug #2056: null value for an annotation while persisting the AST
This code works in P2J:... Greg Shah
09:47 AM Base Language Bug #2056: null value for an annotation while persisting the AST
I was trying to force the rules to see the var definition hidden in the format_phrase node, and emit widget + var for... Constantin Asofiei
09:36 AM Base Language Bug #2056: null value for an annotation while persisting the AST
I can help with this.
Constantin: do you have any other findings to report?
We do support @-base fields alrea...
Greg Shah
05:17 PM Database Feature #2000: add conversion support for table and table handle parameters
I uncommited my last commit. Stanislav Lomany
05:13 PM Database Feature #2000: add conversion support for table and table handle parameters
> Please distribute the Config change as a separate update zip file BUT at the SAME TIME as the svl_upd20130226a.zip.... Stanislav Lomany
05:04 PM Database Feature #2000: add conversion support for table and table handle parameters
Please distribute the Config change as a separate update zip file BUT at the SAME TIME as the svl_upd20130226a.zip. ... Greg Shah
04:37 PM Database Feature #2000: add conversion support for table and table handle parameters
Actually, I think we're OK here. All the failures are in the Config class, which is hand-written and will need to be... Eric Faulhaber
03:47 PM Database Feature #2000: add conversion support for table and table handle parameters
Majic did not compile after this update. Please see #2067 for the results. Eric Faulhaber
03:08 PM Database Feature #2000: add conversion support for table and table handle parameters
> I'll do it here. Do you expect any differences? If I find anything unusual, I'll ask.
TABLE parameters should us...
Stanislav Lomany
02:29 PM Database Feature #2000: add conversion support for table and table handle parameters
I'll do it here. Do you expect any differences? If I find anything unusual, I'll ask. Eric Faulhaber
02:17 PM Database Feature #2000: add conversion support for table and table handle parameters
> Have you run conversion on Majic with this to check for unexpected changes?
No. I can run, but it will take 2.5 h.
Stanislav Lomany
02:10 PM Database Feature #2000: add conversion support for table and table handle parameters
Have you run conversion on Majic with this to check for unexpected changes? Eric Faulhaber
02:07 PM Database Feature #2000: add conversion support for table and table handle parameters
Everything except SHARED variables for TABLE-HANDLE FOR. I recommend to distribute the remaining part later as a sepa... Stanislav Lomany
12:11 AM Database Feature #2000: add conversion support for table and table handle parameters
Stanislav Lomany wrote:
> Heh, it look like BUFFER parameter is misconverted, but not because of me:
>
> [...]
...
Eric Faulhaber
07:23 PM Database Feature #2000: add conversion support for table and table handle parameters
Fix for #2. Stanislav Lomany
03:53 PM Database Feature #1947: add conversion support for database methods
om_upd20130227c.zip has passed conversion testing and is checked into bzr as revision 10223. Greg Shah
02:17 PM Database Feature #1947: add conversion support for database methods
The om_upd20130227b.zip is close, but I have made a couple of changes to the code. The post-rules section is moved t... Greg Shah
01:29 PM Database Feature #1947: add conversion support for database methods
Ignore my last post; I mis-read the documentation. NO-LOCK is the default if not specified. So, it seems we will n... Eric Faulhaber
01:25 PM Database Feature #1947: add conversion support for database methods
Correction: I don't think we'll need @P2JQuery.getNext()@ (only @P2JQuery.getNext(LockType lockType)@); seems the 4... Eric Faulhaber
01:14 PM Database Feature #1947: add conversion support for database methods
Vadim, please fix the query handle GET-* return type problem, as described in #1985, note 61 (repeated below for conv... Eric Faulhaber
12:37 PM Database Feature #1947: add conversion support for database methods
This update fixes generation of @LockType@ literals into converted java source.
Ovidiu Maxiniuc
12:04 PM Database Feature #1947 (WIP): add conversion support for database methods
Needed to re-open this for some conversion corrections to query methods GET-NEXT, GET-FIRST, etc. Please see note 61... Eric Faulhaber
02:06 PM Conversion Tools Bug #2066: brew adds unnecessary comma in method parameter list after comment
On a whim last night, I tried to compile the partially converted customer app project, and quickly hit an "illegal st... Eric Faulhaber
01:59 PM Conversion Tools Bug #2066 (Closed): brew adds unnecessary comma in method parameter list after comment
Eric Faulhaber
01:48 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Passed runtime regression testing and is checked into bzr as revision 10222. Greg Shah
01:45 PM Database Feature #1949: add conversion support for database triggers
Passed conversion testing and is checked in as bzr revision 10221. Greg Shah
12:16 PM Database Feature #1949: add conversion support for database triggers
Conversion testing passed. Please check in the update and distribute it. Greg Shah
09:45 AM Database Feature #1949: add conversion support for database triggers
I have started conversion testing. Greg Shah
09:41 AM Database Feature #1949: add conversion support for database triggers
The code looks OK. We need to conversion test it. Greg Shah
09:40 AM Database Feature #1949: add conversion support for database triggers
Indeed, the annotations are not set unless some variables are first declared. And, because in our sample the block is... Ovidiu Maxiniuc
09:19 AM Database Feature #1949: add conversion support for database triggers
Looks like for trigger blocks, the undoable counter are not initialized (written as annotation).
The attached propos...
Ovidiu Maxiniuc
05:24 AM Database Feature #1949: add conversion support for database triggers
Problem with DB triggers in server project:... Constantin Asofiei
12:14 PM Base Language Bug #2065: ambiguity in date/decimal literals that is not handled properly by the ProgressLexer
For details, please see notes 6 and 7 of #2063. Greg Shah
12:13 PM Base Language Bug #2065 (Closed): ambiguity in date/decimal literals that is not handled properly by the Progre...
Greg Shah
12:12 PM Base Language Feature #2063 (Closed): Support negative numbers defined with the "-" on the right side
Greg Shah
11:39 AM Base Language Feature #2063: Support negative numbers defined with the "-" on the right side
Commited to bzr as revision number 10220. Costin Savin
11:17 AM Base Language Feature #2063: Support negative numbers defined with the "-" on the right side
Has passed conversion regression testing (no changes in generated sources), please check in and distribute. Constantin Asofiei
09:30 AM Base Language Feature #2063: Support negative numbers defined with the "-" on the right side
I'm OK with it. Put it through conversion testing. Greg Shah
09:28 AM Base Language Feature #2063: Support negative numbers defined with the "-" on the right side
Added proposed update Costin Savin
09:08 AM Base Language Feature #2063: Support negative numbers defined with the "-" on the right side
The coding changes look OK. Moving the sign to the left was what I was going to propose. Make sure you remove the e... Greg Shah
09:06 AM Base Language Feature #2063: Support negative numbers defined with the "-" on the right side
We must be very careful here.... Greg Shah
08:18 AM Base Language Feature #2063: Support negative numbers defined with the "-" on the right side
Please test with these cases too:... Constantin Asofiei
08:02 AM Base Language Feature #2063: Support negative numbers defined with the "-" on the right side
Added proposed update which corrects the assignment. Costin Savin
06:44 AM Base Language Feature #2063: Support negative numbers defined with the "-" on the right side
Update looks good, this is going through conversion regression testing now. Constantin Asofiei
06:13 AM Base Language Feature #2063: Support negative numbers defined with the "-" on the right side
This update fixes conversion side but there is still work to do to have the correct value set. Costin Savin
04:37 AM Base Language Feature #2063: Support negative numbers defined with the "-" on the right side
Statements like: ... Costin Savin
04:31 AM Base Language Feature #2063 (Closed): Support negative numbers defined with the "-" on the right side
Costin Savin
11:53 AM Database Feature #1668: add support for additional (non-dynamic) database attributes
Discussion moved from emails.
---
Eric,
As far as I understood, Ovidiu is already busy with BUFFER-VALUE r...
Vadim Nebogatov
10:35 AM Base Language Bug #2061: unreachable code is too aggressive when shared vars are used
Greg Shah wrote:
> Everything looks good here, except the copyright dates in the new ruleset. You can check in a fi...
Constantin Asofiei
09:09 AM Base Language Bug #2061 (Closed): unreachable code is too aggressive when shared vars are used
Everything looks good here, except the copyright dates in the new ruleset. You can check in a fix without any furthe... Greg Shah
08:00 AM Base Language Bug #2061 (Review): unreachable code is too aggressive when shared vars are used
This has passed conversion regression testing on MAJIC, no resurfaced dead-code.
Committed to bzr revision 10218.
Constantin Asofiei
06:28 AM Base Language Bug #2061: unreachable code is too aggressive when shared vars are used
I'm reposting cause I had a left behind printfln. Constantin Asofiei
06:11 AM Base Language Bug #2061: unreachable code is too aggressive when shared vars are used
My reachable processing was too aggressive, I'm putting this into conversion regression testing. Constantin Asofiei
08:09 PM Base Language Bug #2061: unreachable code is too aggressive when shared vars are used
I've checked converted sources, there is some resurrected dead-code in MAJIC that should not affect runtime; MAJIC di... Constantin Asofiei
07:02 PM Base Language Bug #2061: unreachable code is too aggressive when shared vars are used
renamed to not conflict... Constantin Asofiei
07:00 PM Base Language Bug #2061: unreachable code is too aggressive when shared vars are used
This code fixes this testcase, I will test the server file and regression conversion testing. Constantin Asofiei
12:07 AM Database Bug #2062 (Closed): buffer parameter names doubled up, not included in RecordBuffer.openScope() call
The following test:... Eric Faulhaber
12:01 AM Database Bug #2062 (Closed): buffer parameter names doubled up, not included in RecordBuffer.openScope() call
Eric Faulhaber
08:00 PM Base Language Bug #2060 (Closed): forward function definitions that include a parameter name can "fixup" missin...
Greg Shah
08:00 PM Base Language Bug #2060: forward function definitions that include a parameter name can "fixup" missing paramet...
Passed conversion and is checked into bzr as revision 10216. Greg Shah

02/26/2013

06:53 PM Database Feature #2000: add conversion support for table and table handle parameters
> In regards to issue number 4, can you explain what the code in th-proc.p is supposed to do?
> This code seems like...
Stanislav Lomany
06:08 PM Database Feature #2000: add conversion support for table and table handle parameters
Heh, it look like BUFFER parameter is misconverted, but not because of me:... Stanislav Lomany
05:33 PM Database Feature #2000: add conversion support for table and table handle parameters
> Hm...actually, a BUFFER parameter on a temp-table won't cause a call to TemporaryBuffer.associate. Is there still ... Stanislav Lomany
05:28 PM Database Feature #2000: add conversion support for table and table handle parameters
Stanislav Lomany wrote:
> > What about BUFFER parameters on temp-tables?
>
> Yes, I missed this type of parameter...
Eric Faulhaber
04:58 PM Database Feature #2000: add conversion support for table and table handle parameters
> What about BUFFER parameters on temp-tables?
Yes, I missed this type of parameters when I was analyzing the impa...
Stanislav Lomany
04:56 PM Database Feature #2000: add conversion support for table and table handle parameters
Stanislav Lomany wrote:
> >In record_scoping.rules, you changed the bufclassname annotation to TableParameter from T...
Eric Faulhaber
04:47 PM Database Feature #2000: add conversion support for table and table handle parameters
In regards to issue number 4, can you explain what the code in th-proc.p is supposed to do?... Greg Shah
04:43 PM Database Feature #2000: add conversion support for table and table handle parameters
>In record_scoping.rules, you changed the bufclassname annotation to TableParameter from Temporary. Isn't that going ... Stanislav Lomany
04:37 PM Database Feature #2000: add conversion support for table and table handle parameters
In record_scoping.rules, you changed the bufclassname annotation to TableParameter from Temporary. Isn't that going ... Eric Faulhaber
04:12 PM Database Feature #2000: add conversion support for table and table handle parameters
> Did you intend to remove this from the define_stmt rule in progress.g?
Yes. I don't know why it was there, proba...
Stanislav Lomany
04:09 PM Database Feature #2000: add conversion support for table and table handle parameters
Did you intend to remove this from the define_stmt rule in progress.g?... Eric Faulhaber
04:08 PM Database Feature #2000: add conversion support for table and table handle parameters
#1 - yes, working on it
#2 - emit TableParameter when calling a function, working on it
#3 - yes, it works fine
#4...
Stanislav Lomany
04:00 PM Database Feature #2000: add conversion support for table and table handle parameters
Stanislav Lomany wrote:
> What remains is:
> 1. procedure TABLE-HANDLE calls using TableParameters, calling side - ...
Eric Faulhaber
03:44 PM Database Feature #2000: add conversion support for table and table handle parameters
I'll add javadocs later. Stanislav Lomany
01:19 PM Database Feature #2000: add conversion support for table and table handle parameters
Attached is the parser change to accept the APPEND syntax on a function call. Greg Shah
06:37 PM Base Language Bug #2061: unreachable code is too aggressive when shared vars are used
I think the solution is to not remove vars/buffers/etc marked as unreachable if there are reachable nodes with a refi... Constantin Asofiei
06:00 PM Base Language Bug #2061: unreachable code is too aggressive when shared vars are used
unreachable code is removed and with it defined vars. following conversion fails:... Constantin Asofiei
05:58 PM Base Language Bug #2061 (Closed): unreachable code is too aggressive when shared vars are used
Constantin Asofiei
05:56 PM User Interface Feature #2058 (Closed): COLOR DISPLAY .. FIELD statement fails
Eric Faulhaber
04:20 PM User Interface Feature #2058: COLOR DISPLAY .. FIELD statement fails
Committed to bzr revision 10214. Constantin Asofiei
03:58 PM User Interface Feature #2058: COLOR DISPLAY .. FIELD statement fails
There is a buffer scope change in so/serv53-r.p for buffer co-bnchmrk, but this is expected, as an UNDERLINE statemen... Constantin Asofiei
01:57 PM User Interface Feature #2058: COLOR DISPLAY .. FIELD statement fails
The changes look good, I'm putting this into conversion regression testing. Constantin Asofiei
01:23 PM User Interface Feature #2058: COLOR DISPLAY .. FIELD statement fails
Added proposed update Costin Savin
12:57 PM User Interface Feature #2058: COLOR DISPLAY .. FIELD statement fails
The following statements work the same as COLOR DISPLAY statement (no buffer is used):... Constantin Asofiei
11:59 AM User Interface Feature #2058: COLOR DISPLAY .. FIELD statement fails
Statements like :
@COLOR DISPLAY red book.price.@
This fails with:...
Costin Savin
11:57 AM User Interface Feature #2058 (Closed): COLOR DISPLAY .. FIELD statement fails
Costin Savin
05:55 PM Database Bug #2057 (Closed): buffer unique name disambiguation (separator problems)
Eric Faulhaber
02:16 PM Database Bug #2057: buffer unique name disambiguation (separator problems)
Passed conversion regression testing, committed to bzr revision 10213. Constantin Asofiei
02:13 PM Database Bug #2057: buffer unique name disambiguation (separator problems)
attached correct update, previous one was for another task (will delete it) Constantin Asofiei
02:08 PM Database Bug #2057: buffer unique name disambiguation (separator problems)
The conversion regression testing has passed, the only diffs were related to instance field order (RecordBuffer.defin... Constantin Asofiei
12:15 PM Database Bug #2057: buffer unique name disambiguation (separator problems)
Constantin Asofiei wrote:
> Eric, one more question: if you can, please explain why BufferScopeWorker.getBuffer atte...
Eric Faulhaber
11:45 AM Database Bug #2057: buffer unique name disambiguation (separator problems)
Update: with the BuffescScopeWorker.getBuffer changed I mentioned earlier, conversion of app folder goes through all ... Constantin Asofiei
11:20 AM Database Bug #2057: buffer unique name disambiguation (separator problems)
Eric, one more question: if you can, please explain why BufferScopeWorker.getBuffer attempts to match the buffer usin... Constantin Asofiei
11:00 AM Database Bug #2057: buffer unique name disambiguation (separator problems)
Eric, the code converts because our test db is named "p2j_test", with an underscore... I had to change the DB name to... Constantin Asofiei
10:59 AM Database Bug #2057: buffer unique name disambiguation (separator problems)
I realize you're the assignee for this, but it looked like it might be related to what I fixed last night, so I conve... Eric Faulhaber
10:10 AM Database Bug #2057: buffer unique name disambiguation (separator problems)
We have a case where an existing buffer defined for a table, like:... Constantin Asofiei
10:00 AM Database Bug #2057 (Closed): buffer unique name disambiguation (separator problems)
Constantin Asofiei
05:54 PM Database Feature #2055 (Closed): RECID AND ROWID IN WHERE CLAUSE
Eric Faulhaber
12:37 PM Database Feature #2055: RECID AND ROWID IN WHERE CLAUSE
Commited to bzr as revision 10212. Costin Savin
12:26 PM Database Feature #2055: RECID AND ROWID IN WHERE CLAUSE
Conversion regression testing has passed, please check in and distribute update. Constantin Asofiei
11:08 AM Database Feature #2055: RECID AND ROWID IN WHERE CLAUSE
Eliminated the problems from previous update Costin Savin
10:17 AM Database Feature #2055: RECID AND ROWID IN WHERE CLAUSE
Beside the header in RecidExpression (where you reference RowidExpression), I don't see any problems. I'm putting thi... Constantin Asofiei
10:14 AM Database Feature #2055: RECID AND ROWID IN WHERE CLAUSE
I'm reviewing this now. Constantin Asofiei
09:59 AM Database Feature #2055: RECID AND ROWID IN WHERE CLAUSE
Derived a case from that for recid
Added proposed update.
Costin Savin
09:11 AM Database Feature #2055: RECID AND ROWID IN WHERE CLAUSE
Costin, use this test:... Constantin Asofiei
08:53 AM Database Feature #2055: RECID AND ROWID IN WHERE CLAUSE
Is there any case for RECID I can use?
For ROWID I testedn the changes with something like @FIND FIRST book WHERE TO...
Costin Savin
05:01 AM Database Feature #2055: RECID AND ROWID IN WHERE CLAUSE
Next error is in .../vcpl/daqueau0.p:... Costin Savin
04:59 AM Database Feature #2055 (Closed): RECID AND ROWID IN WHERE CLAUSE
Costin Savin
05:53 PM Database Bug #2052 (Closed): conversion error resolving master temp-table buffer
Eric Faulhaber
07:48 PM Database Bug #2052: conversion error resolving master temp-table buffer
This update has passed conversion regression testing and is checked into bzr revision 10205. Eric Faulhaber
05:01 PM Base Language Feature #1884: add some of the v10 data types and core built-ins
Passed conversion regression testing, committed to bzr revision 10215. Constantin Asofiei
03:25 PM Base Language Feature #1884: add some of the v10 data types and core built-ins
The server project has a case of:... Constantin Asofiei
04:15 PM Base Language Bug #2060: forward function definitions that include a parameter name can "fixup" missing paramet...
Attached is the update that resolves this issue. It will duplicate the non-forward function definition's buffer para... Greg Shah
02:58 PM Base Language Bug #2060: forward function definitions that include a parameter name can "fixup" missing paramet...
I tested various combinations of other parameter types:
- the regular AS "primitive" types (CHAR, INT, LOGICAL...)...
Greg Shah
12:55 PM Base Language Bug #2060: forward function definitions that include a parameter name can "fixup" missing paramet...
In #1985 (see notes 29, 36 - 43 in that task) we found that forward function definitions that include a parameter nam... Greg Shah
12:52 PM Base Language Bug #2060 (Closed): forward function definitions that include a parameter name can "fixup" missin...
Greg Shah
02:36 PM Base Language Bug #2056: null value for an annotation while persisting the AST
The NPE is thrown because the function "copy_as_widget" attempts to duplicate an incomplete (missing "getter" annotat... Ovidiu Maxiniuc
10:13 AM Base Language Bug #2056: null value for an annotation while persisting the AST
Ovidiu, for now try and fix the "display c @ b as datatype" case, leave that for later. Constantin Asofiei
10:12 AM Base Language Bug #2056: null value for an annotation while persisting the AST
I looked into manuals about the @base-field specification, but they only describe how data is displayed into the resp... Ovidiu Maxiniuc
08:25 AM Base Language Bug #2056: null value for an annotation while persisting the AST
Note that the following case is converted correctly by P2J:... Constantin Asofiei
08:17 AM Base Language Bug #2056: null value for an annotation while persisting the AST
This is a task that tracks the issues reported by Eric in #1985, note 19.
I tried to eliminate the issue by pinpoint...
Ovidiu Maxiniuc
08:05 AM Base Language Bug #2056 (Closed): null value for an annotation while persisting the AST
Ovidiu Maxiniuc
12:45 PM Database Bug #2059 (WIP): CAN-FIND clause for a perm table in the RECORD_PHRASE of a temp table, with a FO...
The following code fails at conversion time:... Constantin Asofiei
12:43 PM Database Bug #2059 (Closed): CAN-FIND clause for a perm table in the RECORD_PHRASE of a temp table, with a...
Constantin Asofiei
12:14 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
I have updated the p2jpl.ddr and have applied it to staging. It has no conversion impact, only runtime. Runtime regr... Greg Shah
12:13 PM Base Language Feature #2050: ATTR_POLY/METH_POLY used as rvalue or in expressions
Passed conversion testing and is checked in as bzr revision 10211. Runtime recursion testing is deferred. Greg Shah
10:57 AM Base Language Feature #2050: ATTR_POLY/METH_POLY used as rvalue or in expressions
The issue is caused by the over-simplistic recursion protection in our context analysis. In addition, even in the ca... Greg Shah
10:53 AM Base Language Feature #2050: ATTR_POLY/METH_POLY used as rvalue or in expressions
From #1985:
ra/ folder fails with:...
Greg Shah
03:42 AM Base Language Feature #2050: ATTR_POLY/METH_POLY used as rvalue or in expressions
> Somehow, the improved expression typing changes the INPUT FUNC_POLY processing. As far as I know, these are equiva... Constantin Asofiei
08:52 PM Base Language Feature #2050: ATTR_POLY/METH_POLY used as rvalue or in expressions
I believe this is passing conversion testing.
The following diffs are present:...
Greg Shah
07:50 PM Base Language Feature #2050: ATTR_POLY/METH_POLY used as rvalue or in expressions
Yes, it does seem to resolve the problem in raam/. Now we get a different error (see #1985). Greg Shah
07:48 PM Base Language Feature #2050: ATTR_POLY/METH_POLY used as rvalue or in expressions
I have implemented major changes to ExpressionConversionWorker.expressionType() to do the following:
1. Add suppor...
Greg Shah
10:40 AM Base Language Feature #1920: implement persistent procedures
Conversion regression testing has passed, committed to bzr revision 10210. Constantin Asofiei
09:05 AM Base Language Feature #1920: implement persistent procedures
It looks good. Greg Shah
08:58 AM Base Language Feature #1920: implement persistent procedures
The removeQuotes change, I'm running regression conversion testing again. Constantin Asofiei
08:55 AM Base Language Feature #1920: implement persistent procedures
OK, so I'm dropping the functions.rules change and I'll change CommonAstSupport.removeQuotes. Note that removeQuotes ... Constantin Asofiei
08:44 AM Base Language Feature #1920: implement persistent procedures
OK. You can use the same approach as progressToJavaString() for dropping the quotes (and any following options):
<...
Greg Shah
08:41 AM Base Language Feature #1920: implement persistent procedures
About issue 1: I don't think is OK to convert the string to Java, as currently I need to match with a Progress legacy... Constantin Asofiei
08:35 AM Base Language Feature #1920: implement persistent procedures
Code Feedback:
1. Strings can be qualified with more than just the @:U@. Your code assumes there can only be 1 qu...
Greg Shah
07:33 AM Base Language Feature #1920: implement persistent procedures
No changes in generated MAJIC sources. Greg, if the update looks good to you, I will release it. Constantin Asofiei
05:55 AM Base Language Feature #1920: implement persistent procedures
Handle the case of single quotes used with function names and others (removeQuotes was improved to remove enclosing s... Constantin Asofiei
05:44 AM Base Language Feature #1920: implement persistent procedures
This update fixes a bug in dynamic-function's func name resolution, for cases like:... Constantin Asofiei
08:21 AM Base Language Feature #2048 (Closed): BUFFER parameters without name in forward function definitions
Greg Shah
06:17 AM Base Language Feature #2048: BUFFER parameters without name in forward function definitions
Commited to bazaar as revision number 10209. Costin Savin
05:44 AM Base Language Feature #2048: BUFFER parameters without name in forward function definitions
Update has passed conversion regression testing, please check in and distribute. Constantin Asofiei
04:46 AM Base Language Feature #2048: BUFFER parameters without name in forward function definitions
The update looks OK, is going through conversion regression testing now. Constantin Asofiei
04:44 AM Base Language Feature #2048: BUFFER parameters without name in forward function definitions
Added proposed update Costin Savin
04:05 AM Database Feature #1668: add support for additional (non-dynamic) database attributes
Added conversion support for EMPTY-TEMP-TABLE and BUFFER-DELETE (see ecf_upd20130226a.zip at #1985). This update pas... Eric Faulhaber
02:34 AM Database Bug #2054 (Closed): conversion errors with complex buffer parameters and definitions
The fix has passed conversion regression testing. It is checked into bzr revision 10207. Eric Faulhaber
02:08 AM Database Bug #2054: conversion errors with complex buffer parameters and definitions
The following testcases produce buffers and fields with the incorrect schemaname annotation, such that downstream pro... Eric Faulhaber
01:59 AM Database Bug #2054 (Closed): conversion errors with complex buffer parameters and definitions
Eric Faulhaber
07:58 PM Base Language Feature #2051 (Closed): conversion support for ATTR_POLY/METH_POLY used as rvalue or in expression
Greg Shah

02/25/2013

04:51 PM Database Bug #2052: conversion error resolving master temp-table buffer
Turns out the previous update fixed the symptom rather than the root cause. Turns out we were not handling empty int... Eric Faulhaber
03:40 PM Database Bug #2052: conversion error resolving master temp-table buffer
Constantin Asofiei wrote:
> This testcase is related to this issue:
> [...]
>
> The buffers get reordered, but n...
Eric Faulhaber
03:08 PM Database Bug #2052: conversion error resolving master temp-table buffer
This testcase is related to this issue:... Constantin Asofiei
02:59 PM Database Bug #2052: conversion error resolving master temp-table buffer
OK, I'll try postponing the DEFINE BUFFER lookups until all the DEFINE TEMP-TABLE statements in a file have been visi... Eric Faulhaber
02:56 PM Database Bug #2052: conversion error resolving master temp-table buffer
I think this is related to annotations/record_scoping_post.rules H008. Constantin Asofiei
02:49 PM Database Bug #2052: conversion error resolving master temp-table buffer
The error occurs because there is an expectation of a DEFINE TEMP-TABLE xyz statement appearing earlier in the AST th... Eric Faulhaber
02:18 PM Database Bug #2052 (Closed): conversion error resolving master temp-table buffer
Eric Faulhaber
03:37 PM Database Feature #2047 (Closed): field references in procedures without explicit buffer scope
Greg Shah
03:15 PM Database Feature #2047: field references in procedures without explicit buffer scope
Committed to bzr revision 10204. Constantin Asofiei
03:02 PM Database Feature #2047: field references in procedures without explicit buffer scope
Check it in and distribute it. Greg Shah
02:42 PM Database Feature #2047: field references in procedures without explicit buffer scope
The conversion has finished and the generated sources look good to me (only some reordering in openScope and buffer i... Constantin Asofiei
01:32 PM Database Feature #2047: field references in procedures without explicit buffer scope
I had a copy-paste error in SymbolResolver, I saved bufname instead of dbname in the "dbname" annotation. I'm running... Constantin Asofiei
11:40 AM Database Feature #2047: field references in procedures without explicit buffer scope
I'm a little nervous about the change BUT I think it should be OK. I'm going to put it into conversion testing now. Greg Shah
11:01 AM Database Feature #2047: field references in procedures without explicit buffer scope
Fix attempt for scope computation for fields in procedures/functions without explicit buffer scope created by other s... Constantin Asofiei
09:39 AM Database Feature #2047: field references in procedures without explicit buffer scope
This one is related to #1706. Looking at the perm buffer scoping from some compile listings from 4GL v9 and new ones ... Constantin Asofiei
08:53 AM Database Feature #2047: field references in procedures without explicit buffer scope
Looks like 4GL allows a buffer reference in a procedure, without having its scope set, as it inherits the buffer scop... Constantin Asofiei
08:51 AM Database Feature #2047 (Closed): field references in procedures without explicit buffer scope
Constantin Asofiei
03:34 PM Conversion Tools Feature #2053: create a parameter type lookup facility for built-in functions and handle based me...
Consider these classes:... Greg Shah
03:19 PM Conversion Tools Feature #2053 (Closed): create a parameter type lookup facility for built-in functions and handle...
Greg Shah
02:36 PM Base Language Feature #1647: implement an option for SETUSERID and USERID to be backed by a replacement for the...
Committed in bzr as 10203. Eugenie Lyzenko
02:27 PM Base Language Feature #1647: implement an option for SETUSERID and USERID to be backed by a replacement for the...
Conversion testing passed. Please check this in and distribute it. Greg Shah
12:49 PM Base Language Feature #1647: implement an option for SETUSERID and USERID to be backed by a replacement for the...
This looks good. I will put it into conversion testing now. Greg Shah
12:41 PM Base Language Feature #1647: implement an option for SETUSERID and USERID to be backed by a replacement for the...
The suggested update has been uploaded. Also I have appended simple test and conversion result. The code drop merged ... Eugenie Lyzenko
09:49 AM Base Language Feature #1647: implement an option for SETUSERID and USERID to be backed by a replacement for the...
I should have provided more information previously, sorry.
For now, all that needs to be done is to add support fo...
Greg Shah
09:42 AM Base Language Feature #1647: implement an option for SETUSERID and USERID to be backed by a replacement for the...
Let me clarify some points.
1. Is the _USER table already implemented in P2J?
2. My work is to add conversion suppo...
Eugenie Lyzenko
02:27 PM Base Language Bug #2049 (Closed): SET statement and NO-ERROR clause
Greg Shah
02:25 PM Base Language Bug #2049: SET statement and NO-ERROR clause
Conversion testing has passed. I have checked it in as bzr revision 10102. Greg Shah
12:11 PM Base Language Bug #2049: SET statement and NO-ERROR clause
But since I haven't tested that assumption (that no-error always will appear at the end), I think it is best to go wi... Greg Shah
12:09 PM Base Language Bug #2049: SET statement and NO-ERROR clause
Added the new archive, I will remove the older, unneeded one.
I believe that @isWidget@ is used as a flag when sca...
Ovidiu Maxiniuc
11:37 AM Base Language Bug #2049: SET statement and NO-ERROR clause
It is not clear to me whether we should have a section like this:... Greg Shah
11:15 AM Base Language Bug #2049 (Review): SET statement and NO-ERROR clause
Looks like the @N0-ERROR@ clause was treated as an widget in the list of parameters of the statements (@SET@, @ASSIGN... Ovidiu Maxiniuc
11:04 AM Base Language Bug #2049 (WIP): SET statement and NO-ERROR clause
Ovidiu Maxiniuc
08:58 AM Base Language Bug #2049: SET statement and NO-ERROR clause
Conversion fails in a case like... Constantin Asofiei
08:57 AM Base Language Bug #2049 (Closed): SET statement and NO-ERROR clause
Constantin Asofiei
02:20 PM Base Language Feature #2048: BUFFER parameters without name in forward function definitions
Keep in mind that the FORWARD declaration should not be changing buffer scoping at all. My guess is that somewhere w... Greg Shah
02:19 PM Base Language Feature #2048: BUFFER parameters without name in forward function definitions
Actually, both results look wrong. doubler2() gets an openScope() with the same buffer name passed twice. That may ... Greg Shah
01:59 PM Base Language Feature #2048: BUFFER parameters without name in forward function definitions
The conversion fails because of code in record_scoping_prep.rules which assumes the buffer annotation is in the copy.... Costin Savin
08:56 AM Base Language Feature #2048: BUFFER parameters without name in forward function definitions
Conversion fails in this case:... Constantin Asofiei
08:53 AM Base Language Feature #2048 (Closed): BUFFER parameters without name in forward function definitions
Constantin Asofiei
01:01 PM Database Feature #1992 (Closed): add support for double-colon (::) syntax
Eric Faulhaber
12:35 PM Database Feature #1992: add support for double-colon (::) syntax
I have chosen not to alter in any way the update that have passed the testing (om_upd20130225a.zip) and committed it ... Ovidiu Maxiniuc
11:38 AM Database Feature #1992: add support for double-colon (::) syntax
Your update (including my change to progress.g) has passed conversion regression testing. I am attaching my updated ... Eric Faulhaber
10:55 AM Database Feature #1992: add support for double-colon (::) syntax
> There was one change to progress.g that seemed unnecessary: after discussion with Greg, I removed the actions in t... Ovidiu Maxiniuc
10:43 AM Database Feature #1992: add support for double-colon (::) syntax
Code review 20130225a:
Nice work! I am running it through conversion regression testing now.
There was one cha...
Eric Faulhaber
06:19 AM Database Feature #1992: add support for double-colon (::) syntax
Latest :: conversion merged with bzr revision 10199 and updated testcase. Ovidiu Maxiniuc
11:47 AM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Greg Shah wrote:
> Final conversion testing passed. This is checked into bzr as 10200.
This will fail runtime reg...
Eric Faulhaber
10:21 AM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Final conversion testing passed. This is checked into bzr as 10200. Greg Shah
09:15 AM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Initial conversion testing passed. Attached is the update merged up to bzr 10199. This is going back into conversio... Greg Shah
11:21 AM Base Language Feature #2050: ATTR_POLY/METH_POLY used as rvalue or in expressions
The issue only occurs for those ATTR_POLY/FUNC_POLY/METH_POLY cases where we cannot detect the type based on the chil... Greg Shah
10:20 AM Base Language Feature #2050: ATTR_POLY/METH_POLY used as rvalue or in expressions
I wonder if ExpressionConversionWorker should ignore these _POLY cases ? And determine the expression type based on t... Constantin Asofiei
10:16 AM Base Language Feature #2050: ATTR_POLY/METH_POLY used as rvalue or in expressions
The problem I was working (in #1655) is the same problem. I "fixed" it by eliminating the use of expressionType() in... Greg Shah
10:02 AM Base Language Feature #2050: ATTR_POLY/METH_POLY used as rvalue or in expressions
Conversion for ATTR_POLY used in complex expressions fails, as the ExpressionConversionWorker can't determine the typ... Constantin Asofiei
09:56 AM Base Language Feature #2050 (Closed): ATTR_POLY/METH_POLY used as rvalue or in expressions
Constantin Asofiei
09:57 AM Base Language Feature #2051: conversion support for ATTR_POLY/METH_POLY used as rvalue or in expression
This is for milestone 4 time tracking only. All comments must be added in parent task #2050 Constantin Asofiei
09:57 AM Base Language Feature #2051 (Closed): conversion support for ATTR_POLY/METH_POLY used as rvalue or in expression
Constantin Asofiei
02:43 AM Database Feature #1975: add runtime support for (non-dynamic) database attributes
Log all history in parent task. Eric Faulhaber
02:37 AM Database Feature #2042 (Closed): add conversion support for some embedded SQL features
Eric Faulhaber
02:34 AM Database Feature #1588: add conversion and runtime support for embedded SQL
Added support for the simple, single table (and column) constructs listed above. These convert to methods in Buffer.... Eric Faulhaber

02/24/2013

05:29 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
A problem has occurred in the use of the ATTR_POLY BUFFER-VALUE (KW_BUF_VAL) as a parameter to an INTEGER() built-in ... Greg Shah
05:08 PM Database Feature #2045 (Closed): conversion support for a DELETE statement with a validation expression
Greg Shah
03:18 PM Database Feature #2045: conversion support for a DELETE statement with a validation expression
This is for time tracking and milestone association only. All history should be in the parent task #2044. Greg Shah
03:17 PM Database Feature #2045 (Closed): conversion support for a DELETE statement with a validation expression
Greg Shah
05:08 PM Database Feature #2044: implement support for a DELETE statement with a validation expression
It passed conversion testing and is committed to bzr as revision 10198. Greg Shah
04:08 PM Database Feature #2044: implement support for a DELETE statement with a validation expression
And now the update... Greg Shah
04:08 PM Database Feature #2044: implement support for a DELETE statement with a validation expression
I fixed the header and have re-attached the update. This is going into conversion regression testing now. Greg Shah
04:04 PM Database Feature #2044: implement support for a DELETE statement with a validation expression
Code review 20130224a:
Changes look OK to me. Note that database_access.rules needs a header entry for your changes.
Eric Faulhaber
03:31 PM Database Feature #2044: implement support for a DELETE statement with a validation expression
Add support to the conversion and runtime for a DELETE statement with a validation expression. We already support DE... Greg Shah
03:17 PM Database Feature #2044 (Closed): implement support for a DELETE statement with a validation expression
Greg Shah
03:52 PM Base Language Feature #1627 (Closed): support for empty EXPORT statements
Greg Shah
03:43 PM Base Language Feature #1627: support for empty EXPORT statements
The evl_upd20130224a.zip has been committed in bzr as 10197. Eugenie Lyzenko
03:32 PM Base Language Feature #1627: support for empty EXPORT statements
This has passed conversion testing. Go ahead and check it in and distribute it. Greg Shah
02:33 PM Base Language Feature #1627: support for empty EXPORT statements
The code looks good. I will run conversion testing now. Greg Shah
01:43 PM Base Language Feature #1627: support for empty EXPORT statements
The modified post_parse_fixups.xml and new rule have been uploaded to eliminate empty export. Also the converted code... Eugenie Lyzenko
03:19 PM Database Feature #2046: runtime support for DELETE statement with a validation expression
This is for time tracking and milestone association only. All history should be in the parent task #2044. Greg Shah
03:19 PM Database Feature #2046 (Closed): runtime support for DELETE statement with a validation expression
Greg Shah
10:31 AM User Interface Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles
Checked in as bzr revision 10196. Greg Shah
08:54 AM User Interface Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles
Attached update makes the window system handles to convert as true handles; also, I've removed the THIS-PROCEDURE hac... Constantin Asofiei
07:19 AM User Interface Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles
I was thinking for the implementation of the window system-handles to allow them to convert to an API which returns t... Constantin Asofiei
07:06 PM User Interface Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles
There are major changes in Majic. And those changes don't compile. This is an example change:... Greg Shah
10:27 AM User Interface Feature #2036 (Closed): conversion support for some frame options
Greg Shah
10:27 AM User Interface Feature #1801: add some frame options
Passed conversion testing and checked into bzr as 10195. Greg Shah
09:24 AM User Interface Feature #1801: add some frame options
I wish you were not right but clearly you are. Luckily for us, you are right often. :) But being right this time me... Greg Shah
06:50 AM User Interface Feature #1801: add some frame options
Looks like my instinct was correct. Using this test:... Constantin Asofiei
09:29 AM Conversion Tools Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...
OK, for now this is done. I am going to move this to another milestone. The only remaining work is to remove the ha... Greg Shah
08:00 AM Conversion Tools Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...
The only real problem is when converting the 4GL proc name, to make the name compatbile with Java syntax. As we don't... Constantin Asofiei
07:18 PM Conversion Tools Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...
Interesting. I wonder what is going on there. I can duplicate your result as well.
But when I used the testcases...
Greg Shah
06:16 AM Base Language Feature #2013: implement the SELF system handle
Committed to bzr revision 10194, passed runtime regression testing. Constantin Asofiei

02/23/2013

05:53 PM User Interface Feature #1801: add some frame options
In regard to the COLOR option, all of the cases are "custom" COLOR names (the protermcap-attribute). VALUE() is not ... Greg Shah
03:01 PM User Interface Feature #1801: add some frame options
This update adds support for:
# STREAM-IO clause
# FONT clause
# IN WIDGET clause
Note that only the static ver...
Constantin Asofiei
02:22 PM User Interface Feature #1801: add some frame options
> # IN WINDOW <handle-expression>
> This should convert to a @frame.[update|display|set|etc](elementList#, <handle-e...
Constantin Asofiei
01:16 PM User Interface Feature #1801: add some frame options
# COLOR
syntax:...
Constantin Asofiei
05:43 PM Base Language Feature #2013: implement the SELF system handle
The change looks fine. This is being conversion tested now. Greg Shah
01:30 PM Base Language Feature #2013: implement the SELF system handle
Fixed initialization of context-local data in SelfManager. Constantin Asofiei
10:14 PM Base Language Feature #2013: implement the SELF system handle
Passed conversion testing. Checked into bzr as 10189. Greg Shah
05:41 PM User Interface Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles
The change looks fine. This is being conversion tested now. Greg Shah
12:29 PM User Interface Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles
Fixed the issues at comment 12. Constantin Asofiei
12:24 PM User Interface Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles
OK, please do fix it. Greg Shah
12:23 PM User Interface Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles
There is a problem when CURRENT/DEFAULT/ACTIVE-WINDOW are not used in an assignment, as in:... Constantin Asofiei
10:23 AM User Interface Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles
Committed to bzr revision 10191. Constantin Asofiei
10:17 AM User Interface Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles
Conversion testing has passed. Please check it in to bzr and distribute via email. Greg Shah
09:20 AM User Interface Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles
The code looks good. It is in conversion testing now. Greg Shah
08:59 AM User Interface Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles
Yes, is merged and ready for testing. Constantin Asofiei
08:58 AM User Interface Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles
I assume this update is merged up to bzr 10190? It is ready for testing? Greg Shah
05:39 AM User Interface Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles
Conversion regression testing passed on my system (no changes in generated code). Constantin Asofiei
02:30 AM User Interface Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles
> Is the assignment of DEFAULT-WINDOW and ACTIVE-WINDOW (and SESSION) silently tolerated (and ignored) at runtime in ... Constantin Asofiei
05:27 PM Base Language Feature #2021 (Closed): conversion support for web services
Greg Shah
05:26 PM Base Language Feature #1645: implement web services support
With this change, testing passed. Checked into bzr as 10193. Greg Shah
04:19 PM Base Language Feature #1645: implement web services support
This update causes a problem with many (all?) RUN statements. Here is a common example diff (this is broken througho... Greg Shah
12:21 PM Base Language Feature #1645: implement web services support
This is in testing now. Greg Shah
11:54 AM Base Language Feature #1645: implement web services support
It looks good. This will go into conversion testing next. Greg Shah
11:46 AM Base Language Feature #1645: implement web services support
Attached update fixes the refAsync issue and refSet.move (which should move to copy not refAsync) Constantin Asofiei
11:39 AM Base Language Feature #1645: implement web services support
Everything else looks OK with the code. Greg Shah
11:38 AM Base Language Feature #1645: implement web services support
In fixups/control_flow.rules refAsync is never assigned, but it is relied upon in the ASYNCH ON case and in the SET h... Greg Shah
11:26 AM Base Language Feature #1645: implement web services support
Built on top of #1782 23d.zip update. Fixed support for @RUN ... SET hPortType ON hWebServ@ statement. Added support ... Constantin Asofiei
08:39 AM Base Language Feature #1645: implement web services support
More info about RUN ... SET ... ON SERVER. Something like this works:... Constantin Asofiei
05:28 AM Base Language Feature #1645: implement web services support
Another later edit: it is possible to use the @SET hPortType@ specification even with the @TRANSACTION DISTINCT@ and ... Constantin Asofiei
04:51 AM Base Language Feature #1645: implement web services support
> fix the @RUN SET ... ON SERVER@ statement
Look like the ASYNC clause is supported (at least at compile-time) for th...
Constantin Asofiei
04:28 AM Base Language Feature #1645: implement web services support
For the Server object handle, all documented attributes/methods are supported except these:
# REQUEST-INFO, RESPONSE...
Constantin Asofiei
04:39 PM Database Feature #2042: add conversion support for some embedded SQL features
Log history in parent issue. Eric Faulhaber
03:27 PM Database Feature #2042 (Closed): add conversion support for some embedded SQL features
Eric Faulhaber
04:39 PM Database Feature #2043: add runtime support for some embedded SQL features
Log history in parent issue. Eric Faulhaber
04:38 PM Database Feature #2043 (Closed): add runtime support for some embedded SQL features
Eric Faulhaber
03:24 PM Conversion Tools Feature #1603: enhance name conversion to support internal procedure names that contain a '.' cha...
I'm not sure what is needed here. The following converts nicely in P2J:... Constantin Asofiei
12:20 PM Conversion Tools Feature #2001: reporting v2.5
This improvement to the reports is designed to massively improve performance. This was needed because on large proje... Greg Shah
12:14 PM User Interface Feature #2019 (Closed): conversion support for LAST-EVENT system handle and attributes
Greg Shah
12:13 PM User Interface Feature #1782: implement LAST-EVENT system handle and associated attributes
Committe to bzr revision 10192. Constantin Asofiei
12:06 PM User Interface Feature #1782: implement LAST-EVENT system handle and associated attributes
This passed testing. Please check it in and distribute it. Greg Shah
11:06 AM User Interface Feature #1782: implement LAST-EVENT system handle and associated attributes
Looks good. It is going into conversion testing now. Greg Shah
10:51 AM User Interface Feature #1782: implement LAST-EVENT system handle and associated attributes
Beside LABEL, the WIDTH/HEIGHT-CHARS/PIXELS attrs had to be duped in the main section too. Constantin Asofiei
10:41 AM User Interface Feature #1782: implement LAST-EVENT system handle and associated attributes
Correct, any attribute/method used with a widget should be in the main section too. I'm going through all the attrs/m... Constantin Asofiei
10:29 AM User Interface Feature #1782: implement LAST-EVENT system handle and associated attributes
Since the getLabel/setLabel is moved inside the check for LAST-EVENT, doesn't that disable using LABEL on a widget (o... Greg Shah
10:26 AM User Interface Feature #1782: implement LAST-EVENT system handle and associated attributes
Merged with revision 10191. Constantin Asofiei
06:29 AM User Interface Feature #1782: implement LAST-EVENT system handle and associated attributes
LAST-EVENT handle is supported in P2J by using KeyReader.asHandle (when we have a @h = LAST-EVENT@ case). For explici... Constantin Asofiei
11:51 AM Base Language Feature #2041 (Closed): implement runtime support for "shared" attributes that are just stubbed
Greg Shah
11:50 AM Base Language Feature #2002 (Closed): refactor some "shared" attributes
Greg Shah
11:15 AM User Interface Feature #2036 (WIP): conversion support for some frame options
Constantin Asofiei
11:11 AM Database Feature #1992: add support for double-colon (::) syntax
OK, please add a suitable task to the Base Language project and target it to milestone 7. Please put all the relevan... Greg Shah
10:55 AM Database Feature #1992: add support for double-colon (::) syntax
For milestone 4, I don't think there is anything we need to do about the *_POLY rvalues, all -will- can be in the run... Constantin Asofiei
10:48 AM Database Feature #1992: add support for double-colon (::) syntax
> Idea is, if we have the ATTR/METH_POLY in an expression or as a rvalue, then 4GL does some automatic conversion of ... Greg Shah
10:25 AM User Interface Feature #2017 (Closed): conversion sypport for CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW s...
Greg Shah
10:16 AM User Interface Feature #2029 (Closed): conversion support for the SIZE phrase
Greg Shah
10:16 AM User Interface Feature #1800: add some missing widget options
For milestone 4, that is fine. Greg Shah
06:19 AM User Interface Feature #1800: add some missing widget options
The full syntax of the size phrase is:... Constantin Asofiei
03:49 AM Database Feature #2000: add conversion support for table and table handle parameters
I'm sending the update in its current state: INPUT/OUTPUT parameters and APPEND option are not handled, createDynamic... Stanislav Lomany
03:00 AM Database Feature #2000: add conversion support for table and table handle parameters
Stanislav, OK now I understand what you mean. APPEND clause used with OUTPUT/INPUT-OUTPUT table at the caller affects... Constantin Asofiei
10:47 PM Database Feature #2000: add conversion support for table and table handle parameters
Stas: please provide an update for all the other functionality discussed above ASAP, even if you don't yet have an a... Eric Faulhaber
01:42 AM Database Feature #1660: add conversion and runtime support for OF keyword use in a CAN-FIND
Vadim Nebogatov wrote:
> ... but conversion of
> ...
Eric Faulhaber
12:38 AM Database Feature #1660: add conversion and runtime support for OF keyword use in a CAN-FIND
I have created environment for tests and made some first conversion tests. Will try to make more tests on Monday.
...
Vadim Nebogatov
10:14 PM Base Language Feature #2014 (Closed): conversion support for SELF system handle
Greg Shah
10:13 PM User Interface Feature #2025 (Closed): conversion support for the CREATE_WIDGET statement
Greg Shah
10:13 PM User Interface Feature #1791: implement dynamic UI support
Passed conversion testing. Checked into bzr as 10190. Greg Shah

02/22/2013

04:45 PM User Interface Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles
Is the assignment of DEFAULT-WINDOW and ACTIVE-WINDOW (and SESSION) silently tolerated (and ignored) at runtime in th... Greg Shah
02:49 PM User Interface Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles
Added intermediate update merged to latest revision, this should cover the cases showed here minus the case for which... Costin Savin
07:35 AM User Interface Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles
What will be the approach for system handles besides CURRENT-WINDOW that are assigned as left value.
It seems that ...
Costin Savin
04:37 PM User Interface Feature #1791: implement dynamic UI support
Merged up to bzr 10188. This version will be going into testing next. Greg Shah
02:18 PM User Interface Feature #1791: implement dynamic UI support
Merged with #2013, fixed conversion of @CREATE VALUE(type)@ when the type is a known widget type. Constantin Asofiei
01:47 PM User Interface Feature #1791: implement dynamic UI support
Yes, please do merge it with the #2013 update. We will put them both in together. Greg Shah
01:42 PM User Interface Feature #1791: implement dynamic UI support
> > I chose the approach of having dedicated APIs because IMO is cleaner, but I can switch to only one API DynamicWid... Constantin Asofiei
01:15 PM User Interface Feature #1791: implement dynamic UI support
> I chose the approach of having dedicated APIs because IMO is cleaner, but I can switch to only one API DynamicWidge... Greg Shah
01:07 PM User Interface Feature #1791: implement dynamic UI support
> 1. Why not do everything using an enum: WidgetTypes.WINDOW, WidgetTypes.FILLIN...
In the end, we will still have t...
Constantin Asofiei
12:52 PM User Interface Feature #1791: implement dynamic UI support
No, leave the trigger phrase out for now.
2 questions:
1. Why not do everything using an enum: WidgetTypes.WIND...
Greg Shah
10:35 AM User Interface Feature #1791: implement dynamic UI support
The trigger phrase was not touched - should I work on this too ? Constantin Asofiei
10:11 AM User Interface Feature #1791: implement dynamic UI support
Attached update adds CREATE WIDGET support (explicit and VALUE versions). Converted code looks like:... Constantin Asofiei
09:15 AM User Interface Feature #1791: implement dynamic UI support
Yes, I like the approach. The assignments for a CREATE WIDGET can be easily dealt with by implicitly using the handl... Greg Shah
05:06 AM User Interface Feature #1791: implement dynamic UI support
The conversion rules to emit this were pretty simple (I have code for all except CREATE BROWSE), although I'm not sur... Constantin Asofiei
08:00 PM User Interface Feature #1791: implement dynamic UI support
High priority for milestone 4:... Greg Shah
04:31 PM Base Language Feature #2013: implement the SELF system handle
Here is the right version. Greg Shah
04:27 PM Base Language Feature #2013: implement the SELF system handle
This is the latest version merged up to bzr 10188. It will go into testing next. Greg Shah
02:17 PM Base Language Feature #2013: implement the SELF system handle
> I think it might be more correct to say that the rule-set only handles the resource reference for handle types. In... Constantin Asofiei
01:46 PM Base Language Feature #2013: implement the SELF system handle
The code looks good.... Greg Shah
01:33 PM Base Language Feature #2013: implement the SELF system handle
> 1. refName is a dead variable and can be removed from methods_attributes.rules.
OK, removed
> 2. How do we emit t...
Constantin Asofiei
12:34 PM Base Language Feature #2013: implement the SELF system handle
Code Feedback:
1. refName is a dead variable and can be removed from methods_attributes.rules.
2. How do we emi...
Greg Shah
12:14 PM Base Language Feature #2013: implement the SELF system handle
Conversion regression testing has passed - compilation was OK, all changes are expected. Constantin Asofiei
06:39 AM Base Language Feature #2013: implement the SELF system handle
Conversion has finished, there was a APPLY ... TO SELF problem, fixed in attached update. All other changes look good... Constantin Asofiei
03:22 AM Base Language Feature #2013: implement the SELF system handle
Added testcases (previous were for session handle) Constantin Asofiei
03:20 AM Base Language Feature #2013: implement the SELF system handle
-Added testcases.- they are for session handle, I've deleted it from here. Constantin Asofiei
03:18 AM Base Language Feature #2013: implement the SELF system handle
Fixed a conversion error, I'm running conversion again. Constantin Asofiei
04:21 PM User Interface Feature #2005 (Closed): add conversion support for methods
Greg Shah
04:20 PM User Interface Feature #2007 (Closed): conversion support for attributes
Greg Shah
04:12 PM User Interface Feature #1804: add missing UI attributes
The update evl_upd20130222c.zip has been committed in bzr as 10188. Eugenie Lyzenko
04:04 PM User Interface Feature #1804: add missing UI attributes
Testing passed. Please check it in and distribute the update. ASAP. Greg Shah
02:46 PM User Interface Feature #1804: add missing UI attributes
Looks great. It is going into testing now. Greg Shah
02:43 PM User Interface Feature #1804: add missing UI attributes
The merged version combined with #2005 changes has been uploaded. Eugenie Lyzenko
02:21 PM User Interface Feature #1804: add missing UI attributes
Is this also merged with the #2005 changes? I want them both in the same update. Greg Shah
02:10 PM User Interface Feature #1804: add missing UI attributes
Merged with latest bzr uploaded. Eugenie Lyzenko
01:26 PM User Interface Feature #1804: add missing UI attributes
Please merge with the latest bzr revision and upload for a final review. Then we will go into conversion testing (ru... Greg Shah
03:09 PM Database Feature #1992: add support for double-colon (::) syntax
All the specified cases work nicely.
> I'm not sure I understand what is being asked here. By definition, the ATTR...
Constantin Asofiei
03:00 PM Database Feature #1992: add support for double-colon (::) syntax
> in assignment case, when the rvalue is a ATTR/METH_POLY, are there cases when the lvalue is of a different type tha... Greg Shah
02:57 PM Database Feature #1992: add support for double-colon (::) syntax
> are there any ATTR_POLY/METH_POLY used directly in a frame-related statement?
In regard to the FUNC_POLY/ATTR_PO...
Greg Shah
01:55 PM Database Feature #2000: add conversion support for table and table handle parameters
> Please fill out this matrix:
When you specify APPEND in the calling procedure it logically applies to the table ...
Stanislav Lomany
12:44 PM Database Feature #2000: add conversion support for table and table handle parameters
> Progress documentation tells that "You can only use the APPEND option for an INPUT parameter in the calling procedu... Greg Shah
12:36 PM Database Feature #2000: add conversion support for table and table handle parameters
Leave it as Temporary if you don't have a need to change it. Less runtime change. If we find we need it to be Buffe... Eric Faulhaber
12:34 PM Database Feature #2000: add conversion support for table and table handle parameters
So, Eric, do you prefer to leave Temporary or switch to Buffer?
Constantin, Greg, how do you prefer to pass APPEND...
Stanislav Lomany
01:21 PM Base Language Feature #2003 (Closed): conversion support for SESSION handle
Greg Shah
01:16 PM Base Language Feature #1612: finish SESSION system handle support
Committed to bzr revision 10187. Constantin Asofiei
01:03 PM Base Language Feature #1612: finish SESSION system handle support
Conversion testing has passed. Please check in and distribute. Greg Shah
12:02 PM Base Language Feature #1612: finish SESSION system handle support
The update looks good. I'm testing it now. Greg Shah
11:43 AM Base Language Feature #1612: finish SESSION system handle support
Merged with revision 10186. Constantin Asofiei
11:10 AM Base Language Feature #1612: finish SESSION system handle support
The code looks fine. I'll re-check after the merge. Greg Shah
03:22 AM Base Language Feature #1612: finish SESSION system handle support
Added tests. Constantin Asofiei
03:19 AM Base Language Feature #1612: finish SESSION system handle support
Merged with 10183, fixed some runtime errors too (ERROR-STATUS handle could not initialize its static proxy). Constantin Asofiei
12:02 PM Database Feature #1974 (Closed): add conversion support for (non-dynamic) database attributes
Eric Faulhaber
11:53 AM Base Language Feature #2009 (Closed): conversion support for LANDSCAPE/PORTRAIT I/O option
Greg Shah
11:49 AM Base Language Feature #2011 (Closed): conversion support for _MSG() built-in
Greg Shah
11:46 AM Base Language Feature #1632: implement _MSG() undocumented built-in function
Conversion tests passed , commited to bazaar as revision 10186 Costin Savin
09:03 AM Base Language Feature #1632: implement _MSG() undocumented built-in function
The update looks good. I will start testing it shortly. Greg Shah
11:27 AM Base Language Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements
Conversion test passed, commited to bazaar as revision 10185 Costin Savin
09:10 AM Base Language Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements
The update looks good. I will start testing it shortly. I am deleting the update that is not matching, so that ther... Greg Shah
09:07 AM Base Language Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements
Attached it Costin Savin
09:06 AM Base Language Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements
This is the wrong update (it is for the _MSG work). Please post the correct one. Greg Shah
04:26 AM Base Language Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements
Added merged update Costin Savin
11:14 AM Base Language Feature #1979 (Closed): conversion support for DOM XML processing
Greg Shah
11:10 AM Base Language Feature #1640: implement DOM XML support
The update evl_upd20130222a.zip passed the conversion test and committed in bzr as 10184. Eugenie Lyzenko
09:02 AM Base Language Feature #1640: implement DOM XML support
The update looks good. I will start testing it shortly. Greg Shah
05:56 AM Base Language Feature #1640: implement DOM XML support
The merged code has been uploaded for testing. The setSubType methods unified with name syntax of the SubTypeAttribut... Eugenie Lyzenko
10:32 AM User Interface Feature #2039: more runtime support for frame options
This is just for time tracking and milestone association. All history should go into the parent task #1801. Greg Shah
10:32 AM User Interface Feature #2039 (Rejected): more runtime support for frame options
Greg Shah
10:32 AM User Interface Feature #2038: conversion and runtime support for frame options, attributes and methods
This is just for time tracking and milestone association. All history should go into the parent task #1801. Greg Shah
10:32 AM User Interface Feature #2038 (Closed): conversion and runtime support for frame options, attributes and methods
Greg Shah
10:30 AM User Interface Feature #2037: runtime support for frame options
This is just for time tracking and milestone association. All history should go into the parent task #1801. Greg Shah
10:30 AM User Interface Feature #2037 (Closed): runtime support for frame options
Greg Shah
10:27 AM User Interface Feature #2036: conversion support for some frame options
This is just for time tracking and milestone association. All history should go into the parent task #1801. Greg Shah
10:25 AM User Interface Feature #2036 (Closed): conversion support for some frame options
Greg Shah
10:11 AM User Interface Feature #1801: add some frame options
High priority frame options for milestone 4:
COLOR
FONT
IN WINDOW
STREAM-IO
Greg Shah
03:02 AM Base Language Feature #2002: refactor some "shared" attributes
Committed to bzr revision 10182. Constantin Asofiei
11:15 PM Database Feature #1999 (Closed): add conversion support for builtin functions in a WHERE clause
I am closing this issue. While it brought up some interesting issues with our CAN-FIND support (which are now docume... Eric Faulhaber
10:28 PM Database Feature #1999: add conversion support for builtin functions in a WHERE clause
Vadim Nebogatov wrote:
> CAN-FIND(): SHARE-LOCK and NO-WAIT
> Yes, you are right, it is supported. I did not notic...
Eric Faulhaber
08:30 PM Database Feature #1999: add conversion support for builtin functions in a WHERE clause
CAN-FIND(): SHARE-LOCK and NO-WAIT
Yes, you are right, it is supported. I did not notice that WHERE clause is gener...
Vadim Nebogatov
07:19 PM Database Feature #1999: add conversion support for builtin functions in a WHERE clause
Vadim Nebogatov wrote:
> Briefly, all functions are supported with all options excepting
>
> 1) can-find() - work...
Eric Faulhaber
11:09 PM Database Feature #2035: optimize conversion of CAN-FIND([FIRST|LAST] temp-table-record ... {SHARE-LOCK|EXC...
Currently, we convert this construct to use a WhereExpression, which does a client-side lock test for the found recor... Eric Faulhaber
11:02 PM Database Feature #2035 (New): optimize conversion of CAN-FIND([FIRST|LAST] temp-table-record ... {SHARE-LO...
Eric Faulhaber
10:59 PM Database Bug #2034: correct conversion of CAN-FIND({FIRST|LAST} ... {SHARE-LOCK|EXCLUSIVE_LOCK} [NO-WAIT])
Currently, we convert @CAN-FIND({FIRST|LAST} ...)@ with a lock the same as we do as if it doesn't have a lock; that ... Eric Faulhaber
10:54 PM Database Bug #2034 (New): correct conversion of CAN-FIND({FIRST|LAST} ... {SHARE-LOCK|EXCLUSIVE_LOCK} [NO-...
Eric Faulhaber
10:50 PM Database Feature #1660: add conversion and runtime support for OF keyword use in a CAN-FIND
The construct @record OF table@ in a 4gl query signifies a join between two tables (see "Record phrase" documentation... Eric Faulhaber
08:18 PM User Interface Feature #2032: runtime support for widget options
This is for time tracking and association with a milestone. All history must be placed in parent task #1800. Greg Shah
08:18 PM User Interface Feature #2032 (Closed): runtime support for widget options
Greg Shah
08:17 PM User Interface Feature #2031: conversion support for remaining widget options
This is for time tracking and association with a milestone. All history must be placed in parent task #1800. Greg Shah
08:17 PM User Interface Feature #2031 (Closed): conversion support for remaining widget options
Greg Shah
08:15 PM User Interface Feature #2029: conversion support for the SIZE phrase
This is for time tracking and association with a milestone. All history must be placed in parent task #1800. Greg Shah
08:15 PM User Interface Feature #2029 (Closed): conversion support for the SIZE phrase
Greg Shah
08:13 PM User Interface Feature #1800: add some missing widget options
For milestone 4, add the SIZE clause to the conversion of widget options as in:... Greg Shah
08:09 PM User Interface Feature #2028: complete runtime support for dynamic UI
This just for time tracking and association with the milestone. All history must be placed in the parent task #1791. Greg Shah
08:09 PM User Interface Feature #2028 (Closed): complete runtime support for dynamic UI
Greg Shah
08:08 PM User Interface Feature #2027: preliminary runtime support for CREATE_WIDGET and an IN WINDOW clause
This just for time tracking and association with the milestone. All history must be placed in the parent task #1791. Greg Shah
08:08 PM User Interface Feature #2027 (Closed): preliminary runtime support for CREATE_WIDGET and an IN WINDOW clause
Greg Shah
08:03 PM User Interface Feature #2026: conversion support for CREATE_BROWSE
This just for time tracking and association with the milestone. All history must be placed in the parent task #1791. Greg Shah
08:03 PM User Interface Feature #2026 (Closed): conversion support for CREATE_BROWSE
Greg Shah
08:02 PM User Interface Feature #2025: conversion support for the CREATE_WIDGET statement
This just for time tracking and association with the milestone. All history must be placed in the parent task #1791. Greg Shah
08:01 PM User Interface Feature #2025 (Closed): conversion support for the CREATE_WIDGET statement
Greg Shah

02/21/2013

06:40 PM User Interface Feature #1805: add missing UI method support
You are right. If browse not used in real code the P2J removes the code. The example in browse_ui_test.p properly con... Eugenie Lyzenko
05:51 PM User Interface Feature #1805: add missing UI method support
I noticed that you have the attributes update built on top of the methods, which is fine. I am also OK with combinin... Greg Shah
05:33 PM User Interface Feature #1805: add missing UI method support
What will be the testing sequence of update application? This method update will be the first one, then update for at... Eugenie Lyzenko
05:28 PM User Interface Feature #1805: add missing UI method support
Here is the sample we do not convert:
...
define browse bStat query q1 display.
create browse hBr.
...
Before us...
Eugenie Lyzenko
05:14 PM User Interface Feature #1805: add missing UI method support
The code changes look fine. Please be prepared to merge soon when we are able to schedule the update.
> However w...
Greg Shah
05:59 AM User Interface Feature #1805: add missing UI method support
Added support for MOVE-BEFORE-TAB-ITEM(). The method DESELECT-ROWS() has already supported. However we do not have th... Eugenie Lyzenko
06:06 PM User Interface Feature #1804: add missing UI attributes
The refresh for drop has been uploaded. Eugenie Lyzenko
05:20 PM User Interface Feature #1804: add missing UI attributes
Feedback:
1. methods_attributes.rules is missing a history entry.
2. Please use HWND instead of HWnd in method na...
Greg Shah
06:24 AM User Interface Feature #1804: add missing UI attributes
Adding conversion support for
FIRST-TAB-ITEM
NEXT-TAB-ITEM
HWND
UI attributes.
Eugenie Lyzenko
03:36 PM Database Feature #2000: add conversion support for table and table handle parameters
> From my testing, I don't remember finding any parameter validation based on APPEND clause for temp-tables. This is ... Stanislav Lomany
03:20 PM Database Feature #2000: add conversion support for table and table handle parameters
> Maybe I misunderstood your original comment "@Temporary@ should be at least @Buffer@". I thought you meant the par... Stanislav Lomany
03:00 PM Database Feature #2000: add conversion support for table and table handle parameters
> > 2. We must make a decision on how APPEND parameter should be passed from the calling side.
> I think we need Con...
Constantin Asofiei
02:35 PM Database Feature #2000: add conversion support for table and table handle parameters
Stanislav Lomany wrote:
> 1.
> > OK, in that case I think we can have Temporary extend Buffer.
> Hmm, it seems tha...
Eric Faulhaber
02:16 PM Database Feature #2000: add conversion support for table and table handle parameters
1.
> OK, in that case I think we can have Temporary extend Buffer.
Hmm, it seems that it makes *.Buf classes obsole...
Stanislav Lomany
07:04 PM Database Feature #2000: add conversion support for table and table handle parameters
> I'm pretty sure we already support the APPEND option, even though it's not used in Majic.
APPEND option can be s...
Stanislav Lomany
02:55 PM Base Language Feature #2002: refactor some "shared" attributes
FYI:... Greg Shah
01:33 PM Base Language Feature #2002: refactor some "shared" attributes
Fixed issues 1 to 4, merged with 10181. Constantin Asofiei
01:24 PM Base Language Feature #2002: refactor some "shared" attributes
Greg Shah wrote:
> 6. Wasn't the idea behind the BufferField design was to avoid get/set methods that could conflict...
Eric Faulhaber
01:13 PM Base Language Feature #2002: refactor some "shared" attributes
> 1. Please put a TODO comment into BrowseColumnWidget that it should not always return "FILL-IN" as its type. From ... Constantin Asofiei
12:50 PM Base Language Feature #2002: refactor some "shared" attributes
Code Review Feedback:
1. Please put a TODO comment into BrowseColumnWidget that it should not always return "FILL-...
Greg Shah
12:11 PM Base Language Feature #2002: refactor some "shared" attributes
> Also, please prepare any Majic changes that need to be made.
See #2023
Constantin Asofiei
12:07 PM Base Language Feature #2002: refactor some "shared" attributes
There are 2 check-ins that will occur shortly. Be prepared to merge up to the lastest level. Also, please prepare a... Greg Shah
10:45 AM Base Language Feature #2002: refactor some "shared" attributes
There is one MAJIC-side change needed, as GenericWidget.getFormat now returns character instead of String (I chose to... Constantin Asofiei
10:40 AM Base Language Feature #2002: refactor some "shared" attributes
The only change in generated code is the one related to label: now it unwraps using @handle.unwrapCommonField@, inste... Constantin Asofiei
05:40 AM Base Language Feature #2002 (WIP): refactor some "shared" attributes
Constantin Asofiei
05:33 AM Base Language Feature #2002: refactor some "shared" attributes
This update cleans #1668 errors + refactors attributes. I'm running conversion now, I'll let you know how it goes.
L...
Constantin Asofiei
01:41 PM Database Feature #1949 (Closed): add conversion support for database triggers
Eric Faulhaber
01:30 PM Database Feature #1949 (Review): add conversion support for database triggers
Stanislav Lomany
01:39 PM Database Feature #2024 (Closed): implement runtime support for database triggers
Eric Faulhaber
12:39 PM Database Feature #1999: add conversion support for builtin functions in a WHERE clause
Briefly, all functions are supported with all options excepting
1) can-find() - works in general, but at least FIR...
Vadim Nebogatov
12:34 PM Database Feature #1999: add conversion support for builtin functions in a WHERE clause
Spreadsheet with testing results is attached.
Vadim Nebogatov
12:12 PM Base Language Feature #1640: implement DOM XML support
I have looked into current bzr. There is one point need to be discussed. The attribute SUBTYPE has implemented as sta... Eugenie Lyzenko
12:10 PM Base Language Feature #2013: implement the SELF system handle
I'm leaving a conversion to run over night, hopefully all SELF-handle usage will convert nicely. Constantin Asofiei
10:20 AM Base Language Feature #2013: implement the SELF system handle
I like it. Greg Shah
06:23 AM Base Language Feature #2013 (WIP): implement the SELF system handle
Attached update with proposed solution (built on top of revision 10179). With this approach, all attribute/method acc... Constantin Asofiei
05:58 AM Base Language Feature #2013: implement the SELF system handle
How I see this working: we have a SelfManager class which manages a stack of "self" handles. Each event responsible ... Constantin Asofiei
11:49 AM Database Feature #1668: add support for additional (non-dynamic) database attributes
The update is added for review at #2002. Constantin Asofiei
11:47 AM Base Language Feature #1612: finish SESSION system handle support
Added support for the high-priority stuff (built on top of revision 10179, was easier that way) plus stubs for some a... Constantin Asofiei
07:12 AM Base Language Feature #1612: finish SESSION system handle support
List of not supported attributes:
* progress.g parser errors:...
Constantin Asofiei
09:57 AM Database Feature #1992: add support for double-colon (::) syntax
Yes, this is the case for the @::@, too, as the final attribute in the rewritten form is buffer-value() attribute whe... Ovidiu Maxiniuc
09:51 AM Database Feature #1992: add support for double-colon (::) syntax
Greg, Ovidiu found an interesting case of BUFFER-VALUE usage (which applies to any ATTR_POLY or METH_POLY). If is use... Constantin Asofiei
08:00 AM Base Language Feature #1632: implement _MSG() undocumented built-in function
Looks good. I will let you know when we can test. Only conversion regression testing will be needed. Be prepared t... Greg Shah
04:45 AM Base Language Feature #1632: implement _MSG() undocumented built-in function
Corrected javadoc, was meant to say first: greater or equal 1, then I though greater than 0 to be better as descripti... Costin Savin
06:35 AM Base Language Feature #2003 (WIP): conversion support for SESSION handle
Constantin Asofiei
06:34 AM Base Language Feature #2014 (WIP): conversion support for SELF system handle
Constantin Asofiei
05:01 AM User Interface Feature #2017 (WIP): conversion sypport for CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW syst...
Costin Savin
07:20 PM Base Language Feature #2022: runtime support for web services
This task is only for time tracking and association with the milestone. All history goes in parent task #1645. Greg Shah
07:20 PM Base Language Feature #2022 (Closed): runtime support for web services
Greg Shah
07:20 PM Base Language Feature #2021: conversion support for web services
This task is only for time tracking and association with the milestone. All history goes in parent task #1645. Greg Shah
07:19 PM Base Language Feature #2021 (Closed): conversion support for web services
Greg Shah

02/20/2013

06:57 PM Base Language Feature #1781: add missing support for the WIDGET-HANDLE builtin function
After a quick review of the handle.java class and the builtin_functions.rules, I can see the following:
1. WIDGET-...
Greg Shah
06:20 PM Base Language Feature #1781: add missing support for the WIDGET-HANDLE builtin function
The use cases (and even the description of the function) seem to be identical to the HANDLE() builtin function. A te... Greg Shah
06:41 PM Database Feature #2000: add conversion support for table and table handle parameters
Stanislav Lomany wrote:
> Conversion for TABLE-HANDLE parameters should probably look in the similar way:
> [...]
...
Eric Faulhaber
06:37 PM Database Feature #2000: add conversion support for table and table handle parameters
Stanislav Lomany wrote:
> Notes: 1. @Temporary@ should be at least @Buffer@
OK, in that case I think we can have ...
Eric Faulhaber
05:56 PM Database Feature #2000: add conversion support for table and table handle parameters
Conversion for TABLE-HANDLE parameters should probably look in the similar way:... Stanislav Lomany
05:48 PM Database Feature #2000: add conversion support for table and table handle parameters
Heh, I didn't expected it to be converted...
It is converted to:...
Stanislav Lomany
05:30 PM Database Feature #2000: add conversion support for table and table handle parameters
We already support it today, as far as I understand. Remember that you implemented all the deep copy of temp-tables ... Greg Shah
05:02 PM Database Feature #2000: add conversion support for table and table handle parameters
How do we convert this today? I vaguely remember dealing with this issue in the past, but I don't recall whether we ... Eric Faulhaber
03:55 PM Database Feature #2000: add conversion support for table and table handle parameters
About TABLE parameters.
We must pass to the called function information that identifies the table and information ...
Stanislav Lomany
05:11 PM User Interface Feature #2020: runtime support for LAST-EVENT system handle and associated attributes
This task is just for time tracking and association with the milestone. All history goes in the parent task #1782. Greg Shah
05:11 PM User Interface Feature #2020 (Closed): runtime support for LAST-EVENT system handle and associated attributes
Greg Shah
05:10 PM User Interface Feature #2019: conversion support for LAST-EVENT system handle and attributes
This task is just for time tracking and association with the milestone. All history goes in the parent task #1782. Greg Shah
05:09 PM User Interface Feature #2019 (Closed): conversion support for LAST-EVENT system handle and attributes
Greg Shah
05:01 PM User Interface Feature #2017: conversion sypport for CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system han...
This task is only for time tracking and association with milestone 4. All history should be in the parent task #2016. Greg Shah
04:59 PM User Interface Feature #2017 (Closed): conversion sypport for CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW s...
Greg Shah
05:00 PM User Interface Feature #2018: runtime support for CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles
This task is only for time tracking and association with milestone 7. All history should be in the parent task #2016. Greg Shah
04:59 PM User Interface Feature #2018 (Closed): runtime support for CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW syst...
Greg Shah
04:58 PM User Interface Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles
CURRENT-WINDOW is assignable but neither DEFAULT-WINDOW or ACTIVE-WINDOW can be assigned.
DEFAULT-WINDOW is a hand...
Greg Shah
04:34 PM User Interface Feature #2016 (Closed): implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles
Greg Shah
02:55 PM Database Feature #1949: add conversion support for database triggers
h2. TODO
This update doesn't handle the case if an UI trigger is 1. nested into DB trigger and 2. references DB tr...
Stanislav Lomany
02:09 PM Base Language Feature #1990 (Closed): conversion support for appserver
Greg Shah
02:00 PM Base Language Feature #1608: implement full appserver support (from 4GL clients only)
Committed to bzr revision 10179. Constantin Asofiei
01:44 PM Base Language Feature #1608: implement full appserver support (from 4GL clients only)
The changes passed regression testing. Please check them into bzr and distribute the update. Greg Shah
01:59 PM Database Feature #1992: add support for double-colon (::) syntax
Here is the implementation and some testcase.
I'm afraid this is not built on the last source-code, I will work on t...
Ovidiu Maxiniuc
01:50 PM Database Feature #1992: add support for double-colon (::) syntax
> This could be one of the hardest things to implement. If the field name has changed during the conversion process i... Greg Shah
12:39 PM Database Feature #1992: add support for double-colon (::) syntax
Greg Shah wrote:
> Some thoughts:
>
> 1. Queries are explicitly mentioned as supported by @::@ in the 4GL languag...
Ovidiu Maxiniuc
12:13 PM Database Feature #1992: add support for double-colon (::) syntax
Some thoughts:
1. Queries are explicitly mentioned as supported by @::@ in the 4GL language reference. It wouldn'...
Greg Shah
11:19 AM Database Feature #1992: add support for double-colon (::) syntax
I already have an implementation here but, reading your previous note, made me turn back to OE installation.
The rea...
Ovidiu Maxiniuc
10:28 AM Database Feature #1992: add support for double-colon (::) syntax
OK, so without chaining, the scope of this feature should be much smaller. As you suggested earlier, let's go with a... Eric Faulhaber
01:43 PM Base Language Feature #1632: implement _MSG() undocumented built-in function
The code looks good. I only have 1 question. The javadoc says this:... Greg Shah
10:26 AM Base Language Feature #1632: implement _MSG() undocumented built-in function
Added proposed update Costin Savin
10:07 AM Base Language Feature #1632: implement _MSG() undocumented built-in function
OK, this is more clear.
As far as the negative numbers are concerned, we won't duplicate that behavior right now. ...
Greg Shah
09:26 AM Base Language Feature #1632: implement _MSG() undocumented built-in function
I realized the 0 index difference happened because I mistakenly rerun the program in some cases using the character e... Costin Savin
09:03 AM Base Language Feature #1632: implement _MSG() undocumented built-in function
Please upload the msg_test.txt and msg_test2.txt output files so that I can better understand what is going on.
> ...
Greg Shah
08:37 AM Base Language Feature #1632: implement _MSG() undocumented built-in function
Done more testing and got a better understanding of how msg working.
It seems the _msg(int) will return the error num...
Costin Savin
12:02 PM Base Language Feature #2011 (Review): conversion support for _MSG() built-in
Costin Savin
10:41 AM Database Feature #1999: add conversion support for builtin functions in a WHERE clause
Please provide a summary of which functions are supported by conversion already and which need work. We need to get ... Eric Faulhaber
09:29 AM Database Feature #1668: add support for additional (non-dynamic) database attributes
Constantin Asofiei wrote:
> > Yes, you are correct.
> Please provide an example of read-only private-data attribute...
Vadim Nebogatov
09:09 AM Database Feature #1668: add support for additional (non-dynamic) database attributes
> Yes, you are correct.
Please provide an example of read-only private-data attribute.
Constantin Asofiei
09:08 AM Database Feature #1668: add support for additional (non-dynamic) database attributes
Constantin Asofiei wrote:
> Also #2 - I see that PRIVATE-DATA has an unwrap case of WriteablePrivateData - are there...
Vadim Nebogatov
08:28 AM Base Language Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements
It is good to go. I will let you know when we can schedule it. Because there are some updates in front, please be r... Greg Shah
03:04 AM Base Language Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements
Added proposed update. Costin Savin

02/19/2013

05:21 PM Base Language Feature #2015: runtime support for SELF system handle
This is just for time tracking and association with milestone 4. All history goes in parent task #2013. Greg Shah
05:21 PM Base Language Feature #2015 (Closed): runtime support for SELF system handle
Greg Shah
05:21 PM Base Language Feature #2014: conversion support for SELF system handle
This is just for time tracking and association with milestone 4. All history goes in parent task #2013. Greg Shah
05:20 PM Base Language Feature #2014 (Closed): conversion support for SELF system handle
Greg Shah
05:19 PM Base Language Feature #2013: implement the SELF system handle
The SELF system handle returns the handle to the resource currently being processed in a trigger or other callback pr... Greg Shah
05:15 PM Base Language Feature #2013 (Closed): implement the SELF system handle
Greg Shah
05:03 PM Base Language Feature #1640: implement DOM XML support
The update looks good. We will try to get it scheduled soon, but you will probably have to merge up to the bzr head ... Greg Shah
09:02 PM Base Language Feature #1640: implement DOM XML support
The update for new attributes/methods has been uploaded for review. Eugenie Lyzenko
04:57 PM Base Language Feature #1608: implement full appserver support (from 4GL clients only)
We don't need to handle the Asynchronous request handle object for milestone 4. We will probably go ahead and implem... Greg Shah
08:59 AM Base Language Feature #1608: implement full appserver support (from 4GL clients only)
This code fixes the unsuscribe_stmt clause (I've tested will all proc-related events tests and they passed). Conversi... Constantin Asofiei
06:21 AM Base Language Feature #1608: implement full appserver support (from 4GL clients only)
I don't see the Asynchronous request object handle mentioned in this task, but please let me know if this is necessar... Constantin Asofiei
04:33 PM Base Language Feature #2002: refactor some "shared" attributes
Please go ahead with this task in combination with #1974 (#1668). Prepare a single update that cleans all of this up. Greg Shah
01:32 PM Base Language Feature #2002: refactor some "shared" attributes
I think the best grouping should be this:
# COLUMN-LABEL (BUFFER-FIELD), DATA-TYPE(BUFFER-FIELD, WIDGET), FORMAT(BUF...
Constantin Asofiei
08:51 AM Base Language Feature #2002: refactor some "shared" attributes
Except DATA-TYPE and FORMAT (which are common for BUFFER-FIELD and widgets), I don't see any way of grouping these at... Constantin Asofiei
04:20 PM Database Feature #1668: add support for additional (non-dynamic) database attributes
CORRECTION: vmn_upd20130218b.zip is what we tested; it should be overlaid with vmn_upd20130219b.zip. Eric Faulhaber
04:18 PM Database Feature #1668: add support for additional (non-dynamic) database attributes
Constantin,
We had a regression in staging for a browse column widget handle which used to do @handle.unwrapWidget...
Eric Faulhaber
01:25 PM Database Feature #1668: add support for additional (non-dynamic) database attributes
> Greg, Constantin: thoughts on how to properly support this? I added the WidthCharable (I know, lame name) interfa... Constantin Asofiei
01:10 PM Database Feature #1668: add support for additional (non-dynamic) database attributes
Update above is resubmitted Vadim Nebogatov
12:54 PM Database Feature #1668: add support for additional (non-dynamic) database attributes
Vadim Nebogatov wrote:
> IS-OPEN
> POSITION
> TABLE-HANDLE
> SESSION:FIRST-BUFFER
> (DBNAME was already supporte...
Eric Faulhaber
12:36 PM Database Feature #1668: add support for additional (non-dynamic) database attributes
IS-OPEN
POSITION
TABLE-HANDLE
SESSION:FIRST-BUFFER
(DBNAME was already supported )
Update vmn_20130219a.zip co...
Vadim Nebogatov
11:47 PM Database Feature #1668: add support for additional (non-dynamic) database attributes
Vadim Nebogatov wrote:
> I also created Sizeable/WriteableSizeable interfaces for attributes
>
> WIDTH-CHARS (KW_WID...
Eric Faulhaber
03:34 PM Base Language Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements
Feedback:
Please fix the code formatting issues in Stream.java (there are several):
1. Header # is wrong.
2. W...
Greg Shah
12:08 PM Base Language Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements
Added proposed update Costin Savin
07:07 PM Base Language Feature #1631: implement support for LANDSCAPE/PORTRAIT in I/O statements
The following is an example of the option in use:... Greg Shah
02:20 PM Base Language Feature #1632: implement _MSG() undocumented built-in function
From your status report:
> Tested the _msg function , results seems to not be consistent for the same value.
P...
Greg Shah
07:12 PM Base Language Feature #1632: implement _MSG() undocumented built-in function
This is an undocumented built-in function. We need to determine what it does. at a high level it is used to create ... Greg Shah
01:23 PM Database Feature #1992: add support for double-colon (::) syntax
>First, as I wrote above in notes 4 and 7, the second operand can be almost anything (as it is the name of a field fr... Greg Shah
12:58 PM Database Feature #1992: add support for double-colon (::) syntax
First, as I wrote above in notes 4 and 7, the second operand can be almost anything (as it is the name of a field fro... Ovidiu Maxiniuc
12:20 PM Database Feature #2000: add conversion support for table and table handle parameters
Yes, that's correct. Eric Faulhaber
12:07 PM Database Feature #2000 (WIP): add conversion support for table and table handle parameters
Am I correct that the scope of this task is
DEFINE PARAMETER TABLE
DEFINE PARAMETER TABLE-HANDLE
TABLE functio...
Stanislav Lomany
12:09 PM Base Language Feature #2011 (WIP): conversion support for _MSG() built-in
Costin Savin
07:13 PM Base Language Feature #2011: conversion support for _MSG() built-in
This task is only for time tracking and association with milestone 4. All history should be placed in the parent tas... Greg Shah
07:13 PM Base Language Feature #2011 (Closed): conversion support for _MSG() built-in
Greg Shah
05:03 AM Base Language Feature #2009 (WIP): conversion support for LANDSCAPE/PORTRAIT I/O option
Costin Savin
07:01 PM Base Language Feature #2009: conversion support for LANDSCAPE/PORTRAIT I/O option
This task is only for time tracking and association with milestone 4. All history should be placed in the parent tas... Greg Shah
07:01 PM Base Language Feature #2009 (Closed): conversion support for LANDSCAPE/PORTRAIT I/O option
Greg Shah
07:14 PM Base Language Feature #2012: runtime support for _MSG() built-in
This task is only for time tracking and association with milestone 4. All history should be placed in the parent tas... Greg Shah
07:14 PM Base Language Feature #2012 (Closed): runtime support for _MSG() built-in
Greg Shah
07:02 PM Base Language Feature #2010: runtime support for LANDSCAPE/PORTRAIT I/O options
This task is only for time tracking and association with milestone 4. All history should be placed in the parent tas... Greg Shah
07:02 PM Base Language Feature #2010 (Closed): runtime support for LANDSCAPE/PORTRAIT I/O options
Greg Shah

02/18/2013

06:48 PM User Interface Feature #1804: add missing UI attributes
The following are high priority:
FIRST-TAB-ITEM
NEXT-TAB-ITEM
HWND
Greg Shah
06:47 PM User Interface Feature #2008: runtime support for attributes in GUI
This is just for time tracking and association with milestone 4. All history should be in parent task #1804. Greg Shah
06:47 PM User Interface Feature #2008 (Closed): runtime support for attributes in GUI
Greg Shah
06:47 PM User Interface Feature #2007: conversion support for attributes
This is just for time tracking and association with milestone 4. All history should be in parent task #1804. Greg Shah
06:46 PM User Interface Feature #2007 (Closed): conversion support for attributes
Greg Shah
06:45 PM User Interface Feature #1805: add missing UI method support
The following are needed with high priority:... Greg Shah
06:44 PM User Interface Feature #2006: add runtime support for new methods in GUI
This is for time tracking and association with milestone 4 only. All updates should be placed in parent task #1805. Greg Shah
06:42 PM User Interface Feature #2006 (Closed): add runtime support for new methods in GUI
Greg Shah
06:43 PM User Interface Feature #2005: add conversion support for methods
This is for time tracking and association with milestone 4 only. All updates should be placed in parent task #1805. Greg Shah
06:41 PM User Interface Feature #2005 (Closed): add conversion support for methods
Greg Shah
06:39 PM Base Language Feature #1627: support for empty EXPORT statements
Good. Then the solution is to do the following:
1. In post_parse_fixups.rules, you should add a new rule-set like...
Greg Shah
05:35 PM Base Language Feature #1627: support for empty EXPORT statements
> Let me make sure I understand. In export_test[1-3].p, if you remove the empty EXPORT statement from those files, do... Eugenie Lyzenko
05:20 PM Base Language Feature #1627: support for empty EXPORT statements
> This redirects output to the file and produces non-empty file with real values of the variable like printing to the... Greg Shah
04:29 PM Base Language Feature #1627: support for empty EXPORT statements
> When a stream is not explicitly used (e.g. EXPORT STREAM my-stream...) then you must first redirect the terminal li... Eugenie Lyzenko
04:15 PM Base Language Feature #1627: support for empty EXPORT statements
> EXPORT cannot be used with output to the screen. (1105)
When a stream is not explicitly used (e.g. EXPORT STREAM...
Greg Shah
02:55 PM Base Language Feature #1627: support for empty EXPORT statements
The statements
EXPORT var1 (some-var2 + 54) var3.
EXPORT database-table.
both have run-time error in 4GL:
...
E...
Eugenie Lyzenko
09:59 AM Base Language Feature #1627: support for empty EXPORT statements
It is possible to have an "empty" EXPORT statement in the 4GL, as in:... Greg Shah
06:24 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Based on a review of the recent reports, the following dynamic DB attributes are in use but are not yet implemented:
...
Greg Shah
06:23 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Based on a review of the recent reports, the following dynamic DB method is in use but is not yet implemented:... Greg Shah
06:19 PM Base Language Feature #1979 (WIP): conversion support for DOM XML processing
Greg Shah
06:19 PM Base Language Feature #1640: implement DOM XML support
I have found that the following are actually in use in the application and need to be added for milestone 4:
Attri...
Greg Shah
05:49 PM Database Feature #1668: add support for additional (non-dynamic) database attributes
There are some DB attributes still missing from the checked in code:
DBNAME
IS-OPEN
POSITION
TABLE-HANDLE
SESS...
Greg Shah
12:24 PM Database Feature #1668: add support for additional (non-dynamic) database attributes
I have attached merge of previous update (vmn_upd20130218a) with current bzr
1) vmn_upd20130218a.zip - support res...
Vadim Nebogatov
05:46 PM Base Language Feature #2004: runtime support for SESSION handle
This task is just for time tracking and association with milestone 4. Put all history into the parent task #1612. Greg Shah
05:46 PM Base Language Feature #2004 (Closed): runtime support for SESSION handle
Greg Shah
05:45 PM Base Language Feature #2003: conversion support for SESSION handle
This task is just for time tracking and association with milestone 4. Put all history into the parent task #1612. Greg Shah
05:45 PM Base Language Feature #2003 (Closed): conversion support for SESSION handle
Greg Shah
05:43 PM Base Language Feature #1612: finish SESSION system handle support
The following are high priority:
Attributes:
CLIENT-TYPE
FIRST-BUFFER
NUMERIC-SEPARATOR
NUMERIC-DECIMAL-POIN...
Greg Shah
05:14 PM Base Language Feature #1608: implement full appserver support (from 4GL clients only)
I have reviewed the code, the only problem is that the unsubscribe_stmt still cannot match on the event name after th... Greg Shah
04:25 PM Base Language Feature #1608: implement full appserver support (from 4GL clients only)
Attached update with the mentioned issues fixed. Constantin Asofiei
04:19 PM Base Language Feature #1608: implement full appserver support (from 4GL clients only)
> OK, so the idea the front phase should leave the ASTs as unchaged as possible.
Yes, that's right.
> Please le...
Greg Shah
04:10 PM Base Language Feature #1608: implement full appserver support (from 4GL clients only)
> I'm in the middle of the code review, but there is at least 1 major issue. The subscribe_stmt and unsubscribe_stmt... Constantin Asofiei
03:46 PM Base Language Feature #1608: implement full appserver support (from 4GL clients only)
More Feedback:
1. handle.java is missing the "--JPRM--" in the header.
2. Is HandleChain.setType() always going...
Greg Shah
03:25 PM Base Language Feature #1608: implement full appserver support (from 4GL clients only)
Code Review Feedback:
I'm in the middle of the code review, but there is at least 1 major issue. The subscribe_st...
Greg Shah
02:32 PM Base Language Feature #1608: implement full appserver support (from 4GL clients only)
Merged with revision 10178. Constantin Asofiei
02:01 PM Base Language Feature #1608: implement full appserver support (from 4GL clients only)
Attached update provides conversion support for app-server related statements and attributes/methods. Fixes progress.... Constantin Asofiei
12:00 PM Base Language Feature #1608: implement full appserver support (from 4GL clients only)
Greg Shah wrote:
> You will have to remove the expr option from that rule.
Yes, expr from widget_qualifier is no lo...
Constantin Asofiei
10:44 AM Base Language Feature #1608: implement full appserver support (from 4GL clients only)
I don't have a problem with your approach. I think it may work, but I do suspect there will be lookahead issues. Yo... Greg Shah
08:28 AM Base Language Feature #1608: implement full appserver support (from 4GL clients only)
I think the final solution is to get rid of the allowInProc quirk and call the widget_qualifier rule (in lvalue) only... Constantin Asofiei
04:20 PM Base Language Feature #1994 (Closed): conversion support for SOAP
Greg Shah
03:13 PM Base Language Feature #2002: refactor some "shared" attributes
Please implement appropriate interfaces for the following attributes which are shared between multiple resources:
...
Greg Shah
03:04 PM Base Language Feature #2002 (Closed): refactor some "shared" attributes
Greg Shah
02:25 PM Base Language Feature #1644: implement SOAP support
No changes in generated MAJIC sources, committed to bzr revision 10178. Constantin Asofiei
09:37 AM Base Language Feature #1644: implement SOAP support
And the latest update... Constantin Asofiei
09:37 AM Base Language Feature #1644: implement SOAP support
I've removed the trailing quotes. The conversion has been started on staging (with previous generated sources backedup). Constantin Asofiei
09:24 AM Base Language Feature #1644: implement SOAP support
I am OK with the update. The only thing I suggest is that the new javadoc entries have an unmatched trailing double ... Greg Shah
09:14 AM Base Language Feature #1644: implement SOAP support
Added update merged with bzr revision 10177. Constantin Asofiei
07:58 AM Base Language Feature #1644: implement SOAP support
> For these, 4GL allows only integer and int64 values (confirmed by testing).
OK. Please use long instead of int ...
Greg Shah
03:37 AM Base Language Feature #1644: implement SOAP support
> 1. The ErrorManager.WorkArea.soapFault member needs javadoc.
OK
> 2. For int parameters to methods like getHeader...
Constantin Asofiei
01:13 PM Database Feature #1992: add support for double-colon (::) syntax
Taking into consideration a dataset handle @dh@ that contains a buffer handle @bh@ (named @bh-name@) with a character... Ovidiu Maxiniuc
12:58 PM Database Feature #1999 (WIP): add conversion support for builtin functions in a WHERE clause
Vadim Nebogatov
09:26 AM Base Language Feature #1987 (Closed): conversion support for SAX
Greg Shah
09:21 AM Base Language Feature #1620: implement EXTENT parameter support
Added testcases, for reference (they are in bzr too). Constantin Asofiei
08:29 AM Base Language Feature #1620: implement EXTENT parameter support
ca_upd20130218a.zip has been committed as 10175 (has passed regression testing). Constantin Asofiei
03:59 AM Base Language Feature #1620: implement EXTENT parameter support
This update fixes the following issues discovered on Saturday, during regression testing:
* ControlFlowOps NPE
* Bl...
Constantin Asofiei
09:18 AM Base Language Feature #1641: implement SAX XML support
The following attributes(SAX XML support) not yet implemented according to your note(a means SaxAttr, r means SaxRead... Eugenie Lyzenko
09:05 AM Base Language Feature #1641: implement SAX XML support
I have not cross-referenced your final code with the list of all possible features. Can you please make a list of al... Greg Shah
08:28 AM Base Language Feature #1641: implement SAX XML support
evl_upd20130215b.zip has been committed as 10176. Eugenie Lyzenko

02/17/2013

01:22 PM Database Feature #1668: add support for additional (non-dynamic) database attributes
I have attached update
1) vmn_upd20130217a.zip - support rest of database attributes
2) vmn_upd20130217a_test_ca...
Vadim Nebogatov
12:05 PM Base Language Feature #1644: implement SOAP support
Code Review Feedback:
1. The ErrorManager.WorkArea.soapFault member needs javadoc.
2. For int parameters to met...
Greg Shah
11:25 AM Base Language Feature #1644: implement SOAP support
OK, I understand now. Yes, this is an unfortunate side effect of our implementation. But at least the duplicate imp... Greg Shah
11:17 AM Base Language Feature #1608: implement full appserver support (from 4GL clients only)
> Do you want us to get into the high-level design of the appserver's dispatcher/thread pool, startup/shutdown/connec... Greg Shah

02/16/2013

05:15 PM Base Language Feature #1608: implement full appserver support (from 4GL clients only)
Greg: as a side-note, at this time, how much of the runtime do you want to be stubbed out ? Do you want us to get int... Constantin Asofiei
11:53 AM Base Language Feature #1608: implement full appserver support (from 4GL clients only)
> do we have handle fields in the project?
Yes. I think they may only be supported in temp-tables in the 4GL. We...
Greg Shah
10:04 AM Base Language Feature #1608: implement full appserver support (from 4GL clients only)
> 1. Determine the limits of what can be matched from the following "IN handle" cases:
For all cases, the @handle@ ca...
Constantin Asofiei
09:19 AM Base Language Feature #1608: implement full appserver support (from 4GL clients only)
> (thus the current approach of converting TRANSACTION DISTINCT to a KW_TRANS_DS token will not be correct).
You c...
Greg Shah
09:04 AM Base Language Feature #1608: implement full appserver support (from 4GL clients only)
> I assume that you don't need to change the looping of the parser. Instead you are referring to using fixups to for... Constantin Asofiei
08:32 AM Base Language Feature #1608: implement full appserver support (from 4GL clients only)
Some thoughts:
> The RUN statement's clauses can be "switched" to some extent and produce valid code in 4GL, and t...
Greg Shah
07:35 AM Base Language Feature #1608: implement full appserver support (from 4GL clients only)
And another PS: the SET clause for the ASYNCHRONOUS case behaves interesting:
* SET clause can be used without the A...
Constantin Asofiei
07:24 AM Base Language Feature #1608: implement full appserver support (from 4GL clients only)
PS: there is one syntax which can't be fixed that easy. Is related to RUN ... IN, as:... Constantin Asofiei
07:20 AM Base Language Feature #1608: implement full appserver support (from 4GL clients only)
The RUN statement's clauses can be "switched" to some extent and produce valid code in 4GL, and the conclusion is the... Constantin Asofiei
04:40 PM Database Feature #1992: add support for double-colon (::) syntax
Eric Faulhaber wrote:
> Ovidiu Maxiniuc wrote:
> > For the converted code I was thinking/investigated implementing ...
Eric Faulhaber
09:57 PM Database Feature #1992: add support for double-colon (::) syntax
Ovidiu Maxiniuc wrote:
> For the converted code I was thinking/investigated implementing directly the @::@ as a membe...
Eric Faulhaber
03:27 PM Database Feature #1949: add conversion support for database triggers
> * Do you have test cases? Please provide a separate update if those are ready.
I'll provide them.
> * There are ...
Stanislav Lomany
08:54 AM Database Feature #1949: add conversion support for database triggers
> But are you sure that WAIT-FOR can "see" DB events?
I'm mistaken on this, I was doing a @wait-for find of person.f...
Constantin Asofiei
08:41 AM Database Feature #1949: add conversion support for database triggers
There are no mixed cases in the server project. I don't have a good check for the GUI right now, but that is OK.
...
Greg Shah
08:01 AM Database Feature #1949: add conversion support for database triggers
ui_statements.rules looks OK (is built on top of H081); the only comment is about the "== true" and "!= true" tests. ... Constantin Asofiei
12:40 PM Base Language Feature #1644: implement SOAP support
> In each case where we are doing something different that the 4GL documentation, please make a statement like this:
...
Constantin Asofiei
12:26 PM Base Language Feature #1644: implement SOAP support
I will review it later today. Be prepared to merge it Monday morning with the pending 10174-10176 that is currently ... Greg Shah
12:07 PM Base Language Feature #1644: implement SOAP support
Attached update adds conversion support for SOAP-related attributes/methods and statements. Everything is stubbed, un... Constantin Asofiei
09:08 AM Base Language Feature #1644: implement SOAP support
I like the plan.
In regard to the "common" attributes (UNIQUE-ID, INSTANTIATING-PROCEDURE, LOCALNAME, NAMESPACE-UR...
Greg Shah
09:05 AM Database Feature #1586 (Closed): add quick and dirty support for word indexes using LIKE operator
Update was regression tested and checked into bzr revision 10173. Eric Faulhaber
09:01 AM Database Feature #1974: add conversion support for (non-dynamic) database attributes
Update vmn_upd20130214a.zip (see parent issue) was regression tested and checked into bzr revision 10172. Eric Faulhaber
08:56 AM Database Feature #1955 (Closed): add conversion support for CREATE-TEMP-TABLE statement
Updates (see #1652) were regression tested and checked into bzr revision 10171. Eric Faulhaber
08:55 AM Database Feature #1954 (Closed): add conversion support for CREATE QUERY statement
Updates (see #1652) were regression tested and checked into bzr revision 10171. Eric Faulhaber
08:52 AM Database Feature #1953 (Closed): add conversion support for CREATE BUFFER statement
Updates (see #1652) were regression tested and checked into bzr revision 10171. Eric Faulhaber
02:42 AM Base Language Feature #1620: implement EXTENT parameter support
This update:
- fixes decimals clause for 1-extent fields.
- fixes javadoc
- adds a TODO in decimal.setPrecision, f...
Constantin Asofiei
07:44 PM Base Language Feature #1620: implement EXTENT parameter support
FYI, there are some javadoc errors. You can fix them later (in a different check in).... Greg Shah
07:25 PM Conversion Tools Feature #2001 (Closed): reporting v2.5
Greg Shah
07:07 PM Base Language Feature #1641: implement SAX XML support
This is merged on top of ca_upd20130215d.zip (#1608) and ca_upd20130215e.zip (#1620 and #1621). It MUST be applied A... Greg Shah

02/15/2013

06:07 PM Database Feature #2000 (Closed): add conversion support for table and table handle parameters
Eric Faulhaber
05:47 PM Base Language Feature #1641: implement SAX XML support
It looks good. I will merge it on top of Constantin's update and upload the result here. Greg Shah
05:21 PM Base Language Feature #1641: implement SAX XML support
The update merged with bzr 10173 has been uploaded. Eugenie Lyzenko
02:06 PM Base Language Feature #1641: implement SAX XML support
I appreciate it, but there are 3 of us that need to merge and it will be easier to use bzr. Greg Shah
02:00 PM Base Language Feature #1641: implement SAX XML support
> Normally, we only check in after everything is passed in regression testing. For today only, I have asked Eric to c... Eugenie Lyzenko
01:46 PM Base Language Feature #1641: implement SAX XML support
Normally, we only check in after everything is passed in regression testing. For today only, I have asked Eric to ch... Greg Shah
01:21 PM Base Language Feature #1641: implement SAX XML support
> ...
> 2. Merge with the bzr check-ins that should happen from the updates being tested in staging.
> ...
Does ...
Eugenie Lyzenko
12:35 PM Base Language Feature #1641: implement SAX XML support
Code Review Feedback:
1. Change the Abstract and class Javadoc in XmlFactory and XEntity so that they mention both...
Greg Shah
05:07 PM Database Feature #1999: add conversion support for builtin functions in a WHERE clause
The following builtin functions are used within a WHERE clause in the current project (in order of most to least used... Eric Faulhaber
04:47 PM Database Feature #1999 (Closed): add conversion support for builtin functions in a WHERE clause
Eric Faulhaber
04:17 PM Database Feature #1949: add conversion support for database triggers
Code review 20130213a:
Overall, this first drop looks quite good, though honestly it's such a big set of changes i...
Eric Faulhaber
03:22 PM Database Feature #1890: upgrade to the latest stable PLJava and ensure that it is available on all target ...
h2. From the PL/Java mailing list (potentially helpful for Linux 64bit and Java 7)...
Send Pljava-dev mailing list...
Eric Faulhaber
03:22 PM Base Language Feature #1620: implement EXTENT parameter support
Attached update merged with bzr revision 10173. Constantin Asofiei
12:09 PM Base Language Feature #1620: implement EXTENT parameter support
Unfortunately the conversion on the linux box crashed when it was almost at the end, so I will not have a conclusion ... Constantin Asofiei
11:32 AM Base Language Feature #1620: implement EXTENT parameter support
OK, I've checked again and looks like I've been miss-interpreting the diff result, this update actually solves the is... Constantin Asofiei
11:26 AM Base Language Feature #1620: implement EXTENT parameter support
Do these problems already exist in Majic today? Greg Shah
11:20 AM Base Language Feature #1620: implement EXTENT parameter support
What I'm currently reconverting doesn't fix the dead-vars emitted in validateExpression and validateMessage methods. ... Constantin Asofiei
11:12 AM Base Language Feature #1620: implement EXTENT parameter support
The code looks good. Assuming your tests show that it needs no further changes, the plan is as follows:
1. As soo...
Greg Shah
07:02 AM Base Language Feature #1620: implement EXTENT parameter support
After checking the converted sources, the following issues were fixed/found:
# in some programs, the validation expr...
Constantin Asofiei
12:52 PM Base Language Feature #1608: implement full appserver support (from 4GL clients only)
The delete widget changes look good. We will keep it separate from the rest of the appserver update and instead incl... Greg Shah
12:19 PM Base Language Feature #1608: implement full appserver support (from 4GL clients only)
PS: I suggest to test and release this together with the #1620 changes, as we will be able to integrate the Deletable... Constantin Asofiei
12:12 PM Base Language Feature #1608: implement full appserver support (from 4GL clients only)
This update adds the Deletable interface and DELETE WIDGET support (note that with DELETE WIDGET any kind of resource... Constantin Asofiei
09:37 AM Base Language Feature #1608: implement full appserver support (from 4GL clients only)
Interesting finding. The permutations never seem to end. This also has implications about our runtime implementatio... Greg Shah
09:17 AM Base Language Feature #1608: implement full appserver support (from 4GL clients only)
OK, I will work on this. I will not push this change to all resources yet, only to what we are currently working.
...
Constantin Asofiei
09:11 AM Base Language Feature #1608: implement full appserver support (from 4GL clients only)
Good idea. Please go with the Deletable approach.
Also: please add support for DELETE WIDGET, which is the equiva...
Greg Shah
08:55 AM Base Language Feature #1608: implement full appserver support (from 4GL clients only)
A note about delete: currently, each deletable resource must be registered in HandleOps.delete and call its dedicated... Constantin Asofiei
12:33 PM Database Feature #1668: add support for additional (non-dynamic) database attributes
Attached is an updated version of your last code drop, merged with newer levels of Ovidiu's code, with which this upd... Eric Faulhaber
12:31 PM Database Feature #1586: add quick and dirty support for word indexes using LIKE operator
Sorry, I misspoke (mistyped?) in my last update. I made some minor changes to the 20130212c drop to merge with newer... Eric Faulhaber
10:07 AM Database Feature #1586 (Test): add quick and dirty support for word indexes using LIKE operator
We are regression testing the update as is, which contains conversion support and some of the runtime implementation.... Eric Faulhaber
11:27 AM Database Feature #1947: add conversion support for database methods
Yes, please do. Greg Shah
11:25 AM Database Feature #1947: add conversion support for database methods
Greg Shah wrote:
> This is a conversion time problem only (since it is in the parser, which has no runtime implicati...
Vadim Nebogatov
11:02 AM Database Feature #1947: add conversion support for database methods
This is a conversion time problem only (since it is in the parser, which has no runtime implications). Greg Shah
11:01 AM Database Feature #1947: add conversion support for database methods
Vadim Nebogatov wrote:
> Do you mean runtime? In conversion time
>
> FIND FIRST btest WHERE NO-LOCK.
>
> is c...
Eric Faulhaber
10:55 AM Database Feature #1947: add conversion support for database methods
Greg Shah wrote:
> There is a bug related to the parser changes for making the lock types into literals:
>
> [......
Vadim Nebogatov
07:56 AM Database Feature #1947: add conversion support for database methods
There is a bug related to the parser changes for making the lock types into literals:... Greg Shah
11:17 AM Base Language Feature #1994 (WIP): conversion support for SOAP
Constantin Asofiei
11:15 AM Database Bug #1914: database conversion requires Internet connectivity
The stacktrace for this error is:... Constantin Asofiei
11:02 AM Base Language Feature #1644: implement SOAP support
Implementation details:
* SOAPFactory - class with APIs for CREATE SOAP-HEADER and CREATE SOAP-HEADER-ENTRYREF state...
Constantin Asofiei
 

Also available in: Atom