FWD

09/02/2014

11:40 AM User Interface Feature #1793 (Review): improve color support

Here are my latest changes on color improvements:
- synchronization state between server and client.
- default syst... Marius Gligor

10:19 AM Base Language Bug #2367: re-connecting an appserver agent after a hard client termination

Code Review 0902a
The changes look good. Greg Shah

09:59 AM Base Language Bug #2367: re-connecting an appserver agent after a hard client termination

Constantin Asofiei wrote:
> Ovidiu, attached update should fix the remaining problem. The solution was to make the ... Ovidiu Maxiniuc

06:20 AM Base Language Bug #2367: re-connecting an appserver agent after a hard client termination

Ovidiu, attached update should fix the remaining problem. The solution was to make the (queue state check, add sessi... Constantin Asofiei

04:53 AM Base Language Bug #2367: re-connecting an appserver agent after a hard client termination

Ovidiu, you are correct, if the client is killed just before the session listener is registered, we still have proble... Constantin Asofiei

09:59 AM User Interface Feature #2252: implement GUI client support

Greg Shah wrote:
> Code Review hc_upd20140831a
>
> Wow, that is a lot of work! It took me many hours to review th... Hynek Cihlar

09:49 PM User Interface Feature #2252: implement GUI client support

Code Review hc_upd20140831a
Wow, that is a lot of work! It took me many hours to review that update. Generally, I... Greg Shah

09/01/2014

05:04 PM User Interface Feature #1791: implement dynamic UI support

Another update today for review. I've faced another issues with lost @UNINITIALIZED@ state. In this update all constr... Eugenie Lyzenko

02:21 PM User Interface Feature #1791: implement dynamic UI support

Code Review 0829a/b and 0901a
I am fine with the changes. Greg Shah

04:03 AM User Interface Feature #1791: implement dynamic UI support

The next update for your review.
Looks like I've found the issue resolution. We need to initialize the state map f... Eugenie Lyzenko

04:26 PM Base Language Bug #2367: re-connecting an appserver agent after a hard client termination

Constantin,
I tested on Linux/PostgreSQL with bzr rev 10603 and your update 0806b, @initial_agents@, @min_agents@ a... Ovidiu Maxiniuc

10:40 AM Base Language Bug #2367: re-connecting an appserver agent after a hard client termination

Constantin Asofiei wrote:
>
> Eric: as Ovidiu is away, please do a quick test on the server project, by killing th... Ovidiu Maxiniuc

02:10 PM User Interface Feature #2252: implement GUI client support

I'm trying to test the following update with the last remarks and got strange behavior. It shows window button on the... Vadim Gindin

08/31/2014

06:06 PM User Interface Feature #2252: implement GUI client support

Attached are changes related to #2323 - refactor coordinate system and implement GUI coordinate support.
What's in... Hynek Cihlar

02:29 PM User Interface Feature #2252: implement GUI client support

I retested implicit pause cases and PAUSE BEFORE HIDE statement to research behavior of THIS-PROCEDURE:CURRENT-WINDOW... Vadim Gindin

11:16 PM Database Support #2383: write an SQL script to verify all UDFs for built-in functions work once p2jpl.jar ...

The @p2jpl.jar@ contains a subset of the full P2J runtime classes. We recently found (in #2362) that one of the Progr... Eric Faulhaber

11:08 PM Database Support #2383 (New): write an SQL script to verify all UDFs for built-in functions work once p2jp...

Eric Faulhaber

08/29/2014

06:19 PM Database Bug #2382: Improve format string error handling in ADD-NEW-FIELD implementation

Some additional problems with @date@ type:
1) IllegalStateException at @DynamicTablesHelper:797@ (missed date and ... Vadim Nebogatov

06:09 PM User Interface Feature #1791: implement dynamic UI support

Unfortunately at least one regression I have already found. Consider pressing 'V' from main menu.
The current screen... Eugenie Lyzenko

05:54 PM User Interface Feature #1791: implement dynamic UI support

These two updates for review contain fixed login related classes, including one from timco majic related sources. I m... Eugenie Lyzenko

09:17 AM User Interface Feature #1791: implement dynamic UI support

Code Review 0828a
I am fine with the changes. Greg Shah

09:09 AM User Interface Feature #1791: implement dynamic UI support

> all we need is to properly clean up after finish, correct?
You may also need these widgets to be in the @WidgetR... Greg Shah

08:05 PM User Interface Feature #1791: implement dynamic UI support

Update for review includes:
1. Renaming @ScreenBuffer@ helper method to bitwise AND the state.
2. Adding helper met... Eugenie Lyzenko

12:27 PM User Interface Feature #1793: improve color support

> I think that we have do some changes here in order to accommodate our needs for GUI drivers perhaps on another Redm... Greg Shah

12:18 PM User Interface Feature #1793: improve color support

1. The P2J implementation for LOAD, USE and UNLOAD statements is conforming with OpenEdge manual.
It works only if ... Marius Gligor

09:01 AM User Interface Feature #2252: implement GUI client support

Code Review 0827a
1. In @GuiOutputManager@ you ask @// TODO added to try. Fix this later. Was WindowConfig.SESSION... Greg Shah

08/28/2014

05:44 PM Database Bug #2382: Improve format string error handling in ADD-NEW-FIELD implementation

Attached tests for different data types reproducing some errors.
@decimal, integer@
errors with different comb... Vadim Nebogatov

12:14 PM Database Bug #2382 (New): Improve format string error handling in ADD-NEW-FIELD implementation

Vadim Nebogatov

05:18 PM User Interface Feature #1791: implement dynamic UI support

> Please check all Authenticator implementations for how the widget IDs are computed.
Except GenericFrame(server s... Eugenie Lyzenko

02:29 PM User Interface Feature #1791: implement dynamic UI support

Eugenie Lyzenko wrote:
> 1. Consider the code @src/aero/timco/majic/security/LoginClient.java@.
Please check all A... Constantin Asofiei

11:48 AM User Interface Feature #1791: implement dynamic UI support

>3. Why do you have buffer.size() < size as a condition in ScreenBuffer.isValidId()?
Yes I had to put the describi... Eugenie Lyzenko

11:19 AM User Interface Feature #1791: implement dynamic UI support

> It has ID assignments completely different from new approach(and moreover it differs from old one too).
LoginCli... Greg Shah

11:03 AM User Interface Feature #1791: implement dynamic UI support

Code Review 0827a
1. In @ScreenBuffer@, you chose to start with an empty state map instead of one populated by UNI... Greg Shah

10:05 PM User Interface Feature #1791: implement dynamic UI support

Found a way to debug login screen locally by tunneling server port @3434@ and using @-i1@ instance to remote connecti... Eugenie Lyzenko

04:19 PM User Interface Feature #2252: implement GUI client support

6) StatusLineGuiImpl.draw is not called at all and message string is not displayed in the status line of any open win... Vadim Gindin

04:17 PM User Interface Feature #2252: implement GUI client support

I faced with the following problems.
1) We probably do not need to use contsant session window ID everywhere or we... Vadim Gindin

03:48 PM User Interface Feature #1793: improve color support

> Because system colors are not part of 4GL environment I think that system color table should be stored on server di... Greg Shah

03:32 PM User Interface Feature #1793: improve color support

Code Review 0828a
The code is fine. I like the direction it is moving. Greg Shah

12:55 PM User Interface Feature #1793: improve color support

> we need to ensure that .ini files can be specified for normal users, batch processes and appserver agents
Yes.
... Greg Shah

09:08 AM User Interface Feature #1793: improve color support

Here are my latest changes for COLOR-TABLE implementation.

1. The management of COLOR-TABLE is done now on server... Marius Gligor

04:30 AM User Interface Feature #1793: improve color support

Greg Shah wrote:
> As you note, there is no reason we can't use stanza-based INI files on non-Windows platforms. In... Constantin Asofiei

08/27/2014

06:51 PM User Interface Feature #1791: implement dynamic UI support

Some considerations and questions to discuss for inline widget ID calculation in current code. I have found new place... Eugenie Lyzenko

05:40 PM User Interface Feature #1791: implement dynamic UI support

This update for review includes:
1. Several fixes for @ThinClient.(get|set)ScreenBuffer()@ and @GenericFrame.getScre... Eugenie Lyzenko

09:56 AM User Interface Feature #1793: improve color support

Constantin Asofiei wrote:
> Marius Gligor wrote:
> > I found a conversion problem and cannot fix it. Both @COLOR-TA... Marius Gligor

07:06 AM User Interface Feature #1793: improve color support

Marius Gligor wrote:
> I found a conversion problem and cannot fix it. Both @COLOR-TABLE@ and @FONT-TBALE@ have a @N... Constantin Asofiei

06:34 AM User Interface Feature #1793: improve color support

I found a conversion problem and cannot fix it. Both @COLOR-TABLE@ and @FONT-TBALE@ have a @NUM-ENTRIES@ attribute.
... Marius Gligor

08/26/2014

05:52 PM Base Language Bug #2367: re-connecting an appserver agent after a hard client termination

Code Review 0806b
Wow! That is tricky code with lots of subtlety. You documented it well and the approach makes ... Greg Shah

04:47 PM Base Language Bug #2367 (WIP): re-connecting an appserver agent after a hard client termination

This one was tricky to duplicate and even trickier to solve. The cause is this: if the appserver client terminates t... Constantin Asofiei

02:52 PM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

> In out code, we add extra new line only for MODE_EXPORT, but in this situation we need to add extra line only when ... Greg Shah

02:04 PM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

I know, that 4gl documentation is not always correct, but there is next paragraph in @put@ statement:
>UNFORMATTED
... Evgeny Kiselev

01:32 PM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

Greg Shah wrote:
> I still don't know the answer to this question from note 87.
>
> And I would like to know your... Evgeny Kiselev

10:34 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

Code Review 0820a
I am fine with the changes.
> However, I think the problems 10/11 in #1629 note 17 will NOT b... Greg Shah

09:45 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

Evgeny Kiselev wrote:
> Before merge this update have been passed regression testing, but now it not compile because... Constantin Asofiei

08:35 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

fix problem described in note 86
fix issues from note 87
merged with latest revision
Before merge this update ha... Evgeny Kiselev

05:46 AM User Interface Feature #2252: implement GUI client support

Greg Shah wrote:
> > About ca_upd20140808c.zip: as code touched by this update seems to be affected by other tasks, ... Constantin Asofiei

02:31 AM User Interface Feature #2381: implement PUT-KEY-VALUE COLOR (n | ALL)

Marius Gligor wrote:
> PUT-KEY-VALUE COLOR (n | ALL) is used to save COLOR-TABLE of current environment on a persist... Marius Gligor

02:28 AM User Interface Feature #2381 (New): implement PUT-KEY-VALUE COLOR (n | ALL)

Marius Gligor

08/25/2014

03:29 PM User Interface Feature #1793: improve color support

> 5. In P2J the COLOR-TABLE management is done on each environment on the client side. That's why all server API for ... Greg Shah

03:16 PM User Interface Feature #1793: improve color support

Code Review 0825a
I'm fine with the changes. Greg Shah

03:05 PM User Interface Feature #1793: improve color support

Code Review 0822b
1. Minor javadoc changes to @getLegacyPlatform()@:
@specify a legacy platform regarding the r... Greg Shah

02:47 PM User Interface Feature #1793: improve color support

If we decide to load and store custom environments also on server side like default environment we could move the cod... Marius Gligor

02:18 PM User Interface Feature #1793: improve color support

> In conclusion I think that we have to follow the same behaviour and implements a mechanism to save COLOR-TABLE some... Greg Shah

10:47 AM User Interface Feature #1793: improve color support

Here are my changes after your code review for 0814a on note 9.
Also I did new tests this time using @LOAD@ @USE@ an... Marius Gligor

11:01 AM Bugs Bug #2380 (Rejected): NullPointerException when widget set to visible in CREATE statement

This is a known problem that will be resolved as part of #1791. Our dynamic widget support is not yet functional. W... Greg Shah

10:59 AM Bugs Bug #2380: NullPointerException when widget set to visible in CREATE statement

The following sample causes an NPE when run converted in P2J:... Greg Shah

10:58 AM User Interface Feature #1791: implement dynamic UI support

> The suggested fix is:
I don't see any reason to enter the @synchronized@ block. Entering it obtains the lock fo... Greg Shah

10:48 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

OK, that makes more sense now. What do you suggest? Greg Shah

10:00 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

Here is my stacktrace:... Evgeny Kiselev

09:24 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

> problem with @put unformatted "~n ".@:
> ...
> and in method com.goldencode.p2j.util.Stream#generateFormattedText... Greg Shah

10:25 AM User Interface Feature #2252: implement GUI client support

> any widget resource requiring access to these attributes (from either server or client side) will interrogate the c... Greg Shah

10:09 AM User Interface Feature #2252: implement GUI client support

> About ca_upd20140808c.zip: as code touched by this update seems to be affected by other tasks, I think I should rel... Greg Shah

08/24/2014

04:46 PM Bugs Bug #2380 (Rejected): NullPointerException when widget set to visible in CREATE statement

Hynek Cihlar

08/22/2014

04:14 PM User Interface Feature #1791: implement dynamic UI support

Two more issues has been found during testing:
1. NullPointer exception in code @LogicalTerminal.deregisterFrameCont... Eugenie Lyzenko

08:27 AM User Interface Feature #1791: implement dynamic UI support

Code Review 0821a
I'm fine with the changes. Let's get this through testing. You can fix the memory leak in the ... Greg Shah

06:42 AM User Interface Feature #1791: implement dynamic UI support

Greg Shah wrote:
> # @LT.releaseSharedFrame()@ is the only way that shared frames actually "go away" permanently. U... Constantin Asofiei

08:49 PM User Interface Feature #1791: implement dynamic UI support

Looks like I've found the root cause. It really the interference of new ID approach and old one. The method is @Widge... Eugenie Lyzenko

02:28 PM User Interface Feature #2252: implement GUI client support

About ca_upd20140808c.zip: as code touched by this update seems to be affected by other tasks, I think I should relea... Constantin Asofiei

02:26 PM User Interface Feature #2252: implement GUI client support

About note 157/158, the work for #2254 and sync'ing the server and client-side widget states. Unfortunately, there i... Constantin Asofiei

12:43 PM User Interface Feature #1793: improve color support

The attached archive @0822b@ contains implementation of @EnvironmentOps.getLegacyPlatform()@ Marius Gligor

11:03 AM User Interface Feature #1793: improve color support

Digging in the customer's @OE 10.2b@ environment I found the configuration file progress.ini which contains among oth... Marius Gligor

08:53 AM User Interface Feature #1793: improve color support

Code Review 0822a
The changes are fine.
> the code inside ColorSpec class is running only on the server side, ... Greg Shah

07:17 AM User Interface Feature #1793: improve color support

Here are my changes for COLOR phrase implementation as a result of your code review.
1. Regarding platform detecti... Marius Gligor

09:32 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

problem described in note 86 divide into 2 problems:
1) incorrect position for message method with redirected stream ... Evgeny Kiselev

08/21/2014

06:33 PM Database Feature #2220: dynamic query methods which require implementation

Rules from note 41 apply to multi-table queries as well. Stanislav Lomany

01:38 PM User Interface Feature #2252: implement GUI client support

Committed to bzr with rev 10600. Vadim Gindin

01:17 PM User Interface Feature #2252: implement GUI client support

> Previous update passed regression testing. Can I commit it?
Yes, please do. Greg Shah

01:16 PM User Interface Feature #2252: implement GUI client support

Previous update passed regression testing. Can I commit it? Vadim Gindin

08:42 AM User Interface Feature #2252: implement GUI client support

Code Review 0821a
I like the way this is going. Moving the @Window@ functionality from @static@ to non-@static@ i... Greg Shah

04:35 AM User Interface Feature #2252: implement GUI client support

> What happens if CURRENT-WINDOW is unrealized?
DEFAULT-WINDOW is used
I've added some client implementation for ... Vadim Gindin

11:42 AM User Interface Feature #1793: improve color support

Code Review 0821a
I like the result. Some minor feedback:
1. All data members should be at the top of the clas... Greg Shah

11:17 AM User Interface Feature #1793: improve color support

I've created #2379 to capture the work item for adding color support to the native Windows console (ChUI) client. We... Greg Shah

10:58 AM User Interface Feature #1793: improve color support

The attached archive contains my changes which I made to implements COLOR phrase for ChUI interfaces.
The @protermca... Marius Gligor

11:16 AM User Interface Feature #2379 (New): implement color support in the Windows native console (ChUI) client

Greg Shah

11:15 AM User Interface Feature #2378: implements dos-hex-attribute of COLOR phrase

See notes 11 and 12 in #1793 for details of previous research. Greg Shah

08/20/2014

05:47 PM User Interface Feature #1793: improve color support

Enums have the advantage of being very concise in syntax and being easy to read/understand/use. The down side of usi... Greg Shah

05:44 PM User Interface Feature #1793: improve color support

Question from MAG:
ColorPalette should holds multiple entries depending on platform Linux or Windows. ColorPalette... Greg Shah

04:18 PM User Interface Feature #1791: implement dynamic UI support

The update certainly has a regressions in frame ID handling(on client side I guess). After main syman menu displaying... Eugenie Lyzenko

10:32 AM User Interface Feature #1791: implement dynamic UI support

Sorry, I did not remove @ClientIdHelper@ from old location, so 0820a has two files with same class. Repackaged in 082... Eugenie Lyzenko

09:46 AM User Interface Feature #1791: implement dynamic UI support

Code Review 0820a
I like the changes. Well done.
> If you do not mind I'll start the runtime regression testin... Greg Shah

09:42 AM User Interface Feature #1791: implement dynamic UI support

This update for your review moves the @INPUT_FRAME_ID@ constant to @WidgetId@ class. The @WIDGET_ID_RANGE_BEGIN@ now ... Eugenie Lyzenko

08:18 AM User Interface Feature #1791: implement dynamic UI support

> I think these widgets do not have the server side counterpart because they exist only at editing time.
Yes.
>... Greg Shah

09:15 AM User Interface Feature #2252: implement GUI client support

Code Review 0820a
The changes look fine.
> Implicit Pause behaves exactly as explicit: uses CURRENT-WINDOW.
... Greg Shah

02:27 AM User Interface Feature #2252: implement GUI client support

I've tested implicit pause cases, listed in the note №160. Implicit Pause behaves exactly as explicit: uses CURRENT-W... Vadim Gindin

08/19/2014

06:54 PM User Interface Feature #1791: implement dynamic UI support

Also I guess this artificial frame and fill-in will neither be in widget registry not the part of server side frame. ... Eugenie Lyzenko

06:46 PM User Interface Feature #1791: implement dynamic UI support

>Does it work? :) Please test it with standalone testcases, including shared frames.
Yes, but there is one little ... Eugenie Lyzenko

05:32 PM User Interface Feature #1791: implement dynamic UI support

Code Review 0819a
I like it.
Does it work? :) Please test it with standalone testcases, including shared fra... Greg Shah

03:42 PM User Interface Feature #1791: implement dynamic UI support

This update for your review includes:
1. Methods renaming for @registerWidgetIdObject()@, @deregisterWidgetIdObject(... Eugenie Lyzenko

05:55 AM User Interface Feature #1791: implement dynamic UI support

Eugenie Lyzenko wrote:
> >We can remove the @LT.activateSharedFrame()@ method completely.
>
> In this case we nee... Greg Shah

05:37 AM User Interface Feature #1791: implement dynamic UI support

>We can remove the @LT.activateSharedFrame()@ method completely.
In this case we need to move the work this method... Eugenie Lyzenko

10:41 PM User Interface Feature #1791: implement dynamic UI support

> The problem here is sharedframereg is a map of <id, GenericFrame> while widget registry is a map of <id, GenericWid... Greg Shah

01:41 PM User Interface Feature #2378 (New): implements dos-hex-attribute of COLOR phrase

Marius Gligor

12:53 PM User Interface Feature #1793: improve color support

These are very good findings.
> 8. I could not do tests using dos-hex-attribute on Windows ChUI (see 2-b) However ... Greg Shah

12:07 PM User Interface Feature #1793: improve color support

Here are my conclusion doing some "researches" on color implementation for ChUI and GUI interfaces on Linux OS/ Windo... Marius Gligor

08:37 PM User Interface Feature #1793: improve color support

> The valuse are stored on Windows registry and are used by Windows GUI widgets.
> I think that our GUI implementati... Greg Shah

08:34 PM User Interface Feature #1793: improve color support

Code Review 0814a
1. Line 463 of language_statements.rules has a reference to KW_FONT.
2. The progress.g change... Greg Shah

08/18/2014

07:45 PM User Interface Feature #1791: implement dynamic UI support

>The processing of LT.replaceFrame() probably needs to remap the new frame's contained widgets into the widget regist... Eugenie Lyzenko

07:22 PM User Interface Feature #1791: implement dynamic UI support

>11. Once the client has actually hidden the frame, it will notify the server and in the LT.applyChanges() method, ... Eugenie Lyzenko

05:43 PM User Interface Feature #1791: implement dynamic UI support

>I think the sharedframereg is NOT needed after your changes. It is only used to make sure that shared frame IDs are ... Eugenie Lyzenko

04:37 PM User Interface Feature #1791: implement dynamic UI support

Eugenie Lyzenko wrote:
> >5. The deregisterFrameContent() code should still have the locking implemented...
>
> Y... Greg Shah

04:35 PM User Interface Feature #1791: implement dynamic UI support

In regard to the shared frame processing, it is quite complex. I'm not sure that our basic approach is 100% correct.... Greg Shah

04:16 PM User Interface Feature #1791: implement dynamic UI support

>5. The deregisterFrameContent() code should still have the locking implemented...
You mean @private deregisterFra... Eugenie Lyzenko

01:10 PM User Interface Feature #1791: implement dynamic UI support

Code Review 0818a
1. Please rename the following:
@registerWidgetIdObject()@ to @registerWidget()@
@deregister... Greg Shah

09:51 AM User Interface Feature #1791: implement dynamic UI support

Adding some improvements in this update:
1. Deregister frame when it is destroyed
2. Adding static method to deregi... Eugenie Lyzenko

07:49 AM User Interface Feature #1791: implement dynamic UI support

Checking the code with frame related testcases I have found potential issues with widget registry. This is related to... Eugenie Lyzenko

04:50 PM User Interface Feature #2252: implement GUI client support

Code Review vig_upd20140815a.zip
The only thing I would like to see changed is to move the common @hWin@ processin... Greg Shah

12:57 PM User Interface Feature #2252: implement GUI client support

Greg Shah wrote:
> I will handle the code review for vig_upd20140815a.zip shortly.
>
> > Only following statement... Vadim Gindin

12:28 PM User Interface Feature #2252: implement GUI client support

I will handle the code review for vig_upd20140815a.zip shortly.
> Only following statements with BEFORE-HIDE are c... Greg Shah

08:01 AM User Interface Feature #2252: implement GUI client support

Greg Shah wrote:
>
> Also, do check in your testcases.
Due to the customer server outage I have committed the t... Hynek Cihlar

08/16/2014

06:24 PM User Interface Feature #1791: implement dynamic UI support

This update adds more cleanup for frame deregistration. Looks like we need to remove widgets even when the frame is m... Eugenie Lyzenko

08/15/2014

04:03 PM Database Feature #2376: retain bulk getter/setter methods for custom denormalized extent fields

Test cases are checked in to testcases/uast/denormalization folder. Vadim Nebogatov

03:56 PM Database Feature #2376: retain bulk getter/setter methods for custom denormalized extent fields

Test @testcases/uast/denormalization/bulk3@:... Vadim Nebogatov

12:42 PM Database Feature #2376: retain bulk getter/setter methods for custom denormalized extent fields

Test @testcases/uast/denormalization/bulk2@:... Vadim Nebogatov

04:00 PM Database Feature #2134: configurable denormalization of extent fields into individual fields in schema con...

Test cases are checked in to @testcases/uast/denormalization@ folder. Vadim Nebogatov

03:21 PM User Interface Feature #2252: implement GUI client support

> Change the int data type to double for all existing data structures and attributes holding character coordinate val... Greg Shah

01:58 PM User Interface Feature #2252: implement GUI client support

*About PAUSE statements list*. Only following statements with BEFORE-HIDE are correct from the Progress point of view... Vadim Gindin

09:09 AM User Interface Feature #2252: implement GUI client support

I would like to do some real work (read code changes) on the GUI coordinate support (#2323). The following are the st... Hynek Cihlar

03:15 PM User Interface Feature #1791: implement dynamic UI support

This update for your review includes:
1. Operations with widget registry are now have protection locking
2. Addin... Eugenie Lyzenko

03:05 PM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

Code Review 0812a
The proposed code can be accepted with only some minor changes (listed below).
However, I t... Greg Shah

04:50 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

update:
1) rollback isTerm() method
2) rollback ThinClient(described below)
3) I've added in StreamFactory next co... Evgeny Kiselev

08/14/2014

06:33 PM User Interface Feature #1791: implement dynamic UI support

> The question: the map has data pair <Integer,GenericWidget>. On the other hand we can(and other maps uses this) use... Greg Shah

06:20 PM User Interface Feature #1791: implement dynamic UI support

Code Review 0814b
1. The locking for the widget registry (and frame registries...) needs to be improved. Right no... Greg Shah

05:12 PM User Interface Feature #1791: implement dynamic UI support

The next update for your review contains widget ID registry implementation in addition to other notes resolution. The... Eugenie Lyzenko

02:06 PM User Interface Feature #1791: implement dynamic UI support

> May be it is better to move ClientIdHelper class to com.goldencode.p2j.ui.chui package(the same place as ThinClient... Greg Shah

02:05 PM User Interface Feature #1791: implement dynamic UI support

Code Review 0814a
Yes, the approach is correct. Some minor feedback:
1. The @ClientIdHelper@ should be in the ... Greg Shah

02:01 PM User Interface Feature #1791: implement dynamic UI support

The question. May be it is better to move @ClientIdHelper@ class to @com.goldencode.p2j.ui.chui@ package(the same pla... Eugenie Lyzenko

11:44 AM User Interface Feature #1791: implement dynamic UI support

This update for review reflects the recent notes to using @ThinClient@ or @LogicalTerminal@ to work with ID. I need t... Eugenie Lyzenko

08:37 AM User Interface Feature #1791: implement dynamic UI support

Code Review 0813a
This version is very good.
My only concern is how this will work in certain scenarios like ... Greg Shah

05:03 PM Database Feature #2220: dynamic query methods which require implementation

>Please report the test cases you used to determine these rules and check them into the testcases project if you have... Stanislav Lomany

11:58 AM Database Feature #2220: dynamic query methods which require implementation

Stanislav Lomany wrote:
> I finally got caching rules for adaptive queries (single-table):
> # Cache is advanced in... Eric Faulhaber

11:41 AM Database Feature #2220: dynamic query methods which require implementation

I finally got caching rules for adaptive queries (single-table):
# Cache is advanced in forward (if the first iterat... Stanislav Lomany

04:26 PM Database Feature #2376: retain bulk getter/setter methods for custom denormalized extent fields

Thanks, Vadim. So, this tells us that we do not get a runtime error in Progress when invoking BUFFER-VALUE on an exte... Eric Faulhaber

04:02 PM Database Feature #2376: retain bulk getter/setter methods for custom denormalized extent fields

Test @testcases/uast/denormalization/bulk1@:... Vadim Nebogatov

12:54 PM User Interface Feature #2252: implement GUI client support

Hynek Cihlar wrote:
> Constantin Asofiei wrote:
> > We need to decide what is the policy of pushing a certain widge... Greg Shah

12:37 PM User Interface Feature #1793: improve color support

Here is a first version of @COLOR-TABLE@ implementation.
The implementation of @COLOR-TABLE@ looks the same as @FONT... Marius Gligor

12:28 PM Database Feature #2273: address remaining limitations of SQL Server needed to support legacy 4GL behavior

Ovidiu Maxiniuc wrote:
> The cause could be @(org.eclipse.jetty.util.component.AbstractLifeCycle:WARNING) FAILED Ser... Eric Faulhaber

08:41 AM Database Bug #2222: WRITE event triggered too early

Code Review 0813a
I am fine with the changes. Greg Shah

08/13/2014

06:04 PM User Interface Feature #2252: implement GUI client support

Constantin Asofiei wrote:
> We need to decide what is the policy of pushing a certain widget config to the client:
... Hynek Cihlar

09:31 AM User Interface Feature #2252: implement GUI client support

> I will need to know not only default window from the client (static method Window.getDefaultWindow()), but also ac... Greg Shah

09:22 AM User Interface Feature #2252: implement GUI client support

About my question 4 in the note 144. I will need to know not only default window from the client (static method @Wind... Vadim Gindin

05:52 PM Database Bug #2377 (New): default buffer can be incorrectly scoped to an internal procedure

Eric Faulhaber

05:47 PM Database Bug #2222: WRITE event triggered too early

The attached update fixes a defect which enabled write triggers to corrupt the @BlockManager@'s context-local state.
... Eric Faulhaber

05:39 PM User Interface Feature #1791: implement dynamic UI support

The point to clarify:
>Please investigate keeping a single server-side registry of all widgets, including windows,... Eugenie Lyzenko

04:05 PM User Interface Feature #1791: implement dynamic UI support

Working on the point #7 from your note. But have the update to upload meantime.
In this update for review: @FrameI... Eugenie Lyzenko

06:28 AM User Interface Feature #1791: implement dynamic UI support

> I think the solution can be just replacement WindowConfig.SESSION_WINDOW_ID with WidgetId.DEFAULT_WINDOW_ID in all ... Greg Shah

05:33 PM Database Feature #2376: retain bulk getter/setter methods for custom denormalized extent fields

There appears is a hole in our current implementation of custom, denormalized extent fields, in that we have eliminat... Eric Faulhaber

11:48 AM Database Feature #2376 (Test): retain bulk getter/setter methods for custom denormalized extent fields

Eric Faulhaber

04:35 PM Database Feature #2273: address remaining limitations of SQL Server needed to support legacy 4GL behavior

The conversion test was successful, there are no changes in the ddl code, only the @.hbm.xml@ are affected: and extra... Ovidiu Maxiniuc

06:17 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

Evgeny Kiselev wrote:
> Also When we removed isTerm() method, there are next possible issues:
> @RemoteStream@ had ... Constantin Asofiei

06:07 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

Also When we removed isTerm() method, there are next possible issues:
@RemoteStream@ had constructor @RemoteStream(in... Evgeny Kiselev

06:02 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

Evgeny Kiselev wrote:
> > CTRL-C part:
> > ctrlc_11_session1 step 18-28
> > ctrlc_11_session3 step 9-23, 25
> > c... Constantin Asofiei

05:55 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

> CTRL-C part:
> ctrlc_11_session1 step 18-28
> ctrlc_11_session3 step 9-23, 25
> ctrlc_11_session4 step 1-26, 28
... Evgeny Kiselev

04:47 AM Base Language Bug #2375: fix the memptr initialization (in extent) and memptr parameter processing

Attached update is a first pass at fixing the problems noted in #1635 note 29,30,31,32. Testcases which cover memptr... Constantin Asofiei

04:32 AM Base Language Bug #2375 (Closed): fix the memptr initialization (in extent) and memptr parameter processing

Constantin Asofiei

08/12/2014

07:08 PM User Interface Feature #1791: implement dynamic UI support

> 5. The @WidgetId.allocateWindowID()@ can't work for allocating anything other than the @DEFAULT-WINDOW@, which is n... Eugenie Lyzenko

10:56 AM User Interface Feature #1791: implement dynamic UI support

Code Review 0811b
1. In WidgetId, the class javadoc states "Every JVM session has it's own set of widget ID.". Th... Greg Shah

04:34 PM User Interface Feature #2252: implement GUI client support

> Do you mean WindowWidget or exactly Window?
I mean WindowWidget.
>> 4. The external LogicalTerminal.pause*()... Greg Shah

04:13 PM User Interface Feature #2252: implement GUI client support

Greg Shah wrote:
..
> 3. @isWindowRealized()@ seems like it would be best implemented inside the @Window@ widget it... Vadim Gindin

04:21 PM Base Language Bug #2338: fix _MSG function

Vadim Gindin wrote:
> Constantin Asofiei wrote:
> ..
> > * QUIT/STOP/ENDKEY conditions
>
> I didn't find a way ... Constantin Asofiei

04:07 PM Base Language Bug #2338: fix _MSG function

Constantin Asofiei wrote:
..
> * QUIT/STOP/ENDKEY conditions
I didn't find a way to test QUIT and ENDKEY conditi... Vadim Gindin

04:01 PM Database Feature #2273: address remaining limitations of SQL Server needed to support legacy 4GL behavior

Ovidiu Maxiniuc wrote:
> Eric Faulhaber wrote:
> > Code review 0811b:
> >
> > Looks good, but I have some questi... Eric Faulhaber

03:03 PM Database Feature #2273: address remaining limitations of SQL Server needed to support legacy 4GL behavior

Eric Faulhaber wrote:
> Code review 0811b:
>
> Looks good, but I have some questions:
> * In the event there is ... Ovidiu Maxiniuc

10:38 AM Database Feature #2273: address remaining limitations of SQL Server needed to support legacy 4GL behavior

Code review 0811b:
Looks good, but I have some questions:
* In the event there is no @sql-size@ hint (potentially... Eric Faulhaber

10:40 AM Database Bug #2347: hql to SQL name mapping issue

Makes sense. So no need for a separate code review here. Once that update (0811a) is finished/tested, we can close ou... Eric Faulhaber

10:30 AM Database Bug #2347: hql to SQL name mapping issue

Yes, they are part of om_upd20140811a.zip (#2332).
It's hard for me to maintain them in separate updates, at some po... Ovidiu Maxiniuc

10:22 AM Database Bug #2347: hql to SQL name mapping issue

Ovidiu, were the changes in this update rolled up into om_upd20140811a.zip (#2332)? Eric Faulhaber

09:08 AM Base Language Feature #1635: implement MEMPTR/RAW support

I'm fine with the proposed approach. My only concern is that I don't want us to spend too much time fixing this, as ... Greg Shah

05:03 AM Base Language Feature #1635: implement MEMPTR/RAW support

Greg Shah wrote:
> Code Review 0811a
>
> The changes look good. When it passes testing, please check it in and d... Constantin Asofiei

08:44 AM Database Feature #2220: dynamic query methods which require implementation

Code review 0812a:
I think it looks OK, but this whole area of the code is tricky to assess with just a review. I'... Eric Faulhaber

05:18 AM Database Feature #2220: dynamic query methods which require implementation

Fixes for testcases in notes 28 (not about flushing part, about PREV) and 34 (LAST issue). I didn't performed extensi... Stanislav Lomany

03:14 AM User Interface Feature #2144: add minimum runtime support for methods (server)

passed regression testing and committed with rev 10596. Vadim Gindin

08/11/2014

05:14 PM User Interface Feature #2144: add minimum runtime support for methods (server)

Code Review 0811b
I am fine with the changes. Greg Shah

04:42 PM User Interface Feature #2144: add minimum runtime support for methods (server)

next update with corrections Vadim Gindin

01:41 PM User Interface Feature #2144: add minimum runtime support for methods (server)

Code Review 0811a
1. This code needs @null@ protection since @query@ can be @null@.... Greg Shah

01:29 PM User Interface Feature #2144: add minimum runtime support for methods (server)

During the work on that task I found that DESELECT-ROWS is already implemented and only some error checking was neede... Vadim Gindin

05:12 PM Database Feature #2273: address remaining limitations of SQL Server needed to support legacy 4GL behavior

I have finished merging the old update with bzr rev 10595. Please see the attached update.
My simple testcases were ... Ovidiu Maxiniuc

04:26 PM Base Language Feature #1635: implement MEMPTR/RAW support

Greg Shah wrote:
> Thoughts on how to accommodate this?
Looks like this special state is preserved until the memptr... Constantin Asofiei

01:34 PM Base Language Feature #1635: implement MEMPTR/RAW support

> when memptr is set to unknown, the unknown equality test is computed different: it's like Schrodinger's cat, the me... Greg Shah

01:17 PM Base Language Feature #1635: implement MEMPTR/RAW support

Code Review 0811a
The changes look good. When it passes testing, please check it in and distribute it. Greg Shah

12:38 PM Base Language Feature #1635: implement MEMPTR/RAW support

I have some weird unknown equality test using memptr... See this test:... Constantin Asofiei

04:04 PM Documentation Feature #2346 (Closed): remote client launch documentation

There are many good ideas here.
In addition, there are some improvements that could possibly help make our brokers... Greg Shah

05:49 AM Documentation Feature #2346: remote client launch documentation

OTOH, now your reasoning about the relative paths makes sense... if the spawner can use/determine the home dir for th... Constantin Asofiei

05:40 AM Documentation Feature #2346: remote client launch documentation

Marius Gligor wrote:
> Sorry but I'm totally confused. The working directory is for OS accounts not for P2J accounts... Constantin Asofiei

05:36 AM Documentation Feature #2346: remote client launch documentation

Sorry but I'm totally confused. The working directory is for OS accounts not for P2J accounts.
When a web client is ... Marius Gligor

05:04 AM Documentation Feature #2346: remote client launch documentation

Marius Gligor wrote:
> I would like to fix the @workingDirectory@ issue and I coming with a lot of remarks:
>
> 1... Constantin Asofiei

04:15 AM Documentation Feature #2346: remote client launch documentation

I would like to fix the @workingDirectory@ issue and I coming with a lot of remarks:
1. We have the same problem o... Marius Gligor

03:48 PM User Interface Feature #2252: implement GUI client support

Constantin Asofiei wrote:
> # @ACTIVE-WINDOW@ (and maybe @CURRENT-WINDOW@ too) can be driven from the client-side; c... Constantin Asofiei

03:43 PM User Interface Feature #2252: implement GUI client support

Greg Shah wrote:
> Code Review vig_upd20140810a.zip
Some thoughts about this update:
# instead of @UiUtils.locateP... Constantin Asofiei

03:06 PM User Interface Feature #2252: implement GUI client support

Greg Shah wrote:
> Interesting. This is all caused by the PAGED option when the "terminal" is opened as a stream. ... Constantin Asofiei

01:21 PM User Interface Feature #2252: implement GUI client support

Constantin Asofiei wrote:
> That is an old assumption, which is no longer valid: the widget location can't change wi... Hynek Cihlar

01:20 PM User Interface Feature #2252: implement GUI client support

Hynek Cihlar wrote:
> Constantin Asofiei wrote:
> > The position of a widget can be set via both character-based an... Constantin Asofiei

12:41 PM User Interface Feature #2252: implement GUI client support

Code Review vig_upd20140810a.zip
The approach is moving in the right direction.
1. I would prefer to use an @in... Greg Shah

10:21 AM User Interface Feature #2252: implement GUI client support

Code Review ca_upd20140808c.zip
The changes are OK. Greg Shah

10:19 AM User Interface Feature #2252: implement GUI client support

> The idea was that this proves that GUI still handles the PUT SCREEN. But we need to make sure that the client code ... Greg Shah

03:43 PM User Interface Feature #1791: implement dynamic UI support

This update adds client/server session type checking into @EventDefinition.java@. Eugenie Lyzenko

12:04 PM User Interface Feature #1791: implement dynamic UI support

Forgot to add @ThinClient.java@ to previous update. Also the javadoc comments added in @WidhetId@ class. Eugenie Lyzenko

11:08 AM User Interface Feature #1791: implement dynamic UI support

The question/clarification for new ID approach update. I've found the class @EventDefinition@ is used on both on the ... Eugenie Lyzenko

02:58 PM User Interface Feature #2374: implement WINDOW events in GUI mode

From #2252 note 138:
> Doesn't it still generate the WINDOW-CLOSE 4GL event? It is very common to have code like ON ... Constantin Asofiei

02:57 PM User Interface Feature #2374 (Closed): implement WINDOW events in GUI mode

Constantin Asofiei

02:55 PM User Interface Feature #2373: implemented output to redirected, paged terminal via (un)named streams in GUI mode

Starting from the case in #2252-141, implement output to stream when the stream is paged/page-size is set and it targ... Constantin Asofiei

02:53 PM User Interface Feature #2373 (New): implemented output to redirected, paged terminal via (un)named streams in GU...

Constantin Asofiei

10:28 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

> tc_job_002
> tc_job_clock_002
Are these the known failures as described in our documentation?
The other prob... Greg Shah

09:51 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

Greg Shah wrote:
> We need to get this through testing. Are there any tests which are always failing?
CTRL-C part:... Evgeny Kiselev

09:48 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

OK, then we need to leave the code as:... Greg Shah

09:39 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

In @StreamWrapper@ with next code: ... Evgeny Kiselev

10:09 AM User Interface Feature #2372: implement support for PUT SCREEN in GUI

Although PUT SCREEN is documented (in the 4GL reference) as not working in GUI, in fact it can be used. However, its... Greg Shah

09:54 AM User Interface Feature #2372 (New): implement support for PUT SCREEN in GUI

Greg Shah

09:03 AM Database Bug #2350 (Closed): BUFFER-COPY errors related with copying fields with extent

Eric Faulhaber

08:44 AM Database Bug #2350: BUFFER-COPY errors related with copying fields with extent

update [vmn_upd20140807a.zip] committed to bzr rev. 10595 and distributed. Vadim Nebogatov

07:45 AM Database Bug #2350: BUFFER-COPY errors related with copying fields with extent

Please commit and distribute the 0807a update. Eric Faulhaber

05:30 AM Database Bug #2350: BUFFER-COPY errors related with copying fields with extent

Regression completed: @tc_job_clock_002@ finally passed in 20140810_163259.
Vadim Nebogatov

02:09 AM Database Support #2371: trigger behavior

h1. Database Trigger Firing Rules
h2. General Sequence
Session triggers generally fire before schema triggers, EXCE... Eric Faulhaber

12:28 AM Database Support #2371 (Closed): trigger behavior

Eric Faulhaber

08/10/2014

06:50 PM User Interface Feature #1791: implement dynamic UI support

The update is the new widget ID allocation approach for you to review. Does not include the dynamic widget ID support... Eugenie Lyzenko

04:05 PM Database Bug #2350: BUFFER-COPY errors related with copying fields with extent

Regression 20140810_120027: failed tc_job_002, tc_job_clock_002 from previous regression. Will repeat regression one ... Vadim Nebogatov

12:53 PM User Interface Feature #2252: implement GUI client support

Here is the first skeleton of implementation system handles ^-WINDOW. Could you look at it. I've added window Id para... Vadim Gindin

08/09/2014

06:42 PM Database Bug #2350: BUFFER-COPY errors related with copying fields with extent

Regression 20140809_123827: failed tc_job_002, tc_job_clock_002 from previous regression. Will repeat regression one ... Vadim Nebogatov

06:09 PM User Interface Feature #2252: implement GUI client support

Constantin Asofiei wrote:
> The position of a widget can be set via both character-based and pixel-based coordinates... Hynek Cihlar

08/08/2014

04:25 PM User Interface Feature #2252: implement GUI client support

I would summarize behavior rules of *-WINDOW system handles as follows.
Handles itself.
1. When the 4GL starts,... Vadim Gindin

03:56 PM User Interface Feature #2252: implement GUI client support

Greg Shah wrote:
> > There were two reasons I've changed them this way:
> No, your reasons make sense. Please put ... Constantin Asofiei

08:52 AM User Interface Feature #2252: implement GUI client support

Two other thoughts:
1. When the ui/chui/ code reaches a state where:
* It only has ChUI-specific code left in i... Greg Shah

08:30 AM User Interface Feature #2252: implement GUI client support

Code Review 0808b
My only concern is with the previous @ThinClient.waitForEvent()@ change:
1. Why isn't @honorS... Greg Shah

07:08 AM User Interface Feature #2252: implement GUI client support

> add multiple driver support at runtime, to allow writing to streams. This is somehow tricky, as same widget can be ... Greg Shah

06:51 AM User Interface Feature #2252: implement GUI client support

> > 4. Why are the @ChuiWidgetFactory@ and @GuiWidgetFactory@ classes modifying the return value signature to be the ... Greg Shah

06:32 AM User Interface Feature #2252: implement GUI client support

Greg Shah wrote:
> 1. The @ProcessStream@ history entry is not accurate. You are removing the unnecessary TC import... Constantin Asofiei

04:17 PM Documentation Feature #2346: remote client launch documentation

Greg Shah wrote:
> Constantin: any objections?
# the javadoc for BrokerCore.BROKER_WD is incorrect.
# setting a co... Constantin Asofiei

10:30 AM Documentation Feature #2346: remote client launch documentation

Code Review 0802a
The code is fine. I don't see much downside to providing this feature.
Constantin: any objec... Greg Shah

03:17 PM User Interface Feature #2370: finish window popup menu impl

The window popup (shown at mouse right-click on the window title or mouse click on window icon or alt+space) needs to... Constantin Asofiei

03:15 PM User Interface Feature #2370 (Closed): finish window popup menu impl

Constantin Asofiei

03:15 PM User Interface Feature #2369: add configuration for window details inherited from the OS (title, border, color, ...

See #2252 note 127. The widow details (like title font, color, icon, border, background, etc) need to be made config... Constantin Asofiei

03:14 PM User Interface Feature #2369 (Rejected): add configuration for window details inherited from the OS (title, bord...

Constantin Asofiei

03:13 PM User Interface Feature #2368: allow widget output to stream in GUI mode

In GUI mode, writing widget to streams requires access to a ChUI driver. See #2252-127. Constantin Asofiei

03:11 PM User Interface Feature #2368 (WIP): allow widget output to stream in GUI mode

Constantin Asofiei

02:10 PM User Interface Feature #1791: implement dynamic UI support

> The ID will be incrementing for new widget?
Yes.
> Meaning allocation direction from 1 to UPPER_LIMIT, correc... Greg Shah

11:54 AM User Interface Feature #1791: implement dynamic UI support

> I am interested in the results of your PAUSE version. But we already have enough knowledge to know that there are m... Eugenie Lyzenko

09:18 AM User Interface Feature #1791: implement dynamic UI support

I am interested in the results of your PAUSE version. But we already have enough knowledge to know that there are mo... Greg Shah

07:11 AM User Interface Feature #1791: implement dynamic UI support

> Make sure to run this directly from the command line (with @-p@) instead of from the procedure editor. The procedu... Eugenie Lyzenko

06:36 AM User Interface Feature #1791: implement dynamic UI support

Eugenie, check if this limit is not somehow related to some @pro@ arguments. At least for recursivity issues, I've f... Constantin Asofiei

06:15 AM User Interface Feature #1791: implement dynamic UI support

> I made simple creation loop without delete. The results vary from run to run. The maximum I've got is 9972 creatio... Greg Shah

05:46 AM User Interface Feature #1791: implement dynamic UI support

The process of ID saturation has some notes. I made simple creation loop without delete. The results vary from run to... Eugenie Lyzenko

02:07 PM Database Bug #2350: BUFFER-COPY errors related with copying fields with extent

Regression 20140808_092455: failed tc_job_002, tc_job_clock_002 from previous regression. Will repeat "main-regressio... Vadim Nebogatov

02:00 PM Base Language Feature #1635: implement MEMPTR/RAW support

> Or raw/memptr values with no data are considered not-unknown?
raw/memptr has a concept of "uninitialized". For ... Greg Shah

11:51 AM Base Language Feature #1635: implement MEMPTR/RAW support

There is a bug in the BinaryData.assign code; if a raw/memptr value is set to unknown and then assigned to something ... Constantin Asofiei

01:49 PM Base Language Bug #2367: re-connecting an appserver agent after a hard client termination

Eric: yes, both set to 1:... Ovidiu Maxiniuc

01:08 PM Base Language Bug #2367: re-connecting an appserver agent after a hard client termination

Ovidiu: this was achieved with @min_agents@ and @max_agents@ both set to 1, correct? Eric Faulhaber

01:03 PM Base Language Bug #2367: re-connecting an appserver agent after a hard client termination

Ovidiu, please try to duplicate again, and capture the server thread dump (use @jstack@ for this). I'm curious where... Constantin Asofiei

01:01 PM Base Language Bug #2367: re-connecting an appserver agent after a hard client termination

When a client abruptly terminate (killed or otherwise disconnected because of network failure) the appserver enters a... Ovidiu Maxiniuc

12:43 PM Base Language Bug #2367 (Closed): re-connecting an appserver agent after a hard client termination

Ovidiu Maxiniuc

10:26 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

I edited the previous note to fix the logic I had broken... Greg Shah

10:24 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

Code Review 0805a
I agree that an alternate approach in StreamWrapper seems more correct.
> StreamWrapper line 404:... Greg Shah

05:51 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

ctrc part passed
main part failed, but problem was in testsuit, now tests are running again.
different from previ... Evgeny Kiselev

08/07/2014

07:09 PM User Interface Feature #2252: implement GUI client support

Code Review 0806d
This is a really great step forward for the client! I was already deep into this review before ... Greg Shah

02:21 PM User Interface Feature #2252: implement GUI client support

Replacement for ca_upd20140806d.zip. It fixes a bug exposed by regression testing (related to 0806d.zip) plus:
* cur... Constantin Asofiei

11:42 AM User Interface Feature #2252: implement GUI client support

Constantin Asofiei wrote:
> > It seems that character positioning and sizing is always performed with the default fo... Hynek Cihlar

11:04 AM User Interface Feature #2252: implement GUI client support

Hynek Cihlar wrote:
> Constantin Asofiei wrote:
> > Once you have this, see what happens if the widget is moved to ... Constantin Asofiei

10:41 AM User Interface Feature #2252: implement GUI client support

Hynek Cihlar wrote:
> Greg Shah wrote:
> > > What is the correct way to move a widget from one window to another?
... Hynek Cihlar

10:35 AM User Interface Feature #2252: implement GUI client support

Greg Shah wrote:
> > What is the correct way to move a widget from one window to another?
>
> The f1 frame is nev... Hynek Cihlar

10:32 AM User Interface Feature #2252: implement GUI client support

> What is the correct way to move a widget from one window to another?
The f1 frame is never realized before the @... Greg Shah

10:10 AM User Interface Feature #2252: implement GUI client support

Constantin Asofiei wrote:
> Once you have this, see what happens if the widget is moved to a window with a different... Hynek Cihlar

06:15 PM Database Bug #2350: BUFFER-COPY errors related with copying fields with extent

Regression 20140807_101619: failed tc_job_002, tc_job_clock_002, gso178_session1, gso178_session2, gso242_session1, g... Vadim Nebogatov

03:03 PM User Interface Feature #1791: implement dynamic UI support

Interesting. We won't implement this feature right now.
Since we can't "see" the widget IDs that are generated in... Greg Shah

01:21 PM User Interface Feature #1791: implement dynamic UI support

>Probably so. Before I say for sure, please do this test: run the same test without the -usewidgetid and see if it be... Eugenie Lyzenko

11:55 AM User Interface Feature #1791: implement dynamic UI support

> This means Progress has serious constraint for using dynamic widgets
Yes.
> often delete/create is not recomm... Greg Shah

10:41 AM User Interface Feature #1791: implement dynamic UI support

Yes, you are right, just after attempt to create new widget in "wrap around" case - when widget with @ID = 1@ was jus... Eugenie Lyzenko

10:16 AM User Interface Bug #2365: ThinClient.trigger() and ThinClient.validate() must send the screen-buffer for all fra...

The original discussion in which this issue was identified:
-------- Original Message --------
Subject: Re: GUI ... Greg Shah

10:14 AM User Interface Bug #2365 (Closed): ThinClient.trigger() and ThinClient.validate() must send the screen-buffer fo...

Greg Shah

08/06/2014

06:05 PM Database Bug #2350: BUFFER-COPY errors related with copying fields with extent

Corrected update vmn_upd20140807a.zip is attached. Tests still work properly, search API (#2353) also works.
Regres... Vadim Nebogatov

03:41 PM Database Bug #2350: BUFFER-COPY errors related with copying fields with extent

Code review 20140806b:
Line 2790 catches @ConditionException@ instead of @ErrorConditionException@, as I requested... Eric Faulhaber

02:02 PM Database Bug #2350: BUFFER-COPY errors related with copying fields with extent

Corrected update vmn_upd20140806b.zip is attached, test results for note 27 are like in Progress. Regression started. Vadim Nebogatov

10:13 AM Database Bug #2350: BUFFER-COPY errors related with copying fields with extent

Code review 20140806a:
Please note the path of the source file in the zip archive is missing the leading @src/@ di... Eric Faulhaber

10:07 AM Database Bug #2350: BUFFER-COPY errors related with copying fields with extent

Your test results, where we are not returning a result for 2, 4, and 5 (while Progress returns false) tells me that w... Eric Faulhaber

09:09 AM Database Bug #2350: BUFFER-COPY errors related with copying fields with extent

Please check attached @buffer-compare-pair-list.p@. Execution results:
h3. Progress... Vadim Nebogatov

09:08 PM Database Bug #2350: BUFFER-COPY errors related with copying fields with extent

Code review 20140805a:
* As noted above, the @if@ condition at line 3662 should drop the BUFFER-COMPARE-specific p... Eric Faulhaber

08:29 PM Database Bug #2350: BUFFER-COPY errors related with copying fields with extent

Vadim Nebogatov wrote:
> Eric Faulhaber wrote:
> > Yes, it looks like that length restriction is wrong; I'm not sur... Eric Faulhaber

05:18 PM User Interface Feature #1791: implement dynamic UI support

> But now we need to differentiate the server and client context for this calculation because classes used in this pr... Greg Shah

05:16 PM User Interface Feature #1791: implement dynamic UI support

> So when I got 1 number the next creation shows the error message and existed widgets disappears.
This is not exa... Greg Shah

05:09 PM User Interface Feature #1791: implement dynamic UI support

Another issue we need to solve in P2J implementation is the new implementation for @WidgetId.frameIdFromWidgetId(int ... Eugenie Lyzenko

04:19 PM User Interface Feature #2252: implement GUI client support

Greg, attached is a massive update which touches more than the window title. The GUI window is a little ugly at this... Constantin Asofiei

08:49 AM User Interface Feature #2252: implement GUI client support

Code Review vig_upd20140806a.zip
1. Can ACTIVE-WINDOW really be assigned from business logic? Your code allows it... Greg Shah

08:14 AM User Interface Feature #2252: implement GUI client support

> To add some real behavior (for ENABLE, MESSAGE and other statements) I need to know the future GUI client class. Wi... Greg Shah

05:28 AM User Interface Feature #2252: implement GUI client support

I just added new fields to @LogicalTerminal@ class. To add some real behavior (for ENABLE, MESSAGE and other statemen... Vadim Gindin

12:32 PM Database Feature #2220: dynamic query methods which require implementation

Stanislav Lomany wrote:
> Found this in AdaptiveQuery javadoc:
> [...]
Yes, I wrote that. All such cases are con... Eric Faulhaber

12:07 PM Database Feature #2220: dynamic query methods which require implementation

Found this in AdaptiveQuery javadoc:... Stanislav Lomany

08/05/2014

05:48 PM Database Bug #2350: BUFFER-COPY errors related with copying fields with extent

I have attached next update vmn_upd20140805a.zip tested with @#2353@ and @buffer-copy-pair-list.p@ from note 18. Both... Vadim Nebogatov

04:09 PM Database Bug #2350: BUFFER-COPY errors related with copying fields with extent

I just noticed that message ... Vadim Nebogatov

03:36 PM User Interface Feature #2252: implement GUI client support

Vadim Gindin wrote:
> If you meant conversion rules, they already formulated for the corresponding task for CHUI cas... Constantin Asofiei

03:32 PM User Interface Feature #2252: implement GUI client support

If you meant conversion rules, they already formulated for the corresponding task for CHUI case. I'm trying to add ju... Vadim Gindin

03:19 PM User Interface Feature #2252: implement GUI client support

Vadim Gindin wrote:
> I tried to run _change_parent_frame.p_ with gui swing driver.
The swing gui driver is very-v... Constantin Asofiei

03:13 PM User Interface Feature #2252: implement GUI client support

I tried to run _change_parent_frame.p_ with gui swing driver. I added some UI components stubs for that, but I faced ... Vadim Gindin

01:33 PM Database Feature #2359: automated maintenance of database support files

Current implementation of custom functions exposed in SQL queries uses some additional files that, even if they rarel... Ovidiu Maxiniuc

01:18 PM Database Feature #2359 (New): automated maintenance of database support files

Ovidiu Maxiniuc

01:14 PM Database Feature #2358: HQLPreprocessor and dialect specific functions

At this moment @HQLPreprocessor@ must preprocess the HQL code depending on the dialect.
The @rtrim@ function is rep... Ovidiu Maxiniuc

01:03 PM Database Feature #2358 (WIP): HQLPreprocessor and dialect specific functions

Ovidiu Maxiniuc

08:00 PM Documentation Feature #2346: remote client launch documentation

I reviewed the latest chapter. The result is good. I cleaned it up and checked it in as bzr rev 71.
My only ques... Greg Shah

08/04/2014

07:15 PM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support

merged with latest revision (ThinClient class)
Regression testing failed with 10 tests in main part and 3 tests in c... Evgeny Kiselev

07:11 PM Database Bug #2350: BUFFER-COPY errors related with copying fields with extent

[ECF: moved content of this note to #2353, note 13] Vadim Nebogatov

11:12 AM Database Bug #2350: BUFFER-COPY errors related with copying fields with extent

Eric Faulhaber wrote:
> Yes, it looks like that length restriction is wrong; I'm not sure why I came up with that.
... Vadim Nebogatov

10:42 AM Database Bug #2350: BUFFER-COPY errors related with copying fields with extent

Vadim Nebogatov wrote:
> Condition RecordBuffer, 3661
>
> ... Eric Faulhaber

04:39 PM User Interface Feature #1791: implement dynamic UI support

>How did you determine that this was the behavior?
Consider the testcase @dyn_wid_test6.p@. It has two pair of but... Eugenie Lyzenko

03:39 PM User Interface Feature #1791: implement dynamic UI support

> If there are the dynamic widgets allocated at this time - they will be destroyed. So we returning to the state when... Greg Shah

02:17 PM User Interface Feature #1791: implement dynamic UI support

The investigation findings:
1. The starting point for ID allocation is 65535. Neither 0 nor 1. And more important ... Eugenie Lyzenko

09:10 AM Conversion Tools Bug #2357: callgraph - set schema triggers as entry points

Since these triggers are explicitly coded into the schema file, we must assume these are valid entry points and autom... Greg Shah

07:33 AM Conversion Tools Bug #2357: callgraph - set schema triggers as entry points

Original issue is in #2260 note 14. Constantin Asofiei

07:33 AM Conversion Tools Bug #2357: callgraph - set schema triggers as entry points

Currently schema trigger procedures are not automatically set as entry points - they need to be manually added to the... Constantin Asofiei

07:31 AM Conversion Tools Bug #2357 (New): callgraph - set schema triggers as entry points

Constantin Asofiei

08:55 AM Database Feature #2220: dynamic query methods which require implementation

While working on the LAST issue, I've looked into invalidation logic for adaptive queries. I think it's a bit doubtfu... Stanislav Lomany

07:37 AM Conversion Tools Feature #2251: improve the call graph generation

0715d.zip was released as rev 10593.
Tasks #2356 and #2357 were added for the issues in #2260. Constantin Asofiei

07:30 AM Conversion Tools Bug #2356: pphints bug - nested includes are missing from the.pphints file

Cases like this:... Constantin Asofiei

07:28 AM Conversion Tools Bug #2356 (New): pphints bug - nested includes are missing from the.pphints file

Constantin Asofiei