Activity
From 08/10/2014 to 09/08/2014
09/08/2014
- 05:07 PM Database Bug #2222: WRITE event triggered too early
- Eric,
I reviewed closely your last update. Changes make sense. I did not find any issues except for a few javadoc ... - 02:09 PM Base Language Bug #2338: fix _MSG function
- > 1a. size(memptr) < size(file). For exapmle size(memptr) = 5 and size(file) = 23.
> Progress reads all file and dyn... - 02:07 PM Base Language Bug #2386: STRING(memptr_var) will render the contents of the memptr as a null terminated string
- See uast/memptr/memptr_to_string.p.
In the 4GL, the contents seem to be read from index 1 (1-based indexing) and i... - 02:03 PM Base Language Bug #2386 (New): STRING(memptr_var) will render the contents of the memptr as a null terminated s...
- 12:55 PM User Interface Feature #2252: implement GUI client support
- > 1. In many places in this update, you are moving back to @int@ from @double@. A good example is @src/com/goldencod...
- 10:34 AM User Interface Feature #2252: implement GUI client support
- Code Review hc_upd20140907a.zip
I like the new @Coordinate@ helper class. Use of it makes clear to the reader tha...
09/07/2014
- 04:31 PM User Interface Feature #2252: implement GUI client support
- Attached is the update of hc_upd20140831a. It resolves the issues from review at notes 184 and 188.
The most impo... - 02:50 PM Base Language Bug #2338: fix _MSG function
- I forgot to add for the case №1 "Stream", that STRING(memptr) in Progress successfully outputs string representation ...
- 02:45 PM Base Language Bug #2338: fix _MSG function
- I tried to test these mysterious cases. It is not easy. Here are some findings.
1. @Stream.readBlock()@ method, th...
09/06/2014
- 09:59 PM Database Bug #2222: WRITE event triggered too early
- Ovidiu Maxiniuc wrote:
> I have not finished yet reviewing your update 20140903a, only a side-by-side compare with c...
09/05/2014
- 06:19 PM Database Bug #2222: WRITE event triggered too early
- I have not finished yet reviewing your update 20140903a, only a side-by-side compare with current bzr. At first impre...
- 12:06 AM Database Bug #2222: WRITE event triggered too early
- Ovidiu, would you please review the attached update? It goes way beyond the write trigger fix to deal with the incorr...
- 02:06 PM Base Language Feature #27: implement a compatible ENCODE built-in function
- Here is the Progress 4GL compatible @ENCODE@ algorithm specification.
+Summary+
The function takes a source byt... - 11:05 AM Base Language Feature #2385: implement environment access on GUI interfaces.
- I agree with your thoughts. If this read-only approach is still going to take a significant amount of time/changes, ...
- 10:56 AM Base Language Feature #2385: implement environment access on GUI interfaces.
- Indeed the big problem with @INI@ files on @P2J@ is the deployment location. Reading or writing @INI@ files on server...
- 10:06 AM Base Language Feature #2385: implement environment access on GUI interfaces.
- Interesting findings.
> Since we are looking to use INI files in both Linux OS and Windows OS the name of the INI ... - 09:36 AM Base Language Feature #2385: implement environment access on GUI interfaces.
- I did some tests using @LOAD@ @USE@ and @UNLOAD@ statements to manage user environment on both @OE@ and @P2J@.
Curre... - 08:56 AM User Interface Feature #1791: implement dynamic UI support
- > Sorry, that I'm meddling.
You are not meddling. You are CONTRIBUTING. Your questions help us make this project... - 08:24 AM User Interface Feature #1791: implement dynamic UI support
- Code Review 0904a
I'm fine with the changes. - 04:48 AM User Interface Feature #1791: implement dynamic UI support
- Sorry, that I'm meddling. Why your updates does not change @handle.getResourceId@ static method (and corresponding @R...
09/04/2014
- 07:49 PM User Interface Feature #1791: implement dynamic UI support
- The today update for review includes:
1. Merge with the recent code base.
2. Fix for shared frame importing @Screen... - 10:31 AM User Interface Feature #2286 (Closed): design and implement basic GUI window widget support
- 10:16 AM User Interface Feature #1793 (Closed): improve color support
- 10:08 AM User Interface Feature #1793: improve color support
- 0904c Passed conversion and regression tests. Committed revision 10605.
- 09:46 AM User Interface Feature #1793: improve color support
- Code Review 0904c
It is good. Go ahead and check it in/distribute it. - 09:31 AM User Interface Feature #1793: improve color support
- Done.
- 09:03 AM User Interface Feature #1793: improve color support
- Code Review 0904b
I am OK with the changes and I do think they are safe enough to avoid further testing.
I have... - 08:03 AM User Interface Feature #1793: improve color support
- A minor change to log a message whenever colors cannot be mapped and are mapped by default to a 0 RGB value.
- 07:44 AM User Interface Feature #1793: improve color support
- The changes in 0903b passed both conversion and regression tests. However I didn't do the commits and distributions y...
- 04:02 AM Base Language Feature #2385: implement environment access on GUI interfaces.
Ovidiu,
So far I did no changes on current implementation for Windows environment access.
I only added getLegac...- 03:05 AM Base Language Feature #2385 (WIP): implement environment access on GUI interfaces.
- Current implementation for @COLOR-TABLE@ and @FONT-TABLE@ statements load the default environment from server directo...
- 02:47 AM Base Language Feature #2385: implement environment access on GUI interfaces.
- GUI clients are using environment statements LOAD USE and UNLOAD to load colors, fonts and potentially other resource...
- 02:06 AM Base Language Feature #2385 (Closed): implement environment access on GUI interfaces.
09/03/2014
- 07:26 PM User Interface Feature #1791: implement dynamic UI support
- >My only question is whether the @ScreenBuffer(int frameId, int numWidgets)@ constructor is ever safe to use in the n...
- 07:22 PM User Interface Feature #1791: implement dynamic UI support
- Status update.
The next regression I've faced is in PO adding screen. This is the serious issue with shared frames... - 09:05 AM User Interface Feature #1791: implement dynamic UI support
- Code Review 0901b
The changes look good and they do look more correct.
My only question is whether the @ScreenB... - 04:54 PM User Interface Feature #2252: implement GUI client support
- Greg Shah wrote:
> Code Review vig_upd20140901a.zip
>
> I am generally fine with this as an interim update.
>
... - 09:15 AM User Interface Feature #2252: implement GUI client support
- > 1. Place a standardized marker in a comment, which can be searched on to find all these places again. Something li...
- 08:58 AM User Interface Feature #2252: implement GUI client support
- Hynek Cihlar wrote:
> Greg Shah wrote:
> > Code Review hc_upd20140831a
> >
> > Wow, that is a lot of work! It to... - 08:53 AM User Interface Feature #2252: implement GUI client support
- > It shows window button on the task bar but does not show the window itself. Testcase window_parenting/pause.p. Bod...
- 08:48 AM User Interface Feature #2252: implement GUI client support
- Code Review vig_upd20140901a.zip
I am generally fine with this as an interim update.
1. Can we make the window ... - 03:37 PM Base Language Bug #2367 (Closed): re-connecting an appserver agent after a hard client termination
- 06:47 AM Base Language Bug #2367: re-connecting an appserver agent after a hard client termination
- Greg Shah wrote:
> Code Review 0902a
>
> The changes look good.
Committed to rev 10604. - 01:14 PM Base Language Feature #27: implement a compatible ENCODE built-in function
- New/updated articles have been found:
http://programmers.stackexchange.com/questions/206645/how-can-i-reverse-engi... - 12:59 PM Base Language Feature #27: implement a compatible ENCODE built-in function
- The following link (see attached for the actual text file that is linked) is a really useful primer on the theory beh...
- 12:12 PM User Interface Feature #1793: improve color support
- > I have no other works to do on this task.
OK, please get this regression tested (both conversion and runtime).
... - 11:58 AM User Interface Feature #1793: improve color support
- I have no other works to do on this task.
Nevertheless they are other issues to implements like LOAD, USE, UNLOAD, ... - 11:49 AM User Interface Feature #1793: improve color support
- Code Review 0903b
The changes look good. I like the more general approach to reading color tables from the server... - 11:00 AM User Interface Feature #1793: improve color support
- I fixed the issues reported on Code Review 0903a (note 39)
- 10:04 AM User Interface Feature #1793: improve color support
- Code Review 0903a
The changes look good.
1. WindowConfig is missing a history entry.
2. The call from the cl... - 06:01 AM User Interface Feature #1793: improve color support
- I did some changes inside @ColorTable@ class to load colors on a per user manner.
I've fixed also some javadoc texts. - 12:07 PM User Interface Feature #2384: implement custom color overrides for ChUI
- This task is meant to allow the configuration of custom colors for ChUI as is possible in the 4GL using the protermca...
- 12:05 PM User Interface Feature #2384 (New): implement custom color overrides for ChUI
09/02/2014
- 11:40 AM User Interface Feature #1793 (Review): improve color support
- Here are my latest changes on color improvements:
- synchronization state between server and client.
- default syst... - 10:19 AM Base Language Bug #2367: re-connecting an appserver agent after a hard client termination
- Code Review 0902a
The changes look good. - 09:59 AM Base Language Bug #2367: re-connecting an appserver agent after a hard client termination
- Constantin Asofiei wrote:
> Ovidiu, attached update should fix the remaining problem. The solution was to make the ... - 06:20 AM Base Language Bug #2367: re-connecting an appserver agent after a hard client termination
- Ovidiu, attached update should fix the remaining problem. The solution was to make the (queue state check, add sessi...
- 04:53 AM Base Language Bug #2367: re-connecting an appserver agent after a hard client termination
- Ovidiu, you are correct, if the client is killed just before the session listener is registered, we still have proble...
- 09:59 AM User Interface Feature #2252: implement GUI client support
- Greg Shah wrote:
> Code Review hc_upd20140831a
>
> Wow, that is a lot of work! It took me many hours to review th... - 09:49 PM User Interface Feature #2252: implement GUI client support
- Code Review hc_upd20140831a
Wow, that is a lot of work! It took me many hours to review that update. Generally, I...
09/01/2014
- 05:04 PM User Interface Feature #1791: implement dynamic UI support
- Another update today for review. I've faced another issues with lost @UNINITIALIZED@ state. In this update all constr...
- 02:21 PM User Interface Feature #1791: implement dynamic UI support
- Code Review 0829a/b and 0901a
I am fine with the changes. - 04:03 AM User Interface Feature #1791: implement dynamic UI support
- The next update for your review.
Looks like I've found the issue resolution. We need to initialize the state map f... - 04:26 PM Base Language Bug #2367: re-connecting an appserver agent after a hard client termination
- Constantin,
I tested on Linux/PostgreSQL with bzr rev 10603 and your update 0806b, @initial_agents@, @min_agents@ a... - 10:40 AM Base Language Bug #2367: re-connecting an appserver agent after a hard client termination
- Constantin Asofiei wrote:
>
> Eric: as Ovidiu is away, please do a quick test on the server project, by killing th... - 02:10 PM User Interface Feature #2252: implement GUI client support
- I'm trying to test the following update with the last remarks and got strange behavior. It shows window button on the...
08/31/2014
- 06:06 PM User Interface Feature #2252: implement GUI client support
- Attached are changes related to #2323 - refactor coordinate system and implement GUI coordinate support.
What's in... - 02:29 PM User Interface Feature #2252: implement GUI client support
- I retested implicit pause cases and PAUSE BEFORE HIDE statement to research behavior of THIS-PROCEDURE:CURRENT-WINDOW...
- 11:16 PM Database Support #2383: write an SQL script to verify all UDFs for built-in functions work once p2jpl.jar ...
- The @p2jpl.jar@ contains a subset of the full P2J runtime classes. We recently found (in #2362) that one of the Progr...
- 11:08 PM Database Support #2383 (New): write an SQL script to verify all UDFs for built-in functions work once p2jp...
08/29/2014
- 06:19 PM Database Bug #2382: Improve format string error handling in ADD-NEW-FIELD implementation
- Some additional problems with @date@ type:
1) IllegalStateException at @DynamicTablesHelper:797@ (missed date and ... - 06:09 PM User Interface Feature #1791: implement dynamic UI support
- Unfortunately at least one regression I have already found. Consider pressing 'V' from main menu.
The current screen... - 05:54 PM User Interface Feature #1791: implement dynamic UI support
- These two updates for review contain fixed login related classes, including one from timco majic related sources. I m...
- 09:17 AM User Interface Feature #1791: implement dynamic UI support
- Code Review 0828a
I am fine with the changes. - 09:09 AM User Interface Feature #1791: implement dynamic UI support
- > all we need is to properly clean up after finish, correct?
You may also need these widgets to be in the @WidgetR... - 08:05 PM User Interface Feature #1791: implement dynamic UI support
- Update for review includes:
1. Renaming @ScreenBuffer@ helper method to bitwise AND the state.
2. Adding helper met... - 12:27 PM User Interface Feature #1793: improve color support
- > I think that we have do some changes here in order to accommodate our needs for GUI drivers perhaps on another Redm...
- 12:18 PM User Interface Feature #1793: improve color support
- 1. The P2J implementation for LOAD, USE and UNLOAD statements is conforming with OpenEdge manual.
It works only if ... - 09:01 AM User Interface Feature #2252: implement GUI client support
- Code Review 0827a
1. In @GuiOutputManager@ you ask @// TODO added to try. Fix this later. Was WindowConfig.SESSION...
08/28/2014
- 05:44 PM Database Bug #2382: Improve format string error handling in ADD-NEW-FIELD implementation
- Attached tests for different data types reproducing some errors.
@decimal, integer@
errors with different comb... - 12:14 PM Database Bug #2382 (New): Improve format string error handling in ADD-NEW-FIELD implementation
- 05:18 PM User Interface Feature #1791: implement dynamic UI support
- > Please check all Authenticator implementations for how the widget IDs are computed.
Except GenericFrame(server s... - 02:29 PM User Interface Feature #1791: implement dynamic UI support
- Eugenie Lyzenko wrote:
> 1. Consider the code @src/aero/timco/majic/security/LoginClient.java@.
Please check all A... - 11:48 AM User Interface Feature #1791: implement dynamic UI support
- >3. Why do you have buffer.size() < size as a condition in ScreenBuffer.isValidId()?
Yes I had to put the describi... - 11:19 AM User Interface Feature #1791: implement dynamic UI support
- > It has ID assignments completely different from new approach(and moreover it differs from old one too).
LoginCli... - 11:03 AM User Interface Feature #1791: implement dynamic UI support
- Code Review 0827a
1. In @ScreenBuffer@, you chose to start with an empty state map instead of one populated by UNI... - 10:05 PM User Interface Feature #1791: implement dynamic UI support
- Found a way to debug login screen locally by tunneling server port @3434@ and using @-i1@ instance to remote connecti...
- 04:19 PM User Interface Feature #2252: implement GUI client support
- 6) StatusLineGuiImpl.draw is not called at all and message string is not displayed in the status line of any open win...
- 04:17 PM User Interface Feature #2252: implement GUI client support
- I faced with the following problems.
1) We probably do not need to use contsant session window ID everywhere or we... - 03:48 PM User Interface Feature #1793: improve color support
- > Because system colors are not part of 4GL environment I think that system color table should be stored on server di...
- 03:32 PM User Interface Feature #1793: improve color support
- Code Review 0828a
The code is fine. I like the direction it is moving. - 12:55 PM User Interface Feature #1793: improve color support
- > we need to ensure that .ini files can be specified for normal users, batch processes and appserver agents
Yes.
... - 09:08 AM User Interface Feature #1793: improve color support
- Here are my latest changes for COLOR-TABLE implementation.
1. The management of COLOR-TABLE is done now on server... - 04:30 AM User Interface Feature #1793: improve color support
- Greg Shah wrote:
> As you note, there is no reason we can't use stanza-based INI files on non-Windows platforms. In...
08/27/2014
- 06:51 PM User Interface Feature #1791: implement dynamic UI support
- Some considerations and questions to discuss for inline widget ID calculation in current code. I have found new place...
- 05:40 PM User Interface Feature #1791: implement dynamic UI support
- This update for review includes:
1. Several fixes for @ThinClient.(get|set)ScreenBuffer()@ and @GenericFrame.getScre... - 09:56 AM User Interface Feature #1793: improve color support
- Constantin Asofiei wrote:
> Marius Gligor wrote:
> > I found a conversion problem and cannot fix it. Both @COLOR-TA... - 07:06 AM User Interface Feature #1793: improve color support
- Marius Gligor wrote:
> I found a conversion problem and cannot fix it. Both @COLOR-TABLE@ and @FONT-TBALE@ have a @N... - 06:34 AM User Interface Feature #1793: improve color support
- I found a conversion problem and cannot fix it. Both @COLOR-TABLE@ and @FONT-TBALE@ have a @NUM-ENTRIES@ attribute.
...
08/26/2014
- 05:52 PM Base Language Bug #2367: re-connecting an appserver agent after a hard client termination
- Code Review 0806b
Wow! That is tricky code with lots of subtlety. You documented it well and the approach makes ... - 04:47 PM Base Language Bug #2367 (WIP): re-connecting an appserver agent after a hard client termination
- This one was tricky to duplicate and even trickier to solve. The cause is this: if the appserver client terminates t...
- 02:52 PM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
- > In out code, we add extra new line only for MODE_EXPORT, but in this situation we need to add extra line only when ...
- 02:04 PM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
- I know, that 4gl documentation is not always correct, but there is next paragraph in @put@ statement:
>UNFORMATTED
... - 01:32 PM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
- Greg Shah wrote:
> I still don't know the answer to this question from note 87.
>
> And I would like to know your... - 10:34 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
- Code Review 0820a
I am fine with the changes.
> However, I think the problems 10/11 in #1629 note 17 will NOT b... - 09:45 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
- Evgeny Kiselev wrote:
> Before merge this update have been passed regression testing, but now it not compile because... - 08:35 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
- fix problem described in note 86
fix issues from note 87
merged with latest revision
Before merge this update ha... - 05:46 AM User Interface Feature #2252: implement GUI client support
- Greg Shah wrote:
> > About ca_upd20140808c.zip: as code touched by this update seems to be affected by other tasks, ... - 02:31 AM User Interface Feature #2381: implement PUT-KEY-VALUE COLOR (n | ALL)
- Marius Gligor wrote:
> PUT-KEY-VALUE COLOR (n | ALL) is used to save COLOR-TABLE of current environment on a persist... - 02:28 AM User Interface Feature #2381 (New): implement PUT-KEY-VALUE COLOR (n | ALL)
08/25/2014
- 03:29 PM User Interface Feature #1793: improve color support
- > 5. In P2J the COLOR-TABLE management is done on each environment on the client side. That's why all server API for ...
- 03:16 PM User Interface Feature #1793: improve color support
- Code Review 0825a
I'm fine with the changes. - 03:05 PM User Interface Feature #1793: improve color support
- Code Review 0822b
1. Minor javadoc changes to @getLegacyPlatform()@:
@specify a legacy platform regarding the r... - 02:47 PM User Interface Feature #1793: improve color support
- If we decide to load and store custom environments also on server side like default environment we could move the cod...
- 02:18 PM User Interface Feature #1793: improve color support
- > In conclusion I think that we have to follow the same behaviour and implements a mechanism to save COLOR-TABLE some...
- 10:47 AM User Interface Feature #1793: improve color support
- Here are my changes after your code review for 0814a on note 9.
Also I did new tests this time using @LOAD@ @USE@ an... - 11:01 AM Bugs Bug #2380 (Rejected): NullPointerException when widget set to visible in CREATE statement
- This is a known problem that will be resolved as part of #1791. Our dynamic widget support is not yet functional. W...
- 10:59 AM Bugs Bug #2380: NullPointerException when widget set to visible in CREATE statement
- The following sample causes an NPE when run converted in P2J:...
- 10:58 AM User Interface Feature #1791: implement dynamic UI support
- > The suggested fix is:
I don't see any reason to enter the @synchronized@ block. Entering it obtains the lock fo... - 10:48 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
- OK, that makes more sense now. What do you suggest?
- 10:00 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
- Here is my stacktrace:...
- 09:24 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
- > problem with @put unformatted "~n ".@:
> ...
> and in method com.goldencode.p2j.util.Stream#generateFormattedText... - 10:25 AM User Interface Feature #2252: implement GUI client support
- > any widget resource requiring access to these attributes (from either server or client side) will interrogate the c...
- 10:09 AM User Interface Feature #2252: implement GUI client support
- > About ca_upd20140808c.zip: as code touched by this update seems to be affected by other tasks, I think I should rel...
08/24/2014
- 04:46 PM Bugs Bug #2380 (Rejected): NullPointerException when widget set to visible in CREATE statement
08/22/2014
- 04:14 PM User Interface Feature #1791: implement dynamic UI support
- Two more issues has been found during testing:
1. NullPointer exception in code @LogicalTerminal.deregisterFrameCont... - 08:27 AM User Interface Feature #1791: implement dynamic UI support
- Code Review 0821a
I'm fine with the changes. Let's get this through testing. You can fix the memory leak in the ... - 06:42 AM User Interface Feature #1791: implement dynamic UI support
- Greg Shah wrote:
> # @LT.releaseSharedFrame()@ is the only way that shared frames actually "go away" permanently. U... - 08:49 PM User Interface Feature #1791: implement dynamic UI support
- Looks like I've found the root cause. It really the interference of new ID approach and old one. The method is @Widge...
- 02:28 PM User Interface Feature #2252: implement GUI client support
- About ca_upd20140808c.zip: as code touched by this update seems to be affected by other tasks, I think I should relea...
- 02:26 PM User Interface Feature #2252: implement GUI client support
- About note 157/158, the work for #2254 and sync'ing the server and client-side widget states. Unfortunately, there i...
- 12:43 PM User Interface Feature #1793: improve color support
- The attached archive @0822b@ contains implementation of @EnvironmentOps.getLegacyPlatform()@
- 11:03 AM User Interface Feature #1793: improve color support
- Digging in the customer's @OE 10.2b@ environment I found the configuration file progress.ini which contains among oth...
- 08:53 AM User Interface Feature #1793: improve color support
- Code Review 0822a
The changes are fine.
> the code inside ColorSpec class is running only on the server side, ... - 07:17 AM User Interface Feature #1793: improve color support
- Here are my changes for COLOR phrase implementation as a result of your code review.
1. Regarding platform detecti... - 09:32 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
- problem described in note 86 divide into 2 problems:
1) incorrect position for message method with redirected stream ...
08/21/2014
- 06:33 PM Database Feature #2220: dynamic query methods which require implementation
- Rules from note 41 apply to multi-table queries as well.
- 01:38 PM User Interface Feature #2252: implement GUI client support
- Committed to bzr with rev 10600.
- 01:17 PM User Interface Feature #2252: implement GUI client support
- > Previous update passed regression testing. Can I commit it?
Yes, please do. - 01:16 PM User Interface Feature #2252: implement GUI client support
- Previous update passed regression testing. Can I commit it?
- 08:42 AM User Interface Feature #2252: implement GUI client support
- Code Review 0821a
I like the way this is going. Moving the @Window@ functionality from @static@ to non-@static@ i... - 04:35 AM User Interface Feature #2252: implement GUI client support
- > What happens if CURRENT-WINDOW is unrealized?
DEFAULT-WINDOW is used
I've added some client implementation for ... - 11:42 AM User Interface Feature #1793: improve color support
- Code Review 0821a
I like the result. Some minor feedback:
1. All data members should be at the top of the clas... - 11:17 AM User Interface Feature #1793: improve color support
- I've created #2379 to capture the work item for adding color support to the native Windows console (ChUI) client. We...
- 10:58 AM User Interface Feature #1793: improve color support
- The attached archive contains my changes which I made to implements COLOR phrase for ChUI interfaces.
The @protermca... - 11:16 AM User Interface Feature #2379 (New): implement color support in the Windows native console (ChUI) client
- 11:15 AM User Interface Feature #2378: implements dos-hex-attribute of COLOR phrase
- See notes 11 and 12 in #1793 for details of previous research.
08/20/2014
- 05:47 PM User Interface Feature #1793: improve color support
- Enums have the advantage of being very concise in syntax and being easy to read/understand/use. The down side of usi...
- 05:44 PM User Interface Feature #1793: improve color support
- Question from MAG:
ColorPalette should holds multiple entries depending on platform Linux or Windows. ColorPalette... - 04:18 PM User Interface Feature #1791: implement dynamic UI support
- The update certainly has a regressions in frame ID handling(on client side I guess). After main syman menu displaying...
- 10:32 AM User Interface Feature #1791: implement dynamic UI support
- Sorry, I did not remove @ClientIdHelper@ from old location, so 0820a has two files with same class. Repackaged in 082...
- 09:46 AM User Interface Feature #1791: implement dynamic UI support
- Code Review 0820a
I like the changes. Well done.
> If you do not mind I'll start the runtime regression testin... - 09:42 AM User Interface Feature #1791: implement dynamic UI support
- This update for your review moves the @INPUT_FRAME_ID@ constant to @WidgetId@ class. The @WIDGET_ID_RANGE_BEGIN@ now ...
- 08:18 AM User Interface Feature #1791: implement dynamic UI support
- > I think these widgets do not have the server side counterpart because they exist only at editing time.
Yes.
>... - 09:15 AM User Interface Feature #2252: implement GUI client support
- Code Review 0820a
The changes look fine.
> Implicit Pause behaves exactly as explicit: uses CURRENT-WINDOW.
... - 02:27 AM User Interface Feature #2252: implement GUI client support
- I've tested implicit pause cases, listed in the note №160. Implicit Pause behaves exactly as explicit: uses CURRENT-W...
08/19/2014
- 06:54 PM User Interface Feature #1791: implement dynamic UI support
- Also I guess this artificial frame and fill-in will neither be in widget registry not the part of server side frame. ...
- 06:46 PM User Interface Feature #1791: implement dynamic UI support
- >Does it work? :) Please test it with standalone testcases, including shared frames.
Yes, but there is one little ... - 05:32 PM User Interface Feature #1791: implement dynamic UI support
- Code Review 0819a
I like it.
Does it work? :) Please test it with standalone testcases, including shared fra... - 03:42 PM User Interface Feature #1791: implement dynamic UI support
- This update for your review includes:
1. Methods renaming for @registerWidgetIdObject()@, @deregisterWidgetIdObject(... - 05:55 AM User Interface Feature #1791: implement dynamic UI support
- Eugenie Lyzenko wrote:
> >We can remove the @LT.activateSharedFrame()@ method completely.
>
> In this case we nee... - 05:37 AM User Interface Feature #1791: implement dynamic UI support
- >We can remove the @LT.activateSharedFrame()@ method completely.
In this case we need to move the work this method... - 10:41 PM User Interface Feature #1791: implement dynamic UI support
- > The problem here is sharedframereg is a map of <id, GenericFrame> while widget registry is a map of <id, GenericWid...
- 01:41 PM User Interface Feature #2378 (New): implements dos-hex-attribute of COLOR phrase
- 12:53 PM User Interface Feature #1793: improve color support
- These are very good findings.
> 8. I could not do tests using dos-hex-attribute on Windows ChUI (see 2-b) However ... - 12:07 PM User Interface Feature #1793: improve color support
- Here are my conclusion doing some "researches" on color implementation for ChUI and GUI interfaces on Linux OS/ Windo...
- 08:37 PM User Interface Feature #1793: improve color support
- > The valuse are stored on Windows registry and are used by Windows GUI widgets.
> I think that our GUI implementati... - 08:34 PM User Interface Feature #1793: improve color support
- Code Review 0814a
1. Line 463 of language_statements.rules has a reference to KW_FONT.
2. The progress.g change...
08/18/2014
- 07:45 PM User Interface Feature #1791: implement dynamic UI support
- >The processing of LT.replaceFrame() probably needs to remap the new frame's contained widgets into the widget regist...
- 07:22 PM User Interface Feature #1791: implement dynamic UI support
- >11. Once the client has actually hidden the frame, it will notify the server and in the LT.applyChanges() method, ...
- 05:43 PM User Interface Feature #1791: implement dynamic UI support
- >I think the sharedframereg is NOT needed after your changes. It is only used to make sure that shared frame IDs are ...
- 04:37 PM User Interface Feature #1791: implement dynamic UI support
- Eugenie Lyzenko wrote:
> >5. The deregisterFrameContent() code should still have the locking implemented...
>
> Y... - 04:35 PM User Interface Feature #1791: implement dynamic UI support
- In regard to the shared frame processing, it is quite complex. I'm not sure that our basic approach is 100% correct....
- 04:16 PM User Interface Feature #1791: implement dynamic UI support
- >5. The deregisterFrameContent() code should still have the locking implemented...
You mean @private deregisterFra... - 01:10 PM User Interface Feature #1791: implement dynamic UI support
- Code Review 0818a
1. Please rename the following:
@registerWidgetIdObject()@ to @registerWidget()@
@deregister... - 09:51 AM User Interface Feature #1791: implement dynamic UI support
- Adding some improvements in this update:
1. Deregister frame when it is destroyed
2. Adding static method to deregi... - 07:49 AM User Interface Feature #1791: implement dynamic UI support
- Checking the code with frame related testcases I have found potential issues with widget registry. This is related to...
- 04:50 PM User Interface Feature #2252: implement GUI client support
- Code Review vig_upd20140815a.zip
The only thing I would like to see changed is to move the common @hWin@ processin... - 12:57 PM User Interface Feature #2252: implement GUI client support
- Greg Shah wrote:
> I will handle the code review for vig_upd20140815a.zip shortly.
>
> > Only following statement... - 12:28 PM User Interface Feature #2252: implement GUI client support
- I will handle the code review for vig_upd20140815a.zip shortly.
> Only following statements with BEFORE-HIDE are c... - 08:01 AM User Interface Feature #2252: implement GUI client support
- Greg Shah wrote:
>
> Also, do check in your testcases.
Due to the customer server outage I have committed the t...
08/16/2014
- 06:24 PM User Interface Feature #1791: implement dynamic UI support
- This update adds more cleanup for frame deregistration. Looks like we need to remove widgets even when the frame is m...
08/15/2014
- 04:03 PM Database Feature #2376: retain bulk getter/setter methods for custom denormalized extent fields
- Test cases are checked in to testcases/uast/denormalization folder.
- 03:56 PM Database Feature #2376: retain bulk getter/setter methods for custom denormalized extent fields
- Test @testcases/uast/denormalization/bulk3@:...
- 12:42 PM Database Feature #2376: retain bulk getter/setter methods for custom denormalized extent fields
- Test @testcases/uast/denormalization/bulk2@:...
- 04:00 PM Database Feature #2134: configurable denormalization of extent fields into individual fields in schema con...
- Test cases are checked in to @testcases/uast/denormalization@ folder.
- 03:21 PM User Interface Feature #2252: implement GUI client support
- > Change the int data type to double for all existing data structures and attributes holding character coordinate val...
- 01:58 PM User Interface Feature #2252: implement GUI client support
- *About PAUSE statements list*. Only following statements with BEFORE-HIDE are correct from the Progress point of view...
- 09:09 AM User Interface Feature #2252: implement GUI client support
- I would like to do some real work (read code changes) on the GUI coordinate support (#2323). The following are the st...
- 03:15 PM User Interface Feature #1791: implement dynamic UI support
- This update for your review includes:
1. Operations with widget registry are now have protection locking
2. Addin... - 03:05 PM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
- Code Review 0812a
The proposed code can be accepted with only some minor changes (listed below).
However, I t... - 04:50 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
- update:
1) rollback isTerm() method
2) rollback ThinClient(described below)
3) I've added in StreamFactory next co...
08/14/2014
- 06:33 PM User Interface Feature #1791: implement dynamic UI support
- > The question: the map has data pair <Integer,GenericWidget>. On the other hand we can(and other maps uses this) use...
- 06:20 PM User Interface Feature #1791: implement dynamic UI support
- Code Review 0814b
1. The locking for the widget registry (and frame registries...) needs to be improved. Right no... - 05:12 PM User Interface Feature #1791: implement dynamic UI support
- The next update for your review contains widget ID registry implementation in addition to other notes resolution. The...
- 02:06 PM User Interface Feature #1791: implement dynamic UI support
- > May be it is better to move ClientIdHelper class to com.goldencode.p2j.ui.chui package(the same place as ThinClient...
- 02:05 PM User Interface Feature #1791: implement dynamic UI support
- Code Review 0814a
Yes, the approach is correct. Some minor feedback:
1. The @ClientIdHelper@ should be in the ... - 02:01 PM User Interface Feature #1791: implement dynamic UI support
- The question. May be it is better to move @ClientIdHelper@ class to @com.goldencode.p2j.ui.chui@ package(the same pla...
- 11:44 AM User Interface Feature #1791: implement dynamic UI support
- This update for review reflects the recent notes to using @ThinClient@ or @LogicalTerminal@ to work with ID. I need t...
- 08:37 AM User Interface Feature #1791: implement dynamic UI support
- Code Review 0813a
This version is very good.
My only concern is how this will work in certain scenarios like ... - 05:03 PM Database Feature #2220: dynamic query methods which require implementation
- >Please report the test cases you used to determine these rules and check them into the testcases project if you have...
- 11:58 AM Database Feature #2220: dynamic query methods which require implementation
- Stanislav Lomany wrote:
> I finally got caching rules for adaptive queries (single-table):
> # Cache is advanced in... - 11:41 AM Database Feature #2220: dynamic query methods which require implementation
- I finally got caching rules for adaptive queries (single-table):
# Cache is advanced in forward (if the first iterat... - 04:26 PM Database Feature #2376: retain bulk getter/setter methods for custom denormalized extent fields
- Thanks, Vadim. So, this tells us that we do not get a runtime error in Progress when invoking BUFFER-VALUE on an exte...
- 04:02 PM Database Feature #2376: retain bulk getter/setter methods for custom denormalized extent fields
- Test @testcases/uast/denormalization/bulk1@:...
- 12:54 PM User Interface Feature #2252: implement GUI client support
- Hynek Cihlar wrote:
> Constantin Asofiei wrote:
> > We need to decide what is the policy of pushing a certain widge... - 12:37 PM User Interface Feature #1793: improve color support
- Here is a first version of @COLOR-TABLE@ implementation.
The implementation of @COLOR-TABLE@ looks the same as @FONT... - 12:28 PM Database Feature #2273: address remaining limitations of SQL Server needed to support legacy 4GL behavior
- Ovidiu Maxiniuc wrote:
> The cause could be @(org.eclipse.jetty.util.component.AbstractLifeCycle:WARNING) FAILED Ser... - 08:41 AM Database Bug #2222: WRITE event triggered too early
- Code Review 0813a
I am fine with the changes.
08/13/2014
- 06:04 PM User Interface Feature #2252: implement GUI client support
- Constantin Asofiei wrote:
> We need to decide what is the policy of pushing a certain widget config to the client:
... - 09:31 AM User Interface Feature #2252: implement GUI client support
- > I will need to know not only default window from the client (static method Window.getDefaultWindow()), but also ac...
- 09:22 AM User Interface Feature #2252: implement GUI client support
- About my question 4 in the note 144. I will need to know not only default window from the client (static method @Wind...
- 05:52 PM Database Bug #2377 (New): default buffer can be incorrectly scoped to an internal procedure
- 05:47 PM Database Bug #2222: WRITE event triggered too early
- The attached update fixes a defect which enabled write triggers to corrupt the @BlockManager@'s context-local state.
... - 05:39 PM User Interface Feature #1791: implement dynamic UI support
- The point to clarify:
>Please investigate keeping a single server-side registry of all widgets, including windows,... - 04:05 PM User Interface Feature #1791: implement dynamic UI support
- Working on the point #7 from your note. But have the update to upload meantime.
In this update for review: @FrameI... - 06:28 AM User Interface Feature #1791: implement dynamic UI support
- > I think the solution can be just replacement WindowConfig.SESSION_WINDOW_ID with WidgetId.DEFAULT_WINDOW_ID in all ...
- 05:33 PM Database Feature #2376: retain bulk getter/setter methods for custom denormalized extent fields
- There appears is a hole in our current implementation of custom, denormalized extent fields, in that we have eliminat...
- 11:48 AM Database Feature #2376 (Test): retain bulk getter/setter methods for custom denormalized extent fields
- 04:35 PM Database Feature #2273: address remaining limitations of SQL Server needed to support legacy 4GL behavior
- The conversion test was successful, there are no changes in the ddl code, only the @.hbm.xml@ are affected: and extra...
- 06:17 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
- Evgeny Kiselev wrote:
> Also When we removed isTerm() method, there are next possible issues:
> @RemoteStream@ had ... - 06:07 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
- Also When we removed isTerm() method, there are next possible issues:
@RemoteStream@ had constructor @RemoteStream(in... - 06:02 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
- Evgeny Kiselev wrote:
> > CTRL-C part:
> > ctrlc_11_session1 step 18-28
> > ctrlc_11_session3 step 9-23, 25
> > c... - 05:55 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
- > CTRL-C part:
> ctrlc_11_session1 step 18-28
> ctrlc_11_session3 step 9-23, 25
> ctrlc_11_session4 step 1-26, 28
... - 04:47 AM Base Language Bug #2375: fix the memptr initialization (in extent) and memptr parameter processing
- Attached update is a first pass at fixing the problems noted in #1635 note 29,30,31,32. Testcases which cover memptr...
- 04:32 AM Base Language Bug #2375 (Closed): fix the memptr initialization (in extent) and memptr parameter processing
08/12/2014
- 07:08 PM User Interface Feature #1791: implement dynamic UI support
- > 5. The @WidgetId.allocateWindowID()@ can't work for allocating anything other than the @DEFAULT-WINDOW@, which is n...
- 10:56 AM User Interface Feature #1791: implement dynamic UI support
- Code Review 0811b
1. In WidgetId, the class javadoc states "Every JVM session has it's own set of widget ID.". Th... - 04:34 PM User Interface Feature #2252: implement GUI client support
- > Do you mean WindowWidget or exactly Window?
I mean WindowWidget.
>> 4. The external LogicalTerminal.pause*()... - 04:13 PM User Interface Feature #2252: implement GUI client support
- Greg Shah wrote:
..
> 3. @isWindowRealized()@ seems like it would be best implemented inside the @Window@ widget it... - 04:21 PM Base Language Bug #2338: fix _MSG function
- Vadim Gindin wrote:
> Constantin Asofiei wrote:
> ..
> > * QUIT/STOP/ENDKEY conditions
>
> I didn't find a way ... - 04:07 PM Base Language Bug #2338: fix _MSG function
- Constantin Asofiei wrote:
..
> * QUIT/STOP/ENDKEY conditions
I didn't find a way to test QUIT and ENDKEY conditi... - 04:01 PM Database Feature #2273: address remaining limitations of SQL Server needed to support legacy 4GL behavior
- Ovidiu Maxiniuc wrote:
> Eric Faulhaber wrote:
> > Code review 0811b:
> >
> > Looks good, but I have some questi... - 03:03 PM Database Feature #2273: address remaining limitations of SQL Server needed to support legacy 4GL behavior
- Eric Faulhaber wrote:
> Code review 0811b:
>
> Looks good, but I have some questions:
> * In the event there is ... - 10:38 AM Database Feature #2273: address remaining limitations of SQL Server needed to support legacy 4GL behavior
- Code review 0811b:
Looks good, but I have some questions:
* In the event there is no @sql-size@ hint (potentially... - 10:40 AM Database Bug #2347: hql to SQL name mapping issue
- Makes sense. So no need for a separate code review here. Once that update (0811a) is finished/tested, we can close ou...
- 10:30 AM Database Bug #2347: hql to SQL name mapping issue
- Yes, they are part of om_upd20140811a.zip (#2332).
It's hard for me to maintain them in separate updates, at some po... - 10:22 AM Database Bug #2347: hql to SQL name mapping issue
- Ovidiu, were the changes in this update rolled up into om_upd20140811a.zip (#2332)?
- 09:08 AM Base Language Feature #1635: implement MEMPTR/RAW support
- I'm fine with the proposed approach. My only concern is that I don't want us to spend too much time fixing this, as ...
- 05:03 AM Base Language Feature #1635: implement MEMPTR/RAW support
- Greg Shah wrote:
> Code Review 0811a
>
> The changes look good. When it passes testing, please check it in and d... - 08:44 AM Database Feature #2220: dynamic query methods which require implementation
- Code review 0812a:
I think it looks OK, but this whole area of the code is tricky to assess with just a review. I'... - 05:18 AM Database Feature #2220: dynamic query methods which require implementation
- Fixes for testcases in notes 28 (not about flushing part, about PREV) and 34 (LAST issue). I didn't performed extensi...
- 03:14 AM User Interface Feature #2144: add minimum runtime support for methods (server)
- passed regression testing and committed with rev 10596.
08/11/2014
- 05:14 PM User Interface Feature #2144: add minimum runtime support for methods (server)
- Code Review 0811b
I am fine with the changes. - 04:42 PM User Interface Feature #2144: add minimum runtime support for methods (server)
- next update with corrections
- 01:41 PM User Interface Feature #2144: add minimum runtime support for methods (server)
- Code Review 0811a
1. This code needs @null@ protection since @query@ can be @null@.... - 01:29 PM User Interface Feature #2144: add minimum runtime support for methods (server)
- During the work on that task I found that DESELECT-ROWS is already implemented and only some error checking was neede...
- 05:12 PM Database Feature #2273: address remaining limitations of SQL Server needed to support legacy 4GL behavior
- I have finished merging the old update with bzr rev 10595. Please see the attached update.
My simple testcases were ... - 04:26 PM Base Language Feature #1635: implement MEMPTR/RAW support
- Greg Shah wrote:
> Thoughts on how to accommodate this?
Looks like this special state is preserved until the memptr... - 01:34 PM Base Language Feature #1635: implement MEMPTR/RAW support
- > when memptr is set to unknown, the unknown equality test is computed different: it's like Schrodinger's cat, the me...
- 01:17 PM Base Language Feature #1635: implement MEMPTR/RAW support
- Code Review 0811a
The changes look good. When it passes testing, please check it in and distribute it. - 12:38 PM Base Language Feature #1635: implement MEMPTR/RAW support
- I have some weird unknown equality test using memptr... See this test:...
- 04:04 PM Documentation Feature #2346 (Closed): remote client launch documentation
- There are many good ideas here.
In addition, there are some improvements that could possibly help make our brokers... - 05:49 AM Documentation Feature #2346: remote client launch documentation
- OTOH, now your reasoning about the relative paths makes sense... if the spawner can use/determine the home dir for th...
- 05:40 AM Documentation Feature #2346: remote client launch documentation
- Marius Gligor wrote:
> Sorry but I'm totally confused. The working directory is for OS accounts not for P2J accounts... - 05:36 AM Documentation Feature #2346: remote client launch documentation
- Sorry but I'm totally confused. The working directory is for OS accounts not for P2J accounts.
When a web client is ... - 05:04 AM Documentation Feature #2346: remote client launch documentation
- Marius Gligor wrote:
> I would like to fix the @workingDirectory@ issue and I coming with a lot of remarks:
>
> 1... - 04:15 AM Documentation Feature #2346: remote client launch documentation
- I would like to fix the @workingDirectory@ issue and I coming with a lot of remarks:
1. We have the same problem o... - 03:48 PM User Interface Feature #2252: implement GUI client support
- Constantin Asofiei wrote:
> # @ACTIVE-WINDOW@ (and maybe @CURRENT-WINDOW@ too) can be driven from the client-side; c... - 03:43 PM User Interface Feature #2252: implement GUI client support
- Greg Shah wrote:
> Code Review vig_upd20140810a.zip
Some thoughts about this update:
# instead of @UiUtils.locateP... - 03:06 PM User Interface Feature #2252: implement GUI client support
- Greg Shah wrote:
> Interesting. This is all caused by the PAGED option when the "terminal" is opened as a stream. ... - 01:21 PM User Interface Feature #2252: implement GUI client support
- Constantin Asofiei wrote:
> That is an old assumption, which is no longer valid: the widget location can't change wi... - 01:20 PM User Interface Feature #2252: implement GUI client support
- Hynek Cihlar wrote:
> Constantin Asofiei wrote:
> > The position of a widget can be set via both character-based an... - 12:41 PM User Interface Feature #2252: implement GUI client support
- Code Review vig_upd20140810a.zip
The approach is moving in the right direction.
1. I would prefer to use an @in... - 10:21 AM User Interface Feature #2252: implement GUI client support
- Code Review ca_upd20140808c.zip
The changes are OK. - 10:19 AM User Interface Feature #2252: implement GUI client support
- > The idea was that this proves that GUI still handles the PUT SCREEN. But we need to make sure that the client code ...
- 03:43 PM User Interface Feature #1791: implement dynamic UI support
- This update adds client/server session type checking into @EventDefinition.java@.
- 12:04 PM User Interface Feature #1791: implement dynamic UI support
- Forgot to add @ThinClient.java@ to previous update. Also the javadoc comments added in @WidhetId@ class.
- 11:08 AM User Interface Feature #1791: implement dynamic UI support
- The question/clarification for new ID approach update. I've found the class @EventDefinition@ is used on both on the ...
- 02:58 PM User Interface Feature #2374: implement WINDOW events in GUI mode
- From #2252 note 138:
> Doesn't it still generate the WINDOW-CLOSE 4GL event? It is very common to have code like ON ... - 02:57 PM User Interface Feature #2374 (Closed): implement WINDOW events in GUI mode
- 02:55 PM User Interface Feature #2373: implemented output to redirected, paged terminal via (un)named streams in GUI mode
- Starting from the case in #2252-141, implement output to stream when the stream is paged/page-size is set and it targ...
- 02:53 PM User Interface Feature #2373 (New): implemented output to redirected, paged terminal via (un)named streams in GU...
- 10:28 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
- > tc_job_002
> tc_job_clock_002
Are these the known failures as described in our documentation?
The other prob... - 09:51 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
- Greg Shah wrote:
> We need to get this through testing. Are there any tests which are always failing?
CTRL-C part:... - 09:48 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
- OK, then we need to leave the code as:...
- 09:39 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
- In @StreamWrapper@ with next code: ...
- 10:09 AM User Interface Feature #2372: implement support for PUT SCREEN in GUI
- Although PUT SCREEN is documented (in the 4GL reference) as not working in GUI, in fact it can be used. However, its...
- 09:54 AM User Interface Feature #2372 (New): implement support for PUT SCREEN in GUI
- 09:03 AM Database Bug #2350 (Closed): BUFFER-COPY errors related with copying fields with extent
- 08:44 AM Database Bug #2350: BUFFER-COPY errors related with copying fields with extent
- update [vmn_upd20140807a.zip] committed to bzr rev. 10595 and distributed.
- 07:45 AM Database Bug #2350: BUFFER-COPY errors related with copying fields with extent
- Please commit and distribute the 0807a update.
- 05:30 AM Database Bug #2350: BUFFER-COPY errors related with copying fields with extent
- Regression completed: @tc_job_clock_002@ finally passed in 20140810_163259.
- 02:09 AM Database Support #2371: trigger behavior
- h1. Database Trigger Firing Rules
h2. General Sequence
Session triggers generally fire before schema triggers, EXCE... - 12:28 AM Database Support #2371 (Closed): trigger behavior
08/10/2014
- 06:50 PM User Interface Feature #1791: implement dynamic UI support
- The update is the new widget ID allocation approach for you to review. Does not include the dynamic widget ID support...
- 04:05 PM Database Bug #2350: BUFFER-COPY errors related with copying fields with extent
- Regression 20140810_120027: failed tc_job_002, tc_job_clock_002 from previous regression. Will repeat regression one ...
- 12:53 PM User Interface Feature #2252: implement GUI client support
- Here is the first skeleton of implementation system handles ^-WINDOW. Could you look at it. I've added window Id para...
Also available in: Atom