Project

General

Profile

Activity

From 02/11/2016 to 03/11/2016

03/11/2016

11:52 AM User Interface Bug #2954: Focus is not put on the expected widget when window activated
Sergey Ivanovskiy wrote:
> 2958 issue is reproduced for the Swing client, trying to identify the root causes.
After...
Sergey Ivanovskiy
09:46 AM User Interface Bug #2954: Focus is not put on the expected widget when window activated
2958 issue is reproduced for the Swing client, trying to identify the root causes. Sergey Ivanovskiy
08:18 AM User Interface Bug #2954: Focus is not put on the expected widget when window activated
Have you looked at the recreate in #2958?
What are the remaining known issues?
What testing is still pending?
Greg Shah
12:28 AM User Interface Bug #2954: Focus is not put on the expected widget when window activated
I can't reproduce this bug on the Swing client with the attached program that creates two dynamic windows and one the... Sergey Ivanovskiy
09:24 AM Base Language Feature #1612: finish SESSION system handle support
In the dialog the @Debug@ button should be present but disabled so that it is clear that it is not functional. The c... Greg Shah
09:23 AM Base Language Feature #1612: finish SESSION system handle support
Greg Shah wrote:
> We are not going to support @-clientlog@ at this time. Make sure to put an @UnimplementedFeature....
Igor Skornyakov
09:21 AM Base Language Feature #1612: finish SESSION system handle support
We are not going to support @-clientlog@ at this time. Make sure to put an @UnimplementedFeature.todo()@ into the deb... Greg Shah
09:04 AM Base Language Feature #1612: finish SESSION system handle support
Greg Shah wrote:
> What do the Progress docs state about it?
Essentially not much more than I could see. It is esse...
Igor Skornyakov
08:57 AM Base Language Feature #1612: finish SESSION system handle support
> BTW: I understand that -clientlog, -logginglebel and -debugalert should be command-line options of the client. Is t... Greg Shah
08:57 AM Base Language Feature #1612: finish SESSION system handle support
> > What is the purpose of @-clientlog@? I guess it sets a log file name. But for what use?
> > I'm not sure that ...
Greg Shah
08:56 AM Base Language Feature #1612: finish SESSION system handle support
Greg Shah wrote:
> What is the purpose of @-clientlog@? I guess it sets a log file name. But for what use?
> I'm ...
Igor Skornyakov
08:50 AM Base Language Feature #1612: finish SESSION system handle support
What is the purpose of @-clientlog@? I guess it sets a log file name. But for what use?
I'm not sure that we nee...
Greg Shah
08:36 AM Base Language Feature #1612: finish SESSION system handle support
Greg Shah wrote:
> No. Those other attributes are not in use and we aren't going to support them at this time.
I s...
Igor Skornyakov
08:28 AM Base Language Feature #1612: finish SESSION system handle support
> There is a number of attributes which are related to @-clientlog@ startup parameter (@LOGFILE-NAME@, @LOGGING-LEVEL... Greg Shah
08:20 AM User Interface Bug #2849: implement and/or fix the default popup menus for all widgets
> At the any time there is only one opened popup menu is possible in the application. Should I fix it now or it is be... Greg Shah
05:40 AM User Interface Bug #2849: implement and/or fix the default popup menus for all widgets
Sergey Ivanovskiy wrote:
> Does this check @if ( this.getActualBounds().contains(e.getX(), e.getY()) )@ work properl...
Vadim Gindin
05:31 AM User Interface Bug #2849: implement and/or fix the default popup menus for all widgets
Colleagues. I have a question. At the any time there is only one opened popup menu is possible in the application. Sh... Vadim Gindin
01:07 AM User Interface Bug #2849: implement and/or fix the default popup menus for all widgets
Does this check @if ( this.getActualBounds().contains(e.getX(), e.getY()) )@ work properly? Theoretically it should r... Sergey Ivanovskiy
12:55 AM User Interface Bug #2849: implement and/or fix the default popup menus for all widgets
> I would propose that @editor.physicalBounds().contains(..)@ should be replaced with @editor.getActualBounds().conta... Sergey Ivanovskiy
09:17 PM User Interface Bug #2849: implement and/or fix the default popup menus for all widgets
I'm testing my proposal and it probably wrong.. I'm confused with such amount of location methods: @location/physical... Vadim Gindin
09:07 PM User Interface Bug #2849: implement and/or fix the default popup menus for all widgets
I would propose that @editor.physicalBounds().contains(..)@ should be replaced with @editor.getActualBounds().contain... Vadim Gindin
07:28 PM User Interface Bug #2914: Fix errors in window_sizing/test_runner.p
Rebased task branch 2914b against trunk revision 10981. 2914b is now at revision 10985. Hynek Cihlar

03/10/2016

06:57 PM User Interface Bug #2849: implement and/or fix the default popup menus for all widgets
Committed revision 11021 is the summary fix from 1811t and editor menu standalone fix. Vadim, please review @EditorGu... Sergey Ivanovskiy
12:23 PM User Interface Bug #2849: implement and/or fix the default popup menus for all widgets
Yes, the branch is ready. Please fix it. Vadim Gindin
07:35 AM User Interface Bug #2849: implement and/or fix the default popup menus for all widgets
> It works fine for SWING, but for WEB it shows editor popup when the user clicks that square in the right bottom cor... Sergey Ivanovskiy
06:36 AM User Interface Bug #2849: implement and/or fix the default popup menus for all widgets
It works fine for SWING, but for WEB it shows editor popup when the user clicks that square in the right bottom corne... Vadim Gindin
05:55 AM User Interface Bug #2849: implement and/or fix the default popup menus for all widgets
> Ok, If you are sure, I don't mind.
Committed revision 11020 rolled back @AbstarctContainer.findMouseSource@ and @E...
Sergey Ivanovskiy
05:37 AM User Interface Bug #2849: implement and/or fix the default popup menus for all widgets
Ok, If you are sure, I don't mind. Vadim Gindin
05:21 AM User Interface Bug #2849: implement and/or fix the default popup menus for all widgets
I think that 1811t will be committed to the trunc, then the same issues will appear again. It is better to apply @Abs... Sergey Ivanovskiy
05:15 AM User Interface Bug #2849: implement and/or fix the default popup menus for all widgets
Don't know how to do it better. In 1811t @AbstractContainer.findMouseSource@ returns the mouse source component. And ... Sergey Ivanovskiy
05:09 AM User Interface Bug #2849: implement and/or fix the default popup menus for all widgets
Sergey Ivanovskiy wrote:
> Vadim Gindin wrote:
> > I have some difficulty. Lets look at EDITOR that has both scroll...
Vadim Gindin
04:48 AM User Interface Bug #2849: implement and/or fix the default popup menus for all widgets
Vadim Gindin wrote:
> I have some difficulty. Lets look at EDITOR that has both scroll bars: horizontal and vertical....
Sergey Ivanovskiy
04:08 AM User Interface Bug #2849: implement and/or fix the default popup menus for all widgets
I have some difficulty. Lets look at EDITOR that has both scroll bars: horizontal and vertical. I'm confused with wid... Vadim Gindin
06:35 PM User Interface Bug #3013: The mouse wheel doesn't work if the mouse pointer is over scrollbars
Committed revision 11061 fixed 2) issue from note 56. Sergey Ivanovskiy
06:09 PM User Interface Bug #3013: The mouse wheel doesn't work if the mouse pointer is over scrollbars
Ok. Planning to check... Sergey Ivanovskiy
03:11 PM User Interface Bug #3013: The mouse wheel doesn't work if the mouse pointer is over scrollbars
Sergey Ivanovskiy wrote:
> It relates to the focus management, it seems that sometimes I can't focus the given widge...
Igor Skornyakov
03:07 PM User Interface Bug #3013: The mouse wheel doesn't work if the mouse pointer is over scrollbars
> Sergey Ivanovskiy wrote:
> > 3) Unrelated: if we press CTRL + D to set the GLOVE cursor to the widget, then the foc...
Sergey Ivanovskiy
03:01 PM User Interface Bug #3013: The mouse wheel doesn't work if the mouse pointer is over scrollbars
Sergey Ivanovskiy wrote:
> Igor, please look at the video of the last P2j test against ./mouse/load-mouse-pointer.p....
Igor Skornyakov
02:57 PM User Interface Bug #3013: The mouse wheel doesn't work if the mouse pointer is over scrollbars
Committed revision 11059 fixed the 1) issue with labels with TODO comments. Sergey Ivanovskiy
02:31 PM User Interface Bug #3013: The mouse wheel doesn't work if the mouse pointer is over scrollbars
Igor, please look at the video of the last P2j test against ./mouse/load-mouse-pointer.p. It seems that two unknown i... Sergey Ivanovskiy
02:15 PM Base Language Feature #1612: finish SESSION system handle support
The note 59 has been updated. Igor Skornyakov
12:40 PM Database Bug #3026: BUFFER-DELETE() method does not account for table-level delete validation
Our implementation of the @BUFFER-DELETE()@ method is incomplete. If the table containing the target record has schem... Eric Faulhaber
12:39 PM Database Bug #3026 (Closed): BUFFER-DELETE() method does not account for table-level delete validation
Eric Faulhaber
11:07 AM Database Feature #2692: table-level VALEXP/VALMSG support
One other aspect of this task is still open: I've discovered that our implementation of the @BUFFER-DELETE()@ method ... Eric Faulhaber
03:28 AM User Interface Bug #3025: Do not show resize cursor for non-resizable window
When window widget RESIZE attribute set to false, we still show resize cursor at the wndow edges. Hynek Cihlar
03:27 AM User Interface Bug #3025 (New): Do not show resize cursor for non-resizable window
Hynek Cihlar

03/09/2016

06:07 PM Base Language Feature #1612: finish SESSION system handle support
My initial description of the @DEBEG-ALERT@ semantics was not correct as I started me tests from the Procedure Editor... Igor Skornyakov
02:47 PM User Interface Bug #2954: Focus is not put on the expected widget when window activated
Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> > Hynek, do you know if caption buttons should be traversed using ...
Sergey Ivanovskiy
02:17 PM User Interface Bug #2954: Focus is not put on the expected widget when window activated
Sergey Ivanovskiy wrote:
> Hynek, do you know if caption buttons should be traversed using TAB or SHIFT + TAB?
No...
Hynek Cihlar
02:09 PM User Interface Bug #2954: Focus is not put on the expected widget when window activated
Hynek, do you know if caption buttons should be traversed using TAB or SHIFT + TAB? Sergey Ivanovskiy
01:52 PM User Interface Bug #2954: Focus is not put on the expected widget when window activated
Sergey Ivanovskiy wrote:
> The attached program doesn't work correctly with "shift + tab" in the web and swing clien...
Sergey Ivanovskiy
12:45 PM User Interface Bug #2954: Focus is not put on the expected widget when window activated
The note 37 has been updated. Sergey Ivanovskiy
12:40 PM User Interface Bug #2954: Focus is not put on the expected widget when window activated
The common issue (Swing and Web clients) with the focus_order.p is the top "h2" window doesn't highlight its title bar. Sergey Ivanovskiy
12:37 PM User Interface Bug #2954: Focus is not put on the expected widget when window activated
The attached program doesn't work correctly with "shift + tab" in the web and swing clients. Planning to investigate ... Sergey Ivanovskiy
11:58 AM User Interface Bug #2954: Focus is not put on the expected widget when window activated
Found that labels in frames are not registered as widgets but have unique ids. In this program "A" if the mouse point... Sergey Ivanovskiy
11:06 AM User Interface Bug #2849: implement and/or fix the default popup menus for all widgets
Committed revision 11018 fixed @p2j.mouse.js@. Sergey Ivanovskiy
10:07 AM User Interface Bug #2849: implement and/or fix the default popup menus for all widgets
Vadim Gindin wrote:
> Window title popup isn't working for Web client.. (but it works for SWING). What could be a re...
Sergey Ivanovskiy
09:55 AM User Interface Bug #2849: implement and/or fix the default popup menus for all widgets
> I don't understand.. Sergey, is proposed fix complete? Why wouldn't you commit it?
Because it contains some changes...
Sergey Ivanovskiy
09:16 AM User Interface Bug #2849: implement and/or fix the default popup menus for all widgets
I don't understand.. Sergey, is proposed fix complete? Why wouldn't you commit it? Vadim Gindin
09:17 AM User Interface Bug #3023: error when frame initialization fails
If the shared frames do not match with their master frame, the initialization should raise 683 condition and the proc... Ovidiu Maxiniuc
09:01 AM User Interface Bug #3023 (New): error when frame initialization fails
Ovidiu Maxiniuc
08:58 AM User Interface Bug #3022: frame widgets and menus remain registered to ConfigManager and LogicalTerminal
I noticed that information about widgets created by a procedure remain in @ConfigManager@ and @LogicalTerminal@ data ... Ovidiu Maxiniuc
08:26 AM User Interface Bug #3022 (New): frame widgets and menus remain registered to ConfigManager and LogicalTerminal
Ovidiu Maxiniuc
07:31 AM User Interface Bug #3021: MESSAGE with SET clause works incorrectly
With Progress the attached program displays empty string and accepts @ENTER@ while converted version displays "?" and... Igor Skornyakov
07:28 AM User Interface Bug #3021 (Closed): MESSAGE with SET clause works incorrectly
Igor Skornyakov
03:50 AM User Interface Support #2672: GUI web client performance improvements
I've committed the changes I've made last week for the state-sync optimization to branch 2672b (from trunk rev 10980)... Constantin Asofiei

03/08/2016

04:26 PM Base Language Feature #1612: finish SESSION system handle support
Greg Shah wrote:
> Code Review Task Branch 1612a Revision 10983
>
> 1. Are you sure that only the @message(Object...
Igor Skornyakov
04:21 PM Base Language Feature #1612: finish SESSION system handle support
Code Review Task Branch 1612a Revision 10983
1. Are you sure that only the @message(Object[] list, ColorSpec cs, han...
Greg Shah
04:17 PM Base Language Feature #1612: finish SESSION system handle support
Rebased task branch 1612a from P2J trunk rev 10980. The latest revision is now 10983. Igor Skornyakov
04:07 PM Base Language Feature #1612: finish SESSION system handle support
Greg Shah wrote:
> > OK. What should I work on tomorrow?
>
> Is @DATA-ENTRY-RETURN@ done?
>
> Is @APPL-ALERT-B...
Igor Skornyakov
04:04 PM Base Language Feature #1612: finish SESSION system handle support
> OK. What should I work on tomorrow?
Is @DATA-ENTRY-RETURN@ done?
Is @APPL-ALERT-BOXES@ done?
Finish those ...
Greg Shah
03:35 PM Base Language Feature #1612: finish SESSION system handle support
Greg Shah wrote:
> The customer does use @-debugalert@. The @.pf@ I have does not use @-clientlog@ but I will check...
Igor Skornyakov
03:21 PM Base Language Feature #1612: finish SESSION system handle support
> Regarding DEBUG-ALERT. It is possible of course to provide a stack trace of the server-side code, but it will be re... Greg Shah
02:44 PM Base Language Feature #1612: finish SESSION system handle support
Greg Shah wrote:
> I appreciate the updates on @IMMEDIATE-DISPLAY@. As I mentioned in note 86:
>
> > OK, at this...
Igor Skornyakov
02:34 PM Base Language Feature #1612: finish SESSION system handle support
I appreciate the updates on @IMMEDIATE-DISPLAY@. As I mentioned in note 86:
> OK, at this point I think we need t...
Greg Shah
02:31 PM Base Language Feature #1612: finish SESSION system handle support
I was able to see an effect of the @IMMEDIATE-DISPLAY@ attribute (at least partially). Note 59 has been updated. See ... Igor Skornyakov
04:04 PM User Interface Bug #2954: Focus is not put on the expected widget when window activated
Tests to check the focus management are #1798-32. Sergey Ivanovskiy
03:32 PM User Interface Bug #2849: implement and/or fix the default popup menus for all widgets
The web combo boxes display opened drop downs incorrectly to their parents in this branch. Sergey Ivanovskiy
03:11 PM User Interface Bug #2849: implement and/or fix the default popup menus for all widgets
Sergey Ivanovskiy wrote:
> Greg Shah wrote:
> > > window title popup is not opened for WEB client.
> >
> > This ...
Sergey Ivanovskiy
01:52 PM User Interface Bug #2849: implement and/or fix the default popup menus for all widgets
Greg Shah wrote:
> > window title popup is not opened for WEB client.
>
> This is caused by the broken @findMouse...
Sergey Ivanovskiy
01:28 PM User Interface Bug #2849: implement and/or fix the default popup menus for all widgets
I've committed my current changes and rebased the branch. Now current revision is 11017. Vadim Gindin
12:42 PM User Interface Bug #2849: implement and/or fix the default popup menus for all widgets
Constantin Asofiei wrote:
> Vadim Gindin wrote:
> > Constantin Asofiei wrote:
> > > Review for 2849a rev 11006:
>...
Vadim Gindin
11:19 AM User Interface Bug #2849: implement and/or fix the default popup menus for all widgets
> window title popup is not opened for WEB client.
This is caused by the broken @findMouseSource()@, right?
Ser...
Greg Shah
11:16 AM User Interface Bug #2849: implement and/or fix the default popup menus for all widgets
Greg Shah wrote:
> Greg Shah wrote:
> > > Some items in window title bar popup have icons, such as Close, Maximize,...
Vadim Gindin
10:42 AM User Interface Bug #2849: implement and/or fix the default popup menus for all widgets
Greg Shah wrote:
> > Some items in window title bar popup have icons, such as Close, Maximize, Minimize, Restore. Sh...
Greg Shah
07:33 AM User Interface Bug #2849: implement and/or fix the default popup menus for all widgets
Vadim Gindin wrote:
> Constantin Asofiei wrote:
> > Review for 2849a rev 11006:
> > # @EditorGuiImpl.mouseClicked@...
Constantin Asofiei
06:12 AM User Interface Bug #2849: implement and/or fix the default popup menus for all widgets
Window title popup isn't working for Web client.. (but it works for SWING). What could be a reason - coordinates? Edi... Vadim Gindin
03:27 PM User Interface Feature #2967 (WIP): web socket message sizes are limited to 32K, make sure that drawing ops and ...
Yes, both these issues will be handled by Constantin. Greg Shah
01:14 PM User Interface Feature #2967: web socket message sizes are limited to 32K, make sure that drawing ops and images...
> If I understand correctly, the remaining work for this task is for Constantin. Correct?
Yes if the known two issu...
Sergey Ivanovskiy
10:53 AM User Interface Feature #2967: web socket message sizes are limited to 32K, make sure that drawing ops and images...
If I understand correctly, the remaining work for this task is for Constantin. Correct? Greg Shah
02:42 PM Base Language Bug #3020: Add support for the IMMEDIATE-DISPLAY and MULTITASKING-INTERVAL SEEION attributes
In a simplest scenario when @MULTITASKING-INTERVAL@ == 0 (default value) the @IMMEDIATE-DISPLAY@ is @false@ (default ... Igor Skornyakov
02:38 PM Base Language Bug #3020 (Test): Add support for the IMMEDIATE-DISPLAY and MULTITASKING-INTERVAL SEEION attributes
Igor Skornyakov
01:44 PM User Interface Support #2675: list of differences between the web GUI client and the original 4GL Windows GUI en...
The current implementation of the GUI web client redirects to the login page if a user executes the reload/refresh co... Sergey Ivanovskiy
12:14 PM User Interface Bug #2914: Fix errors in window_sizing/test_runner.p
Rebased task branch 2914b against trunk revision 10980. 2914b is now at revision 10982. ChUI regression test restarted. Hynek Cihlar
12:08 PM User Interface Bug #2914: Fix errors in window_sizing/test_runner.p
Greg Shah wrote:
> Please note that a rebase will be needed.
Right, thanks for pointing this out.
Hynek Cihlar
12:06 PM User Interface Bug #2914: Fix errors in window_sizing/test_runner.p
Code Review Task Branch 2914b Revision 10981
The changes are fine.
Please note that a rebase will be needed.
Greg Shah
11:27 AM User Interface Bug #2914: Fix errors in window_sizing/test_runner.p
Please review task branch 2914b revision 10981. It contains a regression fix - frame/window size may be calculated wr... Hynek Cihlar
11:35 AM User Interface Feature #3019: Add icons support to menu items
> > Is it possible to implement icons in a 4GL custom popup menu?
>
> If you asked about possibility to assign ico...
Greg Shah
11:29 AM User Interface Feature #3019: Add icons support to menu items
Greg Shah wrote:
> Are there icons in any of the other default menus (e.g. for editor and fill-in)?
No. Icons are on...
Vadim Gindin
11:17 AM User Interface Feature #3019: Add icons support to menu items
Are there icons in any of the other default menus (e.g. for editor and fill-in)?
Is it possible to implement icons...
Greg Shah
11:13 AM User Interface Feature #3019: Add icons support to menu items
Window title popup contains icons for the following items: Close, Maximize, Minimize, Restore. Add new class for Menu... Vadim Gindin
11:09 AM User Interface Feature #3019 (New): Add icons support to menu items
Vadim Gindin
11:00 AM User Interface Bug #2968: disconnect/reconnect and manual reload must re-establish the websocket connection, nee...
Is there anything more to do on this task, other than adding comments?
Please document the limitations of our relo...
Greg Shah
08:04 AM User Interface Support #2672: GUI web client performance improvements
Please put primary focus on the editing improvements. We know there is much to be gained there.
While you are wor...
Greg Shah
05:32 AM User Interface Support #2672: GUI web client performance improvements
Greg, I can continue with the state-sync changes, but (again) this doesn't solve fully our scenario. The most used A... Constantin Asofiei
05:16 AM User Interface Support #2672: GUI web client performance improvements
Testing passed and 2672a rev 10982 was merged to trunk rev 10980. Branch 2672a was archived. Constantin Asofiei
07:05 AM User Interface Feature #1798: implement full frame family support (parent-child relationships between frames)
See the @testcases/uast/frame-z-order/frame-parenting.p@, @nested-frames.p@ and @frame-parenting2.p@ tests. Constantin Asofiei

03/07/2016

05:56 PM User Interface Bug #2914: Fix errors in window_sizing/test_runner.p
I have opened task branch 2914b for regression fixes. Hynek Cihlar
04:10 PM User Interface Bug #2849: implement and/or fix the default popup menus for all widgets
In previous note please read "When I've *commented* @findMouseSource@ change" instead of "When I've committed @findMo... Vadim Gindin
04:09 PM User Interface Bug #2849: implement and/or fix the default popup menus for all widgets
Constantin Asofiei wrote:
> Review for 2849a rev 11006:
> # have you tested this with the Web client?
Not yet.
> ...
Vadim Gindin
03:54 PM User Interface Bug #2849: implement and/or fix the default popup menus for all widgets
This change to @findMouseSource()@ has been removed in revision 11056 of branch 1811t. It has been replaced with a d... Greg Shah
03:50 PM User Interface Bug #2849: implement and/or fix the default popup menus for all widgets
W/o this fix the selection by mouse drag and scrolling by mouse wheel was not working. Igor Skornyakov
03:48 PM User Interface Bug #2849: implement and/or fix the default popup menus for all widgets
Igor, I've found that you changed @EditorGuiImpl.findMouseSource()@, adding @this == src.parent(EditorGuiImpl.class)@... Vadim Gindin
01:07 AM User Interface Bug #2849: implement and/or fix the default popup menus for all widgets
I've rebased the branch. Current revision is 11013. Vadim Gindin
02:41 PM User Interface Feature #1798: implement full frame family support (parent-child relationships between frames)
Constantin: what testcases can be used to explore our frame family support (especially in regard to focus processing)... Greg Shah
01:37 PM Base Language Feature #1612: finish SESSION system handle support
I cannot reproduce the effect of the @IMMEDIATE-DISPLAY@ I've seen initially. I'm really start to think that it was a... Igor Skornyakov
11:56 AM Base Language Feature #1612: finish SESSION system handle support
The note 59 has been updated. Igor Skornyakov
01:07 PM User Interface Bug #3013 (Closed): The mouse wheel doesn't work if the mouse pointer is over scrollbars
It looks good. I'm closing this task. Greg Shah
01:04 PM User Interface Bug #3013: The mouse wheel doesn't work if the mouse pointer is over scrollbars
Committed revision 11056 fixed history entries and added todo comments. Sergey Ivanovskiy
12:13 PM User Interface Bug #3013: The mouse wheel doesn't work if the mouse pointer is over scrollbars
> Do you mean to add processAction(MouseEvent e) to Widget and to implement it in subclasses?
I'm not sure. At th...
Greg Shah
12:05 PM User Interface Bug #3013: The mouse wheel doesn't work if the mouse pointer is over scrollbars
> Also, in regard to the issue from note 38 (it is still a problem, right?) please open a new bug as subtask for #267... Sergey Ivanovskiy
11:59 AM User Interface Bug #3013: The mouse wheel doesn't work if the mouse pointer is over scrollbars
Good. Make the cleanup I requested in the code review.
Also, in regard to the issue from note 38 (it is still a p...
Greg Shah
11:57 AM User Interface Bug #3013: The mouse wheel doesn't work if the mouse pointer is over scrollbars
It seems that p2j and 1811t perform @uast/mouse/load-mouse-pointer.p@ similarly. Sergey Ivanovskiy
11:52 AM User Interface Bug #3013: The mouse wheel doesn't work if the mouse pointer is over scrollbars
Is there anything left to do on this task? Greg Shah
11:51 AM User Interface Bug #3013: The mouse wheel doesn't work if the mouse pointer is over scrollbars
Code Review Task Branch 1811t Revisions 11054/11055
I like the approach.
1. I prefer not to encode widget-speci...
Greg Shah
11:01 AM User Interface Support #2672: GUI web client performance improvements
Greg Shah wrote:
> Please rebase to trunk 10979 and then rerun regression testing.
Rebased and runtime testing star...
Constantin Asofiei
10:46 AM User Interface Support #2672: GUI web client performance improvements
Greg Shah wrote:
> > Next work (related to networked exported APIs/StateSync) can be released into 1811t.
>
> Is ...
Constantin Asofiei
10:44 AM User Interface Support #2672: GUI web client performance improvements
> Next work (related to networked exported APIs/StateSync) can be released into 1811t.
Is this work higher priorit...
Greg Shah
10:43 AM User Interface Support #2672: GUI web client performance improvements
Please rebase to trunk 10979 and then rerun regression testing. Assuming it passes, you can merge to trunk. Greg Shah
10:32 AM User Interface Support #2672: GUI web client performance improvements
Greg Shah wrote:
> How much more work is needed on this? We need you to move on to other word, unless the remaining...
Constantin Asofiei
10:12 AM User Interface Support #2672: GUI web client performance improvements
Code Review Task Branch 2672a Revision 10981
The changes are fine.
How much more work is needed on this? We ne...
Greg Shah
05:30 AM User Interface Bug #3016: In 4GL window HEIGHT can be less than the actual height
In 4GL window HEIGHT attribute can be assigned to smaller values than the smallest physical window size. So we end up... Hynek Cihlar
05:28 AM User Interface Bug #3016 (New): In 4GL window HEIGHT can be less than the actual height
Hynek Cihlar

03/06/2016

03:50 PM Base Language Feature #1612: finish SESSION system handle support
There is a correlation between @IMMEDIATE-DISPLAY@ and @MULTITASKING-INTERVAL@. The attached test runs the same proce... Igor Skornyakov
02:37 PM Base Language Feature #1612: finish SESSION system handle support
It is strange but today I do not see any effect of the @IMMEDIATE-DISPLAY@ at all. Igor Skornyakov
12:49 PM User Interface Bug #3013: The mouse wheel doesn't work if the mouse pointer is over scrollbars
Igor Skornyakov wrote:
> Sergey Ivanovskiy wrote:
> > There are @FrameGuiImpl@, @ModalWindow@, @OverlayWindow@ and @W...
Sergey Ivanovskiy
12:44 PM User Interface Bug #3013: The mouse wheel doesn't work if the mouse pointer is over scrollbars
Sergey Ivanovskiy wrote:
> There are @FrameGuiImpl@, @ModalWindow@, @OverlayWindow@ and @WindowGuiImpl@ classes that...
Igor Skornyakov
11:21 AM User Interface Bug #3013: The mouse wheel doesn't work if the mouse pointer is over scrollbars
Igor Skornyakov wrote:
> The semantics you describe can looks OK. The problem is that I it seems to be not exactly c...
Sergey Ivanovskiy
10:57 AM User Interface Bug #3013: The mouse wheel doesn't work if the mouse pointer is over scrollbars
Sergey Ivanovskiy wrote:
> Understand your position and trying to explain and to prove that this change of @Abstract...
Igor Skornyakov
10:54 AM User Interface Bug #3013: The mouse wheel doesn't work if the mouse pointer is over scrollbars
Igor Skornyakov wrote:
> Sergey Ivanovskiy wrote:
> > Thanks, I will use it. Igor, are you planning to fix it? Can I ...
Sergey Ivanovskiy
10:35 AM User Interface Bug #3013: The mouse wheel doesn't work if the mouse pointer is over scrollbars
Greg Shah wrote:
> I like the approach (in 3013_2.txt), please go ahead.
Greg, please review the committed revision 1...
Sergey Ivanovskiy
08:44 AM User Interface Bug #3013: The mouse wheel doesn't work if the mouse pointer is over scrollbars
Sergey Ivanovskiy wrote:
> Thanks, I will use it. Igor, are you planning to fix it? Can I look at this too, because ...
Igor Skornyakov
08:01 AM User Interface Bug #3013: The mouse wheel doesn't work if the mouse pointer is over scrollbars
> BTW: you can make a screencast for a single window if in the profile you will choose "Record a single rectangle" an... Sergey Ivanovskiy
07:58 AM User Interface Bug #3013: The mouse wheel doesn't work if the mouse pointer is over scrollbars
BTW: you can make a screencast for a single window if in the profile you will choose "Record a single rectangle" and ... Igor Skornyakov
07:54 AM User Interface Bug #3013: The mouse wheel doesn't work if the mouse pointer is over scrollbars
Sergey Ivanovskiy wrote:
> This tool is helpful. I tried to display the mouse pointer over a scroll bar and a combob...
Igor Skornyakov
07:34 AM User Interface Bug #3013: The mouse wheel doesn't work if the mouse pointer is over scrollbars
This tool is helpful. I tried to display the mouse pointer over a scroll bar and a combobox button. Sergey Ivanovskiy
07:04 AM User Interface Bug #3013: The mouse wheel doesn't work if the mouse pointer is over scrollbars
Sergey Ivanovskiy wrote:
> Igor Skornyakov wrote:
> > Sergey Ivanovskiy wrote:
> > > Ok, understand. Please look a...
Igor Skornyakov
06:41 AM User Interface Bug #3013: The mouse wheel doesn't work if the mouse pointer is over scrollbars
Igor Skornyakov wrote:
> Sergey Ivanovskiy wrote:
> > Ok, understand. Please look at the next scenario (in note 17) I...
Sergey Ivanovskiy
05:28 AM User Interface Bug #3013: The mouse wheel doesn't work if the mouse pointer is over scrollbars
I've added a more detailed screencast of the test. Igor Skornyakov
05:13 AM User Interface Bug #3013: The mouse wheel doesn't work if the mouse pointer is over scrollbars
Ok. I will send you screen shot that is suspected (note 17) in P2j Sergey Ivanovskiy
05:08 AM User Interface Bug #3013: The mouse wheel doesn't work if the mouse pointer is over scrollbars
Sergey Ivanovskiy wrote:
> Ok, understand. Please look at the next scenario (in note 17) Is this behavior correct?
...
Igor Skornyakov
05:04 AM User Interface Bug #3013: The mouse wheel doesn't work if the mouse pointer is over scrollbars
Igor Skornyakov wrote:
> Sergey Ivanovskiy wrote:
> > These steps are described in note 19
> > 1) Run uast/mouse/load...
Sergey Ivanovskiy
04:51 AM User Interface Bug #3013: The mouse wheel doesn't work if the mouse pointer is over scrollbars
Sergey Ivanovskiy wrote:
> These steps are described in note 19
> 1) Run uast/mouse/load-mouse-pointer.p
> 2) Sele...
Igor Skornyakov
04:50 AM User Interface Bug #3013: The mouse wheel doesn't work if the mouse pointer is over scrollbars
Igor Skornyakov wrote:
> Here is the screencast of the mouse cursor test. Made with http://www.maartenbaert.be/simpl...
Sergey Ivanovskiy
04:43 AM User Interface Bug #3013: The mouse wheel doesn't work if the mouse pointer is over scrollbars
These steps are described in note 19
1) Run uast/mouse/load-mouse-pointer.p
2) Select "WAIT" cursor from "wcur" com...
Sergey Ivanovskiy

03/05/2016

07:47 AM User Interface Support #2672: GUI web client performance improvements
2672a rev 10981 contains comments and some other changes (mostly rollbacks). Constantin Asofiei
07:47 AM User Interface Support #2672: GUI web client performance improvements
rules for attributes:
# all size-related attributes setters change the AUTO-RESIZE to FALSE (regardless if is a no-o...
Constantin Asofiei
05:46 AM User Interface Bug #2849: implement and/or fix the default popup menus for all widgets
Review for 2849a rev 11006:
# have you tested this with the Web client?
# some classes are missing history entries
...
Constantin Asofiei
04:14 AM User Interface Bug #3013: The mouse wheel doesn't work if the mouse pointer is over scrollbars
Here is the screencast of the mouse cursor test. Made with http://www.maartenbaert.be/simplescreenrecorder/ Igor Skornyakov

03/04/2016

05:27 PM User Interface Bug #2914 (Closed): Fix errors in window_sizing/test_runner.p
Greg Shah
05:26 PM User Interface Bug #2914: Fix errors in window_sizing/test_runner.p
Greg Shah wrote:
> I can close this task, right?
Yes, please.
Hynek Cihlar
05:12 PM User Interface Bug #2914: Fix errors in window_sizing/test_runner.p
I can close this task, right? Greg Shah
05:10 PM User Interface Bug #2914: Fix errors in window_sizing/test_runner.p
2914a committed to trunk as rev 10979 and archived. Hynek Cihlar
04:58 PM User Interface Bug #2914: Fix errors in window_sizing/test_runner.p
Code Review Task Branch 2914a Revision 10998
The changes are good.
Please merge this to trunk.
Greg Shah
04:56 PM User Interface Bug #2914: Fix errors in window_sizing/test_runner.p
2914a passed ChUI regression tests. Note that the regression fix in 10998 only affects GUI code. Hynek Cihlar
04:53 PM User Interface Bug #2914: Fix errors in window_sizing/test_runner.p
Greg Shah wrote:
> Code Review Task Branch 2914a Revision 10997
>
> You're right, I had not reverted. It was my ...
Hynek Cihlar
04:49 PM User Interface Bug #2914: Fix errors in window_sizing/test_runner.p
Code Review Task Branch 2914a Revision 10997
You're right, I had not reverted. It was my mistake, sorry.
Pleas...
Greg Shah
04:43 PM User Interface Bug #2914: Fix errors in window_sizing/test_runner.p
Greg Shah wrote:
> Code Review Task Branch 2914a Revision 10997
>
> This revision is not compilable.
>
> 1. Th...
Hynek Cihlar
04:16 PM User Interface Bug #2914: Fix errors in window_sizing/test_runner.p
Code Review Task Branch 2914a Revision 10997
This revision is not compilable.
1. There are merge problems with ...
Greg Shah
08:57 AM User Interface Bug #2914: Fix errors in window_sizing/test_runner.p
Please review 2914a rev 10997. It is a release candidate with all the required changes for this issue.
Note that Ch...
Hynek Cihlar
05:23 PM User Interface Bug #3013: The mouse wheel doesn't work if the mouse pointer is over scrollbars
Greg Shah wrote:
> I don't understand. Does note 19 describe a bug or not?
>
> At a minimum, there is confusion ...
Igor Skornyakov
05:18 PM User Interface Bug #3013: The mouse wheel doesn't work if the mouse pointer is over scrollbars
I don't understand. Does note 19 describe a bug or not?
At a minimum, there is confusion here so perhaps some cla...
Greg Shah
05:12 PM User Interface Bug #3013: The mouse wheel doesn't work if the mouse pointer is over scrollbars
Greg Shah wrote:
> > This is actually a bad wording in the test plan.
>
> Igor: please update the test plan to b...
Igor Skornyakov
04:54 PM User Interface Bug #3013: The mouse wheel doesn't work if the mouse pointer is over scrollbars
> This is actually a bad wording in the test plan.
Igor: please update the test plan to be accurate.
Greg Shah
04:54 PM User Interface Bug #3013: The mouse wheel doesn't work if the mouse pointer is over scrollbars
I like the approach (in 3013_2.txt), please go ahead. Greg Shah
04:53 PM User Interface Bug #3013: The mouse wheel doesn't work if the mouse pointer is over scrollbars
Sergey Ivanovskiy wrote:
> In p2j trunc version @uast/mouse/load-mouse-pointer.p@ doesn't pass the 1 test
> [...]
...
Igor Skornyakov
04:30 PM User Interface Bug #3013: The mouse wheel doesn't work if the mouse pointer is over scrollbars
Planning to commit this diff that moves 1811t to be the same as p2j, but it doesn't fix these bugs, because there are... Sergey Ivanovskiy
04:18 PM User Interface Bug #3013: The mouse wheel doesn't work if the mouse pointer is over scrollbars
In p2j trunc version @uast/mouse/load-mouse-pointer.p@ doesn't pass the 1 test... Sergey Ivanovskiy
01:06 PM User Interface Bug #3013: The mouse wheel doesn't work if the mouse pointer is over scrollbars
Another reason with @AbstractContainer.findMouseSource@ it can impact the focus management. Sergey Ivanovskiy
11:47 AM User Interface Bug #3013: The mouse wheel doesn't work if the mouse pointer is over scrollbars
The things are very complicated because I suspect the test 1 for p2j trunc in the case of COMBO-BOX SIMPLE
because if...
Sergey Ivanovskiy
10:53 AM User Interface Bug #3013: The mouse wheel doesn't work if the mouse pointer is over scrollbars
I understand the great work has been done with custom cursors, this test is really complicated and it looks that thes... Sergey Ivanovskiy
09:54 AM User Interface Bug #3013: The mouse wheel doesn't work if the mouse pointer is over scrollbars
Igor Skornyakov wrote:
> Sergey Ivanovskiy wrote:
> > Do you have some tests to check it?
>
> The test for the c...
Sergey Ivanovskiy
09:53 AM User Interface Bug #3013: The mouse wheel doesn't work if the mouse pointer is over scrollbars
Sergey Ivanovskiy wrote:
> Do you have some tests to check it?
The test for the custom cursor functionality is @u...
Igor Skornyakov
09:51 AM User Interface Bug #3013: The mouse wheel doesn't work if the mouse pointer is over scrollbars
Igor: please explain to Sergey, how to test the custom cursor for combo-box.
Sergey: If it is broken, please find ...
Greg Shah
09:50 AM User Interface Bug #3013: The mouse wheel doesn't work if the mouse pointer is over scrollbars
Igor Skornyakov wrote:
> Sergey Ivanovskiy wrote:
> > I have check the behavior of the default cursor with combo bo...
Sergey Ivanovskiy
09:47 AM User Interface Bug #3013: The mouse wheel doesn't work if the mouse pointer is over scrollbars
Sergey Ivanovskiy wrote:
> I have check the behavior of the default cursor with combo box, but how it can be if the ...
Igor Skornyakov
09:44 AM User Interface Bug #3013: The mouse wheel doesn't work if the mouse pointer is over scrollbars
I have check the behavior of the default cursor with combo box, but how it can be if the custom don't work while the ... Sergey Ivanovskiy
09:40 AM User Interface Bug #3013: The mouse wheel doesn't work if the mouse pointer is over scrollbars
Igor Skornyakov wrote:
> Greg Shah wrote:
> > Code Review Task Branch 1811t Revision 11051
> >
> > I'm fine with...
Sergey Ivanovskiy
09:31 AM User Interface Bug #3013: The mouse wheel doesn't work if the mouse pointer is over scrollbars
Greg Shah wrote:
> Code Review Task Branch 1811t Revision 11051
>
> I'm fine with the changes.
>
> My only con...
Igor Skornyakov
09:11 AM User Interface Bug #3013: The mouse wheel doesn't work if the mouse pointer is over scrollbars
> Code Review Task Branch 1811t Revision 11051
>
> My only concern is that the changes were put there for a specif...
Sergey Ivanovskiy
08:58 AM User Interface Bug #3013: The mouse wheel doesn't work if the mouse pointer is over scrollbars
Code Review Task Branch 1811t Revision 11051
I'm fine with the changes.
My only concern is that the changes wer...
Greg Shah
05:15 PM Base Language Feature #1612: finish SESSION system handle support
Greg Shah wrote:
> What a surprise, you've found another Progress documentation failure.
>
> Please note that Eug...
Igor Skornyakov
05:10 PM Base Language Feature #1612: finish SESSION system handle support
What a surprise, you've found another Progress documentation failure.
Please note that Eugenie found exactly the s...
Greg Shah
05:00 PM Base Language Feature #1612: finish SESSION system handle support
Greg Shah wrote:
> Your description of @IMMEDIATE-DISPLAY@ is the opposite of how it is described by Progress:
>
...
Igor Skornyakov
01:59 PM Base Language Feature #1612: finish SESSION system handle support
Greg Shah wrote:
> > It seems that there is no problem with Swing GUI. Roughly speaking it is sufficient to check th...
Igor Skornyakov
01:49 PM Base Language Feature #1612: finish SESSION system handle support
> It seems that there is no problem with Swing GUI. Roughly speaking it is sufficient to check the value of the @IMME... Greg Shah
01:07 PM Base Language Feature #1612: finish SESSION system handle support
Greg Shah wrote:
> Your description of @IMMEDIATE-DISPLAY@ is the opposite of how it is described by Progress:
Sorr...
Igor Skornyakov
12:42 PM Base Language Feature #1612: finish SESSION system handle support
Your description of @IMMEDIATE-DISPLAY@ is the opposite of how it is described by Progress:... Greg Shah
10:39 AM Base Language Feature #1612: finish SESSION system handle support
Eugenie Lyzenko wrote:
> >Eugenie, please comment.
>
> This is mandatory with the current working model(like for ...
Hynek Cihlar
10:27 AM Base Language Feature #1612: finish SESSION system handle support
Greg Shah wrote:
> Questions:
>
> 1. What does "all output operation" mean?
> 2. What does "pending updates" mea...
Igor Skornyakov
10:17 AM Base Language Feature #1612: finish SESSION system handle support
>Eugenie, please comment.
This is mandatory with the current working model(like for @EntryFieldGuiImpl@). These ar...
Eugenie Lyzenko
10:15 AM Base Language Feature #1612: finish SESSION system handle support
> The semantics of the DATA-ENTRY-RETURN seems to be as described in the Progress documentation (see uast/session/dat... Greg Shah
10:13 AM Base Language Feature #1612: finish SESSION system handle support
Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > The problematic code is in @ComboBoxGuiImpl.createSimpleList()@...
Igor Skornyakov
10:04 AM Base Language Feature #1612: finish SESSION system handle support
Hynek Cihlar wrote:
> The problematic code is in @ComboBoxGuiImpl.createSimpleList()@, for some reason the method ad...
Constantin Asofiei
10:03 AM Base Language Feature #1612: finish SESSION system handle support
Greg Shah wrote:
> Before I can evaluate your proposal, I need to understand what exactly IMMEDIATE-DISPLAY does. P...
Igor Skornyakov
09:53 AM Base Language Feature #1612: finish SESSION system handle support
Igor Skornyakov wrote:
> It seems that @Frame.isLastWidget()@ method is not exactly correct.
> For the the frame de...
Hynek Cihlar
09:52 AM Base Language Feature #1612: finish SESSION system handle support
Before I can evaluate your proposal, I need to understand what exactly IMMEDIATE-DISPLAY does. Please provide a desc... Greg Shah
09:50 AM Base Language Feature #1612: finish SESSION system handle support
There are still number of details regarding @IMMEDIATE-DISPLAY@ to be checked but one problem is clear right now.
...
Igor Skornyakov
04:56 PM User Interface Support #2672: GUI web client performance improvements
> So, the runtime will have just a flag check - the overall impact will be minimal, no reflection involved.
Good i...
Greg Shah
04:52 PM User Interface Support #2672: GUI web client performance improvements
Greg Shah wrote:
> On the other hand, if most APIs are safe for the bypass, then I wouldn't want to edit all of them...
Constantin Asofiei
04:44 PM User Interface Support #2672: GUI web client performance improvements
> But the other idea - to discard the StateSync part from the message completely (thus don't even call getChanges or ... Greg Shah
04:38 PM User Interface Support #2672: GUI web client performance improvements
Greg Shah wrote:
> > I will document them here (and in the P2J code, where the attributes are defined).
>
> Good...
Constantin Asofiei
04:37 PM User Interface Support #2672: GUI web client performance improvements
Greg Shah wrote:
> I'm surprised that this would be possible. I thought that we have cases where we allow changes t...
Constantin Asofiei
04:24 PM User Interface Support #2672: GUI web client performance improvements
> I will document them here (and in the P2J code, where the attributes are defined).
Good.
If you want to merg...
Greg Shah
04:23 PM User Interface Support #2672: GUI web client performance improvements
> I think is better a reverse approach: mark only the APIs which actually affect the UI. Because there are other sta... Greg Shah
04:10 PM User Interface Support #2672: GUI web client performance improvements
Greg Shah wrote:
> > For cases like ServerExports or ClientExports APIs which need only get some server-side state o...
Constantin Asofiei
03:59 PM User Interface Support #2672: GUI web client performance improvements
Greg Shah wrote:
> My only question: what was the process that you used to determine these attributes were safe to t...
Constantin Asofiei
03:56 PM User Interface Support #2672: GUI web client performance improvements
Code Review Task Branch 2672a Revision 10980
I'm OK with the changes.
My only question: what was the process th...
Greg Shah
03:02 PM User Interface Support #2672: GUI web client performance improvements
Greg Shah wrote:
> > 2672a revision 10980 adds no-op for attribute setters which allow this, but the impact is not s...
Constantin Asofiei
01:53 PM User Interface Support #2672: GUI web client performance improvements
> For cases like ServerExports or ClientExports APIs which need only get some server-side state or data (and are non-... Greg Shah
12:40 PM User Interface Support #2672: GUI web client performance improvements
In a BROWSE widget, for a single mouse click in a row, there are 6 client-server trips for just this row selection. ... Constantin Asofiei
12:25 PM User Interface Support #2672: GUI web client performance improvements
1811t rev 11053 compacts the "enable OS events" calls for the web driver, in a single call: all window IDs are passed... Constantin Asofiei
04:33 PM User Interface Bug #2849: implement and/or fix the default popup menus for all widgets
Vadim, please rebase the branch to latest trunk. Constantin Asofiei
02:22 PM User Interface Bug #2849: implement and/or fix the default popup menus for all widgets
> I've fixed the first remark... What about others?
As Hynek notes, we have some significant changes coming for th...
Greg Shah
02:19 PM User Interface Bug #2849: implement and/or fix the default popup menus for all widgets
> Some items in window title bar popup have icons, such as Close, Maximize, Minimize, Restore. Should I implement ico... Greg Shah
07:37 AM User Interface Bug #2849: implement and/or fix the default popup menus for all widgets
I've fixed the first remark... What about others? Vadim Gindin
05:26 AM User Interface Bug #2849: implement and/or fix the default popup menus for all widgets
Vadim Gindin wrote:
> I've fixed popup imlementation for dialog boxes. Please review. Revision 11005.
* @MousePop...
Hynek Cihlar
03:45 AM User Interface Bug #2849: implement and/or fix the default popup menus for all widgets
I've fixed popup imlementation for dialog boxes. Please review. Revision 11005.
Some items in window title bar pop...
Vadim Gindin
02:33 PM User Interface Feature #2564: implement GUI BROWSE widget
Rebased task branch 2564f from P2J trunk revision 10988. Stanislav Lomany
01:14 PM User Interface Bug #3015: Frame scrolling is broken
When frame content is scrolled, it is redrawn with artifacts. This can be reproduced in @uast/demo/demo_widgets.p@. Hynek Cihlar
01:12 PM User Interface Bug #3015 (New): Frame scrolling is broken
Hynek Cihlar
09:48 AM User Interface Bug #2954: Focus is not put on the expected widget when window activated
Yes, correct. I don't think the other modules need to use it. The message types should be hidden inside @p2j.socket... Greg Shah
09:17 AM User Interface Bug #2954: Focus is not put on the expected widget when window activated
Greg Shah wrote:
> To be clear, I'm suggesting that all the constants should be in a private var inside @p2j.sockets...
Sergey Ivanovskiy
09:15 AM User Interface Bug #2954: Focus is not put on the expected widget when window activated
To be clear, I'm suggesting that all the constants should be in a private var inside @p2j.sockets.js@. Greg Shah
09:13 AM User Interface Bug #2954: Focus is not put on the expected widget when window activated
Code Review Task Branch 1811t Revision 11052
I don't see the need to expose all of these constants as public data....
Greg Shah

03/03/2016

04:49 PM Base Language Feature #1612: finish SESSION system handle support
Implemented runtime support for the @SESSION:DATA-ENTRY-RETURN@ attribute.
Committed to the task branch 1612a revn...
Igor Skornyakov
02:05 PM Base Language Feature #1612: finish SESSION system handle support
It seems that @Frame.isLastWidget()@ method is not exactly correct.
For the the frame definition...
Igor Skornyakov
01:15 PM Base Language Feature #1612: finish SESSION system handle support
Eugenie Lyzenko wrote:
> The idea behind if when the @ENTER@ key is pressing in combo-box with editable field(and dr...
Igor Skornyakov
01:12 PM Base Language Feature #1612: finish SESSION system handle support
The idea behind if when the @ENTER@ key is pressing in combo-box with editable field(and drop-down is closed) or in f... Eugenie Lyzenko
12:54 PM Base Language Feature #1612: finish SESSION system handle support
Greg Shah wrote:
> In regard to the call to @getDataEntryReturn()@, I imagine that this may have to do with support ...
Igor Skornyakov
12:39 PM Base Language Feature #1612: finish SESSION system handle support
> What is the reason of the code mentioned above despite this fact (and the comment)?
The comment was probably wri...
Greg Shah
12:16 PM Base Language Feature #1612: finish SESSION system handle support
I see the following code fragment in the @ComboBox.processKeyEvent()@ method... Igor Skornyakov
04:48 PM User Interface Bug #2914: Fix errors in window_sizing/test_runner.p
Rebased task branch 2914a against trunk revision 10978. 2914a is now at revision 10996. Hynek Cihlar
03:46 PM User Interface Bug #2914: Fix errors in window_sizing/test_runner.p
During frame setup when a client remote call is performed the frame may be considered dead and removed from the clien... Hynek Cihlar
03:14 PM Database Bug #2955: Update records participating in a scrolling adaptive query.
Stanislav Lomany wrote:
> > How? What's the error?
>...
Eric Faulhaber
02:56 PM Database Bug #2955: Update records participating in a scrolling adaptive query.
> How? What's the error?... Stanislav Lomany
02:27 PM Database Bug #2955: Update records participating in a scrolling adaptive query.
Stanislav Lomany wrote:
> This issue applies no scrolling/non-scrolling compound queries with no regards to browse (...
Eric Faulhaber
12:53 PM Database Bug #2955: Update records participating in a scrolling adaptive query.
This issue applies no scrolling/non-scrolling compound queries with no regards to browse (however using an editable b... Stanislav Lomany
10:49 PM Database Bug #2955: Update records participating in a scrolling adaptive query.
Stanislav Lomany wrote:
> Guys, please consider the design of the solution for this issue (see previous note):
> 1....
Eric Faulhaber
02:23 PM User Interface Bug #2954: Focus is not put on the expected widget when window activated
Greg, please review committed revision 11052 that adds named constants @p2j.constants.js@.
Sergey Ivanovskiy
08:09 AM User Interface Bug #2954: Focus is not put on the expected widget when window activated
Sergey Ivanovskiy wrote:
> Constantin, could you help to explain the issue in note 23? It is important to fix its re...
Constantin Asofiei
06:22 AM User Interface Bug #2954: Focus is not put on the expected widget when window activated
I need to extend its definition as ... Sergey Ivanovskiy
06:10 AM User Interface Bug #2954: Focus is not put on the expected widget when window activated
Igor Skornyakov wrote:
> Sergey Ivanovskiy wrote:
> > I don't understand what is @AbstractContainer.findMouseSource...
Sergey Ivanovskiy
06:06 AM User Interface Bug #2954: Focus is not put on the expected widget when window activated
Sergey Ivanovskiy wrote:
> I don't understand what is @AbstractContainer.findMouseSource@. I need the answer to fix ...
Igor Skornyakov
05:59 AM User Interface Bug #2954: Focus is not put on the expected widget when window activated
Igor Skornyakov wrote:
> Sergey Ivanovskiy wrote:
> > To be more concrete please look at these changes and the functi...
Sergey Ivanovskiy
02:50 AM User Interface Bug #2954: Focus is not put on the expected widget when window activated
Sergey Ivanovskiy wrote:
> To be more concrete please look at these changes and the function definition
> [...]
> ...
Igor Skornyakov
01:06 AM User Interface Bug #2954: Focus is not put on the expected widget when window activated
To be more concrete please look at these changes and the function definition... Sergey Ivanovskiy
12:00 AM User Interface Bug #2954: Focus is not put on the expected widget when window activated
Sergey Ivanovskiy wrote:
> Ok, the previous 1811t code have able to detect if the mouse is over the scroll bars but n...
Sergey Ivanovskiy
01:16 PM User Interface Bug #3013: The mouse wheel doesn't work if the mouse pointer is over scrollbars
Sergey Ivanovskiy wrote:
> Web client - For the old version 1811t if the mouse pointer is over the scroll bars, then...
Sergey Ivanovskiy
01:00 PM User Interface Bug #3013: The mouse wheel doesn't work if the mouse pointer is over scrollbars
Web client - For the old version 1811t if the mouse pointer is over the scroll bars, then the target scroll bar gets ... Sergey Ivanovskiy
11:15 AM User Interface Bug #3013: The mouse wheel doesn't work if the mouse pointer is over scrollbars
Greg, please review committed revision 11051. It fixed the part 1). Tested with Swing and Web clients. The rest part ... Sergey Ivanovskiy
09:59 AM User Interface Bug #3013: The mouse wheel doesn't work if the mouse pointer is over scrollbars
The code from @AbstractWidget@ implements this function unconditionally to a possible widget id.... Sergey Ivanovskiy
09:44 AM User Interface Bug #3013: The mouse wheel doesn't work if the mouse pointer is over scrollbars
1) in ./demo/demo_widgets.p (com.goldencode.testcases.demo.DemoWidgets.execute) the editor doesn't scroll its content... Sergey Ivanovskiy
09:36 AM User Interface Bug #3013 (Closed): The mouse wheel doesn't work if the mouse pointer is over scrollbars
Sergey Ivanovskiy
09:06 AM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
It is a good idea. I'll add it. Greg Shah
03:57 AM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Greg.
I've added the test for the LOAD-MOUSE-CURSOR and the test plan (@uast/mouse/load-mouse-pointer.p@ and @uast/m...
Igor Skornyakov
05:39 AM User Interface Bug #2849: implement and/or fix the default popup menus for all widgets
Vadim Gindin wrote:
> I faced with the following problem. Window title popup menu is always shown under title bar fo...
Hynek Cihlar
05:12 AM User Interface Bug #2849: implement and/or fix the default popup menus for all widgets
I faced with the following problem. Window title popup menu is always shown under title bar for @DialogBoxWindow@. I'... Vadim Gindin

03/02/2016

02:29 PM Database Bug #2955: Update records participating in a scrolling adaptive query.
That is how it works in 4GL. Stanislav Lomany
11:22 AM Database Bug #2955: Update records participating in a scrolling adaptive query.
Stanislav Lomany wrote:
> Consider the current record was updated at some level of an adaptive compound query. Then ...
Eric Faulhaber
10:36 AM Database Bug #2955: Update records participating in a scrolling adaptive query.
Guys, please consider the design of the solution for this issue (see previous note):
1. Register compound query as a...
Stanislav Lomany
01:58 PM User Interface Bug #2954: Focus is not put on the expected widget when window activated
Ok, the previous 1811t code have able to detect if the mouse is over the scroll bars but now all events are delivered... Sergey Ivanovskiy
01:33 PM User Interface Bug #2954: Focus is not put on the expected widget when window activated
Sergey Ivanovskiy wrote:
> Yes, it is a regression in 1811t. The complexity here appears due to the GUI classes hier...
Igor Skornyakov
01:30 PM User Interface Bug #2954: Focus is not put on the expected widget when window activated
Yes, it is a regression in 1811t. The complexity here appears due to the GUI classes hierarchy of ScrollPane and Scro... Sergey Ivanovskiy
01:21 PM User Interface Bug #2954: Focus is not put on the expected widget when window activated
Sergey Ivanovskiy wrote:
> Found a regression in @./demo/demo_widgets.p@ (@com.goldencode.testcases.demo.DemoWidgets...
Igor Skornyakov
01:16 PM User Interface Bug #2954: Focus is not put on the expected widget when window activated
Planning to do it. Found a regression in @./demo/demo_widgets.p@ (@com.goldencode.testcases.demo.DemoWidgets.execute@... Sergey Ivanovskiy
12:54 PM User Interface Bug #2954: Focus is not put on the expected widget when window activated
> I think that such kind of errors can be eliminated if names are used instead of numeric constants in p2j.socket.js... Greg Shah
12:41 PM User Interface Bug #2954: Focus is not put on the expected widget when window activated
Committed revision 11050. Now 1811t is safe to use. I think that such kind of errors can be eliminated if names are u... Sergey Ivanovskiy
12:30 PM User Interface Bug #2954: Focus is not put on the expected widget when window activated
Sorry, it is due to messages constants. Sergey Ivanovskiy
12:27 PM User Interface Bug #2954: Focus is not put on the expected widget when window activated
Please, don't update from 1811t. After rebase the web client doesn't work. Investigating the reasons. The swing clien... Sergey Ivanovskiy
11:24 AM User Interface Bug #2954: Focus is not put on the expected widget when window activated
Now 1811t grows from the current trunc. Encountered trivial history conflicts and the WebClientMessageTypes changes r... Sergey Ivanovskiy
09:01 AM User Interface Bug #2954: Focus is not put on the expected widget when window activated
Sergey Ivanovskiy wrote:
> Igor, could you help I found this code in the trunc src/com/goldencode/p2j/ui/client/driv...
Igor Skornyakov
09:00 AM User Interface Bug #2954: Focus is not put on the expected widget when window activated
Igor, could you help I found this code in the trunc src/com/goldencode/p2j/ui/client/driver/web/res/p2j.socket.js (pl... Sergey Ivanovskiy
08:32 AM User Interface Bug #2954: Focus is not put on the expected widget when window activated
Yes, it should be fixed. Greg Shah
08:10 AM User Interface Bug #2954: Focus is not put on the expected widget when window activated
According to this diff from the trunk bzr diff -c10976 > 10976.txt... Sergey Ivanovskiy
08:02 AM User Interface Bug #2954: Focus is not put on the expected widget when window activated
Misspelled history number was found in the current trunc in this module @src/com/goldencode/p2j/ui/client/gui/driver/... Sergey Ivanovskiy
07:01 AM User Interface Bug #2954: Focus is not put on the expected widget when window activated
Planning to rebase 1811t from latest trunk. Sergey Ivanovskiy
01:16 PM Base Language Feature #1612: finish SESSION system handle support
Added @uast/session/data-entry-return.p@ revision 1476. Note 59 has been updated Igor Skornyakov
01:07 PM Base Language Feature #1612: finish SESSION system handle support
Greg Shah wrote:
> I assume you are planning to provide more details than currently posted in note 59?
Of course....
Igor Skornyakov
01:06 PM Base Language Feature #1612: finish SESSION system handle support
> Semantics of the APPL-ALERT-BOXES, DATA-ENTRY-RETURN, DEBUG-ALERT and IMMEDIATE-DISPLAY SESSION attributes.
I as...
Greg Shah
11:50 AM Base Language Feature #1612: finish SESSION system handle support
Tests added to @uast/session@ revision 1475. Igor Skornyakov
11:36 AM Base Language Feature #1612: finish SESSION system handle support
Semantics of the @APPL-ALERT-BOXES@, @DATA-ENTRY-RETURN@, @DEBUG-ALERT@ and @IMMEDIATE-DISPLAY@ @SESSION@ attributes.... Igor Skornyakov
08:33 AM Base Language Feature #1612: finish SESSION system handle support
Yes, no problem. Greg Shah
08:25 AM Base Language Feature #1612: finish SESSION system handle support
Greg Shah wrote:
> Please document (here) the found behavior for each of the attributes.
>
> Also, please split t...
Igor Skornyakov
08:16 AM Base Language Feature #1612: finish SESSION system handle support
Please document (here) the found behavior for each of the attributes.
Also, please split the testcase into separat...
Greg Shah
07:57 AM Base Language Feature #1612: finish SESSION system handle support
Added state variables for the @APPL-ALERT-BOXES@, @DATA-ENTRY-RETURN@, @DEBUG-ALERT@ and @IMMEDIATE-DISPLAY@ @SESSION... Igor Skornyakov
07:13 AM Base Language Feature #1612: finish SESSION system handle support
The value of the @APPL-ALERT-BOXES@ doesn't affect @MESSAGE@ statement with @SET@/@UPDATE@ clause. Igor Skornyakov
03:22 AM Base Language Feature #1612: finish SESSION system handle support
Rebased task branch 1612a from P2J trunk rev 10978. The latest revision is now 10979. Igor Skornyakov
08:41 AM User Interface Bug #2849: implement and/or fix the default popup menus for all widgets
Vadim Gindin wrote:
> What window the method @GuiDriver.selectWindow(int windowId)@ can accept? Can it be @DialogBox...
Hynek Cihlar
08:29 AM User Interface Bug #2849: implement and/or fix the default popup menus for all widgets
What window the method @GuiDriver.selectWindow(int windowId)@ can accept? Can it be @DialogBox@ or only @Window@ id?
...
Vadim Gindin

03/01/2016

06:48 PM Database Bug #2807 (Closed): LDBNAME can work with an unopen buffer
This fix was merged to the P2J trunk in revision 10952. Eric Faulhaber
04:12 PM User Interface Bug #2969 (Closed): websocket keep-alive
Greg Shah
03:42 PM User Interface Bug #2969: websocket keep-alive
It is done in 1811t. Sergey Ivanovskiy
04:11 PM User Interface Bug #2968: disconnect/reconnect and manual reload must re-establish the websocket connection, nee...
> 3 Watchdog timer does the same, System.exit() is used to kill the spawn process in order to be able to create a new... Greg Shah
03:31 PM User Interface Bug #2968: disconnect/reconnect and manual reload must re-establish the websocket connection, nee...
> Code Review Task Branch 1811t Revision 11038
Committed revision 11040, 11041 fixes 1,2,4.
3 Watchdog timer does the...
Sergey Ivanovskiy
10:15 AM User Interface Bug #2968: disconnect/reconnect and manual reload must re-establish the websocket connection, nee...
Greg Shah wrote:
> Code Review Task Branch 1811t Revision 11038
>
> 1. With your fix to resolve the 2 hander issu...
Sergey Ivanovskiy
10:02 AM User Interface Bug #2968: disconnect/reconnect and manual reload must re-establish the websocket connection, nee...
Code Review Task Branch 1811t Revision 11038
1. With your fix to resolve the 2 hander issue, reload should work fo...
Greg Shah
12:56 AM User Interface Bug #2968: disconnect/reconnect and manual reload must re-establish the websocket connection, nee...
Sergey Ivanovskiy wrote:
> Greg Shah wrote:
> > Do NOT implement JS caching. It adds too many potential problems a...
Sergey Ivanovskiy
04:01 PM User Interface Bug #2956: When switching windows with Web GUI task bar the source window is not deactivated
Is there anything left to do on this task? Greg Shah
01:14 PM Base Language Feature #1612: finish SESSION system handle support
Rebased task branch 1612a from P2J trunk rev 10976. The latest revision is now 10977. Igor Skornyakov
07:18 AM Base Language Feature #1612: finish SESSION system handle support
Added conversion support and stub for the @SESSION:IMMEDIATE-DISPLAY@, write support for the @SESSION:DATA-ENTRY-RETU... Igor Skornyakov
06:05 AM Base Language Feature #1612: finish SESSION system handle support
created task branch 1612a Igor Skornyakov
01:05 PM User Interface Feature #2565 (Closed): implement runtime support for the SET-WAIT-STATE method
Greg Shah
01:03 PM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
The task branch 2565a has been archived Igor Skornyakov
12:44 PM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
The task branch 2565a revison 11068 has been merged to the trunk and committed as revision 10976. Igor Skornyakov
12:35 PM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Greg Shah wrote:
> Yes. I think your changes (since the last time CTRL-C testing passed) are safe enough.
OK. ac...
Igor Skornyakov
12:34 PM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Yes. I think your changes (since the last time CTRL-C testing passed) are safe enough. Greg Shah
12:27 PM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Greg Shah wrote:
> Great!
>
> Please merge task branch 2565a revision 11068 to trunk and archive the branch.
W...
Igor Skornyakov
12:26 PM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Great!
Please merge task branch 2565a revision 11068 to trunk and archive the branch.
Greg Shah
12:25 PM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Greg Shah wrote:
> OK, please run it in single mode or manually to see if it will work. The problem is probably not...
Igor Skornyakov
12:16 PM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
OK, please run it in single mode or manually to see if it will work. The problem is probably not due to your changes... Greg Shah
12:14 PM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Greg Shah wrote:
> What is the expected text?...
Igor Skornyakov
12:12 PM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
What is the expected text? Greg Shah
12:11 PM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Greg Shah wrote:
> > > Only @tc_codes_employees_021@
> >
> > Unfortunately this one is not expected to be failed ...
Igor Skornyakov
12:10 PM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
> The regression test restated.
We don't want to do a full regression testing run to see if this will pass. Pleas...
Greg Shah
12:08 PM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Eugenie Lyzenko wrote:
> Igor Skornyakov wrote:
> > Only @tc_codes_employees_021@
>
> Unfortunately this one is ...
Igor Skornyakov
12:08 PM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
> > Only @tc_codes_employees_021@
>
> Unfortunately this one is not expected to be failed - need to get it passed ...
Greg Shah
12:06 PM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Igor Skornyakov wrote:
> Only @tc_codes_employees_021@
Unfortunately this one is not expected to be failed - need...
Eugenie Lyzenko
12:00 PM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Igor Skornyakov wrote:
> BTW: selection on mouse drag for @FILL-IN@ doesn't work neither in trunk nor on 2565a.
Mou...
Constantin Asofiei
11:59 AM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Only @tc_codes_employees_021@ and @tc_job_002@ failed in two runs of the main part. Igor Skornyakov
11:14 AM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Constantin Asofiei wrote:
> Otherwise, I'm still a little worried about @AbstractContainer.findMouseSource@ change: i...
Igor Skornyakov
11:05 AM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Greg Shah wrote:
> Please post the @findMouseSource()@ testing results when you have them.
Gentlemen, I don't mea...
Igor Skornyakov
10:52 AM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Greg Shah wrote:
> Please post the @findMouseSource()@ testing results when you have them.
Sure.
Igor Skornyakov
10:52 AM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Please post the @findMouseSource()@ testing results when you have them. Greg Shah
10:34 AM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Constantin Asofiei wrote:
> Review for 2565a rev 11067:
> # @Boolean ClientExports.setWaitState@ - please review al...
Igor Skornyakov
09:47 AM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Eugenie Lyzenko wrote:
> Igor Skornyakov wrote:
> > All @gso_ctrlc_tests@ passed, all @gso_ctrlc_3way_tests@ failed...
Igor Skornyakov
09:46 AM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Igor Skornyakov wrote:
> All @gso_ctrlc_tests@ passed, all @gso_ctrlc_3way_tests@ failed.
To simplify 3-way tests...
Eugenie Lyzenko
09:40 AM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Constantin Asofiei wrote:
> Review for 2565a rev 11067:
> # @Boolean ClientExports.setWaitState@ - please review al...
Igor Skornyakov
09:37 AM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Review for 2565a rev 11067:
# @Boolean ClientExports.setWaitState@ - please review all usage of this API; if the API...
Constantin Asofiei
09:37 AM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Greg Shah wrote:
> Are you confident that you have not lost any of Eugenie's javadoc changes?
I hope so. There wh...
Igor Skornyakov
09:33 AM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Are you confident that you have not lost any of Eugenie's javadoc changes? Greg Shah
09:32 AM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
All @gso_ctrlc_tests@ passed, all @gso_ctrlc_3way_tests@ failed. Igor Skornyakov
08:23 AM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Greg Shah wrote:
> How is MAJIC regression testing going?
The night run ended with a lot of connection failures a...
Igor Skornyakov
08:17 AM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
How is MAJIC regression testing going? Greg Shah
05:39 AM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Manual Web GUI tests passed OK Igor Skornyakov
04:49 AM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Manual Swing GUI tests passed OK. Igor Skornyakov
01:04 PM User Interface Feature #2566 (Closed): implement LOAD-MOUSE-POINTER method
The implementation is now present in trunk revision 10976 (merged from 2565a). Greg Shah
01:02 PM User Interface Bug #2792: image loading issues
The recently noted issues are resolved by trunk revision 10976 (merged from 2565a). Greg Shah
01:01 PM User Interface Bug #2995 (Closed): if the first mouse after app startup is on a combo-box, then an abend occurs
Resolved by trunk revision 10976 (merged from 2565a). Greg Shah
01:00 PM User Interface Bug #2996 (Closed): Cursor change at the window border
Greg Shah
12:59 PM User Interface Bug #2996: Cursor change at the window border
Resolved by trunk revision 10976 (merged from 2565a). Greg Shah
01:00 PM User Interface Bug #2982 (Closed): in Web client, overlay window must not be "resizeable"
Resolved by trunk revision 10976 (merged from 2565a). Greg Shah
11:45 AM Database Feature #3011: try H2 internal connection pool instead of UnpooledConnectionProvider
I read in the H2 documentation that the H2 internal connection pool should be significantly faster for embedded datab... Eric Faulhaber
11:42 AM Database Feature #3011 (Rejected): try H2 internal connection pool instead of UnpooledConnectionProvider
Eric Faulhaber
11:23 AM Database Feature #3010: retrieve new primary keys from database in batch
It also seems our implementation to get and reclaim primary keys for temp-tables is overly complicated. See @Temporar... Eric Faulhaber
11:10 AM Database Feature #3010: retrieve new primary keys from database in batch
Implementation note: since reclaimed keys are stored individually in the @IdentityPool@, we would need a new API in t... Eric Faulhaber
10:54 AM Database Feature #3010: retrieve new primary keys from database in batch
I've noticed that in some use cases, we are spending a lot of time retrieving new primary keys from the database, usi... Eric Faulhaber
10:39 AM Database Feature #3010 (WIP): retrieve new primary keys from database in batch
Eric Faulhaber
09:49 AM User Interface Bug #2914: Fix errors in window_sizing/test_runner.p
> As this IMHO has small negative impact I would create new issue and deal with this later. Greg, what do you think?
...
Greg Shah
09:27 AM User Interface Bug #2914: Fix errors in window_sizing/test_runner.p
In 4GL window HEIGHT attribute can be assigned to smaller values than the smallest physical window size. So we end up... Hynek Cihlar

02/29/2016

03:52 PM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Fixed javadocs
Committed to the task branch 2565a revno 11067.
Igor Skornyakov
03:27 PM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Rebased task branch 2565a from P2J trunk rev 10975. The latest revision is now 11066.
The only conflicts during re...
Igor Skornyakov
03:01 PM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Greg Shah wrote:
> Before you do this testing, please rebase. It should be the last one before your merge.
>
> A...
Igor Skornyakov
03:00 PM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Before you do this testing, please rebase. It should be the last one before your merge.
Although I'd prefer not t...
Greg Shah
02:50 PM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Greg Shah wrote:
> There has been a substantial amount of change in GUI code since then. I think it is important to...
Igor Skornyakov
02:44 PM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
> > In what revision did your manual testing of the Swing GUI client pass all standalone GUI tests?
>
> It was rev...
Greg Shah
02:28 PM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
As far as I can see FSD tests passed OK after adding the following to the @directory.xml@:... Igor Skornyakov
02:21 PM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Greg Shah wrote:
> In what revision did your manual testing of the Swing GUI client pass all standalone GUI tests?
...
Igor Skornyakov
02:15 PM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
In what revision did your manual testing of the Swing GUI client pass all standalone GUI tests? Greg Shah
01:43 PM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
The issue from the note 285 is fixed.
Committed to the task branch 2565a revno 11063.
What's remained is the ma...
Igor Skornyakov
12:47 PM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
As far as I can see all standard manual GUI tests run identically in 2565a and trunk (WebGUI) with one exception: the... Igor Skornyakov
11:55 AM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Constantin Asofiei wrote:
> Does @IBEAM@ still work in your tests? I was testing @IBEAM@ for a combo-box in @demo-wi...
Igor Skornyakov
11:46 AM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Igor Skornyakov wrote:
> Constantin Asofiei wrote:
> > Please check the @LOAD-MOUSE-POINTER@ for combo-box/button -...
Constantin Asofiei
10:19 AM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Greg Shah wrote:
> Code Review Task Branch 2565a Revision 11059
Fixed. Committed to the task branch 2565a revno 1...
Igor Skornyakov
09:39 AM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Code Review Task Branch 2565a Revision 11059
1. Are you intending to assign @me.currentHovered@ and @me.currentMou...
Greg Shah
08:20 AM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
The issue with mouse drug is fixed.
Committed to the task branch 2565a revno 11059
Only JS code was affected.
...
Igor Skornyakov
02:44 PM User Interface Support #2961: list of differences between the Swing GUI client and the original 4GL Windows GUI ...
5. Window cannot be moved outside of screen bounds in Swing GUI. See #3008. Hynek Cihlar
02:42 PM User Interface Bug #3008: Window in Swing GUI cannot be moved outside of screen bounds
Top-level window in Swing GUI, smaller than screen size, cannot be moved outside of screen bounds. When mouse-draggin... Hynek Cihlar
02:32 PM User Interface Bug #3008 (New): Window in Swing GUI cannot be moved outside of screen bounds
Hynek Cihlar
02:17 PM User Interface Bug #2914: Fix errors in window_sizing/test_runner.p
Greg Shah wrote:
> > When the window fits fully on the screen, calling java.awt.Window.setLocation() doesn't allow t...
Hynek Cihlar
12:18 PM User Interface Bug #2914: Fix errors in window_sizing/test_runner.p
> When the window fits fully on the screen, calling java.awt.Window.setLocation() doesn't allow the window to move ou... Greg Shah
10:11 AM User Interface Bug #2914: Fix errors in window_sizing/test_runner.p
Rebased task branch 2914a against trunk revision 10974. 2914a is now at revision 10988. Hynek Cihlar
02:10 PM Conversion Tools Support #3005 (Closed): OO processing cleanup items
Greg Shah
02:10 PM Conversion Tools Support #3005: OO processing cleanup items
Merged to trunk as revision 10975. Task branch 3005a was archived. Greg Shah
12:09 PM User Interface Bug #2968: disconnect/reconnect and manual reload must re-establish the websocket connection, nee...
Greg Shah wrote:
> Do NOT implement JS caching. It adds too many potential problems and too much complexity.
>
>...
Sergey Ivanovskiy
12:08 PM User Interface Bug #2968: disconnect/reconnect and manual reload must re-establish the websocket connection, nee...
Constantin Asofiei wrote:
> Other questions:
> # What happens if the user hits "refresh page" while the JS side is ...
Sergey Ivanovskiy
11:53 AM User Interface Bug #2968: disconnect/reconnect and manual reload must re-establish the websocket connection, nee...
Do NOT implement JS caching. It adds too many potential problems and too much complexity.
At this point, if it is...
Greg Shah
11:40 AM User Interface Bug #2968: disconnect/reconnect and manual reload must re-establish the websocket connection, nee...
Other questions:
# What happens if the user hits "refresh page" while the JS side is in the middle of processing som...
Constantin Asofiei
11:32 AM User Interface Bug #2968: disconnect/reconnect and manual reload must re-establish the websocket connection, nee...
Sergey Ivanovskiy wrote:
> Constantin Asofiei wrote:
> > We need to consider that all the JS-side data is lost, if th...
Sergey Ivanovskiy
11:29 AM User Interface Bug #2968: disconnect/reconnect and manual reload must re-establish the websocket connection, nee...
Yes, mouse regions, icons, drawings, all required fields for each JS module if we will save the JS client state. Sergey Ivanovskiy
11:25 AM User Interface Bug #2968: disconnect/reconnect and manual reload must re-establish the websocket connection, nee...
Sergey Ivanovskiy wrote:
> I used the @localStorage@ and did't save the icons caches and mouse regions and drawings....
Constantin Asofiei
11:24 AM User Interface Bug #2968: disconnect/reconnect and manual reload must re-establish the websocket connection, nee...
Constantin Asofiei wrote:
> We need to consider that all the JS-side data is lost, if the web page is reloaded. If ...
Sergey Ivanovskiy
11:21 AM User Interface Bug #2968: disconnect/reconnect and manual reload must re-establish the websocket connection, nee...
No, I used to save this state on reload the web page. But I understand it is complex because many fields and variable... Sergey Ivanovskiy
11:17 AM User Interface Bug #2968: disconnect/reconnect and manual reload must re-establish the websocket connection, nee...
Sergey Ivanovskiy wrote:
> It may be more complex task in compare with saving the JS client state. Because I am almo...
Constantin Asofiei
11:16 AM User Interface Bug #2968: disconnect/reconnect and manual reload must re-establish the websocket connection, nee...
Constantin Asofiei wrote:
> Greg Shah wrote:
> > I the issue in note 6 present with the web ChUI too? We had the w...
Sergey Ivanovskiy
11:10 AM User Interface Bug #2968: disconnect/reconnect and manual reload must re-establish the websocket connection, nee...
Sergey Ivanovskiy wrote:
> Constantin, you are not right, because this token is used only once to generate the autho...
Constantin Asofiei
11:08 AM User Interface Bug #2968: disconnect/reconnect and manual reload must re-establish the websocket connection, nee...
Constantin Asofiei wrote:
> Sergey Ivanovskiy wrote:
> > > > Thus the second handler has an uninitialized state tha...
Sergey Ivanovskiy
11:04 AM User Interface Bug #2968: disconnect/reconnect and manual reload must re-establish the websocket connection, nee...
Sergey Ivanovskiy wrote:
> > > Thus the second handler has an uninitialized state that is inconsistent with the curr...
Constantin Asofiei
11:02 AM User Interface Bug #2968: disconnect/reconnect and manual reload must re-establish the websocket connection, nee...
Greg Shah wrote:
> I the issue in note 6 present with the web ChUI too? We had the web ChUI reload case working pro...
Constantin Asofiei
10:53 AM User Interface Bug #2968: disconnect/reconnect and manual reload must re-establish the websocket connection, nee...
I don't like this approach but it is possible to save the current JS client state in the file on the java side and on... Sergey Ivanovskiy
10:37 AM User Interface Bug #2968: disconnect/reconnect and manual reload must re-establish the websocket connection, nee...
Greg Shah wrote:
> > Due to this issue I would like to create a new perspective task to do the web application accor...
Sergey Ivanovskiy
10:18 AM User Interface Bug #2968: disconnect/reconnect and manual reload must re-establish the websocket connection, nee...
> I don't want to implement any kind of caching, local storage or index db. Can we just make the reload work by forc... Sergey Ivanovskiy
09:31 AM User Interface Bug #2968: disconnect/reconnect and manual reload must re-establish the websocket connection, nee...
Fonts are cached separately. Sergey Ivanovskiy
09:30 AM User Interface Bug #2968: disconnect/reconnect and manual reload must re-establish the websocket connection, nee...
Refresh/reopen requires to redraw all windows, to restore embedded fonts and mouse widgets regions. I tried to restor... Sergey Ivanovskiy
09:09 AM User Interface Bug #2968: disconnect/reconnect and manual reload must re-establish the websocket connection, nee...
The web ChUI has the same problem. I don't know how to repeat all window drawings. How can we restore the embedded fo... Sergey Ivanovskiy
09:01 AM User Interface Bug #2968: disconnect/reconnect and manual reload must re-establish the websocket connection, nee...
> Due to this issue I would like to create a new perspective task to do the web application according to a standard w... Greg Shah
08:55 AM User Interface Bug #2968: disconnect/reconnect and manual reload must re-establish the websocket connection, nee...
I don't want to implement any kind of caching, local storage or index db. Can we just make the reload work by forcin... Greg Shah
12:59 AM User Interface Support #2672: GUI web client performance improvements
Some remarks to discuss are
There are differences in the web performance depending on the used strategy to do cachin...
Sergey Ivanovskiy

02/28/2016

03:06 PM User Interface Bug #2968: disconnect/reconnect and manual reload must re-establish the websocket connection, nee...
The picture result is probably due to the current clipping region on the Web java side. It adds a complexity to the t... Sergey Ivanovskiy
02:36 PM User Interface Bug #2968: disconnect/reconnect and manual reload must re-establish the websocket connection, nee...
I encountered the problems to restore the web application if the application web page is reloaded or reopened.
There ...
Sergey Ivanovskiy
08:56 AM User Interface Support #2672: GUI web client performance improvements
Constantin, according to the test @getImageData@ and @putImageData@ are expensive operations. Did you compare the web... Sergey Ivanovskiy

02/27/2016

11:14 AM User Interface Bug #2914: Fix errors in window_sizing/test_runner.p
Hynek Cihlar wrote:
> Hynek Cihlar wrote:
> > Greg Shah wrote:
> > > What is left to do on this task?
> >
> > I...
Hynek Cihlar
11:09 AM User Interface Bug #2914: Fix errors in window_sizing/test_runner.p
Hynek Cihlar wrote:
> Greg Shah wrote:
> > What is left to do on this task?
>
> I also found two new trunk regre...
Hynek Cihlar
09:10 PM User Interface Bug #2914: Fix errors in window_sizing/test_runner.p
I can confirm the window size performance problem exists in Web GUI, too. I was able to reach the max window size of ... Hynek Cihlar
07:51 PM User Interface Bug #2914: Fix errors in window_sizing/test_runner.p
Task branch 2914a revision 10984 passed conversion testing. Hynek Cihlar

02/26/2016

05:52 PM User Interface Bug #2968: disconnect/reconnect and manual reload must re-establish the websocket connection, nee...
Planing to finish this task this weekend due to the tests to restore the document tree with the embedded fonts and th... Sergey Ivanovskiy
11:48 AM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
OK, thanks.
When you have the fix for the GUI issue, we will evaluate if the changes needed will require a new rou...
Greg Shah
11:45 AM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
At the last run only the following regression tests failed:... Igor Skornyakov
09:50 AM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Greg Shah wrote:
> Code Review Task Branch 2565a Revision 11057
>
> In @ChuiWidgetFactory@ please search on the t...
Igor Skornyakov
09:45 AM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Code Review Task Branch 2565a Revision 11057
In @ChuiWidgetFactory@ please search on the text "GUI" and change it ...
Greg Shah
09:42 AM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Greg Shah wrote:
> Code Review Task Branch 2565a Revision 11055
Sorry. Fixed now. I've also removed obsolete meth...
Igor Skornyakov
09:33 AM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
> There is a number of methods in the WidgetFactoryAdapter which just throw new RuntimeException("Not implemented.") ... Greg Shah
09:32 AM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Code Review Task Branch 2565a Revision 11055
The javadoc changes requested in note 268 were not done.
> clean u...
Greg Shah
09:26 AM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
There is a number of methods in the @WidgetFactoryAdapter@ which just throw @new RuntimeException("Not implemented.")... Igor Skornyakov
09:21 AM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Greg Shah wrote:
> Code Review Task Branch 2565a Revision 11054
>
> 1. The GUI-specific additions to @ChuiWidgetF...
Igor Skornyakov
09:16 AM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Greg Shah wrote:
> What issues remain to be fixed from manual testing or automated regression testing?
I have goo...
Igor Skornyakov
09:14 AM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
What issues remain to be fixed from manual testing or automated regression testing? Greg Shah
09:12 AM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Code Review Task Branch 2565a Revision 11054
1. The GUI-specific additions to @ChuiWidgetFactory@ are inappropriat...
Greg Shah
07:59 AM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Fixed a bug revealed by automated regression testeting
Committed to a task branch 2565a revno 11054
Regression te...
Igor Skornyakov
03:50 AM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Fixed a bug revealed by automated regression testeting
Committed to a task branch 2565a revno 11053
Regression te...
Igor Skornyakov
10:59 AM User Interface Bug #2914: Fix errors in window_sizing/test_runner.p
Greg Shah wrote:
> What is left to do on this task?
I also found two new trunk regressions.
* Window cannot be...
Hynek Cihlar
10:56 AM User Interface Bug #2914: Fix errors in window_sizing/test_runner.p
Greg Shah wrote:
> Code Review Task Branch 2914a Revision 10984
>
> 1. Is the @ClientBuilder.localStart()@ change...
Hynek Cihlar
10:38 AM User Interface Bug #2914: Fix errors in window_sizing/test_runner.p
Code Review Task Branch 2914a Revision 10984
1. Is the @ClientBuilder.localStart()@ change (to redirect STDOUT) so...
Greg Shah
10:28 AM User Interface Bug #2914: Fix errors in window_sizing/test_runner.p
Greg Shah wrote:
> I will do a code review shortly.
>
> What is left to do on this task?
There are some unresolved ...
Hynek Cihlar
09:58 AM User Interface Bug #2914: Fix errors in window_sizing/test_runner.p
I will do a code review shortly.
What is left to do on this task?
Have you handled the web client as well?
Greg Shah
09:33 AM User Interface Bug #2914: Fix errors in window_sizing/test_runner.p
I have committed the solution for the large window sizes in Swing, see task branch 2914a revision 10984.
I improve...
Hynek Cihlar
08:56 AM Conversion Tools Feature #2503: improve ConversionDriver.main() to provide back a return code and/or better handle...
I was happy about 7 months ago that the fix in rev 10909 gave me what I needed. It appears there is at least one case... Paul E
07:48 AM Conversion Tools Support #3005: OO processing cleanup items
Conversion regression testing has passed, it causes no changes to the converted output.
Eric: the only possible ru...
Greg Shah
05:38 AM Runtime Infrastructure Feature #3003: improve performance of BaseDataType.deepCopy()
Thanks for the detail, Greg.
I've relooked at the call stack - it appears that the deregister() is being called from...
Guy M

02/25/2016

06:06 PM User Interface Bug #2968: disconnect/reconnect and manual reload must re-establish the websocket connection, nee...
The following problem appears if the application webpage is reloaded or refreshed on F5. We have two WebPageHandlers.... Sergey Ivanovskiy
05:42 PM User Interface Bug #3006: paste operation doesn't work properly
I've noticed the following issue with @ask-gui.p@. If I try to paste a file name into the entry field right after the... Igor Skornyakov
05:40 PM User Interface Bug #3006 (New): paste operation doesn't work properly
Igor Skornyakov
05:16 PM Conversion Tools Support #3005: OO processing cleanup items
Created task branch 3005a from trunk revision 10973.
Hand testing shows the changes work. Checked in to 3005a as ...
Greg Shah
03:35 PM Conversion Tools Support #3005: OO processing cleanup items
Some customer code was found that passed temp-tables as a parameter to OO methods. This is a problem during the firs... Greg Shah
03:28 PM Conversion Tools Support #3005 (Closed): OO processing cleanup items
Greg Shah
04:36 PM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
The results of the regression testing:
1. All ctrl-C tests passed.
2. The following main tests failed in 3 runs...
Igor Skornyakov
06:54 AM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Igor Skornyakov wrote:
> The regression found: the additional window opened in the @./demo/calc-static-chars.p@ is n...
Igor Skornyakov
06:40 AM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Constantin Asofiei wrote:
> Please check the @LOAD-MOUSE-POINTER@ for combo-box/button - is not working anymore, in ...
Igor Skornyakov
06:20 AM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Constantin Asofiei wrote:
> Please check the @LOAD-MOUSE-POINTER@ for combo-box/button - is not working anymore, in ...
Igor Skornyakov
06:20 AM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
The regression found: the additional window opened in the @./demo/calc-static-chars.p@ is not movable/resizable in 25... Igor Skornyakov
06:19 AM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Please check the @LOAD-MOUSE-POINTER@ for combo-box/button - is not working anymore, in rev 11052. Constantin Asofiei
12:55 PM Runtime Infrastructure Feature #3003: improve performance of BaseDataType.deepCopy()
> Since P2J is mimicking Progress, does this not mean that you only need to do a deep copy at block entry when a TRAN... Greg Shah
12:19 PM Runtime Infrastructure Feature #3003: improve performance of BaseDataType.deepCopy()
Hi,
We discussed today whether we should investigate making search API calls non-TRANSACTION - which might make a ...
Guy M

02/24/2016

05:55 PM User Interface Bug #2968: disconnect/reconnect and manual reload must re-establish the websocket connection, nee...
Committed revision 11033, 11034 implemented 1,2,3 except of the usecase "to reload/to close the application web page". Sergey Ivanovskiy
04:08 PM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Greg Shah wrote:
> OK, it looks fine, except for the @ClientExports.loadMousePointer()@ which still has a ptrName ja...
Igor Skornyakov
03:52 PM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
OK, it looks fine, except for the @ClientExports.loadMousePointer()@ which still has a ptrName javadoc parameter.
...
Greg Shah
03:32 PM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Fixed items 14-16 from note 235?
Committed to the task branch 2565a revno 11051,
Igor Skornyakov
02:46 PM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
I'm comparing 2565a with the trunk. This is the only way to see what I messed up. Igor Skornyakov
02:43 PM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Code Review Task Branch 2565a Revision 11050
@ClientExports.loadMousePointer()@ still has a ptrName javadoc parame...
Greg Shah
02:34 PM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Greg Shah wrote:
> Code Review Task Branch 2565a Revision 11047
>
> This is substantially better.
>
> 1. @ThinClien...
Igor Skornyakov
02:18 PM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Code Review Task Branch 2565a Revision 11047
This is substantially better.
1. @ThinClient/ClientExports.loadMou...
Greg Shah
12:47 PM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Greg Shah wrote:
> Code Review Task Branch 2565a Revision 11042
All issues except 14-16 have been addressed.
C...
Igor Skornyakov
09:36 AM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Fixed the issue with @MOUSE_WHEEL@/@MOUSE_DRAGGED@ in the @EDITOR@ (Swing). Many thanks to Constantin for a clue.
...
Igor Skornyakov
07:55 AM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Greg Shah wrote:
> > The idea of the @filename@ field in the @MousePointer@ is to have some place where the name of ...
Igor Skornyakov
07:30 AM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
> The idea of the @filename@ field in the @MousePointer@ is to have some place where the name of the file with cursor... Greg Shah
07:28 AM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
My guess is that the root of the problem is that the @findMouseSource@ method doesn't take into account the type of t... Igor Skornyakov
07:13 AM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Constantin Asofiei wrote:
> I understand what you say here. But in the @SwingMouseHandler$WorkArea.actions@ map the...
Igor Skornyakov
07:11 AM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Greg, I've reworked @MousePonter@/@MousePtrWrapper@ (committed to the task branch 25652 revno 11045).
I've also remo...
Igor Skornyakov
07:09 AM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Igor Skornyakov wrote:
> > Beside this, for widgets which don't have a custom cursor, we don't need to register a @M...
Constantin Asofiei
05:47 AM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Constantin Asofiei wrote:
> The @MouseHoverAction@ in case of a drop-down is registered with a @ScrollPaneGuiImpl@, ...
Igor Skornyakov
05:36 AM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
The @MouseHoverAction@ in case of a drop-down is registered with a @ScrollPaneGuiImpl@, as we need a widget with an I... Constantin Asofiei
04:08 AM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Constantin Asofiei wrote:
> The changes in this diff solve the EDITOR problem in 2565a:
> [...]
Thank you Constant...
Igor Skornyakov
04:03 AM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
The changes in this diff solve the EDITOR problem in 2565a:... Constantin Asofiei
03:58 AM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Constantin Asofiei wrote:
> Igor Skornyakov wrote:
> > With SwingGUI I've noticed only one difference while running...
Igor Skornyakov
03:49 AM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Igor Skornyakov wrote:
> With SwingGUI I've noticed only one difference while running tests mentioned in the note 22...
Constantin Asofiei
03:39 AM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Igor Skornyakov wrote:
>
> Thank you Eugenie. Unfortunately the approaches you described seem to be not completely...
Eugenie Lyzenko
03:28 AM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Eugenie Lyzenko wrote:
> >I'm a little confused. The method mouseWheelMoved exist both in MouseWheelListener (invoke...
Igor Skornyakov
09:38 PM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
>I'm a little confused. The method mouseWheelMoved exist both in MouseWheelListener (invoked from the MouseHandler.ap... Eugenie Lyzenko
07:20 PM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Code Review Task Branch 2565a Revision 11042
1. As mentioned previously, the UI system is designed as a series of ...
Greg Shah
02:14 PM Runtime Infrastructure Feature #3003: improve performance of BaseDataType.deepCopy()
The @BaseDataType.deepCopy@ method stands out in JVM profiling/sampling.
It is invoked for every in-scope, undo-ab...
Eric Faulhaber
02:06 PM Runtime Infrastructure Feature #3003 (New): improve performance of BaseDataType.deepCopy()
Eric Faulhaber
01:57 PM Bug #3002: static code analysis issues
Paul wrote:
> Lots of switch statement fall throughs.
Ovidiu just fixed an issue with switch statement fall through...
Eric Faulhaber
01:29 PM Bug #3002: static code analysis issues
Thank you for running this and posting some results. We do intend to run some form of this in the future, but have n... Greg Shah
12:56 PM Bug #3002: static code analysis issues
I've also ran Google's errorprone against P2J and the converted code: nothing interesting to report from this (very f... Paul E
11:21 AM Bug #3002: static code analysis issues
Some further analysis with findbugs indicates a few more potentially noteworthy problems:... Paul E
10:06 AM Bug #3002: static code analysis issues
I've been looking at doing some static analysis as one way of trying to identify potential performance problems.
Whi...
Paul E
10:04 AM Bug #3002 (Closed): static code analysis issues
Paul E
10:44 AM Database Bug #2955: Update records participating in a scrolling adaptive query.
Consider the current record was updated at some level of an adaptive compound query. Then a query at more granular le... Stanislav Lomany
08:44 AM User Interface Bug #2914: Fix errors in window_sizing/test_runner.p
Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > Another solution I see would be to avoid double-buffering from ...
Hynek Cihlar
08:14 AM User Interface Bug #2914: Fix errors in window_sizing/test_runner.p
Greg Shah wrote:
> > I can make the limit configurable and make the app logic report the assigned (and possibly larg...
Hynek Cihlar
07:40 AM User Interface Bug #2914: Fix errors in window_sizing/test_runner.p
Hynek Cihlar wrote:
> Another solution I see would be to avoid double-buffering from a certain (configurable) window...
Constantin Asofiei
07:37 AM User Interface Bug #2914: Fix errors in window_sizing/test_runner.p
> I can make the limit configurable and make the app logic report the assigned (and possibly larger size) as you sugg... Greg Shah
03:26 AM User Interface Feature #2967: web socket message sizes are limited to 32K, make sure that drawing ops and images...
Actually, the PASTE in GUI 4GL doesn't invoke triggers at all, regardless of the widget. We need a generic approach ... Constantin Asofiei
03:00 AM User Interface Feature #2967: web socket message sizes are limited to 32K, make sure that drawing ops and images...
Sergey Ivanovskiy wrote:
> I don't know it will be correct if the triggers on the inserted text will be invoked befo...
Constantin Asofiei
12:55 AM User Interface Feature #2967: web socket message sizes are limited to 32K, make sure that drawing ops and images...
Constantin Asofiei wrote:
> For editor, we need to consider if pasting text into it may or may not result in invoking...
Sergey Ivanovskiy

02/23/2016

04:58 PM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
I'm a little confused. The method @mouseWheelMoved@ exist both in @MouseWheelListener@ (invoked from the @MouseHandle... Igor Skornyakov
01:18 PM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Constantin Asofiei wrote:
> Igor Skornyakov wrote:
> > With SwingGUI I've noticed only one difference while running...
Igor Skornyakov
01:17 PM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Igor Skornyakov wrote:
> With SwingGUI I've noticed only one difference while running tests mentioned in the note 22...
Constantin Asofiei
01:16 PM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
With SwingGUI I've noticed only one difference while running tests mentioned in the note 222:
@/demo/demo_widgets.p@...
Igor Skornyakov
11:45 AM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
> According to the Firebug profiler setting a custom cursor (from the file) take 7+ times less time than e.g. @foundM... Greg Shah
04:44 AM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
According to the Firebug profiler setting a custom cursor (from the file) take 7+ times less time than e.g. @foundMou... Igor Skornyakov
01:13 PM User Interface Feature #2967: web socket message sizes are limited to 32K, make sure that drawing ops and images...
Constantin Asofiei wrote:
> > for editor, let the driver parse the text and split it into lines. This way there will...
Constantin Asofiei
01:11 PM User Interface Feature #2967: web socket message sizes are limited to 32K, make sure that drawing ops and images...
Sergey Ivanovskiy wrote:
> We need to block the JS client mouse listeners if the text processing is not finished
I...
Constantin Asofiei
12:04 PM User Interface Feature #2967: web socket message sizes are limited to 32K, make sure that drawing ops and images...
> Code Review Task Branch 1811t Revision 11029
>
> 1. I prefer not to create the temp dir for every client. This su...
Sergey Ivanovskiy
10:17 AM User Interface Feature #2967: web socket message sizes are limited to 32K, make sure that drawing ops and images...
The same thread issue can be reproduced for @./demo/movie-ratings-dynamic.p com.goldencode.testcases.demo.MovieRating... Sergey Ivanovskiy
09:07 AM User Interface Feature #2967: web socket message sizes are limited to 32K, make sure that drawing ops and images...
This thread issue can be observed in the case if the pasted text has no more than hundreds lines and @WebClientProtoc... Sergey Ivanovskiy
08:01 AM User Interface Feature #2967: web socket message sizes are limited to 32K, make sure that drawing ops and images...
Sergey Ivanovskiy wrote:
> I encountered the thread lock in the case of the large paste data in the editor, the main...
Sergey Ivanovskiy
01:53 AM User Interface Feature #2967: web socket message sizes are limited to 32K, make sure that drawing ops and images...
#33 has been deleted due to the fact @MSG_PASTE@ is handled by @GuiWebSocket@ like it has been described.
LE: GES pu...
Sergey Ivanovskiy
12:34 PM User Interface Bug #2914: Fix errors in window_sizing/test_runner.p
Greg Shah wrote:
> Yikes!
>
> I think we need to put some basic protections into place as a default. The custome...
Hynek Cihlar
10:19 AM User Interface Bug #2914: Fix errors in window_sizing/test_runner.p
Yikes!
I think we need to put some basic protections into place as a default. The customer should be able to over...
Greg Shah
11:44 AM User Interface Support #2672: GUI web client performance improvements
Custom cursor support in JS is currently implemented without any caching of the resulting prepared cursor. In other ... Greg Shah

02/22/2016

05:17 PM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
@SET-WAIT-STATE@ re-worked
Committed to the task branch 2565a revno 11042.
The only remaining issue is optimize...
Igor Skornyakov
02:07 PM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Greg Shah wrote:
> Eugenie: don't we have non-gui testcases for FSD in @testcases/uast/@ already?
Honestly I do not...
Eugenie Lyzenko
01:55 PM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Yes, we would want to have automated tests for this. My only concern is the time it would take to create these. I d... Greg Shah
12:06 PM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
>Thank you Eugenie. Please note however that FileSystemDaemon is a collection of non-UI utility classes with well-def... Eugenie Lyzenko
10:39 AM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Eugenie Lyzenko wrote:
> Greg Shah wrote:
> >
> > Eugenie: Please make a list of the important testcases to run f...
Igor Skornyakov
10:17 AM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Greg Shah wrote:
> This is the standard test list:
Thank you Greg. This looks not that much as I anticipated.
Igor Skornyakov
10:16 AM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
This is the standard test list:
./ask-gui.p
./hello.p
./demo/calc.p
./demo/calc-static.p
./demo/calc-static-ch...
Greg Shah
10:01 AM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Greg Shah wrote:
> Your changes are extensive and even without these specific changes, you will have to run all of t...
Igor Skornyakov
09:54 AM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
> Greg, this code is in the GuiWebDriver so it affects Web GUI only. I do not think that it is feasible to run all GU... Greg Shah
09:52 AM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Greg Shah wrote:
>
> Eugenie: Please make a list of the important testcases to run for testing of this area.
1....
Eugenie Lyzenko
09:44 AM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Greg Shah wrote:
> Pretty soon, you will be ready for regression testing. Since you have changed code that affects ...
Igor Skornyakov
09:10 AM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Igor Skornyakov wrote:
> Greg Shah wrote:
> > Code Review Task Branch 2565a Revision 11031
> >
> > This is part ...
Greg Shah
09:04 AM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
> Anyway - you will need to run testcases(at least all known at this time for the area the FileSytemDaemon is involve... Greg Shah
08:27 AM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Re-worked custom cursor load from a file. Added server-side load.
Committed to the task branch 2565a revno 11041
Igor Skornyakov
03:42 PM User Interface Feature #2967: web socket message sizes are limited to 32K, make sure that drawing ops and images...
I encountered the thread lock in the case of the large paste data in the editor, the main thread and the web task thr... Sergey Ivanovskiy
01:52 PM User Interface Feature #2967: web socket message sizes are limited to 32K, make sure that drawing ops and images...
> please approve that we only need to support MSG_PASTE. In this case we aren't required to save partial messages and... Greg Shah
01:29 PM User Interface Feature #2967: web socket message sizes are limited to 32K, make sure that drawing ops and images...
I found the positive usage of the fast timer. It looks that the JS client reacts more rapidly if the setTimeout is re... Sergey Ivanovskiy
01:27 PM User Interface Feature #2967: web socket message sizes are limited to 32K, make sure that drawing ops and images...
Greg, please approve that we only need to support MSG_PASTE. In this case we aren't required to save partial messages... Sergey Ivanovskiy
10:11 AM User Interface Feature #2967: web socket message sizes are limited to 32K, make sure that drawing ops and images...
Code Review Task Branch 1811t Revision 11029
1. I prefer not to create the temp dir for every client. This suppor...
Greg Shah
09:40 AM User Interface Feature #2967: web socket message sizes are limited to 32K, make sure that drawing ops and images...
I'm reviewing the code now. However, I don't want to support the file upload at this time. As mentioned in note 22,... Greg Shah
04:52 AM User Interface Feature #2967: web socket message sizes are limited to 32K, make sure that drawing ops and images...
Committed revision 11029 takes into account that a file size can be larger than the JVM heap size and fixes the close... Sergey Ivanovskiy
11:57 AM User Interface Bug #2968: disconnect/reconnect and manual reload must re-establish the websocket connection, nee...
The watch dog timeout is given by this directory configuration path "webClient/watchdogTimeout@value" with the defaul... Sergey Ivanovskiy
11:47 AM User Interface Bug #2914: Fix errors in window_sizing/test_runner.p
Greg Shah wrote:
> > Also, with the default client Java heap setup, there are out of memory exceptions when attempti...
Hynek Cihlar
08:40 AM User Interface Bug #2914: Fix errors in window_sizing/test_runner.p
> Also, with the default client Java heap setup, there are out of memory exceptions when attempting to resize the win... Greg Shah
10:22 AM User Interface Bug #2925: EDITOR widget is invisible in presence of the BROWSE one.
In addition. When I run the converted attached test (w/o @BROWSE@) then all drop-down lists at the top of the window ... Igor Skornyakov
08:49 AM User Interface Bug #2787: implement mnemonics/accelerator key support for button
That still sounds like we can have common code and just differentiate the use cases with a flag. Greg Shah
07:40 AM User Interface Bug #2787: implement mnemonics/accelerator key support for button
Yes, buttons use the same algorithm, but I've found a small difference: button labels do not use first character of a... Vadim Gindin
07:11 AM User Interface Bug #2849: implement and/or fix the default popup menus for all widgets
Vadim I believe the problem with the popup offset is in @TopLevelWindow.initEditorPopup()@. The mouse event point is ... Hynek Cihlar
05:49 AM User Interface Bug #2849: implement and/or fix the default popup menus for all widgets
Hynek, sorry. I forgot to commit my current changes to 2849a. That also means that the reason could be in some of my ... Vadim Gindin
03:45 AM User Interface Bug #2849: implement and/or fix the default popup menus for all widgets
Vadim Gindin wrote:
> Hynek Cihlar wrote:
> > ..
> > I did a quick test, created a simple frame in a regular windo...
Hynek Cihlar
02:48 AM User Interface Bug #2849: implement and/or fix the default popup menus for all widgets
Hynek Cihlar wrote:
> ..
> I did a quick test, created a simple frame in a regular window and in a DIALOG-BOX. Clic...
Vadim Gindin

02/20/2016

02:26 PM User Interface Bug #2914: Fix errors in window_sizing/test_runner.p
There is a technical limit of the max window size in Swing GUI driver. The screen buffer implemented by @BufferedImag... Hynek Cihlar
07:13 PM User Interface Bug #2914: Fix errors in window_sizing/test_runner.p
Thanks for the inputs. I have reverted my changes except of the fix of Case 1 and applied Constantin's changes. The r... Hynek Cihlar
01:18 PM User Interface Feature #2967: web socket message sizes are limited to 32K, make sure that drawing ops and images...
Greg, please review the committed revision 11027. Sergey Ivanovskiy
04:52 AM User Interface Bug #2849: implement and/or fix the default popup menus for all widgets
Vadim Gindin wrote:
> I'm trying to fix the following bug:
> When I open popup menu in EDITOR in a standard WINDOW ...
Hynek Cihlar
08:53 PM User Interface Bug #2849: implement and/or fix the default popup menus for all widgets
>Eugenie, does it ring a bell?
?
>If I remember correctly you were solving some mouse-click offset issues when impl...
Eugenie Lyzenko
07:32 PM User Interface Bug #2849: implement and/or fix the default popup menus for all widgets
Vadim Gindin wrote:
> I'm trying to fix the following bug:
> When I open popup menu in EDITOR in a standard WINDOW ...
Hynek Cihlar

02/19/2016

04:57 PM User Interface Bug #2914: Fix errors in window_sizing/test_runner.p
For the third case, the @chp_wrapper=decimal@ annotation is emitted at the COLON node:... Constantin Asofiei
04:48 PM User Interface Bug #2914: Fix errors in window_sizing/test_runner.p
From previous note, changing the code to:... Constantin Asofiei
04:37 PM User Interface Bug #2914: Fix errors in window_sizing/test_runner.p
Hynek, the first case looks like an incorrect wrapping; the AST for the right-side value has a @no_wrap=true@ annotat... Constantin Asofiei
01:36 PM User Interface Bug #2914: Fix errors in window_sizing/test_runner.p
Code Review Task Branch 2914a Revision 10974
The @literals.rules@ change is fine.
The @functions_procedures.rul...
Greg Shah
09:12 AM User Interface Bug #2914: Fix errors in window_sizing/test_runner.p
I have found three conversion errors related to type conversion.
Case 1:...
Hynek Cihlar
07:37 AM User Interface Bug #2914: Fix errors in window_sizing/test_runner.p
Rebased task branch 2914a against trunk revision 10972. 2914a is now at revision 10974. Hynek Cihlar
04:14 PM User Interface Bug #2997: Add support for pre-defined cursor types which do not have direct counterparts in AWT/JS
Please find image captures of Progress pre-defined cursors which do not have AWT counterparts attached. Igor Skornyakov
03:57 PM User Interface Bug #2997: Add support for pre-defined cursor types which do not have direct counterparts in AWT/JS
Greg Shah wrote:
> http://www.trickyways.com/2014/03/capture-mouse-cursor-screenshot-windows/
> http://windows.micr...
Igor Skornyakov
03:54 PM User Interface Bug #2997: Add support for pre-defined cursor types which do not have direct counterparts in AWT/JS
http://www.trickyways.com/2014/03/capture-mouse-cursor-screenshot-windows/
http://windows.microsoft.com/en-us/window...
Greg Shah
03:48 PM User Interface Bug #2997: Add support for pre-defined cursor types which do not have direct counterparts in AWT/JS
Greg Shah wrote:
> Please post image captures of the "no counterpart" cursors. These will be for reference purposes...
Igor Skornyakov
07:51 AM User Interface Bug #2997: Add support for pre-defined cursor types which do not have direct counterparts in AWT/JS
To be clear, when we create these images, we must do so "from scratch". We cannot just make a copy of the bits used ... Greg Shah
07:51 AM User Interface Bug #2997: Add support for pre-defined cursor types which do not have direct counterparts in AWT/JS
Please post image captures of the "no counterpart" cursors. These will be for reference purposes only, we will not c... Greg Shah
03:54 AM User Interface Bug #2997: Add support for pre-defined cursor types which do not have direct counterparts in AWT/JS
At this moment there are a few mouse cursors which are standard for Progress but do not have direct counterparts in A... Igor Skornyakov
03:51 AM User Interface Bug #2997 (New): Add support for pre-defined cursor types which do not have direct counterparts i...
Igor Skornyakov
03:29 PM User Interface Bug #2849: implement and/or fix the default popup menus for all widgets
I'm trying to fix the following bug:
When I open popup menu in EDITOR in a standard WINDOW it is shown at the point ...
Vadim Gindin
05:08 AM User Interface Bug #2849: implement and/or fix the default popup menus for all widgets
Vadim Gindin wrote:
> Hynek Cihlar wrote:
> > ..
> > Yes we attempt not to put driver-specific code into common code,...
Hynek Cihlar
04:39 AM User Interface Bug #2849: implement and/or fix the default popup menus for all widgets
Hynek Cihlar wrote:
> ..
> Yes we attempt not to put driver-specific code into common code, but there are exception...
Vadim Gindin
01:10 PM User Interface Support #2672: GUI web client performance improvements
Constantin Asofiei wrote:
> 2. fixed AbstractWidget.clipRectangle (the bottom/right coordinates were computed incorr...
Constantin Asofiei
01:09 PM User Interface Support #2672: GUI web client performance improvements
1811t rev 11026 fixes:
# the window icon - we must not cache image widgets, as they are not rectangular and can be t...
Constantin Asofiei
10:55 AM User Interface Support #2672: GUI web client performance improvements
Sergey Ivanovskiy wrote:
> Ok, we can create a task to fix artifacts that appear in the case of popup-menu with the ...
Constantin Asofiei
10:54 AM User Interface Support #2672: GUI web client performance improvements
Ok, we can create a task to fix artifacts that appear in the case of popup-menu with the most simple 4GL test case pr... Sergey Ivanovskiy
10:40 AM User Interface Support #2672: GUI web client performance improvements
Sergey, I've seen this only in a scenario for test 454 and also when the window popup-menu is shown then cleared (any... Constantin Asofiei
10:07 AM User Interface Support #2672: GUI web client performance improvements
Another argument can be if we test our system against @hello.p@, then are these artifacts present? Sergey Ivanovskiy
09:57 AM User Interface Support #2672: GUI web client performance improvements
In Chrome I found this issue if we get @var image = ctx.getImageData(0.5,0.5, 10, 1)@, then the returned image dimens... Sergey Ivanovskiy
09:51 AM User Interface Support #2672: GUI web client performance improvements
If you removed the @translate(0.5, 0.5)@ call, then some artifacts disappeared, didn't they? Now I have no ideas beca... Sergey Ivanovskiy
09:43 AM User Interface Support #2672: GUI web client performance improvements
I increased the sizes of regions to watch the picture and the second red squared rectangle is antialiased. It has smo... Sergey Ivanovskiy
09:29 AM User Interface Support #2672: GUI web client performance improvements
Constantin, please could you explain it more thoroughly.
The first script should intersect this rectangle(0, 0, 8, 8...
Sergey Ivanovskiy
08:58 AM User Interface Support #2672: GUI web client performance improvements
Constantin Asofiei wrote:
> 3. an existing issue in trunk: in Web client for test 454, after navigating through the ...
Constantin Asofiei
08:13 AM User Interface Support #2672: GUI web client performance improvements
About the editing and showing data on the editor/fill-in:
# for editor, let the driver parse the text and split it i...
Constantin Asofiei
12:52 AM User Interface Support #2672: GUI web client performance improvements
> Greg Shah wrote:
> > It got me thinking. When the user is editing text in a fill-in or editor (or a browse cell/s...
Sergey Ivanovskiy
12:54 PM User Interface Bug #2968: disconnect/reconnect and manual reload must re-establish the websocket connection, nee...
> 1) Disconnect/reconnect usecase
> Greg, please could you explain disconnect/reconnect? Does it mean the main conne...
Greg Shah
12:37 PM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
@MouseEvent.MOUSE_MOVED@ is restored in @ScrollPaneGuiImpl.mouseActions@.
Committed to the task branch 2565a revno...
Igor Skornyakov
11:12 AM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Constantin Asofiei wrote:
> About 2565a rev 11035:
> # @ClientExports.setMousePointer@ - the javadoc is missing the...
Igor Skornyakov
09:59 AM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
More fixes according to the code review part 2:
>20. Why did you make the EditorGuiImpl.setEnabled() and FillInGui...
Igor Skornyakov
09:55 AM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Eugenie Lyzenko wrote:
> I think adding the informative comments will significantly help to review such code, just t...
Igor Skornyakov
09:51 AM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
>I'm sorry that you find the new version of the code less readable but you understand that this is mostly a matter of... Eugenie Lyzenko
07:14 AM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
About 2565a rev 11035:
# @ClientExports.setMousePointer@ - the javadoc is missing the parameter name for @ptr@.
# @...
Constantin Asofiei
06:47 AM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
More fixes according to the code review part 2:
>11. UiUtils.lookup4GLWidgetId() could have been done with less code....
Igor Skornyakov
06:08 AM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Constantin Asofiei wrote:
> Igor, in rev 11035 ThinClient.trigger returns if wait-state is on. But this code in 4GL...
Igor Skornyakov
05:55 AM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Constantin Asofiei wrote:
> Igor, in rev 11035 ThinClient.trigger returns if wait-state is on. But this code in 4GL...
Igor Skornyakov
05:50 AM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Igor, in rev 11035 ThinClient.trigger returns if wait-state is on. But this code in 4GL proves that triggers are exe... Constantin Asofiei
03:45 AM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Eugenie Lyzenko wrote:
> >Eugenie: Please review the FileSytemDaemon changes in 2565a.
>
> Well, the code was sig...
Igor Skornyakov
07:24 PM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
>Eugenie: Please review the FileSytemDaemon changes in 2565a.
Well, the code was significantly rewritten from the ...
Eugenie Lyzenko
11:55 AM User Interface Feature #3000: implement the SLIDER widget in ChUI
The GUI slider already is complete. This task is to add the proper ChUI support using as much common code as possible. Greg Shah
11:55 AM User Interface Feature #3000 (New): implement the SLIDER widget in ChUI
Greg Shah
11:54 AM User Interface Bug #2787: implement mnemonics/accelerator key support for button
> # How is the alert-box relates to mnemonics?
Did you read #2775-8 as mentioned above?
It has this comment:
...
Greg Shah
11:47 AM User Interface Feature #2967: web socket message sizes are limited to 32K, make sure that drawing ops and images...
I'm OK with this proposed approach. Make sure you write your own from-scratch version of the faster timeouts approach. Greg Shah
09:16 AM Runtime Infrastructure Support #2998 (New): consider whether we should implement a separate security context for init/te...
Greg Shah

02/18/2016

05:54 PM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Greg Shah wrote:
> Code Review Task Branch 2565a Revision 11031
>
> This is part 2 of the code review.
> 42. You...
Igor Skornyakov
05:09 PM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Fixed the following issues from the code review part 2: 17-19, 47, 53.
Committed to the task branch 2565a revno 11...
Igor Skornyakov
04:08 PM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
> Regarding 47: There is no 'implements' keyword in the MouseHoverAction.
I should have written @extends@.
Greg Shah
04:04 PM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Greg Shah wrote:
> As I noted in items 17 and 18 of my code review, we are going to use @window.btoa()@ for our enco...
Igor Skornyakov
04:04 PM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Sergey Ivanovskiy wrote:
> I don't know, but the reason can be found if we answer this question what css engine can ...
Igor Skornyakov
04:03 PM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
As I noted in items 17 and 18 of my code review, we are going to use @window.btoa()@ for our encoding. Please remove ... Greg Shah
04:01 PM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
I don't know, but the reason can be found if we answer this question what css engine can do with @this.canvas.style.c... Sergey Ivanovskiy
03:51 PM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Sergey Ivanovskiy wrote:
> Igor, please could you consider the second method due to the optimization. I am worried a...
Igor Skornyakov
03:46 PM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Igor, please could you consider the second method due to the optimization. I am worried about the large string that w... Sergey Ivanovskiy
03:43 PM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Fixed the following issues from the code review part 2: 1-7, 10, 12-16, 21-35, 37, 39-41, 45,46, 48-52, 54, 55.
Rega...
Igor Skornyakov
03:40 PM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Let us consider two methods to set a custom cursor:
1) The first we use now...
Sergey Ivanovskiy
03:13 PM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
It is okay, I only want to select the best, it should be your solution. Sergey Ivanovskiy
03:12 PM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Sergey Ivanovskiy wrote:
> If we consider @p2j.socket.js@, then we can find two methods to transform to base64 encod...
Igor Skornyakov
03:06 PM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
If we consider @p2j.socket.js@, then we can find two methods to transform to base64 encoding. The first method is imp... Sergey Ivanovskiy
02:51 PM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Sergey Ivanovskiy wrote:
> Igor, there are lot of changes, do you know that in the current 2565a the following funct...
Igor Skornyakov
02:43 PM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Igor, there are lot of changes, do you know that in the current 2565a the following function @Window.prototype.isPare... Sergey Ivanovskiy
02:21 PM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
> But in fact @GenericWidget.loadLousePointer@ does exactly what you describe (and no more).
You are processing on...
Greg Shah
02:10 PM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
> I've added the block of triggers as @SET-WAIT-STATE@ causes deactivation of the active drop-down. I had a trigger o... Greg Shah
12:50 PM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Sergey: Please review the web client changes in 2565a.
Constantin: Please review the mouse processing changes in 2...
Greg Shah
12:49 PM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Code Review Task Branch 2565a Revision 11031
This is part 2 of the code review.
1. You have put GUI-specific co...
Greg Shah
11:49 AM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Greg Shah wrote:
> Code Review Task Branch 2565a Revision 11026
> 8. I am still finding a significant number of cod...
Igor Skornyakov
10:48 AM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Greg Shah wrote:
> 1. The cursor loading and processing should be as hidden as is possible on the client side. Yet ...
Igor Skornyakov
10:35 AM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
I've added the block of triggers as @SET-WAIT-STATE@ causes deactivation of the active drop-down. I had a trigger on ... Igor Skornyakov
10:23 AM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Greg Shah wrote:
> >> 4. Please explain the logic behind duplicating the mousePointer member in so many of the *Conf...
Igor Skornyakov
10:13 AM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
>> 4. Please explain the logic behind duplicating the mousePointer member in so many of the *Config classes (and thus... Greg Shah
10:08 AM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
You're right that some changes have been made. But I am concerned about the core approach. There are comments that ... Greg Shah
10:03 AM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Committed to the task branch 2565a revno 11031 Igor Skornyakov
10:00 AM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Greg Shah wrote:
> Code Review Task Branch 2565a Revision 11026
> 4. Please explain the logic behind duplicating th...
Igor Skornyakov
09:01 AM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Greg Shah wrote:
> 1. Most issues in note 121 (a code review) above have not been resolved. Items 1, 2 and 5 all ...
Igor Skornyakov
08:25 AM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Thank you Greg,
I'm working on your comments right now.
Igor Skornyakov
07:41 AM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Code Review Task Branch 2565a Revision 11026
This is part 1 of my code review. I want you to fix these things ver...
Greg Shah
06:41 AM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Re-tested after rebase. Added custom mouse pointer support for the @SLIDER@ widget.
Committed to the task branch 2...
Igor Skornyakov
05:37 AM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Rebased task branch 2565a from P2J trunk rev 10972. The latest revision is now 11028. Igor Skornyakov
12:28 PM User Interface Bug #2849: implement and/or fix the default popup menus for all widgets
Vadim Gindin wrote:
> Does anybody know why in common class @TopLevelWindow@ the following GUI-specific statement is...
Hynek Cihlar
12:18 PM User Interface Bug #2849: implement and/or fix the default popup menus for all widgets
Does anybody know why in common class @TopLevelWindow@ the following GUI-specific statement is used: @GuiDriver gd = ... Vadim Gindin
06:25 AM User Interface Support #2672: GUI web client performance improvements
It should improve drawings of lines(horizontal and vertical) having 1 pixel width and lines having 2 or more pixels w... Sergey Ivanovskiy
11:56 PM User Interface Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
Branch @2612b@ was merged to trunk as revno @10972@ then it was archived. Eugenie Lyzenko
11:46 PM User Interface Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
The results are in @2612b_10987_2791e7a_20160217_evl.zip@. Eugenie Lyzenko
11:42 PM User Interface Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
Greg Shah wrote:
> If CTRL-C testing passes, please go ahead and merge 2612b to trunk.
OK. The testing completed,...
Eugenie Lyzenko
10:36 PM User Interface Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
If CTRL-C testing passes, please go ahead and merge 2612b to trunk. Greg Shah
10:21 PM User Interface Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
The main part completed without regressions. Running @CTRL-C@ one. Eugenie Lyzenko

02/17/2016

05:44 PM User Interface Support #2672: GUI web client performance improvements
Very cool results! Great job!
I've taken a quick look. Please add the comments I requested in note 30. Then I w...
Greg Shah
04:43 PM User Interface Support #2672: GUI web client performance improvements
Sergey Ivanovskiy wrote:
> Greg, let me try with the 11021 design taking into account the tests result about the pix...
Sergey Ivanovskiy
04:11 PM User Interface Support #2672: GUI web client performance improvements
Greg, let me try with the 11021 design taking into account the tests result about the pixels operations. Sergey Ivanovskiy
04:03 PM User Interface Support #2672: GUI web client performance improvements
Greg, I change some method and gives improvement
look at this instead of get we can use create in some cases for Wid...
Sergey Ivanovskiy
03:49 PM User Interface Support #2672: GUI web client performance improvements
Committed revision 11023 removes 11020 and 11021 changes. Sergey Ivanovskiy
03:31 PM User Interface Support #2672: GUI web client performance improvements
> Greg, Do you agree if I will roll back 11021 changes according to this test?
Yes, roll it back. Even for the @...
Greg Shah
02:51 PM User Interface Support #2672: GUI web client performance improvements
Greg, Do you agree if I will roll back 11021 changes according to this test? Sergey Ivanovskiy
02:48 PM User Interface Support #2672: GUI web client performance improvements
I did this simple test to draw 160 vertical lines of 400 pixel width
for @DefaultPathRenderer@ with the default st...
Sergey Ivanovskiy
01:34 PM User Interface Support #2672: GUI web client performance improvements
>> I am planing to check it with script test and will provide the JS test and its result here. Depending on the resul... Greg Shah
11:50 AM User Interface Support #2672: GUI web client performance improvements
Also it is my fault that I don't check the performance for these two cases:
1) draw vertical|horizontal line by pixe...
Sergey Ivanovskiy
11:43 AM User Interface Support #2672: GUI web client performance improvements
Before 11021 changes these primitives: drawRect, drawRoundRect, draw3DRect draws the stroked lines only if the curren... Sergey Ivanovskiy
11:02 AM User Interface Support #2672: GUI web client performance improvements
Constantin, I found the performance issue with @./demo/movie-ratings-dynamic.p@ (@com.goldencode.testcases.demo.Movie... Sergey Ivanovskiy
08:11 AM User Interface Support #2672: GUI web client performance improvements
Constantin Asofiei wrote:
> Sergey Ivanovskiy wrote:
> > The image background issue is ...
> Thanks for pointing t...
Constantin Asofiei
01:45 AM User Interface Support #2672: GUI web client performance improvements
I would like to notice the main problem related to the Web client performance is synchronous requests from the Java s... Sergey Ivanovskiy
12:49 AM User Interface Support #2672: GUI web client performance improvements
I think that @getImageData@ is also an expensive operation. Sergey Ivanovskiy
12:43 AM User Interface Support #2672: GUI web client performance improvements
It looks that the new caching introduced by 11022 is more slower than the previous version 11021.
The reported times...
Sergey Ivanovskiy
05:18 PM User Interface Bug #2996: Cursor change at the window border
Restore the mouse cursor change at the crossing of the window border for the Web GUI. Igor Skornyakov
05:17 PM User Interface Bug #2996 (Closed): Cursor change at the window border
Igor Skornyakov
05:14 PM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Cleanup finished.
Committed to the task branch 2565a revno 11026
Ready for the code review
Igor Skornyakov
02:30 PM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Custom mouse pointer support for the @COMBO-BOX@ (WebGUI) finished.
Committed to the task branch 2565a revno 11023...
Igor Skornyakov
10:13 AM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Greg Shah wrote:
> Please create a separate task for this. We may have someone else work it. Do not work on the ...
Igor Skornyakov
10:08 AM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
> After that the only remaining issue will be cursor change on the window border. It should be difficult
Please crea...
Greg Shah
08:41 AM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Greg Shah wrote:
> Igor: Please provide some details on the state of this task. I know you are working on some prob...
Igor Skornyakov
08:06 AM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Igor: Please provide some details on the state of this task. I know you are working on some problems with combo-box ... Greg Shah
02:34 PM User Interface Bug #2995: if the first mouse after app startup is on a combo-box, then an abend occurs
Greg Shah wrote:
> Code Review Task Branch 2565a Revisions 11019/11020
> 1. Why are @WidgetRegistry.getComponents()...
Igor Skornyakov
11:01 AM User Interface Bug #2995: if the first mouse after app startup is on a combo-box, then an abend occurs
Code Review Task Branch 2565a Revisions 11019/11020
Overall, the approach seems good.
1. Why are @WidgetRegistr...
Greg Shah
02:06 PM User Interface Bug #2914: Fix errors in window_sizing/test_runner.p
I've created task branch 2914a. Hynek Cihlar
12:53 PM User Interface Bug #2849: implement and/or fix the default popup menus for all widgets
Vadim Gindin wrote:
> I've tested DIALOG-BOX. System popups are really don't work for it. So I'm adding that support...
Hynek Cihlar
12:28 PM User Interface Bug #2849: implement and/or fix the default popup menus for all widgets
I've tested DIALOG-BOX. System popups are really don't work for it. So I'm adding that support to DialogBox in the sa... Vadim Gindin
10:36 AM User Interface Bug #2849: implement and/or fix the default popup menus for all widgets
Vadim Gindin wrote:
> Hynek Cihlar wrote:
> > In @MenuGuiImpl@, why to use reflection instead of just calling the c...
Hynek Cihlar
07:17 AM User Interface Bug #2849: implement and/or fix the default popup menus for all widgets
Hynek Cihlar wrote:
> @EditorGuiImpl.mouseClicked()@
> The @wnd.initEditorPopup()@ call is fishy and I think may not ...
Vadim Gindin
11:00 AM User Interface Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
The conversion testing completed, generated codes are identical. Continue with runtime testing. Eugenie Lyzenko
07:32 AM User Interface Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
Greg Shah wrote:
> Code Review Task Branch 2612b Revision 10987
>
> I'm fine with the changes. Please put them t...
Eugenie Lyzenko
07:29 AM User Interface Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
Code Review Task Branch 2612b Revision 10987
I'm fine with the changes. Please put them through regression testing.
Greg Shah
07:47 PM User Interface Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
Task branch @2612b@ for review updated to revision @10987@.
Added support for @INT64@ internal slider variable. Sc...
Eugenie Lyzenko

02/16/2016

06:16 PM User Interface Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
Task branch @2612b@ for review updated to revision @10986@.
Notes resolution for point 1 and 3 from #60 note. The ...
Eugenie Lyzenko
06:07 PM User Interface Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
> But the question: even if we can initially assign the big enough value the screen value can be from MIN to MAX - wh... Greg Shah
05:57 PM User Interface Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
>> The only data is possible to use with slider is INTEGER.
>Changing the Sl variable in slider_test01.p to int64...
Eugenie Lyzenko
04:42 PM User Interface Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
>> 2. Can you use an int64 or decimal with a slider?
>
> The only data is possible to use with slider is INTEGER.
...
Greg Shah
04:39 PM User Interface Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
Guy: Eugenie's slider testcases exhibit a strange behavior in GUI. Consider this code:... Greg Shah
04:31 PM User Interface Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
>1. Please add comments to the javadoc for both versions of SliderWidget,setNoCurrentValue(). As you mention in note ... Eugenie Lyzenko
04:03 PM User Interface Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
Code Review Task Branch 2612b Revision 10985
This is great work!
1. Please add comments to the javadoc for both...
Greg Shah
03:54 PM User Interface Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
Greg Shah wrote:
> What testcases shows this behavior?
Every test in @uast/slider/@ directory. In all of them the...
Eugenie Lyzenko
03:31 PM User Interface Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
> Also I've made the change looking strange, so need your comments. I have found in 4GL when the slider value is chan... Greg Shah
06:00 PM User Interface Bug #2849: implement and/or fix the default popup menus for all widgets
@EditorGuiImpl.mouseClicked()@
The @wnd.initEditorPopup()@ call is fishy and I think may not work in a @DIALOG-BOX@....
Hynek Cihlar
03:25 PM User Interface Bug #2849: implement and/or fix the default popup menus for all widgets
Yes, you can start testing.
Hynek and Constantin: please review.
Greg Shah
12:58 PM User Interface Bug #2849: implement and/or fix the default popup menus for all widgets
Fixed. Can I ran regression testing? Vadim Gindin
12:34 PM User Interface Bug #2849: implement and/or fix the default popup menus for all widgets
Code Review Task Branch 2849a Revision 10995
1. In @EditorPopupGuiImpl@, this code:...
Greg Shah
05:11 AM User Interface Bug #2849: implement and/or fix the default popup menus for all widgets
Greg Shah wrote:
> ..
> 3. It is not clear to me if the changes to how @invalidateSelection()@ is called in the @Ed...
Vadim Gindin
04:36 AM User Interface Bug #2849: implement and/or fix the default popup menus for all widgets
I've rebased branch 2849a with the latest trunk revision. Current branch revision is 10992. Vadim Gindin
05:53 PM User Interface Support #2672: GUI web client performance improvements
The difficult problems in ./browse/gui/browse-gui-stat1.p are
!browse_artifacts_in_title.png!
It happens after clicki...
Sergey Ivanovskiy
05:38 PM User Interface Support #2672: GUI web client performance improvements
It looks the same for ./browse/gui/browse-gui-stat1.p, I am planning to check the dots drawing and to do it the same ... Sergey Ivanovskiy
05:05 PM User Interface Support #2672: GUI web client performance improvements
Sergey Ivanovskiy wrote:
> If we draw the image exactly like it comes from the Java, the result should be like we se...
Constantin Asofiei
05:00 PM User Interface Support #2672: GUI web client performance improvements
Sergey Ivanovskiy wrote:
> It should be the same as the previous implementation it has been tested with demo_widgets...
Constantin Asofiei
04:59 PM User Interface Support #2672: GUI web client performance improvements
If we draw the image exactly like it comes from the Java, the result should be like we see, I have encountered it in ... Sergey Ivanovskiy
04:52 PM User Interface Support #2672: GUI web client performance improvements
Sergey Ivanovskiy wrote:
> The image background issue is ...
Thanks for pointing this, I'll look into it. I think so...
Constantin Asofiei
04:50 PM User Interface Support #2672: GUI web client performance improvements
The image background issue is !icons_bg_issue.png! Sergey Ivanovskiy
04:42 PM User Interface Support #2672: GUI web client performance improvements
Constantin Asofiei wrote:
> Sergey, about revision 11021; the changes look OK, but are you sure this gets us the sam...
Sergey Ivanovskiy
04:30 PM User Interface Support #2672: GUI web client performance improvements
Sergey, about revision 11021; the changes look OK, but are you sure this gets us the same result as the previous impl... Constantin Asofiei
03:54 PM User Interface Support #2672: GUI web client performance improvements
1811t rev 11022 enhances the drawing cache to include intermediate widget states; currently, caching is used only for... Constantin Asofiei
12:02 PM User Interface Support #2672: GUI web client performance improvements
Sergey Ivanovskiy wrote:
> Constantin, could you help? Does the Web Chui client support md5 hashing? It looks that p...
Constantin Asofiei
11:48 AM User Interface Support #2672: GUI web client performance improvements
Constantin, could you help? Does the Web Chui client support md5 hashing? It looks that p2j.socket.js is a common mod... Sergey Ivanovskiy
01:34 AM User Interface Support #2672: GUI web client performance improvements
Greg Shah wrote:
> It got me thinking. When the user is editing text in a fill-in or editor (or a browse cell/simple...
Sergey Ivanovskiy
04:51 PM User Interface Bug #2911: Fix extra background shown for popup_ext.p
Some more info for note 25; the main problem with menu and popup-menu is this: these widgets behave differently than ... Constantin Asofiei
03:29 PM User Interface Feature #2967: web socket message sizes are limited to 32K, make sure that drawing ops and images...
Agree, it doesn't require to use Web Workers API. There is an alternative to use Timers API or http://dbaron.org/log/... Sergey Ivanovskiy
12:04 PM User Interface Bug #2995: if the first mouse after app startup is on a combo-box, then an abend occurs
Please find the diff file attached. The fix is committed to the task branch 2565a Igor Skornyakov
11:07 AM User Interface Bug #2995: if the first mouse after app startup is on a combo-box, then an abend occurs
I prefer not to add a 3rd party code dependency for this. The 3rd party code also seems more designed for caching. T... Greg Shah
11:04 AM User Interface Bug #2995: if the first mouse after app startup is on a combo-box, then an abend occurs
From Igor:
After added synchronization for access to the WidgetRegistry.widgetList the problem seem to disappear. ...
Greg Shah
11:03 AM User Interface Bug #2995: if the first mouse after app startup is on a combo-box, then an abend occurs
This was reported by Igor:
-------- Forwarded Message --------
Subject: Issue with COMBO-BOX
Date: Thu, 11 Feb...
Greg Shah
11:01 AM User Interface Bug #2995 (Closed): if the first mouse after app startup is on a combo-box, then an abend occurs
Greg Shah
11:19 AM User Interface Bug #2914: Fix errors in window_sizing/test_runner.p
Greg Shah wrote:
> Please create a 2914a task branch for the changes. I'd also like to see some details posted here...
Hynek Cihlar
09:59 AM User Interface Bug #2914: Fix errors in window_sizing/test_runner.p
Please create a 2914a task branch for the changes. I'd also like to see some details posted here about the problems ... Greg Shah
10:46 AM User Interface Bug #2784 (Rejected): ./menu/simple_sm.p displays parts of menus inside window content frame for ...
I closing this, since all known issues are already resolved. Greg Shah
10:39 AM User Interface Bug #1830: implement SYSTEM-DIALOG-GET-FILE support
> Implement everything from scratch keeping look and feel to match the Windows style. In this model all elements are... Greg Shah
10:35 AM User Interface Bug #1830: implement SYSTEM-DIALOG-GET-FILE support
The customer has confirmed that these statements will soon be disabled in their code. We do not have to work this ta... Greg Shah
08:44 AM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
-------- Forwarded Message --------
Subject: Re: Mouse cursor
Date: Wed, 10 Feb 2016 13:55:42 -0500
From: Igor ....
Greg Shah
08:43 AM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
-------- Forwarded Message --------
Subject: Re: Mouse cursor
Date: Wed, 10 Feb 2016 13:38:27 -0500
From: Igor ....
Greg Shah
08:42 AM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
-------- Forwarded Message --------
Subject: Re: Mouse cursor
Date: Wed, 10 Feb 2016 13:26:26 -0500
From: Igor ...
Greg Shah

02/15/2016

06:07 PM User Interface Support #2672: GUI web client performance improvements
Code Review Task Branch 1811t Revisions 11020/11021
The changes in @p2j.canvas_renderer.js@ are pretty straightfor...
Greg Shah
05:29 PM User Interface Support #2672: GUI web client performance improvements
This text was written by Sergey in #2967 (note 21):
> In the case of the text editor we have numerous synchronous ...
Greg Shah
04:40 PM User Interface Support #2672: GUI web client performance improvements
Greg, please review the committed revision 11021. It reduced @putImageData@ invocations for horizontal and vertical l... Sergey Ivanovskiy
02:29 AM User Interface Support #2672: GUI web client performance improvements
For vertical and horizontal lines the stroke that widens a line can be optimized to reduce @putImageData@, because th... Sergey Ivanovskiy
05:37 PM User Interface Feature #2967: web socket message sizes are limited to 32K, make sure that drawing ops and images...
> The note 18 states that if we send a large message from JS to Java using JS WebSocket API, then the Jetty server ca... Greg Shah
12:36 PM User Interface Feature #2967: web socket message sizes are limited to 32K, make sure that drawing ops and images...
> 4. I don't understand all your findings so far. In particular, you state in notes 12 and 14 above, that our curren... Sergey Ivanovskiy
11:51 AM User Interface Feature #2967: web socket message sizes are limited to 32K, make sure that drawing ops and images...
Some thoughts:
1. The current RFC implements a per "frame" payload size specified in the frame header with a maxim...
Greg Shah
01:25 PM User Interface Bug #2982: in Web client, overlay window must not be "resizeable"
@processWindowBorder@ is noop when overlay window is active.
Committed to the task branch 2565a revno 11022.
Igor Skornyakov
11:24 AM User Interface Bug #2787: implement mnemonics/accelerator key support for button
# How is the alert-box relates to mnemonics?
# Does button grouping mechanism supported not or it doesn't supported ...
Vadim Gindin
08:23 AM User Interface Bug #2787: implement mnemonics/accelerator key support for button
Created task branch 2787a from P2J trunk revision 10971. Vadim Gindin
10:52 AM User Interface Bug #2857: font differences for toggle box and menu
Vadim, are the metrics of the toggle-box correct? I mean, the widget height/width (and its inner highlight rectangle)... Constantin Asofiei
10:18 AM User Interface Bug #2849: implement and/or fix the default popup menus for all widgets
Code Review Task Branch 2849a Revision 10991
1. Please rebase this to the latest trunk revision 10971.
2. The u...
Greg Shah
08:02 AM User Interface Bug #2784: ./menu/simple_sm.p displays parts of menus inside window content frame for the web client
I've checked it just now. It is not reproduced in the current trunk revision (10971). Vadim Gindin
07:15 AM User Interface Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
Rebased task branch @2612b@ from P2J trunk revision @10971@, new revision is @10985@. Eugenie Lyzenko
06:47 AM User Interface Bug #2911: Fix extra background shown for popup_ext.p
Vadim Gindin wrote:
> So I thought so and I'd tried to fix this changing the point used to call the body from @bodyL...
Constantin Asofiei
05:57 AM User Interface Feature #1801: add some frame options
Task branch 2038b was merged to trunk as revision 10971.
It resolves the runtime support for FRAME/WINDOW attribut...
Hynek Cihlar
05:36 AM User Interface Feature #1801: add some frame options
Hynek Cihlar wrote:
> Are you ok with merging 2038b revision 11000 to trunk?
Yes, go ahead and merge to trunk.
Constantin Asofiei
05:23 AM User Interface Feature #1801: add some frame options
Constantin Asofiei wrote:
> Hynek, about 2038b revision 10999:
> # @Frame.calculateWidth@ - line 1619 has some comm...
Hynek Cihlar
04:54 AM User Interface Feature #1801: add some frame options
Hynek, about 2038b revision 10999:
# @Frame.calculateWidth@ - line 1619 has some commented code, remove it if is no ...
Constantin Asofiei

02/14/2016

04:42 PM User Interface Bug #1830: implement SYSTEM-DIALOG-GET-FILE support
Greg Shah wrote:
> Actually, I'm trying to avoid doing this task for the current project. I am waiting to hear back...
Eugenie Lyzenko
04:41 PM User Interface Bug #1830: implement SYSTEM-DIALOG-GET-FILE support
Actually, I'm trying to avoid doing this task for the current project. I am waiting to hear back from the customer. ... Greg Shah
01:23 PM User Interface Bug #2911: Fix extra background shown for popup_ext.p
Sub-menu body background looks drawn in a correct point, but it is also cut (clipped), so it is hardly depends on ite... Vadim Gindin
06:00 AM User Interface Bug #2911: Fix extra background shown for popup_ext.p
So I thought so and I'd tried to fix this changing the point used to call the body from @bodyLoc@ to @this.physicalLo... Vadim Gindin
05:50 AM User Interface Bug #2911: Fix extra background shown for popup_ext.p
Could you help me to deal with that. Here is the sub-menus hierarchy: Menu->SubMenu["John"]->SubMenu["sm00"].
Here...
Vadim Gindin

02/13/2016

05:05 PM User Interface Support #2672: GUI web client performance improvements
Greg, Constantin, the committed revision 11020 reduces @putImageData@ invocations for horizontal and vertical lines. ... Sergey Ivanovskiy
03:54 PM User Interface Feature #1801: add some frame options
2038b revision 10999 passes ChUI regression tests, GUI regression tests and the supported customer GUI demo screens. ... Hynek Cihlar
07:07 PM User Interface Bug #1830: implement SYSTEM-DIALOG-GET-FILE support
Is this the next task in queue, correct? Eugenie Lyzenko
07:03 PM User Interface Bug #1830: implement SYSTEM-DIALOG-GET-FILE support
This is the simple demo for @SYSTEM-DIALOG GET-FILE@ statement. As you can see it is the native OS dialog. So we have... Eugenie Lyzenko

02/12/2016

03:39 PM User Interface Bug #2968: disconnect/reconnect and manual reload must re-establish the websocket connection, nee...
1) Disconnect/reconnect usecase
Greg, please could you explain disconnect/reconnect? Does it mean the main connectio...
Sergey Ivanovskiy
11:27 AM User Interface Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
Task branch @2612b@ for review updated to revision @10983, 10984@.
Added missed @ASSIGN@ statement support. Now th...
Eugenie Lyzenko
07:21 PM User Interface Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
Some mote testing for GUI slider:
1. The web client works fine, see the attached file for sample.
2. There is one...
Eugenie Lyzenko
05:43 AM User Interface Support #2672: GUI web client performance improvements
Constantin, please look at this diff with the current 1811t. It works but the performance hasn't been increased yet. ... Sergey Ivanovskiy
12:41 AM User Interface Feature #2967: web socket message sizes are limited to 32K, make sure that drawing ops and images...
Found that on the current branch the draw buffer size (0x81 message) is large enough if we scroll down the editor con... Sergey Ivanovskiy

02/11/2016

02:05 PM User Interface Feature #2967: web socket message sizes are limited to 32K, make sure that drawing ops and images...
According to my test if we send the file with its size exceeding the maximum binary message size excepted by Jetty (g... Sergey Ivanovskiy
01:22 PM User Interface Feature #2612: implement GUI conversion and runtime support for the SLIDER widget
Task branch @2612b@ for review updated to revision @10982@.
The screenshot for dynamic widget in @P2J@ is attached...
Eugenie Lyzenko
01:14 PM User Interface Bug #2911: Fix extra background shown for popup_ext.p
> It means that @Origin@ of sm00 is @219:104@. What does @AbstractGuiDriver.translatedOrigin@ contain? Is it a locati... Constantin Asofiei
12:33 PM User Interface Bug #2911: Fix extra background shown for popup_ext.p
John drawing bitmap at: 25:104 with clip: NativeRectangle[top=0, left=0, bottom=23, right=100]
John drawing body bit...
Vadim Gindin
08:31 AM User Interface Bug #2911: Fix extra background shown for popup_ext.p
Vadim Gindin wrote:
> I've fixed bodyLoc translation in SubMenuGuiImpl.draw(). It was translated twice, that was wro...
Constantin Asofiei
05:38 AM User Interface Bug #2911: Fix extra background shown for popup_ext.p
I've fixed bodyLoc translation in SubMenuGuiImpl.draw(). It was translated twice, that was wrong and coordinates look... Vadim Gindin
11:28 AM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
1. The discussion become too deep inside the code logic to be private. Please move it to the Redmine, appropriate tas... Eugenie Lyzenko
11:28 AM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Well. it seem that the problem is in the AbstractContainer. findMouseSource method. Its implementation seems a little... Eugenie Lyzenko
11:26 AM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
I will take a look. Please note however that for all widgets except drop-down part of the COMBO-BOX mouse hover event... Eugenie Lyzenko
11:26 AM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Hi Igor,
The mouse events for drop-down's ScrollableSelectionListGuiImpl component is routed from ScrollPaneGuiImp...
Eugenie Lyzenko
11:25 AM User Interface Feature #2565: implement runtime support for the SET-WAIT-STATE method
Hi Eugenie,
I'm working now on the runtime support for the custom mouse cursor (LOAD-MOUSE-POINTER method). At this ...
Eugenie Lyzenko
11:18 AM Database Bug #2990: inconsequent field names in shared temp-tables
Ok, my concern on this comes from the scale of the unknowns: we've got 13% test coverage and so it's unknown how many... Paul E
10:27 AM Database Bug #2990: inconsequent field names in shared temp-tables
This is a challenging error to detect at conversion time, given the way we currently detect common temp-table definit... Eric Faulhaber
09:59 AM Runtime Infrastructure Bug #2994 (New): use static code analysis to scan p2j source for security vulnerabilities (Java, ...
Greg Shah
09:57 AM Runtime Infrastructure Support #2993 (New): penetration testing: non-priviledged local user scenario
Greg Shah
09:55 AM Runtime Infrastructure Support #2992 (New): penetration testing: remote access scenario
Greg Shah
09:50 AM Runtime Infrastructure Support #2991: ensure that all XML parsing is done securely
A useful quote from one of the above articles:
"Java applications using XML libraries are particularly vulnerable ...
Greg Shah
09:48 AM Runtime Infrastructure Support #2991: ensure that all XML parsing is done securely
https://blog.detectify.com/2014/04/11/how-we-got-read-access-on-googles-production-servers/
https://www.owasp.org/in...
Greg Shah
09:47 AM Runtime Infrastructure Support #2991 (New): ensure that all XML parsing is done securely
Greg Shah
09:34 AM User Interface Feature #1801: add some frame options
Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > All work OK.
> Great!
>
> Have you checked the standalone G...
Hynek Cihlar
09:17 AM User Interface Feature #1801: add some frame options
Hynek Cihlar wrote:
> All work OK.
Great!
Have you checked the standalone GUI tests?
Constantin Asofiei
09:12 AM User Interface Feature #1801: add some frame options
Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > Yes, I didn't find any regressions there. What is the official ...
Hynek Cihlar
07:03 AM User Interface Feature #1801: add some frame options
Hynek Cihlar wrote:
> Yes, I didn't find any regressions there. What is the official test scenario that should work?...
Constantin Asofiei
06:38 AM User Interface Feature #1801: add some frame options
Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > Constantin, please review.
> I'm OK with the changes. I assum...
Hynek Cihlar
06:02 AM User Interface Feature #1801: add some frame options
Hynek Cihlar wrote:
> Constantin, please review.
I'm OK with the changes. I assume some cleanup is still needed, a...
Constantin Asofiei
04:18 AM User Interface Feature #1801: add some frame options
The ChUI regression test run ended with a regression, an NPE in FillIn.draw(). This was fixed in 2038b revision 10995... Hynek Cihlar
 

Also available in: Atom