FWD

02/19/2019

06:08 PM Base Language Feature #3751: implement support for OO 4GL and structured error handling

Greg Shah wrote:
> Good. :) I was worried that I had missed something.
As we are still on the overload subject: I ... Constantin Asofiei

05:53 PM Base Language Feature #3751: implement support for OO 4GL and structured error handling

Good. :) I was worried that I had missed something. Greg Shah

05:46 PM Base Language Feature #3751: implement support for OO 4GL and structured error handling

Greg Shah wrote:
> Do you have a testcase that shows a different result?
No.
Constantin Asofiei

05:42 PM Base Language Feature #3751: implement support for OO 4GL and structured error handling

Constantin Asofiei wrote:
> There's another case regarding the parameter modes at the method's signature: the caller... Greg Shah

02:14 PM Database Feature #3758 (Closed): misc database features

Greg Shah

01:14 PM Database Feature #3758: misc database features

Greg Shah wrote:
> Can this task be closed?
RECORD-LENGTH: I think I covered all datatypes which can be serialize... Ovidiu Maxiniuc

12:44 PM Database Feature #3758: misc database features

Can this task be closed? Greg Shah

12:43 PM Database Feature #3758: misc database features

Code Review 3750b Revision 11340
I'm good with the changes. I like the approach with the BDT @getSize()@. When w... Greg Shah

01:04 PM Database Feature #3761: add DYNAMIC-FUNCTION() support to the dynamic database WHERE clause interpreter

Yes, I think it is safe. Greg Shah

01:00 PM Database Feature #3761: add DYNAMIC-FUNCTION() support to the dynamic database WHERE clause interpreter

Ovidiu Maxiniuc wrote:
> I think it ready for the final regression test. It must be the ETF, the standard tests on d... Eric Faulhaber

12:29 PM Database Feature #3761: add DYNAMIC-FUNCTION() support to the dynamic database WHERE clause interpreter

Greg Shah wrote:
> Does the customer's testcase work properly?
Yes, it did.
> Is there anything more to do on th... Ovidiu Maxiniuc

12:27 PM Database Feature #3761: add DYNAMIC-FUNCTION() support to the dynamic database WHERE clause interpreter

Is there anything more to do on this task?
Does the customer's testcase work properly? Greg Shah

10:46 AM User Interface Feature #3876: add support for "direct font control" at the widget level

I took this issue to resolve custom font assignment to TREEVIEW widget needed in #3750. I did a preliminary work for ... Hynek Cihlar

10:42 AM User Interface Feature #3876 (WIP): add support for "direct font control" at the widget level

Hynek Cihlar

10:35 AM Conversion Tools Feature #3927 (Test): conversion mode that takes a file spec and a file blacklist

Eric Faulhaber

10:04 AM Conversion Tools Feature #3927: conversion mode that takes a file spec and a file blacklist

Code Review Task Branch 3898a Revision 11312
I'm good with the changes. Greg Shah

01:21 AM Conversion Tools Feature #3927: conversion mode that takes a file spec and a file blacklist

Note that the initial implementation of the this feature does not take case-sensitivity into account for name matchin... Eric Faulhaber

01:15 AM Conversion Tools Feature #3927 (Review): conversion mode that takes a file spec and a file blacklist

This feature is added in 3898a/11312. One specifies the @-X@ option to the @ConversionDriver@ and provides a starting... Eric Faulhaber

02/18/2019

06:23 PM Base Language Feature #3751: implement support for OO 4GL and structured error handling

Constantin Asofiei wrote:
> There's another case regarding the parameter modes at the method's signature: the caller... Constantin Asofiei

03:45 PM Base Language Feature #3751: implement support for OO 4GL and structured error handling

There's another case regarding the parameter modes at the method's signature: the caller is not required to specify t... Constantin Asofiei

01:04 PM User Interface Feature #3762: misc UI features

> I've been wondering if the core of the implementation is the idea that the query is closed and reopened such that t... Stanislav Lomany

12:29 PM Conversion Tools Feature #3927: conversion mode that takes a file spec and a file blacklist

The current conversion modes supported by @ConversionDriver@/@TransformDriver@ are either a file specification at the... Eric Faulhaber

12:03 PM Conversion Tools Feature #3927 (Closed): conversion mode that takes a file spec and a file blacklist

Eric Faulhaber

02/15/2019

03:05 AM Testing Feature #3704: enable automated testing for GUI (Swing and web clients)

Cypress doesn't seem to support shadow DOM. See https://github.com/cypress-io/cypress/issues/144. Hynek Cihlar

02/14/2019

05:54 PM Base Language Feature #3751: implement support for OO 4GL and structured error handling

> But there is no tempidx annotation emitted by the parser, so I don't know the targeted constructor. Greg, can you p... Greg Shah

05:48 PM Base Language Feature #3751: implement support for OO 4GL and structured error handling

And something else to mention: after FUNCTION/PROCEDURES and the CALL handle, the 4GL's 'reflection' is the third way... Constantin Asofiei

05:30 PM Base Language Feature #3751: implement support for OO 4GL and structured error handling

Greg Shah wrote:
> I understand the need for the modes/signature for proper runtime matching. It does seem like we ... Constantin Asofiei

05:21 PM Base Language Feature #3751: implement support for OO 4GL and structured error handling

> But there is no tempidx annotation emitted by the parser, so I don't know the targeted constructor. Greg, can you p... Greg Shah

05:15 PM Base Language Feature #3751: implement support for OO 4GL and structured error handling

I understand the need for the modes/signature for proper runtime matching. It does seem like we could put all of thi... Greg Shah

05:08 PM Base Language Feature #3751: implement support for OO 4GL and structured error handling

The same idea is with the constructors - the 4GL compilers 'hard links' the NEW with the constructor definition. We ... Constantin Asofiei

04:56 PM Base Language Feature #3751: implement support for OO 4GL and structured error handling

Greg Shah wrote:
> > I solved this by emitting the signature at the Java method or constructor (for OO cases).
> ... Constantin Asofiei

04:50 PM Base Language Feature #3751: implement support for OO 4GL and structured error handling

> I solved this by emitting the signature at the Java method or constructor (for OO cases).
Can you clarify this... Greg Shah

04:24 PM Base Language Feature #3751: implement support for OO 4GL and structured error handling

Constantin Asofiei wrote:
> FYI, @ClassDefinition.isWideningTypeMatch@ was not extracted correct.
Fixed in 3750b ... Greg Shah

02:11 PM Base Language Feature #3751: implement support for OO 4GL and structured error handling

FYI, @ClassDefinition.isWideningTypeMatch@ was not extracted correct. Constantin Asofiei

12:46 PM Base Language Feature #3751: implement support for OO 4GL and structured error handling

The constructors referenced by the @NEW@ statement must always be disambiguated by the parser phase. The reason is b... Constantin Asofiei

03:45 PM User Interface Feature #3762: misc UI features

I've been wondering if the core of the implementation is the idea that the query is closed and reopened such that the... Greg Shah

03:43 PM User Interface Feature #3762: misc UI features

Stanislav Lomany wrote:
> FYI, we miss implementation of @QUERY:CREATE-RESULT-LIST-ENTRY@, so it should be implement... Greg Shah

03:41 PM User Interface Feature #3762: misc UI features

FYI, we miss implementation of @QUERY:CREATE-RESULT-LIST-ENTRY@, so it should be implemented for all types of queries... Stanislav Lomany

02:07 PM Database Feature #3761: add DYNAMIC-FUNCTION() support to the dynamic database WHERE clause interpreter

Thanks for fixing this. Please note that @index_selection.rules@ lines 487-512 and lines 594-619 are exact duplicates... Eric Faulhaber

10:03 AM Database Feature #3761: add DYNAMIC-FUNCTION() support to the dynamic database WHERE clause interpreter

Eric Faulhaber wrote:
> Ovidiu, I am concerned your changes to @index_selection.rules@ may be too aggressive. Won't ... Ovidiu Maxiniuc

09:41 PM Database Feature #3761: add DYNAMIC-FUNCTION() support to the dynamic database WHERE clause interpreter

Ovidiu, I am concerned your changes to @index_selection.rules@ may be too aggressive. Won't this extract built-in fun... Eric Faulhaber

02/13/2019

02:54 PM Database Feature #3761: add DYNAMIC-FUNCTION() support to the dynamic database WHERE clause interpreter

The function call seems to be more complicated. In fact, I think that all calls to UDF (ABL internal functions) are e... Ovidiu Maxiniuc

01:29 PM User Interface Feature #3762: misc UI features

I'll be working on @BROWSE:CREATE-RESULT-LIST-ENTRY@ while AWS is not accessible. Stanislav Lomany

02/11/2019

03:39 PM Database Feature #3761: add DYNAMIC-FUNCTION() support to the dynamic database WHERE clause interpreter

I did some tests today in order to understand the exact moment when the evaluation of the @P2JQuery.Parameter@ is nee... Ovidiu Maxiniuc

02/07/2019

02:36 PM Database Feature #3044: dynamic validation expression support

Most (if not all) of the work on this was already done in #3275 (see #3275-113 and later). Greg Shah

07:03 PM Testing Feature #3704: enable automated testing for GUI (Swing and web clients)

In regard to the recording and timemachine support, I agree these are pretty tricky. Greg Shah

07:01 PM Testing Feature #3704: enable automated testing for GUI (Swing and web clients)

> If the test is written manually, another tricky part is to uniquely identify a widget - we could use its name (if i... Greg Shah

02/06/2019

06:05 PM Database Feature #3758: misc database features

I added (full) implementation of RECORD-LENGTH to 3750b. Committed revision 11340.
The solution central point is in ... Ovidiu Maxiniuc

09:52 AM Database Feature #3758: misc database features

Please see #3549 for my previous research into the layout of a 4GL serialized database record. It has findings that ... Greg Shah

09:16 AM Database Feature #3758: misc database features

3750b Eric Faulhaber

08:21 AM Database Feature #3758: misc database features

Eric Faulhaber wrote:
> Did you base your implementation on https://documentation.progress.com/output/ua/OpenEdge_la... Ovidiu Maxiniuc

10:40 PM Database Feature #3758: misc database features

Ovidiu Maxiniuc wrote:
> Do we need to find the exact formula for RECORD-LENGTH?
> I have implemented a formula tha... Eric Faulhaber

09:23 PM Database Feature #3758: misc database features

Eric,
Do we need to find the exact formula for RECORD-LENGTH?
I have implemented a formula that works well for a sm... Ovidiu Maxiniuc

04:52 PM Testing Feature #3704: enable automated testing for GUI (Swing and web clients)

Greg Shah wrote:
> Hynek/Constantin: Can you each review the details of the "Cypress":https://cypress.io project an... Constantin Asofiei

12:26 PM User Interface Feature #3908 (Closed): implement browse column VIEW-AS COMBO-BOX

Greg Shah

02/05/2019

11:24 AM Base Language Feature #3751: implement support for OO 4GL and structured error handling

Greg Shah wrote:
> I understand. I was just wondering if our BlockManager exception infrastructure (try/catch/final... Constantin Asofiei

11:21 AM Base Language Feature #3751: implement support for OO 4GL and structured error handling

From Constantin:
> 4GL has some cases where a builtin ERROR condition gets converted to a SysError OO exception if... Greg Shah

08:45 AM Testing Feature #3704: enable automated testing for GUI (Swing and web clients)

Eric Faulhaber wrote:
> Another thing to consider with Cypress: what are the performance implications of maintaining... Greg Shah

09:17 PM Testing Feature #3704: enable automated testing for GUI (Swing and web clients)

Another thing to consider with Cypress: what are the performance implications of maintaining a DOM "shadow tree" that... Eric Faulhaber

02/04/2019

06:41 PM Testing Feature #3704: enable automated testing for GUI (Swing and web clients)

Greg Shah wrote:
> Another testing framework is "Cypress":https://cypress.io. A customer mentioned that this is beco... Greg Shah

01/31/2019

03:52 PM Base Language Feature #3751: implement support for OO 4GL and structured error handling

Ovidiu, about rev 11329:
* there was a merge typo in ObjectOps - I've fixed it in 11330
* you can use @AtomicIntege... Constantin Asofiei

10:41 AM Base Language Feature #3751: implement support for OO 4GL and structured error handling

Constantin Asofiei wrote:
> The idea is the @? extends Bar@ - Java doesn't allow accessing a private method from a s... Ovidiu Maxiniuc

08:55 AM Base Language Feature #3751: implement support for OO 4GL and structured error handling

Ovidiu Maxiniuc wrote:
> Constantin Asofiei wrote:
> > Does it compile if you edit the file to look like @((Bar) fo... Constantin Asofiei

08:49 AM Base Language Feature #3751: implement support for OO 4GL and structured error handling

The same cast is currently generated for private methods. Ovidiu Maxiniuc

08:45 AM Base Language Feature #3751: implement support for OO 4GL and structured error handling

Constantin Asofiei wrote:
> Does it compile if you edit the file to look like @((Bar) foo.ref()).myName.assign(p1);@... Ovidiu Maxiniuc

08:14 AM Base Language Feature #3751: implement support for OO 4GL and structured error handling

Ovidiu Maxiniuc wrote:
> *2*. The destructors are not called for me because for me @ProcedureManager.getStackEntry(0... Constantin Asofiei

07:15 AM Base Language Feature #3751: implement support for OO 4GL and structured error handling

Constantin,
Three notes after our last conversation:
*1*. I got what you meant. I will add the necessary support f... Ovidiu Maxiniuc

06:26 AM Base Language Feature #3751: implement support for OO 4GL and structured error handling

I don't think counting these objects will be the problem. I think this can be easily done by a context-local integer ... Ovidiu Maxiniuc

01/30/2019

06:31 PM Base Language Feature #3751: implement support for OO 4GL and structured error handling

Eric Faulhaber wrote:
> Constantin Asofiei wrote:
> > One more thing to add: do not convert to bulk delete a @for ... Constantin Asofiei

06:23 PM Base Language Feature #3751: implement support for OO 4GL and structured error handling

Constantin Asofiei wrote:
> One more thing to add: do not convert to bulk delete a @for tt-buffer: delete tt-buffer... Eric Faulhaber

05:59 PM Base Language Feature #3751: implement support for OO 4GL and structured error handling

Ovidiu Maxiniuc wrote:
> I committed some fixes and a solution for bulk delete. The update contains some optimisatio... Constantin Asofiei

03:32 PM Base Language Feature #3751: implement support for OO 4GL and structured error handling

Greg Shah wrote:
> If you specify the @FOR@, then the name of the handle must be an existing variable in the externa... Constantin Asofiei

03:29 PM Base Language Feature #3751: implement support for OO 4GL and structured error handling

What a ridiculous undocumented "feature". To be clear: when the @FOR handle@ is present, it seems to map the "proced... Greg Shah

12:48 PM Base Language Feature #3751: implement support for OO 4GL and structured error handling

Constantin Asofiei wrote:
> The only way I can make it work is like this:
> [...]
> I think you are correct, the F... Constantin Asofiei

12:42 PM Base Language Feature #3751: implement support for OO 4GL and structured error handling

The only way I can make it work is like this:... Constantin Asofiei

12:37 PM Base Language Feature #3751: implement support for OO 4GL and structured error handling

There is an undocumented "feature" that allows @TABLE-HANDLE FOR@ to be specified. It was seen in customer code and ... Greg Shah

12:27 PM Base Language Feature #3751: implement support for OO 4GL and structured error handling

Greg Shah wrote:
> Constantin: Can you think of any reason I should fix this instead of deleting it?
I think it was... Constantin Asofiei

12:01 PM Base Language Feature #3751: implement support for OO 4GL and structured error handling

In @common-progress@ there is this function:... Greg Shah

01:45 AM Base Language Feature #3751: implement support for OO 4GL and structured error handling

Constantin Asofiei wrote:
> Please focus on finding the hooks for field assignment and record deletion. I'll fix an... Ovidiu Maxiniuc

12:52 PM Conversion Tools Feature #3337: Source code analytics features

We should simplify the use of the @ReportDriver@. Currently, it is too error prone.
When implementing reporting v3... Eric Faulhaber

01/29/2019

03:55 PM Base Language Feature #3751: implement support for OO 4GL and structured error handling

Ovidiu Maxiniuc wrote:
> Constantin Asofiei wrote:
> > The DESTRUCTOR is called when the object is explicitly delet... Constantin Asofiei

10:25 AM Base Language Feature #3751: implement support for OO 4GL and structured error handling

Constantin Asofiei wrote:
> The DESTRUCTOR is called when the object is explicitly deleted (via @DELETE OBJECT@) or ... Ovidiu Maxiniuc

11:59 PM Base Language Feature #3751: implement support for OO 4GL and structured error handling

Constantin Asofiei wrote:
> 3750b 11320 fixes a conversion problem.
It also converted and compiled fully with the P... Constantin Asofiei

01/28/2019

05:37 PM Base Language Feature #3751: implement support for OO 4GL and structured error handling

3750b 11320 fixes a conversion problem. Constantin Asofiei

03:43 PM Base Language Feature #3751: implement support for OO 4GL and structured error handling

Eric Faulhaber wrote:
> Do we not know which class' objects will be stored in a field at conversion time, and whethe... Constantin Asofiei

03:40 PM Base Language Feature #3751: implement support for OO 4GL and structured error handling

Constantin Asofiei wrote:
> Let me rephrase this. We wouldn't 'bulk delete' a loop like this, right?
> [...]
Co... Eric Faulhaber

03:35 PM Base Language Feature #3751: implement support for OO 4GL and structured error handling

Constantin Asofiei wrote:
> Eric Faulhaber wrote:
> > I think we still could maintain the bulk operations by queryi... Constantin Asofiei

03:25 PM Base Language Feature #3751: implement support for OO 4GL and structured error handling

Eric Faulhaber wrote:
> I think we still could maintain the bulk operations by querying the object references first,... Constantin Asofiei

03:20 PM Base Language Feature #3751: implement support for OO 4GL and structured error handling

Exactly. This is what I meant in note 436. Ovidiu Maxiniuc

03:15 PM Base Language Feature #3751: implement support for OO 4GL and structured error handling

Constantin Asofiei wrote:
> Eric Faulhaber wrote:
> > Take for example an EMPTY-TEMP-TABLE statement or a table goi... Eric Faulhaber

03:02 PM Base Language Feature #3751: implement support for OO 4GL and structured error handling

Eric Faulhaber wrote:
> Take for example an EMPTY-TEMP-TABLE statement or a table going out of scope. We just do an ... Constantin Asofiei

02:56 PM Base Language Feature #3751: implement support for OO 4GL and structured error handling

Constantin Asofiei wrote:
> Eric Faulhaber wrote:
> > Are there side effects to an object being gc'd, such that the... Eric Faulhaber

02:55 PM Base Language Feature #3751: implement support for OO 4GL and structured error handling

Ovidiu Maxiniuc wrote:
> I don't think that this is possible (as you noted also, the bulk delete is the main cause h... Constantin Asofiei

02:41 PM Base Language Feature #3751: implement support for OO 4GL and structured error handling

Ovidiu Maxiniuc wrote:
> BTW, I see that the destructor is not yet called. Will it be called automatically when the ... Constantin Asofiei

02:36 PM Base Language Feature #3751: implement support for OO 4GL and structured error handling

Constantin Asofiei wrote:
> Good question. Yes, there is legacy @DESTRUCTOR@ code which needs to be executed on del... Ovidiu Maxiniuc

02:30 PM Base Language Feature #3751: implement support for OO 4GL and structured error handling

Eric Faulhaber wrote:
> Are there side effects to an object being gc'd, such that the delete/gc has to happen at a v... Constantin Asofiei

02:29 PM Base Language Feature #3751: implement support for OO 4GL and structured error handling

Eric Faulhaber wrote:
> How are you doing he reference counting for object references stored in temp-tables?
We are... Ovidiu Maxiniuc

02:24 PM Base Language Feature #3751: implement support for OO 4GL and structured error handling

Are there side effects to an object being gc'd, such that the delete/gc has to happen at a very specific time/order, ... Eric Faulhaber

02:21 PM Base Language Feature #3751: implement support for OO 4GL and structured error handling

Eric Faulhaber wrote:
> How are you doing he reference counting for object references stored in temp-tables?
It doe... Constantin Asofiei

02:20 PM Base Language Feature #3751: implement support for OO 4GL and structured error handling

Eric Faulhaber wrote:
> # It is much trickier to know when a record is deleted. We optimize many types of bulk dele... Constantin Asofiei

02:18 PM Base Language Feature #3751: implement support for OO 4GL and structured error handling

Ovidiu Maxiniuc wrote:
> As far as I can tell, if an object is stored in a TEMP-TABLE, it is not automatically disca... Eric Faulhaber

02:16 PM Base Language Feature #3751: implement support for OO 4GL and structured error handling

Constantin Asofiei wrote:
> Eric, is there an easy way to track a DMO property setter (when is being invoked, knowin... Eric Faulhaber

01:58 PM Base Language Feature #3751: implement support for OO 4GL and structured error handling

Simple tests with 3750b rev 11319 are working for static temp-tables, static class initialization, static and instanc... Constantin Asofiei

12:16 PM Base Language Feature #3751: implement support for OO 4GL and structured error handling

Sorry, my bad, the text capture was done with an object still referred by variable. I rerun the code and the destruct... Ovidiu Maxiniuc

12:05 PM Base Language Feature #3751: implement support for OO 4GL and structured error handling

Ovidiu Maxiniuc wrote:
> There are a few interesting notes:
> * the second object created (@C3758Bar_4309@) is drop... Constantin Asofiei

11:54 AM Base Language Feature #3751: implement support for OO 4GL and structured error handling

Constantin Asofiei wrote:
> Did you find way to track if a field is changed (to unknown or some other ref)?
I start... Ovidiu Maxiniuc

02:47 AM Database Feature #3758: misc database features

3750b/11317 adds basic runtime support for the {READ|WRITE}-JSON methods. Basic JSON import and export work with some... Eric Faulhaber