Project

General

Profile

Activity

From 02/16/2021 to 03/17/2021

03/18/2021

11:34 PM User Interface Feature #4179: create a standalone native launcher (Windows EXE and Linux/UNIX version) which can...
Good article: https://stackoverflow.com/questions/6267546/how-do-i-associate-a-custom-mime-type-to-my-local-applicati... Roger Borrello
11:25 PM User Interface Feature #4179: create a standalone native launcher (Windows EXE and Linux/UNIX version) which can...
Greg Shah wrote:
> Is it fully working at this point?
My testcase works on Firefox. I am trying to get the same r...
Roger Borrello
10:55 PM User Interface Feature #4179: create a standalone native launcher (Windows EXE and Linux/UNIX version) which can...
Greg Shah wrote:
> Code Review Task 3821c Revisions 12140 through 12142
>
> The changes are good.
>
> The @Gui...
Roger Borrello
08:52 PM User Interface Feature #4179: create a standalone native launcher (Windows EXE and Linux/UNIX version) which can...
Is it fully working at this point? Greg Shah
08:52 PM User Interface Feature #4179: create a standalone native launcher (Windows EXE and Linux/UNIX version) which can...
Code Review Task 3821c Revisions 12140 through 12142
The changes are good.
The @GuiWebDriver.writeLauncherWrapp...
Greg Shah

03/17/2021

07:31 PM User Interface Feature #4179: create a standalone native launcher (Windows EXE and Linux/UNIX version) which can...
I was missing the @DesktopHelpers@ classname in the method declaration, leading to the issue in #4179-67. Fixed in @1... Roger Borrello
06:33 PM User Interface Feature #4179: create a standalone native launcher (Windows EXE and Linux/UNIX version) which can...
Eugenie Lyzenko wrote:
> Never mind. I see this is already fixed in @12141@. Thanks.
My apologies. The makefile c...
Roger Borrello
06:27 PM User Interface Feature #4179: create a standalone native launcher (Windows EXE and Linux/UNIX version) which can...
Eugenie Lyzenko wrote:
> Eugenie Lyzenko wrote:
> > Roger Borrello wrote:
> > > Changes committed in @12140@.
> ...
Eugenie Lyzenko
06:23 PM User Interface Feature #4179: create a standalone native launcher (Windows EXE and Linux/UNIX version) which can...
Eugenie Lyzenko wrote:
> Roger Borrello wrote:
> > Changes committed in @12140@.
> >
> > Regarding the paramete...
Eugenie Lyzenko
06:06 PM User Interface Feature #4179: create a standalone native launcher (Windows EXE and Linux/UNIX version) which can...
Roger Borrello wrote:
> Changes committed in @12140@.
>
> Regarding the parameters, I didn't want to hold up the...
Eugenie Lyzenko
05:40 PM User Interface Feature #4179: create a standalone native launcher (Windows EXE and Linux/UNIX version) which can...
Changes committed in @12140@.
Regarding the parameters, I didn't want to hold up the task for this. There's some ...
Roger Borrello
10:25 AM User Interface Feature #4179: create a standalone native launcher (Windows EXE and Linux/UNIX version) which can...
> I found that in using Desktop.java, we have some conflicts with awt.Desktop. Should I name that something else?
...
Greg Shah
09:26 AM User Interface Feature #4179: create a standalone native launcher (Windows EXE and Linux/UNIX version) which can...
Greg Shah wrote:
> 1. @LAUNCHER_MIME_TYPE@ should only be defined in one place. Why not put it in @Desktop.java@ and...
Roger Borrello
08:08 AM User Interface Feature #4179: create a standalone native launcher (Windows EXE and Linux/UNIX version) which can...
Code Review Task Branch 3821c Revision 12127
1. @LAUNCHER_MIME_TYPE@ should only be defined in one place. Why not ...
Greg Shah
10:49 PM User Interface Feature #4179: create a standalone native launcher (Windows EXE and Linux/UNIX version) which can...
Greg Shah wrote:
> It just needs to live wherever the @p2j.jar@ exists. It looks like you changed the name of the n...
Roger Borrello
06:23 PM Database Feature #1587: implement full support for word indexes
Igor Skornyakov wrote:
> Without triggers, we have to add the word tables population/update on every insert/update...
Eric Faulhaber
02:04 PM Database Feature #1587: implement full support for word indexes
Eric Faulhaber wrote:
> The current implementation of triggers in H2 seems to be a dealbreaker, in that the trigger ...
Igor Skornyakov
01:53 PM Database Feature #1587: implement full support for word indexes
Igor Skornyakov wrote:
> It seems that for H2 temporary tables it is impossible to use triggers. H2 trigger is invok...
Eric Faulhaber
09:47 AM Database Feature #1587: implement full support for word indexes
It seems that for H2 temporary tables it is impossible to use triggers. H2 trigger is invoked with a separate new con... Igor Skornyakov
08:31 AM Database Feature #1587: implement full support for word indexes
Igor Skornyakov wrote:
> I've encountered a strange problem with trigger for @_temp@:
> [...]
>
> The @OnInsertW...
Igor Skornyakov
07:30 AM Database Feature #1587: implement full support for word indexes
I've encountered a strange problem with trigger for @_temp@:... Igor Skornyakov
03:52 AM Database Feature #1587: implement full support for word indexes
Igor Skornyakov wrote:
> No runtime changes are required. By "will just not work" I mean that the corresponding piec...
Igor Skornyakov
03:30 AM Database Feature #1587: implement full support for word indexes
Eric Faulhaber wrote:
> Until now, I think yes. I think the other related tables (normalized extent field tables), i...
Igor Skornyakov
03:27 AM Database Feature #1587: implement full support for word indexes
Eric Faulhaber wrote:
> Sorry, to clarify "will just not work", do you mean that removing the subscript at conversio...
Igor Skornyakov
04:36 PM Database Feature #3574 (Closed): finish implementation of temp-table XML support
Greg Shah
04:26 PM Database Feature #3574: finish implementation of temp-table XML support
Yes, please do. I am not aware of any remaining issue. Ovidiu Maxiniuc
02:30 PM Database Feature #3574: finish implementation of temp-table XML support
Can we close this? Greg Shah
03:18 PM Testing Feature #1888 (Closed): integrate the framework into the build
Greg Shah
03:14 PM Testing Feature #1888: integrate the framework into the build
Greg Shah wrote:
> It looks good.
>
> Please add javadoc for @AbstractDateTest.createDate()@, @TestDateFormat.bef...
Vladimir Tsichevski
02:57 PM Testing Feature #1888: integrate the framework into the build
It looks good.
Please add javadoc for @AbstractDateTest.createDate()@, @TestDateFormat.beforeClass()@, @TestDateFo...
Greg Shah
02:30 PM Testing Feature #1888: integrate the framework into the build
Greg Shah wrote:
> Code Review Task Branch 3821c Revision 12130
>
> It is good. I really only see coding standar...
Vladimir Tsichevski
11:13 AM Testing Feature #1888: integrate the framework into the build
Code Review Task Branch 3821c Revision 12130
It is good. I really only see coding standards issues.
1. Please ...
Greg Shah
09:56 AM Testing Feature #1888 (Review): integrate the framework into the build
JUnit-based testing support was added in 3821c rev. 12130.
Also 139 tests in 13 containers for parsing/applying va...
Vladimir Tsichevski
02:29 PM Database Bug #5176 (Closed): Buffer field attribute leak
Greg Shah
12:38 PM Base Language Bug #5203: Temp Table - serialization/transaction scope/pk
Marian Edu wrote:
> I've updated the tests in @oo/json/quirks/table_serialize.p@ and the behavior is rather confusin...
Ovidiu Maxiniuc
06:55 AM Base Language Bug #5203: Temp Table - serialization/transaction scope/pk
I've updated the tests in @oo/json/quirks/table_serialize.p@ and the behavior is rather confusing :(
For a temp-ta...
Marian Edu
11:51 PM Base Language Feature #4768: finish copy-lob support
Ovidiu, please note we still need to ensure that UNDO on a persistent table with a LOB field works correctly. Eric Faulhaber

03/16/2021

07:15 PM Base Language Feature #4768: finish copy-lob support
Ovidiu Maxiniuc wrote:
> > * Check undo behavior (if any) with test cases.
> Actually the LOB fields are only allow...
Eric Faulhaber
06:46 PM Base Language Feature #4768: finish copy-lob support
> * Check undo behavior (if any) with test cases.
Actually the LOB fields are only allowed in @NO-UNDO@ tables, the ...
Ovidiu Maxiniuc
06:59 PM User Interface Feature #4179: create a standalone native launcher (Windows EXE and Linux/UNIX version) which can...
It just needs to live wherever the @p2j.jar@ exists. It looks like you changed the name of the native method. Did y... Greg Shah
05:54 PM User Interface Feature #4179: create a standalone native launcher (Windows EXE and Linux/UNIX version) which can...
A minor problem with the Swing that I can move on from. I was just trying to complete the code. But the JNI cannot be... Roger Borrello
01:13 PM User Interface Feature #4179: create a standalone native launcher (Windows EXE and Linux/UNIX version) which can...
Roger Borrello wrote:
> Greg Shah wrote:
> > Code Review #4179-61 Patch
> >
> > 1. The changes to @GuiWebDriver....
Sergey Ivanovskiy
11:29 AM User Interface Feature #4179: create a standalone native launcher (Windows EXE and Linux/UNIX version) which can...
> At this point we don't know whether we have a URI for launcher://file_to_launch or simply a path to a file.
We d...
Greg Shah
11:21 AM User Interface Feature #4179: create a standalone native launcher (Windows EXE and Linux/UNIX version) which can...
Greg Shah wrote:
> Code Review #4179-61 Patch
>
> 1. The changes to @GuiWebDriver.openMimeResource()@ are:
>
>...
Roger Borrello
10:13 AM User Interface Feature #4179: create a standalone native launcher (Windows EXE and Linux/UNIX version) which can...
Code Review #4179-61 Patch
1. The changes to @GuiWebDriver.openMimeResource()@ are:
* should not be uncondition...
Greg Shah
09:28 AM User Interface Feature #4179: create a standalone native launcher (Windows EXE and Linux/UNIX version) which can...
The wrapping end is coded and attached as a patch. I would appreciate some review. I am working on the native code, w... Roger Borrello
06:41 PM Database Feature #1587: implement full support for word indexes
Ovidiu Maxiniuc wrote:
> The only case that comes into my mind is that there is a single statement and the delimiter...
Eric Faulhaber
06:35 PM Database Feature #1587: implement full support for word indexes
I think the missing of @dialect.getDelimiter()@ is just an omission. I am sorry for that. Please add it in @TempTable... Ovidiu Maxiniuc
06:34 PM Database Feature #1587: implement full support for word indexes
Actually, we do append the delimiter to the end of the DROP INDEX statements, which are added to the JDBC batch first... Eric Faulhaber
06:26 PM Database Feature #1587: implement full support for word indexes
Igor Skornyakov wrote:
> I think it is needed. Without it, the statements are not properly terminated and cannot b...
Eric Faulhaber
06:22 PM Database Feature #1587: implement full support for word indexes
Igor Skornyakov wrote:
> Actually, I remove the subscript at runtime (now silently) at a very early stage of the p...
Eric Faulhaber
06:19 PM Database Feature #1587: implement full support for word indexes
Eric Faulhaber wrote:
> > Is there any reason why we do not append @dialect.getDelimiter()@ to the @drop table@ stat...
Igor Skornyakov
06:12 PM Database Feature #1587: implement full support for word indexes
Igor Skornyakov wrote:
> Is there any reason why we do not append @dialect.getDelimiter()@ to the @drop table@ sta...
Eric Faulhaber
05:40 PM Database Feature #1587: implement full support for word indexes
Is there any reason why we do not append @dialect.getDelimiter()@ to the @drop table@ statement in the TempTableHelpe... Igor Skornyakov
04:18 PM Database Feature #1587: implement full support for word indexes
Eric Faulhaber wrote:

> I can make the conversion changes (including adding the 1688 warning), but I wanted to un...
Igor Skornyakov
03:57 PM Database Feature #1587: implement full support for word indexes
> This is a little bit of a grey area, because the converted output we are talking about is a string containing a con... Greg Shah
03:52 PM Database Feature #1587: implement full support for word indexes
Greg Shah wrote:
> In other words, it is OK in the input 4GL code but we should only ever generate correct/clean Jav...
Eric Faulhaber
03:39 PM Database Feature #1587: implement full support for word indexes
> Actually, I do not think that leaving the subscript in the converted code is misleading since the definition of th... Greg Shah
03:05 PM Database Feature #1587: implement full support for word indexes
Eric Faulhaber wrote:
> If we fix the conversion to drop the extent field dereference, will the current runtime be a...
Igor Skornyakov
02:14 PM Database Feature #1587: implement full support for word indexes
If we fix the conversion to drop the extent field dereference, will the current runtime be able to handle the FQL? If... Eric Faulhaber
02:00 PM Database Feature #1587: implement full support for word indexes
Eric Faulhaber wrote:
> Please refresh my memory...for the 1688 warning, is adding the conversion-time warning the o...
Igor Skornyakov
01:06 PM Database Feature #1587: implement full support for word indexes
Please refresh my memory...for the 1688 warning, is adding the conversion-time warning the only thing left to be done... Eric Faulhaber
04:01 AM Database Feature #1587: implement full support for word indexes
Eric Faulhaber wrote:
> Igor, what is left for this task, besides adding the 1688 error to conversion?
Eric,
I u...
Igor Skornyakov
03:56 AM Database Feature #1587: implement full support for word indexes
Igor, what is left for this task, besides adding the 1688 error to conversion? Eric Faulhaber
04:43 PM Base Language Bug #5203: Temp Table - serialization/transaction scope/pk
I created the following test:... Ovidiu Maxiniuc
03:42 PM Base Language Bug #5203: Temp Table - serialization/transaction scope/pk
This is a bit strange: suppose we have a record in buffer but, since the record was not validated, it may be invalid.... Ovidiu Maxiniuc
01:42 PM Base Language Bug #5203: Temp Table - serialization/transaction scope/pk
Marian Edu wrote:
> Ovidiu Maxiniuc wrote:
> > The 'uncommitted' records are just one for each each buffer. For the...
Eric Faulhaber
12:53 PM Base Language Bug #5203: Temp Table - serialization/transaction scope/pk
Ovidiu Maxiniuc wrote:
> I do not think the problem here is the transaction. It seems to me that this is only relate...
Marian Edu
12:22 PM Base Language Bug #5203: Temp Table - serialization/transaction scope/pk
I do not think the problem here is the transaction. It seems to me that this is only related to serialization methods... Ovidiu Maxiniuc
07:38 AM Base Language Bug #5203: Temp Table - serialization/transaction scope/pk
Eric/Ovidiu: the above looks like a temp-table flush issue. Constantin Asofiei
05:52 AM Base Language Bug #5203: Temp Table - serialization/transaction scope/pk
There seems to be a difference in how 4GL is handling serialization/transaction scoping for temp-tables. First I thou... Marian Edu
05:52 AM Base Language Bug #5203 (Test): Temp Table - serialization/transaction scope/pk
Marian Edu
01:02 PM Base Language Bug #5202: Temp Table serialize-name/xml-node-name
Ovidiu Maxiniuc wrote:
> The @xmlNodeName@ and @serializeName@ are members of this structure and they are used on ...
Marian Edu
11:51 AM Base Language Bug #5202: Temp Table serialize-name/xml-node-name
The code in @Column@ constructor is as old as the class itself. What has changed recently is the data structure and t... Ovidiu Maxiniuc
11:34 AM Base Language Bug #5202: Temp Table serialize-name/xml-node-name
Aren't these changes in a very recent revision of 3821c? I think they are not present in the latest 4384i. Perhaps ... Greg Shah
11:23 AM Base Language Bug #5202 (WIP): Temp Table serialize-name/xml-node-name
We do not use the @Table@ annotation directly, because that is the static hardcoded value. Instead, the values of its... Ovidiu Maxiniuc
03:49 AM Base Language Bug #5202: Temp Table serialize-name/xml-node-name
Eric/Ovidiu: please comment what's the proper way of resolving the xmlNodeName, serializeName for a temp-table. Constantin Asofiei
03:44 AM Base Language Bug #5202: Temp Table serialize-name/xml-node-name
While the @Table@ annotation has both the @xmlNodeName@ and @serializeName@ info, that is not available in @TempTable... Marian Edu
03:43 AM Base Language Bug #5202 (Test): Temp Table serialize-name/xml-node-name
Marian Edu
11:26 AM Testing Feature #1888: integrate the framework into the build
By generic, I mean that the code would be used in other projects outside of FWD. Greg Shah
11:26 AM Testing Feature #1888: integrate the framework into the build
4GL (OE) related stuff is FWD-specific so that is NOT generic. Greg Shah
10:42 AM Testing Feature #1888: integrate the framework into the build
Greg Shah wrote:
> ... For anything generic, please put the helpers in @com.goldencode.testing@.
By anything ge...
Vladimir Tsichevski
10:39 AM Testing Feature #1888: integrate the framework into the build
> We can use something like com.goldencode.p2j.tests as the base package name for that classes, OK?
For any test h...
Greg Shah
10:35 AM Testing Feature #1888: integrate the framework into the build
Greg Shah wrote:
> Please put the test classes into the same package as the classes they test, but with a @test@ bas...
Vladimir Tsichevski
03:32 AM User Interface Bug #5118: TREELIST widget issues
Vladimir Tsichevski wrote:
> An issue from #4908-4:
>
> By pressing and releasing left and right mouse buttons ...
Hynek Cihlar
03:05 AM Base Language Support #5120: Date/Datetime - from iso
Constantin Asofiei wrote:
> Marian: can you take a look at this part:
> > plus some formatting of the string read...
Marian Edu

03/15/2021

07:42 PM User Interface Feature #4179: create a standalone native launcher (Windows EXE and Linux/UNIX version) which can...
> I want to add @GuiWebDriver.openLauncherResource@ that will mimic @openMimeResource@ but will create a temp wrapper... Greg Shah
06:06 PM User Interface Feature #4179: create a standalone native launcher (Windows EXE and Linux/UNIX version) which can...
Some change questions...
I want to add @GuiWebDriver.openLauncherResource@ that will mimic @openMimeResource@ but ...
Roger Borrello
02:13 PM User Interface Feature #4179: create a standalone native launcher (Windows EXE and Linux/UNIX version) which can...
For security reasons, we will prompt the user before calling @desktopOpen()@. The idea is to display the command lin... Greg Shah
02:06 PM User Interface Feature #4179: create a standalone native launcher (Windows EXE and Linux/UNIX version) which can...
I've just spoken with Roger and we've agreed on the following approach.
*1.* @OPEN-MIME-RESOURCE@ will be enhanced...
Greg Shah
09:51 AM User Interface Feature #4179: create a standalone native launcher (Windows EXE and Linux/UNIX version) which can...
Roger Borrello wrote:
> To close out my thoughts (I have a doctor appointment shortly), if we do find @file:///@, we...
Sergey Ivanovskiy
09:46 AM User Interface Feature #4179: create a standalone native launcher (Windows EXE and Linux/UNIX version) which can...
Why are we messing with @file://@ in this task? The plan was to *always* use a @launcher://@ protocol for the launch... Greg Shah
09:43 AM User Interface Feature #4179: create a standalone native launcher (Windows EXE and Linux/UNIX version) which can...
To close out my thoughts (I have a doctor appointment shortly), if we do find @file:///@, we can proceed as if the re... Roger Borrello
09:40 AM User Interface Feature #4179: create a standalone native launcher (Windows EXE and Linux/UNIX version) which can...
As to what that means to our code, if we agree on the "file://" prefix... we have to further decide if there is or is... Roger Borrello
09:38 AM User Interface Feature #4179: create a standalone native launcher (Windows EXE and Linux/UNIX version) which can...
Sergey Ivanovskiy wrote:
> For an example, this url throws exception @new URL("file://" + "C:\\tmp\\name.txt");@ but...
Roger Borrello
09:10 AM User Interface Feature #4179: create a standalone native launcher (Windows EXE and Linux/UNIX version) which can...
For an example, this url throws exception @new URL("file://" + "C:\\tmp\\name.txt");@ but this one is correct... Sergey Ivanovskiy
09:01 AM User Interface Feature #4179: create a standalone native launcher (Windows EXE and Linux/UNIX version) which can...
These changes are not correct because @file:///@ is important for local files. Please look at https://en.wikipedia.or... Sergey Ivanovskiy
08:18 AM User Interface Feature #4179: create a standalone native launcher (Windows EXE and Linux/UNIX version) which can...
Sergey, take a look at this update I propose for @UiUtils@:... Roger Borrello
04:46 PM Base Language Support #5120: Date/Datetime - from iso
Greg Shah wrote:
> OK, defer the work. Please create a task for it.
Added #5201.
Marian: can you take a look at...
Constantin Asofiei
04:45 PM Base Language Bug #5201: fix issues related to the error messages reported for invalid date/datetime/datetime-t...
From #5120-7:
> ... rev 1010 of the xfer testcases project contains a set of tests of how literals are parsed as d...
Constantin Asofiei
04:43 PM Base Language Bug #5201 (New): fix issues related to the error messages reported for invalid date/datetime/date...
Constantin Asofiei
04:40 PM User Interface Bug #5118: TREELIST widget issues
An issue from #4908-4:
By pressing and releasing left and right mouse buttons while dragging a tree column heade...
Vladimir Tsichevski
03:00 PM Database Feature #1587: implement full support for word indexes
* Re-worked implicit ordering to be compatible with one for @CONTAINS@ with UDF described in #1587-423
* Refactored ...
Igor Skornyakov
03:29 AM Database Feature #1587: implement full support for word indexes
Eric Faulhaber wrote:
> One question: for a given record, is there any efficiency/performance difference evaluating ...
Igor Skornyakov
01:35 PM Database Bug #5176: Buffer field attribute leak
Eric Faulhaber wrote:
> Code review 3821c/12108:
> Generally, the changes look good to me, though the change was so...
Ovidiu Maxiniuc
10:42 AM Base Language Support #5200 (Closed): Database access issue
Marian Edu wrote:
> Did a @deploy.all@ and that seems to be recreated the database, all good now... hmm, maybe one...
Eric Faulhaber
10:25 AM Base Language Support #5200: Database access issue
Eric Faulhaber wrote:
> Is @CUSTOMER@ a persistent table or a temp-table?
>
> If persistent, what is the size of ...
Marian Edu
10:16 AM Base Language Support #5200: Database access issue
Eric Faulhaber wrote:
> Is @CUSTOMER@ a persistent table or a temp-table?
>
> If persistent, what is the size of ...
Marian Edu
10:06 AM Base Language Support #5200: Database access issue
Is @CUSTOMER@ a persistent table or a temp-table?
If persistent, what is the size of your database file (@deploy/d...
Eric Faulhaber
09:37 AM Base Language Support #5200: Database access issue
I'm having issues with accessing the 'fwd' database in one test, the database seems to be setup to use H2 and I don't... Marian Edu
09:36 AM Base Language Support #5200 (Closed): Database access issue
Marian Edu
09:21 AM Base Language Support #5199 (Closed): decimal - get value
Greg Shah
08:43 AM Base Language Support #5199: decimal - get value
Constantin Asofiei wrote:
> There is the @decimal.toBigDecimal()@ if you want to get the @BigDecimal@ instance.
T...
Marian Edu
07:29 AM Base Language Support #5199: decimal - get value
There is the @decimal.toBigDecimal()@ if you want to get the @BigDecimal@ instance. Constantin Asofiei
03:28 AM Base Language Support #5199: decimal - get value
Trying to get the JSON serialization as close as possible to the 4GL one I see for decimal data type the conversion i... Marian Edu
03:28 AM Base Language Support #5199 (Closed): decimal - get value
Marian Edu

03/14/2021

05:27 PM Database Feature #1587: implement full support for word indexes
Igor Skornyakov wrote:
> Hopefully is not not just a 'late night idea' ))
Well, it seems like an interesting on...
Eric Faulhaber
06:16 AM User Interface Feature #4179: create a standalone native launcher (Windows EXE and Linux/UNIX version) which can...
Sergey Ivanovskiy wrote:
> @UiUtils.resolveLocalFileResource(String uriString)@ doesn't throw malformed URL exceptio...
Sergey Ivanovskiy
05:26 AM User Interface Feature #4179: create a standalone native launcher (Windows EXE and Linux/UNIX version) which can...
Roger Borrello wrote:
> Greg Shah wrote:
> > At this point, we are going with our own @launcher://@ protocol for sp...
Sergey Ivanovskiy

03/13/2021

12:08 PM Testing Feature #1888: integrate the framework into the build
Greg Shah wrote:
> I know and accept that this different from the standard Maven layout, but we already deviate. ...
Vladimir Tsichevski
11:22 AM Testing Feature #1888: integrate the framework into the build
Please put the test classes into the same package as the classes they test, but with a @test@ base directory instead ... Greg Shah

03/12/2021

06:50 PM User Interface Feature #4179: create a standalone native launcher (Windows EXE and Linux/UNIX version) which can...
> With respect to the OPEN-MIME-TYPE testcase and Swing, it also works "out of the box" using the file:// protocol
...
Greg Shah
06:28 PM User Interface Feature #4179: create a standalone native launcher (Windows EXE and Linux/UNIX version) which can...
Roger Borrello wrote:
> Greg Shah wrote:
> > At this point, we are going with our own @launcher://@ protocol for sp...
Greg Shah
05:07 PM User Interface Feature #4179: create a standalone native launcher (Windows EXE and Linux/UNIX version) which can...
With respect to the @OPEN-MIME-TYPE@ testcase and Swing, it also works "out of the box" using the @file://@ protocol,... Roger Borrello
03:49 PM User Interface Feature #4179: create a standalone native launcher (Windows EXE and Linux/UNIX version) which can...
Greg Shah wrote:
> At this point, we are going with our own @launcher://@ protocol for specifying the resource to lo...
Roger Borrello
12:31 PM User Interface Feature #4179: create a standalone native launcher (Windows EXE and Linux/UNIX version) which can...
It was @msys@. I'm not sure where that comes into play, but when I don't include @c:\msys\bin@ in the path, everythin... Roger Borrello
11:52 AM User Interface Feature #4179: create a standalone native launcher (Windows EXE and Linux/UNIX version) which can...
Greg Shah wrote:
> See @.bzrignore@.
Thanks.
With respect to @library.c@ and the non-declaration, I'll have to d...
Roger Borrello
08:56 AM User Interface Feature #4179: create a standalone native launcher (Windows EXE and Linux/UNIX version) which can...
See @.bzrignore@. Greg Shah
08:49 AM User Interface Feature #4179: create a standalone native launcher (Windows EXE and Linux/UNIX version) which can...
Greg Shah wrote:
> I assume you are fixing them.
With respect to the Java header, which is what triggered a rebui...
Roger Borrello
07:49 AM User Interface Feature #4179: create a standalone native launcher (Windows EXE and Linux/UNIX version) which can...
At this point, we are going with our own @launcher://@ protocol for specifying the resource to load?
If so, then I...
Greg Shah
07:44 AM User Interface Feature #4179: create a standalone native launcher (Windows EXE and Linux/UNIX version) which can...
> because there were warnings/errors in memory.c and library.c
I assume you are fixing them.
Greg Shah
07:44 AM User Interface Feature #4179: create a standalone native launcher (Windows EXE and Linux/UNIX version) which can...
Code Review Task Branch 3821c Revision 12113
The changes are good.
Greg Shah
05:36 PM Database Feature #1587: implement full support for word indexes
BTW. I've just realized that it is possible to add a 'natural' implicit ordering to the queries using the @CONTAINS@ ... Igor Skornyakov
02:27 PM Database Feature #1587: implement full support for word indexes
I'm ok with using GUIDs. Eric Faulhaber
02:25 PM Database Feature #1587: implement full support for word indexes
Greg Shah wrote:
> Do dynamic temp-tables have names?
Yes, they are referenced in subsequent dynamic queries by n...
Eric Faulhaber
02:20 PM Database Feature #1587: implement full support for word indexes
Greg Shah wrote:
> Do dynamic temp-tables have names?
If they are in the H2 database they should have at least so...
Igor Skornyakov
02:16 PM Database Feature #1587: implement full support for word indexes
Do dynamic temp-tables have names? Greg Shah
02:10 PM Database Feature #1587: implement full support for word indexes
Eric Faulhaber wrote:
> Igor Skornyakov wrote:
> When you say "ensure that data objects created for word tables are...
Igor Skornyakov
02:09 PM Database Feature #1587: implement full support for word indexes
Some google searches suggest '@@@' is a valid character in an SQL table name, but not in a 4GL table name. This will ... Eric Faulhaber
01:59 PM Database Feature #1587: implement full support for word indexes
Igor Skornyakov wrote:
> Another question. I need to ensure that data objects created for word tables are unique, ev...
Eric Faulhaber
01:45 PM Database Feature #1587: implement full support for word indexes
Eric Faulhaber wrote:
> Yes, the dirty database should work properly with extent fields, if we go with the UDF appro...
Igor Skornyakov
01:42 PM Database Feature #1587: implement full support for word indexes
Igor Skornyakov wrote:
> So I have to add a check for @isDirty@ and do not re-write the query for the 'dirty' data...
Eric Faulhaber
01:32 PM Database Feature #1587: implement full support for word indexes
Eric Faulhaber wrote:
> Igor Skornyakov wrote:
> > What is 'dirty' database and should I consider such databases fo...
Igor Skornyakov
01:22 PM Database Feature #1587: implement full support for word indexes
Igor Skornyakov wrote:
> What is 'dirty' database and should I consider such databases for the word tables support?
...
Eric Faulhaber
05:28 AM Database Feature #1587: implement full support for word indexes
Another question. I need to ensure that data objects created for word tables are unique, even in the scope of a sessi... Igor Skornyakov
05:19 AM Database Feature #1587: implement full support for word indexes
Sorry for my ignorance. What is 'dirty' database and should I consider such databases for the word tables support?
T...
Igor Skornyakov
04:41 PM Testing Feature #1888: integrate the framework into the build
Hynek Cihlar wrote:
> You will need to add dependency on JUnit 5 including @junit-platform-console-standalone@.
>...
Vladimir Tsichevski
04:17 PM Database Bug #5056 (Closed): Temp-tables and unique indexes
Eric Faulhaber
04:00 PM Database Bug #5056: Temp-tables and unique indexes
The validation works correctly for temp-tables now. It does not really make sense why OE shows error 132 multiple tim... Ovidiu Maxiniuc
11:39 AM Database Bug #5176: Buffer field attribute leak
Code review 3821c/12108:
Generally, the changes look good to me, though the change was so dense in @TableMapper@, ...
Eric Faulhaber
09:33 AM Base Language Bug #5194: Stream handle - type missing, not deletable
As a side note when serializing JSON data to a stream the 4GL does not close the stream, however the data is being fl... Marian Edu
03:57 AM Base Language Bug #5194: Stream handle - type missing, not deletable
There are some issues with a stream handle, first it does not support @type@ property - trying to access it eventuall... Marian Edu
03:57 AM Base Language Bug #5194 (New): Stream handle - type missing, not deletable
Marian Edu

03/11/2021

06:58 PM User Interface Feature #4179: create a standalone native launcher (Windows EXE and Linux/UNIX version) which can...
See @12113@ for updates.
Also, it must have been some time since @ant-native@ was built on 32-bit, because there w...
Roger Borrello
10:35 AM User Interface Feature #4179: create a standalone native launcher (Windows EXE and Linux/UNIX version) which can...
Code Review Task Branch 3821c Revision 12111
This is much better.
1. I don't think that @desktop.h@ should have...
Greg Shah
09:35 AM User Interface Feature #4179: create a standalone native launcher (Windows EXE and Linux/UNIX version) which can...
Please review rev 12111. Right now the @fwd_local_launcher.c@ is a little bit "hokey", but until I get the connective... Roger Borrello
07:23 AM User Interface Feature #4179: create a standalone native launcher (Windows EXE and Linux/UNIX version) which can...
Search for @javah@ in @build.xml@. Greg Shah
06:21 AM User Interface Feature #4179: create a standalone native launcher (Windows EXE and Linux/UNIX version) which can...
With respect to the JNI and the makefile, the @JNIHEADER@ macro includes generated headers. How are those generated, ... Roger Borrello
02:41 PM Database Feature #1587: implement full support for word indexes
Eric Faulhaber wrote:
> Just saw this in the H2 mailing list, FWIW. Noel is one of the main contributors to the proj...
Igor Skornyakov
02:30 PM Database Feature #1587: implement full support for word indexes
Just saw this in the H2 mailing list, FWIW. Noel is one of the main contributors to the project. The OP was reporting... Eric Faulhaber
10:10 AM Base Language Bug #5192 (Hold): OO Quirk - Json Number with exponent
Greg Shah
10:08 AM Base Language Bug #5192: OO Quirk - Json Number with exponent
> we can implement it right in FWD and let all those numeric get methods parse the actual number instead of throwing ... Greg Shah
08:55 AM Base Language Bug #5192: OO Quirk - Json Number with exponent
Although numbers with exponents are supported to some extent in 4GL implementation those are not really parsed, one c... Marian Edu
08:45 AM Base Language Bug #5192 (Hold): OO Quirk - Json Number with exponent
Marian Edu
07:49 AM Database Bug #5121: Converted temp table should be using the legacy name instead of the converted name in ...
Eric Faulhaber wrote:
> Ovidiu, can you think of an efficient way to give access to @SharedVariableManager.lookupTem...
Ovidiu Maxiniuc
09:22 PM Database Bug #5121: Converted temp table should be using the legacy name instead of the converted name in ...
Roger Borrello wrote:
> Greg Shah wrote:
> > I think the legacy name can be found in @expected@. It is the DMO we ...
Eric Faulhaber

03/10/2021

04:28 PM Base Language Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...
The testcases are very good, thank you. The behavior is indeed just like tables/table-handles except for the interes... Greg Shah
02:25 AM Base Language Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...
Greg Shah wrote:
> > I have a set of testcases in our old/crappy testcase repo. I will check them in to the new/hotn...
Marian Edu
04:27 PM Database Bug #5176 (WIP): Buffer field attribute leak
I committed the fix in 3821c as revision 12108. The update is a aggregate, it contains fixes for other smaller issues... Ovidiu Maxiniuc
04:08 PM Database Bug #5121: Converted temp table should be using the legacy name instead of the converted name in ...
Eric? Greg Shah
03:51 PM Database Bug #5121: Converted temp table should be using the legacy name instead of the converted name in ...
Greg Shah wrote:
> I think the legacy name can be found in @expected@. It is the DMO we are searching for, which in...
Roger Borrello
01:17 PM Database Bug #5121: Converted temp table should be using the legacy name instead of the converted name in ...
I think the legacy name can be found in @expected@. It is the DMO we are searching for, which inherently maps 1-to-1... Greg Shah
12:02 PM Database Bug #5121: Converted temp table should be using the legacy name instead of the converted name in ...
At this point in processing I don't think we know the legacy name (since we haven't found it).
From @SharedVariabl...
Roger Borrello
01:44 PM Database Bug #4173 (Closed): BUFFER-COPY/BUFFER-COMPARE compares table fields by name rather than data typ...
Greg Shah
01:29 PM Database Bug #4173 (WIP): BUFFER-COPY/BUFFER-COMPARE compares table fields by name rather than data type a...
This can be closed; the premises in #4173 are not accurate as there is a difference in implementation between @bufer-... Adrian Lungu
11:01 AM Database Bug #4173: BUFFER-COPY/BUFFER-COMPARE compares table fields by name rather than data type and order
Is this still an open issue? Greg Shah
01:42 PM Database Feature #3958 (Closed): BUFFER-COPY optimization
Greg Shah
01:22 PM Database Feature #3958: BUFFER-COPY optimization
This can be closed; the BUFFER-COPY implementation reached all the optimizations proposed here. Adrian Lungu
11:00 AM Database Feature #3958: BUFFER-COPY optimization
What is left to do on this task? Greg Shah
01:26 PM Database Feature #4011: database/persistence layer performance improvements
We have the idea in #4011-774 implemented as @DmoSignature@. Adrian Lungu
11:01 AM Database Feature #4011: database/persistence layer performance improvements
Is #4011-774 complete? Greg Shah
01:19 PM Database Feature #4055: optimize temp-table output parameter copying
#4055-63 keeps track of the things left to do. The opened ones are still some possible directions, which were explore... Adrian Lungu
10:59 AM Database Feature #4055: optimize temp-table output parameter copying
What is left to do on this task? Greg Shah
11:21 AM Database Feature #1587: implement full support for word indexes
The final logic for implicit sorting appeared to be more tricky than I've described initially. In particular, a situa... Igor Skornyakov
08:27 AM User Interface Bug #4826 (Closed): HTTP 413 error with Web Client
Greg Shah
05:13 AM User Interface Bug #4826: HTTP 413 error with Web Client
Sergey Ivanovskiy wrote:
> I changed this condition @if (key.substring(0, 4).toLowerCase() = = "auth-")@ to @if (key...
Hynek Cihlar
05:13 AM User Interface Bug #4826: HTTP 413 error with Web Client
Sergey Ivanovskiy wrote:
> It seems that @substring(indexStart, indexEnd)@ is safe and doesn't throw index out of bo...
Hynek Cihlar
04:07 AM User Interface Bug #4826: HTTP 413 error with Web Client
The ECMA 262 specification https://tc39.es/ecma262/#sec-string.prototype.substring also states the same specification... Sergey Ivanovskiy
04:04 AM User Interface Bug #4826: HTTP 413 error with Web Client
I changed this condition @if (key.substring(0, 4).toLowerCase() = = "auth-")@ to @if (key.substring(0, 5).toLowerCase... Sergey Ivanovskiy
04:01 AM User Interface Bug #4826: HTTP 413 error with Web Client
It seems that @substring(indexStart, indexEnd)@ is safe and doesn't throw index out of bound exception. MDN said that... Sergey Ivanovskiy
07:44 AM Base Language Feature #4965: Parameter annotation - qualified
Constantin Asofiei wrote:
> Marian, you mean a @return new progress.lang.object()@ will work in 4GL but will not wor...
Marian Edu
06:23 AM Base Language Feature #4965: Parameter annotation - qualified
Marian, you mean a @return new progress.lang.object()@ will work in 4GL but will not work in FWD? If yes, then this i... Constantin Asofiei
05:51 AM Base Language Feature #4965: Parameter annotation - qualified
Marian Edu wrote:
> Constantin Asofiei wrote:
> > Each object var definition should be declared outside the top-lev...
Marian Edu
02:14 AM Base Language Bug #4978: Static method call in base class
Greg Shah wrote:
> > @o:foo()@ produces a compile error when called from @Extension@ because @o@ is @Base@ and @foo(...
Marian Edu
10:18 PM User Interface Feature #4179 (WIP): create a standalone native launcher (Windows EXE and Linux/UNIX version) whi...
Roger Borrello
08:24 PM User Interface Feature #4179: create a standalone native launcher (Windows EXE and Linux/UNIX version) which can...
> and break it down into parts to be "launched".
I don't think this is correct. @OPEN-MIME-RESOURCE@ just sends t...
Greg Shah

03/09/2021

05:59 PM User Interface Feature #4179: create a standalone native launcher (Windows EXE and Linux/UNIX version) which can...
Greg Shah wrote:
> I think this code is very GUI specific. Please put it in @com.goldencode.p2j.ui.client.gui@ and ...
Roger Borrello
04:27 PM User Interface Feature #4179: create a standalone native launcher (Windows EXE and Linux/UNIX version) which can...
I think this code is very GUI specific. Please put it in @com.goldencode.p2j.ui.client.gui@ and change the @shellOpe... Greg Shah
03:46 PM User Interface Feature #4179: create a standalone native launcher (Windows EXE and Linux/UNIX version) which can...
Right now the JNI is in @com.goldencode.p2j.util@ and the method is @Java_com_goldencode_p2j_util_shellOpenFile@. Is ... Roger Borrello
05:25 PM User Interface Bug #4826: HTTP 413 error with Web Client
Sergey Ivanovskiy wrote:
> Yes, I didn't observe that cookies with these keys "renderer" and "graphicsCached" should...
Hynek Cihlar
11:34 AM User Interface Bug #4826: HTTP 413 error with Web Client
Yes, I didn't observe that cookies with these keys "renderer" and "graphicsCached" should be persistent. These change... Sergey Ivanovskiy
07:51 AM User Interface Bug #4826: HTTP 413 error with Web Client
Sergey Ivanovskiy wrote:
> Does it make sense to implement the server side solution by setting response header @Clea...
Hynek Cihlar
07:27 AM User Interface Bug #4826 (WIP): HTTP 413 error with Web Client
Please review the committed revision 12095 (3821c) that should clear authorization token cookies if the application p... Sergey Ivanovskiy
05:04 PM Database Feature #1587: implement full support for word indexes
Ovidiu Maxiniuc wrote:
> These two classes are really specialised:
> * the @DDLGeneratorWorker@ is used by static c...
Igor Skornyakov
05:02 PM Database Feature #1587: implement full support for word indexes
Eric Faulhaber wrote:
> Not as such. The documentation on FWD internals is the least developed of the various books....
Igor Skornyakov
04:25 PM Database Feature #1587: implement full support for word indexes
These two classes are really specialised:
* the @DDLGeneratorWorker@ is used by static conversion to get DDLs for pe...
Ovidiu Maxiniuc
03:39 PM Database Feature #1587: implement full support for word indexes
Not as such. The documentation on FWD internals is the least developed of the various books.
The code which create...
Eric Faulhaber
03:15 PM Database Feature #1587: implement full support for word indexes
Eric Faulhaber wrote:
> OK, please post any questions you may have about the temp-table creation, DDL, etc. Ovidiu o...
Igor Skornyakov
03:07 PM Database Feature #1587: implement full support for word indexes
OK, please post any questions you may have about the temp-table creation, DDL, etc. Ovidiu or I will be able to get y... Eric Faulhaber
01:57 PM Database Feature #1587: implement full support for word indexes
Eric Faulhaber wrote:
> Igor Skornyakov wrote:
> Given that support for H2 already is implemented, what is the incr...
Igor Skornyakov
01:02 PM Database Feature #1587: implement full support for word indexes
Igor Skornyakov wrote:
> According to #1587-327, you wanted also to implement word tables for @_temp@ db.
Given...
Eric Faulhaber
11:58 AM Database Feature #1587: implement full support for word indexes
Eric Faulhaber wrote:
> Igor, other than finishing the sort implementation (and gauging its performance) and the 168...
Igor Skornyakov
11:50 AM Database Feature #1587: implement full support for word indexes
Igor, other than finishing the sort implementation (and gauging its performance) and the 1688 conversion warning, wha... Eric Faulhaber
02:48 AM Database Feature #1587: implement full support for word indexes
Eric Faulhaber wrote:
> W.r.t. the command line options, we don't want to use system properties long term. For any o...
Igor Skornyakov
02:44 PM Database Bug #5176: Buffer field attribute leak
I have really thought of this issue during last days.
The @DmoMeta@ carries immutable data, that is: information ...
Ovidiu Maxiniuc
11:53 AM Database Bug #5176: Buffer field attribute leak
Ovidiu, if every buffer has its own writable version of a certain set of attributes, does it make sense for each buff... Eric Faulhaber
11:47 AM Database Support #5183: database collation
Some additional research to consider:
*1.* Locales
A "locale":https://en.wikipedia.org/wiki/Locale_(computer_so...
Greg Shah
01:41 AM Base Language Bug #5035: Temp-Table index on P.L.O field
Greg Shah wrote:
> > is there a way to resolve an instance from its ID, an equivalent for handle function?
>
> Ma...
Marian Edu

03/08/2021

05:54 PM Database Feature #1587: implement full support for word indexes
Code review 3821c, rev 12079, 12089:
The logic changes look good to me. I have not tested them.
W.r.t. the comm...
Eric Faulhaber
03:35 AM Database Feature #1587: implement full support for word indexes
Eric Faulhaber wrote:
> Another question/concern: it seems like this approach requires the CTE. It follows that it w...
Igor Skornyakov
03:31 AM Database Feature #1587: implement full support for word indexes
Eric Faulhaber wrote:
> In the absence of a BY clause, I don't know of any guaranteed ordering of the results of a q...
Igor Skornyakov
11:03 PM Database Feature #1587: implement full support for word indexes
Another question/concern: it seems like this approach requires the CTE. It follows that it would disrupt your more pe... Eric Faulhaber
10:46 PM Database Feature #1587: implement full support for word indexes
This is a very interesting proposal, and I appreciate the creativity in coming up with it.
In the absence of a BY ...
Eric Faulhaber
01:35 PM Base Language Bug #4978: Static method call in base class
Another reason it is not often seen is the use of @super@ in the child class as the reference to call overridden pare... Greg Shah
01:31 PM Base Language Bug #4978: Static method call in base class
Interesting. I had not run across that restriction before. I guess the package visibility rules limit the cases whe... Greg Shah
12:57 PM Base Language Bug #4978: Static method call in base class
Greg Shah wrote:
> I just find it surprising that the 4GL does not allow child classes to access protected methods i...
Constantin Asofiei
12:47 PM Base Language Bug #4978: Static method call in base class
> @o:foo()@ produces a compile error when called from @Extension@ because @o@ is @Base@ and @foo()@ is protected.
...
Greg Shah
11:11 AM Runtime Infrastructure Feature #5170: add support for cloud-based load balancing and WAF
If @WebHandler@ handles and delegates all web requests, then it needs to add the corresponding server host to the Apa... Sergey Ivanovskiy
07:34 AM Runtime Infrastructure Feature #5170: add support for cloud-based load balancing and WAF
> I didn't test this solution when there are two or more identical Apache web servers running in AWS.
I don't know...
Greg Shah
02:45 AM Runtime Infrastructure Feature #5170: add support for cloud-based load balancing and WAF
#2683 only implemented the custom reverse proxy support for the web clients with help of the Apache web server runnin... Sergey Ivanovskiy
10:02 AM Base Language Support #5120: Date/Datetime - from iso
These tests have OO 4GL code usage. You must checkout the "skeletons":/projects/p2j/wiki/Object_Oriented_Classes_and... Greg Shah
08:41 AM Base Language Support #5120: Date/Datetime - from iso
Constantin Asofiei wrote:
> Greg Shah wrote:
> > Vladimir is making changes to the date parsing in #4880. Are the ...
Vladimir Tsichevski
07:21 AM Base Language Bug #5035: Temp-Table index on P.L.O field
> if this is an issue in FWD is not because the ID's are incremental or random but with the fact that the actual (int... Greg Shah
06:52 AM Base Language Bug #5035: Temp-Table index on P.L.O field
Greg Shah wrote:
> Code Review Task Branch 3821c Revision 12088
> The changes are OK for me.
> Ovidiu: If you are ...
Ovidiu Maxiniuc
05:35 AM Base Language Bug #5035: Temp-Table index on P.L.O field
Greg Shah wrote:
>
> This is a real issue. The embedded mode web client includes a kind of javascript appserver f...
Marian Edu
07:15 AM Runtime Infrastructure Support #4086: review the RemoteObject exports in StandardServer and other common runtime classes...
Please check all external API mechanisms (appserver replacement, webspeed/web handler, REST, SOAP and the embedded dr... Greg Shah
07:09 AM Testing Feature #1887 (Closed): research unit testing frameworks and make an appropriate selection
Both Hynek and Vladimir have voiced their preference for JUnit. I have no specific requirements that suggest TestNG ... Greg Shah

03/07/2021

11:35 AM Base Language Support #5120: Date/Datetime - from iso
OK, defer the work. Please create a task for it. Greg Shah
10:57 AM Base Language Support #5120: Date/Datetime - from iso
Greg Shah wrote:
> Vladimir is making changes to the date parsing in #4880. Are the issues overlapping?
I think #4...
Constantin Asofiei
10:51 AM Base Language Support #5120: Date/Datetime - from iso
Vladimir is making changes to the date parsing in #4880. Are the issues overlapping?
Are the tests broken because...
Greg Shah
10:23 AM Base Language Support #5120: Date/Datetime - from iso
There are some differences in the error messages/codes reported by FWD in case of invalid literals, but the functiona... Constantin Asofiei
10:17 AM Base Language Support #5120: Date/Datetime - from iso
What is left to do on this task? Greg Shah
10:57 AM Database Feature #1587: implement full support for word indexes
I doubt that it is possible to implement an implicit ordering imposed by @CONTAINS@ which is 100% compatible with 4GL... Igor Skornyakov
10:25 AM Database Feature #1587: implement full support for word indexes
I've created the following test to analyze the implicit sorting imposed by @CONTAINS@ (see @testcases/words/words-ord... Igor Skornyakov
10:34 AM Base Language Bug #4978: Static method call in base class
See attached for the tests I used.
@o:foo()@ produces a compile error when called from @Extension@ because @o@ is ...
Constantin Asofiei
10:07 AM Base Language Bug #4978: Static method call in base class
As part of the changes for #4350, I'm switching the @exactMethodLookup()@ to use @candidates()@ for making a list of ... Greg Shah
09:13 AM Base Language Bug #5035 (Test): Temp-Table index on P.L.O field
Greg Shah

03/06/2021

02:41 PM Database Feature #1587: implement full support for word indexes
The problem with ... Igor Skornyakov
08:21 AM Database Feature #1587: implement full support for word indexes
Added CNF ordering (see #1576-386).
Committed to 3821c/12089
Igor Skornyakov
05:10 AM Database Feature #1587: implement full support for word indexes
I understand that the order of terms in the @CONTAINS@@ expression is important for implicit sorting. So I'm going to... Igor Skornyakov
01:35 PM Runtime Infrastructure Feature #5170: add support for cloud-based load balancing and WAF
Sergey: From your perspective (as the person that added reverse proxy support for the web client), what is needed for... Greg Shah
01:29 PM Base Language Bug #5035: Temp-Table index on P.L.O field
Greg Shah wrote:
> Constantin: Is there anything else to do here?
No.
Constantin Asofiei
10:41 AM Base Language Bug #5035: Temp-Table index on P.L.O field
Code Review Task Branch 3821c Revision 12088
The changes are OK for me.
Ovidiu: If you are OK with the persiste...
Greg Shah
07:29 AM Base Language Bug #5035 (WIP): Temp-Table index on P.L.O field
The changes are in 3821c rev 12088.
Ovidiu: please review.
Constantin Asofiei
01:29 PM Runtime Infrastructure Feature #5184: enable non-SSL mode for Jetty
We don't recommend *ever* using anything except SSL. This includes the scenario where the systems are only running o... Greg Shah
01:21 PM Runtime Infrastructure Feature #5184 (New): enable non-SSL mode for Jetty
Greg Shah
12:54 PM User Interface Feature #4179: create a standalone native launcher (Windows EXE and Linux/UNIX version) which can...
Code Review Task Branch 3821c Revision 12090
It is a good start.
1. As mentioned in #4179-14, we need to assume...
Greg Shah
11:33 AM User Interface Feature #4179: create a standalone native launcher (Windows EXE and Linux/UNIX version) which can...
I'm not sure what you mean by "mime-type helper". Are you referring to the launcher that will be registered as an ap... Greg Shah
11:30 AM User Interface Feature #4179: create a standalone native launcher (Windows EXE and Linux/UNIX version) which can...
Committed @fwd_local_launcher.c@ in @3821c_12090@ which utilizes @xdg-open@.
While the code can accept parameters,...
Roger Borrello
10:56 AM User Interface Feature #4179: create a standalone native launcher (Windows EXE and Linux/UNIX version) which can...
In trying to understand how to register an application helper for our mime-type helper, I was confused by whether or ... Roger Borrello
11:24 AM Database Support #5183: database collation
In the "Internationalize ABL Application" docs there are good details about codepages and all the character configura... Greg Shah
10:17 AM Base Language Bug #4749: Conversion error for object indeterminate extent output parameter
Code Review Task Branch 3821c Revision 12087
The changes are good.
Greg Shah
08:01 AM Base Language Bug #4749: Conversion error for object indeterminate extent output parameter
Greg Shah wrote:
> Please add javadoc to @ArrayAssigner.register(BaseDataType[] array)@ and @ArrayAssigner.registerD...
Constantin Asofiei

03/05/2021

05:17 PM Database Support #5183: database collation
The attached program (@cp_coll.p@) was written as a starting point to review the 4GL's collation, inspired by the exi... Eric Faulhaber
05:05 PM Database Support #5183: database collation
A review of how FWD collates its database data has raised some questions as to whether we are doing it correctly for ... Eric Faulhaber
05:00 PM Database Support #5183 (WIP): database collation
Eric Faulhaber
04:05 PM Base Language Bug #5035: Temp-Table index on P.L.O field
> I haven't touched com-handle field, I assume this is also mapped as Long in 4GL, but its weird to test in FWD. And ... Greg Shah
03:13 PM Base Language Bug #5035: Temp-Table index on P.L.O field
I've switched both handle and object fields to Long and incremental value. There are two more issues to check, unkn... Constantin Asofiei
11:41 AM Base Language Bug #5035: Temp-Table index on P.L.O field
> anyone can walk through session first object/handle and use next-sibling to get access to everything
Yes, this i...
Greg Shah
11:07 AM Base Language Bug #5035: Temp-Table index on P.L.O field
I find this illusion of security kinda funny, random or incremental is exactly the same in a single threaded environm... Marian Edu
10:33 AM Base Language Bug #5035: Temp-Table index on P.L.O field
Greg Shah wrote:
> I understand it is more secure but does it break any existing 4GL behavior?
Only in cases of w...
Constantin Asofiei
09:59 AM Base Language Bug #5035: Temp-Table index on P.L.O field
> The major reason why the resource ID for the persistent procedures/handles/etc needs to be random is because you ca... Greg Shah
09:43 AM Base Language Bug #5035: Temp-Table index on P.L.O field
Greg Shah wrote:
> This seems reasonable. Do I understand correctly that the internal representation will never be ...
Constantin Asofiei
08:42 AM Base Language Bug #5035: Temp-Table index on P.L.O field
> I have the changes to move the object ID to a long, incrementing value. This will be used by the toString and temp-... Greg Shah
05:18 AM Base Language Bug #5035: Temp-Table index on P.L.O field
I have the changes to move the object ID to a long, incrementing value. This will be used by the toString and temp-t... Constantin Asofiei
02:10 PM Runtime Infrastructure Feature #4405: provide the capability to deliver static HTML and resources via the FWD server's J...
We need to handle this sooner rather than later.
Hynek: What would you estimate is the effort for this?
Greg Shah
07:36 AM Base Language Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> Marian, the signature for @JsonArray:read@ as documented at https://docs.progress.com/bu...
Marian Edu
06:30 AM Base Language Feature #4384: Builtin OO Implementation
I have a fix for the @jsonarray:read(handle)@ case - the conversion rules will emit the TableParameter for builtin OO... Constantin Asofiei
05:39 AM Base Language Feature #4384: Builtin OO Implementation
Marian, the signature for @JsonArray:read@ as documented at https://docs.progress.com/bundle/openedge-abl-reference-1... Constantin Asofiei
04:31 AM Base Language Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> Constantin Asofiei wrote:
> > @bzr merge@ is not working. Please unbind your skeleton project,...
Constantin Asofiei
04:16 AM Base Language Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> @bzr merge@ is not working. Please unbind your skeleton project, bind to the xfer proje...
Marian Edu
04:03 AM Base Language Feature #4384: Builtin OO Implementation
@bzr merge@ is not working. Please unbind your skeleton project, bind to the xfer project, run @bzr update@ and afte... Constantin Asofiei
03:58 AM Base Language Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> Marian, please use the skeleton checkout from xfer, @/opt/fwd/skeleton@ to create the pa...
Marian Edu
03:34 AM Base Language Feature #4384: Builtin OO Implementation
Marian, please use the skeleton checkout from xfer, @/opt/fwd/skeleton@ to create the patch. That is at revision 99. Constantin Asofiei
02:04 AM Base Language Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> Marian, you've made some changes to JsonConstruct and the read(TableParameter) method is...
Marian Edu
01:54 AM User Interface Feature #4179: create a standalone native launcher (Windows EXE and Linux/UNIX version) which can...
I did see information indicating that Chrome uses whatever the desktop's mime database contains. I don't know if ther... Roger Borrello
07:22 PM Base Language Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...
> I have a set of testcases in our old/crappy testcase repo. I will check them in to the new/hotness testcases repo. ... Greg Shah

03/04/2021

04:30 PM Base Language Feature #4384: Builtin OO Implementation
Marian, you've made some changes to JsonConstruct and the read(TableParameter) method is now gone.
This code no lo...
Constantin Asofiei
02:14 PM Base Language Support #5120: Date/Datetime - from iso
The changes are in 3821c rev 12081.
Also, rev 1010 of the xfer testcases project contains a set of tests of how li...
Constantin Asofiei
11:48 AM Testing Feature #1888: integrate the framework into the build
Vladimir Tsichevski wrote:
> Hynek Cihlar wrote:
>
> > Create a simple Gradle java target and run @ConsoleLaunche...
Hynek Cihlar
11:10 AM Testing Feature #1888: integrate the framework into the build
Hynek Cihlar wrote:
> Create a simple Gradle java target and run @ConsoleLauncher@ class from JUnit 5.
I am not...
Vladimir Tsichevski
11:01 AM Testing Feature #1888: integrate the framework into the build
Vladimir Tsichevski wrote:
> BTW is there a reason such a mix of ant and gradle was created instead of using gradle ...
Hynek Cihlar
11:00 AM Testing Feature #1888: integrate the framework into the build
We started the project in 2004 with @ant@. We only shifted to Gradle in 2017. At that time we decided to add depend... Greg Shah
10:59 AM Testing Feature #1888: integrate the framework into the build
Vladimir Tsichevski wrote:
> The reason I did this in a project other than FWD so far is I failed to add tests into ...
Hynek Cihlar
10:50 AM Testing Feature #1888: integrate the framework into the build
BTW is there a reason such a mix of ant and gradle was created instead of using gradle only? Vladimir Tsichevski
10:48 AM Testing Feature #1888: integrate the framework into the build
The reason I did this in a project other than FWD so far is I failed to add tests into the FWD build process. The 'te... Vladimir Tsichevski
09:59 AM Testing Feature #1888: integrate the framework into the build
> Note: in this example FWD need to be build and installed in local Maven repository.
We deliberately picked Gradl...
Greg Shah
09:50 AM Testing Feature #1888 (WIP): integrate the framework into the build
It is quite easy to create a Gradle-based project with unit-test for FWD.
The only thing necessary to enable test ...
Vladimir Tsichevski
11:39 AM User Interface Bug #5178: Handle APPLY -2 in ChUI
4GL documentation states that "APPLY -2 is the same as APPLY ENDKEY". However, it was found that it works only in ChU... Stanislav Lomany
11:05 AM User Interface Bug #5178 (New): Handle APPLY -2 in ChUI
Stanislav Lomany
10:30 AM Base Language Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...
Marian Edu wrote:
> Greg Shah wrote:
> > > If you want I can go ahead and fill in the tests unless this is already ...
Greg Shah
08:02 AM Database Bug #5176: Buffer field attribute leak
My understanding is that in the 4GL every temp-table *instance* is a completely separate table. Multiple table insta... Greg Shah
08:10 PM Database Bug #5176: Buffer field attribute leak
I will try to summarize an ugly issue I am investigating lately.
I was working on a issue related to #3574-11 and ...
Ovidiu Maxiniuc
07:07 PM Database Bug #5176 (Closed): Buffer field attribute leak
Ovidiu Maxiniuc
06:29 AM Database Feature #1587: implement full support for word indexes
I've noticed that queries with @CONTAINS@ run faster with CTE when the expression is 'simple' (its CNF contains only ... Igor Skornyakov

03/03/2021

04:56 PM Conversion Tools Feature #5175 (New): add the value of the builtin preprocessor variables (like WINDOW-SYSTEM), us...
Constantin Asofiei
04:15 PM Testing Feature #1887: research unit testing frameworks and make an appropriate selection
The most obvious frameworks to consider are "JUnit":https://junit.org and "TestNG":https://testng.org/doc/.
+Compa...
Greg Shah
03:46 PM Database Feature #1587: implement full support for word indexes
Added SQL re-writing using common table expressions (WITH clause).
Committed to 3821c/12077.
For PostgreSQL, it i...
Igor Skornyakov
03:27 PM Base Language Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...
Greg Shah wrote:
> In other words, can you define the same dataset in 2 or more ways in source code?
Yes, you can ...
Ovidiu Maxiniuc
08:41 AM Base Language Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...
Greg Shah wrote:
> > If you want I can go ahead and fill in the tests unless this is already covered someplace else....
Marian Edu
08:23 AM Base Language Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...
> If you want I can go ahead and fill in the tests unless this is already covered someplace else.
How much work is...
Greg Shah
08:09 AM Base Language Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...
Greg Shah wrote:
> Marian/Ovidiu: Can you give me your best understanding of the answers to the above questions? ...
Marian Edu
07:32 AM Base Language Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...
In regard to dataset and dataset-handle parameters, I need some help.
* Based on the 4GL docs, these are described...
Greg Shah
12:30 AM Base Language Feature #5160: About cast() function support
I have same issues with regular methods and constructors. Even regular method got same error with output table parame... Deividas Varzgalys

03/02/2021

10:17 AM Runtime Infrastructure Feature #5170: add support for cloud-based load balancing and WAF
We need to enable FWD to be used behind a load balancer and "WAF":https://en.wikipedia.org/wiki/Web_application_firew... Greg Shah
10:11 AM Runtime Infrastructure Feature #5170 (New): add support for cloud-based load balancing and WAF
Greg Shah
08:09 AM Base Language Feature #5160: About cast() function support
Coincidentally, I am already working on this root cause in #4350. The problem is that we need to better handle metho... Greg Shah
07:40 AM Base Language Feature #5160: About cast() function support
test.p file.... Deividas Varzgalys
02:41 AM Database Feature #1587: implement full support for word indexes
Eric Faulhaber wrote:
> Well, it is extra work to add it in @HQLPreprocessor@ and I imagine there probably is some w...
Igor Skornyakov
08:08 PM User Interface Feature #4179: create a standalone native launcher (Windows EXE and Linux/UNIX version) which can...
Greg Shah wrote:
> In #4179-1 is this requirement: *which can be registered as a browser's application helper for th...
Roger Borrello
07:52 PM User Interface Feature #4179: create a standalone native launcher (Windows EXE and Linux/UNIX version) which can...
Regarding Linux, I came across @xdg-open@, which is part of @xdg-utils@:
https://wiki.archlinux.org/index.php/Xdg...
Roger Borrello

03/01/2021

05:59 PM Database Feature #1587: implement full support for word indexes
Well, it is extra work to add it in @HQLPreprocessor@ and I imagine there probably is some work to ignore it when gen... Eric Faulhaber
05:19 PM Database Feature #1587: implement full support for word indexes
Eric Faulhaber wrote:
> The RTRIM is injected for text property references by the @HQLPreprocessor@. It is needed fo...
Igor Skornyakov
05:09 PM Database Feature #1587: implement full support for word indexes
The RTRIM is injected for text property references by the @HQLPreprocessor@. It is needed for normal text property eq... Eric Faulhaber
04:44 PM Database Feature #1587: implement full support for word indexes
I've noticed some strange thing.
Consider the following 4GL code:...
Igor Skornyakov
09:59 AM Base Language Feature #5160: About cast() function support
Please post a standalone example so that we can recreate the problem here. Greg Shah
09:46 AM Base Language Feature #5160: About cast() function support
I just pasted "*" due to the data safety of current project source code names. This error occurs in filenames without... Deividas Varzgalys
05:28 AM Base Language Feature #4965: Parameter annotation - qualified
Please post a small test which shows this problem. The reference is decremented somewhere where it should not be. Constantin Asofiei
05:17 AM Base Language Feature #4965: Parameter annotation - qualified
Constantin Asofiei wrote:
> Each object var definition should be declared outside the top-level block (in the Java m...
Marian Edu
03:57 AM Base Language Feature #4965: Parameter annotation - qualified
Marian Edu wrote:
> This is part of the 'OO SDK' and as per your suggestion everything under @com.goldencode.p2j.oo@...
Constantin Asofiei
03:48 AM Base Language Feature #4965: Parameter annotation - qualified
Constantin Asofiei wrote:
> Also, I see lots of classes have @null@ as the referent in i.e. its @BlockManager.functi...
Marian Edu

02/26/2021

05:42 PM Database Bug #4994 (WIP): NPE in AdaptiveQuery when loading null data for an outer join
In case of OUTER JOIN tables when there is no matching record, @data[i]@ is @null@. Rewriting the problematic line as... Ovidiu Maxiniuc
02:47 PM Database Support #4550: eliminate the need to place the p2jspi.jar in the JVM extension directory
It is good to know that the bug is just a configuration issue. At a minimum we need to improve our documentation. F... Greg Shah
02:28 PM Database Support #4550: eliminate the need to place the p2jspi.jar in the JVM extension directory
Greg Shah wrote:
> If I understand correctly, the @p2jspi.jar @ is hard coded to the equivalent of the 4GL 8859-1.
...
Eric Faulhaber
07:53 AM Database Support #4550: eliminate the need to place the p2jspi.jar in the JVM extension directory
We also need to consider that the effective codepage for H2 temp-tables must be something that can be overridden. In... Greg Shah
02:36 PM User Interface Feature #4170 (Closed): add drag and drop support to treeview widget
> There is a known conversion issue that this code with a corresponding hint file
Please create a separate task fo...
Greg Shah
02:12 PM User Interface Feature #4170 (Review): add drag and drop support to treeview widget
Sergey Ivanovskiy
02:10 PM User Interface Feature #4170: add drag and drop support to treeview widget
Yes, the image list tests are working in general. There is a known conversion issue that this code with a correspondi... Sergey Ivanovskiy
01:10 PM User Interface Feature #4170: add drag and drop support to treeview widget
Please provide details as a separate task. Greg Shah
01:05 PM User Interface Feature #4170: add drag and drop support to treeview widget
Greg Shah wrote:
> Roger: I think you may have found some related behavior that seems wrong. Can you open a new tas...
Roger Borrello
08:39 AM User Interface Feature #4170: add drag and drop support to treeview widget
Can this task be put into Test mode?
Roger: I think you may have found some related behavior that seems wrong. Ca...
Greg Shah
09:43 AM Build and Source Control Bug #5166 (Closed): libp2j.so links to unpatched ncurses 6.2 instead of the patched ncurses 5.9
Alright, I'm closing this.
As an aside, we should probably work #5167 sooner rather than later.
Greg Shah
09:17 AM Build and Source Control Bug #5166: libp2j.so links to unpatched ncurses 6.2 instead of the patched ncurses 5.9
Yes, running deploy/server/server.sh starts without @undefined symbol: auto_getch_refresh@ in the server.log file Chris Weaver
09:14 AM Build and Source Control Bug #5166: libp2j.so links to unpatched ncurses 6.2 instead of the patched ncurses 5.9
With everything patched properly, I guess the client is starting now? Greg Shah
09:11 AM Build and Source Control Bug #5166: libp2j.so links to unpatched ncurses 6.2 instead of the patched ncurses 5.9
Followed the steps but have different results. If I look at the @ldd p2j/build/lib/libp2j.so@ output:
@linux-vdso....
Chris Weaver
08:05 AM Build and Source Control Support #5167: using static linking to eliminate the need to patch the system-wide ncurses
We would like to eliminate the need to patch the system-wide version of ncurses. #2660 is designed to do exactly tha... Greg Shah
08:02 AM Build and Source Control Support #5167 (Closed): using static linking to eliminate the need to patch the system-wide ncurses
Greg Shah
07:49 AM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
> Both of these dependencies could be specified as parameters to a new command line program
I don't understand why...
Greg Shah
06:21 AM User Interface Feature #4179: create a standalone native launcher (Windows EXE and Linux/UNIX version) which can...
In #4179-1 is this requirement: *which can be registered as a browser's application helper for the "application/fwd-l... Greg Shah
02:11 AM Database Bug #5056: Temp-tables and unique indexes
Can this issue be closed? Eric Faulhaber
07:51 PM Base Language Feature #4378: properly handle clob/lonchar assignment, especially the implicit codepage conversion
Actually the dereference operation pose other issues. The COPY-LOB is also not working correctly when a dereferenced ... Ovidiu Maxiniuc

02/25/2021

06:50 PM User Interface Feature #4179: create a standalone native launcher (Windows EXE and Linux/UNIX version) which can...
I made updates in revs @12060/12061@ to allow the build to proceed. How are the native parts deployed if you are simp... Roger Borrello
09:08 AM User Interface Feature #4179: create a standalone native launcher (Windows EXE and Linux/UNIX version) which can...
I removed the @launcher@ target to prevent the continuation of the failures found in #5034-317, which was created by ... Roger Borrello
06:17 PM Build and Source Control Bug #5166: libp2j.so links to unpatched ncurses 6.2 instead of the patched ncurses 5.9
Chris: Please try Roger's exact script and the 6.1 patches. His changes do cause the 6.1/6.2 version of the library ... Greg Shah
06:15 PM Build and Source Control Bug #5166: libp2j.so links to unpatched ncurses 6.2 instead of the patched ncurses 5.9
I've reviewed #3298 and have looked more carefully at "Patching NCURSES":/projects/p2j/wiki/Patching_NCURSES. I've m... Greg Shah
06:14 PM Build and Source Control Bug #5166: libp2j.so links to unpatched ncurses 6.2 instead of the patched ncurses 5.9
There are 6.1 patches from last July on that same "page":/projects/p2j/wiki/Patching_NCURSES#Obtain-the-Patches that ... Roger Borrello
05:56 PM Build and Source Control Bug #5166: libp2j.so links to unpatched ncurses 6.2 instead of the patched ncurses 5.9
I'm running Ubuntu 20.10. When I installed it in December 2020, I used the "Patching NCURSES":/projects/p2j/wiki/Pat... Greg Shah
04:39 PM Build and Source Control Bug #5166 (Closed): libp2j.so links to unpatched ncurses 6.2 instead of the patched ncurses 5.9
Greg Shah
03:07 PM Database Feature #1587: implement full support for word indexes
Eric Faulhaber wrote:
> A separate thought: what if we remove the @distinct@ keyword? Unless I'm reading the plan wr...
Igor Skornyakov
03:03 PM Database Feature #1587: implement full support for word indexes
I'm trying to figure out whether there is a way to express these search conditions without the hash joins (and someti... Eric Faulhaber
02:45 PM Database Feature #1587: implement full support for word indexes
Eric Faulhaber wrote:
> Thank you.
>
> Are these two statements functionally equivalent?
>
> 1)
>
> [...]
...
Igor Skornyakov
02:37 PM Database Feature #1587: implement full support for word indexes
As I re-read that last post, I'm not sure my where clause makes sense in that second query...rethinking... Eric Faulhaber
02:35 PM Database Feature #1587: implement full support for word indexes
Thank you.
Are these two statements functionally equivalent?
1)...
Eric Faulhaber
02:06 PM Database Feature #1587: implement full support for word indexes
Eric Faulhaber wrote:
> What is the SQL for the expression @"s0 | s1"@?
>
> For @"(s0 | s1) & s5*"@?
>
> (LE: ...
Igor Skornyakov
01:59 PM Database Feature #1587: implement full support for word indexes
What is the SQL for the expression @"s0 | s1"@?
For @"(s0 | s1) & s5*"@?
(LE: fixed syntax error in original post)
Eric Faulhaber
01:53 PM Database Feature #1587: implement full support for word indexes
Eric Faulhaber wrote:
> Igor, can't the first form of the SQL be simplified as follows?
> In other words, why is th...
Igor Skornyakov
01:39 PM Database Feature #1587: implement full support for word indexes
Igor, can't the first form of the SQL be simplified as follows?
From:...
Eric Faulhaber
11:02 AM Database Feature #1587: implement full support for word indexes
Eric Faulhaber wrote:
> Yes, I was looking at the sort part of the plan, but you are right that the parts below do l...
Igor Skornyakov
11:01 AM Database Feature #1587: implement full support for word indexes
Yes, I was looking at the sort part of the plan, but you are right that the parts below do look somewhat faster. Plea... Eric Faulhaber
10:54 AM Database Feature #1587: implement full support for word indexes
Eric Faulhaber wrote:
> Igor Skornyakov wrote:
>
> > At this moment I'm looking how to change SQL re-writing usin...
Igor Skornyakov
10:43 AM Database Feature #1587: implement full support for word indexes
Igor Skornyakov wrote:
> At this moment I'm looking how to change SQL re-writing using @WITH@ clause (see #1587-36...
Eric Faulhaber
10:30 AM Database Feature #1587: implement full support for word indexes
I've added two things to the word tables support.
# The re-writing of the SQL queries with @CONTAINS@ re-writing can...
Igor Skornyakov
04:27 AM Database Feature #1587: implement full support for word indexes
With a logically equivalent but different re-written SQL statement using @WITH@ clause:... Igor Skornyakov
03:46 AM Database Feature #1587: implement full support for word indexes
Adding index on the 'word' field in the word tables helps. The times are (see #1587-357)
|expr |records|e...
Igor Skornyakov
03:09 AM Database Feature #1587: implement full support for word indexes
Word tables' tests to @sftp://xfer.goldencode.com/opt/testcases/@ revision 1008.
Tests (including Java project for g...
Igor Skornyakov
02:07 AM Database Feature #1587: implement full support for word indexes
Eric Faulhaber wrote:
> Igor, is this test code (including the code which generates the test data) checked in?
No...
Igor Skornyakov
02:04 AM Database Feature #1587: implement full support for word indexes
Eric Faulhaber wrote:
> Igor, while the improvement over the UDF approach is considerable in some cases, the new app...
Igor Skornyakov
01:21 PM Database Bug #5056 (Test): Temp-tables and unique indexes
Patch committed as 3821c/12065. Eric Faulhaber
09:25 PM Database Bug #5056: Temp-tables and unique indexes
Eric Faulhaber wrote:
> Ovidiu, please test whether the attached patch resolves your original issue(s). It gets both...
Ovidiu Maxiniuc
09:42 AM Database Feature #5165: disallow usage of an incompatible database instance
We can also validate the schema specified at the permament DMOs with the database tables/indexes. Constantin Asofiei
05:48 AM Database Feature #5165: disallow usage of an incompatible database instance
In OE, the database metaschema has CRC values stored for each table, index and schema trigger. When compiling 4GL to... Greg Shah
05:08 AM Database Feature #5165 (New): disallow usage of an incompatible database instance
Greg Shah
04:32 AM Base Language Feature #4965 (Test): Parameter annotation - qualified
Greg Shah

02/24/2021

06:35 PM Database Feature #1587: implement full support for word indexes
Igor, is this test code (including the code which generates the test data) checked in? Eric Faulhaber
05:22 PM Database Feature #1587: implement full support for word indexes
Igor, while the improvement over the UDF approach is considerable in some cases, the new approach is still not as per... Eric Faulhaber
02:33 PM Database Feature #1587: implement full support for word indexes
For the performance testing, I've used a modified approach described at #1587-340. Instead of generated "word" as all... Igor Skornyakov
06:21 PM User Interface Feature #4179: create a standalone native launcher (Windows EXE and Linux/UNIX version) which can...
First pass committed in @3821c_12057@. There is an update to the native @makefile@ to use the new @makefile.launcher@... Roger Borrello
11:19 AM Base Language Feature #5160: About cast() function support
> ./abl/*.p:741:37: unexpected token: GetData
> ...
> 2.Error processing .*.p --- Caused by: java.lang.NullPointerE...
Greg Shah
11:08 AM Base Language Feature #5160: About cast() function support
> unexpected token: strict-entity-resolution
Correct, in your version of FWD we did not recognise this attribute a...
Greg Shah
08:43 AM Base Language Feature #4965: Parameter annotation - qualified
Marian Edu wrote:
> How should we proceed were, a new merge or just wait for the new 4384 branch and fix whatever ne...
Constantin Asofiei
07:55 AM Base Language Feature #4965: Parameter annotation - qualified
Constantin Asofiei wrote:
> Marian, there are some compile errors -
> [...]
>
> Is this a typo? Shouldn't each ...
Marian Edu
08:40 AM Base Language Bug #4749 (Test): Conversion error for object indeterminate extent output parameter
Code Review Task Branch 3821c Revision 12052
Overall, the changes are good.
Please add javadoc to @ArrayAssigne...
Greg Shah

02/23/2021

06:34 PM Database Bug #5056: Temp-tables and unique indexes
Similar to the patch proposed in #4884-15, I have fixed the cases identified above. The three main xfer testcases are... Ovidiu Maxiniuc
07:43 PM Database Bug #5056: Temp-tables and unique indexes
I found the cause for the 'regression' of your patch. It is probably not a single thing, but a couple of issues which... Ovidiu Maxiniuc
12:50 PM Base Language Feature #4384: Builtin OO Implementation
Branch 4384i was created from branch 3821c revision 12052.
Marian: please review revision 12051, it fixes some com...
Constantin Asofiei
12:45 PM Base Language Bug #4749: Conversion error for object indeterminate extent output parameter
Constantin Asofiei wrote:
> As for the dynamic array issues - the root cause was the fact that the Java reference fo...
Constantin Asofiei
12:21 PM Base Language Feature #4965: Parameter annotation - qualified
> Greg: I think we need a 4384i branch?
Yes. Please make one as soon as you are happy with the 3821c starting point.
Greg Shah
12:18 PM Base Language Feature #4965: Parameter annotation - qualified
Marian, there are some compile errors - ... Constantin Asofiei
12:12 PM Base Language Feature #4965: Parameter annotation - qualified
Constantin Asofiei wrote:
> Marian, 4384h on xfer is still on rev 12004 - although I think is a little old, is still...
Marian Edu
12:04 PM Base Language Feature #4965: Parameter annotation - qualified
Marian, 4384h on xfer is still on rev 12004 - although I think is a little old, is still good, because I could use it... Constantin Asofiei
02:46 AM Base Language Feature #4965: Parameter annotation - qualified
Greg Shah wrote:
> > I've pushed 3821c revision 12046 to xfer. Do you want to branch from that, apply your changes ...
Marian Edu
10:28 AM User Interface Feature #5151: Add complete support for tree-list OCX triggers
I can't tell if is is safe to presume a default value for direct - maybe the majority of node changes are due to impl... Adrian Lungu
10:26 AM User Interface Feature #5151: Add complete support for tree-list OCX triggers
The direct flag is set on @true@ when @setCurrentNode@ is fired due to a user specific action (usually a mouse press ... Adrian Lungu
10:23 AM User Interface Feature #5151: Add complete support for tree-list OCX triggers
Adrian,
I need to change customer specific code that uses modified @TreeGuiImp.setCurrentNode(TreeNode<N> node, bo...
Eugenie Lyzenko
06:57 AM User Interface Feature #5151: Add complete support for tree-list OCX triggers
Committed 3821c/rev. 12049 adding support for @OnChangeNodeDirect@ and @OnChangeTopVisibleNode@. In this process, I r... Adrian Lungu
10:26 AM Base Language Feature #5160: About cast() function support
Yes, GeneralInfoPart is my class.... Deividas Varzgalys
08:44 AM Base Language Feature #5160: About cast() function support
> Does your tool support cast() function in that way?
Yes, FWD does support chaining a method call off of a @cast(...
Greg Shah
08:40 AM Base Language Feature #5160: About cast() function support
From Deividas:
> I have issue in conversion process that error show up with cast() function
> ...
Greg Shah
05:05 AM Base Language Feature #5160 (New): About cast() function support
Deividas Varzgalys
10:07 AM Runtime Infrastructure Feature #5155: make it easier to deploy custom servlets into the FWD server
To allow mixed annotations and web.xml configuration for the services (servlet, web socket), the web.xml needs to hav... Constantin Asofiei
09:23 AM User Interface Feature #4179: create a standalone native launcher (Windows EXE and Linux/UNIX version) which can...
> What if you run OPEN-MIME-RESOURCE of this custom mime-type in ChUI or Swing clients? Should they reject?
@OPEN-...
Greg Shah
08:56 AM User Interface Feature #4179: create a standalone native launcher (Windows EXE and Linux/UNIX version) which can...
A question about implementation. Would the launcher only function on web client? What if you run @OPEN-MIME-RESOURCE@... Roger Borrello
07:33 AM User Interface Feature #4179: create a standalone native launcher (Windows EXE and Linux/UNIX version) which can...
> So the tc.openMimeResource should make a special case of mimeType=application/fwd-local-launcher
Yes, if needed....
Greg Shah
07:43 AM Deployment Support #3303: make the automated deployment process fully production ready
Greg Shah wrote:
> > So the build/classes.aop is not needed?
>
> I don'tknow for sure.
>
> Hynek: is this s...
Hynek Cihlar
07:19 AM Deployment Support #3303: make the automated deployment process fully production ready
> So the build/classes.aop is not needed?
I don'tknow for sure.
Hynek: is this something from AspectJ? Is i...
Greg Shah
07:03 PM Deployment Support #3303: make the automated deployment process fully production ready
Greg Shah wrote:
> The command line launcher is @/usr/bin/ansible-pull@. This is Python code that calls @ansible@. ...
Roger Borrello

02/22/2021

06:52 PM User Interface Feature #4179: create a standalone native launcher (Windows EXE and Linux/UNIX version) which can...
So the @tc.openMimeResource@ should make a special case of @mimeType=application/fwd-local-launcher@ and force the gi... Roger Borrello
07:09 PM User Interface Feature #4179: create a standalone native launcher (Windows EXE and Linux/UNIX version) which can...
> @UiUtils.resolveResourceUrl@
As of now, @file://@ resources are local to the FWD client. We will have to format...
Greg Shah
05:50 PM Deployment Support #3303: make the automated deployment process fully production ready
Greg Shah wrote:
> > @build/lib/*.jar@ should probably be @build/*@
>
> As far as I know, this is not needed.
...
Roger Borrello
07:45 AM Runtime Infrastructure Feature #5155: make it easier to deploy custom servlets into the FWD server
Our current approach to loading web applications/servlets into the FWD server's embedded container current relies on ... Greg Shah
07:29 AM Runtime Infrastructure Feature #5155 (New): make it easier to deploy custom servlets into the FWD server
Greg Shah
07:20 AM Base Language Feature #4965: Parameter annotation - qualified
> I've pushed 3821c revision 12046 to xfer. Do you want to branch from that, apply your changes and provide a bzr se... Greg Shah
07:18 AM Base Language Feature #4965: Parameter annotation - qualified
Greg Shah wrote:
> > since there seems to be some automatic changes applied to 'oo' packages should we make a new b...
Marian Edu
06:55 AM Base Language Feature #4965: Parameter annotation - qualified
> since there seems to be some automatic changes applied to 'oo' packages should we make a new branch to incorporate... Greg Shah
04:09 AM Base Language Feature #4965: Parameter annotation - qualified
Marian Edu wrote:
> Constantin, just to clarify, the default to P.L.O is not for the (newly added) return type but f...
Constantin Asofiei
03:08 AM Base Language Feature #4965: Parameter annotation - qualified
Constantin Asofiei wrote:
> I agree that the return type should be added. But the approach to 'default to PLO' if t...
Marian Edu
08:14 PM Base Language Feature #4965: Parameter annotation - qualified
Perhaps the default value for @LegacySignature.returns()@ should be "VOID".
As for the poly cases, I think they sh...
Greg Shah
05:04 AM User Interface Feature #5151: Add complete support for tree-list OCX triggers
After some investigation, the following behavior is expected:
* @OnChangeNodeDirect@ is fired when the selected node...
Adrian Lungu
03:24 AM Base Language Bug #5029: OO constructor with array input parameter
Constantin Asofiei wrote:
> Marian, regarding #5029-15 - I've tried duplicating using this test:
> [...]
>
> But...
Marian Edu

02/21/2021

11:28 AM Base Language Feature #5146: record additional legacy class and method data in annotations
3821c rev 12042 to 12044 fixes the 'extent', 'qualified' and adds 'returns' annotation to all legacy p2j.oo methods. ... Constantin Asofiei
11:27 AM Base Language Feature #4965 (WIP): Parameter annotation - qualified
All changes are in 3821c revs 12042 to 12044.
I did not touch the poly methods/parameters:...
Constantin Asofiei
09:27 AM Base Language Feature #4965: Parameter annotation - qualified
I've built a tool which automatically edits the source code for the @com.goldencode.p2j.oo@ classes and injects @qual... Constantin Asofiei

02/20/2021

11:44 AM User Interface Feature #4179: create a standalone native launcher (Windows EXE and Linux/UNIX version) which can...
How should the path to the local resource be formatted? Is it up to the user to enter *file:///* or should any valid ... Roger Borrello
11:26 AM Database Feature #1587: implement full support for word indexes
Finished with word tables support for denormalized extent fields. Tested with a large customer app. and with test app... Igor Skornyakov
03:29 AM User Interface Feature #5151: Add complete support for tree-list OCX triggers
Committed 3821c/rev. 12038 regarding @OnTreeDrag*@ OCX event triggers. The tests are mostly accurate; however, the i... Adrian Lungu
07:46 PM Database Bug #5056: Temp-tables and unique indexes
I used your patch to run the xfer tests and things have changed. It is not perfect, but I cannot tell exactly why.
...
Ovidiu Maxiniuc

02/19/2021

04:15 PM Base Language Bug #4978: Static method call in base class
Lets assume you have a protected instance method @Base.foo@ and a class @Extension@ which extends @Base@.
# in a met...
Constantin Asofiei
03:57 PM Base Language Bug #4978: Static method call in base class
We need to be careful using qualified/unqualified. Most of the time when we say qualified, we mean the "package" por... Greg Shah
01:28 PM Base Language Bug #4978 (WIP): Static method call in base class
The same behavior where the static member from a super-class can be accessed from a sub-class is allowed for variable... Constantin Asofiei
03:11 PM Base Language Feature #4965: Parameter annotation - qualified
Greg Shah wrote:
> > I already have code to calculate the return type using reflection and the existing annotations....
Constantin Asofiei
11:38 AM Base Language Feature #4965: Parameter annotation - qualified
> I already have code to calculate the return type using reflection and the existing annotations.
3821c rev 12032 ...
Greg Shah
11:09 AM Base Language Feature #4965: Parameter annotation - qualified
I already have code to calculate the return type using reflection and the existing annotations. I will check it in s... Greg Shah
11:05 AM Base Language Feature #4965: Parameter annotation - qualified
It was easy to write a simple tool to check the @p2j.oo@ methods which have @LegacySignature@. The list of problems ... Constantin Asofiei
09:59 AM Base Language Feature #4965: Parameter annotation - qualified
> You mentioned at some point that the method's return type is not in LegacySignature - where was this logged?
See...
Greg Shah
09:47 AM Base Language Feature #4965: Parameter annotation - qualified
Greg, you mentioned at some point that the method's return type is not in LegacySignature - where was this logged?
...
Constantin Asofiei
01:55 PM Base Language Bug #4749: Conversion error for object indeterminate extent output parameter
The conversion issue for @ObjectExtentGlobal@ is already fixed.
As for the dynamic array issues - the root cause w...
Constantin Asofiei
11:31 AM Database Feature #1587: implement full support for word indexes
Added word tables' support for custom extents (conversion and database import).
Committed to 3821c/12031
Igor Skornyakov
11:14 AM Base Language Bug #5029: OO constructor with array input parameter
Marian, regarding #5029-15 - I've tried duplicating using this test:... Constantin Asofiei
10:55 AM Base Language Feature #5146: record additional legacy class and method data in annotations
Regarding the return type for function and OO methods - my only problem is that there are ~3000 hand-written classes ... Constantin Asofiei
10:48 AM Database Feature #4397 (Closed): add database attrs, methods and options
Ovidiu has recently confirmed that testing passed for the features in this task. Greg Shah
07:38 AM User Interface Feature #4179: create a standalone native launcher (Windows EXE and Linux/UNIX version) which can...
Your testcase to run this can be as simple as this:... Greg Shah
07:24 AM User Interface Bug #5153: improvements to down body processing
1. Should we just add this @processDownBody()@ to @handleScreenBuffers()@? If the @downConfigs@ are non-null then we... Greg Shah
07:21 AM User Interface Bug #5153 (New): improvements to down body processing
Greg Shah

02/18/2021

06:27 PM Database Bug #5056: Temp-tables and unique indexes
Eric,
I looked deeper into the server's log (there are a lot of @java.lang.IllegalStateException: Empty scopes in Un...
Ovidiu Maxiniuc
06:19 PM Database Bug #5056: Temp-tables and unique indexes
Eric,
I am sorry to inform you that the patch is not making the testsets behave better. In fact, the test stops much...
Ovidiu Maxiniuc
05:10 PM Database Bug #5056: Temp-tables and unique indexes
Ovidiu, please test whether the attached patch resolves your original issue(s). It gets both of the test cases you pr... Eric Faulhaber
05:00 PM Database Feature #1587: implement full support for word indexes
Eric Faulhaber wrote:
> Please don't. If we were starting from scratch, we could consider it, but the changes you sh...
Igor Skornyakov
04:44 PM Database Feature #1587: implement full support for word indexes
Please don't. If we were starting from scratch, we could consider it, but the changes you should be making to DDL gen... Eric Faulhaber
04:15 PM Database Feature #1587: implement full support for word indexes
As I can see at this moment FWD has a dependency on Apache Velocity. Can I use it for DDL generation? This will make ... Igor Skornyakov
03:44 PM Database Feature #1587: implement full support for word indexes
I've resolved the issues described in #1587-349, implemented the generation of the word tables with indices/constrain... Igor Skornyakov
03:13 PM Database Feature #4022: upgrade to a newer PostgreSQL release
> * Did the package come out of the standard Ubuntu repos? Or did you have to add a PPA to the system?
Ubuntu.
...
Stanislav Lomany
01:55 PM Database Feature #4022: upgrade to a newer PostgreSQL release
>> Were you able to leverage the pre-built PL/Java binaries?
>
> I installed PL/Java package using apt, along with ...
Greg Shah
02:06 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
I've changed item 2.3 from "Deal with multi-page Jasper layout (this relates to the case where export of a browse is ... Greg Shah
02:01 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
> Stanislav: Do you have any opinions on this?
I don't like dealing with JasperReport templates because the code l...
Stanislav Lomany
01:35 PM User Interface Feature #3880: enhanced browse 3rd phase of improvements
In #5145-11, Vladimir makes a very good point that using JasperReports for @BROWSE@ spreadsheet export has a big disa... Greg Shah
12:19 PM User Interface Feature #5151: Add complete support for tree-list OCX triggers
I investigated the @OnTreeDrag*@ triggers and they seem to be compatible with our current effort with @OLEDRAGDROP@, ... Adrian Lungu
07:26 AM User Interface Feature #5151: Add complete support for tree-list OCX triggers
Please summarize the steps for adding the needed support. Greg Shah
04:39 AM User Interface Feature #5151 (WIP): Add complete support for tree-list OCX triggers
Some of the tree based widgets don't have conversion support for some ocx-triggers:
* OnChangeNode (*supported*)
...
Adrian Lungu
04:37 AM User Interface Feature #5151 (WIP): Add complete support for tree-list OCX triggers
Adrian Lungu
12:17 PM Base Language Bug #5035: Temp-Table index on P.L.O field
Greg Shah wrote:
> > is there a way to resolve an instance from its ID, an equivalent for handle function?
>
> Ma...
Marian Edu
10:24 AM Base Language Bug #5035: Temp-Table index on P.L.O field
> is there a way to resolve an instance from its ID, an equivalent for handle function?
Marian: We need your thoug...
Greg Shah
10:22 AM Base Language Bug #4749 (WIP): Conversion error for object indeterminate extent output parameter
Greg Shah
06:13 AM User Interface Bug #5118: TREELIST widget issues
FIXED in rev 12518.
Another difference:
In FWD a node is collapsed/expanded on mouse up event for *any mouse butt...
Vladimir Tsichevski

02/17/2021

04:02 PM Database Feature #1587: implement full support for word indexes
Eric Faulhaber wrote:
> Igor Skornyakov wrote:
> > I've noticed two things regarding custom extends.
> > # If the ...
Igor Skornyakov
03:58 PM Database Feature #1587: implement full support for word indexes
Igor Skornyakov wrote:
> I've noticed two things regarding custom extends.
> # If the number of the @<extent-field@...
Eric Faulhaber
02:57 PM Database Feature #1587: implement full support for word indexes
I've noticed two things regarding custom extends.
# If the number of the @<extent-field@ subnodes on the .hints file...
Igor Skornyakov

02/16/2021

05:07 PM User Interface Bug #5150: killing the web page for the web client should raise the equivalent of a window-close ...
Thanks for creating this issue.
FYI the business value is: when the software is licensed for a maximum number of ...
Jurjen Dijkstra
04:37 PM User Interface Bug #5150: killing the web page for the web client should raise the equivalent of a window-close ...
> I think we need a listener for session termination which will emulate the 'window close' logic.
I think this is...
Greg Shah
04:33 PM User Interface Bug #5150: killing the web page for the web client should raise the equivalent of a window-close ...
A customer reported this issue (my paraphrased version):
> When the user closes the webbrowser (or only the browse...
Greg Shah
04:31 PM User Interface Bug #5150 (New): killing the web page for the web client should raise the equivalent of a window-...
Greg Shah
04:42 PM Base Language Feature #4384: Builtin OO Implementation
I've added wiki documentation that lists our currently "supported built-in OO classes":/projects/p2j/wiki/Object_Orie... Greg Shah
01:58 PM Base Language Bug #5029 (Test): OO constructor with array input parameter
Greg Shah
01:12 PM Base Language Bug #5029: OO constructor with array input parameter
Constantin Asofiei wrote:
> OK, that's because my tests always had the INPUT modifier. I'll fix this.
>
> For no...
Constantin Asofiei
01:57 PM Database Feature #1587: implement full support for word indexes
Eric Faulhaber wrote:
> No problem. The annotation for the @wiext@ index looks correct to me as is.
Well, formally ...
Igor Skornyakov
01:50 PM Database Feature #1587: implement full support for word indexes
Igor Skornyakov wrote:
> I'm talking about @name = "fextFirst", legacy = "f-ext"@. The word table name was also ba...
Eric Faulhaber
01:21 PM Database Feature #1587: implement full support for word indexes
Eric Faulhaber wrote:
> I'm having trouble understanding the question. Please provide an example.
I mean the follow...
Igor Skornyakov
01:10 PM Database Feature #1587: implement full support for word indexes
Igor Skornyakov wrote:
> I've noticed that for word index with customized extent fields the value of the @name@ attr...
Eric Faulhaber
01:05 PM Database Feature #1587: implement full support for word indexes
I've noticed that for word index with customized extent fields the value of the @name@ attribute of the @IndexCompone... Igor Skornyakov
08:45 AM User Interface Feature #3283: add 4GL extension to obtain the mouse pointer location
How much effort is there to fix this? Greg Shah
05:43 AM User Interface Feature #3283: add 4GL extension to obtain the mouse pointer location
GET-MOUSE-POSITION returns coordinates relative to the screen when called on @FIELD-GROUP@ widget. It must return coo... Hynek Cihlar
 

Also available in: Atom