Project

General

Profile

Activity

From 03/10/2022 to 04/08/2022

04/08/2022

06:34 PM Base Language Bug #6268: Characters encoding issues with UTF-8 for emoji and confusable symbols.
Small pic showing the end status for now. Please attach to the new bug issue along with this comment.
Using @the g...
Eugenie Lyzenko
06:32 PM Base Language Bug #6268: Characters encoding issues with UTF-8 for emoji and confusable symbols.
The patch to unlock negative @ASC@ code conversion. Eugenie Lyzenko
06:29 PM Base Language Bug #6268 (New): Characters encoding issues with UTF-8 for emoji and confusable symbols.
Eugenie Lyzenko
05:38 PM User Interface Bug #6267: StackOverflowError in BROWSE widget
Vladimir: Please use @bzr blame@ and report who wrote the code in question. Greg Shah
02:28 PM User Interface Bug #6267: StackOverflowError in BROWSE widget
This issue was first published as #5034-1982. Vladimir Tsichevski
02:27 PM User Interface Bug #6267: StackOverflowError in BROWSE widget
Stack overflow situation in @Browse@ widget:
# create an application with an editable @BROWSE@ widget (example @br...
Vladimir Tsichevski
02:24 PM User Interface Bug #6267 (Review): StackOverflowError in BROWSE widget
Vladimir Tsichevski
05:04 PM Database Bug #3896: improve performance of the _lock metadata implementation
Eric Faulhaber wrote:
> Is the latest patch still based on 3821c/13684?
Please find the patch based on 3821c/13...
Igor Skornyakov
04:57 PM Database Bug #3896: improve performance of the _lock metadata implementation
Igor Skornyakov wrote:
> Eric,
> Can you please review this? I cannot commit another changes e.g. for the @Database...
Eric Faulhaber
04:17 PM Database Bug #3896: improve performance of the _lock metadata implementation
Eric,
Can you please review this? I cannot commit another changes e.g. for the @DatabaseManager@ since these changes...
Igor Skornyakov
10:00 AM Conversion Tools Bug #5135: replace -s, -f and -x options of ConversionDriver with a single combined mode
> I can either use java.nio.Path.toRealPath (if it works) to resolve the real filename at OS level, or otherwise rely... Greg Shah
09:17 AM Conversion Tools Bug #5135: replace -s, -f and -x options of ConversionDriver with a single combined mode
Another issue: lets assume we are under Windows, where file names are case-insensitive; you have a @F ./Build.p@ line... Constantin Asofiei
07:45 AM Conversion Tools Feature #6202: allow .df files to exist in a path that is not directly in data/
> I think the schema @.hints@ should be stored with the @.df@ file, not with @.schema@.
Correct.
> More than t...
Greg Shah

04/07/2022

07:05 PM Conversion Tools Feature #6202: allow .df files to exist in a path that is not directly in data/
This note was added because of the #5034-1965. It was caused because the conversion got confused about the location o... Ovidiu Maxiniuc
01:42 PM Conversion Tools Feature #6202: allow .df files to exist in a path that is not directly in data/
> Note that this defines the location where the .d files are, to allow the import for custom locations. This is not t... Greg Shah
11:48 AM Conversion Tools Feature #6202: allow .df files to exist in a path that is not directly in data/
Greg Shah wrote:
> * The @dataPath@ parameter for import could be optional. I like to have the option to override t...
Ovidiu Maxiniuc
06:53 AM Conversion Tools Feature #6202: allow .df files to exist in a path that is not directly in data/
All of this is very good. A couple of items:
* The @dataPath@ parameter for import could be optional. I like to ...
Greg Shah
04:00 PM Build and Source Control Bug #6208: cleanup build warnings
Thank you for your review.
Ovidiu Maxiniuc wrote:
> Partial review of @fix_all_compile_warnings_6208.diff@. Just ...
Tomasz Domin
02:25 PM Conversion Tools Bug #5135: replace -s, -f and -x options of ConversionDriver with a single combined mode
And yes, it is OK to leave @-s@. Greg Shah
02:25 PM Conversion Tools Bug #5135: replace -s, -f and -x options of ConversionDriver with a single combined mode
I was assuming that all of the modes would remain until we've migrated all projects into the @-z@. Greg Shah
02:16 PM Conversion Tools Bug #5135: replace -s, -f and -x options of ConversionDriver with a single combined mode
Greg, I'll remove the whitelist and blacklist modes in current work, but the 'FILESPEC' (-s mode) should remain, this... Constantin Asofiei
11:19 AM Conversion Tools Bug #5135: replace -s, -f and -x options of ConversionDriver with a single combined mode
Greg Shah wrote:
> Yes, this makes sense. We should also require double quoted strings when there are embedded spac...
Constantin Asofiei
11:14 AM Conversion Tools Bug #5135: replace -s, -f and -x options of ConversionDriver with a single combined mode
Yes, this makes sense. We should also require double quoted strings when there are embedded space characters.
<pr...
Greg Shah
10:25 AM Conversion Tools Bug #5135: replace -s, -f and -x options of ConversionDriver with a single combined mode
Greg, in the case where we use a file, there will be problems if there are space characters in either the file spec o... Constantin Asofiei
06:55 AM Conversion Tools Bug #5135: replace -s, -f and -x options of ConversionDriver with a single combined mode
As with other flags @-z@ and @-Z@ should be equivalent. Greg Shah
06:55 AM Conversion Tools Bug #5135: replace -s, -f and -x options of ConversionDriver with a single combined mode
> Greg, to make something clear: the @X@ and @I@ filters will work only on the set of files determined from the D, N,... Greg Shah
03:04 AM Conversion Tools Bug #5135 (WIP): replace -s, -f and -x options of ConversionDriver with a single combined mode
Greg, to make something clear: the @X@ and @I@ filters will work only on the set of files determined from the D, N, F... Constantin Asofiei
02:04 PM Runtime Infrastructure Feature #5896: enhance legacy REST support to provide better pure Java development
Greg Shah wrote:
> So: if the calling application has multiple threads, each thread will execute the login with the ...
Constantin Asofiei
01:57 PM Runtime Infrastructure Feature #5896: enhance legacy REST support to provide better pure Java development
Greg Shah wrote:
> 1. The reasoning behind the use of @ThreadLocal@ in @JsonRequestsParser@, @ResponseArguments@ is ...
Constantin Asofiei
01:37 PM Runtime Infrastructure Feature #5896: enhance legacy REST support to provide better pure Java development
Code Review Task Branch 3821c Revisions 13714, 13740
It is very good. I especially like the extensibility of the ...
Greg Shah
11:42 AM Runtime Infrastructure Feature #5896: enhance legacy REST support to provide better pure Java development
> The authentication and authorization implementation does this:
> * the request has a FWD username and a token. FW...
Greg Shah
11:17 AM Runtime Infrastructure Feature #5896: enhance legacy REST support to provide better pure Java development
> 7. There is a comment "authentication and authorization is not mandatory". Does this mean that by default everythin... Constantin Asofiei
11:11 AM Runtime Infrastructure Feature #5896: enhance legacy REST support to provide better pure Java development
Greg Shah wrote:
> Help me understand the current model, then we will discuss this issue.
The authentication and au...
Constantin Asofiei
10:55 AM Runtime Infrastructure Feature #5896: enhance legacy REST support to provide better pure Java development
> concurrency issues: FWD contexts do not support this. So I need to prohibit an API call (or queue them?) if there i... Greg Shah
10:48 AM Runtime Infrastructure Feature #5896: enhance legacy REST support to provide better pure Java development
I have reviewed the documentation. Here are some questions/comments about the implementation:
Overall, this is ve...
Greg Shah
11:26 AM Conversion Tools Feature #6253 (WIP): add file-set processing into p2j.cfg.xml
Constantin Asofiei
08:45 AM Base Language Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> Eugenie Lyzenko wrote:
> > Constantin Asofiei wrote:
> > > > The question. If I update...
Eugenie Lyzenko
06:07 AM User Interface Bug #6258: SELECTION-LIST: Swing ChUI: SPACE and arrow buttons processing
When space is pressed in Swing ChUI mode, the current row is selected.
Issues:
# After the SPACE was pressed, t...
Vladimir Tsichevski
06:05 AM User Interface Bug #6258 (Closed): SELECTION-LIST: Swing ChUI: SPACE and arrow buttons processing
Vladimir Tsichevski

04/06/2022

07:04 PM Conversion Tools Feature #6202: allow .df files to exist in a path that is not directly in data/
With r13746 we have the abilities to:
* pick the .df from any subdirectory under the project's root. The path is spe...
Ovidiu Maxiniuc
07:03 PM Conversion Tools Feature #6256: improved profile support
For complex projects, the OpenEdge compilation will often be done in multiple different compile runs. Each one might... Greg Shah
06:46 PM Conversion Tools Feature #6256 (Closed): improved profile support
Greg Shah
06:45 PM Conversion Tools Feature #6255: simplify the namespace configuration, part deux
In #4105, many improvements were made to simplify the namespace configuration in @p2j.cfg.xml@.
I have 2 additiona...
Greg Shah
06:40 PM Conversion Tools Feature #6255 (WIP): simplify the namespace configuration, part deux
Greg Shah
06:33 PM Conversion Tools Feature #6253: add file-set processing into p2j.cfg.xml
The global section of the @p2j.cfg.xml@ should allow the definition of a @file-set@ element which will allow the expl... Greg Shah
06:14 PM Conversion Tools Feature #6253 (Closed): add file-set processing into p2j.cfg.xml
Greg Shah
06:19 PM User Interface Bug #6254: SELECTION-LIST: horizontal scrollbar is always inactive
Horizontal scrolling is not working in @SELECTION-LIST@. The scrollbar is visible, but inactive even if long lines ex... Vladimir Tsichevski
06:18 PM User Interface Bug #6254 (New): SELECTION-LIST: horizontal scrollbar is always inactive
Vladimir Tsichevski
06:17 PM Conversion Tools Bug #5135: replace -s, -f and -x options of ConversionDriver with a single combined mode
This new file processing approach can be activated with the @-Z<input_file>@ command line option. I know this is dif... Greg Shah
05:04 PM Conversion Tools Bug #5135: replace -s, -f and -x options of ConversionDriver with a single combined mode
I've been thinking about the syntax for this approach. Using a list of @X@ (exclude) and @I@ (include) filters is a ... Greg Shah
06:10 PM Conversion Tools Feature #6252: cleanup of p2j.cfg.xml
Make the global section of @p2j.cfg.xml@ simpler with the following changes:
* Set good default values for @P2J_RU...
Greg Shah
06:06 PM Conversion Tools Feature #6252 (New): cleanup of p2j.cfg.xml
Greg Shah
05:49 PM User Interface Bug #6251: Swing ChUI: BACK-TAB does not work
Test example @5937.p@.
The @TAB@ key works properly, but the @BACK-TAB@ does not do anything for any widget in the...
Vladimir Tsichevski
05:48 PM User Interface Bug #6251 (Rejected): Swing ChUI: BACK-TAB does not work
Vladimir Tsichevski
05:34 PM User Interface Bug #6250: SELECTION-LIST: declaring event trigger does not suppress normal event processing
# In OE, if I define an event trigger, the default event processing is suppressed. For example, if I define event tri... Vladimir Tsichevski
05:32 PM User Interface Bug #6250 (New): SELECTION-LIST: declaring event trigger does not suppress normal event processing
Vladimir Tsichevski
05:20 PM Conversion Tools Feature #3699: improve call-graph visualization to make it much more usable
I found an interesting article on the "ForceAtlas2":https://journals.plos.org/plosone/article?id=10.1371/journal.pone... Greg Shah
04:25 PM User Interface Bug #6249: SELECTION-LIST: lookup items beginning with SPACE issue
@SELECTION-LIST@ lookup feature: go to first or next item beginning with the character pressed.
When the user pres...
Vladimir Tsichevski
04:15 PM User Interface Bug #6249 (New): SELECTION-LIST: lookup items beginning with SPACE issue
Vladimir Tsichevski
03:34 PM User Interface Bug #6248: SELECTION-LIST: No mouse double-click actions
This issue was initially referenced in #5937. Vladimir Tsichevski
03:33 PM User Interface Bug #6248: SELECTION-LIST: No mouse double-click actions
In OE, when the user double-click an item in @SELECTION-LIST@:
# In *single selection mode*: @DEFAULT-ACTION@ is t...
Vladimir Tsichevski
03:32 PM User Interface Bug #6248 (New): SELECTION-LIST: No mouse double-click actions
Vladimir Tsichevski
02:36 PM Base Language Feature #4384: Builtin OO Implementation
Eugenie Lyzenko wrote:
> Constantin Asofiei wrote:
> > > The question. If I update to this version for big customer...
Constantin Asofiei
02:36 PM Base Language Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> > The question. If I update to this version for big customer project, and convert it the...
Eugenie Lyzenko
02:31 PM Base Language Feature #4384: Builtin OO Implementation
> The question. If I update to this version for big customer project, and convert it the generated Java code will *no... Constantin Asofiei
02:30 PM Base Language Feature #4384: Builtin OO Implementation
Igor Skornyakov wrote:
> Constantin Asofiei wrote:
> > Greg Shah wrote:
> > > Constantin: Please apply the patch t...
Eugenie Lyzenko
09:48 AM Base Language Feature #4384: Builtin OO Implementation
Greg Shah wrote:
> If it is required for your current work, then please add the stubs.
So far I have several doze...
Igor Skornyakov
09:44 AM Base Language Feature #4384: Builtin OO Implementation
Igor Skornyakov wrote:
> Constantin Asofiei wrote:
> > Greg Shah wrote:
> > > Constantin: Please apply the patch t...
Greg Shah
09:40 AM Base Language Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> Greg Shah wrote:
> > Constantin: Please apply the patch to the skeleton project and pus...
Igor Skornyakov
09:26 AM Base Language Feature #4384: Builtin OO Implementation
Greg Shah wrote:
> Constantin: Please apply the patch to the skeleton project and push to xfer and proj.goldencode.c...
Constantin Asofiei
08:39 AM Base Language Feature #4384: Builtin OO Implementation
Constantin: Please apply the patch to the skeleton project and push to xfer and proj.goldencode.com (see [[p2j:Downlo... Greg Shah
03:11 AM Base Language Feature #4384: Builtin OO Implementation
Attached a skeleton patch for @Progress.Security@ classes. Marian Edu
01:56 PM Database Bug #6242: PSQLException when creating identity sequence using PostgreSQL dialect
In revision 3821c/13746 I added some code to detect whether the query string returned by p2j dialect when updating th... Ovidiu Maxiniuc
09:48 AM Database Bug #6242: PSQLException when creating identity sequence using PostgreSQL dialect
When performing database import on a fresh PostgreSQL database using 3821c/13704, we hit:... Eric Faulhaber
09:43 AM Database Bug #6242 (New): PSQLException when creating identity sequence using PostgreSQL dialect
Eric Faulhaber
01:55 PM Runtime Infrastructure Feature #5896: enhance legacy REST support to provide better pure Java development
Greg, please review [[p2j:Java REST Services]] and [[p2j:Securing the Web Services (REST, SOAP, WEBHANDLER)]], and le... Constantin Asofiei
01:10 PM User Interface Bug #6247: SELECTION-LIST drawing issues in GUI mode
These issues were previously registered as #5937-9 and #5937-10. Vladimir Tsichevski
01:08 PM User Interface Bug #6247: SELECTION-LIST drawing issues in GUI mode
The selection list in OE:
!5937-OE.png!
the same list in FWD:
!5937-FWD.png!
The differences:
1. in FWD th...
Vladimir Tsichevski
01:04 PM User Interface Bug #6247 (New): SELECTION-LIST drawing issues in GUI mode
Vladimir Tsichevski
11:11 AM User Interface Bug #6245: SELECTION-LIST: the first item is not initially highlighted in Swing ChUI
The test example @5937-simple.p@. Vladimir Tsichevski
11:05 AM User Interface Bug #6245: SELECTION-LIST: the first item is not initially highlighted in Swing ChUI
In OE ChUI, when the ``SELECTION-LIST`` is first shown, the first item is highlighted:
!6245-OE.png!
In FWD Swi...
Vladimir Tsichevski
11:03 AM User Interface Bug #6245 (New): SELECTION-LIST: the first item is not initially highlighted in Swing ChUI
Vladimir Tsichevski
09:51 AM User Interface Bug #6241: NPE in LinuxKeyboardReader when Escape is pressed
# Open any application with a window in ChUI Swing.
# Press @Escape@. Client crashes with NPE.
The stack trace:
...
Vladimir Tsichevski
09:38 AM User Interface Bug #6241 (New): NPE in LinuxKeyboardReader when Escape is pressed
Vladimir Tsichevski
06:48 AM User Interface Bug #6240: Context menu should open on mouse down and not mouse click
The attached diff simply moves the code responsible for showing context menus from @mouseClicked@ to @mousePressed@. ... Hynek Cihlar
06:45 AM User Interface Bug #6240 (New): Context menu should open on mouse down and not mouse click
Hynek Cihlar

04/05/2022

05:57 PM User Interface Bug #6239: SELECTION-LIST dragging with mouse does not scroll
In OE if the user drags an item in a @SELECTION-LIST@ with vertical scrolling enabled, the list is scrolled when the ... Vladimir Tsichevski
05:52 PM User Interface Bug #6239 (New): SELECTION-LIST dragging with mouse does not scroll
Vladimir Tsichevski
03:20 PM User Interface Bug #6238: Incorrect focus after frame hidden
The following test case shows the issue. In GUI focus must be set in @t2@ after the button is chosen, but it is set i... Hynek Cihlar
03:18 PM User Interface Bug #6238 (New): Incorrect focus after frame hidden
Hynek Cihlar
01:57 PM Runtime Infrastructure Feature #5896: enhance legacy REST support to provide better pure Java development
The changes to add authentication and authorization for web services are in 3821c/13740.
I'll finish the documenta...
Constantin Asofiei
12:10 PM Runtime Infrastructure Feature #5896: enhance legacy REST support to provide better pure Java development
Greg, something which should have been obvious for me from the start: the agent will switch context and execute the t... Constantin Asofiei
10:06 AM Conversion Tools Feature #6237: OEUnit support
"OEUnit":https://github.com/CameronWills/OEUnit is an open source project (Eclipse Public License) which preceded ABL... Greg Shah
10:03 AM Conversion Tools Feature #6237 (Closed): OEUnit support
Greg Shah

04/04/2022

01:04 PM Conversion Tools Feature #6203 (Closed): create cvtpath and move conversion database into that directory
Greg Shah
11:02 AM Conversion Tools Feature #6203: create cvtpath and move conversion database into that directory
Greg Shah wrote:
> I'd like to push this to xfer. Please make the @build.xml@ changes in the active customer projec...
Constantin Asofiei
10:55 AM Conversion Tools Feature #6203: create cvtpath and move conversion database into that directory
I'd like to push this to xfer. Please make the @build.xml@ changes in the active customer projects so that everythin... Greg Shah
01:01 PM Runtime Infrastructure Feature #5896: enhance legacy REST support to provide better pure Java development
Greg, some notes about the authentication mechanism:
* the webservice resource plugin will allow ACLs to be set for ...
Constantin Asofiei
12:21 PM User Interface Bug #6234: Frame does not receive focus
Example program @frame-focus.p@. In OE, when the user presses a key, the @ANY-KEY@ trigger is fired, and a message is... Vladimir Tsichevski
12:18 PM User Interface Bug #6234 (New): Frame does not receive focus
Vladimir Tsichevski
12:14 PM Conversion Tools Feature #6202: allow .df files to exist in a path that is not directly in data/
Greg Shah wrote:
> > According to #5586, there will not be a @cvt@ in jar. The directory structure for all artifacts...
Ovidiu Maxiniuc
12:05 PM Conversion Tools Feature #6202: allow .df files to exist in a path that is not directly in data/
> According to #5586, there will not be a @cvt@ in jar. The directory structure for all artifacts must be preserved i... Greg Shah
12:03 PM Conversion Tools Feature #6202: allow .df files to exist in a path that is not directly in data/
Constantin Asofiei wrote:
> OK, then the runtime doesn't need 'cvtpath' at all, as the root folder is the project ro...
Ovidiu Maxiniuc
12:02 PM Conversion Tools Feature #6202: allow .df files to exist in a path that is not directly in data/
Just as an FYI, in my customer project, I utilized the "deploy.dist" target to include everything needed to perform t... Roger Borrello
11:59 AM Conversion Tools Feature #6202: allow .df files to exist in a path that is not directly in data/
Ovidiu Maxiniuc wrote:
> Constantin Asofiei wrote:
> > I'm confused - how will the artifacts be kept in the jar - w...
Constantin Asofiei
11:56 AM Conversion Tools Feature #6202: allow .df files to exist in a path that is not directly in data/
Constantin Asofiei wrote:
> I'm confused - how will the artifacts be kept in the jar - will they be relative to the ...
Ovidiu Maxiniuc
11:53 AM Conversion Tools Feature #6202: allow .df files to exist in a path that is not directly in data/
Ovidiu Maxiniuc wrote:
> Constantin Asofiei wrote:
> > Ovidiu Maxiniuc wrote:
> > > It uses @Configuration.getConv...
Constantin Asofiei
11:50 AM Conversion Tools Feature #6202: allow .df files to exist in a path that is not directly in data/
Constantin Asofiei wrote:
> Ovidiu Maxiniuc wrote:
> > It uses @Configuration.getConversionFolder()@ at conversion ...
Ovidiu Maxiniuc
11:42 AM Conversion Tools Feature #6202: allow .df files to exist in a path that is not directly in data/
Ovidiu Maxiniuc wrote:
> It uses @Configuration.getConversionFolder()@ at conversion but, at runtime, the returned p...
Constantin Asofiei
11:40 AM Conversion Tools Feature #6202: allow .df files to exist in a path that is not directly in data/
Constantin Asofiei wrote:
> Ovidiu, are you planning to jar the entire @cvt/@ folder?
Of course, not. The @build.xm...
Ovidiu Maxiniuc
11:32 AM Conversion Tools Feature #6202: allow .df files to exist in a path that is not directly in data/
Ovidiu, are you planning to jar the entire @cvt/@ folder? For runtime, I would use a pre-defined/static 'cvtpath' (i... Constantin Asofiei
11:23 AM Conversion Tools Feature #6202: allow .df files to exist in a path that is not directly in data/
Greg Shah wrote:
> Please shift to use the @Configuration.getConversionFolder()@ instead of the @xmlFile@ approach. ...
Ovidiu Maxiniuc
07:19 AM User Interface Support #6212 (Closed): View frame display default value for fill-in for some data types
Greg Shah
02:54 AM User Interface Support #6212: View frame display default value for fill-in for some data types
6212.patch checked in 3821c revision 13734. Hynek Cihlar

04/03/2022

07:34 PM User Interface Support #6212: View frame display default value for fill-in for some data types
Yes, go ahead. Greg Shah
03:00 PM User Interface Support #6212: View frame display default value for fill-in for some data types
Hynek Cihlar wrote:
> Greg Shah wrote:
> > Hynek: Please review and merge to 3821c if it is OK.
>
> Marian, the ...
Hynek Cihlar
11:34 AM Conversion Tools Feature #6203: create cvtpath and move conversion database into that directory
Greg Shah wrote:
> Code Review Task Branch 3821c Revision 13732
>
> Nice!
>
> 1. @Configuration.getConversionF...
Constantin Asofiei
10:34 AM Conversion Tools Feature #6203: create cvtpath and move conversion database into that directory
Code Review Task Branch 3821c Revision 13732
Nice!
1. @Configuration.getConversionFolder()@ should have the @ex...
Greg Shah
10:22 AM Conversion Tools Feature #6203: create cvtpath and move conversion database into that directory
Greg wrote:
> When do you think you can have this ready?
Constantin wrote (2 hours later):
> Added to 3821c/1373...
Greg Shah
10:38 AM Conversion Tools Feature #6202: allow .df files to exist in a path that is not directly in data/
Please shift to use the @Configuration.getConversionFolder()@ instead of the @xmlFile@ approach. By default it shoul... Greg Shah

04/02/2022

02:31 PM User Interface Support #6212: View frame display default value for fill-in for some data types
Greg Shah wrote:
> > Normally this should not be called when data type or format is being set
>
> The @DISPLAY <e...
Marian Edu
09:40 AM User Interface Support #6212: View frame display default value for fill-in for some data types
> Normally this should not be called when data type or format is being set
The @DISPLAY <expr> format "<fmt>" &#64...
Greg Shah
08:35 AM User Interface Support #6212: View frame display default value for fill-in for some data types
Hynek Cihlar wrote:
> Marian, the change also affects other use cases than only @VIEW@ or visibility change. For exa...
Marian Edu
12:29 PM Conversion Tools Feature #6203 (Review): create cvtpath and move conversion database into that directory
Added to 3821c/13732. Constantin Asofiei
09:57 AM Conversion Tools Feature #6203: create cvtpath and move conversion database into that directory
Constantin: When do you think you can have this ready? Greg Shah
09:57 AM Conversion Tools Feature #6202: allow .df files to exist in a path that is not directly in data/
> I have the changes ready to commit but
Are these changes to FWD or are they the project changes referenced in #...
Greg Shah
09:33 PM Conversion Tools Feature #6202: allow .df files to exist in a path that is not directly in data/
I have the changes ready to commit but there are two issues.
* I only tested on PoC and hotel_gui projects. That is,...
Ovidiu Maxiniuc

04/01/2022

02:07 PM Build and Source Control Bug #6208: cleanup build warnings
Greg Shah wrote:
> Hynek/Constantin: Please review the rest of the changes.
Beside missing history entries and TODO...
Constantin Asofiei
12:08 PM User Interface Support #6212: View frame display default value for fill-in for some data types
Greg Shah wrote:
> Hynek: Please review and merge to 3821c if it is OK.
Marian, the change also affects other use...
Hynek Cihlar
08:26 AM User Interface Support #6212: View frame display default value for fill-in for some data types
Hynek: Please review and merge to 3821c if it is OK. Greg Shah
06:41 AM User Interface Support #6212 (Review): View frame display default value for fill-in for some data types
Marian Edu
06:41 AM User Interface Support #6212 (WIP): View frame display default value for fill-in for some data types
Attached a quick patch to fix this and for whatever reason the screen width for datetime format only considered the d... Marian Edu

03/31/2022

07:38 PM Build and Source Control Bug #6208: cleanup build warnings
Greg Shah wrote:
> Ovidiu: Please review the persistence/database stats/database dump checker changes.
Partial re...
Ovidiu Maxiniuc
12:42 PM Build and Source Control Bug #6208: cleanup build warnings
Sergey: Please review the admin client changes.
Ovidiu: Please review the persistence/database stats/database dump c...
Greg Shah
12:25 PM Build and Source Control Bug #6208: cleanup build warnings
... Tomasz Domin
11:18 AM Build and Source Control Bug #6208: cleanup build warnings
... Tomasz Domin
07:19 AM Build and Source Control Bug #6208: cleanup build warnings
>>... Tomasz Domin
12:46 PM Runtime Infrastructure Bug #6227: AcmeClient - unsupported Challenge Type
Current AcmeClient implementation is using TlsSni01Challenge, which is unsupported since 2019.
It must to be migrate...
Tomasz Domin
12:45 PM Runtime Infrastructure Bug #6227 (New): AcmeClient - unsupported Challenge Type
Tomasz Domin
10:18 AM Runtime Infrastructure Feature #5896: enhance legacy REST support to provide better pure Java development
> Also, what wiki should I use for the documentation?
See [[p2j:Java REST Services]]
Greg Shah

03/30/2022

04:06 PM Runtime Infrastructure Feature #5896: enhance legacy REST support to provide better pure Java development
Constantin Asofiei wrote:
> Ovidiu: please take a look at @p2j.persist.Record@ and @p2j.rest.serializers.RecordSeria...
Ovidiu Maxiniuc

03/29/2022

03:34 PM Conversion Tools Feature #1757: update ANTLR to latest version
ANTLR v3 is dead at this point and was replaced by ANTLR v4. Whether it makes sense or not to move to ANTLR v4 is no... Greg Shah
01:52 PM Runtime Infrastructure Feature #5896: enhance legacy REST support to provide better pure Java development
Greg, the support for the REST services implemented directly in Java is in 3821c/13714.
Please review. Also, what...
Constantin Asofiei
11:55 AM Build and Source Control Bug #6208: cleanup build warnings
Greg Shah wrote:
> > Replaced with IOUtils.toInputStream(data,Charset.defaultCharset()), note that serialization of ...
Ovidiu Maxiniuc
08:16 AM Build and Source Control Bug #6208: cleanup build warnings
> Remote GuiWebSocket.getTextWidth is deprecated for single text sample
I think we can just remove the deprecated ...
Greg Shah
07:58 AM Build and Source Control Bug #6208: cleanup build warnings
> According to related TODO I presume this method's logic needs to be moved to separate class,
>> ...
Greg Shah
05:39 AM Build and Source Control Bug #6208: cleanup build warnings
... Tomasz Domin
03:50 AM Build and Source Control Bug #6208: cleanup build warnings
... Tomasz Domin
10:02 AM Conversion Tools Feature #6202: allow .df files to exist in a path that is not directly in data/
I would be fine with those updates to that POC project. Roger Borrello
09:49 AM Conversion Tools Feature #6202: allow .df files to exist in a path that is not directly in data/
Greg,
I worked with latest POC (#6088, which Roger is maintaining) when adding these changes. I have chosen it bec...
Ovidiu Maxiniuc
07:09 AM Conversion Tools Feature #6202: allow .df files to exist in a path that is not directly in data/
Overall, I'm good with the approach. When #6203 (@cvtpath@) is available, you should remove @xmlFile@ and use @cvtpa... Greg Shah

03/28/2022

03:36 PM Build and Source Control Bug #6208: cleanup build warnings
... Tomasz Domin
02:18 PM Build and Source Control Bug #6208: cleanup build warnings
... Tomasz Domin
09:12 AM Build and Source Control Bug #6208 (WIP): cleanup build warnings
Tomasz Domin
08:48 AM User Interface Support #6212: View frame display default value for fill-in for some data types
When calling @view@ on a frame, or change it's @visibility@ in FWD some of the fill-ins in the frame shows a default ... Marian Edu
08:45 AM User Interface Support #6212 (Closed): View frame display default value for fill-in for some data types
Marian Edu
08:36 AM User Interface Bug #6211: Display changes z-order
When a @display@ statement is used with a widgets list the FWD implementation changes the widgets z-order in frame by... Marian Edu
08:23 AM User Interface Bug #6211 (New): Display changes z-order
Marian Edu
06:53 AM Database Bug #3896: improve performance of the _lock metadata implementation
Sorry, forgot to add new classes to the .diff file. Igor Skornyakov
06:02 AM Database Bug #3896: improve performance of the _lock metadata implementation
Finished.
Please review.
Thank you.
Igor Skornyakov

03/27/2022

03:21 PM Database Bug #3896: improve performance of the _lock metadata implementation
Added JMX instrumentation and cleanup logic to @LockTableUpdater@.
However, I have a strange problem with finding pe...
Igor Skornyakov

03/26/2022

11:16 PM Conversion Tools Feature #6202 (WIP): allow .df files to exist in a path that is not directly in data/
As noted above I added a @dataFolder@ attribute in @namespace@. This specifies the location of @.d@ data files. Toget... Ovidiu Maxiniuc

03/25/2022

02:20 PM Build and Source Control Bug #6208: cleanup build warnings
Ovidiu Maxiniuc wrote:
> * The first half a dozen warnings are generated by @DatabaseStatistics@. It is "dangling"...
Eric Faulhaber
01:36 PM Build and Source Control Bug #6208: cleanup build warnings
Some notes on warning related to persistence:
* The first half a dozen warnings are generated by @DatabaseStatistics...
Ovidiu Maxiniuc
09:25 AM Build and Source Control Bug #6208: cleanup build warnings
On my system, @./gradlew core@ results in the following:... Greg Shah
09:12 AM Build and Source Control Bug #6208 (Closed): cleanup build warnings
Greg Shah
01:14 PM Conversion Tools Feature #6202: allow .df files to exist in a path that is not directly in data/
Greg Shah wrote:
> > I am now trying to fix the data_analyzer (optionally invoked using f2+m1+cb conversion profile)...
Eric Faulhaber
06:00 AM Conversion Tools Feature #6202: allow .df files to exist in a path that is not directly in data/
> I am now trying to fix the data_analyzer (optionally invoked using f2+m1+cb conversion profile).
I think we have...
Greg Shah
08:57 PM Conversion Tools Feature #6202: allow .df files to exist in a path that is not directly in data/
In #4105 I added flexibility for loading the @.df@ file from a configured place, but there were some issues with the ... Ovidiu Maxiniuc
01:13 PM Base Language Bug #5294 (Closed): parsing problems for assign-style statements with a OO chained lvalue
Code Review Task Branch 3821c Revision 13690
No objections.
Greg Shah
12:51 PM Base Language Bug #5294 (Review): parsing problems for assign-style statements with a OO chained lvalue
Constantin Asofiei
12:51 PM Base Language Bug #5294 (WIP): parsing problems for assign-style statements with a OO chained lvalue
Thanks, the patch is in 3821c/13690.
Constantin Asofiei
12:36 PM Base Language Bug #5294: parsing problems for assign-style statements with a OO chained lvalue
There is no way to comment out the rule definition itself. You can use @/* */@ or @//@ comments inside a rule to rem... Greg Shah
10:47 AM Base Language Bug #5294: parsing problems for assign-style statements with a OO chained lvalue
Greg, how do I comment the rule in antlr? I can't neither with @/**/@ or with @//@.
These rules need to be commen...
Constantin Asofiei
07:34 AM Database Bug #3896: improve performance of the _lock metadata implementation
Please note that the @_Lock@ VST cleanup in a separate thread should be a rare event. It will happen only if the lock... Igor Skornyakov
07:11 AM Database Bug #3896: improve performance of the _lock metadata implementation
Greg Shah wrote:
> I prefer to avoid executors or Java thread pools. It adds hidden logic to manage threads which m...
Igor Skornyakov
06:49 AM Database Bug #3896: improve performance of the _lock metadata implementation
> I'm planning to use a @SingleThreadExecutor@ shared by all instances of the @LockTableUpdater@ for the background @... Greg Shah
05:07 AM Database Bug #3896: improve performance of the _lock metadata implementation
After fixing an obvious mistake with adding @final@ to the @Empty@ class declaration the smoke test of the large cust... Igor Skornyakov
06:27 AM Database Feature #6187: eliminate explicit buffer usage in can-find
In my opinion, the converted code will read better with @canFind(...)@ than @new FindQuery(...).hasAny()@. Greg Shah
06:23 AM Database Feature #6187: eliminate explicit buffer usage in can-find
We really should just implement a set of static @canFind()@ methods which have the @<dmo>.Buf.class@ as a parameter a... Greg Shah
04:30 AM Database Feature #6187: eliminate explicit buffer usage in can-find
This is still an issue. It can be see with this simple test:... Constantin Asofiei

03/24/2022

03:22 PM Database Bug #3896: improve performance of the _lock metadata implementation
@LockTableUpdater@ is re-worked in the same way as @UserTableStatUpdater@ was re-worked some time ago. No separated t... Igor Skornyakov
02:01 PM Conversion Tools Feature #6202: allow .df files to exist in a path that is not directly in data/
We aren't moving to a database in this task. Even in #5586, the database is only likely to hold non-artifacts. Some... Greg Shah
01:52 PM Conversion Tools Feature #6202: allow .df files to exist in a path that is not directly in data/
Greg Shah wrote:
> Eric: Do you have any comments or concerns?
We have to consider runtime use of these resourc...
Eric Faulhaber

03/23/2022

09:09 AM Conversion Tools Feature #6203: create cvtpath and move conversion database into that directory
As noted in #6202 and #5586, we are going to be moving all intermediate conversion artifacts into a configurable dire... Greg Shah
09:05 AM Conversion Tools Feature #6203 (Closed): create cvtpath and move conversion database into that directory
Greg Shah
09:03 AM Conversion Tools Feature #6202: allow .df files to exist in a path that is not directly in data/
In #4105-52, Roger attempted to organize @.df@ files in subdirectories of @data/@. This worked for the front end sta... Greg Shah
08:38 AM Conversion Tools Feature #6202 (Closed): allow .df files to exist in a path that is not directly in data/
Greg Shah

03/22/2022

02:58 PM Base Language Bug #5288: Some date field character comparisons have runtime incompatibilities during runtime
The attached patch is a partial fix, which hasn't been checked in. I wanted to make sure it is kept with this task. Roger Borrello

03/21/2022

08:16 AM User Interface Bug #4993 (Closed): Overlay prevents input when modal dialog open in embedded mode in Chrome
Confirmed, this is fixed. Greg Shah

03/18/2022

01:47 PM Runtime Infrastructure Feature #5896: enhance legacy REST support to provide better pure Java development
Greg Shah wrote:
> Is it a good idea to have the client code calculate the PK? We have very specific requirements f...
Ovidiu Maxiniuc
08:41 AM Runtime Infrastructure Feature #5896: enhance legacy REST support to provide better pure Java development
Is it a good idea to have the client code calculate the PK? We have very specific requirements for that value, norma... Greg Shah
01:27 AM Runtime Infrastructure Feature #5896: enhance legacy REST support to provide better pure Java development
Eric Faulhaber wrote:
> If we have a factory that can create concrete instances of @Book@, will that meet the need? ...
Constantin Asofiei
08:38 PM Runtime Infrastructure Feature #5896: enhance legacy REST support to provide better pure Java development
If you have the DMO interface available @Class<T> clazz@, then all you need to do is:... Ovidiu Maxiniuc
08:26 AM Database Feature #6187: eliminate explicit buffer usage in can-find
It seems in 2015, this may already have been resolved (from @record_scoping_prep.rules@):... Greg Shah

03/17/2022

06:58 PM Runtime Infrastructure Feature #5896: enhance legacy REST support to provide better pure Java development
If we have a factory that can create concrete instances of @Book@, will that meet the need? The objects it creates wo... Eric Faulhaber
03:03 PM Runtime Infrastructure Feature #5896: enhance legacy REST support to provide better pure Java development
Eric, I have some issues with automatically serializing the DMOs. For OUTPUT, it is easy, just create the JSON.
B...
Constantin Asofiei
12:38 PM Database Bug #3896: improve performance of the _lock metadata implementation
Does it make sense to move @LockTableUpdater.UpdateWorker.fileNums@ map to the @MetadataManager@ (as a value of the m... Igor Skornyakov
07:24 AM Database Feature #6187: eliminate explicit buffer usage in can-find
I don't recall why we require this extra buffer that is not actually a buffer in the 4GL. I do recall how painful th... Greg Shah
07:23 AM Database Feature #6187 (New): eliminate explicit buffer usage in can-find
Greg Shah

03/16/2022

11:53 AM Testing Feature #6183 (WIP): design and implement (as needed) the approach for writing automated 4GL comp...
Greg Shah

03/14/2022

01:39 PM User Interface Bug #6167: Mouse event processing refactoring/improvement
h4. The patch description
h5. Main ideas
# The mouse released event must be dispatched to the widget which is...
Vladimir Tsichevski
01:35 PM User Interface Bug #6167: Mouse event processing refactoring/improvement
Another issue: in WEB, while no mouse buttons is pressed, all mouse events generated have @button=1@ instead of expec... Vladimir Tsichevski
01:33 PM User Interface Bug #6167: Mouse event processing refactoring/improvement
Another problem: in WEB, when the mouse enters a window area, the @MOUSE_ENTER@ event for the window is sent twice fr... Vladimir Tsichevski
01:28 PM User Interface Bug #6167: Mouse event processing refactoring/improvement
h4. WEB event slippage problem
I noticed the following problem with WEB mouse events synchronization:
h5. Situa...
Vladimir Tsichevski
01:24 PM User Interface Bug #6167: Mouse event processing refactoring/improvement
This issue is created after #6013, all customer-specific material removed.
h4. The main issue.
In 4gl, the @MO...
Vladimir Tsichevski
10:57 AM User Interface Bug #6167 (New): Mouse event processing refactoring/improvement
Vladimir Tsichevski

03/13/2022

04:47 AM Database Bug #3896 (WIP): improve performance of the _lock metadata implementation
Igor Skornyakov

03/11/2022

12:50 PM Base Language Feature #6161 (Closed): add support for DYNAMIC-PROPERTY() built-in function and DYNAMIC-PROPERTY...
Greg Shah

03/10/2022

01:51 PM User Interface Bug #6042 (Closed): Nested frame must not be made visible when empty and DISPLAY/ENABLE executed ...
Greg Shah
01:35 PM User Interface Bug #6042: Nested frame must not be made visible when empty and DISPLAY/ENABLE executed on the pa...
I can't replicate this either. Let's close it then. Hynek Cihlar
 

Also available in: Atom