FWD

05/07/2022

03:46 PM Base Language Feature #4065: server-side processing of client platform dependencies

I have some changes which brings memptr fully on server-side (very pin-pointed changes, no major refactoring).
But... Constantin Asofiei

08:22 AM Build and Source Control Bug #6208: cleanup build warnings

Hynek/Ovidiu: Please review the fix_all_compile_warnings_6208_v4.diff.
If the #6208 changes are ready for merge a... Greg Shah

05/06/2022

02:26 PM Runtime Infrastructure Support #5567: move FWD to Java 11

Today I've rebased to latest 3821c and implemented changes/formatings/optimization proposed Ovidiu and started testin... Tomasz Domin

09:12 AM Runtime Infrastructure Support #5567: move FWD to Java 11

Ovidiu Maxiniuc wrote:
> > * make use of @Long/Integer/Character.valueOf@ instead of @new Long/Integer/Character@ ... Tomasz Domin

01:32 AM Base Language Bug #6293 (Rejected): dataset/temp-table options defined in interface

Ovidiu, most likely this is not a real issue. I'm closing it. Constantin Asofiei

05/05/2022

04:23 PM Base Language Bug #6293 (WIP): dataset/temp-table options defined in interface

I am trying to duplicate this but I cannot. Incrementally I created and modified additional classes like this:... Ovidiu Maxiniuc

03:51 AM Base Language Bug #6293: dataset/temp-table options defined in interface

This was created after reviewing some customer application code, where I noticed that the temp-table at the interface... Constantin Asofiei

12:47 PM Runtime Infrastructure Support #5567: move FWD to Java 11

Tomasz Domin wrote:
> My understanding of this task is migrating codebase and toolset to Java 11. I took the opportu... Ovidiu Maxiniuc

11:53 AM Runtime Infrastructure Support #5567: move FWD to Java 11

Copied from #6208#note-25 as it matches here better:
My understanding of this task is migrating codebase and tools... Tomasz Domin

12:16 PM Build and Source Control Bug #6208: cleanup build warnings

Ovidiu Maxiniuc wrote:
> Review of r13835/5567a (branched from r13827/3821a)
> * @SecondLevelCacheStatistics@, @Sta... Tomasz Domin

10:52 AM Runtime Infrastructure Bug #6084: NIO SSL performance is slower than standard Java SSL

Greg Shah wrote:
> In #5384, Hynek implemented Conscrypt support for the web client communication (Java client SSL t... Hynek Cihlar

05/04/2022

04:11 PM Build and Source Control Bug #6208: cleanup build warnings

I noticed that changes for #6208 are already in 5567a. They were the only files with history entry added :). I saw no... Ovidiu Maxiniuc

03:56 PM Build and Source Control Bug #6208: cleanup build warnings

Greg Shah wrote:
> Hynek/Ovidiu: Please review 5567a.
I meant that #6208 is ready and it is integrated into 5567a... Tomasz Domin

10:55 AM Conversion Tools Feature #6320: sharded schemata

We have multiple customers that split up a large 4GL application into multiple independent modules, each of which can... Greg Shah

10:51 AM Conversion Tools Feature #6320 (WIP): sharded schemata

Greg Shah

10:47 AM Conversion Tools Feature #6319: IntelliJ plugin

IntelliJ plugin for integration with syntax check and running conversion (et al). This must also provide the full sup... Greg Shah

10:44 AM Conversion Tools Feature #6319 (Rejected): IntelliJ plugin

Greg Shah

10:31 AM Runtime Infrastructure Support #5567: move FWD to Java 11

Greg Shah wrote:
> > Actually I am using <replace> tasks to replace string in generated java file, as there is only ... Tomasz Domin

05/03/2022

03:23 PM Build and Source Control Bug #6208: cleanup build warnings

Review of r13835/5567a (branched from r13827/3821a)
* general: each file's header must be updated with a new histori... Ovidiu Maxiniuc

06:29 AM Build and Source Control Bug #6208: cleanup build warnings

Hynek/Ovidiu: Please review 5567a. Greg Shah

09:23 AM Database Bug #6310: for first "first()", exclusive-lock, raises FWD exception while 4GL raises at the fiel...

Greg Shah wrote:
> Please create a bug in the Database project for this issue. We will focus on item 1 and then see... Tijs Wickardt

08:56 AM Database Bug #6310: for first "first()", exclusive-lock, raises FWD exception while 4GL raises at the fiel...

Greg Shah wrote:
> In regard to the unrelated issues, make a list and post them here. We will move them to another ... Tijs Wickardt

08:55 AM Database Bug #6310 (New): for first "first()", exclusive-lock, raises FWD exception while 4GL raises at th...

Tijs Wickardt

07:03 AM Runtime Infrastructure Feature #5776: reduce memory requirements for the FWD client

> The BLOB and CLOB support was added in #3500. That task has no useful details about the actual implementation, jus... Greg Shah

07:01 AM User Interface Feature #5742: improve web client startup time

We have another case where a customer's system (based on Amazon Linux which is in turn based on RedHat/CentOS) showed... Greg Shah

06:45 AM Runtime Infrastructure Support #5567: move FWD to Java 11

> > I don't think we need to be dynamic. Download it and manually modify the code. We will post the customized vers... Greg Shah

05/02/2022

04:02 PM Runtime Infrastructure Support #5567: move FWD to Java 11

Greg Shah wrote:
> I don't think we need to be dynamic. Download it and manually modify the code. We will post the... Tomasz Domin

03:33 PM Build and Source Control Bug #6208: cleanup build warnings

So I did.
Updated patch attached to the ticket.
Its already integrated into #5567 Tomasz Domin

11:02 AM Conversion Tools Feature #6256: improved profile support

If there were a need for 2 main database configured:
# a *merged* configuration with all schemas in one database, na... Roger Borrello

10:25 AM Conversion Tools Feature #6256: improved profile support

Sorry, failed refresh. Ovidiu Maxiniuc

10:24 AM Conversion Tools Feature #6256: improved profile support

Eric Faulhaber wrote:
> Ovidiu, do I understand correctly that when the @importFile@ attribute of @namespace@ is spe... Ovidiu Maxiniuc

10:26 AM Conversion Tools Feature #6302: Improve conversion of empty OCX arguments

This issue does not appear in known customer scenarios, so its severity reduced to LOW. Vladimir Tsichevski

09:32 AM Database Bug #3896 (Closed): improve performance of the _lock metadata implementation

Eric Faulhaber

08:05 AM Database Bug #3896: improve performance of the _lock metadata implementation

Greg Shah wrote:
> Is this complete?
I think so. Igor Skornyakov

08:04 AM Database Bug #3896: improve performance of the _lock metadata implementation

Is this complete? Greg Shah

08:10 AM Runtime Infrastructure Bug #6084: NIO SSL performance is slower than standard Java SSL

In #5384, Hynek implemented Conscrypt support for the web client communication (Java client SSL to web client over th... Greg Shah

06:46 AM User Interface Bug #6267 (Review): StackOverflowError in BROWSE widget

Constantin, please review the committed revision 13835(3821c). Sergey Ivanovskiy

05/01/2022

11:43 AM Conversion Tools Feature #6256: improved profile support

The current changes are in 6129a/13823. Constantin Asofiei

04/30/2022

05:20 PM Conversion Tools Feature #6256: improved profile support

Greg Shah wrote:
> We can defer any conversion issues until a second phase of work. The front end part is what is n... Constantin Asofiei

02:53 PM Conversion Tools Feature #6256: improved profile support

We can defer any conversion issues until a second phase of work. The front end part is what is needed this week. Greg Shah

02:49 PM Conversion Tools Feature #6256: improved profile support

Greg Shah wrote:
> My idea was to add an extra layer at the ConversionDriver level, which would associate the profil... Constantin Asofiei

02:32 PM Conversion Tools Feature #6256: improved profile support

My idea was to add an extra layer at the ConversionDriver level, which would associate the profile with some sub-set ... Greg Shah

02:30 PM Conversion Tools Feature #6256: improved profile support

> What if a file is part of multiple profiles?
The profiles are intended to be mutually-exclusive. We can define ... Greg Shah

02:26 PM Conversion Tools Feature #6256: improved profile support

Greg Shah wrote:
> The files specified for the profile should be parsed/converted with the same settings as if the p... Constantin Asofiei

02:15 PM Conversion Tools Feature #6256: improved profile support

When I said the multiple profile merge was needed, I meant a different idea.
Each profile can be run standalone. ... Greg Shah

02:07 PM Conversion Tools Feature #6256: improved profile support

So, the approach is this:
* multiple profiles are allowed (only for conversion time), and they can be specified via ... Constantin Asofiei

02:04 PM Conversion Tools Feature #6256: improved profile support

Eric: I think the shard idea makes good sense. We have multiple customers using this approach in OE today. The idea... Greg Shah

01:59 PM Conversion Tools Feature #6256: improved profile support

A useful addition (medium term, not immediately) would be to be able to load multiple DF files into a single schema n... Eric Faulhaber

01:03 PM Conversion Tools Feature #6256: improved profile support

Greg Shah wrote:
> The multi-profile merge mode is needed as part of this task.
This will be only for conversion. ... Constantin Asofiei

01:00 PM Conversion Tools Feature #6256: improved profile support

It is a good plan. Greg Shah

12:22 PM Conversion Tools Feature #6256: improved profile support

Constantin Asofiei wrote:
> * if no profile is set as default, let the global configuration be the default, unless o... Constantin Asofiei

12:20 PM Conversion Tools Feature #6256: improved profile support

Greg Shah wrote:
> > The @SchemaConfig$Profile@ has a @isDefault@, which suggests that there can be a @isDefault@ at... Constantin Asofiei

12:13 PM Conversion Tools Feature #6256: improved profile support

Greg Shah wrote:
> The multi-profile merge mode is needed as part of this task.
Understood.
Constantin Asofiei

12:12 PM Conversion Tools Feature #6256: improved profile support

> Do you see a need to make the profile/schema node optional? In this case, it would be inherited from the global con... Greg Shah

12:10 PM Conversion Tools Feature #6256: improved profile support

Do you see a need to make the @profile/schema@ node optional? In this case, it would be inherited from the global con... Constantin Asofiei

11:27 AM Conversion Tools Feature #6256: improved profile support

I don't think there is a hard requirement for that at the profile level. Greg Shah

11:26 AM Conversion Tools Feature #6256: improved profile support

> The @SchemaConfig$Profile@ has a @isDefault@, which suggests that there can be a @isDefault@ attribute at the @prof... Greg Shah

11:26 AM Conversion Tools Feature #6256: improved profile support

Greg Shah wrote:
> The namespace should assume @default="true"@ so that it doesn't have to be duplicated. But it sh... Constantin Asofiei

11:24 AM Conversion Tools Feature #6256: improved profile support

The namespace should assume @default="true"@ so that it doesn't have to be duplicated. But it should be possible to ... Greg Shah

11:12 AM Conversion Tools Feature #6256: improved profile support

The @profile@ node has only @name@ attribute in #6256-8.
The @SchemaConfig$Profile@ has a @isDefault@, which sugge... Constantin Asofiei

10:03 AM Conversion Tools Feature #6256: improved profile support

> At least the syntax in note 5 is no longer valid, right?
Right. Greg Shah

09:56 AM Conversion Tools Feature #6256: improved profile support

Greg Shah wrote:
> Is there some other use case I'm missing?
I don't think so.
> We already handle the namespace... Constantin Asofiei

09:49 AM Conversion Tools Feature #6256: improved profile support

> When running in single profile mode, the profile will need to overwrite default @parameter@ and @file-set@ nodes,
... Greg Shah

09:48 AM Conversion Tools Feature #6256: improved profile support

> each profile has the same syntax as the 'global' profile (so the namespace nodes would be added in a schema node)
... Greg Shah

09:39 AM Conversion Tools Feature #6256: improved profile support

When running in single profile mode, the profile will need to overwrite default @parameter@ and @file-set@ nodes, and... Constantin Asofiei

09:35 AM Conversion Tools Feature #6256: improved profile support

Greg/Eric: my thought would be the profiles to work like this:
* there is the 'global' profile which is used implici... Constantin Asofiei

02:17 PM Base Language Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...

In @annotations/naming.rules@ we use @ConvertedClassName.addMethod()@ to add entries for the c'tors. It seems like t... Greg Shah

02:12 PM Base Language Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...

Greg Shah wrote:
> > If that is removed, the prerequisite (for conversion to complete) will be to have stubbed skele... Constantin Asofiei

02:07 PM Base Language Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...

> If that is removed, the prerequisite (for conversion to complete) will be to have stubbed skeletons in p2j.oo for a... Greg Shah

04/29/2022

02:54 PM Runtime Infrastructure Support #5567: move FWD to Java 11

I don't think we need to be dynamic. Download it and manually modify the code. We will post the customized version ... Greg Shah

02:20 PM Runtime Infrastructure Support #5567: move FWD to Java 11

Today:
* Rebased to latest (fixed) version of 3821c
* Fixed more warnings - committed today: 5567a/13834
* Started... Tomasz Domin

02:51 PM Build and Source Control Bug #6208: cleanup build warnings

I assume we would remove the @&#64;Deprecated@. Greg Shah

02:20 PM Build and Source Control Bug #6208: cleanup build warnings

As code lives on there are new warnings to be removed like:... Tomasz Domin

01:49 PM Conversion Tools Bug #6308: post string literal alternative coding quirk in 4GL preprocessor

The function issue is actually a 4GL preprocessor quirk. I've created a testcase and checked it into [[p2j:Old UAST ... Greg Shah

01:46 PM Conversion Tools Bug #6308 (Internal Test): post string literal alternative coding quirk in 4GL preprocessor

Greg Shah

05:33 AM User Interface Bug #6038: ComboBox setScreenValue improvements

Marian Edu wrote:
> Guys, I'm trying to close this somehow but although I've tried to keep the current implementatio... Hynek Cihlar

04:15 AM User Interface Bug #6267: StackOverflowError in BROWSE widget

If @cpinternal@ is @UTF-8@, then 4GL calculates a key codepoint using reverse mapping of bytes to integer in reverse ... Sergey Ivanovskiy

03:25 AM Conversion Tools Feature #6302: Improve conversion of empty OCX arguments

Vladimir, is there a customer app failing test case for this? If not I suggest you make this lower priority. Hynek Cihlar

03:06 AM Conversion Tools Feature #6302: Improve conversion of empty OCX arguments

Vladimir Tsichevski wrote:
> The @.ast@ file seems to be correct (all parameters in the call are present, but in @.j... Hynek Cihlar

04/28/2022

07:29 PM Conversion Tools Feature #6302: Improve conversion of empty OCX arguments

The @.ast@ file seems to be correct (all parameters in the call are present, but in @.jast@ file parameters for the @... Vladimir Tsichevski

07:08 PM Conversion Tools Feature #6302: Improve conversion of empty OCX arguments

Vladimir Tsichevski wrote:
> Tijs Wickardt wrote:
>
> > The OpenEdge documentation states explicitly that OCX's a... Tijs Wickardt

06:18 PM Conversion Tools Feature #6302: Improve conversion of empty OCX arguments

Tijs Wickardt wrote:
> FYI: see @testcases/oxc_to_fwd/mscomctl-treeview-ocx.w@ :
> @hNode = chCfTreeView:TreeView:... Vladimir Tsichevski

06:10 PM Conversion Tools Feature #6302: Improve conversion of empty OCX arguments

Tijs Wickardt wrote:
> The OpenEdge documentation states explicitly that OCX's are 0-based, not 1-based like the 4... Vladimir Tsichevski

03:19 PM Conversion Tools Feature #6302: Improve conversion of empty OCX arguments

Tijs Wickardt wrote:
> Vladimir Tsichevski wrote:
> > Seems, I was not right here: undefined values *can* be used b... Vladimir Tsichevski

03:16 PM Conversion Tools Feature #6302: Improve conversion of empty OCX arguments

Vladimir Tsichevski wrote:
> Seems, I was not right here: undefined values *can* be used by OE to pass the "default"... Tijs Wickardt

02:50 PM Conversion Tools Feature #6302 (WIP): Improve conversion of empty OCX arguments

Seems, I was not right here: undefined values *can* be used by OE to pass the "default" value to OCX. Moreover, undef... Vladimir Tsichevski

01:15 PM Conversion Tools Feature #6302: Improve conversion of empty OCX arguments

This issue must be fixed along with: #5622-12. Otherwise no compilable code is created by conversion for this call. Vladimir Tsichevski

09:20 AM Conversion Tools Feature #6302: Improve conversion of empty OCX arguments

Hynek Cihlar wrote:
> @hNode.assign(hTree.unwrapTreeView().getNodes().unwrapTreeNodeCollection().add(new integer()... Tijs Wickardt

09:16 AM Conversion Tools Feature #6302: Improve conversion of empty OCX arguments

FYI: see @testcases/oxc_to_fwd/mscomctl-treeview-ocx.w@ :
@hNode = chCfTreeView:TreeView:Nodes:Add(,,cParentNodeID,... Tijs Wickardt

08:43 AM Conversion Tools Feature #6302: Improve conversion of empty OCX arguments

The function parameter specification in COM type library may contain a default value. Perhaps this is the value used ... Hynek Cihlar

08:32 AM Conversion Tools Feature #6302: Improve conversion of empty OCX arguments

Empty arguments of converted OCX method invocations are converted into "unknown" instances.
For example the follo... Hynek Cihlar

08:23 AM Conversion Tools Feature #6302 (WIP): Improve conversion of empty OCX arguments

Hynek Cihlar

01:34 PM Base Language Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...

Greg Shah wrote:
> > The main reason the converter is used is the case when we don't have a counterpart skeleton in ... Constantin Asofiei

01:28 PM Base Language Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...

> The main reason the converter is used is the case when we don't have a counterpart skeleton in FWD, just the .cls f... Greg Shah

09:40 AM Base Language Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...

Greg Shah wrote:
> I've spent the last few days trying to stabilize and finish my previous work. I'm deep into the ... Constantin Asofiei

09:15 AM Base Language Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...

I've spent the last few days trying to stabilize and finish my previous work. I'm deep into the changes to eliminate... Greg Shah

12:10 PM Conversion Tools Feature #6256: improved profile support

Yes, the syntax is OK. Greg Shah

12:00 PM Conversion Tools Feature #6256 (WIP): improved profile support

Incorporating the above suggestions/requirements, I have updated the sample configuration as follows:... Eric Faulhaber

07:25 AM Conversion Tools Feature #6256: improved profile support

Greg Shah wrote:
> > I'm assuming (for now) that profile *.df files will be found in ./data/<profile-name>/.
> No, ... Ovidiu Maxiniuc

11:40 AM Database Feature #1587: implement full support for word indexes

I encountered in a customer's data dump the following situation:
The @.df@ file looks like this:... Ovidiu Maxiniuc

10:48 AM User Interface Bug #5622: TREEVIEW widget issues

Vladimir Tsichevski wrote:
> Tijs Wickardt wrote:
>
> > Interesting. A possible third explanation: OE stores the ... Tijs Wickardt

10:35 AM User Interface Bug #5622: TREEVIEW widget issues

Tijs Wickardt wrote:
> Interesting. A possible third explanation: OE stores the default OCX values in the wrx. If ... Vladimir Tsichevski

10:01 AM User Interface Bug #5622: TREEVIEW widget issues

Vladimir Tsichevski wrote:
> > I see two explanations here. OE either looks in the type library where default param ... Tijs Wickardt

09:34 AM User Interface Bug #5622: TREEVIEW widget issues

Hynek Cihlar wrote:
> > And this value must *not* be the 4gl @undefined@, because, by my observations, sending @un... Vladimir Tsichevski

08:44 AM User Interface Bug #5622: TREEVIEW widget issues

I created #6302 to cover the empty arguments issue. Hynek Cihlar

08:41 AM User Interface Bug #5622: TREEVIEW widget issues

Vladimir Tsichevski wrote:
> Hynek Cihlar wrote:
>
> > It is on the OCX object to determine what the default valu... Hynek Cihlar

08:30 AM User Interface Bug #5622: TREEVIEW widget issues

Hynek Cihlar wrote:
> It is on the OCX object to determine what the default value is when an empty argument is giv... Vladimir Tsichevski

03:30 AM User Interface Bug #5622: TREEVIEW widget issues

Hynek Cihlar wrote:
> Vladimir Tsichevski wrote:
> > Hynek Cihlar wrote:
> >
> > > I assume you mean the followi... Hynek Cihlar

03:27 AM User Interface Bug #5622: TREEVIEW widget issues

Vladimir Tsichevski wrote:
> Hynek Cihlar wrote:
>
> > I assume you mean the following statement: @hNode = chCfTr... Hynek Cihlar

06:59 AM Base Language Feature #3310: add support for the equivalent of the OpenEdge Web Services Adapter (and ProxyGen)...

Constantin Asofiei wrote:
> Greg Shah wrote:
> > > In FWD, I don't see a reason to emit this 'book' class which ju... Constantin Asofiei

05:39 AM User Interface Bug #6267: StackOverflowError in BROWSE widget

I found that the issue is in @Utils.toChar(int)@ that is used for converting a codepoint to a character. If an input ... Sergey Ivanovskiy

04/27/2022

07:27 PM Conversion Tools Feature #6256: improved profile support

> Is this the right vision?
Mostly, yes. The part I don't understand is why there is a @schema@ node inside the @... Greg Shah

06:07 PM Conversion Tools Feature #6256: improved profile support

At this moment the structure of the configuration file is:... Ovidiu Maxiniuc

04:59 PM Conversion Tools Feature #6256: improved profile support

To translate the above configuration requirements into a sample @p2j.cfg.xml@, I understand it should look something ... Eric Faulhaber

07:24 PM User Interface Bug #5622: TREEVIEW widget issues

Vladimir Tsichevski wrote:
> Tijs Wickardt wrote:
> > On Wed 2022-04-20 we parked some @treeview@ issues. See @xfer... Tijs Wickardt

06:51 PM User Interface Bug #5622: TREEVIEW widget issues

Hynek Cihlar wrote:
> I assume you mean the following statement: @hNode = chCfTreeView:TreeView:Nodes:Add(,,cParen... Vladimir Tsichevski

06:17 PM User Interface Bug #5622: TREEVIEW widget issues

Another difference: in OCX the first argument to the @add@ procedure is a 1-based node index, and cannot be zero.
In... Vladimir Tsichevski

01:16 PM User Interface Bug #5622: TREEVIEW widget issues

Tijs Wickardt wrote:
> On Wed 2022-04-20 we parked some @treeview@ issues. See @xfer testcases@ , @ocx_to_fwd/mscomc... Vladimir Tsichevski

05:32 AM User Interface Bug #5622: TREEVIEW widget issues

Tijs Wickardt wrote:
> On Wed 2022-04-20 we parked some @treeview@ issues. See @xfer testcases@ , @ocx_to_fwd/mscomc... Hynek Cihlar

02:33 AM User Interface Bug #5622: TREEVIEW widget issues

On Wed 2022-04-20 we parked some @treeview@ issues. See @xfer testcases@ , @ocx_to_fwd/mscomctl-treeview-ocx.readme.t... Tijs Wickardt

03:21 PM Base Language Feature #3310: add support for the equivalent of the OpenEdge Web Services Adapter (and ProxyGen)...

Greg Shah wrote:
> > In FWD, I don't see a reason to emit this 'book' class which just allows to call 'book.create'... Constantin Asofiei

03:19 PM Base Language Feature #3310: add support for the equivalent of the OpenEdge Web Services Adapter (and ProxyGen)...

> In FWD, I don't see a reason to emit this 'book' class which just allows to call 'book.create' instead of working ... Greg Shah

01:53 PM Base Language Feature #3310: add support for the equivalent of the OpenEdge Web Services Adapter (and ProxyGen)...

Greg, in OE the proxy Java Open Client allows a 'SubAppObject' which groups access to the programs in its own Java cl... Constantin Asofiei

01:29 PM Database Bug #6301: incorrect initialization of date-related fields with today and now literals

The issue can be observed at runtime: the "now" moment is not evaluated for each record at the moment the record is c... Ovidiu Maxiniuc

01:18 PM Database Bug #6301 (Test): incorrect initialization of date-related fields with today and now literals

Ovidiu Maxiniuc

07:42 AM Database Bug #3896: improve performance of the _lock metadata implementation

Eric Faulhaber wrote:
> As noted earlier, I don't want to address this unless we find it's needed. Let's go with the... Igor Skornyakov

07:34 AM Database Bug #3896: improve performance of the _lock metadata implementation

Greg Shah wrote:
> The moment that the @_lock@ table is ever accessed by converted 4GL code, maintenance starts. At... Igor Skornyakov

07:32 AM Database Bug #3896: improve performance of the _lock metadata implementation

Igor Skornyakov wrote:
> Actually, what Eric suggests (the batch VST cleanup) can reduce the duration of the maint... Eric Faulhaber

07:28 AM Database Bug #3896: improve performance of the _lock metadata implementation

The moment that the @_lock@ table is ever accessed by converted 4GL code, maintenance starts. At that point, the @_l... Greg Shah

07:22 AM Database Bug #3896: improve performance of the _lock metadata implementation

Greg Shah wrote:
> > The actual maintenance starts when the first lock persisted because of the access is released.
... Igor Skornyakov

07:16 AM Database Bug #3896: improve performance of the _lock metadata implementation

> The actual maintenance starts when the first lock persisted because of the access is released.
By "access is rel... Greg Shah

06:59 AM Database Bug #3896: improve performance of the _lock metadata implementation

Greg Shah wrote:
> The moment any access to the @_lock@ table occurs, we start expending CPU cycles maintaining that... Igor Skornyakov

06:55 AM Database Bug #3896: improve performance of the _lock metadata implementation

The moment any access to the @_lock@ table occurs, we start expending CPU cycles maintaining that table. Do I unders... Greg Shah

06:47 AM Database Bug #3896: improve performance of the _lock metadata implementation

Greg Shah wrote:
> > Moreover, we submit a clean task only if we see that the lock data was persisted.
>
> What d... Igor Skornyakov

06:39 AM Database Bug #3896: improve performance of the _lock metadata implementation

> Moreover, we submit a clean task only if we see that the lock data was persisted.
What do you mean by "persisted... Greg Shah

06:27 AM Database Bug #3896: improve performance of the _lock metadata implementation

Greg Shah wrote:
> > After all, if we expect that user access to the _Lock table will be rare, then the cost of the ... Igor Skornyakov

06:19 AM Database Bug #3896: improve performance of the _lock metadata implementation

> After all, if we expect that user access to the _Lock table will be rare, then the cost of the background maintenan... Greg Shah

06:11 AM Database Bug #3896: improve performance of the _lock metadata implementation

Greg Shah wrote:
> Eric controls this decision.
>
> I am not suggesting leaving the code as you have written it. ... Igor Skornyakov

05:54 AM Database Bug #3896: improve performance of the _lock metadata implementation

Eric controls this decision.
I am not suggesting leaving the code as you have written it. I am suggesting that th... Greg Shah

05:47 AM Database Bug #3896: improve performance of the _lock metadata implementation

Greg Shah wrote:
> Are we *really, really sure* that this incremental maintenance approach is needed? The @_lock@ d... Igor Skornyakov

05:36 AM Database Bug #3896: improve performance of the _lock metadata implementation

Are we *really, really sure* that this incremental maintenance approach is needed? The @_lock@ data is expected to b... Greg Shah

02:27 AM Database Bug #3896: improve performance of the _lock metadata implementation

Eric Faulhaber wrote:
> Nevertheless, the above scenario could happen (who knows how developers have instrumented so... Igor Skornyakov

02:17 AM Database Bug #3896: improve performance of the _lock metadata implementation

Eric Faulhaber wrote:
> Well, the block nesting of the test seems a little odd to me, but it should work. You must... Igor Skornyakov

11:00 PM Database Bug #3896: improve performance of the _lock metadata implementation

Igor Skornyakov wrote:
> Eric Faulhaber wrote:
> > Why are we hitting the VST on a state change event? Presumably, ... Eric Faulhaber

10:20 PM Database Bug #3896: improve performance of the _lock metadata implementation

Igor Skornyakov wrote:
> I see some strange results with a simple 4GL test.
> Consider the following program:
> [.... Eric Faulhaber

07:16 AM User Interface Bug #6038: ComboBox setScreenValue improvements

Greg Shah wrote:
> ** if multiple different format strings are defined (e.g. explicit @FORMAT ""@ definitions or imp... Marian Edu

05:57 AM User Interface Bug #6267: StackOverflowError in BROWSE widget

I tested FWD with WINDOWS-1252 and the changes discussed in this thread and found many new issues for Swing and Web c... Sergey Ivanovskiy

04/26/2022

03:56 PM User Interface Bug #6267: StackOverflowError in BROWSE widget

It is okey. I cannot find how to setup of @i18n@ node in the directory. Is @i18n@ a node of @container@ class?
<pre... Sergey Ivanovskiy

02:47 PM User Interface Bug #6267: StackOverflowError in BROWSE widget

Sergey Ivanovskiy wrote:
> Sergey Ivanovskiy wrote:
> > It seems that the @Keyboard@ can use unicode codepoints whe... Hynek Cihlar

02:32 PM User Interface Bug #6267: StackOverflowError in BROWSE widget

Sergey Ivanovskiy wrote:
> It seems that the @Keyboard@ can use unicode codepoints when it initializes basic keys
>... Sergey Ivanovskiy

06:41 AM User Interface Bug #6267: StackOverflowError in BROWSE widget

It seems that the @Keyboard@ can use unicode codepoints when it initializes basic keys... Sergey Ivanovskiy

06:36 AM User Interface Bug #6267: StackOverflowError in BROWSE widget

If integer value is within [0, 255], then it can be decoded using the current internal codepage given by @cpinternal@... Sergey Ivanovskiy

01:46 PM Base Language Feature #6300 (Closed): class definitions with USE-WIDGET-POOL

Greg Shah

01:07 PM Base Language Feature #4354 (Closed): add GET-CLASS() function support

Greg Shah

01:06 PM Base Language Feature #4354: add GET-CLASS() function support

Greg Shah wrote:
> Is there anything remaining to work on for this task?
No. Constantin Asofiei

01:05 PM Base Language Feature #4354: add GET-CLASS() function support

Is there anything remaining to work on for this task? Greg Shah

12:41 PM Runtime Infrastructure Support #5567: move FWD to Java 11

> antlr warnings are related with objects representing numbers instantiation:
Let's just modify ANTLR 2.7.7 to fix... Greg Shah

10:57 AM User Interface Bug #6298: Display using format

> Question - do we need to handle the case when the @value@ passed to @setScreenValue@ might be @FormatedValue@ (by l... Greg Shah

06:44 AM User Interface Bug #6298: Display using format

Looking at some issues with screen-value when the widget is using a custom format and the @display@ statement is used... Marian Edu

06:25 AM User Interface Bug #6298 (New): Display using format

Marian Edu

10:56 AM User Interface Bug #6038: ComboBox setScreenValue improvements

Our current approach can be described like this:
* static widgets (both client-side and server-side) are aware of ... Greg Shah

08:52 AM Conversion Tools Feature #6255: simplify the namespace configuration, part deux

What was frustrating was that in my local testing worked, but with the main project it abended - and this was only be... Constantin Asofiei

06:24 AM Database Bug #3896: improve performance of the _lock metadata implementation

I see some strange results with a simple 4GL test.
Consider the following program:... Igor Skornyakov

04/25/2022

04:33 PM Database Bug #3896: improve performance of the _lock metadata implementation

Eric Faulhaber wrote:
> Code review @_lock3.diff@ (applied to 3821c/13813):
>
> 1) I didn't notice this when I re... Igor Skornyakov

03:21 PM Database Bug #3896: improve performance of the _lock metadata implementation

Code review @_lock3.diff@ (applied to 3821c/13813):
1) I didn't notice this when I reviewed an earlier version of ... Eric Faulhaber

03:42 PM Runtime Infrastructure Support #5567: move FWD to Java 11

Rebased to latest 3821c and still testing Tomasz Domin

01:44 PM Runtime Infrastructure Support #5567: move FWD to Java 11

Greg Shah wrote:
> Please show an example.
antlr warnings are related with objects representing numbers instantiati... Tomasz Domin

02:09 PM User Interface Bug #6267: StackOverflowError in BROWSE widget

OK, fix it. Greg Shah

01:59 PM User Interface Bug #6267: StackOverflowError in BROWSE widget

I checked that Apply statement interprets integer expression according to @cpinternal@ code page so @APPLY 225 TO EDI... Sergey Ivanovskiy

11:58 AM User Interface Bug #6267: StackOverflowError in BROWSE widget

Our approach is to use Unicode throughout all internal Java/Javascript code and we only convert to/from the @CPINTERN... Greg Shah

11:00 AM User Interface Bug #6267: StackOverflowError in BROWSE widget

I cannot answer these two questions. In this code... Sergey Ivanovskiy

01:20 PM Base Language Feature #6292: nested catch blocks

A conversion fix for this is complete, but the runtime is not completed (the 'catchBlock' implementation). Constantin Asofiei

12:55 PM Base Language Feature #6292: nested catch blocks

See #6277-4 and #6277-5. Greg Shah

12:54 PM Base Language Feature #6292 (Closed): nested catch blocks

Greg Shah

01:18 PM Base Language Bug #6293: dataset/temp-table options defined in interface

It is possible to have this:... Constantin Asofiei

01:16 PM Base Language Bug #6293 (Rejected): dataset/temp-table options defined in interface

Constantin Asofiei

04/24/2022

09:07 AM Conversion Tools Feature #6255: simplify the namespace configuration, part deux

With 13811, the metadata schema can be loaded twice. This was seen in a customer project which then had ambiguous re... Greg Shah

04/22/2022

06:28 PM Conversion Tools Feature #6255 (WIP): simplify the namespace configuration, part deux

The implementation for the initial two requests can be found in FWD starting with r13811 of 3821c.
We should keep ... Ovidiu Maxiniuc

03:22 PM User Interface Bug #6267: StackOverflowError in BROWSE widget

It looks like the code from @I18nOps@ isn't used by @Keyboard@ but @String cset = Utils.getCharsetOverride();@ is use... Sergey Ivanovskiy

01:51 PM User Interface Bug #6267: StackOverflowError in BROWSE widget

Thank you. I have found this code @I18nOps@ too. Sergey Ivanovskiy

01:39 PM User Interface Bug #6267: StackOverflowError in BROWSE widget

Sergey Ivanovskiy wrote:
> Could you point me what is code that is responsible for providing @cpinternal@ and @cpstr... Greg Shah

01:36 PM User Interface Bug #6267: StackOverflowError in BROWSE widget

Could you point me what is code that is responsible for providing @cpinternal@ and @cpstream@ codepage settings? I wo... Sergey Ivanovskiy

01:27 PM Runtime Infrastructure Feature #5896: enhance legacy REST support to provide better pure Java development

OK, at a minimum, it seems like we need a list of those paths which are unsecured. These are publicly visible and re... Greg Shah

12:42 PM Runtime Infrastructure Feature #5896: enhance legacy REST support to provide better pure Java development

Greg, this is a 'chicken and the egg' problem. Lets say an application secures only the @/rest/private/@ paths and l... Constantin Asofiei

12:31 PM Runtime Infrastructure Feature #5896: enhance legacy REST support to provide better pure Java development

> If I use defaults for @login_path@, this mode where authentication is done at each call will no longer work.
Wha... Greg Shah

12:08 PM Runtime Infrastructure Feature #5896: enhance legacy REST support to provide better pure Java development

The structure of an ACL to check if a path must be authenticated is:... Constantin Asofiei

12:08 PM Runtime Infrastructure Feature #5896: enhance legacy REST support to provide better pure Java development

Greg Shah wrote:
> Constantin Asofiei wrote:
> > If I force defaults for @rest/authentication/login_path@ and @rest... Constantin Asofiei

12:05 PM Runtime Infrastructure Feature #5896: enhance legacy REST support to provide better pure Java development

Constantin Asofiei wrote:
> If I force defaults for @rest/authentication/login_path@ and @rest/authentication/logout... Greg Shah

06:38 AM Runtime Infrastructure Feature #5896: enhance legacy REST support to provide better pure Java development

If I force defaults for @rest/authentication/login_path@ and @rest/authentication/logout_path@, to @/fwdlogin@ and @/... Constantin Asofiei

11:52 AM Runtime Infrastructure Support #5567: move FWD to Java 11

Tomasz Domin wrote:
> Greg Shah wrote:
> > > Unfortunately antlr generated code will produce warnings in Java 11 un... Greg Shah

10:10 AM Runtime Infrastructure Support #5567: move FWD to Java 11

Today I refactored code to make use of ReflectiveOperationException on .newInstance (instead of 4 other exceptions), ... Tomasz Domin

05:42 AM Runtime Infrastructure Support #5567: move FWD to Java 11

Greg Shah wrote:
> > Unfortunately antlr generated code will produce warnings in Java 11 until we migrate to newer v... Tomasz Domin

04/21/2022

05:51 PM User Interface Bug #6267: StackOverflowError in BROWSE widget

> I'll commit the fix for double @super.processKeyEvent(ke)@
Committed as 3821c rev 13808.
Stanislav Lomany

05:15 PM User Interface Bug #6267: StackOverflowError in BROWSE widget

> Theoretically, no, @return isPrintable(keyLabel(key));@ should be enough, as those places have already the proper @... Stanislav Lomany

10:53 AM User Interface Bug #6267: StackOverflowError in BROWSE widget

Stanislav Lomany wrote:
> What about the cases when @isReal@ flag is @true@, but it's not called from @EventManager.... Constantin Asofiei

10:44 AM User Interface Bug #6267: StackOverflowError in BROWSE widget

What about the cases when @isReal@ flag is @true@, but it's not called from @EventManager.getKeyEvent@? Do we preserv... Stanislav Lomany

05:47 AM User Interface Bug #6267: StackOverflowError in BROWSE widget

Stanislav Lomany wrote:
> > I agree, a replacement to be called by @EventManager.getKeyEvent@, when @isReal@ flag is... Constantin Asofiei

04:02 AM User Interface Bug #6267: StackOverflowError in BROWSE widget

Stanislav, I would propose to discuss the following topics:
# To add a special keyboard layout to handle Cyrillic ch... Sergey Ivanovskiy

08:14 PM User Interface Bug #6267: StackOverflowError in BROWSE widget

> I agree, a replacement to be called by @EventManager.getKeyEvent@, when @isReal@ flag is true.
Constantin, do ... Stanislav Lomany

12:46 PM Runtime Infrastructure Support #5567: move FWD to Java 11

> Unfortunately antlr generated code will produce warnings in Java 11 until we migrate to newer version (which is a s... Greg Shah

12:36 PM Runtime Infrastructure Support #5567: move FWD to Java 11

Today I've mainly worked on changes to newInstance and datatypes conversion, static accessors
Unfortunately antlr g... Tomasz Domin

11:38 AM Runtime Infrastructure Feature #5896: enhance legacy REST support to provide better pure Java development

Greg Shah wrote:
> > or just disable the authentication at the rest/soap/webhandler nodes in the directory.
>
> W... Constantin Asofiei

11:18 AM Runtime Infrastructure Feature #5896: enhance legacy REST support to provide better pure Java development

> or just disable the authentication at the rest/soap/webhandler nodes in the directory.
What is the advantage of ... Greg Shah

11:14 AM Runtime Infrastructure Feature #5896: enhance legacy REST support to provide better pure Java development

Greg Shah wrote:
> This approach requires an explicit intervention to open everything. But that intervention is not... Constantin Asofiei

11:13 AM Runtime Infrastructure Feature #5896: enhance legacy REST support to provide better pure Java development

This approach requires an explicit intervention to open everything. But that intervention is not hard. It is just a... Greg Shah

09:27 AM Runtime Infrastructure Feature #5896: enhance legacy REST support to provide better pure Java development

> the point is to 'force' the user to 'open access to all' for certain APIs, so these are explicitly visible in the d... Greg Shah

09:18 AM Runtime Infrastructure Feature #5896: enhance legacy REST support to provide better pure Java development

Greg Shah wrote:
> We probably should all the ones that are built into FWD. I see no reason these should be optiona... Constantin Asofiei

09:02 AM Runtime Infrastructure Feature #5896: enhance legacy REST support to provide better pure Java development

> > I agree that we cannot expect calling applications to be rewritten to our authentication model. I'm not suggesti... Greg Shah

08:53 AM Runtime Infrastructure Feature #5896: enhance legacy REST support to provide better pure Java development

Code Review Task Branch 3821c Revision 13800
The changes are good. Greg Shah

07:44 AM User Interface Bug #6053 (WIP): Widget realisation

Marian Edu

04/20/2022

07:46 PM User Interface Bug #6267: StackOverflowError in BROWSE widget

> * DELETE - considered as printable. It has code 127 and I have to say that it was considered as printable before th... Stanislav Lomany

07:40 PM User Interface Bug #6267: StackOverflowError in BROWSE widget

> It is worth checking the obvious cases that can be generated by Firefox/Chrome with your keyboard. Perhaps there a... Stanislav Lomany

07:44 AM User Interface Bug #6267: StackOverflowError in BROWSE widget

> Greg, should I check all the other keys?
It is worth checking the obvious cases that can be generated by Firefox... Greg Shah

03:58 AM User Interface Bug #6267: StackOverflowError in BROWSE widget

Stanislav Lomany wrote:
> > I agree, a replacement to be called by @EventManager.getKeyEvent@, when @isReal@ flag is... Constantin Asofiei

03:45 AM User Interface Bug #6267: StackOverflowError in BROWSE widget

> I agree, a replacement to be called by @EventManager.getKeyEvent@, when @isReal@ flag is true.
Constantin, are y... Stanislav Lomany

03:08 PM Runtime Infrastructure Feature #5896: enhance legacy REST support to provide better pure Java development

3821c/13800 contains improvements from the #5896-17 review.
The docs are updated and examples added in [[p2j:Java ... Constantin Asofiei

04/19/2022

01:31 PM Build and Source Control Bug #6208: cleanup build warnings

Recent FWD changes related to schema processing have caused some breakage. Roger is working on moving to a more stan... Greg Shah

01:26 PM Build and Source Control Bug #6208: cleanup build warnings

Is anyone able to build and run ChUI regression tests/p2j 3821c integration tests ?
I am getting errors since last w... Tomasz Domin

12:16 PM Database Bug #6275: SKIP-DELETED-RECORD implementation

Greg Shah wrote:
> Ovidiu: Please review.
A single question: calls to @stopOnSkippedRecord@ occur on @first@, @ne... Ovidiu Maxiniuc

12:02 PM Conversion Tools Feature #6253: add file-set processing into p2j.cfg.xml

Please check 3821c/13794. Constantin Asofiei

10:41 AM Conversion Tools Feature #6253: add file-set processing into p2j.cfg.xml

> > A command like this:
> > [...]
> > will use the @file-set@ configuration from the @cfg/p2j.cfg.xml@ (will assum... Greg Shah

11:07 AM Runtime Infrastructure Support #5567: move FWD to Java 11

Rebased to the latest p2j 3821c (13792)
Managed to build and test hotel_chui - no issues found.
As I dont have a ... Tomasz Domin

10:43 AM User Interface Bug #6267: StackOverflowError in BROWSE widget

Greg Shah wrote:
> Getting rid of the regression is important.
The fix from 3821c/13785 solves the regression.
>... Constantin Asofiei

09:30 AM User Interface Bug #6267: StackOverflowError in BROWSE widget

What I mean by separate, is create a replacement for @isPrintableKey()@ for the user-typed key. It should be named d... Greg Shah

09:28 AM User Interface Bug #6267: StackOverflowError in BROWSE widget

Why not separate these cases and do the safe thing at this point? Getting rid of the regression is important. Greg Shah

04/18/2022

08:52 AM User Interface Bug #6282: Combo-box VALUE-CHANGED

For drop-down/drop-down-list combo-box when the drop down list is made visible and a value is selected before closing... Marian Edu

08:51 AM User Interface Bug #6282 (New): Combo-box VALUE-CHANGED

Marian Edu

05:45 AM Conversion Tools Bug #5135 (Closed): replace -s, -f and -x options of ConversionDriver with a single combined mode

Greg Shah

05:45 AM Conversion Tools Feature #6253 (Closed): add file-set processing into p2j.cfg.xml

Code Review Task Branch 3821c Revision 13788
It is good. Greg Shah

05:44 AM User Interface Bug #6267: StackOverflowError in BROWSE widget

> If you see other places where @isPrintableKey@ receives the code generated by a generated key press, please specify... Stanislav Lomany

05:42 AM User Interface Bug #6267: StackOverflowError in BROWSE widget

Constantin Asofiei wrote:
> About the euro sign: you are right, pressing CTRL-ALT-5 generates the euro sign in OE (w... Sergey Ivanovskiy

05:04 AM User Interface Bug #6267: StackOverflowError in BROWSE widget

Not exactly. The only place in FWD where @isPrintableKey@ receives the key code generated as it was typed by the use... Constantin Asofiei

04:49 AM User Interface Bug #6267: StackOverflowError in BROWSE widget

Constantin, so we have
* a "key code" which is a number that can be supplied to @APPLY@ or generated by a key press... Stanislav Lomany

02:57 AM User Interface Bug #6267: StackOverflowError in BROWSE widget

It can be more clear if someone run this java program... Sergey Ivanovskiy

04/17/2022

03:52 PM User Interface Bug #6267: StackOverflowError in BROWSE widget

So if you would apply @APPLY 128 TO ch.@ using codepage @Windows-1252@, then you got the euro sign in the target field. Sergey Ivanovskiy

03:45 PM User Interface Bug #6267: StackOverflowError in BROWSE widget

Constantin, the decimal code @8364@ for the euro sign is just a representation of the euro sign but its key code can ... Sergey Ivanovskiy

04/16/2022

02:58 PM Conversion Tools Bug #5135: replace -s, -f and -x options of ConversionDriver with a single combined mode

Greg Shah wrote:
> Any amount of whitespace (not just space char) should be ignored.
Please see 3821c/13788. Constantin Asofiei

02:58 PM Conversion Tools Feature #6253: add file-set processing into p2j.cfg.xml

The changes are in 3821c/13788. Constantin Asofiei

09:06 AM User Interface Bug #6267: StackOverflowError in BROWSE widget

A problem with @Keyboard.isPrintable@ originates from having to distinguish between characters being pressed by the u... Constantin Asofiei

04/15/2022

04:57 PM User Interface Bug #6267: StackOverflowError in BROWSE widget

Greg Shah wrote:
> Vladimir: Please use @bzr blame@ and report who wrote the code in question.... Vladimir Tsichevski

02:46 PM User Interface Bug #6267: StackOverflowError in BROWSE widget

Unfortunately, Nick Saxon is the original author of the majority of the @Keyboard@ class, including the key action/fu... Greg Shah

02:37 PM User Interface Bug #6267 (WIP): StackOverflowError in BROWSE widget

OK, now we're on the same page.
Greg, I checked usages of @isPrintableKey(int key)@ and half of them pass @KeyInpu... Stanislav Lomany

01:49 PM User Interface Bug #6267: StackOverflowError in BROWSE widget

It seems that this function should be implemented using @evt.keyCode()@... Sergey Ivanovskiy

01:36 PM User Interface Bug #6267: StackOverflowError in BROWSE widget

Stanislav Lomany wrote:
> Consider we have a @KeyInput@ with @KeyInput.key = 501@ and @KeyInput.actionCode = -119@. ... Sergey Ivanovskiy

01:17 PM User Interface Bug #6267: StackOverflowError in BROWSE widget

Consider we have a @KeyInput@ with @KeyInput.key = 501@ and @KeyInput.actionCode = -119@. I'm telling that it looks l... Stanislav Lomany

11:05 AM User Interface Bug #6267: StackOverflowError in BROWSE widget

In our system the key codes from 501 to 509 belong the the navigation key set and if @KeyCode@ belongs this range, th... Sergey Ivanovskiy

09:57 AM User Interface Bug #6267: StackOverflowError in BROWSE widget

> Stanislav, it seems that @KeyInput@ is created from @TypeAHead@ with help of @EventManager.eventFromKey@. So @Keybo... Stanislav Lomany

09:18 AM User Interface Bug #6267: StackOverflowError in BROWSE widget

Stanislav Lomany wrote:
> So it looks like you excluded @ǵ@ and some other chars from the printable range.
Yes.
Sergey Ivanovskiy

09:17 AM User Interface Bug #6267: StackOverflowError in BROWSE widget

Stanislav, it seems that @KeyInput@ is created from @TypeAHead@ with help of @EventManager.eventFromKey@. So @Keyboar... Sergey Ivanovskiy

08:53 AM User Interface Bug #6267: StackOverflowError in BROWSE widget

So it looks like you excluded @ǵ@ and some other chars from the printable range. Stanislav Lomany

08:51 AM User Interface Bug #6267: StackOverflowError in BROWSE widget

> I found that this unicode symbol ǵ has decimal code 501. It seems that my changes are correct.
Right, but we don... Stanislav Lomany

08:09 AM User Interface Bug #6267: StackOverflowError in BROWSE widget

Stanislav Lomany wrote:
>
> An arrow doesn't seem to fall into any of these categories. So it should return @true@ ... Sergey Ivanovskiy

06:34 AM User Interface Bug #6267: StackOverflowError in BROWSE widget

Igor, please take a look at the code which Vladimir posted in #6267-1. We have double @super.processKeyEvent(ke)@ cal... Stanislav Lomany

06:30 AM User Interface Bug #6267: StackOverflowError in BROWSE widget

> And, in any case, the program should be guarded against unlimited recursion.
I would say the keys in the browse ... Stanislav Lomany

06:19 AM User Interface Bug #6267: StackOverflowError in BROWSE widget

> Committed revision 13785 (3821c) please review.
Sergey, @Character.isAlphabetic@ states that the following keys ... Stanislav Lomany

05:40 AM User Interface Bug #6267: StackOverflowError in BROWSE widget

Committed revision 13785 (3821c) please review. Sergey Ivanovskiy

01:42 PM Runtime Infrastructure Support #5567: move FWD to Java 11

Tomasz Domin wrote:
> But I cannot make Swing GUI work - there is only yellow rectangle on screen, the application s... Tomasz Domin

08:10 AM Conversion Tools Bug #5135: replace -s, -f and -x options of ConversionDriver with a single combined mode

Any amount of whitespace (not just space char) should be ignored. Greg Shah

12:55 AM Conversion Tools Bug #5135: replace -s, -f and -x options of ConversionDriver with a single combined mode

I created a list file for a project. The file contained several lines using the @D@ directive. I noticed there can be... Eric Faulhaber

04/14/2022

07:00 PM User Interface Bug #6267: StackOverflowError in BROWSE widget

Sergey Ivanovskiy wrote:
> I would propose to fix @Keyboard.isPrintableKey(key, isReal)@ to limit this condition
> ... Vladimir Tsichevski

06:32 PM User Interface Bug #6267: StackOverflowError in BROWSE widget

I would propose to fix @Keyboard.isPrintableKey(key, isReal)@ to limit this condition
@Character.isAlphabetic(key) &... Sergey Ivanovskiy

05:37 PM User Interface Bug #6267: StackOverflowError in BROWSE widget

Vladimir Tsichevski wrote:
> Stanislav Lomany wrote:
> > Vladimir, I cannot help saying that the issue you was anal... Vladimir Tsichevski

05:35 PM User Interface Bug #6267: StackOverflowError in BROWSE widget

Stanislav Lomany wrote:
> Vladimir, I cannot help saying that the issue you was analyzing is caused by your change 1... Vladimir Tsichevski

05:34 PM User Interface Bug #6267: StackOverflowError in BROWSE widget

Stanislav Lomany wrote:
> Vladimir, I cannot help saying that the issue you was analyzing is caused by your change 1... Greg Shah

04:34 PM User Interface Bug #6267: StackOverflowError in BROWSE widget

Vladimir, I cannot help saying that the issue you was analyzing is caused by your change 13716 (3821c). The change is... Stanislav Lomany

04:57 PM Conversion Tools Feature #6253: add file-set processing into p2j.cfg.xml

> but recursive makes sense for it to default to 'true'.
Let's do it. Greg Shah

04:56 PM Conversion Tools Feature #6253: add file-set processing into p2j.cfg.xml

Code Review Task Branch 3821c Revision 13778
The changes are good.
1. An "include file" has a special meaning i... Greg Shah

03:26 PM Base Language Feature #6280: date literal // quirk

The presence of certain malformed separators can be matched and sometimes causes a date literal to have an unexpected... Greg Shah

03:22 PM Base Language Feature #6280 (New): date literal // quirk

Greg Shah

10:59 AM Runtime Infrastructure Support #5567: move FWD to Java 11

Client Web GUI - both embedded and Virtual Desktop are now working fine
But I cannot make Swing GUI work - there is ... Tomasz Domin

02:23 AM Runtime Infrastructure Support #5567: move FWD to Java 11

Client Web GUI app works except there is a problem with font sizes.
The reason is modularization and ClassLoader.cl... Tomasz Domin

02:50 AM Testing Feature #6183: design and implement (as needed) the approach for writing automated 4GL compatibil...

Greg, all of our tests are using the same approach that is basically generate output in log file and then compare the... Marian Edu

04/13/2022

04:10 PM Runtime Infrastructure Support #5567: move FWD to Java 11

Built hotel_gui, but it does not work correctly.
Most of the scripts for hotel_*ui are based on system-wide java ins... Tomasz Domin

06:37 AM Runtime Infrastructure Support #5567: move FWD to Java 11

Attached for the reference only - patch against trunk branch
branch 5567a:
Rebased to 3821c, pushed to 5567a, com... Tomasz Domin

11:27 AM Runtime Infrastructure Feature #5896: enhance legacy REST support to provide better pure Java development

Ovidiu Maxiniuc wrote:
> @RecordSerializer@:
> * method @initialize()@: I think @record.initialize()@ should be inv... Constantin Asofiei

09:20 AM Conversion Tools Feature #6203: create cvtpath and move conversion database into that directory

Constantin Asofiei wrote:
> Thanks, I can duplicate it:
> * run @ant convert.list@ with 3821c - name is @MultiLine1... Roger Borrello

09:15 AM Conversion Tools Feature #6203: create cvtpath and move conversion database into that directory

Thanks, I can duplicate it:
* run @ant convert.list@ with 3821c - name is @MultiLine1@.
* run @ant clean.all@
* ru... Constantin Asofiei

09:03 AM Conversion Tools Feature #6203: create cvtpath and move conversion database into that directory

Constantin Asofiei wrote:
> Roger, please upload to devsrv01 your entire testcases project where you do the conversi... Roger Borrello

04:04 AM Conversion Tools Feature #6203: create cvtpath and move conversion database into that directory

Roger, please upload to devsrv01 your entire testcases project where you do the conversion (without the p2j/ folder).... Constantin Asofiei

09:19 AM Testing Feature #6183: design and implement (as needed) the approach for writing automated 4GL compatibil...

In this task I want to find some answers so that we can move ahead with implementing the full approach described in [... Greg Shah

08:34 AM Conversion Tools Feature #6253: add file-set processing into p2j.cfg.xml

Greg Shah wrote:
> Should we make the following common cases the default?
>
> * @recursive="true"@
> * @spec="(*... Constantin Asofiei

08:32 AM Conversion Tools Feature #6253 (Review): add file-set processing into p2j.cfg.xml

The changes are in 3821c/13778 for both this task and #5135. Constantin Asofiei

08:28 AM Conversion Tools Feature #6253: add file-set processing into p2j.cfg.xml

It looks good.
Should we make the following common cases the default?
* @recursive="true"@
* @spec="(*.[pPwW... Greg Shah

08:15 AM Conversion Tools Feature #6253: add file-set processing into p2j.cfg.xml

The @file-set@ in @p2j.cfg.xml@ will look like this:... Constantin Asofiei

08:10 AM Conversion Tools Feature #6253: add file-set processing into p2j.cfg.xml

Constantin Asofiei wrote:
> A command like this:
> [...]
> will use the @file-set@ configuration from the @cfg/p2j... Greg Shah

08:09 AM Conversion Tools Feature #6253: add file-set processing into p2j.cfg.xml

> I've used @<file-set filename="file-set.txt" />@ (@filename@ instead of @input-file@) because of the dash in @input... Greg Shah

08:08 AM Conversion Tools Feature #6253: add file-set processing into p2j.cfg.xml

A command like this:... Constantin Asofiei

08:07 AM Conversion Tools Feature #6253: add file-set processing into p2j.cfg.xml

I've used @<file-set filename="file-set.txt" />@ (@filename@ instead of @input-file@) because of the dash in @input-f... Constantin Asofiei

08:32 AM Conversion Tools Bug #5135 (Review): replace -s, -f and -x options of ConversionDriver with a single combined mode

The changes are in 3821c/13778 for both this task and #6253. Constantin Asofiei

08:28 AM Conversion Tools Bug #5135: replace -s, -f and -x options of ConversionDriver with a single combined mode

OK Greg Shah

08:19 AM Conversion Tools Bug #5135: replace -s, -f and -x options of ConversionDriver with a single combined mode

Z mode is stripping the @./@ prefix, because of some peculiarities when resolving the path (I need the real OS filena... Constantin Asofiei

07:06 AM Database Bug #6275: SKIP-DELETED-RECORD implementation

Ovidiu: Please review. Greg Shah

04:16 AM Database Bug #6275: SKIP-DELETED-RECORD implementation

@SKIP-DELETED-RECORD@ was implemented as a part of #5882. In turned out that these changes weren't necessary for fixi... Stanislav Lomany

04:02 AM Database Bug #6275 (Review): SKIP-DELETED-RECORD implementation

Stanislav Lomany

04:16 AM Database Bug #3896: improve performance of the _lock metadata implementation

Reworked based on the code review and tested with a large customer app.
Please review the final version (attached). Igor Skornyakov

04/12/2022

06:21 PM Database Feature #4722 (WIP): data import should be able to run with only the converted application jar fi...

Partial work in this area was done in recent commits (revisions: 13695, 13746, 13753, 13776 of branch 3821c). Ovidiu Maxiniuc

04:27 PM Runtime Infrastructure Support #5567: move FWD to Java 11

Till now worked on trunk branch, as I was already working on it:
Added dependencies missing in java 11:
fwdCCS g... Tomasz Domin

10:29 AM Runtime Infrastructure Support #5567: move FWD to Java 11

> as I didn't know if there are any projects based on clean trunk.
All projects are dependent upon 3821c at this p... Greg Shah

10:24 AM Runtime Infrastructure Support #5567: move FWD to Java 11

Greg Shah wrote:
> Via email, from Tomasz:
> Please make sure to rebase 5567a from the latest 3821c. The differenc... Tomasz Domin

09:14 AM Runtime Infrastructure Support #5567: move FWD to Java 11

Via email, from Tomasz:
> Created branch 5567a, started porting with fixing compilation bugs. I've considered upgr... Greg Shah

04:18 PM Conversion Tools Feature #6203: create cvtpath and move conversion database into that directory

Ovidiu Maxiniuc wrote:
> This is odd, at least. Does it happens for a single project? It does not happen for me. It ... Roger Borrello

03:42 PM Conversion Tools Feature #6203: create cvtpath and move conversion database into that directory

This is odd, at least. Does it happens for a single project? It does not happen for me. It is a configuration issue, ... Ovidiu Maxiniuc

03:27 PM Conversion Tools Feature #6203: create cvtpath and move conversion database into that directory

I'm not sure if this was an intended change, but with the 13732 revision, generated filenames are no longer Camel-Cas... Roger Borrello

03:04 AM Base Language Bug #6268: Characters encoding issues with UTF-8 for emoji and confusable symbols.

The inconsistency regarding emoji length of the JVM versus other runtimes is nicely explained at "Emojis, Java and St... Tijs Wickardt

04/11/2022

03:32 PM Base Language Bug #6268: Characters encoding issues with UTF-8 for emoji and confusable symbols.

Defer. Greg Shah

02:44 PM Base Language Bug #6268: Characters encoding issues with UTF-8 for emoji and confusable symbols.

Greg,
What is our plan here? Do we need to work on this now or can be deferred? Eugenie Lyzenko

02:08 PM Database Bug #3896: improve performance of the _lock metadata implementation

Eric Faulhaber wrote:
> Igor Skornyakov wrote:
>
> > The problem with combining multiple updates into a single tr... Igor Skornyakov

02:03 PM Database Bug #3896: improve performance of the _lock metadata implementation

Igor Skornyakov wrote:
> The problem with combining multiple updates into a single transaction is that we need to ... Eric Faulhaber

01:51 PM Database Bug #3896: improve performance of the _lock metadata implementation

Eric Faulhaber wrote:
> Igor Skornyakov wrote:
>
> > [...]
> > Anyway, I will think how to improve the current l... Igor Skornyakov

01:01 PM Database Bug #3896 (Review): improve performance of the _lock metadata implementation

Eric Faulhaber

12:56 PM Database Bug #3896: improve performance of the _lock metadata implementation

Eric Faulhaber wrote:
> Igor Skornyakov wrote:
>
> > [...]
> > Anyway, I will think how to improve the current l... Igor Skornyakov

12:52 PM Database Bug #3896: improve performance of the _lock metadata implementation

Igor Skornyakov wrote:
> [...]
> Anyway, I will think how to improve the current logic.
As I noted, it is ok t... Eric Faulhaber

12:49 PM Database Bug #3896: improve performance of the _lock metadata implementation

Eric Faulhaber wrote:
> @_lock2.diff@ patch code review:
>
> Typo at @FwdJMX@:173: @faild@ -> @failed@.
>
> @L... Igor Skornyakov

12:19 PM Database Bug #3896: improve performance of the _lock metadata implementation

@_lock2.diff@ patch code review:
Typo at @FwdJMX@:173: @faild@ -> @failed@.
@LockTableUpdater@:
Please remov... Eric Faulhaber

11:25 AM Conversion Tools Feature #6270: annotations-based per-file hints

Greg Shah wrote:
> To clarify, I meant that to maintain the WINE environment one must have an original Windows funct... Tijs Wickardt

08:54 AM Conversion Tools Feature #6270: annotations-based per-file hints

> > a working Windows configuration
> This seems to be a misunderstanding. I meant:
> Only the binaries that are n... Greg Shah

08:48 AM Conversion Tools Feature #6270: annotations-based per-file hints

No need for apologies, these are all valid points.
> a working Windows configuration
This seems to be a misunders... Tijs Wickardt

08:17 AM Conversion Tools Feature #6270: annotations-based per-file hints

Every time we add *any* dependency, we add friction in the process of getting everything running properly. For conve... Greg Shah

02:41 AM Conversion Tools Feature #6270: annotations-based per-file hints

Greg Shah wrote:
> I don't see the same value in maintaining the @.wrx@ as a resource. It cannot be easily edited, ... Tijs Wickardt

06:04 AM User Interface Bug #6038 (Feedback): ComboBox setScreenValue improvements

Guys, I'm trying to close this somehow but although I've tried to keep the current implementation where the @screen-v... Marian Edu

02:42 AM Runtime Infrastructure Support #5567 (WIP): move FWD to Java 11

First step - prepare a plan.
Need to review all the code and all tools for problems with JDK11
Tomasz Domin

04/10/2022

07:41 PM Conversion Tools Feature #6270: annotations-based per-file hints

I don't see the same value in maintaining the @.wrx@ as a resource. It cannot be easily edited, it can only be edite... Greg Shah

02:36 PM Conversion Tools Feature #6270: annotations-based per-file hints

Note: https://pkgs.alpinelinux.org/package/edge/community/x86/wine
(and winetricks)
Non edge version (stable): ... Tijs Wickardt

02:16 PM Conversion Tools Feature #6270: annotations-based per-file hints

Hynek Cihlar wrote:
> Greg Shah wrote:.
> > > .. interpret .wrx files (for example) the related annotations should ... Tijs Wickardt

12:15 PM Conversion Tools Feature #6270: annotations-based per-file hints

Greg Shah wrote:
> > It should be limited only to information that FWD cannot deduce at the conversion.
>
> This... Tijs Wickardt

12:04 PM Conversion Tools Feature #6270: annotations-based per-file hints

Greg Shah wrote:
> > It should be limited only to information that FWD cannot deduce at the conversion.
>
> This... Hynek Cihlar

11:14 AM Conversion Tools Feature #6270: annotations-based per-file hints

> It should be limited only to information that FWD cannot deduce at the conversion.
This is already the case. W... Greg Shah

11:08 AM Conversion Tools Feature #6270: annotations-based per-file hints

I like the idea of using 4GL annotations for FWD runtime hints.
It reduces the chance of an OE developer forgetting ... Tijs Wickardt

09:48 AM Conversion Tools Feature #6270: annotations-based per-file hints

Today, we have multiple types of hints at the individual source-file level.
* "UAST Hints" are read from a file th... Greg Shah

09:14 AM Conversion Tools Feature #6270 (New): annotations-based per-file hints

Greg Shah

04/08/2022

06:34 PM Base Language Bug #6268: Characters encoding issues with UTF-8 for emoji and confusable symbols.

Small pic showing the end status for now. Please attach to the new bug issue along with this comment.
Using @the g... Eugenie Lyzenko

06:32 PM Base Language Bug #6268: Characters encoding issues with UTF-8 for emoji and confusable symbols.

The patch to unlock negative @ASC@ code conversion. Eugenie Lyzenko

06:29 PM Base Language Bug #6268 (New): Characters encoding issues with UTF-8 for emoji and confusable symbols.

Eugenie Lyzenko

05:38 PM User Interface Bug #6267: StackOverflowError in BROWSE widget

Vladimir: Please use @bzr blame@ and report who wrote the code in question. Greg Shah

02:28 PM User Interface Bug #6267: StackOverflowError in BROWSE widget

This issue was first published as #5034-1982. Vladimir Tsichevski

02:27 PM User Interface Bug #6267: StackOverflowError in BROWSE widget

Stack overflow situation in @Browse@ widget:
# create an application with an editable @BROWSE@ widget (example @br... Vladimir Tsichevski

02:24 PM User Interface Bug #6267 (Review): StackOverflowError in BROWSE widget

Vladimir Tsichevski

05:04 PM Database Bug #3896: improve performance of the _lock metadata implementation

Eric Faulhaber wrote:
> Is the latest patch still based on 3821c/13684?
Please find the patch based on 3821c/13... Igor Skornyakov

04:57 PM Database Bug #3896: improve performance of the _lock metadata implementation

Igor Skornyakov wrote:
> Eric,
> Can you please review this? I cannot commit another changes e.g. for the @Database... Eric Faulhaber

04:17 PM Database Bug #3896: improve performance of the _lock metadata implementation

Eric,
Can you please review this? I cannot commit another changes e.g. for the @DatabaseManager@ since these changes... Igor Skornyakov

10:00 AM Conversion Tools Bug #5135: replace -s, -f and -x options of ConversionDriver with a single combined mode

> I can either use java.nio.Path.toRealPath (if it works) to resolve the real filename at OS level, or otherwise rely... Greg Shah

09:17 AM Conversion Tools Bug #5135: replace -s, -f and -x options of ConversionDriver with a single combined mode

Another issue: lets assume we are under Windows, where file names are case-insensitive; you have a @F ./Build.p@ line... Constantin Asofiei

07:45 AM Conversion Tools Feature #6202: allow .df files to exist in a path that is not directly in data/

> I think the schema @.hints@ should be stored with the @.df@ file, not with @.schema@.
Correct.
> More than t... Greg Shah