Activity
From 01/07/2023 to 02/05/2023
02/04/2023
- 07:32 PM Database Feature #7062: Direct access to H2 internals to solve basic queries
- Eric Faulhaber wrote:
> Ultimately, we create the SQL forms of the column names. So, we can use whatever we want as ...
02/03/2023
- 06:53 PM Database Bug #6837: prevent unnecessary upper/rtrim injection in queries if the data type doesn't require it
- Thank you. I tried it now and it worked. I was able to create a table and execute a quick select statement over a cou...
- 06:17 PM Database Bug #6837: prevent unnecessary upper/rtrim injection in queries if the data type doesn't require it
- I'm pretty sure @citext@ existed as an extension before PostgreSQL 11. I thought it was one of the core data types af...
- 05:25 PM Database Bug #6837: prevent unnecessary upper/rtrim injection in queries if the data type doesn't require it
- The changes are necessary only if/when we decide to switch from case-sensitive character data types to case-insensiti...
- 10:51 AM Database Bug #6837: prevent unnecessary upper/rtrim injection in queries if the data type doesn't require it
- It seems like note 11 is suggesting some changes to encode the logic in the dialects and fix the DDL generation.
- 10:49 AM Database Bug #6837: prevent unnecessary upper/rtrim injection in queries if the data type doesn't require it
- It sounds like this task can be closed, then, correct?
- 05:17 PM Database Feature #7062: Direct access to H2 internals to solve basic queries
- Ultimately, we create the SQL forms of the column names. So, we can use whatever we want as an identifier, if we find...
- 04:20 PM Database Feature #7062: Direct access to H2 internals to solve basic queries
- Actually the prefixes for the computed columns in H2 dialect are @__i@ and @__s@ (for *i* gnore casing and case- *s* ...
- 10:34 AM Database Feature #7062: Direct access to H2 internals to solve basic queries
- I extended my solution to cover all unique indexes. Most of the processing is done in @FQLPreprocessor@ to identify w...
- 10:50 AM Database Feature #6348: implement support for MariaDB
- Ovidiu Maxiniuc wrote:
> Committed revision 14396 / 6129b.
The change looks good. Can we close this task? - 08:35 AM Runtime Infrastructure Bug #5703 (WIP): rationalize, standardize and simplify the client-side log file name configuration
- I'm trying to figure out what is part of our OpenEdge replica implementation and what is our invention.
* @outputT...
02/02/2023
- 03:47 PM Database Feature #7062: Direct access to H2 internals to solve basic queries
- Greg Shah wrote:
> You're saying that in the 4GL these have separate @recid@ values when a temp-table is passed as a... - 11:56 AM Database Feature #7062: Direct access to H2 internals to solve basic queries
- Alexandru Lungu wrote:
> I may have misinterpreted FWD's behavior. I have seen multiple fields like "some_field" a... - 11:46 AM Database Feature #7062: Direct access to H2 internals to solve basic queries
- Greg Shah wrote:
> > I only consider tables without computed-columns (date-time, extent or case-insensitive char fie... - 09:54 AM Database Feature #7062: Direct access to H2 internals to solve basic queries
- > I only consider tables without computed-columns (date-time, extent or case-insensitive char fields)
In regard to... - 05:51 AM Database Feature #7062: Direct access to H2 internals to solve basic queries
- > Please also consider #6720; I don't yet know if lazy hydration should be applied to H2 embedded databases. I have t...
- 03:26 PM Database Feature #7037: remove dirty share manager
- Stanislav Lomany wrote:
> FYI I've found @uast/shared-dirty-records/p*.p@ and @uast/shared-dirty-records/leaking*.p@... - 03:24 PM Database Feature #7037: remove dirty share manager
- FYI I've found @uast/shared-dirty-records/p*.p@ and @uast/shared-dirty-records/leaking*.p@ testcases which "demonstra...
- 01:18 PM Database Feature #6371: implement SAVE CACHE statement
- Boris Schegolev wrote:
> Branch 6129b is frozen for now, so, let's take a look at what we know was not implemented b... - 08:27 AM Database Feature #6371: implement SAVE CACHE statement
- > EXTENT support (currently, expanded mode only...
I think we only need expanded mode support. The old "denormali... - 12:05 PM Runtime Infrastructure Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...
- At this point, we need to pause because of the freeze on trunk. We will rebase and merge when the "thaw" occurs.
- 12:05 PM Runtime Infrastructure Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...
- Code Review Task Branch 5701a Revisions 14485 and 14486
The changes are good. - 04:18 AM Runtime Infrastructure Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...
- Thank you for the explanation. Actually I was able to figure out the first part by reading the documentation for the ...
- 11:15 AM Base Language Feature #6421: finish GENERATE-RANDOM-KEY support
- Theodoros Theodorou wrote:
> Is this test below a good test? Should I store it at @testcases/security/security-polic... - 11:10 AM Base Language Feature #6421: finish GENERATE-RANDOM-KEY support
- Do you have test code for the error cases that I mentioned in #6421-16?
In your testcase #6421-21, you should avoi... - 10:41 AM Base Language Feature #6421: finish GENERATE-RANDOM-KEY support
- Hello Igor and thank you for your review.
I replaced @getAlgKeyLen()@ with @SecurityPlicyManager.getSymmetricCiper... - 09:58 AM Base Language Feature #6410: implement additional built-in OO classes/interfaces
- > we can then keep OE11.7 as main target and OE12.2 'extensions/fixes' are only nice to have?
Correct. If there a... - 09:41 AM Base Language Feature #6410: implement additional built-in OO classes/interfaces
- Greg Shah wrote:
> I prefer not to have different FWD branches for different OE versions.
Understood, then only... - 09:25 AM Base Language Feature #6410: implement additional built-in OO classes/interfaces
- 11.7 and 12.2 is fine.
> Now, this only has effect at compile time - for FWD will be when the conversion is execut... - 03:12 AM Base Language Feature #6410: implement additional built-in OO classes/interfaces
- Greg Shah wrote:
> Yes, please use @PROVERSION@ and preprocessing to conditionally implement logic by OE version.
... - 06:40 AM Database Bug #7088: Lazily initialize activeBundle inside RandomAccessQuery
- I've done a slim test with ~40,000 find queries. ~13.000 of them used @ffCache@. The total time spent on activation w...
02/01/2023
- 06:11 PM Database Feature #6371: implement SAVE CACHE statement
- Branch 6129b is frozen for now, so, let's take a look at what we know was not implemented by now:
* more validatio... - 04:28 PM Database Feature #6348: implement support for MariaDB
- The update I was talking in #6348-54 was committed the next day in revision 14308 (see @MariaDbSequenceHandler.java@)...
- 02:34 PM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
- Does @SourceNameMapper.convertName()@ often get called with the same @legacyProgName@ and @lookup@ function? If so, ...
- 02:34 PM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
- Code Review Task Branch 6129b Revision 14394
The changes look good. - 01:29 PM Database Feature #7062: Direct access to H2 internals to solve basic queries
- > A copy in a separate logical or physical temp-table should have a distinct primary key (recid) value. This is the i...
- 01:26 PM Database Feature #7062: Direct access to H2 internals to solve basic queries
- Eric Faulhaber wrote:
> Alexandru, one other thing to consider, which I suppose you've already noticed: we don't act... - 01:25 PM Database Feature #7062: Direct access to H2 internals to solve basic queries
- Greg Shah wrote:
> > I empirically discovered that (recid) is always the primary key of our temp-tables in H2; multi... - 01:15 PM Database Feature #7062: Direct access to H2 internals to solve basic queries
- Alexandru, one other thing to consider, which I suppose you've already noticed: we don't actually create unique indic...
- 01:09 PM Database Feature #7062: Direct access to H2 internals to solve basic queries
- > I empirically discovered that (recid) is always the primary key of our temp-tables in H2; multiplex is irrelevant. ...
- 12:54 PM Database Feature #7062: Direct access to H2 internals to solve basic queries
- Alexandru Lungu wrote:
> I've finished implementing a simple mean of H2 direct access for @RAQ@ with simple @recid@ ... - 10:54 AM Database Feature #7062: Direct access to H2 internals to solve basic queries
- I've finished implementing a simple mean of H2 direct access for @RAQ@ with simple @recid@ look-up. The results are f...
- 01:26 PM Base Language Feature #6421: finish GENERATE-RANDOM-KEY support
- Theodoros Theodorou wrote:
> I read the encryption algorithm by using @SecurityPolicyManager.getSymmetricEncryptionA... - 12:55 PM Base Language Feature #6421: finish GENERATE-RANDOM-KEY support
- Greg Shah wrote:
> The original code in @SecurityOps.generateRandomKey()@ was forced to @AES_CBC_128@. Take a look... - 12:47 PM Base Language Feature #6421: finish GENERATE-RANDOM-KEY support
- The original code in @SecurityOps.generateRandomKey()@ was forced to @AES_CBC_128@. Take a look at trunk.
- 12:45 PM Base Language Feature #6421: finish GENERATE-RANDOM-KEY support
- Greg Shah wrote:
> Igor: Please review.
Sorry, I do not understand. As far as I remember and can see from the cod... - 12:26 PM Base Language Feature #6421: finish GENERATE-RANDOM-KEY support
- > Do I need to checkout 6421a from the testcases project or use the main branch?
I'm not exactly sure what you are... - 08:45 AM Base Language Feature #6421: finish GENERATE-RANDOM-KEY support
- Do I need to checkout 6421a from the testcases project or use the main branch?
Then I should include my @test-genr... - 01:00 PM Database Bug #7088: Lazily initialize activeBundle inside RandomAccessQuery
- This makes sense. Although the cost currently is mitigated to some degree by caching in @FQLHelper@, there is still w...
- 04:23 AM Database Bug #7088: Lazily initialize activeBundle inside RandomAccessQuery
- There is relevant activity when building an @activeBundle@ in general, mostly related to FQL composition (@createBund...
- 04:09 AM Database Bug #7088 (New): Lazily initialize activeBundle inside RandomAccessQuery
- 11:40 AM Runtime Infrastructure Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...
- Lets consider this code from @spawn.c@:...
- 10:17 AM Runtime Infrastructure Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...
- Galya Bogdanova wrote:
> Eugenie Lyzenko wrote:
> > Yes, I did. @src/native/spawn.c@ has neither history nor year u... - 09:43 AM Runtime Infrastructure Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...
- Eugenie Lyzenko wrote:
> Yes, I did. @src/native/spawn.c@ has neither history nor year update. @src/native/winspawn.... - 09:25 AM Runtime Infrastructure Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...
- Galya Bogdanova wrote:
> Eugenie Lyzenko wrote:
> > When you add new history entry with date (@2023MMDD@), and you ... - 06:04 AM Runtime Infrastructure Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...
- Eugenie Lyzenko wrote:
> When you add new history entry with date (@2023MMDD@), and you should mark your change the ... - 06:01 AM Runtime Infrastructure Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...
- Galya Bogdanova wrote:
> Eugenie Lyzenko wrote:
> > I have no objections, in addition to history entries it is requ... - 03:02 AM Runtime Infrastructure Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...
- Eugenie Lyzenko wrote:
> I have no objections, in addition to history entries it is required to change Year to @2023... - 02:43 AM Runtime Infrastructure Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...
- Greg Shah wrote:
> Code Review Task Branch 5701a Revisions 14484 and 14485
>
> 1. In @spawn.c:launchP2JClient@, t... - 10:11 AM Database Feature #6444: dataset improvements
- Rebased task branch 6444a to the trunk rev.14483.
Suspended working on this task while the trunk and 6129b are frozen. - 09:49 AM Database Feature #6995: possibly support NO-UNDO temporary tables directly in H2
- Eric Faulhaber wrote:
> I have not yet reviewed the changes in detail, but my opinion is that removing all SQL redo ... - 09:40 AM Database Support #7058: get the FWD fork of the H2 code base under version control
- Greg Shah wrote:
> See if you can just do some limited edits to Source Code Management to explain branching for FWD ... - 09:39 AM Base Language Bug #7089: sanitize p2j.oo method signature
- In incremental conversion, it was found that a @RequestBuilder.put@ method's LegacySignature was inconsistent with th...
- 09:27 AM Base Language Bug #7089 (WIP): sanitize p2j.oo method signature
- 09:38 AM Database Bug #7035: Extract query parameters from statically converted FQL
- *Review for patch #7035-9*
There is consistent work going on with this extraction and I am pleased with this new @Pa... - 04:23 AM Database Bug #7035: Extract query parameters from statically converted FQL
- Eric Faulhaber wrote:
> Please add a test with such an extent field reference, and make sure it still works, both in... - 08:52 AM Base Language Feature #6410 (WIP): implement additional built-in OO classes/interfaces
01/31/2023
- 05:11 PM Database Feature #6348: implement support for MariaDB
- Ovidiu, are all the sequence features working now? Based on #6348-54 and the entries leading up to it, it seemed this...
- 04:12 PM Database Feature #6348: implement support for MariaDB
- Committed revision 14396 / 6129b.
- 01:35 AM Database Feature #6348: implement support for MariaDB
- Ovidiu Maxiniuc wrote:
> ... there are a few methods which still use @UnimplementedFeature@ to report missing featur... - 04:46 PM Runtime Infrastructure Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...
- Greg Shah wrote:
> Eugenie: Please review branch 5701a.
I have no objections, in addition to history entries it i... - 03:54 PM Runtime Infrastructure Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...
- Eugenie: Please review branch 5701a.
- 03:53 PM Runtime Infrastructure Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...
- Code Review Task Branch 5701a Revisions 14484 and 14485
1. In @spawn.c:launchP2JClient@, the @memset(arguments[len... - 04:47 AM Runtime Infrastructure Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...
- I've tested both Linux and Windows spawner. Here are the final changes in the .diff file, also committed to @5701a@.
... - 03:56 AM Runtime Infrastructure Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...
- Constantin Asofiei wrote:
> Galya, please describe how you are running a program on the appserver. A batch program ... - 03:59 PM Database Bug #6837: prevent unnecessary upper/rtrim injection in queries if the data type doesn't require it
- The current implementation injects the upper/rtrim into FQLs of the queries at conversion time because it assumes at ...
- 01:59 AM Database Bug #6837: prevent unnecessary upper/rtrim injection in queries if the data type doesn't require it
- What is left to do on the MariaDB side for:
* lenient mode?
* strict mode? - 03:55 PM Database Feature #6371: implement SAVE CACHE statement
- I pushed revision 6129b/14395 with comment cleaning procedure and some JavaDoc that was missing.
- 02:13 AM Database Feature #6371: implement SAVE CACHE statement
- Boris, please continue implementing the remaining items in #6371-119.
I've also noticed in the code that the colum... - 11:25 AM Database Feature #6995: possibly support NO-UNDO temporary tables directly in H2
- I have not yet reviewed the changes in detail, but my opinion is that removing all SQL redo code from FWD is OK as lo...
- 08:59 AM Database Feature #6995: possibly support NO-UNDO temporary tables directly in H2
- > I am not necessarily sensitive with huge chunks of code being removed (less is faster), but should we keep some of ...
- 08:36 AM Database Feature #6995: possibly support NO-UNDO temporary tables directly in H2
- Eric, I added you as a watcher now.
- 08:27 AM Database Feature #6995: possibly support NO-UNDO temporary tables directly in H2
- I tested 6995a_h2 with your FWD patch against a large customer application and there was no regression.
The performa... - 05:06 AM Database Feature #6995: possibly support NO-UNDO temporary tables directly in H2
- I committed to 6995a_h2, rev.7 the changes that you asked for.
Also, when running @build.sh test@, the errors were ... - 03:49 AM Database Feature #6995: possibly support NO-UNDO temporary tables directly in H2
- Radu, based on our new FWD-H2 branching system #7058, I've created 6995a_h2 to hold your patch from #6995-13. However...
- 09:30 AM Base Language Feature #6421: finish GENERATE-RANDOM-KEY support
- Yes, except it would be useful to put slightly more detail in the comment. Something like this seems appropriate:
... - 09:18 AM Base Language Feature #6421: finish GENERATE-RANDOM-KEY support
- History entry means to add a comment in the beginning of the file?
Like the following?... - 09:12 AM Base Language Feature #6421: finish GENERATE-RANDOM-KEY support
- Theodoros Theodorou wrote:
> How to write test cases?
[[p2j:Writing 4GL Testcases]]
[[p2j:Testing_Process#Proje... - 09:03 AM Base Language Feature #6421: finish GENERATE-RANDOM-KEY support
- How to write test cases? I thought that the p2j test cases do not run.
- 06:20 AM Base Language Feature #6421: finish GENERATE-RANDOM-KEY support
- Code Review Task Branch 6421a Revision 14484
1. @generateRandomKey()@ needs complete error handling. Please write... - 05:41 AM Base Language Feature #6421: finish GENERATE-RANDOM-KEY support
- Igor: Please review.
- 02:06 AM Base Language Feature #6421 (Review): finish GENERATE-RANDOM-KEY support
- I have committed my changes and the task is ready for review
- 02:05 AM Base Language Feature #6421: finish GENERATE-RANDOM-KEY support
- I have created the branch 6421a
- 09:08 AM Database Support #7058: get the FWD fork of the H2 code base under version control
- See if you can just do some limited edits to Source Code Management to explain branching for FWD vs H2.
- 05:09 AM Database Support #7058: get the FWD fork of the H2 code base under version control
- Greg, I've done only one documentation change to "Patching and Building Customized 3rd Party Libraries":/projects/p2j...
- 08:50 AM Build and Source Control Bug #7083: P2J Native Build Cannot Find -ljvm Under Windows
- h2. Environment
Windows VirtualBox VM is set up by following the steps in [[p2j:Windows 11 Virtual Machine Setup w... - 03:05 AM Build and Source Control Bug #7083 (Rejected): P2J Native Build Cannot Find -ljvm Under Windows
- 08:25 AM Database Feature #7037: remove dirty share manager
- Greg Shah wrote:
> > Cross-session use for the small set of tables (currently, only one I know of) which needs it.
... - 05:38 AM Database Feature #7037: remove dirty share manager
- > Cross-session use for the small set of tables (currently, only one I know of) which needs it.
Tomasz may have fo... - 01:56 AM Database Feature #6628: port PostgreSQL native user defined functions to MariaDB
- Eric Faulhaber wrote:
> Igor Skornyakov wrote:
>
> > I think that error handling can be finished in 2-3 days.
>... - 01:32 AM Database Feature #6628: port PostgreSQL native user defined functions to MariaDB
- Igor Skornyakov wrote:
> I think that error handling can be finished in 2-3 days.
Please finish this when you ...
01/30/2023
- 05:43 PM Database Feature #7037: remove dirty share manager
- AFAICT, your assessment of how @DirtyShareSupport@ works currently is correct.
It seems we need to support the fol... - 03:03 PM Database Feature #7037: remove dirty share manager
- In @DirtyShareSupport@ we effectively have @forceDirtyShare@ always enabled, and, correct me if I'm wrong, no convert...
- 01:01 PM Database Feature #7037: remove dirty share manager
- Stas, I'm sorry I did not remember this existing implementation. How does this overlap/conflict/differ with your rece...
- 12:58 PM Database Feature #7037: remove dirty share manager
- Stanislav Lomany wrote:
> As far as I understand, the following should happen when dirty sharing is disabled in the ... - 11:10 AM Database Feature #7037: remove dirty share manager
- One more thing: what cases that should be tested to make sure then remain working after cross-session dirty sharing h...
- 10:37 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
- I checked in various performance changes in 6129b revision 14394. Please review.
- 09:52 AM Database Feature #7061 (WIP): Enable the use of lazy result sets in H2
- 09:42 AM Database Feature #6371: implement SAVE CACHE statement
- The documentation for this task is in [[p2j:Non-Standard Save Cache Implementation]].
- 09:11 AM Database Support #7058: get the FWD fork of the H2 code base under version control
- I'm glad the existing scripts worked.
- 08:33 AM Database Support #7058 (WIP): get the FWD fork of the H2 code base under version control
- Added version control for our H2 fork:
* redesigned @code/p2j_repo/fwd-h2@ to honor the @active/dead/merged/trunk@ p... - 06:52 AM Database Support #7058: get the FWD fork of the H2 code base under version control
- Greg Shah wrote:
> > Should we use the same branch naming convention (task number + ascending letters) as we use in ... - 08:50 AM Runtime Infrastructure Feature #6377: provide tooling (and UI in the admin interface) to manage appserver agents (start/...
- I would prefer to implement this using a REST API. We will provide a CLI (command line interface) and would probably...
- 07:24 AM Runtime Infrastructure Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...
- Galya, please describe how you are running a program on the appserver. A batch program executes its 4GL program imme...
- 06:40 AM Runtime Infrastructure Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...
- So configuration-wise @appserver@ turns into batch if I remove @<node-attribute name="appserver" value="app_server"/>...
- 05:05 AM Runtime Infrastructure Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...
- Galya Bogdanova wrote:
> Greg, Constantin, I'll need some clarifications here:
> 1. What do you refer to as agent l... - 03:25 AM Runtime Infrastructure Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...
- Greg, Constantin, I'll need some clarifications here:
1. What do you refer to as agent logs in FWD? @outputToFile@ i... - 07:03 AM Database Bug #6829 (WIP): H2 forces re-parse of all prepared statements when metadata is changed
- Danut, please strictly refer to #6829-1 for the moment: consider the H2 performance of reparsing prepared statements ...
- 03:17 AM Database Feature #6444: dataset improvements
- Marian Edu wrote:
> Igor Skornyakov wrote:
> > Marian,
> > The description of the @SYNCHRONIZE@ method semantics i... - 03:12 AM Database Feature #6444: dataset improvements
- Igor Skornyakov wrote:
> Marian,
> The description of the @SYNCHRONIZE@ method semantics in the OE documentation lo...
01/28/2023
- 03:54 AM Database Feature #6444: dataset improvements
- Marian,
The description of the @SYNCHRONIZE@ method semantics in the OE documentation looks not very clear for me.
... - 03:35 AM Database Feature #6444: dataset improvements
- > > And generally, please place the @{@ on a new line (FWD coding standard). I forgot to add this in my previous revi...
- 02:56 AM Database Feature #6444: dataset improvements
- Ovidiu Maxiniuc wrote:
> I looked in the log of FWD repository and, indeed it shows I added some implementation for ... - 08:22 PM Database Feature #6444: dataset improvements
- I looked in the log of FWD repository and, indeed it shows I added some implementation for @synchronize@ method (and ...
- 11:51 PM Database Feature #6371: implement SAVE CACHE statement
- Rev 6129b/14392 fixes issues with setting initial values in the DMO interface. It also pulls in a newer MariaDB JDBC ...
01/27/2023
- 01:18 PM Base Language Feature #7082: Improve converted call site names
- I think we can provide this as an option, though if we do we will want to reduce some of the text (maybe remove the @...
- 12:57 PM Base Language Feature #7082: Improve converted call site names
- I suggest to make call site names more readable. E.g. I have to click each of this sites to understand what this code...
- 12:51 PM Base Language Feature #7082 (New): Improve converted call site names
- 12:08 PM Database Feature #6444: dataset improvements
- Retrofitted Ovidio's changes for the @DynamicQueryHelper@ from 6129b to 6444a.
This resolves #6444-115. Reworked @Bu... - 09:57 AM Database Feature #6444: dataset improvements
- Indeed, #6444-115 does not manifest itself in 6129b.
However, there are a lot of differences between this branch and... - 07:30 AM Database Feature #6444: dataset improvements
- Ovidiu Maxiniuc wrote:
> I did a quick review of your commits up to 14485/6444a since 14480:
> AbstractQuery, Compo... - 02:24 AM Database Feature #6444: dataset improvements
- Ovidiu Maxiniuc wrote:
> Igor Skornyakov wrote:
> > I've encountered a strange problem. Consider the following prog... - 10:44 AM Database Feature #6371: implement SAVE CACHE statement
- I added same filtering for columns and indexes, it should save some CPU time. Also, MariaDB returns @boolean@ as @bit...
- 10:17 AM Database Feature #6371: implement SAVE CACHE statement
- Filtering is resolved - see revision 6129b/14389. It also removes the TODO I had there.
- 07:21 AM Database Feature #6371: implement SAVE CACHE statement
- Boris Schegolev wrote:
> I pushed 2 commits into 6129b - 14385 and 14386. Now our save-cache test programs operate o... - 10:44 AM Runtime Infrastructure Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...
- I meant both cases. It sounds like we are OK there, if I understand your points.
Do we have the same control over... - 10:38 AM Runtime Infrastructure Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...
- Greg Shah wrote:
> > Galya, I've tested in OpenEdge and only @MESSAGE@ statement (with or without @VIEW-AS ALERT-BOX... - 09:59 AM Runtime Infrastructure Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...
- > Galya, I've tested in OpenEdge and only @MESSAGE@ statement (with or without @VIEW-AS ALERT-BOX@) end up in the age...
- 09:53 AM Runtime Infrastructure Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...
- Galya, I've tested in OpenEdge and only @MESSAGE@ statement (with or without @VIEW-AS ALERT-BOX@) end up in the agent...
- 09:09 AM Runtime Infrastructure Bug #5701 (Test): logfile names for -O outputToFile use the spawner pid instead of the Java (FWD ...
- I'm uploading the latest diff that includes the win changes. They are committed to 5701a as well. I'll be testing tho...
- 05:47 AM Runtime Infrastructure Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...
- Starting appserver as scheduled batch initializes @ThinClient@, @BatchDriver@, @OutputManager@, @ErrorWriterBatch@, c...
- 09:16 AM Database Feature #7064: Analyze the performance impact of the implicit meta schema in H2
- > org.h2.engine.Database.meta only stores information from non-temporary sessions, which we do not use
Although we... - 08:34 AM Database Feature #7064 (WIP): Analyze the performance impact of the implicit meta schema in H2
- Alexandru Lungu wrote:
> * H2 generates an implicit @INFORMATION_SCHEMA@ schema on database creation. This schema co... - 08:04 AM Base Language Feature #3853: implement LOG-MANAGER runtime
- I've found a workaround fix for batch writing all @stdout@ through @ErrorWriterBatch#displayError()@, which messed up...
- 07:58 AM Database Feature #7062 (WIP): Direct access to H2 internals to solve basic queries
- I've done some consistent implementation for the @FIND tt WHERE recid(tt) = 2@ use-case. However, I am facing some li...
- 03:02 AM Runtime Infrastructure Feature #7080: expose all admin APIs via REST
- A small clarification. The Admin remoting isn't based on @RemoteObject@ since the GWT rewrite.
There are three (GW... - 10:58 PM Database Feature #6348: implement support for MariaDB
- Indeed, there were several updates to the dialects. But there are some unfinished features:
* what I know for sure i...
01/26/2023
- 06:36 PM Runtime Infrastructure Feature #7080: expose all admin APIs via REST
- Moving to a REST API will provide several benefits.
* It will be a simpler and cleaner model than the current sync... - 06:20 PM Runtime Infrastructure Feature #7080 (Test): expose all admin APIs via REST
- 06:20 PM Database Feature #6444: dataset improvements
- Igor Skornyakov wrote:
> I've encountered a strange problem. Consider the following program:
> [...]
> It works fi... - 01:45 PM Database Feature #6444: dataset improvements
- Finished support for the @SYNCHRONIZE@ method, albeit not in a very efficient way (see #6444-115, #6444-116).
Comm... - 11:53 AM Database Feature #6444: dataset improvements
- Igor Skornyakov wrote:
> What is the right way to retrieve the value of the primary key from the @BufferImpl@ instan... - 10:02 AM Database Feature #6444: dataset improvements
- What is the right way to retrieve the value of the primary key from the @BufferImpl@ instance.
Thank you. - 07:23 AM Database Feature #6444: dataset improvements
- The @HQLPrepocessor.getFindByRowid@ method looks strange
# It checks only the first parameter. In my test the @rowid... - 05:40 AM Database Feature #6444: dataset improvements
- I've found a workarount for #6444-115, but at the cost of more complicated (and expensive) query:...
- 04:35 AM Database Feature #6444: dataset improvements
- I've encountered a strange problem.
Consider the following program:... - 05:20 PM Database Feature #6371: implement SAVE CACHE statement
- I pushed 2 commits into 6129b - 14385 and 14386. Now our save-cache test programs operate on PostgreSQL and MariaDB e...
- 06:28 AM Database Feature #6371: implement SAVE CACHE statement
- I've manually ported the SAVE CACHE feature from trunk rev 14483 to 6129b and committed that as 6129b/14383. I have d...
- 03:53 AM Database Feature #6371: implement SAVE CACHE statement
- Boris, we were discussing the @datetime-tz@ implementation yesterday, but there is still a TODO in the code for the I...
- 03:48 AM Database Feature #6371: implement SAVE CACHE statement
- I committed 6371a/14458, which:
* implements thread safety to prevent concurrent schema checking and DMO generatio... - 02:09 PM Database Feature #7037: remove dirty share manager
- As far as I understand, the following should happen when dirty sharing is disabled in the directory:
# Dirty databa... - 02:02 PM Conversion Tools Feature #3883: eclipse plug for developing 4GL code using FWD including editing, syntax checks, r...
- In April 2022, the official word is that "Eclipse Theia is the next generation of Eclipse!":https://eclipse-foundatio...
- 01:54 PM Conversion Tools Feature #6319: IntelliJ plugin
- The long term roadmap for IntelliJ is not clear, I can't find it published anywhere. If anyone can point me to somet...
- 10:35 AM Runtime Infrastructure Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...
- Greg Shah wrote:
> Eugenie: Please review.
The change looks good for me. - 08:15 AM Runtime Infrastructure Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...
- Eugenie: Please review.
- 08:05 AM Runtime Infrastructure Bug #5701 (Review): logfile names for -O outputToFile use the spawner pid instead of the Java (FW...
- 08:01 AM Runtime Infrastructure Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...
- Find attached a good solution to the wrong pid in @outputToFile@ name. It simplifies the spawner logic by removing a ...
- 10:13 AM Database Bug #7035: Extract query parameters from statically converted FQL
- Dănuț Filimon wrote:
> What is the purpose of @inlineSubstitutionParameter@? The modifications I made for extracting... - 10:06 AM Base Language Feature #6820: reduce String.toLowerCase and toUpperCase usage and String instances
- The use of @String.toLowerCase@ and @toUpperCase@ in @P2JField.computeHash - 90k@ and @Validation.setUniqueQueryPara...
- 09:58 AM Base Language Feature #6820: reduce String.toLowerCase and toUpperCase usage and String instances
- The use of @toLowerCase@ and @toUpperCase@ in @h2.Function.getSimpleValue - 178k@ is valid there.
- 09:04 AM Base Language Feature #6421: finish GENERATE-RANDOM-KEY support
- Create a task branch (6421a) and you can commit changes there.
- 08:52 AM Base Language Feature #6421: finish GENERATE-RANDOM-KEY support
- I read the encryption algorithm by using @SecurityPolicyManager.getSymmetricEncryptionAlgorithm().toStringMessage()@....
- 08:21 AM Database Feature #6995: possibly support NO-UNDO temporary tables directly in H2
- I've included in H2 a flag for temporary tables that shows whether or not a table is defined with @no-undo@. The main...
- 04:12 AM Database Feature #7076: make CAN-FIND avoid hydration
- I found Ovidiu's comment in #5453-2 relevant for this task.
01/25/2023
- 05:17 PM Database Feature #7076: make CAN-FIND avoid hydration
- Let's go for the quick win.
- 04:43 PM Database Feature #7076: make CAN-FIND avoid hydration
- It does, if we implement it as a sub-select (i.e., when it is a nested CAN-FIND in another query's WHERE clause).
... - 02:59 PM Database Feature #7076: make CAN-FIND avoid hydration
- I assume we already do this, but just in case, does CAN-FIND avoid hydration?
- 02:58 PM Database Feature #7076 (Closed): make CAN-FIND avoid hydration
- 04:13 PM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
- Greg Shah wrote:
> 3821c?
I meant 6129b. 3821c has burned into my cerebral cortex after the years working with th... - 04:08 PM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
- 3821c?
- 03:48 PM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
- 3821c revision 14382 introduces caching of resolved procedure internal entries. It speeds up tests in a large custome...
- 04:07 PM Database Feature #6371: implement SAVE CACHE statement
- Implemented validation "except for the implicit primary key index, the primary key may only appear at the end of a no...
- 02:28 PM Database Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries
- > > For example, the @lvalue@ rule will be doing constant lookups of a wide range of possible matches while the actua...
- 02:10 PM Database Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries
- In regard to writing things to disk for persistence between server runs, we could write the generated DMOs (bytecode)...
- 01:47 PM Database Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries
- Greg Shah wrote:
> I suspect there is still some significant improvement that can be made to the performance. The c... - 01:37 PM Database Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries
- Greg Shah wrote:
> I have another idea, which I think should be a "game changer". Let's write out the generated cla... - 01:06 PM Base Language Feature #3853: implement LOG-MANAGER runtime
- I've found an unexpected behavior with batch execution. @stdout@ is displayed using @ErrorManager.displayError(lineOu...
- 10:25 AM Database Feature #6928: H2 UPDATE performance improvement
- I added a patch that fixes the problem that I found earlier (and another one that I found while testing). Long story ...
- 05:36 AM Database Feature #6928: H2 UPDATE performance improvement
- Radu, please debug this and fix it.
- 05:34 AM Database Feature #6928: H2 UPDATE performance improvement
- While working on another task, I stumbled upon an issue. With fwd-h2 rev.7 it worked fine, *but in rev.8 there seems ...
- 07:37 AM Base Language Bug #7073 (New): Launching non-interactive program creates JNI core dump in process_linux.c due t...
- 11:25 PM Base Language Bug #7073: Launching non-interactive program creates JNI core dump in process_linux.c due to ncurses
- Greg Shah wrote:
> That failing code is not code that is checked in to trunk. It is specific to *your system*. You... - 07:29 PM Base Language Bug #7073 (Rejected): Launching non-interactive program creates JNI core dump in process_linux.c ...
- That failing code is not code that is checked in to trunk. It is specific to *your system*. Your logging is broken.
- 06:11 AM Database Feature #7061: Enable the use of lazy result sets in H2
- Eric Faulhaber wrote:
> Alexandru Lungu wrote:
>
> > Adopting this idea means replacing @ProgressiveResults@ with... - 05:35 AM Database Feature #7061: Enable the use of lazy result sets in H2
- Alexandru Lungu wrote:
> Adopting this idea means replacing @ProgressiveResults@ with @ScrollingResults@ backed by... - 06:09 AM Database Bug #7035: Extract query parameters from statically converted FQL
- Dănuț Filimon wrote:
> Are there any cases where @NUM_LITERAL, DEC_LITERAL, STRING@ should not be substituted?
... - 05:59 AM Database Bug #7035: Extract query parameters from statically converted FQL
- I wrote an implementation for that makes use of the @FQLPreprocessor.mainWalk@ method to parse the where clause AST a...
- 05:38 AM Database Feature #7063: Support FIRST/LAST join directly in H2
- Eric Faulhaber wrote:
> When converting FIND/FIRST LAST, whether as a joined query component (i.e., @RandomAccessQue...
01/24/2023
- 06:57 PM Base Language Bug #7073: Launching non-interactive program creates JNI core dump in process_linux.c due to ncurses
- With logging added to @process_linux.c@ we see it occur in @ fprintf(fp, "pseudoTerminalWait: move cursor part 2...
- 06:56 PM Base Language Bug #7073: Launching non-interactive program creates JNI core dump in process_linux.c due to ncurses
- @uast/util/process_launch_helper.p@ can be used.
Using Swing, run the program, and pass in any command, like *ls*
... - 06:50 PM Base Language Bug #7073 (New): Launching non-interactive program creates JNI core dump in process_linux.c due t...
- 05:32 PM Database Feature #7063: Support FIRST/LAST join directly in H2
- Alexandru Lungu wrote:
> An alternative to this technique would be to introduce a @FIRST JOIN@ or @LAST JOIN@ into... - 11:10 AM Database Feature #6444: dataset improvements
- Eric Faulhaber wrote:
> Igor, have you ported the changes needed from 6129b into 6444a? Where do you feel we now sta... - 10:53 AM Database Feature #6444: dataset improvements
- Igor, have you ported the changes needed from 6129b into 6444a? Where do you feel we now stand on % Done for this iss...
- 10:49 AM Database Feature #6628: port PostgreSQL native user defined functions to MariaDB
- Eric Faulhaber wrote:
> Igor, is this task finished, other than implementing your idea for error handling? How much ... - 10:44 AM Database Feature #6628: port PostgreSQL native user defined functions to MariaDB
- Igor, is this task finished, other than implementing your idea for error handling? How much effort do you think it is...
- 10:40 AM Database Feature #6348: implement support for MariaDB
- Ovidiu, as of 3821c/14182, we have this issue marked as 60% done. Many changes have been made since then, including l...
- 06:17 AM Database Feature #7064: Analyze the performance impact of the implicit meta schema in H2
- Alexandru Lungu wrote:
> Now that I am reading #7064-1 again, it needs some rephrasing indeed.
> I am mostly referr... - 05:48 AM Database Feature #7064: Analyze the performance impact of the implicit meta schema in H2
- Igor Skornyakov wrote:
> Sorry, I do not understand what you mean. As far as I remember the META database contains i... - 06:13 AM Database Feature #7066: Implement multi-table indexed query in H2
- You can simply check @prg.h2.result.SortOrder.sort@. This holds the @ORDER BY@ clause and is triggered only when H2 n...
- 02:31 AM Database Feature #7066: Implement multi-table indexed query in H2
- Alexandru, what H2 methods are responsible for this re-sorting of the rows? I want to check in the profiler.
- 05:16 AM Database Feature #7062: Direct access to H2 internals to solve basic queries
- Greg Shah wrote:
> This is really interesting. For temp-tables (and using H2 for a permanent database), it is conce... - 02:53 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
- Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > Constantin Asofiei wrote:
> > > Bellow are the backtraces for ... - 02:38 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
- Hynek Cihlar wrote:
> Constantin Asofiei wrote:
> > Bellow are the backtraces for @SourceNameMapper.getInternalEntr... - 02:37 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
- Constantin Asofiei wrote:
> Bellow are the backtraces for @SourceNameMapper.getInternalEntry@ - these are reduced af... - 02:24 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
- Bellow are the backtraces for @SourceNameMapper.getInternalEntry@ - these are reduced after the InvokeConfig call-sit...
- 07:42 PM Database Feature #7020: always use "expanded" extent fields
- Thank you Constantin for the link to wiki. I was able to identify the cause of the NPE. When retrieving meta informat...
01/23/2023
- 06:57 PM Database Feature #6371: implement SAVE CACHE statement
- I pushed a fix for the issue with removing columns. Also fixed another minor thing. See revision 14456.
- 04:50 PM Database Bug #6829: H2 forces re-parse of all prepared statements when metadata is changed
- Alexandru Lungu wrote:
> Constantin Asofiei wrote:
> > Alexandru, I've uncommited 6129b rev 14378. The changes in t... - 04:38 AM Database Bug #6829: H2 forces re-parse of all prepared statements when metadata is changed
- I created #7060 to target exactly the issue of wildcard usage, as a performance/memory management standalone improvem...
- 04:14 AM Database Bug #6829: H2 forces re-parse of all prepared statements when metadata is changed
- Eric Faulhaber wrote:
> Alexandru Lungu wrote:
>
> > Committed 6129b/rev. 14378. This includes no alias columns f... - 03:17 PM Database Support #7058: get the FWD fork of the H2 code base under version control
- > Should we use the same branch naming convention (task number + ascending letters) as we use in FWD? It probably mak...
- 03:11 PM Database Feature #7064: Analyze the performance impact of the implicit meta schema in H2
- Sorry, I do not understand what you mean. As far as I remember the META database contains information about permanent...
- 07:22 AM Database Feature #7064: Analyze the performance impact of the implicit meta schema in H2
- There is a so called @INFORMATION_SCHEMA@ in H2 which is implicitly built: once for a shared temp-database and multip...
- 07:02 AM Database Feature #7064 (Rejected): Analyze the performance impact of the implicit meta schema in H2
- 02:52 PM Database Feature #7062: Direct access to H2 internals to solve basic queries
- This is really interesting. For temp-tables (and using H2 for a permanent database), it is conceptually close to the...
- 06:23 AM Database Feature #7062: Direct access to H2 internals to solve basic queries
- I've done slim experiments with the H2 internals to understand how easy/fast is to interface directly with H2. I have...
- 05:38 AM Database Feature #7062 (Closed): Direct access to H2 internals to solve basic queries
- 12:33 PM Database Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries
- I have another idea, which I think should be a "game changer". Let's write out the generated classes (and any critic...
- 12:28 PM Database Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries
- I suspect there is still some significant improvement that can be made to the performance. The core parsing might be...
- 12:02 PM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
- Constantin, I didn't find any major performance issues profiling the big customer application. Can you please share m...
- 09:25 AM Database Feature #7066: Implement multi-table indexed query in H2
- As far as I could investigate H2, it seems like multi-table queries are severely lacking indexed traversal of joined ...
- 09:08 AM Database Feature #7066 (WIP): Implement multi-table indexed query in H2
- 06:47 AM Database Feature #7063: Support FIRST/LAST join directly in H2
- I recall spending some time in #6196 to identify a clean and short way to encode the 4GL FIRST/LAST semantics using S...
- 06:24 AM Database Feature #7063 (New): Support FIRST/LAST join directly in H2
- 05:36 AM Database Feature #7061: Enable the use of lazy result sets in H2
- *Prerequisites*
FWD converts most of the index-sorted single-table @FOR@ queries into @AdaptiveQuery@. With the effo... - 04:40 AM Database Feature #7061 (Closed): Enable the use of lazy result sets in H2
- 04:50 AM Database Feature #7060: Consider using wildcard selection to reduce SQL size
- Please note that this change may require extensive testing and changes in some non-obvious places.
For example in m... - 04:35 AM Database Feature #7060: Consider using wildcard selection to reduce SQL size
- There is initial work in #6829 on introducing wildcard selection (using @*@ symbol). This can reduce the size of an S...
- 04:17 AM Database Feature #7060 (Closed): Consider using wildcard selection to reduce SQL size
- 02:53 AM Database Feature #6816: improve PreselectQuery.assembleHQL
- Alexandru Lungu wrote:
> Looks good, no concerns.
Done. Committed to 6129b, rev. 14379.
01/20/2023
- 05:49 PM Database Feature #6371: implement SAVE CACHE statement
- I found the root cause for the error you described. Luckily, it's not caching or so, but just a logical mistake (Sche...
- 02:27 PM Database Feature #7020: always use "expanded" extent fields
- Thank you for doing the tests.
May I have some details on this abend? An error message or a stack trace / log file?
... - 03:41 AM Database Feature #7020: always use "expanded" extent fields
- I've tested 7020a/14377 and there is an abend with a customer's application.
- 12:19 AM Database Feature #7020: always use "expanded" extent fields
- Eric Faulhaber wrote:
> On the dynamic index issue, we will have the variable's value at runtime. Isn't this enough ... - 01:31 PM Database Bug #7059: FWD shouldn't raise errors for non-numeric extent indexes.
- The original issue was #7043-4. Copied from there:...
- 01:29 PM Database Bug #7059 (WIP): FWD shouldn't raise errors for non-numeric extent indexes.
- 12:57 PM Database Bug #6829: H2 forces re-parse of all prepared statements when metadata is changed
- Alexandru, I've uncommited 6129b rev 14378. The changes in this rev are in the attached patch.
- 12:42 PM Database Bug #6829: H2 forces re-parse of all prepared statements when metadata is changed
- Alexandru Lungu wrote:
> Committed 6129b/rev. 14378. This includes no alias columns for all SELECT queries and wil... - 10:54 AM Database Bug #6829: H2 forces re-parse of all prepared statements when metadata is changed
- Alexandru Lungu wrote:
> Greg Shah wrote:
> > > However, we CAN do an inspection before the FQL->SQL conversion and... - 10:46 AM Database Bug #6829: H2 forces re-parse of all prepared statements when metadata is changed
- Greg Shah wrote:
> > However, we CAN do an inspection before the FQL->SQL conversion and, if there are none of these... - 12:37 PM Database Support #7058: get the FWD fork of the H2 code base under version control
- We have entered a new phase of H2 performance improvement work, and there is already a set of changes we have been ma...
- 12:31 PM Database Support #7058 (Closed): get the FWD fork of the H2 code base under version control
- 12:29 PM Database Feature #6928: H2 UPDATE performance improvement
- Alexandru Lungu wrote:
> H2 rev. 7 is mostly targeting progressively fetched (using LIMIT) multi-table @AdaptiveQuer... - 11:37 AM Database Feature #6928: H2 UPDATE performance improvement
- H2 rev. 7 is mostly targeting progressively fetched (using LIMIT) multi-table @AdaptiveQuery@. This is not yet part o...
- 09:28 AM Database Feature #6928: H2 UPDATE performance improvement
- H2's UPDATE command was profiled and improved to avoid object allocations and unnecessary iterations. This is in fwd...
- 10:38 AM Database Feature #6816: improve PreselectQuery.assembleHQL
- Looks good, no concerns.
- 09:33 AM Database Feature #6816: improve PreselectQuery.assembleHQL
- I think this can be committed to 6129b. Alexandru, any concerns?
- 06:52 AM Database Feature #6816: improve PreselectQuery.assembleHQL
- With Alex's help, I've managed to find an example that results in that error. The problem was my misinterpretation of...
- 03:11 AM Database Feature #6816: improve PreselectQuery.assembleHQL
- I've tried the patch with a customer application and there is an abend:...
- 10:34 AM Database Support #6714 (Review): check if there is an optimization opportunity when copying temp-tables ba...
- 09:53 AM Database Feature #6825: improve table meta runtime (TableMapper and other)
- The approach in #6825-4 improved the TableMapper memory and CPU footprint, but the access to these is still done in a...
- 09:51 AM Database Feature #2137: runtime support for FIELDS/EXCEPT record phrase options
- Current changes work, although normalized extent fields are always loaded. Otherwise, #6720 may touch this area again.
- 07:11 AM Database Feature #2137: runtime support for FIELDS/EXCEPT record phrase options
- 6129b/14377 has the EXCEPT/FIELDS support ported from trunk - this includes some work done by Sergey in #5731
- 09:48 AM Base Language Feature #6820: reduce String.toLowerCase and toUpperCase usage and String instances
- I marked the issue at 100%. But there are still some left out places, those that were more complex to address (see #6...
- 09:27 AM Base Language Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection
- A resume of what was done at this task:
Experiments were done using lambda expression instead of Java reflection o... - 09:25 AM Base Language Support #4032: block/transaction processing context-local and other performance improvements
- Changes mentioned in previous notes:
* cache the 'helper' instance at the WrappedResource, object and other cases, t... - 09:23 AM Base Language Feature #6827: reduce the memory footprint of WrappedResource implementations: replace BDTs with ...
- Profiling and manual/automated code review was used to identify BDT and collection fields in WrappedResource implemen...
- 09:22 AM Base Language Feature #6826 (Review): reduce the BDT usage in FWD runtime
- Profiling and manual/automated code review was used to identify BDT field and local variable definitions. These were...
- 09:21 AM Base Language Feature #6824: lazy initialization of collection class members
- The fixes part of the fixes from previous notes were determined from profiling and manual/automated code review, used...
- 09:20 AM Base Language Feature #6650: improve performance of Scopeable notification in TM.processScopeNotifications
- After what was done in #6650-34, scope processing is still an expensive area, although the possibilities to improve i...
- 08:51 AM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
- I understand. My concern is not with your change, it is with my code in @convert/control_flow.rules@. It doesn't co...
- 08:34 AM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
- The code in control_flow.rules considers the case where the 4GL @return.@ statement is the last one in the top-level ...
- 08:30 AM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
- Code Review Task Branch 7045a Revision 14481
I don't object to the change, but I'm unsure if it will work quite ri... - 03:25 AM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
- The changes from 7045a are ported and committed to 6129b/14375.
- 02:37 AM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
- 7045a/14481 added another condition to emit a real Java return: the 4GL return statement must not have any downstream...
- 07:05 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
- 6129b revision 14376 reimplements the case insensitive maps in @SourceNameMapper@ with @CaseInsensitiveHashMap@.
- 04:55 AM Database Feature #6720: lazy hydration
- Thanks for the second set of eyes, Alexandru! I was staring at this too long and completely missed that the second ca...
- 04:08 AM Database Feature #6720: lazy hydration
- Eric Faulhaber wrote:
> In the first conditional block, we check the session cache for a DMO with the primary key re... - 03:33 AM Database Feature #6720: lazy hydration
- Ovidiu, Constantin, Alexandru, can you please help me understand this snippet of code in @SQLQuery.hydrateRecordImpl@...
- 03:41 AM Database Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries
- Constantin Asofiei wrote:
> Ovidiu, did you meant to rebase 6813a on top of 7020a? See commits 14375 and 14376
I c... - 03:32 AM Database Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries
- Ovidiu, did you meant to rebase 6813a on top of 7020a? See commits 14375 and 14376
- 08:38 PM Database Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries
- I have done the final clean-up and local tests and then rebased from @6129b@ and pushed to @../p2j/active/6813a/@. Th...
01/19/2023
- 03:35 PM Database Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries
- Constantin Asofiei wrote:
> Ovidiu Maxiniuc wrote:
> > A NPE, OTOH, will immediately pinpoint to the source of the ... - 02:43 PM Database Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries
- Ovidiu Maxiniuc wrote:
> A NPE, OTOH, will immediately pinpoint to the source of the error.
Ovidiu, we need this in... - 02:40 PM Database Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries
- Sorry, I was not aware of this @Automatic Null Checking@ feature. My bad. I experimented the exact situation referred...
- 02:06 PM Database Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries
- Ovidiu Maxiniuc wrote:
> Since @node@ is @null@, the original code will evaluate to @false@ without throwing NPE.
... - 01:49 PM Database Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries
- > Since node is null, the original code will evaluate to false without throwing NPE. The upPath now will execute the ...
- 12:54 PM Database Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries
- I understand. What is the appropriate action to do when @node@ is @null@ when replacing:...
- 08:50 AM Database Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries
- > I will investigate in-depth later tomorrow/today, but it looks to me like out JIT is not working correctly. Instead...
- 12:33 AM Database Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries
- Committed r14365 of 6813a. All occurrences have been processed and upgraded, including those from Java code and @prog...
- 02:33 PM Base Language Feature #6820: reduce String.toLowerCase and toUpperCase usage and String instances
- Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > ... 6129b revision 14369. And related fixes. Please review.
> ... - 02:20 PM Base Language Feature #6820: reduce String.toLowerCase and toUpperCase usage and String instances
- Hynek Cihlar wrote:
> ... 6129b revision 14369. And related fixes. Please review.
I see only one issue:
* TempTabl... - 11:21 AM Base Language Feature #6820 (Review): reduce String.toLowerCase and toUpperCase usage and String instances
- I removed all the upper/lower case occurrences in the list in #6820-4 with the exception of the following list. These...
- 06:48 AM Base Language Feature #6820: reduce String.toLowerCase and toUpperCase usage and String instances
- Eric Faulhaber wrote:
> Hynek Cihlar wrote:
>
> > I'm not sure we want to give up @AbstractHashedMap@. My prelimin... - 06:33 AM Base Language Feature #6820: reduce String.toLowerCase and toUpperCase usage and String instances
- XmlImport.tablesByXmlName changed to @CaseInsensitiveHashMap@ and some other cases in 6129b revision 14369. And relat...
- 02:28 PM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
- Code Review Task Branch 7045a Revision 14480
Weird. I don't understand the reason this works, but the code seems ... - 02:11 PM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
- The problem described in #7045-15 is fixed in 7045a rev 14480.
- 08:11 AM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
- There was a regression, in some cases like:...
- 11:21 AM Base Language Feature #6649 (WIP): improve the performance or SourceNameMapper runtime
- 10:48 AM Database Feature #7037: remove dirty share manager
- We have multiple applications which are dependent upon the record nursery (item 3 in #7037-6) but which do not (as fa...
- 08:02 AM Database Bug #6829: H2 forces re-parse of all prepared statements when metadata is changed
- > However, we CAN do an inspection before the FQL->SQL conversion and, if there are none of these special columns, th...
- 05:05 AM Database Bug #6829: H2 forces re-parse of all prepared statements when metadata is changed
- > You are right. However, we CAN do an inspection before the FQL->SQL conversion and, if there are none of these spec...
- 07:51 PM Database Feature #7020: always use "expanded" extent fields
- Ovidiu Maxiniuc wrote:
> I would like to keep it this way for a little, until the conversion is "expanded"-aware. ... - 07:36 PM Database Feature #7020: always use "expanded" extent fields
- Eric Faulhaber wrote:
> Code review 7020a/14361-14362:
> Nice work! Thank you for turning it around in such a short... - 07:39 PM Database Feature #6371: implement SAVE CACHE statement
- Boris, I agree that the messiness of the data type processing is not nice. If you have a way to simplify this while s...
01/18/2023
- 05:29 PM Database Bug #6829: H2 forces re-parse of all prepared statements when metadata is changed
- Note that we also use H2's query cache (the default size is 8; we set it to 1024 in @H2Helper.setCommonInMemoryProper...
- 05:13 PM Database Bug #6829: H2 forces re-parse of all prepared statements when metadata is changed
- I applaud efforts to make the SQL more compact and thereby reduce the memory consumption, and I agree we should pursu...
- 04:29 PM Database Bug #6829: H2 forces re-parse of all prepared statements when metadata is changed
- Alexandru Lungu wrote:
> I agree that on a general case, this is not feasible. However, I have many examples of very... - 07:36 AM Database Bug #6829: H2 forces re-parse of all prepared statements when metadata is changed
- I've analyzed a heap dump without any alias generated for the columns. I got an ~8k chars long SQL string stored in a...
- 06:19 AM Database Bug #6829: H2 forces re-parse of all prepared statements when metadata is changed
- Ovidiu Maxiniuc wrote:
> We cannot rely on H2 or any other SQL server to provide the right order of columns for our ... - 04:22 PM Database Feature #7020: always use "expanded" extent fields
- Code review 7020a/14361-14362:
Nice work! Thank you for turning it around in such a short time.
TBH, it is hard... - 11:48 AM Database Feature #7020: always use "expanded" extent fields
- Don't we already deal with this case in the current implementation of expanded extent fields? I may be misremembering...
- 03:49 PM Base Language Feature #6820: reduce String.toLowerCase and toUpperCase usage and String instances
- In the large customer application I see an improvement between 100-200ms between 6129b revisions 14366 and 14368.
- 03:23 PM Base Language Feature #6820: reduce String.toLowerCase and toUpperCase usage and String instances
- @XmlImport.tablesByXmlName@ can be switched to a @CaseInsensitiveHashMap@. The other cas remaining - from @TempTable...
- 02:45 PM Base Language Feature #6820: reduce String.toLowerCase and toUpperCase usage and String instances
- Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > Constantin Asofiei wrote:
> > > Unfortunately this introduces ... - 02:36 PM Base Language Feature #6820: reduce String.toLowerCase and toUpperCase usage and String instances
- Constantin Asofiei wrote:
> Both commons-collections-3.2.2.jar and commons-collections4-4.4.jar are copied in @build... - 02:21 PM Base Language Feature #6820: reduce String.toLowerCase and toUpperCase usage and String instances
- Hynek Cihlar wrote:
> Constantin Asofiei wrote:
> > Unfortunately this introduces a visible slowdown in a large cus... - 02:06 PM Base Language Feature #6820: reduce String.toLowerCase and toUpperCase usage and String instances
- Constantin Asofiei wrote:
> Unfortunately this introduces a visible slowdown in a large customer application perform... - 12:25 PM Base Language Feature #6820: reduce String.toLowerCase and toUpperCase usage and String instances
- Unfortunately this introduces a visible slowdown in a large customer application performance testing - ~200ms or so.
- 11:12 AM Base Language Feature #6820: reduce String.toLowerCase and toUpperCase usage and String instances
- Hynek Cihlar wrote:
> Actually we explicitly declare dependency on @commons-collection-3.2.2@. I deliberately added ... - 11:09 AM Base Language Feature #6820: reduce String.toLowerCase and toUpperCase usage and String instances
- Hynek Cihlar wrote:
> I'm not sure we want to give up @AbstractHashedMap@. My preliminary testing shows it outperf... - 10:41 AM Base Language Feature #6820: reduce String.toLowerCase and toUpperCase usage and String instances
- Constantin Asofiei wrote:
> Hynek, you add a dependency on @commons-collections4@ ver @4.4@, but FWD already is (in)... - 10:16 AM Base Language Feature #6820: reduce String.toLowerCase and toUpperCase usage and String instances
- Hynek, you add a dependency on @commons-collections4@ ver @4.4@, but FWD already is (in)directly dependent on commons...
- 08:56 AM Base Language Feature #6820: reduce String.toLowerCase and toUpperCase usage and String instances
- 6129b revision 14367 resolves most of the cases reported in #6820-4.
Some cases were kept because the use of lower... - 03:27 PM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
- OK, go ahead when it makes sense.
- 03:24 PM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
- Greg Shah wrote:
> Constantin: Do you want me to merge this into 6129b? It does require a reconversion, but I'd lik... - 02:43 PM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
- Constantin: Do you want me to merge this into 6129b? It does require a reconversion, but I'd like to get the perform...
- 08:39 AM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
- I haven't ported this to 6129b but it should apply pretty easily. Please try it on the customer app to see the diffe...
- 08:35 AM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
- Greg Shah wrote:
> I use @wa.tm.getBlockType()@ to check the current block instead of looking at @nearest@ which wou... - 08:33 AM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
- I use @wa.tm.getBlockType()@ to check the current block instead of looking at @nearest@ which would be @BlockType.FUN...
- 08:32 AM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
- It does exit. I've tested it here. In this case the current block type is NOT @BlockType.FUNCTION@ so it will throw...
- 08:13 AM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
- My point is about this code:...
- 07:39 AM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
- > Isn't @BlockManager.returnNormal@ supposed to throw the @ReturnUnwindException@? I mean, this code should distingui...
- 02:33 AM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
- Greg Shah wrote:
> Constantin: Please review 7045a revision 14479.
Isn't @BlockManager.returnNormal@ supposed to th... - 02:45 PM Database Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries
- Constantin Asofiei wrote:
> Ovidiu Maxiniuc wrote:
> > It seems that they never end :(. My IDE stops counting at 10... - 01:18 PM Database Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries
- Code Review Task Branch 6129b Revision 14360
The @DynamicConversionHelper@ and @DynamicQueryHelper@ need history e... - 02:46 AM Database Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries
- Ovidiu Maxiniuc wrote:
> It seems that they never end :(. My IDE stops counting at 100+ occurrences. The vast majori... - 11:18 PM Database Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries
- A new set of changes were committed to 6813a (r14364).
It seems that they never end :(. My IDE stops counting at 1... - 11:23 AM Database Feature #6444: dataset improvements
- OK, then if Constantin has no objection, let's go with the manual retrofit approach.
- 11:20 AM Database Feature #6444: dataset improvements
- Eric Faulhaber wrote:
> Igor, which approach do you think requires the least amount of effort, both for you now, and... - 11:13 AM Database Feature #6444: dataset improvements
- Igor, which approach do you think requires the least amount of effort, both for you now, and for merging 6129b to tru...
- 10:21 AM Database Feature #6444: dataset improvements
- Igor Skornyakov wrote:
> Greg Shah wrote:
> > We would like to do so, but it will not happen for at least 3 weeks.
... - 10:08 AM Database Feature #6444: dataset improvements
- Greg Shah wrote:
> We would like to do so, but it will not happen for at least 3 weeks.
I see. In this case, mayb... - 10:06 AM Database Feature #6444: dataset improvements
- We would like to do so, but it will not happen for at least 3 weeks.
- 05:25 AM Database Feature #6444: dataset improvements
- As mentioned in #6444-83 DATA-SET serialization features should better be tested/fixed on top of changes made for #64...
- 04:41 AM Database Feature #6444: dataset improvements
- Rebased the task branch 6444a to the trunk/14480.
Pushed up to revision 14484.
- 06:11 AM Database Bug #7035: Extract query parameters from statically converted FQL
- Eric Faulhaber wrote:
> Dănuț Filimon wrote:
> Note that there are other cases where we have to do some inlining ou... - 11:11 PM Database Bug #7035: Extract query parameters from statically converted FQL
- Dănuț Filimon wrote:
> What is the purpose of @inlineSubstitutionParameter@? The modifications I made for extracti... - 04:06 AM Database Bug #7047: Problem with AdaptiveQuery and ScrollableResults
- Added attachements
- 04:04 AM Database Bug #7047: Problem with AdaptiveQuery and ScrollableResults
- It looks like we have problems either with @AdaptiveQuery@ or @ScrollingResults@ (or both).
Consider the attached pr... - 04:03 AM Database Bug #7047 (New): Problem with AdaptiveQuery and ScrollableResults
- 07:42 PM Database Feature #6371: implement SAVE CACHE statement
- OK, I pushed proper translation of datatypes for Postgres - rev 14454.
I have to say that I don't really like the ...
01/17/2023
- 06:28 PM Base Language Feature #7045 (Review): re-implement "normal" (non-abend) stack unwinding to avoid throwing an ex...
- Constantin: Please review 7045a revision 14479.
- 06:26 PM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
- In addition to user-defined functions, 2 additional callable program types which are efectively the equivalent of use...
- 09:24 AM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
- I'm working on a simple approach for now. Rather than reimplementing all of the flow control for the cases where the...
- 05:53 PM Database Bug #6829: H2 forces re-parse of all prepared statements when metadata is changed
- We cannot rely on H2 or any other SQL server to provide the right order of columns for our properties. There are a lo...
- 05:58 AM Database Bug #6829: H2 forces re-parse of all prepared statements when metadata is changed
- Alexandru Lungu wrote:
> * As a risky statement, the "*" wildcard can be used in many situations to reduce SQL size.... - 04:52 AM Database Bug #6829: H2 forces re-parse of all prepared statements when metadata is changed
- > Alexandru, I have in a heap dump UnclosablePreparedStatement instances with ~90KB retained heap. But in at least a ...
- 03:38 PM Database Support #4701: try to improve H2 transaction commit performance
- We can wait. I just noticed this and it is not a critical change, just a preference. I think it is more intuitive to ...
- 03:40 AM Database Support #4701: try to improve H2 transaction commit performance
- Eric Faulhaber wrote:
> Greg Shah wrote:
> > Alexandru:
> >
> > Is #4701-72 still the correct way to enable priv... - 03:24 PM Database Feature #6444: dataset improvements
- Igor Skornyakov wrote:
> So I suggest creating a separate task for #6444-99 and switching to the remaining items i... - 02:13 PM Database Feature #6444: dataset improvements
- Igor Skornyakov wrote:
> If I add an explicit ordering to the query in the #6444-99 test, the test passes. So the pr... - 01:18 PM Database Feature #6444: dataset improvements
- Igor Skornyakov wrote:
> Regarding #6444-99:
>
> The situation is a little confusing.
> The @AdaptiveQuery.execu... - 11:24 AM Database Feature #6444: dataset improvements
- Regarding #6444-99:
The situation is a little confusing.
The @AdaptiveQuery.executeQuery()@ instead of creating @... - 09:30 AM Database Feature #6444: dataset improvements
- I believe that FILL support for recursive DATA-RELATIONs is done.
Committed to 6444a/14476.
Working on #6444-99 (... - 05:17 AM Database Feature #6444: dataset improvements
- I've got a strange exception.
A very simple test... - 04:57 AM Database Feature #6444: dataset improvements
- I've noticed a problem with DDL generation.
If the list of dialects in @p2j.cfg.xml@ contains @mariadb@ then in the... - 10:18 AM Database Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries
- Constantin,
I started with @relativePath()@ since I counted the most occurrences in @rules/@ folder. It make sense ... - 11:16 PM Database Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries
- Ovidiu Maxiniuc wrote:
> The Java support should be done (I left some scaffolding in there) but the TRPL is not full... - 10:05 AM Database Bug #7035: Extract query parameters from statically converted FQL
- I've experimented with the testcase provided and found out a lot about how FQLPreprocessor works. I wrote an implemen...
- 09:13 AM Base Language Feature #3853: implement LOG-MANAGER runtime
- +This diagram shows the current state of the call stack producing error logs (not a complete view):+
!clientlog-ol... - 06:36 AM Base Language Feature #6821: java collection performance
- As far as I can see, only @pruneSessionCache()@ issue is left here.
- 06:35 AM Base Language Feature #6821: java collection performance
- > You will see that the Scopeable scopestart/finished do lots of work - please check if it may be possible to condens...
- 02:35 AM Base Language Feature #6817: replace INSTANTIATING-PROCEDURE and other handle<ExternalProgram> with the actual ...
- Constantin Asofiei wrote:
> 6129b/14365 fixes a problem related to WidgetPool .
The change is good, thanks! - 01:28 AM Database Feature #6371: implement SAVE CACHE statement
- To determine the permissible data types, please refer to the static initializers for the @fwd2sql@ maps in the respec...
01/16/2023
- 06:45 PM Database Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries
- I have created branch 6813a and committed revision 14363.
It is not final.
The Java support should be done (I left... - 02:14 PM Database Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries
- Eric Faulhaber wrote:
> Ovidiu, did you get the varargs working? If it doesn't work directly with @Aast@, try it wit... - 02:07 PM Database Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries
- Ovidiu, did you get the varargs working? If it doesn't work directly with @Aast@, try it with @CommonAstSupport@, as ...
- 06:40 PM Database Feature #7020: always use "expanded" extent fields
- I committed r14362.
I have a problem which I did not solved: the dynamic extent indices.
For example, for the ab... - 05:23 PM Runtime Infrastructure Bug #6671: Build configurations need "fine tuning"
- I found that @src/4gl/embedded/**@ was missing from the *archive* task for the @"${dist.home}/fwd_deploy-convert_${ma...
- 03:54 PM Base Language Feature #6824: lazy initialization of collection class members
- Some other changes related to this are in 6129b/14366.
- 03:54 PM Base Language Support #4032: block/transaction processing context-local and other performance improvements
- Another batch of changes related to this is in 6129b/14366
- 03:53 PM Base Language Feature #6827: reduce the memory footprint of WrappedResource implementations: replace BDTs with ...
- 6129b/14366 contains a set of changes related to this, I don't think there's anything else remaining related to the w...
- 03:53 PM Base Language Feature #6826: reduce the BDT usage in FWD runtime
- 6129b/14366 contains a set of changes related to this, mainly from what profiling a large customer app showed.
- 03:51 PM Base Language Feature #6817 (Test): replace INSTANTIATING-PROCEDURE and other handle<ExternalProgram> with the ...
- 6129b/14365 fixes a problem related to WidgetPool .
- 03:51 AM Base Language Feature #6817 (Review): replace INSTANTIATING-PROCEDURE and other handle<ExternalProgram> with th...
- I checked in the changes in 6129b revision 14364. In addition to the attached 6817a.diff I also modified the followin...
- 02:10 AM Base Language Feature #6817: replace INSTANTIATING-PROCEDURE and other handle<ExternalProgram> with the actual ...
- Hynek, I don't see any issue with the patch. Also, the comments don't introduce anything new. Please add header ent...
- 03:28 PM Database Support #4701: try to improve H2 transaction commit performance
- Greg Shah wrote:
> Alexandru:
>
> Is #4701-72 still the correct way to enable private temp-table databases?
>
... - 02:38 PM Database Support #4701: try to improve H2 transaction commit performance
- Alexandru:
Is #4701-72 still the correct way to enable private temp-table databases?
How to we enable LOCK_MODE=0? - 12:42 PM Database Feature #7037: remove dirty share manager
- 7037a has been merged into the trunk as bzr revision 14478.
- 09:41 AM Database Feature #7037: remove dirty share manager
- Created task branch 7037a from FWD trunk revision 14477.
- 08:00 AM Database Feature #7037: remove dirty share manager
- Constantin Asofiei wrote:
> Eric, doesn't this disable the @FIND for non-temp-table records in the record nursery@ c... - 01:59 AM Database Feature #7037: remove dirty share manager
- Eric, doesn't this disable the @FIND for non-temp-table records in the record nursery@ case Greg mentioned? I ask bec...
- 01:07 AM Database Feature #7037: remove dirty share manager
- > This seems safe to commit this in both trunk and in 6129b.
Committed as 6129b rev 14362... - 12:06 PM Database Feature #6444: dataset improvements
- Ovidiu Maxiniuc wrote:
> I was writing a pretty equivalent response. That is correct. The values for paging are not ... - 12:04 PM Database Feature #6444: dataset improvements
- I was writing a pretty equivalent response. That is correct. The values for paging are not really used per-se, only t...
- 12:00 PM Database Feature #6444: dataset improvements
- Igor Skornyakov wrote:
> What is the reason to use @maxResults@ and @startOffset@ in the @QueryKey@ for the @Persist... - 04:48 AM Database Feature #6444: dataset improvements
- What is the reason to use @maxResults@ and @startOffset@ in the @QueryKey@ for the @Persistence.staticQueryCache@?
I... - 11:51 AM Base Language Bug #6399: ENCRYPT/DECRYPT built-in function results different than 4GL when IV is shorter than r...
- The runtime implementation of this is in @SecurityOps.encrypt()/decrypt()@. There should be no conversion changes ne...
- 11:49 AM Base Language Feature #6421: finish GENERATE-RANDOM-KEY support
- The runtime implementation of this is in @SecurityOps.generateRandomKey()@. There should be no conversion changes ne...
- 11:41 AM Base Language Feature #6421 (WIP): finish GENERATE-RANDOM-KEY support
- 10:41 AM Base Language Feature #6821: java collection performance
- Stanislav Lomany wrote:
> Performance overhead in function vs procedure is cause by throwing @ReturnUnwindException@... - 08:24 AM Base Language Feature #6821: java collection performance
- Performance overhead in function vs procedure is cause by throwing @ReturnUnwindException@. I think that in vast majo...
- 10:29 AM Base Language Feature #7045 (Test): re-implement "normal" (non-abend) stack unwinding to avoid throwing an exce...
- 08:03 AM Database Bug #6829: H2 forces re-parse of all prepared statements when metadata is changed
- Constantin Asofiei wrote:
> Alexandru, I think a first pass would be to change the FQL generation to use @c1@, @c2@,... - 07:08 AM Database Support #6714: check if there is an optimization opportunity when copying temp-tables based on mu...
- Constantin Asofiei wrote:
> Some concerns on moving the source records to the destination table just by updating the... - 03:52 AM Base Language Feature #6820 (WIP): reduce String.toLowerCase and toUpperCase usage and String instances
01/15/2023
- 05:13 PM Database Feature #7037: remove dirty share manager
- Greg Shah wrote:
> Eric: Do you have any objections?
>
> This seems safe to commit this in both trunk and in 612... - 04:36 PM Database Feature #7037: remove dirty share manager
- Eric: Do you have any objections?
This seems safe to commit this in both trunk and in 6129b. - 03:19 PM Database Feature #7037: remove dirty share manager
- Please review the diff which allows to disable dirty sharing. I've tested trunk with this change on the big customers...
- 06:38 AM Database Feature #7037: remove dirty share manager
- I've tested it in Hotel (I had to disable @ConnectionManager.authenticate@ to run it) and found no persistence-relate...
- 10:48 AM Database Feature #6444: dataset improvements
- Fixed second-pass query generation for queries with CONTAINS operator.
Committed to 6444a/14475.
- 12:13 AM Database Feature #7020: always use "expanded" extent fields
- I have created the 7020a branch (from 6129b) and committed r14361 which includes the changes for a first version of "...
01/14/2023
- 05:00 PM Database Feature #7037: remove dirty share manager
- The last time we measured it, I recall that about 10% of time was spent inside the dirty database. Removing it might...
- 04:59 PM Database Feature #7037: remove dirty share manager
- Let's make sure that Hotel works properly with your changes.
- 07:17 AM Database Feature #7037: remove dirty share manager
- Eric expected that the persistence layer will break badly if there is not a safe mocking version of the @NopDirtyShar...
- 04:57 PM Base Language Feature #6821: java collection performance
- Stanislav Lomany wrote:
> [...]
>
> It looks interesting to me that functions are executed 10 times slower than p... - 04:28 PM Base Language Feature #6821: java collection performance
- ...
- 01:36 AM Database Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries
- varargs in TRPL are emulated via @Object[]@ I think - see @CommonAstSupport.getAncestorOfType@ for an example.
- 09:56 PM Database Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries
- Ovidiu Maxiniuc wrote:
> Eric Faulhaber wrote:
> > That should make the replacement TRPL code simpler and more comp... - 08:37 PM Database Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries
- Greg Shah wrote:
> I understand. Even though it is possibly not much improvement, it still must be something small ...
01/13/2023
- 06:26 PM Database Feature #6371: implement SAVE CACHE statement
- I pushed minor updates to the table validation procedure - new rule plus the table name shows up in the error window....
- 11:56 AM Database Feature #6371: implement SAVE CACHE statement
- Eric Faulhaber wrote:
> Eric Faulhaber wrote:
> On second thought, this might not be what you were seeing. This was... - 03:53 AM Database Feature #6371: implement SAVE CACHE statement
- Eric Faulhaber wrote:
> Boris, with rev 14450, I get this in an infinite loop when I run @save-cache3.p@:
>
> [..... - 02:48 AM Database Feature #6371: implement SAVE CACHE statement
- Boris, with rev 14450, I get this in an infinite loop when I run @save-cache3.p@:...
- 05:23 PM Base Language Feature #6817: replace INSTANTIATING-PROCEDURE and other handle<ExternalProgram> with the actual ...
- The attached diff contains @handle@ replacements for the @com.goldencode.p2j.persist@ Java package. I left several co...
- 04:51 PM Database Feature #7037: remove dirty share manager
- I'm done for today, but for the case you're in a hurry, I've attached option 1: @NopDirtyShareContext@ as well as opt...
- 03:44 PM Database Feature #7037: remove dirty share manager
- > Please create a @NopDirtyShareContext@ by extending @DirtyShareContext@ and write each method as an empty implement...
- 02:15 PM Database Feature #7037 (WIP): remove dirty share manager
- 11:43 AM Database Feature #7037: remove dirty share manager
- Greg Shah wrote:
> Please create a @NopDirtyShareContext@ by extending @DirtyShareContext@ and write each method as ... - 10:18 AM Database Feature #7037: remove dirty share manager
- FYI, the following are the existing (known) use cases for the dirty share database.
# FIND query cross-session mod... - 10:07 AM Database Feature #7037: remove dirty share manager
- Optimally this should be configurable in the directory so that we can turn it on or off without code changes.
- 10:06 AM Database Feature #7037: remove dirty share manager
- Please create a @NopDirtyShareContext@ by extending @DirtyShareContext@ and write each method as an empty implementat...
- 03:27 AM Database Feature #7037: remove dirty share manager
- Greg Shah wrote:
> How easy is it to separate the portions only used for the cross-session behavior (which is about ... - 02:49 AM Database Feature #7037: remove dirty share manager
- How easy is it to separate the portions only used for the cross-session behavior (which is about the 4GL transaction ...
- 02:21 PM Base Language Feature #6821: java collection performance
- Committed 6129b rev 14358: Final round of performance improvements which are replacements of some 'for-each' loops wi...
- 10:36 AM Database Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries
- Greg Shah wrote:
> > They must be grouped in a block / single_block / stmt_list to benefit from natural processing d... - 03:11 AM Database Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries
- Greg Shah wrote:
> > I think there are other source of improvements in TRPL. One I can guess now are usages of @down... - 03:02 AM Database Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries
- > I think there are other source of improvements in TRPL. One I can guess now are usages of @downPath@ and @upPath@ w...
- 03:01 AM Database Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries
- > They must be grouped in a block / single_block / stmt_list to benefit from natural processing downstream. I debugge...
- 12:06 AM Database Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries
- I tried to create a new @dynamic_query@ entry point for parser. There are 3-4 statements which need to be supported:
... - 08:42 AM Base Language Feature #3853: implement LOG-MANAGER runtime
- When @-clientlog@ or @LOG-MANAGER:LOGFILE-NAME@ is defined logging level 1 is always enabled (except if explicitly se...
- 02:52 AM Base Language Feature #3853: implement LOG-MANAGER runtime
- Marian Edu wrote:
> Bref, using @-errostack@ has no effect on the client log so don't bother with it in this case.
... - 02:43 AM Base Language Feature #3853: implement LOG-MANAGER runtime
- Greg Shah wrote:
> Marian: Can you offer any guidance?
* @-errorstack@ (@session:error-stack-trace@) has no effec... - 06:25 AM Database Feature #6816: improve PreselectQuery.assembleHQL
- I've attached a patch in which I've done some refactoring to the @SortCriterion@ constructor. Mainly, instead of call...
01/12/2023
- 02:30 PM Database Feature #7037: remove dirty share manager
- The dirty share manager originally was added to solve a problem with a particular use case in one customer's applicat...
- 01:53 PM Database Feature #7037 (Test): remove dirty share manager
- 10:54 AM Database Feature #6444: dataset improvements
- Added fix for H2 bug with bind parameters in recursive CTEs.
Now the test works fine both temp tables and permanent ... - 01:51 AM Database Feature #6444: dataset improvements
- > It returns nothing. Moreover, as I mentioned the problem is gone if the query has no parameters.
> It is known tha... - 01:43 AM Database Feature #6444: dataset improvements
- Ovidiu Maxiniuc wrote:
> Executing @.next()@ will cause the result to advance. You lose the object of interest. You ... - 10:05 AM Base Language Feature #3853: implement LOG-MANAGER runtime
- Marian: Can you offer any guidance?
- 06:40 AM Base Language Feature #3853: implement LOG-MANAGER runtime
- I'm trying to find the difference in the log files when @SESSION:ERROR-STACK-TRACE@ (@-errorstack@) is enabled, but f...
- 09:33 AM Database Support #6714: check if there is an optimization opportunity when copying temp-tables based on mu...
- Some concerns on moving the source records to the destination table just by updating the multiplex ID to the destinat...
- 08:14 AM Database Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries
- Nice! Let's see what we can get back by implementing a new parser rule (@dynamic_query@) which is designed to do the...
- 12:17 AM Database Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries
- I added timers for the setup of @SymbolResolver@, @SchemaDictionary@ and other tasks needed for the @query-prepare@ a...
- 03:07 AM Database Bug #7035 (WIP): Extract query parameters from statically converted FQL
- The following is a testcase in which FWD hard-codes the arguments into the FQL:...
- 02:52 AM Database Bug #7035 (Closed): Extract query parameters from statically converted FQL
- 09:33 PM Base Language Feature #6824: lazy initialization of collection class members
- Review of: 6129b/14348.
I am OK with the code. However, in @DataSet@, when it is decided that @callbacks == null@ ...
01/11/2023
- 03:22 PM Database Feature #6444: dataset improvements
- Igor Skornyakov wrote:
> I've tested with permanent H2 tables.
> If I stop with the debugger in the @SQLQuery.scrol... - 02:16 PM Database Feature #6444: dataset improvements
- Igor Skornyakov wrote:
> In addition to #6444-86.
> If I set a breakpoint at the last statement of the @FqlToSqlCon... - 11:29 AM Database Feature #6444: dataset improvements
- In addition to #6444-86.
If I set a breakpoint at the last statement of the @FqlToSqlConverter.toSQL()@ (@return sql... - 10:47 AM Database Feature #6444: dataset improvements
- Ovidiu Maxiniuc wrote:
> To test these queries during in real application using the data currently in temp-tables, y... - 06:23 AM Database Support #6714: check if there is an optimization opportunity when copying temp-tables based on mu...
- There already is a JMX for @OutputTableCopier@ with the same name and it measures the execution time and call count o...
- 04:35 AM Database Support #6714: check if there is an optimization opportunity when copying temp-tables based on mu...
- Danut, can you add a counter JMX for your modification? I think we can benefit from finding out how many times this s...
- 04:04 AM Database Feature #6371: implement SAVE CACHE statement
- Simply skipping surrogate primary key column seems to break index handling, rules are failing during AST validation. ...
01/10/2023
- 06:43 PM Database Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries
- > Looking at the time results from #6813-18 it looks to me that the main slow-performance problem lies in the convers...
- 04:46 PM Database Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries
- Looking at the time results from #6813-18 it looks to me that the main slow-performance problem lies in the conversio...
- 02:15 PM Base Language Feature #6827: reduce the memory footprint of WrappedResource implementations: replace BDTs with ...
- I'm still on #6821, so feel free to do anything you want here.
- 02:13 PM Base Language Feature #6827: reduce the memory footprint of WrappedResource implementations: replace BDTs with ...
- Stanislav, do you need help here?
- 12:14 PM Base Language Feature #6821: java collection performance
- Committed 6129b rev 14351: @P2JIndex.components()@ provides direct access to the components array in order to improve...
- 11:13 AM Base Language Feature #6821: java collection performance
- Greg Shah wrote:
> Don't we already know the exact list of rowids used for all @UPDATE@ statements? We also know th... - 10:27 AM Base Language Feature #6821: java collection performance
- > Ultimately, we could iterate the tables individually and process (delete/update then invalidate) the records indivi...
- 08:40 PM Base Language Feature #6821: java collection performance
- The reason @pruneSessionCache()@ is called on @afterBuf@ and @beforeBuf@ after a batch operation executed using SQL d...
- 10:51 AM Base Language Feature #6826: reduce the BDT usage in FWD runtime
- Stanislav Lomany wrote:
> No.
OK, I'm taking it, as is easier to look in the profiler and see what can be reduced.
- 10:50 AM Base Language Feature #6826: reduce the BDT usage in FWD runtime
- No.
- 10:50 AM Base Language Feature #6826: reduce the BDT usage in FWD runtime
- Stanislav, did you start work on this?
- 09:20 AM Base Language Feature #3853: implement LOG-MANAGER runtime
- *Logging level rules:*
|Startup params/4GL setters|Auto set logging level|
|none|2|
|-logentrytypes (invalid)|0|... - 09:18 AM Database Support #6714: check if there is an optimization opportunity when copying temp-tables based on mu...
- I've made a comparison between *3821c/rev.14467* and the patched version from #6714-5 using different *patched versio...
- 09:01 AM Database Feature #6444: dataset improvements
- I'm not sure how the @EDITOR:EMPTY@ attribute was included here. We will move that work to #7032.
- 09:00 AM User Interface Feature #7032 (New): implement the EDITOR:EMPTY attribute
- 08:24 AM Testing Support #6858: rework existing testcases to use ABLUnit
- > > Wonder if we can somehow get out hands on Vladimir's implementation to see how things are working in FWD?
> I th... - 08:07 AM Testing Support #6858: rework existing testcases to use ABLUnit
- > * First, not all tests are really unit-tests - some of them really need user interaction, other tests needs an appl...
- 07:53 AM Testing Support #6858: rework existing testcases to use ABLUnit
- When I made an entry in this task on 2022-12-15 at 09:55, I accidentally set it to private.
Here it is. It relate... - 07:48 AM Testing Support #6858: rework existing testcases to use ABLUnit
- Vladimir Tsichevski wrote:
> > Wonder if we can somehow get out hands on Vladimir's implementation to see how thin... - 07:38 AM Base Language Feature #6650: improve performance of Scopeable notification in TM.processScopeNotifications
- 6129b/14350 improves:
* OUTPUT parameter processing: track if an output parameter is associated with a table field, ... - 07:34 AM Base Language Support #4032: block/transaction processing context-local and other performance improvements
- A batch of changes (including #4032-5) are in 6129b/14349
- 07:12 AM Base Language Feature #6824: lazy initialization of collection class members
- A batch of changes (including #6824-4) are in 6129b/14348
Please review. - 07:01 AM Database Feature #6825: improve table meta runtime (TableMapper and other)
- The changes for #6825-4 are in 6129b/14347
- 06:40 AM Database Feature #6830 (Review): find and fix all SQL SELECT statements with inlined literal arguments, an...
- 05:01 AM Database Feature #6830: find and fix all SQL SELECT statements with inlined literal arguments, and rewrite...
- Constantin Asofiei wrote:
> Radu, the changes are OK with 6129b and a customer app (performance is improved). Pleas... - 04:15 AM Database Feature #6371: implement SAVE CACHE statement
- Also, please review the data type checking in the PostgreSQL dialect again, and apply the methodology I described in ...
- 04:12 AM Database Feature #6371: implement SAVE CACHE statement
- Revision 14449 fixes the table name and legacy table name when creating the schema AST. Only the DMO interface name s...
01/09/2023
- 06:11 PM Database Feature #6371: implement SAVE CACHE statement
- In the end the solution is pretty simple - see revision 14448.
- 12:58 PM Base Language Feature #6821: java collection performance
- Greg Shah wrote:
> I was thinking of the DMO in its buffer form, not the concept of the specific record that is co... - 07:33 AM Base Language Feature #6821: java collection performance
- > PreselectQuery.components() - 430k
Committed 6129b rev 14345: replaced components iterator with @ArrayList.get()... - 06:58 AM Base Language Feature #6821: java collection performance
- Eric Faulhaber wrote:
> Greg Shah wrote:
> > Eric Faulhaber wrote:
> > > Greg Shah wrote:
> > > > > Greg, are you... - 06:33 AM Base Language Feature #6821: java collection performance
- Stanislav Lomany wrote:
> > I would start with Java arrays first (look for @[]@ in the text).
>
> Constantin, are... - 12:42 PM Database Feature #6830: find and fix all SQL SELECT statements with inlined literal arguments, and rewrite...
- Radu, the changes are OK with 6129b and a customer app (performance is improved). Please commit the 6830-6129b.patch...
- 06:36 AM Database Feature #6830: find and fix all SQL SELECT statements with inlined literal arguments, and rewrite...
- Here you go, the patch ported to 6129b, rev. 14344.
I tested some little examples to see that nothing breaks, but n... - 03:23 AM Database Feature #6830: find and fix all SQL SELECT statements with inlined literal arguments, and rewrite...
- Radu Apetrii wrote:
> Constantin Asofiei wrote:
> > Radu, what is the state of this task? Was anything committed to... - 02:36 AM Database Feature #6830: find and fix all SQL SELECT statements with inlined literal arguments, and rewrite...
- Constantin Asofiei wrote:
> Radu, what is the state of this task? Was anything committed to 3821c?
No, I did not co... - 12:08 PM Testing Support #6858: rework existing testcases to use ABLUnit
- Marian Edu wrote:
> not sure how the test engine will work in FWD so we're trying to make the test methods that wa... - 10:00 AM Testing Support #6858: rework existing testcases to use ABLUnit
- Greg, we have a number of things to discuss here.
* First, not all tests are really unit-tests - some of them rea... - 08:57 AM Base Language Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection
- Greg Shah wrote:
> I understand there is no performance difference in lambdas themselves. I'm wondering about the c... - 08:39 AM Database Feature #7020: always use "expanded" extent fields
- > * added a new @denormalized@ attribute in @@Property@ annotation
Please name this @expanded@ because the "denorm... - 06:31 AM Database Feature #6444: dataset improvements
- Here is my understanding of the current task status
h3. DATA-RELATION:RECURSIVE attribute
* The FILL method s...
01/08/2023
- 01:36 PM Base Language Feature #6821: java collection performance
- > I would start with Java arrays first (look for @[]@ in the text).
Constantin, are you suggesting to replace enha...
01/07/2023
- 05:51 PM Base Language Feature #6821: java collection performance
- The "for" cycle changes reviewed by Constantin were merged and committed as 6129b rev 14344.
Also available in: Atom