Project

General

Profile

Activity

From 11/10/2023 to 12/09/2023

12/08/2023

04:34 PM Database Feature #6720: lazy hydration
Alexandru, sorry for the delay. The size and the nature of changes (class tree, virtual methods) required ore time th... Ovidiu Maxiniuc
12:06 PM Database Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
The original implementation (when Hibernate was involved) had a very high overhead. I don't know the exact number, bu... Eric Faulhaber
09:35 AM Database Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
Greg Shah wrote:
> > The tests show a ~3.5% decrease in performance.
>
> No, we can't move ahead with this.
Ra...
Alexandru Lungu
09:16 AM Database Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
> The tests show a ~3.5% decrease in performance.
No, we can't move ahead with this.
Greg Shah
08:47 AM Database Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
Alexandru Lungu wrote:
> large customer application smoke tests
Done. Worked without any issue in all cases (sql lo...
Radu Apetrii
09:49 AM User Interface Bug #7824: Simplify idle connection settings and apply the default configuration for the web clie...
Sergey Ivanovskiy wrote:
> We can change the code of @WebClientsManager@ for the case when agent range is not config...
Hynek Cihlar
09:47 AM User Interface Bug #7824: Simplify idle connection settings and apply the default configuration for the web clie...
Sergey Ivanovskiy wrote:
> At this moment the debug mode is not enabled if the agent range is not configured. For th...
Hynek Cihlar
08:43 AM User Interface Bug #7824: Simplify idle connection settings and apply the default configuration for the web clie...
Sergey Ivanovskiy wrote:
> These web client settings (under @webClient@ node)
> [...]
> are set automatically for...
Greg Shah
07:22 AM User Interface Bug #7824: Simplify idle connection settings and apply the default configuration for the web clie...
We can change the code of @WebClientsManager@ for the case when agent range is not configured but the @jvmArgs@ is gi... Sergey Ivanovskiy
07:10 AM User Interface Bug #7824: Simplify idle connection settings and apply the default configuration for the web clie...
The agent range is common for the debugger and jmx agents so jvmArgs just describes jmx and/or debug agents should be... Sergey Ivanovskiy
07:06 AM User Interface Bug #7824: Simplify idle connection settings and apply the default configuration for the web clie...
At this moment the debug mode is not enabled if the agent range is not configured. For the known application there ar... Sergey Ivanovskiy
06:48 AM User Interface Bug #7824: Simplify idle connection settings and apply the default configuration for the web clie...
Sergey Ivanovskiy wrote:
> The agent port is assigned by @WebClientManager@ that reads @jvmArgs@ option in the direc...
Hynek Cihlar
06:31 AM User Interface Bug #7824: Simplify idle connection settings and apply the default configuration for the web clie...
Hynek Cihlar wrote:
> Code review 7824a revisions 14862..14867.
>
> I may be misinterpreting the changes, but I d...
Sergey Ivanovskiy
05:05 AM User Interface Bug #7824: Simplify idle connection settings and apply the default configuration for the web clie...
Hynek Cihlar wrote:
> Code review 7824a revisions 14862..14867.
>
> I may be misinterpreting the changes, but I d...
Hynek Cihlar
05:04 AM User Interface Bug #7824: Simplify idle connection settings and apply the default configuration for the web clie...
Code review 7824a revisions 14862..14867.
I may be misinterpreting the changes, but I don't see how the debug mode...
Hynek Cihlar
02:46 AM User Interface Bug #7824: Simplify idle connection settings and apply the default configuration for the web clie...
These web client settings (under @webClient@ node) ... Sergey Ivanovskiy
02:16 AM User Interface Bug #7824: Simplify idle connection settings and apply the default configuration for the web clie...
This is what was changed in this task in one patch. Sergey Ivanovskiy
02:13 AM User Interface Bug #7824: Simplify idle connection settings and apply the default configuration for the web clie...
Hynek, please review rev 14867 (7824a) that removed @MAX_HTTP_IDLE_TIMEOUT@ and added @CONNECTION_TIMEOUT@ and @INFIN... Sergey Ivanovskiy
08:38 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
Rebased 6649b to latest trunk. 6649b is now at rev. 14878. Alexandru Lungu
05:54 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
*Committed 6649b/rev.14849* where I made the following changes:
- Created @MonitorRunnable@ which allows identifying...
Dănuț Filimon
08:13 AM Deployment Support #3303: make the automated deployment process fully production ready
The playbooks are 3 years old, were never 100% complete and we never got local execution running (even though we do v... Greg Shah
08:13 PM Deployment Support #3303: make the automated deployment process fully production ready
I have been looking closer at @mgmt@ since I'd like to use it to setup a customer's VM for supporting Docker images. ... Roger Borrello
07:53 AM Build and Source Control Support #5167: using static linking to eliminate the need to patch the system-wide ncurses
Then how do we provide a newer version outside of the standard workstation? Greg Shah
07:52 AM Database Bug #8101: Issue with temp-table defined as reference-only
This isn't likely to be a FWD issue. Don't make edits there yet. It is more likely a dependency on the 4GL code side... Greg Shah
06:40 AM Base Language Feature #6417: cleanup some known items in appserver support
> * argument translation to remote definition type I think is done the same as the CALL statement does it...
What do...
Galya B

12/07/2023

06:13 PM Build and Source Control Support #5167: using static linking to eliminate the need to patch the system-wide ncurses
Greg Shah wrote:
> Is there some change in the scripts that our customers must use? If so, then it is a FWD issue.
...
Roger Borrello
04:03 PM Build and Source Control Support #5167: using static linking to eliminate the need to patch the system-wide ncurses
Is there some change in the scripts that our customers must use? If so, then it is a FWD issue.
If this is just s...
Greg Shah
03:56 PM Build and Source Control Support #5167: using static linking to eliminate the need to patch the system-wide ncurses
Greg Shah wrote:
> Is this something for the standard workstation or is it a FWD issue? You are posting in a task a...
Roger Borrello
03:03 PM Build and Source Control Support #5167: using static linking to eliminate the need to patch the system-wide ncurses
Is this something for the standard workstation or is it a FWD issue? You are posting in a task about FWD, but your c... Greg Shah
06:08 PM Database Bug #8101: Issue with temp-table defined as reference-only
I think I found the issue. In the @TemporaryBuffer.java@... Theodoros Theodorou
03:01 PM User Interface Bug #7824: Simplify idle connection settings and apply the default configuration for the web clie...
Is there any documentation about the connection settings (the full set, not just the ones changed here)?
Hynek: Pl...
Greg Shah
12:25 PM User Interface Bug #7824: Simplify idle connection settings and apply the default configuration for the web clie...
Could this task be reviewed? I rebased 7824a. Sergey Ivanovskiy
10:42 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
Greg Shah wrote:
> Eric: Is @org.apache.commons.lang3.tuple.*@ a supported/approved library for use in persistence? ...
Eric Faulhaber
10:06 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
> I've been obedient adding the overloaded method with the logical name, but where is the java @SsoAuthenticator@ get... Greg Shah
09:55 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
I've been obedient adding the overloaded method with the logical name, but where is the java @SsoAuthenticator@ getti... Galya B
09:51 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
We're doing a default authentication for SSO login, where the customer should not know anything about the details, bu... Galya B
09:50 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
Greg Shah wrote:
> Supplement to the code review: the @ldbname@ parameter must be processed case insensitively (e.g....
Galya B
09:45 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
Supplement to the code review: the @ldbname@ parameter must be processed case insensitively (e.g. storing/retrieving ... Greg Shah
09:20 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
>
> > Anyway, the directory database cfgs are there for runtime usage. Any usage from import is a side usage.
> >...
Greg Shah
09:17 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
Greg Shah wrote:
> > > I thought I had answered this in #7884-25. We are reworking the code DB logic into sessionle...
Galya B
09:15 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
> Such reader will need to learn to read the names of the classes and the javadoc, where it says:
My comment stand...
Greg Shah
09:10 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
Greg Shah wrote:
> > > 2. The logic in @connectToDb()@ which reads configuration from the directory is also somethin...
Galya B
09:01 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
Greg Shah wrote:
> Galya B wrote:
> > Greg Shah wrote:
> > > > 4. There is nothing hidden. The connection is clean...
Galya B
09:00 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
Galya B wrote:
> Greg Shah wrote:
> > > 4. There is nothing hidden. The connection is cleaned up on JVM shutdown.
...
Greg Shah
08:58 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
> > I thought I had answered this in #7884-25. We are reworking the code DB logic into sessionless code that is in F... Greg Shah
08:55 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
> 2. Is it better to create a DB connection on each login attempt in a live system?
This was a retorical question.
Galya B
08:54 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
Greg Shah wrote:
> > 4. There is nothing hidden. The connection is cleaned up on JVM shutdown.
>
> I mean it is a...
Galya B
08:52 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
> 1. It's expected to be only one connection.
Per database instance. This may be many connections to a given clus...
Greg Shah
08:50 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
Greg Shah wrote:
> I thought I had answered this in #7884-25. We are reworking the code DB logic into sessionless c...
Galya B
08:49 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
> > 2. The logic in @connectToDb()@ which reads configuration from the directory is also something that should not be... Greg Shah
08:40 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
Galya B wrote:
> Greg Shah wrote:
> > Code Review Task Branch 7884a Revision 14843
> >
> > 1. I think the logic ...
Greg Shah
08:24 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
Greg Shah wrote:
> 3. I don't think it is a good idea to implement long lived connections to the database here, nor ...
Galya B
08:18 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
Greg Shah wrote:
> 2. The logic in @connectToDb()@ which reads configuration from the directory is also something th...
Galya B
08:15 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
Greg Shah wrote:
> Code Review Task Branch 7884a Revision 14843
>
> 1. I think the logic for obtaining the defaul...
Galya B
07:27 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
Code Review Task Branch 7884a Revision 14843
1. I think the logic for obtaining the default database name (@Databa...
Greg Shah
07:21 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
Eric: Is @org.apache.commons.lang3.tuple.*@ a supported/approved library for use in persistence? I see it used there... Greg Shah
07:06 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
r14843: @setuserid(userid, password, ldbname)@. Galya B
06:45 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
It will optionally be present in the original 4GL code. There are 2 forms:
* @setuserid(userid, password)@
* @se...
Greg Shah
02:26 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
Greg Shah wrote:
> My primary concern is that we don't support the @ldbname@ parameter variant of @setuserid()@. I ...
Galya B
02:22 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
Ovidiu Maxiniuc wrote:
> For the second part. Provided the @ldbname@, the database configuration from registry can b...
Galya B
09:23 PM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
I reviewed the changes in 7884a.
I am OK with the changes. My concerns were for:
* duplicate code;
* hardcoded t...
Ovidiu Maxiniuc
08:53 AM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
Alexandru Lungu wrote:
> Regarding your last comment: it depends upon the delegate right? If the delegate is not len...
Eduard Soltan
08:40 AM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
Eduard, I started converting a really large application with 7045b (on top of 7156b). You have 3 days left to do the ... Alexandru Lungu
08:34 AM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
I think is not needed, as @QueryWrapper@ is used in conversion of @open query@ statement. And in this case QQE is not... Eduard Soltan
08:04 AM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
Alexandru, I haven't looked at the full code, but is the @QueryWrapper.handleQueryOffEnd@ still needed? Constantin Asofiei
08:34 AM Database Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
Radu Apetrii wrote:
> I'm starting the rebase now. I'll update you when it is done so we can both do the tests.
Don...
Radu Apetrii
08:13 AM Database Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
I'm starting the rebase now. I'll update you when it is done so we can both do the tests. Radu Apetrii
08:07 AM Database Feature #7416 (Internal Test): Reiterate DatabaseStatistics and leverage to other database profli...
Lets move this into Internal Test and have it completely tested and merged. Even if these are refactorings, we still ... Alexandru Lungu
07:08 AM Base Language Feature #6417 (WIP): cleanup some known items in appserver support
Galya B
06:28 AM Database Feature #6496: add equivalent support for -trig command line option
Rebased 6496a to latest trunk. 6496a is now at rev. 14869
Alexandru [ad], please review @StartupParameters@ as there...
Alexandru Lungu
04:08 AM Database Feature #6496: add equivalent support for -trig command line option
Commited the changes requested in branch 6496a rev 14748.
Also, should I add more comments inside the methods to exp...
Alexandru Donica
08:57 PM Database Feature #6496: add equivalent support for -trig command line option
Had an idea for local optimisation: in @DTM.getSchemaTrigger()@, @proceduresClassMap@ is used to cache the converted ... Ovidiu Maxiniuc
02:19 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
Eugenie Lyzenko wrote:
> In general I have no objections.
>
> But I have the question and the clear answer is ver...
Galya B

12/06/2023

06:41 PM Build and Source Control Support #5167: using static linking to eliminate the need to patch the system-wide ncurses
I fixed an oversite in @files/setup_ncurses6x.sh@ such that the environment wasn't being updated properly, as well as... Roger Borrello
06:32 PM Database Feature #6496: add equivalent support for -trig command line option
Review of 6496a/14743-7:
Good job. I think the code is almost ready. Just a few minor things to adjust.
* @Data...
Ovidiu Maxiniuc
04:20 PM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
Code Review Task Branch 7884a Revisions 14840 through 14842
The overall approach is reasonable. Ovidiu and Eric w...
Greg Shah
07:31 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
7884a r14842 ready for review. The dialect and conversion specifics now shared between @MetadataSecurityOps.NoSession... Galya B
05:23 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
Galya, yes, @SQL_MODE_DEFAULT@ is the default if otherwise not specified in p2j.cfg.xml, as a @conversion="minimal"@ ... Constantin Asofiei
03:40 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
Galya B wrote:
> Is the "conversion" always @SQL_MODE_DEFAULT@. I don't see a case where @NsConfig.setConversion@ is...
Galya B
03:33 PM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
In general I have no objections.
But I have the question and the clear answer is very important. How the custom th...
Eugenie Lyzenko
12:56 PM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
Eugenie/Hynek: Please review. Greg Shah
12:05 PM Deployment Support #8103: merge Hotel GUI, Hotel ChUI and implement a multi-modal template process
It would be easier to support a single Hotel project than to maintain two separate projects. We would need to merge ... Greg Shah
12:00 PM Deployment Support #8103 (New): merge Hotel GUI, Hotel ChUI and implement a multi-modal template process
Greg Shah
06:18 AM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
Eduard, please focus on reaching a "state-of-the-art" solution for 7045b (also referring to #7045-84). Also, triple c... Alexandru Lungu
02:00 AM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
Alexandru Lungu wrote:
> I've run 7045b with the performance tests and got 8.168s. Comparing to the baseline of 7.95...
Eduard Soltan
05:28 AM Database Bug #8101: Issue with temp-table defined as reference-only
An exception is thrown when @TestCodepageConversions.cls@ is executed regarding temp-tables.
Ovidiu Maxiniuc wrote...
Theodoros Theodorou
05:25 AM Database Bug #8101 (Closed): Issue with temp-table defined as reference-only
Theodoros Theodorou
05:08 AM Database Feature #7323: Implement soft unique index in FWD-H2
I've committed to 7323a rev. 14804-14805 some minor changes regarding:
* Fixed the validation condition in @Validati...
Radu Apetrii

12/05/2023

11:58 AM User Interface Bug #8098: The task bar without tasks is not displayed or drawn if ui program displays a lonely d...
The task bar is not displayed for this program... Sergey Ivanovskiy
09:29 AM User Interface Bug #8098 (New): The task bar without tasks is not displayed or drawn if ui program displays a lo...
Sergey Ivanovskiy
11:01 AM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
I am looking now in the changes of 7045b:
* Eduard, mind that you have some hard-tabs in your last commit (@Adaptive...
Alexandru Lungu
09:55 AM Database Bug #8044 (Test): Fix "Failed direct-access due to Error direct accessing for finding record by u...

Branch 8044a was merged into trunk as rev. 14860 and archived.
Alexandru Lungu
09:42 AM Database Bug #8044 (Merge Pending): Fix "Failed direct-access due to Error direct accessing for finding re...
You can merge now. Greg Shah
03:33 AM Database Bug #8044 (Internal Test): Fix "Failed direct-access due to Error direct accessing for finding re...
*Review of 8044a:*
* I am OK with the changes.
As long as you've done smoke tests with a large application and ...
Alexandru Lungu
08:58 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
Hynek Cihlar wrote:
> The logic gets more and more complex so it would be nice to be able to know how does it perfor...
Dănuț Filimon
05:33 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
Hynek Cihlar wrote:
> With the LinkedBlockingQueue on the limit, adding more tasks to the executor will cause Reject...
Dănuț Filimon
05:14 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
Dănuț Filimon wrote:
> Hynek Cihlar wrote:
> Initially the cache entry was a @Map@, but a potential leak was notice...
Hynek Cihlar
03:15 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
Hynek Cihlar wrote:
> In @createSourceCacheEntry@ the object submitted to the @mappingExecutor@ is a @Thread@, but i...
Dănuț Filimon
07:37 AM User Interface Bug #8074 (Review): Preferred UI Theme not selected in web with auto-login and forked sessions
8074a based on trunk r14859 ready for review. Includes (in order of appearance):
* Theme options include an empty op...
Galya B
04:38 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
A note: The path in @FallbackEnvironmentReader@ when using @Preferences@ is composed from root user node @~/.java/.us... Galya B
02:17 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
Greg Shah wrote:
> > But java @Preferences@ is case-sensitive, so we can either keep the original names (envs / keys...
Galya B
06:24 AM Database Feature #6496 (Review): add equivalent support for -trig command line option
I have commited an update to branch 6496a rev. 14747.
I saved a cache in @DatabaseTriggerManager@ to get the java cl...
Alexandru Donica
05:51 AM Base Language Bug #8008: read-json on a 1252 longchar should convert to utf-8 automatically before hydrating te...
In this Note, I summarize the parts from #7944 which were out of scope there.
The @convert_json_1252_fcp_memptr.p@ f...
Tijs Wickardt

12/04/2023

05:02 PM Database Feature #6414 (Test): ERROR attribute for buffer, dataset and temp-table
Committed revision 14859. The branch was archived. Ovidiu Maxiniuc
01:38 PM Database Feature #6414: ERROR attribute for buffer, dataset and temp-table
You can merge to trunk now. Greg Shah
12:17 PM Database Feature #6414 (Merge Pending): ERROR attribute for buffer, dataset and temp-table
Greg, I think this is ready for merge to trunk (Ovidiu, correct me if you think otherwise). Eric Faulhaber
12:15 PM Database Feature #6414: ERROR attribute for buffer, dataset and temp-table
The task branch was rebased to latest trunk. The current revision is 14861.
I also test with a large customer applic...
Ovidiu Maxiniuc
01:38 PM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
> But java @Preferences@ is case-sensitive, so we can either keep the original names (envs / keys / sections), or mak... Greg Shah
12:01 PM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
@EnvironmentDaemon@ is almost case-insensitive (check occurrences of @.toLowerCase()@). I guess it started with the r... Galya B
08:54 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
Eugenie Lyzenko wrote:
> Greg Shah wrote:
> > > Also there is a problem in registry where the @base_name@ is actual...
Galya B
08:43 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
Greg Shah wrote:
> > Also there is a problem in registry where the @base_name@ is actually not used in the native co...
Eugenie Lyzenko
08:26 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
Greg Shah wrote:
> Galya B wrote:
> > Actually there is another conversion issue with the example.
> >
> > It ha...
Galya B
08:20 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
> Also there is a problem in registry where the @base_name@ is actually not used in the native code. The char is load... Greg Shah
08:18 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
Galya B wrote:
> Actually there is another conversion issue with the example.
>
> It has @PUT-KEY-VALUE SECTION "...
Greg Shah
07:45 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
Also there is a problem in registry where the @base_name@ is actually not used in the native code. The char is loaded... Galya B
07:30 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
Actually there is another conversion issue with the example.
It has @PUT-KEY-VALUE SECTION "PSC\Clue\TEMP-PRGM" KE...
Galya B
06:27 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
I'm trying to convert an example procedure from "here":https://community.progress.com/s/article/21529.
Edited: Co...
Galya B
10:47 AM Database Feature #8067: investigate adding automatically adding a FIELDS clause for simple record blocks
This command assumes the .xml file is saved as @rules/reports/fields.xml@ and included in a p2j.jar build:... Constantin Asofiei
10:25 AM Database Feature #8067 (WIP): investigate adding automatically adding a FIELDS clause for simple record bl...
Constantin, can you provide some guidance on how to run your rule-set against a large customer application without ac... Alexandru Lungu
10:38 AM Base Language Feature #7045 (Internal Test): re-implement "normal" (non-abend) stack unwinding to avoid throwin...
I've run 7045b with the performance tests and got 8.168s. Comparing to the baseline of 7.958s, this is +2.5% slower. ... Alexandru Lungu
05:54 AM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
Committed on 7045b, revision 14835.
I tested @uast/query_off_end/qoe_exception@ , did not see any regressions. In ...
Eduard Soltan
03:47 AM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
Eduard, please address the review and commit a final solution to 7045b (including javadoc / history entries / etc.) a... Alexandru Lungu
03:07 AM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
Eric Faulhaber wrote:
> I have noted the discussion above that @QOEE@ is not yet fully eliminated. I see this, for i...
Eduard Soltan
09:13 AM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
Branch 4722b was rebased to trunk_14857 and is at revision 14861. Roger Borrello
04:14 AM Database Feature #6720: lazy hydration
Ovidiu Maxiniuc wrote:
> I grabbed 6720c and looked at the latest changes. Indeed, I do not see a reason for a chang...
Alexandru Lungu
03:25 AM Base Language Bug #7460: implement Progress.Lang.Class:getMethods
6410b rev 14828 was rebased from trunk rev 14856 - new rev 14860 Constantin Asofiei
03:19 AM Base Language Bug #7460: implement Progress.Lang.Class:getMethods
Constantin Asofiei wrote:
> Yes, I'll need to rebase. Are all changes in 6410b?
I have some local changes but no...
Marian Edu
03:00 AM Base Language Bug #7460: implement Progress.Lang.Class:getMethods
Yes, I'll need to rebase. Are all changes in 6410b? Constantin Asofiei
02:50 AM Base Language Bug #7460: implement Progress.Lang.Class:getMethods
Constantin Asofiei wrote:
> Created task branch 7460a from trunk rev 14850.
>
> 7460a rev 14851 has a regression ...
Marian Edu
03:24 AM Base Language Feature #6410: implement additional built-in OO classes/interfaces
6410b rev 14828 was rebased from trunk rev 14856 - new rev 14860 Constantin Asofiei
02:52 AM User Interface Feature #4203 (Test): expose some web-client details as 4GL global variables
4203a was merged to trunk as rev. 14856 and archived. Galya B

12/03/2023

09:39 AM User Interface Bug #8095: LEAVE trigger fires in no focus change situation
In the following code, a @FILL-IN@ is created in its own frame, and three @ON LEAVE@ triggers are attached to the @FI... Vladimir Tsichevski
08:07 AM User Interface Bug #8095 (New): LEAVE trigger fires in no focus change situation
Vladimir Tsichevski

12/02/2023

03:36 PM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
Code review 6649b revisions 14840..14847.
In @createSourceCacheEntry@ the object submitted to the @mappingExecutor...
Hynek Cihlar

12/01/2023

10:08 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
> > > Indeed, the use of @setuserid@ is very common.
> > As far as I understand @setuserid@ is a common DB authent...
Greg Shah
04:07 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
Is the "conversion" always @SQL_MODE_DEFAULT@. I don't see a case where @NsConfig.setConversion@ is used. Galya B
10:00 AM User Interface Feature #4203 (Merge Pending): expose some web-client details as 4GL global variables
Greg Shah
02:08 AM User Interface Feature #4203: expose some web-client details as 4GL global variables
I've tested with testcases all types of drivers. The procedure I used is a simple @message FWD-CLIENT-DRIVER@. I also... Galya B
09:13 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
My bad. The enhanced configs for all users are stored in directory, so this is not in conflict with isolating the use... Galya B
06:00 AM Base Language Bug #8084 (WIP): refactor the 'execute' method for legacy classes
Created task branch 8084a from trunk rev 14853 Constantin Asofiei

11/30/2023

01:53 PM Base Language Bug #7460: implement Progress.Lang.Class:getMethods
Branch 7460a was merged into trunk as rev. 14851 and archived. Constantin Asofiei
01:38 PM Base Language Bug #7460 (Merge Pending): implement Progress.Lang.Class:getMethods
Code Review Task Branch 7460a Revisions 14850 and 14851
No objections.
Greg Shah
12:52 PM Base Language Bug #7460: implement Progress.Lang.Class:getMethods
Created task branch 7460a from trunk rev 14850.
7460a rev 14851 has a regression fix: Do not use 'TypeFactory.obje...
Constantin Asofiei
01:53 PM Runtime Infrastructure Bug #7589: org.slf4j.impl.StaticLoggerBinder when deploying p2j.jar in tomcat
Code Review fix-spawner-classpath.diff
I'm fine with the changes.
How have they been tested?
Greg Shah
12:56 PM User Interface Feature #4203 (Internal Test): expose some web-client details as 4GL global variables
Code Review Task Branch 4203a Revision 14851
The changes are good.
Greg Shah
09:09 AM User Interface Feature #4203 (Review): expose some web-client details as 4GL global variables
4203a r14851 based on trunk r14850 ready for review. Implements @FWD-CLIENT-DRIVER@, adds short readable names to dri... Galya B
08:28 AM User Interface Feature #4203: expose some web-client details as 4GL global variables
Greg Shah wrote:
> The value should be added to @ClientParameters@ at startup so that it is always available at the ...
Galya B
08:23 AM User Interface Feature #4203 (WIP): expose some web-client details as 4GL global variables
Galya B
08:18 AM User Interface Feature #4203: expose some web-client details as 4GL global variables
The value should be added to @ClientParameters@ at startup so that it is always available at the server (without the ... Greg Shah
08:32 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
Greg Shah wrote:
> > There are only two solutions: either we "degrade" the functionality by removing both options, o...
Galya B
08:18 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
> > Anything that targets more than the current user must (by definition) be stored in the directory, not in user-spe... Greg Shah
01:40 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
Greg Shah wrote:
> What changes are needed in @SsoAuthenticator@ to provide the @storageId@?
It is present in the i...
Galya B
10:21 PM Database Feature #6720: lazy hydration
I grabbed 6720c and looked at the latest changes. Indeed, I do not see a reason for a change in performance. The hydr... Ovidiu Maxiniuc

11/29/2023

03:32 PM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
The value should be added to @ClientParameters@ at startup so that it is always available at the server (without the ... Greg Shah
03:05 PM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
> I'm working on isolating the users in the client storage, but I forgot that the enhanced browse configs can be appl... Greg Shah
03:04 PM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
> Since we probably don't have enough control over the customer behavior, then the solution I propose is to always in... Greg Shah
03:12 PM User Interface Feature #4203: expose some web-client details as 4GL global variables
> May I ask if the IPs will be used for licensing in 4GL? Because I would hope, since the IPs (the external one and t... Greg Shah
11:56 AM Database Bug #7113: Problem with nested CAN-FIND conversion
Eric Faulhaber wrote:
> Ovidiu, 7259a was merged to trunk some time ago. Did it fix this issue?
7259a contained cha...
Ovidiu Maxiniuc
11:10 AM Database Bug #7113: Problem with nested CAN-FIND conversion
Ovidiu, 7259a was merged to trunk some time ago. Did it fix this issue? If not, are the changes in 7113a needed? Eric Faulhaber
10:59 AM Database Bug #6812 (Internal Test): fix FastFindCache to use a shared instance per persistent database
Constantin, does it make sense to regression test this with the large POC? Eric Faulhaber
08:59 AM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
I am addressing some regression on running POC. But I think, I am close to find the problem causing this regression. ... Eduard Soltan
08:35 AM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
Eduard, please make an update on your status of running the POC with your changes and addressing Eric's #7045-77. Alexandru Lungu
07:45 AM Database Feature #6720: lazy hydration
Ovidiu, I finished the implementation completely and tested it over a large POC. However, I created a separate branch... Alexandru Lungu
05:37 AM Database Bug #7138: Short circuit fake-update (update with a new value eqaul to the old value) in H2
After running a large POC with *7156b/rev.14846* (which uses *FWD-H2/rev.33*) and the changes from *7138a_h2/rev.24 -... Dănuț Filimon
03:57 AM Runtime Infrastructure Bug #7589: org.slf4j.impl.StaticLoggerBinder when deploying p2j.jar in tomcat
The JVM spawned from @/opt/spawner/spawn@ now doesn't have our slf4j implementation and doesn't produce logs for @Cen... Galya B
03:31 AM Database Bug #8030 (Test): unique index violation when creating a record in two sessions
Alexandru Lungu
12:36 AM Database Bug #8030: unique index violation when creating a record in two sessions
Code review 8030a/14829-14830:
The logic changes look fine to me. For clarity, I did change the name of the method...
Eric Faulhaber
02:02 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
Ovidiu Maxiniuc wrote:
> Just a small observation: at line 406 in @MetadataSecurityOps@, @SecurityOps._encode(String...
Galya B

11/28/2023

04:29 PM Database Feature #6496: add equivalent support for -trig command line option
The (schema-)triggers are context specific because the @propath@ is context specific (@EnvironmentOps.getSearchPath()... Ovidiu Maxiniuc
08:54 AM Database Feature #6496: add equivalent support for -trig command line option
Are the trigger defs already context-specific? If so, let's avoid the map lookup. Greg Shah
03:03 PM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
Review of 7884a, r14840.
The new code in @MetadataSecurityOps.java@ is well written. Just a small observation: at ...
Ovidiu Maxiniuc
12:15 PM Database Bug #8030: unique index violation when creating a record in two sessions
Eric Faulhaber wrote:
> Yes, please do.
Sorry, I misread your note. I'll review...
Eric Faulhaber
11:31 AM Database Bug #8030: unique index violation when creating a record in two sessions
Yes, please do. Eric Faulhaber
11:21 AM Database Bug #8030: unique index violation when creating a record in two sessions
AFAIK, everything is done on 8030a (including MariaDB - I discussed with Danut and the issue in #8030-1 is no longer ... Alexandru Lungu
11:16 AM Database Bug #8030: unique index violation when creating a record in two sessions
Dănuț Filimon wrote:
> *Committed 8030a/rev.14830*. Modified @RecordBuffer.reportValidationException@.
>
> Alexan...
Eric Faulhaber
03:11 AM Database Bug #8030 (Review): unique index violation when creating a record in two sessions
*Committed 8030a/rev.14830*. Modified @RecordBuffer.reportValidationException@.
Alexandru, the example provided di...
Dănuț Filimon
10:19 AM Database Bug #7138: Short circuit fake-update (update with a new value eqaul to the old value) in H2
Yes, please go ahead. Alexandru Lungu
08:35 AM Database Bug #7138 (Review): Short circuit fake-update (update with a new value eqaul to the old value) in H2
Branch 7454a was previously merged into trunk as rev. 14833. Alexandru, should I run the POC tests for this task befo... Dănuț Filimon
09:43 AM Database Bug #7731: performance improvements for FQLPreprocessor
[[p2j:Database Configuration#Cache-Sizes]] was updated with the necessary information for configuring the cache size ... Dănuț Filimon
09:37 AM Database Bug #7731 (Test): performance improvements for FQLPreprocessor
Branch 7731a was merged into trunk as rev. 14844 and archived. Alexandru Lungu
09:14 AM Database Bug #7731: performance improvements for FQLPreprocessor
You can merge now. Greg Shah
09:20 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
I ran a large POC with *7156b/rev.14846* and the changes from *6649b/rev.14835 - 14847* and obtained good results (th... Dănuț Filimon
05:50 AM Base Language Feature #6649 (Review): improve the performance or SourceNameMapper runtime
*Committed 6649b/rev.14847* which solves the problem mentioned in #6649-144. By not keeping the thread idle, the corr... Dănuț Filimon
08:09 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
I'm working on isolating the users in the client storage, but I forgot that the enhanced browse configs can be applie... Galya B
08:02 AM Database Feature #7323: Implement soft unique index in FWD-H2
Alexandru Lungu wrote:
> Radu, can you check if we are still hitting @validateUniqueByQuery@ for _temp? If so, how m...
Radu Apetrii
06:46 AM Database Feature #7323: Implement soft unique index in FWD-H2
Radu, can you check if we are still hitting @validateUniqueByQuery@ for _temp? If so, how many times do we actually b... Alexandru Lungu
06:38 AM Database Feature #7323: Implement soft unique index in FWD-H2
I finished running the performance tests and the results are not very encouraging:
* 7323a rev. 14801 (*before* the ...
Radu Apetrii
03:49 AM Base Language Bug #8084: refactor the 'execute' method for legacy classes
Oh right, this makes sense - getting rid of the @BlockManager@ API. This way we avoid doing @ProcedureManager@ work. Alexandru Lungu
03:31 AM Base Language Bug #8084: refactor the 'execute' method for legacy classes
What I meant is to emit all the code (like buffer scopes) directly in the Java method, and do not enclose it in @Bloc... Constantin Asofiei
03:29 AM Base Language Bug #8084: refactor the 'execute' method for legacy classes
Contantin, just a question here: I thought we open scopes in @externalProcedure@ due to the fact that we are aware *o... Alexandru Lungu

11/27/2023

04:50 PM Database Feature #6496: add equivalent support for -trig command line option
Most likely, not. A context-level map should do it. The only think that is missing is the invalidate event, when the ... Ovidiu Maxiniuc
08:08 AM Database Feature #6496: add equivalent support for -trig command line option
Ovidiu: Is it difficult for us to cache the results at the trigger definition? If not, I'd prefer that over the idea... Greg Shah
04:39 PM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
My last commit does not change business code in @ImportWorker@, just the logs are more verbose.
I had a look at th...
Ovidiu Maxiniuc
11:12 AM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
Roger Borrello wrote:
> This does not happen with trunk, so something in this branch is causing H2 word tables to be...
Roger Borrello
10:59 AM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
Roger Borrello wrote:
> Ovidiu, when I run @ant import.db@ using the H2 database, it is trying to import into the *r...
Roger Borrello
10:42 AM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
Ovidiu, when I run @ant import.db@ using the H2 database, it is trying to import into the *reservation__guest* table.... Roger Borrello
02:28 PM Base Language Bug #8084: refactor the 'execute' method for legacy classes
Currently, each legacy class has a synthetic 'execute' instance method which includes initialization like instance-le... Constantin Asofiei
02:23 PM Base Language Bug #8084 (Test): refactor the 'execute' method for legacy classes
Constantin Asofiei
11:52 AM Database Bug #7731 (Merge Pending): performance improvements for FQLPreprocessor
This can merge to trunk after 7669a. Greg Shah
07:35 AM Database Bug #7731: performance improvements for FQLPreprocessor
I think the changes are OK. I've tested with a large POC performance run, and there was a visible improvement. Constantin Asofiei
10:15 AM Database Bug #8030: unique index violation when creating a record in two sessions
Danut, please move this into Review once you finish the implementation so we can move on with the review part. There ... Alexandru Lungu
09:23 AM Database Bug #8030: unique index violation when creating a record in two sessions
I can't recall exactly. We have some changes in #7323 that was doing the cause unwrapping for FWD-H2 *exactly* becaus... Alexandru Lungu
09:20 AM Database Bug #8030: unique index violation when creating a record in two sessions
Alexandru, in what case is required to unwrap the cause for P2JH2Dialect? I'll need a bit more context to adjust the ... Dănuț Filimon
09:04 AM Database Bug #8030: unique index violation when creating a record in two sessions
I committed the fix for #8030-3 in *8030a/rev.14829*, currently investigating @RecordBuffer.reportValidationException@. Dănuț Filimon
05:56 AM Database Bug #8030: unique index violation when creating a record in two sessions
I managed to reproduce the issue after fixing a configuration issue in @build_db.xml@. Working on it right now. Dănuț Filimon
04:43 AM Database Bug #8030: unique index violation when creating a record in two sessions
Danut, can you re-attempt to recreate this and fix? Please do some debugging to see where you are failing into recrea... Alexandru Lungu
10:14 AM Database Feature #7323: Implement soft unique index in FWD-H2
Theoretically yes. Practically, the flag will only take affect if there are violations. We need to check on our large... Alexandru Lungu
10:04 AM Database Feature #7323: Implement soft unique index in FWD-H2
I've addressed the review points and committed to 7323a rev. 14802-14803. Right now I'm running the performance tests... Radu Apetrii
08:24 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
Ovidiu: Please review. Consider if there is any common code that can be shared with the existing session-based @setu... Greg Shah
04:59 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
If we want to support multiple users in one browser, then the theme drop-down on the login page should never have a p... Galya B

11/26/2023

08:31 AM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
Branch 4722b was rebased to trunk_14841 and is at revision 14845. Roger Borrello

11/24/2023

06:11 AM Base Language Feature #6649 (WIP): improve the performance or SourceNameMapper runtime
Dănuț Filimon
06:05 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
After investigating, I found out that the @mappingExecutor@ creates an @AssociatedThread@ with the current context, m... Dănuț Filimon
02:11 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
There is an issue with how the cache entries are built. The @AssociatedThread@ doesn't use the correct context when b... Dănuț Filimon
05:57 AM User Interface Bug #8074 (WIP): Preferred UI Theme not selected in web with auto-login and forked sessions
Since we probably don't have enough control over the customer behavior, then the solution I propose is to always inco... Galya B
05:49 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
Basically the authentication code presented in #3931-435 is moved from @HotelGuiSsoAuthenticator@ to @MetadataSecurit... Galya B
05:37 AM User Interface Feature #7884 (Review): Standard 4GL methods used for login screen authentication to be exposed i...
Galya B
05:37 AM User Interface Feature #7884 (WIP): Standard 4GL methods used for login screen authentication to be exposed in s...
7884a r14840: MetadataSecurityOps.NoSessionHelper class added to support sso login screen authentication. Galya B
04:11 AM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
Code review 7045b/14825-14834:
There are file header entries problems (i.e., duplicate entries in some files, miss...
Eric Faulhaber
12:42 AM Database Feature #6496: add equivalent support for -trig command line option
#6649 already has a cache implementation which not only stores the results from @convertNametoClass()@, but also @con... Dănuț Filimon
09:03 PM Database Feature #6496: add equivalent support for -trig command line option
Greg Shah wrote:
> If we implement the solution in #6649, we still have to do a minimal cache lookup for each trigge...
Ovidiu Maxiniuc
07:37 PM Database Feature #6720: lazy hydration
That is an interesting approach. I did not realized that level of specialization would be necessary. This class was a... Ovidiu Maxiniuc

11/23/2023

10:55 AM User Interface Feature #4203: expose some web-client details as 4GL global variables
May I ask if the IPs will be used for licensing in 4GL? Because I would hope, since the IPs (the external one and the... Galya B
10:35 AM User Interface Feature #4856 (Test): web client session forking
7813a was merged to trunk as rev. 14839 and archived. Galya B
10:19 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
So I'm seeing the options as:
1. All users happily share the same configs and override each other;
2. The customer ...
Galya B
09:59 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
The core issue is that in the original OE 'end user' == 'OS user' and client storage (registry, ini) rarely clashes b... Galya B
09:47 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
This @storageId@ should ensure the same client process reused by many users can store end user specific info in indep... Galya B
09:38 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
The solution should not be specific to SSO. Why not just use the FWD account name or some UUID associated with the F... Greg Shah
09:36 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
Greg Shah wrote:
> Where is the @storageId@ coming from?
Hopefully from well written @SsoAuthenticator@ implementat...
Galya B
09:32 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
I agree that we don't have to worry about the existing production cfg values. Right now is the best time to make any ... Greg Shah
09:27 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
Maybe now it's the right time to do it, since we've just launched the methods accessing client storage, up till now t... Galya B
09:22 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
I ponder on more trivial matters like: Should I break all current prod client storage configs and add the @storageId@... Galya B
09:17 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
Some customer applications do use their own subclasses of our themes. When doing so, these themes are registered in ... Greg Shah
09:09 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
Greg Shah wrote:
> > you were mentioning before there are supposed to be changes related to themes.
>
> Can you ...
Galya B
09:06 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
> you were mentioning before there are supposed to be changes related to themes.
Can you remind me of where/when ...
Greg Shah
06:50 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
The flows of auto-login and forking a new session in web bypass the login screen, thus a preferred UI theme can't be ... Galya B
06:48 AM User Interface Bug #8074 (Closed): Preferred UI Theme not selected in web with auto-login and forked sessions
Galya B
10:02 AM Database Feature #6720: lazy hydration
*Status update:*
Ovidiu, I followed your suggestion on having a @BitSet@ to store the selected fields. However, I ...
Alexandru Lungu
09:11 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
It is a good point. I think what we are looking for here is to expose the authentication check itself, without the p... Greg Shah
08:38 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
There is something tricky with exposing @setuserid@ before the session has started. It can be used to validate the lo... Galya B
09:09 AM Database Bug #7167: Associating records from opened buffers to new sessions is slow
Alexandru Lungu wrote:
> Danut, please re-test the large POC and see if why we are still having spikes on @BufferMan...
Dănuț Filimon
08:54 AM Database Feature #6496: add equivalent support for -trig command line option
My point here is that by doing something in the database trigger manager itself, we can get an even better level of o... Greg Shah
08:52 AM Database Feature #6496: add equivalent support for -trig command line option
> However, it searches the root directory even after I seem to have removed it from propath (I even printed the propa... Greg Shah
07:54 AM Database Feature #6496: add equivalent support for -trig command line option
Small observation.
I had tried in progress developer studio to remove all from propath (right click on project, proj...
Alexandru Donica
04:57 AM Database Feature #6496 (WIP): add equivalent support for -trig command line option
Alexandru Donica wrote:
> So in 4GL it definitely tries to append the trig location to every propath folder, because...
Alexandru Lungu
04:49 AM Database Feature #6496: add equivalent support for -trig command line option
So in 4GL it definitely tries to append the trig location to every propath folder, because when I reordered the propa... Alexandru Donica
03:05 AM Database Feature #6496: add equivalent support for -trig command line option
Greg, what you are saying is a side-effect of #6649. Every @convertName@ (or @fastConvertName@) is added to one of th... Alexandru Lungu
06:03 AM Database Feature #8067: investigate adding automatically adding a FIELDS clause for simple record blocks
I have not went further with this. The report I used is this:... Constantin Asofiei
05:20 AM Database Feature #8067: investigate adding automatically adding a FIELDS clause for simple record blocks
Constantin, what kind of queries did you consider. FOR EACH loops with BREAK BY shouldn't be counted (or maybe can be... Alexandru Lungu
04:37 AM Database Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
I've committed to 7416b rev. 14773 the changes suggested in #7416-41 with two exceptions: the two points related to @... Radu Apetrii

11/22/2023

03:02 PM Base Language Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection
> > What specific use cases would be using the modified code?
> RecordBuffer, TemporarBuffer, DataSet, ControlFlowOp...
Greg Shah
08:56 AM Base Language Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection
Greg Shah wrote:
> Please post the test harness code or whatever it is that you are using to create the failing case...
Constantin Asofiei
08:22 AM Base Language Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection
Please post the test harness code or whatever it is that you are using to create the failing case ("where I created 1... Greg Shah
01:59 PM User Interface Feature #4856 (Internal Test): web client session forking
Greg Shah
08:10 AM User Interface Feature #4856 (Review): web client session forking
In 7813a r14861 virtual desktop taskbar menu item 'New Session' is wired up to @SessionUtils.forkNewSesion@. Galya B
11:06 AM Database Feature #6496: add equivalent support for -trig command line option
We should consider an approach similar to #1970, where we changed @ControlFlowOps@ and the converted code to cache th... Greg Shah
10:59 AM Database Feature #6496: add equivalent support for -trig command line option
> However I see now that in 4GL, it searches for the trigger location in every folder in propath, and uses the first ... Greg Shah
10:18 AM Database Feature #6496: add equivalent support for -trig command line option
Alexandru Donica wrote:
> I did some more tests in 4GL with the propath now that I may not have done a while ago, or...
Alexandru Lungu
10:00 AM Database Feature #6496: add equivalent support for -trig command line option
I did some more tests in 4GL with the propath now that I may not have done a while ago, or I did not complete them pr... Alexandru Donica
09:55 AM Database Feature #6496: add equivalent support for -trig command line option
* Another question: the prefixes (@String[] prefixes = new String[] {"./", ".\\", "../", "..\\"};@) should be checked... Alexandru Lungu
07:42 AM Database Feature #6496: add equivalent support for -trig command line option
Alexandru [ad], just a notice. Is is possible to state a @-trig@ relative to the propath? Thus, if you have a trigger... Alexandru Lungu
04:08 AM Database Feature #6496: add equivalent support for -trig command line option
I am giving it a shot with some performance tests now - if everything is OK, I will merge it. Alexandru Lungu
09:42 AM User Interface Feature #4853: implement support for reporting a device-id which is meant to identify a unique cl...
Greg Shah wrote:
> I'm not opposed to exposing some useful state out to the 4GL code (like the web client IP address...
Galya B
09:39 AM User Interface Feature #4853: implement support for reporting a device-id which is meant to identify a unique cl...
Don't work on this right now. I am discussing the requirement with the customer and they may be dropping it on their... Greg Shah
09:32 AM User Interface Feature #4853: implement support for reporting a device-id which is meant to identify a unique cl...
Also I'm always thinking of a flow where the IP and fingerprint don't matter, but it works only when 'one browser' po... Galya B
09:27 AM User Interface Feature #4853: implement support for reporting a device-id which is meant to identify a unique cl...
Can I implement a simple fingerprint myself? It will take a while to figure out how to test the canvas and the audio,... Galya B
05:54 AM User Interface Feature #3931: single sign-on for virtual desktop mode
I think we should reference the feature as simple sign-on (SSO). This way we'll be keeping all the SSO references, bu... Galya B
05:25 AM User Interface Bug #8012: Fix combo-box corner cases
After putting some thought into this, I came up with a format that, IMO, would make the changes relatively easy to re... Radu Apetrii
05:13 AM Database Feature #7323: Implement soft unique index in FWD-H2
Also, please attempt to retest the POC for performance after the changes. Make a baseline with 7156b / an intermediar... Alexandru Lungu
05:09 AM Database Bug #7167: Associating records from opened buffers to new sessions is slow
Also, please remake the statistic on #7167-1 now with 1s of lifespan vs 10s of lifespan. Alexandru Lungu
05:08 AM Database Bug #7167: Associating records from opened buffers to new sessions is slow
Danut, please re-test the large POC and see if why we are still having spikes on @BufferManager.activeBuffers@. Pleas... Alexandru Lungu
04:11 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
I tested with a rebased 6649b from 7156b (7156b at rev. 14846, branched from trunk rev. 14822 + all 8 commits from 66... Alexandru Lungu

11/21/2023

05:33 PM Database Feature #6496: add equivalent support for -trig command line option
Greg Shah wrote:
> Is there more testing needed for this branch?
I haven't tested this branch. Please let me know i...
Theodoros Theodorou
05:23 PM Database Feature #6496: add equivalent support for -trig command line option
Is there more testing needed for this branch?
Theodoros: Is anything in 6496a dependent on the changes in 7732a?
Greg Shah
05:20 PM Database Feature #6496: add equivalent support for -trig command line option
Greg Shah wrote:
> Theodoros: Please review.
The changes look good.
> All: We are trying to merge 7732a before...
Theodoros Theodorou
08:09 AM Database Feature #6496: add equivalent support for -trig command line option
Theodoros: Please review.
All: We are trying to merge 7732a before 6496a since it has changes related to the start...
Greg Shah
03:59 AM Database Feature #6496 (Review): add equivalent support for -trig command line option
I moved the trigger location parameter to @StartupParameters@ as adviced. I also removed the map that cached the trig... Alexandru Donica
04:26 PM User Interface Bug #7515: FILL-IN: editing dates issues
Vladimir Tsichevski wrote:
> # The @gso_171@ test: the @Dist date@ is @01/01/-099@ instead of expected @01/01/-999...
Vladimir Tsichevski
02:43 PM Base Language Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection
Currently there are three experimental branches:
* 6819c - uses singleton, byte-code generated, BiFunction inner cla...
Constantin Asofiei
01:56 PM Base Language Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection
Please post details of the results from your testing described in #6819-61 (6 months ago).
I understand you've bee...
Greg Shah
02:40 PM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
Eric: Please don't forget to do a code review ASAP. Greg Shah
07:52 AM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
Eduard, I didn't had the chance to convert yet the POC. Can you attempt it? I have already queued some other performa... Alexandru Lungu
02:22 PM Database Feature #8067: investigate adding automatically adding a FIELDS clause for simple record blocks
A crude report on the .ast of a large POC app results in ~13% (18k from 141k) of the FOR EACH blocks which can be imp... Constantin Asofiei
02:07 PM Database Feature #8067: investigate adding automatically adding a FIELDS clause for simple record blocks
Good point. Greg Shah
01:16 PM Database Feature #8067: investigate adding automatically adding a FIELDS clause for simple record blocks
Greg Shah wrote:
> That is why I was suggesting bypassing that case.
I agree, but this would exclude all temp-table...
Constantin Asofiei
01:09 PM Database Feature #8067: investigate adding automatically adding a FIELDS clause for simple record blocks
That is why I was suggesting bypassing that case. Greg Shah
12:56 PM Database Feature #8067: investigate adding automatically adding a FIELDS clause for simple record blocks
Greg Shah wrote:
> One important contraint to include is that the buffer must be scoped to the @FOR@ loop. If the s...
Constantin Asofiei
12:26 PM Database Feature #8067: investigate adding automatically adding a FIELDS clause for simple record blocks
Let's move ahead with this. Note that we should do this analysis *after* record scoping is finished in annotations. ... Greg Shah
09:51 AM Database Feature #8067: investigate adding automatically adding a FIELDS clause for simple record blocks
Greg Shah wrote:
> We can certainly use TRPL to analyze field usage and generate an implicit @FIELDS@ clause if cert...
Constantin Asofiei
09:47 AM Database Feature #8067: investigate adding automatically adding a FIELDS clause for simple record blocks
We can certainly use TRPL to analyze field usage and generate an implicit @FIELDS@ clause if certain constraints are ... Greg Shah
09:31 AM Database Feature #8067: investigate adding automatically adding a FIELDS clause for simple record blocks
In a customer application, we noticed patterns like @for each tt1: do something with a few fields. end.@ where althou... Constantin Asofiei
09:28 AM Database Feature #8067 (WIP): investigate adding automatically adding a FIELDS clause for simple record bl...
Constantin Asofiei
12:31 PM User Interface Feature #4856: web client session forking
> Can I directly execute 4GL method from the front-end
Not from the virtual desktop. Embedded mode does have tool...
Greg Shah
09:07 AM User Interface Feature #4856: web client session forking
Can I directly execute 4GL method from the front-end or I need to create a new WebSocket msg and handle it all the wa... Galya B
11:24 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
Alex, when you test the large app, do you use 7156b with the changes from 6649b on top? Will the latest 7156b work OK? Hynek Cihlar
09:35 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
*6649b* was rebased to *trunk/rev.14834* and the current revision is *14845*.
*Committed 6649b/rev.14846*:
* Used...
Dănuț Filimon
07:29 AM Base Language Bug #7656: investigate performance of context-local helpers (e.g. TransactionManager.TransactionH...
Alexandru, in @devsrv01:/tmp/AccessModifier.7z@ there is the project I use to automatically 'fix' the access modifie... Constantin Asofiei
06:19 AM User Interface Bug #8012: Fix combo-box corner cases
I added to @testcases/uast/combo_box/screen_value@ some more tests regarding @ADD-LAST@, @ADD-FIRST@, @LIST-ITEM-PAIR... Radu Apetrii
09:17 PM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
Ovidiu... I must have really missed something for H2 regarding the use of DDL in the application jar file. I hadn't s... Roger Borrello
07:05 PM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
Ovidiu, I am using this branch, and getting an error finding the ddl, when it is in the @hotel.jar@ file. When I unzi... Roger Borrello

11/20/2023

05:10 PM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
I fixed the minor typo and checked in revision 14837. Roger Borrello
04:11 PM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
Ovidiu Maxiniuc wrote:
> I committed my 4722b changes as r14836.
> Nothing fancy, just more verbose logs and allowe...
Roger Borrello
03:35 PM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
I committed my 4722b changes as r14836.
Nothing fancy, just more verbose logs and allowed loading of FS resources if...
Ovidiu Maxiniuc
08:48 AM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
Ovidiu: Do you still have changes to put into 4722b? Greg Shah
08:45 AM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
Branch 4722b was rebased to trunk_14834 and is at revision 14835. Roger Borrello
10:08 AM Database Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
Okay then, please continue working on the review. Andrei, disregard my comment. Alexandru Lungu
09:49 AM Database Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
Alexandru Lungu wrote:
> As the review is quite detailed, Andrei [ai], can you manage clearing as many as the minor ...
Radu Apetrii
09:46 AM Database Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
As the review is quite detailed, Andrei [ai], can you manage clearing as many as the minor points above? If there are... Alexandru Lungu
07:21 AM Runtime Infrastructure Bug #8060: Admin Console login fails every first time (AdminServerImpl.setTargetLive)
Can you move it or I need to create a new one? Galya B
07:20 AM Runtime Infrastructure Bug #8060: Admin Console login fails every first time (AdminServerImpl.setTargetLive)
Greg Shah wrote:
> Does this need to be in the customer project? It seems like a generic issue.
My bad. It's gen...
Galya B
07:19 AM Runtime Infrastructure Bug #8060: Admin Console login fails every first time (AdminServerImpl.setTargetLive)
Does this need to be in the customer project? It seems like a generic issue. Greg Shah
05:16 AM Runtime Infrastructure Bug #8060: Admin Console login fails every first time (AdminServerImpl.setTargetLive)
On fresh server start the first attempt to login in the Admin Console with correct credentials always fails:
!admi...
Galya B
05:13 AM Runtime Infrastructure Bug #8060 (Test): Admin Console login fails every first time (AdminServerImpl.setTargetLive)
Galya B
06:03 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
On a large POC, the total improvement of the changes in 6649b was of -0.3%. Alexandru Lungu
04:00 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
Hynek Cihlar wrote:
> Do you mean 70 individual propath entries or 70 paths in a single propath?
One single long ...
Alexandru Lungu
02:34 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
Alexandru Lungu wrote:
> I've done some tests, and there were no obvious problems. I am moving this to the profiler ...
Hynek Cihlar

11/18/2023

02:23 PM User Interface Bug #7515: FILL-IN: editing dates issues
Running MAJIC tests revealed at teast two regressions in ChUI in @7019a@:
# incorrect behavior of date @FILL-IN@ f...
Vladimir Tsichevski
07:33 PM Base Language Feature #6431: implement support to allow CPINTERNAL set to UTF-8 and CP936
Marian Edu wrote:
> Hi Theodoros, just pushed the i18n tests on testcases (rev#1514), we're still working one some c...
Theodoros Theodorou

11/17/2023

06:31 PM Database Bug #7999: FWD does not honor FIELDS/EXCEPT at dynamic queries
Review of 7999a, r14833.
Good job. The goal of the task was reached. But I have some things to note, mainly becaus...
Ovidiu Maxiniuc
12:49 PM Database Bug #7999: FWD does not honor FIELDS/EXCEPT at dynamic queries
Ovidiu: Please review. Greg Shah
12:43 PM Database Bug #7999 (Review): FWD does not honor FIELDS/EXCEPT at dynamic queries
Alexandru Lungu
10:05 AM Database Bug #7999: FWD does not honor FIELDS/EXCEPT at dynamic queries
Committed on 7999a, revision 14833.
- @DynamicQueryHelper@, added methods to traverse @fields@ and @except@ phrases...
Eduard Soltan
09:09 AM Database Bug #7454 (Test): Make ValueStringIgnoreCase the default generated value for setString in FWD-H2
Branch 7454a was merged into trunk as rev. 14833 and archived. Alexandru Lungu
08:17 AM Database Bug #7454: Make ValueStringIgnoreCase the default generated value for setString in FWD-H2
You can merge now. Greg Shah
07:51 AM Database Bug #7454: Make ValueStringIgnoreCase the default generated value for setString in FWD-H2
Regression tests passed successfully. *7454a can be merged - Greg, waiting for your call* Alexandru Lungu
08:47 AM Base Language Feature #6431: implement support to allow CPINTERNAL set to UTF-8 and CP936
Theodoros Theodorou wrote:
> Hello Marian. Greg asked me to coordinate with you that we do not do the same effort tw...
Marian Edu
07:41 AM Base Language Feature #6431: implement support to allow CPINTERNAL set to UTF-8 and CP936
Hello Marian. Greg asked me to coordinate with you that we do not do the same effort twice. Please have a look at @te... Theodoros Theodorou
07:11 AM Base Language Feature #6431: implement support to allow CPINTERNAL set to UTF-8 and CP936
Yes, it needs to be fixed. Such conversions should yield identical results. It seems likely that the cause is relat... Greg Shah
08:23 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
Alexandru Lungu wrote:
> Mind that the search-path cache is not synchronized. Please add @synchronize@ to that acces...
Dănuț Filimon
08:13 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
*Review of 6649b/rev.14808*
Mind that the search-path cache is not synchronized. Please add @synchronize@ to that ...
Alexandru Lungu
08:03 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
Alexandru Lungu wrote:
> Some extra ideas:
>
> * Also, what about @convertedNames@? Can't it possible leak as we ...
Dănuț Filimon
07:33 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
Alexandru Lungu wrote:
> Danut please fix #6649-131 - I am planning to start performance testing with 6649a as soon ...
Dănuț Filimon
07:08 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
Some extra ideas:
* Also, what about @convertedNames@? Can't it possible leak as we are constantly adding to it th...
Alexandru Lungu
06:26 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
I've done some tests, and there were no obvious problems. I am moving this to the profiler asap.
However, I want t...
Alexandru Lungu
04:04 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
I converted a large application and generated a @name_map.xml@ with ~39k (~7k of OO classes) class-mappings and only ... Alexandru Lungu
07:50 AM Database Feature #6496: add equivalent support for -trig command line option
I have been working on this little by little between other high priority tasks. I intent to put more focus on this ta... Alexandru Donica
07:48 AM Database Feature #6496: add equivalent support for -trig command line option
Any progress here? Mind that we need a major performance drop for the upcoming week, and the addition of @-trig@ may ... Alexandru Lungu
07:18 AM User Interface Bug #7946 (Test): Default selection and current browse row color differs for different customers ...
Greg Shah
05:24 AM Database Feature #7382: Check performance of delete from vs drop table in H2
Alexandru Lungu wrote:
> Radu, please let me know if you managed to handle this to some extent. Otherwise, Eduard wi...
Radu Apetrii
05:23 AM Database Feature #7382: Check performance of delete from vs drop table in H2
Radu, please let me know if you managed to handle this to some extent. Otherwise, Eduard will continue working on this. Alexandru Lungu
04:05 AM Database Bug #8044 (Review): Fix "Failed direct-access due to Error direct accessing for finding record by...
*Committed 8044a/rev.14830* Normalized unknown value, date and datetime arguments. In the end, I used @dateValue()@ t... Dănuț Filimon

11/16/2023

06:03 PM Base Language Feature #6431: implement support to allow CPINTERNAL set to UTF-8 and CP936
Hello, I wrote a small test (chr_and_asc.p) which tests the conversion of a character from one code page to another (... Theodoros Theodorou
10:33 AM Database Bug #7454: Make ValueStringIgnoreCase the default generated value for setString in FWD-H2
Alexandru Lungu wrote:
> Profiled 7454a now and got -0.6% improvement. This was on-spot with the expectancy (or even...
Dănuț Filimon
09:36 AM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
Greg Shah wrote:
> Does this branch only have the script change?
I believe Ovidiu had something for this branch:
...
Roger Borrello
05:37 AM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
Does this branch only have the script change? Greg Shah
08:03 PM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
Branch 4722b was rebased to trunk_14829 and is at revision 14830. Roger Borrello
06:04 AM Database Bug #8044: Fix "Failed direct-access due to Error direct accessing for finding record by unique i...
While I was testing a large application, there were not a lot of instances where the unknown value is normalized to n... Dănuț Filimon
04:34 AM Database Bug #8044: Fix "Failed direct-access due to Error direct accessing for finding record by unique i...
Please check the @DateType.setParameter@ function. It should do the same. Alexandru Lungu
04:32 AM Database Bug #8044: Fix "Failed direct-access due to Error direct accessing for finding record by unique i...
Alexandru Lungu wrote:
> Not quite; I was just seeing this pop up thousand of times.
>
> Please also mind handli...
Dănuț Filimon
04:21 AM Database Bug #8044: Fix "Failed direct-access due to Error direct accessing for finding record by unique i...
Not quite; I was just seeing this pop up thousand of times.
Please also mind handling:
* the unknown value as we...
Alexandru Lungu
03:53 AM Database Bug #8044: Fix "Failed direct-access due to Error direct accessing for finding record by unique i...
*Committed 8044a/rev.14829* Normalized @rowid@ and @longchar@ arguments.
Alexandru, can you provide a reproduction c...
Dănuț Filimon
12:40 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
*Committed 6649b/rev.14807*. Fixed a NPE when there are no path-mapping nodes in name_map.xml. Dănuț Filimon

11/15/2023

09:51 AM Database Bug #7454 (Internal Test): Make ValueStringIgnoreCase the default generated value for setString i...
Profiled 7454a now and got -0.6% improvement. This was on-spot with the expectancy (or even quite better).
I will mo...
Alexandru Lungu
09:41 AM Database Bug #8044: Fix "Failed direct-access due to Error direct accessing for finding record by unique i...
I am still getting the same error but in a different process now, there is another object aside from @rowid@ that is ... Dănuț Filimon
09:21 AM Database Bug #8044: Fix "Failed direct-access due to Error direct accessing for finding record by unique i...
I have multiple warning where this direct access exception is logged in a customer application: @23/11/15 16:08:27.39... Dănuț Filimon
09:12 AM Database Bug #8044 (WIP): Fix "Failed direct-access due to Error direct accessing for finding record by un...
Alexandru Lungu
09:37 AM Database Bug #7731: performance improvements for FQLPreprocessor
Alexandru Lungu wrote:
> What internal tests should be done here, Danut? Are you able to do some smoke tests on larg...
Dănuț Filimon
09:32 AM Database Bug #7731: performance improvements for FQLPreprocessor
What internal tests should be done here, Danut? Are you able to do some smoke tests on large applications?
I can t...
Alexandru Lungu
08:23 AM Database Bug #7567: use Session.PK instead of DatabaseManager.PRIMARY_KEY wherever possible
If only we completed #7782, we could remove this useless @id@ workaround code. Problems like the above are just extr... Greg Shah
08:15 AM Database Bug #7567: use Session.PK instead of DatabaseManager.PRIMARY_KEY wherever possible
Here are the current scenarios that I tested with Hotel_GUI:
* 7567a without changes - @primaryKeyName="recid"@ and ...
Dănuț Filimon
05:18 AM Database Bug #7567: use Session.PK instead of DatabaseManager.PRIMARY_KEY wherever possible
It seems that the "recid" is hard coded in @SchemaConfig@ and is used by the meta database, this causes the server to... Dănuț Filimon
08:12 AM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
Understood. For such extensive changes to our control flow, it seems necessary. Greg Shah
08:09 AM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
Greg, I can do that for POC, but it will take me a day to have it converted. Also mind that I am already reconverting... Alexandru Lungu
07:31 AM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
If you think it is ready, let's get ChUI regression tests, ETF and the big POC tested. Greg Shah
03:40 AM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
Converted and setup a large customer application using 7045b branch, and used it for a bit. Did not noticed any major... Eduard Soltan
08:01 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
> It will hide the implementation details, which can be considered an improvement,
This isn't just an improvement...
Greg Shah
07:43 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
Greg Shah wrote:
> No, I don't think that is a likely approach. Those classes are tightly coupled to context, to th...
Galya B
07:41 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
No, I don't think that is a likely approach. Those classes are tightly coupled to context, to the legacy transaction... Greg Shah
07:36 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
OK, so then we agree to proceed with reworking the core FWD DB classes to work without context, so that the DB check ... Galya B
07:28 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
> > Indeed, the use of @setuserid@ is very common.
> As far as I understand @setuserid@ is a common DB authenticat...
Greg Shah
07:25 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
Galya B wrote:
> Greg Shah wrote:
> > Indeed, the use of @setuserid@ is very common.
> As far as I understand @s...
Galya B
07:23 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
Greg Shah wrote:
> Indeed, the use of @setuserid@ is very common.
As far as I understand @setuserid@ is a common ...
Galya B
07:23 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
> I need a definition of 'properly'.
Directly showing the replacement of the original 4GL authentication method, e...
Greg Shah
07:21 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
Galya wrote:
> Actually hotel gui works properly and exemplary now (tested with h2). The raised concern was that i...
Greg Shah
07:21 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
I need a definition of 'properly'. Galya B
07:19 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
We may want to work part of this task so that the Hotel GUI SSO is properly implemented as an example. Greg Shah
07:03 AM User Interface Feature #4856: web client session forking
> > Is 7813a involved in future headway on this task?
> Yes. It will use the same mechanism, started in a different ...
Greg Shah
01:49 AM User Interface Feature #4856: web client session forking
Greg Shah wrote:
> Is 7813a involved in future headway on this task?
Yes. It will use the same mechanism, started i...
Galya B
03:35 AM Database Bug #7999 (WIP): FWD does not honor FIELDS/EXCEPT at dynamic queries
Alexandru Lungu

11/14/2023

03:01 PM Database Feature #6414: ERROR attribute for buffer, dataset and temp-table
I think there are very few places in customer projects which are affected by the changes in this branch. The fwdtests... Ovidiu Maxiniuc
02:42 PM Database Feature #6414 (Internal Test): ERROR attribute for buffer, dataset and temp-table
Ovidiu Maxiniuc wrote:
> Branch 6414a updated, rebased and pushed as r14827.
Thanks for addressing the code revie...
Eric Faulhaber
02:13 PM User Interface Feature #4856: web client session forking
Is 7813a involved in future headway on this task? Greg Shah
08:02 AM Database Feature #7323: Implement soft unique index in FWD-H2
I have found only some points:
* Remove @hasDirectAccess@ entirely and let @startValidate@ and @stopValidate@ simply...
Alexandru Lungu
06:45 AM Database Feature #7323: Implement soft unique index in FWD-H2
Unfortunately, I still have the same results as in #7323-49 :/ We are adding to much overhead somewhere. Maybe after... Alexandru Lungu
04:39 AM Database Feature #7323: Implement soft unique index in FWD-H2
I committed to 7323a, rev. 14801 the following changes:
* Reverted @TempTableHelper@ to its original state.
* Repla...
Radu Apetrii
04:07 AM Database Feature #7323: Implement soft unique index in FWD-H2
Alexandru Lungu wrote:
> I will start testing in ~30mins. If you have time to get them committed, it is ideal. If no...
Radu Apetrii
03:39 AM Database Feature #7323: Implement soft unique index in FWD-H2
I will start testing in ~30mins. If you have time to get them committed, it is ideal. If not, the changes are minor a... Alexandru Lungu
02:18 AM Database Feature #7323: Implement soft unique index in FWD-H2
Is it OK to commit those changes now or will it interfere with your testing? Radu Apetrii
07:53 AM Database Feature #6815: configure all cache sizes in the directory, and create documentation for them
> OTOH, for this specific case, it may just be that the parsed predicate is 'one of a kind', in that it uses some uni... Alexandru Lungu
07:42 AM Database Feature #6815: configure all cache sizes in the directory, and create documentation for them
Alexandru Lungu wrote:
> Danut, please point out to the documentation in this task and mark it as Review when finish...
Dănuț Filimon
07:13 AM Database Bug #7924 (Review): add support for creating an empty database
I attached a patch that solves the issue. Ovidiu, can you retest MariaDB and tell me if there are any more problems w... Dănuț Filimon
06:23 AM Database Bug #7924: add support for creating an empty database
Ovidiu Maxiniuc wrote:
> As noted in my previous note, this is the cause of the failure: the indices attempts to use...
Dănuț Filimon
05:03 AM Database Bug #8044 (WIP): Fix "Failed direct-access due to Error direct accessing for finding record by un...
Alexandru Lungu
04:53 AM Database Bug #8030: unique index violation when creating a record in two sessions
I retested with *7156b/rev.14846* but I couldn't reproduce the error with this branch too. Dănuț Filimon
04:37 AM Database Bug #8030: unique index violation when creating a record in two sessions
Alexandru Lungu wrote:
> Danut, also make sure you use the right schema (having unique indexes on book-id / isbn).
...
Dănuț Filimon
04:35 AM Database Bug #8030: unique index violation when creating a record in two sessions
Danut, also make sure you use the right schema (having unique indexes on book-id / isbn). Alexandru Lungu
04:06 AM Database Bug #8030: unique index violation when creating a record in two sessions
Dănuț Filimon wrote:
> Constantin Asofiei wrote:
> > Don't use parallel clients, run the same client twice. Also y...
Constantin Asofiei
04:05 AM Database Bug #8030: unique index violation when creating a record in two sessions
Constantin Asofiei wrote:
> Don't use parallel clients, run the same client twice. Also you need to use MariaDB for...
Dănuț Filimon
04:02 AM Database Bug #8030: unique index violation when creating a record in two sessions
Dănuț Filimon wrote:
> I was not able to reproduce the scenario with *trunk/rev.14828*, especially make it to reach ...
Constantin Asofiei
04:00 AM Database Bug #8030: unique index violation when creating a record in two sessions
I was not able to reproduce the scenario with *trunk/rev.14828*, especially make it to reach the catch from @orm.Pers... Dănuț Filimon

11/13/2023

11:22 AM Database Feature #7323 (Internal Test): Implement soft unique index in FWD-H2
*Review of 7323a*
* I don't think the cast to @P2JH2Dialect@ is needed anymore in @TempTableHelper@. The methods a...
Alexandru Lungu
10:38 AM Database Bug #8030 (WIP): unique index violation when creating a record in two sessions
Constantin Asofiei wrote:
> The @java.sql.SQLIntegrityConstraintViolationException.cause@ field is null for MariaDB....
Alexandru Lungu
04:37 AM Database Bug #8030: unique index violation when creating a record in two sessions
The @java.sql.SQLIntegrityConstraintViolationException.cause@ field is null for MariaDB.
Constantin Asofiei
03:46 AM Database Bug #8030: unique index violation when creating a record in two sessions
I added Radu as a watcher; he is the author of 7323a. Alexandru Lungu
03:45 AM Database Bug #8030: unique index violation when creating a record in two sessions
Constantin, just a further notice on #8030-3. In H2, the first SQLException is an internal H2 exception that has anot... Alexandru Lungu
03:12 AM Database Bug #8030: unique index violation when creating a record in two sessions
Constantin Asofiei wrote:
> There is a case for #7669, which I don't have yet a complete standalone recreate; it loo...
Tomasz Domin
08:02 AM Database Bug #7567: use Session.PK instead of DatabaseManager.PRIMARY_KEY wherever possible
Alexandru Lungu wrote:
> Danut, please double check: @searchPath@ and @propath@ in directory.xml and propath in p2j....
Dănuț Filimon
07:55 AM Database Bug #7567: use Session.PK instead of DatabaseManager.PRIMARY_KEY wherever possible
Danut, please double check: @searchPath@ and @propath@ in directory.xml and propath in p2j.cfg.xml. Is smart.p at lea... Alexandru Lungu
07:53 AM Database Bug #7567: use Session.PK instead of DatabaseManager.PRIMARY_KEY wherever possible
I had to make a few small changes to @DirectAccessHelper@ to fit the changes made in H2. When I tried to test Hotel_G... Dănuț Filimon
05:43 AM Database Feature #6496 (WIP): add equivalent support for -trig command line option
Alexandru Lungu
05:42 AM Database Feature #6496: add equivalent support for -trig command line option
I am moving this to High priority as it may grant us some performance improvement that we really need now. Alexandru ... Alexandru Lungu
05:16 AM Base Language Feature #6649 (Internal Test): improve the performance or SourceNameMapper runtime
Dănuț Filimon
05:09 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
I also tried to find out the cause of the incremental version where nodes are duplicated but after running a @./gradl... Dănuț Filimon
05:06 AM Base Language Feature #6649 (WIP): improve the performance or SourceNameMapper runtime
*Committed 6649b/rev.14805 and 6649b/rev.14806*:
* Made @sourceCache@ configurable through @CacheManager@. I previou...
Dănuț Filimon
04:06 AM Database Bug #8032 (WIP): Deleted records are returned by a preselect query
This is already handled in #5768. There are multiple attempts to fix this (the last one is 5768c). This will be fixed... Alexandru Lungu

11/12/2023

10:51 AM Database Bug #8032: Deleted records are returned by a preselect query
Here's a testcase. A record was preselected by a query and then deleted in the same session. It is still returned by ... Stanislav Lomany
08:08 AM Database Bug #8032 (Closed): Deleted records are returned by a preselect query
Stanislav Lomany
04:29 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
Code review 6649b revision 14804.
@initializationPaths.size() == 0@ in @createSourceCacheEntry@ should be protecte...
Hynek Cihlar

11/11/2023

02:51 PM Database Bug #8030: unique index violation when creating a record in two sessions
OK, this message seems to be a red herring: is just logged when this test is executed twice in a row:... Constantin Asofiei
03:43 AM Database Bug #8030: unique index violation when creating a record in two sessions
There is a case for #7669, which I don't have yet a complete standalone recreate; it looks like this, ran from two cl... Constantin Asofiei
03:30 AM Database Bug #8030 (Closed): unique index violation when creating a record in two sessions
Constantin Asofiei

11/10/2023

11:38 AM Database Feature #6815: configure all cache sizes in the directory, and create documentation for them
Alexandru, in #7669, I start seeing @DynamicQueryHelper cache level #1 is full. Dumped 1 old entries@ - (some 750k m... Constantin Asofiei
10:57 AM Database Feature #6815 (WIP): configure all cache sizes in the directory, and create documentation for them
Danut, please point out to the documentation in this task and mark it as Review when finished. Alexandru Lungu
11:02 AM Database Bug #7167 (Internal Test): Associating records from opened buffers to new sessions is slow
With some slim analysis, I still see @BufferManager.activeBuffers@ in top 50 performance items (being called ~100 tim... Alexandru Lungu
10:37 AM Database Feature #6720: lazy hydration
I run some regression testing and they passed. I also got them a second round to extract some insights.
|_. JMX |_...
Alexandru Lungu
09:56 AM Base Language Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection
That code resolves the @MethodAccess@ target for a @java.lang.reflect.Method@. @Method@ instances are not singleton,... Constantin Asofiei
09:50 AM Base Language Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection
Constantin, I reached quite randomly in @Utils.invoke@ and saw the double map access on @METHOD_DATA@ and @methodAcce... Alexandru Lungu
09:37 AM Database Bug #8025: Persistence API improvements
Constantin Asofiei wrote:
> Eric, customers need to access the result set metadata for the @ ScrollableResults<?> re...
Alexandru Lungu
09:10 AM Database Bug #8025: Persistence API improvements
Another part which is requested by customers to be improved: @executeSQLBatch@ to return an @int[]@ array with the re... Constantin Asofiei
07:44 AM Database Bug #8025: Persistence API improvements
Eric, customers need to access the result set metadata for the @ ScrollableResults<?> resultSet = connection.executeS... Constantin Asofiei
07:43 AM Database Bug #8025 (New): Persistence API improvements
Constantin Asofiei
09:02 AM Base Language Feature #6649 (Review): improve the performance or SourceNameMapper runtime
*Committed 6649b/rev.14804*.
* After solving the path-mapping node duplication problem, I reverted the changes from ...
Dănuț Filimon
03:23 AM Base Language Feature #6410: implement additional built-in OO classes/interfaces
Marian, please remind me of your issues - I plan to look at them over the next week. Also, point me to any test repr... Constantin Asofiei
 

Also available in: Atom