Activity
From 11/27/2023 to 12/26/2023
12/25/2023
- 07:04 AM Database Bug #6767: Possible name clashes in DMO classes
- The work redone in the branch 6767b, The branch is rebased to trunk rev. 14906 the branch revision is 14917.
Please,...
12/23/2023
- 02:34 PM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
- 6649c was merged to trunk rev 14906 and archived.
- 08:04 PM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
- Created task branch 6649c from trunk rev 14905
6649c rev 14906 fixes a race condition in SourceNameMapper propath ... - 10:40 PM Base Language Feature #4392: add -pf support for appserver CONNECT() method
- Constantin Asofiei wrote:
> * FileStream - *Ovidiu*: I understand the purpose of 'hasDuplicatedLastLine' flag, but a...
12/22/2023
- 03:01 PM Database Bug #6767: Possible name clashes in DMO classes
- The following methods should be also renamed in addition to the methods listed in #6767-9:...
- 12:52 PM Base Language Feature #6422 (WIP): implement auditing support including AUDIT-POLICY and AUDIT-CONTROL
- Wow, I missed a lot.
Theodoros: Please address these concerns/notes. - 12:47 PM Base Language Feature #6422 (Review): implement auditing support including AUDIT-POLICY and AUDIT-CONTROL
- Review of 6422a rev 14906 (the entire code):
* @AuditControlManager@
** we don't/can't use @volatile@ for context-... - 12:47 PM Base Language Feature #6422 (Internal Test): implement auditing support including AUDIT-POLICY and AUDIT-CONTROL
- Eric Faulhaber wrote:
> Some minor coding standards or format issues in @DirectoryServiceHelper@:
> * Lines 7-8 sho... - 12:11 PM Base Language Feature #6422: implement auditing support including AUDIT-POLICY and AUDIT-CONTROL
- Code Review Task Branch 6422a Revisions 14889 through 14906
I'm OK with the changes. - 11:48 AM Base Language Feature #6422: implement auditing support including AUDIT-POLICY and AUDIT-CONTROL
- Theodoros: Please rebase this to the latest trunk revision 14903.
Constantin: Please review after this is rebased. - 11:29 AM Base Language Feature #6422: implement auditing support including AUDIT-POLICY and AUDIT-CONTROL
- Code review 6422a/14902-14906 (after rebase):
The changes look good to me.
Some minor coding standards or forma... - 12:49 PM Runtime Infrastructure Bug #7589 (Internal Test): org.slf4j.impl.StaticLoggerBinder when deploying p2j.jar in tomcat
- Code Review Task Branch 7589b Revision 14868
The changes look good. If suitable testing has been completed, we ca... - 12:35 PM Base Language Bug #8119 (Merge Pending): JavaDoc build task produces more warnings in Windows in comparison to ...
- Code Review Task Branch 8119a Revisions 14874 and 14875
The changes are good.
Please rebase and we will schedul... - 12:16 PM Base Language Feature #4392: add -pf support for appserver CONNECT() method
- Review of 4392a rev 14868:
* ConnectHelper - is it possible to go into an infinite recursion in 4GL, if -pf is used ... - 12:09 PM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
- Code review 8074a.
@WebDriverHandler.getAvailableThemes@ should somehow handle a theme with empty name in the dire... - 10:42 AM Database Bug #7138: Short circuit fake-update (update with a new value eqaul to the old value) in H2
- What is the status of 7138a_h2? Does it need more review? More testing? It seems to provide a decent improvement o...
- 04:24 AM Base Language Feature #7045 (Test): re-implement "normal" (non-abend) stack unwinding to avoid throwing an exce...
- Branch 7045b was merged into trunk revision 14899 and archived.
- 12:31 AM Database Bug #7496 (WIP): finish support for query:forward-only attribute
- Since 7496b was merged, I'll put this issue into WIP. I've managed to find a few other issues with the implementation...
12/21/2023
- 03:07 PM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
- 7045b is at the front of the queue now, go ahead and merge.
- 02:33 PM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
- You can merge 7045b to trunk after 3303a.
- 02:27 PM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
- 7045b passed ETF testing.
- 09:30 AM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
- Constantin, do you feel like it is better to get *everything* in trunk and then run ETF against all, instead of "micr...
- 09:03 AM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
- Alexandru Lungu wrote:
> Constantin, ETF tests are the only ones that were not run. I rebased 7045b to latest trunk ... - 07:15 AM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
- Nice catches, Eduard! Please do a second iteration of the changes - I really want to make sure we don't missed someth...
- 06:17 AM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
- Looked at 7045b after rebase, it looks fine.
Done some minor fixes at history entry.
In @forBlockWorker@, changed i... - 02:43 PM Base Language Bug #8154: refactor scopeable stacks
- Constantin Asofiei wrote:
> I need to digest this more; for scoped dictionaries, in my mind I have something like th... - 01:51 PM Base Language Bug #8154: refactor scopeable stacks
- Eric Faulhaber wrote:
> Constantin Asofiei wrote:
> > [...]
> > Why I mention this: all this stack push/pop, my fe... - 01:19 PM Base Language Bug #8154: refactor scopeable stacks
- Constantin Asofiei wrote:
> [...]
> Why I mention this: all this stack push/pop, my feeling is that is expensive; o... - 12:46 PM Base Language Bug #8154: refactor scopeable stacks
- From #7026-296:
> Constantin Asofiei wrote:
> > On a side note: all scope support is managed in various stacks (o... - 12:45 PM Base Language Bug #8154 (WIP): refactor scopeable stacks
- 02:42 PM Deployment Support #3303: make the automated deployment process fully production ready
- Greg Shah wrote:
> Code Review Task Branch 3303a Revision(s?) 14897 through 14899
>
> I'm not sure why it shows 3... - 02:32 PM Deployment Support #3303: make the automated deployment process fully production ready
- Code Review Task Branch 3303a Revision(s?) 14897 through 14899
I'm not sure why it shows 3 revisions but the chang... - 02:25 PM Deployment Support #3303: make the automated deployment process fully production ready
- The incorrect branch name has been corrected to be *3303a*
- 02:02 PM Deployment Support #3303: make the automated deployment process fully production ready
- Roger Borrello wrote:
> Greg Shah wrote:
> > Could you have misnamed the branch on creation?
>
> Ugh... I must d... - 02:00 PM Deployment Support #3303: make the automated deployment process fully production ready
- Greg Shah wrote:
> Could you have misnamed the branch on creation?
Ugh... I must dyslexic be... I created it as *... - 01:57 PM Deployment Support #3303: make the automated deployment process fully production ready
- There is no branch at @~/secure/code/p2j_repo/p2j/active/3303a/@. Could you have misnamed the branch on creation?
- 01:49 PM Deployment Support #3303: make the automated deployment process fully production ready
- Branch 3303a was rebased to trunk_14896 and is at revision 14899.
- 02:42 PM Runtime Infrastructure Bug #8135: replace ScopedDictionary for better performance
- Some notes on the current prototype replacement...
I've gotten rid of the dictionaries at each scope level. There ... - 02:39 PM Base Language Feature #6650: improve performance of Scopeable notification in TM.processScopeNotifications
- Branch 7026f was merged into trunk revision 14897 and archived.
- 10:34 AM Base Language Feature #6650: improve performance of Scopeable notification in TM.processScopeNotifications
- 7026f rev 14903 fixes some regressions in WidgetPool support.
- 06:14 AM Base Language Feature #6650: improve performance of Scopeable notification in TM.processScopeNotifications
- 7026f rev 14902 includes:
* Refactored the WidgetPool scopeable support to register for processing as needed.
* Obj... - 01:34 PM Base Language Feature #6422: implement auditing support including AUDIT-POLICY and AUDIT-CONTROL
- Eric Faulhaber wrote:
> Code review 6422a/14649-14653:
> > * I think the bind/unbind is not needed because I think ... - 12:39 PM Database Feature #6442: missing encoding/collation features
- The @DBCODEPAGE()@ and @DBCOLLATION()@ built-in function were implemented in #7326 and available in trunk starting wi...
- 12:05 PM Database Feature #4722 (Test): data import should be able to run with only the converted application jar f...
- Branch 4722b was merged into trunk revision 14895 and archived.
- 11:24 AM Database Feature #4722 (Merge Pending): data import should be able to run with only the converted applicat...
- Please merge 4722b after 8056b.
- 10:58 AM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
- I rebased the branch to trunk/14890 and fixed the (strange, albeit simple) conflicts.
Pushed up 4722b to revision 14... - 09:11 AM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
- Ovidiu : Please rebase and if the result is working with a smoke test, we will get it merged.
- 09:03 AM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
- Greg Shah wrote:
> Constantin: Please review the @memptr@ change in 4722b rev 14888. If this was a safe change, why... - 08:44 AM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
- Constantin: Please review the @memptr@ change in 4722b rev 14888. If this was a safe change, why didn't we make it b...
- 08:31 AM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
- Ovidiu, there are a couple of conflicts when attempting to rebase against trunk revision 14890. Could you take a look...
- 08:28 AM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
- Eric Faulhaber wrote:
> I think the @import.sh@ changes are ok, but I did not confirm with a test. Has this been tes... - 09:36 PM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
- Eric Faulhaber wrote:
> In the @XmlFilePlugin@ c'tor, there is this comment:
> [...]
> At @ImportWorker@ line 606,... - 11:36 AM User Interface Bug #7824 (Test): Simplify idle connection settings and apply the default configuration for the w...
- 11:33 AM User Interface Bug #7824: Simplify idle connection settings and apply the default configuration for the web clie...
- 7824a has been rebased, merged into the trunc as rev 14893 and archived.
- 11:21 AM User Interface Bug #7824: Simplify idle connection settings and apply the default configuration for the web clie...
- Planning to merge within next 15 minutes after rebase.
- 10:00 AM User Interface Bug #7824: Simplify idle connection settings and apply the default configuration for the web clie...
- This can merge after 7889a.
- 09:46 AM User Interface Bug #7824 (Merge Pending): Simplify idle connection settings and apply the default configuration ...
- Code review 7824a revision 14897. The changes are good, I have no more objections.
- 04:00 AM User Interface Bug #7824: Simplify idle connection settings and apply the default configuration for the web clie...
- 7824a has been rebased. It seems that it can be merged into the trunc. Are there any objections?
- 11:23 AM Database Feature #8067: investigate adding automatically adding a FIELDS clause for simple record blocks
- I fully agree with Eric and mark this as top focus in the implementation. However, I am not 100% sure this approach w...
- 11:13 AM Database Feature #8067: investigate adding automatically adding a FIELDS clause for simple record blocks
- Please note that an explicit FIELDS clause in 4GL code will raise an error if a field is accessed in downstream code ...
- 10:50 AM Database Bug #7496: finish support for query:forward-only attribute
- Branch 7496b was merged into trunk revision 14891 and archived.
This task is still open due to 7496a. - 10:07 AM Database Bug #7496: finish support for query:forward-only attribute
- Doing it now - just 10 mins to check it out.
- 07:52 AM Database Bug #7496: finish support for query:forward-only attribute
- You can merge 7496b to trunk now.
- 04:57 AM Database Bug #7496: finish support for query:forward-only attribute
- Greg, this seems like an easy performance gain. It was fully tested (except ETF). We can go ahead with the merge of 7...
- 08:42 AM Database Bug #6767: Possible name clashes in DMO classes
- Eric Faulhaber wrote:
> Vladimir, sorry for the long delay in reviewing this again. Please rebase this branch when y...
12/20/2023
- 06:55 PM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
- Hold off on the merge. 8056a and 8127a need to go first.
- 11:44 AM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
- Just rebased 7045b to latest trunk, but the process was a bit slow due to the large number of changes to be introduce...
- 11:38 AM Base Language Feature #7045 (Merge Pending): re-implement "normal" (non-abend) stack unwinding to avoid throwin...
- Please merge to trunk after 8007a.
- 10:36 AM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
- Quick final look at 7045b/14838...
It looks like we still need a rebase to current trunk before merge. Also, some ... - 09:48 AM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
- Completely finished the testing of 7045b. Pending for merge.
- 09:25 AM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
- Removed hard tabs from the previous commit. Committed on 7045b, revision 14838.
I do not think there is anything els... - 04:39 PM Database Bug #6767: Possible name clashes in DMO classes
- Vladimir, sorry for the long delay in reviewing this again. Please rebase this branch when you can. I started reviewi...
- 04:26 PM Base Language Feature #6422: implement auditing support including AUDIT-POLICY and AUDIT-CONTROL
- Code review 6422a/14649-14653:
*Please note again that I am not familiar with the legacy audit feature set, so I a... - 10:41 AM Base Language Feature #6422: implement auditing support including AUDIT-POLICY and AUDIT-CONTROL
- Kind reminder for a review
- 01:37 PM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
- Code review 4722b/14887-14892:
Generally good, but please see comments/questions below.
I think the @import.sh@... - 12:14 PM Database Feature #4722 (Review): data import should be able to run with only the converted application jar...
- Eric: Please review.
- 11:59 PM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
- Branch 4722b was rebased to trunk_14886 and is at revision 14892.
- 09:43 PM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
- I think so but, to my knowledge, the changes r14878..14884 were not reviewed.
- 01:21 PM Base Language Feature #8138: ABLUnit configuration using environment variables
- I agree, we should add the ability to configure the bootstrap cfg file name (and only the bootstrap cfg file name) vi...
- 08:27 AM Base Language Feature #8138: ABLUnit configuration using environment variables
- Vladimir Tsichevski wrote:
> Using Java properties for client configuration will allow to run with no configuration ... - 06:53 AM Base Language Feature #8138: ABLUnit configuration using environment variables
- Marian Edu wrote:
> Vladimir Tsichevski wrote:
> > IMO this will add another layer of complexity and mixed technolo... - 06:49 AM Base Language Feature #8138: ABLUnit configuration using environment variables
- Vladimir Tsichevski wrote:
> IMO this will add another layer of complexity and mixed technology. Besides, using OS e... - 06:02 AM Base Language Feature #8138: ABLUnit configuration using environment variables
- IMO this will add another layer of complexity and mixed technology. Besides, using OS environment variables with Java...
- 04:13 AM Base Language Feature #8138: ABLUnit configuration using environment variables
- I'm extracting that from another unrelated issue just so it doesn't get lost.
Vladimir, we're running ABLUnit from... - 04:08 AM Base Language Feature #8138 (Internal Test): ABLUnit configuration using environment variables
- 01:21 PM User Interface Bug #7794: FILL-IN: editing numbers issues
- h2. Known issues compiled
This entry contains all know sub-issues, and will be edited as new sub-issues emerge and... - 12:50 PM User Interface Bug #7794: FILL-IN: editing numbers issues
- Greg Shah wrote:
> I am remembering that some layout modes (@COLON-ALIGNED@?, @SIDE-LABELS@?) might change the align... - 12:18 PM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
- 6649a has been dead-archived.
- 02:06 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
- Greg Shah wrote:
> Is 6649a a live branch?
It should not be, all the work I've done was in 6649b. - 08:29 AM Database Feature #6720: lazy hydration
- I am "battling" with a small regression when averaging the new row-structure architecture with lazy hydration. I was ...
- 08:25 AM Database Bug #7496: finish support for query:forward-only attribute
- *Committed 7496b/rev.14879* Added the patch from #7496-41.
- 05:40 AM Database Bug #7496: finish support for query:forward-only attribute
- I finished testing the patch from #7496-41:
* POC tests: passed;
* POC regression tests: passed (with the expected ... - 05:30 AM Base Language Feature #8140: Client PID
- Is there a way to get the 'client' process identifier in FWD? We use that for sikuli to identify the process window t...
- 05:24 AM Base Language Feature #8140 (New): Client PID
- 05:12 AM Base Language Bug #8139: OS-COMMAND fails on windows if not in "batch mode"
- For what it's worth forcing the @SwingGuiDriver@ to take into account the @background@ option does solve the issue an...
- 04:48 AM Base Language Bug #8139: OS-COMMAND fails on windows if not in "batch mode"
- We're trying to start a 'ui simulator' based on sikuli using @OS-COMMAND@ and this is always failing if the client is...
- 04:16 AM Base Language Bug #8139 (New): OS-COMMAND fails on windows if not in "batch mode"
- 12:00 AM Deployment Support #3303: make the automated deployment process fully production ready
- Branch 3303a was rebased to trunk_14886 and is at revision 14889.
12/19/2023
- 05:47 PM Database Bug #8101: Issue with temp-table defined as reference-only
- The above 4gl code generates the following java code....
- 03:58 PM Database Feature #6720: lazy hydration
- How far along is 6720b?
- 11:21 AM Runtime Infrastructure Bug #8135: replace ScopedDictionary for better performance
- @ScopedDictionary@ and to a lesser degree its subclass @ScopedSymbolDictionary@ are used throughout the runtime to ma...
- 11:11 AM Runtime Infrastructure Bug #8135 (New): replace ScopedDictionary for better performance
- 10:18 AM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
- 7045b passes a large set of regression tests from a customer application. I tested without the changes in rev. 14837....
- 10:13 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
- Is 6649a a live branch?
- 03:39 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
- Alexandru, I remember you also mentioned it in #6815. But at that time you asked Constantin for feedback on the idea....
- 03:32 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
- I agree with Eric. Fine tuning cache-sizes is a common pattern when deploying. I would also like a mechanism that can...
- 09:59 AM Database Feature #7066: Implement multi-table indexed query in H2
- It is pending mostly as it was attempting to optimize multi-table queries on H2. After some profiling and tracking, t...
- 09:50 AM Database Feature #7066: Implement multi-table indexed query in H2
- What is the status of this task and of 7066a?
- 09:38 AM Base Language Feature #6497: add equivalent support for the -T command line option
- 6497a was dead-archived.
- 08:38 AM Deployment Support #3303: make the automated deployment process fully production ready
- The repository for @~/secure/code/p2j_repo/mgmt/@ is now also available on *xfer.goldencode.com* as @/opt/fwd/mgmt@
- 07:41 AM Deployment Support #3303: make the automated deployment process fully production ready
- > After testing, I think I should remove at least *ncurses*, perhaps *jdk* as well. It all depends on how "thin" we w...
- 08:29 AM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
- Ovidiu: Is this safe and ready to merge to trunk?
- 08:28 AM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
- Greg Shah wrote:
> Does this need any further testing?
Not from my perspective. - 07:42 AM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
- Does this need any further testing?
- 07:41 AM Database Bug #7496 (Internal Test): finish support for query:forward-only attribute
- This change is invasive as it affects all @ProgressiveResults@ across any application. I am OK with the change: we sh...
- 07:38 AM Database Bug #7496: finish support for query:forward-only attribute
- Alexandru, I tested POC with the solution mentioned in #7496-40 after we discussed it could provide a performance imp...
- 03:06 AM Database Bug #7496: finish support for query:forward-only attribute
- Dănuț Filimon wrote:
> First things first, there are a lot of @23/12/15 12:47:11.619+0200 | SEVERE | com.goldencode...
12/18/2023
- 04:39 PM Deployment Support #3303: make the automated deployment process fully production ready
- Right now I have the roles for building a Docker host as:
* base
* fwd_acct
* dev_tools
* jdk
* ncurses
* inter... - 02:13 PM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
- Dănuț Filimon wrote:
> [[p2j:Database Configuration#Cache-Sizes]] was updated with the necessary information for con... - 11:40 AM User Interface Bug #7824: Simplify idle connection settings and apply the default configuration for the web clie...
- Please review rev 14889 (7824a) that fixed refs: #7824-17 and #7824-27.
- 10:44 AM Base Language Feature #8124: rework conversion and runtime support for BLOCK-LEVEL and ROUTINE-LEVEL statements
- Some notes about this: ROUTINE/BLOCK-LEVEL affect the 'file' and not the 'instance'. So, for OO, each top-level call...
- 10:02 AM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
- Branch 4722b was rebased to trunk_14882 and is at revision 14888.
- 09:51 AM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
- Roger Borrello wrote:
> Great! Don't forget to update the @ImportWorker.java@ header. I'll test it out this AM.
I... - 09:22 AM Database Bug #8101: Issue with temp-table defined as reference-only
- The failure comes from the line @boolean hasRecords = local.nonEmptyTableFlags.contains(multiplexID);@ in @TemporaryB...
- 06:29 AM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
- Eduard, please mind that there are still some hard-tabs in the last 2 commits. (@BlockManager@).
12/15/2023
- 09:10 AM Database Bug #7496 (WIP): finish support for query:forward-only attribute
- POC tests still fail, I am trying to setup the fwdtests project in Eclipse and debug.
- 07:10 AM Database Bug #7496: finish support for query:forward-only attribute
- First things first, there are a lot of @23/12/15 12:47:11.619+0200 | SEVERE | com.goldencode.p2j.persist.ForwardResu...
- 04:07 AM Database Bug #7496: finish support for query:forward-only attribute
- I am picking up work on this issue for #7991 and will be testing the changes first to see if there are any obvious pr...
- 07:43 AM Database Feature #8067: investigate adding automatically adding a FIELDS clause for simple record blocks
- Committed on 8967a, revision 14872.
Added an annotation @internalfields@ with fields used in a @FOR EACH@ block to... - 07:04 AM Base Language Feature #6417: cleanup some known items in appserver support
- @WebSpeed@ used to be OE app in the browser (in some script) running on the WebSpeed agent. So the client knew it is ...
- 04:39 AM Base Language Feature #6417: cleanup some known items in appserver support
- > * VersionInfo:clientType supports only 4GLCLIENT and APPSERVER at this time
Access to @clientType@ via:
* @SESS... - 02:51 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
- [[p2j:Database Configuration#Cache-Sizes]] was updated with the necessary information for configuring the cache size ...
- 08:38 PM Deployment Support #3303: make the automated deployment process fully production ready
- The latest revision builds a FWD reference system utilizing Docker image to retrieve the FWD deployment. Right now it...
12/14/2023
- 12:24 PM Base Language Feature #8124: rework conversion and runtime support for BLOCK-LEVEL and ROUTINE-LEVEL statements
- Instead of emitting @onBlockLevel(Condition.ERROR, Action.THROW);@ or @onRoutineLevel(Condition.ERROR, Action.THROW);...
- 12:22 PM Base Language Feature #8124 (New): rework conversion and runtime support for BLOCK-LEVEL and ROUTINE-LEVEL stat...
- 12:18 PM Base Language Bug #8084 (Test): refactor the 'execute' method for legacy classes
- 11:56 AM Base Language Bug #8084: refactor the 'execute' method for legacy classes
- Branch 8084a was merged to trunk rev 14876 and archived.
- 11:38 AM Base Language Bug #8084: refactor the 'execute' method for legacy classes
- If you've done enough, you can merge.
- 11:34 AM Base Language Bug #8084: refactor the 'execute' method for legacy classes
- Greg Shah wrote:
> Yes, if you are complete with testing.
I haven't converted all apps, but I think the conversion ... - 09:47 AM Base Language Bug #8084 (Internal Test): refactor the 'execute' method for legacy classes
- Yes, if you are complete with testing.
- 09:32 AM Base Language Bug #8084: refactor the 'execute' method for legacy classes
- Greg Shah wrote:
> As an additional improvement, I wonder if we should change how @BLOCK-LEVEL@ and @ROUTINE-LEVEL@ ... - 07:10 PM Base Language Bug #8084: refactor the 'execute' method for legacy classes
- Code Review Task Branch 8084a Revisions 14870 through 14873
The changes are good.
As an additional improvement,... - 11:19 AM Base Language Feature #6649 (Test): improve the performance or SourceNameMapper runtime
- Branch 6649b was merged to trunk rev 14874 and archived.
- 11:08 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
- Yes, please merge now.
- 11:01 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
- As this was the last testing required for #6649, I am preparing to merge 6649b.
- 10:58 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
- Constantin Asofiei wrote:
> Alexandru Lungu wrote:
> > Constantin, if 6649b passes ETF, we can merge it to trunk. P... - 10:32 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
- Alexandru Lungu wrote:
> Constantin, if 6649b passes ETF, we can merge it to trunk. Please let me know when to proce... - 09:43 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
- Constantin, if 6649b passes ETF, we can merge it to trunk. Please let me know when to proceed.
- 08:49 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
- Together with Alexandru we've managed to find a cause and solution for the trunk regression. I'm working on running ...
- 05:37 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
- Great news! I've ran the regression tests and all tests passed successfully.
- 10:30 AM Base Language Bug #8119 (Review): JavaDoc build task produces more warnings in Windows in comparison to Linux
- 10:30 AM Base Language Bug #8119 (WIP): JavaDoc build task produces more warnings in Windows in comparison to Linux
- 8119a r14874,14875: Option added to javadoc task to show all warnings.
- 09:15 AM Base Language Bug #8119: JavaDoc build task produces more warnings in Windows in comparison to Linux
- @ant@ automatically picks up any @-D@ options on the command line and turns them into properties that can be referenc...
- 09:08 AM Base Language Bug #8119: JavaDoc build task produces more warnings in Windows in comparison to Linux
- Once upon a time I got a project with configured linter that wasn't used. I enabled a test plan in the CI/CD for each...
- 08:57 AM Base Language Bug #8119: JavaDoc build task produces more warnings in Windows in comparison to Linux
- > So do we want to open the Pandora box?
No, but I do want to have a @-D@ option that we can use to enable it. Ma... - 02:12 AM Base Language Bug #8119: JavaDoc build task produces more warnings in Windows in comparison to Linux
- Here it is: The same output with @-Xdoclint:all@. So do we want to open the Pandora box?
- 10:19 AM Deployment Support #3303: make the automated deployment process fully production ready
- May I suggest Docker should be the main basis for the build and runtime roles? This would allow us to pull "code" fro...
- 10:07 AM Database Feature #6720: lazy hydration
- Adapted 6720b according to the row structure architecture. Continuing with testing and tracking.
- 09:29 AM Base Language Bug #8116: SEARCH vs FILE-INFO
- I like the idea.
- 07:13 AM Base Language Bug #8116: SEARCH vs FILE-INFO
- Vladimir Tsichevski wrote:
> The only difference I can recall is that the client configuration cannot be set from co... - 06:46 AM Base Language Bug #8116: SEARCH vs FILE-INFO
- Eugenie Lyzenko wrote:
> From application point of view the @PROPATH/SEARACHPATH@ should be @,@ separated. But in a ... - 08:05 AM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
- Ovidiu Maxiniuc wrote:
> Roger,
> Please update to latest 4922b. There are two issues fixed, which in fact, were pr... - 08:16 PM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
- Roger,
Please update to latest 4922b. There are two issues fixed, which in fact, were present in trunk:
* changing ... - 02:34 AM Runtime Infrastructure Bug #7589: org.slf4j.impl.StaticLoggerBinder when deploying p2j.jar in tomcat
- This is the type of warnings displayed when no slf4j imp present for the client:...
- 02:13 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
- Waiting for feedback from Eric and Ovidiu #7884-32, #7884-42 and #7884-44.
12/13/2023
- 04:30 PM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
- Greg Shah wrote:
> It is clear there is a regression that needs to be fixed here.
Well... not really. The culprit... - 03:51 PM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
- It is clear there is a regression that needs to be fixed here.
- 03:49 PM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
- Just want to log the *reservation.d* processing from non-4722b:...
- 02:11 PM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
- Greg Shah wrote:
> I'd like to get this into trunk. What is the effort to make this safe?
If Ovidiu could verify... - 06:59 AM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
- I'd like to get this into trunk. What is the effort to make this safe?
- 10:55 AM Database Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
- Done. Branch 7416b was merged into trunk as rev. 14872 and archived.
- 10:10 AM Database Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
- Greg Shah wrote:
> You can go ahead.
I'll quickly rebase the branch and then proceed with the merging.
- 10:03 AM Database Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
- You can go ahead.
- 06:31 AM Database Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
- After re-running the performance tests for both the baseline and the changed version, I got the following result:
* ... - 04:23 AM Database Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
- Radu Apetrii wrote:
> Alexandru Lungu wrote:
> > Radu, first "batch" of logging refactoring didn't show any downgra... - 10:49 AM Base Language Bug #8119: JavaDoc build task produces more warnings in Windows in comparison to Linux
- I don't know of a way to make OpenJDK show them. I'd be glad to see them (as long as it was optional) because to fin...
- 10:30 AM Base Language Bug #8119: JavaDoc build task produces more warnings in Windows in comparison to Linux
- Yes, it's Oracle. This explains it.
But the Oracle ones are valid issues. Can we somehow make Open JDK show them, ... - 10:15 AM Base Language Bug #8119: JavaDoc build task produces more warnings in Windows in comparison to Linux
- Could you be building on Windows using the Oracle JDK? The Oracle JDK generates a ver long list of javadoc errors as...
- 09:19 AM Base Language Bug #8119: JavaDoc build task produces more warnings in Windows in comparison to Linux
- @./gradlew ant-javadoc@ build task produces more warnings in Windows in comparison to Linux.
- 09:16 AM Base Language Bug #8119 (Closed): JavaDoc build task produces more warnings in Windows in comparison to Linux
- 10:08 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
- Alexandru Lungu wrote:
> It is normal to have 18-21 tests failed on that regression tests.
>
> As of my understan... - 09:52 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
- I ran the #7669-1 test and one of the users failed during the run 75 due to a @StaleRecordException@. I am running 71...
- 09:06 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
- It is normal to have 18-21 tests failed on that regression tests.
As of my understanding: if ETF passes, only ChUI... - 09:01 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
- I finished testing a customer application with 7156b and 6649b and got between 18 (first run) and 21 (seconds run) te...
- 08:02 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
- Rebased 6649b to latest trunk. It is now at rev. 14886.
Constantin, you can start the ETF tests. These tests are n... - 07:46 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
- Danut, I am planning to do rebase of 6649b to the latest trunk now.
- 06:48 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
- Alexandru Lungu wrote:
> Danut, lets focus merging this by EOD. What testing is left?
Currently fixed the import.db... - 06:46 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
- Alexandru Lungu wrote:
> Danut, lets focus merging this by EOD. What testing is left?
Are all changes in 6649? I ca... - 06:45 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
- Danut, lets focus merging this by EOD. What testing is left?
- 09:38 AM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
- Committed on 7045b, revision 14837.
This change requires reconversion. 4gl constructs like @for tt@, should be con... - 08:27 AM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
- I discussed with Eduard and it seems that the problem is that we have @forBlock(P2JQuery, int, String, Block)@, but w...
- 09:03 AM Base Language Bug #8116: SEARCH vs FILE-INFO
- Greg Shah wrote:
> Vladimir can also help here regarding the specifics of our ABLUnit support. It is slightly diffe... - 08:58 AM Base Language Bug #8116: SEARCH vs FILE-INFO
- From application point of view the @PROPATH/SEARACHPATH@ should be @,@ separated. But in a real application the separ...
- 08:53 AM Base Language Bug #8116: SEARCH vs FILE-INFO
- Vladimir can also help here regarding the specifics of our ABLUnit support. It is slightly different because of the ...
- 08:51 AM Base Language Bug #8116: SEARCH vs FILE-INFO
- I'll make a couple of quick points and then Eugenie will take it from there.
1. Your use case should be supported ... - 08:53 AM Base Language Feature #4392: add -pf support for appserver CONNECT() method
- 4392a r14868 Ready for review. Fixing the remote @FileStream@ by adding a flag to determine if the file is supposed t...
- 06:11 AM Base Language Feature #4392: add -pf support for appserver CONNECT() method
- A note: Even with @StreamFactory@ it's not always the client filesystem, but depends on the directory config @server-...
- 01:39 AM Base Language Feature #4392: add -pf support for appserver CONNECT() method
- I'll add a flag to handle both cases. By default it will be the old logic, since we can't pinpoint where it's used. A...
- 08:26 PM Base Language Feature #4392: add -pf support for appserver CONNECT() method
- Constantin Asofiei wrote:
> Ovidiu, please see previous note - do you recall why that was added?
I remember the mom... - 07:07 AM Deployment Support #3303: make the automated deployment process fully production ready
- I generally like this. Let's consider the idea that roles can be additive. By splitting these into "lego blocks" we...
- 06:43 AM Build and Source Control Support #5167: using static linking to eliminate the need to patch the system-wide ncurses
- We can leave them.
- 06:40 AM Base Language Bug #8084 (Review): refactor the 'execute' method for legacy classes
- The changes for this and #8069 are in 8084a rev 14873. Please review.
- 05:37 AM Runtime Infrastructure Bug #7589: org.slf4j.impl.StaticLoggerBinder when deploying p2j.jar in tomcat
- 7589b r14868: adds FWD's slf4j implementation to the classpath of both the temp JVM created by the spawner and the sp...
12/12/2023
- 06:33 PM Deployment Support #3303: make the automated deployment process fully production ready
- Greg Shah wrote:
> The playbooks are 3 years old, were never 100% complete and we never got local execution running ... - 06:22 PM Deployment Support #3303: make the automated deployment process fully production ready
- Branch 3303 was created from trunk_14870. I checked in an update to allow for locales to be included in the convert a...
- 06:17 PM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
- Branch 4722b was rebased to trunk_14870 and is at revision 14874.
- 05:43 PM Build and Source Control Support #5167: using static linking to eliminate the need to patch the system-wide ncurses
- Updated the "wiki":/projects/p2j/wiki/Patching_NCURSES_Using_Static_Linking. Should the older versions be removed? I ...
- 05:19 PM Build and Source Control Support #5167: using static linking to eliminate the need to patch the system-wide ncurses
- Yes
- 05:18 PM Build and Source Control Support #5167: using static linking to eliminate the need to patch the system-wide ncurses
- Greg Shah wrote:
> Then how do we provide a newer version outside of the standard workstation?
I'm not sure. Is t... - 02:31 PM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
- Alexandru Lungu wrote:
> Danut, is it possible to test 6649b without reconverting? This should theoretically run wit... - 11:18 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
- Danut, is it possible to test 6649b without reconverting? This should theoretically run with no problem and build up ...
- 07:04 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
- The results of the POC test are in :)
|_. |_. Baseline (4 cold tests avg) |_. 7156b + 66... - 05:07 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
- I smoke tested a large customer application with 6649b and everything worked well. Currently running POC tests.
- 04:44 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
- Dănuț Filimon wrote:
> I addressed the review from Hynek in *6649b.rev.14879*
Code review. The changes are good.
- 03:33 AM Base Language Feature #6649 (Internal Test): improve the performance or SourceNameMapper runtime
- 03:32 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
- I addressed the review from Hynek in *6649b.rev.14879* where I added a @removeIdentifier@ method and changed the logg...
- 02:55 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
- Alexandru Lungu wrote:
> Constantin, can you run the ETF tests with 6649b once ready? Thank you.
Will do.
- 02:54 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
- Danut, please mark this as Urgent; we need to test it asap.
Thus, address the review from Hynek and lets move on w... - 11:13 AM Database Feature #6720: lazy hydration
- Branch 6720c was merged to trunk rev 14869 and archived.
Resuming work on 6720b - 10:59 AM Database Feature #6720: lazy hydration
- You can merge to trunk now.
- 10:40 AM Database Feature #6720: lazy hydration
- Completely fixed 6720c. I had some "invisible" regressions there. Also, it was quite confusing why the @AdaptiveRowSt...
- 03:37 AM Database Feature #6720: lazy hydration
- Fixed the last concerns. Committed 6720c / rev. 14848.
Redoing quick profiling and regression tests now for 6720c... - 11:07 AM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
- Eduard, there is an API issue we have on BlockManager. I think the rewriting of the BlockManager API to include the q...
- 03:55 AM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
- Committed on 7045b, revision 14836.
- removed @handleQueryOffEnd@ method from QueryWrapper and all of its usage.
- ... - 02:58 AM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
- Eduard, please address the latest suggestions and commit to 7045b.
Lets redo the whole testing process with this l... - 09:09 AM Base Language Feature #4392: add -pf support for appserver CONNECT() method
- > By the way @-pf@ for DB connect uses @new File()@. Is it acceptable there?
No. That is not OK there either. - 02:37 AM Base Language Feature #4392: add -pf support for appserver CONNECT() method
- Constantin Asofiei wrote:
> Galya B wrote:
> > By the way @-pf@ for DB connect uses @new File()@. Is it acceptable ... - 02:17 AM Base Language Feature #4392: add -pf support for appserver CONNECT() method
- Galya B wrote:
> By the way @-pf@ for DB connect uses @new File()@. Is it acceptable there?
You mean the code in @C... - 01:48 AM Base Language Feature #4392: add -pf support for appserver CONNECT() method
- Ovidiu, please see previous note - do you recall why that was added?
- 01:44 AM Base Language Feature #4392: add -pf support for appserver CONNECT() method
- I've found the issue with the remote stream:
@FileStream@:... - 12:47 AM Base Language Feature #4392: add -pf support for appserver CONNECT() method
- Greg Shah wrote:
> Code Review Task Branch 4392a Revisions 14865 and 14866
>
> I did a quick review. The primary... - 12:45 AM Base Language Feature #4392: add -pf support for appserver CONNECT() method
- Greg Shah wrote:
> Code Review Task Branch 4392a Revisions 14865 and 14866
>
> I did a quick review. The primary... - 08:16 AM Base Language Bug #8116: SEARCH vs FILE-INFO
- Although there is this slight difference in FWD implementation my issue seems to come from invalid @PROPATH@ settings...
- 04:19 AM Base Language Bug #8116: SEARCH vs FILE-INFO
- When using @SEARCH@ using relative path in 4GL the file is looked-up in all @PROPATH@ entries and if found the full-p...
- 04:19 AM Base Language Bug #8116 (New): SEARCH vs FILE-INFO
12/11/2023
- 03:56 PM Base Language Feature #4392: add -pf support for appserver CONNECT() method
- Some other notes, beside what Greg mentioned:
# does @-pf@ overwrite only the preceding options (the one which appea... - 03:10 PM Base Language Feature #4392: add -pf support for appserver CONNECT() method
- Constantin: Please review.
- 03:10 PM Base Language Feature #4392: add -pf support for appserver CONNECT() method
- Code Review Task Branch 4392a Revisions 14865 and 14866
I did a quick review. The primary issue I see is that the... - 10:12 AM Base Language Feature #4392: add -pf support for appserver CONNECT() method
- ...and r14866 for the file header.
- 10:07 AM Base Language Feature #4392 (Review): add -pf support for appserver CONNECT() method
- 4392a r14865 ready for review.
Fixes the connect param "-pf" for servers. The code wasn't completed and was throwi... - 01:19 PM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
- Code review 6649b revision 14878.
@MonitorRunnable.identifiers@ are never cleared. Shouldn't an entry be removed, ... - 12:13 PM Database Feature #6720: lazy hydration
- I am glad you already tested the implementation and you found no regressions. I re-analysed the iterator from @Ordere...
- 06:02 AM Database Feature #6720: lazy hydration
- Committed 6720c/14847 including the suggestions you made.
* Regarding @fieldCnt@, it should have been 1 to short ... - 11:30 AM User Interface Bug #7824: Simplify idle connection settings and apply the default configuration for the web clie...
- Sergey Ivanovskiy wrote:
> Please review the committed revision 14868 (7824a).
Code review.
According to the j... - 06:34 AM User Interface Bug #7824: Simplify idle connection settings and apply the default configuration for the web clie...
- Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> > We can change the code of @WebClientsManager@ for the case when ... - 03:15 AM Base Language Feature #6417: cleanup some known items in appserver support
- > * versioninfo fields are read-only, but writing them is a runtime error and not compile error in FWD.
This one see... - 02:12 AM Database Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
- Alexandru Lungu wrote:
> Radu, first "batch" of logging refactoring didn't show any downgrade. I didn't expect to se... - 02:08 AM Database Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
- Eric Faulhaber wrote:
> Are you saying there is a 3.5% penalty when the implementation is passive, or when it is act...
12/08/2023
- 04:34 PM Database Feature #6720: lazy hydration
- Alexandru, sorry for the delay. The size and the nature of changes (class tree, virtual methods) required ore time th...
- 12:06 PM Database Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
- The original implementation (when Hibernate was involved) had a very high overhead. I don't know the exact number, bu...
- 09:35 AM Database Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
- Greg Shah wrote:
> > The tests show a ~3.5% decrease in performance.
>
> No, we can't move ahead with this.
Ra... - 09:16 AM Database Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
- > The tests show a ~3.5% decrease in performance.
No, we can't move ahead with this. - 08:47 AM Database Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
- Alexandru Lungu wrote:
> large customer application smoke tests
Done. Worked without any issue in all cases (sql lo... - 09:49 AM User Interface Bug #7824: Simplify idle connection settings and apply the default configuration for the web clie...
- Sergey Ivanovskiy wrote:
> We can change the code of @WebClientsManager@ for the case when agent range is not config... - 09:47 AM User Interface Bug #7824: Simplify idle connection settings and apply the default configuration for the web clie...
- Sergey Ivanovskiy wrote:
> At this moment the debug mode is not enabled if the agent range is not configured. For th... - 08:43 AM User Interface Bug #7824: Simplify idle connection settings and apply the default configuration for the web clie...
- Sergey Ivanovskiy wrote:
> These web client settings (under @webClient@ node)
> [...]
> are set automatically for... - 07:22 AM User Interface Bug #7824: Simplify idle connection settings and apply the default configuration for the web clie...
- We can change the code of @WebClientsManager@ for the case when agent range is not configured but the @jvmArgs@ is gi...
- 07:10 AM User Interface Bug #7824: Simplify idle connection settings and apply the default configuration for the web clie...
- The agent range is common for the debugger and jmx agents so jvmArgs just describes jmx and/or debug agents should be...
- 07:06 AM User Interface Bug #7824: Simplify idle connection settings and apply the default configuration for the web clie...
- At this moment the debug mode is not enabled if the agent range is not configured. For the known application there ar...
- 06:48 AM User Interface Bug #7824: Simplify idle connection settings and apply the default configuration for the web clie...
- Sergey Ivanovskiy wrote:
> The agent port is assigned by @WebClientManager@ that reads @jvmArgs@ option in the direc... - 06:31 AM User Interface Bug #7824: Simplify idle connection settings and apply the default configuration for the web clie...
- Hynek Cihlar wrote:
> Code review 7824a revisions 14862..14867.
>
> I may be misinterpreting the changes, but I d... - 05:05 AM User Interface Bug #7824: Simplify idle connection settings and apply the default configuration for the web clie...
- Hynek Cihlar wrote:
> Code review 7824a revisions 14862..14867.
>
> I may be misinterpreting the changes, but I d... - 05:04 AM User Interface Bug #7824: Simplify idle connection settings and apply the default configuration for the web clie...
- Code review 7824a revisions 14862..14867.
I may be misinterpreting the changes, but I don't see how the debug mode... - 02:46 AM User Interface Bug #7824: Simplify idle connection settings and apply the default configuration for the web clie...
- These web client settings (under @webClient@ node) ...
- 02:16 AM User Interface Bug #7824: Simplify idle connection settings and apply the default configuration for the web clie...
- This is what was changed in this task in one patch.
- 02:13 AM User Interface Bug #7824: Simplify idle connection settings and apply the default configuration for the web clie...
- Hynek, please review rev 14867 (7824a) that removed @MAX_HTTP_IDLE_TIMEOUT@ and added @CONNECTION_TIMEOUT@ and @INFIN...
- 08:38 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
- Rebased 6649b to latest trunk. 6649b is now at rev. 14878.
- 05:54 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
- *Committed 6649b/rev.14849* where I made the following changes:
- Created @MonitorRunnable@ which allows identifying... - 08:13 AM Deployment Support #3303: make the automated deployment process fully production ready
- The playbooks are 3 years old, were never 100% complete and we never got local execution running (even though we do v...
- 08:13 PM Deployment Support #3303: make the automated deployment process fully production ready
- I have been looking closer at @mgmt@ since I'd like to use it to setup a customer's VM for supporting Docker images. ...
- 07:53 AM Build and Source Control Support #5167: using static linking to eliminate the need to patch the system-wide ncurses
- Then how do we provide a newer version outside of the standard workstation?
- 07:52 AM Database Bug #8101: Issue with temp-table defined as reference-only
- This isn't likely to be a FWD issue. Don't make edits there yet. It is more likely a dependency on the 4GL code side...
- 06:40 AM Base Language Feature #6417: cleanup some known items in appserver support
- > * argument translation to remote definition type I think is done the same as the CALL statement does it...
What do...
12/07/2023
- 06:13 PM Build and Source Control Support #5167: using static linking to eliminate the need to patch the system-wide ncurses
- Greg Shah wrote:
> Is there some change in the scripts that our customers must use? If so, then it is a FWD issue.
... - 04:03 PM Build and Source Control Support #5167: using static linking to eliminate the need to patch the system-wide ncurses
- Is there some change in the scripts that our customers must use? If so, then it is a FWD issue.
If this is just s... - 03:56 PM Build and Source Control Support #5167: using static linking to eliminate the need to patch the system-wide ncurses
- Greg Shah wrote:
> Is this something for the standard workstation or is it a FWD issue? You are posting in a task a... - 03:03 PM Build and Source Control Support #5167: using static linking to eliminate the need to patch the system-wide ncurses
- Is this something for the standard workstation or is it a FWD issue? You are posting in a task about FWD, but your c...
- 06:08 PM Database Bug #8101: Issue with temp-table defined as reference-only
- I think I found the issue. In the @TemporaryBuffer.java@...
- 03:01 PM User Interface Bug #7824: Simplify idle connection settings and apply the default configuration for the web clie...
- Is there any documentation about the connection settings (the full set, not just the ones changed here)?
Hynek: Pl... - 12:25 PM User Interface Bug #7824: Simplify idle connection settings and apply the default configuration for the web clie...
- Could this task be reviewed? I rebased 7824a.
- 10:42 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
- Greg Shah wrote:
> Eric: Is @org.apache.commons.lang3.tuple.*@ a supported/approved library for use in persistence? ... - 10:06 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
- > I've been obedient adding the overloaded method with the logical name, but where is the java @SsoAuthenticator@ get...
- 09:55 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
- I've been obedient adding the overloaded method with the logical name, but where is the java @SsoAuthenticator@ getti...
- 09:51 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
- We're doing a default authentication for SSO login, where the customer should not know anything about the details, bu...
- 09:50 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
- Greg Shah wrote:
> Supplement to the code review: the @ldbname@ parameter must be processed case insensitively (e.g.... - 09:45 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
- Supplement to the code review: the @ldbname@ parameter must be processed case insensitively (e.g. storing/retrieving ...
- 09:20 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
- >
> > Anyway, the directory database cfgs are there for runtime usage. Any usage from import is a side usage.
> >... - 09:17 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
- Greg Shah wrote:
> > > I thought I had answered this in #7884-25. We are reworking the code DB logic into sessionle... - 09:15 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
- > Such reader will need to learn to read the names of the classes and the javadoc, where it says:
My comment stand... - 09:10 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
- Greg Shah wrote:
> > > 2. The logic in @connectToDb()@ which reads configuration from the directory is also somethin... - 09:01 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
- Greg Shah wrote:
> Galya B wrote:
> > Greg Shah wrote:
> > > > 4. There is nothing hidden. The connection is clean... - 09:00 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
- Galya B wrote:
> Greg Shah wrote:
> > > 4. There is nothing hidden. The connection is cleaned up on JVM shutdown.
... - 08:58 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
- > > I thought I had answered this in #7884-25. We are reworking the code DB logic into sessionless code that is in F...
- 08:55 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
- > 2. Is it better to create a DB connection on each login attempt in a live system?
This was a retorical question. - 08:54 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
- Greg Shah wrote:
> > 4. There is nothing hidden. The connection is cleaned up on JVM shutdown.
>
> I mean it is a... - 08:52 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
- > 1. It's expected to be only one connection.
Per database instance. This may be many connections to a given clus... - 08:50 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
- Greg Shah wrote:
> I thought I had answered this in #7884-25. We are reworking the code DB logic into sessionless c... - 08:49 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
- > > 2. The logic in @connectToDb()@ which reads configuration from the directory is also something that should not be...
- 08:40 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
- Galya B wrote:
> Greg Shah wrote:
> > Code Review Task Branch 7884a Revision 14843
> >
> > 1. I think the logic ... - 08:24 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
- Greg Shah wrote:
> 3. I don't think it is a good idea to implement long lived connections to the database here, nor ... - 08:18 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
- Greg Shah wrote:
> 2. The logic in @connectToDb()@ which reads configuration from the directory is also something th... - 08:15 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
- Greg Shah wrote:
> Code Review Task Branch 7884a Revision 14843
>
> 1. I think the logic for obtaining the defaul... - 07:27 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
- Code Review Task Branch 7884a Revision 14843
1. I think the logic for obtaining the default database name (@Databa... - 07:21 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
- Eric: Is @org.apache.commons.lang3.tuple.*@ a supported/approved library for use in persistence? I see it used there...
- 07:06 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
- r14843: @setuserid(userid, password, ldbname)@.
- 06:45 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
- It will optionally be present in the original 4GL code. There are 2 forms:
* @setuserid(userid, password)@
* @se... - 02:26 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
- Greg Shah wrote:
> My primary concern is that we don't support the @ldbname@ parameter variant of @setuserid()@. I ... - 02:22 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
- Ovidiu Maxiniuc wrote:
> For the second part. Provided the @ldbname@, the database configuration from registry can b... - 09:23 PM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
- I reviewed the changes in 7884a.
I am OK with the changes. My concerns were for:
* duplicate code;
* hardcoded t... - 08:53 AM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
- Alexandru Lungu wrote:
> Regarding your last comment: it depends upon the delegate right? If the delegate is not len... - 08:40 AM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
- Eduard, I started converting a really large application with 7045b (on top of 7156b). You have 3 days left to do the ...
- 08:34 AM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
- I think is not needed, as @QueryWrapper@ is used in conversion of @open query@ statement. And in this case QQE is not...
- 08:04 AM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
- Alexandru, I haven't looked at the full code, but is the @QueryWrapper.handleQueryOffEnd@ still needed?
- 08:34 AM Database Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
- Radu Apetrii wrote:
> I'm starting the rebase now. I'll update you when it is done so we can both do the tests.
Don... - 08:13 AM Database Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
- I'm starting the rebase now. I'll update you when it is done so we can both do the tests.
- 08:07 AM Database Feature #7416 (Internal Test): Reiterate DatabaseStatistics and leverage to other database profli...
- Lets move this into Internal Test and have it completely tested and merged. Even if these are refactorings, we still ...
- 07:08 AM Base Language Feature #6417 (WIP): cleanup some known items in appserver support
- 06:28 AM Database Feature #6496: add equivalent support for -trig command line option
- Rebased 6496a to latest trunk. 6496a is now at rev. 14869
Alexandru [ad], please review @StartupParameters@ as there... - 04:08 AM Database Feature #6496: add equivalent support for -trig command line option
- Commited the changes requested in branch 6496a rev 14748.
Also, should I add more comments inside the methods to exp... - 08:57 PM Database Feature #6496: add equivalent support for -trig command line option
- Had an idea for local optimisation: in @DTM.getSchemaTrigger()@, @proceduresClassMap@ is used to cache the converted ...
- 02:19 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
- Eugenie Lyzenko wrote:
> In general I have no objections.
>
> But I have the question and the clear answer is ver...
12/06/2023
- 06:41 PM Build and Source Control Support #5167: using static linking to eliminate the need to patch the system-wide ncurses
- I fixed an oversite in @files/setup_ncurses6x.sh@ such that the environment wasn't being updated properly, as well as...
- 06:32 PM Database Feature #6496: add equivalent support for -trig command line option
- Review of 6496a/14743-7:
Good job. I think the code is almost ready. Just a few minor things to adjust.
* @Data... - 04:20 PM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
- Code Review Task Branch 7884a Revisions 14840 through 14842
The overall approach is reasonable. Ovidiu and Eric w... - 07:31 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
- 7884a r14842 ready for review. The dialect and conversion specifics now shared between @MetadataSecurityOps.NoSession...
- 05:23 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
- Galya, yes, @SQL_MODE_DEFAULT@ is the default if otherwise not specified in p2j.cfg.xml, as a @conversion="minimal"@ ...
- 03:40 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
- Galya B wrote:
> Is the "conversion" always @SQL_MODE_DEFAULT@. I don't see a case where @NsConfig.setConversion@ is... - 03:33 PM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
- In general I have no objections.
But I have the question and the clear answer is very important. How the custom th... - 12:56 PM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
- Eugenie/Hynek: Please review.
- 12:05 PM Deployment Support #8103: merge Hotel GUI, Hotel ChUI and implement a multi-modal template process
- It would be easier to support a single Hotel project than to maintain two separate projects. We would need to merge ...
- 12:00 PM Deployment Support #8103 (New): merge Hotel GUI, Hotel ChUI and implement a multi-modal template process
- 06:18 AM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
- Eduard, please focus on reaching a "state-of-the-art" solution for 7045b (also referring to #7045-84). Also, triple c...
- 02:00 AM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
- Alexandru Lungu wrote:
> I've run 7045b with the performance tests and got 8.168s. Comparing to the baseline of 7.95... - 05:28 AM Database Bug #8101: Issue with temp-table defined as reference-only
- An exception is thrown when @TestCodepageConversions.cls@ is executed regarding temp-tables.
Ovidiu Maxiniuc wrote... - 05:25 AM Database Bug #8101 (Closed): Issue with temp-table defined as reference-only
- 05:08 AM Database Feature #7323: Implement soft unique index in FWD-H2
- I've committed to 7323a rev. 14804-14805 some minor changes regarding:
* Fixed the validation condition in @Validati...
12/05/2023
- 11:58 AM User Interface Bug #8098: The task bar without tasks is not displayed or drawn if ui program displays a lonely d...
- The task bar is not displayed for this program...
- 09:29 AM User Interface Bug #8098 (New): The task bar without tasks is not displayed or drawn if ui program displays a lo...
- 11:01 AM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
- I am looking now in the changes of 7045b:
* Eduard, mind that you have some hard-tabs in your last commit (@Adaptive... - 09:55 AM Database Bug #8044 (Test): Fix "Failed direct-access due to Error direct accessing for finding record by u...
Branch 8044a was merged into trunk as rev. 14860 and archived.- 09:42 AM Database Bug #8044 (Merge Pending): Fix "Failed direct-access due to Error direct accessing for finding re...
- You can merge now.
- 03:33 AM Database Bug #8044 (Internal Test): Fix "Failed direct-access due to Error direct accessing for finding re...
- *Review of 8044a:*
* I am OK with the changes.
As long as you've done smoke tests with a large application and ... - 08:58 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
- Hynek Cihlar wrote:
> The logic gets more and more complex so it would be nice to be able to know how does it perfor... - 05:33 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
- Hynek Cihlar wrote:
> With the LinkedBlockingQueue on the limit, adding more tasks to the executor will cause Reject... - 05:14 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
- Dănuț Filimon wrote:
> Hynek Cihlar wrote:
> Initially the cache entry was a @Map@, but a potential leak was notice... - 03:15 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
- Hynek Cihlar wrote:
> In @createSourceCacheEntry@ the object submitted to the @mappingExecutor@ is a @Thread@, but i... - 07:37 AM User Interface Bug #8074 (Review): Preferred UI Theme not selected in web with auto-login and forked sessions
- 8074a based on trunk r14859 ready for review. Includes (in order of appearance):
* Theme options include an empty op... - 04:38 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
- A note: The path in @FallbackEnvironmentReader@ when using @Preferences@ is composed from root user node @~/.java/.us...
- 02:17 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
- Greg Shah wrote:
> > But java @Preferences@ is case-sensitive, so we can either keep the original names (envs / keys... - 06:24 AM Database Feature #6496 (Review): add equivalent support for -trig command line option
- I have commited an update to branch 6496a rev. 14747.
I saved a cache in @DatabaseTriggerManager@ to get the java cl... - 05:51 AM Base Language Bug #8008: read-json on a 1252 longchar should convert to utf-8 automatically before hydrating te...
- In this Note, I summarize the parts from #7944 which were out of scope there.
The @convert_json_1252_fcp_memptr.p@ f...
12/04/2023
- 05:02 PM Database Feature #6414 (Test): ERROR attribute for buffer, dataset and temp-table
- Committed revision 14859. The branch was archived.
- 01:38 PM Database Feature #6414: ERROR attribute for buffer, dataset and temp-table
- You can merge to trunk now.
- 12:17 PM Database Feature #6414 (Merge Pending): ERROR attribute for buffer, dataset and temp-table
- Greg, I think this is ready for merge to trunk (Ovidiu, correct me if you think otherwise).
- 12:15 PM Database Feature #6414: ERROR attribute for buffer, dataset and temp-table
- The task branch was rebased to latest trunk. The current revision is 14861.
I also test with a large customer applic... - 01:38 PM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
- > But java @Preferences@ is case-sensitive, so we can either keep the original names (envs / keys / sections), or mak...
- 12:01 PM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
- @EnvironmentDaemon@ is almost case-insensitive (check occurrences of @.toLowerCase()@). I guess it started with the r...
- 08:54 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
- Eugenie Lyzenko wrote:
> Greg Shah wrote:
> > > Also there is a problem in registry where the @base_name@ is actual... - 08:43 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
- Greg Shah wrote:
> > Also there is a problem in registry where the @base_name@ is actually not used in the native co... - 08:26 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
- Greg Shah wrote:
> Galya B wrote:
> > Actually there is another conversion issue with the example.
> >
> > It ha... - 08:20 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
- > Also there is a problem in registry where the @base_name@ is actually not used in the native code. The char is load...
- 08:18 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
- Galya B wrote:
> Actually there is another conversion issue with the example.
>
> It has @PUT-KEY-VALUE SECTION "... - 07:45 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
- Also there is a problem in registry where the @base_name@ is actually not used in the native code. The char is loaded...
- 07:30 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
- Actually there is another conversion issue with the example.
It has @PUT-KEY-VALUE SECTION "PSC\Clue\TEMP-PRGM" KE... - 06:27 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
- I'm trying to convert an example procedure from "here":https://community.progress.com/s/article/21529.
Edited: Co... - 10:47 AM Database Feature #8067: investigate adding automatically adding a FIELDS clause for simple record blocks
- This command assumes the .xml file is saved as @rules/reports/fields.xml@ and included in a p2j.jar build:...
- 10:25 AM Database Feature #8067 (WIP): investigate adding automatically adding a FIELDS clause for simple record bl...
- Constantin, can you provide some guidance on how to run your rule-set against a large customer application without ac...
- 10:38 AM Base Language Feature #7045 (Internal Test): re-implement "normal" (non-abend) stack unwinding to avoid throwin...
- I've run 7045b with the performance tests and got 8.168s. Comparing to the baseline of 7.958s, this is +2.5% slower. ...
- 05:54 AM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
- Committed on 7045b, revision 14835.
I tested @uast/query_off_end/qoe_exception@ , did not see any regressions. In ... - 03:47 AM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
- Eduard, please address the review and commit a final solution to 7045b (including javadoc / history entries / etc.) a...
- 03:07 AM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
- Eric Faulhaber wrote:
> I have noted the discussion above that @QOEE@ is not yet fully eliminated. I see this, for i... - 09:13 AM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
- Branch 4722b was rebased to trunk_14857 and is at revision 14861.
- 04:14 AM Database Feature #6720: lazy hydration
- Ovidiu Maxiniuc wrote:
> I grabbed 6720c and looked at the latest changes. Indeed, I do not see a reason for a chang... - 03:25 AM Base Language Bug #7460: implement Progress.Lang.Class:getMethods
- 6410b rev 14828 was rebased from trunk rev 14856 - new rev 14860
- 03:19 AM Base Language Bug #7460: implement Progress.Lang.Class:getMethods
- Constantin Asofiei wrote:
> Yes, I'll need to rebase. Are all changes in 6410b?
I have some local changes but no... - 03:00 AM Base Language Bug #7460: implement Progress.Lang.Class:getMethods
- Yes, I'll need to rebase. Are all changes in 6410b?
- 02:50 AM Base Language Bug #7460: implement Progress.Lang.Class:getMethods
- Constantin Asofiei wrote:
> Created task branch 7460a from trunk rev 14850.
>
> 7460a rev 14851 has a regression ... - 03:24 AM Base Language Feature #6410: implement additional built-in OO classes/interfaces
- 6410b rev 14828 was rebased from trunk rev 14856 - new rev 14860
- 02:52 AM User Interface Feature #4203 (Test): expose some web-client details as 4GL global variables
- 4203a was merged to trunk as rev. 14856 and archived.
12/03/2023
- 09:39 AM User Interface Bug #8095: LEAVE trigger fires in no focus change situation
- In the following code, a @FILL-IN@ is created in its own frame, and three @ON LEAVE@ triggers are attached to the @FI...
- 08:07 AM User Interface Bug #8095 (New): LEAVE trigger fires in no focus change situation
12/02/2023
- 03:36 PM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
- Code review 6649b revisions 14840..14847.
In @createSourceCacheEntry@ the object submitted to the @mappingExecutor...
12/01/2023
- 10:08 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
- > > > Indeed, the use of @setuserid@ is very common.
> > As far as I understand @setuserid@ is a common DB authent... - 04:07 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
- Is the "conversion" always @SQL_MODE_DEFAULT@. I don't see a case where @NsConfig.setConversion@ is used.
- 10:00 AM User Interface Feature #4203 (Merge Pending): expose some web-client details as 4GL global variables
- 02:08 AM User Interface Feature #4203: expose some web-client details as 4GL global variables
- I've tested with testcases all types of drivers. The procedure I used is a simple @message FWD-CLIENT-DRIVER@. I also...
- 09:13 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
- My bad. The enhanced configs for all users are stored in directory, so this is not in conflict with isolating the use...
- 06:00 AM Base Language Bug #8084 (WIP): refactor the 'execute' method for legacy classes
- Created task branch 8084a from trunk rev 14853
11/30/2023
- 01:53 PM Base Language Bug #7460: implement Progress.Lang.Class:getMethods
- Branch 7460a was merged into trunk as rev. 14851 and archived.
- 01:38 PM Base Language Bug #7460 (Merge Pending): implement Progress.Lang.Class:getMethods
- Code Review Task Branch 7460a Revisions 14850 and 14851
No objections. - 12:52 PM Base Language Bug #7460: implement Progress.Lang.Class:getMethods
- Created task branch 7460a from trunk rev 14850.
7460a rev 14851 has a regression fix: Do not use 'TypeFactory.obje... - 01:53 PM Runtime Infrastructure Bug #7589: org.slf4j.impl.StaticLoggerBinder when deploying p2j.jar in tomcat
- Code Review fix-spawner-classpath.diff
I'm fine with the changes.
How have they been tested? - 12:56 PM User Interface Feature #4203 (Internal Test): expose some web-client details as 4GL global variables
- Code Review Task Branch 4203a Revision 14851
The changes are good. - 09:09 AM User Interface Feature #4203 (Review): expose some web-client details as 4GL global variables
- 4203a r14851 based on trunk r14850 ready for review. Implements @FWD-CLIENT-DRIVER@, adds short readable names to dri...
- 08:28 AM User Interface Feature #4203: expose some web-client details as 4GL global variables
- Greg Shah wrote:
> The value should be added to @ClientParameters@ at startup so that it is always available at the ... - 08:23 AM User Interface Feature #4203 (WIP): expose some web-client details as 4GL global variables
- 08:18 AM User Interface Feature #4203: expose some web-client details as 4GL global variables
- The value should be added to @ClientParameters@ at startup so that it is always available at the server (without the ...
- 08:32 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
- Greg Shah wrote:
> > There are only two solutions: either we "degrade" the functionality by removing both options, o... - 08:18 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
- > > Anything that targets more than the current user must (by definition) be stored in the directory, not in user-spe...
- 01:40 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
- Greg Shah wrote:
> What changes are needed in @SsoAuthenticator@ to provide the @storageId@?
It is present in the i... - 10:21 PM Database Feature #6720: lazy hydration
- I grabbed 6720c and looked at the latest changes. Indeed, I do not see a reason for a change in performance. The hydr...
11/29/2023
- 03:32 PM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
- The value should be added to @ClientParameters@ at startup so that it is always available at the server (without the ...
- 03:05 PM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
- > I'm working on isolating the users in the client storage, but I forgot that the enhanced browse configs can be appl...
- 03:04 PM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
- > Since we probably don't have enough control over the customer behavior, then the solution I propose is to always in...
- 03:12 PM User Interface Feature #4203: expose some web-client details as 4GL global variables
- > May I ask if the IPs will be used for licensing in 4GL? Because I would hope, since the IPs (the external one and t...
- 11:56 AM Database Bug #7113: Problem with nested CAN-FIND conversion
- Eric Faulhaber wrote:
> Ovidiu, 7259a was merged to trunk some time ago. Did it fix this issue?
7259a contained cha... - 11:10 AM Database Bug #7113: Problem with nested CAN-FIND conversion
- Ovidiu, 7259a was merged to trunk some time ago. Did it fix this issue? If not, are the changes in 7113a needed?
- 10:59 AM Database Bug #6812 (Internal Test): fix FastFindCache to use a shared instance per persistent database
- Constantin, does it make sense to regression test this with the large POC?
- 08:59 AM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
- I am addressing some regression on running POC. But I think, I am close to find the problem causing this regression. ...
- 08:35 AM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
- Eduard, please make an update on your status of running the POC with your changes and addressing Eric's #7045-77.
- 07:45 AM Database Feature #6720: lazy hydration
- Ovidiu, I finished the implementation completely and tested it over a large POC. However, I created a separate branch...
- 05:37 AM Database Bug #7138: Short circuit fake-update (update with a new value eqaul to the old value) in H2
- After running a large POC with *7156b/rev.14846* (which uses *FWD-H2/rev.33*) and the changes from *7138a_h2/rev.24 -...
- 03:57 AM Runtime Infrastructure Bug #7589: org.slf4j.impl.StaticLoggerBinder when deploying p2j.jar in tomcat
- The JVM spawned from @/opt/spawner/spawn@ now doesn't have our slf4j implementation and doesn't produce logs for @Cen...
- 03:31 AM Database Bug #8030 (Test): unique index violation when creating a record in two sessions
- 12:36 AM Database Bug #8030: unique index violation when creating a record in two sessions
- Code review 8030a/14829-14830:
The logic changes look fine to me. For clarity, I did change the name of the method... - 02:02 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
- Ovidiu Maxiniuc wrote:
> Just a small observation: at line 406 in @MetadataSecurityOps@, @SecurityOps._encode(String...
11/28/2023
- 04:29 PM Database Feature #6496: add equivalent support for -trig command line option
- The (schema-)triggers are context specific because the @propath@ is context specific (@EnvironmentOps.getSearchPath()...
- 08:54 AM Database Feature #6496: add equivalent support for -trig command line option
- Are the trigger defs already context-specific? If so, let's avoid the map lookup.
- 03:03 PM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
- Review of 7884a, r14840.
The new code in @MetadataSecurityOps.java@ is well written. Just a small observation: at ... - 12:15 PM Database Bug #8030: unique index violation when creating a record in two sessions
- Eric Faulhaber wrote:
> Yes, please do.
Sorry, I misread your note. I'll review... - 11:31 AM Database Bug #8030: unique index violation when creating a record in two sessions
- Yes, please do.
- 11:21 AM Database Bug #8030: unique index violation when creating a record in two sessions
- AFAIK, everything is done on 8030a (including MariaDB - I discussed with Danut and the issue in #8030-1 is no longer ...
- 11:16 AM Database Bug #8030: unique index violation when creating a record in two sessions
- Dănuț Filimon wrote:
> *Committed 8030a/rev.14830*. Modified @RecordBuffer.reportValidationException@.
>
> Alexan... - 03:11 AM Database Bug #8030 (Review): unique index violation when creating a record in two sessions
- *Committed 8030a/rev.14830*. Modified @RecordBuffer.reportValidationException@.
Alexandru, the example provided di... - 10:19 AM Database Bug #7138: Short circuit fake-update (update with a new value eqaul to the old value) in H2
- Yes, please go ahead.
- 08:35 AM Database Bug #7138 (Review): Short circuit fake-update (update with a new value eqaul to the old value) in H2
- Branch 7454a was previously merged into trunk as rev. 14833. Alexandru, should I run the POC tests for this task befo...
- 09:43 AM Database Bug #7731: performance improvements for FQLPreprocessor
- [[p2j:Database Configuration#Cache-Sizes]] was updated with the necessary information for configuring the cache size ...
- 09:37 AM Database Bug #7731 (Test): performance improvements for FQLPreprocessor
- Branch 7731a was merged into trunk as rev. 14844 and archived.
- 09:14 AM Database Bug #7731: performance improvements for FQLPreprocessor
- You can merge now.
- 09:20 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
- I ran a large POC with *7156b/rev.14846* and the changes from *6649b/rev.14835 - 14847* and obtained good results (th...
- 05:50 AM Base Language Feature #6649 (Review): improve the performance or SourceNameMapper runtime
- *Committed 6649b/rev.14847* which solves the problem mentioned in #6649-144. By not keeping the thread idle, the corr...
- 08:09 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
- I'm working on isolating the users in the client storage, but I forgot that the enhanced browse configs can be applie...
- 08:02 AM Database Feature #7323: Implement soft unique index in FWD-H2
- Alexandru Lungu wrote:
> Radu, can you check if we are still hitting @validateUniqueByQuery@ for _temp? If so, how m... - 06:46 AM Database Feature #7323: Implement soft unique index in FWD-H2
- Radu, can you check if we are still hitting @validateUniqueByQuery@ for _temp? If so, how many times do we actually b...
- 06:38 AM Database Feature #7323: Implement soft unique index in FWD-H2
- I finished running the performance tests and the results are not very encouraging:
* 7323a rev. 14801 (*before* the ... - 03:49 AM Base Language Bug #8084: refactor the 'execute' method for legacy classes
- Oh right, this makes sense - getting rid of the @BlockManager@ API. This way we avoid doing @ProcedureManager@ work.
- 03:31 AM Base Language Bug #8084: refactor the 'execute' method for legacy classes
- What I meant is to emit all the code (like buffer scopes) directly in the Java method, and do not enclose it in @Bloc...
- 03:29 AM Base Language Bug #8084: refactor the 'execute' method for legacy classes
- Contantin, just a question here: I thought we open scopes in @externalProcedure@ due to the fact that we are aware *o...
11/27/2023
- 04:50 PM Database Feature #6496: add equivalent support for -trig command line option
- Most likely, not. A context-level map should do it. The only think that is missing is the invalidate event, when the ...
- 08:08 AM Database Feature #6496: add equivalent support for -trig command line option
- Ovidiu: Is it difficult for us to cache the results at the trigger definition? If not, I'd prefer that over the idea...
- 04:39 PM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
- My last commit does not change business code in @ImportWorker@, just the logs are more verbose.
I had a look at th... - 11:12 AM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
- Roger Borrello wrote:
> This does not happen with trunk, so something in this branch is causing H2 word tables to be... - 10:59 AM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
- Roger Borrello wrote:
> Ovidiu, when I run @ant import.db@ using the H2 database, it is trying to import into the *r... - 10:42 AM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
- Ovidiu, when I run @ant import.db@ using the H2 database, it is trying to import into the *reservation__guest* table....
- 02:28 PM Base Language Bug #8084: refactor the 'execute' method for legacy classes
- Currently, each legacy class has a synthetic 'execute' instance method which includes initialization like instance-le...
- 02:23 PM Base Language Bug #8084 (Test): refactor the 'execute' method for legacy classes
- 11:52 AM Database Bug #7731 (Merge Pending): performance improvements for FQLPreprocessor
- This can merge to trunk after 7669a.
- 07:35 AM Database Bug #7731: performance improvements for FQLPreprocessor
- I think the changes are OK. I've tested with a large POC performance run, and there was a visible improvement.
- 10:15 AM Database Bug #8030: unique index violation when creating a record in two sessions
- Danut, please move this into Review once you finish the implementation so we can move on with the review part. There ...
- 09:23 AM Database Bug #8030: unique index violation when creating a record in two sessions
- I can't recall exactly. We have some changes in #7323 that was doing the cause unwrapping for FWD-H2 *exactly* becaus...
- 09:20 AM Database Bug #8030: unique index violation when creating a record in two sessions
- Alexandru, in what case is required to unwrap the cause for P2JH2Dialect? I'll need a bit more context to adjust the ...
- 09:04 AM Database Bug #8030: unique index violation when creating a record in two sessions
- I committed the fix for #8030-3 in *8030a/rev.14829*, currently investigating @RecordBuffer.reportValidationException@.
- 05:56 AM Database Bug #8030: unique index violation when creating a record in two sessions
- I managed to reproduce the issue after fixing a configuration issue in @build_db.xml@. Working on it right now.
- 04:43 AM Database Bug #8030: unique index violation when creating a record in two sessions
- Danut, can you re-attempt to recreate this and fix? Please do some debugging to see where you are failing into recrea...
- 10:14 AM Database Feature #7323: Implement soft unique index in FWD-H2
- Theoretically yes. Practically, the flag will only take affect if there are violations. We need to check on our large...
- 10:04 AM Database Feature #7323: Implement soft unique index in FWD-H2
- I've addressed the review points and committed to 7323a rev. 14802-14803. Right now I'm running the performance tests...
- 08:24 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
- Ovidiu: Please review. Consider if there is any common code that can be shared with the existing session-based @setu...
- 04:59 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
- If we want to support multiple users in one browser, then the theme drop-down on the login page should never have a p...
Also available in: Atom