Activity

From 12/06/2023 to 01/04/2024

01/04/2024

03:56 PM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...: I had a look over 7884a/14843. I see it already uses some of the ideas I wrote above. I have only a few notes:
* I... Ovidiu Maxiniuc
03:27 PM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...: Eric Faulhaber wrote:
> Greg Shah wrote:
> > Eric: Is @org.apache.commons.lang3.tuple.*@ a supported/approved libra... Ovidiu Maxiniuc
03:01 PM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...: In #7884-32 Galya B wrote:
> Ovidiu Maxiniuc wrote:
> > For the second part. Provided the @ldbname@, the database c... Ovidiu Maxiniuc
12:26 PM Runtime Infrastructure Bug #7589: org.slf4j.impl.StaticLoggerBinder when deploying p2j.jar in tomcat: Galya B wrote:
> Roger Borrello wrote:
> > In order to achieve a level of flexibility in the Docker versions of pro... Roger Borrello
03:36 AM Runtime Infrastructure Bug #7589: org.slf4j.impl.StaticLoggerBinder when deploying p2j.jar in tomcat: Roger Borrello wrote:
> In order to achieve a level of flexibility in the Docker versions of projects, the Dockerfil... Galya B
08:46 AM User Interface Bug #8074 (Closed): Preferred UI Theme not selected in web with auto-login and forked sessions: Greg Shah
08:42 AM User Interface Bug #8074 (Test): Preferred UI Theme not selected in web with auto-login and forked sessions: 8074a was merged to trunk as rev. 14911 and archived. Galya B
08:30 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions: It can be merged to trunk now. Greg Shah
07:52 AM User Interface Bug #8074 (Merge Pending): Preferred UI Theme not selected in web with auto-login and forked sess...: Galya B wrote:
> It's been tested before the review and now I've tested the newly introduced changes - @UserPreferen... Hynek Cihlar
07:18 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions: It's been tested before the review and now I've tested the newly introduced changes - @UserPreferences@ needed some m... Galya B
03:45 AM User Interface Bug #8074 (Internal Test): Preferred UI Theme not selected in web with auto-login and forked sess...: Code review 8074a revisions 14865 and 14866. The changes are good, I have no more concerns. Do you plan any more test... Hynek Cihlar
02:20 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions: r14866 Theme without value in directory to use class name in the dropdown Galya B
02:09 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions: Hynek Cihlar wrote:
> Galya B wrote:
> > Hynek Cihlar wrote:
> > > Code review 8074a.
> > >
> > > @WebDriverHan... Galya B

01/03/2024

01:29 PM Runtime Infrastructure Bug #7589: org.slf4j.impl.StaticLoggerBinder when deploying p2j.jar in tomcat: Thanks for the explanation. In order to achieve a level of flexibility in the Docker versions of projects, the Docker... Roger Borrello
08:24 AM Runtime Infrastructure Bug #7589: org.slf4j.impl.StaticLoggerBinder when deploying p2j.jar in tomcat: Roger Borrello wrote:
> Galya B wrote:
> > If you want to introduce a related change, please take into consideratio... Galya B
08:17 AM Runtime Infrastructure Bug #7589: org.slf4j.impl.StaticLoggerBinder when deploying p2j.jar in tomcat: Galya B wrote:
> If you want to introduce a related change, please take into consideration that with 7589b @postbuil... Roger Borrello
02:25 AM Runtime Infrastructure Bug #7589: org.slf4j.impl.StaticLoggerBinder when deploying p2j.jar in tomcat: Roger Borrello wrote:
> Happy New Year!
Happy New Year!
> There were also a couple of oversights with this bra... Galya B
12:10 PM User Interface Bug #7515: FILL-IN: editing dates issues: Another minor issue:
OE: when the cursor points to a delimiter, and the user inputs the *same* delimiter character... Vladimir Tsichevski
11:25 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions: Galya B wrote:
> Hynek Cihlar wrote:
> > Code review 8074a.
> >
> > @WebDriverHandler.getAvailableThemes@ should... Hynek Cihlar
10:55 AM Base Language Feature #6417: cleanup some known items in appserver support: Galya B wrote:
> It won't help with #6417-5 that is to make clear the requirement (do we want a runtime or compile e... Constantin Asofiei
09:30 AM Base Language Feature #6417: cleanup some known items in appserver support: Constantin Asofiei wrote:
> Import these in SoapUI and see if these work. There is also a @file-cvt-list.txt.rest_a... Galya B
09:11 AM Base Language Feature #6417: cleanup some known items in appserver support: > * some errors throw by SERVER:CONNECT are not the same
Tests in @testcases/appsrv/test/connect_errors/@ are now ... Galya B
06:47 AM Base Language Feature #6417: cleanup some known items in appserver support: Galya, these are the steps to run the web tests from xfer testcases; some info is at [[p2j:Testcases#Running-Web-test... Constantin Asofiei
03:00 AM Base Language Feature #6422: implement auditing support including AUDIT-POLICY and AUDIT-CONTROL: Theodoros Theodorou wrote:
> > * @AuditDbOps@
> > ** is @meta_aud_audit_data@ hard-coded SQL name valid for all sup... Constantin Asofiei

01/02/2024

01:54 PM Runtime Infrastructure Bug #7589: org.slf4j.impl.StaticLoggerBinder when deploying p2j.jar in tomcat: Happy New Year!
I just wanted to post a "public service announcement" as this update to @postbuild.sh@ creates a ... Roger Borrello
08:12 AM Runtime Infrastructure Bug #7589 (Test): org.slf4j.impl.StaticLoggerBinder when deploying p2j.jar in tomcat: 7589b was merged to trunk as rev. 14908 and archived. Galya B
07:55 AM Runtime Infrastructure Bug #7589: org.slf4j.impl.StaticLoggerBinder when deploying p2j.jar in tomcat: You can merge now. Greg Shah
08:52 AM Base Language Feature #6422: implement auditing support including AUDIT-POLICY and AUDIT-CONTROL: > Ok. There is @/security/accounts/osusers/osuser@ and @webClient/defaultOsUser@ in @hotel_gui@. Which one should I u... Greg Shah
08:28 AM Base Language Bug #8119 (Closed): JavaDoc build task produces more warnings in Windows in comparison to Linux: Greg Shah
08:23 AM Base Language Bug #8119: JavaDoc build task produces more warnings in Windows in comparison to Linux: New param @javadoc.verbose@ added to [[p2j:Building_FWD_From_Source#Build-Properties]]. Galya B
08:11 AM Base Language Bug #8119: JavaDoc build task produces more warnings in Windows in comparison to Linux: Please add this new property to "Build Properties":/projects/p2j:Building_FWD_From_Source#Build-Properties. Greg Shah
08:05 AM Base Language Bug #8119 (Test): JavaDoc build task produces more warnings in Windows in comparison to Linux: 8119a was merged to trunk as rev. 14907 and archived. Galya B
07:56 AM Base Language Bug #8119: JavaDoc build task produces more warnings in Windows in comparison to Linux: You can merge now. Greg Shah
08:09 AM Deployment Support #3303: make the automated deployment process fully production ready: Branch 3303a was merged into trunk revision 14898 and archived. Roger Borrello

01/01/2024

05:55 PM Base Language Feature #6422: implement auditing support including AUDIT-POLICY and AUDIT-CONTROL: > * @AuditDbOps@
> ** is @meta_aud_audit_data@ hard-coded SQL name valid for all supported dialects? *Eric:* here I ... Theodoros Theodorou
09:09 AM Base Language Feature #4392: add -pf support for appserver CONNECT() method: Constantin Asofiei wrote:
> Review of 4392a rev 14868:
> * ConnectHelper - is it possible to go into an infinite re... Galya B
04:09 AM Base Language Feature #4392: add -pf support for appserver CONNECT() method: Ovidiu Maxiniuc wrote:
> Constantin Asofiei wrote:
> > * FileStream - *Ovidiu*: I understand the purpose of 'hasDup... Galya B
04:05 AM Base Language Feature #4392: add -pf support for appserver CONNECT() method: Constantin Asofiei wrote:
> * we need to fix the ConnectionManager part where it uses 'new File'
It sounds a relate... Galya B
03:57 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions: Hynek Cihlar wrote:
> Code review 8074a.
>
> @WebDriverHandler.getAvailableThemes@ should somehow handle a theme ... Galya B
03:00 AM Base Language Bug #8119: JavaDoc build task produces more warnings in Windows in comparison to Linux: Greg Shah wrote:
> Code Review Task Branch 8119a Revisions 14874 and 14875
>
> The changes are good.
>
> Pleas... Galya B
02:55 AM Runtime Infrastructure Bug #7589: org.slf4j.impl.StaticLoggerBinder when deploying p2j.jar in tomcat: Greg Shah wrote:
> Code Review Task Branch 7589b Revision 14868
>
> The changes look good. If suitable testing h... Galya B

12/28/2023

05:59 PM Base Language Feature #6422: implement auditing support including AUDIT-POLICY and AUDIT-CONTROL: Constantin Asofiei wrote:
> Review of 6422a rev 14906 (the entire code):
> * @AuditControlManager@
> ** we don't/... Theodoros Theodorou

12/25/2023

07:04 AM Database Bug #6767: Possible name clashes in DMO classes: The work redone in the branch 6767b, The branch is rebased to trunk rev. 14906 the branch revision is 14917.
Please,... Vladimir Tsichevski

12/23/2023

02:34 PM Base Language Feature #6649: improve the performance or SourceNameMapper runtime: 6649c was merged to trunk rev 14906 and archived. Constantin Asofiei
08:04 PM Base Language Feature #6649: improve the performance or SourceNameMapper runtime: Created task branch 6649c from trunk rev 14905
6649c rev 14906 fixes a race condition in SourceNameMapper propath ... Constantin Asofiei
10:40 PM Base Language Feature #4392: add -pf support for appserver CONNECT() method: Constantin Asofiei wrote:
> * FileStream - *Ovidiu*: I understand the purpose of 'hasDuplicatedLastLine' flag, but a... Ovidiu Maxiniuc

12/22/2023

03:01 PM Database Bug #6767: Possible name clashes in DMO classes: The following methods should be also renamed in addition to the methods listed in #6767-9:... Vladimir Tsichevski
12:52 PM Base Language Feature #6422 (WIP): implement auditing support including AUDIT-POLICY and AUDIT-CONTROL: Wow, I missed a lot.
Theodoros: Please address these concerns/notes. Greg Shah
12:47 PM Base Language Feature #6422 (Review): implement auditing support including AUDIT-POLICY and AUDIT-CONTROL: Review of 6422a rev 14906 (the entire code):
* @AuditControlManager@
** we don't/can't use @volatile@ for context-... Constantin Asofiei
12:47 PM Base Language Feature #6422 (Internal Test): implement auditing support including AUDIT-POLICY and AUDIT-CONTROL: Eric Faulhaber wrote:
> Some minor coding standards or format issues in @DirectoryServiceHelper@:
> * Lines 7-8 sho... Theodoros Theodorou
12:11 PM Base Language Feature #6422: implement auditing support including AUDIT-POLICY and AUDIT-CONTROL: Code Review Task Branch 6422a Revisions 14889 through 14906
I'm OK with the changes. Greg Shah
11:48 AM Base Language Feature #6422: implement auditing support including AUDIT-POLICY and AUDIT-CONTROL: Theodoros: Please rebase this to the latest trunk revision 14903.
Constantin: Please review after this is rebased. Greg Shah
11:29 AM Base Language Feature #6422: implement auditing support including AUDIT-POLICY and AUDIT-CONTROL: Code review 6422a/14902-14906 (after rebase):
The changes look good to me.
Some minor coding standards or forma... Eric Faulhaber
12:49 PM Runtime Infrastructure Bug #7589 (Internal Test): org.slf4j.impl.StaticLoggerBinder when deploying p2j.jar in tomcat: Code Review Task Branch 7589b Revision 14868
The changes look good. If suitable testing has been completed, we ca... Greg Shah
12:35 PM Base Language Bug #8119 (Merge Pending): JavaDoc build task produces more warnings in Windows in comparison to ...: Code Review Task Branch 8119a Revisions 14874 and 14875
The changes are good.
Please rebase and we will schedul... Greg Shah
12:16 PM Base Language Feature #4392: add -pf support for appserver CONNECT() method: Review of 4392a rev 14868:
* ConnectHelper - is it possible to go into an infinite recursion in 4GL, if -pf is used ... Constantin Asofiei
12:09 PM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions: Code review 8074a.
@WebDriverHandler.getAvailableThemes@ should somehow handle a theme with empty name in the dire... Hynek Cihlar
10:42 AM Database Bug #7138: Short circuit fake-update (update with a new value eqaul to the old value) in H2: What is the status of 7138a_h2? Does it need more review? More testing? It seems to provide a decent improvement o... Greg Shah
04:24 AM Base Language Feature #7045 (Test): re-implement "normal" (non-abend) stack unwinding to avoid throwing an exce...: Branch 7045b was merged into trunk revision 14899 and archived. Alexandru Lungu
12:31 AM Database Bug #7496 (WIP): finish support for query:forward-only attribute: Since 7496b was merged, I'll put this issue into WIP. I've managed to find a few other issues with the implementation... Dănuț Filimon

12/21/2023

03:07 PM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception: 7045b is at the front of the queue now, go ahead and merge. Greg Shah
02:33 PM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception: You can merge 7045b to trunk after 3303a. Greg Shah
02:27 PM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception: 7045b passed ETF testing. Constantin Asofiei
09:30 AM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception: Constantin, do you feel like it is better to get *everything* in trunk and then run ETF against all, instead of "micr... Alexandru Lungu
09:03 AM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception: Alexandru Lungu wrote:
> Constantin, ETF tests are the only ones that were not run. I rebased 7045b to latest trunk ... Constantin Asofiei
07:15 AM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception: Nice catches, Eduard! Please do a second iteration of the changes - I really want to make sure we don't missed someth... Alexandru Lungu
06:17 AM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception: Looked at 7045b after rebase, it looks fine.
Done some minor fixes at history entry.
In @forBlockWorker@, changed i... Eduard Soltan
02:43 PM Base Language Bug #8154: refactor scopeable stacks: Constantin Asofiei wrote:
> I need to digest this more; for scoped dictionaries, in my mind I have something like th... Eric Faulhaber
01:51 PM Base Language Bug #8154: refactor scopeable stacks: Eric Faulhaber wrote:
> Constantin Asofiei wrote:
> > [...]
> > Why I mention this: all this stack push/pop, my fe... Constantin Asofiei
01:19 PM Base Language Bug #8154: refactor scopeable stacks: Constantin Asofiei wrote:
> [...]
> Why I mention this: all this stack push/pop, my feeling is that is expensive; o... Eric Faulhaber
12:46 PM Base Language Bug #8154: refactor scopeable stacks: From #7026-296:
> Constantin Asofiei wrote:
> > On a side note: all scope support is managed in various stacks (o... Constantin Asofiei
12:45 PM Base Language Bug #8154 (WIP): refactor scopeable stacks: Constantin Asofiei
02:42 PM Deployment Support #3303: make the automated deployment process fully production ready: Greg Shah wrote:
> Code Review Task Branch 3303a Revision(s?) 14897 through 14899
>
> I'm not sure why it shows 3... Roger Borrello
02:32 PM Deployment Support #3303: make the automated deployment process fully production ready: Code Review Task Branch 3303a Revision(s?) 14897 through 14899
I'm not sure why it shows 3 revisions but the chang... Greg Shah
02:25 PM Deployment Support #3303: make the automated deployment process fully production ready: The incorrect branch name has been corrected to be *3303a* Roger Borrello
02:02 PM Deployment Support #3303: make the automated deployment process fully production ready: Roger Borrello wrote:
> Greg Shah wrote:
> > Could you have misnamed the branch on creation?
>
> Ugh... I must d... Constantin Asofiei
02:00 PM Deployment Support #3303: make the automated deployment process fully production ready: Greg Shah wrote:
> Could you have misnamed the branch on creation?
Ugh... I must dyslexic be... I created it as *... Roger Borrello
01:57 PM Deployment Support #3303: make the automated deployment process fully production ready: There is no branch at @~/secure/code/p2j_repo/p2j/active/3303a/@. Could you have misnamed the branch on creation? Greg Shah
01:49 PM Deployment Support #3303: make the automated deployment process fully production ready: Branch 3303a was rebased to trunk_14896 and is at revision 14899. Roger Borrello
02:42 PM Runtime Infrastructure Bug #8135: replace ScopedDictionary for better performance: Some notes on the current prototype replacement...
I've gotten rid of the dictionaries at each scope level. There ... Eric Faulhaber
02:39 PM Base Language Feature #6650: improve performance of Scopeable notification in TM.processScopeNotifications: Branch 7026f was merged into trunk revision 14897 and archived. Constantin Asofiei
10:34 AM Base Language Feature #6650: improve performance of Scopeable notification in TM.processScopeNotifications: 7026f rev 14903 fixes some regressions in WidgetPool support.
Constantin Asofiei
06:14 AM Base Language Feature #6650: improve performance of Scopeable notification in TM.processScopeNotifications: 7026f rev 14902 includes:
* Refactored the WidgetPool scopeable support to register for processing as needed.
* Obj... Constantin Asofiei
01:34 PM Base Language Feature #6422: implement auditing support including AUDIT-POLICY and AUDIT-CONTROL: Eric Faulhaber wrote:
> Code review 6422a/14649-14653:
> > * I think the bind/unbind is not needed because I think ... Theodoros Theodorou
12:39 PM Database Feature #6442: missing encoding/collation features: The @DBCODEPAGE()@ and @DBCOLLATION()@ built-in function were implemented in #7326 and available in trunk starting wi... Ovidiu Maxiniuc
12:05 PM Database Feature #4722 (Test): data import should be able to run with only the converted application jar f...: Branch 4722b was merged into trunk revision 14895 and archived. Ovidiu Maxiniuc
11:24 AM Database Feature #4722 (Merge Pending): data import should be able to run with only the converted applicat...: Please merge 4722b after 8056b. Greg Shah
10:58 AM Database Feature #4722: data import should be able to run with only the converted application jar file (an...: I rebased the branch to trunk/14890 and fixed the (strange, albeit simple) conflicts.
Pushed up 4722b to revision 14... Ovidiu Maxiniuc
09:11 AM Database Feature #4722: data import should be able to run with only the converted application jar file (an...: Ovidiu : Please rebase and if the result is working with a smoke test, we will get it merged. Greg Shah
09:03 AM Database Feature #4722: data import should be able to run with only the converted application jar file (an...: Greg Shah wrote:
> Constantin: Please review the @memptr@ change in 4722b rev 14888. If this was a safe change, why... Constantin Asofiei
08:44 AM Database Feature #4722: data import should be able to run with only the converted application jar file (an...: Constantin: Please review the @memptr@ change in 4722b rev 14888. If this was a safe change, why didn't we make it b... Greg Shah
08:31 AM Database Feature #4722: data import should be able to run with only the converted application jar file (an...: Ovidiu, there are a couple of conflicts when attempting to rebase against trunk revision 14890. Could you take a look... Roger Borrello
08:28 AM Database Feature #4722: data import should be able to run with only the converted application jar file (an...: Eric Faulhaber wrote:
> I think the @import.sh@ changes are ok, but I did not confirm with a test. Has this been tes... Roger Borrello
09:36 PM Database Feature #4722: data import should be able to run with only the converted application jar file (an...: Eric Faulhaber wrote:
> In the @XmlFilePlugin@ c'tor, there is this comment:
> [...]
> At @ImportWorker@ line 606,... Ovidiu Maxiniuc
11:36 AM User Interface Bug #7824 (Test): Simplify idle connection settings and apply the default configuration for the w...: Sergey Ivanovskiy
11:33 AM User Interface Bug #7824: Simplify idle connection settings and apply the default configuration for the web clie...: 7824a has been rebased, merged into the trunc as rev 14893 and archived. Sergey Ivanovskiy
11:21 AM User Interface Bug #7824: Simplify idle connection settings and apply the default configuration for the web clie...: Planning to merge within next 15 minutes after rebase. Sergey Ivanovskiy
10:00 AM User Interface Bug #7824: Simplify idle connection settings and apply the default configuration for the web clie...: This can merge after 7889a. Greg Shah
09:46 AM User Interface Bug #7824 (Merge Pending): Simplify idle connection settings and apply the default configuration ...: Code review 7824a revision 14897. The changes are good, I have no more objections. Hynek Cihlar
04:00 AM User Interface Bug #7824: Simplify idle connection settings and apply the default configuration for the web clie...: 7824a has been rebased. It seems that it can be merged into the trunc. Are there any objections? Sergey Ivanovskiy
11:23 AM Database Feature #8067: investigate adding automatically adding a FIELDS clause for simple record blocks: I fully agree with Eric and mark this as top focus in the implementation. However, I am not 100% sure this approach w... Alexandru Lungu
11:13 AM Database Feature #8067: investigate adding automatically adding a FIELDS clause for simple record blocks: Please note that an explicit FIELDS clause in 4GL code will raise an error if a field is accessed in downstream code ... Eric Faulhaber
10:50 AM Database Bug #7496: finish support for query:forward-only attribute: Branch 7496b was merged into trunk revision 14891 and archived.
This task is still open due to 7496a. Alexandru Lungu
10:07 AM Database Bug #7496: finish support for query:forward-only attribute: Doing it now - just 10 mins to check it out. Alexandru Lungu
07:52 AM Database Bug #7496: finish support for query:forward-only attribute: You can merge 7496b to trunk now. Greg Shah
04:57 AM Database Bug #7496: finish support for query:forward-only attribute: Greg, this seems like an easy performance gain. It was fully tested (except ETF). We can go ahead with the merge of 7... Alexandru Lungu
08:42 AM Database Bug #6767: Possible name clashes in DMO classes: Eric Faulhaber wrote:
> Vladimir, sorry for the long delay in reviewing this again. Please rebase this branch when y... Vladimir Tsichevski

12/20/2023

06:55 PM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception: Hold off on the merge. 8056a and 8127a need to go first. Greg Shah
11:44 AM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception: Just rebased 7045b to latest trunk, but the process was a bit slow due to the large number of changes to be introduce... Alexandru Lungu
11:38 AM Base Language Feature #7045 (Merge Pending): re-implement "normal" (non-abend) stack unwinding to avoid throwin...: Please merge to trunk after 8007a. Greg Shah
10:36 AM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception: Quick final look at 7045b/14838...
It looks like we still need a rebase to current trunk before merge. Also, some ... Eric Faulhaber
09:48 AM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception: Completely finished the testing of 7045b. Pending for merge. Alexandru Lungu
09:25 AM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception: Removed hard tabs from the previous commit. Committed on 7045b, revision 14838.
I do not think there is anything els... Eduard Soltan
04:39 PM Database Bug #6767: Possible name clashes in DMO classes: Vladimir, sorry for the long delay in reviewing this again. Please rebase this branch when you can. I started reviewi... Eric Faulhaber
04:26 PM Base Language Feature #6422: implement auditing support including AUDIT-POLICY and AUDIT-CONTROL: Code review 6422a/14649-14653:
*Please note again that I am not familiar with the legacy audit feature set, so I a... Eric Faulhaber
10:41 AM Base Language Feature #6422: implement auditing support including AUDIT-POLICY and AUDIT-CONTROL: Kind reminder for a review Theodoros Theodorou
01:37 PM Database Feature #4722: data import should be able to run with only the converted application jar file (an...: Code review 4722b/14887-14892:
Generally good, but please see comments/questions below.
I think the @import.sh@... Eric Faulhaber
12:14 PM Database Feature #4722 (Review): data import should be able to run with only the converted application jar...: Eric: Please review. Greg Shah
11:59 PM Database Feature #4722: data import should be able to run with only the converted application jar file (an...: Branch 4722b was rebased to trunk_14886 and is at revision 14892. Roger Borrello
09:43 PM Database Feature #4722: data import should be able to run with only the converted application jar file (an...: I think so but, to my knowledge, the changes r14878..14884 were not reviewed. Ovidiu Maxiniuc
01:21 PM Base Language Feature #8138: ABLUnit configuration using environment variables: I agree, we should add the ability to configure the bootstrap cfg file name (and only the bootstrap cfg file name) vi... Greg Shah
08:27 AM Base Language Feature #8138: ABLUnit configuration using environment variables: Vladimir Tsichevski wrote:
> Using Java properties for client configuration will allow to run with no configuration ... Marian Edu
06:53 AM Base Language Feature #8138: ABLUnit configuration using environment variables: Marian Edu wrote:
> Vladimir Tsichevski wrote:
> > IMO this will add another layer of complexity and mixed technolo... Vladimir Tsichevski
06:49 AM Base Language Feature #8138: ABLUnit configuration using environment variables: Vladimir Tsichevski wrote:
> IMO this will add another layer of complexity and mixed technology. Besides, using OS e... Marian Edu
06:02 AM Base Language Feature #8138: ABLUnit configuration using environment variables: IMO this will add another layer of complexity and mixed technology. Besides, using OS environment variables with Java... Vladimir Tsichevski
04:13 AM Base Language Feature #8138: ABLUnit configuration using environment variables: I'm extracting that from another unrelated issue just so it doesn't get lost.
Vladimir, we're running ABLUnit from... Marian Edu
04:08 AM Base Language Feature #8138 (Internal Test): ABLUnit configuration using environment variables: Marian Edu
01:21 PM User Interface Bug #7794: FILL-IN: editing numbers issues: h2. Known issues compiled
This entry contains all know sub-issues, and will be edited as new sub-issues emerge and... Vladimir Tsichevski
12:50 PM User Interface Bug #7794: FILL-IN: editing numbers issues: Greg Shah wrote:
> I am remembering that some layout modes (@COLON-ALIGNED@?, @SIDE-LABELS@?) might change the align... Vladimir Tsichevski
12:18 PM Base Language Feature #6649: improve the performance or SourceNameMapper runtime: 6649a has been dead-archived. Greg Shah
02:06 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime: Greg Shah wrote:
> Is 6649a a live branch?
It should not be, all the work I've done was in 6649b. Dănuț Filimon
08:29 AM Database Feature #6720: lazy hydration: I am "battling" with a small regression when averaging the new row-structure architecture with lazy hydration. I was ... Alexandru Lungu
08:25 AM Database Bug #7496: finish support for query:forward-only attribute: *Committed 7496b/rev.14879* Added the patch from #7496-41. Dănuț Filimon
05:40 AM Database Bug #7496: finish support for query:forward-only attribute: I finished testing the patch from #7496-41:
* POC tests: passed;
* POC regression tests: passed (with the expected ... Dănuț Filimon
05:30 AM Base Language Feature #8140: Client PID: Is there a way to get the 'client' process identifier in FWD? We use that for sikuli to identify the process window t... Marian Edu
05:24 AM Base Language Feature #8140 (New): Client PID: Marian Edu
05:12 AM Base Language Bug #8139: OS-COMMAND fails on windows if not in "batch mode": For what it's worth forcing the @SwingGuiDriver@ to take into account the @background@ option does solve the issue an... Marian Edu
04:48 AM Base Language Bug #8139: OS-COMMAND fails on windows if not in "batch mode": We're trying to start a 'ui simulator' based on sikuli using @OS-COMMAND@ and this is always failing if the client is... Marian Edu
04:16 AM Base Language Bug #8139 (New): OS-COMMAND fails on windows if not in "batch mode": Marian Edu
12:00 AM Deployment Support #3303: make the automated deployment process fully production ready: Branch 3303a was rebased to trunk_14886 and is at revision 14889. Roger Borrello

12/19/2023

05:47 PM Database Bug #8101: Issue with temp-table defined as reference-only: The above 4gl code generates the following java code.... Theodoros Theodorou
03:58 PM Database Feature #6720: lazy hydration: How far along is 6720b? Greg Shah
11:21 AM Runtime Infrastructure Bug #8135: replace ScopedDictionary for better performance: @ScopedDictionary@ and to a lesser degree its subclass @ScopedSymbolDictionary@ are used throughout the runtime to ma... Eric Faulhaber
11:11 AM Runtime Infrastructure Bug #8135 (New): replace ScopedDictionary for better performance: Eric Faulhaber
10:18 AM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception: 7045b passes a large set of regression tests from a customer application. I tested without the changes in rev. 14837.... Alexandru Lungu
10:13 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime: Is 6649a a live branch? Greg Shah
03:39 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime: Alexandru, I remember you also mentioned it in #6815. But at that time you asked Constantin for feedback on the idea.... Dănuț Filimon
03:32 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime: I agree with Eric. Fine tuning cache-sizes is a common pattern when deploying. I would also like a mechanism that can... Alexandru Lungu
09:59 AM Database Feature #7066: Implement multi-table indexed query in H2: It is pending mostly as it was attempting to optimize multi-table queries on H2. After some profiling and tracking, t... Alexandru Lungu
09:50 AM Database Feature #7066: Implement multi-table indexed query in H2: What is the status of this task and of 7066a? Greg Shah
09:38 AM Base Language Feature #6497: add equivalent support for the -T command line option: 6497a was dead-archived. Greg Shah
08:38 AM Deployment Support #3303: make the automated deployment process fully production ready: The repository for @~/secure/code/p2j_repo/mgmt/@ is now also available on *xfer.goldencode.com* as @/opt/fwd/mgmt@
Roger Borrello
07:41 AM Deployment Support #3303: make the automated deployment process fully production ready: > After testing, I think I should remove at least *ncurses*, perhaps *jdk* as well. It all depends on how "thin" we w... Greg Shah
08:29 AM Database Feature #4722: data import should be able to run with only the converted application jar file (an...: Ovidiu: Is this safe and ready to merge to trunk? Greg Shah
08:28 AM Database Feature #4722: data import should be able to run with only the converted application jar file (an...: Greg Shah wrote:
> Does this need any further testing?
Not from my perspective. Roger Borrello
07:42 AM Database Feature #4722: data import should be able to run with only the converted application jar file (an...: Does this need any further testing? Greg Shah
07:41 AM Database Bug #7496 (Internal Test): finish support for query:forward-only attribute: This change is invasive as it affects all @ProgressiveResults@ across any application. I am OK with the change: we sh... Alexandru Lungu
07:38 AM Database Bug #7496: finish support for query:forward-only attribute: Alexandru, I tested POC with the solution mentioned in #7496-40 after we discussed it could provide a performance imp... Dănuț Filimon
03:06 AM Database Bug #7496: finish support for query:forward-only attribute: Dănuț Filimon wrote:
> First things first, there are a lot of @23/12/15 12:47:11.619+0200 | SEVERE | com.goldencode... Dănuț Filimon

12/18/2023

04:39 PM Deployment Support #3303: make the automated deployment process fully production ready: Right now I have the roles for building a Docker host as:
* base
* fwd_acct
* dev_tools
* jdk
* ncurses
* inter... Roger Borrello
02:13 PM Base Language Feature #6649: improve the performance or SourceNameMapper runtime: Dănuț Filimon wrote:
> [[p2j:Database Configuration#Cache-Sizes]] was updated with the necessary information for con... Eric Faulhaber
11:40 AM User Interface Bug #7824: Simplify idle connection settings and apply the default configuration for the web clie...: Please review rev 14889 (7824a) that fixed refs: #7824-17 and #7824-27. Sergey Ivanovskiy
10:44 AM Base Language Feature #8124: rework conversion and runtime support for BLOCK-LEVEL and ROUTINE-LEVEL statements: Some notes about this: ROUTINE/BLOCK-LEVEL affect the 'file' and not the 'instance'. So, for OO, each top-level call... Constantin Asofiei
10:02 AM Database Feature #4722: data import should be able to run with only the converted application jar file (an...: Branch 4722b was rebased to trunk_14882 and is at revision 14888. Roger Borrello
09:51 AM Database Feature #4722: data import should be able to run with only the converted application jar file (an...: Roger Borrello wrote:
> Great! Don't forget to update the @ImportWorker.java@ header. I'll test it out this AM.
I... Roger Borrello
09:22 AM Database Bug #8101: Issue with temp-table defined as reference-only: The failure comes from the line @boolean hasRecords = local.nonEmptyTableFlags.contains(multiplexID);@ in @TemporaryB... Theodoros Theodorou
06:29 AM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception: Eduard, please mind that there are still some hard-tabs in the last 2 commits. (@BlockManager@). Alexandru Lungu

12/15/2023

09:10 AM Database Bug #7496 (WIP): finish support for query:forward-only attribute: POC tests still fail, I am trying to setup the fwdtests project in Eclipse and debug. Dănuț Filimon
07:10 AM Database Bug #7496: finish support for query:forward-only attribute: First things first, there are a lot of @23/12/15 12:47:11.619+0200 | SEVERE | com.goldencode.p2j.persist.ForwardResu... Dănuț Filimon
04:07 AM Database Bug #7496: finish support for query:forward-only attribute: I am picking up work on this issue for #7991 and will be testing the changes first to see if there are any obvious pr... Dănuț Filimon
07:43 AM Database Feature #8067: investigate adding automatically adding a FIELDS clause for simple record blocks: Committed on 8967a, revision 14872.
Added an annotation @internalfields@ with fields used in a @FOR EACH@ block to... Eduard Soltan
07:04 AM Base Language Feature #6417: cleanup some known items in appserver support: @WebSpeed@ used to be OE app in the browser (in some script) running on the WebSpeed agent. So the client knew it is ... Galya B
04:39 AM Base Language Feature #6417: cleanup some known items in appserver support: > * VersionInfo:clientType supports only 4GLCLIENT and APPSERVER at this time
Access to @clientType@ via:
* @SESS... Galya B
02:51 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime: [[p2j:Database Configuration#Cache-Sizes]] was updated with the necessary information for configuring the cache size ... Dănuț Filimon
08:38 PM Deployment Support #3303: make the automated deployment process fully production ready: The latest revision builds a FWD reference system utilizing Docker image to retrieve the FWD deployment. Right now it... Roger Borrello

12/14/2023

12:24 PM Base Language Feature #8124: rework conversion and runtime support for BLOCK-LEVEL and ROUTINE-LEVEL statements: Instead of emitting @onBlockLevel(Condition.ERROR, Action.THROW);@ or @onRoutineLevel(Condition.ERROR, Action.THROW);... Greg Shah
12:22 PM Base Language Feature #8124 (New): rework conversion and runtime support for BLOCK-LEVEL and ROUTINE-LEVEL stat...: Greg Shah
12:18 PM Base Language Bug #8084 (Test): refactor the 'execute' method for legacy classes: Greg Shah
11:56 AM Base Language Bug #8084: refactor the 'execute' method for legacy classes: Branch 8084a was merged to trunk rev 14876 and archived. Constantin Asofiei
11:38 AM Base Language Bug #8084: refactor the 'execute' method for legacy classes: If you've done enough, you can merge. Greg Shah
11:34 AM Base Language Bug #8084: refactor the 'execute' method for legacy classes: Greg Shah wrote:
> Yes, if you are complete with testing.
I haven't converted all apps, but I think the conversion ... Constantin Asofiei
09:47 AM Base Language Bug #8084 (Internal Test): refactor the 'execute' method for legacy classes: Yes, if you are complete with testing. Greg Shah
09:32 AM Base Language Bug #8084: refactor the 'execute' method for legacy classes: Greg Shah wrote:
> As an additional improvement, I wonder if we should change how @BLOCK-LEVEL@ and @ROUTINE-LEVEL@ ... Constantin Asofiei
07:10 PM Base Language Bug #8084: refactor the 'execute' method for legacy classes: Code Review Task Branch 8084a Revisions 14870 through 14873
The changes are good.
As an additional improvement,... Greg Shah
11:19 AM Base Language Feature #6649 (Test): improve the performance or SourceNameMapper runtime: Branch 6649b was merged to trunk rev 14874 and archived. Alexandru Lungu
11:08 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime: Yes, please merge now. Greg Shah
11:01 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime: As this was the last testing required for #6649, I am preparing to merge 6649b. Alexandru Lungu
10:58 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime: Constantin Asofiei wrote:
> Alexandru Lungu wrote:
> > Constantin, if 6649b passes ETF, we can merge it to trunk. P... Constantin Asofiei
10:32 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime: Alexandru Lungu wrote:
> Constantin, if 6649b passes ETF, we can merge it to trunk. Please let me know when to proce... Constantin Asofiei
09:43 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime: Constantin, if 6649b passes ETF, we can merge it to trunk. Please let me know when to proceed. Alexandru Lungu
08:49 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime: Together with Alexandru we've managed to find a cause and solution for the trunk regression. I'm working on running ... Constantin Asofiei
05:37 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime: Great news! I've ran the regression tests and all tests passed successfully. Dănuț Filimon
10:30 AM Base Language Bug #8119 (Review): JavaDoc build task produces more warnings in Windows in comparison to Linux: Galya B
10:30 AM Base Language Bug #8119 (WIP): JavaDoc build task produces more warnings in Windows in comparison to Linux: 8119a r14874,14875: Option added to javadoc task to show all warnings. Galya B
09:15 AM Base Language Bug #8119: JavaDoc build task produces more warnings in Windows in comparison to Linux: @ant@ automatically picks up any @-D@ options on the command line and turns them into properties that can be referenc... Greg Shah
09:08 AM Base Language Bug #8119: JavaDoc build task produces more warnings in Windows in comparison to Linux: Once upon a time I got a project with configured linter that wasn't used. I enabled a test plan in the CI/CD for each... Galya B
08:57 AM Base Language Bug #8119: JavaDoc build task produces more warnings in Windows in comparison to Linux: > So do we want to open the Pandora box?
No, but I do want to have a @-D@ option that we can use to enable it. Ma... Greg Shah
02:12 AM Base Language Bug #8119: JavaDoc build task produces more warnings in Windows in comparison to Linux: Here it is: The same output with @-Xdoclint:all@. So do we want to open the Pandora box?
Galya B
10:19 AM Deployment Support #3303: make the automated deployment process fully production ready: May I suggest Docker should be the main basis for the build and runtime roles? This would allow us to pull "code" fro... Roger Borrello
10:07 AM Database Feature #6720: lazy hydration: Adapted 6720b according to the row structure architecture. Continuing with testing and tracking. Alexandru Lungu
09:29 AM Base Language Bug #8116: SEARCH vs FILE-INFO: I like the idea. Greg Shah
07:13 AM Base Language Bug #8116: SEARCH vs FILE-INFO: Vladimir Tsichevski wrote:
> The only difference I can recall is that the client configuration cannot be set from co... Marian Edu
06:46 AM Base Language Bug #8116: SEARCH vs FILE-INFO: Eugenie Lyzenko wrote:
> From application point of view the @PROPATH/SEARACHPATH@ should be @,@ separated. But in a ... Marian Edu
08:05 AM Database Feature #4722: data import should be able to run with only the converted application jar file (an...: Ovidiu Maxiniuc wrote:
> Roger,
> Please update to latest 4922b. There are two issues fixed, which in fact, were pr... Roger Borrello
08:16 PM Database Feature #4722: data import should be able to run with only the converted application jar file (an...: Roger,
Please update to latest 4922b. There are two issues fixed, which in fact, were present in trunk:
* changing ... Ovidiu Maxiniuc
02:34 AM Runtime Infrastructure Bug #7589: org.slf4j.impl.StaticLoggerBinder when deploying p2j.jar in tomcat: This is the type of warnings displayed when no slf4j imp present for the client:... Galya B
02:13 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...: Waiting for feedback from Eric and Ovidiu #7884-32, #7884-42 and #7884-44. Galya B

12/13/2023

04:30 PM Database Feature #4722: data import should be able to run with only the converted application jar file (an...: Greg Shah wrote:
> It is clear there is a regression that needs to be fixed here.
Well... not really. The culprit... Roger Borrello
03:51 PM Database Feature #4722: data import should be able to run with only the converted application jar file (an...: It is clear there is a regression that needs to be fixed here. Greg Shah
03:49 PM Database Feature #4722: data import should be able to run with only the converted application jar file (an...: Just want to log the *reservation.d* processing from non-4722b:... Roger Borrello
02:11 PM Database Feature #4722: data import should be able to run with only the converted application jar file (an...: Greg Shah wrote:
> I'd like to get this into trunk. What is the effort to make this safe?
If Ovidiu could verify... Roger Borrello
06:59 AM Database Feature #4722: data import should be able to run with only the converted application jar file (an...: I'd like to get this into trunk. What is the effort to make this safe? Greg Shah
10:55 AM Database Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools: Done. Branch 7416b was merged into trunk as rev. 14872 and archived. Radu Apetrii
10:10 AM Database Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools: Greg Shah wrote:
> You can go ahead.
I'll quickly rebase the branch and then proceed with the merging.
Radu Apetrii
10:03 AM Database Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools: You can go ahead. Greg Shah
06:31 AM Database Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools: After re-running the performance tests for both the baseline and the changed version, I got the following result:
* ... Radu Apetrii
04:23 AM Database Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools: Radu Apetrii wrote:
> Alexandru Lungu wrote:
> > Radu, first "batch" of logging refactoring didn't show any downgra... Radu Apetrii
10:49 AM Base Language Bug #8119: JavaDoc build task produces more warnings in Windows in comparison to Linux: I don't know of a way to make OpenJDK show them. I'd be glad to see them (as long as it was optional) because to fin... Greg Shah
10:30 AM Base Language Bug #8119: JavaDoc build task produces more warnings in Windows in comparison to Linux: Yes, it's Oracle. This explains it.
But the Oracle ones are valid issues. Can we somehow make Open JDK show them, ... Galya B
10:15 AM Base Language Bug #8119: JavaDoc build task produces more warnings in Windows in comparison to Linux: Could you be building on Windows using the Oracle JDK? The Oracle JDK generates a ver long list of javadoc errors as... Greg Shah
09:19 AM Base Language Bug #8119: JavaDoc build task produces more warnings in Windows in comparison to Linux: @./gradlew ant-javadoc@ build task produces more warnings in Windows in comparison to Linux. Galya B
09:16 AM Base Language Bug #8119 (Closed): JavaDoc build task produces more warnings in Windows in comparison to Linux: Galya B
10:08 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime: Alexandru Lungu wrote:
> It is normal to have 18-21 tests failed on that regression tests.
>
> As of my understan... Greg Shah
09:52 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime: I ran the #7669-1 test and one of the users failed during the run 75 due to a @StaleRecordException@. I am running 71... Dănuț Filimon
09:06 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime: It is normal to have 18-21 tests failed on that regression tests.
As of my understanding: if ETF passes, only ChUI... Alexandru Lungu
09:01 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime: I finished testing a customer application with 7156b and 6649b and got between 18 (first run) and 21 (seconds run) te... Dănuț Filimon
08:02 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime: Rebased 6649b to latest trunk. It is now at rev. 14886.
Constantin, you can start the ETF tests. These tests are n... Alexandru Lungu
07:46 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime: Danut, I am planning to do rebase of 6649b to the latest trunk now. Alexandru Lungu
06:48 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime: Alexandru Lungu wrote:
> Danut, lets focus merging this by EOD. What testing is left?
Currently fixed the import.db... Dănuț Filimon
06:46 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime: Alexandru Lungu wrote:
> Danut, lets focus merging this by EOD. What testing is left?
Are all changes in 6649? I ca... Constantin Asofiei
06:45 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime: Danut, lets focus merging this by EOD. What testing is left? Alexandru Lungu
09:38 AM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception: Committed on 7045b, revision 14837.
This change requires reconversion. 4gl constructs like @for tt@, should be con... Eduard Soltan
08:27 AM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception: I discussed with Eduard and it seems that the problem is that we have @forBlock(P2JQuery, int, String, Block)@, but w... Alexandru Lungu
09:03 AM Base Language Bug #8116: SEARCH vs FILE-INFO: Greg Shah wrote:
> Vladimir can also help here regarding the specifics of our ABLUnit support. It is slightly diffe... Vladimir Tsichevski
08:58 AM Base Language Bug #8116: SEARCH vs FILE-INFO: From application point of view the @PROPATH/SEARACHPATH@ should be @,@ separated. But in a real application the separ... Eugenie Lyzenko
08:53 AM Base Language Bug #8116: SEARCH vs FILE-INFO: Vladimir can also help here regarding the specifics of our ABLUnit support. It is slightly different because of the ... Greg Shah
08:51 AM Base Language Bug #8116: SEARCH vs FILE-INFO: I'll make a couple of quick points and then Eugenie will take it from there.
1. Your use case should be supported ... Greg Shah
08:53 AM Base Language Feature #4392: add -pf support for appserver CONNECT() method: 4392a r14868 Ready for review. Fixing the remote @FileStream@ by adding a flag to determine if the file is supposed t... Galya B
06:11 AM Base Language Feature #4392: add -pf support for appserver CONNECT() method: A note: Even with @StreamFactory@ it's not always the client filesystem, but depends on the directory config @server-... Galya B
01:39 AM Base Language Feature #4392: add -pf support for appserver CONNECT() method: I'll add a flag to handle both cases. By default it will be the old logic, since we can't pinpoint where it's used. A... Galya B
08:26 PM Base Language Feature #4392: add -pf support for appserver CONNECT() method: Constantin Asofiei wrote:
> Ovidiu, please see previous note - do you recall why that was added?
I remember the mom... Ovidiu Maxiniuc
07:07 AM Deployment Support #3303: make the automated deployment process fully production ready: I generally like this. Let's consider the idea that roles can be additive. By splitting these into "lego blocks" we... Greg Shah
06:43 AM Build and Source Control Support #5167: using static linking to eliminate the need to patch the system-wide ncurses: We can leave them. Greg Shah
06:40 AM Base Language Bug #8084 (Review): refactor the 'execute' method for legacy classes: The changes for this and #8069 are in 8084a rev 14873. Please review. Constantin Asofiei
05:37 AM Runtime Infrastructure Bug #7589: org.slf4j.impl.StaticLoggerBinder when deploying p2j.jar in tomcat: 7589b r14868: adds FWD's slf4j implementation to the classpath of both the temp JVM created by the spawner and the sp... Galya B

12/12/2023

06:33 PM Deployment Support #3303: make the automated deployment process fully production ready: Greg Shah wrote:
> The playbooks are 3 years old, were never 100% complete and we never got local execution running ... Roger Borrello
06:22 PM Deployment Support #3303: make the automated deployment process fully production ready: Branch 3303 was created from trunk_14870. I checked in an update to allow for locales to be included in the convert a... Roger Borrello
06:17 PM Database Feature #4722: data import should be able to run with only the converted application jar file (an...: Branch 4722b was rebased to trunk_14870 and is at revision 14874. Roger Borrello
05:43 PM Build and Source Control Support #5167: using static linking to eliminate the need to patch the system-wide ncurses: Updated the "wiki":/projects/p2j/wiki/Patching_NCURSES_Using_Static_Linking. Should the older versions be removed? I ... Roger Borrello
05:19 PM Build and Source Control Support #5167: using static linking to eliminate the need to patch the system-wide ncurses: Yes Greg Shah
05:18 PM Build and Source Control Support #5167: using static linking to eliminate the need to patch the system-wide ncurses: Greg Shah wrote:
> Then how do we provide a newer version outside of the standard workstation?
I'm not sure. Is t... Roger Borrello
02:31 PM Base Language Feature #6649: improve the performance or SourceNameMapper runtime: Alexandru Lungu wrote:
> Danut, is it possible to test 6649b without reconverting? This should theoretically run wit... Dănuț Filimon
11:18 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime: Danut, is it possible to test 6649b without reconverting? This should theoretically run with no problem and build up ... Alexandru Lungu
07:04 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime: The results of the POC test are in :)
|_. |_. Baseline (4 cold tests avg) |_. 7156b + 66... Dănuț Filimon
05:07 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime: I smoke tested a large customer application with 6649b and everything worked well. Currently running POC tests. Dănuț Filimon
04:44 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime: Dănuț Filimon wrote:
> I addressed the review from Hynek in *6649b.rev.14879*
Code review. The changes are good.
Hynek Cihlar
03:33 AM Base Language Feature #6649 (Internal Test): improve the performance or SourceNameMapper runtime: Dănuț Filimon
03:32 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime: I addressed the review from Hynek in *6649b.rev.14879* where I added a @removeIdentifier@ method and changed the logg... Dănuț Filimon
02:55 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime: Alexandru Lungu wrote:
> Constantin, can you run the ETF tests with 6649b once ready? Thank you.
Will do.
Constantin Asofiei
02:54 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime: Danut, please mark this as Urgent; we need to test it asap.
Thus, address the review from Hynek and lets move on w... Alexandru Lungu
11:13 AM Database Feature #6720: lazy hydration: Branch 6720c was merged to trunk rev 14869 and archived.
Resuming work on 6720b Alexandru Lungu
10:59 AM Database Feature #6720: lazy hydration: You can merge to trunk now. Greg Shah
10:40 AM Database Feature #6720: lazy hydration: Completely fixed 6720c. I had some "invisible" regressions there. Also, it was quite confusing why the @AdaptiveRowSt... Alexandru Lungu
03:37 AM Database Feature #6720: lazy hydration: Fixed the last concerns. Committed 6720c / rev. 14848.
Redoing quick profiling and regression tests now for 6720c... Alexandru Lungu
11:07 AM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception: Eduard, there is an API issue we have on BlockManager. I think the rewriting of the BlockManager API to include the q... Alexandru Lungu
03:55 AM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception: Committed on 7045b, revision 14836.
- removed @handleQueryOffEnd@ method from QueryWrapper and all of its usage.
- ... Eduard Soltan
02:58 AM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception: Eduard, please address the latest suggestions and commit to 7045b.
Lets redo the whole testing process with this l... Alexandru Lungu
09:09 AM Base Language Feature #4392: add -pf support for appserver CONNECT() method: > By the way @-pf@ for DB connect uses @new File()@. Is it acceptable there?
No. That is not OK there either. Greg Shah
02:37 AM Base Language Feature #4392: add -pf support for appserver CONNECT() method: Constantin Asofiei wrote:
> Galya B wrote:
> > By the way @-pf@ for DB connect uses @new File()@. Is it acceptable ... Galya B
02:17 AM Base Language Feature #4392: add -pf support for appserver CONNECT() method: Galya B wrote:
> By the way @-pf@ for DB connect uses @new File()@. Is it acceptable there?
You mean the code in @C... Constantin Asofiei
01:48 AM Base Language Feature #4392: add -pf support for appserver CONNECT() method: Ovidiu, please see previous note - do you recall why that was added? Constantin Asofiei
01:44 AM Base Language Feature #4392: add -pf support for appserver CONNECT() method: I've found the issue with the remote stream:
@FileStream@:... Galya B
12:47 AM Base Language Feature #4392: add -pf support for appserver CONNECT() method: Greg Shah wrote:
> Code Review Task Branch 4392a Revisions 14865 and 14866
>
> I did a quick review. The primary... Galya B
12:45 AM Base Language Feature #4392: add -pf support for appserver CONNECT() method: Greg Shah wrote:
> Code Review Task Branch 4392a Revisions 14865 and 14866
>
> I did a quick review. The primary... Galya B
08:16 AM Base Language Bug #8116: SEARCH vs FILE-INFO: Although there is this slight difference in FWD implementation my issue seems to come from invalid @PROPATH@ settings... Marian Edu
04:19 AM Base Language Bug #8116: SEARCH vs FILE-INFO: When using @SEARCH@ using relative path in 4GL the file is looked-up in all @PROPATH@ entries and if found the full-p... Marian Edu
04:19 AM Base Language Bug #8116 (New): SEARCH vs FILE-INFO: Marian Edu

12/11/2023

03:56 PM Base Language Feature #4392: add -pf support for appserver CONNECT() method: Some other notes, beside what Greg mentioned:
# does @-pf@ overwrite only the preceding options (the one which appea... Constantin Asofiei
03:10 PM Base Language Feature #4392: add -pf support for appserver CONNECT() method: Constantin: Please review. Greg Shah
03:10 PM Base Language Feature #4392: add -pf support for appserver CONNECT() method: Code Review Task Branch 4392a Revisions 14865 and 14866
I did a quick review. The primary issue I see is that the... Greg Shah
10:12 AM Base Language Feature #4392: add -pf support for appserver CONNECT() method: ...and r14866 for the file header. Galya B
10:07 AM Base Language Feature #4392 (Review): add -pf support for appserver CONNECT() method: 4392a r14865 ready for review.
Fixes the connect param "-pf" for servers. The code wasn't completed and was throwi... Galya B
01:19 PM Base Language Feature #6649: improve the performance or SourceNameMapper runtime: Code review 6649b revision 14878.
@MonitorRunnable.identifiers@ are never cleared. Shouldn't an entry be removed, ... Hynek Cihlar
12:13 PM Database Feature #6720: lazy hydration: I am glad you already tested the implementation and you found no regressions. I re-analysed the iterator from @Ordere... Ovidiu Maxiniuc
06:02 AM Database Feature #6720: lazy hydration: Committed 6720c/14847 including the suggestions you made.
* Regarding @fieldCnt@, it should have been 1 to short ... Alexandru Lungu
11:30 AM User Interface Bug #7824: Simplify idle connection settings and apply the default configuration for the web clie...: Sergey Ivanovskiy wrote:
> Please review the committed revision 14868 (7824a).
Code review.
According to the j... Hynek Cihlar
06:34 AM User Interface Bug #7824: Simplify idle connection settings and apply the default configuration for the web clie...: Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> > We can change the code of @WebClientsManager@ for the case when ... Sergey Ivanovskiy
03:15 AM Base Language Feature #6417: cleanup some known items in appserver support: > * versioninfo fields are read-only, but writing them is a runtime error and not compile error in FWD.
This one see... Galya B
02:12 AM Database Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools: Alexandru Lungu wrote:
> Radu, first "batch" of logging refactoring didn't show any downgrade. I didn't expect to se... Radu Apetrii
02:08 AM Database Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools: Eric Faulhaber wrote:
> Are you saying there is a 3.5% penalty when the implementation is passive, or when it is act... Radu Apetrii

12/08/2023

04:34 PM Database Feature #6720: lazy hydration: Alexandru, sorry for the delay. The size and the nature of changes (class tree, virtual methods) required ore time th... Ovidiu Maxiniuc
12:06 PM Database Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools: The original implementation (when Hibernate was involved) had a very high overhead. I don't know the exact number, bu... Eric Faulhaber
09:35 AM Database Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools: Greg Shah wrote:
> > The tests show a ~3.5% decrease in performance.
>
> No, we can't move ahead with this.
Ra... Alexandru Lungu
09:16 AM Database Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools: > The tests show a ~3.5% decrease in performance.
No, we can't move ahead with this. Greg Shah
08:47 AM Database Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools: Alexandru Lungu wrote:
> large customer application smoke tests
Done. Worked without any issue in all cases (sql lo... Radu Apetrii
09:49 AM User Interface Bug #7824: Simplify idle connection settings and apply the default configuration for the web clie...: Sergey Ivanovskiy wrote:
> We can change the code of @WebClientsManager@ for the case when agent range is not config... Hynek Cihlar
09:47 AM User Interface Bug #7824: Simplify idle connection settings and apply the default configuration for the web clie...: Sergey Ivanovskiy wrote:
> At this moment the debug mode is not enabled if the agent range is not configured. For th... Hynek Cihlar
08:43 AM User Interface Bug #7824: Simplify idle connection settings and apply the default configuration for the web clie...: Sergey Ivanovskiy wrote:
> These web client settings (under @webClient@ node)
> [...]
> are set automatically for... Greg Shah
07:22 AM User Interface Bug #7824: Simplify idle connection settings and apply the default configuration for the web clie...: We can change the code of @WebClientsManager@ for the case when agent range is not configured but the @jvmArgs@ is gi... Sergey Ivanovskiy
07:10 AM User Interface Bug #7824: Simplify idle connection settings and apply the default configuration for the web clie...: The agent range is common for the debugger and jmx agents so jvmArgs just describes jmx and/or debug agents should be... Sergey Ivanovskiy
07:06 AM User Interface Bug #7824: Simplify idle connection settings and apply the default configuration for the web clie...: At this moment the debug mode is not enabled if the agent range is not configured. For the known application there ar... Sergey Ivanovskiy
06:48 AM User Interface Bug #7824: Simplify idle connection settings and apply the default configuration for the web clie...: Sergey Ivanovskiy wrote:
> The agent port is assigned by @WebClientManager@ that reads @jvmArgs@ option in the direc... Hynek Cihlar
06:31 AM User Interface Bug #7824: Simplify idle connection settings and apply the default configuration for the web clie...: Hynek Cihlar wrote:
> Code review 7824a revisions 14862..14867.
>
> I may be misinterpreting the changes, but I d... Sergey Ivanovskiy
05:05 AM User Interface Bug #7824: Simplify idle connection settings and apply the default configuration for the web clie...: Hynek Cihlar wrote:
> Code review 7824a revisions 14862..14867.
>
> I may be misinterpreting the changes, but I d... Hynek Cihlar
05:04 AM User Interface Bug #7824: Simplify idle connection settings and apply the default configuration for the web clie...: Code review 7824a revisions 14862..14867.
I may be misinterpreting the changes, but I don't see how the debug mode... Hynek Cihlar
02:46 AM User Interface Bug #7824: Simplify idle connection settings and apply the default configuration for the web clie...: These web client settings (under @webClient@ node) ... Sergey Ivanovskiy
02:16 AM User Interface Bug #7824: Simplify idle connection settings and apply the default configuration for the web clie...: This is what was changed in this task in one patch. Sergey Ivanovskiy
02:13 AM User Interface Bug #7824: Simplify idle connection settings and apply the default configuration for the web clie...: Hynek, please review rev 14867 (7824a) that removed @MAX_HTTP_IDLE_TIMEOUT@ and added @CONNECTION_TIMEOUT@ and @INFIN... Sergey Ivanovskiy
08:38 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime: Rebased 6649b to latest trunk. 6649b is now at rev. 14878. Alexandru Lungu
05:54 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime: *Committed 6649b/rev.14849* where I made the following changes:
- Created @MonitorRunnable@ which allows identifying... Dănuț Filimon
08:13 AM Deployment Support #3303: make the automated deployment process fully production ready: The playbooks are 3 years old, were never 100% complete and we never got local execution running (even though we do v... Greg Shah
08:13 PM Deployment Support #3303: make the automated deployment process fully production ready: I have been looking closer at @mgmt@ since I'd like to use it to setup a customer's VM for supporting Docker images. ... Roger Borrello
07:53 AM Build and Source Control Support #5167: using static linking to eliminate the need to patch the system-wide ncurses: Then how do we provide a newer version outside of the standard workstation? Greg Shah
07:52 AM Database Bug #8101: Issue with temp-table defined as reference-only: This isn't likely to be a FWD issue. Don't make edits there yet. It is more likely a dependency on the 4GL code side... Greg Shah
06:40 AM Base Language Feature #6417: cleanup some known items in appserver support: > * argument translation to remote definition type I think is done the same as the CALL statement does it...
What do... Galya B

12/07/2023

06:13 PM Build and Source Control Support #5167: using static linking to eliminate the need to patch the system-wide ncurses: Greg Shah wrote:
> Is there some change in the scripts that our customers must use? If so, then it is a FWD issue.
... Roger Borrello
04:03 PM Build and Source Control Support #5167: using static linking to eliminate the need to patch the system-wide ncurses: Is there some change in the scripts that our customers must use? If so, then it is a FWD issue.
If this is just s... Greg Shah
03:56 PM Build and Source Control Support #5167: using static linking to eliminate the need to patch the system-wide ncurses: Greg Shah wrote:
> Is this something for the standard workstation or is it a FWD issue? You are posting in a task a... Roger Borrello
03:03 PM Build and Source Control Support #5167: using static linking to eliminate the need to patch the system-wide ncurses: Is this something for the standard workstation or is it a FWD issue? You are posting in a task about FWD, but your c... Greg Shah
06:08 PM Database Bug #8101: Issue with temp-table defined as reference-only: I think I found the issue. In the @TemporaryBuffer.java@... Theodoros Theodorou
03:01 PM User Interface Bug #7824: Simplify idle connection settings and apply the default configuration for the web clie...: Is there any documentation about the connection settings (the full set, not just the ones changed here)?
Hynek: Pl... Greg Shah
12:25 PM User Interface Bug #7824: Simplify idle connection settings and apply the default configuration for the web clie...: Could this task be reviewed? I rebased 7824a. Sergey Ivanovskiy
10:42 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...: Greg Shah wrote:
> Eric: Is @org.apache.commons.lang3.tuple.*@ a supported/approved library for use in persistence? ... Eric Faulhaber
10:06 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...: > I've been obedient adding the overloaded method with the logical name, but where is the java @SsoAuthenticator@ get... Greg Shah
09:55 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...: I've been obedient adding the overloaded method with the logical name, but where is the java @SsoAuthenticator@ getti... Galya B
09:51 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...: We're doing a default authentication for SSO login, where the customer should not know anything about the details, bu... Galya B
09:50 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...: Greg Shah wrote:
> Supplement to the code review: the @ldbname@ parameter must be processed case insensitively (e.g.... Galya B
09:45 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...: Supplement to the code review: the @ldbname@ parameter must be processed case insensitively (e.g. storing/retrieving ... Greg Shah
09:20 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...: >
> > Anyway, the directory database cfgs are there for runtime usage. Any usage from import is a side usage.
> >... Greg Shah
09:17 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...: Greg Shah wrote:
> > > I thought I had answered this in #7884-25. We are reworking the code DB logic into sessionle... Galya B
09:15 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...: > Such reader will need to learn to read the names of the classes and the javadoc, where it says:
My comment stand... Greg Shah
09:10 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...: Greg Shah wrote:
> > > 2. The logic in @connectToDb()@ which reads configuration from the directory is also somethin... Galya B
09:01 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...: Greg Shah wrote:
> Galya B wrote:
> > Greg Shah wrote:
> > > > 4. There is nothing hidden. The connection is clean... Galya B
09:00 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...: Galya B wrote:
> Greg Shah wrote:
> > > 4. There is nothing hidden. The connection is cleaned up on JVM shutdown.
... Greg Shah
08:58 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...: > > I thought I had answered this in #7884-25. We are reworking the code DB logic into sessionless code that is in F... Greg Shah
08:55 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...: > 2. Is it better to create a DB connection on each login attempt in a live system?
This was a retorical question. Galya B
08:54 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...: Greg Shah wrote:
> > 4. There is nothing hidden. The connection is cleaned up on JVM shutdown.
>
> I mean it is a... Galya B
08:52 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...: > 1. It's expected to be only one connection.
Per database instance. This may be many connections to a given clus... Greg Shah
08:50 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...: Greg Shah wrote:
> I thought I had answered this in #7884-25. We are reworking the code DB logic into sessionless c... Galya B
08:49 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...: > > 2. The logic in @connectToDb()@ which reads configuration from the directory is also something that should not be... Greg Shah
08:40 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...: Galya B wrote:
> Greg Shah wrote:
> > Code Review Task Branch 7884a Revision 14843
> >
> > 1. I think the logic ... Greg Shah
08:24 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...: Greg Shah wrote:
> 3. I don't think it is a good idea to implement long lived connections to the database here, nor ... Galya B
08:18 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...: Greg Shah wrote:
> 2. The logic in @connectToDb()@ which reads configuration from the directory is also something th... Galya B
08:15 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...: Greg Shah wrote:
> Code Review Task Branch 7884a Revision 14843
>
> 1. I think the logic for obtaining the defaul... Galya B
07:27 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...: Code Review Task Branch 7884a Revision 14843
1. I think the logic for obtaining the default database name (@Databa... Greg Shah
07:21 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...: Eric: Is @org.apache.commons.lang3.tuple.*@ a supported/approved library for use in persistence? I see it used there... Greg Shah
07:06 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...: r14843: @setuserid(userid, password, ldbname)@. Galya B
06:45 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...: It will optionally be present in the original 4GL code. There are 2 forms:
* @setuserid(userid, password)@
* @se... Greg Shah
02:26 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...: Greg Shah wrote:
> My primary concern is that we don't support the @ldbname@ parameter variant of @setuserid()@. I ... Galya B
02:22 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...: Ovidiu Maxiniuc wrote:
> For the second part. Provided the @ldbname@, the database configuration from registry can b... Galya B
09:23 PM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...: I reviewed the changes in 7884a.
I am OK with the changes. My concerns were for:
* duplicate code;
* hardcoded t... Ovidiu Maxiniuc
08:53 AM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception: Alexandru Lungu wrote:
> Regarding your last comment: it depends upon the delegate right? If the delegate is not len... Eduard Soltan
08:40 AM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception: Eduard, I started converting a really large application with 7045b (on top of 7156b). You have 3 days left to do the ... Alexandru Lungu
08:34 AM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception: I think is not needed, as @QueryWrapper@ is used in conversion of @open query@ statement. And in this case QQE is not... Eduard Soltan
08:04 AM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception: Alexandru, I haven't looked at the full code, but is the @QueryWrapper.handleQueryOffEnd@ still needed? Constantin Asofiei
08:34 AM Database Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools: Radu Apetrii wrote:
> I'm starting the rebase now. I'll update you when it is done so we can both do the tests.
Don... Radu Apetrii
08:13 AM Database Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools: I'm starting the rebase now. I'll update you when it is done so we can both do the tests. Radu Apetrii
08:07 AM Database Feature #7416 (Internal Test): Reiterate DatabaseStatistics and leverage to other database profli...: Lets move this into Internal Test and have it completely tested and merged. Even if these are refactorings, we still ... Alexandru Lungu
07:08 AM Base Language Feature #6417 (WIP): cleanup some known items in appserver support: Galya B
06:28 AM Database Feature #6496: add equivalent support for -trig command line option: Rebased 6496a to latest trunk. 6496a is now at rev. 14869
Alexandru [ad], please review @StartupParameters@ as there... Alexandru Lungu
04:08 AM Database Feature #6496: add equivalent support for -trig command line option: Commited the changes requested in branch 6496a rev 14748.
Also, should I add more comments inside the methods to exp... Alexandru Donica
08:57 PM Database Feature #6496: add equivalent support for -trig command line option: Had an idea for local optimisation: in @DTM.getSchemaTrigger()@, @proceduresClassMap@ is used to cache the converted ... Ovidiu Maxiniuc
02:19 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions: Eugenie Lyzenko wrote:
> In general I have no objections.
>
> But I have the question and the clear answer is ver... Galya B

12/06/2023

06:41 PM Build and Source Control Support #5167: using static linking to eliminate the need to patch the system-wide ncurses: I fixed an oversite in @files/setup_ncurses6x.sh@ such that the environment wasn't being updated properly, as well as... Roger Borrello
06:32 PM Database Feature #6496: add equivalent support for -trig command line option: Review of 6496a/14743-7:
Good job. I think the code is almost ready. Just a few minor things to adjust.
* @Data... Ovidiu Maxiniuc
04:20 PM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...: Code Review Task Branch 7884a Revisions 14840 through 14842
The overall approach is reasonable. Ovidiu and Eric w... Greg Shah
07:31 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...: 7884a r14842 ready for review. The dialect and conversion specifics now shared between @MetadataSecurityOps.NoSession... Galya B
05:23 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...: Galya, yes, @SQL_MODE_DEFAULT@ is the default if otherwise not specified in p2j.cfg.xml, as a @conversion="minimal"@ ... Constantin Asofiei
03:40 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...: Galya B wrote:
> Is the "conversion" always @SQL_MODE_DEFAULT@. I don't see a case where @NsConfig.setConversion@ is... Galya B
03:33 PM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions: In general I have no objections.
But I have the question and the clear answer is very important. How the custom th... Eugenie Lyzenko
12:56 PM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions: Eugenie/Hynek: Please review. Greg Shah
12:05 PM Deployment Support #8103: merge Hotel GUI, Hotel ChUI and implement a multi-modal template process: It would be easier to support a single Hotel project than to maintain two separate projects. We would need to merge ... Greg Shah
12:00 PM Deployment Support #8103 (New): merge Hotel GUI, Hotel ChUI and implement a multi-modal template process: Greg Shah
06:18 AM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception: Eduard, please focus on reaching a "state-of-the-art" solution for 7045b (also referring to #7045-84). Also, triple c... Alexandru Lungu
02:00 AM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception: Alexandru Lungu wrote:
> I've run 7045b with the performance tests and got 8.168s. Comparing to the baseline of 7.95... Eduard Soltan
05:28 AM Database Bug #8101: Issue with temp-table defined as reference-only: An exception is thrown when @TestCodepageConversions.cls@ is executed regarding temp-tables.
Ovidiu Maxiniuc wrote... Theodoros Theodorou
05:25 AM Database Bug #8101 (Closed): Issue with temp-table defined as reference-only: Theodoros Theodorou
05:08 AM Database Feature #7323: Implement soft unique index in FWD-H2: I've committed to 7323a rev. 14804-14805 some minor changes regarding:
* Fixed the validation condition in @Validati... Radu Apetrii

« Previous

Also available in: Atom

Project

General

Profile

FWD

Activity

Activity

01/04/2024

01/03/2024

01/02/2024

01/01/2024

12/28/2023

12/25/2023

12/23/2023

12/22/2023

12/21/2023

12/20/2023

12/19/2023

12/18/2023

12/15/2023

12/14/2023

12/13/2023

12/12/2023

12/11/2023

12/08/2023

12/07/2023

12/06/2023