Project

General

Profile

Activity

From 05/17/2025 to 06/15/2025

06/13/2025

05:56 PM Feature #10094: RECIDs from different tenants of same logical database should not overlap
I upgraded the project of the single customer to be MT-enabled. Committed to r89.
Here are the changes in @build.pro...
Ovidiu Maxiniuc
04:13 PM Bug #6767: Possible name clashes in DMO classes
I’m struggling to get the conversion to work as intended. For example, I’d like the @NEXT-SIBLING@ attribute converte... Vladimir Tsichevski
02:20 PM Bug #6767: Possible name clashes in DMO classes
Vladimir Tsichevski wrote:
> We should distinguish these cases within the conversion rules, perhaps using conditiona...
Constantin Asofiei
02:13 PM Bug #6767: Possible name clashes in DMO classes
Constantin Asofiei wrote:
> Vladimir Tsichevski wrote:
> > We need to update the conversion rules, as the correct m...
Vladimir Tsichevski
01:40 PM Bug #6767: Possible name clashes in DMO classes
Vladimir Tsichevski wrote:
> We need to update the conversion rules, as the correct method names are now @privateDat...
Constantin Asofiei
09:52 AM Bug #6767: Possible name clashes in DMO classes
Vladimir Tsichevski wrote:
> Constantin Asofiei wrote:
>
> > Looks like you don't need to revert.
> Good, now I ...
Vladimir Tsichevski

06/12/2025

12:11 PM Bug #6767: Possible name clashes in DMO classes
Constantin Asofiei wrote:
> Looks like you don't need to revert.
Good, now I am running a customer big applicatio...
Vladimir Tsichevski
12:02 PM Bug #6767: Possible name clashes in DMO classes
Vladimir Tsichevski wrote:
> Constantin Asofiei wrote:
> > Review of 6767c rev 15980.
> > * @AbstractTempTable@
>...
Constantin Asofiei
07:24 AM Bug #6767: Possible name clashes in DMO classes
Constantin Asofiei wrote:
> Review of 6767c rev 15980.
> * @AbstractTempTable@
> ** line 2938 - please add back @d...
Vladimir Tsichevski
05:05 AM Bug #6767: Possible name clashes in DMO classes
Review of 6767c rev 15980.
* @AbstractTempTable@
** line 2938 - please add back @defBuffer.bufferManager@ instead o...
Constantin Asofiei
10:22 AM Bug #9078: emit FindQuery as (reused) variables
Danut, just keep in mind that a Map has a higher overhead than a plain array. That is why I am suggesting creating an... Alexandru Lungu
02:24 AM Bug #9078: emit FindQuery as (reused) variables
Alexandru Lungu wrote:
> Dănuț Filimon wrote:
> > I did not take into account that there might be a limitation to t...
Dănuț Filimon

06/11/2025

05:28 PM Bug #6767: Possible name clashes in DMO classes
Eric Faulhaber wrote:
> Vladimir, this is a large set of changes. What testing do you propose?
I think, convert...
Vladimir Tsichevski
05:22 PM Bug #6767 (Review): Possible name clashes in DMO classes
Committed as 6767c rev. 15980. Please, review. Vladimir Tsichevski
12:13 PM Bug #6767: Possible name clashes in DMO classes
For @HandleChain@ and its ancestors I found 8 matching methods:... Vladimir Tsichevski
11:43 AM Bug #6767: Possible name clashes in DMO classes
Eric, Constantin,
I need you to confirm this:
*DMO setters* do not use *Java built-in types*. For example, we can...
Vladimir Tsichevski
04:28 PM Feature #10142: allow UDFs to live in the public schema instead a UDF-specific schema
A customer using PostgreSQL in the cloud requested that the native SQL UDFs representing Progress built-in functions ... Eric Faulhaber
04:16 PM Feature #10142 (New): allow UDFs to live in the public schema instead a UDF-specific schema
Eric Faulhaber
10:39 AM Bug #9078: emit FindQuery as (reused) variables
Dănuț Filimon wrote:
> I did not take into account that there might be a limitation to the number of local variables...
Alexandru Lungu
09:14 AM Bug #9078: emit FindQuery as (reused) variables
I did not take into account that there might be a limitation to the number of local variables that can be defined in ... Dănuț Filimon
08:36 AM Bug #9078: emit FindQuery as (reused) variables
I discussed with Artur and took time to take a look at all find queries from the problematic class. I took each one a... Dănuț Filimon
07:59 AM Feature #7504 (Internal Test): Export data tool from FWD into .d files
Lorian Sandu
07:50 AM Feature #7020: always use "expanded" extent fields
Constantin Asofiei wrote:
> Is @expand-extents=true@ now the default and we need to configure projects which can't u...
Stefanel Pezamosca
07:47 AM Feature #7020: always use "expanded" extent fields
Is @expand-extents=true@ now the default and we need to configure projects which can't use this mode explicitly in p2... Constantin Asofiei
07:17 AM Feature #10094: RECIDs from different tenants of same logical database should not overlap
I made sure the tables are not skipped if the @.d@ files are empty. Replacing all @System.out@ with proper logging.
...
Ovidiu Maxiniuc
08:07 PM Feature #10094: RECIDs from different tenants of same logical database should not overlap
Greg Shah wrote:
> We will need to have tested that as well to confirm that it resolves everything safely.
As a fir...
Ovidiu Maxiniuc

06/10/2025

03:07 PM Bug #6767: Possible name clashes in DMO classes
> And this refactor can be done automatically (with CTRL+SHIFT+G) in Eclipse, although each one needs to be done 'by ... Constantin Asofiei
02:14 PM Bug #6767 (WIP): Possible name clashes in DMO classes
Vladimir Tsichevski
02:13 PM Bug #6767: Possible name clashes in DMO classes
Constantin Asofiei wrote:
> Vladimir, did you use some script to 'sed' the changes?
No. I used Java reflection to c...
Vladimir Tsichevski
01:17 PM Bug #6767: Possible name clashes in DMO classes
Vladimir, did you use some script to 'sed' the changes? As Eric mentioned, there are lots of unintended changes. The... Constantin Asofiei
12:59 PM Bug #6767: Possible name clashes in DMO classes
Code review 6767b/15628-15629 (apologies for the long delay):
Overall, the changes look good, though I think we ar...
Eric Faulhaber
09:08 AM Feature #10094: RECIDs from different tenants of same logical database should not overlap
The ideal test 10094a would be to have a logical database with the shared db at least two tenant dbs. The customer di... Ovidiu Maxiniuc
08:50 AM Feature #10094: RECIDs from different tenants of same logical database should not overlap
> Please let me know if I got your question right.
Yes, mostly.
If the schema can be incorrect from prior runs ...
Greg Shah
08:24 AM Feature #10094: RECIDs from different tenants of same logical database should not overlap
What 10094a adds is that the empty tables from the (re-)imported database are guaranteed to be indexed.
Do you thi...
Ovidiu Maxiniuc
05:53 AM Feature #10094: RECIDs from different tenants of same logical database should not overlap
I'm trying to determine if we need to write a migration script to cleanup existing MT installations so that they matc... Greg Shah
09:02 AM Bug #10111 (WIP): All statements are logged to a single text file for P2JQueryLogger and SQLState...
Addressed the 1st and 2nd point in @10111a/15979@.
For the 3rd, I am thinking of creating a super class for those 2 ...
Andrei Plugaru
07:57 AM Bug #10111: All statements are logged to a single text file for P2JQueryLogger and SQLStatementLo...
+Review of 10111a/15978.+
The changes are logical. The reason is explained in 1st note above. Good catch!
The c...
Ovidiu Maxiniuc
06:34 AM Bug #10111 (Review): All statements are logged to a single text file for P2JQueryLogger and SQLSt...
Committed @10111a/15978@. The changes are quite simple: just removing the static keyword for @fileLogger@ in @SQLStat... Andrei Plugaru
06:33 AM Bug #10111 (WIP): All statements are logged to a single text file for P2JQueryLogger and SQLState...
Andrei Plugaru
06:02 AM Bug #10111: All statements are logged to a single text file for P2JQueryLogger and SQLStatementLo...
While using @SQLStatementLogger@ for multiple databases, I discovered that all the statements are logged to a single ... Andrei Plugaru
04:58 AM Bug #10111 (Test): All statements are logged to a single text file for P2JQueryLogger and SQLStat...
Andrei Plugaru
06:39 AM Bug #9078: emit FindQuery as (reused) variables
Artur ran a conversion for a customer application and found a conversion issue. I plan to work with Artur to identify... Dănuț Filimon
05:55 AM Bug #9994 (Rejected): Err: Cannot run GET methods on query until it is opened.
Greg Shah
01:56 AM Bug #9994: Err: Cannot run GET methods on query until it is opened.
This can be closed/rejected. Stefanel Pezamosca
03:14 AM Feature #9440 (Test): get-codepage() function should work with CLOB fields
Branch 9440a was merged to trunk rev 15975 and archived. Teodor Gorghe
02:49 AM Feature #9440 (Merge Pending): get-codepage() function should work with CLOB fields
Please rebase and merge 9440a now. Constantin Asofiei
12:18 AM Bug #10080: Temp-table records are leaking in can-find statements
Updated @query/canfindmultiplex@ testcases. Eduard Soltan

06/09/2025

07:37 PM Feature #10094: RECIDs from different tenants of same logical database should not overlap
I am not sure I fully understand the question.
TL;DR: If the import decides that a table is processed, the indexes...
Ovidiu Maxiniuc
08:03 AM Feature #10094: RECIDs from different tenants of same logical database should not overlap
Does this mean that existing imported databases may have some indexes which need to be dropped? Greg Shah

06/06/2025

06:55 PM Feature #10094: RECIDs from different tenants of same logical database should not overlap
As discussed with Constantin, I did a bit of reworking on the import to be sure the indexes of the tables are correct... Ovidiu Maxiniuc
08:14 PM Feature #10094 (Review): RECIDs from different tenants of same logical database should not overlap
I have created branch 10094a and committed the changes as revision 15970.
The implementation was actually easier t...
Ovidiu Maxiniuc
11:18 AM Bug #10083: Infinite loop when changing walking index fields
CHUI Regression tests passed with 10083a. ☑️
Large GUI Application unit tests passed. ☑️
Eduard Soltan
07:11 AM Bug #10083 (Internal Test): Infinite loop when changing walking index fields
Tomasz Domin wrote:
> Do you mean @10083a/15961@ as I can confirm that, results are fine with @10083a/15961@.
> Why...
Eduard Soltan
06:41 AM Bug #10083: Infinite loop when changing walking index fields
Eduard Soltan wrote:
> Tomasz Domin wrote:
> > Eduard Soltan wrote:
> > > Tomasz, could you run it again with 1008...
Tomasz Domin
05:40 AM Bug #10083: Infinite loop when changing walking index fields
Tomasz Domin wrote:
> Eduard Soltan wrote:
> > Tomasz, could you run it again with 10083-13 patch?
>
> The resul...
Eduard Soltan
02:46 AM Bug #10083: Infinite loop when changing walking index fields
Eduard Soltan wrote:
> Tomasz, could you run it again with 10083-13 patch?
The result stays the same:...
Tomasz Domin
02:34 AM Bug #10083: Infinite loop when changing walking index fields
Eduard Soltan wrote:
> Tomasz, could you run it again with 10083-13 patch?
I am working on this. Is this patch fo...
Tomasz Domin
02:23 AM Bug #10083: Infinite loop when changing walking index fields
Tomasz, could you run it again with 10083-13 patch? Eduard Soltan
10:55 AM Support #10101: broader testing of various database performance configuration options
Different database implementations offer various performance tuning configuration settings. For example, PostgreSQL o... Eric Faulhaber
02:08 AM Bug #10104: Analyze performance drop after rev. 15963
This task aims to analyze the performance drop of trunk rev 15963.
In one of our testing, a performance decrease of...
Andrei Iacob
01:58 AM Bug #10104 (New): Analyze performance drop after rev. 15963
Andrei Iacob

06/05/2025

03:51 PM Support #10101 (New): broader testing of various database performance configuration options
Eric Faulhaber
02:09 PM Bug #10080: Temp-table records are leaking in can-find statements
Tested performed:
- unit tests of a large gui application ✅
- chui regression tests ✅
Is any additional testin...
Eduard Soltan
02:00 AM Bug #10080: Temp-table records are leaking in can-find statements
Constantin Asofiei wrote:
> Eduard, please see #10088-57 - is this task fixing the CAN-FIND sub-select, so that now ...
Eduard Soltan
01:51 AM Bug #10080: Temp-table records are leaking in can-find statements
Eduard, please see #10088-57 - is this task fixing the CAN-FIND sub-select, so that now it correctly has the _multipl... Constantin Asofiei
12:39 PM Bug #10083: Infinite loop when changing walking index fields
Eduard Soltan wrote:
> Tomasz Domin wrote:
> > No wiki yet.
> > See #9270, #6860#80, @support/harness/readme.txt@ ...
Tomasz Domin
09:54 AM Bug #10083: Infinite loop when changing walking index fields
... Eduard Soltan
09:23 AM Bug #10083: Infinite loop when changing walking index fields
Tomasz Domin wrote:
> I've run @support/harness/test/cross_session_test.xml@ dirty share tests and they fail much mo...
Eduard Soltan
09:12 AM Bug #10083: Infinite loop when changing walking index fields
Tomasz Domin wrote:
> No wiki yet.
> See #9270, #6860#80, @support/harness/readme.txt@ (that will go into Wiki)
> ...
Eduard Soltan
05:53 AM Bug #10083: Infinite loop when changing walking index fields
No wiki yet.
See #9270, #6860#80, @support/harness/readme.txt@ (that will go into Wiki)
Attached @zfile_set.txt@ fo...
Tomasz Domin
05:04 AM Bug #10083: Infinite loop when changing walking index fields
Is there a wiki to run @support/harness/test/cross_session_test.xml@?. I tried to run them myself it was giving me al... Eduard Soltan
04:54 AM Bug #10083: Infinite loop when changing walking index fields
I've run @support/harness/test/cross_session_test.xml@ dirty share tests and they fail much more compared to @trunk@.... Tomasz Domin
12:12 PM Feature #7504: Export data tool from FWD into .d files
Lorian Sandu wrote:
> *Roger*, when you are available, please have a look.
Updates look good. Again, the use case f...
Roger Borrello
12:08 PM Feature #7504: Export data tool from FWD into .d files
Greg Shah wrote:
> Roger: I would prefer if @import.sh@ *did not* work on multiple database at once. The reasoning:...
Roger Borrello
10:00 AM Feature #7504: Export data tool from FWD into .d files
Roger: I would prefer if @import.sh@ *did not* work on multiple database at once. The reasoning: separate logs for e... Greg Shah
06:58 AM Feature #7504: Export data tool from FWD into .d files
Committed to @7504b / rev 15912@ :
@export.sh@:
* added support for multiple databases export
* added support fo...
Lorian Sandu
04:01 AM Feature #7504: Export data tool from FWD into .d files
Roger Borrello wrote:
> I'm also curious why you don't allow a list of DBs to be passed in, same as @import.sh@? I'm...
Lorian Sandu
09:15 AM Bug #9078: emit FindQuery as (reused) variables
Rebased *9078b* to latest *trunk/15969*, the branch is now at revision *15973*. Dănuț Filimon
03:20 AM Feature #9440: get-codepage() function should work with CLOB fields
Teodor Gorghe wrote:
> Ok, thanks.
> Related to this task, I noticed that the task status become "Internal Test".
...
Constantin Asofiei

06/04/2025

02:19 PM Feature #7504: Export data tool from FWD into .d files
> I don't think adding as a reviewer adds as a watcher... is that a function that can be added?
No
Greg Shah
11:07 AM Feature #7504: Export data tool from FWD into .d files
I'm also curious why you don't allow a list of DBs to be passed in, same as @import.sh@? I'm not sure I understand th... Roger Borrello
10:44 AM Feature #7504: Export data tool from FWD into .d files
Lorian Sandu wrote:
> Greg Shah wrote:
> > Roger: Please review @export.sh@.
>
> Roger, the revisions that need ...
Roger Borrello
08:56 AM Feature #7504: Export data tool from FWD into .d files
Greg Shah wrote:
> Roger: Please review @export.sh@.
Sorry I missed this. I don't think adding as a reviewer adds...
Roger Borrello
08:22 AM Feature #7504: Export data tool from FWD into .d files
Attached the @build.properties@, @build.xml@ and @build_db.xml@ from @hotel@ with support for @export@.
After revi...
Lorian Sandu
10:01 AM Bug #10080 (Internal Test): Temp-table records are leaking in can-find statements
I see nothing wrong with 10080a r15964.
Please proceed with testing (those from #8308 should do it) if the regress...
Ovidiu Maxiniuc
05:04 AM Bug #10080 (Review): Temp-table records are leaking in can-find statements
Eduard Soltan
05:02 AM Bug #10080 (WIP): Temp-table records are leaking in can-find statements
Committed on 10080a, rev. *15964*.
The parameters where not updating in case there were a multiplex id injected in...
Eduard Soltan
08:05 AM Feature #10094 (WIP): RECIDs from different tenants of same logical database should not overlap
During the runtime, the PKs even from different private tenants are unique across the logical database since all of t... Ovidiu Maxiniuc
07:31 AM Feature #10094 (Test): RECIDs from different tenants of same logical database should not overlap
Ovidiu Maxiniuc
05:01 AM Feature #7020: always use "expanded" extent fields
Radu tested @7020d@ with @<parameter name="expand-extents" value="false" />@ in @p2j.cfg.xml@ for the large GUI Appli... Stefanel Pezamosca

06/03/2025

03:01 PM Bug #10083: Infinite loop when changing walking index fields
I am not sure, but I think I made similar change in past and there was a problem. Let me check it with testcases/dirt... Tomasz Domin
01:47 AM Bug #10083 (Review): Infinite loop when changing walking index fields
Eduard Soltan
01:46 AM Bug #10083 (WIP): Infinite loop when changing walking index fields
With the patch from #10083-1, unit tests of a customer application does not get stuck in a infinite loop. Committed m... Eduard Soltan
04:05 AM Feature #7504: Export data tool from FWD into .d files
Greg Shah wrote:
> Roger: Please review @export.sh@.
Roger, the revisions that need to be reviewed from @7504b@ a...
Lorian Sandu
03:44 AM Bug #10080: Temp-table records are leaking in can-find statements
The scenario from #10076-1 is:... Șerban Bursuc

06/02/2025

04:38 PM Bug #10083: Infinite loop when changing walking index fields
Manage to create a small test case for infinite loop in unit tests in customer application. Please also look at the *... Eduard Soltan
04:37 PM Bug #10083 (Test): Infinite loop when changing walking index fields
Eduard Soltan
02:50 PM Feature #7504: Export data tool from FWD into .d files
Roger: Please review @export.sh@. Greg Shah
12:49 PM Feature #7504: Export data tool from FWD into .d files
I added the support for exporting using @ant export.db@ .
The changes are in @build.xml@ and @build_db.xml@.
Sh...
Lorian Sandu
10:34 AM Feature #7504: Export data tool from FWD into .d files
I created @export.sh@ and committed it to -@7504b / rev 15910@- @7504b / rev 15911@.
It it stored in @tools/script...
Lorian Sandu
09:16 AM Bug #10080: Temp-table records are leaking in can-find statements
Original test case can be found in #8308-505. There are also more tests committed in xfer testcases/1753.
The chan...
Dănuț Filimon
09:13 AM Bug #10080 (Test): Temp-table records are leaking in can-find statements
Dănuț Filimon
07:44 AM Feature #9440: get-codepage() function should work with CLOB fields
Ok, thanks.
Related to this task, I noticed that the task status become "Internal Test".
What tests do I need to run?
Teodor Gorghe
07:40 AM Feature #9440 (Internal Test): get-codepage() function should work with CLOB fields
I'm OK with the changes. Constantin Asofiei

05/31/2025

08:50 PM Feature #9456: implement SQL Server dialect and helpers
Revision 15960 of 9456a contains the fix from #9456-6. It was successful on hotel import and (probably - technical is... Ovidiu Maxiniuc

05/30/2025

01:33 PM Feature #9456: implement SQL Server dialect and helpers
MSSQL has this syntax - see https://stackoverflow.com/questions/767657/how-do-i-create-a-unique-constraint-that-also-... Constantin Asofiei
11:45 AM Feature #7504: Export data tool from FWD into .d files
Right :(. It was my developer side talking :). Ovidiu Maxiniuc
11:18 AM Feature #7504: Export data tool from FWD into .d files
The ant target is only there when the conversion project is there. In production, it is not there, so the @export.sh... Greg Shah
11:05 AM Feature #7504: Export data tool from FWD into .d files
My vote is for @ant@ target. It's more flexible and the configuration is already there (@build.properties@). Ovidiu Maxiniuc
03:36 AM Feature #7504: Export data tool from FWD into .d files
I think the best way to deliver this is through an @export.sh@ similar to @import.sh@ we already have.
You can also ...
Alexandru Lungu

05/29/2025

08:45 AM Feature #7504: Export data tool from FWD into .d files
Ovidiu Maxiniuc wrote:
> I had a look at r15908 of 7504b.
>
> I noticed that the @main()@ method in @ExportWorker...
Lorian Sandu
08:05 AM Feature #9831 (Closed): add admin API to set c3p0 configuration for individual tenant databases
Thanks, Brian! Greg Shah
07:53 AM Feature #9831: add admin API to set c3p0 configuration for individual tenant databases
Testing now that all three RedMine issues are in place with the directory.xml removal of breakAfterAcquireFailure
ht...
Brian Woodard

05/28/2025

01:26 PM Feature #9456: implement SQL Server dialect and helpers
To the list above I need to add another bullet:
* MSSQL does not allow multiple @null@ in unique indexes.
The solut...
Ovidiu Maxiniuc
12:16 PM Feature #7504: Export data tool from FWD into .d files
I had a look at r15908 of 7504b.
I noticed that the @main()@ method in @ExportWorker@ lacks the javadoc.
Also, ...
Ovidiu Maxiniuc
07:22 AM Feature #7504: Export data tool from FWD into .d files
Ovidiu Maxiniuc wrote:
> When I did the capture, I only looked up the occurrences, but did not do any further resear...
Lorian Sandu
10:05 AM Bug #10049 (Test): UDF configuration regression in Persistence.java
Branch 10049a was merged into trunk as rev. 15946 and archived. Ovidiu Maxiniuc
08:50 AM Bug #10049 (Merge Pending): UDF configuration regression in Persistence.java
Please merge 10049a now. Constantin Asofiei
03:10 AM Bug #9763 (Test): xml-node-name buffer option
9763b was merged to trunk rev. 15942 and archived. Eduard Soltan
03:00 AM Bug #9763 (Merge Pending): xml-node-name buffer option
Eduard, you can merge 9763b now. Constantin Asofiei

05/27/2025

03:53 PM Bug #10049: UDF configuration regression in Persistence.java
*There is no new UDF added. Only a small runtime change.*
As noted in first note, the problem was an incorrect det...
Ovidiu Maxiniuc
03:40 PM Bug #10049: UDF configuration regression in Persistence.java
This is only a runtime change, with no new UDF installation (or other special handling/configuration or devops) requi... Eric Faulhaber
03:18 PM Bug #10049: UDF configuration regression in Persistence.java
The aforementioned test passed. Ovidiu Maxiniuc
12:24 PM Feature #7504: Export data tool from FWD into .d files
OK, you mentioned only 2 occurrences, but I knew that there are more calls of the method from the base class.
When...
Ovidiu Maxiniuc
02:49 AM Feature #7504: Export data tool from FWD into .d files
Ovidiu Maxiniuc wrote:
> I'm also on Idea and I see 35 of them. Maybe you have a filter of some kind?
> I cannot ex...
Lorian Sandu
09:55 AM Bug #9763: xml-node-name buffer option
No, everything seems correct now. Ovidiu Maxiniuc
06:00 AM Bug #9763: xml-node-name buffer option
Review for 9763b rev 15950:
* BufferImpl - missing history number
* RecordBuffer - no actual change, use 'bzr rever...
Constantin Asofiei
02:56 AM Feature #7020: always use "expanded" extent fields
7020d was rebased to latest trunk (rev. 15941) and it's now at revision 15959. Stefanel Pezamosca

05/26/2025

05:37 PM Feature #9456: implement SQL Server dialect and helpers
With my latest changes from 9456a, I was able to convert and import the @hotel@ database into a MS SQL Server instanc... Ovidiu Maxiniuc
03:58 PM Bug #10049 (Internal Test): UDF configuration regression in Persistence.java
OK, then I am putting this to the test.
This area is accessed each time a @Persistence@ object is initialized. The...
Ovidiu Maxiniuc
02:22 PM Bug #10049: UDF configuration regression in Persistence.java
I'm OK with the changes. Constantin Asofiei
01:34 PM Bug #10049 (Review): UDF configuration regression in Persistence.java
Constantin, please review the fix since it is a bit different (I rewrote 4 lines to be more human readable) than what... Ovidiu Maxiniuc
01:32 PM Bug #10049 (Internal Test): UDF configuration regression in Persistence.java
Constantin noticed a flaw in the configuration of UDF (SQL native vs deprecated Java). Just by chance, I identified t... Ovidiu Maxiniuc
01:17 PM Bug #10049 (Test): UDF configuration regression in Persistence.java
Ovidiu Maxiniuc
12:15 PM Bug #9763: xml-node-name buffer option
Fixed rebase issues in rev. 15950. Is additional testing necessary? Eduard Soltan
10:55 AM Bug #9763: xml-node-name buffer option
I had one more quick look over 9763b, r15949.
In @BufferImpl.java@, I think there is a rebase error, @** 139 ES 2...
Ovidiu Maxiniuc
08:19 AM Bug #9763: xml-node-name buffer option
Eduard Soltan wrote:
> Yes it the 9763b branch, I run 9763b @bzr push --overwrite ~/secure/code/p2j_repo/p2j/active/...
Eduard Soltan
08:07 AM Bug #9763: xml-node-name buffer option
Ovidiu Maxiniuc wrote:
> Do you mean 9763b? The current revision is 15835. Is it possible you pushed to different br...
Eduard Soltan
08:03 AM Bug #9763: xml-node-name buffer option
Do you mean 9763b? The current revision is 15835. Is it possible you pushed to different branch? Ovidiu Maxiniuc
07:58 AM Bug #9763: xml-node-name buffer option
Rebased to latest trunk, *rev. 15937*. Did some quick smoke testing and unit tests of a large GUI application and it ... Eduard Soltan
11:14 AM Feature #7504: Export data tool from FWD into .d files
I'm also on Idea and I see 35 of them. Maybe you have a filter of some kind?
I cannot export this list so I attached...
Ovidiu Maxiniuc
08:16 AM Feature #7504: Export data tool from FWD into .d files
I've reviewed the usages of @toStringExport()@:
* Within the @raw@ class: it's only used in @toString()@, which can ...
Lorian Sandu
07:56 AM Feature #7504: Export data tool from FWD into .d files
+Review of 7504b / r15907+
I think there might be some issues with current changes from @raw@ class. The problem i...
Ovidiu Maxiniuc
07:28 AM Feature #7504: Export data tool from FWD into .d files
Ovidiu Maxiniuc wrote:
> +Review of 7504b / r15906+
>
> * @raw.java@: The problem is that the @toStringExport()@ ...
Lorian Sandu
05:23 AM Feature #9543 (Test): implement missing BUFFER attributes
9543b was merged to trunk 15936 and archived. Eduard Soltan
04:43 AM Feature #9543 (Merge Pending): implement missing BUFFER attributes
Please merge 9543b after 10027a Constantin Asofiei
01:32 AM Feature #9543: implement missing BUFFER attributes
Ovidiu Maxiniuc wrote:
> I think the update is safe.
>
> But, before the merge into trunk, please add the followi...
Eduard Soltan

05/23/2025

04:06 PM Feature #9543: implement missing BUFFER attributes
I think the update is safe.
But, before the merge into trunk, please add the following changes (no code affected, ...
Ovidiu Maxiniuc
05:30 AM Feature #9543: implement missing BUFFER attributes
Some additional testing should be performed or it could merged to trunk? Eduard Soltan
12:34 AM Feature #9543: implement missing BUFFER attributes
Summary of the testing performed:
- unit tests and smoke tests of large GUI appplication ✅
- smoke tests of a ...
Eduard Soltan
03:02 PM Feature #7504: Export data tool from FWD into .d files
+Review of 7504b / r15906+
Good job. Just some minor issues:
* @Record.java@:2099: a space is required after @if@...
Ovidiu Maxiniuc
07:32 AM Feature #7504: Export data tool from FWD into .d files
Thanks for the review, Ovidiu.
Sorry for the formatting issues, i've addressed all of them in rev @15906@.
> * ...
Lorian Sandu
12:40 PM Feature #7020: always use "expanded" extent fields
Roger Borrello wrote:
> Will the addition of this parameter in @p2j.cfg.xml@ break conversion if #7020 fix is not in...
Stefanel Pezamosca
12:37 PM Feature #7020: always use "expanded" extent fields
Stefanel Pezamosca wrote:
> Yes, that's correct.
Thanks. I have this in the @p2j.cfg.xml@ I will check into the p...
Roger Borrello
12:28 PM Feature #7020: always use "expanded" extent fields
Roger Borrello wrote:
> Stefanel Pezamosca wrote:
> > The thing changed in 7020d is the @denorm-extents@ from @p2j....
Stefanel Pezamosca
12:23 PM Feature #7020: always use "expanded" extent fields
Stefanel Pezamosca wrote:
> The thing changed in 7020d is the @denorm-extents@ from @p2j.cfg.xml@ that was renamed w...
Roger Borrello
11:15 AM Feature #7020: always use "expanded" extent fields
Alexandru Lungu wrote:
> > Does 7020d remove normalized extent support completely? If so, then we have to resolve #7...
Greg Shah
10:51 AM Feature #7020: always use "expanded" extent fields
Greg Shah wrote:
> Is there any reason to hold back 9537a? Has it been tested enough?
Yes 9537a has been tested an...
Stefanel Pezamosca
10:27 AM Feature #7020: always use "expanded" extent fields
> Does 7020d remove normalized extent support completely? If so, then we have to resolve #7020-122 before we merge. O... Alexandru Lungu
09:10 AM Feature #7020: always use "expanded" extent fields
Greg Shah wrote:
> > I think such process should be documented and create a task per customer (for us to test).
>
...
Lorian Sandu
09:07 AM Feature #7020: always use "expanded" extent fields
> I think such process should be documented and create a task per customer (for us to test).
Agreed.
It is my u...
Greg Shah
08:38 AM Feature #7020: always use "expanded" extent fields
> Are there any other tests that should be done for 7020d?
Stefanel, from my understanding, 7020d is making any sc...
Alexandru Lungu

05/22/2025

02:48 PM Feature #7504: Export data tool from FWD into .d files
+Review of 7504b / r15905+
It seems pretty advanced to me. None of the next issues are really serious, but they sh...
Ovidiu Maxiniuc
09:25 AM Feature #7504 (Review): Export data tool from FWD into .d files
I have committed my changes to @7504b / rev 15905@.
Ovidiu, when you have a moment, could you please take a look? ...
Lorian Sandu
10:02 AM Bug #10026: A multi-table AdaptiveQuery running off-end is still updating the cursor
I made a testcase: {{Collapse(See testcase)... Stefanel Pezamosca
03:33 AM Bug #9994 (Feedback): Err: Cannot run GET methods on query until it is opened.
Stefanel Pezamosca

05/21/2025

01:28 PM Feature #7504: Export data tool from FWD into .d files
While exporting data from a tenant database i found this error when reading a datetimetz value from the database
<pr...
Lorian Sandu
05:27 AM Feature #7504: Export data tool from FWD into .d files
Yes.
That's the *size of the payload*. In other words, *the offset at which the the footer starts* (the file offset ...
Ovidiu Maxiniuc
04:00 AM Feature #7504: Export data tool from FWD into .d files
The implementation is nearly complete; however, I still need some information regarding the PSC footer.... Lorian Sandu
10:09 AM Bug #10026: A multi-table AdaptiveQuery running off-end is still updating the cursor
> Do you have an example/testcase that shows this? At the moment I don't understand how this case should look like su... Alexandru Lungu
09:58 AM Bug #10026: A multi-table AdaptiveQuery running off-end is still updating the cursor
Alexandru Lungu wrote:
> * Extra: please check in OE what happens if buffers are loaded with something else before a...
Stefanel Pezamosca
04:58 AM Bug #10026 (WIP): A multi-table AdaptiveQuery running off-end is still updating the cursor
Stefanel Pezamosca
04:45 AM Bug #10026: A multi-table AdaptiveQuery running off-end is still updating the cursor
From #10000:
> First and foremost, there is Eduard's change in trunk rev. 15701 where buffers from components 2 on...
Alexandru Lungu
04:28 AM Bug #10026 (WIP): A multi-table AdaptiveQuery running off-end is still updating the cursor
Alexandru Lungu
09:50 AM Feature #9543: implement missing BUFFER attributes
Unit tests and fwd tests of large application passed. An issue was reported there but it seems that it was a problem ... Eduard Soltan
08:04 AM Feature #9440: get-codepage() function should work with CLOB fields
Commited revision *1758* on *testcases*.
Commited revision *15913* on P2J branch *9440a*.
Teodor Gorghe
05:40 AM Feature #9440: get-codepage() function should work with CLOB fields
Teodor Gorghe wrote:
> When using @get-codepage(buffer ttTable::fInt)@, on OpenEdge, it does not throw any error. Th...
Constantin Asofiei
05:11 AM Feature #9440: get-codepage() function should work with CLOB fields
When using @get-codepage(buffer ttTable::fInt)@, on OpenEdge, it does not throw any error. The returned value is @?@.... Teodor Gorghe
03:25 AM Feature #9440: get-codepage() function should work with CLOB fields
Please expand the test to also use @get-codepage(buffer ttTable::fClob)@ (i.e. the POLY case which should convert to ... Constantin Asofiei
03:23 AM Feature #9440: get-codepage() function should work with CLOB fields
I modified the @/tests/base_language/builtin_functions/functionality/TestGetCodepage.cls@ to use @SESSION:CPINTERNAL@... Teodor Gorghe
03:16 AM Feature #9440: get-codepage() function should work with CLOB fields
I'm OK with the changes in rev 15912.
What standalone tests did you use for this?
Constantin Asofiei
03:59 AM Feature #7020: always use "expanded" extent fields
Task branch 7020d was rebased to trunk revision 15922.
7020d is now at revision 15940.
Are there any other tests...
Stefanel Pezamosca
02:43 AM Bug #9969 (WIP): Parsing query string error with \r character.
Reverted rev *15910* and rev *15900* from trunk in *15920*. Octavian Adrian Gavril

05/20/2025

11:37 AM Feature #7020: always use "expanded" extent fields
Cool. I presumed that, but needed a confirmation. Ovidiu Maxiniuc
09:51 AM Feature #7020: always use "expanded" extent fields
Ovidiu Maxiniuc wrote:
> If I am not mistaken, in the case of the GUI project with harness test, the application is ...
Stefanel Pezamosca
09:39 AM Feature #7020: always use "expanded" extent fields
Nice catch!
The changes in 7020d, r15920 are good.
If I am not mistaken, in the case of the GUI project with harn...
Ovidiu Maxiniuc
07:35 AM Feature #7020: always use "expanded" extent fields
Lorian helped me test 7020d on his project. During the tests, we discovered an issue related to the SQL generation fo... Stefanel Pezamosca
06:06 AM Bug #9016 (Review): Improve performance in FQLPreprocessor by using astCache
Committed 9016a/15919. Added astCache to FQLPreprocessor().
Alexandru, please review.
Dănuț Filimon
06:06 AM Bug #9016 (WIP): Improve performance in FQLPreprocessor by using astCache
Had a discussion with Artur and this task was mentioned. However, this might not improve the performance in his scena... Dănuț Filimon
05:43 AM Feature #9440: get-codepage() function should work with CLOB fields
Commited revision 15912 on branch 9440a.
Replaced @new character()@ with @character.UNKNOWN@ on @longchar.getCodePag...
Teodor Gorghe
03:03 AM Bug #9994: Err: Cannot run GET methods on query until it is opened.
From my POV, I suggest waiting until we receive a clear response from the customer, as the original task is currently... Paula Păstrăguș
02:03 AM Bug #9994: Err: Cannot run GET methods on query until it is opened.
Since this task doesn't reflect the actual issue discovered in 9810-100, I think it should be marked as Rejected at t... Stefanel Pezamosca

05/19/2025

09:31 AM Feature #7504: Export data tool from FWD into .d files
Create a new task for the import bug. Greg Shah
09:26 AM Feature #7504: Export data tool from FWD into .d files
Lorian Sandu wrote:
> Greg Shah wrote:
> > > After import, the stored value in the database was @1919-12-31@ (disre...
Lorian Sandu
08:03 AM Feature #9440: get-codepage() function should work with CLOB fields
Commited revision 15911 on branch 9440a.
I changed the @builtin_functions.rules@, with the changes you provided. In ...
Teodor Gorghe
07:29 AM Feature #9440: get-codepage() function should work with CLOB fields
Review of 15910 rev 9440a:
* this must nest the @rule@s (like if/then/(if/then/else)/else); currently is is (if/then...
Constantin Asofiei
07:22 AM Feature #9440 (Review): get-codepage() function should work with CLOB fields
Teodor Gorghe
07:22 AM Feature #9440: get-codepage() function should work with CLOB fields
Commited revision 15910 on branch 9440a, with the changes according to the latest code review. Teodor Gorghe
03:31 AM Feature #9440 (WIP): get-codepage() function should work with CLOB fields
Teodor, review of 9440a rev 15909:
* @builtin_functions.rules@ - this code:...
Constantin Asofiei
02:24 AM Feature #9440 (Review): get-codepage() function should work with CLOB fields
Teodor Gorghe
04:25 AM Bug #9937 (Test): buffer argument with different DMO than the parameter
9937a was merged to trunk rev. 15914 and archived. Eduard Soltan
04:04 AM Bug #9937 (Merge Pending): buffer argument with different DMO than the parameter
Please merge 9937a now. Constantin Asofiei
03:48 AM Bug #9937: buffer argument with different DMO than the parameter
Testing of 2 customers applications went successful. Eduard Soltan
02:35 AM Bug #9969: Parsing query string error with \r character.
Ovidiu Maxiniuc wrote:
> After upgrading to trunk 15913 (including 15910), the antlr build target results in a lot (...
Octavian Adrian Gavril
 

Also available in: Atom