Project

General

Profile

Activity

From 07/06/2025 to 08/04/2025

08/04/2025

02:35 PM Bug #10351: ProDataSet READ-XML issue when temp-table node is the same as dataset node
OK, what you found is if the root node does not match the dataset, and is a temp-table (serialized) name, then the ro... Constantin Asofiei
05:56 AM Bug #10351: ProDataSet READ-XML issue when temp-table node is the same as dataset node
Constantin Asofiei wrote:
> Teodor, is this related to #10203 ?
The testcase that Dennis wrote on #10203 is relat...
Teodor Gorghe
05:49 AM Bug #10351: ProDataSet READ-XML issue when temp-table node is the same as dataset node
Teodor, is this related to #10203 ? Constantin Asofiei
01:54 PM Bug #10360 (WIP): FOR loop WHERE condition evaluation issue
Teodor, the fix is not OK. The root cause is the @block-level on error undo, throw.@ clause in FWD and an additional... Constantin Asofiei
05:46 AM Bug #10360: FOR loop WHERE condition evaluation issue
On FWD, without the 10360a rev 16084 fix, the test cases always fails when the handle is invalid, including @FOR EACH... Teodor Gorghe
04:41 AM Bug #10360: FOR loop WHERE condition evaluation issue
IMHO, there are multiple issues here:
* if no records actually "hit" the faulty clause, no error is thrown.
** if t...
Alexandru Lungu
01:48 AM Bug #10360 (Review): FOR loop WHERE condition evaluation issue
Teodor Gorghe
01:47 AM Bug #10360 (WIP): FOR loop WHERE condition evaluation issue
Teodor Gorghe
01:47 AM Bug #10360: FOR loop WHERE condition evaluation issue
Constantin Asofiei wrote:
> For now, lets fix it so that FWD doesn't abend - I assume the resolver/lambda? for this ...
Teodor Gorghe
10:43 AM Feature #6457: finish COPY-LOB support
Constantin Asofiei wrote:
> Review for 6457a rev 16070:
> * @Stream.java@ - why the reason for the commented co...
Eduard Soltan
06:35 AM Feature #6457 (WIP): finish COPY-LOB support
Review for 6457a rev 16070:
* missing history entry or copyright year update: @block_properties.rules@, @copy_lob.ru...
Constantin Asofiei
10:41 AM Bug #10285 (Internal Test): Static compound query returns no result
Yes, I think you are right. Your reasoning seems sound to me.
Let's get this into tests with the other testsets. Ple...
Ovidiu Maxiniuc
09:37 AM Bug #10285 (Review): Static compound query returns no result
*I have committed @10285a/16085@.* My changes make that FORWARD-ONLY result sets are created only if this entire cond... Andrei Plugaru
07:08 AM Bug #10285 (WIP): Static compound query returns no result
I think I understand the root cause of the issue.
In FWD, we already have a wrapper for the forward only result se...
Andrei Plugaru
08:16 AM Feature #9456: implement SQL Server dialect and helpers
Alexandru Lungu wrote:
> I am OK then with the changes to RAQ to distinguish between dirty and primary parameters....
Eduard Soltan
07:50 AM Feature #9456: implement SQL Server dialect and helpers
> Not only for that, there are cases when user defined where clause might be different in SqlServer dialect and H2 bu... Alexandru Lungu
05:55 AM Feature #9456: implement SQL Server dialect and helpers
Alexandru Lungu wrote:
> Review of 9456b:
> * I see plenty of @isLimitBeforeOffset@ checks that alter the behavior ...
Eduard Soltan
05:37 AM Feature #9456: implement SQL Server dialect and helpers
Alexandru Lungu wrote:
> Is @toWhereExpendeNullExpression@ a AND / OR based null check vs @toWhereExpression@ that...
Eduard Soltan
05:14 AM Feature #9456: implement SQL Server dialect and helpers
Review of 9456b:
* I see plenty of @isLimitBeforeOffset@ checks that alter the behavior of persistence code. Sometim...
Alexandru Lungu
04:52 AM Bug #10337 (Review): Possible memory leak with FastFindCache
I implemented the idea from #10337-19 (with a few changes) in 10337b/16074.
Alexandru, please review.
Artur Școlnic

08/01/2025

02:30 PM Bug #10360: FOR loop WHERE condition evaluation issue
Constantin Asofiei wrote:
> Ovidiu: do you recall some example where we emit a client-side WHERE in FWD, in conversi...
Ovidiu Maxiniuc
08:03 AM Bug #10360: FOR loop WHERE condition evaluation issue
For now, lets fix it so that FWD doesn't abend - I assume the resolver/lambda? for this argument is not properly exec... Constantin Asofiei
07:54 AM Bug #10360: FOR loop WHERE condition evaluation issue
I have updated the Test code from the #10360-2.
{{Collapse(Logs)...
Teodor Gorghe
07:39 AM Bug #10360: FOR loop WHERE condition evaluation issue
Teodor, please also add a test where @hdl::f3@ is a valid field and @hdl@ is a valid handle. Constantin Asofiei
07:26 AM Bug #10360: FOR loop WHERE condition evaluation issue
This one is weird, not in terms that it fails, but how 4GL behaves. In FWD, we evaluate all arguments before executi... Constantin Asofiei
07:02 AM Bug #10360: FOR loop WHERE condition evaluation issue
We have the following test case: {{Collapse(CODE)... Teodor Gorghe
06:53 AM Bug #10360 (Test): FOR loop WHERE condition evaluation issue
Teodor Gorghe
01:03 PM Feature #9456: implement SQL Server dialect and helpers
OK, I will remove the outer @if@. Ovidiu Maxiniuc
01:00 PM Feature #9456: implement SQL Server dialect and helpers
Constantin Asofiei wrote:
> * the @releaseSavepoint@ part - for non-local dbs, that should also check via JDBC for t...
Constantin Asofiei
12:43 PM Feature #9456: implement SQL Server dialect and helpers
Ovidiu, some notes:
* the @"FirstNumber".equals(firstColumnLabel)@ approach (appears twice now in the code) I think ...
Constantin Asofiei
12:33 PM Feature #9456: implement SQL Server dialect and helpers
I did the best effort to detect the dialect in @Session@ in order to avoid the NPE regression reported in #7143-1634 ... Ovidiu Maxiniuc
09:25 AM Feature #9456: implement SQL Server dialect and helpers
Alexandru, please review the @p2j.persist@ changes. Constantin Asofiei
07:13 AM Feature #9456: implement SQL Server dialect and helpers
Ovidiu, 9456b/16097 looks good (I've committed some formatting fixes).
Please commit the dialect NPE fix from #714...
Constantin Asofiei
07:37 AM Bug #6923: inner transaction block reverts too much
Alexandru Lungu wrote:
> > Thanks, then I have no other concerns for 6923a_h2 . The changes are additive and can be ...
Constantin Asofiei
07:19 AM Bug #6923: inner transaction block reverts too much
> Thanks, then I have no other concerns for 6923a_h2 . The changes are additive and can be merged to fwd-h2 trunk (an... Alexandru Lungu
06:59 AM Bug #6923: inner transaction block reverts too much
Thanks, then I have no other concerns for 6923a_h2 . The changes are additive and can be merged to fwd-h2 trunk (and... Constantin Asofiei
06:57 AM Bug #6923: inner transaction block reverts too much
> What happens at this step in FWD, when the sub-tx is rollbacked? I assume the record is removed completely from the... Alexandru Lungu
06:52 AM Bug #6923: inner transaction block reverts too much
Constantin Asofiei wrote:
> Also, you are missing assigning the multiplex ID to the row, @reclaimPrimaryKey@.
But w...
Constantin Asofiei
06:36 AM Bug #6923: inner transaction block reverts too much
Also, in other words, after the sub-tx was rolled back: the newly created record still survives, and needs its PK to ... Constantin Asofiei
06:34 AM Bug #6923: inner transaction block reverts too much
Alexandru Lungu wrote:
> * record is created (claiming a new key)
OK, so this adds the record to the multiplex inde...
Constantin Asofiei
06:22 AM Bug #6923: inner transaction block reverts too much
> I think if a row is added to the scan index, then all indexes need to see this row.
My code is mostly like @getN...
Alexandru Lungu
06:20 AM Bug #6923: inner transaction block reverts too much
> Alexandru, how is reclaimPrimaryKey supposed to be used?
I can agree that my implementation was quite aggresive....
Alexandru Lungu
06:10 AM Bug #6923: inner transaction block reverts too much
Alexandru, how is @reclaimPrimaryKey@ supposed to be used?
With 6923a_h2/60, we leave the table indexes in an inco...
Constantin Asofiei
05:43 AM Bug #6923: inner transaction block reverts too much
Constantin, just a reminder. Please review 6923a_h2/60. I want to merge it to FWD_H2 trunk and eventually make a rele... Alexandru Lungu
06:06 AM Bug #10337: Possible memory leak with FastFindCache
... Alexandru Lungu
06:00 AM Bug #10337: Possible memory leak with FastFindCache
Although, invalidation of the L3 caches on revereseLookup/LRUList expiry would be a nightmare. We would need to keep ... Artur Școlnic
05:54 AM Bug #10337: Possible memory leak with FastFindCache
How about... Artur Școlnic
05:52 AM Bug #10337: Possible memory leak with FastFindCache
> Map<RecordIdentifier<String>, LRUList<L2Key>> reverseLookup = new WeakHashMap<>();
Considering the L3 cache for ...
Alexandru Lungu
05:50 AM Bug #10337: Possible memory leak with FastFindCache
Well, I guess a map with weak references as keys is a WeakHashMap :) Artur Școlnic
05:49 AM Bug #10337: Possible memory leak with FastFindCache
Alexandru Lungu wrote:
> But I want to express my concern of the fact that we are *still* allowing the reverse-look-...
Artur Școlnic
05:35 AM Bug #10337: Possible memory leak with FastFindCache
> I think that if we make the reverseLookup a LRU cache with weak referenced keys, we can unbound the L3 cache.
Te...
Alexandru Lungu
03:52 AM Feature #6457 (Review): finish COPY-LOB support
I'll review the first pass and we'll work on the codepage problems in a second branch. Constantin Asofiei
01:28 AM Bug #10351: ProDataSet READ-XML issue when temp-table node is the same as dataset node
Committed revision *16081* on task branch *10351a*:
- Added some @isRoot = false@ before break because the next stre...
Teodor Gorghe

07/31/2025

12:35 PM Bug #10337: Possible memory leak with FastFindCache
Artur Școlnic wrote:
> Alternatively, we can disregard the ReveresLookup class in favor of a more light weight solut...
Artur Școlnic
12:02 PM Bug #10337: Possible memory leak with FastFindCache
Alternatively, we can disregard the ReveresLookup class in favor of a more light weight solution:... Artur Școlnic
10:47 AM Bug #10337: Possible memory leak with FastFindCache
Alexandru, what if we introduce a new type of LRU that has weak references as keys? This will take care of the situat... Artur Școlnic
06:25 AM Bug #10337 (WIP): Possible memory leak with FastFindCache
Artur, please reassess #10337-14 issue and #10337-19 idea. ReverseLookup collections are a 2D caches. Introducing a L... Alexandru Lungu
10:10 AM Feature #10325 (Review): Optimize AdaptiveQuery for single-result scenarios
I have committed @10325a/16076@. This revision contains mostly cosmetic changes.
I have run the performance test sui...
Andrei Plugaru
09:17 AM Bug #10351 (Review): ProDataSet READ-XML issue when temp-table node is the same as dataset node
Committed revision *16080* on task branch *10351a*:
- @DATASET:READ-XML@ added support for buffer as root node.
T...
Teodor Gorghe
04:44 AM Bug #10351 (WIP): ProDataSet READ-XML issue when temp-table node is the same as dataset node
Created task branch *10351a*. Teodor Gorghe
04:22 AM Bug #10351: ProDataSet READ-XML issue when temp-table node is the same as dataset node
On OE 4GL, you can define XML input files, for static and dynamic datasets, with a structure like this:... Teodor Gorghe
04:16 AM Bug #10351 (Test): ProDataSet READ-XML issue when temp-table node is the same as dataset node
Teodor Gorghe

07/30/2025

03:10 PM Bug #10337 (Review): Possible memory leak with FastFindCache
Alexandru Lungu wrote:
>
> However, in the heap dump I analyzed, @emptyRecordsCache@ was (surprisingly) mostly emp...
Artur Școlnic
07:07 AM Bug #10337: Possible memory leak with FastFindCache
> I think that the memory leak in 9802f was caused mainly by the absence of a designated ExpiryListener for the empty... Alexandru Lungu
06:46 AM Bug #10337: Possible memory leak with FastFindCache
I think that the memory leak in 9802f was caused mainly by the absence of a designated @ExpiryListener@ for the @empt... Artur Școlnic
03:44 AM Bug #10337: Possible memory leak with FastFindCache
In fact, I think there is a small caveat. We still need a @touch@ mechanism so that the LRU cache will mark the @Node... Alexandru Lungu
03:31 AM Bug #10337 (WIP): Possible memory leak with FastFindCache
Alexandru Lungu
03:31 AM Bug #10337: Possible memory leak with FastFindCache
Review of 10337b:... Alexandru Lungu

07/29/2025

01:17 PM Feature #9456: implement SQL Server dialect and helpers
Committed on 9456b, rev. 16081.
Reverted boolean conversion for dirty database, separated parameters for FQL query...
Eduard Soltan
10:18 AM Feature #9456: implement SQL Server dialect and helpers
Ovidiu Maxiniuc wrote:
> But that is not always the case. There are cases when an UDF (in H2 that is a method from...
Eduard Soltan
09:40 AM Feature #9456: implement SQL Server dialect and helpers
Yes, that is only a particular case of transformation. Also, many of the transformations, although more complicated (... Ovidiu Maxiniuc
09:29 AM Feature #9456: implement SQL Server dialect and helpers
Ovidiu Maxiniuc wrote:
> This is most likely incorrect: if the primary is MSSQL, this will cause the booleans to b...
Eduard Soltan
09:19 AM Feature #9456: implement SQL Server dialect and helpers
Eduard Soltan wrote:
> Committed on 9456b, rev. 16076.
> Convert booleans for dirty database in case primary databa...
Ovidiu Maxiniuc
06:53 AM Feature #9456: implement SQL Server dialect and helpers
Committed on 9456b, rev. 16077. AddInterval and GetInterval function fix-ups Eduard Soltan
04:10 AM Feature #9456: implement SQL Server dialect and helpers
Committed on 9456b, rev. 16076.
Convert booleans for dirty database in case primary database does not support bool...
Eduard Soltan
03:25 AM Feature #9456: implement SQL Server dialect and helpers
*Eduard* - there are usages of 'lower' in @udf/sqlserver/udfs.sql@ where it matches with an uppercase text, see:
<pr...
Constantin Asofiei
10:50 AM Feature #10325 (WIP): Optimize AdaptiveQuery for single-result scenarios
I have continued implementation for this task.
For the issue spotted in the last part of #10325-4, I have stopped f...
Andrei Plugaru
09:32 AM Bug #10026: A multi-table AdaptiveQuery running off-end is still updating the cursor
I made some more experiments related with Scrolling/Non-Scrolling Queries.
For this testcase: {{Collapse(Scrolling &...
Stefanel Pezamosca
06:02 AM Bug #10337: Possible memory leak with FastFindCache
Artur, please archive branches after you merge them - 10337a is still 'active'.
Constantin Asofiei

07/28/2025

11:31 AM Feature #10094: RECIDs from different tenants of same logical database should not overlap
The erroneous output of the _seqno to log files fixed against this RedMine and reported against https://proj.goldenco... Brian Woodard
11:30 AM Feature #6457: finish COPY-LOB support
I am not really sure how the conversion happens in UTF-8 character to ISO-8859-1 in 4GL.
h3. Test 1
-Cpinternal...
Eduard Soltan
02:46 AM Feature #6457: finish COPY-LOB support
Committed on 6457a, rev. 16069.
- Added NO-CONVERT conversion support + plus error handling. From the docs:...
Eduard Soltan
04:32 AM Bug #10171 (Internal Test): Word Index/CONTAINS support for MS SQL Server.
I tested 9456a with a few standalone testcases I made with CONTAINS and they were ok. 9456a was already merged to tru... Stefanel Pezamosca

07/26/2025

08:15 AM Bug #10337 (Review): Possible memory leak with FastFindCache
I overhauled the ReverseLookup and brought back the changes from 9802f, tested the code and it is as fast as 9802f, I... Artur Școlnic

07/25/2025

10:37 AM Feature #10325: Optimize AdaptiveQuery for single-result scenarios
I have continued with the integration of Alex's idea from @9724b@ regarding moving the break position in the index ba... Andrei Plugaru
09:32 AM Bug #10337: Possible memory leak with FastFindCache
Reverted the changes from trunk rev 16051. I will create 10337b and use it to bring those back with a more robust mem... Artur Școlnic
08:18 AM Bug #10337 (WIP): Possible memory leak with FastFindCache
I identified the culprit for the real memory leak:
* there is a FIND done in a @while true@
* first time is inser...
Alexandru Lungu
07:56 AM Bug #10337 (Test): Possible memory leak with FastFindCache
Greg Shah
09:32 AM Feature #9456: implement SQL Server dialect and helpers
Committed on 9456b, rev. 16071.
Revision *16071* contains changes from 10283a, this fixes the @coalesce@, and fix...
Eduard Soltan
04:07 AM Bug #10302: checkUniqueFind in FQLPreprocessor doesn't work properly
While working on another task, I probably discovered a functional issue in FWD caused by the problem reported in this... Andrei Plugaru
03:00 AM Support #6709: track nested FIND inside a related FOR loop
Dănuț Filimon wrote:
> I committed *6709a/16053*. There was an issue with RuntimeJastInterpreter.java where the Data...
Dănuț Filimon

07/24/2025

10:20 AM Bug #10337: Possible memory leak with FastFindCache
10337a was merged to trunk as rev 16069. Artur Școlnic
10:15 AM Bug #10337 (Merge Pending): Possible memory leak with FastFindCache
Please merge to trunk. Alexandru Lungu
10:11 AM Bug #10337: Possible memory leak with FastFindCache
Harness and webui navigation passed. Artur Școlnic
10:06 AM Bug #10337 (Internal Test): Possible memory leak with FastFindCache
I am OK with the changes. Please proceed with regression testing. Alexandru Lungu
10:03 AM Bug #10337: Possible memory leak with FastFindCache
I changed it. Artur Școlnic
10:00 AM Bug #10337: Possible memory leak with FastFindCache
... Alexandru Lungu
09:43 AM Bug #10337: Possible memory leak with FastFindCache
I extended the check to resolvable also, the code is in rev 16070. Artur Școlnic
09:35 AM Bug #10337: Possible memory leak with FastFindCache
Review of 10337a.
* The fix is almost complete. You are missing the cases where @resolved[i] = ((Resolvable) subst)....
Alexandru Lungu
09:15 AM Bug #10337 (Review): Possible memory leak with FastFindCache
I committed the fix to 10337a/16069. Artur Școlnic
08:52 AM Bug #10337: Possible memory leak with FastFindCache
PS: this is not caused directly by #9802, but rather a latent bug that is exposed by more "intensive" caching. Alexandru Lungu
08:49 AM Bug #10337 (WIP): Possible memory leak with FastFindCache
Artur, I think I identified a reason for a memory leak for the changes. This is only based on static analysis.
The...
Alexandru Lungu
08:40 AM Bug #10337 (Test): Possible memory leak with FastFindCache
Alexandru Lungu
10:16 AM Bug #6923: inner transaction block reverts too much
> A new direct-access API to reclaim a PK. This is used for rollbacked records that were flushed, but reverted back t... Alexandru Lungu
09:49 AM Support #6709 (Review): track nested FIND inside a related FOR loop
I committed *6709a/16053*. There was an issue with RuntimeJastInterpreter.java where the DataModelObject array was no... Dănuț Filimon
07:17 AM Support #6709 (WIP): track nested FIND inside a related FOR loop
I am putting this into WIP as I am close to getting the runtime changes done, so I'd rather get a review for all of t... Dănuț Filimon
07:52 AM Feature #10094 (Test): RECIDs from different tenants of same logical database should not overlap
Branch 10094a was merged into trunk as r16066 and was archived. Ovidiu Maxiniuc
04:04 AM Feature #10094 (Merge Pending): RECIDs from different tenants of same logical database should not...
> Ovidiu/Alexandru, 10094a needs to be merged today, if we plan to push to xfer.
This can be merged now.
Alexandru Lungu
03:03 AM Feature #10094: RECIDs from different tenants of same logical database should not overlap
Ovidiu/Alexandru, 10094a needs to be merged today, if we plan to push to xfer. Constantin Asofiei
07:32 AM Feature #10325: Optimize AdaptiveQuery for single-result scenarios
I have further investigated this. Currently, switching the AdaptiveQuery into dynamic mode will lead to the query fro... Andrei Plugaru

07/23/2025

06:55 PM Feature #10094: RECIDs from different tenants of same logical database should not overlap
Both aforementioned regression tests passed. Ovidiu Maxiniuc
05:31 PM Feature #10094: RECIDs from different tenants of same logical database should not overlap
The only untested part is the very last commit (related to @setval@ for sequences). It passed my local tests, but I h... Ovidiu Maxiniuc
04:57 PM Feature #10094 (Internal Test): RECIDs from different tenants of same logical database should not...
Code review 10094a/16073-16074:
The changes look good to me.
What testing, if any, is left to do?
Eric Faulhaber
01:35 PM Feature #10094: RECIDs from different tenants of same logical database should not overlap
Thank you Ovidiu for the update and fix. We were going to report separately. Carson Mader
01:34 PM Feature #10094: RECIDs from different tenants of same logical database should not overlap
Carson, you are right. this is the exact issue the last commit will fix. It is a regression introduced in the last we... Ovidiu Maxiniuc
01:11 PM Feature #10094: RECIDs from different tenants of same logical database should not overlap
Ovidiu Maxiniuc wrote:
> 10094a was rebased. Additionally, it contains the fix for set sequence value for PGSQL dial...
Carson Mader
12:12 PM Feature #10094 (Review): RECIDs from different tenants of same logical database should not overlap
10094a was rebased. Additionally, it contains the fix for set sequence value for PGSQL dialect, as discussed in stand... Ovidiu Maxiniuc
10:40 AM Support #4080: AWS Aurora support
I think this can be closed, but we should document that we support Aurora. Greg Shah
10:37 AM Feature #6454: database informational features
Eric: Can we close this? Greg Shah
07:31 AM Feature #10310: move tenant database from one multitenant cluster to another
The @recid@ uniqueness in FWD maps to the FWD server, not to the PostgreSQL cluster. This means that this migration ... Greg Shah
07:26 AM Feature #10325: Optimize AdaptiveQuery for single-result scenarios
An initial approach I have tried is to make the @AdaptiveQuery@ run into dynamic mode when we know it matches at most... Andrei Plugaru
04:53 AM Feature #9456: implement SQL Server dialect and helpers
I have fixed syntax for set sequence value in PostgreSQL dialect in 9457c/16098. I think we need to get this patch in... Ovidiu Maxiniuc
02:24 AM Feature #9456: implement SQL Server dialect and helpers
*Ovidiu*, the following statement does not work after *9456a* changes (with tstcasesdb database):
- @CURRENT-VALUE (...
Teodor Gorghe

07/22/2025

01:36 PM Feature #10094: RECIDs from different tenants of same logical database should not overlap
Eric,
Yesterday I've updated the branch 10094a according to suggestions in the review from #note-26. It was also r...
Ovidiu Maxiniuc
12:34 PM Feature #6457: finish COPY-LOB support
Eduard Soltan wrote:
> I will look into it. I observed how transaction is handled in @buffer-copy@ or other similar ...
Constantin Asofiei
12:33 PM Feature #6457: finish COPY-LOB support
Constantin Asofiei wrote:
> Eduard Soltan wrote:
> > Committed on 6457a, rev. 16066.
> >
> > - Emit @Transaction...
Eduard Soltan
12:14 PM Feature #6457: finish COPY-LOB support
Eduard Soltan wrote:
> Committed on 6457a, rev. 16066.
>
> - Emit @Transaction.FULL@ parameter when target of cop...
Constantin Asofiei
12:12 PM Feature #6457: finish COPY-LOB support
Committed on 6457a, rev. 16066.
- Emit @Transaction.FULL@ parameter when target of copy-lob operation is a persist...
Eduard Soltan
11:28 AM Feature #10310: move tenant database from one multitenant cluster to another
Just to be sure I understand the goal of this new FWD tool: the idea is to balance the load of FWD servers by migrati... Ovidiu Maxiniuc
10:43 AM Bug #6923: inner transaction block reverts too much
I have reviewed the changes in 6923a/r16049. I think the code will work. Thank you for adding comments with the chang... Ovidiu Maxiniuc
07:36 AM Feature #10325: Optimize AdaptiveQuery for single-result scenarios
The scope of this task is to optimize the @AdaptiveQuery@ into @RandomAccessQuery@ when we know that the where clause... Andrei Plugaru
03:17 AM Feature #10325 (Review): Optimize AdaptiveQuery for single-result scenarios
Andrei Plugaru
04:20 AM Support #6709: track nested FIND inside a related FOR loop
Dănuț Filimon wrote:
> I see the ChUI project used @datanames.xml@ which also changes how the converted project sees...
Dănuț Filimon

07/21/2025

01:03 PM Feature #6457: finish COPY-LOB support
First major problem found, it is common for around 100 tests.... Eduard Soltan
12:38 PM Feature #6457: finish COPY-LOB support
Greg Shah wrote:
> From the wiki:
>
> > All files from @tests/copy_lob/support/data@ should be moved to @deploy/c...
Eduard Soltan
10:55 AM Feature #6457: finish COPY-LOB support
From the wiki:
> All files from @tests/copy_lob/support/data@ should be moved to @deploy/client/tests/copy_lob/sup...
Greg Shah
10:29 AM Feature #6457: finish COPY-LOB support
After solving all configuration issues, I was left only with assertion errors which should be investigated.... Eduard Soltan
09:05 AM Feature #6457: finish COPY-LOB support
As you work through issues in these tests, please update [[p2j:LOB Tests]] with details of the test status and how to... Greg Shah
08:26 AM Feature #6457: finish COPY-LOB support
After creating the following path in @deploy/client/tests/copy_lob/support/data@, I get the following results:
<pr...
Eduard Soltan
08:07 AM Feature #6457: finish COPY-LOB support
Got the following after running @testcases/tests/copy_lob/@... Eduard Soltan
07:36 AM Feature #6457: finish COPY-LOB support
Greg Shah wrote:
> The BOM handling has a testcase already written. See @testcases/copy_lob/tests/bom.p@.
Greg/S...
Eduard Soltan
06:25 AM Feature #6457: finish COPY-LOB support
> Stanislav: please summarize any work done for this task
I didn't produce any testcases and used the existing one...
Stanislav Lomany
06:00 AM Feature #6457: finish COPY-LOB support
Stanislav: please summarize any work done for this task
Eduard: please look into the xfer testcase, run them in FW...
Constantin Asofiei
10:47 AM Bug #6923: inner transaction block reverts too much
Committed xfer/testcases rev. 1792 with my unit tests for this. "safe" suites are ones that are cut-out in terms of p... Alexandru Lungu
10:43 AM Bug #6923 (Review): inner transaction block reverts too much
I committed 6923a/16047 and 6923a/16048 with:
* Fixed re-reserving of the PK after rollbacking flushed NEW records (...
Alexandru Lungu
09:47 AM Support #6709: track nested FIND inside a related FOR loop
I see the ChUI project used @datanames.xml@ which also changes how the converted project sees the bufname and filenam... Dănuț Filimon
08:57 AM Support #6709: track nested FIND inside a related FOR loop
I'll have to work on the conversion changes a bit more, the bufname is not the right one to use in this case. I've fo... Dănuț Filimon
07:34 AM Support #6709: track nested FIND inside a related FOR loop
I implemented the conversion changes necessary, this works by emitting a DataModelObject array before the Object arra... Dănuț Filimon
06:55 AM Feature #9456 (WIP): implement SQL Server dialect and helpers
Ovidiu Maxiniuc
06:48 AM Feature #9456: implement SQL Server dialect and helpers
I have created 9456b from trunk 16062 for subsequent changes. Ovidiu Maxiniuc
06:46 AM Feature #9456: implement SQL Server dialect and helpers
Branch 9456a was merged into trunk as 16062 then it was archived. Ovidiu Maxiniuc
05:47 AM Feature #9456: implement SQL Server dialect and helpers
I peeked at r16089. There are some updates which do not seem logical (although they will work with the default CI col... Ovidiu Maxiniuc
04:57 AM Feature #9456 (Merge Pending): implement SQL Server dialect and helpers
Ovidiu, please merge 9456a after 10114b. Constantin Asofiei
04:54 AM Feature #9456: implement SQL Server dialect and helpers
Committed on 9456a, rev. 16089. Added some udfs functions overloads, and small functions fix ups. Only @sqlserver/udf... Eduard Soltan
04:06 AM Feature #9456: implement SQL Server dialect and helpers
Eduard, please double-check your pending UDF changes for SqlServer and after that commit them to 9456a. We will merg... Constantin Asofiei

07/18/2025

05:18 PM Feature #10310: move tenant database from one multitenant cluster to another
In a multitenant environment, there is a requirement to "move" a tenant database instance from one database cluster t... Eric Faulhaber
04:52 PM Feature #10310 (New): move tenant database from one multitenant cluster to another
Eric Faulhaber
04:50 PM Feature #10094: RECIDs from different tenants of same logical database should not overlap
Code review 10094a/16060-16062:
Looks good overall.
The only objection I have is that the dialect-specific erro...
Eric Faulhaber
10:07 AM Bug #6923: inner transaction block reverts too much
What I continued investigating:
* I made the H2 changes to "reclaimPrimaryKey" if the DMO was NEW in the outer sub-t...
Alexandru Lungu
06:54 AM Support #6709: track nested FIND inside a related FOR loop
> If conversion changes are acceptable, this is what I'd like to do.
Yes, go ahead.
Greg Shah
06:50 AM Support #6709: track nested FIND inside a related FOR loop
Greg Shah wrote:
> Dănuț Filimon wrote:
> > [...]
> >
> > I can't come up with any idea on how to let the FindQu...
Dănuț Filimon
06:47 AM Support #6709: track nested FIND inside a related FOR loop
Dănuț Filimon wrote:
> [...]
>
> I can't come up with any idea on how to let the FindQuery that @tt2@ is a refere...
Greg Shah
03:51 AM Support #6709: track nested FIND inside a related FOR loop
... Dănuț Filimon
05:02 AM Bug #9078: emit FindQuery as (reused) variables
I did a ChUI conversion and the project built with no issues, I noticed both the array and variable FindQuery types b... Dănuț Filimon
03:13 AM Feature #9456 (Internal Test): implement SQL Server dialect and helpers
Ovidiu, please consider 9456a frozen for testing. Constantin Asofiei
08:16 PM Feature #9456: implement SQL Server dialect and helpers
I added missing javadoc and reverted blank changes.
The support for boolean data type should be working correctly no...
Ovidiu Maxiniuc

07/17/2025

05:03 PM Feature #10094: RECIDs from different tenants of same logical database should not overlap
I used branch 10094a to test the import process on a large ST database and performed a smoke-test on it. No problems ... Ovidiu Maxiniuc
11:06 AM Bug #10307: FFcache keys don't match for the values inlined vs passed as args
While working on #8279, found a scenario where the a record wasn't retrieved from the FF cache, even though it should... Andrei Plugaru
11:02 AM Bug #10307 (New): FFcache keys don't match for the values inlined vs passed as args
Andrei Plugaru
11:01 AM Bug #10302: checkUniqueFind in FQLPreprocessor doesn't work properly
While working on #8279, I tried to understand how many @AdaptiveQuery@ s have the where clause matching an unique ind... Andrei Plugaru
07:37 AM Bug #10302 (New): checkUniqueFind in FQLPreprocessor doesn't work properly
Andrei Plugaru
07:57 AM Bug #9683: CompoundQuery is doing extra hydration attempts
I assume we will finish this task first, but I am highlighting that we *really need to finish* the general solution t... Greg Shah
02:17 AM Bug #9683: CompoundQuery is doing extra hydration attempts
Greg Shah wrote:
> We need to finish the work in #6720.
Before finishing up #9683 or instead of #9683?
Artur Școlnic
06:59 AM Support #6709: track nested FIND inside a related FOR loop
I committed *6709a/16052*. Added FOR_LOOP_WHILE and DO_TO_WHILE reports, fixed database joins report. (refs: #6709)
...
Dănuț Filimon
05:24 AM Support #6709: track nested FIND inside a related FOR loop
Added a fix to *6709a/16051*, only reports are affected. I also got the report results for the ChUI application.
!ch...
Dănuț Filimon
03:20 AM Support #6709: track nested FIND inside a related FOR loop
One solution would be to consider all FindQuery nested when its buffers can be found in the @openBuffers@ and we are ... Dănuț Filimon
03:12 AM Support #6709: track nested FIND inside a related FOR loop
Greg Shah wrote:
> If we are implementing a runtime mode for this detection, we would expect to use the @Transaction...
Dănuț Filimon
03:15 AM Feature #7504 (Test): Export data tool from FWD into .d files
*7504c* was merged into @trunk / rev 16053@. Lorian Sandu
03:06 AM Feature #7504 (Merge Pending): Export data tool from FWD into .d files
7504c can be merged now. Constantin Asofiei
03:03 AM Feature #7504: Export data tool from FWD into .d files
Aside from exporting some data, I believe there's nothing else that needs testing, as the changes only affect @Export... Lorian Sandu

07/16/2025

12:43 PM Feature #4369: implement stateless FWD server clustering
We already run in Docker quite nicely. The issue is that there is quite a bit of 4GL compatibility (like database lo... Greg Shah
10:50 AM Feature #4369: implement stateless FWD server clustering
I am a little late to the party, but glancing over this task, I think Docker fits quite well for Stateless FWD Cluste... Artur Școlnic
12:25 PM Bug #9683: CompoundQuery is doing extra hydration attempts
We need to finish the work in #6720. Greg Shah
10:14 AM Bug #9683 (Review): CompoundQuery is doing extra hydration attempts
Artur Școlnic
06:48 AM Bug #9683: CompoundQuery is doing extra hydration attempts
Rebased 9683a on trunk rev 16047. Addressed review points in rev 16053. Artur Școlnic
12:24 PM Support #6709: track nested FIND inside a related FOR loop
We don't want this to be driven by conversion, but rather we would want to detect things purely based on runtime proc... Greg Shah
12:23 PM Support #6709: track nested FIND inside a related FOR loop
If we are implementing a runtime mode for this detection, we would expect to use the @TransactionManager@ to get deta... Greg Shah
06:31 AM Support #6709: track nested FIND inside a related FOR loop
Dănuț Filimon wrote:
> I'm looking into the runtime changes and how the blocks are converted at the moment, just to ...
Dănuț Filimon
06:03 AM Support #6709: track nested FIND inside a related FOR loop
Ovidiu/Alexandru, please review 6709a for the report changes. Dănuț Filimon
05:20 AM Support #6709 (Review): track nested FIND inside a related FOR loop
I'm looking into the runtime changes and how the blocks are converted at the moment, just to understand what I can us... Dănuț Filimon
04:10 AM Support #6709: track nested FIND inside a related FOR loop
I rebased *6709a* to latest *trunk/16046* and committed *16050*. Added nested find block type reports. Dănuț Filimon
07:44 AM Bug #6923: inner transaction block reverts too much
I committed 6923a/16047 containing more or less the change in #6923-7. However, I refined it to better consider sub-t... Alexandru Lungu
06:19 AM Feature #9456: implement SQL Server dialect and helpers
No. @bzr@ added it without my knowledge. I never use @add@ during rebase. I think it was confused because the file wa... Ovidiu Maxiniuc
06:08 AM Feature #9456: implement SQL Server dialect and helpers
Ovidiu, is @src/com/goldencode/p2j/persist/dialect/P2JSQLServer2008Dialect.java.THIS.THIS@ supposed to exist? Constantin Asofiei
05:50 AM Feature #9456: implement SQL Server dialect and helpers
Branch 9456a was rebase to trunk r16048. Current revision is 16078. Ovidiu Maxiniuc
04:41 AM Feature #7504: Export data tool from FWD into .d files
Ovidiu Maxiniuc wrote:
> I took a look at 7504c / 16047.
>
> I think the code is handle the expanded extents corr...
Lorian Sandu
04:14 AM Feature #7020 (Test): always use "expanded" extent fields
Branch 7020f was merged into trunk as rev. 16048 and archived. Stefanel Pezamosca
03:46 AM Feature #7020 (Merge Pending): always use "expanded" extent fields
Please merge 7020f now. Constantin Asofiei
03:46 AM Bug #10111: All statements are logged to a single text file for P2JQueryLogger and SQLStatementLo...
I have ported the changes to @7156e@ as rev. 15764. Andrei Plugaru
03:17 AM Bug #10111: All statements are logged to a single text file for P2JQueryLogger and SQLStatementLo...
10111a changes should also be ported to *7156e*. Dănuț Filimon
03:15 AM Bug #10111 (Test): All statements are logged to a single text file for P2JQueryLogger and SQLStat...
I have merged to trunk as rev. 16047. Andrei Plugaru
02:39 AM Bug #10111 (Merge Pending): All statements are logged to a single text file for P2JQueryLogger an...
10111a can be merged now. Constantin Asofiei

07/15/2025

06:02 PM Bug #10111: All statements are logged to a single text file for P2JQueryLogger and SQLStatementLo...
I think so.
*Constantin* can you queue this branch for merging?
Ovidiu Maxiniuc
06:50 AM Bug #10111: All statements are logged to a single text file for P2JQueryLogger and SQLStatementLo...
I have rebased @10111a@ to the latest trunk.
*Ovidiu*, please let me know when can it be merged.
Andrei Plugaru
06:18 AM Bug #10111: All statements are logged to a single text file for P2JQueryLogger and SQLStatementLo...
OK. If there's just a single warning and the tests showed no regressions then I do not see a reason to delay the merg... Ovidiu Maxiniuc
03:13 AM Bug #10111: All statements are logged to a single text file for P2JQueryLogger and SQLStatementLo...
Ovidiu Maxiniuc wrote:
> but if the node already exists, what will happen when FWD will try to read the node?
If ...
Andrei Plugaru
03:06 PM Feature #7504: Export data tool from FWD into .d files
Lorian, please double-check datetime-tz scalar and extent fields. Constantin Asofiei
02:52 PM Feature #7504: Export data tool from FWD into .d files
I took a look at 7504c / 16047.
I think the code is handle the expanded extents correctly. However, I ask you agre...
Ovidiu Maxiniuc
08:41 AM Feature #7504: Export data tool from FWD into .d files
I tested again the export tool and with the new @expanded_extents@ in place, there is a thing that i had to change in... Lorian Sandu
07:14 AM Feature #7504: Export data tool from FWD into .d files
The changes are good. I modified the title and contents to remove the reference to "Progress". These are now just r... Greg Shah
06:55 AM Feature #7504: Export data tool from FWD into .d files
> I will also update the [[p2j:Data_Migration#Data-Export|Data_Migration]] with details about the new export tool.
...
Lorian Sandu
03:42 AM Feature #7504 (Test): Export data tool from FWD into .d files
*7504b* was merged into @trunk / rev 16046@
I will also update the [[p2j:Data_Migration#Data-Export|Data_Migration...
Lorian Sandu
01:48 PM Feature #9456: implement SQL Server dialect and helpers
Thank you for noticing this issue.
The @SQLServerHelper@ class has more issues than this. It creates a list of DDL...
Ovidiu Maxiniuc
11:12 AM Feature #9456: implement SQL Server dialect and helpers
Ovidiu, looking at the udfs tests I found a couple of problems:
1) When creating the udfs aliases, we get with ref...
Eduard Soltan
12:27 PM Bug #10171: Word Index/CONTAINS support for MS SQL Server.
At a first quick look, the code seems OK. I will do a more thoroughly review soon. Ovidiu Maxiniuc
10:23 AM Bug #10171 (Review): Word Index/CONTAINS support for MS SQL Server.
Ovidiu,
There was another issue in the trigger function generation for word index tables over expanded extent fiel...
Stefanel Pezamosca
11:34 AM Feature #7020 (Internal Test): always use "expanded" extent fields
I have reviewed 7020f/r16040. I think the code is good.
In particular, I see a lot of changes in @rename_word_tables...
Ovidiu Maxiniuc
07:40 AM Feature #7020: always use "expanded" extent fields
Ovidiu, please review the .sql and the FqlToSql changes Constantin Asofiei
04:36 AM Feature #7020: always use "expanded" extent fields
Added the dmoMeta NULL check in 7020f revision 16040.
7020f is ready for a final review.
Stefanel Pezamosca
04:13 AM Feature #7020: always use "expanded" extent fields
I managed to reproduce.... Stefanel Pezamosca
03:45 AM Feature #7020: always use "expanded" extent fields
Constantin Asofiei wrote:
> Stefanel, the code in p2o.xml needs to be in an outer @while true@ loop, which exits whe...
Stefanel Pezamosca
02:08 AM Feature #7020: always use "expanded" extent fields
Stefanel, the code in p2o.xml needs to be in an outer @while true@ loop, which exits when no longer @isCollision@ by ... Constantin Asofiei
09:23 AM Bug #9317 (Closed): FIRST/LAST clauses can avoid generating sub-selects if the WHERE clause match...
This can be closed. Alexandru Lungu
08:09 AM Bug #10288: Encrypted connetion to SQL Server
Constantin Asofiei wrote:
> Is there any configuration specific on the setup of SQLServer ?
I just setup the SQL ...
Eduard Soltan
08:05 AM Bug #10288: Encrypted connetion to SQL Server
Is there any configuration specific on the setup of SQLServer ? Constantin Asofiei
05:54 AM Support #6709: track nested FIND inside a related FOR loop
I've managed to get a report for nested FINDs in FOR EACH statements, the report works in the following way:
# there...
Dănuț Filimon
04:04 AM Support #6709: track nested FIND inside a related FOR loop
Alexandru Lungu wrote:
> Is this ready for review? Or are you actively working on #6709-47?
I'm working on #6709-...
Dănuț Filimon
04:02 AM Support #6709: track nested FIND inside a related FOR loop
Is this ready for review? Or are you actively working on #6709-47? Alexandru Lungu

07/14/2025

05:10 PM Feature #7504: Export data tool from FWD into .d files
Actually, please merge after 10286a. Greg Shah
02:35 PM Feature #7504 (Merge Pending): Export data tool from FWD into .d files
7504b can be merged to trunk now. Greg Shah
02:16 PM Feature #7504: Export data tool from FWD into .d files
Yes, branch 7504b can be queued for merging into trunk. Ovidiu Maxiniuc
03:35 PM Bug #10111: All statements are logged to a single text file for P2JQueryLogger and SQLStatementLo...
I understand that your test have a good coverage of the affected code.
Related to node type change. If the node is...
Ovidiu Maxiniuc
02:48 PM Feature #9455: port native user defined functions to SQL Server
Ovidiu Maxiniuc wrote:
> I think the cause for this exception is the absence from @build.properties@ of the definiti...
Eduard Soltan
02:25 PM Feature #9455: port native user defined functions to SQL Server
I think the cause for this exception is the absence from @build.properties@ of the definition for @db.import_threads@... Ovidiu Maxiniuc
01:09 PM Bug #10288: Encrypted connetion to SQL Server
Constantin Asofiei wrote:
> Lets make this decision only after we find what's needed to make the secure connection...
Eduard Soltan
10:01 AM Bug #10288: Encrypted connetion to SQL Server
Eduard Soltan wrote:
> In a development environment should we use a certificate or skip the the certificate validati...
Constantin Asofiei
09:12 AM Bug #10288: Encrypted connetion to SQL Server
In a development environment should we use a certificate or skip the the certificate validation? Eduard Soltan
05:12 AM Bug #10288: Encrypted connetion to SQL Server
SQL Server is running on a virtual machine. I want to connect to the server instance from my local environment (Ubunt... Eduard Soltan
04:42 AM Bug #10288 (New): Encrypted connetion to SQL Server
Eduard Soltan
07:47 AM Feature #7020 (Review): always use "expanded" extent fields
Committed to 7020f:
* revision 16037: Improved the logic of rename_word_tables_postgresql.sql - renaming the main wo...
Stefanel Pezamosca
07:45 AM Feature #7020 (WIP): always use "expanded" extent fields
Created branch 7020f from trunk revision 16036.
Stefanel Pezamosca
05:16 AM Feature #7020: always use "expanded" extent fields
Constantin Asofiei wrote:
> 7020e was merged to trunk rev 16036 - it contained a fix related to loading extent datet...
Stefanel Pezamosca
07:19 AM Bug #9078: emit FindQuery as (reused) variables
DO blocks are quite tricky, those blocks do not have an instvarid and in some cases I can get out of the expected blo... Dănuț Filimon
06:54 AM Bug #6923: inner transaction block reverts too much
I am encountering the same problem described here when dealing with #8388. The reason is exactly that the DMO is roll... Alexandru Lungu
04:16 AM Bug #10285: Static compound query returns no result
I have found out that the issue is only reproducible when using the MariaDB driver. I have tracked the difference to ... Andrei Plugaru
04:12 AM Bug #10285: Static compound query returns no result
While investigating #8279, regarding some CQ instances, I found an example that doesn't seem to work properly in FWD:... Andrei Plugaru
04:11 AM Bug #10285 (Test): Static compound query returns no result
Andrei Plugaru

07/13/2025

05:42 AM Feature #7020: always use "expanded" extent fields
There is also this NPE in ETF:... Constantin Asofiei
04:43 AM Feature #7020: always use "expanded" extent fields
7020e was merged to trunk rev 16036 - it contained a fix related to loading extent datetime-tz fields (the offset in ... Constantin Asofiei

07/11/2025

09:31 AM Feature #10094: RECIDs from different tenants of same logical database should not overlap
Constantin Asofiei wrote:
> Why the @if (restInBucket++ == 0)@? Just to get the first result?
Sorry for the C/C++ ...
Ovidiu Maxiniuc
09:17 AM Feature #10094 (Internal Test): RECIDs from different tenants of same logical database should not...
I've also tested an import and it worked. Constantin Asofiei
09:17 AM Feature #10094: RECIDs from different tenants of same logical database should not overlap
@TenantIdContext.prepareNextBracket@ - there is a @while (rs.next())@ which suggets that there may be more than one ... Constantin Asofiei
08:58 AM Support #6709: track nested FIND inside a related FOR loop
To do:
* add a report where nested find queries are displayed based on the type of block, but only if the block refe...
Dănuț Filimon
07:40 AM Support #6709: track nested FIND inside a related FOR loop
Committed *6709a/16034*. Included UNIQUE finds in the report, I missed those previously. Dănuț Filimon
06:54 AM Support #6709: track nested FIND inside a related FOR loop
Dănuț Filimon wrote:
> * Nested FIND: 13 first, 6 next, 5 last, 5 current, 3 where (this is confusing a bit because ...
Dănuț Filimon
06:35 AM Bug #9078 (Review): emit FindQuery as (reused) variables
Fixed #9078-113 in *9078b/16039*. We did not emit the find query as a variable when we had a block in the queue, but ... Dănuț Filimon
05:21 AM Bug #9078 (WIP): emit FindQuery as (reused) variables
Found the issue from #9078-113 again, but I got a reliable reproduction this time. It seems that when I use the array... Dănuț Filimon
06:23 AM Feature #9456: implement SQL Server dialect and helpers
This is in trunk.
* Dialect has this:...
Constantin Asofiei
06:14 AM Feature #9456: implement SQL Server dialect and helpers
Constantin Asofiei wrote:
> Ovidiu, first results on conversion: @nulls last@ is added on indexes for H2 dialect (th...
Ovidiu Maxiniuc

07/10/2025

06:09 PM Feature #10094: RECIDs from different tenants of same logical database should not overlap
Constantin Asofiei wrote:
> Ovidiu, are there any changes required in existing scripts (non-tenant and multi-tenant)...
Ovidiu Maxiniuc
05:40 AM Feature #10094: RECIDs from different tenants of same logical database should not overlap
Ovidiu, are there any changes required in existing scripts (non-tenant and multi-tenant) for data import? Constantin Asofiei
03:51 PM Feature #9456: implement SQL Server dialect and helpers
This is not intentional. I wonder why I did not notice it. It is a regression. Thank you for reporting it. I'm fixing... Ovidiu Maxiniuc
03:48 PM Feature #9456: implement SQL Server dialect and helpers
Ovidiu, first results on conversion: @nulls last@ is added on indexes for H2 dialect (this includes the meta schema a... Constantin Asofiei
11:58 AM Feature #9456 (Review): implement SQL Server dialect and helpers
Ovidiu Maxiniuc
11:58 AM Feature #9456: implement SQL Server dialect and helpers
Branch 9456a was rebased to trunk/16032. Pushed up to revision 16060.
It is ready for review.
Note: I have some...
Ovidiu Maxiniuc
05:41 AM Feature #9456: implement SQL Server dialect and helpers
Ovidiu, can 9456a be moved to review?
About the data/dump/ database folder missing: if you haven't already fixed i...
Constantin Asofiei
09:57 AM Bug #10111: All statements are logged to a single text file for P2JQueryLogger and SQLStatementLo...
I have run a test suite of a large customer application and also tested different options for the logging tools and d... Andrei Plugaru
09:24 AM Support #6709: track nested FIND inside a related FOR loop
I ran the reports for hotel and got:
* Nested FIND: 13 first, 6 next, 5 last, 5 current, 3 where (this is confusing ...
Dănuț Filimon
08:02 AM Support #6709: track nested FIND inside a related FOR loop
Committed *6709a/16032*. Extended the functionality of the nested_find annotation and added more detailed reports:
...
Dănuț Filimon
05:48 AM Support #6709: track nested FIND inside a related FOR loop
> Alex, I took a look at the last example from #6709-38 and only the FOR EACH find has the nested_find annotation. Ar... Alexandru Lungu

07/09/2025

12:17 PM Feature #9455: port native user defined functions to SQL Server
Tried to import the import the testcases database in sql server and got the following error.... Eduard Soltan
10:34 AM Bug #10276: Joinable interface should be made public
While investigating #8279, I found an important functional issue regarding @Joinable@ interface. I was getting this e... Andrei Plugaru
08:51 AM Bug #10276 (New): Joinable interface should be made public
Andrei Plugaru
08:49 AM Bug #10111: All statements are logged to a single text file for P2JQueryLogger and SQLStatementLo...
Thanks, Ovidiu for the review.
Regarding testing, I am thinking of running a test suite of a large customer applic...
Andrei Plugaru
08:00 AM Feature #10094: RECIDs from different tenants of same logical database should not overlap
*Eric/Constantin: Please review this ASAP so we can move this task ahead.* Greg Shah
08:00 AM Support #6709: track nested FIND inside a related FOR loop
... Dănuț Filimon
07:18 AM Feature #7504: Export data tool from FWD into .d files
Ovidiu: Please get this into the merge queue if it is ready to go. Greg Shah
05:36 AM Bug #10171: Word Index/CONTAINS support for MS SQL Server.
I fixed the above warnings by creating the @word@ field in the generated @wordTable@ with the parent field @maxWidth@... Stefanel Pezamosca
04:33 AM Support #10222: Is cross-session dirty share available through Fast Find Cache even if disabled?
> Maybe a possible solution is to have a mix of private FFCs and common FFC. The latter will keep only pristine data ... Alexandru Lungu
03:49 AM Bug #6767: Possible name clashes in DMO classes
Vladimir Tsichevski wrote:
>
> So I am not the person to blame :-).
OK, you get only a partial blame :-).
I ...
Hynek Cihlar
03:37 AM Bug #10083 (Test): Infinite loop when changing walking index fields
Constantin Asofiei

07/08/2025

07:43 PM Feature #10270: implement some temp-tables using the persistent database instance when they are j...
I think this might be useful, but the heuristic could be difficult to implement because of dynamic queries. What I me... Ovidiu Maxiniuc
09:35 AM Feature #10270: implement some temp-tables using the persistent database instance when they are j...
> The idea here is that we could analyze usage of each temp-table and implement heuristcs that mark specific temp-tab... Alexandru Lungu
08:28 AM Feature #10270: implement some temp-tables using the persistent database instance when they are j...
The idea here is that we could analyze usage of each temp-table and implement heuristcs that mark specific temp-table... Greg Shah
08:23 AM Feature #10270 (New): implement some temp-tables using the persistent database instance when they...
Greg Shah
07:31 PM Bug #10111 (Internal Test): All statements are logged to a single text file for P2JQueryLogger an...
I think the changes in 15984 are OK. Can we move to 100% done? Ovidiu Maxiniuc
04:24 AM Bug #10111: All statements are logged to a single text file for P2JQueryLogger and SQLStatementLo...
I remembered something worth noting. In my current implementation, I have changed the type of the @enabled@ node for ... Andrei Plugaru
03:51 AM Bug #10111 (Review): All statements are logged to a single text file for P2JQueryLogger and SQLSt...
I have committed @10111a/15984@ with the missing files and addressed the rest of the review. Ovidiu, please take a lo... Andrei Plugaru
06:44 PM Feature #9456: implement SQL Server dialect and helpers
As discussed during technical meet from Monday I tried executing the import from within the guest OS. That required m... Ovidiu Maxiniuc
01:05 PM Feature #9456: implement SQL Server dialect and helpers
9456a seems stable now after the fixes for word tables.
The customer's 'small' database imports without any issue....
Ovidiu Maxiniuc
12:31 PM Feature #9456: implement SQL Server dialect and helpers
Ovidiu/Stefanel/Eduard: please lets get 9456a stabilized and ready for review tomorrow (this will include all the UDF... Constantin Asofiei
06:34 PM Support #10222: Is cross-session dirty share available through Fast Find Cache even if disabled?
Alexandru Lungu wrote:
> Of course, I am looking further for *Ovidiu*'s input on this matter.
I had a look over 102...
Ovidiu Maxiniuc
04:39 PM Bug #10171: Word Index/CONTAINS support for MS SQL Server.
I have just noticed a warning when the word indexes are created:... Ovidiu Maxiniuc
08:24 AM Bug #10171 (WIP): Word Index/CONTAINS support for MS SQL Server.
Stefanel Pezamosca wrote:
> Hmm, another case of "IntelliJ knows better".
It tries to help based on your configurat...
Ovidiu Maxiniuc
06:54 AM Bug #10171 (Review): Word Index/CONTAINS support for MS SQL Server.
I fixed the above issues in revision 9456a revision 16053. Stefanel Pezamosca
04:47 AM Bug #10171 (WIP): Word Index/CONTAINS support for MS SQL Server.
Stefanel Pezamosca
04:47 AM Bug #10171: Word Index/CONTAINS support for MS SQL Server.
Ovidiu Maxiniuc wrote:
> I did not do a thorough review, only a few observations:
> * please stick to JDK8 for the ...
Stefanel Pezamosca
02:56 PM Bug #6767: Possible name clashes in DMO classes
Hynek Cihlar wrote:
> The private data getter and setter was added by Vladimir in the context of #5144. I don't reca...
Vladimir Tsichevski
01:42 PM Bug #6767: Possible name clashes in DMO classes
The private data getter and setter was added by Vladimir in the context of #5144. I don't recall @PRIVATE-DATA@ neede... Hynek Cihlar
09:47 AM Support #6709: track nested FIND inside a related FOR loop
Alex, I took a look at the last example from #6709-38 and only the FOR EACH find has the nested_find annotation. Are ... Dănuț Filimon
09:05 AM Support #6709: track nested FIND inside a related FOR loop
I'll mention a few ideas from the latest discussions so that I do not lose track of them:
* Tracking nested finds in...
Dănuț Filimon
07:59 AM Support #6709: track nested FIND inside a related FOR loop
There are some bugs in the report so that more nested FINDs are logged than needed. I think the flag is set incorrect... Alexandru Lungu
09:43 AM Bug #10198: analyze FIND statements which use only a small number of fields
Just FYI: I also thought of this a while ago, but there was an issue with caching. The more variance we have in the F... Alexandru Lungu
09:43 AM Feature #9455: port native user defined functions to SQL Server
Ovidiu Maxiniuc wrote:
> I do not know (most likely not yet) whether 9457c was also rebased. Therefore they are most...
Constantin Asofiei
09:41 AM Feature #9455: port native user defined functions to SQL Server
Ovidiu Maxiniuc wrote:
>
> I do not know (most likely not yet) whether 9457c was also rebased. Therefore they are ...
Eduard Soltan
09:35 AM Feature #9455: port native user defined functions to SQL Server
Branch 9456a was rebased after 7020a was merged in. The denormalisation of extent fields was replaced with expanded c... Ovidiu Maxiniuc
09:27 AM Feature #9455: port native user defined functions to SQL Server
Eduard Soltan wrote:
> I think there is a issue with some @_meta@ dmos.
>
> The following field in @_meta.MetaDb@...
Stefanel Pezamosca
09:26 AM Feature #9455: port native user defined functions to SQL Server
I think there is a issue with some @_meta@ dmos.
The following field in @_meta.MetaDb@ dmo:...
Eduard Soltan
07:55 AM Bug #9078 (Review): emit FindQuery as (reused) variables
I added 9078b to my ETF conversion queue, it will take a while to get through it. Dănuț Filimon
07:54 AM Bug #9078: emit FindQuery as (reused) variables
Dănuț Filimon wrote:
> I've managed to fix the issue, I've also noticed that CAN-FINDs were ignored and AdaptiveFind...
Dănuț Filimon
07:23 AM Bug #9078: emit FindQuery as (reused) variables
I've managed to fix the issue, I've also noticed that CAN-FINDs were ignored and AdaptiveFinds were also counted. I'l... Dănuț Filimon
06:24 AM Bug #9078 (WIP): emit FindQuery as (reused) variables
I've found an issue while converting ETF:... Dănuț Filimon

07/07/2025

04:07 PM Bug #10171: Word Index/CONTAINS support for MS SQL Server.
I did not do a thorough review, only a few observations:
* please stick to JDK8 for the moment. @List<E> of(E... ele...
Ovidiu Maxiniuc
02:50 PM Feature #9455: port native user defined functions to SQL Server
See my note #9991-52. The import of the smaller database was (pretty much) successful.
There are some issues with t...
Ovidiu Maxiniuc
02:32 PM Feature #9455: port native user defined functions to SQL Server
Manage to set up Hotel Gui with connection to a SQL Server instance running on a virtual machine. Did a smoke test wi... Eduard Soltan
10:26 AM Bug #10111: All statements are logged to a single text file for P2JQueryLogger and SQLStatementLo...
Ovidiu Maxiniuc wrote:
> +Review of 10111a/r15983+
>
> First, why in revno: 15983 the files: @src/com/goldencode/...
Andrei Plugaru
10:12 AM Bug #10111: All statements are logged to a single text file for P2JQueryLogger and SQLStatementLo...
+Review of 10111a/r15983+
First, why in revno: 15983 the files: @src/com/goldencode/p2j/persist/BaseLoggingConfigu...
Ovidiu Maxiniuc
04:59 AM Bug #10111: All statements are logged to a single text file for P2JQueryLogger and SQLStatementLo...
I think this branch is ready for a review.
Main changes:
* @10111a/15982@: Moved the common logic from @P2JLoggingD...
Andrei Plugaru
09:22 AM Feature #7020: always use "expanded" extent fields
Roger Borrello wrote:
> Stefanel Pezamosca wrote:
> > Is there anything else to do before merging 7020d to trunk?
...
Stefanel Pezamosca
09:21 AM Feature #7020: always use "expanded" extent fields
Stefanel Pezamosca wrote:
> Is there anything else to do before merging 7020d to trunk?
Yes... I know. Too late.
...
Roger Borrello
09:16 AM Support #10222: Is cross-session dirty share available through Fast Find Cache even if disabled?
> FWD is not leaking anything except FINDs that were done on other sessions as well. It sounds quite bad to me. Overa... Greg Shah
08:44 AM Support #10222: Is cross-session dirty share available through Fast Find Cache even if disabled?
Of course, I am looking further for *Ovidiu's* input on this matter. Alexandru Lungu
08:40 AM Support #10222: Is cross-session dirty share available through Fast Find Cache even if disabled?
*Greg*, I decided in today's stand-up to put #10222 on hold. The implementation of fast-find cache is complete and so... Alexandru Lungu
06:04 AM Support #10222 (WIP): Is cross-session dirty share available through Fast Find Cache even if disa...
Review for #10222:
* I don't understand @session.getCached(dmo.getClass(), cacheResult.getRecordID()).equals(dmo))@....
Alexandru Lungu
08:36 AM Bug #6767: Possible name clashes in DMO classes
Constantin Asofiei wrote:
> Argh, this is OCX.
It was, but it is not in FWD.
>
> Hynek: can you point Vladimir t...
Vladimir Tsichevski
01:44 AM Bug #6767: Possible name clashes in DMO classes
Argh, this is OCX.
Hynek: can you point Vladimir to an example how @TreeFace@ emits @get/setPrivateData@ via OCX?
Constantin Asofiei
07:17 AM Bug #9078: emit FindQuery as (reused) variables
Rebased *9078b* to latest *trunk/16028*, the branch is now at revision *16037*. Dănuț Filimon
02:39 AM Bug #9078: emit FindQuery as (reused) variables
Constantin Asofiei wrote:
> Danut, does @AdaptiveFind@ still emit properly? This is the @FIND FIRST. REPEAT: FIND N...
Dănuț Filimon
02:25 AM Bug #9078: emit FindQuery as (reused) variables
Danut, does @AdaptiveFind@ still emit properly? This is the @FIND FIRST. REPEAT: FIND NEXT. END.@ pattern, if I'm no... Constantin Asofiei
02:19 AM Feature #7504: Export data tool from FWD into .d files
The runtime regression testing for @7504b@ finished successfully. Lorian Sandu
 

Also available in: Atom