Project

General

Profile

Activity

From 11/20/2015 to 12/19/2015

12/19/2015

07:08 AM Bug #2795: scoped variables/tables/etc and persistent procedures
2795a rev 10968 fixes the conversion issue about non-tt shared buffers. I'm running conversion again (will let you k... Constantin Asofiei
05:47 AM Bug #2795: scoped variables/tables/etc and persistent procedures
Constantin Asofiei wrote:
> Unfortunately GUI and server conversion both failed with a NPE. I'm looking into it.
I ...
Constantin Asofiei
05:06 AM Bug #2795: scoped variables/tables/etc and persistent procedures
Unfortunately GUI and server conversion both failed with a NPE. I'm looking into it. Constantin Asofiei
07:02 PM Bug #2795: scoped variables/tables/etc and persistent procedures
2795a rev 10967 is a good candidate for review (there are some javadocs missing and some TODO's in appserver invocati... Constantin Asofiei
07:09 PM Bug #2837: GUI combo-box drop-down needs to be able to draw outside of it's containing top-level ...
Task branch @2837a@ updated to revision @10961@.
This is the early draft version, so lot of commented out code is ...
Eugenie Lyzenko

12/18/2015

05:05 PM Bug #2795: scoped variables/tables/etc and persistent procedures
Constantin Asofiei wrote:
> Finally, about shared temp-tables and extent fields: there is a new issue which is (I th...
Eric Faulhaber
05:01 PM Bug #2795: scoped variables/tables/etc and persistent procedures
Constantin Asofiei wrote:
> If these pass, I would like to run a set of full customer tests - there are lots of chan...
Eric Faulhaber
03:54 PM Bug #2795: scoped variables/tables/etc and persistent procedures
I've rebased 2795a from trunk rev 10960. As of rev 10966, what is missing is support for FRAME and MENU resources.
...
Constantin Asofiei
03:46 PM Bug #2837: GUI combo-box drop-down needs to be able to draw outside of it's containing top-level ...
Rebased task branch @2837a@ from P2J trunk revision @10960@, new branch revision is @10960@ to(no updates yet). Eugenie Lyzenko
03:29 PM Bug #2837: GUI combo-box drop-down needs to be able to draw outside of it's containing top-level ...
This is the very first picture of the overlay window with opened drop-down widget. And there is one point to discuss.... Eugenie Lyzenko
02:18 PM Feature #2564: implement GUI BROWSE widget
"Scroll to view" rules:
# If the current (editable) column is not "visible" in the browse viewport and user _a)_ pres...
Stanislav Lomany
12:07 PM Bug #2928: non-localhost testing and fixes
I have installed the local DNS service on the server machine A(192.168.1.35) - @dnsmasq@ the lightweight DNS server w... Sergey Ivanovskiy
05:22 AM Bug #2928: non-localhost testing and fixes
As of now, spawning web clients using a hostname that is not localmost does nothat work with Firefox. That is unacce... Greg Shah
02:59 AM Bug #2928: non-localhost testing and fixes
Greg, please clarify your vision of this issue. My test environment only proves that Firefox doesn't cache a host nam... Sergey Ivanovskiy

12/17/2015

03:35 PM Bug #2929: test chrome browser support
> Code Review Task Branch 1811t Revision 10964
>
> I don't understand the change to @CanvasRenderer.prototype.drawIm...
Sergey Ivanovskiy
03:20 PM Bug #2929: test chrome browser support
> Code Review Task Branch 1811t Revision 10963
>
>
> 1. There is this code in toProperties():
>
> [...]
>
> In JS...
Sergey Ivanovskiy
11:04 AM Bug #2929: test chrome browser support
Code Review Task Branch 1811t Revision 10965
I have the same concerns for the @applyCompositeMode()@ changes as I ...
Greg Shah
11:03 AM Bug #2929: test chrome browser support
Code Review Task Branch 1811t Revision 10964
I don't understand the change to @CanvasRenderer.prototype.drawImage(...
Greg Shah
10:58 AM Bug #2929: test chrome browser support
Code Review Task Branch 1811t Revision 10963
1. There is this code in toProperties():...
Greg Shah
03:32 PM Bug #2909: Fix key navigation for popup_ext.p
I didn't understand why I should change @SubMenu.focusTraversable()@ (See previous note)?
I've fixed key navigatio...
Vadim Gindin
03:05 PM Bug #2887: web client flashing/drawing artifacts
Greg, please review, the committed revision 10967 has the target fixes. Sergey Ivanovskiy
10:18 AM Bug #2887: web client flashing/drawing artifacts
Constantin Asofiei wrote:
> Sergey, the code looks OK; only one note: on @p2j.js:100@, is the @" wait"@ (with the sp...
Sergey Ivanovskiy
10:10 AM Bug #2887: web client flashing/drawing artifacts
Sergey Ivanovskiy wrote:
> Greg, this code change is improved according your review. I can commit the changes to 181...
Constantin Asofiei
09:56 AM Bug #2887: web client flashing/drawing artifacts
Code Review offscreenBuffer_5.txt
This version is better.
Constantin: please review this and provide feedback...
Greg Shah
01:03 PM Bug #2940: ./image/image0.p displays a faded app-icon.ico.
Please look at https://proj.goldencode.com/redmine/attachments/4486/image.png for the attached picture and for a refe... Sergey Ivanovskiy
01:00 PM Bug #2940 (New): ./image/image0.p displays a faded app-icon.ico.
Sergey Ivanovskiy
12:58 PM Bug #2939: ./demo/calc-static-chars.p the plus sign button looks like it doesn't fit the required...
This bug can be reproduced for the swing and web clients for ./demo/calc-static-chars.p. Please look at the attached ... Sergey Ivanovskiy
12:56 PM Bug #2939 (New): ./demo/calc-static-chars.p the plus sign button looks like it doesn't fit the re...
Sergey Ivanovskiy
12:54 PM Bug #2938: ./demo/calc.p (web client) the plus sign button becomes damaged if do clicking on its ...
This bug can be reproduced for the web client running ./demo/calc.p. Please see the attached picture #2928-5. Sergey Ivanovskiy
12:52 PM Bug #2938 (New): ./demo/calc.p (web client) the plus sign button becomes damaged if do clicking o...
Sergey Ivanovskiy
12:49 PM Feature #2564: implement GUI BROWSE widget
The issue was moved to #2936. Stanislav Lomany
11:12 AM Feature #2564: implement GUI BROWSE widget
> Should I implement "cell shrinking quirk" now or leave for later?
This seems to be a pretty strange behavior tha...
Greg Shah
12:38 PM Feature #2936: Editing cell shrinking quirk
The issue was originally described in issue #2564 note 242.
If a cell is edited and we scroll to the right, the cell...
Stanislav Lomany
12:31 PM Feature #2936 (New): Editing cell shrinking quirk
Stanislav Lomany
12:29 PM Bug #2928: non-localhost testing and fixes
Greg Shah wrote:
> I think we need to consider 2 things:
>
> 1. Have you tested with a DNS name (other than local...
Sergey Ivanovskiy
10:21 AM Bug #2928: non-localhost testing and fixes
> And one bug #2928-10 is related to the screen resolution and fonts for the tested notebook.
Is this a bug in P2J...
Greg Shah
10:18 AM Bug #2928: non-localhost testing and fixes
Sergey Ivanovskiy wrote:
> Let the simple server be located on 192.168.1.35 and accessed by https://192.168.1.35:744...
Greg Shah
10:10 AM Bug #2928: non-localhost testing and fixes
> 1. Are any of these bugs caused by non-localhost browser usage?
I couldn't find bugs caused by non-localhost brows...
Sergey Ivanovskiy
09:49 AM Bug #2795: scoped variables/tables/etc and persistent procedures
Greg Shah wrote:
> > I'm moving the initializer code for DEFINE NEW [GLOBAL] SHARED VARIABLE ... EXTENT ... INIT as ...
Constantin Asofiei

12/16/2015

04:11 PM Bug #2930: test IE browser support
For IE 11 the fonts don't work, trying to load the target font throws this exception:... Sergey Ivanovskiy
04:00 PM Bug #2930: test IE browser support
Committed revision 10966 fixes the task bar panel dragging for IE. Sergey Ivanovskiy
02:24 PM Bug #2930: test IE browser support
IE 10 emulation doesn't work due to @Map@ usages, but the last Edge (11) works with @Map@. Sergey Ivanovskiy
02:17 PM Bug #2930: test IE browser support
Trying to load https://192.168.1.35:7443/gui throws an invalid certificates message, it can be passed by adding https... Sergey Ivanovskiy
08:21 AM Bug #2930: test IE browser support
Microsoft provides VMs for free to allow web developers to test their apps in various versions of the IE/Edge browser... Greg Shah
09:18 AM Bug #2795: scoped variables/tables/etc and persistent procedures
> I'm moving the initializer code for DEFINE NEW [GLOBAL] SHARED VARIABLE ... EXTENT ... INIT as a parameter for Shar... Greg Shah
09:12 AM Bug #2837: GUI combo-box drop-down needs to be able to draw outside of it's containing top-level ...
OK, go ahead with your plan. Make sure to get all of these behaviors correct in the implementation. Greg Shah
09:04 AM Bug #2837: GUI combo-box drop-down needs to be able to draw outside of it's containing top-level ...
Greg Shah wrote:
> Have you checked if these windows can stay open while you are moving/minimizing/restoring/maximiz...
Eugenie Lyzenko
08:32 AM Bug #2837: GUI combo-box drop-down needs to be able to draw outside of it's containing top-level ...
I like the plan.
Have you checked if these windows can stay open while you are moving/minimizing/restoring/maxim...
Greg Shah
06:04 AM Bug #2837: GUI combo-box drop-down needs to be able to draw outside of it's containing top-level ...
Eugenie Lyzenko wrote:
> After investigation the I have something to present as implementation plan.
> 1. I guess w...
Hynek Cihlar
08:43 AM Bug #2929: test chrome browser support
Committed revision 10965 adds a Chrome's fix for @applyCompositeMode@. Sergey Ivanovskiy
08:24 AM Bug #2928: non-localhost testing and fixes
Sergey:
1. Are any of these bugs caused by non-localhost browser usage?
2. Please create new sub-tasks of #2677...
Greg Shah
04:41 AM Bug #2928: non-localhost testing and fixes
Greg Shah wrote:
> Sergey: please report which of the problems noted above (if any) are:
>
> 1. Caused by the non...
Sergey Ivanovskiy

12/15/2015

06:32 PM Bug #2837: GUI combo-box drop-down needs to be able to draw outside of it's containing top-level ...
After investigation the I have something to present as implementation plan.
1. I guess we need to have the driver in...
Eugenie Lyzenko
06:24 PM Feature #2564: implement GUI BROWSE widget
Guys, there is the quirk: in COLUMN-SCROLLING mode, if a cell is edited and we scroll to the right, the cell is shrin... Stanislav Lomany
05:38 PM Bug #2929: test chrome browser support
Committed revision 10964 fixes the getImageData implementation for Chrome. The final result is not with a precise acc... Sergey Ivanovskiy
02:58 PM Bug #2929: test chrome browser support
Have started to work on this issue: for Chrome the image drawing works incorrectly. Found that getImageData(x, y, w, ... Sergey Ivanovskiy
02:56 PM Bug #2929: test chrome browser support
Committed revision 10963 fixed the "style of HTML Element has only a getter" issue for Chrome browser. Sergey Ivanovskiy
07:43 AM Bug #2929: test chrome browser support
The test with Google Chrome Version 47.0.2526.80 (64-bit) is failed throwing this root cause exception... Sergey Ivanovskiy
11:40 AM Bug #2928: non-localhost testing and fixes
Paul Eames wrote:
> Constantin,
>
> When you say "has access to", what do you mean?
Full read/write access.
>...
Constantin Asofiei
11:31 AM Bug #2928: non-localhost testing and fixes
Constantin,
When you say "has access to", what do you mean?
Permissions on the working directory were 0775 and ...
Paul E
11:21 AM Bug #2928: non-localhost testing and fixes
Paul Eames wrote:
> I changed to use IP addresses. TBH I'm not sure if that was the important change.
>
> I was ...
Constantin Asofiei
11:11 AM Bug #2928: non-localhost testing and fixes
It's working now.
Thank you for your help.
I changed to use IP addresses. TBH I'm not sure if that was the import...
Paul E
11:09 AM Bug #2928: non-localhost testing and fixes
In that case this issue is related to how host names can be resolved in your network and to accepted routes. I haven'... Sergey Ivanovskiy
10:36 AM Bug #2928: non-localhost testing and fixes
Sergey,
In my case the server name is "gui-conv".
I see a redirect address of:
https://gui-conv:7449/?token=.....
Paul E
09:59 AM Bug #2928: non-localhost testing and fixes
Paul Eames wrote:
> Ah good, I see you get the same behaviour that I do - that's encouraging.
This NPE is generated...
Constantin Asofiei
08:58 AM Bug #2928: non-localhost testing and fixes
Hi Paul,
Could you please report here the redirect url the JS client gets if you set the hostname of the Linux VM th...
Sergey Ivanovskiy
08:28 AM Bug #2928: non-localhost testing and fixes
Ah good, I see you get the same behaviour that I do - that's encouraging.
In that case we should be able to get th...
Paul E
07:44 AM Bug #2928: non-localhost testing and fixes
Sergey/Constantin: please work with Paul to find a solution to his issue. This has high priority since he is trying ... Greg Shah
07:43 AM Bug #2928: non-localhost testing and fixes
This has been reported by a customer:
-------- Forwarded Message --------
Subject: Re: GUI distribution
Date: ...
Greg Shah
03:06 AM Bug #2928: non-localhost testing and fixes
The bug from #2928-5 (./demo/calc.p) can be reproduced for the current trunc version. Sergey Ivanovskiy
08:40 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
Greg Shah wrote:
> You should be able to assign #2935 to yourself. If that doesn't work, let me know.
>
> > Shou...
Igor Skornyakov
08:32 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
You should be able to assign #2935 to yourself. If that doesn't work, let me know.
> Should I create a separate t...
Greg Shah
08:30 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
Greg Shah wrote:
> > 1. Load custom cursor from file. This can be done in one or two days.
> > 2. Add custom cursor...
Igor Skornyakov
08:26 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
> 1. Load custom cursor from file. This can be done in one or two days.
> 2. Add custom cursor support for BROWSE in...
Greg Shah
04:18 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
Section 27 has been updated. Igor Skornyakov

12/14/2015

04:13 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
*TODO:*
1. Load custom cursor from file. This can be done in one or two days.
2. Add custom cursor support for @BRO...
Igor Skornyakov
10:56 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
Added JavaDoc and history
Committed to the task branch 2565a revno 10977.
Igor Skornyakov
09:00 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
Greg Shah wrote:
> OK, create a sub-task of #2677 for this, unless you need it fixed for this task.
OK, thank you...
Igor Skornyakov
08:42 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
OK, create a sub-task of #2677 for this, unless you need it fixed for this task. Greg Shah
04:06 PM Bug #2935: Active drop-down disables triggers and WAIT ... PAUSE
When the drop-down @COMBO-BOX@ (@DROP-DOWN@ and @DROP-DOWN-LIST@ mode) is active then @ON <key> ANYWHERE@ is not invo... Igor Skornyakov
03:59 PM Bug #2935 (New): Active drop-down disables triggers and WAIT ... PAUSE
Igor Skornyakov
03:28 PM Bug #2928: non-localhost testing and fixes
./browse/gui/browse-gui-stat1.p has faded columns headers in the case if the js client is on the different computer, ... Sergey Ivanovskiy
02:58 PM Bug #2928: non-localhost testing and fixes
./window_sizing/test_runner.p , ./window_sizing/default_empty_window.p and ./window_sizing/create_empty_window.p are ... Sergey Ivanovskiy
02:43 PM Bug #2928: non-localhost testing and fixes
/button/gui_btn_test5.p has a known issue with a damaged image if do clicking on the "enable on/off" button two times... Sergey Ivanovskiy
02:25 PM Bug #2928: non-localhost testing and fixes
./image/image0.p displays a faded app-icon.ico. The same issue happens with local launches. It can be reproduced for ... Sergey Ivanovskiy
01:46 PM Bug #2928: non-localhost testing and fixes
For the swing and web clients the plus sign button looks like it doesn't fit the required bounds. It can be reproduc... Sergey Ivanovskiy
01:15 PM Bug #2928: non-localhost testing and fixes
For the web client the plus sign becomes damaged if do clicking on its neighbor row buttons. It can be reproduced for... Sergey Ivanovskiy
12:49 PM Bug #2928: non-localhost testing and fixes
1811t has the known missed space character issue in text fields for the swing and web clients. Thus it hasn't been re... Sergey Ivanovskiy
11:32 AM Bug #2928: non-localhost testing and fixes
Let the simple server be located on 192.168.1.35 and accessed by https://192.168.1.35:7443/gui. Trying to login the s... Sergey Ivanovskiy
02:15 PM Bug #2795: scoped variables/tables/etc and persistent procedures
> Ovidiu: can you post some details about how the TEMP-TABLEs should be matched? Is there some existing code which ch... Ovidiu Maxiniuc
01:59 PM Bug #2795: scoped variables/tables/etc and persistent procedures
I've created branch 2795 in which rev 10960 contains:
* the GLOBAL SHARED resources are not removed when the procedu...
Constantin Asofiei
12:18 PM Bug #2795: scoped variables/tables/etc and persistent procedures
In regard to notes 15 and 16: I'm moving the initializer code for @DEFINE NEW [GLOBAL] SHARED VARIABLE ... EXTENT ...... Constantin Asofiei
12:08 PM Bug #2795: scoped variables/tables/etc and persistent procedures
Ovidiu Maxiniuc wrote:
> IIRC, there was an issue when using initialized shared variables, something like this:
> ....
Constantin Asofiei
11:45 AM Bug #2795: scoped variables/tables/etc and persistent procedures
IIRC, there was an issue when using initialized shared variables, something like this:
Procedure p1:...
Ovidiu Maxiniuc
11:09 AM Bug #2795: scoped variables/tables/etc and persistent procedures
Ovidiu, please describe what this change in @variable_definition.rules@ tried to solve:... Constantin Asofiei
01:20 PM Bug #2934: ON ENTRY trigger is not activated with COMBO-BOX
The @ON ENTRY@ trigger is not activated for the @SIMPLE@ and @DROP-DOWN-LIST@ @COMBO-BOX@ if it gains focus after @TA... Igor Skornyakov
01:18 PM Bug #2934 (New): ON ENTRY trigger is not activated with COMBO-BOX
Igor Skornyakov
11:12 AM Bug #2933: Fix pop-up menu layout for CHUI (popup_ext.p)
@ESC-U@ Vadim Gindin
08:47 AM Bug #2933: Fix pop-up menu layout for CHUI (popup_ext.p)
What keys are used to open the menu? Greg Shah
02:22 AM Bug #2933: Fix pop-up menu layout for CHUI (popup_ext.p)
Here is the test:... Vadim Gindin
02:17 AM Bug #2933 (New): Fix pop-up menu layout for CHUI (popup_ext.p)
Vadim Gindin
08:49 AM Bug #2912 (Closed): alert-box is displayed on the task bar in Web GUI client, it shouldn't
Greg Shah
02:28 AM Bug #2912: alert-box is displayed on the task bar in Web GUI client, it shouldn't
Greg Shah wrote:
> Code Review Task Branch 1811t Revision 10961
>
> I'm fine with the changes.
>
> Constantin:...
Constantin Asofiei
08:47 AM Bug #2850 (Closed): menu/simple_sm.p drawing issues in Swing client
Greg Shah
02:22 AM Bug #2850: menu/simple_sm.p drawing issues in Swing client
I've created the task #2933 for CHUI layout errors. Vadim Gindin
08:40 AM Bug #2832 (Closed): GUI combo-box simple mode is broken
Greg Shah

12/13/2015

03:14 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
After the rebase the situation with @COMBO-BOX@ border and custom mouse cursor activation is fixed. However the @ON E... Igor Skornyakov
04:17 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
Rebased task branch 2565a from P2J trunk rev 10959. The latest revision is now 10974. Igor Skornyakov
01:38 AM Bug #2837: GUI combo-box drop-down needs to be able to draw outside of it's containing top-level ...
The task @2837a@ has been created based on trunk revision @10959@. Eugenie Lyzenko
01:22 AM Bug #2832: GUI combo-box simple mode is broken
Branch @2832a@ was merged to trunk as revno @10959@ then it was archived. Eugenie Lyzenko
01:12 AM Bug #2832: GUI combo-box simple mode is broken
Testing completed the results: @2832a_10968_de19d84_20151213_evl.zip@. No regressions, the @TC-CODES-EMPLOYEES-021@ a... Eugenie Lyzenko

12/12/2015

06:13 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
Rebased task branch 2565a from P2J trunk rev 10958. The latest revision is now 10973. Igor Skornyakov
07:30 AM Bug #2931: test Safari browser support
Please test the web client from the Safari browser. Report any found issues here. Resolve those issues. Anything r... Greg Shah
07:30 AM Bug #2931 (Closed): test Safari browser support
Greg Shah
07:29 AM Bug #2930: test IE browser support
Please test the web client from the IE 11 browser. Report any found issues here. Resolve those issues. Anything ri... Greg Shah
07:29 AM Bug #2930 (Closed): test IE browser support
Greg Shah
07:28 AM Bug #2929: test chrome browser support
Please test the web client from the Chrome browser. Report any found issues here. Resolve those issues. Anything r... Greg Shah
07:27 AM Bug #2929 (Closed): test chrome browser support
Greg Shah
07:26 AM Bug #2928: non-localhost testing and fixes
For testing, please run through the standalone GUI testcases list (the same ones we use for regression testing GUI). ... Greg Shah
07:24 AM Bug #2928: non-localhost testing and fixes
Please test the web client from a browser on a separate physical system than where the Java client process launches. ... Greg Shah
07:23 AM Bug #2928 (Closed): non-localhost testing and fixes
Greg Shah
07:04 AM Bug #2912: alert-box is displayed on the task bar in Web GUI client, it shouldn't
Code Review Task Branch 1811t Revision 10961
I'm fine with the changes.
Constantin: please review.
Greg Shah
06:58 AM Bug #2916 (Closed): sub-menu arrow in a title is drawn differently: as without left vertical line...
Code Review Task Branch 1811t Revision 10960
The change looks good.
Greg Shah
06:46 AM Bug #2849: implement and/or fix the default popup menus for all widgets
I'm changing the name of this task to more accurately reflect the work needed.
1. For the system icon and titlebar...
Greg Shah
06:42 AM Feature #2927: add I18N features to the default popup menu for editable widgets
Add the missing internationalization features in the default popup menu for editable widgets. See #2849 for details. Greg Shah
06:40 AM Feature #2927 (New): add I18N features to the default popup menu for editable widgets
Greg Shah
06:15 AM Bug #2850: menu/simple_sm.p drawing issues in Swing client
> CHUI. Dynamic attach/detach menubar (MENUBAR layout problems). It correlates with the task #2557
It was my under...
Greg Shah
08:12 PM Bug #2906 (Closed): to support wheel events for the web client
Code Review Task Branch 1811t Revisions 10958 and 10959
The changes look good.
Greg Shah

12/11/2015

05:58 PM Bug #2832: GUI combo-box simple mode is broken
The testing is in progress, main part has been started. Eugenie Lyzenko
04:58 PM Bug #2832: GUI combo-box simple mode is broken
Eugenie Lyzenko wrote:
> Task branch @2832a@ for review updated to revision @10968@.
>
> Added conditional repain...
Constantin Asofiei
03:38 PM Bug #2832: GUI combo-box simple mode is broken
Task branch @2832a@ for review updated to revision @10968@.
Added conditional repaint when changing widget enable ...
Eugenie Lyzenko
03:13 PM Bug #2832: GUI combo-box simple mode is broken
Eugenie: please go ahead and make this fix and then go into testing. Greg Shah
02:58 PM Bug #2832: GUI combo-box simple mode is broken
Eugenie Lyzenko wrote:
> Rebased task branch @2832a@ from P2J trunk revision @10958@, new branch revision is @10967@...
Constantin Asofiei
02:43 PM Bug #2832: GUI combo-box simple mode is broken
Rebased task branch @2832a@ from P2J trunk revision @10958@, new branch revision is @10967@.
Constantin,
If you...
Eugenie Lyzenko
12:57 PM Bug #2832: GUI combo-box simple mode is broken
I agree that it would be optimal to move to an @AbstractContainer@ approach at some point but considering our time co... Greg Shah
08:33 AM Bug #2832: GUI combo-box simple mode is broken
Code Review Task Branch 2832a Revision 10966
I'm good with the changes.
Constantin: do you have any concerns wi...
Greg Shah
07:06 AM Bug #2832: GUI combo-box simple mode is broken
Eugenie Lyzenko wrote:
> Task branch @2832a@ for review updated to revision @10966@.
>
> The fix for recent note....
Hynek Cihlar

12/10/2015

04:08 PM Bug #2832: GUI combo-box simple mode is broken
Task branch @2832a@ for review updated to revision @10966@.
The fix for recent note. Also I have found the format ...
Eugenie Lyzenko
02:30 PM Bug #2832: GUI combo-box simple mode is broken
Task branch @2832a@ for review updated to revision @10965@.
This is the fix for format ignoring issue for @combo-b...
Eugenie Lyzenko
12:33 PM Bug #2832: GUI combo-box simple mode is broken
Hynek Cihlar wrote:
> > Let me know if this update has objections, I'll think for how to rework if this approach is ...
Eugenie Lyzenko
12:16 PM Bug #2832: GUI combo-box simple mode is broken
Eugenie Lyzenko wrote:
> Task branch @2832a@ for review updated to revision @10964@.
>
> Fixes for partial item d...
Hynek Cihlar
11:20 AM Bug #2832: GUI combo-box simple mode is broken
Task branch @2832a@ for review updated to revision @10964@.
Fixes for partial item drawing. Unfortunately approach...
Eugenie Lyzenko
04:05 AM Bug #2832: GUI combo-box simple mode is broken
Eugenie Lyzenko wrote:
> Task branch @2832a@ for review updated to revision @10963@.
>
> This is the fix for visi...
Hynek Cihlar
10:17 PM Bug #2832: GUI combo-box simple mode is broken
Task branch @2832a@ for review updated to revision @10963@.
This is the fix for visible items mismatch. However ne...
Eugenie Lyzenko
01:33 PM Bug #2887: web client flashing/drawing artifacts
Greg, this code change is improved according your review. I can commit the changes to 1811t if you approve it. Sergey Ivanovskiy
11:32 AM Bug #2887: web client flashing/drawing artifacts
> Code Review offscreenBuffer_4.txt
>
> 1. Is it safe to assign @document.body.className@ directly? It will overrid...
Sergey Ivanovskiy
10:23 AM Bug #2887: web client flashing/drawing artifacts
I see my mistake about the "hidden" issue. We toggle visibility in @Window.prototype.setVisible()@ using @this.canva... Greg Shah
10:21 AM Bug #2887: web client flashing/drawing artifacts
Code Review offscreenBuffer_4.txt
1. Is it safe to assign @document.body.className@ directly? It will override al...
Greg Shah
09:33 AM Bug #2887: web client flashing/drawing artifacts
And there was this discussion of the wait timer:
On 11/27/2015 05:09 PM, Serg Ivanovskiy wrote:
> Greg,
>
> I w...
Greg Shah
09:31 AM Bug #2887: web client flashing/drawing artifacts
Then there was this set of responses:
On 11/27/2015 05:10 PM, Greg Shah wrote:
> Sergey,
>
> Please post the di...
Greg Shah
09:29 AM Bug #2887: web client flashing/drawing artifacts
I'm adding some of the early discussion here to record it for future reference:
> On 11/27/2015 01:49 PM, Serg Iva...
Greg Shah
11:09 AM Bug #2795: scoped variables/tables/etc and persistent procedures
Constantin Asofiei wrote:
> Guys, is the @blockDepth@ parameter in this @TemporaryBuffer.define@ API ever emitted?
...
Ovidiu Maxiniuc
03:04 AM Bug #2795: scoped variables/tables/etc and persistent procedures
Eric Faulhaber wrote:
> What additional concerns do you have for this at runtime?
In GLOBAL case: for temp-tables, ...
Constantin Asofiei
02:29 AM Bug #2795: scoped variables/tables/etc and persistent procedures
Guys, is the @blockDepth@ parameter in this @TemporaryBuffer.define@ API ever emitted?... Constantin Asofiei
09:42 AM Support #2672: GUI web client performance improvements
I'm adding some email discussion here for future reference, regarding font/text metrics and text editing:
On 11/27/2...
Greg Shah
03:51 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
Section 27 has been updated. Igor Skornyakov

12/09/2015

02:48 PM Bug #2912: alert-box is displayed on the task bar in Web GUI client, it shouldn't
Greg, please review the committed rev 10961. Sergey Ivanovskiy
01:06 PM Bug #2912: alert-box is displayed on the task bar in Web GUI client, it shouldn't
Hynek Cihlar wrote:
> @realizeChildWindow()@ returns a child top-level window. Although there isn't a formal javadoc...
Sergey Ivanovskiy
12:42 PM Bug #2912: alert-box is displayed on the task bar in Web GUI client, it shouldn't
Sergey Ivanovskiy wrote:
> > Try @simpler_alert_box.p@ for example. I guess we will have to extend the window info p...
Hynek Cihlar
12:34 PM Bug #2912: alert-box is displayed on the task bar in Web GUI client, it shouldn't
No, there is the other way to use @GuiDriver.setWindowVisible(true)@, because at that point we can identify the windo... Sergey Ivanovskiy
12:26 PM Bug #2912: alert-box is displayed on the task bar in Web GUI client, it shouldn't
> Try @simpler_alert_box.p@ for example. I guess we will have to extend the window info passed to JS client so it can... Sergey Ivanovskiy
09:26 AM Bug #2912: alert-box is displayed on the task bar in Web GUI client, it shouldn't
Sergey Ivanovskiy wrote:
> Hynek, please log here what is a target program to reproduce this bug. For the JS client ...
Hynek Cihlar
09:07 AM Bug #2912: alert-box is displayed on the task bar in Web GUI client, it shouldn't
Hynek, please log here what is a target program to reproduce this bug. For the JS client we can't distinguish modal w... Sergey Ivanovskiy
01:30 PM Bug #2795: scoped variables/tables/etc and persistent procedures
Constantin Asofiei wrote:
> The @SVM.addTempTable@ will check the global scope (if there is another temp-table with ...
Eric Faulhaber
12:53 PM Bug #2795: scoped variables/tables/etc and persistent procedures
Eric Faulhaber wrote:
> Your initial solution seems to be runtime-only, but it seems now you are discussing a conver...
Constantin Asofiei
12:30 PM Bug #2795: scoped variables/tables/etc and persistent procedures
Constantin Asofiei wrote:
> There is another issue here, for @DEFINE NEW GLOBAL SHARED TEMP-TABLE@: if there already ...
Eric Faulhaber
11:38 AM Bug #2795: scoped variables/tables/etc and persistent procedures
There is another issue here, for @DEFINE NEW GLOBAL SHARED TEMP-TABLE@: if there already exists a declaration for the... Constantin Asofiei
01:01 PM Bug #2832: GUI combo-box simple mode is broken
Eugenie Lyzenko wrote:
> The only thing that constant is the height in chars and height in pixels(that is computed f...
Hynek Cihlar
12:55 PM Bug #2832: GUI combo-box simple mode is broken
>Yes. Let's take the combo 'cb' from the screen shots. While in P2J the font height in the simple list seems to be gr... Eugenie Lyzenko
12:23 PM Bug #2832: GUI combo-box simple mode is broken
Eugenie Lyzenko wrote:
> Is it the difference you noted?
Yes. Let's take the combo 'cb' from the screen shots. Wh...
Hynek Cihlar
12:10 PM Bug #2832: GUI combo-box simple mode is broken
Hynek Cihlar wrote:
> Tested with @USE-3D-SIZE@ set to @yes@ for both 4GL and P2J.
Take a look at the pictures at...
Eugenie Lyzenko
10:10 AM Bug #2832: GUI combo-box simple mode is broken
Eugenie Lyzenko wrote:
> Hynek Cihlar wrote:
> >
> > [...]
> >
> > Different sizes produce various size differ...
Hynek Cihlar
09:50 AM Bug #2832: GUI combo-box simple mode is broken
Hynek Cihlar wrote:
>
> [...]
>
> Different sizes produce various size differences between P2J and 4GL.
Have...
Eugenie Lyzenko
09:25 AM Bug #2832: GUI combo-box simple mode is broken
Another issue I just noted is that 4GL seems to ignore the format specification for @COMBO-BOX@. Although this is not... Hynek Cihlar
09:22 AM Bug #2832: GUI combo-box simple mode is broken
Eugenie Lyzenko wrote:
> >Only small thing. I noticed the number of visible items in the simple list differs from 4G...
Hynek Cihlar
08:01 AM Bug #2832: GUI combo-box simple mode is broken
>Only small thing. I noticed the number of visible items in the simple list differs from 4GL. Is this expected?
In...
Eugenie Lyzenko
07:37 AM Bug #2832: GUI combo-box simple mode is broken
Hynek Cihlar wrote:
> The code looks ok to me.
>
> Only small thing. I noticed the number of visible items in th...
Eugenie Lyzenko
07:19 AM Bug #2832: GUI combo-box simple mode is broken
Eugenie Lyzenko wrote:
> Task branch @2832a@ for review updated to revision @10962@.
>
> Several fixes to improve...
Hynek Cihlar
11:38 AM Bug #2906: to support wheel events for the web client
-Removed as it was added in wrong task (added to #2795)- Constantin Asofiei
02:00 AM Bug #2906: to support wheel events for the web client
Greg, please review committed revisions 10959/10958. Sergey Ivanovskiy
08:25 AM Bug #2916: sub-menu arrow in a title is drawn differently: as without left vertical line (Web Cli...
Greg, please review the committed rev 10960 (1811t). Sergey Ivanovskiy

12/08/2015

06:03 PM Bug #2832: GUI combo-box simple mode is broken
Task branch @2832a@ for review updated to revision @10962@.
Several fixes to improve @EntryField@ text painting to...
Eugenie Lyzenko
11:20 AM Bug #2832: GUI combo-box simple mode is broken
Task branch @2832a@ for review updated to revision @10961@.
This is the fix for @StringIndexOutOfBoundsException@ ...
Eugenie Lyzenko
06:14 AM Bug #2832: GUI combo-box simple mode is broken
I checked the problematic cases and the @SIMPLE@ mode works fine.
I just noticed an abend when a simple-mode sele...
Hynek Cihlar
03:40 PM Feature #2564: implement GUI BROWSE widget
If a column doesn't fit into visible area, fill-in can be extended to invisible area to the right, maximum 3 pixels (... Stanislav Lomany
02:04 PM Feature #2564: implement GUI BROWSE widget
Positioning of the fill-in in a cell:
!editing1.png!
Stanislav Lomany
01:23 PM Bug #2765: find proper freely licensed replacements for the MS Windows OS fonts
GPL is listed on some sites as the license, but it is not clear what the source of that is from. It also is not clea... Greg Shah
01:21 PM Bug #2765: find proper freely licensed replacements for the MS Windows OS fonts
-------- Forwarded Message --------
Subject: Re: Font rendering
Date: Tue, 8 Dec 2015 17:08:32 +0000
From: Guy ...
Greg Shah
08:02 AM Bug #2765: find proper freely licensed replacements for the MS Windows OS fonts
To be clear, there are 2 things going on here:
1. We are temporarily using the non-bitmap Windows fonts in our tes...
Greg Shah
01:03 PM Bug #2849: implement and/or fix the default popup menus for all widgets
Greg Shah wrote:
> Before we go further with this, I need to address some questions. Some screen captures might help ...
Vadim Gindin
11:56 AM Bug #2906: to support wheel events for the web client
Greg, please review the changes for mouse events due to new added parameters. Sergey Ivanovskiy
08:38 AM Feature #1794: implement font support
Useful KB article:
http://knowledgebase.progress.com/articles/Article/P123946
I think this is exactly what we a...
Greg Shah
07:57 AM Bug #2925: EDITOR widget is invisible in presence of the BROWSE one.
When running the converted version of the attached program the @EDITOR@ widget is invisible. The debugger shows that ... Igor Skornyakov
07:54 AM Bug #2925 (New): EDITOR widget is invisible in presence of the BROWSE one.
Igor Skornyakov
05:23 AM Bug #2924: The combobox drop down throws ArrayIndexOutOfBound exception if the scroll buttons are...
The steps to reproduce for the swing client the current version 1811t ./combo_box/combo_box9_1.p are
1) Open the dro...
Sergey Ivanovskiy
05:17 AM Bug #2924 (Closed): The combobox drop down throws ArrayIndexOutOfBound exception if the scroll bu...
Sergey Ivanovskiy

12/07/2015

06:22 PM Bug #2832: GUI combo-box simple mode is broken
Task branch @2832a@ for review updated to revision @10960@.
This is the initial value set fix for scrollable list....
Eugenie Lyzenko
05:46 PM Bug #2832: GUI combo-box simple mode is broken
>As an example, you can test the @ENABLE ALL@ case as mentioned in note 1. Create a frame with a combo box in simple ... Eugenie Lyzenko
03:41 PM Bug #2832: GUI combo-box simple mode is broken
Eugenie Lyzenko wrote:
> Or I need to know the cases when this approach will fail.
As an example, you can test th...
Hynek Cihlar
02:04 PM Bug #2832: GUI combo-box simple mode is broken
Rebased task branch @2832a@ from P2J trunk revision @10957@, new branch revision is @10958@. Eugenie Lyzenko
01:42 PM Bug #2832: GUI combo-box simple mode is broken
The task branch @2832a@ updated for review at revision @10957@.
The combo-box functionality restored in @SIMPLE@ m...
Eugenie Lyzenko
05:47 PM Bug #2844 (Closed): flat status area in web client
Greg Shah
05:30 PM Bug #2844: flat status area in web client
> Please also test the following:
>
> ./toggle_box/gui/tbx_present.p
> ./combo_box/combo_box9_1.p
> ./rectangle/...
Sergey Ivanovskiy
09:52 AM Bug #2844: flat status area in web client
I have started to check com.goldencode.testcases.toggle_box.gui.TbxPresent.execute with the current trunc version and... Sergey Ivanovskiy
09:08 AM Bug #2844: flat status area in web client
Please also test the following:
./toggle_box/gui/tbx_present.p
./combo_box/combo_box9_1.p
./rectangle/rect_test2...
Greg Shah
08:57 AM Bug #2844: flat status area in web client
I tested this fix with ./demo/demo_widgets.p, ./ask-gui.p, ./hello.p.
Sergey Ivanovskiy
08:33 AM Bug #2844: flat status area in web client
Code Review Task Branch 1811t Revision 10957
The change looks good. What web GUI testcases have you checked with ...
Greg Shah
02:06 PM Feature #2564: implement GUI BROWSE widget
Created task branch 2564e from trunk revision 10957. This branch will contain implementation of editing browse. Stanislav Lomany
10:57 AM Bug #2923: ./combo_box/combo_box9_1.p web combobox width is not enough to display its content wit...
Please look at the attached picture, the web combobox width doesn't match its content with appropriate paddings. Sergey Ivanovskiy
10:54 AM Bug #2923 (New): ./combo_box/combo_box9_1.p web combobox width is not enough to display its conte...
Sergey Ivanovskiy
10:44 AM Bug #2922: ./toggle_box/gui/tbx_present.p clicking on an any scrollbar button leads to its conten...
The bug is related to the scroll pane component and can be reproduced for any test program. For an example, ./combo_b... Sergey Ivanovskiy
10:35 AM Bug #2922: ./toggle_box/gui/tbx_present.p clicking on an any scrollbar button leads to its conten...
The same bug is reproduced for the swing client too. Sergey Ivanovskiy
10:21 AM Bug #2922: ./toggle_box/gui/tbx_present.p clicking on an any scrollbar button leads to its conten...
This bug is found on the current trunc version for the web client. Steps to reproduce are
1) Resize the window to a ...
Sergey Ivanovskiy
10:16 AM Bug #2922 (New): ./toggle_box/gui/tbx_present.p clicking on an any scrollbar button leads to its ...
Sergey Ivanovskiy
09:00 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
Greg Shah wrote:
> Make sure you are working in a fresh branch, so you don't mix up the 2565a branch. Then, just us...
Igor Skornyakov
08:55 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
Make sure you are working in a fresh branch, so you don't mix up the 2565a branch. Then, just use @bzr merge@ and ta... Greg Shah
08:54 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
Greg Shah wrote:
> Actually, Eugenie is not too far from having #2832 resolved. He already has it resolved enough t...
Igor Skornyakov
08:47 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
Actually, Eugenie is not too far from having #2832 resolved. He already has it resolved enough to use simple combo-b... Greg Shah
06:42 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
Because of the #2832 the custom mouse pointer for the @SIMPLE@ @COMBO-BOX@ cannot be implemented now. Igor Skornyakov
05:48 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
Section 27 has been updated. Igor Skornyakov
04:41 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
Resolved the issue with @WINDOW@ custom cursor mentioned in the note 80.
Committed to branch 2565a revno 10966.
Igor Skornyakov
08:48 AM Bug #2704 (Closed): large fill-in drawing differences
Greg Shah
08:20 AM Bug #2704: large fill-in drawing differences
Issues 2 and 3 from note 12 are in tasks #2921 and #2920. This task can be closed. Constantin Asofiei
08:18 AM Bug #2921: fix vertical placement of FILL-IN (editable or not)/LABEL/EDITOR text
From #2704 note 12:
> Vertical placement is still off by a few pixels... this is mostly related to drawing the text c...
Constantin Asofiei
08:17 AM Bug #2921 (Closed): fix vertical placement of FILL-IN (editable or not)/LABEL/EDITOR text
Constantin Asofiei
08:16 AM Bug #2920: fix fill-in caret color when background is not white
The caret color in cases when FILL-IN background's color is not white might follow the same XOR rules we found for ot... Constantin Asofiei
08:15 AM Bug #2920 (New): fix fill-in caret color when background is not white
Constantin Asofiei
07:28 AM Bug #2906: to support wheel events for the web client
Yes, it is a good idea. Please do so. Greg Shah
03:23 AM Bug #2906: to support wheel events for the web client
Greg, Constantin, what do you think if we will implement a support for the ALT/SHIFT/CTRL modifiers within this task?... Sergey Ivanovskiy

12/06/2015

05:42 PM Bug #2832: GUI combo-box simple mode is broken
The task @2832a@ has been created based on trunk revision @10956@. Eugenie Lyzenko

12/05/2015

08:28 AM Bug #2844: flat status area in web client
Done. Committed revision 10957.
Sergey Ivanovskiy

12/04/2015

05:30 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
Rebased task branch 2565a from P2J trunk rev 10956. The latest revision is now 10965. Igor Skornyakov
05:06 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
Greg Shah wrote:
> I think this is a known issue. See #2879. If you are talking about the same thing, then you don...
Igor Skornyakov
05:04 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
> but one cannot make a selection with mouse.
I think this is a known issue. See #2879. If you are talking about...
Greg Shah
04:58 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
1. Implemented @WindowGuiImpl.mouse(Entered/Exited)@. However there is a problem. When mouse enters Window from the e... Igor Skornyakov
03:45 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
Rebased task branch 2565a from P2J trunk rev 10955. The latest revision is now 10963. Igor Skornyakov
04:31 PM Bug #2909: Fix key navigation for popup_ext.p
It is hard to tell if such a change would be OK in those locations. It is possible. However, since the default vers... Greg Shah
03:13 PM Bug #2909: Fix key navigation for popup_ext.p
Have a look at ThinClient diff. It's a draft. Vadim Gindin
02:59 PM Bug #2909: Fix key navigation for popup_ext.p
> It's not so simple, so I proposed that this change could be not acceptable and I can spend some time in vain workin... Greg Shah
02:45 PM Bug #2909: Fix key navigation for popup_ext.p
Greg Shah wrote:
> Can you point out the menu/sub-menu code which you are proposing to change?
At this moment I don...
Vadim Gindin
02:29 PM Bug #2909: Fix key navigation for popup_ext.p
Can you point out the menu/sub-menu code which you are proposing to change?
Constantin: please review this task.
Greg Shah
02:27 PM Bug #2909: Fix key navigation for popup_ext.p
Would it be correct to change our approach (replace @isEnabled()@ with something other in @ThinClient@) or I should f... Vadim Gindin
07:09 AM Bug #2909: Fix key navigation for popup_ext.p
Disabled menu items are navigable.. It contravenes with the our approach, that only enabled @isEnabled()==true@ widge... Vadim Gindin
04:16 PM Bug #2844: flat status area in web client
Please clean up the changes (e.g. please remove all the commented logging), add your history entry(s) and check it in... Greg Shah
02:41 PM Bug #2844: flat status area in web client
> Code Review clipping_regions_1.txt
>
> My primary concern with this change is that the each use of @adjustOrigin...
Sergey Ivanovskiy
02:25 PM Bug #2844: flat status area in web client
Code Review clipping_regions_1.txt
My primary concern with this change is that the each use of @adjustOrigin()@ (w...
Greg Shah
12:18 PM Bug #2844: flat status area in web client
Greg, please review the clipping region changes, the reason is to transform all stacked clipping regions according to... Sergey Ivanovskiy
11:51 AM Bug #2844: flat status area in web client
Good. Post a diff when you have a fix available. Greg Shah
11:06 AM Bug #2844: flat status area in web client
Found the root cause, each of the stacked clipping regions should be updated on translate/untranslate in order to sav... Sergey Ivanovskiy
04:28 AM Bug #2844: flat status area in web client
The hello.p JS client drawing logs proves that this bug is due to an incorrect last clipping region that is used for ... Sergey Ivanovskiy
04:15 PM Feature #1811: implement the AJAX client driver
Created task branch 1811t from P2J trunk 10956. This will contain the changes for #2844, #2906, #2912, #2916, #2672,... Greg Shah
02:55 PM Bug #2849: implement and/or fix the default popup menus for all widgets
No it is shown only for FillIn and Editor. I've attached my current testcase. Vadim Gindin
02:42 PM Bug #2849: implement and/or fix the default popup menus for all widgets
> Currently I'd checked Toggle-box, FillIn, Editor, Slider, Selection-list, Combobox, Button.
Does it show in Togg...
Greg Shah
02:41 PM Bug #2849: implement and/or fix the default popup menus for all widgets
Here is how default pop-up menu looks like:
!default_popup.png!
It is shown the same for @FillIn@ and @Editor@ widg...
Vadim Gindin
08:58 AM Bug #2849: implement and/or fix the default popup menus for all widgets
Before we go further with this, I need to address some questions. Some screen captures might help too.
1. You are ...
Greg Shah
02:12 PM Bug #2919: new version of demo_widgets.p displays the drawing artifact related to cursor in the u...
The picture for the web client. Sergey Ivanovskiy
02:07 PM Bug #2919: new version of demo_widgets.p displays the drawing artifact related to cursor in the u...
For the swing client the drawing artifact is not stable and disappears if you click on the window, but for the web cl... Sergey Ivanovskiy
02:00 PM Bug #2919 (New): new version of demo_widgets.p displays the drawing artifact related to cursor in...
Sergey Ivanovskiy
01:16 PM Bug #2912: alert-box is displayed on the task bar in Web GUI client, it shouldn't
Yes, this only happens in Web GUI. Hynek Cihlar
08:25 AM Bug #2912: alert-box is displayed on the task bar in Web GUI client, it shouldn't
This only happens in the web client? Greg Shah
08:39 AM Bug #2918: frame title active state difference for frames without focusable widgets
This issue is happening when the frame has no focusable widgets inside and for certain conditions. The example - @rec... Eugenie Lyzenko
08:36 AM Bug #2918 (Closed): frame title active state difference for frames without focusable widgets
Eugenie Lyzenko
07:45 AM Support #2672: GUI web client performance improvements
We need to coordinate this work with #2913, which is related. Greg Shah
07:43 AM Bug #2913: Improve window dragging in Web GUI client
Although this is a bug, it is highly related to the web client performance improvements we will be making in #2672. ... Greg Shah
07:31 AM Bug #2897: image based button become distorted on exit after disable/enable cycle
From Sergey:
The last log's lines were produced by clicking "Quit" button according to your scenario . It looks li...
Greg Shah
02:42 AM Bug #2857: font differences for toggle box and menu
Vadim Gindin wrote:
> 3 Right after start and MENUBAR is drawn, when I move mouse pointer under the MENUBAR all items...
Vadim Gindin
02:38 AM Bug #2916: sub-menu arrow in a title is drawn differently: as without left vertical line (Web Cli...
Here are the images of incorrect arrows: !sm_arrow.png! and !sm_arrow_hl.png! and correct arrows: !correct_arrows.png! Vadim Gindin
02:22 AM Bug #2916 (Closed): sub-menu arrow in a title is drawn differently: as without left vertical line...
Vadim Gindin

12/03/2015

06:07 PM Bug #2915: A modal window in Swing GUI client should not be on top of all other OS windows
A modal window in Swing GUI client should not be on top of all other OS windows. This applies to @ALERT-BOX@ and @DIA... Hynek Cihlar
06:05 PM Bug #2915 (New): A modal window in Swing GUI client should not be on top of all other OS windows
Hynek Cihlar
06:03 PM Bug #2914 (Closed): Fix errors in window_sizing/test_runner.p
Hynek Cihlar
06:01 PM Bug #2913: Improve window dragging in Web GUI client
When window is mouse-dragged by its title bar and the mouse speed reached certain threshold (and the mouse cursor lea... Hynek Cihlar
06:00 PM Bug #2913 (Feedback): Improve window dragging in Web GUI client
Hynek Cihlar
05:59 PM Bug #2912 (Closed): alert-box is displayed on the task bar in Web GUI client, it shouldn't
Hynek Cihlar
05:50 PM Bug #2828: alert-box button text is vertically positioned too low in the web client as compared w...
I retested 2677a and 2677b and the problem still exists in web client. The button text is shifted up though. See the ... Hynek Cihlar
05:49 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
@FrameGuiImpl.mouse(Entered/Exited)@ is implemented. It is clear how to do the same for the @WindowGuiImpl@.
Committ...
Igor Skornyakov
11:50 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
Constantin Asofiei wrote:
> Please describe in detail how your solution will work. Look at how currently @GuiDriver...
Igor Skornyakov
11:42 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
Igor Skornyakov wrote:
> Constantin Asofiei wrote:
> > I would expect the implementation should not require any spe...
Constantin Asofiei
10:03 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
Constantin Asofiei wrote:
> I would expect the implementation should not require any specific code in widget classes...
Igor Skornyakov
09:30 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
Igor Skornyakov wrote:
> Constantin Asofiei wrote:
> > Please give an example why these are needed for @FRAME@.
> ...
Constantin Asofiei
08:55 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
Constantin Asofiei wrote:
> Please give an example why these are needed for @FRAME@.
Imagine that we have two fra...
Igor Skornyakov
08:42 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
Igor Skornyakov wrote:
> Constantin Asofiei wrote:
> > > At this moment it seems that @mouseEntered@/@mouseExited@ ...
Constantin Asofiei
08:41 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
Constantin Asofiei wrote:
> > At this moment it seems that @mouseEntered@/@mouseExited@ are not invoked for @FRAME@ ...
Igor Skornyakov
08:28 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
Igor Skornyakov wrote:
> At this moment it seems that @mouseEntered@/@mouseExited@ are not invoked for @FRAME@ and @...
Constantin Asofiei
01:31 PM Bug #2736 (Closed): fix GUI menu drawing problems in menu/simple_sm.p
Greg Shah
01:24 PM Bug #2910: artifacts (traces) of closed pop-up menu and menubar is stayed in the workspace
This only occurs in the Web Client. Greg Shah
12:45 PM Bug #2910 (Closed): artifacts (traces) of closed pop-up menu and menubar is stayed in the workspace
Vadim Gindin
01:05 PM Bug #2911: Fix extra background shown for popup_ext.p
See details in #2736 starting from the note 15. Vadim Gindin
01:04 PM Bug #2911 (Closed): Fix extra background shown for popup_ext.p
Vadim Gindin
12:43 PM Bug #2909: Fix key navigation for popup_ext.p
Described behaviour makes sense for GUI. Vadim Gindin
12:42 PM Bug #2909: Fix key navigation for popup_ext.p
# Check if key navigation works even mouse pointer is not over the opened pop-up menu: somewhere else even outside of... Vadim Gindin
12:34 PM Bug #2909 (Closed): Fix key navigation for popup_ext.p
Vadim Gindin
11:29 AM Bug #2907: UPDATE statement in a window which is not ACTIVE-WINDOW must bring the window on top
In @demo/simple_windows.p@, an UPDATE must bring its owner window to top. The task should check the other input bloc... Constantin Asofiei
11:27 AM Bug #2907 (New): UPDATE statement in a window which is not ACTIVE-WINDOW must bring the window on...
Constantin Asofiei
10:46 AM Bug #2906: to support wheel events for the web client
If the wheel events are permitted (the direction is set for them), they can load demo_widgets.p. Sergey Ivanovskiy
10:45 AM Bug #2906 (Closed): to support wheel events for the web client
Sergey Ivanovskiy
10:41 AM Bug #2905: ./window_parenting/waitfor_2wnd.p the web client displays two windows with grey title...
Two windows are displayed with grey title bars and one of them has the active task icon (the initial web client displ... Sergey Ivanovskiy
10:38 AM Bug #2905 (New): ./window_parenting/waitfor_2wnd.p the web client displays two windows with grey...
Sergey Ivanovskiy
10:34 AM Bug #2904: ./frame-z-order/zw1.p - incorrect focus owner
The corresponding fill-in widget on the current active window should have a focus and if the current active window is... Sergey Ivanovskiy
10:28 AM Bug #2904 (New): ./frame-z-order/zw1.p - incorrect focus owner
Sergey Ivanovskiy
08:24 AM Bug #2903: the height of the frame in movie-ratings-static.p is incorrect
The height of the frame in the @movie-ratings-static.p@ is incorrect. See bellow: left is P2J, right is 4GL.
!mov...
Constantin Asofiei
08:23 AM Bug #2903 (New): the height of the frame in movie-ratings-static.p is incorrect
Constantin Asofiei
08:20 AM Bug #2902: demo/demo_widgets.p top frame is made scrollable (height is incorrect?)
Another issue: even if the frame is made scrollabe, using the scrollbar doesn't scroll the content. We should double... Constantin Asofiei
08:20 AM Bug #2902: demo/demo_widgets.p top frame is made scrollable (height is incorrect?)
Ensure you have the latest @testcases/uast/demo/demo_widgets.p@. The top-frame is made scrollable, when it should ha... Constantin Asofiei
08:18 AM Bug #2902 (New): demo/demo_widgets.p top frame is made scrollable (height is incorrect?)
Constantin Asofiei
08:09 AM Bug #2901: clicking on a checkbox without label displays the "selected" rectangle at the right-si...
When selecting the 5th checkbox in the @Ratings@ group, there is a small rectangle drawn to the right side of it. Th... Constantin Asofiei
08:05 AM Bug #2901 (New): clicking on a checkbox without label displays the "selected" rectangle at the ri...
Constantin Asofiei
08:04 AM Bug #2900: the drop-down in movie-ratings-dynamic.p shows an extra line
When opening the @Select movie@ combo-box drop-down, there is an extra empty row added to the bottom, just bellow @Pu... Constantin Asofiei
08:03 AM Bug #2900 (New): the drop-down in movie-ratings-dynamic.p shows an extra line
Constantin Asofiei
08:02 AM Bug #2899: drop-down text "Pulp Fiction" is trimmed incorrectly in movie-ratings-dynamic.p
In the movie-selection combo-box, when opening the drop-down, instead of @Pulp Fiction@ P2J displays @Pulp Fic@. Same... Constantin Asofiei
08:00 AM Bug #2899 (New): drop-down text "Pulp Fiction" is trimmed incorrectly in movie-ratings-dynamic.p
Constantin Asofiei

12/02/2015

05:45 PM Bug #2897: image based button become distorted on exit after disable/enable cycle
This issue is Web client related only. In Swing it is OK. The testcases is @./button/gui_btn_test5.p@. To recreate:
...
Eugenie Lyzenko
05:37 PM Bug #2897 (New): image based button become distorted on exit after disable/enable cycle
Eugenie Lyzenko
04:42 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
TODO (Swing):
1. Support for special cases: BROWSE, COMBO-BOX
2. @mouseEntered@/@mouseExited@ for @FRAME@ and @WIN...
Igor Skornyakov
04:06 AM Bug #2832: GUI combo-box simple mode is broken
Hynek Cihlar wrote:
>
> Eugenie, if you recover the original design, the implementation will be still broken. Mult...
Eugenie Lyzenko
02:39 AM Bug #2832: GUI combo-box simple mode is broken
Eugenie Lyzenko wrote:
> The investigation shows the SIMPLE mode internal logic is almost all broken. I've recovered...
Hynek Cihlar
08:41 PM Bug #2832: GUI combo-box simple mode is broken
The investigation shows the SIMPLE mode internal logic is almost all broken. I've recovered most of all but not yet c... Eugenie Lyzenko

12/01/2015

05:50 PM Bug #2895: Implement separate COLUMN-LABEL annotations for similair temp tables
See task #2564 notes 206, 217-233. Stanislav Lomany
05:47 PM Bug #2895 (New): Implement separate COLUMN-LABEL annotations for similair temp tables
Stanislav Lomany
05:34 PM Feature #2894 (Closed): Implement browse multiple selection with Shift and Ctrl keys
Stanislav Lomany
05:34 PM Bug #2893 (Closed): Mouse clicks on rows are not 100% accurate
Stanislav Lomany
05:32 PM Feature #2892 (Closed): Implement browse scrolling with mouse wheel
Stanislav Lomany
05:01 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
At this moment it seems that @mouseEntered@/@mouseExited@ are not invoked for @FRAME@ and @WINDOW@. We need toi imple... Igor Skornyakov
09:05 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
@ON ENTRY@ trigger activation is not compatible with 4GL.
When the attached program runs in 4GL the @ON ENTRY ANYW...
Igor Skornyakov
06:52 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
In 4GL the attached program opens two windows (a second one after any widget gains focus). The messages are displayed... Igor Skornyakov
06:38 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
@SLIDER@ doesn't work.... Igor Skornyakov
02:37 PM Feature #2564: implement GUI BROWSE widget
Also, create a new sub-task of #2811 for the buffer scoping issue. I want to close #2819. Greg Shah
02:37 PM Feature #2564: implement GUI BROWSE widget
The priority of 1 through 6 is correct. I have no specific opinion on 7 through 11. We can leave it as is for now.
...
Greg Shah
01:34 PM Feature #2564 (WIP): implement GUI BROWSE widget
Remaining issues.
Will make soon:
1. #2825 fix is ready and tested, can be merged to trunk after 2677b
2. #2882 WI...
Stanislav Lomany
10:18 AM Bug #2891: Cannot switch between windows in simple_windows.p
Testcase:... Stanislav Lomany
10:13 AM Bug #2891 (New): Cannot switch between windows in simple_windows.p
Stanislav Lomany
09:28 AM Bug #2890: Incompatible ON ENTRY trigger activation
@ON ENTRY@ trigger activation is not compatible with 4GL.
When the attached program runs in 4GL the @ON ENTRY ANYW...
Igor Skornyakov
09:27 AM Bug #2890 (New): Incompatible ON ENTRY trigger activation
Igor Skornyakov
09:25 AM Bug #2889: Multiple windows support is incorrect
In 4GL the attached program opens two windows (a second one after any widget gains focus and a corresponding @MESSAGE... Igor Skornyakov
09:23 AM Bug #2889 (New): Multiple windows support is incorrect
Igor Skornyakov
05:29 AM Bug #2749 (Closed): widget keeps drawing with focus highlight when a different from gets selected
Greg Shah

11/30/2015

04:10 PM Bug #2749: widget keeps drawing with focus highlight when a different from gets selected
The fix for issue and fix for clipped image in @movie-ratings-dynamic.p@ has been committed in bzr as @10979@ for rev... Eugenie Lyzenko
09:38 AM Bug #2749: widget keeps drawing with focus highlight when a different from gets selected
The fix is based on the fact when combo-box is losing the focus the widget look is different. It is possible to fix t... Eugenie Lyzenko

11/29/2015

06:11 AM Bug #2888: SELECTION-LIST ignores DEFAULT-ACTION
The following code sample should output a message when selection list is double-clicked or ENTER is pressed.... Hynek Cihlar
06:06 AM Bug #2888 (New): SELECTION-LIST ignores DEFAULT-ACTION
Hynek Cihlar

11/28/2015

09:27 PM Bug #2749: widget keeps drawing with focus highlight when a different from gets selected
The investigation results. The frames inside test properly receive the gaining/loosing focus. This is the painting is... Eugenie Lyzenko

11/27/2015

06:59 PM Bug #2887: web client flashing/drawing artifacts
it fixes the wait cursor issue. Also it passes simple tests. Sergey Ivanovskiy
06:51 PM Bug #2887: web client flashing/drawing artifacts
Greg, please review this diff. It passes 454 testcase for the customer. The changes are to assign p2j.socket.js a fun... Sergey Ivanovskiy
06:20 PM Bug #2887: web client flashing/drawing artifacts
The issue is to smooth flashing effects. The proposed solution creates the off screen canvas and the window canvas. C... Sergey Ivanovskiy
05:09 PM Bug #2887 (Closed): web client flashing/drawing artifacts
Greg Shah
02:53 PM Bug #2849: implement and/or fix the default popup menus for all widgets
I've checked again @FillIn@ and @Editor@ widgets. It behave in the following way (when right mouse button is clicked)... Vadim Gindin
02:24 PM Bug #2850: menu/simple_sm.p drawing issues in Swing client
There are the following issues:
# CHUI. Dynamic attach/detach menubar (MENUBAR layout problems). It correlates with ...
Vadim Gindin
02:08 PM Bug #2850: menu/simple_sm.p drawing issues in Swing client
Are there any issues mentioned in this task which are not yet fixed AND which are not part of some other open task? Greg Shah
01:29 PM Bug #2850: menu/simple_sm.p drawing issues in Swing client
Committed with revno 10978. Vadim Gindin
01:06 PM Bug #2850: menu/simple_sm.p drawing issues in Swing client
Go ahead and check these into 2677b. Greg Shah
12:04 PM Bug #2850: menu/simple_sm.p drawing issues in Swing client
Here is the current changes diff (base on revision 10976 of the branch 2677b). Changes solve 3 bugs, described in the... Vadim Gindin
02:20 PM Bug #2851 (WIP): the default-window retains its active titlebar even when it is no longer the foc...
Greg Shah
02:18 PM Bug #2749: widget keeps drawing with focus highlight when a different from gets selected
Sorry, wrong task. Greg Shah
02:17 PM Bug #2749 (WIP): widget keeps drawing with focus highlight when a different from gets selected
Greg Shah
02:10 PM Bug #2854 (Closed): scrollbar buttons don't draw the pressed state
Greg Shah
01:16 PM Bug #2854: scrollbar buttons don't draw the pressed state
The @evl_upd20151125a.diff@ has been committed in @2677b@ as @10977@. Eugenie Lyzenko
01:06 PM Bug #2854: scrollbar buttons don't draw the pressed state
Go ahead and check these into 2677b. Greg Shah
09:21 AM Bug #2854: scrollbar buttons don't draw the pressed state
We know there are some regressions in the GUI testcases for 2677b. Let's see how significant these are before we dec... Greg Shah
01:56 PM Bug #2886: missing pause when an invalid program name is input in ask-gui.p
Please see #2778-96 for details. Greg Shah
01:55 PM Bug #2886 (New): missing pause when an invalid program name is input in ask-gui.p
Greg Shah
01:52 PM Bug #2779 (Closed): ./demo/calc-static-chars.p has the vertical scrollbar and its buttons layout ...
As of task branch 2677b revision 10976 this no longer occurs. I'm not sure which update resolved it but we have made... Greg Shah
01:46 PM Bug #2828: alert-box button text is vertically positioned too low in the web client as compared w...
This same issue can be seen in the frame title for the web client (the text is positioned to the right and lower than... Greg Shah
09:22 AM Bug #2809: implement missing behaviour related to HIDDEN attribute
Greg Shah wrote:
> Is there more work still needed for WINDOW:HIDDEN and DIALOG-BOX:HIDDEN?
Yes, I haven't tested y...
Constantin Asofiei
09:20 AM Bug #2809: implement missing behaviour related to HIDDEN attribute
Is there more work still needed for WINDOW:HIDDEN and DIALOG-BOX:HIDDEN? Greg Shah
07:01 AM Bug #2809: implement missing behaviour related to HIDDEN attribute
2677b rev 10975 fixes implicit window show, when is targeted by a frame; the UI statements showing the window are the... Constantin Asofiei
06:53 AM Bug #2861 (Closed): fix widget z-order inside frame, when focus is switching - there are differen...
Agreed, this is done. Greg Shah

11/26/2015

06:08 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
Rebased task branch 2565a from P2J trunk rev 10954. The latest revision is now 10957. Igor Skornyakov
04:58 PM Bug #2851: the default-window retains its active titlebar even when it is no longer the focused w...
After recent rebase for @2677b@ the test @frame-z-order/zw1.p@ stops working. The windows are all hidden now. Eugenie Lyzenko
10:07 PM Bug #2851: the default-window retains its active titlebar even when it is no longer the focused w...
This is some intermediate results for review. I've uploaded as zip instead of diffing because fix is in progress and ... Eugenie Lyzenko
03:34 PM Bug #2854: scrollbar buttons don't draw the pressed state
Hynek Cihlar wrote:
> Eugenie Lyzenko wrote:
>
> The threading issue is resolved.
>
> Just one thing for futur...
Eugenie Lyzenko
03:25 PM Bug #2854: scrollbar buttons don't draw the pressed state
Eugenie Lyzenko wrote:
> This is the updated diff for review.
The threading issue is resolved.
Just one thing ...
Hynek Cihlar
03:11 PM Bug #2854: scrollbar buttons don't draw the pressed state
This is the updated diff for review. Eugenie Lyzenko
02:36 PM Bug #2854: scrollbar buttons don't draw the pressed state
Hynek Cihlar wrote:
> Btw., the same problem is in @ScrollBarGuiImpl.mousePressed()@. @EventManager.postEvent()@ mus...
Eugenie Lyzenko
12:13 PM Bug #2854: scrollbar buttons don't draw the pressed state
Btw., the same problem is in @ScrollBarGuiImpl.mousePressed()@. @EventManager.postEvent()@ must be replaced with @Thi... Hynek Cihlar
11:08 AM Bug #2854: scrollbar buttons don't draw the pressed state
Eugenie Lyzenko wrote:
> Hynek Cihlar wrote:
> > Eugenie Lyzenko wrote:
> >
> > You have to use @ThinClient.post...
Hynek Cihlar
09:37 AM Bug #2854: scrollbar buttons don't draw the pressed state
Hynek Cihlar wrote:
> Eugenie Lyzenko wrote:
>
> You have to use @ThinClient.postOSEvent()@ so that the event man...
Eugenie Lyzenko
08:43 AM Bug #2854: scrollbar buttons don't draw the pressed state
Eugenie Lyzenko wrote:
> >Do you mean the scroll bar is not redrawn? Is the scroll event properly processed, is the ...
Hynek Cihlar
08:08 AM Bug #2854: scrollbar buttons don't draw the pressed state
>Do you mean the scroll bar is not redrawn? Is the scroll event properly processed, is the scroll bar state updated?
...
Eugenie Lyzenko
03:43 AM Bug #2854: scrollbar buttons don't draw the pressed state
Eugenie Lyzenko wrote:
> Hynek Cihlar wrote:
> > Eugenie Lyzenko wrote:
> >
> > Very well.
> >
> > We also n...
Hynek Cihlar
03:34 AM Bug #2854: scrollbar buttons don't draw the pressed state
Hynek Cihlar wrote:
> Eugenie Lyzenko wrote:
>
> Very well.
>
> We also need to get rid of the @ThinClient.ev...
Eugenie Lyzenko
02:46 AM Bug #2854: scrollbar buttons don't draw the pressed state
Eugenie Lyzenko wrote:
> Hynek Cihlar wrote:
> >
> > No. During the time you are scrolling, the application is st...
Hynek Cihlar
02:14 PM Bug #2861: fix widget z-order inside frame, when focus is switching - there are differences betwe...
Second run has only a common failure: GSO 17's gso_17.sum report has an extra row... I'm inclined to assume is a fals... Constantin Asofiei
09:36 AM Bug #2861: fix widget z-order inside frame, when focus is switching - there are differences betwe...
Runtime testing passed with only false negatives (I assume). I'm running main part again to confirm. Constantin Asofiei
03:08 AM Bug #2861: fix widget z-order inside frame, when focus is switching - there are differences betwe...
2677b rev 10968 fixes the regression in note 7. Runtime testing is in progress again. Constantin Asofiei
03:06 AM Bug #2861: fix widget z-order inside frame, when focus is switching - there are differences betwe...
The changes exposed an existing issue in @Frame.drawDownFrame@: @frameScroll.minimumSize@ reports incorrect height; i... Constantin Asofiei
03:47 AM Bug #2849: implement and/or fix the default popup menus for all widgets
Vadim Gindin wrote:
> ..
> There are possible 3 variants:
> # Leave the current change, that add right mouse butt...
Vadim Gindin
03:39 AM Bug #2850: menu/simple_sm.p drawing issues in Swing client
Yesterday, I've fixed CHUI bug with menubar:
> Another bug for CHUI: Focused element of MENUBAR must be drawn as Col...
Vadim Gindin

11/25/2015

06:06 PM Bug #2854: scrollbar buttons don't draw the pressed state
Hynek Cihlar wrote:
>
> No. During the time you are scrolling, the application is still processing input.
>
> ...
Eugenie Lyzenko
05:07 PM Bug #2854: scrollbar buttons don't draw the pressed state
Eugenie Lyzenko wrote:
> Hynek Cihlar wrote:
> > Eugenie Lyzenko wrote:
> >
> > I don't agree. Other events are ...
Hynek Cihlar
05:01 PM Bug #2854: scrollbar buttons don't draw the pressed state
Hynek Cihlar wrote:
> Eugenie Lyzenko wrote:
>
> I don't agree. Other events are processed when the mouse button ...
Eugenie Lyzenko
04:54 PM Bug #2854: scrollbar buttons don't draw the pressed state
Eugenie Lyzenko wrote:
> The auto scroll should work only when mouse is down. We need to react immediately. And this...
Hynek Cihlar
04:19 PM Bug #2854: scrollbar buttons don't draw the pressed state
>You've made the ScrollBarGuiButton.mouseInputExecutor static ... I don't think you wanted to remain so, as you added... Eugenie Lyzenko
12:22 PM Bug #2854: scrollbar buttons don't draw the pressed state
Greg Shah wrote:
> Code Review evl_upd20151125a.diff
>
> I'm OK with the changes.
>
> Hynek/Constantin: do you have...
Hynek Cihlar
12:07 PM Bug #2854: scrollbar buttons don't draw the pressed state
Eugenie Lyzenko wrote:
> Greg Shah wrote:
> > Eugenie: please resolve items 2 and 3 from Constantin's feedback.
> ...
Constantin Asofiei
11:59 AM Bug #2854: scrollbar buttons don't draw the pressed state
Code Review evl_upd20151125a.diff
I'm OK with the changes.
Hynek/Constantin: do you have any remaining concerns?
Greg Shah
09:23 AM Bug #2854: scrollbar buttons don't draw the pressed state
>Btw., why is the extra thread needed? Can't we just redraw the button back up on a mouse button released event?
N...
Eugenie Lyzenko
09:17 AM Bug #2854: scrollbar buttons don't draw the pressed state
Greg Shah wrote:
> Eugenie: please resolve items 2 and 3 from Constantin's feedback.
>
Done with evl_upd2015112...
Eugenie Lyzenko
09:13 AM Bug #2854: scrollbar buttons don't draw the pressed state
Hynek Cihlar wrote:
> Eugenie Lyzenko wrote:
> > This is implementation for auto-scroll mode as reaction to press a...
Hynek Cihlar
09:04 AM Bug #2854: scrollbar buttons don't draw the pressed state
Eugenie Lyzenko wrote:
> This is implementation for auto-scroll mode as reaction to press and hold the mouse on scro...
Hynek Cihlar
08:43 AM Bug #2854: scrollbar buttons don't draw the pressed state
Eugenie: please resolve items 2 and 3 from Constantin's feedback.
I'll add a task for the web client flashing issue.
Greg Shah
08:22 AM Bug #2854: scrollbar buttons don't draw the pressed state
Greg Shah wrote:
> Code Review evl_upd20151124d.diff
>
> My primary concern is whether the new approach has any n...
Constantin Asofiei
07:32 AM Bug #2854: scrollbar buttons don't draw the pressed state
Code Review evl_upd20151124d.diff
My primary concern is whether the new approach has any negative ramifications fo...
Greg Shah
09:45 PM Bug #2854: scrollbar buttons don't draw the pressed state
This is implementation for auto-scroll mode as reaction to press and hold the mouse on scrollbar button. Eugenie Lyzenko
08:09 PM Bug #2854: scrollbar buttons don't draw the pressed state
This is the change for review to note #2 resolution.
I have found another deviation with @4GL@. When press and hol...
Eugenie Lyzenko
04:50 PM Bug #2851: the default-window retains its active titlebar even when it is no longer the focused w...
We have serious issue with @window@ activation here. Especially when there are many windows in addition to the main w... Eugenie Lyzenko
01:08 PM Bug #2861: fix widget z-order inside frame, when focus is switching - there are differences betwe...
Code Review Task Branch 2677b Revision 10966
The changes are good. The resulting code is much cleaner. Hopefully...
Greg Shah
12:53 PM Bug #2861 (Review): fix widget z-order inside frame, when focus is switching - there are differen...
2677b rev 10966 contains a fix for this and #2878.
I'm starting runtime testing with this revision.
Constantin Asofiei
10:47 AM Bug #2861: fix widget z-order inside frame, when focus is switching - there are differences betwe...
No, adding a clipping rectangle with only the widget's visible part will not work - as the visible part may not be a ... Constantin Asofiei
05:55 AM Bug #2861: fix widget z-order inside frame, when focus is switching - there are differences betwe...
The issues in @nested_frames.p@ are not exactly z-order related. The problem is with explicit widget drawing, when t... Constantin Asofiei
04:20 AM Bug #2861 (WIP): fix widget z-order inside frame, when focus is switching - there are differences...
Constantin Asofiei
11:52 AM Bug #2850: menu/simple_sm.p drawing issues in Swing client
Here is the latest diff on merged branch. Vadim Gindin
10:23 AM Bug #2850: menu/simple_sm.p drawing issues in Swing client
Vadim Gindin wrote:
> Talking about ability to draw menu with opened sub-menus exceeding window sizes, is there a se...
Hynek Cihlar
09:50 AM Bug #2850: menu/simple_sm.p drawing issues in Swing client
OK, I understand.
I have collected changes for 2-3 tasks and I would want to commit some of them, that are approve...
Vadim Gindin
03:18 AM Bug #2850: menu/simple_sm.p drawing issues in Swing client
Greg Shah wrote:
> > In that case w.isVisible()==false and therefore super.currentFocus() will be called. Isn't it?
...
Hynek Cihlar
09:44 AM Bug #2879: selecting item from the list by mouse in SELECTION-LIST widget is broken
To recreate use any @SELECTION-LIST@ widget test like @selection_list/sel_list_test10.p@ and try to click on some ite... Eugenie Lyzenko
09:41 AM Bug #2879 (New): selecting item from the list by mouse in SELECTION-LIST widget is broken
Eugenie Lyzenko
08:42 AM Feature #1798 (Closed): implement full frame family support (parent-child relationships between f...
Well done! Greg Shah
08:39 AM Feature #1798: implement full frame family support (parent-child relationships between frames)
Constantin Asofiei wrote:
> 2677b rev 10960 fixes another regression (looks like is last one). runtime testing is in...
Constantin Asofiei
03:47 AM Feature #1798: implement full frame family support (parent-child relationships between frames)
2677b rev 10960 fixes another regression (looks like is last one). runtime testing is in progress. Constantin Asofiei
07:55 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
The approach based on the EditableWidget should be re-designed for a number of reasons:
1. The mouse cursor shape fo...
Igor Skornyakov

11/24/2015

06:28 PM Bug #2854: scrollbar buttons don't draw the pressed state
The point #2 is still under resolution. Be ready later today. Eugenie Lyzenko
06:15 PM Bug #2854: scrollbar buttons don't draw the pressed state
The changes for review to fix. We need to use @repaint()@ for pressing state. In drop-down based combo-box the specia... Eugenie Lyzenko
04:40 PM Bug #2850: menu/simple_sm.p drawing issues in Swing client
> In that case w.isVisible()==false and therefore super.currentFocus() will be called. Isn't it?
Yes, you're proba...
Greg Shah
03:01 PM Bug #2850: menu/simple_sm.p drawing issues in Swing client
Greg Shah wrote:
> > It is just a such behaviour: while popup menu is opened, tab order isn't working and navigation...
Vadim Gindin
02:42 PM Bug #2850: menu/simple_sm.p drawing issues in Swing client
> It is just a such behaviour: while popup menu is opened, tab order isn't working and navigation is available only i... Greg Shah
02:35 PM Bug #2850: menu/simple_sm.p drawing issues in Swing client
Greg Shah wrote:
> Code Review 1124.diff
>
> My only question is regarding the addition of the @Window.currentFoc...
Vadim Gindin
02:10 PM Bug #2850: menu/simple_sm.p drawing issues in Swing client
Code Review 1124.diff
My only question is regarding the addition of the @Window.currentFocus()@ code. This seems ...
Greg Shah
12:18 PM Bug #2850: menu/simple_sm.p drawing issues in Swing client
All 3 points in this task are fixed. See attached diff. I've separated issues from other tasks. Vadim Gindin
08:58 AM Bug #2850: menu/simple_sm.p drawing issues in Swing client
1. Separate out the changes for toggle-box/right mouse issues.
2. Fix the rest based on the code reviews.
Greg Shah
08:54 AM Bug #2850: menu/simple_sm.p drawing issues in Swing client
So should I fix it now or postpone that? Vadim Gindin
07:29 AM Bug #2850: menu/simple_sm.p drawing issues in Swing client
Beside what Greg noted:
* in ChUI, message area, status area, frames (and menubar) are all attached to the same pare...
Constantin Asofiei
07:18 AM Bug #2850: menu/simple_sm.p drawing issues in Swing client
Code Review 1123.diff
1. I don't think it is a good idea to require that the status line and message line implemen...
Greg Shah
02:12 PM Bug #2836 (Closed): wrong number of inner lines in COMBO-BOX
Greg Shah
02:03 PM Bug #2836: wrong number of inner lines in COMBO-BOX
Greg Shah wrote:
> Code Review evl_upd20151124a.zip
>
> I'm fine with the change. You can check it into branch 2...
Eugenie Lyzenko
01:38 PM Bug #2836: wrong number of inner lines in COMBO-BOX
Code Review evl_upd20151124a.zip
I'm fine with the change. You can check it into branch 2677b.
Greg Shah
01:30 PM Bug #2836: wrong number of inner lines in COMBO-BOX
This is the fix for issue. @ComboBoxWidget.finishSetup()@ recalculates the @INNER-LINES@ value after explicitly set. ... Eugenie Lyzenko
02:11 PM Bug #2859 (Closed): combo-box layout obscures the 3D border
Greg Shah
01:52 PM Bug #2859: combo-box layout obscures the 3D border
The fix for issue from @evl_upd20151123b.zip@ has been commited in @2677b@ as revision @10956@. Eugenie Lyzenko
01:33 PM Bug #2859: combo-box layout obscures the 3D border
The changes will be checked in with #2816 (see note 10). Greg Shah
11:46 AM Feature #1801: add some frame options
Hynek Cihlar wrote:
> The attached diff improves drawing of FILL-IN border. It utilizes the @Keep3DFillinBorder@ env...
Hynek Cihlar
11:21 AM Feature #1801: add some frame options
Please note that the diff attached with note 314 was also posted to #2876 as it also contains fixes related to #2876,... Hynek Cihlar
11:14 AM Feature #1801: add some frame options
The attached diff improves drawing of FILL-IN border. It utilizes the @Keep3DFillinBorder@ environment variable, when... Hynek Cihlar
10:03 AM Feature #1798: implement full frame family support (parent-child relationships between frames)
Constantin Asofiei wrote:
> > Yes, @DIALOG@ window should only host one frame. There is an abstract method @TopLevelW...
Hynek Cihlar
09:39 AM Feature #1798: implement full frame family support (parent-child relationships between frames)
Greg Shah wrote:
> What else is left to do for this task (besides regression testing)?
I can't think of anything el...
Constantin Asofiei
09:39 AM Feature #1798: implement full frame family support (parent-child relationships between frames)
Hynek Cihlar wrote:
> Constantin Asofiei wrote:
> > Hynek Cihlar wrote:
> > > Similar issue as above in @UiUtils.g...
Constantin Asofiei
09:23 AM Feature #1798: implement full frame family support (parent-child relationships between frames)
Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > Similar issue as above in @UiUtils.getFramesAbove()@. In case o...
Hynek Cihlar
09:14 AM Feature #1798: implement full frame family support (parent-child relationships between frames)
Hynek Cihlar wrote:
> Similar issue as above in @UiUtils.getFramesAbove()@. In case of a @DIALOG@ the method will co...
Constantin Asofiei
08:52 AM Feature #1798: implement full frame family support (parent-child relationships between frames)
What else is left to do for this task (besides regression testing)? Greg Shah
08:47 AM Feature #1798: implement full frame family support (parent-child relationships between frames)
Hynek Cihlar wrote:
> Constantin Asofiei wrote:
> > 2677b rev 10953 contains second phase of frame family support (...
Constantin Asofiei
08:43 AM Feature #1798: implement full frame family support (parent-child relationships between frames)
Greg Shah wrote:
> Code Review Task Branch 2677b Revision 10954
>
> My only question is about the safety of @boun...
Constantin Asofiei
07:45 AM Feature #1798: implement full frame family support (parent-child relationships between frames)
Code Review Task Branch 2677b Revision 10954
My only question is about the safety of @bounds.intersects(outer)@ in...
Greg Shah
07:36 AM Feature #1798: implement full frame family support (parent-child relationships between frames)
Constantin Asofiei wrote:
> 2677b rev 10953 contains second phase of frame family support (plus some other fixes). P...
Hynek Cihlar
06:47 AM Feature #1798: implement full frame family support (parent-child relationships between frames)
2677b rev 10954 fixes a bug in @isRootFrame()@. main part is in progress. Constantin Asofiei

11/23/2015

03:46 PM Feature #1798: implement full frame family support (parent-child relationships between frames)
2677b rev 10953 contains second phase of frame family support (plus some other fixes). Please review.
Runtime test...
Constantin Asofiei
01:56 PM Bug #2849: implement and/or fix the default popup menus for all widgets
Greg Shah wrote:
> > but displays blinked cursor later when pop-up menu will be closed
>
> Vadim, have you teste...
Vadim Gindin
11:37 AM Bug #2849: implement and/or fix the default popup menus for all widgets
> but displays blinked cursor later when pop-up menu will be closed
Vadim, have you tested without a popup menu r...
Greg Shah
11:33 AM Bug #2849: implement and/or fix the default popup menus for all widgets
Hynek Cihlar wrote:
> Vadim Gindin wrote:
> > Hynek Cihlar wrote:
> > > Greg Shah wrote:
> > > > I'm OK with the ...
Vadim Gindin
06:01 AM Bug #2849: implement and/or fix the default popup menus for all widgets
Vadim Gindin wrote:
> Hynek Cihlar wrote:
> > Greg Shah wrote:
> > > I'm OK with the changes.
> > >
> > > Hynek...
Hynek Cihlar
03:09 AM Bug #2850: menu/simple_sm.p drawing issues in Swing client
Constantin. You were absolutely right about the reason. I've added @isVisible@ check for MENUBAR to @WindowLayout@ an... Vadim Gindin

11/22/2015

07:54 AM Bug #2850: menu/simple_sm.p drawing issues in Swing client
Constantin Asofiei wrote:
> Vadim, in which branch are you working this?
bracnh 2677a, revno 11067.

> Also, p...
Vadim Gindin
04:22 AM Bug #2849: implement and/or fix the default popup menus for all widgets
Hynek Cihlar wrote:
> Greg Shah wrote:
> > I'm OK with the changes.
> >
> > Hynek/Constantin: any concerns with the ...
Vadim Gindin

11/21/2015

05:14 AM Feature #2565: implement runtime support for the SET-WAIT-STATE method
Section 27 has been updated Igor Skornyakov

11/20/2015

06:53 PM Bug #2859: combo-box layout obscures the 3D border
This is the fix for issue. The several small GUI fixes to improve @combo-box@ painting. Also the simple mode may need... Eugenie Lyzenko
02:52 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
> @BROWSE@ widget support with @VIEW-AS TOGGLE-BOX@ and @VIEW-AS COMBO-BOX@ options is incorrect - the converted code... Greg Shah
01:52 PM Feature #2565: implement runtime support for the SET-WAIT-STATE method
@BROWSE@ widget support with @VIEW-AS TOGGLE-BOX@ and @VIEW-AS COMBO-BOX@ options is incorrect - the converted code d... Igor Skornyakov
02:51 PM Feature #2628: Non-fill-in column support in browse.
In regard to cursor support for those contained widgets, please see #2565-60. Greg Shah
02:37 PM Bug #2849: implement and/or fix the default popup menus for all widgets
Greg Shah wrote:
> I'm OK with the changes.
>
> Hynek/Constantin: any concerns with the @ThinClient@ change?
V...
Hynek Cihlar
02:30 PM Bug #2849: implement and/or fix the default popup menus for all widgets
I'm OK with the changes.
Hynek/Constantin: any concerns with the @ThinClient@ change?
Vadim: Even if everyone i...
Greg Shah
02:36 AM Bug #2849: implement and/or fix the default popup menus for all widgets
Here the diff, including small sub-menu fix. Vadim Gindin
09:59 AM Bug #2834 (Closed): GUI combo-box multiple drop-downs can be shown
Update evl_upd20151119a.zip (for both #2833 and #2834) committed to 2677a as revision 11071. Greg Shah
04:02 AM Bug #2834: GUI combo-box multiple drop-downs can be shown
Greg Shah wrote:
> Code Review evl_upd20151118b.zip
>
> (Originally posted to #2831 by accident)
>
> I am fine...
Constantin Asofiei
09:58 AM Bug #2833 (Closed): GUI combo-box navigation keys don't work as expected
Greg Shah
09:41 AM Bug #2833: GUI combo-box navigation keys don't work as expected
Greg Shah wrote:
> Code Review evl_upd20151119a.zip
>
> I'm good with the changes. Please update the copyright d...
Eugenie Lyzenko
09:07 AM Bug #2833: GUI combo-box navigation keys don't work as expected
Code Review evl_upd20151119a.zip
I'm good with the changes. Please update the copyright date in @Key.java@ and ch...
Greg Shah
09:57 AM Bug #2850: menu/simple_sm.p drawing issues in Swing client
Vadim, I think I know why you are seeing the top light-gray space. Menu-bar gets attached to window (and window is r... Constantin Asofiei
09:44 AM Bug #2850: menu/simple_sm.p drawing issues in Swing client
Vadim, in which branch are you working this?
Also, please remind me, have you managed to address the sub-menu body...
Constantin Asofiei
09:57 AM Bug #2867: investigate PUT SCREEN problems in ChUI on both linux and windows
A useful clarification from Constantin:
> When I made the initial change to @UiUtils.hideFrames@, they were not to...
Greg Shah
09:28 AM Bug #2867: investigate PUT SCREEN problems in ChUI on both linux and windows
Use the @testcases/uast/frame_hiding_clears_put_screen_run.p@ and check for any differences between P2J and 4GL, with... Constantin Asofiei
09:24 AM Bug #2867 (New): investigate PUT SCREEN problems in ChUI on both linux and windows
Constantin Asofiei
05:21 AM Bug #2861: fix widget z-order inside frame, when focus is switching - there are differences betwe...
When focus is switching between overlapped widgets inside the same frame (these widgets may be a nested frame, too), ... Constantin Asofiei
05:20 AM Bug #2861 (Closed): fix widget z-order inside frame, when focus is switching - there are differen...
Constantin Asofiei
 

Also available in: Atom