Activity
From 01/01/2015 to 01/30/2015
01/30/2015
- 05:01 PM User Interface Feature #2478: button image support
- > Normally, the answer would be yes. But right now we are in the middle of a number of conflicting updates that have...
- 04:57 PM User Interface Feature #2478: button image support
- Normally, the answer would be yes. But right now we are in the middle of a number of conflicting updates that have @...
- 11:43 AM User Interface Feature #2478: button image support
- The @CTRL-C@ part completed without regression. 3-way tests was started in a separate session. The results file on sh...
- 07:56 AM User Interface Feature #2478: button image support
- Finally I have got the main part completed without regression. Starting the @CTRL-C@ tests.
- 04:51 PM User Interface Feature #2479: DEFINE IMAGE and image phrase support for both button and image
- This update for your review includes conversion support implementation candidate for @size-phrase@ and @image-phrase@...
- 05:35 AM User Interface Feature #2479: DEFINE IMAGE and image phrase support for both button and image
- Yes, please implement this.
- 05:25 AM User Interface Feature #2479: DEFINE IMAGE and image phrase support for both button and image
- Question. Do we need th support for @FROM {X n Y n} | {ROW n COLUMN n}@ clause of the @image phrase@?
This sets th... - 03:31 PM User Interface Feature #1790: implement menu support
- I did as you advised. I used @menu.setVisible(true)@ that calls @repaint()@ method, that in turn call @EventManager.p...
- 11:22 AM User Interface Feature #1790: implement menu support
- Greg Shah wrote:
> 1. I think your drawing issues are related to how you are directly calling @menu.draw()@ in @Thi... - 08:44 AM User Interface Feature #1790: implement menu support
- > but still got mbar.getSelf().readOnlyError("popup-only");.
You have to add the attribute into the writable attri... - 08:06 AM User Interface Feature #1790: implement menu support
- # I've added POPUP-ONLY to @load_descriptiors@ function along with other menu related attributes, created @MenuInterf...
- 03:27 PM User Interface Feature #2498: implement ADD-LAST() method
- Additional details about COMBO-BOX widget behaviour in presence of duplicated/"unknown" labels/values:
1. empty labe... - 08:41 AM User Interface Feature #2498: implement ADD-LAST() method
- > May be it makes sense to fix the implementation of ADD-FIRST as well (the current implementation also doesn't show ...
- 07:48 AM User Interface Feature #2498: implement ADD-LAST() method
- If "unknown value is specified for @ADD-LAST(items)@ method it is accepted but on the screen a blank line is shown (i...
- 12:40 PM Base Language Bug #2509 (Closed): problem converting INPUT x @ y constructs
- 12:27 PM Base Language Bug #2509: problem converting INPUT x @ y constructs
- P2J incorrectly resolves the frame of a @INPUT i@ expression, in a case like this:...
- 12:23 PM Base Language Bug #2509 (Closed): problem converting INPUT x @ y constructs
- 08:16 AM User Interface Bug #2497: ANY-PRINTABLE only works for specific widget triggers, but not frame or global anywhere
- LE: the trigger in note 22 was changed to be for the frame, not widget.
- 08:12 AM User Interface Bug #2497: ANY-PRINTABLE only works for specific widget triggers, but not frame or global anywhere
- I'm noting this here, but is a bug, not a regression; the following case doesn't work in P2J:...
- 06:56 AM User Interface Bug #2497: ANY-PRINTABLE only works for specific widget triggers, but not frame or global anywhere
- The changes are doing well in regression testing. I got timeout failures in tc_item_master_006, tc_item_master_104 a...
- 05:21 AM Base Language Bug #2507 (Closed): format validation with editing blocks
- 01:11 AM Base Language Bug #2507: format validation with editing blocks
- Greg Shah wrote:
> Code Review ca_upd20150129b.zip
>
> I'm fine with the changes.
Passed runtime testing, re...
01/29/2015
- 06:20 PM User Interface Feature #1790: implement menu support
- Code Review vig_upd20150130a.zip
I think it is moving in the right direction.
1. I think your drawing issues ar... - 03:54 PM User Interface Feature #1790: implement menu support
- The next update, containing the following changes.
# The first working (in testing mode) variant with popup-menu.
#... - 08:29 AM User Interface Feature #1790: implement menu support
- OK. Keep this in mind when you are working on getting the event processing to work properly.
- 05:38 AM User Interface Feature #1790: implement menu support
- Greg Shah wrote:
> Can you create a trigger on this event and use no-apply? Something like this:
>
> [...]
>... - 05:51 PM Base Language Bug #2499: DST portion of the timezone offset is always included when it should be conditional
- Code Review om_upd20150129b.zip
There are no changes in the @datetime.java@ that was in the update zip. Otherwise... - 02:44 PM Base Language Bug #2499: DST portion of the timezone offset is always included when it should be conditional
- This is most likely an RC.
I only done the 'theoretical' checking on @datetime@ and @datetimetz@. I am preparing no... - 05:31 PM User Interface Feature #2252: implement GUI client support
- Greg Shah wrote:
> Code Review hc_upd20150129b.zip
>
> My review of ZCL is not very very deep. But overall, I'm ... - 05:07 PM User Interface Feature #2252: implement GUI client support
- Code Review hc_upd20150129b.zip
My review of ZCL is not very very deep. But overall, I'm fine with the update. O... - 10:51 AM User Interface Feature #2252: implement GUI client support
- Constantin Asofiei wrote:
>
> After re-enabling this code for the case oldLbl is null, the NPE is no longer there.... - 05:43 AM User Interface Feature #2252: implement GUI client support
- Hynek Cihlar wrote:
> > > An update, the NPE is caused by my changes. I have changed the side-label management sligh... - 05:06 AM User Interface Feature #2252: implement GUI client support
- Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > Constantin Asofiei wrote:
> > > Hynek Cihlar wrote:
> > > > Const... - 04:52 AM User Interface Feature #2252: implement GUI client support
- Hynek Cihlar wrote:
> Constantin Asofiei wrote:
> > Hynek Cihlar wrote:
> > > Constantin, this also touches some o... - 04:18 AM User Interface Feature #2252: implement GUI client support
- Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > Constantin, this also touches some of your side-label changes, ... - 03:24 AM User Interface Feature #2252: implement GUI client support
- Hynek Cihlar wrote:
> Constantin, this also touches some of your side-label changes, please have a look too. Also no... - 02:44 AM User Interface Feature #2252: implement GUI client support
- Replacement for ca_upd20150123a.zip, side-labels in shared frames.
Passed runtime testing, released to rev 10725. - 08:51 PM User Interface Feature #2252: implement GUI client support
- The attached update adds support for moving frame widgets by setting col/row/x/y attributes from application code. Th...
- 04:37 PM User Interface Feature #2508: test LIST-ITEMS support in P2J and confirm that it is complete, add or fix feature...
- This attribute is available on selection list, combo-box and browse column. Please write use cases to test it, inclu...
- 04:33 PM User Interface Feature #2508 (Closed): test LIST-ITEMS support in P2J and confirm that it is complete, add or fi...
- 04:28 PM Base Language Bug #2507: format validation with editing blocks
- Code Review ca_upd20150129b.zip
I'm fine with the changes. - 03:57 PM Base Language Bug #2507: format validation with editing blocks
- > This is going through runtime testing now.
CTRL-C passed, MAIN part was killed and restarted, as after ~5 hours ... - 10:52 AM Base Language Bug #2507: format validation with editing blocks
- This is replacement of 0128a.zip. Enhances the support for character formats and is a good step forward, but there ar...
- 04:11 PM User Interface Bug #2497: ANY-PRINTABLE only works for specific widget triggers, but not frame or global anywhere
- > there are the testcases/uast/*focus*.p tests.
Good idea. I'll see if they can be used to test this out. - 04:09 PM User Interface Bug #2497: ANY-PRINTABLE only works for specific widget triggers, but not frame or global anywhere
- Greg Shah wrote:
> I wonder if it is worth testing my second approach with MAJIC.
Yes, I think this one is OK to te... - 03:57 PM User Interface Bug #2497: ANY-PRINTABLE only works for specific widget triggers, but not frame or global anywhere
- I've tried the following idea:...
- 03:54 PM User Interface Bug #2497: ANY-PRINTABLE only works for specific widget triggers, but not frame or global anywhere
- Greg Shah wrote:
> That is a strange result. I wouldn't have expected that without NO-APPLY. The entry/leave proce... - 03:37 PM User Interface Bug #2497: ANY-PRINTABLE only works for specific widget triggers, but not frame or global anywhere
- That is a strange result. I wouldn't have expected that without NO-APPLY. The entry/leave processing must be respon...
- 03:26 PM User Interface Bug #2497: ANY-PRINTABLE only works for specific widget triggers, but not frame or global anywhere
- @refocusTarget@ might have been used to solve a case like this:...
- 02:43 PM User Interface Bug #2497: ANY-PRINTABLE only works for specific widget triggers, but not frame or global anywhere
- The change to add @refocusTarget()@ came in rev 9907 (H649 on 20101015 by SIY). There is no indication of why this w...
- 02:26 PM User Interface Bug #2497: ANY-PRINTABLE only works for specific widget triggers, but not frame or global anywhere
- I stepped over that @refocusTarget()@ call because I knew the target widget was already in focus.
I don't fully un... - 01:25 PM User Interface Bug #2497: ANY-PRINTABLE only works for specific widget triggers, but not frame or global anywhere
- Greg Shah wrote:
> Part of the problem is that the screen refreshes are deferred so I can't see when the cursor move... - 01:02 PM User Interface Bug #2497: ANY-PRINTABLE only works for specific widget triggers, but not frame or global anywhere
- This update fixes the trigger recursion but the cursor is still always forced back to the first char position. I hav...
- 07:11 PM User Interface Bug #2497: ANY-PRINTABLE only works for specific widget triggers, but not frame or global anywhere
- Actually, we do have generic protection logic for trigger recursion. It is located in @LogicalTerminal.trigger()@:
... - 02:46 PM Database Bug #2488: replace runtime compilation of dynamic queries
- This update fixes the copy/paste bug revealed by issues #2500 and #2501.
- 02:36 PM User Interface Feature #2494 (Closed): DELETE() method runtime implementation
- 02:34 PM User Interface Feature #2494: DELETE() method runtime implementation
- Passed runtime regression testing and checked in as bzr rev 10727.
- 02:05 PM User Interface Feature #2494: DELETE() method runtime implementation
- You can check in the update and send the associated notification email.
Please make sure you have no other changes... - 01:48 PM User Interface Feature #2494: DELETE() method runtime implementation
- Igor Skornyakov wrote:
> Actually the is one test which failed in exactly the same way in both runs:
>
> failure ... - 01:44 PM User Interface Feature #2494: DELETE() method runtime implementation
- Actually the is one test which failed in exactly the same way in both runs:
failure in step 40: 'Unexpected EOF in... - 01:05 PM User Interface Feature #2494: DELETE() method runtime implementation
- Are there any specific tests that failed in both runs (even though the failure was at a different point)? The only w...
- 12:41 PM User Interface Feature #2494: DELETE() method runtime implementation
- Second run of the regression test failed:
2 gso_tests Specific GSO testcases to regression test. FAILED NONE gs... - 08:34 AM User Interface Feature #2494: DELETE() method runtime implementation
- Merged with recent changes
- 01:05 PM User Interface Feature #2498: implement ADD-LAST() method
- Yes and yes.
- 12:28 PM User Interface Feature #2498: implement ADD-LAST() method
- I have a question.
As far as I understand there is no "null" value in ABL - it has "unknown" (literal ?) instead. If... - 07:02 PM User Interface Feature #2478: button image support
- Conversion testing completed. The codes are identical. Starting the runtime testing.
01/28/2015
- 05:21 PM User Interface Feature #2494: DELETE() method runtime implementation
- 1 tests failed:
2 gso_tests Specific GSO testcases to regression test. FAILED NONE gso_tests 2314.617 ... - 11:16 AM User Interface Feature #2494: DELETE() method runtime implementation
- Greg Shah wrote:
> Code Review ias_upd20150128a.zip (which is really ias_upd20150128b.zip)
>
> I'm OK with the ch... - 11:09 AM User Interface Feature #2494: DELETE() method runtime implementation
- Code Review ias_upd20150128a.zip (which is really ias_upd20150128b.zip)
I'm OK with the changes. Please get them ... - 11:08 AM User Interface Feature #2494: DELETE() method runtime implementation
- Sorry, I wasn't looking carefully enough. I see that you defined your own interface to match the concept of the @Fun...
- 11:07 AM User Interface Feature #2494: DELETE() method runtime implementation
- Also, please don't upload modified updates as the same update zip file name. The update in note 80 is your second up...
- 11:05 AM User Interface Feature #2494: DELETE() method runtime implementation
- I don't understand. Isn't @Function@ a Java 8 thing or a Guava thing? Neither should be used in our code. Where in...
- 10:24 AM User Interface Feature #2494: DELETE() method runtime implementation
- Greg Shah wrote:
> 1. We do not yet support Java 8. We want to do so, but it takes some real planning because it re... - 09:55 AM User Interface Feature #2494: DELETE() method runtime implementation
- Code Review ias_upd20150128a.zip
1. We do not yet support Java 8. We want to do so, but it takes some real planni... - 06:27 AM User Interface Feature #2494: DELETE() method runtime implementation
- Java code updated: use value instead of label in the @DELETE(list-items)@ for COMBO-BOX and SELECTION-LIST widgets.
- 05:11 PM User Interface Feature #2498: implement ADD-LAST() method
- Do you have testcases for the errors and edge cases?
Please collect all of your testcases and check them into the ... - 04:57 PM User Interface Feature #2498: implement ADD-LAST() method
- Greg Shah wrote:
> Please check how this works with parameters that are unknown value and empty string.
>
> Pleas... - 04:48 PM User Interface Feature #2498: implement ADD-LAST() method
- Please check how this works with parameters that are unknown value and empty string.
Please also check how it work... - 03:36 PM User Interface Feature #2498: implement ADD-LAST() method
- Greg,
1. Can I start Java runtime implementation?
2. Should I try to implement the described "strange" behaviour if... - 03:16 PM User Interface Feature #2498: implement ADD-LAST() method
- Sample 4GL programs
- 01:55 PM User Interface Feature #2498: implement ADD-LAST() method
- The RADIO-SET widget has only @ADD-LAST(label, value)@ method.
It just adds the new label/value to the widget.
If AUT... - 10:42 AM User Interface Feature #2498: implement ADD-LAST() method
- For COMBO-BOX and SELECTION-LIST:
1. If LIST-ITEM-PAIRS is set then @ADD-LAST(items)@ is rejected with two warnings (... - 05:06 PM User Interface Feature #1790: implement menu support
- > Assume we have a button with popup-menu assigned. We must press ESC-U for CHUI or F4 for WINDOWS to call this menu ...
- 04:37 PM User Interface Feature #1790: implement menu support
- I also want to add, that I faced with conversion bug for frames during conversion of @chui_menu_2_purpose.p@. Extra f...
- 04:31 PM User Interface Feature #1790: implement menu support
- I need an advice. Assume we have a button with popup-menu assigned. We must press ESC-U for CHUI or F4 for WINDOWS to...
- 03:02 PM User Interface Feature #1790: implement menu support
- I'm working on showing POPUP-MENU for widgets. I'd like to add this too.
About @MenuElementConfig@. There is some ... - 12:56 PM User Interface Feature #1790: implement menu support
- I'd like to see this next set of functionality stabilized and put into testing. What is left to do?
- 12:55 PM User Interface Feature #1790: implement menu support
- Code Review vig_upd20150128a.zip
Overall, this is MUCH better than the previous approach. Well done.
1. Menus n... - 04:52 PM Base Language Bug #2499: DST portion of the timezone offset is always included when it should be conditional
- I'm good with this approach if you find the the @datetime@ and @datetimetz@ are OK too.
- 04:37 PM Base Language Bug #2499 (WIP): DST portion of the timezone offset is always included when it should be conditional
- Most likely, the code inside @getDefaultOffset@ should be fixed:...
- 04:21 PM Database Bug #2488 (WIP): replace runtime compilation of dynamic queries
- Added 'dumb' cache implementation and some additional fixes.
- 04:03 PM User Interface Bug #2497: ANY-PRINTABLE only works for specific widget triggers, but not frame or global anywhere
- This update (which does make ANY-PRINTABLE more widely functional), can also cause problems. This code that applies ...
- 03:01 PM User Interface Feature #2478: button image support
- >It looks good. Please do get it tested.
OK. Starting the conversion testing stage(we have the rule changed). - 02:56 PM User Interface Feature #2478: button image support
- Code Review evl_upd20150128a.zip
It looks good. Please do get it tested. - 02:50 PM User Interface Feature #2478: button image support
- Reworked image loading support.
- New interfaces added, reworked conversion rule for methods.
- bit change for imag... - 12:56 PM User Interface Feature #2478: button image support
- > So we can run testing now or postpone to the time the interface rework is ready. What do you think?
Do the rewor... - 12:25 PM User Interface Feature #2478: button image support
- >This update seems pretty close to something that can go into regression testing. Is there anything else needed excep...
- 12:13 PM User Interface Feature #2478 (WIP): button image support
- > Is it answering to your question?
Yes.
This update seems pretty close to something that can go into regressio... - 11:24 AM User Interface Feature #2478: button image support
- >1. There are no real changes in ButtonWidget, just a history entry. I think that can be removed safely. :)
OK. Done... - 11:01 AM User Interface Feature #2478: button image support
- Code Review evl_upd20150127a.zip
I like it.
1. There are no real changes in @ButtonWidget@, just a history entr... - 08:27 PM User Interface Feature #2478: button image support
- Small update to add method interfaces to support dynamic button/image widgets.
- 11:55 AM Base Language Bug #2507: format validation with editing blocks
- Greg Shah wrote:
> Code Review ca_upd20150128a.zip
>
> My only concern is with the use of @checkFormat()@ instead... - 08:31 AM Base Language Bug #2507: format validation with editing blocks
- Code Review ca_upd20150128a.zip
My only concern is with the use of @checkFormat()@ instead of @validateFormat()@ o... - 04:19 AM Base Language Bug #2507: format validation with editing blocks
- From what I see, the format validation is done when LEAVE is sent for the widget. More, when EDITING mode is enabled...
- 04:05 AM Base Language Bug #2507: format validation with editing blocks
- Constantin,
Consider this:... - 04:04 AM Base Language Bug #2507 (Closed): format validation with editing blocks
01/27/2015
- 03:46 PM User Interface Feature #2494: DELETE() method runtime implementation
- It appears that my understanding of the DELETE() method semantics was incorrect -the @DELETE(list-items)@ for COMBO-B...
- 08:47 AM User Interface Feature #2494: DELETE() method runtime implementation
- Code Review ias_upd20150127a.zip
The changes look good.
I agree that the testing failures are most likely not d... - 06:00 AM User Interface Feature #2494: DELETE() method runtime implementation
- Some regression tests failed:
1. 1. failure in step 13: 'timeout before the specific screen buffer became available ... - 02:31 PM User Interface Feature #1790: implement menu support
- 1) I've prepared the next update with separate menu description class. Does it preferable than previous updates with ...
- 04:26 AM User Interface Bug #2495: APPLY event TO handle does not work
- ca_upd20150127a.zip passed conversion testing and was released to bzr rev 10723
- 04:26 AM User Interface Bug #2495: APPLY event TO handle does not work
- Fixed some conversion issues related to APPLY TO handle.
Anything which has a frame-id needs to convert as a Gener... - 08:29 PM User Interface Feature #2478: button image support
- Had to modify @CommonWidget/GenericWidget@ classes to add @loadImage*()@ methods support to handle dynamically alloca...
01/26/2015
- 02:44 PM User Interface Feature #2494: DELETE() method runtime implementation
- Thank you.
- 02:24 PM User Interface Feature #2494: DELETE() method runtime implementation
- Igor Skornyakov wrote:
> I tried to run regression test, but it failed (runtime-regression).
The problem is with y... - 02:22 PM User Interface Feature #2494: DELETE() method runtime implementation
- Got it. Thank you for your patience. I've configured Eclipse to avoid specific explicit imports. BTW: what about stat...
- 01:37 PM User Interface Feature #2494: DELETE() method runtime implementation
- Code Review ias_upd20150124d.zip
Almost there. 5 small problems are remaining. Sorry that we are so specific in o... - 06:51 AM User Interface Feature #2494: DELETE() method runtime implementation
- I'm very sorry, but I've dropped the entire content of the repo by a stupid mistake. How this can be repaired?
- 06:08 AM User Interface Feature #2494: DELETE() method runtime implementation
- Something is wrong with your repo, see this like:...
- 06:03 AM User Interface Feature #2494: DELETE() method runtime implementation
- I've tried to run regression testing but the compilation failed. Please find the build logs attached. As I can see th...
- 02:42 PM Base Language Bug #2499: DST portion of the timezone offset is always included when it should be conditional
- Some ideas about automating the DST testing (in junits or date.main):
> Ovidiu Maxiniuc wrote:
Java 8 has some new A... - 12:35 PM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
- Evgeny Kiselev wrote:
> My changes in @Window@ class is issue for gso_276 test. Looking for approach.
Did you int... - 12:34 PM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
- Code Review evk_upd20150126a.zip
1. Please remove @import org.apache.commons.logging.*;@ from @Stream.java@.
2.... - 07:46 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
- My changes in @Window@ class is issue for gso_276 test. Looking for approach.
- 09:01 PM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
- Tests gso_17 and gso_488 has been fixed in @Stream@ class. Even if output is unformatted we still need to use formatt...
- 12:01 PM Runtime Infrastructure Feature #2506: provide support for substitution variables which can be inserted in PROPATH entrie...
- In the 4GL, the PROPATH is often specified in scripts which modify the environment before launching the Progress clie...
- 11:53 AM Runtime Infrastructure Feature #2506 (New): provide support for substitution variables which can be inserted in PROPATH ...
- 11:51 AM Base Language Feature #2505: SEARCH and loading of static resources from the server-side application jar
- Today our SEARCH and any file reading occurs exclusively on the client side. As part of #2476 we are implementing su...
- 11:47 AM Base Language Feature #2505 (New): SEARCH and loading of static resources from the server-side application jar
- 11:46 AM Base Language Feature #2504: real environment access for OS-GETENV
- Today we map OS-GETENV to the JVM @System.getProperty()@ which does not real from real environment variables, but ins...
- 11:40 AM Base Language Feature #2504 (Closed): real environment access for OS-GETENV
- 11:38 AM Conversion Tools Feature #2503: improve ConversionDriver.main() to provide back a return code and/or better handle...
- From a customer:
> Conversion failed last night (because we checked something in that we shouldn't have done - a c... - 11:37 AM Conversion Tools Feature #2503 (WIP): improve ConversionDriver.main() to provide back a return code and/or better ...
- 11:35 AM Conversion Tools Feature #2502: using a file list as input for the ConversionDriver fails if there is trailing space
- Even a single trailing space will cause the file to be silently not found, leading to unexpected results. I haven't ...
- 11:33 AM Conversion Tools Feature #2502 (New): using a file list as input for the ConversionDriver fails if there is traili...
- 03:14 AM Database Bug #2488: replace runtime compilation of dynamic queries
- Eric,
If you did not started the review, please find attached an update that adds the missing javadocs to @RuntimeJa...
01/24/2015
- 02:53 PM User Interface Bug #2497 (Closed): ANY-PRINTABLE only works for specific widget triggers, but not frame or globa...
- Passed regression testing and checked in as bzr rev 10720.
- 07:56 PM User Interface Feature #2478: button image support
- This updates has code merged with recent code base.
One interesting thing I've found. If the method @LOAD-IMAGE()@...
01/23/2015
- 06:00 PM User Interface Feature #1790: implement menu support
- I've fixed this bug. It was some sort of serialization bug. I also fixed a drawing of menu-item labels for menubar. H...
- 12:06 PM User Interface Feature #1790: implement menu support
- Hopefully you are continuing to debug. I have no idea what is causing the problem.
- 10:02 AM User Interface Feature #1790: implement menu support
- I did it and nevertheless the constructor of @SilentUnwindException@ is called from client-side with the error @com.g...
- 09:31 AM User Interface Feature #1790: implement menu support
- I can't tell anything useful from the logs. You'll have to set breakpoints in the @SilentUnwindException@ constructo...
- 09:27 AM User Interface Feature #1790: implement menu support
- In the future, when posting something that isn't large, please post it in-line here. Don't attach a file for such th...
- 09:23 AM User Interface Feature #1790: implement menu support
- I need some advice. I got an error, that happen right in the moment of client call. I've filled @ScreenDefinition@ wi...
- 04:24 PM User Interface Feature #2494: DELETE() method runtime implementation
- Done. I did it with meld - it appears to be almost as good as Araxis Merge I used before.
- 04:14 PM User Interface Feature #2494: DELETE() method runtime implementation
- The class definition itself has been changed:...
- 03:56 PM User Interface Feature #2494: DELETE() method runtime implementation
- I see tow issues.
1. Invalid braces in constructor (fixed)
2. Reformatted comments/Javadocs.
I can revert my chang... - 03:39 PM User Interface Feature #2494: DELETE() method runtime implementation
- Code Review ias_upd20150123c.zip
> I'm sorry.
No worries. Learning the coding standards is part of the ramp-up... - 03:07 PM User Interface Feature #2494: DELETE() method runtime implementation
- Oh, I'm sorry. It appears that one have to set this in two places in Eclipse now.
- 02:44 PM User Interface Feature #2494: DELETE() method runtime implementation
- Code Review ias_upd20150123b.zip
Actually, this update is very hard to compare with the first for @ComboBoxWidget@... - 02:27 PM User Interface Feature #2494: DELETE() method runtime implementation
- Greg Shah wrote:
> FYI, we prefer to minimize the linkages because there can be unintended consequences. For exampl... - 02:06 PM User Interface Feature #2494: DELETE() method runtime implementation
- FYI, we prefer to minimize the linkages because there can be unintended consequences. For example, some of our code ...
- 02:05 PM User Interface Feature #2494: DELETE() method runtime implementation
- Sadly, I see that it has also sneaked its way into @LogicalTerminal@ and @ChuiWebPageHandler@. We'll need to clean t...
- 02:00 PM User Interface Feature #2494: DELETE() method runtime implementation
- Igor Skornyakov wrote:
> Got it.
> Regarding 3rd party dependencies. I used Google Guava classes only because the c... - 01:53 PM User Interface Feature #2494: DELETE() method runtime implementation
- Got it.
Regarding 3rd party dependencies. I used Google Guava classes only because the corresponding jar is already ... - 01:14 PM User Interface Feature #2494: DELETE() method runtime implementation
- Code Review ias_upd20150123.zip
Functionally, it is quite good. Most of the feedback relates to coding standards.... - 12:54 PM User Interface Feature #2494: DELETE() method runtime implementation
- Please find updated classes attached.
- 12:27 PM User Interface Feature #2494: DELETE() method runtime implementation
- That should not be needed.
OK, so you should do the following:
1. Upload the update zip file here so that we ca... - 12:19 PM User Interface Feature #2494: DELETE() method runtime implementation
- Thank you - it works. I've finished testing in ChUI mode. Shall I test on Windows as well?
- 11:59 AM User Interface Feature #2494: DELETE() method runtime implementation
- It's not the best way, but for now you can use this: @frame.getName(this)@ from within a widget. This corresponds to...
- 10:55 AM User Interface Feature #2494: DELETE() method runtime implementation
- I've started testing in ChUI mode. Basically all works, but there is one minor(?) issues:
The type() return not th... - 09:44 AM User Interface Feature #2494: DELETE() method runtime implementation
- It's OK - I understand. Thank you,
- 09:43 AM User Interface Feature #2494: DELETE() method runtime implementation
- Good. Sorry for the old docs. We are busy and haven't gotten them updated. And those docs reference an internal bz...
- 09:35 AM User Interface Feature #2494: DELETE() method runtime implementation
- Yes, it works, thank you.
- 09:23 AM User Interface Feature #2494: DELETE() method runtime implementation
- The documentation is out of date. The @ServerDriver@ itself has no understanding of a @-z@ parameter. The @server.s...
- 09:12 AM User Interface Feature #2494: DELETE() method runtime implementation
- I got the command from /books/conversion_handbook/p2j_conversion_handbook.pdf page 221
- 09:03 AM User Interface Feature #2494: DELETE() method runtime implementation
- I don't fully understand what you are saying you did or what the problem is.
When I run a server for my converted ... - 06:43 AM User Interface Feature #2494: DELETE() method runtime implementation
- I've tried to launch the P2J Server as described in the "P2J Conversion Handbook", but got an error @"Too many config...
- 03:46 PM User Interface Bug #2497: ANY-PRINTABLE only works for specific widget triggers, but not frame or global anywhere
- No, here it is.
- 03:45 PM User Interface Bug #2497: ANY-PRINTABLE only works for specific widget triggers, but not frame or global anywhere
- Good catch. Here is the version with javadoc.
- 03:03 PM User Interface Bug #2497: ANY-PRINTABLE only works for specific widget triggers, but not frame or global anywhere
- Greg Shah wrote:
> Merged update to bzr 10719 which includes the fix from #2495. I'm going to put this into testing... - 01:45 PM User Interface Bug #2497: ANY-PRINTABLE only works for specific widget triggers, but not frame or global anywhere
- Merged update to bzr 10719 which includes the fix from #2495. I'm going to put this into testing.
- 01:57 PM Base Language Bug #2499: DST portion of the timezone offset is always included when it should be conditional
- I took a quick look at this. Outside the util package, @date.getDefaultOffset()@ is used from @persist/HQLPreprocess...
- 01:51 PM Base Language Bug #2499: DST portion of the timezone offset is always included when it should be conditional
- TIMCO reported a problem with transactions starting at midnight. Constantin tracked the problem back to the TODAY fu...
- 01:46 PM Base Language Bug #2499 (WIP): DST portion of the timezone offset is always included when it should be conditional
- 01:34 PM User Interface Bug #2495 (Closed): APPLY event TO handle does not work
- 01:29 PM User Interface Bug #2495 (Review): APPLY event TO handle does not work
- Greg Shah wrote:
> Please check it in.
Released to rev 10719. - 08:28 AM User Interface Bug #2495: APPLY event TO handle does not work
- Please check it in.
- 07:13 AM User Interface Bug #2495: APPLY event TO handle does not work
- Greg Shah wrote:
> Code Review ca_upd20150122c.zip
>
> It looks good.
0122c.zip passed runtime/conversion testing. - 12:31 PM User Interface Feature #2498: implement ADD-LAST() method
- This method is available on selection list, combo-box, radio-set and browse column. Follow the same approach as for ...
- 12:30 PM User Interface Feature #2498 (Closed): implement ADD-LAST() method
- 10:05 AM User Interface Feature #2478: button image support
- This update for review adds @DEFINE IMAGE@ handling for deferred data loading for image widget.
Continue working. - 09:29 AM Database Bug #2488: replace runtime compilation of dynamic queries
- Greg, you are right.
We do parse the initial query using the @progress.g@ (@ProgressParser@ from the code in note ... - 08:58 AM Database Bug #2488: replace runtime compilation of dynamic queries
- When I refer to the Progress AST, I mean the original AST that is first created for the provided expression in a @QUE...
- 08:55 AM Database Bug #2488: replace runtime compilation of dynamic queries
- A few thoughts on the caching:
I agree with Greg that the Progress AST will be much more reliable. However, it is ... - 08:53 AM Database Bug #2488: replace runtime compilation of dynamic queries
- Not sure I understand. Of course, the trees will be the except for the string value at some point. But later, during ...
- 08:26 AM Database Bug #2488: replace runtime compilation of dynamic queries
- > and realize that they are the same ?
Don't forget that in the Progress AST the tree structure is in fact:
* ... - 05:01 AM Database Bug #2488: replace runtime compilation of dynamic queries
- I analyzed the logs with the queries from #1868. Here are some results/thoughts:
* there are ~5500 @FIND FIRST@ of w... - 09:29 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
- >Eugenie Lyzenko: is there anything about GSO 488 which was not captured in the 4GL?
I think yes. The 4GL system @... - 08:39 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
- Code Review evk_upd20150121a.zip
The changes are fine. In the future, please post the update without the @01_@ pr... - 07:46 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
- Greg Shah wrote:
> Are the ChUI-specific changes to @Window.message()@ still needed (to set the cursor position to c... - 09:18 AM User Interface Feature #2252: implement GUI client support
- Code Review ca_upd20150123a.zip
The changes look good. The result is cleaner too from a design perspective, so it... - 07:48 AM User Interface Feature #2252: implement GUI client support
- Fix for side-label in shared frames. Built on top of #2495 ca_upd20150122c.zip
01/22/2015
- 06:15 PM User Interface Feature #2478: button image support
- This update for review contains prototype for deferred image loading in button widget. Some notes:
1. There is only ... - 05:55 PM User Interface Bug #2497: ANY-PRINTABLE only works for specific widget triggers, but not frame or global anywhere
- The testcase is checked in as @testcases/uast/any_printable_event.p@.
- 05:53 PM User Interface Bug #2497: ANY-PRINTABLE only works for specific widget triggers, but not frame or global anywhere
- This is the fix. It ensures that ANY-PRINTABLE and ANY-KEY are searched on each pass through (specific-widget, frame...
- 05:49 PM User Interface Bug #2497: ANY-PRINTABLE only works for specific widget triggers, but not frame or global anywhere
- The following testcase illustrates this problem:...
- 05:48 PM User Interface Bug #2497 (Closed): ANY-PRINTABLE only works for specific widget triggers, but not frame or globa...
- 04:56 PM Database Bug #2488: replace runtime compilation of dynamic queries
- Uploaded update for review, together a file with my important testcases.
* I tried to detect as much as possible i... - 06:02 AM Database Bug #2488: replace runtime compilation of dynamic queries
- After I got satisfactory results with simpler queries, I started to increase the complexity of the dynamic queries in...
- 03:38 PM Database Bug #2496: Static conversion of legacy field names does not preserve original case
- Legacy field names annotations for static conversion are now in low case. TableMapper seems works properly, also ther...
- 03:07 PM Database Bug #2496 (New): Static conversion of legacy field names does not preserve original case
- 02:20 PM User Interface Feature #2494: DELETE() method runtime implementation
- Greg Shah wrote:
> For this task I think you can ignore the browse column aspects.
OK. Thank you.
- 02:17 PM User Interface Feature #2494: DELETE() method runtime implementation
- > If I understand correctly this means that in the scope of this task there is nothing to do specifically for the BRO...
- 02:11 PM User Interface Feature #2494: DELETE() method runtime implementation
- Here it is
- 02:09 PM User Interface Feature #2494: DELETE() method runtime implementation
- > If I understand correctly this means that in the scope of this task there is nothing to do specifically for the BRO...
- 01:43 PM User Interface Feature #2494: DELETE() method runtime implementation
- Please note the generated code for the BROWSE widget contains nothing related to a combo-box column except @addWidget...
- 01:22 PM User Interface Feature #2494: DELETE() method runtime implementation
- Indeed - after commenting out p2j_test namespace the browse2.p converted OK (even with @f0+cb@)
Thanks a lot! - 01:20 PM User Interface Feature #2494: DELETE() method runtime implementation
- Greg Shah wrote:
> The "b" reference in the define frame is being matched with a field in the book table of p2j_test... - 01:15 PM User Interface Feature #2494: DELETE() method runtime implementation
- I guess that P2J is having a problem with @DEFINE FRAME f b.@ from line 10 of @r-browse2.p@, if that is the same prog...
- 12:55 PM User Interface Feature #2494: DELETE() method runtime implementation
- Well, the conversion passed for combo, radio and select. I had to use @f2+m0+cb@ as @f0+cb@ disn't work (at some stag...
- 12:39 PM User Interface Feature #2494: DELETE() method runtime implementation
- Thank you very much.
Now the conversion started. However there are other problems at the later steps. I'll try to un... - 11:37 AM User Interface Feature #2494: DELETE() method runtime implementation
- I believe that the current @testcases/uast/@ environment was broken at some point by some kind of metadata -nonsense-...
- 11:28 AM User Interface Feature #2494: DELETE() method runtime implementation
- Greg,
I cannot perform the conversion:
Exception in thread "main" java.lang.ExceptionInInitializerError
Caused by:... - 09:57 AM User Interface Feature #2494: DELETE() method runtime implementation
- > I understand that now I have to convert my 4GL sample programs and test. Is that correct?
Exactly right. - 09:25 AM User Interface Feature #2494: DELETE() method runtime implementation
- I see. Thank you.
I've implemented @DELETE()@ for RADIO-SET, SELECTION-LIST and COMBO-BOX. I understand that now I... - 08:44 AM User Interface Feature #2494: DELETE() method runtime implementation
- Each resource type has a TYPE attribute. It comes from the @CommonHandle@ interface and is implemented for widgets a...
- 07:30 AM User Interface Feature #2494: DELETE() method runtime implementation
- I have a question.
In 4GL warning contains a name of the widget - e.g. "The DELETE attribute on the SELECTION-LIST ... - 01:37 PM User Interface Bug #2495: APPLY event TO handle does not work
- Code Review ca_upd20150122c.zip
It looks good. - 01:19 PM User Interface Bug #2495: APPLY event TO handle does not work
- Attached fixes the issues in notes 3 and 5. Testing is under way.
- 12:52 PM User Interface Bug #2495: APPLY event TO handle does not work
- > Should I continue fixing this?
Yes, if it can be done in a reasonable amount of time. I think it is time to get... - 12:37 PM User Interface Bug #2495: APPLY event TO handle does not work
- There is this case also:...
- 10:24 AM User Interface Bug #2495: APPLY event TO handle does not work
- Greg Shah wrote:
> 3. In @LogicalTerminal.apply(WrappedResource res, double eventCode)@, could a non-widget/non-fram... - 09:56 AM User Interface Bug #2495: APPLY event TO handle does not work
- Code Review ca_upd20150122a.zip
This is really good. I like how you solved the ID lookup problem by using a diffe... - 09:00 AM User Interface Bug #2495: APPLY event TO handle does not work
- -------- Forwarded Message --------
Subject: Re: common idiom which we don't handle properly
Date: Thu, 22 Jan 2015... - 08:59 AM User Interface Bug #2495: APPLY event TO handle does not work
- I have found a common idiom which we don't handle properly. Here is an example:...
- 08:56 AM User Interface Bug #2495 (Closed): APPLY event TO handle does not work
01/21/2015
- 06:17 PM User Interface Feature #2476: window icon support improvements
- Committed in bzr as 10716.
- 06:03 PM User Interface Feature #2476: window icon support improvements
- Yes, go ahead.
- 05:47 PM User Interface Feature #2476: window icon support improvements
- The @CTRL-C@ part completed without regressions. Had to start 3-way tests separately. The results file is on the shar...
- 09:31 AM User Interface Feature #2476: window icon support improvements
- The main part of the regression testing has been completed without regressions, starting the @CTRL-C@ tests.
- 06:06 PM User Interface Feature #2478: button image support
- OK, please take this into account in your design.
1. I think that the loadImage() methods should still be used by ... - 05:32 PM User Interface Feature #2478: button image support
- >Eugenie: please determine the answer to this question.
The answer is the moment when button is realized is the po... - 01:57 PM User Interface Feature #2478: button image support
- > But if the image is loaded only when the frame (or button?) is realised, unless I've missed some discussion on the...
- 01:26 PM User Interface Feature #2478: button image support
- >> Postpone the image loading to the moment when the button widget is created on the client side. This will requir...
- 01:25 PM User Interface Feature #2478: button image support
- Greg Shah wrote:
> > Postpone the image loading to the moment when the button widget is created on the client side. ... - 01:15 PM User Interface Feature #2478: button image support
- > Postpone the image loading to the moment when the button widget is created on the client side. This will require ad...
- 12:56 PM User Interface Feature #2478: button image support
- The button widget image processing note. There are two places when we need to set/load image integration into button ...
- 01:29 PM User Interface Feature #2494: DELETE() method runtime implementation
- Greg Shah wrote:
> I have not yet gotten the time to finish the code review on those changes (and on the other fix... - 01:06 PM User Interface Feature #2494: DELETE() method runtime implementation
- > So, it seems that I can start coding now. Is that correct?\
Yes.
> Albeit these changes do not affect the cla... - 01:01 PM User Interface Feature #2494: DELETE() method runtime implementation
- Greg Shah wrote:
> Just change the @delete(int)@ to be @delete(long)@
Got it. So, it seems that I can start codin... - 12:51 PM User Interface Feature #2494: DELETE() method runtime implementation
- > I see. However at this moment we have @delete(int)@ method in the @ControlSetEntity@ (and even in @GenericWidget@)....
- 12:22 PM User Interface Feature #2494: DELETE() method runtime implementation
- Greg Shah wrote:
> > But I see entry(int) and entry(int64) in ControlSetEntity, but there is no entry(long)
>
> I... - 12:08 PM User Interface Feature #2494: DELETE() method runtime implementation
- Constantin Asofiei wrote:
> To determine what is the message shown by the DELETE method (in this case), usually I ch... - 11:08 AM User Interface Feature #2494: DELETE() method runtime implementation
- Constantin Asofiei wrote:
> On a side note, how do you use the @r-radio.p@ test? I've tried switching focus to the f... - 10:41 AM User Interface Feature #2494: DELETE() method runtime implementation
- Greg Shah wrote:
> Constantin/Stanislav: can you think of other ways we code these warning cases in the P2J runtime?... - 10:21 AM User Interface Feature #2494: DELETE() method runtime implementation
- > Does it just mean that there is no need to add delete(decimal idx) method?
Yes. Although how we would handle a ... - 09:30 AM User Interface Feature #2494: DELETE() method runtime implementation
> This means we need some extra investigation. Some warnings are just formatted messages displayed in the message ...- 08:52 AM User Interface Feature #2494: DELETE() method runtime implementation
- > method generates warning if
This means we need some extra investigation. Some warnings are just formatted mess... - 07:29 AM User Interface Feature #2494: DELETE() method runtime implementation
- Questions.
1. I understand that we should not care about thread safety of widgets' methods as they are supposed to b... - 07:09 AM User Interface Feature #2494: DELETE() method runtime implementation
- Runtime support.
1. Server side.
a. Implement @delete(int idx)@, @delete(int64 idx)@, @delete(String item)@ and @de... - 06:04 AM User Interface Feature #2494: DELETE() method runtime implementation
- 1. The statement about raising error is not correct. Actually the @DELETE(list-index)@ method generates warning if ar...
- 10:28 AM Database Bug #2488: replace runtime compilation of dynamic queries
- Eric Faulhaber wrote:
> Don't we convert these kinds of expressions into HQL today, using PL/Java UDFs to represent ... - 10:27 AM Database Bug #2488: replace runtime compilation of dynamic queries
- Ovidiu Maxiniuc wrote:
> On the other hand, if we do to many semantic annotations, the tree will grow - and the mana... - 10:19 AM Database Bug #2488: replace runtime compilation of dynamic queries
- Ovidiu Maxiniuc wrote:
> The static call is emitted, relying on java compiler to resolve the actual method to be inv... - 02:58 AM Database Bug #2488: replace runtime compilation of dynamic queries
- This is true, we don't do the constant expression evaluation at this moment neither in static conversion but it would...
- 08:57 AM User Interface Feature #2422: add features to BROWSE
- About this particular feature:
>If the previous page is fully deleted, you have to press Page Up twice in order to m... - 08:14 AM User Interface Feature #2422: add features to BROWSE
- You'll be working on GUI soon, so do make sure that your approach can be easily adapted for those cases.
01/20/2015
- 05:59 PM User Interface Feature #2422: add features to BROWSE
- Some differences in handling of Page Up/Down in ChUI and UI versions.
# About Page Down key (in ChUI it's not actu... - 04:36 PM Database Bug #2488: replace runtime compilation of dynamic queries
- Certainly static expressions will be more efficient to convert, execute, and store at conversion. I'm pretty sure we ...
- 03:55 PM Database Bug #2488: replace runtime compilation of dynamic queries
- > Don't abandon it just yet...it will not need to do as much as it does now, but this is a good candidate to morph in...
- 08:08 PM Database Bug #2488: replace runtime compilation of dynamic queries
- Ovidiu Maxiniuc wrote:
> Attached you can find a first version of 'runtime/interpret_find_query.xml'. It only handle... - 04:31 PM User Interface Feature #2494: DELETE() method runtime implementation
- Good results.
Please make sure you have tested the following:
* For @DELETE(list-index)@: @INTEGER@ inputs of 0... - 02:59 PM User Interface Feature #2494: DELETE() method runtime implementation
- 1. The @DELETE()@ method exists for COMBO-BOX, RADIO-SET, SELECTION-LIST and BROWSE column widgets. Its semantics and...
- 11:16 AM User Interface Feature #2494: DELETE() method runtime implementation
- You can edit it manually like a normal cell. I'm not sure if drop-down list can actually appear in browse in ChUI. Po...
- 07:45 AM User Interface Feature #2494: DELETE() method runtime implementation
- Stanislav: in the 4GL, how does one get the ChUI browse cell for a combo-box into editing mode?
- 07:42 AM User Interface Feature #2494: DELETE() method runtime implementation
- I failed to activate editing in Linux character mode. In Windows GUI mode the corresponding cell had standard clickab...
- 07:38 AM User Interface Feature #2494: DELETE() method runtime implementation
- FYI, LIST-ITEMS support in P2J may be partial (I think it is missing at least for browse columns).
When running th... - 03:40 PM User Interface Feature #2476: window icon support improvements
- The conversion testing completed. Generated codes are identical. Starting the runtime testing.
And I have committe... - 10:59 AM User Interface Feature #2476: window icon support improvements
- > I suggest to run regression and commit icon related changes to have some intermediate work stage to shift the next...
- 10:59 AM User Interface Feature #2476: window icon support improvements
- It is not a bad idea to load resources from a specific part of the jar, but I am OK with the current implementation a...
- 10:56 AM User Interface Feature #2476: window icon support improvements
- Eugenie Lyzenko wrote:
> Regarding icon loading. Everything looks OK except one point I need to clarify:
> 1. Assum... - 10:42 AM User Interface Feature #2476: window icon support improvements
- Regarding icon loading. Everything looks OK except one point I need to clarify:
1. Assume we start the server from @... - 08:02 PM User Interface Feature #2476: window icon support improvements
- > I'm good with this.
>
> Does this pass all of your 4GL testcases?
>
> If so, please put it into conversion an... - 07:11 PM User Interface Feature #2476: window icon support improvements
- Code Review evl_upd20150119c.zip
I'm good with this.
Does this pass all of your 4GL testcases?
If so, please... - 07:26 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
- Code Review evk_upd20150119a.zip
It looks good.
Are the ChUI-specific changes to @Window.message()@ still neede... - 09:18 PM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
- Explicit flush stream is helped, thanks.
That's why different test in regression testing were failed from time to t...
01/19/2015
- 06:53 PM User Interface Feature #2476: window icon support improvements
- Greg Shah wrote:
>
> The only thing I see is that @FileSystemOps.searchPath()@ should not be called from the clien... - 06:15 PM User Interface Feature #2476: window icon support improvements
- Code Review evl_upd20150119b.zip
This is really good!
The only thing I see is that @FileSystemOps.searchPath(... - 05:43 PM User Interface Feature #2476: window icon support improvements
- Small change to eliminate point #4 from the notes.
- 02:28 PM User Interface Feature #2476: window icon support improvements
- The new update for review. The fixes for notes to the previous one. Also the @gclogo.ico@ default icon has been moved...
- 11:44 AM User Interface Feature #2476: window icon support improvements
- > Does it mean the @FileSystemOps.searchPath()@ must be called on client side?
Not exactly. Instead, the client ... - 11:35 AM User Interface Feature #2476: window icon support improvements
- One question.
>...If the app jar load fails, then it calls the client with a filename. It is the ThinClient.set*(S... - 03:33 PM User Interface Feature #2494: DELETE() method runtime implementation
- > How the COMBO-BOX widget for the BROWSE column can be activated in the Linux character mode?
This is close, but... - 08:07 PM User Interface Feature #2494: DELETE() method runtime implementation
- Methods and attributes are functions and properties that can be invoked/read/written using a @HANDLE@ type. Each wid...
- 07:54 PM User Interface Feature #2494 (Closed): DELETE() method runtime implementation
- 02:36 PM Database Bug #2488: replace runtime compilation of dynamic queries
- Attached you can find a first version of 'runtime/interpret_find_query.xml'. It only handles the simple @find-query@ ...
- 08:07 PM Database Bug #2488: replace runtime compilation of dynamic queries
- Ovidiu Maxiniuc wrote:
> If you have the chance to re-run it, please add the string @predicate@ before and, to simpl... - 01:27 PM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
- > So we need always NL before message if message is not on the first line(or we need to calculate NL character as not...
- 09:06 PM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
- Greg Shah wrote:
> Please post the corresponding 4GL output so that I can better understand what this code is suppose...
01/18/2015
- 09:11 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
- Please post the corresponding 4GL output so that I can better understand what this code is supposed to do.
01/17/2015
- 05:57 PM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
- Constantin Asofiei wrote:
> Evgeny Kiselev wrote:
> > - Message should be always on New Line if current position is n... - 05:27 PM Database Bug #2488: replace runtime compilation of dynamic queries
- Eric Faulhaber wrote (from Constantin's email):
> The problem here is that at conversion-time the SchemaDictionary (... - 10:35 AM User Interface Feature #2476: window icon support improvements
- Code Review evl_upd20150116b.zip
1. You can't load @LogicalTerminal@ on the client, but you are trying to do so. ... - 07:50 PM User Interface Feature #2476: window icon support improvements
- This update has sources merged with the recent code base. Also cleanups, some common code rework(@Image@ class remove...
- 08:15 AM User Interface Bug #2491 (Closed): SCREEN-VALUE returns a formatted value based on the widget's format string
- CTRL-C tests passed (without any failures, including the 3-way ones). The attached version is checked in as bzr rev ...
- 06:40 AM User Interface Bug #2491: SCREEN-VALUE returns a formatted value based on the widget's format string
- In regard to the use of screen-value in validation expressions, at least the basic functionality works as expected wi...
- 06:18 AM User Interface Bug #2491 (WIP): SCREEN-VALUE returns a formatted value based on the widget's format string
- The @DateFormat@ class needed more changes to properly match the original behavior. With the attached changes, this ...
- 08:06 AM User Interface Feature #1790: implement menu support
- Code Review vig_upd20150117a.zip
As a general approach, I'm not entirely convinced it is the best idea to add menu...
01/16/2015
- 05:46 PM Database Bug #2488: replace runtime compilation of dynamic queries
- BTW, we have implemented a lot of constructor and method matching support already for TRPL itself. Perhaps we can lev...
- 05:37 PM Database Bug #2488: replace runtime compilation of dynamic queries
- I've taken a look at the code so far and it is a great start! Yes, I agree that the final tree is simpler to deal wit...
- 03:55 PM Database Bug #2488: replace runtime compilation of dynamic queries
- Eric Faulhaber wrote:
> Sure, I can do that, but are you certain you want to use the current, final version of the J... - 03:41 PM Database Bug #2488: replace runtime compilation of dynamic queries
- Ovidiu Maxiniuc wrote:
> I did some researches on windev01. Progress is not very permissive. The static statements c... - 03:30 PM Database Bug #2488: replace runtime compilation of dynamic queries
- Related to the @createAlias@ topic, here's an email exchange I had with Constantin recently:
> Eric,
>
> The prob... - 03:28 PM Database Bug #2488: replace runtime compilation of dynamic queries
- > The text of the error message suggests you are passing the same parameter (@dictdb@) for both the @alias@ and @ldbN...
- 02:38 PM Database Bug #2488: replace runtime compilation of dynamic queries
- While I am excited that you've begun implementing a solution, I'm curious whether you've found the answers to the que...
- 02:31 PM Database Bug #2488: replace runtime compilation of dynamic queries
- Ovidiu Maxiniuc wrote:
> I started implementing a small 'interpreting' engine, targeting only the required node/item... - 02:25 PM Database Bug #2488: replace runtime compilation of dynamic queries
- I started implementing a small 'interpreting' engine, targeting only the required node/items. In fact at this time, t...
- 04:54 PM User Interface Feature #2476: window icon support improvements
- I'm more worried about the client falling back to the default icon when the @setWindowDefaultIcon()@ fails to load a ...
- 04:13 PM User Interface Feature #2476: window icon support improvements
- >I think there is still a problem when the client side is told to do something (like load a filename) and that fails....
- 03:52 PM User Interface Feature #2476: window icon support improvements
- Eugenie Lyzenko wrote:
> >3. Fallback to the default icon when other specified options fail.
>
> This is handled ... - 03:50 PM User Interface Feature #2476: window icon support improvements
- >3. Fallback to the default icon when other specified options fail.
This is handled in LT.setWindowDefaultIcon():
... - 02:27 PM User Interface Feature #2476: window icon support improvements
- Code Review evl_upd20150116a.zip
This is really good. Keep going as per your plan.
I realize this is unfinishe... - 02:05 PM User Interface Feature #2476: window icon support improvements
- This update for review is not the final version to test. Just for you to see the default icon implementation and new ...
- 03:58 PM User Interface Feature #1790: implement menu support
- Here is the next update. I used @ScreenDefinition@ (not @ScreenBuffer@). Please confirm, that I'm on right way.
- 02:12 AM User Interface Feature #1790: implement menu support
- > Constantin: thoughts?
# I suspect that showing the sub-menu (when a menu is activated in the menubar) will need to... - 02:11 PM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
- Evgeny Kiselev wrote:
> - Message should be always on New Line if current position is not in the start of line. I th... - 08:04 AM User Interface Feature #2252: implement GUI client support
- Constantin Asofiei wrote:
> Greg Shah wrote:
> > Code Review ca_upd20150115b.zip
> >
> > I'm fine with the chang... - 05:42 AM User Interface Feature #2252: implement GUI client support
- Greg Shah wrote:
> Code Review ca_upd20150115b.zip
>
> I'm fine with the changes.
0115b.zip passed runtime testing. - 06:40 AM Base Language Bug #2485: Invalid THIS-PROCEDURE in AdminClient
- Committed to bzr rev 10711.
- 05:36 AM Base Language Bug #2485: Invalid THIS-PROCEDURE in AdminClient
- Stanislav Lomany wrote:
> MAJIC converted OK. Please review the update so I can distribute it.
I'm OK with the chan... - 05:28 AM Base Language Bug #2485: Invalid THIS-PROCEDURE in AdminClient
- MAJIC converted OK. Please review the update so I can distribute it.
- 02:18 AM Base Language Bug #2485: Invalid THIS-PROCEDURE in AdminClient
- Fixed conversion. MAJIC conversion is running.
- 01:58 AM User Interface Bug #2491: SCREEN-VALUE returns a formatted value based on the widget's format string
- Greg, I recall that SCREEN-VALUE was problematic in the widget validation expressions, too. It can be postponed if th...
- 09:20 PM User Interface Bug #2491: SCREEN-VALUE returns a formatted value based on the widget's format string
- It turns out that our SCREEN-VALUE implementation was nearly completely broken. MAJIC only uses a small number of ca...
- 09:15 PM User Interface Bug #2491 (Closed): SCREEN-VALUE returns a formatted value based on the widget's format string
01/15/2015
- 06:35 PM User Interface Feature #2479: DEFINE IMAGE and image phrase support for both button and image
- >Add @type == prog.define_image@ to that and I think the problem will be resolved.
Thank, this works. - 06:08 PM User Interface Feature #2479: DEFINE IMAGE and image phrase support for both button and image
- > I've found I've missed one rule file update for image widget conversion support: convert/frame_generator.xml. Witho...
- 06:04 PM User Interface Feature #2479: DEFINE IMAGE and image phrase support for both button and image
- Greg,
I've found I've missed one rule file update for image widget conversion support: convert/frame_generator.xml... - 06:08 PM Base Language Bug #2485 (Closed): Invalid THIS-PROCEDURE in AdminClient
- 05:42 PM Base Language Bug #2485 (Review): Invalid THIS-PROCEDURE in AdminClient
- 05:40 PM Base Language Bug #2485: Invalid THIS-PROCEDURE in AdminClient
- svl_upd20150115a.zip was committed into bzr rev 10710.
svl_upd20150114b.zip was committed to staging on devsrv01. - 10:45 AM Base Language Bug #2485: Invalid THIS-PROCEDURE in AdminClient
- Stanislav Lomany wrote:
> So, should I distribute the P2J update without regression testing
Run only the CTRL-C pa... - 10:43 AM Base Language Bug #2485: Invalid THIS-PROCEDURE in AdminClient
- So, should I distribute the P2J update without regression testing and check in MAJIC part into staging branch on devs...
- 10:07 AM Base Language Bug #2485: Invalid THIS-PROCEDURE in AdminClient
- Stanislav Lomany wrote:
> Fixed getting "headless" attribute.
If this solves the admin client problem without regre... - 09:34 AM Base Language Bug #2485: Invalid THIS-PROCEDURE in AdminClient
- Fixed getting "headless" attribute.
- 03:53 AM Base Language Bug #2485: Invalid THIS-PROCEDURE in AdminClient
- Stanislav Lomany wrote:
> Looks like with this call is disturbing natural order of loading @TransactionManager@ and ... - 05:04 PM User Interface Feature #1790: implement menu support
- > ScreenBuffer is not really useful because it linked to a frame and we don't know what frame is the main (common). S...
- 03:17 PM User Interface Feature #1790: implement menu support
- I trying to decide how to transfer information about main menu (menubar=true) to the client. @ScreenBuffer@ is not re...
- 11:35 AM User Interface Feature #1790: implement menu support
- No, that is not something that is specific to the p2j project. It is a tool that we would add to the standard workst...
- 11:09 AM User Interface Feature #1790: implement menu support
- Should I commit (without @work@ folder as you wrote) the script from the note #152? If yes - can I commit it right to...
- 11:03 AM User Interface Feature #1790: implement menu support
- @vig_upd20150114d.zip@ is committed to bzr with rev №10709
- 09:42 AM User Interface Feature #1790: implement menu support
- Yes, please do check in vig_upd20150114d.zip and distribute it.
- 09:37 AM User Interface Feature #1790: implement menu support
- The current update has passed conversion and regression testing. Can I commit it?
- 03:41 PM User Interface Feature #2252: implement GUI client support
- Constantin Asofiei wrote:
> Hynek, please check your tests, too.
Yes, works ok. - 01:58 PM User Interface Feature #2252: implement GUI client support
- Code Review ca_upd20150115b.zip
I'm fine with the changes. - 01:51 PM User Interface Feature #2252: implement GUI client support
- Greg Shah wrote:
> > If down frame widgets are not moved by changing their ROW/COLUMN attribute, then I think we sh... - 01:23 PM User Interface Feature #2252: implement GUI client support
- > If down frame widgets are not moved by changing their ROW/COLUMN attribute, then I think we should leave this as i...
- 01:14 PM User Interface Feature #2252: implement GUI client support
- Greg,
> * moving widgets in a down frame; not sure yet, might be related to the layout issue.
This is related to th... - 10:12 AM User Interface Feature #2252: implement GUI client support
- Greg Shah wrote:
> Code Review ca_upd20150115a.zip
>
> It's good. Please check it in.
Released to rev 10708. - 09:44 AM User Interface Feature #2252: implement GUI client support
- Code Review ca_upd20150115a.zip
It's good. Please check it in. - 04:46 AM User Interface Feature #2252: implement GUI client support
- This is replacement for ca_upd20150114b.zip and passed runtime testing. The @Assigning row/col attributes of a widg...
- 03:12 PM Database Bug #2488: replace runtime compilation of dynamic queries
- Ovidiu Maxiniuc wrote:
> Yes, @query-prepare()@ is the big issue. I believe there are no constrains here and any num... - 02:58 PM Database Bug #2488: replace runtime compilation of dynamic queries
- Yes, @query-prepare()@ is the big issue. I believe there are no constrains here and any number of buffers can be adde...
- 02:53 PM Database Bug #2488: replace runtime compilation of dynamic queries
- OK, so no calls to UDFs, either? That's another way to trigger client-side where clause processing.
If not, it wou... - 02:42 PM Database Bug #2488: replace runtime compilation of dynamic queries
- Looking at @find-first()@ method in manual, the predicate expression is very simple, just ...
- 02:34 PM Database Bug #2488: replace runtime compilation of dynamic queries
- I think the following would give us a reasonably complex @WhereExpression@:...
- 01:05 PM Database Bug #2488: replace runtime compilation of dynamic queries
- > I'm not sure how well an interpreted WhereExpression would work. We may still have to fall back to a compiled appro...
- 12:47 PM Database Bug #2488: replace runtime compilation of dynamic queries
- Ovidiu Maxiniuc wrote:
> The java/TRLP debate. It's clear that TRPL has the some advantages, but I think that we sho... - 12:41 PM Database Bug #2488: replace runtime compilation of dynamic queries
- Ovidiu Maxiniuc wrote:
> The difficulty appears when there are another buffers (and aliases)...
Please explain your... - 06:41 AM Database Bug #2488: replace runtime compilation of dynamic queries
- I understand the principle of this approach.
At first sight, it looks rather easy, the where clause and sorting ar... - 02:04 AM Database Bug #2488: replace runtime compilation of dynamic queries
- The basic idea behind this improvement is to continue to use runtime TRPL to convert a query to an in-memory, Java AS...
- 01:40 PM User Interface Feature #2490: fix movement of widgets part of a down frame's body
- The widgets part of the down body for a down frame can't be safely moved (by changing their ROW/COLUMN attributes) be...
- 01:36 PM User Interface Feature #2490 (New): fix movement of widgets part of a down frame's body
- 12:53 PM User Interface Feature #2476: window icon support improvements
- Actually, let's name @setDefaultWindowIcon()@ as @setWindowDefaultIcon()@ instead. I think it is more descriptive.
... - 12:31 PM User Interface Feature #2476: window icon support improvements
- >1. We want to minimize unnecessary calls from the client to the server. Generally, we want the server to dictate the...
- 11:33 AM User Interface Feature #2476: window icon support improvements
- Code Review evl_upd20150114a.zip
This is moving in the right direction, but I do have some questions/comments:
... - 07:43 PM User Interface Feature #2476: window icon support improvements
- The update includes icon related part of the icon/image implementation for review. Not completed testing but approach...
- 09:38 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
- I think your idea of changing the approach seems to be on the right track.
> Message should be always on New Line ... - 05:21 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
- At the moment regression tests finished with failed status.
5 tests are failed because of different numbers of rows ...
01/14/2015
- 03:14 PM Base Language Bug #2485: Invalid THIS-PROCEDURE in AdminClient
- Heh, there is a problem with @TransactionManager.isHeadless@: normal clients do not start....
- 02:20 PM Base Language Bug #2485: Invalid THIS-PROCEDURE in AdminClient
- The query changes are the same that were sent to Scott.
- 12:48 PM Base Language Bug #2485: Invalid THIS-PROCEDURE in AdminClient
- Code Review svl_upd20150114b.zip
I'm fine with the external procedure wrapping parts of this.
Eric: please revi... - 12:48 PM Base Language Bug #2485: Invalid THIS-PROCEDURE in AdminClient
- Code Review svl_upd20150114a.zip
I'm fine with this. - 11:40 AM Base Language Bug #2485: Invalid THIS-PROCEDURE in AdminClient
- Updates for review.
- 08:22 AM Base Language Bug #2485: Invalid THIS-PROCEDURE in AdminClient
- Yes, I think that is fine. We just need to put some clear comments into there to explain why this is being done.
- 01:59 AM Base Language Bug #2485: Invalid THIS-PROCEDURE in AdminClient
- Greg, can we assume that if we are in headless mode (@TransactionManager.isHeadless()@ returns true), we are under li...
- 12:06 PM User Interface Feature #2252: implement GUI client support
- Constantin Asofiei wrote:
> Hynek, I'm planning on looking into solving these problems (based on my previous update)... - 11:58 AM User Interface Feature #2252: implement GUI client support
- Hynek, I'm planning on looking into solving these problems (based on my previous update):
* Assigning row/col attrib... - 11:11 AM User Interface Feature #2252: implement GUI client support
- Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > Constantin Asofiei wrote:
> > > Second part of the SIDE-LABEL-... - 11:08 AM User Interface Feature #2252: implement GUI client support
- Hynek Cihlar wrote:
> Constantin Asofiei wrote:
> > Second part of the SIDE-LABEL-HANDLE support, to allow changing... - 09:09 AM User Interface Feature #2252: implement GUI client support
- Greg Shah wrote:
> Code Review ca_upd20150114b.zip
>
> It looks like there were some tricky latent bugs that you ... - 09:08 AM User Interface Feature #2252: implement GUI client support
- Constantin Asofiei wrote:
> Second part of the SIDE-LABEL-HANDLE support, to allow changing the ROW/COLUMN attribute... - 09:06 AM User Interface Feature #2252: implement GUI client support
- > The remaining issue is related to moving widgets in a down frame; root cause: server-side has only 1 widget which i...
- 09:05 AM User Interface Feature #2252: implement GUI client support
- Code Review ca_upd20150114b.zip
It looks like there were some tricky latent bugs that you had to solve here. I se... - 08:58 AM User Interface Feature #2252: implement GUI client support
- The label moves ok and the position attributes are properly reported back to the server.
Btw. there are some (chui... - 06:51 AM User Interface Feature #2252: implement GUI client support
- Second part of the SIDE-LABEL-HANDLE support, to allow changing the ROW/COLUMN attributes from the server-side. Runt...
- 10:09 AM User Interface Feature #1790: implement menu support
- > Can It be useful for somebody?
Very cool! I like it.
The only thing we need to do here is to eliminate the d... - 10:03 AM User Interface Feature #1790: implement menu support
- I was using an eclipse plugin to merge files last time and didn't accustom to this plugin probably. The reason of the...
- 09:54 AM User Interface Feature #1790: implement menu support
- Thank you. These folders are different. diff*_ddl.txt is empty, but diff_*_src.txt is not empty. I'm trying to interp...
- 09:35 AM User Interface Feature #1790: implement menu support
- As noted in the @timco.html@:
*Build and Save a Comparison Version*
Before running any conversion regression te... - 09:30 AM User Interface Feature #1790: implement menu support
- I've ran conv-regression task. It executed, but failed at the end. Here is the end of the log:...
- 08:35 AM User Interface Feature #1790: implement menu support
- Code Review vig_upd20150114c.zip
This is really good. Please put it into both conversion and runtime regression t... - 05:31 AM User Interface Feature #1790: implement menu support
- I missed several files.
- 04:48 AM User Interface Feature #1790: implement menu support
- Thank you. Here is the current update with these changes.
- 04:18 AM User Interface Feature #1790: implement menu support
- Vadim Gindin wrote:
> Please, recall me, should I change a year of a Copyright block in each modified file to 2015?
... - 03:16 AM User Interface Feature #1790: implement menu support
- I've merged @method_attributes.rules@ and changed @text@ with @names.convert(text, names.variable)@ corresponding to ...
- 10:07 AM Base Language Bug #2489: FileSystemOps.searchPath(String) should return the 4GL procedure name for external pro...
- It is common for 4GL code to search for 4GL external procedure names before executing those programs. Such searches ...
- 09:54 AM Base Language Bug #2489 (Closed): FileSystemOps.searchPath(String) should return the 4GL procedure name for ext...
- 01:26 AM Database Bug #2488: replace runtime compilation of dynamic queries
- Dynamically defined queries are parsed and converted at runtime by P2J, then compiled into discrete Java classes usin...
- 12:48 AM Database Bug #2488 (Closed): replace runtime compilation of dynamic queries
- 09:06 PM User Interface Feature #2487: implement READ-FILE() and SAVE-FILE() methods in the editor widget
- The @READ-FILE()@ method is already supported in @methods_attributes.rules@ (and the runtime stubs are in the @Editor...
- 08:32 PM User Interface Feature #2487 (Closed): implement READ-FILE() and SAVE-FILE() methods in the editor widget
- 08:29 PM User Interface Feature #2486: enhance editor functionality
- This task is just here to aggregate the related sub-tasks.
- 08:28 PM User Interface Feature #2486 (Closed): enhance editor functionality
01/13/2015
- 04:06 PM Base Language Bug #2485 (WIP): Invalid THIS-PROCEDURE in AdminClient
- Constantin, thanks, that helped.
Guys, there is one more issue: if we connect to a fresh server - no standards cli... - 09:42 AM Base Language Bug #2485: Invalid THIS-PROCEDURE in AdminClient
- Stanislav,
Your stacktrace is hiding another NPE, when the scope is initially pushed:... - 08:54 AM Base Language Bug #2485: Invalid THIS-PROCEDURE in AdminClient
- I think all of the issues have the same cause. Reproduction:
1. Log into admin client.
2. MAJIC -> Printer Maintena... - 07:18 AM Base Language Bug #2485 (Closed): Invalid THIS-PROCEDURE in AdminClient
- 01:19 PM User Interface Feature #1790: implement menu support
- Code Review vig_upd20150113a.zip
The only problem I see is that you still have a duplicate section for @kw_full_h_... - 01:14 PM User Interface Feature #1790: implement menu support
- I think the triggers code looks fine. Is there anything else to do for the conversion?
- 12:48 PM User Interface Feature #1790: implement menu support
- Here are the source and generated files for menu references in triggers as you asked earlier.
- 12:44 PM User Interface Feature #1790: implement menu support
- The next update.
# Fixed remarks.
# Fixed @lvalue@ rule in progress.g (added KW_SUB_MENU as possible widget qualifi... - 09:39 AM User Interface Feature #1790: implement menu support
- It is a good question. We already have quite a bit of logic that handles these cases differently. Right now they ca...
- 09:38 AM User Interface Feature #1790: implement menu support
- I suppose I should make the common AST subtree for both cases. How can I make it and where? May be it is also a parse...
- 09:33 AM User Interface Feature #1790: implement menu support
- After I fixed some parsing problem I faced with the following difficulty during conversion of the following trigger:
... - 07:18 AM User Interface Feature #2252: implement GUI client support
- Committed to bzr revision 10704.
Greg Shah wrote:
> Code Review hc_upd20150112a.zip
>
> It looks good. Pleas... - 08:37 PM User Interface Feature #2252: implement GUI client support
- Code Review hc_upd20150112a.zip
It looks good. Please check it in. - 08:41 PM User Interface Feature #2476: window icon support improvements
- OK, do whatever matches the behavior of the 4GL.
- 08:30 PM User Interface Feature #2476: window icon support improvements
- The important finding. Progress does not load the icon from current directory if the current directory is not in @PRO...
01/12/2015
- 06:30 PM User Interface Feature #2252: implement GUI client support
- In ref to #2424.
The attached change set resolves widget positioning in a frame and passed regression testing. Ple... - 12:29 PM User Interface Feature #2422: add features to BROWSE
- Here is the list of 4GL bugs which I'm not going to reproduce. It's obviously not full and may expand it as I'll find...
- 12:13 PM User Interface Feature #1790: implement menu support
- I'm OK with what I saw in the code.
Please post some examples here (both the 4GL and then the converted Java for t... - 11:54 AM User Interface Feature #1790: implement menu support
- The only triggers references are left. What do you think about approach I used for that?
- 11:10 AM User Interface Feature #1790: implement menu support
- Code Review vig_upd20150112a.zip
Generally, the changes are quite good. I see the following cleanup items. It se... - 09:39 AM User Interface Feature #1790: implement menu support
- Here is the current update with the following changes.
# Fixed extra ';' for EXPRESSION/NUM_LITERAL. Check please is... - 10:45 AM User Interface Feature #2479: DEFINE IMAGE and image phrase support for both button and image
- Please add @CREATE IMAGE@ support by adding the widget to the list @DynamicWidgetFactory.java@.
01/10/2015
- 05:21 PM User Interface Feature #2476: window icon support improvements
- >1. In ImageGuiImpl, should line 258 be if (readers.hasNext()) or should it be while (readers.hasNext())?
I use fi... - 01:07 PM User Interface Feature #2476: window icon support improvements
- Code Review evl_upd20150109b.zip
1. In @ImageGuiImpl@, should line 258 be @if (readers.hasNext())@ or should it be... - 07:36 PM User Interface Feature #2476: window icon support improvements
- This update for review adds current path adding to be included in image loading approach. If the image or icon was no...
01/09/2015
- 03:20 PM User Interface Feature #1790: implement menu support
- You'll have to upload the entire update for me to get a better sense of your approach. We should not have to put lot...
- 12:29 PM User Interface Feature #1790: implement menu support
- I found some interesting place in @expressions.rules@ line 1234:...
- 12:02 PM User Interface Feature #1790: implement menu support
- I'm trying to find out a solution for extra semicolon emission (see note #71). I still can't find a place where it is...
- 01:24 PM User Interface Feature #2476: window icon support improvements
- This upload for review implements small/regular icon loading. The idea is the difference we need to make is the image...
- 07:55 AM User Interface Feature #2476: window icon support improvements
- > Moreover according to 4GL document icon size difference should work in Windows 95 or NT method). So I do not even s...
- 07:54 AM User Interface Feature #2476: window icon support improvements
- Please make sure you support all the variants of these methods (with more than one parameter).
In addition, it is ... - 10:05 PM User Interface Feature #2476: window icon support improvements
- >2. Add Window.loadSmallIcon() runtime support.
About LOAD-SMALL-ICON. Generally speaking there is no difference b... - 11:40 AM Bugs Bug #2483: Fix issues identified by static code analysis
- /home/ias/p2j/src/com/goldencode/p2j/util/EnvironmentOps.java:1313 Non-virtual method call in com.goldencode.p2j.util...
- 11:01 AM Bugs Bug #2483: Fix issues identified by static code analysis
- /home/ias/p2j/src/com/goldencode/p2j/util/integer.java:359 Possible null pointer dereference of value in new com.gold...
- 10:58 AM Bugs Bug #2483: Fix issues identified by static code analysis
- /home/ias/p2j/src/com/goldencode/p2j/persist/type/DatetimeTzUserType.java:239 Possible null pointer dereference of va...
- 10:56 AM Bugs Bug #2483: Fix issues identified by static code analysis
- /home/ias/p2j/src/com/goldencode/p2j/uast/CallbackResolver.java:355 Possible null pointer dereference of method in co...
- 10:48 AM Bugs Bug #2483: Fix issues identified by static code analysis
- /home/ias/p2j/src/com/goldencode/p2j/persist/hql/HQLParser.java:147 Incorrect lazy initialization and update of stati...
- 10:36 AM Bugs Bug #2483: Fix issues identified by static code analysis
- /home/ias/p2j/src/com/goldencode/p2j/ui/WindowWidget.java:276 There is an apparent infinite recursive loop in com.gol...
- 10:31 AM Bugs Bug #2483: Fix issues identified by static code analysis
- /home/ias/p2j/src/com/goldencode/p2j/e4gl/E4GLPreprocessor.java:307 Self assignment of field E4GLPreprocessor.opts in...
- 10:28 AM Bugs Bug #2483: Fix issues identified by static code analysis
- TableResultSet.java, line 603.
((BigDecimal) res).setScale(scale);
Looks like a misprint, should be: res = ((BigDec... - 10:18 AM Bugs Bug #2483: Fix issues identified by static code analysis
- I've fixed the issues we discussed recently except the one regarding the ExpressionConversionWorker (I understand it ...
- 10:17 AM Bugs Bug #2483: Fix issues identified by static code analysis
- 1. DirectoryCopy, line 1216
if (att != null || att.length > 0)
Potential NPE. I think a correct version is: ... - 10:16 AM Bugs Bug #2483: Fix issues identified by static code analysis
- 1. Eclipse reports potential NPE at line 1216 in the DirectoryCopy.java
2. FindBugs reports 250+ suspicious places i... - 09:02 AM Bugs Bug #2483 (Closed): Fix issues identified by static code analysis
- 08:02 AM Database Bug #2482 (WIP): conversion of FIND does not honor NO-LOCK when specified early
- 02:29 AM Database Bug #2482: conversion of FIND does not honor NO-LOCK when specified early
- I found that a FIND statement of the following form is converted without a @LockType.NONE@ lock type:...
- 02:03 AM Database Bug #2482 (WIP): conversion of FIND does not honor NO-LOCK when specified early
01/08/2015
- 08:55 AM User Interface Feature #2478: button image support
- Greg Shah wrote:
> Is there any behavior yet to be implemented?
If we think about images processing here - handle... - 08:45 AM User Interface Feature #2478: button image support
- Is there any behavior yet to be implemented?
- 07:36 AM User Interface Feature #2478: button image support
- The update @evl_upd20150107a.zip@ has been committed in bzr as 10698.
- 10:42 PM User Interface Feature #2478: button image support
- Good, go ahead.
- 08:37 PM User Interface Feature #2478: button image support
- Runtime testing completed. The results - @10696_65fcb0a_20150107_evl.zip@. The 3-way tests was started in separate se...
- 07:03 PM User Interface Feature #2478: button image support
- The update @evl_upd20150107a.zip@ has passed the main runtime regression cycle. Waiting for CTRL-C part to be completed.
- 08:02 AM User Interface Feature #2476: window icon support improvements
- The update @evl_upd20150107b.zip@ has been committed in bzr as 10699.
- 05:28 AM User Interface Feature #2476: window icon support improvements
- Eugenie: OK, go ahead and check it in.
- 05:26 AM User Interface Feature #2476: window icon support improvements
- Greg Shah wrote:
> I don't know that we need to runtime test this since from a ChUI perspective this just adds a no-... - 05:25 AM User Interface Feature #2476: window icon support improvements
- I don't know that we need to runtime test this since from a ChUI perspective this just adds a no-op method. Thoughts?
- 04:58 AM User Interface Feature #2476: window icon support improvements
- Eugenie, your changes seem OK, but I'm not sure when the GUI code broke, as something simple as this doesn't work any...
- 08:22 PM User Interface Feature #2476: window icon support improvements
- Also note the new window in 4GL is placed over the main one, while in P2J the main window remains on top. This is the...
- 08:02 PM User Interface Feature #2476: window icon support improvements
- >1. Loading icons using using a handle that isn't CURRENT-WINDOW does not work.
The main issue with loading icons ... - 04:46 AM User Interface Feature #2252: implement GUI client support
- Greg Shah wrote:
> Code Review ca_upd20150108a.zip
>
> I'm fine with the code. Please check it in.
Committed ... - 04:38 AM User Interface Feature #2252: implement GUI client support
- Code Review ca_upd20150108a.zip
I'm fine with the code. Please check it in. - 01:57 AM User Interface Feature #2252: implement GUI client support
- This is replacement for ca_upd20150105c.zip , adds SIDE-LABEL-HANDLE support. The positioning via ROW/COLUMN attribut...
01/07/2015
- 03:04 PM User Interface Feature #1798: implement full frame family support (parent-child relationships between frames)
- The above notes are really about the widget-level requirements, which perhaps should be placed in another task. I do...
- 03:00 PM User Interface Feature #1798: implement full frame family support (parent-child relationships between frames)
- I think the conversion already supports these features. If I understand correctly, the work is on the runtime side.
... - 12:55 PM User Interface Feature #2481 (Closed): enable, test and fix clipping for both rectangle and button GUI widgets
- 12:53 PM User Interface Feature #1832 (Closed): implement image support
- This work will be completed as part of #2446.
- 12:51 PM User Interface Feature #2446 (WIP): implement BUTTON and IMAGE GUI widgets (runtime and conversion support)
- 10:30 AM User Interface Feature #2480: add support for button and image attributes and options
- Some of these attributes are available for both button and image (but no other widgets). Other attributes are availa...
- 09:01 AM User Interface Feature #2480 (Closed): add support for button and image attributes and options
- 10:27 AM User Interface Feature #2252: implement GUI client support
- The conversion testing completed. Generated code files are identical. Starting the runtime regression tests.
- 09:20 AM User Interface Feature #2252: implement GUI client support
- Code Review evl_upd20150107a.zip
It looks fine. - 08:57 AM User Interface Feature #2252: implement GUI client support
- The new file for regression testing. There was missing enclosing quote (") in @methods_attributes.rules@ file. This c...
- 09:55 PM User Interface Feature #2252: implement GUI client support
- Code Review evl_upd20150106c.zip
Everything looks good. Please go ahead with testing. - 09:50 PM User Interface Feature #2252: implement GUI client support
- Greg Shah wrote:
> Code Review evl_upd20150106b.zip
>
> @load-small-icon()@ is missing from the newer @methods_at... - 09:27 PM User Interface Feature #2252: implement GUI client support
- Code Review evl_upd20150106b.zip
@load-small-icon()@ is missing from the newer @methods_attributes.rules@. - 09:14 PM User Interface Feature #2252: implement GUI client support
- >3. All the @ButtonWidget.loadImage*(character)@ methods are silently returning when you pass unknown value as the pa...
- 08:14 PM User Interface Feature #2252: implement GUI client support
- This:...
- 08:04 PM User Interface Feature #2252: implement GUI client support
- Greg Shah wrote:
> Code Review
>
> This is good. Some minor things:
>
> 1. Please move the @methods_attribut... - 07:26 PM User Interface Feature #2252: implement GUI client support
- Code Review
This is good. Some minor things:
1. Please move the @methods_attributes.rules@ changes into the @... - 08:54 AM User Interface Feature #2479: DEFINE IMAGE and image phrase support for both button and image
- It is important to note that full DEFINE IMAGE conversion support is part of this task. Currently, we have some prov...
- 10:01 PM User Interface Feature #2425 (Closed): implement GUI rectangle widget
01/06/2015
- 06:19 PM Bugs Bug #2249 (Closed): PermGen leak due to dynamic conversion at runtime
- The @ConversionPool@ implementation seems to be holding up well with testing. We have a separate PermGen growth issue...
- 05:53 PM User Interface Feature #2479: DEFINE IMAGE and image phrase support for both button and image
- Full Image phrase support for DEFINE BUTTON and DEFINE IMAGE widgets:
size-phrase({SIZE | SIZE-CHARS | SIZE-PIXELS... - 05:53 PM User Interface Feature #2479 (Closed): DEFINE IMAGE and image phrase support for both button and image
- 05:50 PM User Interface Feature #2478: button image support
- Image handling methods for buttons:
LOAD-MAGE-UP
LOAD-IMAGE-DOWN
LOAD-IMAGE-INSENSITIVE
Reproduce native 4GL ... - 05:49 PM User Interface Feature #2478 (Closed): button image support
- 05:43 PM User Interface Bug #2477: button remains pressed when it should not
- Sometimes button seems to lose track of mouse events. Perhaps it has something to do with dragging and then releasin...
- 05:43 PM User Interface Bug #2477 (Closed): button remains pressed when it should not
- 05:42 PM User Interface Feature #2252: implement GUI client support
- The update for review contains LOAD-MAGE-UP, LOAD-IMAGE-DOWN, LOAD-IMAGE-INSENSITIVE implementation for conversion an...
- 05:39 PM User Interface Feature #2476: window icon support improvements
- 1. Loading icons using using a handle that isn't CURRENT-WINDOW does not work.
2. Add Window.loadSmallIcon() runti... - 05:36 PM User Interface Feature #2476 (Closed): window icon support improvements
01/05/2015
- 04:51 PM User Interface Feature #2252: implement GUI client support
- Code Review ca_upd20150105c.zip
The update looks quite good.
The only thing I would suggest is to move @process... - 04:00 PM User Interface Feature #2252: implement GUI client support
- First pass at the SIDE-LABEL-HANDLE attribute. This can be used with these widgets: COMBO-BOX, EDITOR, FILL-IN, RADI...
- 11:39 AM User Interface Feature #2252: implement GUI client support
- Committed to bzr revision 10694.
Greg Shah wrote:
> Code Review hc_upd20150103a.zip
>
> The change is fine. P... - 11:10 AM User Interface Feature #2252: implement GUI client support
- Code Review hc_upd20150103a.zip
The change is fine. Please check it in. - 11:04 AM User Interface Feature #2252: implement GUI client support
- The attached update resolves the runtime regression introduced by hc_upd20141221c. The problem was in unwanted change...
- 09:42 AM User Interface Feature #2252: implement GUI client support
- The @evl_upd20150103a.zip@ has been committed in bzr as @10693@.
- 09:20 AM User Interface Feature #2252: implement GUI client support
- The runtime testing for @evl_upd20150103a.zip@ completed including CTRL-C. No regressions except knowing @TC-INQUIRY-...
- 04:10 AM User Interface Feature #1790: implement menu support
- Greg Shah wrote:
> I'm not sure if we need to implement this tracking for shared menus. ... If I am right, then you...
01/04/2015
- 09:29 AM User Interface Feature #2252: implement GUI client support
- > Is it supposed the new dynamic window be shown in separate window in addition to the default one(I mean we should s...
01/03/2015
- 02:39 PM User Interface Feature #2252: implement GUI client support
- >I didn't try it directly with CURRENT-WINDOW. Please see if the above handle-based @hwin@ code works for you.
The... - 12:05 PM User Interface Feature #2252: implement GUI client support
- I was trying like this:...
- 10:31 AM User Interface Feature #2252: implement GUI client support
- Greg,
>
> 1. I couldn't get the customer icons to load using simple testcases. It didn't matter which icon files ... - 10:19 AM User Interface Feature #2252: implement GUI client support
- Summary of remaining work on image, icons, button and tooltip support:
+Icons+
1. I couldn't get the customer i... - 10:01 AM User Interface Feature #2252: implement GUI client support
- Greg Shah wrote:
> Code Review evl_upd20150103a.zip
>
> The merge looks good. If it passes testing, please check... - 07:31 AM User Interface Feature #2252: implement GUI client support
- Code Review evl_upd20150103a.zip
The merge looks good. If it passes testing, please check it in. - 06:50 AM User Interface Feature #2252: implement GUI client support
- >Eugenie: on second thought, please hold off of checking in and distributing the @evl_upd20141222a.zip@. I have been ...
01/02/2015
- 04:56 PM User Interface Feature #2474: dynamically execute applhelp.p instead of driving it from a static directory entry
- Today P2J can only have a static @applhelp.p@ equivalent, but in the 4GL the propath is searched dynamically to find ...
- 04:55 PM User Interface Feature #2474 (New): dynamically execute applhelp.p instead of driving it from a static directory...
- 02:52 PM User Interface Bug #2473: ENABLE/DISABLE by themselves don't define frames (but they do add to them if the frame...
- Consider these cases:
+Case 1+... - 02:47 PM User Interface Bug #2473 (New): ENABLE/DISABLE by themselves don't define frames (but they do add to them if the...
Also available in: Atom