Project

General

Profile

Activity

From 09/23/2023 to 10/22/2023

10/22/2023

07:17 AM User Interface Feature #4856 (WIP): web client session forking
Galya B

10/21/2023

10:41 AM User Interface Bug #7946: Default selection and current browse row color differs for different customers applica...
Should we add @oldBrowseSelectionBar@ parameter to the directory? E.g. in @server/default/theme/oldBrowseSelectionBar... Stanislav Lomany
10:29 AM User Interface Bug #7946: Default selection and current browse row color differs for different customers applica...
I found the cause of the issue. This picture from my earlier investigations which illustrates the difference between ... Stanislav Lomany
09:23 PM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
Just sharing my experience.
It might be an easy fix: check whether the jar (which should contain the @.sql@ resour...
Ovidiu Maxiniuc
08:18 PM Database Feature #6414: ERROR attribute for buffer, dataset and temp-table
Since #6414-3 we have the @Errorable@ interface which groups together all @error@ attributes, regardless of object ty... Ovidiu Maxiniuc

10/20/2023

03:05 PM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
Roger Borrello wrote:
> Tijs Wickardt wrote:
> > When you run the procedure described at [[p2j:Testcases]], does yo...
Tijs Wickardt
02:51 PM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
Tijs Wickardt wrote:
> When you run the procedure described at [[p2j:Testcases]], does your jar include them?
Sor...
Roger Borrello
02:44 PM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
Roger Borrello wrote:
> Does your jar include the @ddl@ files?
After revert?
Els can check on Monday, I'm not at...
Tijs Wickardt
02:21 PM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
Does your jar include the @ddl@ files? Roger Borrello
01:37 PM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
Hello Roger, I'm experiencing the same regression as Els in #4722-162 .
We aren't completely sure which commit after...
Tijs Wickardt
02:43 PM Database Feature #6414: ERROR attribute for buffer, dataset and temp-table
Ovidiu, how much effort is there to finish this? We are trying to get it done this month. Eric Faulhaber
11:34 AM Base Language Bug #7299: resolution of the target OO method in chained calls with poly arguments
Branch 7299b was merged to trunk rev 14779 and archived Constantin Asofiei
10:15 AM Base Language Bug #7299: resolution of the target OO method in chained calls with poly arguments
Code Review Task Branch 7299b Revisions 14778 through 14780
The changes are good.
Greg Shah
10:19 AM Database Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
Radu, please let me know when you finish with the changes here. I will like to have this reviewed, tested and merged ... Alexandru Lungu
08:31 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
Alexandru Lungu wrote:
> For the conversion side, do you mean preprocessing the path when converting to extract the ...
Hynek Cihlar
08:25 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
I've *committed 6649b/rev.14743* with the following changes:
* renamed @convertNameDynamically@ to @fastConvertName@...
Dănuț Filimon
07:30 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
For the conversion side, do you mean preprocessing the path when converting to extract the base name (@a.p@ from @x/y... Alexandru Lungu
07:28 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
Hynek Cihlar wrote:
> Another idea I'm not sure you already considered is precalculating the denormalized Progress n...
Dănuț Filimon
06:06 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
Hynek Cihlar wrote:
> The precalculated map would be stored per session and would have to be recalculated on input c...
Hynek Cihlar
06:04 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
Another idea I'm not sure you already considered is precalculating the denormalized Progress names passed in to the c... Hynek Cihlar
05:32 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
Hynek Cihlar wrote:
> I'm not that familiar with the anticipated test cases, but wouldn't the cache still be benefic...
Dănuț Filimon
08:26 AM User Interface Bug #7946: Default selection and current browse row color differs for different customers applica...
> @app_A@ - Windows Server 2012 + OE 11.x
> @app_C@ - Windows Server 2016 + OE 10.x (!)
> @app_M@ - Windows Serve...
Greg Shah
04:37 AM User Interface Bug #7946: Default selection and current browse row color differs for different customers applica...
While @app_C@ and @app_M@ have different row color, the @HKEY_CURRENT_USER\Control Panel\Colors@ sections are the sam... Stanislav Lomany
04:33 AM User Interface Bug #7946: Default selection and current browse row color differs for different customers applica...
We have differences in "selection color" which affects color of selection in fill-in, editor, drop-downs and selectio... Stanislav Lomany
02:27 AM User Interface Bug #7946 (Test): Default selection and current browse row color differs for different customers ...
Stanislav Lomany

10/19/2023

04:49 PM Database Feature #7943: improvements in lock management for diagnostics and release of orphaned locks
A customer with a ChUI application (see #5290) is on an older version of FWD and had issues with locks being held lon... Greg Shah
03:53 PM Database Feature #7943 (New): improvements in lock management for diagnostics and release of orphaned locks
Greg Shah
11:38 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
Dănuț Filimon wrote:
> Hynek Cihlar wrote:
> It seems that currently the @convertName@ method calls @getLegacyCaseS...
Hynek Cihlar
09:51 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
Hynek Cihlar wrote:
> *convertNameDynamically:*
> * instead of
> [...]
> it would be more efficient to store cas...
Dănuț Filimon
10:36 AM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
Hi Roger,
We found a possible regression after the merge with trunk of this issue.
In xfer testcases I can convert ...
Els van Dun
10:05 AM Base Language Bug #7299: resolution of the target OO method in chained calls with poly arguments
Greg, please review 7299b (revs 14778 - 14780) - this contains regression fixes for #6501-359 and #7929 Constantin Asofiei
07:15 AM Base Language Bug #7299: resolution of the target OO method in chained calls with poly arguments
7299b rev 14776 will show linkage errors when resolving Java class names during conversion. The problem here is that... Constantin Asofiei
12:51 AM User Interface Feature #4856: web client session forking
The core requirement of the task is to open a new session of the same user easily without dialogs. That is achieved w... Galya B
12:39 AM User Interface Feature #4129: map web client users to OS accounts
You're referring to a very old comment, where I'm trying to figure out the point of the trusted security check that w... Galya B
12:37 AM User Interface Feature #4129: map web client users to OS accounts
Greg Shah wrote:
> I'm worried that the code is now written to force the storage of the password when customers will...
Galya B
12:33 AM User Interface Feature #4854: origin affinity
Constantin Asofiei wrote:
> Some notes about the diff:
> * the testing I think can be done with Hotel GUI and enhan...
Galya B

10/18/2023

05:52 PM Base Language Feature #6431: implement support to allow CPINTERNAL set to UTF-8 and CP936
Greg Shah wrote:
> We will be running these as unit tests using our ABLUnit support. At some point, your testcases ...
Theodoros Theodorou
05:48 PM Base Language Feature #6431: implement support to allow CPINTERNAL set to UTF-8 and CP936
Ovidiu Maxiniuc wrote:
> Theodoros Theodorou wrote:
> > I am trying to build a prorgam in OE that generates tests. ...
Theodoros Theodorou
05:27 PM Base Language Feature #6431: implement support to allow CPINTERNAL set to UTF-8 and CP936
Theodoros Theodorou wrote:
> I am trying to build a prorgam in OE that generates tests. I generated a file located a...
Ovidiu Maxiniuc
05:18 PM Base Language Feature #6431: implement support to allow CPINTERNAL set to UTF-8 and CP936
Theodoros Theodorou wrote:
> Greg Shah wrote:
> > You could make this data driven. The idea is to capture the inpu...
Greg Shah
05:11 PM Base Language Feature #6431: implement support to allow CPINTERNAL set to UTF-8 and CP936
We will be running these as unit tests using our ABLUnit support. At some point, your testcases will be reworked to ... Greg Shah
05:02 PM Base Language Feature #6431: implement support to allow CPINTERNAL set to UTF-8 and CP936
Greg Shah wrote:
> > What do you think about my idea for testing asc() and chr() with different -cpinternals?
>
>...
Theodoros Theodorou
04:56 PM Base Language Feature #6431: implement support to allow CPINTERNAL set to UTF-8 and CP936
Greg Shah wrote:
> You could make this data driven. The idea is to capture the inputs and results in an array even ...
Theodoros Theodorou
04:19 PM Base Language Feature #6431: implement support to allow CPINTERNAL set to UTF-8 and CP936
> What do you think about my idea for testing asc() and chr() with different -cpinternals?
I think we must do that...
Greg Shah
04:17 PM Base Language Feature #6431: implement support to allow CPINTERNAL set to UTF-8 and CP936
You could make this data driven. The idea is to capture the inputs and results in an array even in a data file. Then... Greg Shah
04:09 PM Base Language Feature #6431: implement support to allow CPINTERNAL set to UTF-8 and CP936
I am trying to build a prorgam in OE that generates tests. I generated a file located at testcases/cp/cpinternal/iso8... Theodoros Theodorou
04:42 PM User Interface Feature #4129: map web client users to OS accounts
> > > All OS users will have to have password defined for web, because the spawner does PAM authentication for the we... Greg Shah
02:24 PM User Interface Feature #4854: origin affinity
Some notes about the diff:
* the testing I think can be done with Hotel GUI and enhanced browse - this uses this sto...
Constantin Asofiei
09:00 AM User Interface Feature #4856: web client session forking
> I'm pretty sure it's not expected the 4GL app to be subscribed for an event from web for a new forked session.
I...
Greg Shah
08:59 AM User Interface Feature #4856: web client session forking
> You can have different users logged in with auto-login.
Please help me understand how this can work. Auto-login...
Greg Shah
08:46 AM User Interface Feature #4856: web client session forking
I'm pretty sure it's not expected the 4GL app to be subscribed for an event from web for a new forked session.
Galya B
08:43 AM User Interface Feature #4856: web client session forking
You can have different users logged in with auto-login. This is not related to opening a new session (so called `fork... Galya B
08:33 AM User Interface Feature #4856: web client session forking
Our discussion in #7813 highlights that I did not pick up on a crucial detail.
> Also it dawned on me just now tha...
Greg Shah

10/17/2023

01:21 PM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
Code review 6649b revision 14742 and 14741.
Functionally the changes look OK. I'm throwing in some random ideas fo...
Hynek Cihlar
03:14 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
Alexandru Lungu wrote:
> There is a lot of documentation there, so from this POV I think the changes are clear enoug...
Dănuț Filimon
10:20 AM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
Committed on 7045b, revision 14682.
For now @QueryOffEnd@ exception is not throw in case a query is part of a @for...
Eduard Soltan
09:17 AM Database Bug #7924: add support for creating an empty database
Greg, thank you for the heads-up. This exact same thing I wanted to mention, but I missed it. Please note my "Two way... Alexandru Lungu
09:09 AM Database Bug #7924: add support for creating an empty database
Please note that the ant task is a development convenience. When deploying to production environments, there will be... Greg Shah
08:37 AM Database Bug #7924 (WIP): add support for creating an empty database
A summary from a customer task - mostly from Eric:
* Empty database: _A database with a fully working schema (incl...
Alexandru Lungu
08:23 AM Database Bug #7924 (Test): add support for creating an empty database
Alexandru Lungu
04:41 AM User Interface Bug #7879: Cursor isn't positioned right when FILL-IN split on multiple lines
Tomasz Domin wrote:
> There are two issues:
> first - there is no label on initial screen, the issue is caused by a...
Tomasz Domin

10/16/2023

01:30 PM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
Hynek: Please review. Greg Shah
11:22 AM User Interface Feature #4854: origin affinity
Sergey Ivanovskiy wrote:
> Ok. In this case you should create a branch or use the existing branch. I guess your chan...
Galya B
09:49 AM User Interface Feature #4854: origin affinity
Ok. In this case you should create a branch or use the existing branch. I guess your changes are base on 3931a.
...
Sergey Ivanovskiy
09:34 AM User Interface Feature #4854: origin affinity
Ah, that is. Yes, unfortunately there is no branch, only the diff. Galya B
09:33 AM User Interface Feature #4854: origin affinity
I did not find them because you did not commit them into the 3931a branch, correct? Sergey Ivanovskiy
02:49 AM User Interface Feature #4854: origin affinity
Sergey, you were able to miss this block of new code in the .diff?... Galya B
10:22 AM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
Committed on 7045b, revision 14681.
Because there are cases where an error still should be throw, I reintroduced ...
Eduard Soltan
09:08 AM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
Eduard, please make a separate issue for #7045-53 if this can be reproduced without 7045b changes. We need to focus o... Alexandru Lungu
01:59 AM User Interface Feature #4853: implement support for reporting a device-id which is meant to identify a unique cl...
https://github.com/fingerprintjs/fingerprintjs changed their license and their current version is under commercial li... Galya B

10/14/2023

06:32 AM Base Language Bug #7299: resolution of the target OO method in chained calls with poly arguments
Greg Shah wrote:
> It seems pretty safe. I'm OK with you merging to trunk.
I'll delay this until I get the custome...
Constantin Asofiei

10/13/2023

03:34 PM Base Language Bug #7299: resolution of the target OO method in chained calls with poly arguments
It seems pretty safe. I'm OK with you merging to trunk. Greg Shah
03:34 PM Base Language Bug #7299: resolution of the target OO method in chained calls with poly arguments
Code Review Task Branch 7299b Revison 14774
The change is good.
Greg Shah
01:38 PM Base Language Bug #7299: resolution of the target OO method in chained calls with poly arguments
There is a regression in the conversion of #7156 project: a LPARENS can enclose an argument. I've created 7299b from... Constantin Asofiei
12:27 PM User Interface Feature #4854: origin affinity
Galya B wrote:
> With the introduction of cross-document messaging between the wrapper container and the iframe do...
Sergey Ivanovskiy
09:36 AM User Interface Feature #4854: origin affinity
If @SsoAuthenticator@ related configs are not used, then all will go to the @"__default"@ key. If sso is enabled, dif... Galya B
09:34 AM User Interface Feature #4854: origin affinity
Good question. :) I modified the FWD code in @GuiWebDriver#init@ by adding at the end:... Galya B
09:27 AM User Interface Feature #4854: origin affinity
Galya, how did you test the new storage functionality? Sergey Ivanovskiy
11:18 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
I skimmed the changes in 6649b and they are quite robust. Well done!
There is a lot of documentation there, so from ...
Alexandru Lungu
10:22 AM Database Feature #4722 (Test): data import should be able to run with only the converted application jar f...
Roger Borrello
10:22 AM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
4722a was merged to trunk rev 14773 and archived. Roger Borrello
09:58 AM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
Please merge to trunk now. Greg Shah
09:32 AM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
Greg Shah wrote:
> Is there anything we need to handle from a project migration/cfg perspective when this is merged?...
Roger Borrello
09:27 AM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
> Is there anything we need to handle from a project migration/cfg perspective when this is merged?
Roger: Can you...
Greg Shah
09:18 AM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
Branch 4722a was rebased with trunk_14772 and is at revision 14790. Roger Borrello
10:11 AM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
During some investigation I came across @QueryConstants.RETRIEVE_MODES@ used in @CompoundQuery@.
I tried to call @...
Eduard Soltan
07:24 AM Database Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
Review:
* Add history numbers to @Validation@ (and all other classes that have changes on this branch exclusively ...
Alexandru Lungu
01:07 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
Refs #3931-457:
Greg Shah wrote:
> > Can we compile a list of authentication methods in OpenEdge 4GL that can be ...
Galya B
01:05 AM User Interface Feature #3931: single sign-on for virtual desktop mode
Constantin Asofiei wrote:
> Galya, full reconversion is required because progress.g adds a new token - this invalida...
Galya B

10/12/2023

04:55 PM User Interface Feature #3931: single sign-on for virtual desktop mode
> Can we compile a list of authentication methods in OpenEdge 4GL that can be applicable?
>
> I know only of @setu...
Greg Shah
12:35 PM User Interface Feature #3931: single sign-on for virtual desktop mode
Galya, full reconversion is required because progress.g adds a new token - this invalidates token IDs in schema AST f... Constantin Asofiei
08:00 AM User Interface Feature #3931: single sign-on for virtual desktop mode
The *migration plan* should assess the production / live system and answer several questions:
# Is @/embedded@ mod...
Galya B
03:39 PM User Interface Feature #4854: origin affinity
Sergey: Please review. Greg Shah
02:38 PM User Interface Bug #7879: Cursor isn't positioned right when FILL-IN split on multiple lines
There are two issues:
first - there is no label on initial screen, the issue is caused by a ScrollEvent sent when FI...
Tomasz Domin
10:26 AM User Interface Bug #7907: Browse row-leave handler not called after apply entry in FWD
Greg Shah wrote:
> Is this intended to be a generic bug or does this need to be moved into a customer project?
A ge...
Yuriy Volyanskyy
09:36 AM User Interface Bug #7907: Browse row-leave handler not called after apply entry in FWD
Is this intended to be a generic bug or does this need to be moved into a customer project?
Is this related to any...
Greg Shah
09:35 AM User Interface Bug #7907: Browse row-leave handler not called after apply entry in FWD
From Yuriy:
I made a unit test that works in OE but fails in FWD. Please see the attached file. It expects row-lea...
Greg Shah
09:27 AM User Interface Bug #7907 (New): Browse row-leave handler not called after apply entry in FWD
Yuriy Volyanskyy

10/11/2023

09:55 AM User Interface Feature #3931: single sign-on for virtual desktop mode
Greg Shah wrote:
> > Virtual desktop and embedded use the same resource for the login page. It is overridden in hote...
Galya B
08:52 AM User Interface Feature #3931: single sign-on for virtual desktop mode
> Virtual desktop and embedded use the same resource for the login page. It is overridden in hotel_gui to have the pr... Greg Shah
08:01 AM User Interface Feature #3931: single sign-on for virtual desktop mode
3931a rebased on trunk r14770. Galya B
07:37 AM User Interface Feature #3931: single sign-on for virtual desktop mode
Constantin Asofiei wrote:
> * finish the sample SSO for Hotel GUI, and make sure it works for both embedded and norm...
Galya B
06:32 AM User Interface Feature #3931: single sign-on for virtual desktop mode
Constantin Asofiei wrote:
> * finish the documentation: all new directory/bootstrap config options need to be docume...
Galya B
05:17 AM User Interface Feature #3931: single sign-on for virtual desktop mode
Galya, I think 3931a rev 14791 is OK. What needs to be done before merging this to trunk:
* rebase 3931a
* finish ...
Constantin Asofiei
08:09 AM User Interface Bug #7879: Cursor isn't positioned right when FILL-IN split on multiple lines
Greg Shah wrote:
> Is wrapping even a valid ChUI use case?
I can't tell. But OE allows it.
Hynek Cihlar
07:51 AM User Interface Bug #7879: Cursor isn't positioned right when FILL-IN split on multiple lines
Is wrapping even a valid ChUI use case? Greg Shah
02:47 AM User Interface Bug #7879: Cursor isn't positioned right when FILL-IN split on multiple lines
FWD after entering single character:... Tomasz Domin
02:15 AM User Interface Bug #7879: Cursor isn't positioned right when FILL-IN split on multiple lines

4gl - screen when fill-in has no characters...
Tomasz Domin
07:54 AM Base Language Bug #7299 (Test): resolution of the target OO method in chained calls with poly arguments
Greg Shah
03:19 AM Base Language Bug #7299: resolution of the target OO method in chained calls with poly arguments
7299a was merged to trunk rev 14770 and archived. Constantin Asofiei
05:21 AM Database Feature #7416 (Review): Reiterate DatabaseStatistics and leverage to other database profling tools
Radu Apetrii
05:21 AM Database Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
I've done another commit in which I've fixed some of the things that I noticed during the "rereview":
* There was a ...
Radu Apetrii
03:22 AM Database Feature #6720: lazy hydration
Eric, I prepared some questions here last week, but it seems I missed submitting them. I was kind of waiting for feed... Alexandru Lungu
01:47 AM User Interface Feature #4517 (WIP): optionally back the 4GL features for Registry access with the user-specific ...
Galya B

10/10/2023

03:17 PM Base Language Bug #7299: resolution of the target OO method in chained calls with poly arguments
Code Review Task Branch 7299a Revisions 14777 through 14784
No objections.
You can merge to trunk.
Greg Shah
12:51 PM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
Branch 4722a was rebased with trunk_14769 and is at revision 14787. I committed an update to @import.sh@ which change... Roger Borrello
10:14 AM User Interface Feature #4854 (Review): origin affinity
Solution attached as .diff based on latest 3931a r14791. Tested in Virtual Desktop mode (regular and auto login) and ... Galya B
08:33 AM Base Language Feature #3855: implement equivalent support for REST (classic appserver, PASOE REST and WEB trans...
We have customer test environments that are 11.x so we can still access classic appserver for testing. Would that he... Greg Shah
02:28 AM Base Language Feature #3855: implement equivalent support for REST (classic appserver, PASOE REST and WEB trans...
Greg Shah wrote:
> What parts of #3855-102 remain to be completed?
>
> Where are we with the testcases?
I thin...
Marian Edu
08:31 AM Base Language Feature #4658: OO serialization support
> the object has no control of how it's data is being serialised, other than defining what is/isn't serialisable
P...
Greg Shah
02:13 AM Base Language Feature #4658: OO serialization support
Greg Shah wrote:
> Marian: Do you know of any such feature (like Java's @Externalizable@) in the 4GL?
The keyword...
Marian Edu
08:24 AM Base Language Feature #3310 (Closed): add support for the equivalent of the OpenEdge Web Services Adapter (and ...
Greg Shah
02:12 AM Base Language Feature #3310: add support for the equivalent of the OpenEdge Web Services Adapter (and ProxyGen)...
Greg Shah wrote:
> Is there anything left to do on this task?
I don't think so.
Constantin Asofiei
07:27 AM Database Feature #7416 (WIP): Reiterate DatabaseStatistics and leverage to other database profling tools
I tried to run @./gradlew.all@ in the 7416b branch, but I've encountered some errors. Thus, I've committed to 7416b, ... Radu Apetrii
05:28 AM User Interface Bug #7879 (WIP): Cursor isn't positioned right when FILL-IN split on multiple lines
Tomasz Domin
03:49 AM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
Eduard, 7045b is in a "protoype" stage. There may be multiple such issues with it. In fact, the (first) implementatio... Alexandru Lungu
03:41 AM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
There is a problem with current implementation on 7045b.... Eduard Soltan

10/09/2023

03:54 PM Base Language Feature #4658: OO serialization support
> > > And here it shows that OE can have custom serializers: https://programinprogress.com/object-serialization-in-p... Greg Shah
02:46 PM Base Language Feature #4658: OO serialization support
Greg Shah wrote:
> > And here it shows that OE can have custom serializers: https://programinprogress.com/object-se...
Constantin Asofiei
02:21 PM Base Language Feature #4658: OO serialization support
> And here it shows that OE can have custom serializers: https://programinprogress.com/object-serialization-in-progr... Greg Shah
03:51 PM Base Language Feature #3310: add support for the equivalent of the OpenEdge Web Services Adapter (and ProxyGen)...
Is there anything left to do on this task? Greg Shah
02:43 PM Base Language Feature #3310: add support for the equivalent of the OpenEdge Web Services Adapter (and ProxyGen)...
Greg Shah wrote:
> Is the "qualified prefixing" feature from #3310-93 the only remaining feature? I'm trying to und...
Constantin Asofiei
02:38 PM Base Language Feature #3310: add support for the equivalent of the OpenEdge Web Services Adapter (and ProxyGen)...
Is the "qualified prefixing" feature from #3310-93 the only remaining feature? I'm trying to understand what is left... Greg Shah
03:49 PM Base Language Feature #3854 (Closed): update appserver support with PASOE features
Greg Shah
02:36 PM Base Language Feature #3854: update appserver support with PASOE features
Greg Shah wrote:
> Is there any reason to leave this task open? As far as I understand it, all the remaining work i...
Constantin Asofiei
02:35 PM Base Language Feature #3854: update appserver support with PASOE features
Is there any reason to leave this task open? As far as I understand it, all the remaining work is in #6417. Greg Shah
02:42 PM Base Language Feature #3855: implement equivalent support for REST (classic appserver, PASOE REST and WEB trans...
What parts of #3855-102 remain to be completed?
Where are we with the testcases?
Greg Shah
09:22 AM Base Language Bug #7299 (Review): resolution of the target OO method in chained calls with poly arguments
Greg, please review 7299a starting from rev 14777 to 14784 (i.e. compared with 14776, the last reviewed revision).
...
Constantin Asofiei
04:47 AM User Interface Feature #4854: origin affinity

|WebSocket Event | Event Type ID | Description | localStorage access | Response WS msg | GuiWebSocket method |
...
Galya B

10/08/2023

06:45 AM User Interface Feature #3931: single sign-on for virtual desktop mode
I've committed r14788 - r14791 with improvements to @fwd_sdk.js@: documentation on functions and an exposed @sendAuth... Galya B
01:01 AM User Interface Feature #3931: single sign-on for virtual desktop mode
The question is if there are customers using any 4GL methods like @setuserid@ for login page authentication: in-app c... Galya B
01:24 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
4GL methods used by customers to authenticate in-app user & pass on login screens need to be provided in FWD for use ... Galya B
01:07 AM User Interface Feature #7884 (WIP): Standard 4GL methods used for login screen authentication to be exposed in s...
Galya B

10/07/2023

01:57 PM Base Language Bug #7299: resolution of the target OO method in chained calls with poly arguments
7299a was rebased and rev 14777/14778 contains fixes to add @ObjectOps.poly(Object)Arg@ wrapper for cases when a dire... Constantin Asofiei
09:23 PM User Interface Feature #3931: single sign-on for virtual desktop mode
Galya B wrote:
> But when duplicating the logic from @ConnectionManager.authenticate()@, I've noticed that the query...
Ovidiu Maxiniuc

10/06/2023

12:17 PM Base Language Feature #6431: implement support to allow CPINTERNAL set to UTF-8 and CP936
> As far as I understand, using @-cprcodein UTF-8@ tells OE that the source file should be read as UTF-8.
No, I do...
Greg Shah
12:10 PM Base Language Feature #6431: implement support to allow CPINTERNAL set to UTF-8 and CP936
Greg Shah wrote:
> Are all your notes from #6431-13 based on OE testing? I don't want to mix any FWD results togeth...
Theodoros Theodorou
12:03 PM Base Language Feature #6431: implement support to allow CPINTERNAL set to UTF-8 and CP936
Ovidiu Maxiniuc wrote:
> Indeed, this is tricky. I think this is the first time I see @-cprcodein@ OE parameter. If ...
Theodoros Theodorou
09:05 AM Base Language Feature #6431: implement support to allow CPINTERNAL set to UTF-8 and CP936
Are all your notes from #6431-13 based on OE testing? I don't want to mix any FWD results together at this point, it... Greg Shah
10:37 AM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
Eduard, please focus on this task for the upcoming Sprint.
There is a lot of information here, so feel free to ask...
Alexandru Lungu
10:09 AM User Interface Feature #3931: single sign-on for virtual desktop mode
I imagine after merging 3931a, we'll focus on closing #4571 and #7067, and after that formulate the new requirements ... Galya B
10:03 AM User Interface Feature #3931: single sign-on for virtual desktop mode
Greg Shah wrote:
> I'm not opposed to doing this in the next set of changes (which have to be completed quickly anyw...
Galya B
09:54 AM User Interface Feature #3931: single sign-on for virtual desktop mode
I'm not opposed to doing this in the next set of changes (which have to be completed quickly anyway due to customer d... Greg Shah
09:33 AM User Interface Feature #3931: single sign-on for virtual desktop mode
Can we compile a list of authentication methods in OpenEdge 4GL that can be applicable?
I know only of @setuserid@...
Galya B
09:23 AM User Interface Feature #3931: single sign-on for virtual desktop mode
For this use case where the original code was using 4GL features for database authentication, I think we should imple... Greg Shah
04:02 AM User Interface Feature #3931: single sign-on for virtual desktop mode
Ovidiu, a little bit of context:
@SsoAuthenticator@ is an interface for implementation by the customer with custom...
Galya B
09:45 PM User Interface Feature #3931: single sign-on for virtual desktop mode
I do not have a solution currently. Just some notes, until I read the whole thread and get a better understanding of ... Ovidiu Maxiniuc
09:07 AM Database Feature #7416: Reiterate DatabaseStatistics and leverage to other database profling tools
Alexandru Lungu wrote:
> Radu, please rebase 7416b to the latest trunk. "Rereview" the changes and test them with a ...
Radu Apetrii
06:27 AM Database Feature #7416 (Review): Reiterate DatabaseStatistics and leverage to other database profling tools
Radu, please rebase 7416b to the latest trunk. "Rereview" the changes and test them with a project you already have i... Alexandru Lungu
08:36 AM User Interface Bug #7879: Cursor isn't positioned right when FILL-IN split on multiple lines
See the following test case. Run it and fill the fill-in so that the cursor wraps to the next line. Observe the unexp... Hynek Cihlar
08:34 AM User Interface Bug #7879 (WIP): Cursor isn't positioned right when FILL-IN split on multiple lines
Hynek Cihlar

10/05/2023

06:44 PM Base Language Feature #6431: implement support to allow CPINTERNAL set to UTF-8 and CP936
Indeed, this is tricky. I think this is the first time I see @-cprcodein@ OE parameter. If I understand this paramete... Ovidiu Maxiniuc
06:27 PM Base Language Feature #6431: implement support to allow CPINTERNAL set to UTF-8 and CP936
I need help for understanding what needs to be done. Codepages look very tricky. Progress OE returns unexpected resul... Theodoros Theodorou
12:40 PM User Interface Feature #3931: single sign-on for virtual desktop mode
Ovidiu: Can you please review starting at #3931-430 and advise? With this task we are moving Hotel GUI away from 4GL... Greg Shah
12:35 PM User Interface Feature #3931: single sign-on for virtual desktop mode
P.S. @HotelGuiSsoAuthenticator.java@ seems to have to be placed in @embedded/src/com/goldencode/hotel@, but it will g... Galya B
12:29 PM User Interface Feature #3931: single sign-on for virtual desktop mode
I still don't know the answer of the last question, but what I can do on hotel_gui is done. The @SsoAuthenticator@ im... Galya B
06:22 AM User Interface Feature #3931: single sign-on for virtual desktop mode
I see @ConnectionManager@ tries to be smart and find the column names for user / pass based on @com.goldencode.p2j.pe... Galya B
06:19 AM User Interface Feature #3931: single sign-on for virtual desktop mode
The user password has to be encoded, the result is found. Galya B
06:04 AM User Interface Feature #3931: single sign-on for virtual desktop mode
I created a simple jdbc connection in the authenticator, but @SELECT COUNT(*) FROM meta_user@ returns 0. When is @met... Galya B
05:16 AM User Interface Feature #3931: single sign-on for virtual desktop mode
Where is the @meta_user@ table, where is the h2 db - the file @hotel_gui/deploy/db/hotel.h2.db@ seems empty. Is there... Galya B
03:12 AM User Interface Feature #3931: single sign-on for virtual desktop mode
For the hotel_gui authenticator there should be a connection to the DB and then @SecurityOps.setUserId(username, pass... Galya B
02:14 AM User Interface Feature #3931: single sign-on for virtual desktop mode
I'll do the review first and will keep the rebase when we are close to merge (as I assume it can be kind of difficult... Constantin Asofiei
02:03 AM User Interface Feature #3931: single sign-on for virtual desktop mode
Do I rebase and we do the final review?
Login / logout pages are not translated. That can go under #4762 or #7814....
Galya B
06:26 AM Base Language Bug #7873 (Test): conversion issues with dataset/table parameters for class events
Greg Shah
06:18 AM Base Language Bug #7873: conversion issues with dataset/table parameters for class events

7873a was merged to trunk rev 14767 and archived.
Constantin Asofiei
06:11 AM Base Language Bug #7873: conversion issues with dataset/table parameters for class events
Go ahead. Greg Shah
01:15 AM Base Language Bug #7873: conversion issues with dataset/table parameters for class events
Greg Shah wrote:
> What testing do you plan?
I've left overnight conversion for some projects and the result is OK....
Constantin Asofiei
05:54 AM Database Bug #7776 (Review): Previous regression on FWD-H2 lazy mode
This was merged to FWD-H2 trunk as rev. 28 and reached trunk as fwd-h2-1.31-trunk. Alexandru Lungu

10/04/2023

06:23 PM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
Branch 4722a was rebased with trunk_14766 and is at revision 14783. Roger Borrello
04:13 PM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
Ovidiu Maxiniuc wrote:
> I re-reviewed the changes and only have only one question: there are some commits with no f...
Roger Borrello
03:41 PM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
Yes.
I re-reviewed the changes and only have only one question: there are some commits with no file changes (14781, ...
Ovidiu Maxiniuc
08:28 AM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
Ovidiu: Are you OK with merging? Greg Shah
08:26 AM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
Greg Shah wrote:
> Are these changes safe to merge now?
>
> Is there anything we need to handle from a project mi...
Roger Borrello
07:55 AM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
Are these changes safe to merge now?
Is there anything we need to handle from a project migration/cfg perspective ...
Greg Shah
05:50 PM Base Language Feature #7875: Interactive child process launching is broken in GUI
A good amount of background can be found in #7676. Make sure to go through it first.
This required a simple testc...
Roger Borrello
03:55 PM Base Language Feature #7875 (New): Interactive child process launching is broken in GUI
Roger Borrello
04:29 PM Base Language Bug #7873: conversion issues with dataset/table parameters for class events
Code Review Task Branch 7873a Revision 14767
I'm fine with the changes.
What testing do you plan?
Greg Shah
01:45 PM Base Language Bug #7873 (Review): conversion issues with dataset/table parameters for class events
I've added support for DATASET, TABLE, DATASET-HANDLE, TABLE-HANDLE and BUFFER parameters for class events in 7873a r... Constantin Asofiei
10:19 AM Base Language Bug #7873 (WIP): conversion issues with dataset/table parameters for class events
Created task branch 7873a from trunk rev 14766. Constantin Asofiei
10:19 AM Base Language Bug #7873: conversion issues with dataset/table parameters for class events
FWD has problems converting class events with TABLE/DATASET parameters. This issue is meant to explore and fix all p... Constantin Asofiei
10:18 AM Base Language Bug #7873 (Test): conversion issues with dataset/table parameters for class events
Constantin Asofiei
01:27 PM User Interface Feature #3931: single sign-on for virtual desktop mode
I pushed small, but important fix for embedded handlers in r14786. To serve the hotel_gui login page as before, on to... Galya B
07:44 AM User Interface Feature #3931: single sign-on for virtual desktop mode
We're not removing @RemoteLaunchOptionRightsEditor@ and related code now, although it won't have any effect. I heard ... Galya B
06:28 AM User Interface Feature #3931: single sign-on for virtual desktop mode
Done in r14784. Galya B
05:38 AM User Interface Feature #3931: single sign-on for virtual desktop mode
Galya, go ahead and remove the @RemoteObject.registerStaticNetworkServer@ code for @WebClientLauncher@ in @StandardSe... Constantin Asofiei
05:44 AM Base Language Feature #6410: implement additional built-in OO classes/interfaces
Marian, I think we need 'invokeStandalone' to be emitted when the returned value is not read and 'invoke' in all othe... Constantin Asofiei

10/03/2023

06:33 PM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
Branch was rebased to trunk 14764 and is at revision 14781. Roger Borrello
10:32 AM User Interface Feature #3931: single sign-on for virtual desktop mode
I'm against having the remote interface, because it will break any of the enhancements to the wrapper container I'm g... Galya B
09:56 AM User Interface Feature #3931: single sign-on for virtual desktop mode
> > Why not remove remote launching?
> This will make it mandatory to run any embedded web app from within the FWD S...
Greg Shah
04:05 AM User Interface Feature #3931: single sign-on for virtual desktop mode
I've added the section [[p2j:Single_Sign_On#Enforcing-Licensing-Policies|Enforcing Licensing Policies]]. I think it c... Galya B
03:21 AM User Interface Feature #3931: single sign-on for virtual desktop mode
Auto-login session expiration is driven by the 3rd party authentication server / directory. Adding Sign Out button on... Galya B
03:20 AM User Interface Feature #3931: single sign-on for virtual desktop mode
Constantin Asofiei wrote:
> Galya B wrote:
> > What do you mean by that? Notify the authenticator of the server bei...
Galya B
03:13 AM User Interface Feature #3931: single sign-on for virtual desktop mode
Galya B wrote:
> What do you mean by that? Notify the authenticator of the server being started to allow it cleanup ...
Constantin Asofiei
01:27 AM User Interface Feature #3931: single sign-on for virtual desktop mode
Constantin Asofiei wrote:
> Galya: I think we need to change the javadoc for @EmbeddedWebHandler.spawn@ and @WebClie...
Galya B
08:16 AM Base Language Feature #6410: implement additional built-in OO classes/interfaces
Working on remaining issues on method @invoke@ and beside the known issue with @return extent@ I have a situation tha... Marian Edu

10/02/2023

12:58 PM User Interface Feature #3931: single sign-on for virtual desktop mode
Constantin Asofiei wrote:
> Greg Shah wrote:
> > Why not remove remote launching?
> This will make it mandatory to...
Constantin Asofiei
12:45 PM User Interface Feature #3931: single sign-on for virtual desktop mode
Greg Shah wrote:
> Why not remove remote launching?
This will make it mandatory to run any embedded web app from wi...
Constantin Asofiei
12:43 PM User Interface Feature #3931: single sign-on for virtual desktop mode
> *Greg*: we have also the OS user configured for launching batch programs or appservers. This is done via @clientCo... Greg Shah
11:57 AM User Interface Feature #3931: single sign-on for virtual desktop mode
Galya B wrote:
> Constantin Asofiei wrote:
> > * @SecurityManager.removeContext@ needs implementation.
>
> I tri...
Constantin Asofiei
11:34 AM User Interface Feature #3931: single sign-on for virtual desktop mode
Constantin Asofiei wrote:
> * @SecurityManager.removeContext@ needs implementation.
I tried everything and nothin...
Galya B
10:21 AM User Interface Feature #3931: single sign-on for virtual desktop mode
Also, on the logout page there could be a second button called "Sign out", only when auto-login is enabled in the @Ss... Galya B
10:15 AM User Interface Feature #3931: single sign-on for virtual desktop mode
I would like to know the opinion of the customers who would implement auto-login, because it's very specific.
But ...
Galya B
09:53 AM User Interface Feature #3931: single sign-on for virtual desktop mode
Galya, I agree about the @trustedspawner@ - you are correct, the FWD user can have its own OS user and we can conside... Constantin Asofiei
09:09 AM User Interface Feature #3931: single sign-on for virtual desktop mode
Constantin Asofiei wrote:
> *Remote Launching*
>
> The discussion is mainly that for normal SSO spawning, we requ...
Galya B
08:52 AM User Interface Feature #3931: single sign-on for virtual desktop mode
More on the topic of sessions:
* FWD sessions: number of live sessions and their type (forked, same browser, etc), w...
Galya B
08:46 AM User Interface Feature #3931: single sign-on for virtual desktop mode
Ah, I think what's confusing at the moment with the dummy @SsoAuthenticator@ and hotel gui is that the authenticator ... Galya B
08:42 AM User Interface Feature #3931: single sign-on for virtual desktop mode
Constantin Asofiei wrote:
> Review for 3931a rev 14781.
Up in r14782: Admin console fixes and improvements; ENTER...
Galya B
02:24 AM User Interface Feature #3931: single sign-on for virtual desktop mode
Review for 3931a rev 14781.
*Admin Console - OS User*
* editing an OS user:
** does not load the Description
**...
Constantin Asofiei
12:53 PM Database Feature #6720: lazy hydration
Task branch 6720b has been rebased to trunk rev 14762. New 6720b revision is 14766.
Alexandru, please review the c...
Eric Faulhaber
10:44 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
*Committed 6649b/rev.14742*.
* Added r-code file searching;
* Modified @PathLookup@ into an interface;
* Short-cir...
Dănuț Filimon
08:17 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
By removing unnecessary files from the lookup (files with an extension that don't match any legacy program name exten... Dănuț Filimon
04:40 AM Database Bug #7667: Support OUTER-JOIN with PRESELECT at conversion
I retested the testcase from #6196-47, but instead of @for each@ I used @preselect each@.
Without the changes from #...
Andrei Bălteanu

09/29/2023

07:15 PM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
Branch 4722a has been rebased to trunk_14758 at revision 14775. Roger Borrello
05:07 PM Base Language Bug #7299: resolution of the target OO method in chained calls with poly arguments
Code Review Task Branch 7299a Revisions 14756 through 14763
Overall, it looks good. The refactoring made the revi...
Greg Shah
12:33 PM Base Language Bug #5538 (Closed): fix readByte() for DirStream, ProcessStream, and others
Greg Shah
12:33 PM Base Language Bug #5538: fix readByte() for DirStream, ProcessStream, and others
Branch 5538a was merged to trunk rev. 14758 and archived. Theodoros Theodorou
11:16 AM Base Language Bug #5538: fix readByte() for DirStream, ProcessStream, and others
You can merge to trunk now.
Should we set %Done to 100?
Greg Shah
11:15 AM Base Language Bug #5538: fix readByte() for DirStream, ProcessStream, and others
Code Review Task Branch 5538a Revision 14758
No objections.
Greg Shah
10:06 AM Database Bug #7667 (WIP): Support OUTER-JOIN with PRESELECT at conversion
The branch 7667a was created to solve a problem related to a *run-time* optimization. This was not the initial purpos... Andrei Bălteanu
09:58 AM Database Bug #7667: Support OUTER-JOIN with PRESELECT at conversion
What is the % Done on this task? Greg Shah
09:51 AM Database Bug #7667: Support OUTER-JOIN with PRESELECT at conversion
Branch 7667a was merged to trunk rev. 14757 and archived. Alexandru Lungu
09:46 AM Database Bug #7667: Support OUTER-JOIN with PRESELECT at conversion
You can merge 7667a now. Greg Shah
06:59 AM Database Bug #7667: Support OUTER-JOIN with PRESELECT at conversion
Andrei, I am OK with the changes. Still, @isConstant@ is not "integrated" into the mainWalk - there are still two wal... Alexandru Lungu
04:57 AM Database Bug #7667: Support OUTER-JOIN with PRESELECT at conversion
Sure thing!
Committed the changes on 7667a revision 14760.
Andrei Bălteanu
02:35 AM Database Bug #7667: Support OUTER-JOIN with PRESELECT at conversion
Andrei, please address #7667-19 asap (including the move of your code in @mainWalk@ to avoid extra AST traversals). A... Alexandru Lungu
09:46 AM User Interface Bug #7856: Improve parsing of specifications from ini files
Work in #7784 improved the parsing of font specifications such that spaces are also treated as separators (along with... Alexandru Lungu
09:41 AM User Interface Bug #7856 (New): Improve parsing of specifications from ini files
Alexandru Lungu
09:43 AM Base Language Feature #6410: implement additional built-in OO classes/interfaces
> what needs to be done beside finishing the method/invoke support.
Please do implement all the remaining items a...
Greg Shah
06:15 AM Base Language Feature #6410: implement additional built-in OO classes/interfaces
Constantin Asofiei wrote:
> Created task branch 6410b from trunk rev 14756.
>
> The branch is available on xfer.
...
Marian Edu
04:59 AM Base Language Feature #6410: implement additional built-in OO classes/interfaces
Created task branch 6410b from trunk rev 14756.
The branch is available on xfer.
Constantin Asofiei
04:04 AM Base Language Feature #6410: implement additional built-in OO classes/interfaces
Greg Shah wrote:
> In addition to the remaining items in @getMethods()@, what work is left from #6410-1?
As far a...
Marian Edu
06:58 AM Database Bug #7855: Integrate fixEmptyContains into mainWalk at FQL preprocessing
There is another AST traversal done in @fixEmptyContains@ which can be integrated into @mainWalk@ for further perform... Alexandru Lungu
06:58 AM Database Bug #7855 (New): Integrate fixEmptyContains into mainWalk at FQL preprocessing
Alexandru Lungu

09/28/2023

05:12 PM Database Bug #7667: Support OUTER-JOIN with PRESELECT at conversion
Branch 7667 has been rebased to trunk_14756. Roger Borrello
11:05 AM Database Bug #7667: Support OUTER-JOIN with PRESELECT at conversion
Andrei Bălteanu wrote:
> Regarding the problem from #7667-9, I was thinking about the following changes:
> [...]
>...
Eric Faulhaber
10:49 AM Database Bug #7667: Support OUTER-JOIN with PRESELECT at conversion
Code review 7667a/14757:
The logic looks good. A few minor issues:
* Please avoid using the @for-each@ syntax w...
Eric Faulhaber
09:26 AM Database Bug #7667 (Review): Support OUTER-JOIN with PRESELECT at conversion
I'm having a look... Eric Faulhaber
08:40 AM Database Bug #7667: Support OUTER-JOIN with PRESELECT at conversion
Alexandru Lungu wrote:
> Note that this task is about conversion support, so 7667a is not going to address the task,...
Igor Skornyakov
08:27 AM Database Bug #7667: Support OUTER-JOIN with PRESELECT at conversion
Note that this task is about conversion support, so 7667a is not going to address the task, but only fix a run-time r... Alexandru Lungu
06:30 AM Database Bug #7667: Support OUTER-JOIN with PRESELECT at conversion
Modified accordingly.
There was also a parameter out of line and i fixed that too (cheers to Radu for the heads up)...
Andrei Bălteanu
05:44 AM Database Bug #7667: Support OUTER-JOIN with PRESELECT at conversion
Review of 7667a:
* Fix history entry of @CompoundQuery@ (AB is on a different line than the entry description)
* Re...
Alexandru Lungu
04:52 AM Database Bug #7667: Support OUTER-JOIN with PRESELECT at conversion
Regarding the problem from #7667-9, I was thinking about the following changes:... Andrei Bălteanu
05:09 PM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
Branch 4722a has been rebased to trunk_14756. Roger Borrello
03:28 PM Base Language Bug #5538: fix readByte() for DirStream, ProcessStream, and others
Ovidiu Maxiniuc wrote:
> There are minor changes (only some comments) since my last review. One thing which I failed...
Theodoros Theodorou
09:28 AM Base Language Bug #5538: fix readByte() for DirStream, ProcessStream, and others
Code Review Task Branch 5538a Revision 14756
It seems like we could rewrite the @@ as follows:...
Greg Shah
12:24 PM Base Language Bug #7299: resolution of the target OO method in chained calls with poly arguments
Constantin Asofiei wrote:
> ... At least, 'exact method matching' must be done in the entire hierarchy, before goin...
Constantin Asofiei
11:57 AM Base Language Bug #7299: resolution of the target OO method in chained calls with poly arguments
The current changes are in 7299a rev 14758. I'll reconvert some projects and check real scenarios.
This adds @Obj...
Constantin Asofiei
11:27 AM Base Language Bug #7299: resolution of the target OO method in chained calls with poly arguments
Constantin Asofiei wrote:
> My assumption is that @h::f3@ doesn't set the type of the object returned (which would b...
Constantin Asofiei
11:25 AM Base Language Bug #7299: resolution of the target OO method in chained calls with poly arguments
There is something which looks like a bug in the OpenEdge method resolution. Assume there is a method like this:
<p...
Constantin Asofiei
07:06 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
If the more generic approach of #6649-17 is still too costly, then we can certainly put some logic in to check for th... Greg Shah
06:55 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
But wouldn't it be faster to rule out such searches based on the file extension? Since the original lookup is done on... Dănuț Filimon
06:27 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
This is exactly the kind of thing that the idea in #6649-17 would optimize. There will be no @whatever.bmp@ in the m... Greg Shah
06:21 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
Greg Shah wrote:
> These are all coming from @RUN@ statements?
No, I've looked up where a .bmp file is used and it ...
Dănuț Filimon
06:16 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
Lookup on the PROPATH can be done via the SEARCH function and IIRC even by runtime (i.e. when resolving images or ini... Constantin Asofiei
06:13 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
These are all coming from @RUN@ statements? Greg Shah
06:12 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
Alexandru Lungu wrote:
> Danut, can you share some of these extensions and the context in which they are required? I...
Dănuț Filimon
05:59 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
Danut, can you share some of these extensions and the context in which they are required? I mean, what kind of files ... Alexandru Lungu
04:06 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
I've noticed something for a while, but I am only bringing this up now because it might be important. While doing the... Dănuț Filimon

09/27/2023

07:58 PM Base Language Bug #5538 (Test): fix readByte() for DirStream, ProcessStream, and others
Review branch 5538a / 14756.
There are minor changes (only some comments) since my last review. One thing which I ...
Ovidiu Maxiniuc
08:54 AM Base Language Bug #5538: fix readByte() for DirStream, ProcessStream, and others
Ovidiu: Please review. Greg Shah
08:52 AM Base Language Bug #5538: fix readByte() for DirStream, ProcessStream, and others
Please review branch 5538a rev no 14756. It has been rebased to trunk. Theodoros Theodorou
03:51 PM Conversion Tools Feature #7851: automatically add to conversion list all classes referenced via unit test suite an...
The ABLUnit/OEUnit @@TestSuite@ annotation lists classes that are to be executed as part of the suite. We will make ... Greg Shah
03:50 PM Conversion Tools Feature #7851 (Closed): automatically add to conversion list all classes referenced via unit test...
Greg Shah
03:43 PM Testing Support #7850 (New): questions and answers about ABLUnit support in FWD
Greg Shah
01:37 PM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
The benefit of the @build_db.xml@ is it falls right in line with the @ant@ build of the application and provides a le... Roger Borrello
01:25 PM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
I'm good with that idea. Greg Shah
12:44 PM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
I am not aware of any open issues here.
When I first created the @import.sh@ my intention was to have a faster way...
Ovidiu Maxiniuc
12:23 PM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
For Hotel GUI/ChUI, I would expect that the standard projects might be simplified to some degree and I would expect t... Greg Shah
08:12 AM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
Greg Shah wrote:
> Roger: What is the migration plan? There are changes to apply for both Hotel projects? What abo...
Roger Borrello
07:40 AM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
Igor/Ovidiu/Eric: Any objections or known open items?
Roger: What is the migration plan? There are changes to app...
Greg Shah
10:12 AM Database Bug #7797: FWD-H2 LAZY reverse index regression
Sounds good. Eric will handle the push when you are ready. Greg Shah
09:04 AM Database Bug #7797: FWD-H2 LAZY reverse index regression
I would like to have 7789a_h2 merged as well, before the upgrade. I finished the implementation (going to update #778... Alexandru Lungu
08:03 AM Database Bug #7797: FWD-H2 LAZY reverse index regression
Is this ready to be deployed on @proj.goldencode.com@? If so, is it safe to push it with the current version of trunk? Greg Shah
05:44 AM Database Bug #7797 (Test): FWD-H2 LAZY reverse index regression
Alexandru Lungu
05:43 AM Database Bug #7797 (Review): FWD-H2 LAZY reverse index regression
I am OK with the changes in 7066c_h2.
I also changed the planner a bit to score more the indexes that are reversed i...
Alexandru Lungu
07:42 AM Base Language Feature #7842: Make FWD behave the same as OE regarding input through
Please recall that we never use the Description field of the Redmine header. The task details always go into the fir... Greg Shah
03:04 AM Database Feature #6720: lazy hydration
This entry is intended to document the prototype implementation of lazy hydration in 6720b/14632-14634: what is imple... Eric Faulhaber

09/26/2023

07:32 PM User Interface Bug #7824 (Review): Simplify idle connection settings and apply the default configuration for the...
Committed rev 14754 (7824a). This version should simplify debugging. Sergey Ivanovskiy
06:07 PM Database Bug #7667: Support OUTER-JOIN with PRESELECT at conversion
Branch 7667a has been rebased to the latest trunk (14754). Roger Borrello
04:46 AM Database Bug #7667: Support OUTER-JOIN with PRESELECT at conversion
Thanks for the review!
Modified accordingly and committed to 7667a revision 14753.
Andrei Bălteanu
05:52 PM Base Language Feature #7842 (New): Make FWD behave the same as OE regarding input through
Theodoros Theodorou
05:51 PM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
Branch 4722a has been rebased to the latest trunk (14754).
Is there anything keeping this from being merged with t...
Roger Borrello
02:40 PM Conversion Tools Feature #7180: create a centralized manager for the conversion list and per-file/project status a...
Branch 7180a rebased from trunk 14754. Greg Shah
11:12 AM Base Language Bug #5538: fix readByte() for DirStream, ProcessStream, and others
Theodoros Theodorou wrote:
> Ok. Should we close this ticket? Should we create another ticket for implementing the s...
Greg Shah
11:06 AM Base Language Bug #5538: fix readByte() for DirStream, ProcessStream, and others
Ok. Should we close this ticket? Should we create another ticket for implementing the same behavior with OE? Is the i... Theodoros Theodorou
09:28 AM Base Language Feature #6410: implement additional built-in OO classes/interfaces
In addition to the remaining items in @getMethods()@, what work is left from #6410-1? Greg Shah
05:46 AM Base Language Feature #6410: implement additional built-in OO classes/interfaces
Constantin Asofiei wrote:
> Branch 6410a was merged to trunk rev 14751 and archived.
>
> Marian: please let us kn...
Marian Edu
09:24 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
I've committed the implementation to -*6649a/rev.14741*- *6649b/rev.14741*. Please review and advise.
* propath can ...
Dănuț Filimon
08:38 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
> _The PROPATH may be found is in the file name (from name-map.xml)_, not in the search spec.
Yes, but a propath ...
Greg Shah
08:31 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
I retested #6649-30 using the new implementation and I got a total of *38119* calls to the new @SourceNameMapper.conv... Dănuț Filimon
05:36 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
I think we can agree that the extension topic is fully understood now.
> Can you help me understand what you mean ...
Alexandru Lungu
09:06 AM Database Bug #7841: Invalid conversion of temp table DMO when using clob/blob fields
Sorry, there is a typo in the file @start.p@, where I forgot to rename the procedure @atable-clob.p@ to @table-clob.p... Alexandru Donica
08:57 AM Database Bug #7841: Invalid conversion of temp table DMO when using clob/blob fields
I created 2 temp tables, in separate procedures, with the same table name, same field types with same field names, bu... Alexandru Donica
08:51 AM Database Bug #7841 (Test): Invalid conversion of temp table DMO when using clob/blob fields
Alexandru Donica
04:45 AM Database Bug #7797: FWD-H2 LAZY reverse index regression
I've addressed the review from the previous post and committed the changes to 7066c_h2, rev. 31.
> * Why is @curre...
Radu Apetrii

09/25/2023

05:32 PM Base Language Bug #5538: fix readByte() for DirStream, ProcessStream, and others
Although the natural instinct is to create good code, which behaves as one would expect (in this case to fully popula... Ovidiu Maxiniuc
05:23 PM Base Language Bug #5538 (Review): fix readByte() for DirStream, ProcessStream, and others
Theodoros Theodorou
01:55 PM Base Language Bug #5538: fix readByte() for DirStream, ProcessStream, and others
Thank you for confirming the bug Constantin and Ovidiu. I have created a test under @testcases\oo\progress\io\input_s... Theodoros Theodorou
04:32 PM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
> 4GL supports the following file types: @.p@, @.r@, @.w@, @.cls@, @.i@. I've also found @.pf@ (parameter file), @.cf... Greg Shah
04:28 PM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
During conversion, we have a copy of the file-system of the 4GL project. That project might have some arbitrary path... Greg Shah
09:51 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
Alexandru Lungu wrote:
> It is normal not to be found right? I mean, if you are running start.p and the only start.p...
Dănuț Filimon
06:25 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
Dănuț Filimon wrote:
> I've also found a problem with this idea where the possible paths from a @SinglePathLookup@ c...
Alexandru Lungu
06:16 AM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
> The one place I differ is that I was not thinking we would store the propath variants in the *PathLookup helpers. I... Alexandru Lungu
10:18 AM Database Bug #7797: FWD-H2 LAZY reverse index regression
*Review of 7066c_h2:*
* I like seeing ~20 new tests on LAZY :)
* Why is @currentSearchRow = null@ required in you...
Alexandru Lungu
09:04 AM Database Bug #7667: Support OUTER-JOIN with PRESELECT at conversion
*Review of 7667a changes:*
* Please limit this only to outer-join cases. I think it is right to join two tables if...
Alexandru Lungu
08:51 AM Database Bug #7667: Support OUTER-JOIN with PRESELECT at conversion
While trying to create a testcase that would help me solve this initial purpose of the task (changing the conversion ... Andrei Bălteanu
04:31 AM Database Bug #7667: Support OUTER-JOIN with PRESELECT at conversion
Igor, I think I led you into a small misunderstanding.
The comment from #7667-5 was related to a @run-time@ optimiza...
Andrei Bălteanu
08:49 AM User Interface Bug #7824: Simplify idle connection settings and apply the default configuration for the web clie...
I changed the subject because these configuration parameters are needed to be different as they are used differently. Sergey Ivanovskiy
 

Also available in: Atom