FWD

05/31/2024

03:39 PM Runtime Infrastructure Feature #6692 (Merge Pending): move FWD to Java 17

OK, all the applications have reached a minimum level of support for 6692a.
Please merge 6692a to trunk, after 812... Greg Shah

10:52 AM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'

The change is not OK - I get this:... Constantin Asofiei

05:55 AM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'

Rebased 8593d/rev. 15263.
Tested this with a customer unit tests and everything went fine. Although, I think the t... Alexandru Lungu

02:20 AM Database Feature #8834: add bootstrap configuration support for -db OE command line parameter (and related...

Are @-H@, @-S@ and @-P@ used only for the db? If so, it's best to have an array of custom objects with all the config... Galya B

05/30/2024

05:02 PM Database Feature #8834: add bootstrap configuration support for -db OE command line parameter (and related...

The current code provides two ways to make a database connection in FWD:
* Using the session based auto-connect (#... Greg Shah

04:45 PM Database Feature #8834 (Closed): add bootstrap configuration support for -db OE command line parameter (an...

Greg Shah

04:43 PM Database Feature #8833: eliminate legacy load on startup support

This is leftover work that should have been finished in #3930. The objective is to remove the old style load on star... Greg Shah

04:33 PM Database Feature #8833 (New): eliminate legacy load on startup support

Greg Shah

12:30 PM Runtime Infrastructure Feature #6692: move FWD to Java 17

Rebased to current @trunk/15259@
Pushed @6692a/15299@
Tomasz Domin

12:26 PM Runtime Infrastructure Feature #6692: move FWD to Java 17

Roger Borrello wrote:
> I have updated the @container@ project so that base images are created that contain JDK 17. ... Tomasz Domin

11:35 AM Runtime Infrastructure Feature #6692: move FWD to Java 17

Tomasz Domin wrote:
> 6692a rev 15244 - Reverted @mariadb-java-client@ to @FWD@ compatible version: "3.1.2"
>
> ... Greg Shah

11:21 AM Runtime Infrastructure Feature #6692: move FWD to Java 17

6692a rev 15244 - Reverted @mariadb-java-client@ to @FWD@ compatible version: "3.1.2"
Greg - please let me know w... Tomasz Domin

12:03 PM User Interface Bug #8586 (Internal Test): Fields are not in FIELD-GROUP until they are enabled

8586a revision 15256,
Nice simplification of @nextTabItem@!
The changes also affect other use cases like @ENABL... Hynek Cihlar

08:02 AM User Interface Bug #8586: Fields are not in FIELD-GROUP until they are enabled

Hynek: Please review. Greg Shah

08:46 AM Base Language Bug #8799: ON ERROR UNDO, THROW problems leading to infinite loops

Marian Edu wrote:
> Marian Edu wrote:
> > Some of them are just caused by the conversion when unknown (?) is passed... Greg Shah

08:45 AM Base Language Bug #8799: ON ERROR UNDO, THROW problems leading to infinite loops

Artur: Please make all of these testcases work properly, including the conversion fixes. Constantin, Marian and I wi... Greg Shah

04:35 AM Base Language Bug #8799: ON ERROR UNDO, THROW problems leading to infinite loops

Marian Edu wrote:
> Some of them are just caused by the conversion when unknown (?) is passed directly as parameter ... Marian Edu

04:22 AM Base Language Bug #8799: ON ERROR UNDO, THROW problems leading to infinite loops

Marian Edu wrote:
> @undoReturnErrorTopLevel@ doesn't have an override using @ProError@.
This is for the @return ... Marian Edu

03:47 AM Base Language Bug #8799: ON ERROR UNDO, THROW problems leading to infinite loops

Greg Shah wrote:
> > I do not think we have tests for default error handling for all blocks but we can maybe add tho... Marian Edu

08:19 AM Base Language Feature #4347: add runtime support for STOP-AFTER block option

Constantin Asofiei wrote:
> * I think if we need to have a way to disable @STOP-AFTER@, via a directory configuratio... Eduard Soltan

05/29/2024

04:58 PM Runtime Infrastructure Feature #6692: move FWD to Java 17

I have updated the @container@ project so that base images are created that contain JDK 17. After a complete build of... Roger Borrello

05:27 AM Runtime Infrastructure Feature #6692: move FWD to Java 17

6692a rev 15244 - Removed unneeded @janusgraph@ dependency: @metrics-graphite@ and transitive @amqp-client@ Tomasz Domin

04:11 PM User Interface Bug #8586 (Review): Fields are not in FIELD-GROUP until they are enabled

I fixed the @private FieldGroup.nextTabItem()@ in similar way.
Now the complete tab ring can be traversed from 4gl f... Vladimir Tsichevski

10:44 AM User Interface Bug #8586 (WIP): Fields are not in FIELD-GROUP until they are enabled

The problem seems to be in @FieldGroup.getExtremeTabItem()@ method, where only *realized* items are selected:... Vladimir Tsichevski

02:18 PM Base Language Bug #8799: ON ERROR UNDO, THROW problems leading to infinite loops

> I do not think we have tests for default error handling for all blocks but we can maybe add those to somewhere if n... Greg Shah

04:16 AM Base Language Bug #8799: ON ERROR UNDO, THROW problems leading to infinite loops

Greg Shah wrote:
> Marian: Where are we with testcases for @ON ERROR UNDO, THROW@?
We have tests for error handling... Marian Edu

05/28/2024

02:15 PM Base Language Bug #8799: ON ERROR UNDO, THROW problems leading to infinite loops

Marian: Where are we with testcases for @ON ERROR UNDO, THROW@?
Constantin: Do we have a standalone testcase to recr... Greg Shah

05/27/2024

04:03 PM User Interface Bug #8809 (Internal Test): Incorrect next enabled widget calculation

Code review 8809a. The changes look good, but it will require good amount of regression testing, including ChUI regre... Hynek Cihlar

03:32 PM User Interface Bug #8809: Incorrect next enabled widget calculation

Hynek: Please review. Greg Shah

03:26 PM User Interface Bug #8809: Incorrect next enabled widget calculation

The (incomplete) fix for #8770 reverted in 8809a in rev. 15241. Vladimir Tsichevski

07:49 AM User Interface Bug #8809 (Review): Incorrect next enabled widget calculation

Vladimir Tsichevski

07:48 AM User Interface Bug #8809 (WIP): Incorrect next enabled widget calculation

Fixed in 8809a rev. 15240. Please, review. Vladimir Tsichevski

03:37 PM Runtime Infrastructure Feature #6692: move FWD to Java 17

6692a rev 15243 - Restore dependencies: implicit for @batik-ext@ and explicit for @slf4j-api@ and @jcl-over-slf4j@ wh... Tomasz Domin

03:25 PM User Interface Bug #8770: ENTRY event is not sent for a frame when window receives focus

The (incomplete) fix moved from 8809a to in 8770a rev. 15242. Vladimir Tsichevski

09:54 AM User Interface Bug #8770 (WIP): ENTRY event is not sent for a frame when window receives focus

The following code in @TC.waitForWorker@ was probably intended to send @ENTRY@ to the frame in question, but, at leas... Vladimir Tsichevski

07:48 AM User Interface Bug #8770 (Review): ENTRY event is not sent for a frame when window receives focus

Vladimir Tsichevski

07:48 AM User Interface Bug #8770 (WIP): ENTRY event is not sent for a frame when window receives focus

Fixed in 8809a rev. 15240. Vladimir Tsichevski

06:37 AM User Interface Bug #8012: Fix combo-box corner cases

Hynek Cihlar wrote:
> Radu Apetrii wrote:
> > My opinion is that we should stick with @append@ (a.k.a. not removing... Radu Apetrii

06:30 AM User Interface Bug #8012 (Internal Test): Fix combo-box corner cases

Radu Apetrii wrote:
> My opinion is that we should stick with @append@ (a.k.a. not removing it), but I am open to ot... Hynek Cihlar

05:29 AM User Interface Bug #8012: Fix combo-box corner cases

I've followed the leads and reached multiple roots of setting @newAddedItems@. All of them pass as a parameter the va... Radu Apetrii

05/25/2024

07:34 AM Database Bug #8593 (Internal Test): H2 performance improvement for table 'truncate by multiplex'

ETF testing passed. Constantin Asofiei

05/24/2024

03:04 PM Runtime Infrastructure Feature #6692: move FWD to Java 17

6692a rev 15242 - GenericWebServer now exposes all @jetty-@ jars to the .war launched app (fixes the JNDI problem). Constantin Asofiei

02:45 PM User Interface Bug #8012: Fix combo-box corner cases

Radu Apetrii wrote:
> Do you have another suggestion other than seeing who added the @newAddedItems@ code and checki... Hynek Cihlar

12:06 PM User Interface Bug #8012: Fix combo-box corner cases

Hynek Cihlar wrote:
> Radu Apetrii wrote:
> > Hynek Cihlar wrote:
> > * @newAddedItems@ is correctly @null@, then ... Radu Apetrii

11:36 AM User Interface Bug #8012: Fix combo-box corner cases

Radu Apetrii wrote:
> Hynek Cihlar wrote:
> * @newAddedItems@ is correctly @null@, then the answer to the question ... Hynek Cihlar

11:09 AM User Interface Bug #8012: Fix combo-box corner cases

Hynek Cihlar wrote:
> For the added @append@ parameter, could we deduce new items are being added from the @newAdded... Radu Apetrii

01:47 AM Base Language Feature #4347: add runtime support for STOP-AFTER block option

Greg Shah wrote:
>From my point of view yes. The inner blocks with on stop undo, ... does not respond to StopConditi... Eduard Soltan

05/23/2024

04:56 PM User Interface Bug #8809: Incorrect next enabled widget calculation

Run the @8809.p@ example.
In OE, the @focusable7@ button receives focus.
In FWD no focus is set.
The issue ori... Vladimir Tsichevski

03:59 PM User Interface Bug #8809 (Closed): Incorrect next enabled widget calculation

Vladimir Tsichevski

10:58 AM Base Language Feature #4347: add runtime support for STOP-AFTER block option

>> Is @STOP-AFTER@ essentially an @ON STOP UNDO, LEAVE@ but only matching a timeout and not other kinds of @STOP@?
>... Greg Shah

10:33 AM Base Language Feature #4347: add runtime support for STOP-AFTER block option

Greg Shah wrote:
> * 4GL syntax
> ** "time limit" value
> *** Test both literals and "complex" expressions (a vari... Eduard Soltan

09:35 AM Base Language Feature #4347: add runtime support for STOP-AFTER block option

> > Here a StopCondition is triggered on @outerBlock1@, however because the nested @innerBlock1@ which has a @on stop... Greg Shah

09:34 AM Base Language Feature #4347: add runtime support for STOP-AFTER block option

Constantin Asofiei wrote:
> Greg Shah wrote:
> > > I think there is some behavior related to blocking UI statements... Greg Shah

09:26 AM Base Language Feature #4347: add runtime support for STOP-AFTER block option

Eduard, Please do the following:
* In the testcase, add elapsed timers around each of the cases where you are expe... Greg Shah

09:20 AM Base Language Feature #4347: add runtime support for STOP-AFTER block option

Greg Shah wrote:
> > I think there is some behavior related to blocking UI statements (like UDPATE, or PAUSE): if th... Constantin Asofiei

09:16 AM Base Language Feature #4347: add runtime support for STOP-AFTER block option

> I think there is some behavior related to blocking UI statements (like UDPATE, or PAUSE): if these exist, then the ... Greg Shah

02:43 AM Base Language Feature #4347: add runtime support for STOP-AFTER block option

I think there is some behavior related to blocking UI statements (like UDPATE, or PAUSE): if these exist, then the ST... Constantin Asofiei

02:39 AM Base Language Feature #4347: add runtime support for STOP-AFTER block option

Constantin Asofiei wrote:
> Marian Edu wrote:
> > That one works as expected for me (OE12.2), what you can do so it... Marian Edu

02:33 AM Base Language Feature #4347: add runtime support for STOP-AFTER block option

Marian Edu wrote:
> That one works as expected for me (OE12.2), what you can do so it doesn't look like it's mining ... Constantin Asofiei

02:28 AM Base Language Feature #4347: add runtime support for STOP-AFTER block option

Eduard Soltan wrote:
> Here a StopCondition is triggered on @outerBlock1@, however because the nested @innerBlock1... Marian Edu

09:32 AM Database Bug #8593 (Review): H2 performance improvement for table 'truncate by multiplex'

Hmmm, I think I see the problem. Indeed, it is not right to delete the DMO as it is not even inserted in the database... Alexandru Lungu

06:57 AM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'

Actually I get this in the server log:... Constantin Asofiei

03:13 AM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'

Alexandru Lungu wrote:
> Constantin, can you pick this up for another customer application that drove the effort in ... Constantin Asofiei

09:17 AM User Interface Bug #8807: A trigger of ANYWHERE type does not shadow existing trigger for the same event

This issue was first reported in #8606-44. Vladimir Tsichevski

09:16 AM User Interface Bug #8807: A trigger of ANYWHERE type does not shadow existing trigger for the same event

Code example:... Vladimir Tsichevski

08:54 AM User Interface Bug #8807 (Review): A trigger of ANYWHERE type does not shadow existing trigger for the same event

Vladimir Tsichevski

07:23 AM Database Bug #7473 (Test): rewrite toString() implementation for Dataset, StaticTempTable and TempTableBui...

Branch 7473a was merged to trunk rev 15236 and archived. Andrei Iacob

07:16 AM Database Bug #7473: rewrite toString() implementation for Dataset, StaticTempTable and TempTableBuilder to...

You can merge to trunk now. Greg Shah

02:41 AM Database Bug #7473: rewrite toString() implementation for Dataset, StaticTempTable and TempTableBuilder to...

This is ready to merge. Let us know when we can merge. Andrei Iacob

05/22/2024

06:04 PM Base Language Feature #4347: add runtime support for STOP-AFTER block option

Eduard Soltan wrote:
> Committed on 4347a, revision 15205.
I understand from today's meeting that this commit add... Eric Faulhaber

02:48 AM Base Language Feature #4347: add runtime support for STOP-AFTER block option

Committed on 4347a, revision 15205.
Created a suite of test cases.
Also find some scenarios which behaviours in 4... Eduard Soltan

03:22 PM Runtime Infrastructure Feature #6692: move FWD to Java 17

Greg Shah wrote:
> Please commit the change. Let's restart testing.
Committed to 6692a rev 15241. Constantin Asofiei

02:58 PM Runtime Infrastructure Feature #6692: move FWD to Java 17

Please commit the change. Let's restart testing. Greg Shah

01:58 PM Runtime Infrastructure Feature #6692: move FWD to Java 17

This change removes mime4j benchmark, which required jmh:... Constantin Asofiei

11:07 AM Database Bug #7473: rewrite toString() implementation for Dataset, StaticTempTable and TempTableBuilder to...

Since this hasn't merged yet, let's pause the merge so other branches can go.
Eduard: Let me know when you are a... Greg Shah

11:01 AM Base Language Feature #6417: cleanup some known items in appserver support

Galya B wrote:
> May I get a confirmation that @webtests_from_logs/results@ are results from Progress?
Yes, this is... Constantin Asofiei

08:44 AM Base Language Feature #6417: cleanup some known items in appserver support

May I get a confirmation that @webtests_from_logs/results@ are results from Progress? Galya B

10:32 AM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'

I am talking about 8593d. Alexandru Lungu

10:32 AM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'

I am picking this up for a customer unit tests.
As #8593 is broadly about performance in FWD-H2, Constantin, can you... Alexandru Lungu

07:14 AM User Interface Bug #8012: Fix combo-box corner cases

Alexandru Lungu wrote:
> Radu, please look into [[p2j:4GL_Unit_Testing]] and [[p2j:Writing_4GL_Testcases]], more exa... Marian Edu

07:09 AM User Interface Bug #8012: Fix combo-box corner cases

Radu, please look into [[p2j:4GL_Unit_Testing]] and [[p2j:Writing_4GL_Testcases]], more exactly into what we call "xf... Alexandru Lungu

03:08 AM User Interface Bug #8012: Fix combo-box corner cases

Code review 7806b. The changes are pretty dense so it is hard to follow every case, but they look OK to me.
For th... Hynek Cihlar

04:45 AM Conversion Tools Feature #8786: incremental schema conversion and updates

We keep changing our database schema. We basically copied the mechanism we used in OpenEdge. It works like this:
*... André van Hulzen

02:26 AM Base Language Bug #8799: ON ERROR UNDO, THROW problems leading to infinite loops

There are cases when even if an ERROR condition is supposed to be morphed into a structured exception, and re-thrown ... Constantin Asofiei

02:24 AM Base Language Bug #8799 (Test): ON ERROR UNDO, THROW problems leading to infinite loops

Constantin Asofiei

05/21/2024

05:00 PM Conversion Tools Feature #8786: incremental schema conversion and updates

> things get more complicated if a table/ field is renamed. Dropping and recreating might not be the correct choice s... Greg Shah

04:52 PM Conversion Tools Feature #8786: incremental schema conversion and updates

I would like to add a few thoughts here. We need to analyse all kind of mutations which can happen during an upgrade ... Ovidiu Maxiniuc

11:44 AM User Interface Bug #8012: Fix combo-box corner cases

Hynek: Please review. Greg Shah

10:10 AM User Interface Bug #8012 (Review): Fix combo-box corner cases

Check the 7806b changes: Done.
Check that the 34 tests that I've created pass: Done.
Status: waiting for review.
... Radu Apetrii

08:37 AM User Interface Bug #8012: Fix combo-box corner cases

Yes, let's move ahead with 7806b and further changes can go in another branch. Please set the %Done of this task acc... Greg Shah

08:34 AM User Interface Bug #8012: Fix combo-box corner cases

Greg, the branch 7806b solves the issue on #8407. The problem (?) is that this branch contains multiple fixes for com... Radu Apetrii

07:39 AM User Interface Bug #8012: Fix combo-box corner cases

I rebased 7806b with trunk rev. 15226. I suggest waiting for the #8407 result before we decide what to do with 7806b. Radu Apetrii

11:22 AM Database Bug #7473 (Merge Pending): rewrite toString() implementation for Dataset, StaticTempTable and Tem...

This can merge after 8001a. Greg Shah

10:56 AM Database Bug #7473: rewrite toString() implementation for Dataset, StaticTempTable and TempTableBuilder to...

Alexandru Lungu wrote:
> I think the changes are only for debugging purposes, right? Ovidiu, please correct me if I ... Ovidiu Maxiniuc

07:41 AM Database Bug #7473: rewrite toString() implementation for Dataset, StaticTempTable and TempTableBuilder to...

I think the changes are only for debugging purposes, right? Ovidiu, please correct me if I am wrong. Despite trying i... Alexandru Lungu

07:13 AM Database Bug #7473 (Internal Test): rewrite toString() implementation for Dataset, StaticTempTable and Tem...

What testing is needed? Greg Shah

03:17 AM Database Bug #7473: rewrite toString() implementation for Dataset, StaticTempTable and TempTableBuilder to...

I committed the changes. Eduard Baciu

10:38 AM Base Language Feature #6161: add support for DYNAMIC-PROPERTY() built-in function and DYNAMIC-PROPERTY language...

Branch 6161a was merged to trunk rev 15229 and archived. Constantin Asofiei

08:34 AM Base Language Feature #6161 (Merge Pending): add support for DYNAMIC-PROPERTY() built-in function and DYNAMIC-P...

You can merge to trunk after 7417b. Greg Shah

08:04 AM Base Language Feature #6161: add support for DYNAMIC-PROPERTY() built-in function and DYNAMIC-PROPERTY language...

Greg Shah wrote:
> What testing do you propose?
DYNAMIC-PROPERTY is not being used in other projects than #8433. S... Constantin Asofiei

07:58 AM Base Language Feature #6161 (Internal Test): add support for DYNAMIC-PROPERTY() built-in function and DYNAMIC-P...

What testing do you propose? Greg Shah

07:58 AM Base Language Feature #6161: add support for DYNAMIC-PROPERTY() built-in function and DYNAMIC-PROPERTY language...

I think we just watch it in case it becomes a hotspot. One solution would be to group all the details of a property ... Greg Shah

07:30 AM Base Language Feature #6161: add support for DYNAMIC-PROPERTY() built-in function and DYNAMIC-PROPERTY language...

I've moved the bulk getter/setter to be resolved only if no indexed setter/getter is resolved at all. I'm not sure w... Constantin Asofiei

08:38 AM Base Language Feature #4347: add runtime support for STOP-AFTER block option

That explains it. I was looking at the 12.x docs. Greg Shah

07:47 AM Base Language Feature #4347: add runtime support for STOP-AFTER block option

Constantin Asofiei wrote:
> According to https://docs.progress.com/bundle/openedge-startup-and-parameter-reference-1... Marian Edu

04:57 AM Runtime Infrastructure Feature #6692: move FWD to Java 17

Greg Shah wrote:
> The converted code javac times (and heap requirements) as seen in #8773 and #8771, are something ... Tomasz Domin

05/20/2024

03:20 PM Database Bug #7473: rewrite toString() implementation for Dataset, StaticTempTable and TempTableBuilder to...

Review of 7473a, r15210.
The majority of the issues from previous review were addressed, I have not seen any logic... Ovidiu Maxiniuc

02:32 PM Database Bug #8593 (Internal Test): H2 performance improvement for table 'truncate by multiplex'

The changes seem logical. I think the code is OK. Ovidiu Maxiniuc

10:24 AM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'

Ovidiu: Please review. Greg Shah

03:46 AM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'

8593d needs a review first. Alexandru Lungu

12:51 PM Base Language Feature #6161: add support for DYNAMIC-PROPERTY() built-in function and DYNAMIC-PROPERTY language...

Code Review Task Branch 6161a Revision 15222
The changes look good.
The only concern I have is about performa... Greg Shah

07:34 AM Base Language Feature #6161 (Review): add support for DYNAMIC-PROPERTY() built-in function and DYNAMIC-PROPERTY...

Created task branch 6161a from trunk rev 15222. rev 15223 fixed validation of the DYNAMIC-PROPERTY arguments for stat... Constantin Asofiei

11:59 AM Base Language Feature #4347: add runtime support for STOP-AFTER block option

Good.
Eduard: Create a new task for the @-catchStop@ behavior. Focus your implementation for this task on the tr... Greg Shah

11:57 AM Base Language Feature #4347: add runtime support for STOP-AFTER block option

Greg Shah wrote:
> > Greg, @-catchStop 1@ startup option is required for @progress.lang.stopafter@ to be thrown.
... Constantin Asofiei

11:40 AM Base Language Feature #4347: add runtime support for STOP-AFTER block option

> Greg, @-catchStop 1@ startup option is required for @progress.lang.stopafter@ to be thrown.
Are you saying tha... Greg Shah

11:39 AM Base Language Feature #4347: add runtime support for STOP-AFTER block option

> I tried to run this code in Procedure Editor, but it does not work as expected.
Do not run any test code from in... Greg Shah

09:12 AM Base Language Feature #4347: add runtime support for STOP-AFTER block option

Marian Edu wrote:
> As Constantin said you have to move the @catch@ block out of the @stop-after@ one and also make ... Eduard Soltan

08:51 AM Base Language Feature #4347: add runtime support for STOP-AFTER block option

As Constantin said you have to move the @catch@ block out of the @stop-after@ one and also make sure you remove the @... Marian Edu

08:26 AM Base Language Feature #4347: add runtime support for STOP-AFTER block option

Greg, @-catchStop 1@ startup option is required for @progress.lang.stopafter@ to be thrown. Do we want to implement ... Constantin Asofiei

05:24 AM Base Language Feature #4347: add runtime support for STOP-AFTER block option

... Eduard Soltan

10:16 AM Runtime Infrastructure Feature #6692: move FWD to Java 17

The converted code javac times (and heap requirements) as seen in #8773 and #8771, are something for which we need to... Greg Shah

05/17/2024

12:29 PM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'

Is there any further review needed for this or do we just need testing? Greg Shah

05:13 AM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'

Committed 8593d/rev. 15206 to fix #8593-54. It contains the patch from #8593-56.
Recap: there was an issue on datas... Alexandru Lungu

05/16/2024

04:03 PM Conversion Tools Feature #8786: incremental schema conversion and updates

On my customer, and in *hotel_gui*, I have a @archive.incremental@ task in @build.xml@ which attempts to collect all ... Roger Borrello

03:15 PM Conversion Tools Feature #8786: incremental schema conversion and updates

Over time, developing 4GL code naturally requires schema updates. For existing non-trivial persistent database insta... Greg Shah

02:51 PM Conversion Tools Feature #8786 (New): incremental schema conversion and updates

Greg Shah

09:48 AM Base Language Feature #6407: name_map.xml improvements

Greg Shah wrote:
> I thought that in #6407-71, this was changed to a @List@ approach which has proper FIFO ordering.... Galya B

09:31 AM Base Language Feature #6407: name_map.xml improvements

Greg Shah wrote:
> You can include it in 8667a.
The fix was merged to trunk as rev. 15216. Galya B

08:30 AM Base Language Feature #6407: name_map.xml improvements

You can include it in 8667a. Greg Shah

02:08 AM Base Language Feature #6407: name_map.xml improvements

The comparison in the condition is solid... if it wasn't for @extProg.ooname = ooname.isEmpty() ? null : ooname;@. @o... Galya B

05/15/2024

04:12 PM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'

Greg Shah wrote:
> This resolves the regression documented in #7143-900?
Yes Constantin Asofiei

03:53 PM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'

This resolves the regression documented in #7143-900? Greg Shah

03:07 PM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'

Branch 8593c was merged to trunk revision 15212 and archived.
Branch 8593c_h2 was merged to fwd-h2 trunk revision ... Constantin Asofiei

02:55 PM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'

Greg Shah wrote:
> You can merge to trunk now.
Starting. Constantin Asofiei

02:53 PM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'

You can merge to trunk now. Greg Shah

02:52 PM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'

ETF testing passed, the original #7143-903 is fixed, and another app works OK with this. Constantin Asofiei

04:17 AM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'

Reset %Done. Alexandru Lungu

02:56 PM User Interface Bug #8780: Incorrect frame layout

The following code:... Vladimir Tsichevski

02:51 PM User Interface Bug #8780 (New): Incorrect frame layout

Vladimir Tsichevski

10:38 AM Base Language Feature #6407: name_map.xml improvements

> Greg, why would #6667-995 fail with this test (@(!resolvedProgram.pname.equals(pname) || !ooname.equals(resolvedPro... Greg Shah

08:43 AM Base Language Feature #6407: name_map.xml improvements

Greg, why would #6667-995 fail with this test (@(!resolvedProgram.pname.equals(pname) || !ooname.equals(resolvedProgr... Constantin Asofiei

08:30 AM Base Language Feature #6407: name_map.xml improvements

> Interesting. Most of the discussion in this task is about how map resolvement should work and it's implemented acco... Greg Shah

03:00 AM Base Language Feature #6407: name_map.xml improvements

And let me state again, if there is a discrepancy in the content of the maps of two jars in the classpath, this is a ... Galya B

02:44 AM Base Language Feature #6407: name_map.xml improvements

I think we should actually be happy to have found this discrepancy in the scripts. Every time such malfunction appear... Galya B

02:40 AM Base Language Feature #6407: name_map.xml improvements

Greg Shah wrote:
> In #6667-995, Tomasz found that the server failed to start after picking up trunk rev 15180. The... Galya B

05:55 AM Database Bug #7473: rewrite toString() implementation for Dataset, StaticTempTable and TempTableBuilder to...

The modified version of
@RecordBuffer.java - sqlTableContentJson@... Eduard Baciu

03:32 AM Database Bug #7473: rewrite toString() implementation for Dataset, StaticTempTable and TempTableBuilder to...

Rebased branch 7473a to trunk rev. 15208. Current revision at 15209. Andrei Iacob

05/14/2024

04:45 PM Runtime Infrastructure Feature #6692: move FWD to Java 17

In each of these testing processes, please use the details in [[p2j:Switching_Between_Java_8_and_Java_17]] to migrate... Greg Shah

04:40 PM Runtime Infrastructure Feature #6692: move FWD to Java 17

The final phase of testing for 6692a is starting now. When each of the following are resolved, we will merge to trun... Greg Shah

09:08 AM Runtime Infrastructure Feature #6692: move FWD to Java 17

I've pushed @6692a/15240@ based on current @trunk/15205@ I guess which is ready for testing.
Please review commits 1... Tomasz Domin

04:31 PM Database Bug #7473: rewrite toString() implementation for Dataset, StaticTempTable and TempTableBuilder to...

I have just notice that a branch 7473a already exists. It was not mentioned in the task so I assumed the changes are ... Ovidiu Maxiniuc

03:00 PM Database Bug #7473: rewrite toString() implementation for Dataset, StaticTempTable and TempTableBuilder to...

Review of code from #7473-12:
* the overall implementation is good. Nearly all of the notes below are either to incr... Ovidiu Maxiniuc

03:52 PM User Interface Bug #8770: ENTRY event is not sent for a frame when window receives focus

Then a window receives focus, and no field-level was in focus before in this window (for example, when a window is ju... Vladimir Tsichevski

03:31 PM User Interface Bug #8770 (WIP): ENTRY event is not sent for a frame when window receives focus

Vladimir Tsichevski

02:47 PM User Interface Bug #8673: Deduce the logic behind OE focus management and implement in FWD

The missing @printEntryLeave.i@ required to run the @8376-with-focusable.p@ uploaded. Vladimir Tsichevski

02:32 PM Database Bug #8769 (New): BIND argument passing for DATASET, TABLE, DATASET-HANDLE, TABLE-HANDLE arguments...

Constantin Asofiei

02:11 PM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'

I've uploaded 1.48 to projsrv01 and upgraded the version in rev 15206.
I'll run ETF and test with another customer... Constantin Asofiei

01:52 PM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'

I have reviewed the changes from 8593c/rev. 15205. Good job!
Is there a reason for downgrading the percentage done... Ovidiu Maxiniuc

09:33 AM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'

Committed 8593c/rev. 15205 assessing the review from Ovidiu. Alexandru Lungu

09:10 AM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'

Constantin, please review 8593c_h2 changes. If they are OK, please upload it to the GCD repository.
Alexandru Lungu

09:34 AM Base Language Feature #4347: add runtime support for STOP-AFTER block option

Code Review (Part 2) Task Branch 4347a Revision 15204
7. Should we (can we?) name the @Timer@ thread to make it cl... Greg Shah

09:21 AM Base Language Feature #4347: add runtime support for STOP-AFTER block option

Code Review Task Branch 4347a Revision 15204
1. Please explain why @Control.blockInterrupt()@ adds a remote call a... Greg Shah

08:29 AM Base Language Feature #4347: add runtime support for STOP-AFTER block option

I'm reviewing the code now. After reviewing the 4GL docs, I do have some questions. I also added Marian to coordina... Greg Shah

06:20 AM Base Language Feature #4347: add runtime support for STOP-AFTER block option

Constantin Asofiei wrote:
> Ah, you are right, there is a single thread where the tasks are posted. So there is no ... Eduard Soltan

03:12 AM Base Language Feature #4347: add runtime support for STOP-AFTER block option

Eduard Soltan wrote:
> Constantin Asofiei wrote:
> > Review for 4347a rev 15204:
> > * what happens if there are n... Constantin Asofiei

02:49 AM Base Language Feature #4347: add runtime support for STOP-AFTER block option

Constantin Asofiei wrote:
> Review for 4347a rev 15204:
> * what happens if there are nested blocks with @STOP-AFTE... Eduard Soltan

02:16 AM Base Language Feature #4347: add runtime support for STOP-AFTER block option

Review for 4347a rev 15204:
* we need a @SessionListener@ to clean up the @StopAfterTimer.stopAfterTimerOuts@ map. ... Constantin Asofiei

08:24 AM Runtime Infrastructure Bug #8624: Stream should detect whether it is being used from the client or the server

Greg, what do I need to do in order to do server side stream operations? I noticed some setup steps from #4065, besid... Șerban Bursuc

05/13/2024

03:34 PM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'

Greg Shah wrote:
> Ovidiu/Eric: Please review 8593c.
I am OK with the code. A few of notes (cleanup/low priority)... Ovidiu Maxiniuc

03:10 PM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'

These are the changes that unblocked me:... Alexandru Lungu

02:51 PM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'

Alexandru, I don't like leaving 'allocated records' with no meaning in H2. Can we explicitly clear the primary key f... Constantin Asofiei

02:40 PM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'

I am also having a hard time tracking down an issue with the truncate now (not related to my changes in 8593c/8593c_h... Alexandru Lungu

01:27 PM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'

I committed 8593c_h2/rev. 50: Allowing forced reclaiming only for NO-UNDO tables. Otherwise, on a rollback, we may ha... Alexandru Lungu

12:15 PM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'

Eric, I am starting the review process in the next minutes. Please let me know if you are already in the process. Ovidiu Maxiniuc

09:50 AM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'

I committed now 8593c/rev. 15204. This includes a requirement to use in-DB PK mapping if the table has normalized ext... Alexandru Lungu

09:14 AM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'

Ovidiu/Eric: Please review 8593c.
This is quite Urgent since it is to resolve a regression in a customer applicati... Greg Shah

03:04 PM Base Language Feature #4347: add runtime support for STOP-AFTER block option

Greg or Constantin: please review. Eric Faulhaber

09:56 AM Base Language Feature #4347 (Review): add runtime support for STOP-AFTER block option

Committed on 4347a, revision 15204. Eduard Soltan

03:03 PM Base Language Feature #6407: name_map.xml improvements

In #6667-995, Tomasz found that the server failed to start after picking up trunk rev 15180. The issue turned out to... Greg Shah

01:44 PM User Interface Bug #8673: Deduce the logic behind OE focus management and implement in FWD

The #8673-11 now contains the focus data model and the focus change by mouse flow. Please, comment.
The demo progr... Vladimir Tsichevski

01:43 PM Runtime Infrastructure Feature #6692: move FWD to Java 17

Roger Borrello wrote:
> Tomasz Domin wrote:
> > Roger Borrello wrote:
> > > Tomasz Domin wrote:
> > > > I guess t... Tijs Wickardt

01:13 PM Runtime Infrastructure Feature #6692: move FWD to Java 17

Tomasz Domin wrote:
> Roger Borrello wrote:
> > Tomasz Domin wrote:
> > > I guess that was already planned to be c... Roger Borrello

01:03 PM Runtime Infrastructure Feature #6692: move FWD to Java 17

Roger Borrello wrote:
> Tomasz Domin wrote:
> > I guess that was already planned to be changed as @hotel_gui@ has a... Tomasz Domin

12:29 PM Runtime Infrastructure Feature #6692: move FWD to Java 17

Tomasz Domin wrote:
> I guess that was already planned to be changed as @hotel_gui@ has already that change implemen... Roger Borrello

11:56 AM Runtime Infrastructure Feature #6692: move FWD to Java 17

I had some issues with FWD @build.gradle@ as it is using @javascript@ which is no longer available in JVM since JDK15... Tomasz Domin

10:26 AM Database Feature #8756: Modifyable database comment string must support double quoted values

Modifyable database comment string must support double quoted values.
This is needed, because for example Label, Col... Tijs Wickardt

10:16 AM Database Feature #8756 (New): Modifyable database comment string must support double quoted values

Tijs Wickardt

05:10 AM Base Language Feature #6417: cleanup some known items in appserver support

Marian Edu wrote:
> I'm looking back at the responses (in webtests_from_logs folder) and it does look like the asser... Galya B

05:02 AM Base Language Feature #6417: cleanup some known items in appserver support

Galya B wrote:
> Marian Edu wrote:
> > Gayla
> It's Galya.
Galya :)
I'm looking back at the responses (in we... Marian Edu

04:50 AM Base Language Feature #6417: cleanup some known items in appserver support

Marian Edu wrote:
> Gayla
It's Galya. Galya B

04:49 AM Base Language Feature #6417: cleanup some known items in appserver support

Galya B wrote:
> @com.goldencode.p2j.util.decimal@ has:
>
> [...]
>
> But testcases test @pipe_decimal_decimal... Marian Edu

04:48 AM Base Language Feature #6417: cleanup some known items in appserver support

Marian Edu wrote:
> Galya B wrote:
> > Marian, do you have any idea why this test executed as batch in 4GL gives th... Galya B

03:58 AM Base Language Feature #6417: cleanup some known items in appserver support

Greg, how is this going to work? I have more questions than the number of failing tests (quite a few and all over the... Galya B

03:26 AM Base Language Feature #6417: cleanup some known items in appserver support

@com.goldencode.p2j.util.decimal@ has:... Galya B

04:34 AM Database Bug #7473: rewrite toString() implementation for Dataset, StaticTempTable and TempTableBuilder to...

Ovidiu, please provide a second review for the changes. Alexandru Lungu

05/12/2024

02:38 PM Database Bug #8593 (Review): H2 performance improvement for table 'truncate by multiplex'

Committed 8593c_h2/rev. 48 and 8593c/rev. 15203. Contains the following:
* H2 support for @NEXT PK FOR (<table-nam... Alexandru Lungu

05/09/2024

07:58 AM Runtime Infrastructure Feature #6692: move FWD to Java 17

Tomasz Domin wrote:
> I have just pushed @6692a/15188@ with following updates:
>
> Next steps:
> - updating docu... Tomasz Domin

05/08/2024

10:46 AM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'

Constantin Asofiei wrote:
> This is a test where it gets into an infinite loop:
> [...]
>
> This can be expanded... Alexandru Lungu

09:56 AM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'

This is a test where it gets into an infinite loop:... Constantin Asofiei

09:38 AM Database Bug #8593 (WIP): H2 performance improvement for table 'truncate by multiplex'

Timeline:
1. I was thinking of replacing the sequence based PK generator used by @FastCopyHelper@ with a more cust... Alexandru Lungu

06:04 AM Runtime Infrastructure Feature #6692: move FWD to Java 17

I have just pushed @6692a/15188@ with following updates:
* Support for versioned JS dependencies in @ReportWebServ... Tomasz Domin

05/07/2024

11:21 AM Support #8547: Fix documentation for Non-Standard Save Cache Implementation

Ovidiu Maxiniuc wrote:
> Tijs Wickardt wrote:
> > It was #7847-421 , where you mention:
> > > * skip loading table... Tijs Wickardt

11:19 AM Support #8547: Fix documentation for Non-Standard Save Cache Implementation

Tijs Wickardt wrote:
> It was #7847-421 , where you mention:
> > * skip loading tables from mutable databases at se... Ovidiu Maxiniuc

03:09 AM Base Language Feature #6410: implement additional built-in OO classes/interfaces

Constantin Asofiei wrote:
> This gets tricky if you pass an extent field via @::@. But yes, this would need to get ... Marian Edu

05/06/2024

01:52 PM Runtime Infrastructure Feature #6692: move FWD to Java 17

Greg Shah wrote:
> > A remark - I don't think any of customer application would be ready for Java 17 right away - th... Eric Faulhaber

02:52 AM Runtime Infrastructure Bug #8206: Logging manager issues

Otherwise I'm ok with the changes. Galya B

02:52 AM Runtime Infrastructure Bug #8206: Logging manager issues

Vladimir Tsichevski wrote:
> This is the response on the #8206-11 finding and needs to be tested. I am not sure it w... Galya B

05/03/2024

05:41 PM Runtime Infrastructure Feature #6692: move FWD to Java 17

> > Are you saying code changes are needed? I don't think we expose @com.goldencode.p2j.persist.Record@ in converted... Greg Shah

05:12 PM Runtime Infrastructure Feature #6692: move FWD to Java 17

Tomasz Domin wrote:
> Greg Shah wrote:
> > Are you saying code changes are needed? I don't think we expose @com.go... Eugenie Lyzenko

04:00 PM Runtime Infrastructure Feature #6692: move FWD to Java 17

Greg Shah wrote:
> Are you saying code changes are needed? I don't think we expose @com.goldencode.p2j.persist.Reco... Tomasz Domin

07:58 AM Runtime Infrastructure Feature #6692: move FWD to Java 17

Tomasz Domin wrote:
> Tomasz Domin wrote:
> > * test customer applications for regression - the most important appl... Eugenie Lyzenko

06:03 AM Runtime Infrastructure Feature #6692: move FWD to Java 17

> A remark - I don't think any of customer application would be ready for Java 17 right away - they most probably nee... Greg Shah

04:52 AM Runtime Infrastructure Feature #6692: move FWD to Java 17

Tomasz Domin wrote:
> * test customer applications for regression - the most important applications - I guess we nee... Tomasz Domin

05:34 PM User Interface Bug #8673: Deduce the logic behind OE focus management and implement in FWD

I edited it. It should have been @RETURN NO-APPLY <expression>.@. Greg Shah

04:00 PM User Interface Bug #8673: Deduce the logic behind OE focus management and implement in FWD

Thanks, Greg.
One question:
The following two @RETURN <expression>.@ statements look the same:
> * A @RETURN... Vladimir Tsichevski

02:03 PM User Interface Bug #8673: Deduce the logic behind OE focus management and implement in FWD

First, I want to record some of our older documentation:
https://proj.goldencode.com/artifacts/javadoc/latest/api/... Greg Shah

12:21 PM User Interface Bug #8673: Deduce the logic behind OE focus management and implement in FWD

Question to gurus:
A Progress trigger can return a value. If the @NO-APPLY@ is returned, the further event process... Vladimir Tsichevski

10:55 AM Runtime Infrastructure Bug #8206: Logging manager issues

Galya B wrote:
> Vladimir Tsichevski wrote:
> > Log manager initialization fixed in 8206a rev. 15197. Please, revie... Vladimir Tsichevski

09:44 AM Runtime Infrastructure Bug #8206: Logging manager issues

Vladimir Tsichevski wrote:
> Log manager initialization fixed in 8206a rev. 15197. Please, review.
I'm not sure i... Galya B

09:21 AM Runtime Infrastructure Bug #8206 (Review): Logging manager issues

Log manager initialization fixed in 8206a rev. 15197. Please, review. Vladimir Tsichevski

06:29 AM Runtime Infrastructure Bug #8206 (WIP): Logging manager issues

OK, I'll rebase the branch and add the missing change. Vladimir Tsichevski

01:21 AM Runtime Infrastructure Bug #8206: Logging manager issues

Actually Vladimir is better familiar with these issues and has more insight on what needs to be achieved.
Vladimir... Galya B

07:40 AM Base Language Feature #6424: fill gaps in Java Open Client replacement (appserver client support)

Galya B wrote:
> There are some failing tests. Is it the deployment or it's fine?
The failing tests are known failu... Constantin Asofiei

07:28 AM Base Language Feature #6410: implement additional built-in OO classes/interfaces

Marian Edu wrote:
> We have tests for `ParameterList` that are failing for extent parameters used as output/input-ou... Constantin Asofiei

02:13 AM Support #8547: Fix documentation for Non-Standard Save Cache Implementation

Ovidiu Maxiniuc wrote:
> Tijs,
> I do not think that is correct. The phrase from wiki is correct: a full scan is pe... Tijs Wickardt