Project

General

Profile

Activity

From 01/17/2014 to 02/15/2014

02/16/2014

10:04 PM Base Language Feature #1634: implement full native library (.so or DLL) support
Between 2 regression testing runs, all tests have passed except for GSO 167 (and TC JOB 002 which fails as expected i... Greg Shah

02/15/2014

03:47 PM User Interface Feature #1805: add missing UI method support
@Color.toForeground@ receives a @null@ @Color@ instance hence the NPE. It looks like @ColorMapper.toFont@ should hand... Hynek Cihlar
12:48 PM User Interface Feature #1805: add missing UI method support
Vadim: you have a typo on line 23: you need to have @display testt@ instead of @display test@. This was easily spotte... Constantin Asofiei
12:13 PM User Interface Feature #1805: add missing UI method support
I faced with the following conversion problem. The parser makes wrong annotations with links to @schemaname@, @bufnam... Vadim Gindin
02:53 PM Runtime Infrastructure Feature #2124: improve/simplify the startup of server-side batch processes and appserver "agent" ...
Constantin Asofiei wrote:
> Eric: I don't want to commit it until I update the directory.xml you use to run the serv...
Eric Faulhaber
12:59 PM Runtime Infrastructure Feature #2124: improve/simplify the startup of server-side batch processes and appserver "agent" ...
Constantin Asofiei wrote:
> Greg Shah wrote:
> > If I understand correctly, this contains fixes for all issues foun...
Greg Shah
10:24 AM Runtime Infrastructure Feature #2124: improve/simplify the startup of server-side batch processes and appserver "agent" ...
Greg Shah wrote:
> You can check in and distribute this when it passes testing.
Eric: I don't want to commit it unt...
Constantin Asofiei
09:53 AM Runtime Infrastructure Feature #2124: improve/simplify the startup of server-side batch processes and appserver "agent" ...
Greg Shah wrote:
> If I understand correctly, this contains fixes for all issues found in #1811 except for the probl...
Constantin Asofiei
09:48 AM Runtime Infrastructure Feature #2124: improve/simplify the startup of server-side batch processes and appserver "agent" ...
Code Review 0214h
The code changes look good. If I understand correctly, this contains fixes for all issues found...
Greg Shah
01:30 PM User Interface Feature #1811: implement the AJAX client driver
I'm OK with this update. Please manually test the following:
1. The admin console on the MAJIC server.
2. Normal...
Greg Shah
01:55 AM User Interface Feature #1811: implement the AJAX client driver
I builded a new jetty release. The good news are that web sockets are working now in Google Chrome 32. Marius Gligor
01:24 PM Base Language Feature #2145: eliminate program-name limitations
Greg Shah wrote:
> > my concern is that, if the PROPATH gets modified, we might resolve the relative name to a compl...
Constantin Asofiei
01:20 PM Base Language Feature #2145: eliminate program-name limitations
> my concern is that, if the PROPATH gets modified, we might resolve the relative name to a completely different prog... Greg Shah
09:06 AM Base Language Feature #2145: eliminate program-name limitations
This one proves a little more challenging: the procedure names in error messages and the procedure's @FILE-NAME@ and ... Constantin Asofiei
08:59 AM Base Language Feature #1634: implement full native library (.so or DLL) support
This update is merged up to bzr revision 10466. I am going back through runtime regression testing. The first run f... Greg Shah
08:56 AM Base Language Feature #1598 (Closed): shift LOG implementation (MathOps.log()) to BigDecimal
Greg Shah
07:32 AM Base Language Feature #1598: shift LOG implementation (MathOps.log()) to BigDecimal
Committed to bzr revision 10466. Hynek Cihlar
08:43 AM User Interface Feature #2240 (Closed): implement proper color support in the Swing ChUI and AJAX ChUI clients
Greg Shah
07:41 PM Base Language Feature #1624: add support for PUT CONTROL
Final update. Regression is running now. Evgeny Kiselev

02/14/2014

05:47 PM Base Language Feature #1598: shift LOG implementation (MathOps.log()) to BigDecimal
Code Review 0214a
The changes look good. You can check them in and distribute them.
Greg Shah
07:13 AM Base Language Feature #1598: shift LOG implementation (MathOps.log()) to BigDecimal
Introduced @toBigDecimal@ abstract method in @NumberType@ and fixed the file headers. The code changes passed regress... Hynek Cihlar
05:37 PM User Interface Feature #1805: add missing UI method support
Good findings. Go ahead and implement the proper behavior.... Greg Shah
05:56 AM User Interface Feature #1805: add missing UI method support
1) query is not opened.... Vadim Gindin
05:26 PM Base Language Feature #1624: add support for PUT CONTROL
Update the copyright dates and post the final update here. Then start regression testing (both conversion and runtim... Greg Shah
07:45 PM Base Language Feature #1624: add support for PUT CONTROL
Greg Shah wrote:
> Code Review 0208a
>
> 1. Does the @Steam.generateFormattedText()@ have implications when the s...
Evgeny Kiselev
02:53 PM Database Bug #2237: wrong historical annotations in dynamic temp-tables
Replaced the update with the new one with the small change.
It was committed to bzr in rev 10465 and distributed by ...
Ovidiu Maxiniuc
02:14 PM Database Bug #2237: wrong historical annotations in dynamic temp-tables
Ovidiu, you modified @p2o.xml@ and conversion testing has passed. The only other files that changed are new runtime c... Eric Faulhaber
01:58 PM Database Bug #2237: wrong historical annotations in dynamic temp-tables
This is the latest update that is not under testing.
It passed the conversion (I had to manually run the diff - there...
Ovidiu Maxiniuc
01:51 PM Database Bug #2237: wrong historical annotations in dynamic temp-tables
Ovidiu, please post the final update you used for testing and check it in and distribute once it has passed. Eric Faulhaber
12:19 PM Runtime Infrastructure Feature #2124: improve/simplify the startup of server-side batch processes and appserver "agent" ...
This one is merged with mag_upd20140213c.zip from #1811. Constantin Asofiei
09:31 AM Runtime Infrastructure Feature #2124: improve/simplify the startup of server-side batch processes and appserver "agent" ...
This update adds the scheduler cron support and will go into testing; contains other minor fixes too. Constantin Asofiei
09:27 AM Runtime Infrastructure Feature #2124: improve/simplify the startup of server-side batch processes and appserver "agent" ...
I'll use this node to document all the needed setup/configuration for the spawner infrastructure, used in appserver, ... Constantin Asofiei
12:00 PM User Interface Feature #1811: implement the AJAX client driver
Marius Gligor wrote:
> Here are the changes which passed today regression tests.
You can go ahead and release it.
Constantin Asofiei
11:49 AM User Interface Feature #1811: implement the AJAX client driver
Here are the changes which passed today regression tests. Marius Gligor
11:04 AM User Interface Feature #1811: implement the AJAX client driver
Marius Gligor wrote:
> I fixed this issue by replacing the "monospaced" with "monospace" in tty.screen.js line 377 b...
Constantin Asofiei
10:57 AM User Interface Feature #1811: implement the AJAX client driver
1. Regarding fonts: During development I realized that fonts are rendered slightly different on web browsers and Java... Marius Gligor
09:16 AM User Interface Feature #1811: implement the AJAX client driver
I found another problem in @ClientCore@ this time. There are cases when the P2J Client terminates via @System.exit@. ... Constantin Asofiei
07:26 AM User Interface Feature #1811: implement the AJAX client driver
Marius Gligor wrote:
> I saw that you already did some changes inside WebClientSpawner and the code was moved to Cli...
Constantin Asofiei
07:23 AM User Interface Feature #1811: implement the AJAX client driver
I saw that you already did some changes inside WebClientSpawner and the code was moved to ClientSpawner.
However the ...
Marius Gligor
07:15 AM User Interface Feature #1811: implement the AJAX client driver
Marius Gligor wrote:
> The bug must be fixed in line 123 as follow:
OK, I'll include the fix with my #2124 update, ...
Constantin Asofiei
07:07 AM User Interface Feature #1811: implement the AJAX client driver
Unfortunately I found another NPE bug which occur if the spawn or spawn.exe is missing.
In this case the ProcessBuil...
Marius Gligor
06:52 AM User Interface Feature #1811: implement the AJAX client driver
Marius Gligor wrote:
> I just manage to reproduce the bug. I started than I stopped the server without any other act...
Constantin Asofiei
06:46 AM User Interface Feature #1811: implement the AJAX client driver
I just manage to reproduce the bug. I started than I stopped the server without any other action and the bug occurs.
...
Marius Gligor
06:32 AM User Interface Feature #1811: implement the AJAX client driver
TemporaryAccountWorker thread is used to enable/disable temporary accounts.
Since this operation require a specific ...
Marius Gligor
06:12 AM User Interface Feature #1811: implement the AJAX client driver
It's a bug. In TemporaryAccountWorker line 119 I omitted to check the callerLatch for null value.
The correct code s...
Marius Gligor
05:38 AM User Interface Feature #1811: implement the AJAX client driver
Marius, I've managed to get a NPE in @TemporaryAccountPoolWorker@:... Constantin Asofiei
06:04 AM User Interface Feature #1787: implement batch mode support
Constantin, The config options to start batch mode is:
@swing="client:driver:type=chui_batch client:driver:backgroun...
Eugenie Lyzenko
05:05 AM User Interface Feature #1787: implement batch mode support
Eugenie, I've used this configuration to start a client, on linux: @client:driver:type=chui_batch client:mode:batch=t... Constantin Asofiei
04:47 AM Runtime Infrastructure Feature #2243: integrate spawn.c changes into winspawn.c
This task is for integrating the changes added to @spawn.c@ by #2124 into @winspawn.c@. Constantin Asofiei
04:45 AM Runtime Infrastructure Feature #2243 (Closed): integrate spawn.c changes into winspawn.c
Constantin Asofiei
02:16 AM Base Language Feature #2208: create a java application running web services for testing purposes
Evgeny Kiselev wrote:
> Where I can upload update ?
> I've ~20mb zip archive (with axis2 libs and configs).
Commi...
Constantin Asofiei
07:23 PM Base Language Feature #2208: create a java application running web services for testing purposes
Where I can upload update ?
I've ~20mb zip archive (with axis2 libs and configs).
Evgeny Kiselev

02/13/2014

04:20 PM Database Bug #2222: WRITE event triggered too early
As Eric affirmed in a mail I am _modifying some very sensitive code_.
The flush procedure (WRITE triggers and effect...
Ovidiu Maxiniuc
02:38 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
The assumption that they were using a circular linked list is valid, but the rules to add the new field-group are obs... Constantin Asofiei
08:36 AM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
> 1. Strange, but access sibling attributes (PREV-SIBLING, NEXT-SIBLING) of field-groups itself distorted generated g... Constantin Asofiei
01:30 PM Base Language Feature #1634: implement full native library (.so or DLL) support
All testcase updates and captured logs/output are checked into the testcases project.
The code has passed conversi...
Greg Shah
01:03 PM Base Language Feature #1634: implement full native library (.so or DLL) support
As can be seen from the logs, the remaining diffs are:
1. A missing error 86 in one call to output_float_from_buff...
Greg Shah
12:36 PM Base Language Feature #1634: implement full native library (.so or DLL) support
This incorporates many fixes and the code review feedback. It allows the API tests to run properly on Linux. The on... Greg Shah
01:17 PM Runtime Infrastructure Feature #2124: improve/simplify the startup of server-side batch processes and appserver "agent" ...
> You mean only the clients started with the spawner, right?
Right.
> we will at least need a broker to run on ...
Greg Shah
12:41 PM Runtime Infrastructure Feature #2124: improve/simplify the startup of server-side batch processes and appserver "agent" ...
Greg Shah wrote:
> Today we assume that the clients will run on the same system, but I see many use cases where that...
Constantin Asofiei
10:27 AM Runtime Infrastructure Feature #2124: improve/simplify the startup of server-side batch processes and appserver "agent" ...
> But I don't think I fully grasp the scenario you are referring to: if P2J server S1 wants to start a batch process... Greg Shah
10:08 AM Runtime Infrastructure Feature #2124: improve/simplify the startup of server-side batch processes and appserver "agent" ...
1. Looking inside the spawner.c code I understood that the spawner became an universal tool.
You add an option to g...
Marius Gligor
07:08 AM Runtime Infrastructure Feature #2124: improve/simplify the startup of server-side batch processes and appserver "agent" ...
About the scheduler and cron: there is the @Quartz@ library from Terracota released under @Apache Licence V2@: http:/... Constantin Asofiei
01:47 AM Runtime Infrastructure Feature #2124: improve/simplify the startup of server-side batch processes and appserver "agent" ...
Greg Shah wrote:
> My only concern is that the server is very tightly coupled to the command line generation for the...
Constantin Asofiei
07:06 PM Runtime Infrastructure Feature #2124: improve/simplify the startup of server-side batch processes and appserver "agent" ...
Code Review 0212e
I am OK with the changes.
My only concern is that the server is very tightly coupled to the c...
Greg Shah
01:09 PM User Interface Feature #1787: implement batch mode support
The update uploaded that implements the messageBox() processing for background mode for you to review. The simulated ... Eugenie Lyzenko
07:49 AM User Interface Feature #1787: implement batch mode support
Eugenie Lyzenko wrote:
> > Eugenie: the modal message boxes are not supported by background mode. On linux pro -b -p...
Constantin Asofiei
07:39 AM User Interface Feature #1787: implement batch mode support
> Eugenie: the modal message boxes are not supported by background mode. On linux pro -b -p with a MESSAGE ... VIEW-A... Eugenie Lyzenko
04:52 AM User Interface Feature #1787: implement batch mode support
LE: the @all the pro -b, bpro, and prowin32 -b ways of starting a batch program@ part needs to be expanded with (for ... Constantin Asofiei
04:40 AM User Interface Feature #1787: implement batch mode support
Eugenie: the modal message boxes are not supported by background mode. On linux @pro -b -p@ with a @MESSAGE ... VIEW-... Constantin Asofiei
12:23 PM User Interface Feature #1811: implement the AJAX client driver
Code Review 0213b
The changes look good. Please get it runtime regression tested.
Greg Shah
11:22 AM User Interface Feature #1811: implement the AJAX client driver
Renamed sync() method to initRemoteTerminal()
I implemented also the screen characters message caching.
Marius Gligor
10:52 AM User Interface Feature #1811: implement the AJAX client driver
OK. I have an idea to cache also the text messages. I'm going to implements this feature.
Marius Gligor
10:47 AM User Interface Feature #1811: implement the AJAX client driver
Code Review 0213a
I am fine with the code, except for 1 change. I should have looked more carefully at the @sync(...
Greg Shah
09:06 AM User Interface Feature #1811: implement the AJAX client driver
1. Regarding sync() method. This is a private method called from the onConnect(session) method, when a new session is... Marius Gligor
11:29 AM Database Feature #2140 (Review): use positional query substitution parameters in HQLPreprocessor and relat...
Committed to bzr revision 10462. Stanislav Lomany
09:08 AM User Interface Feature #2240 (Review): implement proper color support in the Swing ChUI and AJAX ChUI clients
Marius Gligor

02/12/2014

06:27 PM Base Language Feature #1598: shift LOG implementation (MathOps.log()) to BigDecimal
Code Review 0212a
It looks pretty good. Fix these minor issues and get it tested:
1. I'd prefer to add an abst...
Greg Shah
04:33 PM Base Language Feature #1598: shift LOG implementation (MathOps.log()) to BigDecimal
The attached file contains @log@ function implementation and related changes for review.
The implemented @log@ fun...
Hynek Cihlar
06:04 PM User Interface Feature #1811: implement the AJAX client driver
Code Review 0212a
1. Please note that our maximum line length is 98 characters. The docs haven't been updated. Y...
Greg Shah
12:42 PM User Interface Feature #1811: implement the AJAX client driver
1. AWT Color instances are build using now RGB values in ColorPalette.
2. The code used to set the Font color attr...
Marius Gligor
05:23 PM Base Language Feature #1634: implement full native library (.so or DLL) support
> or better:... Greg Shah
04:14 PM User Interface Feature #1805: add missing UI method support
I'm not sure. Having it on our list may be just a mistake. Please write a testcase (or find one in the testcases/ua... Greg Shah
01:57 PM User Interface Feature #1805: add missing UI method support
As far as I can see @DESELECT-ROWS@ method is really implemented.. What needs to be done in the task #2144 for this t... Vadim Gindin
03:59 PM Base Language Feature #1597 (Closed): shift SQRT implementation (MathOps.sqrt()) to BigDecimal
Greg Shah
02:04 PM Base Language Feature #1597: shift SQRT implementation (MathOps.sqrt()) to BigDecimal
Committed to revision 10461. Hynek Cihlar
10:37 AM Base Language Feature #1597: shift SQRT implementation (MathOps.sqrt()) to BigDecimal
Code Review 0209a
The code looks good. Please commit and distribute it.
Greg Shah
10:23 AM Base Language Feature #1597: shift SQRT implementation (MathOps.sqrt()) to BigDecimal
The attached file is the final version.
Note, that the previously added condition of @sqrt(?) == 1@ was removed. ...
Hynek Cihlar
02:22 PM Database Feature #2140: use positional query substitution parameters in HQLPreprocessor and related classes
This is something Greg or Ovidiu added specifically for composite data type support (specifically, datetime-tz), but ... Eric Faulhaber
02:02 PM Database Feature #2140: use positional query substitution parameters in HQLPreprocessor and related classes
I saw this code which is currently not active... Stanislav Lomany
01:45 PM Database Feature #2140: use positional query substitution parameters in HQLPreprocessor and related classes
Code review 20140212a:
Looks good, nice work. Once it passes the rest of regression testing, please check it in an...
Eric Faulhaber
09:44 AM Database Feature #2140 (WIP): use positional query substitution parameters in HQLPreprocessor and related ...
Minor update for MAJIC (fixed query in TmpSumCleanupContextHook). Stanislav Lomany
09:04 AM Database Feature #2140: use positional query substitution parameters in HQLPreprocessor and related classes
> How does this update take into account the parameter indices we are managing within the @HQLPreprocessor@ (see @par... Stanislav Lomany
01:34 PM Runtime Infrastructure Feature #2124: improve/simplify the startup of server-side batch processes and appserver "agent" ...
Greg, about your review notes:
A. from note 26:
1. the private key strength: 1024 bytes or better is enforced and i...
Constantin Asofiei
03:40 AM Runtime Infrastructure Feature #2124: improve/simplify the startup of server-side batch processes and appserver "agent" ...
Greg Shah wrote:
> > I want to have a central place to spawn P2J clients, regardless of their type, as this will all...
Constantin Asofiei
01:26 AM Base Language Feature #2208: create a java application running web services for testing purposes
Evgeny Kiselev wrote:
> Yes, you are right.
If you think you can solve this in 2-4 hours, then go ahead and solve i...
Constantin Asofiei

02/11/2014

05:48 PM Base Language Feature #2208: create a java application running web services for testing purposes
Yes, you are right. Evgeny Kiselev
02:12 PM Base Language Feature #2208: create a java application running web services for testing purposes
OK, I think I understand your problem: you are you using embedded AXIS2 web server, which does not support HTTPS. An... Constantin Asofiei
08:17 PM Base Language Feature #2208: create a java application running web services for testing purposes
I have problem with SSL. It's not possible to do it in the internal Axis2 web server(SimpleHttpServer).
Here is a ...
Evgeny Kiselev
05:47 PM Base Language Feature #1624: add support for PUT CONTROL
Code Review 0208a
1. Does the @Steam.generateFormattedText()@ have implications when the statement is not PUT CONT...
Greg Shah
05:41 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
I'm trying to identify when the Progress creates auxiliary field-group. There are possible 2 variants:
1. Progress cr...
Vadim Gindin
05:35 PM Database Feature #2140: use positional query substitution parameters in HQLPreprocessor and related classes
How does this update take into account the parameter indices we are managing within the @HQLPreprocessor@ (see @param... Eric Faulhaber
04:54 PM Database Feature #2140: use positional query substitution parameters in HQLPreprocessor and related classes
Update for review. Passed main part of regression testing. The main idea is to:
1. exclude explicit placeholders ("?...
Stanislav Lomany
05:34 PM User Interface Feature #1811: implement the AJAX client driver
Code Review 0211a
1. In ColorPalette, let's use RGB values instead of the AWT Color instances. This is more unive...
Greg Shah
05:25 PM User Interface Feature #1811: implement the AJAX client driver
> 2. According to the P4G manuals the DEFAULT_COLOR_TABLE has 16 colors (0...15) which are reserved, that is, SHOULD ... Greg Shah
12:54 PM User Interface Feature #1811: implement the AJAX client driver
> Seems that pfcolor 3 cannot be converted or not supported.
Looks like PFCOLOR is parsed ok and a valid AST is...
Hynek Cihlar
11:56 AM User Interface Feature #1811: implement the AJAX client driver
Based on the current COLOR implementation for ChUI native driver I implemented the COLOR for ChUI Swing driver too. (... Marius Gligor
04:37 PM Runtime Infrastructure Feature #2124: improve/simplify the startup of server-side batch processes and appserver "agent" ...
> I want to have a central place to spawn P2J clients, regardless of their type, as this will allow us to restrict th... Greg Shah
04:14 PM Runtime Infrastructure Feature #2124: improve/simplify the startup of server-side batch processes and appserver "agent" ...
Code Review 0207e
Sorry, it took me a while to digest this large update. It is quite good. It seems to me that t...
Greg Shah
12:08 PM Runtime Infrastructure Feature #2124: improve/simplify the startup of server-side batch processes and appserver "agent" ...
Greg Shah wrote:
> > keys are hard coded to 1024-bytes - should we make this configurable?
>
> Yes. Default to 1...
Constantin Asofiei
11:40 AM Runtime Infrastructure Feature #2124: improve/simplify the startup of server-side batch processes and appserver "agent" ...
> keys are hard coded to 1024-bytes - should we make this configurable?
Yes. Default to 1024 but allow other size...
Greg Shah
01:54 PM User Interface Bug #2241: Uncompilable code is generated when PFCOLOR option is used with DEFINE VARIABLE
Also note that PFCOLOR in the other statements doesn't generate the actual assignment. So the only option to set PFCO... Hynek Cihlar
01:51 PM User Interface Bug #2241: Uncompilable code is generated when PFCOLOR option is used with DEFINE VARIABLE
The code ... Hynek Cihlar
01:09 PM User Interface Bug #2241 (New): Uncompilable code is generated when PFCOLOR option is used with DEFINE VARIABLE
Hynek Cihlar
06:39 AM User Interface Feature #1787: implement batch mode support
This is the log after running run_batch.p on windev01 within an appserver. Same as input redirection on linux: all te... Constantin Asofiei
06:15 AM User Interface Feature #1787: implement batch mode support
Eugenie, I've ran the attached program (which executes all your tests except @batch_test0.p@) using the @pro -b -p ru... Constantin Asofiei

02/10/2014

04:16 PM User Interface Feature #1787: implement batch mode support
Testcases have been added. Eugenie Lyzenko
12:42 PM Runtime Infrastructure Feature #2124: improve/simplify the startup of server-side batch processes and appserver "agent" ...
We should not hard code the paths into the makefile. It is best to require that to be defined as a parameter on the a... Greg Shah
12:23 PM Runtime Infrastructure Feature #2124: improve/simplify the startup of server-side batch processes and appserver "agent" ...
Greg, a question: when using @JNI_CreateJavaVM@ to create a new JVM instance, the compiled code needs to link with th... Constantin Asofiei
07:48 AM Runtime Infrastructure Feature #2124: improve/simplify the startup of server-side batch processes and appserver "agent" ...
Greg Shah wrote:
> 0. As part of the installation/setup of spawn, we would have a keystore in the file system. That...
Constantin Asofiei
10:15 AM User Interface Feature #1811: implement the AJAX client driver
Today I did a lot of investigations related to COLOR implementation on CHUI Swing and WEB clients.
First I attached ...
Marius Gligor
08:51 AM User Interface Feature #1811: implement the AJAX client driver
Please add some javadoc to describe these important points. Greg Shah
02:14 AM User Interface Feature #1811: implement the AJAX client driver
We have 2 jetty handlers for two targets ./ and ./index.html which load the same page:
1. When the user is first r...
Marius Gligor
08:09 PM Base Language Feature #1624: add support for PUT CONTROL
1) Added conversion for @COPY-LOB@ from file to memptr
2) Added implementation for @COPY-LOB@
3) Added for @RAW@ ty...
Evgeny Kiselev

02/09/2014

01:08 PM User Interface Feature #1811: implement the AJAX client driver
I am not sure how the custom colors will be defined for the Swing and Web chuis, but at the moment color-map.xml may ... Hynek Cihlar
12:37 PM User Interface Feature #1811: implement the AJAX client driver
> Hynek recently added proper color support for our NCURSES/WIN32 Console based ChUI client (the ConsoleDriver which ... Hynek Cihlar
06:56 AM Database Bug #2236 (Review): HQL error generated from dynamically converted query with extent field refere...
Stanislav Lomany
06:26 AM Database Bug #2236: HQL error generated from dynamically converted query with extent field reference in wh...
Committed to bzr revision 10460. Stanislav Lomany

02/07/2014

06:52 PM Runtime Infrastructure Feature #2124: improve/simplify the startup of server-side batch processes and appserver "agent" ...
This adds the SSL certificate generation into the directory and the support to use this data to start processes / web... Constantin Asofiei
04:44 PM Runtime Infrastructure Feature #2124: improve/simplify the startup of server-side batch processes and appserver "agent" ...
Greg Shah wrote:
> The use of BouncyCastle is OK.
OK, Bouncy Castle is limited to only one class and is hidden behi...
Constantin Asofiei
07:58 AM Runtime Infrastructure Feature #2124: improve/simplify the startup of server-side batch processes and appserver "agent" ...
The use of BouncyCastle is OK. Greg Shah
04:08 AM Runtime Infrastructure Feature #2124: improve/simplify the startup of server-side batch processes and appserver "agent" ...
I saw that is a major code refactoring. As I understood the chuiWeb node will be replaced by a global node and per cl... Marius Gligor
07:47 PM Runtime Infrastructure Feature #2124: improve/simplify the startup of server-side batch processes and appserver "agent" ...
I've been trying not to add more external dependencies to the project and use what J2SE provides, but I couldn't find... Constantin Asofiei
06:39 PM User Interface Feature #1811: implement the AJAX client driver
Marius, I'm merging your 0206a.zip update with mine and mainPage and indexPage handlers in ChuiWebDriver.startupServe... Constantin Asofiei
12:53 PM User Interface Feature #1811: implement the AJAX client driver
First, I should have previously mentioned that details about the most recent color work can be found in #1801.
> 1...
Greg Shah
12:13 PM User Interface Feature #1811: implement the AJAX client driver
Today I started to work on issue #2240 regarding color implementation on swing and web chui clients.
I studied the i...
Marius Gligor
09:33 AM User Interface Feature #1811: implement the AJAX client driver
Update [mag_upd20140206a.zip]
Passed regression tests, committed to bzr revision 10459.
Marius Gligor
08:23 AM User Interface Feature #1811: implement the AJAX client driver
Yes. You just need to post your assessment of the regression testing into Redmine, not the results themselves. At t... Greg Shah
08:21 AM User Interface Feature #1811: implement the AJAX client driver
May I delete the attached files containing the test results? Marius Gligor
08:15 AM User Interface Feature #1811: implement the AJAX client driver
The tc_job_002 is expected to fail at that point, so this testing passes.
Please commit the update and distribute it.
Greg Shah
08:00 AM User Interface Feature #1811: implement the AJAX client driver
Here are the results of my regression tests.
For the first time the CTRL-C test passed.
The main test part has onl...
Marius Gligor
06:22 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
Well, I finished the test for the case of any sequence of DOWN and UP calls.
Test: _mixedupdown1.p_
Description: Th...
Vadim Gindin
05:31 PM Database Feature #2134: configurable denormalization of extent fields into individual fields in schema con...
From other side, it is even not needed: such properties already exists in LegacyField annotation:... Vadim Nebogatov
05:20 PM Database Feature #2134: configurable denormalization of extent fields into individual fields in schema con...
I added CustomExtentProperty as indicator that property was denormalized. I thought it was simpler. In principle, I a... Vadim Nebogatov
11:52 AM Database Feature #2134: configurable denormalization of extent fields into individual fields in schema con...
Vadim Nebogatov wrote:
> CustomExtentProperty annotation needed for remember denormalized property name, this “pseud...
Eric Faulhaber
08:22 AM Database Feature #2134: configurable denormalization of extent fields into individual fields in schema con...
Eric Faulhaber wrote:
> Why is the @@CustomExtentMethod@ annotation needed? Don't all the getter and setter methods ...
Vadim Nebogatov
03:38 PM Database Bug #2222: WRITE event triggered too early
OK, good work. Please go ahead and implement these changes and document the names of the test cases which you created... Eric Faulhaber
03:04 PM Database Bug #2222: WRITE event triggered too early
Write-to-db is NOT expected at the end of a block including:
- transactions,
- internal procedures
- fun...
Ovidiu Maxiniuc
02:42 PM Database Bug #2236: HQL error generated from dynamically converted query with extent field reference in wh...
> There are some new TODOs added to @TemporaryBuffer.copyAllRows@. What is the plan for those?
1. ...
Stanislav Lomany
09:55 AM Database Bug #2236: HQL error generated from dynamically converted query with extent field reference in wh...
Code review 20140205a:
In general, looks good. Please regression test.
There are some new TODOs added to @Tempo...
Eric Faulhaber
01:01 PM Database Bug #2237: wrong historical annotations in dynamic temp-tables
No 'strong' reason. Looking into @AbstractCollection@'s source code, both methods share the same implementation excep... Ovidiu Maxiniuc
12:08 PM Database Bug #2237: wrong historical annotations in dynamic temp-tables
> I have fixed that (see DynamicTablesHelper.java:858) before uploading the update.
Why not use @java.util.Set@'s @<...
Eric Faulhaber
09:43 AM User Interface Feature #2238 (Closed): investigate and resolve issues related to browser "session management"
Greg Shah
09:07 AM User Interface Feature #2238 (Review): investigate and resolve issues related to browser "session management"
Marius Gligor
09:42 AM User Interface Feature #2212 (Closed): design websockets protocol for bidirectional communication between the ja...
Greg Shah
09:30 AM User Interface Feature #2212: design websockets protocol for bidirectional communication between the javascript ...
Update [mag_upd20140206a.zip]
Passed regression tests, committed to bzr revision 10459.
Marius Gligor
09:07 AM User Interface Feature #2212 (Review): design websockets protocol for bidirectional communication between the ja...
Marius Gligor
04:11 AM User Interface Feature #2240 (WIP): implement proper color support in the Swing ChUI and AJAX ChUI clients
Marius Gligor

02/06/2014

05:29 PM Database Feature #2134: configurable denormalization of extent fields into individual fields in schema con...
Eric Faulhaber wrote:
> This will require that you become familiar with the @HQLPreprocessor@ class, since it is her...
Eric Faulhaber
05:24 PM Database Feature #2134: configurable denormalization of extent fields into individual fields in schema con...
Thank you for providing the tests and especially the hints and conversion output; it is very helpful for doing the re... Eric Faulhaber
01:16 PM Runtime Infrastructure Feature #2124: improve/simplify the startup of server-side batch processes and appserver "agent" ...
Attached update contains the scheduler support, used to launch the appserver and batch processes. The spawner infrast... Constantin Asofiei
11:14 AM Runtime Infrastructure Feature #2124: improve/simplify the startup of server-side batch processes and appserver "agent" ...
> do we need to provide a way to read into the directory an existing configuration? I.e. for MAJIC, it will read the ... Greg Shah
11:11 AM Runtime Infrastructure Feature #2124: improve/simplify the startup of server-side batch processes and appserver "agent" ...
Greg, about the security configuration (keystores, truststores, etc):
# do we need to provide a way to read into the...
Constantin Asofiei
12:44 PM User Interface Feature #1811: implement the AJAX client driver
I sow now that is missing. It wasn't add to bzr. I will include this file also on the next commit.
Thanks.
Marius Gligor
12:38 PM User Interface Feature #1811: implement the AJAX client driver
Marius, a note about 0129a.zip: the archive has a @tty.keymap.js@ file which is not in bzr rev 10457. Please check 01... Constantin Asofiei
12:11 PM User Interface Feature #1811: implement the AJAX client driver
Hynek recently added proper color support for our NCURSES/WIN32 Console based ChUI client (the ConsoleDriver which is... Greg Shah
12:06 PM User Interface Feature #1811: implement the AJAX client driver
OK. Get this regression tested. Greg Shah
12:02 PM User Interface Feature #1811: implement the AJAX client driver
From my point of view I think no. Marius Gligor
11:57 AM User Interface Feature #1811: implement the AJAX client driver
Code Review 0206a
It looks really good. Other than adding real color support, is there anything else left to do?
...
Greg Shah
11:45 AM User Interface Feature #1811: implement the AJAX client driver
Sorry, it was my mistake. I have a short script to build the archive and I had a small problem inside the script.
Pl...
Marius Gligor
10:50 AM User Interface Feature #1811: implement the AJAX client driver
Were the changes to tty.screen.js and tty.socket.js deliberately removed from 0206a? Greg Shah
10:14 AM User Interface Feature #1811: implement the AJAX client driver
1. The WAIT_TO_DIE javadoc is inaccurate.
Done.
2. Please rename the sartWatchdog() to startWatchdog().
Do...
Marius Gligor
12:08 PM User Interface Feature #2240 (Closed): implement proper color support in the Swing ChUI and AJAX ChUI clients
Greg Shah
10:17 AM Base Language Feature #1597: shift SQRT implementation (MathOps.sqrt()) to BigDecimal
Looks great! Greg Shah
10:02 AM Base Language Feature #1597: shift SQRT implementation (MathOps.sqrt()) to BigDecimal
Yes, the "4GL" is a typo, thanks for catching it. I am attaching a fix and sending it to regression test. Hynek Cihlar
08:15 AM Base Language Feature #1597: shift SQRT implementation (MathOps.sqrt()) to BigDecimal
Code Review 0205a
This looks good.
My only question is about this table:...
Greg Shah
07:20 PM Base Language Feature #1597: shift SQRT implementation (MathOps.sqrt()) to BigDecimal
The input of one is covered by the initial approximation, but yes it won't hurt if stated explicitly.
New in the a...
Hynek Cihlar

02/05/2014

03:04 PM User Interface Feature #1811: implement the AJAX client driver
Code Review 0205a
1. The WAIT_TO_DIE javadoc is inaccurate.
2. Please rename the sartWatchdog() to startWatchdo...
Greg Shah
10:29 AM User Interface Feature #1811: implement the AJAX client driver
Here are the latest changes. I fixed also the issue related to isatty() when using spawner.
It was a bug on my spawn...
Marius Gligor
09:03 AM Base Language Feature #1624: add support for PUT CONTROL
> except wrong conversion of @copy-lob from file "test_put_control.txt" to m.@. P2J convert it's in uncompilable code... Greg Shah
07:58 PM Base Language Feature #1624: add support for PUT CONTROL
... Evgeny Kiselev
04:53 AM Database Bug #2236 (WIP): HQL error generated from dynamically converted query with extent field reference...
Update for review. Contains:
1. fix for this issue
2. part of COPY-TEMP-TABLE functionality
3. fix for BUFFER-VALU...
Stanislav Lomany

02/04/2014

05:48 PM Database Feature #2134: configurable denormalization of extent fields into individual fields in schema con...
I have attached vmn_upd20140204a.zip for your review.
Updated with latest bzr revision 10458.
Test cases were ...
Vadim Nebogatov
03:12 PM User Interface Feature #1811: implement the AJAX client driver
Indeed. The watchdog timer has been designed to terminate the process when the user close the browser.
Even more whe...
Marius Gligor
02:47 PM User Interface Feature #1811: implement the AJAX client driver
Greg Shah wrote:
> 3. As Constantin noted above, it is a common case for these clients to be left running for a very...
Constantin Asofiei
01:26 PM User Interface Feature #1811: implement the AJAX client driver
Code Review 0204a
Overall, this is very good.
1. In ChuiWebSimulator, please synchonize any access or assignmen...
Greg Shah
09:40 AM User Interface Feature #1811: implement the AJAX client driver
Here is the implementation of text attributes (color)
I found the following attributes defined (see ColorAttribute)....
Marius Gligor
08:17 PM User Interface Feature #1811: implement the AJAX client driver
> - the untrusted connection issue will be annoying for "live" usage; for testing is OK, but having to go through thi... Greg Shah
08:11 PM User Interface Feature #1811: implement the AJAX client driver
Code Review 0203b
I am fine with this change.
Greg Shah
03:11 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
Vadim Gindin wrote:
> Field-group creation is seemed straightforward except @UP@ direction.
OK, I understand now. M...
Constantin Asofiei
08:49 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
Constantin Asofiei wrote:
> Greg: Vadim I think is talking about a way to identify a field-group without using the h...
Vadim Gindin
01:17 PM Database Bug #2236: HQL error generated from dynamically converted query with extent field reference in wh...
I'll post the testcase here.... Stanislav Lomany
10:09 AM Database Bug #2222: WRITE event triggered too early
Please see the last notes of VALIDATE statement, in ABL Reference rev 10.2B, page 1115. Ovidiu Maxiniuc
09:47 AM Runtime Infrastructure Feature #2124: improve/simplify the startup of server-side batch processes and appserver "agent" ...
> Currently, Utils.getDirectoryNode APIs do not allow for this kind of search: this is either per-server or per-accou... Greg Shah
09:45 AM Runtime Infrastructure Feature #2124: improve/simplify the startup of server-side batch processes and appserver "agent" ...
Greg, another issue: to automatically launch processes via the scheduler, I want to be able to read the various confi... Constantin Asofiei
08:43 AM Runtime Infrastructure Feature #2124: improve/simplify the startup of server-side batch processes and appserver "agent" ...
> we need a secure way of launching a process under a user without access to the user's password
How about this id...
Greg Shah
07:41 AM Runtime Infrastructure Feature #2124: improve/simplify the startup of server-side batch processes and appserver "agent" ...
> Another improvement that we can do is to keep the \n when we read the password.
> Doing so the spawner cannot be u...
Greg Shah
04:00 AM Runtime Infrastructure Feature #2124: improve/simplify the startup of server-side batch processes and appserver "agent" ...
Marius Gligor wrote:
> 1. The credentials used by spawner are user/password of the user account, that is, the user m...
Constantin Asofiei
02:25 AM Runtime Infrastructure Feature #2124: improve/simplify the startup of server-side batch processes and appserver "agent" ...
Marius Gligor wrote:
> 1. The credentials used by spawner are user/password of the user account, that is, the user m...
Marius Gligor
02:20 AM Runtime Infrastructure Feature #2124: improve/simplify the startup of server-side batch processes and appserver "agent" ...
1. The credentials used by spawner are user/password of the user account, that is, the user must have an account.
...
Marius Gligor

02/03/2014

06:57 PM Base Language Feature #1624: add support for PUT CONTROL
The first testcase above has a bug (you write out 257 bytes but size the memptr at 256).
Also, it doesn't test the...
Greg Shah
07:15 PM Base Language Feature #1624: add support for PUT CONTROL
updated tests.... Evgeny Kiselev
06:46 PM Base Language Feature #1597: shift SQRT implementation (MathOps.sqrt()) to BigDecimal
Code Review 0203b
Overall, this is very good.
1. Should we put a quick out for BigDecimal.ONE?
2. Add javado...
Greg Shah
04:45 PM Base Language Feature #1597 (Review): shift SQRT implementation (MathOps.sqrt()) to BigDecimal
Hynek Cihlar
09:51 AM Base Language Feature #1597: shift SQRT implementation (MathOps.sqrt()) to BigDecimal
Attached file changes the precision of the sqrt algorithm to be defined by @decimal.MAX_SCALE@. Hynek Cihlar
05:06 AM Base Language Feature #1597: shift SQRT implementation (MathOps.sqrt()) to BigDecimal
I didn't realize the evaluator already casts the operands to proper types. Attached is the updated code.
Hynek Cihlar
06:25 PM Base Language Feature #1599: shift EXP implementation (MathOps.pow()) to BigDecimal
There are 3 other versions of pow() and these all resolve down to using @Math.pow()@ and @double@. These need to be ... Greg Shah
04:49 PM Base Language Feature #1599: shift EXP implementation (MathOps.pow()) to BigDecimal
The title of the issue mentions pow and exp. @MathOps@ contains only @pow@ method, but that is already using @BigDeci... Hynek Cihlar
05:50 PM Runtime Infrastructure Feature #2124: improve/simplify the startup of server-side batch processes and appserver "agent" ...
Yes, I understand the problem.
> if possible (maybe by giving the spawner app higher privileges), start the proces...
Greg Shah
03:53 PM Runtime Infrastructure Feature #2124: improve/simplify the startup of server-side batch processes and appserver "agent" ...
Greg, a question about launching a process using the spawner. Currently, the @spawn@ application requires as input va... Constantin Asofiei
04:44 PM Base Language Feature #1598 (WIP): shift LOG implementation (MathOps.log()) to BigDecimal
Hynek Cihlar
04:03 PM Database Feature #2207: Remaining issues for dynamic buffers and dynamic tables
About the issue in note 3. What P2J does in this case:... Stanislav Lomany
03:16 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
Greg: Vadim I think is talking about a way to identify a field-group without using the handle ID in 4GL code, not in ... Constantin Asofiei
03:05 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
The NAME can still be interrogated from converted 4GL code, right? That means there could be code that relies upon t... Greg Shah
01:58 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
I found that I can use the @NAME@ attribute for that purpose (mark the field-group). This attribute has unknown value... Vadim Gindin
12:31 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
I tried to find out what algorithm is used to generate new field-groups and to reuse existed. The case 3 in my previo... Vadim Gindin
08:13 AM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
I assume it is possible to access the PRIVATE-DATA for a FIELD-GROUP widget in 4GL code, which means using that attri... Greg Shah
02:27 PM Database Bug #2222: WRITE event triggered too early
Ovidiu Maxiniuc wrote:
> * The AVM performs validation when it leaves a field.
> What does "leaves" means ?
Thi...
Eric Faulhaber
02:11 PM Database Bug #2222: WRITE event triggered too early
I encountered two sentences that look interesting from the WRITE-trigger pov:
* The AVM performs validation when i...
Ovidiu Maxiniuc
12:18 PM User Interface Feature #1811: implement the AJAX client driver
In regard to the libffi issue, please see note 74 in #1634. Greg Shah
12:05 PM User Interface Feature #1811: implement the AJAX client driver
During the weekend I tried to do some tests on Windows OS and I found two important issues:
1. The File.renameTo(F...
Marius Gligor
10:31 AM User Interface Feature #1811: implement the AJAX client driver
In regard to 0203a, I have some minor concerns with the ClientDriver changes, but please go ahead and commit/distribu... Greg Shah
09:52 AM User Interface Feature #1811: implement the AJAX client driver
The changes look good to me. If Greg has no objections, you can release them. Constantin Asofiei
09:45 AM User Interface Feature #1811: implement the AJAX client driver
Here are the package that I used today on the regression tests.
Passed the regression tests.
Marius Gligor
10:12 AM Database Feature #2024: implement runtime support for database triggers
The @om_upd20140130b.zip@ update fixes a schema-trigger conversion bug when the project contains access to temp-table... Ovidiu Maxiniuc
08:13 AM Database Feature #2024: implement runtime support for database triggers
I wasn't expecting special issues as the update only affects schema triggers and majic does not use them.
Surprising...
Ovidiu Maxiniuc
09:51 AM Database Feature #1662: runtime support for table parameters
Also, NO-ERROR option is not properly handled. Stanislav Lomany
09:49 AM Database Feature #1662: runtime support for table parameters
Issue noted in note 4 in #2207 also affects table parameters. The only difference is that the records can't be partia... Stanislav Lomany

02/02/2014

06:42 PM Base Language Feature #1597: shift SQRT implementation (MathOps.sqrt()) to BigDecimal
Attached are the changes for initial review.
The implemented algorithm yields the same results as the native Progr...
Hynek Cihlar

02/01/2014

08:42 AM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
Vadim Gindin wrote:
> There are an array of predefined FIELD-GROUP ids and we are calculating actual index (fgidx) i...
Constantin Asofiei
06:09 AM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
There are possible several principally different cases:
1. Simple case: All DOWN calls have equal steps size. As it ...
Vadim Gindin

01/31/2014

02:35 PM User Interface Feature #1811: implement the AJAX client driver
Marius, about 0131c.zip:
* please make an update without the JS changes in the .html files, and get it conversion te...
Constantin Asofiei
11:31 AM User Interface Feature #1811: implement the AJAX client driver
1. The user Refresh action could not be detected. Is the same like closing the browser.
When the user reload the ...
Marius Gligor
08:28 AM User Interface Feature #1811: implement the AJAX client driver
I added the ClientDriver log file redirection implementation. Marius Gligor
08:11 AM User Interface Feature #1811: implement the AJAX client driver
1. The redirection to a log file is not possible from ProcessBuilder because we redirect the stderr for spawner not f... Marius Gligor
07:40 AM User Interface Feature #1811: implement the AJAX client driver
Marius Gligor wrote:
> 1. Put screen color message statement isn't implemented on the web client. I have to check ho...
Constantin Asofiei
06:45 AM User Interface Feature #1811: implement the AJAX client driver
A better way to prevent back navigation by editing history.
Marius Gligor
06:01 AM User Interface Feature #1811: implement the AJAX client driver
1. Put screen color message statement isn't implemented on the web client. I have to check how to do that. Could you ... Marius Gligor
05:33 AM User Interface Feature #1811: implement the AJAX client driver
Marius, 0131a.zip solves the login problem (I'll let Greg do a full review), but there are some other issues in MAJIC... Constantin Asofiei
03:07 AM User Interface Feature #1811: implement the AJAX client driver
I fixed the issue related to server key store import. It was a misunderstanding related to implementation.
For a web...
Marius Gligor
01:12 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
Marasmus... there is no shift. It's my mistake. It because of wrong order of operations: displaying the value, execut... Vadim Gindin
11:28 AM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
Constantin Asofiei wrote:
> The field-groups are used to group widgets together (as their names say). It is a lot ea...
Vadim Gindin
08:57 AM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
Vadim Gindin wrote:
> I just don't understand the logic of field-groups. Why authors decided to use spare field-grou...
Constantin Asofiei
09:24 AM Database Feature #2207: Remaining issues for dynamic buffers and dynamic tables
Stas, please put your work on the COPY-TEMP-TABLE handle method on hold. As we discussed previously, this method is n... Eric Faulhaber
07:47 AM Database Feature #2207: Remaining issues for dynamic buffers and dynamic tables
FYI, there is the problem with @COPY-TEMP-TABLE@. Consider the tables... Stanislav Lomany
09:20 AM Base Language Feature #1624: add support for PUT CONTROL
It is close. Some things to add:
1. I think the testing code is too dependent upon using a delimiter. In a scena...
Greg Shah
08:03 AM Base Language Feature #1624: add support for PUT CONTROL
Is this test correct ?... Evgeny Kiselev
06:45 AM Base Language Feature #1624 (WIP): add support for PUT CONTROL
Evgeny Kiselev
03:09 AM User Interface Feature #2212: design websockets protocol for bidirectional communication between the javascript ...
Correct post location is Feature #1811. Please delete my posts. Marius Gligor
03:05 AM User Interface Feature #2212: design websockets protocol for bidirectional communication between the javascript ...
I fixed the issue related to server key store import. It was a misunderstanding related to implementation.
For a web...
Marius Gligor

01/30/2014

06:16 PM User Interface Feature #1811: implement the AJAX client driver
> 1. The browser context menu can be controlled from JS on all major web browsers IE, Firefox and Chrome:
Go ahead...
Greg Shah
01:56 PM User Interface Feature #1811: implement the AJAX client driver
OK Constatin thanks. Tomorrow I will try to fix this issue.
Are you did tests with the web client? How it's works?
Marius Gligor
01:52 PM User Interface Feature #1811: implement the AJAX client driver
Marius Gligor wrote:
> I think that using the temporary accounts implementation is OK to authenticate for server key...
Constantin Asofiei
01:43 PM User Interface Feature #1811: implement the AJAX client driver
OK. In this case I have to do some changes on the ClientCore and potentially on other places.
I think that using the...
Marius Gligor
01:36 PM User Interface Feature #1811: implement the AJAX client driver
Marius Gligor wrote:
> At this moment what I understood is as follow:
> 1. Use the temporary account to connect to ...
Constantin Asofiei
01:33 PM User Interface Feature #1811: implement the AJAX client driver
OK. I have to think to this issue.
At this moment what I understood is as follow:
1. Use the temporary account...
Marius Gligor
12:57 PM User Interface Feature #1811: implement the AJAX client driver
Marius, I think there is a problem with the temporary accounts. If I understood properly, the process of authenticat... Constantin Asofiei
12:20 PM User Interface Feature #1811: implement the AJAX client driver
The changes inside the mag_upd20140129a.zip archive has been committed to bzr revision 10457 Marius Gligor
11:33 AM User Interface Feature #1811: implement the AJAX client driver
Please check in and distribute the 0129a update. Make sure to post the bzr revision number here. Greg Shah
11:24 AM User Interface Feature #1811: implement the AJAX client driver
Regarding browser session and JS code.
The web browser are designed to navigate over the Internet and for security ...
Marius Gligor
11:08 AM User Interface Feature #1811: implement the AJAX client driver
After three executions of CTRL-C part regression tests I obtained the same results (see attachments).
The main part ...
Marius Gligor
08:11 AM User Interface Feature #1811: implement the AJAX client driver
> To avoid any confusions maybe is better to eliminate the Dojo zip from CLASSPATH (from manifest file).
No, it is...
Greg Shah
07:49 AM User Interface Feature #1811: implement the AJAX client driver
To avoid any confusions maybe is better to eliminate the Dojo zip from CLASSPATH (from manifest file).
We could add ...
Marius Gligor
07:44 AM User Interface Feature #1811: implement the AJAX client driver
> The Dojo dependencies zip file is always in the CLASSPATH because is in the list of dependencies inside the manifes... Greg Shah
07:43 AM User Interface Feature #1811: implement the AJAX client driver
> Maybe for safety it's a good idea to design and implements something like a "watchdog" timer used to force an exit ... Greg Shah
06:40 AM User Interface Feature #1811: implement the AJAX client driver
When the page having the JS code running is loaded a WebSocket connection is open.
If the user close the browser the...
Marius Gligor
02:28 AM User Interface Feature #1811: implement the AJAX client driver
The Dojo dependencies zip file is always in the CLASSPATH because is in the list of dependencies inside the manifest ... Marius Gligor
04:09 PM Database Feature #2024 (WIP): implement runtime support for database triggers
Temporarily re-opening this issue to post Ovidiu's update to fix some problems with trigger conversion. Ovidiu, pleas... Eric Faulhaber
03:52 PM Database Feature #2134: configurable denormalization of extent fields into individual fields in schema con...
I have attached vmn_upd20140130a.zip with first tests results containing examples of generated DMOs, table hints and ... Vadim Nebogatov
02:33 PM Base Language Feature #2145: eliminate program-name limitations
> This suggests that looking into the java stack trace is not correct.
Yes. At the time it was originally coded, ...
Greg Shah
01:46 PM Base Language Feature #2145: eliminate program-name limitations
This suggests that looking into the java stack trace is not correct. Instead, @ControlFlowOps@ should keep a stack f... Constantin Asofiei
01:05 PM Base Language Feature #2145: eliminate program-name limitations
To understand the limitations of the P2J @PROGRAM-NAME@ implementation, please see the JavaDoc for @EnvironmentOps.ge... Greg Shah
02:16 AM User Interface Feature #2238 (WIP): investigate and resolve issues related to browser "session management"
Marius Gligor

01/29/2014

06:14 PM User Interface Feature #1788: implement define rectangle and rectangle widget support
For now this will only be implemented in ChUI mode.
Start by writing 4GL testcases to show the features of the rec...
Greg Shah
05:29 PM User Interface Feature #1811: implement the AJAX client driver
For #2238: the following are some potential issues that we need to consider/research. Document your thoughts and fin... Greg Shah
05:18 PM User Interface Feature #1811: implement the AJAX client driver
Code Review 0129a
There are no concerns. Please note that I don't plan to check in the Dojo build, into bzr. I a...
Greg Shah
02:05 PM User Interface Feature #1811: implement the AJAX client driver
Here is the package that I tested today. The package contains the new jetty 9.1 build.
Due to it size the Dojo zip f...
Marius Gligor
05:20 PM User Interface Feature #2238: investigate and resolve issues related to browser "session management"
Please put all history into the parent task, #1811. Greg Shah
05:20 PM User Interface Feature #2238 (Closed): investigate and resolve issues related to browser "session management"
Greg Shah
12:28 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Technically note is correct. I can write "initialize sizer for extent fields and do not initialize for non-extent fie... Stanislav Lomany
11:35 AM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Stanislav Lomany wrote:
> ...
Eric Faulhaber
07:08 AM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
@FieldReference.value(int)@ was broken. I'll include this fix in my next update.... Stanislav Lomany
12:27 PM Base Language Feature #1634: implement full native library (.so or DLL) support
... continued
*common-progress.rules*
is good except for the fact that maybe we should make the condition at line ...
Ovidiu Maxiniuc
11:33 AM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
I just don't understand the logic of field-groups. Why authors decided to use spare field-group?! I just don't see an... Vadim Gindin

01/28/2014

04:23 PM Base Language Feature #1634: implement full native library (.so or DLL) support
Greg Shah wrote:
> ...
> Ovidiu: please review the rules/include/* changes, in regard to assign trigger var def sup...
Ovidiu Maxiniuc
07:54 PM Base Language Feature #1634: implement full native library (.so or DLL) support
OK. Now we are completely using our own libffi Windows builds.
Building libffi libraries from sources using MSYS a...
Eugenie Lyzenko
02:30 PM User Interface Feature #1811: implement the AJAX client driver
Code Review 0128c
The code looks good.
> but just for safety is OK.
Exactly.
> 1. We are not use Dojo at ...
Greg Shah
01:47 PM User Interface Feature #1811: implement the AJAX client driver
I did the changes. Normally no concurrency should occur on this class but just for safety is OK.
I have two other ...
Marius Gligor
01:28 PM User Interface Feature #1811: implement the AJAX client driver
> Sorry, but I don't find any place in this class to use synchronization.
> The open and close methods are synchroni...
Greg Shah
01:13 PM User Interface Feature #1811: implement the AJAX client driver
Sorry, I changed the date of last changes on the ClientBuilderOptions class header. Marius Gligor
01:08 PM User Interface Feature #1811: implement the AJAX client driver
1. Done. ChuiWebSimulator.onConnect allow us to set the session idle time out which in turn override the default valu... Marius Gligor
12:52 PM User Interface Feature #1811: implement the AJAX client driver
> The ConcurrentHashMap is fully thread safe by design and is internally synchronized.
> The Java concurrent package...
Greg Shah
11:44 AM User Interface Feature #1811: implement the AJAX client driver
I added the missing Result class.
The ConcurrentHashMap is fully thread safe by design and is internally synchronize...
Marius Gligor
11:33 AM User Interface Feature #1811: implement the AJAX client driver
Code Review 0128a
1. In ChuiWebSimulator, I would like to shift to an idle timeout (maxIdleTime) that is set progr...
Greg Shah
10:46 AM User Interface Feature #1811: implement the AJAX client driver
Here is the implementation for CTRL-C issue and some remarks.
1. A Result object is used instead a boolean value.
...
Marius Gligor
01:42 PM Database Bug #2237: wrong historical annotations in dynamic temp-tables
Looks like this update fixes the issue.
The table legacy name is also added to in-memory AST. When TRPL (p2o.xml) is...
Ovidiu Maxiniuc
09:49 AM Database Bug #2237: wrong historical annotations in dynamic temp-tables
Here is a more complex sample case:... Ovidiu Maxiniuc
09:43 AM Database Bug #2237 (WIP): wrong historical annotations in dynamic temp-tables
When creating dynamic temp-tables the field and table annotations are wrong. I could reproduce this in dynamic querie... Ovidiu Maxiniuc
09:38 AM Database Bug #2237 (Closed): wrong historical annotations in dynamic temp-tables
Ovidiu Maxiniuc
01:38 PM Database Feature #1662: runtime support for table parameters
> * I was a bit confused by the deferred copy error processing in @TemporaryBuffer@, with the corresponding change in... Stanislav Lomany
10:59 AM Database Feature #2207: Remaining issues for dynamic buffers and dynamic tables
The first issue is not a dynamic tables issue, it is about undo processing for NO-UNDO temp tables. The same result c... Stanislav Lomany
05:46 AM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
Greg Shah wrote:
> I prefer an approach where multiuple virtual widgets on the server resolve to the correct widget ...
Constantin Asofiei
05:32 AM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
We need be careful when using conditional down (@DOWN WITH FRAME f1@, without an expression) and explicit down (i.e. ... Constantin Asofiei

01/27/2014

06:29 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
As we are getting close to the time for implementation, I want to mention something.
I would like to consider an i...
Greg Shah
06:12 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
I suppose I can formulate some rule, interpreting the rules, that Progress uses to fill fields with values.
We have ...
Vadim Gindin
05:43 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
Constantin Asofiei wrote:
> > The only unclear moment is the algorithm of Fill-in filling with values for me.
> I'm...
Vadim Gindin
04:06 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
> The only unclear moment is the algorithm of Fill-in filling with values for me.
I'm not sure what you are refering...
Constantin Asofiei
03:58 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
I've committed all test procedures I had.
The result of stream test _(streams.p)_ is in file _2162_ext_frame_stre...
Vadim Gindin
10:35 AM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
Please commmit the tests for note 36/37 to bzr.
> About cyclic order of field groups I confirm it. All tests show i...
Constantin Asofiei
05:59 PM Base Language Feature #1634: implement full native library (.so or DLL) support
> What if to build libffi in mingw we have to set up MSYS? Is it acceptable?
Yes. But we would only use that envi...
Greg Shah
05:44 PM Base Language Feature #1634: implement full native library (.so or DLL) support
Greg, the question. What if to build libffi in mingw we have to set up MSYS? Is it acceptable? Eugenie Lyzenko
02:34 PM Base Language Feature #1634: implement full native library (.so or DLL) support
The update evl_upd20140127a.zip committed in bzr as 10456. No regression testing required, only Windows syntax code w... Eugenie Lyzenko
01:38 PM Base Language Feature #1634: implement full native library (.so or DLL) support
Conversion regression testing for ges_upd20140127a.zip has passed. No change occurs in the output. This has been ch... Greg Shah
01:31 PM Base Language Feature #1634: implement full native library (.so or DLL) support
Code Review evl_upd20140127.zip
The change is fine. Check it in and distribute it. Then post the revision number...
Greg Shah
01:02 PM Base Language Feature #1634: implement full native library (.so or DLL) support
The updates fixes compilation error on Wndows. Also the binaries allow to build p2j.dll on Windows. Has both 64-bit a... Eugenie Lyzenko
11:27 AM Base Language Feature #1634: implement full native library (.so or DLL) support
This update has some important fixes to make the commons cases work. There is still at least 1 known problem (dealin... Greg Shah
08:49 AM Base Language Feature #1634: implement full native library (.so or DLL) support
Do you have the compilation fixes ready now? If so, please upload them for review.
Have you resolved the way to b...
Greg Shah
01:29 PM Database Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
Update to Hibernate sources. Committed to bzr revision 10454. Stanislav Lomany
11:23 AM Database Feature #2134: configurable denormalization of extent fields into individual fields in schema con...
The unique index is needed; it is part of the legacy metadata schema and an application may include code which relies... Eric Faulhaber
10:23 AM Database Feature #1651 (Closed): add support for dynamic database features
Eric Faulhaber
10:22 AM Database Feature #1655 (Closed): add conversion and runtime support for certain dynamic database attribute...
This update fixes problems with the columnLabel and validateExpression annotations (refs #1655), encountered while co... Eric Faulhaber
09:51 AM User Interface Feature #1811: implement the AJAX client driver
Code Review 0127a
I am fine with the code. It looks very good.
My only request is for tty.keyboard.js, tty.key...
Greg Shah
09:40 AM User Interface Feature #1811: implement the AJAX client driver
> B. Another solution is to use the existing RemoteObject to get a new account and do a re-logon. This scenario shoul... Greg Shah
08:30 AM User Interface Feature #1811: implement the AJAX client driver
1. Today I did a code review over the JS code. The changes are attached.
2. Also I started to investigate the CTRL...
Marius Gligor

01/26/2014

06:26 PM Database Feature #2134: configurable denormalization of extent fields into individual fields in schema con...
Could you check my last question (note 45) about order? Similar question should be addressed with newly added @fieldI... Vadim Nebogatov
09:25 PM Database Feature #1655 (Test): add conversion and runtime support for certain dynamic database attributes ...
The attached, merged update passed regression testing and was committed by Ovidiu to bzr rev. 10452.
I encountered...
Eric Faulhaber
08:30 PM Database Feature #1652 (Closed): add conversion and runtime support for dynamically prepared temp-tables
Eric Faulhaber
08:29 PM Database Bug #2236: HQL error generated from dynamically converted query with extent field reference in wh...
Failing test case is dbuf-query-extent1-dt.p (Stanislav: please provide test case; it is not currently in the testcas... Eric Faulhaber
08:19 PM Database Bug #2236 (Closed): HQL error generated from dynamically converted query with extent field refere...
Eric Faulhaber
08:15 PM Database Feature #2235: fix deployment issues related to dynamic database conversion resources
In #1652, note 135, Stanislav wrote:
> The following files and directories have to be accessed from the server class...
Eric Faulhaber
08:09 PM Database Feature #2235 (Closed): fix deployment issues related to dynamic database conversion resources
Eric Faulhaber
08:06 PM Database Feature #1662 (Closed): runtime support for table parameters
Eric Faulhaber

01/25/2014

04:57 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
About cyclic order of field groups I confirm it. All tests show it. About Fill-in fields - they have equal IDs at all... Vadim Gindin
07:11 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
Here are next tests.
1. Test: _frame_line.p_
Description: The goal is to find out is the FRAME-LINE function and ...
Vadim Gindin
11:04 AM Base Language Feature #1634: implement full native library (.so or DLL) support
> Eugenie: it is OK to get the compilation issues and the libffi.dll built properly. But after that, pause your work ... Eugenie Lyzenko
09:37 AM Base Language Feature #1634: implement full native library (.so or DLL) support
Eugenie: it is OK to get the compilation issues and the libffi.dll built properly. But after that, pause your work o... Greg Shah
10:45 AM User Interface Feature #1811: implement the AJAX client driver
It is good, thanks. Greg Shah
10:43 AM User Interface Feature #1811: implement the AJAX client driver
Sorry, was my fault. Marius Gligor
10:38 AM User Interface Feature #1811: implement the AJAX client driver
Code Review 0125c
I like it. The only thing I don't understand is why the tty.keymap.js is missing.
Greg Shah
10:26 AM User Interface Feature #1811: implement the AJAX client driver
Done. Marius Gligor
10:00 AM User Interface Feature #1811: implement the AJAX client driver
Code Review 0125b
I like this version better from the perspective of how you made the code better separated.
Bu...
Greg Shah
09:55 AM User Interface Feature #1811: implement the AJAX client driver
Code Review 0125a
I don't want to remove all the server-side Dojo support that you already provided. Put that wor...
Greg Shah
09:46 AM User Interface Feature #1811: implement the AJAX client driver
The keyboard listeners are bind on canvas instead document.
The canvas should have the focus in order to receive key...
Marius Gligor
06:31 AM User Interface Feature #1811: implement the AJAX client driver
Looking for a solution to fix the cross browser keystrokes handle issues I found:
Supported Key Combinations:
The...
Marius Gligor
09:35 AM Database Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
As mentioned in #1651 note 5:
> 7. Long term, we want the standard rules to be loaded from the p2j.jar instead of ...
Greg Shah
02:54 AM Database Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
The following files and directories have to be accessed from the server classpath:... Stanislav Lomany
09:29 AM User Interface Feature #2037 (Closed): runtime support for frame options
Greg Shah
09:29 AM User Interface Feature #1801: add some frame options
Attached is the actual version that is the merged code that was checked in as 10451. Greg Shah

01/24/2014

06:43 PM Base Language Feature #1597 (WIP): shift SQRT implementation (MathOps.sqrt()) to BigDecimal
Hynek Cihlar
08:29 AM Base Language Feature #1597: shift SQRT implementation (MathOps.sqrt()) to BigDecimal
I don't know the answer. Often, if the input is a decimal value, then the output can have the same precision. Other... Greg Shah
07:58 AM Base Language Feature #1597: shift SQRT implementation (MathOps.sqrt()) to BigDecimal
What is the expected precision of the algorithm? Hynek Cihlar
06:40 PM User Interface Feature #2037 (Review): runtime support for frame options
Hynek Cihlar
06:38 PM User Interface Feature #1801: add some frame options
hc_upd20140123b.zip passed regression testing and was checked-in to bazaar repository as revision 10451. Hynek Cihlar
06:27 PM Base Language Feature #1634: implement full native library (.so or DLL) support
Building on Windows notes:
The first thing after including ffi.h into compilation preocess is to change the library_...
Eugenie Lyzenko
09:46 PM Base Language Feature #1634 (Closed): implement full native library (.so or DLL) support
Greg Shah
09:37 PM Base Language Feature #1634: implement full native library (.so or DLL) support
The CTRL-C 3-way tests failed (expected) and there were 5 failures in @tc_job*@ and @tc_dc*@ tests (1 of which always... Greg Shah
04:06 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
Vadim Gindin wrote:
> What do you mean when you are saying "the frame starts with only one field-group (for the firs...
Constantin Asofiei
03:53 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
Vadim Gindin wrote:
> Why it is needed to have downBody array with only the first row real?
The problems are in th...
Constantin Asofiei
01:56 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
What do you mean when you are saying "the frame starts with only one field-group (for the first row). When advancing ... Vadim Gindin
01:11 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
As I can understand this, it sounds reasonable. I just have several questions about details. See below.
Constantin...
Vadim Gindin
03:29 PM Database Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
Stas, I looked around this task history and that of related tasks, but I can't seem to find a summary of the configur... Eric Faulhaber
01:21 PM Database Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
Committed to bzr revision 10448. Stanislav Lomany
01:19 PM Database Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
Update for remaining issues. Presumably does not need regression testing. Stanislav Lomany
03:19 PM User Interface Feature #1811: implement the AJAX client driver
> I saw that when a pop-up window is created we can eliminate menu bars and toll bars.
> Do you believe that could b...
Greg Shah
02:27 PM User Interface Feature #1811: implement the AJAX client driver
Starting from IE 9 preventDefault() is supported. We are interested on IE 10 and IE 11 because IE 9 does not support ... Marius Gligor
02:20 PM User Interface Feature #1811: implement the AJAX client driver
Code Review 0124c
My only thought here is that we probably need to always preventDefault() and stopImmediatePropag...
Greg Shah
02:17 PM User Interface Feature #1811: implement the AJAX client driver
To disable default behavior you may have to do 2 things:
1. Prevent the default behavior. In browsers that suppor...
Greg Shah
01:48 PM User Interface Feature #1811: implement the AJAX client driver
Some small changes to fix ESC key in IE.
I did more tests on Windows using IE 11 and Chrome 31.
Unfortunately on ...
Marius Gligor
12:02 PM User Interface Feature #1811: implement the AJAX client driver
It's works in IE but I have to fix a small issue. Event preventDefault() does not work properly with IE.
I tested bo...
Marius Gligor
11:33 AM User Interface Feature #1811: implement the AJAX client driver
1. We have to solve the CTRL-C issue to initialize the converted application without a new server authentication if p... Marius Gligor
10:58 AM User Interface Feature #1811: implement the AJAX client driver
Can you please post a list of what is left to do on #2212? Greg Shah
10:51 AM User Interface Feature #1811: implement the AJAX client driver
Code Review 0124a
All the changes look good. I like the more modular approach.
Code Review 0124b
I prefer t...
Greg Shah
10:40 AM User Interface Feature #1811: implement the AJAX client driver
I did some small improvements and bug fixing. Basically I eliminated the dojo/keys module dependencies.
With this ch...
Marius Gligor
01:23 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
I am running now the full regression on this update. It is based on bzr rev 10450.
It contains the
* om_upd2014012...
Ovidiu Maxiniuc
09:59 AM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Tested, results are the same:... Vadim Nebogatov
02:28 AM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Vadim: this seems like the BUFFER-FIELD can never be deleted explicitly. I forgot about dynamic buffers - please test... Constantin Asofiei
12:33 PM Database Feature #1658 (Closed): improve database trigger support
Eric Faulhaber
12:33 PM Database Feature #1581 (Closed): add conversion and runtime support for certain metadata constructs
Eric Faulhaber
11:53 AM User Interface Feature #1787: implement batch mode support
This was committed as bzr revision 10449. Greg Shah
10:20 AM User Interface Feature #1787: implement batch mode support
The testing results are in:
@10446_f202309_20140124_evl.zip@
Taking into account all sessions the testing has been ...
Eugenie Lyzenko
09:53 AM User Interface Feature #1787: implement batch mode support
Code Review 0124a
All the merges look good. Considering that the only tricky merging was in the build scripts, I ...
Greg Shah
09:29 AM User Interface Feature #1787: implement batch mode support
The code merge with the 10447. Looks like there are no regressions found.
Do I need to commit and distribute?
Eugenie Lyzenko
08:33 AM Base Language Feature #1596: complete big decimal implementation
We had moved from use of double to BigDecimal in the past because we found deviations from the 4GL implementation tha... Greg Shah
09:47 PM Base Language Feature #1641 (Closed): implement SAX XML support
Greg Shah
08:33 PM Base Language Feature #1641: implement SAX XML support
SAX testcases committed at bzr revision 1088. Evgeny Kiselev
09:46 PM Base Language Feature #1988 (Closed): runtime support for SAX
Greg Shah
09:45 PM Base Language Support #2234: test and fix native API support on Windows
Put all history in #1634. Greg Shah
09:43 PM Base Language Support #2234 (Closed): test and fix native API support on Windows
Greg Shah
09:45 PM Base Language Support #2233: test and fix the native API support on Linux
Put all history in #1634. Greg Shah
09:43 PM Base Language Support #2233 (Closed): test and fix the native API support on Linux
Greg Shah
09:41 PM Base Language Feature #2121 (Closed): implement Java runtime support for native libraries
Greg Shah
09:41 PM Base Language Feature #1959 (Closed): implement JNI runtime support for native libraries
Greg Shah

01/23/2014

06:54 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
I tested the following test case based on note 98... Vadim Nebogatov
06:26 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Notes about @DynamicQueryHelper@ from om_upd20140123a:
* I'm OK with using the @QueryProcessor@ interface instead of...
Constantin Asofiei
06:05 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Code review om_upd20140123a:
I'm good with the changes, assuming you will come back around after M7 and finish up ...
Eric Faulhaber
05:09 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Changes in this update (beside the things from notes 89, 90 & 97):
* Added support for dereference as left-side of a...
Ovidiu Maxiniuc
10:28 AM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Update @vmn_upd20140123a.zip@ contains all implemented methods from note 47 excepting @FieldReference.resourceDelete(... Vadim Nebogatov
03:09 AM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Vadim Nebogatov wrote:
> Is current implementation of FieldReference.resourceDelete() correct? What should be tested ...
Constantin Asofiei
02:56 AM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
About the dynamic query code in om_upd20140122a.zip:
* what I don't like is that we are duplicating code in @parseQu...
Constantin Asofiei
06:02 PM User Interface Feature #1801: add some frame options
It looks good. Go ahead with testing. Greg Shah
05:47 PM User Interface Feature #1801: add some frame options
Yes, the application will work ok without the color-map.xml file on the classpath. Just an info log entry will be out... Hynek Cihlar
05:28 PM User Interface Feature #1801: add some frame options
Code Review 0123a
I am fine with the version, except that the color-map.xml should not be checked into the P2J pro...
Greg Shah
04:56 PM User Interface Feature #1801: add some frame options
The attached file includes runtime support of the DCOLOR and PFCOLOR attributes. Hynek Cihlar
04:34 PM User Interface Feature #1801: add some frame options
The implementation is finished. I am doing basic functional tests and will be uploading for review in about half an h... Hynek Cihlar
04:13 PM User Interface Feature #1801: add some frame options
How soon can you upload a candidate for review? I will get it reviewed quickly and hopefully it will be ready for re... Greg Shah
03:58 PM User Interface Feature #1801: add some frame options
Here are the findings.
@DCOLOR@ and @PFCOLOR@ exist only in the form of attributes of INTEGER type. For the chara...
Hynek Cihlar
05:13 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
Vadim, good findings, but you are misinterpreting something. When you are printing the frame's children in @no-loop-i... Constantin Asofiei
04:51 PM Base Language Feature #2232: finish testing the wrapped mode using the web services exposed by the testing server
Using the server created in #2208, test the web services using wrapped mode and fix any found problems.
Also, fix ...
Constantin Asofiei
04:45 PM Base Language Feature #2232 (Closed): finish testing the wrapped mode using the web services exposed by the tes...
Constantin Asofiei
04:41 PM Base Language Feature #1644 (Closed): implement SOAP support
Greg Shah
04:40 PM Base Language Feature #1995 (Closed): runtime support for SOAP
Greg Shah
04:40 PM Base Language Feature #1645 (Closed): implement web services support
Greg Shah
04:39 PM Base Language Feature #2022 (Closed): runtime support for web services
Greg Shah
02:54 PM Database Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
OK, that's a bit confusing, but got it. Still, please open a separate task to track the features needed for full comp... Eric Faulhaber
02:49 PM Database Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
> I think append- is the only option in scope here, since it can be used in internal code paths. The replace- and loo... Stanislav Lomany
02:38 PM Database Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
Stanislav Lomany wrote:
> 3. COPY-TEMP-TABLE: copy modes: append-, replace- and loose-copy-
I think append- is the ...
Eric Faulhaber
02:29 PM Database Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
> * Is the @import com.goldencode.p2j.convert.*;@ statement needed in @TemporaryBuffer@?
That is required for @ParmT...
Stanislav Lomany
02:27 PM Database Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
OK, makes sense. I was understanding this to be a different problem. Eric Faulhaber
02:11 PM Database Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
> Regarding the first error, is it actually necessary to modify Hibernate? I don't know where the code you modified a... Stanislav Lomany
01:36 PM Database Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
Code review 20140123a:
* Is the @import com.goldencode.p2j.convert.*;@ statement needed in @TemporaryBuffer@?
* The...
Eric Faulhaber
01:04 PM Database Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
Regarding the first error, is it actually necessary to modify Hibernate? I don't know where the code you modified abo... Eric Faulhaber
12:24 PM Database Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
Regarding the second error, this query is generated by the conversion rules for historical reasons, when we handled s... Eric Faulhaber
12:21 PM Database Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
Current state of work. Needs regression testing. Stanislav Lomany
10:50 AM Database Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
> Is there a stack trace that goes with this error that shows the problem at the Hibernate level?... Stanislav Lomany
10:18 AM Database Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
Is there a stack trace that goes with this error that shows the problem at the Hibernate level?
Hibernate cannot d...
Eric Faulhaber
09:59 AM Database Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
I was pretty sure that extents work normally for dynamic tables, there are several checked in testcases for them. How... Stanislav Lomany
02:08 PM User Interface Feature #1787: implement batch mode support
Looks like the main part is OK. Continue testing with CTRL-C one. Eugenie Lyzenko
01:50 PM User Interface Feature #1811: implement the AJAX client driver
Code Review 0123a
This is really, really good! I'm glad that you were able to work out an approach that is much m...
Greg Shah
12:01 PM User Interface Feature #1811: implement the AJAX client driver
1. The DOM level 3 events specifications are implemented total or partial on all major web browser but sligtly differ... Marius Gligor
12:57 PM Base Language Feature #1634: implement full native library (.so or DLL) support
This is a version with more fixes, but it is not finished. Still, it is a good version to put into regression testin... Greg Shah
10:29 AM Base Language Feature #1634: implement full native library (.so or DLL) support
This version fixes a conversion regression found in testing. It has passed conversion regression testing and it also... Greg Shah
07:37 PM Base Language Feature #1634: implement full native library (.so or DLL) support
This is a version that has many fixes implemented. Many native API use cases are now working, but not all use cases ... Greg Shah

01/22/2014

06:52 PM User Interface Feature #1801: add some frame options
I don't fully know the answer. I think you will have to do some testing in the real 4GL.
I do know how we have co...
Greg Shah
06:15 PM User Interface Feature #1801: add some frame options
A question about DCOLOR and PFCOLOR. Is the following sample the correct way to set the protermcap color?... Hynek Cihlar
06:30 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
I'm repeating that i:handle peculiarities are the same in iterating and non-iterating tests. All tests I have are com... Vadim Gindin
06:27 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
2. _external_scoped_frame_ihandle.p_ This test checks behavior of the CURRENT-ITERATION in repeat loop in case when t... Vadim Gindin
06:14 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
Here are tests and those results.
1. _no_loop_ihandle.p_. Try to check CURRENT-ITERATION behavior in the case when...
Vadim Gindin
11:38 AM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
Vadim Gindin wrote:
> What else can I do to find when a widget row is created?
Check your findings with cases when ...
Constantin Asofiei
11:28 AM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
Constantin Asofiei wrote:
> Vadim, using the test at note 15, check how the body of a down frame evolves in the case...
Vadim Gindin
06:02 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Ovidiu, Vadim: it looks like you are both very close to being finished with your respective pieces. Although we origi... Eric Faulhaber
05:41 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Vadim Nebogatov wrote:
> Is current implementation of FieldReference.resourceDelete() correct? What should be tested...
Eric Faulhaber
05:20 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
I see only one usage of @resourceDelete()@ related with buffers – @TempTableBuilder.forceClear()@.
@resourceDelete(...
Vadim Nebogatov
04:35 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Constantin Asofiei wrote:
> Eric Faulhaber wrote:
> > Sorry, this was my comment and I see how it is misleading. It...
Vadim Nebogatov
02:42 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Eric Faulhaber wrote:
> Sorry, one more (minor) issue on om_upd20140122a: why did you change the initialization of t...
Ovidiu Maxiniuc
02:12 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Sorry, one more (minor) issue on om_upd20140122a: why did you change the initialization of the @DynamicQueryHelper.wr... Eric Faulhaber
02:03 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
One more thought on @BufferImpl.findByRowID@: we are using @IndexHelper@ to find the primary index, but @IndexHelper@... Eric Faulhaber
01:45 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Code review om_upd20140122a:
Looks good, but I also would like Constantin to review the dynamic query generation par...
Eric Faulhaber
12:10 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
This update adds implementation for the findXyz() dynamic methods and adds the sort clause (using primary index) for ... Ovidiu Maxiniuc
10:20 AM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Eric Faulhaber wrote:
> * In @schema/fixups.xml@, the rule which tests for @type == prog.kw_mand@ is not correct. Th...
Vadim Nebogatov
11:35 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Code review 20140121a:
Overall looks good, but I have a few questions/concerns:
* In @schema/fixups.xml@, the rul...
Eric Faulhaber
03:12 PM Database Feature #2231: LockType error processing
With the emergence of the new dynamic features in P2J some of the parameters of the methods/attributes cannot be chec... Ovidiu Maxiniuc
03:01 PM Database Feature #2231 (Closed): LockType error processing
Ovidiu Maxiniuc
12:30 PM Base Language Feature #1634: implement full native library (.so or DLL) support
This update resolves all issues from the code review and merges to the bzr 10445 level (the latest at this writing).
...
Greg Shah
11:27 AM User Interface Feature #1787: implement batch mode support
Code Review 0122a
It looks good. Get it regression tested.
Greg Shah
10:49 AM User Interface Feature #1787: implement batch mode support
The update clears the notes for previous code review and merges with the recent codebase from bzr. Eugenie Lyzenko
09:14 AM User Interface Feature #1787: implement batch mode support
> 2. I'm surprised that we don't have to link with additional libraries for pthreads on Linux or the event semaphore ... Eugenie Lyzenko
08:41 AM User Interface Feature #1787: implement batch mode support
Code Review 0121a
1. After you use throwException() in native code, please don't use @exit(-1)@. Just use @return...
Greg Shah
09:50 AM Base Language Feature #2013 (Closed): implement the SELF system handle
Greg Shah
09:21 AM Base Language Feature #2013: implement the SELF system handle
Passed conversion and runtime testing, committed to bzr rev 10445. Constantin Asofiei
09:50 AM Base Language Feature #2015 (Closed): runtime support for SELF system handle
Greg Shah
09:09 AM User Interface Feature #1811: implement the AJAX client driver
OK, these are good findings.
Please review the DOM level 3 events specification: http://www.w3.org/TR/DOM-Level-3-...
Greg Shah
07:51 AM User Interface Feature #1811: implement the AJAX client driver
I did some small changes and improvements.
Also I tested a version using native JS instead Dojo. The results are the...
Marius Gligor
04:54 AM User Interface Feature #1811: implement the AJAX client driver
I Tested your code and here are my conclusions:
1. The code does not work at all on IE (Windows) web browser.
...
Marius Gligor

01/21/2014

05:58 PM User Interface Feature #1787: implement batch mode support
This is the release candidate for review. Works for 64-bit Windows. Need to check with 32-bit, later today. Eugenie Lyzenko
04:52 PM User Interface Feature #1787: implement batch mode support
OK, it makes sense. Change all the names to be @signals*@ instead of @signal*@. Greg Shah
04:20 PM User Interface Feature #1787: implement batch mode support
Almost all is ready. One point to discuss:
We can not use @signal.h@ as local header file for our library call. It c...
Eugenie Lyzenko
08:48 AM User Interface Feature #1787: implement batch mode support
I am fine with the use of a semaphore to block waiting for the signal. As noted above, this can be implemented the s... Greg Shah
08:47 AM User Interface Feature #1787: implement batch mode support
> The folowing code works fine in standalone application but does not work in library(like libp2j):
I have not che...
Greg Shah
08:45 AM User Interface Feature #1787: implement batch mode support
Code Review 0120b
1. We don't need calls to the ClientCore.loadNativeP2JLibrary() from many different files. We o...
Greg Shah
08:15 PM User Interface Feature #1787: implement batch mode support
This update adds the Windows implementation for @SIGINT@ handler. Works in Windows 7 64-bit in virtual machine. Conti... Eugenie Lyzenko
05:08 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
I also attached vmn_upd20140121b.zip with tests. Vadim Nebogatov
01:09 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
I have attached update vmn_upd20140121a.zip corresponding to current state in note 47. I am continue implementation o... Vadim Nebogatov
04:57 PM Base Language Bug #2197: fix the error message list cleanup when NO-ERROR mode is enabled and ERROR-STATUS:ERRO...
First of all I need to understand the problem. As we can see from the tests Java program does not clear error list, b... Vadim Gindin
04:11 PM User Interface Feature #1811: implement the AJAX client driver
By the way, you re-uploaded mag_upd20140117b.zip when I think you intended to upload mag_upd20140121b.zip. Greg Shah
04:09 PM User Interface Feature #1811: implement the AJAX client driver
I have not gotten to look at your latest code yet.
However, I think you have come to the wrong conclusion in regar...
Greg Shah
02:13 PM User Interface Feature #1811: implement the AJAX client driver
Here is an improved version for keyboard management. Seems to be closed to the final solution.
Nevertheless I will d...
Marius Gligor
10:31 AM User Interface Feature #1811: implement the AJAX client driver
1. Today I did the appropriate changes inside the JS code in order to manage the keyboard events.
So far all my t...
Marius Gligor
09:39 AM User Interface Feature #1811: implement the AJAX client driver
Please document the differences between Java/Swing key processing and the Javascript equivalent. It was my understand... Greg Shah
03:02 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
Vadim, using the test at note 15, check how the body of a down frame evolves in the cases I've mentioned at note 22. ... Constantin Asofiei
01:25 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
It does seem that this code can only be used from an interactive UI. That is not something that the server project r... Greg Shah
01:23 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
Constantin notes:
Considering that CURRENT-ITERATION is used in the server project only in the adm2/smart.p and th...
Greg Shah
04:07 AM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
Vadim Gindin wrote:
> The first obstacle is the @CURRENT-ITERATION@ for Buffer is an integer but for @Frame/DialogBo...
Constantin Asofiei
02:33 AM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
The first obstacle is the @CURRENT-ITERATION@ for Buffer is an integer but for @Frame/DialogBox@ the @CURRENT-ITERATI... Vadim Gindin
02:11 PM User Interface Feature #1801: add some frame options
> Any other widget types to test or all the widget types?
FILL-IN and BUTTON.
Greg Shah
02:03 PM User Interface Feature #1801: add some frame options
Greg Shah wrote:
> > Unless I am missing a usecase here, the code changes are in-line with your points.
>
> OK, I...
Hynek Cihlar
01:18 PM User Interface Feature #1801: add some frame options
> Unless I am missing a usecase here, the code changes are in-line with your points.
OK, I was misunderstanding th...
Greg Shah
01:46 PM User Interface Feature #2144: add minimum runtime support for methods (server)
Implement runtime support for DESELECT-ROWS() and MOVE-BEFORE-TAB-ITEM(). Please put all history entries in the pare... Greg Shah
11:29 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
Based on the NO-ECHO testcases created in #1629, test the P2J implementation for NO-ECHO and make any functional addi... Greg Shah
11:06 AM User Interface Feature #2016 (Closed): implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles
ChUI and batch support is complete, which is sufficient for M7. GUI support will be implemented in #2229. Greg Shah
11:05 AM User Interface Feature #2018 (Closed): runtime support for CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW syst...
Greg Shah
11:03 AM User Interface Feature #2229 (Closed): implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles...
Greg Shah
04:19 AM Base Language Feature #1645: implement web services support
Evgeny Kiselev wrote:
> Code Review 0116a:
> 1) @com.goldencode.p2j.xml.XNodeRefImpl#getOwnerDocument()@
> Does @R...
Constantin Asofiei

01/20/2014

05:28 PM User Interface Feature #1787: implement batch mode support
Finding. The folowing code works fine in standalone application but does not work in library(like libp2j):... Eugenie Lyzenko
03:44 PM User Interface Feature #1787: implement batch mode support
This is implementation candidate for Linux @SIGINT@ interceptor.
The Java part consist of the new class @SigintWai...
Eugenie Lyzenko
09:40 AM User Interface Feature #1787: implement batch mode support
I haven't gotten to the code review yet. But your approach for Windows is good. Greg Shah
05:24 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
I think @fieldId@ should be also added to LegacyFieldInfo along with other attributes. It will allow to find @fieldId... Vadim Nebogatov
11:04 AM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Stanislav Lomany wrote:
> > This seems OK to me. Stas, Constantin: any concerns with this approach?
>
> Attribute...
Constantin Asofiei
10:15 AM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
> This seems OK to me. Stas, Constantin: any concerns with this approach?
No concerns. Attributes should be stored...
Stanislav Lomany
10:10 AM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Code review om_upd20140117a:
Code seems OK to me, though given your changes to FieldReference, you should coordina...
Eric Faulhaber
10:08 AM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Vadim, in last Thursday's email status report, you wrote:
> I also noticed that FieldReference is not proper place f...
Eric Faulhaber
09:44 AM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Eric Faulhaber wrote:
> The reason I made this comment about the sort clause is because for every RandomAccessQuery ...
Ovidiu Maxiniuc
06:32 AM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Ovidiu Maxiniuc wrote:
> I have attached the intermediary update that contains some my changes for this issue.
> I...
Ovidiu Maxiniuc
05:11 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
Review for 0121a.zip (btw, updates should be named using the day of work's date, not calendaristic):
# you are missi...
Constantin Asofiei
04:45 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
Here it is. An archive with recommended by you changes. The questions.
1) Do I correctly implenented @handle.unwrapI...
Vadim Gindin
01:54 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
Vadim Gindin wrote:
> I tried to convert a simple procedure and it emitted correct (at first saw) java code @myFrame...
Constantin Asofiei
01:29 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
I tried to convert a simple procedure and it emitted correct (at first saw) java code @myFrameFrame.currentIteration(... Vadim Gindin
03:14 PM User Interface Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles
vig_upd20140116a.zip passed regression testing. Committed as rev #10443. Vadim Gindin
02:13 PM Base Language Feature #1645: implement web services support
Code Review 0116a:
1) @com.goldencode.p2j.xml.XNodeRefImpl#getOwnerDocument()@
Does @RESTRICTED_DOCUMENT@ can affai...
Evgeny Kiselev
01:33 PM User Interface Feature #1801: add some frame options
Another argument for splitting the color from attribute I forgot to mention is the @Color@ class itself. It also keep... Hynek Cihlar
01:24 PM User Interface Feature #1801: add some frame options
Greg Shah wrote:
> Code Review 0119a
>
> 1. Why is there a dependency on @javax.jws.soap.SOAPBinding.Use@ in Cons...
Hynek Cihlar
01:21 PM User Interface Feature #1801: add some frame options
Greg Shah wrote:
> Code Review 0117a
> 1. Is the color-map.xml an example of the customer-specific (custom) color m...
Hynek Cihlar
09:08 AM User Interface Feature #1801: add some frame options
Code Review 0119a
1. Why is there a dependency on @javax.jws.soap.SOAPBinding.Use@ in ConsolePrimitives?
2. Ple...
Greg Shah
08:56 AM User Interface Feature #1801: add some frame options
Code Review 0117a
I was disconnected most of the weekend and didn't see your update until now. I'll check the 011...
Greg Shah
12:13 PM User Interface Feature #1811: implement the AJAX client driver
1. I did more investigations regarding the Google Chrome web browser.
Both Google Chrome and jetty teams works cu...
Marius Gligor
09:52 AM Base Language Feature #2013: implement the SELF system handle
Code Review 0120a
I am fine with the changes. Commit and distribute them when they pass testing.
Greg Shah
09:18 AM Base Language Feature #2013: implement the SELF system handle
This removes NullWidget and makes both SELF and FOCUS act as real handles. Manual testing looks OK, waiting for the a... Constantin Asofiei
09:19 AM Runtime Infrastructure Feature #2124 (WIP): improve/simplify the startup of server-side batch processes and appserver "a...
Constantin Asofiei
09:17 AM Base Language Feature #2015 (WIP): runtime support for SELF system handle
Constantin Asofiei

01/19/2014

05:44 PM User Interface Feature #1787: implement batch mode support
> 4. What about Windows?
In Windows we do not have @sigwait()@. So another approach might be acceptable:
1. Ins...
Eugenie Lyzenko
05:09 PM User Interface Feature #1801: add some frame options
The attached hc_upd20140119a.zip contains in-code documentation, file headers plus some cosmetic code changes. The co... Hynek Cihlar
10:36 AM Base Language Feature #1634: implement full native library (.so or DLL) support
I haven't addressed the code review items yet. This is a version with a fix for the package names which match reserv... Greg Shah

01/18/2014

05:16 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Ovidiu Maxiniuc wrote:
> // has TODO regarding generating a properly converted sort clause (currently null); otherwi...
Eric Faulhaber
03:28 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Eric Faulhaber wrote:
> The VAL-EXP attribute actually is used in both read and write modes in the current project. ...
Vadim Nebogatov
04:24 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
The work to determine the rules when the auxiliary field-group is created and how the field-group rows are made visib... Constantin Asofiei
04:03 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
I extended your test to output the content of each field group on every iteration and other useful information. Here ... Vadim Gindin
12:43 PM User Interface Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles
Great, you can release 0116a.zip after it passes testing. Constantin Asofiei
12:16 PM User Interface Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles
There is no changes since last update vig_upd20140116a.zip Vadim Gindin
11:59 AM User Interface Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles
OK, place the final update here for review, before releasing it. Constantin Asofiei
07:20 AM User Interface Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles
So I tested it again. It works. I'm going to run regression testing. Vadim Gindin
05:34 AM Base Language Feature #1634: implement full native library (.so or DLL) support
Review for @0117b.zip@:
* @collect_names.rules@
- line 406: this @<rule>downPath("KW_OUTPUT") or downPath("KW_RETUR...
Constantin Asofiei
07:26 PM User Interface Feature #1787: implement batch mode support
> But let's just call it init_ in all cases to keep the filenames shorter.
OK. This is the prepared base for appro...
Eugenie Lyzenko

01/17/2014

06:15 PM User Interface Feature #1787: implement batch mode support
iniitalize_ would be fine. But let's just call it init_ in all cases to keep the filenames shorter. Greg Shah
05:32 PM User Interface Feature #1787: implement batch mode support
Greg,
Is it OK to name the native and OS dependent init modules as @initialize.(c|h)@ and @initialize_(linux|win)....
Eugenie Lyzenko
01:17 PM User Interface Feature #1787: implement batch mode support
> Eugenie: please work toward having this work done (and regression tested and checked in) by end of day next Friday ... Eugenie Lyzenko
10:09 AM User Interface Feature #1787: implement batch mode support
> we should consider releasing an intermediate update (withtout the @KILL -INT@ fix)
Agreed.
Eugenie: please wo...
Greg Shah
09:47 AM User Interface Feature #1787: implement batch mode support
Greg, a note: if there is a chance all the @kill -INT@ behaviour will not be ready until next friday, we should consi... Constantin Asofiei
08:40 AM User Interface Feature #1787: implement batch mode support
> Another things to discuss is about the signal processing init code for all required signals to special process. We ... Greg Shah
06:58 AM User Interface Feature #1787: implement batch mode support
> Yes. The sigaction() usage needs to be executed every time the client starts (instead of only when a child process ... Eugenie Lyzenko
06:13 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
The VAL-EXP attribute actually is used in both read and write modes in the current project. In the function where it ... Eric Faulhaber
05:49 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
LE: just took a look at the implementation and the attribute name is hard-coded, not determined from annotations - so... Constantin Asofiei
05:44 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Eric Faulhaber wrote:
> Vadim Nebogatov wrote:
> > Two cosmetics found in @HEIGHT-CHARS@ implementation: @HEIGHT-CH...
Constantin Asofiei
05:42 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Vadim Nebogatov wrote:
> Schema conversion step starts from *.dict file received as result of parsing. Am I correct?...
Constantin Asofiei
05:40 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Vadim Nebogatov wrote:
> Two cosmetics found in @HEIGHT-CHARS@ implementation: @HEIGHT-CHARS@ instead of @HEIGHT@ an...
Eric Faulhaber
05:38 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Vadim Nebogatov wrote:
> @POSITION attribute@
> From tests, it is just field order (fieldId) plus 1. It is interest...
Eric Faulhaber
05:24 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Constantin Asofiei wrote:
> Ah, I get it know, you want to get the legacy 4GL expression. The best way is to save it ...
Vadim Nebogatov
05:17 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Ah, I get it know, you want to get the legacy 4GL expression. The best way is to save it in an annotation at the fiel... Constantin Asofiei
05:08 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
No special test is required: it is from p2j_test.dict for p2j_test.book.cost field. Vadim Nebogatov
05:04 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Can you post a small testcase showing how this behaves? If it works how I think it works (i.e. @VALIDATE-EXPRESSION@ ... Constantin Asofiei
04:44 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
@VALIDATE-EXPRESSION attribute@
I missed annotation of this attribute. In *.dict it looks like ...
Vadim Nebogatov
03:06 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Two cosmetics found in @HEIGHT-CHARS@ implementation: @HEIGHT-CHARS@ instead of @HEIGHT@ and @setable@ with one @t@ ... Vadim Nebogatov
01:46 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
@POSITION attribute@... Vadim Nebogatov
01:23 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
I also added some more optional annotations like
/** Data member */
@LegacyField( name = "fc" , format = "...
Vadim Nebogatov
11:27 AM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
I have attached the intermediary update that contains some my changes for this issue.
I am putting this update to c...
Ovidiu Maxiniuc
10:46 AM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Agreed. Consider whether runtime regression testing is necessary for this update. If its impact is only on new runtim... Eric Faulhaber
10:39 AM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Ovidiu, please check if you can extract the code which adds the new annotations into a separate update; I think is wo... Constantin Asofiei
10:10 AM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Some more details on implementation of @bufferField(int)@:
I have done some researches that clarified me that the ...
Ovidiu Maxiniuc
09:30 AM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Eric Faulhaber wrote:
> Sorry, this was my comment and I see how it is misleading. It was not based on testing, but ...
Constantin Asofiei
09:23 AM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
*Ovidiu* working on @BufferImpl.java@
// has TODO regarding generating a properly converted sort clause (currently...
Ovidiu Maxiniuc
08:15 AM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Eric Faulhaber wrote:
> Vadim, to me it doesn't look like @format@ and @changeFormat@ are actually in use. I don't s...
Vadim Nebogatov
08:01 AM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
The same for the LITERAL-QUESTION attribute, I have implemented attribute support without proper analysys according n... Vadim Nebogatov
07:52 AM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Eric Faulhaber wrote:
> AFAIK, RowObjectValidate is just an ADM SmartObjects procedure that we convert. Does this ha...
Vadim Nebogatov
07:39 AM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Constantin Asofiei wrote:
> Vadim Nebogatov wrote:
> > public void setDataType(String dataType) [LE: cannot se...
Eric Faulhaber
07:35 AM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Constantin Asofiei wrote:
> > // not sure why this is implemented for FieldReference; DELETE cannot be called on a
...
Eric Faulhaber
07:23 AM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Vadim Nebogatov wrote:
> public void setDataType(String dataType) [LE: cannot set data type for a buffer field]...
Constantin Asofiei
07:19 AM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
Vadim, to me it doesn't look like @format@ and @changeFormat@ are actually in use. I don't see any rules to generate ... Eric Faulhaber
07:09 AM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
h3. Vadim, current status (implemented methods are marked in bold)
h3. BufferImpl
*public handle bufferField(chara...
Vadim Nebogatov
06:09 PM Base Language Feature #1634: implement full native library (.so or DLL) support
Updated version with conversion fixes and some added functionality to make the testcases work (hex-decode and hex-enc... Greg Shah
02:40 PM Base Language Feature #1634: implement full native library (.so or DLL) support
> The only question is what about ffi.h header?
On Ubuntu, install this package:
sudo apt-get install libffi-de...
Greg Shah
02:10 PM Base Language Feature #1634: implement full native library (.so or DLL) support
> Eugenie: please review the filesys.c change as well as the other native code changes.
I'm OK with changes. The o...
Eugenie Lyzenko
10:41 AM Base Language Feature #1634: implement full native library (.so or DLL) support
Complete first implementation. I am about to start testing, so this is likely to change. But it has all features ful... Greg Shah
05:46 PM User Interface Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles
As Vadim N. noted on #1655 note 63: the problem we have with @WIDTH@ and @WIDTH-CHARS@ can be found with @HEIGHT@ and... Constantin Asofiei
03:21 PM User Interface Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles
Sorry, my bad. The test was missing a no-error clause for the last @this-procedure:current-window = h.@ assignment; s... Constantin Asofiei
02:24 PM User Interface Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles
Constantin,
I've committed tests I have for this task. I already have similar tests. Could you comment, why do you...
Vadim Gindin
04:06 AM User Interface Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles
Vadim Gindin wrote:
> Yes I did test it but my tests did not allow me to find this issue. It probably need to test i...
Constantin Asofiei
04:31 PM Database Feature #2117 (Closed): add runtime support for _lock metadata table
See #2115, note 18. Eric Faulhaber
04:31 PM Database Feature #2115 (Closed): add runtime support for _file and _field metadata tables
This update fixes metadata foreign key detection, completes basic lock metadata support (#2117), removes underscore f... Eric Faulhaber
03:25 PM User Interface Feature #1801: add some frame options
I am attaching changes with the protermcap color support for an early review. The code was functionally tested and is... Hynek Cihlar
02:08 PM User Interface Feature #1811: implement the AJAX client driver
Code Review 0116b
The code looks good. Does ChuiWebSimulator really need to call super.quit()?
Greg Shah
01:29 PM User Interface Feature #1811: implement the AJAX client driver
System.exit(code) works fine.
Marius Gligor
01:07 PM User Interface Feature #1811: implement the AJAX client driver
Code Review 0117a
The changes look fine except for the END-ERROR approach already discussed above.
The use of S...
Greg Shah
12:58 PM User Interface Feature #1811: implement the AJAX client driver
I checked in the TerminalMenu class and we have this code for the Exit menu item:... Greg Shah
12:16 PM User Interface Feature #1811: implement the AJAX client driver
Marius Gligor wrote:
> 1. I found another way to terminate the client process on connection close. Just simple put an...
Constantin Asofiei
12:10 PM User Interface Feature #1811: implement the AJAX client driver
1. I found another way to terminate the client process on connection close. Just simple put an END-ERROR key (code 30... Marius Gligor
 

Also available in: Atom