Activity
From 01/21/2014 to 02/19/2014
02/20/2014
- 11:59 PM Base Language Feature #2208: create a java application running web services for testing purposes
- I've committed intermediate version of test server to the @testcases/uast/web_services/server/@.
To run this from ID... - 11:00 PM Base Language Feature #1624: add support for PUT CONTROL
- Do I need to commit testcases ?
02/19/2014
- 04:00 PM Database Feature #2143 (WIP): prototype IKVM solution for Java UDFs compiled to CIL assemblies and loaded ...
- Sounds like you're making good headway, Ovidiu.
> I attempted to convert the whole p2jpl.jar. Operation finished and... - 02:54 PM Database Feature #2143: prototype IKVM solution for Java UDFs compiled to CIL assemblies and loaded in SQL...
- Progress so far:
* created a small test java class with 2 operators
* compiled the java source code and built the j... - 03:41 PM Base Language Feature #1599: shift EXP implementation (MathOps.pow()) to BigDecimal
- Code Review 0219a
The code looks good. My only comments relate to some coding standards:
1. Lines 608 and 614 a... - 02:52 PM Base Language Feature #1599: shift EXP implementation (MathOps.pow()) to BigDecimal
- Please review the attached changes. Testcases checked in to testcases/uast/math/exp.p.
- 02:35 PM Database Feature #2024: implement runtime support for database triggers
- Committed to bzr as revision 10472 and distributed by mail.
- 12:59 PM User Interface Feature #1811: implement the AJAX client driver
- Passed regression tests. Committed to bzr revision 10471.
I created an Majic environment on my work station based ... - 09:02 AM User Interface Feature #1811: implement the AJAX client driver
- > But I wonder if we shouldn't push to the JS side just the portion(s) of the screen being changed
Yes, we certain... - 04:15 AM User Interface Feature #1811: implement the AJAX client driver
- Marius Gligor wrote:
> 2. Regarding UNIX statement, at this moment I have no idea how to solve. We will see after I ... - 03:24 AM User Interface Feature #1811: implement the AJAX client driver
- 1. I started to find a solution to improve the web ChUI client. I have to improve both network traffic and JS renderi...
- 03:07 AM User Interface Feature #1811: implement the AJAX client driver
- Marius: another part which is not working in Web (or Swing) mode is the @UNIX.@ statement. This suspends the P2J clie...
- 02:38 AM User Interface Feature #1811: implement the AJAX client driver
- Greg Shah wrote:
> Constantin: can you think of any 4GL behavior that this would break?
In terms of 4GL behaviour, ... - 12:15 PM Base Language Feature #1624 (Closed): add support for PUT CONTROL
- 11:52 AM Base Language Feature #1624: add support for PUT CONTROL
- update evk_upd20140214a.zip has been passed regression testing.
Committed to bzr revision 10470. - 11:13 PM Base Language Feature #1624 (Review): add support for PUT CONTROL
- 03:10 AM User Interface Bug #2244: web client performance
- How to launch a Shell command in MAJIC:
* login to main menu using syman/test123
* press F2 for dev help
* press ... - 02:16 AM User Interface Bug #2244 (WIP): web client performance
02/18/2014
- 01:50 PM Base Language Feature #2145: eliminate program-name limitations
- This should solve the SOURCE- and TARGET-PROCEDURE cases (when invoking an external program or a trigger). Also, it i...
- 12:47 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
- The case with UP 1 and down 1 looks good. The question is why have you used additional display statement before the l...
- 11:02 AM Base Language Feature #1634: implement full native library (.so or DLL) support
- Almost.
> take the testcases from @native_library_calls_4gl_..._sample_20131107.zip@
No, that is just a slightly... - 10:51 AM Base Language Feature #1634: implement full native library (.so or DLL) support
- Greg,
The question about task #2234. The goal is to take the testcases from @native_library_calls_4gl_..._sample_2...
02/17/2014
- 02:30 PM User Interface Feature #1805: add missing UI method support
- Marius Gligor wrote:
> Sorry but I don't understood. What version of Color is on my project H003 or H004?
Check the... - 02:23 PM User Interface Feature #1805: add missing UI method support
- Sorry but I don't understood. What version of Color is on my project H003 or H004?
- 02:15 PM User Interface Feature #1805: add missing UI method support
- Marius Gligor wrote:
> Strange but Color.java 293 on my p2j project point to a javadoc line!!!
This is because the ... - 05:47 AM User Interface Feature #1805: add missing UI method support
- My changes for ChUI colors implementation was done only in ColorMapper class.
Exception in thread "AWT-EventQueue-... - 02:26 PM User Interface Feature #1811: implement the AJAX client driver
- You are a go for regression testing on 0217b.
- 02:19 PM User Interface Feature #1811: implement the AJAX client driver
- Marius Gligor wrote:
> Should I started the regression tests using my latest changes or is better to wait until the ... - 02:15 PM User Interface Feature #1811: implement the AJAX client driver
- I tested the redirection by killing P2J web client manually and its works on my workstation.
Nevertheless I will tes... - 01:50 PM User Interface Feature #1811: implement the AJAX client driver
- Greg Shah wrote:
> Constantin: based on these changes and Marius' comments, do you have any other feedback?
The code ... - 01:42 PM User Interface Feature #1811: implement the AJAX client driver
- Code Review 0217b
I am fine with the changes.
Constantin: based on these changes and Marius' comments, do you h... - 01:25 PM User Interface Feature #1811: implement the AJAX client driver
- The TemporaryAccountWorker is a single instance as is declared as static. It was designed to execute one single task ...
- 01:18 PM User Interface Feature #1811: implement the AJAX client driver
- Here are my latest changes.
- 01:12 PM User Interface Feature #1811: implement the AJAX client driver
- The deadlocks does not occur. The callerLatch is always counted down on the finally block when the current task execu...
- 12:57 PM User Interface Feature #1811: implement the AJAX client driver
- Ah, and if you need for the caller to wait for the task to be finished, -you can always use task.wait() at the caller...
- 12:46 PM User Interface Feature #1811: implement the AJAX client driver
- About 0217a: my feeling is that the @TemporaryAccountPool@ and @TemporaryAccountWorker@ changes are prone to deadlock...
- 12:10 PM User Interface Feature #1811: implement the AJAX client driver
- The main difference between web client and swing client is the network layer. Here we have to find solutions to impro...
- 11:50 AM User Interface Feature #1811: implement the AJAX client driver
- In regard to the web client performance DOWN frame issue:
I suspect that the issues we are seeing are probably due... - 11:43 AM User Interface Feature #1811: implement the AJAX client driver
- Code Review 0217a
I am fine with the changes. As far as I can tell, this resolves both the server shutdown issue ... - 11:03 AM User Interface Feature #1811: implement the AJAX client driver
- Here are the changes that I did today:
1. Redirect web client when client exit via System.exit()
We have two s... - 06:57 AM User Interface Feature #1811: implement the AJAX client driver
- I configured the directory.xml and now it works fine.
Just a minor observation.
On note 38 from #2124 - parts 4 fo... - 05:47 AM User Interface Feature #1811: implement the AJAX client driver
- Marius Gligor wrote:
> The build of native artefacts now works but the server start-up fails probably due to major c... - 04:23 AM User Interface Feature #1811: implement the AJAX client driver
- The build of native artefacts now works but the server start-up fails probably due to major changes in design and dir...
- 03:49 AM User Interface Feature #1811: implement the AJAX client driver
- Marius Gligor wrote:
> I did an update form the remote repository and I tried a full build "ant all".
From my follo... - 03:40 AM User Interface Feature #1811: implement the AJAX client driver
- I did an update form the remote repository and I tried a full build "ant all".
The spawn build fails due to:
/usr... - 03:04 AM User Interface Feature #1811: implement the AJAX client driver
- Constantin Asofiei wrote:
> LE: check if the @WatchdogTimer.run:81@ @while (true)@ loop needs to terminate if it was... - 02:51 AM User Interface Feature #1811: implement the AJAX client driver
- Marius Gligor wrote:
> Here are the changes which passed today regression tests.
Passed regression tests. Committ... - 11:53 AM Base Language Support #2233 (Closed): test and fix the native API support on Linux
- 10:50 AM User Interface Bug #2244: web client performance
- Using the ChUI web client with MAJIC exposes some performance problems. Although the web client inherently has a dif...
- 10:23 AM User Interface Bug #2244 (Closed): web client performance
- 10:05 AM Database Feature #2024: implement runtime support for database triggers
- I have merged the update with latest bzr version. The conversion testing passed (as expected, no changes in generated...
02/16/2014
- 08:01 AM Base Language Feature #1624: add support for PUT CONTROL
- Check it in and distribute it.
- 03:20 AM Base Language Feature #1624: add support for PUT CONTROL
- Evgeny Kiselev wrote:
> Final update. Regression is running now.
Passed regression testing - 07:53 AM User Interface Feature #1811: implement the AJAX client driver
- LE: check if the @WatchdogTimer.run:81@ @while (true)@ loop needs to terminate if it was interrupted.
- 07:49 AM User Interface Feature #1811: implement the AJAX client driver
- Marius, there are problems when terminating the P2J server via the "shutdown" command (i.e. @-k@ argument). After at ...
- 04:26 AM Runtime Infrastructure Feature #2124: improve/simplify the startup of server-side batch processes and appserver "agent" ...
- The attached update fixed some oversights (debug was enabled for the spawn's P2J secure connection client and a bug r...
- 10:04 PM Base Language Feature #1634: implement full native library (.so or DLL) support
- Between 2 regression testing runs, all tests have passed except for GSO 167 (and TC JOB 002 which fails as expected i...
02/15/2014
- 03:47 PM User Interface Feature #1805: add missing UI method support
- @Color.toForeground@ receives a @null@ @Color@ instance hence the NPE. It looks like @ColorMapper.toFont@ should hand...
- 12:48 PM User Interface Feature #1805: add missing UI method support
- Vadim: you have a typo on line 23: you need to have @display testt@ instead of @display test@. This was easily spotte...
- 12:13 PM User Interface Feature #1805: add missing UI method support
- I faced with the following conversion problem. The parser makes wrong annotations with links to @schemaname@, @bufnam...
- 02:53 PM Runtime Infrastructure Feature #2124: improve/simplify the startup of server-side batch processes and appserver "agent" ...
- Constantin Asofiei wrote:
> Eric: I don't want to commit it until I update the directory.xml you use to run the serv... - 12:59 PM Runtime Infrastructure Feature #2124: improve/simplify the startup of server-side batch processes and appserver "agent" ...
- Constantin Asofiei wrote:
> Greg Shah wrote:
> > If I understand correctly, this contains fixes for all issues foun... - 10:24 AM Runtime Infrastructure Feature #2124: improve/simplify the startup of server-side batch processes and appserver "agent" ...
- Greg Shah wrote:
> You can check in and distribute this when it passes testing.
Eric: I don't want to commit it unt... - 09:53 AM Runtime Infrastructure Feature #2124: improve/simplify the startup of server-side batch processes and appserver "agent" ...
- Greg Shah wrote:
> If I understand correctly, this contains fixes for all issues found in #1811 except for the probl... - 09:48 AM Runtime Infrastructure Feature #2124: improve/simplify the startup of server-side batch processes and appserver "agent" ...
- Code Review 0214h
The code changes look good. If I understand correctly, this contains fixes for all issues found... - 01:30 PM User Interface Feature #1811: implement the AJAX client driver
- I'm OK with this update. Please manually test the following:
1. The admin console on the MAJIC server.
2. Normal... - 01:55 AM User Interface Feature #1811: implement the AJAX client driver
- I builded a new jetty release. The good news are that web sockets are working now in Google Chrome 32.
- 01:24 PM Base Language Feature #2145: eliminate program-name limitations
- Greg Shah wrote:
> > my concern is that, if the PROPATH gets modified, we might resolve the relative name to a compl... - 01:20 PM Base Language Feature #2145: eliminate program-name limitations
- > my concern is that, if the PROPATH gets modified, we might resolve the relative name to a completely different prog...
- 09:06 AM Base Language Feature #2145: eliminate program-name limitations
- This one proves a little more challenging: the procedure names in error messages and the procedure's @FILE-NAME@ and ...
- 08:59 AM Base Language Feature #1634: implement full native library (.so or DLL) support
- This update is merged up to bzr revision 10466. I am going back through runtime regression testing. The first run f...
- 08:56 AM Base Language Feature #1598 (Closed): shift LOG implementation (MathOps.log()) to BigDecimal
- 07:32 AM Base Language Feature #1598: shift LOG implementation (MathOps.log()) to BigDecimal
- Committed to bzr revision 10466.
- 08:43 AM User Interface Feature #2240 (Closed): implement proper color support in the Swing ChUI and AJAX ChUI clients
- 07:41 PM Base Language Feature #1624: add support for PUT CONTROL
- Final update. Regression is running now.
02/14/2014
- 05:47 PM Base Language Feature #1598: shift LOG implementation (MathOps.log()) to BigDecimal
- Code Review 0214a
The changes look good. You can check them in and distribute them. - 07:13 AM Base Language Feature #1598: shift LOG implementation (MathOps.log()) to BigDecimal
- Introduced @toBigDecimal@ abstract method in @NumberType@ and fixed the file headers. The code changes passed regress...
- 05:37 PM User Interface Feature #1805: add missing UI method support
- Good findings. Go ahead and implement the proper behavior....
- 05:56 AM User Interface Feature #1805: add missing UI method support
- 1) query is not opened....
- 05:26 PM Base Language Feature #1624: add support for PUT CONTROL
- Update the copyright dates and post the final update here. Then start regression testing (both conversion and runtim...
- 07:45 PM Base Language Feature #1624: add support for PUT CONTROL
- Greg Shah wrote:
> Code Review 0208a
>
> 1. Does the @Steam.generateFormattedText()@ have implications when the s... - 02:53 PM Database Bug #2237: wrong historical annotations in dynamic temp-tables
- Replaced the update with the new one with the small change.
It was committed to bzr in rev 10465 and distributed by ... - 02:14 PM Database Bug #2237: wrong historical annotations in dynamic temp-tables
- Ovidiu, you modified @p2o.xml@ and conversion testing has passed. The only other files that changed are new runtime c...
- 01:58 PM Database Bug #2237: wrong historical annotations in dynamic temp-tables
- This is the latest update that is not under testing.
It passed the conversion (I had to manually run the diff - there... - 01:51 PM Database Bug #2237: wrong historical annotations in dynamic temp-tables
- Ovidiu, please post the final update you used for testing and check it in and distribute once it has passed.
- 12:19 PM Runtime Infrastructure Feature #2124: improve/simplify the startup of server-side batch processes and appserver "agent" ...
- This one is merged with mag_upd20140213c.zip from #1811.
- 09:31 AM Runtime Infrastructure Feature #2124: improve/simplify the startup of server-side batch processes and appserver "agent" ...
- This update adds the scheduler cron support and will go into testing; contains other minor fixes too.
- 09:27 AM Runtime Infrastructure Feature #2124: improve/simplify the startup of server-side batch processes and appserver "agent" ...
- I'll use this node to document all the needed setup/configuration for the spawner infrastructure, used in appserver, ...
- 12:00 PM User Interface Feature #1811: implement the AJAX client driver
- Marius Gligor wrote:
> Here are the changes which passed today regression tests.
You can go ahead and release it. - 11:49 AM User Interface Feature #1811: implement the AJAX client driver
- Here are the changes which passed today regression tests.
- 11:04 AM User Interface Feature #1811: implement the AJAX client driver
- Marius Gligor wrote:
> I fixed this issue by replacing the "monospaced" with "monospace" in tty.screen.js line 377 b... - 10:57 AM User Interface Feature #1811: implement the AJAX client driver
- 1. Regarding fonts: During development I realized that fonts are rendered slightly different on web browsers and Java...
- 09:16 AM User Interface Feature #1811: implement the AJAX client driver
- I found another problem in @ClientCore@ this time. There are cases when the P2J Client terminates via @System.exit@. ...
- 07:26 AM User Interface Feature #1811: implement the AJAX client driver
- Marius Gligor wrote:
> I saw that you already did some changes inside WebClientSpawner and the code was moved to Cli... - 07:23 AM User Interface Feature #1811: implement the AJAX client driver
- I saw that you already did some changes inside WebClientSpawner and the code was moved to ClientSpawner.
However the ... - 07:15 AM User Interface Feature #1811: implement the AJAX client driver
- Marius Gligor wrote:
> The bug must be fixed in line 123 as follow:
OK, I'll include the fix with my #2124 update, ... - 07:07 AM User Interface Feature #1811: implement the AJAX client driver
- Unfortunately I found another NPE bug which occur if the spawn or spawn.exe is missing.
In this case the ProcessBuil... - 06:52 AM User Interface Feature #1811: implement the AJAX client driver
- Marius Gligor wrote:
> I just manage to reproduce the bug. I started than I stopped the server without any other act... - 06:46 AM User Interface Feature #1811: implement the AJAX client driver
- I just manage to reproduce the bug. I started than I stopped the server without any other action and the bug occurs.
... - 06:32 AM User Interface Feature #1811: implement the AJAX client driver
- TemporaryAccountWorker thread is used to enable/disable temporary accounts.
Since this operation require a specific ... - 06:12 AM User Interface Feature #1811: implement the AJAX client driver
- It's a bug. In TemporaryAccountWorker line 119 I omitted to check the callerLatch for null value.
The correct code s... - 05:38 AM User Interface Feature #1811: implement the AJAX client driver
- Marius, I've managed to get a NPE in @TemporaryAccountPoolWorker@:...
- 06:04 AM User Interface Feature #1787: implement batch mode support
- Constantin, The config options to start batch mode is:
@swing="client:driver:type=chui_batch client:driver:backgroun... - 05:05 AM User Interface Feature #1787: implement batch mode support
- Eugenie, I've used this configuration to start a client, on linux: @client:driver:type=chui_batch client:mode:batch=t...
- 04:47 AM Runtime Infrastructure Feature #2243: integrate spawn.c changes into winspawn.c
- This task is for integrating the changes added to @spawn.c@ by #2124 into @winspawn.c@.
- 04:45 AM Runtime Infrastructure Feature #2243 (Closed): integrate spawn.c changes into winspawn.c
- 02:16 AM Base Language Feature #2208: create a java application running web services for testing purposes
- Evgeny Kiselev wrote:
> Where I can upload update ?
> I've ~20mb zip archive (with axis2 libs and configs).
Commi... - 07:23 PM Base Language Feature #2208: create a java application running web services for testing purposes
- Where I can upload update ?
I've ~20mb zip archive (with axis2 libs and configs).
02/13/2014
- 04:20 PM Database Bug #2222: WRITE event triggered too early
- As Eric affirmed in a mail I am _modifying some very sensitive code_.
The flush procedure (WRITE triggers and effect... - 02:38 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
- The assumption that they were using a circular linked list is valid, but the rules to add the new field-group are obs...
- 08:36 AM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
- > 1. Strange, but access sibling attributes (PREV-SIBLING, NEXT-SIBLING) of field-groups itself distorted generated g...
- 01:30 PM Base Language Feature #1634: implement full native library (.so or DLL) support
- All testcase updates and captured logs/output are checked into the testcases project.
The code has passed conversi... - 01:03 PM Base Language Feature #1634: implement full native library (.so or DLL) support
- As can be seen from the logs, the remaining diffs are:
1. A missing error 86 in one call to output_float_from_buff... - 12:36 PM Base Language Feature #1634: implement full native library (.so or DLL) support
- This incorporates many fixes and the code review feedback. It allows the API tests to run properly on Linux. The on...
- 01:17 PM Runtime Infrastructure Feature #2124: improve/simplify the startup of server-side batch processes and appserver "agent" ...
- > You mean only the clients started with the spawner, right?
Right.
> we will at least need a broker to run on ... - 12:41 PM Runtime Infrastructure Feature #2124: improve/simplify the startup of server-side batch processes and appserver "agent" ...
- Greg Shah wrote:
> Today we assume that the clients will run on the same system, but I see many use cases where that... - 10:27 AM Runtime Infrastructure Feature #2124: improve/simplify the startup of server-side batch processes and appserver "agent" ...
- > But I don't think I fully grasp the scenario you are referring to: if P2J server S1 wants to start a batch process...
- 10:08 AM Runtime Infrastructure Feature #2124: improve/simplify the startup of server-side batch processes and appserver "agent" ...
- 1. Looking inside the spawner.c code I understood that the spawner became an universal tool.
You add an option to g... - 07:08 AM Runtime Infrastructure Feature #2124: improve/simplify the startup of server-side batch processes and appserver "agent" ...
- About the scheduler and cron: there is the @Quartz@ library from Terracota released under @Apache Licence V2@: http:/...
- 01:47 AM Runtime Infrastructure Feature #2124: improve/simplify the startup of server-side batch processes and appserver "agent" ...
- Greg Shah wrote:
> My only concern is that the server is very tightly coupled to the command line generation for the... - 07:06 PM Runtime Infrastructure Feature #2124: improve/simplify the startup of server-side batch processes and appserver "agent" ...
- Code Review 0212e
I am OK with the changes.
My only concern is that the server is very tightly coupled to the c... - 01:09 PM User Interface Feature #1787: implement batch mode support
- The update uploaded that implements the messageBox() processing for background mode for you to review. The simulated ...
- 07:49 AM User Interface Feature #1787: implement batch mode support
- Eugenie Lyzenko wrote:
> > Eugenie: the modal message boxes are not supported by background mode. On linux pro -b -p... - 07:39 AM User Interface Feature #1787: implement batch mode support
- > Eugenie: the modal message boxes are not supported by background mode. On linux pro -b -p with a MESSAGE ... VIEW-A...
- 04:52 AM User Interface Feature #1787: implement batch mode support
- LE: the @all the pro -b, bpro, and prowin32 -b ways of starting a batch program@ part needs to be expanded with (for ...
- 04:40 AM User Interface Feature #1787: implement batch mode support
- Eugenie: the modal message boxes are not supported by background mode. On linux @pro -b -p@ with a @MESSAGE ... VIEW-...
- 12:23 PM User Interface Feature #1811: implement the AJAX client driver
- Code Review 0213b
The changes look good. Please get it runtime regression tested. - 11:22 AM User Interface Feature #1811: implement the AJAX client driver
- Renamed sync() method to initRemoteTerminal()
I implemented also the screen characters message caching. - 10:52 AM User Interface Feature #1811: implement the AJAX client driver
- OK. I have an idea to cache also the text messages. I'm going to implements this feature.
- 10:47 AM User Interface Feature #1811: implement the AJAX client driver
- Code Review 0213a
I am fine with the code, except for 1 change. I should have looked more carefully at the @sync(... - 09:06 AM User Interface Feature #1811: implement the AJAX client driver
- 1. Regarding sync() method. This is a private method called from the onConnect(session) method, when a new session is...
- 11:29 AM Database Feature #2140 (Review): use positional query substitution parameters in HQLPreprocessor and relat...
- Committed to bzr revision 10462.
- 09:08 AM User Interface Feature #2240 (Review): implement proper color support in the Swing ChUI and AJAX ChUI clients
02/12/2014
- 06:27 PM Base Language Feature #1598: shift LOG implementation (MathOps.log()) to BigDecimal
- Code Review 0212a
It looks pretty good. Fix these minor issues and get it tested:
1. I'd prefer to add an abst... - 04:33 PM Base Language Feature #1598: shift LOG implementation (MathOps.log()) to BigDecimal
- The attached file contains @log@ function implementation and related changes for review.
The implemented @log@ fun... - 06:04 PM User Interface Feature #1811: implement the AJAX client driver
- Code Review 0212a
1. Please note that our maximum line length is 98 characters. The docs haven't been updated. Y... - 12:42 PM User Interface Feature #1811: implement the AJAX client driver
- 1. AWT Color instances are build using now RGB values in ColorPalette.
2. The code used to set the Font color attr... - 05:23 PM Base Language Feature #1634: implement full native library (.so or DLL) support
- > or better:...
- 04:14 PM User Interface Feature #1805: add missing UI method support
- I'm not sure. Having it on our list may be just a mistake. Please write a testcase (or find one in the testcases/ua...
- 01:57 PM User Interface Feature #1805: add missing UI method support
- As far as I can see @DESELECT-ROWS@ method is really implemented.. What needs to be done in the task #2144 for this t...
- 03:59 PM Base Language Feature #1597 (Closed): shift SQRT implementation (MathOps.sqrt()) to BigDecimal
- 02:04 PM Base Language Feature #1597: shift SQRT implementation (MathOps.sqrt()) to BigDecimal
- Committed to revision 10461.
- 10:37 AM Base Language Feature #1597: shift SQRT implementation (MathOps.sqrt()) to BigDecimal
- Code Review 0209a
The code looks good. Please commit and distribute it. - 10:23 AM Base Language Feature #1597: shift SQRT implementation (MathOps.sqrt()) to BigDecimal
- The attached file is the final version.
Note, that the previously added condition of @sqrt(?) == 1@ was removed. ... - 02:22 PM Database Feature #2140: use positional query substitution parameters in HQLPreprocessor and related classes
- This is something Greg or Ovidiu added specifically for composite data type support (specifically, datetime-tz), but ...
- 02:02 PM Database Feature #2140: use positional query substitution parameters in HQLPreprocessor and related classes
- I saw this code which is currently not active...
- 01:45 PM Database Feature #2140: use positional query substitution parameters in HQLPreprocessor and related classes
- Code review 20140212a:
Looks good, nice work. Once it passes the rest of regression testing, please check it in an... - 09:44 AM Database Feature #2140 (WIP): use positional query substitution parameters in HQLPreprocessor and related ...
- Minor update for MAJIC (fixed query in TmpSumCleanupContextHook).
- 09:04 AM Database Feature #2140: use positional query substitution parameters in HQLPreprocessor and related classes
- > How does this update take into account the parameter indices we are managing within the @HQLPreprocessor@ (see @par...
- 01:34 PM Runtime Infrastructure Feature #2124: improve/simplify the startup of server-side batch processes and appserver "agent" ...
- Greg, about your review notes:
A. from note 26:
1. the private key strength: 1024 bytes or better is enforced and i... - 03:40 AM Runtime Infrastructure Feature #2124: improve/simplify the startup of server-side batch processes and appserver "agent" ...
- Greg Shah wrote:
> > I want to have a central place to spawn P2J clients, regardless of their type, as this will all... - 01:26 AM Base Language Feature #2208: create a java application running web services for testing purposes
- Evgeny Kiselev wrote:
> Yes, you are right.
If you think you can solve this in 2-4 hours, then go ahead and solve i...
02/11/2014
- 05:48 PM Base Language Feature #2208: create a java application running web services for testing purposes
- Yes, you are right.
- 02:12 PM Base Language Feature #2208: create a java application running web services for testing purposes
- OK, I think I understand your problem: you are you using embedded AXIS2 web server, which does not support HTTPS. An...
- 08:17 PM Base Language Feature #2208: create a java application running web services for testing purposes
- I have problem with SSL. It's not possible to do it in the internal Axis2 web server(SimpleHttpServer).
Here is a ... - 05:47 PM Base Language Feature #1624: add support for PUT CONTROL
- Code Review 0208a
1. Does the @Steam.generateFormattedText()@ have implications when the statement is not PUT CONT... - 05:41 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
- I'm trying to identify when the Progress creates auxiliary field-group. There are possible 2 variants:
1. Progress cr... - 05:35 PM Database Feature #2140: use positional query substitution parameters in HQLPreprocessor and related classes
- How does this update take into account the parameter indices we are managing within the @HQLPreprocessor@ (see @param...
- 04:54 PM Database Feature #2140: use positional query substitution parameters in HQLPreprocessor and related classes
- Update for review. Passed main part of regression testing. The main idea is to:
1. exclude explicit placeholders ("?... - 05:34 PM User Interface Feature #1811: implement the AJAX client driver
- Code Review 0211a
1. In ColorPalette, let's use RGB values instead of the AWT Color instances. This is more unive... - 05:25 PM User Interface Feature #1811: implement the AJAX client driver
- > 2. According to the P4G manuals the DEFAULT_COLOR_TABLE has 16 colors (0...15) which are reserved, that is, SHOULD ...
- 12:54 PM User Interface Feature #1811: implement the AJAX client driver
- > Seems that pfcolor 3 cannot be converted or not supported.
Looks like PFCOLOR is parsed ok and a valid AST is... - 11:56 AM User Interface Feature #1811: implement the AJAX client driver
- Based on the current COLOR implementation for ChUI native driver I implemented the COLOR for ChUI Swing driver too. (...
- 04:37 PM Runtime Infrastructure Feature #2124: improve/simplify the startup of server-side batch processes and appserver "agent" ...
- > I want to have a central place to spawn P2J clients, regardless of their type, as this will allow us to restrict th...
- 04:14 PM Runtime Infrastructure Feature #2124: improve/simplify the startup of server-side batch processes and appserver "agent" ...
- Code Review 0207e
Sorry, it took me a while to digest this large update. It is quite good. It seems to me that t... - 12:08 PM Runtime Infrastructure Feature #2124: improve/simplify the startup of server-side batch processes and appserver "agent" ...
- Greg Shah wrote:
> > keys are hard coded to 1024-bytes - should we make this configurable?
>
> Yes. Default to 1... - 11:40 AM Runtime Infrastructure Feature #2124: improve/simplify the startup of server-side batch processes and appserver "agent" ...
- > keys are hard coded to 1024-bytes - should we make this configurable?
Yes. Default to 1024 but allow other size... - 01:54 PM User Interface Bug #2241: Uncompilable code is generated when PFCOLOR option is used with DEFINE VARIABLE
- Also note that PFCOLOR in the other statements doesn't generate the actual assignment. So the only option to set PFCO...
- 01:51 PM User Interface Bug #2241: Uncompilable code is generated when PFCOLOR option is used with DEFINE VARIABLE
- The code ...
- 01:09 PM User Interface Bug #2241 (New): Uncompilable code is generated when PFCOLOR option is used with DEFINE VARIABLE
- 06:39 AM User Interface Feature #1787: implement batch mode support
- This is the log after running run_batch.p on windev01 within an appserver. Same as input redirection on linux: all te...
- 06:15 AM User Interface Feature #1787: implement batch mode support
- Eugenie, I've ran the attached program (which executes all your tests except @batch_test0.p@) using the @pro -b -p ru...
02/10/2014
- 04:16 PM User Interface Feature #1787: implement batch mode support
- Testcases have been added.
- 12:42 PM Runtime Infrastructure Feature #2124: improve/simplify the startup of server-side batch processes and appserver "agent" ...
- We should not hard code the paths into the makefile. It is best to require that to be defined as a parameter on the a...
- 12:23 PM Runtime Infrastructure Feature #2124: improve/simplify the startup of server-side batch processes and appserver "agent" ...
- Greg, a question: when using @JNI_CreateJavaVM@ to create a new JVM instance, the compiled code needs to link with th...
- 07:48 AM Runtime Infrastructure Feature #2124: improve/simplify the startup of server-side batch processes and appserver "agent" ...
- Greg Shah wrote:
> 0. As part of the installation/setup of spawn, we would have a keystore in the file system. That... - 10:15 AM User Interface Feature #1811: implement the AJAX client driver
- Today I did a lot of investigations related to COLOR implementation on CHUI Swing and WEB clients.
First I attached ... - 08:51 AM User Interface Feature #1811: implement the AJAX client driver
- Please add some javadoc to describe these important points.
- 02:14 AM User Interface Feature #1811: implement the AJAX client driver
- We have 2 jetty handlers for two targets ./ and ./index.html which load the same page:
1. When the user is first r... - 08:09 PM Base Language Feature #1624: add support for PUT CONTROL
- 1) Added conversion for @COPY-LOB@ from file to memptr
2) Added implementation for @COPY-LOB@
3) Added for @RAW@ ty...
02/09/2014
- 01:08 PM User Interface Feature #1811: implement the AJAX client driver
- I am not sure how the custom colors will be defined for the Swing and Web chuis, but at the moment color-map.xml may ...
- 12:37 PM User Interface Feature #1811: implement the AJAX client driver
- > Hynek recently added proper color support for our NCURSES/WIN32 Console based ChUI client (the ConsoleDriver which ...
- 06:56 AM Database Bug #2236 (Review): HQL error generated from dynamically converted query with extent field refere...
- 06:26 AM Database Bug #2236: HQL error generated from dynamically converted query with extent field reference in wh...
- Committed to bzr revision 10460.
02/07/2014
- 06:52 PM Runtime Infrastructure Feature #2124: improve/simplify the startup of server-side batch processes and appserver "agent" ...
- This adds the SSL certificate generation into the directory and the support to use this data to start processes / web...
- 04:44 PM Runtime Infrastructure Feature #2124: improve/simplify the startup of server-side batch processes and appserver "agent" ...
- Greg Shah wrote:
> The use of BouncyCastle is OK.
OK, Bouncy Castle is limited to only one class and is hidden behi... - 07:58 AM Runtime Infrastructure Feature #2124: improve/simplify the startup of server-side batch processes and appserver "agent" ...
- The use of BouncyCastle is OK.
- 04:08 AM Runtime Infrastructure Feature #2124: improve/simplify the startup of server-side batch processes and appserver "agent" ...
- I saw that is a major code refactoring. As I understood the chuiWeb node will be replaced by a global node and per cl...
- 07:47 PM Runtime Infrastructure Feature #2124: improve/simplify the startup of server-side batch processes and appserver "agent" ...
- I've been trying not to add more external dependencies to the project and use what J2SE provides, but I couldn't find...
- 06:39 PM User Interface Feature #1811: implement the AJAX client driver
- Marius, I'm merging your 0206a.zip update with mine and mainPage and indexPage handlers in ChuiWebDriver.startupServe...
- 12:53 PM User Interface Feature #1811: implement the AJAX client driver
- First, I should have previously mentioned that details about the most recent color work can be found in #1801.
> 1... - 12:13 PM User Interface Feature #1811: implement the AJAX client driver
- Today I started to work on issue #2240 regarding color implementation on swing and web chui clients.
I studied the i... - 09:33 AM User Interface Feature #1811: implement the AJAX client driver
- Update [mag_upd20140206a.zip]
Passed regression tests, committed to bzr revision 10459. - 08:23 AM User Interface Feature #1811: implement the AJAX client driver
- Yes. You just need to post your assessment of the regression testing into Redmine, not the results themselves. At t...
- 08:21 AM User Interface Feature #1811: implement the AJAX client driver
- May I delete the attached files containing the test results?
- 08:15 AM User Interface Feature #1811: implement the AJAX client driver
- The tc_job_002 is expected to fail at that point, so this testing passes.
Please commit the update and distribute it. - 08:00 AM User Interface Feature #1811: implement the AJAX client driver
- Here are the results of my regression tests.
For the first time the CTRL-C test passed.
The main test part has onl... - 06:22 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
- Well, I finished the test for the case of any sequence of DOWN and UP calls.
Test: _mixedupdown1.p_
Description: Th... - 05:31 PM Database Feature #2134: configurable denormalization of extent fields into individual fields in schema con...
- From other side, it is even not needed: such properties already exists in LegacyField annotation:...
- 05:20 PM Database Feature #2134: configurable denormalization of extent fields into individual fields in schema con...
- I added CustomExtentProperty as indicator that property was denormalized. I thought it was simpler. In principle, I a...
- 11:52 AM Database Feature #2134: configurable denormalization of extent fields into individual fields in schema con...
- Vadim Nebogatov wrote:
> CustomExtentProperty annotation needed for remember denormalized property name, this “pseud... - 08:22 AM Database Feature #2134: configurable denormalization of extent fields into individual fields in schema con...
- Eric Faulhaber wrote:
> Why is the @@CustomExtentMethod@ annotation needed? Don't all the getter and setter methods ... - 03:38 PM Database Bug #2222: WRITE event triggered too early
- OK, good work. Please go ahead and implement these changes and document the names of the test cases which you created...
- 03:04 PM Database Bug #2222: WRITE event triggered too early
- Write-to-db is NOT expected at the end of a block including:
- transactions,
- internal procedures
- fun... - 02:42 PM Database Bug #2236: HQL error generated from dynamically converted query with extent field reference in wh...
- > There are some new TODOs added to @TemporaryBuffer.copyAllRows@. What is the plan for those?
1. ... - 09:55 AM Database Bug #2236: HQL error generated from dynamically converted query with extent field reference in wh...
- Code review 20140205a:
In general, looks good. Please regression test.
There are some new TODOs added to @Tempo... - 01:01 PM Database Bug #2237: wrong historical annotations in dynamic temp-tables
- No 'strong' reason. Looking into @AbstractCollection@'s source code, both methods share the same implementation excep...
- 12:08 PM Database Bug #2237: wrong historical annotations in dynamic temp-tables
- > I have fixed that (see DynamicTablesHelper.java:858) before uploading the update.
Why not use @java.util.Set@'s @<... - 09:43 AM User Interface Feature #2238 (Closed): investigate and resolve issues related to browser "session management"
- 09:07 AM User Interface Feature #2238 (Review): investigate and resolve issues related to browser "session management"
- 09:42 AM User Interface Feature #2212 (Closed): design websockets protocol for bidirectional communication between the ja...
- 09:30 AM User Interface Feature #2212: design websockets protocol for bidirectional communication between the javascript ...
- Update [mag_upd20140206a.zip]
Passed regression tests, committed to bzr revision 10459. - 09:07 AM User Interface Feature #2212 (Review): design websockets protocol for bidirectional communication between the ja...
- 04:11 AM User Interface Feature #2240 (WIP): implement proper color support in the Swing ChUI and AJAX ChUI clients
02/06/2014
- 05:29 PM Database Feature #2134: configurable denormalization of extent fields into individual fields in schema con...
- Eric Faulhaber wrote:
> This will require that you become familiar with the @HQLPreprocessor@ class, since it is her... - 05:24 PM Database Feature #2134: configurable denormalization of extent fields into individual fields in schema con...
- Thank you for providing the tests and especially the hints and conversion output; it is very helpful for doing the re...
- 01:16 PM Runtime Infrastructure Feature #2124: improve/simplify the startup of server-side batch processes and appserver "agent" ...
- Attached update contains the scheduler support, used to launch the appserver and batch processes. The spawner infrast...
- 11:14 AM Runtime Infrastructure Feature #2124: improve/simplify the startup of server-side batch processes and appserver "agent" ...
- > do we need to provide a way to read into the directory an existing configuration? I.e. for MAJIC, it will read the ...
- 11:11 AM Runtime Infrastructure Feature #2124: improve/simplify the startup of server-side batch processes and appserver "agent" ...
- Greg, about the security configuration (keystores, truststores, etc):
# do we need to provide a way to read into the... - 12:44 PM User Interface Feature #1811: implement the AJAX client driver
- I sow now that is missing. It wasn't add to bzr. I will include this file also on the next commit.
Thanks. - 12:38 PM User Interface Feature #1811: implement the AJAX client driver
- Marius, a note about 0129a.zip: the archive has a @tty.keymap.js@ file which is not in bzr rev 10457. Please check 01...
- 12:11 PM User Interface Feature #1811: implement the AJAX client driver
- Hynek recently added proper color support for our NCURSES/WIN32 Console based ChUI client (the ConsoleDriver which is...
- 12:06 PM User Interface Feature #1811: implement the AJAX client driver
- OK. Get this regression tested.
- 12:02 PM User Interface Feature #1811: implement the AJAX client driver
- From my point of view I think no.
- 11:57 AM User Interface Feature #1811: implement the AJAX client driver
- Code Review 0206a
It looks really good. Other than adding real color support, is there anything else left to do?
... - 11:45 AM User Interface Feature #1811: implement the AJAX client driver
- Sorry, it was my mistake. I have a short script to build the archive and I had a small problem inside the script.
Pl... - 10:50 AM User Interface Feature #1811: implement the AJAX client driver
- Were the changes to tty.screen.js and tty.socket.js deliberately removed from 0206a?
- 10:14 AM User Interface Feature #1811: implement the AJAX client driver
- 1. The WAIT_TO_DIE javadoc is inaccurate.
Done.
2. Please rename the sartWatchdog() to startWatchdog().
Do... - 12:08 PM User Interface Feature #2240 (Closed): implement proper color support in the Swing ChUI and AJAX ChUI clients
- 10:17 AM Base Language Feature #1597: shift SQRT implementation (MathOps.sqrt()) to BigDecimal
- Looks great!
- 10:02 AM Base Language Feature #1597: shift SQRT implementation (MathOps.sqrt()) to BigDecimal
- Yes, the "4GL" is a typo, thanks for catching it. I am attaching a fix and sending it to regression test.
- 08:15 AM Base Language Feature #1597: shift SQRT implementation (MathOps.sqrt()) to BigDecimal
- Code Review 0205a
This looks good.
My only question is about this table:... - 07:20 PM Base Language Feature #1597: shift SQRT implementation (MathOps.sqrt()) to BigDecimal
- The input of one is covered by the initial approximation, but yes it won't hurt if stated explicitly.
New in the a...
02/05/2014
- 03:04 PM User Interface Feature #1811: implement the AJAX client driver
- Code Review 0205a
1. The WAIT_TO_DIE javadoc is inaccurate.
2. Please rename the sartWatchdog() to startWatchdo... - 10:29 AM User Interface Feature #1811: implement the AJAX client driver
- Here are the latest changes. I fixed also the issue related to isatty() when using spawner.
It was a bug on my spawn... - 09:03 AM Base Language Feature #1624: add support for PUT CONTROL
- > except wrong conversion of @copy-lob from file "test_put_control.txt" to m.@. P2J convert it's in uncompilable code...
- 07:58 PM Base Language Feature #1624: add support for PUT CONTROL
- ...
- 04:53 AM Database Bug #2236 (WIP): HQL error generated from dynamically converted query with extent field reference...
- Update for review. Contains:
1. fix for this issue
2. part of COPY-TEMP-TABLE functionality
3. fix for BUFFER-VALU...
02/04/2014
- 05:48 PM Database Feature #2134: configurable denormalization of extent fields into individual fields in schema con...
- I have attached vmn_upd20140204a.zip for your review.
Updated with latest bzr revision 10458.
Test cases were ... - 03:12 PM User Interface Feature #1811: implement the AJAX client driver
- Indeed. The watchdog timer has been designed to terminate the process when the user close the browser.
Even more whe... - 02:47 PM User Interface Feature #1811: implement the AJAX client driver
- Greg Shah wrote:
> 3. As Constantin noted above, it is a common case for these clients to be left running for a very... - 01:26 PM User Interface Feature #1811: implement the AJAX client driver
- Code Review 0204a
Overall, this is very good.
1. In ChuiWebSimulator, please synchonize any access or assignmen... - 09:40 AM User Interface Feature #1811: implement the AJAX client driver
- Here is the implementation of text attributes (color)
I found the following attributes defined (see ColorAttribute).... - 08:17 PM User Interface Feature #1811: implement the AJAX client driver
- > - the untrusted connection issue will be annoying for "live" usage; for testing is OK, but having to go through thi...
- 08:11 PM User Interface Feature #1811: implement the AJAX client driver
- Code Review 0203b
I am fine with this change. - 03:11 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
- Vadim Gindin wrote:
> Field-group creation is seemed straightforward except @UP@ direction.
OK, I understand now. M... - 08:49 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
- Constantin Asofiei wrote:
> Greg: Vadim I think is talking about a way to identify a field-group without using the h... - 01:17 PM Database Bug #2236: HQL error generated from dynamically converted query with extent field reference in wh...
- I'll post the testcase here....
- 10:09 AM Database Bug #2222: WRITE event triggered too early
- Please see the last notes of VALIDATE statement, in ABL Reference rev 10.2B, page 1115.
- 09:47 AM Runtime Infrastructure Feature #2124: improve/simplify the startup of server-side batch processes and appserver "agent" ...
- > Currently, Utils.getDirectoryNode APIs do not allow for this kind of search: this is either per-server or per-accou...
- 09:45 AM Runtime Infrastructure Feature #2124: improve/simplify the startup of server-side batch processes and appserver "agent" ...
- Greg, another issue: to automatically launch processes via the scheduler, I want to be able to read the various confi...
- 08:43 AM Runtime Infrastructure Feature #2124: improve/simplify the startup of server-side batch processes and appserver "agent" ...
- > we need a secure way of launching a process under a user without access to the user's password
How about this id... - 07:41 AM Runtime Infrastructure Feature #2124: improve/simplify the startup of server-side batch processes and appserver "agent" ...
- > Another improvement that we can do is to keep the \n when we read the password.
> Doing so the spawner cannot be u... - 04:00 AM Runtime Infrastructure Feature #2124: improve/simplify the startup of server-side batch processes and appserver "agent" ...
- Marius Gligor wrote:
> 1. The credentials used by spawner are user/password of the user account, that is, the user m... - 02:25 AM Runtime Infrastructure Feature #2124: improve/simplify the startup of server-side batch processes and appserver "agent" ...
- Marius Gligor wrote:
> 1. The credentials used by spawner are user/password of the user account, that is, the user m... - 02:20 AM Runtime Infrastructure Feature #2124: improve/simplify the startup of server-side batch processes and appserver "agent" ...
- 1. The credentials used by spawner are user/password of the user account, that is, the user must have an account.
...
02/03/2014
- 06:57 PM Base Language Feature #1624: add support for PUT CONTROL
- The first testcase above has a bug (you write out 257 bytes but size the memptr at 256).
Also, it doesn't test the... - 07:15 PM Base Language Feature #1624: add support for PUT CONTROL
- updated tests....
- 06:46 PM Base Language Feature #1597: shift SQRT implementation (MathOps.sqrt()) to BigDecimal
- Code Review 0203b
Overall, this is very good.
1. Should we put a quick out for BigDecimal.ONE?
2. Add javado... - 04:45 PM Base Language Feature #1597 (Review): shift SQRT implementation (MathOps.sqrt()) to BigDecimal
- 09:51 AM Base Language Feature #1597: shift SQRT implementation (MathOps.sqrt()) to BigDecimal
- Attached file changes the precision of the sqrt algorithm to be defined by @decimal.MAX_SCALE@.
- 05:06 AM Base Language Feature #1597: shift SQRT implementation (MathOps.sqrt()) to BigDecimal
- I didn't realize the evaluator already casts the operands to proper types. Attached is the updated code.
- 06:25 PM Base Language Feature #1599: shift EXP implementation (MathOps.pow()) to BigDecimal
- There are 3 other versions of pow() and these all resolve down to using @Math.pow()@ and @double@. These need to be ...
- 04:49 PM Base Language Feature #1599: shift EXP implementation (MathOps.pow()) to BigDecimal
- The title of the issue mentions pow and exp. @MathOps@ contains only @pow@ method, but that is already using @BigDeci...
- 05:50 PM Runtime Infrastructure Feature #2124: improve/simplify the startup of server-side batch processes and appserver "agent" ...
- Yes, I understand the problem.
> if possible (maybe by giving the spawner app higher privileges), start the proces... - 03:53 PM Runtime Infrastructure Feature #2124: improve/simplify the startup of server-side batch processes and appserver "agent" ...
- Greg, a question about launching a process using the spawner. Currently, the @spawn@ application requires as input va...
- 04:44 PM Base Language Feature #1598 (WIP): shift LOG implementation (MathOps.log()) to BigDecimal
- 04:03 PM Database Feature #2207: Remaining issues for dynamic buffers and dynamic tables
- About the issue in note 3. What P2J does in this case:...
- 03:16 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
- Greg: Vadim I think is talking about a way to identify a field-group without using the handle ID in 4GL code, not in ...
- 03:05 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
- The NAME can still be interrogated from converted 4GL code, right? That means there could be code that relies upon t...
- 01:58 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
- I found that I can use the @NAME@ attribute for that purpose (mark the field-group). This attribute has unknown value...
- 12:31 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
- I tried to find out what algorithm is used to generate new field-groups and to reuse existed. The case 3 in my previo...
- 08:13 AM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
- I assume it is possible to access the PRIVATE-DATA for a FIELD-GROUP widget in 4GL code, which means using that attri...
- 02:27 PM Database Bug #2222: WRITE event triggered too early
- Ovidiu Maxiniuc wrote:
> * The AVM performs validation when it leaves a field.
> What does "leaves" means ?
Thi... - 02:11 PM Database Bug #2222: WRITE event triggered too early
- I encountered two sentences that look interesting from the WRITE-trigger pov:
* The AVM performs validation when i... - 12:18 PM User Interface Feature #1811: implement the AJAX client driver
- In regard to the libffi issue, please see note 74 in #1634.
- 12:05 PM User Interface Feature #1811: implement the AJAX client driver
- During the weekend I tried to do some tests on Windows OS and I found two important issues:
1. The File.renameTo(F... - 10:31 AM User Interface Feature #1811: implement the AJAX client driver
- In regard to 0203a, I have some minor concerns with the ClientDriver changes, but please go ahead and commit/distribu...
- 09:52 AM User Interface Feature #1811: implement the AJAX client driver
- The changes look good to me. If Greg has no objections, you can release them.
- 09:45 AM User Interface Feature #1811: implement the AJAX client driver
- Here are the package that I used today on the regression tests.
Passed the regression tests. - 10:12 AM Database Feature #2024: implement runtime support for database triggers
- The @om_upd20140130b.zip@ update fixes a schema-trigger conversion bug when the project contains access to temp-table...
- 08:13 AM Database Feature #2024: implement runtime support for database triggers
- I wasn't expecting special issues as the update only affects schema triggers and majic does not use them.
Surprising... - 09:51 AM Database Feature #1662: runtime support for table parameters
- Also, NO-ERROR option is not properly handled.
- 09:49 AM Database Feature #1662: runtime support for table parameters
- Issue noted in note 4 in #2207 also affects table parameters. The only difference is that the records can't be partia...
02/02/2014
- 06:42 PM Base Language Feature #1597: shift SQRT implementation (MathOps.sqrt()) to BigDecimal
- Attached are the changes for initial review.
The implemented algorithm yields the same results as the native Progr...
02/01/2014
- 08:42 AM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
- Vadim Gindin wrote:
> There are an array of predefined FIELD-GROUP ids and we are calculating actual index (fgidx) i... - 06:09 AM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
- There are possible several principally different cases:
1. Simple case: All DOWN calls have equal steps size. As it ...
01/31/2014
- 02:35 PM User Interface Feature #1811: implement the AJAX client driver
- Marius, about 0131c.zip:
* please make an update without the JS changes in the .html files, and get it conversion te... - 11:31 AM User Interface Feature #1811: implement the AJAX client driver
- 1. The user Refresh action could not be detected. Is the same like closing the browser.
When the user reload the ... - 08:28 AM User Interface Feature #1811: implement the AJAX client driver
- I added the ClientDriver log file redirection implementation.
- 08:11 AM User Interface Feature #1811: implement the AJAX client driver
- 1. The redirection to a log file is not possible from ProcessBuilder because we redirect the stderr for spawner not f...
- 07:40 AM User Interface Feature #1811: implement the AJAX client driver
- Marius Gligor wrote:
> 1. Put screen color message statement isn't implemented on the web client. I have to check ho... - 06:45 AM User Interface Feature #1811: implement the AJAX client driver
- A better way to prevent back navigation by editing history.
- 06:01 AM User Interface Feature #1811: implement the AJAX client driver
- 1. Put screen color message statement isn't implemented on the web client. I have to check how to do that. Could you ...
- 05:33 AM User Interface Feature #1811: implement the AJAX client driver
- Marius, 0131a.zip solves the login problem (I'll let Greg do a full review), but there are some other issues in MAJIC...
- 03:07 AM User Interface Feature #1811: implement the AJAX client driver
- I fixed the issue related to server key store import. It was a misunderstanding related to implementation.
For a web... - 01:12 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
- Marasmus... there is no shift. It's my mistake. It because of wrong order of operations: displaying the value, execut...
- 11:28 AM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
- Constantin Asofiei wrote:
> The field-groups are used to group widgets together (as their names say). It is a lot ea... - 08:57 AM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
- Vadim Gindin wrote:
> I just don't understand the logic of field-groups. Why authors decided to use spare field-grou... - 09:24 AM Database Feature #2207: Remaining issues for dynamic buffers and dynamic tables
- Stas, please put your work on the COPY-TEMP-TABLE handle method on hold. As we discussed previously, this method is n...
- 07:47 AM Database Feature #2207: Remaining issues for dynamic buffers and dynamic tables
- FYI, there is the problem with @COPY-TEMP-TABLE@. Consider the tables...
- 09:20 AM Base Language Feature #1624: add support for PUT CONTROL
- It is close. Some things to add:
1. I think the testing code is too dependent upon using a delimiter. In a scena... - 08:03 AM Base Language Feature #1624: add support for PUT CONTROL
- Is this test correct ?...
- 06:45 AM Base Language Feature #1624 (WIP): add support for PUT CONTROL
- 03:09 AM User Interface Feature #2212: design websockets protocol for bidirectional communication between the javascript ...
- Correct post location is Feature #1811. Please delete my posts.
- 03:05 AM User Interface Feature #2212: design websockets protocol for bidirectional communication between the javascript ...
- I fixed the issue related to server key store import. It was a misunderstanding related to implementation.
For a web...
01/30/2014
- 06:16 PM User Interface Feature #1811: implement the AJAX client driver
- > 1. The browser context menu can be controlled from JS on all major web browsers IE, Firefox and Chrome:
Go ahead... - 01:56 PM User Interface Feature #1811: implement the AJAX client driver
- OK Constatin thanks. Tomorrow I will try to fix this issue.
Are you did tests with the web client? How it's works?
- 01:52 PM User Interface Feature #1811: implement the AJAX client driver
- Marius Gligor wrote:
> I think that using the temporary accounts implementation is OK to authenticate for server key... - 01:43 PM User Interface Feature #1811: implement the AJAX client driver
- OK. In this case I have to do some changes on the ClientCore and potentially on other places.
I think that using the... - 01:36 PM User Interface Feature #1811: implement the AJAX client driver
- Marius Gligor wrote:
> At this moment what I understood is as follow:
> 1. Use the temporary account to connect to ... - 01:33 PM User Interface Feature #1811: implement the AJAX client driver
- OK. I have to think to this issue.
At this moment what I understood is as follow:
1. Use the temporary account... - 12:57 PM User Interface Feature #1811: implement the AJAX client driver
- Marius, I think there is a problem with the temporary accounts. If I understood properly, the process of authenticat...
- 12:20 PM User Interface Feature #1811: implement the AJAX client driver
- The changes inside the mag_upd20140129a.zip archive has been committed to bzr revision 10457
- 11:33 AM User Interface Feature #1811: implement the AJAX client driver
- Please check in and distribute the 0129a update. Make sure to post the bzr revision number here.
- 11:24 AM User Interface Feature #1811: implement the AJAX client driver
- Regarding browser session and JS code.
The web browser are designed to navigate over the Internet and for security ... - 11:08 AM User Interface Feature #1811: implement the AJAX client driver
- After three executions of CTRL-C part regression tests I obtained the same results (see attachments).
The main part ... - 08:11 AM User Interface Feature #1811: implement the AJAX client driver
- > To avoid any confusions maybe is better to eliminate the Dojo zip from CLASSPATH (from manifest file).
No, it is... - 07:49 AM User Interface Feature #1811: implement the AJAX client driver
- To avoid any confusions maybe is better to eliminate the Dojo zip from CLASSPATH (from manifest file).
We could add ... - 07:44 AM User Interface Feature #1811: implement the AJAX client driver
- > The Dojo dependencies zip file is always in the CLASSPATH because is in the list of dependencies inside the manifes...
- 07:43 AM User Interface Feature #1811: implement the AJAX client driver
- > Maybe for safety it's a good idea to design and implements something like a "watchdog" timer used to force an exit ...
- 06:40 AM User Interface Feature #1811: implement the AJAX client driver
- When the page having the JS code running is loaded a WebSocket connection is open.
If the user close the browser the... - 02:28 AM User Interface Feature #1811: implement the AJAX client driver
- The Dojo dependencies zip file is always in the CLASSPATH because is in the list of dependencies inside the manifest ...
- 04:09 PM Database Feature #2024 (WIP): implement runtime support for database triggers
- Temporarily re-opening this issue to post Ovidiu's update to fix some problems with trigger conversion. Ovidiu, pleas...
- 03:52 PM Database Feature #2134: configurable denormalization of extent fields into individual fields in schema con...
- I have attached vmn_upd20140130a.zip with first tests results containing examples of generated DMOs, table hints and ...
- 02:33 PM Base Language Feature #2145: eliminate program-name limitations
- > This suggests that looking into the java stack trace is not correct.
Yes. At the time it was originally coded, ... - 01:46 PM Base Language Feature #2145: eliminate program-name limitations
- This suggests that looking into the java stack trace is not correct. Instead, @ControlFlowOps@ should keep a stack f...
- 01:05 PM Base Language Feature #2145: eliminate program-name limitations
- To understand the limitations of the P2J @PROGRAM-NAME@ implementation, please see the JavaDoc for @EnvironmentOps.ge...
- 02:16 AM User Interface Feature #2238 (WIP): investigate and resolve issues related to browser "session management"
01/29/2014
- 06:14 PM User Interface Feature #1788: implement define rectangle and rectangle widget support
- For now this will only be implemented in ChUI mode.
Start by writing 4GL testcases to show the features of the rec... - 05:29 PM User Interface Feature #1811: implement the AJAX client driver
- For #2238: the following are some potential issues that we need to consider/research. Document your thoughts and fin...
- 05:18 PM User Interface Feature #1811: implement the AJAX client driver
- Code Review 0129a
There are no concerns. Please note that I don't plan to check in the Dojo build, into bzr. I a... - 02:05 PM User Interface Feature #1811: implement the AJAX client driver
- Here is the package that I tested today. The package contains the new jetty 9.1 build.
Due to it size the Dojo zip f... - 05:20 PM User Interface Feature #2238: investigate and resolve issues related to browser "session management"
- Please put all history into the parent task, #1811.
- 05:20 PM User Interface Feature #2238 (Closed): investigate and resolve issues related to browser "session management"
- 12:28 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
- Technically note is correct. I can write "initialize sizer for extent fields and do not initialize for non-extent fie...
- 11:35 AM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
- Stanislav Lomany wrote:
> ... - 07:08 AM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
- @FieldReference.value(int)@ was broken. I'll include this fix in my next update....
- 12:27 PM Base Language Feature #1634: implement full native library (.so or DLL) support
- ... continued
*common-progress.rules*
is good except for the fact that maybe we should make the condition at line ... - 11:33 AM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
- I just don't understand the logic of field-groups. Why authors decided to use spare field-group?! I just don't see an...
01/28/2014
- 04:23 PM Base Language Feature #1634: implement full native library (.so or DLL) support
- Greg Shah wrote:
> ...
> Ovidiu: please review the rules/include/* changes, in regard to assign trigger var def sup... - 07:54 PM Base Language Feature #1634: implement full native library (.so or DLL) support
- OK. Now we are completely using our own libffi Windows builds.
Building libffi libraries from sources using MSYS a... - 02:30 PM User Interface Feature #1811: implement the AJAX client driver
- Code Review 0128c
The code looks good.
> but just for safety is OK.
Exactly.
> 1. We are not use Dojo at ... - 01:47 PM User Interface Feature #1811: implement the AJAX client driver
- I did the changes. Normally no concurrency should occur on this class but just for safety is OK.
I have two other ... - 01:28 PM User Interface Feature #1811: implement the AJAX client driver
- > Sorry, but I don't find any place in this class to use synchronization.
> The open and close methods are synchroni... - 01:13 PM User Interface Feature #1811: implement the AJAX client driver
- Sorry, I changed the date of last changes on the ClientBuilderOptions class header.
- 01:08 PM User Interface Feature #1811: implement the AJAX client driver
- 1. Done. ChuiWebSimulator.onConnect allow us to set the session idle time out which in turn override the default valu...
- 12:52 PM User Interface Feature #1811: implement the AJAX client driver
- > The ConcurrentHashMap is fully thread safe by design and is internally synchronized.
> The Java concurrent package... - 11:44 AM User Interface Feature #1811: implement the AJAX client driver
- I added the missing Result class.
The ConcurrentHashMap is fully thread safe by design and is internally synchronize... - 11:33 AM User Interface Feature #1811: implement the AJAX client driver
- Code Review 0128a
1. In ChuiWebSimulator, I would like to shift to an idle timeout (maxIdleTime) that is set progr... - 10:46 AM User Interface Feature #1811: implement the AJAX client driver
- Here is the implementation for CTRL-C issue and some remarks.
1. A Result object is used instead a boolean value.
... - 01:42 PM Database Bug #2237: wrong historical annotations in dynamic temp-tables
- Looks like this update fixes the issue.
The table legacy name is also added to in-memory AST. When TRPL (p2o.xml) is... - 09:49 AM Database Bug #2237: wrong historical annotations in dynamic temp-tables
- Here is a more complex sample case:...
- 09:43 AM Database Bug #2237 (WIP): wrong historical annotations in dynamic temp-tables
- When creating dynamic temp-tables the field and table annotations are wrong. I could reproduce this in dynamic querie...
- 09:38 AM Database Bug #2237 (Closed): wrong historical annotations in dynamic temp-tables
- 01:38 PM Database Feature #1662: runtime support for table parameters
- > * I was a bit confused by the deferred copy error processing in @TemporaryBuffer@, with the corresponding change in...
- 10:59 AM Database Feature #2207: Remaining issues for dynamic buffers and dynamic tables
- The first issue is not a dynamic tables issue, it is about undo processing for NO-UNDO temp tables. The same result c...
- 05:46 AM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
- Greg Shah wrote:
> I prefer an approach where multiuple virtual widgets on the server resolve to the correct widget ... - 05:32 AM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
- We need be careful when using conditional down (@DOWN WITH FRAME f1@, without an expression) and explicit down (i.e. ...
01/27/2014
- 06:29 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
- As we are getting close to the time for implementation, I want to mention something.
I would like to consider an i... - 06:12 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
- I suppose I can formulate some rule, interpreting the rules, that Progress uses to fill fields with values.
We have ... - 05:43 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
- Constantin Asofiei wrote:
> > The only unclear moment is the algorithm of Fill-in filling with values for me.
> I'm... - 04:06 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
- > The only unclear moment is the algorithm of Fill-in filling with values for me.
I'm not sure what you are refering... - 03:58 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
- I've committed all test procedures I had.
The result of stream test _(streams.p)_ is in file _2162_ext_frame_stre... - 10:35 AM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
- Please commmit the tests for note 36/37 to bzr.
> About cyclic order of field groups I confirm it. All tests show i... - 05:59 PM Base Language Feature #1634: implement full native library (.so or DLL) support
- > What if to build libffi in mingw we have to set up MSYS? Is it acceptable?
Yes. But we would only use that envi... - 05:44 PM Base Language Feature #1634: implement full native library (.so or DLL) support
- Greg, the question. What if to build libffi in mingw we have to set up MSYS? Is it acceptable?
- 02:34 PM Base Language Feature #1634: implement full native library (.so or DLL) support
- The update evl_upd20140127a.zip committed in bzr as 10456. No regression testing required, only Windows syntax code w...
- 01:38 PM Base Language Feature #1634: implement full native library (.so or DLL) support
- Conversion regression testing for ges_upd20140127a.zip has passed. No change occurs in the output. This has been ch...
- 01:31 PM Base Language Feature #1634: implement full native library (.so or DLL) support
- Code Review evl_upd20140127.zip
The change is fine. Check it in and distribute it. Then post the revision number... - 01:02 PM Base Language Feature #1634: implement full native library (.so or DLL) support
- The updates fixes compilation error on Wndows. Also the binaries allow to build p2j.dll on Windows. Has both 64-bit a...
- 11:27 AM Base Language Feature #1634: implement full native library (.so or DLL) support
- This update has some important fixes to make the commons cases work. There is still at least 1 known problem (dealin...
- 08:49 AM Base Language Feature #1634: implement full native library (.so or DLL) support
- Do you have the compilation fixes ready now? If so, please upload them for review.
Have you resolved the way to b... - 01:29 PM Database Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
- Update to Hibernate sources. Committed to bzr revision 10454.
- 11:23 AM Database Feature #2134: configurable denormalization of extent fields into individual fields in schema con...
- The unique index is needed; it is part of the legacy metadata schema and an application may include code which relies...
- 10:23 AM Database Feature #1651 (Closed): add support for dynamic database features
- 10:22 AM Database Feature #1655 (Closed): add conversion and runtime support for certain dynamic database attribute...
- This update fixes problems with the columnLabel and validateExpression annotations (refs #1655), encountered while co...
- 09:51 AM User Interface Feature #1811: implement the AJAX client driver
- Code Review 0127a
I am fine with the code. It looks very good.
My only request is for tty.keyboard.js, tty.key... - 09:40 AM User Interface Feature #1811: implement the AJAX client driver
- > B. Another solution is to use the existing RemoteObject to get a new account and do a re-logon. This scenario shoul...
- 08:30 AM User Interface Feature #1811: implement the AJAX client driver
- 1. Today I did a code review over the JS code. The changes are attached.
2. Also I started to investigate the CTRL...
01/26/2014
- 06:26 PM Database Feature #2134: configurable denormalization of extent fields into individual fields in schema con...
- Could you check my last question (note 45) about order? Similar question should be addressed with newly added @fieldI...
- 09:25 PM Database Feature #1655 (Test): add conversion and runtime support for certain dynamic database attributes ...
- The attached, merged update passed regression testing and was committed by Ovidiu to bzr rev. 10452.
I encountered... - 08:30 PM Database Feature #1652 (Closed): add conversion and runtime support for dynamically prepared temp-tables
- 08:29 PM Database Bug #2236: HQL error generated from dynamically converted query with extent field reference in wh...
- Failing test case is dbuf-query-extent1-dt.p (Stanislav: please provide test case; it is not currently in the testcas...
- 08:19 PM Database Bug #2236 (Closed): HQL error generated from dynamically converted query with extent field refere...
- 08:15 PM Database Feature #2235: fix deployment issues related to dynamic database conversion resources
- In #1652, note 135, Stanislav wrote:
> The following files and directories have to be accessed from the server class... - 08:09 PM Database Feature #2235 (Closed): fix deployment issues related to dynamic database conversion resources
- 08:06 PM Database Feature #1662 (Closed): runtime support for table parameters
01/25/2014
- 04:57 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
- About cyclic order of field groups I confirm it. All tests show it. About Fill-in fields - they have equal IDs at all...
- 07:11 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
- Here are next tests.
1. Test: _frame_line.p_
Description: The goal is to find out is the FRAME-LINE function and ... - 11:04 AM Base Language Feature #1634: implement full native library (.so or DLL) support
- > Eugenie: it is OK to get the compilation issues and the libffi.dll built properly. But after that, pause your work ...
- 09:37 AM Base Language Feature #1634: implement full native library (.so or DLL) support
- Eugenie: it is OK to get the compilation issues and the libffi.dll built properly. But after that, pause your work o...
- 10:45 AM User Interface Feature #1811: implement the AJAX client driver
- It is good, thanks.
- 10:43 AM User Interface Feature #1811: implement the AJAX client driver
- Sorry, was my fault.
- 10:38 AM User Interface Feature #1811: implement the AJAX client driver
- Code Review 0125c
I like it. The only thing I don't understand is why the tty.keymap.js is missing. - 10:26 AM User Interface Feature #1811: implement the AJAX client driver
- Done.
- 10:00 AM User Interface Feature #1811: implement the AJAX client driver
- Code Review 0125b
I like this version better from the perspective of how you made the code better separated.
Bu... - 09:55 AM User Interface Feature #1811: implement the AJAX client driver
- Code Review 0125a
I don't want to remove all the server-side Dojo support that you already provided. Put that wor... - 09:46 AM User Interface Feature #1811: implement the AJAX client driver
- The keyboard listeners are bind on canvas instead document.
The canvas should have the focus in order to receive key... - 06:31 AM User Interface Feature #1811: implement the AJAX client driver
- Looking for a solution to fix the cross browser keystrokes handle issues I found:
Supported Key Combinations:
The... - 09:35 AM Database Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
- As mentioned in #1651 note 5:
> 7. Long term, we want the standard rules to be loaded from the p2j.jar instead of ... - 02:54 AM Database Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
- The following files and directories have to be accessed from the server classpath:...
- 09:29 AM User Interface Feature #2037 (Closed): runtime support for frame options
- 09:29 AM User Interface Feature #1801: add some frame options
- Attached is the actual version that is the merged code that was checked in as 10451.
01/24/2014
- 06:43 PM Base Language Feature #1597 (WIP): shift SQRT implementation (MathOps.sqrt()) to BigDecimal
- 08:29 AM Base Language Feature #1597: shift SQRT implementation (MathOps.sqrt()) to BigDecimal
- I don't know the answer. Often, if the input is a decimal value, then the output can have the same precision. Other...
- 07:58 AM Base Language Feature #1597: shift SQRT implementation (MathOps.sqrt()) to BigDecimal
- What is the expected precision of the algorithm?
- 06:40 PM User Interface Feature #2037 (Review): runtime support for frame options
- 06:38 PM User Interface Feature #1801: add some frame options
- hc_upd20140123b.zip passed regression testing and was checked-in to bazaar repository as revision 10451.
- 06:27 PM Base Language Feature #1634: implement full native library (.so or DLL) support
- Building on Windows notes:
The first thing after including ffi.h into compilation preocess is to change the library_... - 09:46 PM Base Language Feature #1634 (Closed): implement full native library (.so or DLL) support
- 09:37 PM Base Language Feature #1634: implement full native library (.so or DLL) support
- The CTRL-C 3-way tests failed (expected) and there were 5 failures in @tc_job*@ and @tc_dc*@ tests (1 of which always...
- 04:06 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
- Vadim Gindin wrote:
> What do you mean when you are saying "the frame starts with only one field-group (for the firs... - 03:53 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
- Vadim Gindin wrote:
> Why it is needed to have downBody array with only the first row real?
The problems are in th... - 01:56 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
- What do you mean when you are saying "the frame starts with only one field-group (for the first row). When advancing ...
- 01:11 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
- As I can understand this, it sounds reasonable. I just have several questions about details. See below.
Constantin... - 03:29 PM Database Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
- Stas, I looked around this task history and that of related tasks, but I can't seem to find a summary of the configur...
- 01:21 PM Database Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
- Committed to bzr revision 10448.
- 01:19 PM Database Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
- Update for remaining issues. Presumably does not need regression testing.
- 03:19 PM User Interface Feature #1811: implement the AJAX client driver
- > I saw that when a pop-up window is created we can eliminate menu bars and toll bars.
> Do you believe that could b... - 02:27 PM User Interface Feature #1811: implement the AJAX client driver
- Starting from IE 9 preventDefault() is supported. We are interested on IE 10 and IE 11 because IE 9 does not support ...
- 02:20 PM User Interface Feature #1811: implement the AJAX client driver
- Code Review 0124c
My only thought here is that we probably need to always preventDefault() and stopImmediatePropag... - 02:17 PM User Interface Feature #1811: implement the AJAX client driver
- To disable default behavior you may have to do 2 things:
1. Prevent the default behavior. In browsers that suppor... - 01:48 PM User Interface Feature #1811: implement the AJAX client driver
- Some small changes to fix ESC key in IE.
I did more tests on Windows using IE 11 and Chrome 31.
Unfortunately on ... - 12:02 PM User Interface Feature #1811: implement the AJAX client driver
- It's works in IE but I have to fix a small issue. Event preventDefault() does not work properly with IE.
I tested bo... - 11:33 AM User Interface Feature #1811: implement the AJAX client driver
- 1. We have to solve the CTRL-C issue to initialize the converted application without a new server authentication if p...
- 10:58 AM User Interface Feature #1811: implement the AJAX client driver
- Can you please post a list of what is left to do on #2212?
- 10:51 AM User Interface Feature #1811: implement the AJAX client driver
- Code Review 0124a
All the changes look good. I like the more modular approach.
Code Review 0124b
I prefer t... - 10:40 AM User Interface Feature #1811: implement the AJAX client driver
- I did some small improvements and bug fixing. Basically I eliminated the dojo/keys module dependencies.
With this ch... - 01:23 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
- I am running now the full regression on this update. It is based on bzr rev 10450.
It contains the
* om_upd2014012... - 09:59 AM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
- Tested, results are the same:...
- 02:28 AM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
- Vadim: this seems like the BUFFER-FIELD can never be deleted explicitly. I forgot about dynamic buffers - please test...
- 12:33 PM Database Feature #1658 (Closed): improve database trigger support
- 12:33 PM Database Feature #1581 (Closed): add conversion and runtime support for certain metadata constructs
- 11:53 AM User Interface Feature #1787: implement batch mode support
- This was committed as bzr revision 10449.
- 10:20 AM User Interface Feature #1787: implement batch mode support
- The testing results are in:
@10446_f202309_20140124_evl.zip@
Taking into account all sessions the testing has been ... - 09:53 AM User Interface Feature #1787: implement batch mode support
- Code Review 0124a
All the merges look good. Considering that the only tricky merging was in the build scripts, I ... - 09:29 AM User Interface Feature #1787: implement batch mode support
- The code merge with the 10447. Looks like there are no regressions found.
Do I need to commit and distribute? - 08:33 AM Base Language Feature #1596: complete big decimal implementation
- We had moved from use of double to BigDecimal in the past because we found deviations from the 4GL implementation tha...
- 09:47 PM Base Language Feature #1641 (Closed): implement SAX XML support
- 08:33 PM Base Language Feature #1641: implement SAX XML support
- SAX testcases committed at bzr revision 1088.
- 09:46 PM Base Language Feature #1988 (Closed): runtime support for SAX
- 09:45 PM Base Language Support #2234: test and fix native API support on Windows
- Put all history in #1634.
- 09:43 PM Base Language Support #2234 (Closed): test and fix native API support on Windows
- 09:45 PM Base Language Support #2233: test and fix the native API support on Linux
- Put all history in #1634.
- 09:43 PM Base Language Support #2233 (Closed): test and fix the native API support on Linux
- 09:41 PM Base Language Feature #2121 (Closed): implement Java runtime support for native libraries
- 09:41 PM Base Language Feature #1959 (Closed): implement JNI runtime support for native libraries
01/23/2014
- 06:54 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
- I tested the following test case based on note 98...
- 06:26 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
- Notes about @DynamicQueryHelper@ from om_upd20140123a:
* I'm OK with using the @QueryProcessor@ interface instead of... - 06:05 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
- Code review om_upd20140123a:
I'm good with the changes, assuming you will come back around after M7 and finish up ... - 05:09 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
- Changes in this update (beside the things from notes 89, 90 & 97):
* Added support for dereference as left-side of a... - 10:28 AM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
- Update @vmn_upd20140123a.zip@ contains all implemented methods from note 47 excepting @FieldReference.resourceDelete(...
- 03:09 AM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
- Vadim Nebogatov wrote:
> Is current implementation of FieldReference.resourceDelete() correct? What should be tested ... - 02:56 AM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
- About the dynamic query code in om_upd20140122a.zip:
* what I don't like is that we are duplicating code in @parseQu... - 06:02 PM User Interface Feature #1801: add some frame options
- It looks good. Go ahead with testing.
- 05:47 PM User Interface Feature #1801: add some frame options
- Yes, the application will work ok without the color-map.xml file on the classpath. Just an info log entry will be out...
- 05:28 PM User Interface Feature #1801: add some frame options
- Code Review 0123a
I am fine with the version, except that the color-map.xml should not be checked into the P2J pro... - 04:56 PM User Interface Feature #1801: add some frame options
- The attached file includes runtime support of the DCOLOR and PFCOLOR attributes.
- 04:34 PM User Interface Feature #1801: add some frame options
- The implementation is finished. I am doing basic functional tests and will be uploading for review in about half an h...
- 04:13 PM User Interface Feature #1801: add some frame options
- How soon can you upload a candidate for review? I will get it reviewed quickly and hopefully it will be ready for re...
- 03:58 PM User Interface Feature #1801: add some frame options
- Here are the findings.
@DCOLOR@ and @PFCOLOR@ exist only in the form of attributes of INTEGER type. For the chara... - 05:13 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
- Vadim, good findings, but you are misinterpreting something. When you are printing the frame's children in @no-loop-i...
- 04:51 PM Base Language Feature #2232: finish testing the wrapped mode using the web services exposed by the testing server
- Using the server created in #2208, test the web services using wrapped mode and fix any found problems.
Also, fix ... - 04:45 PM Base Language Feature #2232 (Closed): finish testing the wrapped mode using the web services exposed by the tes...
- 04:41 PM Base Language Feature #1644 (Closed): implement SOAP support
- 04:40 PM Base Language Feature #1995 (Closed): runtime support for SOAP
- 04:40 PM Base Language Feature #1645 (Closed): implement web services support
- 04:39 PM Base Language Feature #2022 (Closed): runtime support for web services
- 02:54 PM Database Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
- OK, that's a bit confusing, but got it. Still, please open a separate task to track the features needed for full comp...
- 02:49 PM Database Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
- > I think append- is the only option in scope here, since it can be used in internal code paths. The replace- and loo...
- 02:38 PM Database Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
- Stanislav Lomany wrote:
> 3. COPY-TEMP-TABLE: copy modes: append-, replace- and loose-copy-
I think append- is the ... - 02:29 PM Database Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
- > * Is the @import com.goldencode.p2j.convert.*;@ statement needed in @TemporaryBuffer@?
That is required for @ParmT... - 02:27 PM Database Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
- OK, makes sense. I was understanding this to be a different problem.
- 02:11 PM Database Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
- > Regarding the first error, is it actually necessary to modify Hibernate? I don't know where the code you modified a...
- 01:36 PM Database Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
- Code review 20140123a:
* Is the @import com.goldencode.p2j.convert.*;@ statement needed in @TemporaryBuffer@?
* The... - 01:04 PM Database Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
- Regarding the first error, is it actually necessary to modify Hibernate? I don't know where the code you modified abo...
- 12:24 PM Database Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
- Regarding the second error, this query is generated by the conversion rules for historical reasons, when we handled s...
- 12:21 PM Database Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
- Current state of work. Needs regression testing.
- 10:50 AM Database Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
- > Is there a stack trace that goes with this error that shows the problem at the Hibernate level?...
- 10:18 AM Database Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
- Is there a stack trace that goes with this error that shows the problem at the Hibernate level?
Hibernate cannot d... - 09:59 AM Database Feature #1652: add conversion and runtime support for dynamically prepared temp-tables
- I was pretty sure that extents work normally for dynamic tables, there are several checked in testcases for them. How...
- 02:08 PM User Interface Feature #1787: implement batch mode support
- Looks like the main part is OK. Continue testing with CTRL-C one.
- 01:50 PM User Interface Feature #1811: implement the AJAX client driver
- Code Review 0123a
This is really, really good! I'm glad that you were able to work out an approach that is much m... - 12:01 PM User Interface Feature #1811: implement the AJAX client driver
- 1. The DOM level 3 events specifications are implemented total or partial on all major web browser but sligtly differ...
- 12:57 PM Base Language Feature #1634: implement full native library (.so or DLL) support
- This is a version with more fixes, but it is not finished. Still, it is a good version to put into regression testin...
- 10:29 AM Base Language Feature #1634: implement full native library (.so or DLL) support
- This version fixes a conversion regression found in testing. It has passed conversion regression testing and it also...
- 07:37 PM Base Language Feature #1634: implement full native library (.so or DLL) support
- This is a version that has many fixes implemented. Many native API use cases are now working, but not all use cases ...
01/22/2014
- 06:52 PM User Interface Feature #1801: add some frame options
- I don't fully know the answer. I think you will have to do some testing in the real 4GL.
I do know how we have co... - 06:15 PM User Interface Feature #1801: add some frame options
- A question about DCOLOR and PFCOLOR. Is the following sample the correct way to set the protermcap color?...
- 06:30 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
- I'm repeating that i:handle peculiarities are the same in iterating and non-iterating tests. All tests I have are com...
- 06:27 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
- 2. _external_scoped_frame_ihandle.p_ This test checks behavior of the CURRENT-ITERATION in repeat loop in case when t...
- 06:14 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
- Here are tests and those results.
1. _no_loop_ihandle.p_. Try to check CURRENT-ITERATION behavior in the case when... - 11:38 AM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
- Vadim Gindin wrote:
> What else can I do to find when a widget row is created?
Check your findings with cases when ... - 11:28 AM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
- Constantin Asofiei wrote:
> Vadim, using the test at note 15, check how the body of a down frame evolves in the case... - 06:02 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
- Ovidiu, Vadim: it looks like you are both very close to being finished with your respective pieces. Although we origi...
- 05:41 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
- Vadim Nebogatov wrote:
> Is current implementation of FieldReference.resourceDelete() correct? What should be tested... - 05:20 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
- I see only one usage of @resourceDelete()@ related with buffers – @TempTableBuilder.forceClear()@.
@resourceDelete(... - 04:35 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
- Constantin Asofiei wrote:
> Eric Faulhaber wrote:
> > Sorry, this was my comment and I see how it is misleading. It... - 02:42 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
- Eric Faulhaber wrote:
> Sorry, one more (minor) issue on om_upd20140122a: why did you change the initialization of t... - 02:12 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
- Sorry, one more (minor) issue on om_upd20140122a: why did you change the initialization of the @DynamicQueryHelper.wr...
- 02:03 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
- One more thought on @BufferImpl.findByRowID@: we are using @IndexHelper@ to find the primary index, but @IndexHelper@...
- 01:45 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
- Code review om_upd20140122a:
Looks good, but I also would like Constantin to review the dynamic query generation par... - 12:10 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
- This update adds implementation for the findXyz() dynamic methods and adds the sort clause (using primary index) for ...
- 10:20 AM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
- Eric Faulhaber wrote:
> * In @schema/fixups.xml@, the rule which tests for @type == prog.kw_mand@ is not correct. Th... - 11:35 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
- Code review 20140121a:
Overall looks good, but I have a few questions/concerns:
* In @schema/fixups.xml@, the rul... - 03:12 PM Database Feature #2231: LockType error processing
- With the emergence of the new dynamic features in P2J some of the parameters of the methods/attributes cannot be chec...
- 03:01 PM Database Feature #2231 (Closed): LockType error processing
- 12:30 PM Base Language Feature #1634: implement full native library (.so or DLL) support
- This update resolves all issues from the code review and merges to the bzr 10445 level (the latest at this writing).
... - 11:27 AM User Interface Feature #1787: implement batch mode support
- Code Review 0122a
It looks good. Get it regression tested. - 10:49 AM User Interface Feature #1787: implement batch mode support
- The update clears the notes for previous code review and merges with the recent codebase from bzr.
- 09:14 AM User Interface Feature #1787: implement batch mode support
- > 2. I'm surprised that we don't have to link with additional libraries for pthreads on Linux or the event semaphore ...
- 08:41 AM User Interface Feature #1787: implement batch mode support
- Code Review 0121a
1. After you use throwException() in native code, please don't use @exit(-1)@. Just use @return... - 09:50 AM Base Language Feature #2013 (Closed): implement the SELF system handle
- 09:21 AM Base Language Feature #2013: implement the SELF system handle
- Passed conversion and runtime testing, committed to bzr rev 10445.
- 09:50 AM Base Language Feature #2015 (Closed): runtime support for SELF system handle
- 09:09 AM User Interface Feature #1811: implement the AJAX client driver
- OK, these are good findings.
Please review the DOM level 3 events specification: http://www.w3.org/TR/DOM-Level-3-... - 07:51 AM User Interface Feature #1811: implement the AJAX client driver
- I did some small changes and improvements.
Also I tested a version using native JS instead Dojo. The results are the... - 04:54 AM User Interface Feature #1811: implement the AJAX client driver
- I Tested your code and here are my conclusions:
1. The code does not work at all on IE (Windows) web browser.
...
01/21/2014
- 05:58 PM User Interface Feature #1787: implement batch mode support
- This is the release candidate for review. Works for 64-bit Windows. Need to check with 32-bit, later today.
- 04:52 PM User Interface Feature #1787: implement batch mode support
- OK, it makes sense. Change all the names to be @signals*@ instead of @signal*@.
- 04:20 PM User Interface Feature #1787: implement batch mode support
- Almost all is ready. One point to discuss:
We can not use @signal.h@ as local header file for our library call. It c... - 08:48 AM User Interface Feature #1787: implement batch mode support
- I am fine with the use of a semaphore to block waiting for the signal. As noted above, this can be implemented the s...
- 08:47 AM User Interface Feature #1787: implement batch mode support
- > The folowing code works fine in standalone application but does not work in library(like libp2j):
I have not che... - 08:45 AM User Interface Feature #1787: implement batch mode support
- Code Review 0120b
1. We don't need calls to the ClientCore.loadNativeP2JLibrary() from many different files. We o... - 05:08 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
- I also attached vmn_upd20140121b.zip with tests.
- 01:09 PM Database Feature #1655: add conversion and runtime support for certain dynamic database attributes and met...
- I have attached update vmn_upd20140121a.zip corresponding to current state in note 47. I am continue implementation o...
- 04:57 PM Base Language Bug #2197: fix the error message list cleanup when NO-ERROR mode is enabled and ERROR-STATUS:ERRO...
- First of all I need to understand the problem. As we can see from the tests Java program does not clear error list, b...
- 04:11 PM User Interface Feature #1811: implement the AJAX client driver
- By the way, you re-uploaded mag_upd20140117b.zip when I think you intended to upload mag_upd20140121b.zip.
- 04:09 PM User Interface Feature #1811: implement the AJAX client driver
- I have not gotten to look at your latest code yet.
However, I think you have come to the wrong conclusion in regar... - 02:13 PM User Interface Feature #1811: implement the AJAX client driver
- Here is an improved version for keyboard management. Seems to be closed to the final solution.
Nevertheless I will d... - 10:31 AM User Interface Feature #1811: implement the AJAX client driver
- 1. Today I did the appropriate changes inside the JS code in order to manage the keyboard events.
So far all my t... - 09:39 AM User Interface Feature #1811: implement the AJAX client driver
- Please document the differences between Java/Swing key processing and the Javascript equivalent. It was my understand...
- 03:02 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
- Vadim, using the test at note 15, check how the body of a down frame evolves in the cases I've mentioned at note 22. ...
- 01:25 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
- It does seem that this code can only be used from an interactive UI. That is not something that the server project r...
- 01:23 PM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
- Constantin notes:
Considering that CURRENT-ITERATION is used in the server project only in the adm2/smart.p and th... - 04:07 AM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
- Vadim Gindin wrote:
> The first obstacle is the @CURRENT-ITERATION@ for Buffer is an integer but for @Frame/DialogBo... - 02:33 AM User Interface Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects)
- The first obstacle is the @CURRENT-ITERATION@ for Buffer is an integer but for @Frame/DialogBox@ the @CURRENT-ITERATI...
- 02:11 PM User Interface Feature #1801: add some frame options
- > Any other widget types to test or all the widget types?
FILL-IN and BUTTON. - 02:03 PM User Interface Feature #1801: add some frame options
- Greg Shah wrote:
> > Unless I am missing a usecase here, the code changes are in-line with your points.
>
> OK, I... - 01:18 PM User Interface Feature #1801: add some frame options
- > Unless I am missing a usecase here, the code changes are in-line with your points.
OK, I was misunderstanding th... - 01:46 PM User Interface Feature #2144: add minimum runtime support for methods (server)
- Implement runtime support for DESELECT-ROWS() and MOVE-BEFORE-TAB-ITEM(). Please put all history entries in the pare...
- 11:29 AM Base Language Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
- Based on the NO-ECHO testcases created in #1629, test the P2J implementation for NO-ECHO and make any functional addi...
- 11:06 AM User Interface Feature #2016 (Closed): implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles
- ChUI and batch support is complete, which is sufficient for M7. GUI support will be implemented in #2229.
- 11:05 AM User Interface Feature #2018 (Closed): runtime support for CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW syst...
- 11:03 AM User Interface Feature #2229 (Closed): implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles...
- 04:19 AM Base Language Feature #1645: implement web services support
- Evgeny Kiselev wrote:
> Code Review 0116a:
> 1) @com.goldencode.p2j.xml.XNodeRefImpl#getOwnerDocument()@
> Does @R...
Also available in: Atom