FWD » Core Development

05/10/2019

10:54 PM User Interface Bug #3691: literal $ character in format appears on the right side of the fill-in

Constantin, https://proj.goldencode.com/projects/internal-documentation/wiki/Getting_Started_with_FWD_Development
... Alexei Kaigorodov

08:11 PM Base Language Feature #3753: I18N additions

Task branch @3753a@ has been updated for review to revisions @11332@.
Fixed the regression in @character.java@ and... Eugenie Lyzenko

05/09/2019

07:35 PM Base Language Feature #3753: I18N additions

Conversion passed, source are identical except one added new call to @setNoMap()@ which is OK considering @NO-MAP@ op... Eugenie Lyzenko

04:56 PM Base Language Feature #3753: I18N additions

> If the conversion will be OK can we include the changes for @4010@ and @4066@ into @3753a@ branch to speed up the f... Greg Shah

03:25 PM Base Language Feature #3753: I18N additions

Greg,
The conversion testing is in progress.
If the conversion will be OK can we include the changes for @4010@... Eugenie Lyzenko

12:51 PM Base Language Feature #3753: I18N additions

I'm OK with changes. Minor fixing.
Task branch @3753a@ has been updated for review to revisions @11331@.
This i... Eugenie Lyzenko

09:08 AM Base Language Feature #3753: I18N additions

Revision 11330 fixes a bug in my management of the caching flag. Greg Shah

06:47 AM Base Language Feature #3753: I18N additions

Code Review Task Branch 3753a Revision 11328
The changes are a good step.
I have reworked the code to make @S... Greg Shah

07:32 PM Database Feature #3815: more temp-table options

If we need this information for runtime purposes, then we do need to add this to annotations. Greg Shah

05:09 PM Database Feature #3815: more temp-table options

OK, we have @fieldId@, @order@ and @position@ fields, and the last two are optional. ... Stanislav Lomany

10:42 AM Database Feature #3815: more temp-table options

This seems to be a "feature" of the @BUFFER-FIELD()@ method.
Please see this article:
https://knowledgebase.pro... Greg Shah

09:09 AM Database Feature #3815: more temp-table options

As far as I tested, @LIKE@ and @LIKE-SEQUENTIAL@ behave in the same way (like @LIKE-SEQUENTIAL@). E.g. we have table ... Stanislav Lomany

03:29 AM Database Feature #3815: more temp-table options

Yes, the @BEFORE-TABLE@ option is working for me. I created a small testcase:... Ovidiu Maxiniuc

05:45 PM Base Language Feature #3751: implement support for OO 4GL and structured error handling

There is an issue which has been in the back of my head and bugging me for a while: we solve method name collisions (... Constantin Asofiei

01:07 PM Base Language Feature #3751: implement support for OO 4GL and structured error handling

Code Review Task Branch 3751a Revision 11308
I'm good with the changes. There is quite a bit there!
The @Class... Greg Shah

04:57 PM Database Bug #4071: FWD server stops allowing new web client logins after abend

Greg Shah wrote:
> > > Otherwise we probably need to ensure any rollback is executed on the conversation thread.
> ... Constantin Asofiei

04:55 PM Database Bug #4071: FWD server stops allowing new web client logins after abend

> > Otherwise we probably need to ensure any rollback is executed on the conversation thread.
>
> Agreed. I didn't... Greg Shah

03:31 PM Base Language Feature #3810: SECURITY-POLICY and other security features

Regression testing started. Igor Skornyakov

03:21 PM Base Language Feature #3810: SECURITY-POLICY and other security features

Everything looks good. Please run ChUI regression testing (both conversion and runtime). Greg Shah

02:55 PM Base Language Feature #3810: SECURITY-POLICY and other security features

means that the converted code won't compile because there are no stubs.
Fixed
> 2. @AuditControlManager@ and @Aud... Igor Skornyakov

02:20 PM Base Language Feature #3810: SECURITY-POLICY and other security features

Greg Shah wrote:
> Ovidiu: Please apply your patch from #4073 to 3810a.
Committed as revision 11316 in branch 3810a.
Ovidiu Maxiniuc

01:51 PM Base Language Feature #3810: SECURITY-POLICY and other security features

OK.
Ovidiu: Please apply your patch from #4073 to 3810a.
Igor: After your code review resolutions (and Ovidiu... Greg Shah

01:40 PM Base Language Feature #3810: SECURITY-POLICY and other security features

Constantin Asofiei wrote:
> Also, considering #4073 issue: as HandleCommon was extended with new interfaces, the run... Constantin Asofiei

01:39 PM Base Language Feature #3810: SECURITY-POLICY and other security features

Greg Shah wrote:
> Once the code review items are resolved, I think it makes sense to merge this branch into 3751a (... Constantin Asofiei

01:23 PM Base Language Feature #3810: SECURITY-POLICY and other security features

Once the code review items are resolved, I think it makes sense to merge this branch into 3751a (and then dead-archiv... Greg Shah

01:21 PM Base Language Feature #3810: SECURITY-POLICY and other security features

Code Review Task Branch 3810a Revision 11314
Good update.
1. The gaps marking for the new items should have run... Greg Shah

01:36 PM Bug #4073: code size limit exceeded

The update from note4 looks fine in my tests. Ovidiu Maxiniuc

01:29 PM Bug #4073: code size limit exceeded

Ovidiu, do you have a final fix for this? Constantin Asofiei

11:52 AM User Interface Bug #3691: literal $ character in format appears on the right side of the fill-in

Alexei, if you compile FWD with a @-Dwidget.browser=true@ at the @ant@ command, then you will have a widget browser w... Constantin Asofiei

11:45 AM User Interface Bug #3691: literal $ character in format appears on the right side of the fill-in

Focus on this one: @"$" VIEW-AS TEXT@. Perhaps the problem is that it is being placed in the wrong location? Greg Shah

11:29 AM User Interface Bug #3691: literal $ character in format appears on the right side of the fill-in

There any many use of the $ character .cache files, but not in update-rate-dialog.w.cache (no changes there compared ... Alexei Kaigorodov

10:45 AM User Interface Bug #3691: literal $ character in format appears on the right side of the fill-in

Is there any use of the @$@ character in that program (check the .cache file which has been fully preprocessed)? Greg Shah

09:14 AM User Interface Bug #3691: literal $ character in format appears on the right side of the fill-in

the original code is in file update-rate-dialog.w:
DEFINE VARIABLE roomRate AS DECIMAL FORMAT ">>>,>>9.99":U INITIAL... Alexei Kaigorodov

09:06 AM User Interface Bug #3691: literal $ character in format appears on the right side of the fill-in

> the format string is not changed (and does not contain any dollar sign)
What is the 4GL code that has been conve... Greg Shah

08:55 AM User Interface Bug #3691: literal $ character in format appears on the right side of the fill-in

I saw in debugger that the format string is not changed (and does not contain any dollar sign).
There can be 2 ... Alexei Kaigorodov

10:46 AM Database Feature #3809: ProDataSet support

I do agree that using "HANDLE" seems incorrect for these cases. Aren't these specific types which cannot be intermix... Greg Shah

09:19 AM Database Feature #3809: ProDataSet support

Yes, I though the annotation is incorrect. The type attribute is @"HANDLE"@, too, in @name-map@. I understand they ha... Ovidiu Maxiniuc

08:11 AM Database Feature #3809: ProDataSet support

Ovidiu Maxiniuc wrote:
> Constantin, I have the following definitions in a object:
> [...]
> They are converted in... Constantin Asofiei

08:10 AM Database Feature #3809: ProDataSet support

Constantin, I have the following definitions in a object:... Ovidiu Maxiniuc

04:39 AM Database Feature #3809: ProDataSet support

Please check out the 3751a/11308. Ovidiu Maxiniuc

08:43 AM User Interface Bug #4078 (WIP): cannot login in Hotel demo in Swing mode

Alexei Kaigorodov

07:31 AM User Interface Bug #4078: cannot login in Hotel demo in Swing mode

1. run deploy/server/server.sh
2. run deploy/client/client.sh
3. window appear; enter credentials hotel/hotel
4. t... Alexei Kaigorodov

07:21 AM User Interface Bug #4078 (Closed): cannot login in Hotel demo in Swing mode

Alexei Kaigorodov

08:40 AM User Interface Bug #3630 (Closed): SYSTEM-DIALOG GET-FILE abends with an NPE when INITIAL-DIR not specified

Greg Shah

08:37 AM User Interface Bug #3630: SYSTEM-DIALOG GET-FILE abends with an NPE when INITIAL-DIR not specified

Greg Shah wrote:
> Hynek: Can we close this issue?
Yes, I believe so. I checked the test case and it works OK wit... Hynek Cihlar

08:32 AM User Interface Bug #3630: SYSTEM-DIALOG GET-FILE abends with an NPE when INITIAL-DIR not specified

Hynek: Can we close this issue? Greg Shah

08:30 AM User Interface Bug #3631: SYSTEM-DIALOG FONT won't accept keyboard input in the selection lists

Please work on the initial focus issue. The dialog is implemented in @com/goldencode/p2j/ui/client/gui/FontChooserGu... Greg Shah

08:19 AM User Interface Bug #3631: SYSTEM-DIALOG FONT won't accept keyboard input in the selection lists

If focus manually is pointed into the selection list, keyboard input is possible. Alexei Kaigorodov

08:15 AM User Interface Bug #3631: SYSTEM-DIALOG FONT won't accept keyboard input in the selection lists

If you manually put focus into a selection list, does it accept keyboard input? Greg Shah

05/08/2019

06:13 PM Database Feature #3809: ProDataSet support

Constantin Asofiei wrote:
> Ovidiu, @dataset-handle@ parameters need to convert as @DatasetParameter@ (same as @tabl... Constantin Asofiei

05:57 PM Base Language Feature #3751: implement support for OO 4GL and structured error handling

Created task branch 3751a from trunk rev 11306.
Rev 11307 contains a batch of OO and some misc fixes. Any file wit... Constantin Asofiei

05:45 PM Base Language Feature #3751: implement support for OO 4GL and structured error handling

> Greg, is there a reason why @fixups/stream_references.rules@ wouldn't be ran by @annotations_prep.rules@? The code ... Greg Shah

05:18 PM Base Language Feature #3751: implement support for OO 4GL and structured error handling

Greg, is there a reason why @fixups/stream_references.rules@ wouldn't be ran by @annotations_prep.rules@? The code I ... Constantin Asofiei

04:17 PM Base Language Feature #3751: implement support for OO 4GL and structured error handling

Greg Shah wrote:
> Your approach makes sense, though the "feature" does not make any sense. It is like an implicit ... Constantin Asofiei

04:12 PM Base Language Feature #3751: implement support for OO 4GL and structured error handling

Your approach makes sense, though the "feature" does not make any sense. It is like an implicit static version of a ... Greg Shah

04:09 PM Base Language Feature #3751: implement support for OO 4GL and structured error handling

Greg Shah wrote:
> Do you have an example to help me understand what you mean?
This class:... Constantin Asofiei

04:02 PM Base Language Feature #3751: implement support for OO 4GL and structured error handling

> We need to 'hard-link' it to the proper method definition... and this can only be done by analysing the full table ... Greg Shah

03:59 PM Base Language Feature #3751: implement support for OO 4GL and structured error handling

> @DEF STREAM rpt.@ in a 4GL class can be used from both static and instance methods - and the static usage will have... Greg Shah

03:54 PM Base Language Feature #3751: implement support for OO 4GL and structured error handling

Greg Shah wrote:
> > So, as TABLE parameters allow collisions, and target resolution is done via the temp-table stru... Constantin Asofiei

03:51 PM Base Language Feature #3751: implement support for OO 4GL and structured error handling

> So, as TABLE parameters allow collisions, and target resolution is done via the temp-table structure, in case of co... Greg Shah

05:20 AM Base Language Feature #3751: implement support for OO 4GL and structured error handling

@DEF STREAM rpt.@ in a 4GL class can be used from both static and instance methods - and the static usage will have a... Constantin Asofiei

04:06 PM Database Feature #3815: more temp-table options

Stanislav: Don't do anything on @BEFORE-TABLE@. It will be handled in #3809.
> However, it seems to be already wo... Greg Shah

03:48 PM Database Feature #3815: more temp-table options

Eric Faulhaber wrote:
> Ovidiu, please see previous posts. Is conversion of BEFORE-TABLE already handled as part of ... Ovidiu Maxiniuc

03:28 PM Database Feature #3815: more temp-table options

Ovidiu, please see previous posts. Is conversion of BEFORE-TABLE already handled as part of #3809? Eric Faulhaber

02:42 PM Database Feature #3815: more temp-table options

Do I need to work on @BEFORE-TABLE@ as well? Stanislav Lomany

02:51 PM Database Feature #4056: instrument FWD and supporting libraries to measure database performance

Eric Faulhaber wrote:
> Hynek Cihlar wrote:
> > How about to exclude the FWD classes in aop.xml? So that the FWD cl... Hynek Cihlar

02:30 PM Database Feature #4056: instrument FWD and supporting libraries to measure database performance

Hynek Cihlar wrote:
> How about to exclude the FWD classes in aop.xml? So that the FWD classes are only weaved by th... Eric Faulhaber

02:01 PM Database Feature #4056: instrument FWD and supporting libraries to measure database performance

Eric Faulhaber wrote:
> Hynek Cihlar wrote:
> > I'm not sure how well you can combine load-time and compile-time we... Hynek Cihlar

01:56 PM Database Feature #4056: instrument FWD and supporting libraries to measure database performance

Hynek Cihlar wrote:
> I'm not sure how well you can combine load-time and compile-time weaving.
Actually, I did not... Eric Faulhaber

01:40 PM Database Feature #4056: instrument FWD and supporting libraries to measure database performance

Eric Faulhaber wrote:
> Thank you for the guidance.
>
> I am using compile-time weaving only because that seemed ... Hynek Cihlar

01:32 PM Database Feature #4056: instrument FWD and supporting libraries to measure database performance

Thank you for the guidance.
I am using compile-time weaving only because that seemed to be the most direct way to ... Eric Faulhaber

01:14 PM Database Feature #4056: instrument FWD and supporting libraries to measure database performance

Here is more info on load time weaving http://www.eclipse.org/aspectj/doc/released/devguide/ltw.html. Hynek Cihlar

01:12 PM Database Feature #4056: instrument FWD and supporting libraries to measure database performance

Hynek Cihlar wrote:
> Eric Faulhaber wrote:
> > Hynek, I am using AspectJ to capture method-level profile data (jus... Hynek Cihlar

01:07 PM Database Feature #4056: instrument FWD and supporting libraries to measure database performance

Eric Faulhaber wrote:
> Hynek, I am using AspectJ to capture method-level profile data (just number of invocations a... Hynek Cihlar

12:51 PM Database Feature #4056 (WIP): instrument FWD and supporting libraries to measure database performance

Hynek, I am using AspectJ to capture method-level profile data (just number of invocations and aggregate elapsed time... Eric Faulhaber

01:54 PM User Interface Feature #3908: implement browse column VIEW-AS COMBO-BOX

> Greg, should I run regression testing?
Yes, go ahead. Greg Shah

01:45 PM User Interface Feature #3908: implement browse column VIEW-AS COMBO-BOX

Stanislav Lomany wrote:
> > * ComboBoxGuiImpl.setValue - the condition @config.mode == Mode.DROP_DOWN || config.mode... Hynek Cihlar

01:43 PM User Interface Feature #3908: implement browse column VIEW-AS COMBO-BOX

The issues are addressed in 3908a rev 11313
> * setViewAsComboBox(boolean) - the boolean parameter is redundant an... Stanislav Lomany

01:47 PM User Interface Feature #4077: add option to OPEN-MIME-RESOURCE to delete the original source file when the send ...

@OPEN-MIME-RESOURCE@ is often used when 4GL code generates some output and wants to get it to the user. There is a c... Greg Shah

01:39 PM User Interface Feature #4077 (Closed): add option to OPEN-MIME-RESOURCE to delete the original source file when ...

Greg Shah

01:21 PM Conversion Tools Feature #4076: remove empty triggers during conversion

> I have a question. We can detect if the trigger file is empty quite early, in fixups. Are we able to put a file on ... Greg Shah

12:56 PM Conversion Tools Feature #4076: remove empty triggers during conversion

From the POV of schema triggers only: yes, this should work.
I have a question. We can detect if the trigger file... Ovidiu Maxiniuc

12:49 PM Conversion Tools Feature #4076: remove empty triggers during conversion

One of our customers adds trigger procedures for every permanent database table, even if the trigger is empty. In fa... Greg Shah

12:31 PM Conversion Tools Feature #4076 (New): remove empty triggers during conversion

Greg Shah

12:41 PM Bug #4073: code size limit exceeded

Apparently, the exception was caused because the proxy was implementing only the declaring methods. In @HandleCommon@... Ovidiu Maxiniuc

09:00 AM User Interface Bug #3691: literal $ character in format appears on the right side of the fill-in

From Alexei:
> Installed the Hotel demo and made sure the bug exists, Now thinking how to find the place where th... Greg Shah

08:35 AM User Interface Bug #4075: Combo-box columns 4GL quirks

In 4GL combo box columns are not implemented well: they have a many quirks. The list below describes the differences ... Stanislav Lomany

05:27 AM User Interface Bug #4075 (New): Combo-box columns 4GL quirks

Stanislav Lomany

04:07 AM User Interface Bug #3631: SYSTEM-DIALOG FONT won't accept keyboard input in the selection lists

A test file (attached) runs successfully under FWD (revision 11304).
Keyboard input is accepted, though after moving... Alexei Kaigorodov

02:43 AM User Interface Bug #3630: SYSTEM-DIALOG GET-FILE abends with an NPE when INITIAL-DIR not specified

Cannot reproduce. Created a test file (attached), it runs successfully on FWD (revision 11304). Alexei Kaigorodov

05/07/2019

06:07 PM User Interface Bug #4074: Mismatching ROW-ENTRY/LEAVE events

Also, this code in @Browse.goUp@ doesn't seem valid:... Stanislav Lomany

06:02 PM User Interface Bug #4074: Mismatching ROW-ENTRY/LEAVE events

The issue is that in FWD @ROW-ENTRY@ and @ROW-LEAVE@ events are generated when user leaves or enters a row in editing... Stanislav Lomany

04:27 PM User Interface Bug #4074 (Closed): Mismatching ROW-ENTRY/LEAVE events

Stanislav Lomany

02:57 PM Bug #4073: code size limit exceeded

While working with the new proxy I encountered the following exception:... Ovidiu Maxiniuc

10:11 AM Bug #4073: code size limit exceeded

I found the following patch to work fine:... Ovidiu Maxiniuc

09:22 AM Bug #4073: code size limit exceeded

Today I added some new functionality to FWD and suddenly the client started to abend with... Ovidiu Maxiniuc

09:14 AM Bug #4073 (New): code size limit exceeded

Ovidiu Maxiniuc

12:06 PM Base Language Feature #3810: SECURITY-POLICY and other security features

Added conversion support for:... Igor Skornyakov

08:31 AM Base Language Feature #2135: implement COPY-LOB language statement

Marian Edu wrote:
> Just to be clear on this one, what is already tested and what do we need to test further on it? ... Greg Shah

12:23 AM User Interface Bug #4072: NPE logging into Hotel GUI with Swing client

Found with 4045a/11311 and fresh checkout of hotel_gui rev 197. Probably in trunk 11306 as well. To recreate, just st... Eric Faulhaber

12:19 AM User Interface Bug #4072 (Rejected): NPE logging into Hotel GUI with Swing client

Eric Faulhaber

05/06/2019

06:45 PM Base Language Feature #3753: I18N additions

Greg Shah wrote:
> > Did you mean to implement helper methods in Stream class, correct?
>
> Yes.
Done. Task br... Eugenie Lyzenko

05:54 PM Base Language Feature #3753: I18N additions

> Did you mean to implement helper methods in Stream class, correct?
Yes. Greg Shah

05:49 PM Base Language Feature #3753: I18N additions

Greg Shah wrote:
> I prefer to go with the workers as I documented them. The primary reason is that the logic of wh... Eugenie Lyzenko

05:40 PM Base Language Feature #3753: I18N additions

I prefer to go with the workers as I documented them. The primary reason is that the logic of whether or not we are ... Greg Shah

05:19 PM Base Language Feature #3753: I18N additions

Greg Shah wrote:
>
> The first call to either one of @setConvertSource()@ or @setConvertTarget()@ will always fin... Eugenie Lyzenko

04:47 PM Base Language Feature #3753: I18N additions

Eugenie Lyzenko wrote:
> Greg Shah wrote:
> > 11. In @Stream.setConvertSource(String)@, why is @convert@ set @true@... Greg Shah

04:11 PM Base Language Feature #3810: SECURITY-POLICY and other security features

Added conversion support for... Igor Skornyakov

01:39 PM Base Language Feature #3810: SECURITY-POLICY and other security features

Added conversion support for... Igor Skornyakov

03:30 PM User Interface Feature #3908: implement browse column VIEW-AS COMBO-BOX

Code review 3908a.
* setViewAsComboBox(boolean) - the boolean parameter is redundant and should be removed (false ... Hynek Cihlar

03:18 PM Database Bug #4071: FWD server stops allowing new web client logins after abend

Greg Shah wrote:
> Otherwise we probably need to ensure any rollback is executed on the conversation thread.
Agre... Eric Faulhaber

03:14 PM Database Bug #4071: FWD server stops allowing new web client logins after abend

I'm not saying you are incorrect. It may be a new "feature" of the UNIX socket code. But I think it is an invalid a... Greg Shah

02:29 PM Database Bug #4071: FWD server stops allowing new web client logins after abend

The reason I assumed it was something in the new socket code is that we've had many abnormal ends in the past, where ... Eric Faulhaber

02:26 PM Database Bug #4071: FWD server stops allowing new web client logins after abend

This is persistence context cleanup code. At the persistence level, we don't have any control as to the thread on whi... Eric Faulhaber

02:13 PM Database Bug #4071: FWD server stops allowing new web client logins after abend

> Possibly just a bug in the org.newsclub.net socket code?
Yes, it is possible.
*However*, this database proces... Greg Shah

04:42 AM Database Bug #4071: FWD server stops allowing new web client logins after abend

Eric Faulhaber wrote:
> Is the hung Reader thread preventing port 7449 from being released, because context cleanup ... Constantin Asofiei

12:54 AM Database Bug #4071: FWD server stops allowing new web client logins after abend

I've recently noticed that after some abnormal ends, I can no longer log into the web client without restarting the F... Eric Faulhaber

12:32 AM Database Bug #4071 (New): FWD server stops allowing new web client logins after abend

Eric Faulhaber

06:22 AM Database Feature #3816: table and table handle parameter options

Yes, this one is more urgent since we are about to start work on it. Greg Shah

01:59 AM Database Feature #3816: table and table handle parameter options

Greg Shah wrote:
> Please document the specific questions we have that will require 4GL testcases. I don't know if ... Marian Edu

01:57 AM Base Language Feature #2135: implement COPY-LOB language statement

Just to be clear on this one, what is already tested and what do we need to test further on it? Just the CLOB/BLOB (b... Marian Edu

05/05/2019

12:34 PM Base Language Feature #3753: I18N additions

Greg Shah wrote:
> > We need to know how code page conversion approach if we change CPINTERNAL or CPSTREAM several t... Eugenie Lyzenko

09:09 AM Base Language Feature #3753: I18N additions

> We need to know how code page conversion approach if we change CPINTERNAL or CPSTREAM several time between I/O oper... Greg Shah

05/04/2019

10:44 AM Base Language Feature #3810: SECURITY-POLICY and other security features

1. Fixed @handle@
2. Added/updated gaps data
3. -
4. Added file header and javadoc to @CommonSecurityPolicy@ and ... Igor Skornyakov

10:22 PM Base Language Feature #3753: I18N additions

Task branch @3753a@ has been updated for review to revisions @11327@.
Completed code review notes resolution. To c... Eugenie Lyzenko

08:26 PM Base Language Feature #3753: I18N additions

Task branch @3753a@ has been updated for review to revisions @11326@.
The notes resolved except point @1@(not yet ... Eugenie Lyzenko

05/03/2019

04:49 PM User Interface Feature #3908: implement browse column VIEW-AS COMBO-BOX

Please review 3908a rev 11312, especially the changes for standalone combos. Stanislav Lomany

04:31 PM Base Language Feature #3810: SECURITY-POLICY and other security features

Code Review Task Branch 3810a Revision 11309
The first pass is good. Some items:
1. In @handle.java@, you chan... Greg Shah

10:48 AM Base Language Feature #3810: SECURITY-POLICY and other security features

Added conversion support for... Igor Skornyakov

10:43 AM Base Language Feature #3810: SECURITY-POLICY and other security features

Thank you, Constantin! It works. Igor Skornyakov

10:32 AM Base Language Feature #3810: SECURITY-POLICY and other security features

Constantin Asofiei wrote:
> No, don't add 28 methods - just make sure the conversion rules always wrap a string lite... Constantin Asofiei

10:30 AM Base Language Feature #3810: SECURITY-POLICY and other security features

No, don't add 28 methods - just make sure the conversion rules always wrap a string literal into a @new character(lit... Constantin Asofiei

10:26 AM Base Language Feature #3810: SECURITY-POLICY and other security features

Do we still add multiple signatures for methods with character argument(s) or there is another solution? For example ... Igor Skornyakov

04:09 PM Base Language Feature #3751: implement support for OO 4GL and structured error handling

So, as TABLE parameters allow collisions, and target resolution is done via the temp-table structure, in case of coll... Constantin Asofiei

01:31 PM Base Language Feature #3751: implement support for OO 4GL and structured error handling

Greg Shah wrote:
> I would prefer if the converted name would match the extent value. So @m1(input x as int extent ... Constantin Asofiei

10:36 AM Base Language Feature #3751: implement support for OO 4GL and structured error handling

> a @m1(input x extent)@ and @m1(input x extent 5)@ will have as Java methods @m1_1(int[] x)@ and @m1_2(int[] x)@
... Greg Shah

10:01 AM Base Language Feature #3751: implement support for OO 4GL and structured error handling

Some notes related to #3751-493, solving the collisions in Java signatures. This is solved by ensuring that a 4GL me... Constantin Asofiei

03:32 PM Base Language Feature #3753: I18N additions

Greg Shah wrote:
> 12. @Stream@ is used on both the server and the client. I think the direct usage of @Environment... Eugenie Lyzenko

03:19 PM Base Language Feature #3753: I18N additions

Greg Shah wrote:
> 13. The @Stream.convert@ member is modified multiple times, during construction, possibly when th... Eugenie Lyzenko

02:21 PM Base Language Feature #3753: I18N additions

Greg Shah wrote:
> 11. In @Stream.setConvertSource(String)@, why is @convert@ set @true@ when @targetCp == null@? I... Eugenie Lyzenko

11:28 AM Base Language Feature #3753: I18N additions

> I think it is not the case. I thought about this possibility and the code:
Sorry, I mis-read the code.
> The ... Greg Shah

08:59 PM Base Language Feature #3753: I18N additions

The original 4GL ordering for @GET-CODEPAGES()@:
!code_pages_order.jpg! Eugenie Lyzenko

08:37 PM Base Language Feature #3753: I18N additions

Greg Shah wrote:
> 5. In @I18nOps.getCodePages()@, the returned string will always end in a @,@. Is that how the 4G... Eugenie Lyzenko

01:16 PM Base Language Feature #3854: update appserver support with PASOE features

From Marian:
> Other than that the rest of the day was for setting up one PASOE instance for each and start deploy... Greg Shah

05/02/2019

04:17 PM Base Language Feature #3753: I18N additions

Code Review 3753a Revision 11325
This is a really good update. Some feedback:
1. The change in @DirectoryServe... Greg Shah

10:24 AM Database Feature #3809: ProDataSet support

Ovidiu, @dataset-handle@ parameters need to convert as @DatasetParameter@ (same as @table-handle@ does). Currently t... Constantin Asofiei

10:19 AM Base Language Feature #4064: large-raw data type

In subclassing from @MEMPTR@, we might want to use a name like @SERVER-MEMPTR@. Or we can add an @ON-SERVER@ option ... Greg Shah

10:15 AM Base Language Feature #4064: large-raw data type

> Do you expect for the 4GL programs to be re-written using the large-raw data-type? Because I would use hints at con... Greg Shah

09:43 AM Base Language Feature #4064: large-raw data type

Do you expect for the 4GL programs to be re-written using the @large-raw@ data-type? Because I would use hints at co... Constantin Asofiei

09:45 AM Base Language Support #4032: block/transaction processing context-local and other performance improvements

Greg Shah wrote:
> Constantin: To what extent do we need to look at additional optimizations in @ControlFlowOps@ and... Constantin Asofiei

05/01/2019

07:59 PM Base Language Feature #3753: I18N additions

+4GL tests additional wishes+
It will be good to also have the 4GL testcases that leverage the following Progress ... Eugenie Lyzenko

06:56 PM Base Language Feature #3753: I18N additions

+4GL tests requirement+
More test related area to investigate:
* @LC()@/@CAPS()@ functions for different code pag... Eugenie Lyzenko

05:34 PM Base Language Feature #3753: I18N additions

> As far as I understand the only work left for now in this task is to create the list of the specifications for 4GL ... Greg Shah

05:01 PM Base Language Feature #3753: I18N additions

Task branch @3753a@ has been updated for review to revisions @11325@.
This is the improvement for mapping Java cod... Eugenie Lyzenko

04:29 PM Base Language Feature #3753: I18N additions

+4GL tests requirement+
Another point of the interest for @4GL@ testing is the behavior of the @CHR()@ function in... Eugenie Lyzenko

01:41 PM Base Language Feature #3753: I18N additions

+4GL tests requirement+
The following option's dependency need to be tested in 4GL environment from @CURRENT-LANGU... Eugenie Lyzenko

11:39 AM Base Language Feature #3753: I18N additions

We are arranging for someone to write 4GL testcases to do a deep/comprehensive look at the I18N features.
> What s... Greg Shah

11:04 AM Base Language Feature #3753: I18N additions

Greg Shah wrote:
> > Continue working with next part of the task - translation manager replacement.
>
> Actually,... Eugenie Lyzenko

10:08 AM Base Language Feature #3753: I18N additions

> Continue working with next part of the task - translation manager replacement.
Actually, we are going to defer t... Greg Shah

10:48 PM Base Language Feature #3753: I18N additions

Task branch @3753a@ has been updated for review to revisions @11324@.
The update fixes the bug in @Stream@ while c... Eugenie Lyzenko

05:37 PM User Interface Feature #3908: implement browse column VIEW-AS COMBO-BOX

Rebased task branch 3908a from P2J trunk revision 11306. Stanislav Lomany

04:58 PM Database Feature #3761 (Closed): add DYNAMIC-FUNCTION() support to the dynamic database WHERE clause inter...

As of trunk revision 11302, this functionality is complete. Greg Shah

04:49 PM Base Language Feature #4065: server-side processing of client platform dependencies

Proper processing of "Client Platform Dependencies":/projects/p2j/wiki/Client_Platform_Delegate requires these featur... Greg Shah

04:38 PM Base Language Feature #4065 (Closed): server-side processing of client platform dependencies

Greg Shah

04:37 PM Base Language Feature #4064: large-raw data type

In the 4GL, the @RAW@ type stores binary data up to 31000 bytes in size. For larger binary data, a @MEMPTR@ must be ... Greg Shah

04:29 PM Base Language Feature #4064 (New): large-raw data type

Greg Shah

02:14 PM Database Support #4063: linking looping FIND FIRST/NEXT and FIND LAST/PREV in a set oriented operation

After speaking with Eric, some thoughts:
* The current approach is handled exclusively at runtime.
* The more adv... Greg Shah

02:04 PM Database Support #4063: linking looping FIND FIRST/NEXT and FIND LAST/PREV in a set oriented operation

From Eric:
> Yes. This has been implemented since 2006 as @AdaptiveFind@.
>
> It doesn't detect that it is in ... Greg Shah

02:02 PM Database Support #4063: linking looping FIND FIRST/NEXT and FIND LAST/PREV in a set oriented operation

From Constantin:
> An idea here is to add an UUID at conversion time, to a FIND. This way the runtime can uniquely... Greg Shah

02:01 PM Database Support #4063: linking looping FIND FIRST/NEXT and FIND LAST/PREV in a set oriented operation

Can @FIND FIRST@ and @FIND NEXT@ with same buffer and same @WHERE@ be matched together into a set oriented approach? ... Greg Shah

02:00 PM Database Support #4063 (New): linking looping FIND FIRST/NEXT and FIND LAST/PREV in a set oriented operation

Greg Shah

01:58 PM Database Feature #4033: avoid query for FIND unique when the current record in the buffer would match the ...

I think that in addition to @FIND unique@, there are other cases (@FIND FIRST/LAST@) where we can track enough state ... Greg Shah

01:29 PM Base Language Support #4032: block/transaction processing context-local and other performance improvements

From Eric in #3992-163:
> @SourceNameMapper.removePkg()@ is called hundreds of thousands of times in some use case... Greg Shah

01:27 PM Base Language Support #4032: block/transaction processing context-local and other performance improvements

From Eric (see #3992-162):
> ProcedureManager.hasReferent is showing as a minor bottleneck in some use cases, due ... Greg Shah

01:20 PM Base Language Support #4032: block/transaction processing context-local and other performance improvements

From Eric (see #3992-159):
> We could save a little bit of time by streamlining HandleOps.getLegacyAnnotation. Thi... Greg Shah

01:02 PM Base Language Support #4032: block/transaction processing context-local and other performance improvements

Constantin: To what extent do we need to look at additional optimizations in @ControlFlowOps@ and @ProcedureManager@?... Greg Shah

01:00 PM Base Language Support #4032: block/transaction processing context-local and other performance improvements

@ErrorManager@ should be moved to a @TransactionHelper@ design. For example, @ErrorManager.isPendingError()@ is very... Greg Shah

01:25 PM User Interface Support #4062: getChanges() performance improvements

From Eric (see #3992-162):
> In @LT.getChanges()@, we iterate the entire @frameRegistry@ map on each call, which i... Greg Shah

01:24 PM User Interface Support #4062 (New): getChanges() performance improvements

Greg Shah

01:18 PM Conversion Tools Feature #1757: update ANTLR to latest version

There is a suggestion that moving to ANTLRv4 will improve performance.
On the other hand, we know that tree buildi... Greg Shah

01:17 PM Database Support #4060: investigate converting extent fields to array columns

Note that this task is created in the context of investigating changes that may improve performance, but I don't know... Eric Faulhaber

01:08 PM Database Support #4060: investigate converting extent fields to array columns

We have found on occasion that our default approach of normalizing extent fields of like extent into a secondary tabl... Eric Faulhaber

01:01 PM Database Support #4060 (WIP): investigate converting extent fields to array columns

Eric Faulhaber

01:11 PM Base Language Support #4061: base language performance work

This is a gathering place (master index) of proposed performance work for the base language:
* #4032 block/transac... Greg Shah

01:04 PM Base Language Support #4061 (New): base language performance work

Greg Shah

01:00 PM Database Support #4058: consider denormalizing tables as the default approach

I don't really want to make denormalization the default, as this can result in a huge number of columns in a table, h... Eric Faulhaber

10:49 AM Database Support #4058: consider denormalizing tables as the default approach

We know that denormalizing for all tables is not always a performance improvement, so there may need to be a better a... Greg Shah

10:48 AM Database Support #4058 (New): consider denormalizing tables as the default approach

Greg Shah

11:25 AM User Interface Support #4059: UI performance improvements (master task)

This task is a master index of planned/proposed UI performance work:
* #4912 move UI portions of the web client to... Greg Shah

11:18 AM User Interface Support #4059 (New): UI performance improvements (master task)

Greg Shah

11:13 AM User Interface Feature #3684 (Closed): implement a web theme inspired by material design

Greg Shah

10:46 AM Database Bug #4057: h2 performance degradation

From Eric:
> I'd rather not. 197 has a lot of fixes for regressions in the last few point releases before it.
>
... Greg Shah

10:46 AM Database Bug #4057: h2 performance degradation

As an interim measure, can we go back to 1.4.196 (and add our customizations)? Greg Shah

10:45 AM Database Bug #4057: h2 performance degradation

More from the mailing list:
-------- Forwarded Message --------
Subject: [h2] Re: Recent drops in performance
D... Greg Shah

10:44 AM Database Bug #4057: h2 performance degradation

From Eric:
> We're on (a customized) 1.4.197 (not depicted, but probably somewhere between cyan and red). Greg Shah

10:43 AM Database Bug #4057: h2 performance degradation

From the H2 mailing list:
-------- Forwarded Message --------
Subject: [h2] Re: Recent drops in performance
Dat... Greg Shah

10:42 AM Database Bug #4057 (New): h2 performance degradation

Greg Shah

10:17 AM User Interface Bug #2921 (Closed): fix vertical placement of FILL-IN (editable or not)/LABEL/EDITOR text

Branch 3811a was merged to trunk as revision 11303. Greg Shah

06:32 AM Base Language Feature #3810: SECURITY-POLICY and other security features

Constantin.
Sorry, I forgot to set watch for this task and overlooked your question.
I will try to implement conver... Igor Skornyakov

02:21 AM Database Feature #4056: instrument FWD and supporting libraries to measure database performance

In order to improve the performance of the persistence layer of FWD, we first need to measure the time spent at sever... Eric Faulhaber

02:11 AM Database Feature #4056 (WIP): instrument FWD and supporting libraries to measure database performance

Eric Faulhaber

02:03 AM Database Feature #4055: optimize temp-table output parameter copying

This idea warrants further investigation. Eric Faulhaber

02:02 AM Database Feature #4055: optimize temp-table output parameter copying

Eric wrote:
---
Constantin Asofiei wrote:
> Eric Faulhaber wrote:
> > We could get past the first issue with ... Eric Faulhaber

02:01 AM Database Feature #4055: optimize temp-table output parameter copying

Constantin wrote:
---
Eric Faulhaber wrote:
> We could get past the first issue with some clever insert statem... Eric Faulhaber

02:01 AM Database Feature #4055: optimize temp-table output parameter copying

Eric wrote:
---
Constantin Asofiei wrote:
> Eric, did you notice the time spent during temp-table output param... Eric Faulhaber

02:00 AM Database Feature #4055: optimize temp-table output parameter copying

Constantin wrote:
---
Eric, did you notice the time spent during temp-table output parameter copying, during pr... Eric Faulhaber

01:59 AM Database Feature #4055: optimize temp-table output parameter copying

The following discussion between Constantin and myself is copied from another task... Eric Faulhaber

01:58 AM Database Feature #4055 (WIP): optimize temp-table output parameter copying

Eric Faulhaber

01:32 AM Database Feature #4054: only track specific tables in dirty database

The idea is to improve performance of the persistence layer by only tracking certain tables within the dirty database... Eric Faulhaber

01:28 AM Database Feature #4054 (New): only track specific tables in dirty database

Eric Faulhaber

04/30/2019

09:19 PM Base Language Feature #3753: I18N additions

Task branch @3753a@ has been updated for review to revisions @11322@, @11323@.
The update adds session context are... Eugenie Lyzenko

04/29/2019

08:58 AM Conversion Tools Feature #4053: convert ant buildfile testcases/uast/build.xml into gradle buils file into build g...

The version of our @testcases/uast/build.xml@ is very old. I really don't want to spend any time on it.
We have a... Greg Shah

08:50 AM Conversion Tools Feature #4053: convert ant buildfile testcases/uast/build.xml into gradle buils file into build g...

The converted gradle build file can then be used in 2 ways (as a minimum):
- to create Intellij Idea FWD plugin, a... Greg Shah

05:43 AM Conversion Tools Feature #4053 (New): convert ant buildfile testcases/uast/build.xml into gradle buils file into b...

Alexei Kaigorodov

08:43 AM Base Language Feature #3753: I18N additions

Task branch @3753a@ has been rebased with trunk @11306@, new revision is @11321@. Eugenie Lyzenko

04/27/2019

08:40 AM Base Language Feature #3753: I18N additions

> So there is no conversion/compilation issues. I think we do not need to implement setters for SESSION code pages re... Greg Shah

10:02 PM Base Language Feature #3753: I18N additions

The @settable_cp_attributes.p@... Eugenie Lyzenko

08:54 PM Base Language Feature #3753: I18N additions

Greg Shah wrote:
> ...
> > Also the handling approach has been changed to have conversion by default.
>
> This s... Eugenie Lyzenko

04/26/2019

07:13 PM Base Language Feature #3753: I18N additions

Task branch @3753a@ has been rebased with trunk @11305@, new revision is @11320@. Eugenie Lyzenko

06:51 PM Base Language Feature #3753: I18N additions

Greg Shah wrote:
> Please add conversion and simple runtime support for the attribute getters for all of the codepag... Eugenie Lyzenko

01:01 PM Base Language Feature #3753: I18N additions

Greg Shah wrote:
> > The testing shows the 4GL returns ISO8859-1 for both SESSION:CPSTREAM and SESSION:CPINTERNAL.
... Eugenie Lyzenko

12:47 PM Base Language Feature #3753: I18N additions

Greg Shah wrote:
> > Do we need to implement MAP option here?
> ...
> Maybe. At least the conversion should be s... Eugenie Lyzenko

11:08 AM Base Language Feature #3753: I18N additions

Task branch @3753a@ has been updated for review to revision @11317@.
The update adds conversion and runtime(still ... Eugenie Lyzenko

07:02 AM Base Language Feature #3753: I18N additions

> The testing shows the 4GL returns ISO8859-1 for both SESSION:CPSTREAM and SESSION:CPINTERNAL.
This will depend o... Greg Shah

05:39 AM Base Language Feature #3855: implement equivalent support for REST (classic appserver, PASOE REST and WEB trans...

Greg Shah wrote:
> Question from Marian:
>
> > For classical appsrv there are some session-managed operating mode... Constantin Asofiei

04/25/2019

07:10 PM Base Language Feature #3753: I18N additions

Task branch @3753a@ has been updated for review to revision @11316@.
Testcases repo has been updated to revision @... Eugenie Lyzenko

04:20 PM Base Language Feature #3855: implement equivalent support for REST (classic appserver, PASOE REST and WEB trans...

Question from Marian:
> For classical appsrv there are some session-managed operating modes, do you need to have t... Greg Shah

04/24/2019

06:56 PM Base Language Feature #3753: I18N additions

Task branch @3753a@ has been updated for review to revision @11315@.
Testcases repo has been updated to revision @... Eugenie Lyzenko

09:02 PM Base Language Feature #3753: I18N additions

Task branch @3753a@ has been updated for review to revision @11314@.
Testcases repo has been updated to revision @... Eugenie Lyzenko

03:00 PM Base Language Feature #3751: implement support for OO 4GL and structured error handling

Constantin Asofiei wrote:
> Greg, did you start working on the overload by parameter mode or param's object type? I... Greg Shah

02:20 PM Base Language Feature #3751: implement support for OO 4GL and structured error handling

Greg, did you start working on the overload by parameter mode or param's object type? If not, I need to start workin... Constantin Asofiei

04/23/2019

06:35 PM User Interface Feature #3908: implement browse column VIEW-AS COMBO-BOX

Side issue: a regular combo in FWD with decimals should round decimals according to the format prescision before cmpa... Stanislav Lomany

09:57 AM User Interface Feature #3908: implement browse column VIEW-AS COMBO-BOX

> It is interesting than for integer columns
For decimal columns too.
Stanislav Lomany

09:54 AM User Interface Feature #3908: implement browse column VIEW-AS COMBO-BOX

It is interesting than for integer columns spaces are taken into cosideration for comparision. So... Stanislav Lomany

04:58 PM Base Language Feature #3753: I18N additions

The testing shows the 4GL returns @ISO8859-1@ for both @SESSION:CPSTREAM@ and @SESSION:CPINTERNAL@. In @FWD@ we have ... Eugenie Lyzenko

01:34 PM Base Language Feature #3753: I18N additions

Task branch @3753a@ has been rebased with trunk @11304@, new revision is @11313@. Eugenie Lyzenko

10:34 PM Base Language Feature #3753: I18N additions

So far the next steps plan will be to focus on stream related codepage processing:
- @SESSION:CPSTREAM@
- @INPUT ST... Eugenie Lyzenko

09:00 PM Base Language Feature #3753: I18N additions

Task branch @3753a@ has been updated for review to revision @11312@.
This small update fixes double element for @K... Eugenie Lyzenko

03:53 PM User Interface Feature #3876: add support for "direct font control" at the widget level

This issue is resolved with revision 11306 in 3767a. Please review. Hynek Cihlar

01:31 PM Base Language Feature #3751: implement support for OO 4GL and structured error handling

Go ahead. Greg Shah

01:15 PM Base Language Feature #3751: implement support for OO 4GL and structured error handling

Greg, my WIP changes (by volume) are more misc than OO. I'd like to create a 3859a branch, finish/stabilize/review cu... Constantin Asofiei

01:17 PM Database Feature #3809: ProDataSet support

3809a was merged to trunk as r11304. Fresh new 3809c was created for following changes on this task. Ovidiu Maxiniuc

11:47 AM Database Feature #3809: ProDataSet support

Greg Shah wrote:
> To be safe, please put this back through conversion regression testing. If it passes for the ChU... Ovidiu Maxiniuc

09:53 AM Database Feature #3809: ProDataSet support

Ovidiu Maxiniuc wrote:
> Eric, what do you say?
Yes, I like this better. Eric Faulhaber

09:40 AM Database Feature #3809: ProDataSet support

Constantin Asofiei wrote:
> Ovidiu, there is a regression in 3809a: you've added the @kw_cpy_ttbl@ to the top @load_... Ovidiu Maxiniuc

02:43 AM Database Feature #3809: ProDataSet support

Ovidiu, there is a regression in 3809a: you've added the @kw_cpy_ttbl@ to the top @load_descriptors@ function, and th... Constantin Asofiei

07:34 AM User Interface Feature #1795: implement printing support (real GUI printing not the child process stuff used in ...

> I added it to a Possenet zip file which later on became the initial revision of the repository.
Ahh. That expla... Greg Shah

02:39 AM User Interface Feature #1795: implement printing support (real GUI printing not the child process stuff used in ...

Greg Shah wrote:
> Hynek Cihlar wrote:
> > The attached file is the modified @_osprint.p@ with the native code remo... Hynek Cihlar

04/22/2019

06:32 PM User Interface Feature #4049: implement mouse wheel for combo-boxes

It affects drop-down mode. But in the attached testcase I can observe scrolling issues in simple mode, but the scroll... Stanislav Lomany

06:13 PM User Interface Feature #4049: implement mouse wheel for combo-boxes

Stanislav: Is this for the drop down mode or simple mode or both? Greg Shah

06:12 PM User Interface Feature #4049 (New): implement mouse wheel for combo-boxes

Greg Shah

06:09 PM User Interface Feature #3908: implement browse column VIEW-AS COMBO-BOX

Correction: 4GL behaves correctly for non-character columns regarding cell rendering and item selection when a cell g... Stanislav Lomany

01:12 PM User Interface Feature #3908: implement browse column VIEW-AS COMBO-BOX

BTW scrolling with mouse wheel is not implemented for regular combo-boxes. Stanislav Lomany

09:32 AM User Interface Feature #3908: implement browse column VIEW-AS COMBO-BOX

> The issue described in #3908-10 is questionable. Personally, I would like to implement a normal behavior. Because s... Greg Shah

08:31 AM User Interface Feature #3908: implement browse column VIEW-AS COMBO-BOX

> Can we do something simple to allow non-character fields to be functional without breaking compatibility?
Charac... Stanislav Lomany

07:37 AM User Interface Feature #3908: implement browse column VIEW-AS COMBO-BOX

Stanislav Lomany wrote:
> > If there is no corresponding value in combo box-list, it displays the last used combo-bo... Greg Shah

04:28 AM User Interface Feature #3908: implement browse column VIEW-AS COMBO-BOX

> If there is no corresponding value in combo box-list, it displays the last used combo-box value for this column. So... Stanislav Lomany

02:37 PM Base Language Feature #3854: update appserver support with PASOE features

> I'm not sure the REST/SOAP/WEB can be handled via the 4GL SERVER handle (and CONNECT statement) - these are specifi... Greg Shah

02:18 PM Base Language Feature #3854: update appserver support with PASOE features

A high-level plan on testing the PASOE behavior:
* documentation how to configure and setup PASOE: multi-session age... Constantin Asofiei

01:27 PM Base Language Feature #3753: I18N additions

Task branch @3753a@ has been updated for review to revision @11311@.
The update reflects gap marking status change... Eugenie Lyzenko

01:20 PM Base Language Feature #3810: SECURITY-POLICY and other security features

Igor, do you have an ETA for the conversion side of this task (and stubbed runtime)? At least these attributes are r... Constantin Asofiei

01:07 PM User Interface Feature #3281: implement some frame options

Greg Shah wrote:
> The gap marking for the color phrase seems wrong (from @rules/gaps/user_interface.rules@):
>
>... Constantin Asofiei

10:21 AM User Interface Feature #3281: implement some frame options

The gap marking for the color phrase seems wrong (from @rules/gaps/user_interface.rules@):... Greg Shah

11:42 AM User Interface Bug #3686 (Closed): PSTimer threads must be cleaned up when the client session terminates

Branch 3750b was merged to trunk as revision 11302. Greg Shah

10:24 AM User Interface Bug #3686: PSTimer threads must be cleaned up when the client session terminates

Greg Shah wrote:
> Did branch 3750b resolve this issue?
Yes. Constantin Asofiei

10:12 AM User Interface Bug #3686: PSTimer threads must be cleaned up when the client session terminates

Did branch 3750b resolve this issue? Greg Shah

07:56 AM Database Feature #3816: table and table handle parameter options

Please document the specific questions we have that will require 4GL testcases. I don't know if we will be able to g... Greg Shah

07:51 AM Database Feature #3816: table and table handle parameter options

3809a contains some changes that implement dataset parameters. This will be merged to trunk shortly. As part of thi... Greg Shah

07:48 AM Database Feature #3815: more temp-table options

> BEFORE-TABLE
Isn't this going to be handled as part of the work for #3809? Greg Shah

02:46 AM Database Feature #3809: ProDataSet support

Ovidiu, please rebase 3809a. Constantin Asofiei

04/20/2019

10:58 PM Base Language Feature #3753: I18N additions

Task branch @3753a@ has been updated for review to revision @11310@.
This is completed implementation for @CHR/ASC... Eugenie Lyzenko

04/19/2019

05:59 PM User Interface Feature #3940: CREATE-RESULT-LIST-ENTRY() method support

Addition: 10. We may also want to test @EACH, FIRST/LAST/UNIQUE@ cases. Really not sure about cases where @FIRST/LAST... Stanislav Lomany

09:14 AM User Interface Feature #3940: CREATE-RESULT-LIST-ENTRY() method support

> Testcases should be for all FWD query types: PreselectQuery, AdaptiveQuery, CompoundQuery etc. (we need to provide ... Greg Shah

07:57 AM User Interface Feature #3940: CREATE-RESULT-LIST-ENTRY() method support

> What aspects of the problem still need testcases? We will have external resources write these.
Testcases for @Q... Stanislav Lomany

04:55 PM Database Feature #3809: ProDataSet support

Code Review Task Branch 3809a Revision 11316
I'm good with the changes. Constantin will include the @Preprocessor... Greg Shah

04:44 PM Database Feature #3809: ProDataSet support

The revision 11316 adds some new runtime support. It passed the DataSet Test Suite conversion test. Ovidiu Maxiniuc

03:38 PM Database Feature #3809: ProDataSet support

Greg Shah wrote:
> Code Review Task Branch 3809a Revision 11315
> 2. I think the gap marking needs to be updated wi... Ovidiu Maxiniuc

03:34 PM Database Feature #3809: ProDataSet support

Greg Shah wrote:
> 1. Constantin: In regard to the @Preprocessor@ change:
>
> * Does this resolve #3846 (I assume... Constantin Asofiei

03:30 PM Database Feature #3809: ProDataSet support

Code Review Task Branch 3809a Revision 11315
Generally, I'm good with this code. Some small items are below.
1... Greg Shah

02:38 PM Database Feature #3809: ProDataSet support

Thanks, Ovidiu - 3809a rev 11315 fixes my case for the OO method calls. Constantin Asofiei

01:32 PM Database Feature #3809: ProDataSet support

Sorry,
After my first reply I double checked the branch. I forgot to merge in the TRPL changes :(. Please update to... Ovidiu Maxiniuc

01:29 PM Database Feature #3809: ProDataSet support

Constantin Asofiei wrote:
> Ovidiu, I assume the conversion rules for dataset as function call argument are still WI... Ovidiu Maxiniuc

01:26 PM Database Feature #3809: ProDataSet support

Ovidiu, I assume the conversion rules for dataset as function call argument are still WIP? Constantin Asofiei

09:13 AM Database Feature #3809: ProDataSet support

A bit later than expected I have the solution for @append@ and/or @by-reference@ datasets.
I tried to use the same c... Ovidiu Maxiniuc

01:51 PM User Interface Feature #1795: implement printing support (real GUI printing not the child process stuff used in ...

Hynek Cihlar wrote:
> The attached file is the modified @_osprint.p@ with the native code removed using the implemen... Greg Shah

08:27 PM Base Language Feature #3753: I18N additions

Task branch @3753a@ has been updated for review to revision @11309@.
The update adds target/source code page handl... Eugenie Lyzenko

04/18/2019

05:48 PM Base Language Feature #3751: implement support for OO 4GL and structured error handling

Some other things to consider:
* The following cannot appear in a @DEF VAR@ that is local to a method:
** @PUBLIC... Greg Shah

04:46 PM Base Language Feature #3751: implement support for OO 4GL and structured error handling

There is one more case of the 'method var leak' - if a method-scoped var has the same name as a var defined in a supe... Constantin Asofiei

01:56 PM Base Language Feature #3751: implement support for OO 4GL and structured error handling

Constantin Asofiei wrote:
> There is another flaw related to tempidx: we compute this during pre-scan and the normal... Constantin Asofiei

05:19 PM Database Feature #3809: ProDataSet support

Ovidiu: How long do you expect the parameter support changes to take? It may make sense to hold 3809a for those chan... Greg Shah

05:15 PM Database Feature #3809: ProDataSet support

Greg Shah wrote:
> Constantin: Is it OK to deal with #3809-70 in another branch? Or will that cause us other issues... Constantin Asofiei

05:10 PM Database Feature #3809: ProDataSet support

I'm inclined to get this merged to trunk.
Constantin: Is it OK to deal with #3809-70 in another branch? Or will t... Greg Shah

02:56 PM Database Feature #3809: ProDataSet support

Greg Shah wrote:
> Is there enough runtime change to make runtime regression testing useful?
I think not. I summary... Ovidiu Maxiniuc

02:36 PM Database Feature #3809: ProDataSet support

Ovidiu, I need support for @dataset@ references passed to i.e. function calls (and from this I will adapt for OO meth... Constantin Asofiei

02:30 PM Database Feature #3809: ProDataSet support

Is there enough runtime change to make runtime regression testing useful? Greg Shah

01:44 PM Database Feature #3809: ProDataSet support

The r11310 passed the conversion test on devsrv01, with no changes in generated code compared to latest trunk. I do n... Ovidiu Maxiniuc

12:21 PM Database Feature #3809: ProDataSet support

> And one more thing, I was not able to eliminate the ambiguity warning from progress grammar.
Resolved in revisio... Greg Shah

04:02 PM User Interface Feature #3908: implement browse column VIEW-AS COMBO-BOX

Strange, but only @character@ combo columns display the item description instead of the item value in a cell. However... Stanislav Lomany

09:29 AM User Interface Feature #3908: implement browse column VIEW-AS COMBO-BOX

> I assume that @value@ means the raw data in the backing lvalue (variable or database field). Correct?
Yes.

>... Stanislav Lomany

09:01 AM User Interface Feature #3908: implement browse column VIEW-AS COMBO-BOX

I'm trying to understand your syntax in the last note.
I assume that @value@ means the raw data in the backing lva... Greg Shah

03:06 PM Base Language Feature #3753: I18N additions

Greg Shah wrote:
> > And I need to consider another possible internal representation of the 4GL character type. May ... Eugenie Lyzenko

03:04 PM Base Language Feature #3753: I18N additions

Task branch @3753a@ has been updated for review to revision @11308@. The tescases repo has been updated to rev. @1836... Eugenie Lyzenko

09:38 AM Base Language Feature #3753: I18N additions

> And I need to consider another possible internal representation of the 4GL character type. May be integer array is ... Greg Shah

12:21 AM Base Language Feature #3753: I18N additions

After reading some background info and Progress documentation some point become more clear for implementation perspec... Eugenie Lyzenko

04/17/2019

07:58 PM User Interface Feature #3908: implement browse column VIEW-AS COMBO-BOX

Currently browse cells are rendered at the server side: @value --srv--> screen-value@. Combo columns add a new layer ... Stanislav Lomany

03:46 AM User Interface Feature #3908: implement browse column VIEW-AS COMBO-BOX

> I'm trying to imagine the insane code inside the 4GL that causes this. It makes no sense at all.
I guess that's... Stanislav Lomany

08:04 PM User Interface Feature #3908: implement browse column VIEW-AS COMBO-BOX

> So, from a user's perspective if a cell has no corresponding value in the combo-box, a random value will be display... Greg Shah

05:20 PM Base Language Feature #3753: I18N additions

> For any char the transformations 1.(code page 1) -> 2.(code page 2) -> 3.(code page 1) must get the original charac... Greg Shah

05:01 PM Base Language Feature #3753: I18N additions

Progress handles its various text processing/sorting/conversion using 5 possible input tables:
* character attribu... Greg Shah

03:04 PM Database Feature #3809: ProDataSet support

Fixed hierarchy and some annotation. Added runtime support. refid: #3809
Committed revision 11311. Ovidiu Maxiniuc

04/16/2019

06:20 PM Base Language Feature #3753: I18N additions

Task branch @3753a@ has been updated for review to revision @11307@.
This adds base level of the @CODEPAGE-CONVERT... Eugenie Lyzenko

07:53 AM Base Language Feature #3753: I18N additions

Task branch @3753a@ has been rebased with trunk @11303@, new revision is @11306@. Eugenie Lyzenko

11:00 PM Base Language Feature #3753: I18N additions

Don't implement the @CURRENT-LANGUAGE@ runtime right now. I think this needs to wait until we have tests that show t... Greg Shah

10:35 PM Base Language Feature #3753: I18N additions

Greg Shah wrote:
> > The result - we already have full conversion and runtime support for this based on current dire... Eugenie Lyzenko

10:21 PM Base Language Feature #3753: I18N additions

Task branch @3753a@ has been updated for review to revision @11305@.
Added stub to handle generic case of the @COD... Eugenie Lyzenko

04:27 PM User Interface Feature #3908: implement browse column VIEW-AS COMBO-BOX

FYI. When a combo-box cell gains focus, it displays the value which corresponds the cell value. If there is no corres... Stanislav Lomany

10:24 AM User Interface Feature #3908: implement browse column VIEW-AS COMBO-BOX

> Please summarize status here.
I'm working on rendering/screen-value part. Because combo-box cells behavior diffe... Stanislav Lomany

08:49 AM User Interface Feature #3908: implement browse column VIEW-AS COMBO-BOX

Please summarize status here.
When will this be complete and stable? Greg Shah

01:00 PM Database Feature #3809: ProDataSet support

Constantin Asofiei wrote:
> 3809a 11308 contains some required legacy classes .
and another legacy class in 11309 (... Constantin Asofiei

12:44 PM Database Feature #3809: ProDataSet support

3809a 11308 contains some required legacy classes . Constantin Asofiei

12:16 PM Database Feature #3809: ProDataSet support

Constantin Asofiei wrote:
> Something else - wasn't at some point the idea to avoid the generic get/set method name ... Ovidiu Maxiniuc

12:12 PM Database Feature #3809: ProDataSet support

Constantin Asofiei wrote:
> Ovidiu Maxiniuc wrote:
> > Constantin Asofiei wrote:
> > > I have some untracked chang... Constantin Asofiei

12:09 PM Database Feature #3809: ProDataSet support

Ovidiu Maxiniuc wrote:
> Constantin Asofiei wrote:
> > I have some untracked changes, some related to dataset conve... Constantin Asofiei

12:07 PM Database Feature #3809: ProDataSet support

Constantin Asofiei wrote:
> I have some untracked changes, some related to dataset conversion, some to other, but sa... Ovidiu Maxiniuc

11:40 AM Database Feature #3809: ProDataSet support

I have some untracked changes, some related to dataset conversion, some to other, but safe enough to commit here - pl... Constantin Asofiei

10:59 AM Database Feature #3809: ProDataSet support

Code Review Task Branch 3809b Revision 11327
It was easier to review the old branch than the new one since my last... Greg Shah

07:19 AM Database Feature #3809: ProDataSet support

Greg Shah wrote:
> Ovidiu: Do you think it is stable/safe enough to merge to trunk or does it need additional work?
... Ovidiu Maxiniuc

07:00 AM Database Feature #3809: ProDataSet support

Ovidiu: Do you think it is stable/safe enough to merge to trunk or does it need additional work?
If this has no re... Greg Shah

05:40 AM Database Feature #3809: ProDataSet support

Branch 3750b was relased and merged into 3750a, then archived as 'dead'.
Branch 3750a was updated to r11304. DataSet... Ovidiu Maxiniuc

11:03 AM Base Language Feature #3178: implement STREAM-HANDLE support

The original problem report is expected behavior because FWD does not yet have @STREAM-HANDLE@ support. This task is... Greg Shah

09:08 AM User Interface Feature #3811 (Pending): more misc UI features

The rest of the implementation work is deferred until the @MANUAL-HIGHLIGHT@ 4GL testcases are ready. Greg Shah

09:07 AM User Interface Feature #3811: more misc UI features

Greg Shah wrote:
> Please confirm that everything is complete except for @MANUAL-HIGHLIGHT@, for which we need 4GL t... Eugenie Lyzenko

08:44 AM User Interface Feature #3811: more misc UI features

For the @MANUAL-HIGHLIGHT@ 4GL testcases:
* We understand that some widgets do not honor @MANUAL-HIGHLIGHT@. The ... Greg Shah

08:38 AM User Interface Feature #3811: more misc UI features

Please confirm that everything is complete except for @MANUAL-HIGHLIGHT@, for which we need 4GL testcases. Greg Shah

07:31 AM User Interface Feature #3811: more misc UI features

Branch @3811a@ was merged to trunk as revno @11303@ then it was archived. Eugenie Lyzenko

07:14 AM User Interface Feature #3811: more misc UI features

Greg Shah wrote:
> Yes, go ahead.
Testing completed. The results: @3811a_11326_32748a0_20190416_evl.zip@.
No r... Eugenie Lyzenko

06:49 AM User Interface Feature #3811: more misc UI features

Yes, go ahead. Greg Shah

03:38 AM User Interface Feature #3811: more misc UI features

The main regression part completed without regressions. Waiting for @CTRL-C@ to be done.
Can I merge @3811a@ into ... Eugenie Lyzenko

08:46 AM User Interface Feature #3762 (Closed): misc UI features

Branch 3811a was merged to trunk as revision 11303. This finishes the work in this task. Greg Shah

04/15/2019

06:30 PM Base Language Feature #3753: I18N additions

> The result - we already have full conversion and runtime support for this based on current directory configuration.... Greg Shah

01:21 PM Base Language Feature #3753: I18N additions

The testcases bzr repo updated to rev @1834@ with simple test for @CURRENT-LANGUAGE@ statement/function to verify the... Eugenie Lyzenko

03:02 PM Base Language Feature #3751: implement support for OO 4GL and structured error handling

There is another flaw related to tempidx: we compute this during pre-scan and the normal parsing use it at the refere... Constantin Asofiei

12:11 PM User Interface Feature #3811: more misc UI features

Conversion testing completed. The generated sources are identical.
Starting the runtime tests for @3811a@. Eugenie Lyzenko

08:14 AM User Interface Feature #3811: more misc UI features

Greg Shah wrote:
> Yes, go ahead.
OK. The conversion test has been started. Then runtime. Eugenie Lyzenko

07:56 AM User Interface Feature #3811: more misc UI features

Yes, go ahead. Greg Shah

08:08 AM Base Language Feature #3310: add support for the equivalent of the OpenEdge Web Services Adapter (and ProxyGen)...

> I guess we will have to test all possible cases as usual :)
Yes, please. :) Greg Shah

07:48 AM Base Language Feature #3310: add support for the equivalent of the OpenEdge Web Services Adapter (and ProxyGen)...

There are the @SESSION:CURRENT-REQUEST-INFO@ and @SESSION:CURRENT-RESPONSE-INFO@, which return a @Progress.Lang.OEReq... Constantin Asofiei

07:40 AM Base Language Feature #3310: add support for the equivalent of the OpenEdge Web Services Adapter (and ProxyGen)...

Greg Shah wrote:
> FWD has its own built-in application server as well as an embedded J2EE container (Jetty) that su... Marian Edu

07:36 AM Base Language Feature #3310: add support for the equivalent of the OpenEdge Web Services Adapter (and ProxyGen)...

From Marian:
> I don't know much about your FWD server side (assumed it's some Java but looks like Tomcat is ruled... Greg Shah

07:59 AM User Interface Feature #3908: implement browse column VIEW-AS COMBO-BOX

Rebased task branch 3908a from P2J trunk revision 11302. Stanislav Lomany

07:37 AM Base Language Feature #3855: implement equivalent support for REST (classic appserver, PASOE REST and WEB trans...

See #3310-9 for details on some expectations for the test suite. Greg Shah

03:23 AM Database Feature #3809: ProDataSet support

Ovidiu, once you have the dataset conversion/parsing changes in 3809a stable enough, I think we need to merge this to... Constantin Asofiei

04/14/2019

04:09 PM Base Language Feature #3753: I18N additions

Task branch @3753a@ has been rebased with trunk @11302@, new revision is @11304@. Eugenie Lyzenko

03:52 PM User Interface Feature #3811: more misc UI features

Task branch @3811a@ has been rebased with trunk @11302@, new revision is @11326@.
Can I retest and if no regressio... Eugenie Lyzenko

04/13/2019

06:11 PM Database Feature #3809: ProDataSet support

Ovidiu, now that branch 3750b has been merged to trunk 11302, I have rebased branch 3809a (currently at revision 1130... Eric Faulhaber

08:27 PM Base Language Feature #3753: I18N additions

Task branch @3753a@ has been updated for review to revision @11303@.
This is the support for @FIX-CODEPAGE@ statem... Eugenie Lyzenko

04/12/2019

06:15 PM Database Feature #1587: implement full support for word indexes

It should be noted that error handling for the UDF version of CONTAINS support is not quite right. Any error in the s... Eric Faulhaber

06:07 PM Database Feature #3809: ProDataSet support

Greg Shah wrote:
> I'm not suggesting to use variable types. The idea is to use the @tempIdx@ value in @SymbolResol... Ovidiu Maxiniuc

01:29 PM Database Feature #3809: ProDataSet support

Constantin Asofiei wrote:
> Ovidiu Maxiniuc wrote:
> > > Also, do you have tests for shared datasets? I see no cha... Ovidiu Maxiniuc

01:25 PM Database Feature #3809: ProDataSet support

Ovidiu, please add conversion and stub support for BUFFER:DATA-SOURCE attribute. Constantin Asofiei

01:22 PM Database Feature #3809: ProDataSet support

Ovidiu Maxiniuc wrote:
> > Also, do you have tests for shared datasets? I see no changes in SharedVariableManager r... Constantin Asofiei

01:20 PM Database Feature #3809: ProDataSet support

Constantin Asofiei wrote:
> Hmm... related to OO, we need tests at least for:
> * DATASET and DATASET-HANDLE as met... Ovidiu Maxiniuc

01:15 PM Database Feature #3809: ProDataSet support

Ovidiu Maxiniuc wrote:
> Constantin Asofiei wrote:
> > Ovidiu, do your testcases cover DATASET and DATASET-HANDLE a... Constantin Asofiei

01:03 PM Database Feature #3809: ProDataSet support

Constantin Asofiei wrote:
> Ovidiu, do your testcases cover DATASET and DATASET-HANDLE as OO method arguments?
I ... Ovidiu Maxiniuc

12:59 PM Database Feature #3809: ProDataSet support

Ovidiu, do your testcases cover DATASET and DATASET-HANDLE as OO method arguments? Constantin Asofiei

12:31 PM Database Feature #3809: ProDataSet support

I'm not suggesting to use variable types. The idea is to use the @tempIdx@ value in @SymbolResolver@ (see @addWrappe... Greg Shah

12:17 PM Database Feature #3809: ProDataSet support

Greg Shah wrote:
> Code Review Task Branch 3809b Revision 11605
>
> 1. @annotations/datasets.rules@ implements li... Ovidiu Maxiniuc

05:21 PM Base Language Feature #3855: implement equivalent support for REST (classic appserver, PASOE REST and WEB trans...

In regard to the "clean" DIY (do it yourself) REST approach listed in #3855-1, this is implemented using the web hand... Greg Shah

01:30 PM Conversion Tools Feature #3927 (Closed): conversion mode that takes a file spec and a file blacklist

Branch 3898a was merged to trunk revision 11301. Eric Faulhaber

01:02 PM Base Language Feature #3753: I18N additions

Greg Shah wrote:
> ...
> Better to create a new helper class. But the functions/statements that operate only on @l... Eugenie Lyzenko

11:21 AM Base Language Feature #3753: I18N additions

Greg Shah wrote:
> I don't understand. The following code works:
>
> [...]
>
> Using a string literal or char... Eugenie Lyzenko

04/11/2019

03:00 PM Database Feature #3809: ProDataSet support

> Is it OK to add move within RESERVED boundaries?
That is still for keywords. Instead, please put them inside th... Greg Shah

02:34 PM Database Feature #3809: ProDataSet support

Greg Shah wrote:
> Code Review Task Branch 3809b Revision 11605
Thank you for the review. It helps me fix some issu... Ovidiu Maxiniuc

11:26 AM Database Feature #3809: ProDataSet support

Code Review Task Branch 3809b Revision 11605
1. @annotations/datasets.rules@ implements linking of dataset/datasou... Greg Shah

10:31 AM Database Feature #3809: ProDataSet support

Branch 3809b was updated. Current revision is (LE) 11605 . It contains fixes for regression introduces the last two d... Ovidiu Maxiniuc

10:18 PM Base Language Feature #3753: I18N additions

> Currently runtime is based on Java internal variables, no convmap.cp feature yet.
We should start with a standar... Greg Shah

10:04 PM Base Language Feature #3753: I18N additions

I don't understand. The following code works:... Greg Shah

04/10/2019

07:28 PM Base Language Feature #3753: I18N additions

Task branch @3753a@ has been updated for review to revision @11302@.
The first steps in @I18N@ implementation. Add... Eugenie Lyzenko

06:57 AM Base Language Feature #3753: I18N additions

Greg Shah wrote:
> > Let me know if this plan needs corrections according to current projects requirements.
>
> I... Eugenie Lyzenko

06:28 AM Base Language Feature #3753: I18N additions

> Let me know if this plan needs corrections according to current projects requirements.
I think the plan is OK. ... Greg Shah

03:11 PM User Interface Feature #3811: more misc UI features

Hynek Cihlar wrote:
> Code review @MIN-HEIGHT-CHARS@ and @MAX-HEIGHT-CHARS@ changes in 3811a.
>
> * Reference to ... Eugenie Lyzenko

02:20 PM User Interface Feature #3811: more misc UI features

Code review @MIN-HEIGHT-CHARS@ and @MAX-HEIGHT-CHARS@ changes in 3811a.
* Reference to @MAX-WIDTH-CHARS@ in the ja... Hynek Cihlar

12:39 PM User Interface Feature #3811: more misc UI features

Code Review Task Branch 3811a Revision 11324
I'm good with the changes.
Constantin: Are you OK with the vertica... Greg Shah

05:04 AM Runtime Infrastructure Feature #4041: [Performance] Defer widget server-client state synchronization

Currently widget state is pushed to the client eagerly, with every widget attribute assignment or method call changin... Hynek Cihlar

04:39 AM Runtime Infrastructure Feature #4041 (New): [Performance] Defer widget server-client state synchronization

Hynek Cihlar

02:43 AM Database Feature #3809: ProDataSet support

Yes, there are two ambiguity issues.
I haven't added @options { generateAmbigWarnings = false; }@ to hide them yet... Ovidiu Maxiniuc