FWD

12/08/2022

09:04 PM Base Language Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection

I've been working on a different approach to this problem. The original problem noted above is that ReflectASM and J... Greg Shah

12/07/2022

04:42 PM Database Feature #6444: dataset improvements

Igor Skornyakov wrote:
> It appears that DATASET:FILL() is not working at all for RECURSIVE DATA-RELATION (the @Data... Ovidiu Maxiniuc

11:56 AM Database Feature #6444: dataset improvements

Igor Skornyakov wrote:
> I'm thinking about adding support for a RECURSIVE DATA-RELATION by re-writing the DATA-SOUR... Igor Skornyakov

10:45 AM Database Feature #6444: dataset improvements

The @BufferImpl.fill()@ method is pretty long (400 lines of code) and complicated.
I'm thinking about adding support... Igor Skornyakov

12:25 PM User Interface Feature #3931: single sign-on for virtual desktop mode

Support for @<customers_large_gui_application>@ user name replacing OS account name in log files (as requested in #43... Galya B

07:07 AM Runtime Infrastructure Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...

From Galya, via email:
> I haven't looked at the Java classes instantiated by the spawner, so let me ask if there ... Greg Shah

03:33 AM User Interface Feature #6764: Improve trigger selection for keyboard events.

Hynek Cihlar wrote:
> 6764.07.patch checked in to 3821c revision 14417.
I reverted the patch in 3821c revision 14... Hynek Cihlar

12/06/2022

07:21 AM User Interface Feature #6764: Improve trigger selection for keyboard events.

6764.07.patch checked in to 3821c revision 14417. Hynek Cihlar

07:00 AM User Interface Feature #6764: Improve trigger selection for keyboard events.

Hynek Cihlar wrote:
>
> Marian, please add a file history entry to @ThinClient.java@ and also fix the one in @Even... Marian Edu

03:48 AM User Interface Feature #6764: Improve trigger selection for keyboard events.

Marian Edu wrote:
> Greg Shah wrote:
> > > I'd like to get 6764.06.patch in 3821c. Any objection?
> >
> > No ob... Hynek Cihlar

12/05/2022

03:01 PM Database Feature #6444: dataset improvements

It appears that DATASET:FILL() is not working at all for RECURSIVE DATA-RELATION (the @DataSet.getTopBufferList()@ re... Igor Skornyakov

02:47 PM User Interface Feature #6764: Improve trigger selection for keyboard events.

Greg Shah wrote:
> > I'd like to get 6764.06.patch in 3821c. Any objection?
>
> No objection from me.
None fr... Marian Edu

02:34 PM User Interface Feature #6764: Improve trigger selection for keyboard events.

> I'd like to get 6764.06.patch in 3821c. Any objection?
No objection from me. Greg Shah

02:33 PM User Interface Feature #6764: Improve trigger selection for keyboard events.

Hi
What is the status of this issue ?
I'd like to move on with Regression Tests fix and events/triggers are next bi... Tomasz Domin

02:16 PM User Interface Feature #6764: Improve trigger selection for keyboard events.

Marian, Greg, I'd like to get @6764.06.patch@ in 3821c. Any objection? Hynek Cihlar

01:54 PM User Interface Feature #6978 (WIP): Editor widget performance optimization

Eugenie Lyzenko

09:42 AM User Interface Feature #6978: Editor widget performance optimization

From #6899-95:
Greg Shah wrote:
> Perhaps we can simplify things a bit. We store an array of lines. When we mak... Hynek Cihlar

09:12 AM User Interface Feature #6978: Editor widget performance optimization

The remaining work discussion can be found in #6899.
In short when the editor content become big enough sending fu... Eugenie Lyzenko

09:09 AM User Interface Feature #6978 (WIP): Editor widget performance optimization

Eugenie Lyzenko

09:29 AM Runtime Infrastructure Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...

Greg Shah wrote:
> The approach seems reasonable.
>
> Eugenie: Do you have any thoughts, questions or concerns?
... Eugenie Lyzenko

09:11 AM Runtime Infrastructure Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...

The approach seems reasonable.
Eugenie: Do you have any thoughts, questions or concerns? Greg Shah

06:18 AM Runtime Infrastructure Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...

The Windows spawner is a lot more simple than the UNIX one in the process creation part (more complicated in the secu... Galya B

04:41 AM Runtime Infrastructure Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...

Greg Shah wrote:
> The test code doesn't help me understand the process tree/pid list/redirected output log name for... Galya B

07:34 AM Database Support #6709: track nested FIND inside a related FOR loop

Code Review 6709-rpt-20221205.diff
Good, it is getting closer.
1. I don't think we should limit the for each pr... Greg Shah

03:51 AM Database Support #6709: track nested FIND inside a related FOR loop

Greg Shah wrote:
> 1. Please switch out the use of a @Stack@ for the @ScopedSymbolDictionary@.
I made the @FOR EACH... Dănuț Filimon

06:07 AM Database Feature #6371: implement SAVE CACHE statement

My suspicion is the logical change in @XmlHelper.setAttribute()@ - I added a check for @value.isEmpty()@ and it proba... Boris Schegolev

12:51 AM Database Feature #6371: implement SAVE CACHE statement

Eric Faulhaber wrote:
> I found that I was unable to convert test cases using 6371a/14119, with an error during anno... Eric Faulhaber

02:50 AM Database Feature #6816: improve PreselectQuery.assembleHQL

After I did some investigation upon the @PreselectQuery.assembleHQL@ function, two types of optimization occurred to ... Radu Apetrii

02:13 AM Database Feature #6928: H2 UPDATE performance improvement

|_. version |_. server run |_. client run |_. indexed (ms) |_. unindexed(ms) |
|h2-1.4.200.jar | 1... Alexandru Lungu

12/02/2022

04:52 PM Database Feature #6928: H2 UPDATE performance improvement

Here are the results for two server runs, each with 5 client connection:
|\3=. First Run |/9. |\3=. Second Run |
|_... Ovidiu Maxiniuc

02:32 PM Database Feature #6928: H2 UPDATE performance improvement

Alexandru/Ovidiu: previously I uploaded the wrong jar (it was the rev 7 one, not the patched one). Please try with t... Constantin Asofiei

11:17 AM Runtime Infrastructure Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...

The test code doesn't help me understand the process tree/pid list/redirected output log name for the FWD client. Ca... Greg Shah

09:09 AM Database Support #6708: track/report at runtime when AdaptiveQuery shifts into dynamic mode

Committed 3821c/rev.14409. Made a change in order to display the parent methods in the 4GL code by the number of call... Dănuț Filimon

08:44 AM Database Feature #6444: dataset improvements

Igor Skornyakov wrote:
> However, FWD in this case generates no row data at all.
It appears that this is the prob... Igor Skornyakov

12/01/2022

10:49 AM Runtime Infrastructure Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...

I created a simple test to verify @execvp@ behaviour and uploaded it as zip. The test function in @C@ prints the pid ... Galya B

09:12 AM Runtime Infrastructure Bug #5701 (WIP): logfile names for -O outputToFile use the spawner pid instead of the Java (FWD c...

Constantin Asofiei wrote:
> The spawner will use @NativeSecureConnection.command@ to determine the launch command fo... Galya B

07:08 AM Runtime Infrastructure Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...

Galya Bogdanova wrote:
> ... running in background where no client driver seems to be instantiated in the Java code,... Constantin Asofiei

06:51 AM Runtime Infrastructure Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...

This is how I read the logic for the spawner (I'll be going with the Unix example):
@ClientBuilder#localStart()@ b... Galya B

10:46 AM Database Feature #6444: dataset improvements

When PK and a FK are specified in an incorrect order in the @relation-fields@ clause (see #6444-23), 4GL does not com... Igor Skornyakov

10:30 AM Database Feature #6444: dataset improvements

Igor Skornyakov wrote:
> I've noticed an intersting thing. In the absense of the @nsPrefix@ 4GL @WRITE-XML@ creates ... Igor Skornyakov

05:29 AM Database Feature #6444: dataset improvements

I've noticed an intersting thing. In the absense of the @nsPrefix@ 4GL @WRITE-XML@ creates "html-style" output. See a... Igor Skornyakov

04:46 AM Database Feature #6444: dataset improvements

Marian Edu wrote:
> Igor Skornyakov wrote:
> > What about navigation& I mean the following statement:
> > [...]
>... Igor Skornyakov

04:44 AM Database Feature #6444: dataset improvements

Igor Skornyakov wrote:
> What about navigation& I mean the following statement:
> [...]
> How @a recursive ABL pro... Marian Edu

04:35 AM Database Feature #6444: dataset improvements

Marian Edu wrote:
> Igor Skornyakov wrote:
> > What I'm doing wrong?
> By looking at the records created the 'cE' ... Igor Skornyakov

04:34 AM Database Feature #6444: dataset improvements

Igor Skornyakov wrote:
> What I'm doing wrong?
By looking at the records created the 'cE' is the PK and 'cM' is the... Marian Edu

04:27 AM Database Feature #6444: dataset improvements

Marian Edu wrote:
> This is mostly used by the 'tree-like' .NET UI components, as far as 4GL is concerned the effec... Igor Skornyakov

04:09 AM Database Feature #6444: dataset improvements

Marian Edu wrote:
> Eric Faulhaber wrote:
> > Marian, can you shed any light on the RECURSIVE feature?
>
> This ... Igor Skornyakov

03:34 AM Database Feature #6444: dataset improvements

Eric Faulhaber wrote:
> Marian, can you shed any light on the RECURSIVE feature?
This is mostly used by the 'tree... Marian Edu

02:54 AM Database Feature #6444: dataset improvements

Found a number of incompatibilities in @(READ|WRITE)-XML(SCHEMA)?@ support for RECURSIVE DATASET.
Fixing them in 6129b. Igor Skornyakov

01:00 AM Database Feature #6444: dataset improvements

Ovidiu Maxiniuc wrote:
> Igor,
>
> You cannot have the same table to be both the source and destination for a @fi... Igor Skornyakov

07:52 AM Base Language Bug #6974: NPE at OpenEdge.Core.Class.IsInterface

The test code (@isinterface.p@):... Vladimir Tsichevski

07:46 AM Base Language Bug #6974 (New): NPE at OpenEdge.Core.Class.IsInterface

Vladimir Tsichevski

01:10 AM Database Feature #6371 (WIP): implement SAVE CACHE statement

I found that I was unable to convert test cases using 6371a/14119, with an error during annotations:... Eric Faulhaber

11/30/2022

06:31 PM Database Feature #6444: dataset improvements

Igor,
You cannot have the same table to be both the source and destination for a @fill@ operation (we do not suppo... Ovidiu Maxiniuc

12:28 PM Database Feature #6444: dataset improvements

Another problem with @RECURSIVE@.
I'm trying to write a test for @FILL@ (see the attachment).
When I run it I get... Igor Skornyakov

12:23 PM Database Feature #6444: dataset improvements

Marian, can you shed any light on the RECURSIVE feature? Eric Faulhaber

11:20 AM Database Feature #6444: dataset improvements

The OE documentation about @RECURSIVE@ Data-Relation object I see the following statement about such realtions:
<pre... Igor Skornyakov

04:07 PM Database Feature #6371 (Review): implement SAVE CACHE statement

Boris Schegolev

02:18 AM Database Feature #6454 (Review): database informational features

Eric Faulhaber wrote:
> Igor, other than requiring review for the patch in #6454-11 and for 6129b/14335, is this tas... Igor Skornyakov

02:04 AM Database Feature #6454: database informational features

Igor, other than requiring review for the patch in #6454-11 and for 6129b/14335, is this task finished from your poin... Eric Faulhaber

11/29/2022

01:06 PM Database Feature #6444: dataset improvements

Ovidiu Maxiniuc wrote:
> I assume you talk about the recent serialization updates for temp-tables and FOREIGN-KEY-HI... Igor Skornyakov

12:37 PM Database Feature #6444: dataset improvements

I assume you talk about the recent serialization updates for temp-tables and FOREIGN-KEY-HIDDEN attribute. I do not t... Ovidiu Maxiniuc

10:16 AM Database Feature #6444: dataset improvements

Ovidiu Maxiniuc wrote:
> Eric Faulhaber wrote:
> > Ovidiu, thank you for the summary of status. I am reassigning to... Igor Skornyakov

07:50 AM Database Feature #6454: database informational features

Greg Shah wrote:
> > I understand that this is because we do not have even stubs for RCODE-INFO:CRC-VALUE and RCODE-... Igor Skornyakov

04:24 AM Database Feature #6454: database informational features

Constantin Asofiei wrote:
> Igor Skornyakov wrote:
> > Strangely enough I have found no @@DatabaseReferences@ annot... Igor Skornyakov

03:09 AM Database Feature #6454: database informational features

Igor Skornyakov wrote:
> Strangely enough I have found no @@DatabaseReferences@ annotation in a converted large cust... Constantin Asofiei

05:59 AM Database Feature #6928: H2 UPDATE performance improvement

|_. version |_. server run |_. client run |_. indexed (ms) |_. unindexed(ms) |
|fwd-h2-1.4.200-6.jar| 1... Alexandru Lungu

05:34 AM Database Feature #6928: H2 UPDATE performance improvement

I am doing the stress tests right now.
> I've been running the H2 unit tests, too, and this showed some problems w... Alexandru Lungu

04:16 AM Database Feature #6928: H2 UPDATE performance improvement

Thanks, Ovidiu, I'll profile some more and see what happens. Constantin Asofiei

11/28/2022

06:42 PM Database Bug #6919 (Review): fix ErrorManager.displayError in TempTableBuilder

Ovidiu Maxiniuc wrote:
> I see you added static import for @ErrorManager@. There are very few places where this is d... Boris Schegolev

04:57 PM Base Language Bug #6963: Incorrect conversion of legacy class constructors with an unknown argument of object type

If an unknown value is passed an an argument to a class constructor, the conversion produces an correct call.
The ... Vladimir Tsichevski

04:44 PM Base Language Bug #6963 (New): Incorrect conversion of legacy class constructors with an unknown argument of ob...

Vladimir Tsichevski

04:15 PM Database Feature #6444: dataset improvements

Eric Faulhaber wrote:
> Ovidiu, thank you for the summary of status. I am reassigning to Igor for implementation. Pl... Ovidiu Maxiniuc

04:01 PM Database Feature #6444: dataset improvements

Greg Shah wrote:
> > Greg, Constantin, 3821c or 6129b for these changes? They most likely will be needed in 6129b fi... Igor Skornyakov

03:52 PM Database Feature #6444: dataset improvements

> Greg, Constantin, 3821c or 6129b for these changes? They most likely will be needed in 6129b first, but we should d... Greg Shah

01:29 PM Database Feature #6444 (WIP): dataset improvements

Igor Skornyakov

01:25 PM Database Feature #6444: dataset improvements

Ovidiu, thank you for the summary of status. I am reassigning to Igor for implementation. Please assist him if he has... Eric Faulhaber

03:15 PM Database Feature #6928: H2 UPDATE performance improvement

With attached @h2-1.4.200.jar@, 1st run:
|_. n |_. indexed |_. non-indexed |
| 1 | 799 ms | 453 ms |
| 2 | 302 ms ... Ovidiu Maxiniuc

10:18 AM Database Feature #6928: H2 UPDATE performance improvement

Attached is the second version of the patch and a stress-test for the UPDATE statement (10k field setters). The 'in-... Constantin Asofiei

09:51 AM Database Feature #6928 (WIP): H2 UPDATE performance improvement

Constantin Asofiei

02:52 PM Database Feature #6454: database informational features

Greg Shah wrote:
> > I understand that this is because we do not have even stubs for RCODE-INFO:CRC-VALUE and RCODE-... Igor Skornyakov

02:50 PM Database Feature #6454: database informational features

> I understand that this is because we do not have even stubs for RCODE-INFO:CRC-VALUE and RCODE-INFO:LANGUAGES.
> D... Greg Shah

02:30 PM Database Feature #6454: database informational features

As far as I can see, @RCODE-INFO:TABLE-LIST@ inplementation in FWD uses the value of the @tables@ attribute of the @@... Igor Skornyakov

12:23 PM Database Feature #6454: database informational features

I've noticed the following problem.
The statement... Igor Skornyakov

11:37 AM Database Feature #6454: database informational features

Igor Skornyakov wrote:
> * It looks that the only database restriction we have to support is @READ-ONLY@. Should be ... Igor Skornyakov

10:04 AM Database Feature #6454: database informational features

Constantin Asofiei wrote:
> Igor Skornyakov wrote:
> > Constantin Asofiei wrote:
> > > Igor, RCODE-INFO:TABLE-LIST... Igor Skornyakov

09:59 AM Database Feature #6454: database informational features

Igor Skornyakov wrote:
> Constantin Asofiei wrote:
> > Igor, RCODE-INFO:TABLE-LIST is already added in 6129b.
>
... Constantin Asofiei

09:18 AM Database Feature #6454: database informational features

Constantin Asofiei wrote:
> Igor, RCODE-INFO:TABLE-LIST is already added in 6129b.
Constantin,
I see only @Rcode... Igor Skornyakov

02:49 AM Database Feature #6454: database informational features

Igor, RCODE-INFO:TABLE-LIST is already added in 6129b. Constantin Asofiei

08:59 AM Conversion Tools Feature #6237: OEUnit support

Marian Edu wrote:
> Vladimir Tsichevski wrote:
> > This does not compile for me, or at least displays warning messa... Vladimir Tsichevski

08:48 AM Conversion Tools Feature #6237: OEUnit support

Vladimir Tsichevski wrote:
> This does not compile for me, or at least displays warning messages. Which OE version d... Marian Edu

04:47 AM Database Support #6708: track/report at runtime when AdaptiveQuery shifts into dynamic mode

Committed 3821c/rev.14395. Made the changes mentioned in #6708-12 and fixed a problem where preselect and dynamic cal... Dănuț Filimon

11/27/2022

01:06 PM Database Feature #6454: database informational features

* As I can see from the code @DBPARAM@ reports *all* parameters supported by FWD for @CONNECT@
* It looks that the o... Igor Skornyakov

11/26/2022

02:09 AM Database Feature #6448: make location of LOB files configurable for import

Ovidiu Maxiniuc wrote:
> Review of @lobs.diff@:
>
> Good job! Implemented as requested in #6448-2.
> Please do t... Igor Skornyakov

10:21 PM Database Feature #6448: make location of LOB files configurable for import

Review of @lobs.diff@:
Good job! Implemented as requested in #6448-2.
Please do the cleanup (fix indentation of l... Ovidiu Maxiniuc

11/25/2022

05:40 PM Database Feature #6459: query features

Eric Faulhaber wrote:
> Igor, I'm looking into the history of this part of the code. I don't think it's as simple as... Greg Shah

01:35 PM Database Feature #6459: query features

Eric Faulhaber wrote:
> Igor, I'm looking into the history of this part of the code. I don't think it's as simple as... Igor Skornyakov

11:08 AM Database Feature #6459: query features

Igor, I'm looking into the history of this part of the code. I don't think it's as simple as releasing the record unc... Eric Faulhaber

05:59 AM Database Feature #6459: query features

Constantin Asofiei wrote:
> What's the stacktrace where #6459-5 calls @throwOffend()@?
Here it is:... Igor Skornyakov

05:24 AM Database Feature #6459: query features

Igor Skornyakov wrote:
> According to my tests, both forms of @FIRST-OF@/@LAST-OF@ are fully supported.
>
> I've... Constantin Asofiei

05:31 PM Database Support #6709: track nested FIND inside a related FOR loop

OK, this is close to correct.
1. Please switch out the use of a @Stack@ for the @ScopedSymbolDictionary@. The i... Greg Shah

07:11 AM Database Support #6709: track nested FIND inside a related FOR loop

I made the changes for the report. Now, it can track FIND statements that reference the same buffer as the FOR EACH i... Dănuț Filimon

05:30 PM Database Bug #6919: fix ErrorManager.displayError in TempTableBuilder

Review of @6919.diff@.
Good job! There were a lot of methods to check.
Interesting findings. I was not expectin... Ovidiu Maxiniuc

05:12 PM Conversion Tools Feature #6237: OEUnit support

Marian Edu wrote:
> Vladimir Tsichevski wrote:
> > Seems, OE does not support multiple @ABLUnit@ life cycle unit te... Vladimir Tsichevski

09:15 AM Conversion Tools Feature #6237: OEUnit support

Vladimir Tsichevski wrote:
> Seems, OE does not support multiple @ABLUnit@ life cycle unit test procedures, like @JU... Marian Edu

08:55 AM Conversion Tools Feature #6237: OEUnit support

Or perhaps it makes more sense to implement the 4GL-compatible versions as annotation names which more clearly mappin... Greg Shah

08:52 AM Conversion Tools Feature #6237: OEUnit support

> Currently FWD supports this, and I wonder whether we should do unsupport :-)
We definitely need to implement in ... Greg Shah

06:41 AM Conversion Tools Feature #6237: OEUnit support

Vladimir Tsichevski wrote:
> Seems, OE does not support multiple @ABLUnit@ life cycle unit test procedures.
This ho... Vladimir Tsichevski

12:51 PM Database Feature #6454 (WIP): database informational features

Igor Skornyakov

12:50 PM Database Feature #6448: make location of LOB files configurable for import

Implemented as described in #6448-2.
The attached .diff file is for 6129b/14333.
Please review.
Thank you.
Igor Skornyakov

10:19 AM Database Feature #6448: make location of LOB files configurable for import

Igor Skornyakov wrote:
> I've got the following exception on the database import with 6129b/14333.
> [...]
> Is it... Igor Skornyakov

10:01 AM Database Feature #6448: make location of LOB files configurable for import

I've got the following exception on the database import with 6129b/14333.... Igor Skornyakov

08:04 AM Database Support #6708: track/report at runtime when AdaptiveQuery shifts into dynamic mode

Nice work! I could generate insightful reports using customer applications. I will suggest only some fine tuning here... Alexandru Lungu

11/24/2022

11:56 AM Conversion Tools Feature #6237: OEUnit support

Seems, OE does not support multiple @ABLUnit@ life cycle unit test procedures, like @JUnit5@ supports. That means we ... Vladimir Tsichevski

10:57 AM Database Feature #6582: implement multi-table AdaptiveQuery

> consider way stronger optimizations directly in the H2 engine: this involves some extended work into the H2 optimiz... Greg Shah

10:56 AM Database Feature #6582: implement multi-table AdaptiveQuery

*CHECKPOINT*
I am pending the work here as I can't find any more consistent optimizations to motivate that multi-t... Alexandru Lungu

10:24 AM Database Support #6709: track nested FIND inside a related FOR loop

> This is my intent, but I wanted to share my work until now.
Understood. No worries.
> Also, I guess you mean... Greg Shah

05:00 AM Database Support #6709: track nested FIND inside a related FOR loop

Greg Shah wrote:
> Neither annotations/annotations.xml and annotations/annotations_prep.xml can't be used for the ne... Dănuț Filimon

10:05 AM Database Feature #6453: temp-table features

> Eric, what should we do: remove this list or expose this as a enhanced feature with a method in SESSION handle?
... Greg Shah

01:15 AM Database Feature #6453: temp-table features

Ovidiu Maxiniuc wrote:
> > Actually, if we replace throwing @XmlStreamException@ with @return false@ this will resul... Igor Skornyakov

08:13 PM Database Feature #6453: temp-table features

Igor Skornyakov wrote:
> In fact, I do not understand why we add @TempTableBuilder@ to the @HandleChain@. I have not... Ovidiu Maxiniuc

09:43 AM Database Feature #6448 (WIP): make location of LOB files configurable for import

Igor Skornyakov

09:42 AM Database Feature #6459: query features

I do not see how we can reliably figure out how the @CACHE@ attribute value affects the performance. Such things usua... Igor Skornyakov

09:39 AM Database Support #6708: track/report at runtime when AdaptiveQuery shifts into dynamic mode

Committed 3821c/rev.14384. I applied all the suggestions mentioned by Alexandru in #6708-7 and moved all the changes ... Dănuț Filimon

09:06 AM Database Support #6708: track/report at runtime when AdaptiveQuery shifts into dynamic mode

I rebased 6708a with 3821c. Danut, you can now move the changes from 6708a to 3821c. Alexandru Lungu

11/23/2022

01:39 PM Database Feature #6453: temp-table features

Igor Skornyakov wrote:
> In fact, the caller of this method just returns @false@ on @XmlStreamException@. Since this... Igor Skornyakov

06:52 AM Database Feature #6453: temp-table features

Ovidiu Maxiniuc wrote:
> This class is unique in the fact that we have control of the short lifetime of the @TempTab... Igor Skornyakov

11:16 AM Database Support #6709: track nested FIND inside a related FOR loop

Code Review 6709-rpt.diff
Neither @annotations/annotations.xml@ and @annotations/annotations_prep.xml@ can't be us... Greg Shah

07:40 AM Database Support #6709: track nested FIND inside a related FOR loop

I took a different approach after taking a look at #3194 and modified how the report is made. I created a new rule se... Dănuț Filimon

06:20 AM Database Bug #6923: inner transaction block reverts too much

I attached a patch with some changes that, in my opinion, make more sense than the current implementation. Mainly, th... Radu Apetrii

11/22/2022

01:52 PM Database Feature #6453: temp-table features

Igor Skornyakov wrote:
> Sorry, but I'm confused. We create a new @TempTableBuilder@ instance e.g. in the @readTable... Ovidiu Maxiniuc

12:41 PM Database Feature #6453: temp-table features

Ovidiu Maxiniuc wrote:
> The problem is that @TempTableBuilder@ -s are @HandleChain@ objects which are kept in a lin... Igor Skornyakov

08:41 AM Database Feature #6459: query features

According to my tests, both forms of @FIRST-OF@/@LAST-OF@ are fully supported.
I've also fixed the problem with @... Igor Skornyakov

11/21/2022

05:58 PM Database Bug #6919 (WIP): fix ErrorManager.displayError in TempTableBuilder

I am attaching my changes for review. This should be the complete implementation, I will do more testing tomorrow. Boris Schegolev

02:57 PM Database Feature #6453: temp-table features

Ovidiu Maxiniuc wrote:
> Related to 6129b/14329: after @ErrorManager.recordOrShowError@ do not @throw@ a new excepti... Igor Skornyakov

02:21 PM Database Feature #6453: temp-table features

Igor,
Related to 6129b/14329: after @ErrorManager.recordOrShowError@ do not @throw@ a new exception. After the 4GL... Ovidiu Maxiniuc

09:52 AM Database Feature #6453: temp-table features

Greg Shah wrote:
> >> how safe is to abend here?
> > I think that it is safe because actually, it should never happ... Igor Skornyakov

07:30 AM Database Feature #6453: temp-table features

>> how safe is to abend here?
> I think that it is safe because actually, it should never happen if the schema is co... Greg Shah

02:21 PM Testing Support #6858: rework existing testcases to use ABLUnit

Vladimir Tsichevski wrote:
> # Bugs: the @abl_unit/procedure_annotations/test_suite_no_explicit_errors.p@ refers t... Marian Edu

02:09 PM Testing Support #6858: rework existing testcases to use ABLUnit

Greg Shah wrote:
> Vladimir is only working on the ablunit parts. He is adding some tests at a minimum. One can th... Vladimir Tsichevski

02:04 PM Testing Support #6858: rework existing testcases to use ABLUnit

Marian Edu wrote:
> Vladimir Tsichevski wrote:
> > I've started reworking the sources @abl_unit/@ subdirectory into... Vladimir Tsichevski

01:40 PM Testing Support #6858: rework existing testcases to use ABLUnit

Vladimir is only working on the ablunit parts. He is adding some tests at a minimum. One can think of that work as ... Greg Shah

01:37 PM Testing Support #6858: rework existing testcases to use ABLUnit

Vladimir Tsichevski wrote:
> I've started reworking the sources @abl_unit/@ subdirectory into a "pure ABLUnit". Also... Marian Edu

01:25 PM Testing Support #6858: rework existing testcases to use ABLUnit

I've started reworking the sources @abl_unit/@ subdirectory into a "pure ABLUnit". Also I found some obvious bugs in ... Vladimir Tsichevski

09:30 AM Testing Support #6858: rework existing testcases to use ABLUnit

Just to remind everyone: the "master plan" for testing can be found in [[p2j:Testing Process]] and those pages/tasks ... Greg Shah

09:13 AM Testing Support #6858: rework existing testcases to use ABLUnit

Greg Shah wrote:
> I prefer to migrate these "in place". It is already confusing to have multiple testcase projects... Marian Edu

08:40 AM Testing Support #6858: rework existing testcases to use ABLUnit

I prefer to migrate these "in place". It is already confusing to have multiple testcase projects (old and busted vs ... Greg Shah

06:22 AM Testing Support #6858 (WIP): rework existing testcases to use ABLUnit

We're working on this one and migrate existing unit tests (no user interaction) to new ones using ABLUnit, is there a... Marian Edu

01:06 PM Conversion Tools Bug #6901 (Test): Event handling - ON ANYWHERE

Greg Shah

10:48 AM Conversion Tools Bug #6901: Event handling - ON ANYWHERE

Greg Shah wrote:
> Hynek: Please commit the patch to 3821c.
Patch 6901.patch checked in 3821c revision 14378. Hynek Cihlar

08:24 AM Conversion Tools Bug #6901: Event handling - ON ANYWHERE

Hynek: Please commit the patch to 3821c. Greg Shah

06:42 AM Conversion Tools Bug #6901: Event handling - ON ANYWHERE

Marian Edu wrote:
> Hynek Cihlar wrote:
>
> > I find helpful to turn on rules tracing, this helps to pinpoint the... Marian Edu

06:36 AM Conversion Tools Bug #6901: Event handling - ON ANYWHERE

Hynek Cihlar wrote:
> I find helpful to turn on rules tracing, this helps to pinpoint the exact place where a part... Marian Edu

06:32 AM Conversion Tools Bug #6901: Event handling - ON ANYWHERE

Marian Edu wrote:
> It took me a while to get along understanding xml code in those rules and where/what exactly nee... Hynek Cihlar

06:17 AM Conversion Tools Bug #6901 (Review): Event handling - ON ANYWHERE

It took me a while to get along understanding xml code in those rules and where/what exactly needs to change... this ... Marian Edu

06:15 AM Conversion Tools Bug #6901 (WIP): Event handling - ON ANYWHERE

Marian Edu

07:40 AM Database Bug #6940 (Test): unqualified field name resolution when there is an explicit buffer defined in a...

Code Review Task Branch 6129b Revision 14327
The concept of the change is sound. Combined with the fact that it d... Greg Shah

07:38 AM Database Bug #6940: unqualified field name resolution when there is an explicit buffer defined in an inter...

In the end there was no information in email, @testcases/uast/@, Redmine or @bzr@ that could lead be back to the orig... Greg Shah

11/19/2022

08:16 AM Database Bug #6940: unqualified field name resolution when there is an explicit buffer defined in an inter...

There is no change in the application used for task #346. In the customer's app, all changes look 'expected', the pa... Constantin Asofiei

08:00 AM Database Feature #6453: temp-table features

Constantin Asofiei wrote:
> Review for 6129b/14326:
> * how safe is to abend here?
> [...]
I think that it is saf... Igor Skornyakov

07:41 AM Database Feature #6453: temp-table features

Review for 6129b/14326:
* how safe is to abend here?... Constantin Asofiei

11/18/2022

05:51 PM Database Feature #6450 (Closed): buffer/buffer-field features

Eric Faulhaber

01:59 PM Database Feature #6450: buffer/buffer-field features

Yes, I think so.
Note that, unlike #6444 (where the changes were committed to 3821c), this task uses 6129a/b. Ovidiu Maxiniuc

10:50 AM Database Feature #6450: buffer/buffer-field features

Can this be closed? Eric Faulhaber

02:44 PM Testing Feature #6183: design and implement (as needed) the approach for writing automated 4GL compatibil...

A problem with @skeleton/oo4gl/OpenEdge/DataAdmin/Internal/Util/CdcTablePolicyInstanceEnum.cls@:... Vladimir Tsichevski

01:57 PM Testing Bug #6920: Ins and outs of Sikuli for GUI testing

This chunk of code will show monitor information:... Roger Borrello

01:50 PM Database Feature #6444: dataset improvements

Eric Faulhaber wrote:
> Ovidiu, could you please review the list above and indicate what the actual support is curre... Ovidiu Maxiniuc

01:14 PM Database Bug #6940: unqualified field name resolution when there is an explicit buffer defined in an inter...

The change was introduced in trunk revision 4785:... Greg Shah

12:56 PM Database Bug #6940: unqualified field name resolution when there is an explicit buffer defined in an inter...

I think the intent was to promote the parameter buffer, and not the 'source' for the parameter buffer. For example, ... Constantin Asofiei

12:22 PM Conversion Tools Feature #6237: OEUnit support

Vladimir Tsichevski wrote:
> Just found, that @@TestSuite@ annotation is not recognized and converted in procedures.... Vladimir Tsichevski

12:13 PM Database Feature #6459: query features

Greg Shah wrote:
> There are 2 forms of these: built-in function and handle-based method.
>
> Built-In Function f... Igor Skornyakov

11:42 AM Database Feature #6459: query features

There are 2 forms of these: built-in function and handle-based method.
Built-In Function form:... Greg Shah

10:21 AM Database Feature #6459: query features

Eric Faulhaber wrote:
> Igor Skornyakov wrote:
>
> > In 6129b both @FIRST-OF@ and @LAST-OF@ are set to @rw.cvt_l... Igor Skornyakov

10:20 AM Database Feature #6459: query features

The @convert/methods_attributes.rules@ has support for both methods. Subclasses of @P2JQuery@ like @Persorter@ have ... Greg Shah

10:05 AM Database Feature #6459: query features

Igor Skornyakov wrote:
> In 6129b both @FIRST-OF@ and @LAST-OF@ are set to @rw.cvt_lvl_full | rw.rt_lvl_full@
... Eric Faulhaber

09:42 AM Database Feature #6459: query features

Greg Shah wrote:
> > As far as I can see from my test, @FIRST-OF@, @LAST-OF@ methods are fully supported.
>
> At ... Igor Skornyakov

09:17 AM Database Feature #6459: query features

> As far as I can see from my test, @FIRST-OF@, @LAST-OF@ methods are fully supported.
At a minimum, the gap marki... Greg Shah

08:37 AM Database Feature #6459: query features

As far as I can see from my test, @FIRST-OF@, @LAST-OF@ methods are fully supported.
However, I see the following is... Igor Skornyakov

09:56 AM Database Feature #6453 (Closed): temp-table features

Eric Faulhaber

01:36 AM Database Feature #6453: temp-table features

Ovidiu Maxiniuc wrote:
> Only one change before the commit, please: in @XmlImport.java@, instead of [...]use[...]
>... Igor Skornyakov

08:24 AM Database Bug #6923: inner transaction block reverts too much

Thank you for the explanations!
I've taken them on board and I have seen that the bug is in fact about the restorati... Radu Apetrii

08:01 AM Database Support #6709: track nested FIND inside a related FOR loop

Nice! Please post the diff so I can review the approach. It can be tricky to do this kind of static analysis becaus... Greg Shah

05:51 AM Database Support #6709: track nested FIND inside a related FOR loop

Greg Shah wrote:
> We are trying to evaluate how often in real 4GL code does this condition occur? Getting a measure... Dănuț Filimon

11/17/2022

06:39 PM Database Bug #6940: unqualified field name resolution when there is an explicit buffer defined in an inter...

FYI, I'm digging back through the history on this one. I'll pick it back up in the morning. Greg Shah

08:02 AM Database Bug #6940: unqualified field name resolution when there is an explicit buffer defined in an inter...

The patch is built on top of 6129b/14324. Constantin Asofiei

08:01 AM Database Bug #6940: unqualified field name resolution when there is an explicit buffer defined in an inter...

Greg, the problem is that for a @DEF PARAM BUFFER ... FOR some-buf@ statement, @some-buf@ gets promoted because @def_... Constantin Asofiei

02:52 AM Database Bug #6940: unqualified field name resolution when there is an explicit buffer defined in an inter...

The problem is when a buffer is defined explicitly as a parameter - FWD doesn't resolve the unqualified field properl... Constantin Asofiei

02:46 AM Database Bug #6940 (Test): unqualified field name resolution when there is an explicit buffer defined in a...

Constantin Asofiei

03:18 PM Database Feature #6453: temp-table features

Only one change before the commit, please: in @XmlImport.java@, instead of ... Ovidiu Maxiniuc

02:20 PM Database Feature #6453 (Review): temp-table features

Igor Skornyakov wrote:
> Ovidiu Maxiniuc wrote:
> > Review of @read-xmlschema.diff@:
> [...]
> Can I commit the c... Eric Faulhaber

05:03 AM Database Feature #6453: temp-table features

Tests used for this task committed to @xfer.goldencode.com/opt/testcases/temp-table-marshal@. rev. 1300.
Igor Skornyakov

01:58 AM Database Feature #6453: temp-table features

Ovidiu Maxiniuc wrote:
> Review of @read-xmlschema.diff@:
> * @AbstractTempTable@: the new method lacks the javadoc... Igor Skornyakov

02:32 PM Database Feature #6371: implement SAVE CACHE statement

FYI, I am re-working the class unloading, which will not work currently in "real" use scenarios. When we create a DMO... Eric Faulhaber

02:21 PM Conversion Tools Feature #6237: OEUnit support

Just found, that @@TestSuite@ annotation is not recognized and converted in procedures. Will fix this... Vladimir Tsichevski

02:19 PM Base Language Feature #4658: OO serialization support

Greg Shah wrote:
> If a repo exists on both @devsrv01@ and on @xfer@, then the @devsrv01@ version is authoritative a... Vladimir Tsichevski

11:29 AM Base Language Feature #4658: OO serialization support

If a repo exists on both @devsrv01@ and on @xfer@, then the @devsrv01@ version is authoritative and the @xfer@ versio... Greg Shah

11:27 AM Base Language Feature #4658: OO serialization support

Greg Shah wrote:
> Are you using @~/secure/code/p2j_repo/skeleton@? You should have full commit access to that repo... Vladimir Tsichevski

09:03 AM Base Language Feature #4658: OO serialization support

Are you using @~/secure/code/p2j_repo/skeleton@? You should have full commit access to that repo. It is OK to commi... Greg Shah

07:21 AM Base Language Feature #4658: OO serialization support

Vladimir Tsichevski wrote:
> I think, I found an error in skeleton: class @DataAdminError@ has wrong class names in ... Vladimir Tsichevski

02:02 PM Database Bug #6923: inner transaction block reverts too much

Eric Faulhaber wrote:
> ...the fact that the results are different in your first test case between temp-table and pe... Eric Faulhaber

01:52 PM Database Bug #6923: inner transaction block reverts too much

When you nest transactions like:... Eric Faulhaber

06:50 AM Database Bug #6923 (WIP): inner transaction block reverts too much

An update to this issue:
I narrowed down the code, in order to describe what I have found until this moment. This is... Radu Apetrii

12:02 PM Database Feature #6418: represent extent fields as arrays

Alexandru Lungu wrote:
> Eric, is there any prior partial implementation/discussion into the array fields?
There ... Eric Faulhaber

03:29 AM Database Feature #6418: represent extent fields as arrays

Eric, is there any prior partial implementation/discussion into the array fields? If no, this task can be the lead ef... Alexandru Lungu

09:26 AM Testing Bug #6920: Ins and outs of Sikuli for GUI testing

After working for a few days on the customer testcases, and making sure I was able to get the @Region(x,y,w,h)@ value... Roger Borrello

09:07 AM Testing Feature #6183: design and implement (as needed) the approach for writing automated 4GL compatibil...

In the "new" [[p2j:Testcases]] project, there is the @abl_unit/@ directory with the existing testcases. I think you'... Greg Shah

07:27 AM Testing Feature #6183 (WIP): design and implement (as needed) the approach for writing automated 4GL comp...

I've created an @ABLUnit@ test for creating and sending all built-in errors implemented in FWD, which can be created ... Vladimir Tsichevski

07:41 AM Runtime Infrastructure Feature #6939: improve proxy performance by hard-coding method invocation

Eric Faulhaber wrote:
> But, recently we discovered that @ReflectASM@ actually can perform worse than reflection on ... Constantin Asofiei

07:35 AM Database Feature #2137: runtime support for FIELDS/EXCEPT record phrase options

The @2137_20221114a.patch@ patch was committed to 3821c/14369, with these notes:
* only NO-LOCK records are loaded a... Constantin Asofiei

07:34 AM Database Bug #6941: conversion issue when using undo in do transaction

There is a problem when converting examples that contain an @undo@ statement inside a @do transaction@.
For example,... Radu Apetrii

07:20 AM Database Bug #6941 (Rejected): conversion issue when using undo in do transaction

Radu Apetrii

05:40 AM Database Feature #6816: improve PreselectQuery.assembleHQL

For an initial check, I recommend implementing a very small suite of performance tests (~6) for @PreselectQuery@ to t... Alexandru Lungu

03:33 AM Database Feature #6816 (WIP): improve PreselectQuery.assembleHQL

Alexandru Lungu

11/16/2022

03:54 PM Database Feature #6453: temp-table features

Review of @read-xmlschema.diff@:
* @AbstractTempTable@: the new method lacks the javadoc;
* @XmlImport@:
** method... Ovidiu Maxiniuc

11:59 AM Database Feature #6453: temp-table features

Finished with fixing @READ-XMLSCHEMA@ support for DATASET.
Please review.
Thank you.
I understand that the tas... Igor Skornyakov

03:30 PM Base Language Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection

I'm working on some sample code to show a better approach. Greg Shah

03:28 PM Runtime Infrastructure Feature #6939: improve proxy performance by hard-coding method invocation

When I originally implemented the @com.goldencode.proxy@ package, the pressing goal at the time was to improve memory... Eric Faulhaber

02:48 PM Runtime Infrastructure Feature #6939 (New): improve proxy performance by hard-coding method invocation

Eric Faulhaber

01:40 PM Base Language Feature #6936 (WIP): OpenClient with null values at the DataObject (table) fields for native types

denormalized extent support is not done at this time. Constantin Asofiei

01:34 PM Base Language Feature #6936 (Review): OpenClient with null values at the DataObject (table) fields for native t...

Added in 6129b/14324. Constantin Asofiei

11:17 AM Base Language Feature #6936: OpenClient with null values at the DataObject (table) fields for native types

The issue in the end is described by https://community.progress.com/s/article/P133384 , calling @RunTimeProperties.se... Constantin Asofiei

06:33 AM Base Language Feature #6936: OpenClient with null values at the DataObject (table) fields for native types

Marian Edu wrote:
> Constantin, you might want to check for any typos there... if the field exists (check metadata) ... Constantin Asofiei

06:22 AM Base Language Feature #6936: OpenClient with null values at the DataObject (table) fields for native types

Constantin Asofiei wrote:
> Marian, do you know in what conditions OE's JavaOpenClient would return null instead of ... Marian Edu

05:38 AM Base Language Feature #6936 (WIP): OpenClient with null values at the DataObject (table) fields for native types

Marian, do you know in what conditions OE's JavaOpenClient would return null instead of a default value for integer,i... Constantin Asofiei

05:01 AM Base Language Feature #6936: OpenClient with null values at the DataObject (table) fields for native types

In OE, there seems to be a difference how null values are reported in a ProDataObject.
For example, doing somethin... Constantin Asofiei

04:59 AM Base Language Feature #6936 (WIP): OpenClient with null values at the DataObject (table) fields for native types

Constantin Asofiei

01:30 PM Base Language Feature #4658: OO serialization support

Vladimir Tsichevski wrote:
> I think, I found an error in skeleton: class @DataAdminError@ has wrong class names in ... Vladimir Tsichevski

01:27 PM Base Language Feature #4658: OO serialization support

I think, I found an error in skeleton: class @DataAdminError@ has wrong class names in constructors: @OperationError@... Vladimir Tsichevski

01:01 PM Database Feature #6459: query features

Igor, please focus only on the first bullet point (i.e., @QUERY@ handle) items. Eric Faulhaber

12:28 PM Database Feature #6448: make location of LOB files configurable for import

Eric Faulhaber wrote:
> Currently, the location is hard-coded to a @lobs@ sub-directory of the directory containing ... Eric Faulhaber

10:16 AM Database Feature #6938: XML seriliazation improvement

At this moment the @XMLExport@ class uses manual formatting of the document based on @indent()@/@leneBreak()@ calls (... Igor Skornyakov

10:08 AM Database Feature #6938 (New): XML seriliazation improvement

Igor Skornyakov

10:14 AM Database Support #6708: track/report at runtime when AdaptiveQuery shifts into dynamic mode

3821c is fine. Thanks. Eric Faulhaber

09:04 AM Database Support #6708: track/report at runtime when AdaptiveQuery shifts into dynamic mode

I have no objection.
Eric: Where should the changes go? I'd prefer 3821c. Greg Shah

06:27 AM Database Support #6708 (WIP): track/report at runtime when AdaptiveQuery shifts into dynamic mode

Greg, can we consider moving this change to 3821c or 6129b? It does not change the FWD core behavior; it only augment... Alexandru Lungu

07:14 AM User Interface Feature #6764: Improve trigger selection for keyboard events.

Marian Edu wrote:
> Hynek Cihlar wrote:
> > When does the client send event code of -1 to @LT.apply@? Should this b... Hynek Cihlar

07:12 AM User Interface Feature #6764: Improve trigger selection for keyboard events.

Hynek Cihlar wrote:
> When does the client send event code of -1 to @LT.apply@? Should this be prevented on the clie... Marian Edu

07:10 AM User Interface Feature #6764: Improve trigger selection for keyboard events.

Marian Edu wrote:
> An updated patch to solve some NPE issues (thanks Tomasz for reporting it), it's made against re... Hynek Cihlar

04:41 AM User Interface Feature #6764: Improve trigger selection for keyboard events.

Hynek: Please review the latest patch.
Marian: I'd like to get these changes and the fix for #6901 / #6930 into 38... Greg Shah

06:34 AM Database Support #6709: track nested FIND inside a related FOR loop

This is a good analysis. It certainly highlights the differences in control flow and danger of refactoring such code... Greg Shah

05:57 AM Database Support #6709 (WIP): track nested FIND inside a related FOR loop

Dănuț Filimon

05:36 AM Database Support #6709: track nested FIND inside a related FOR loop

From what I understood, we want to test if either nested find or joined approach is better. After a few tests using t... Dănuț Filimon

05:56 AM Database Feature #5355 (WIP): _Usertablestat metadata improvements

Alexandru Lungu

05:47 AM Database Support #6714: check if there is an optimization opportunity when copying temp-tables based on mu...

Any news about the review? Dănuț Filimon

11/15/2022

02:53 PM Base Language Feature #4658: OO serialization support

I've added Java serialization to the following classes (see @4658.diff@):... Vladimir Tsichevski

01:20 PM Base Language Feature #4658: OO serialization support

Vladimir, I'll try to bring the changes from 6129b to 3821c tomorrow. The files in question are, but some of them co... Constantin Asofiei

11:33 AM Base Language Feature #4658: OO serialization support

Vladimir Tsichevski wrote:
> Greg Shah wrote:
>
> > ** enums are implicitly serializable (no syntax, it just is i... Greg Shah

11:24 AM Base Language Feature #4658: OO serialization support

Greg Shah wrote:
> ** enums are implicitly serializable (no syntax, it just is implemented)
The @LegacyEnum@ Java... Vladimir Tsichevski

11:21 AM Base Language Feature #4658: OO serialization support

I wonder if there is a way to test OO serialization from 4gl, so I could write unit test? Vladimir Tsichevski

11:11 AM Base Language Feature #4658 (WIP): OO serialization support

Vladimir Tsichevski

11:11 AM Base Language Feature #4658: OO serialization support

I am working on serialization of OO error classes. One of them is @SoapFaultError@, which has a field of the @handle@... Vladimir Tsichevski

09:01 AM Base Language Feature #4658: OO serialization support

Constantin Asofiei wrote:
> Vladimir, what branch are you working on? There is some early support for OO serializati... Vladimir Tsichevski

08:27 AM Base Language Feature #4658: OO serialization support

Constantin Asofiei wrote:
> Vladimir, what branch are you working on? There is some early support for OO serializati... Vladimir Tsichevski

07:59 AM Base Language Feature #4658: OO serialization support

Vladimir, what branch are you working on? There is some early support for OO serialization in 6129b, we need to work ... Constantin Asofiei

07:57 AM Base Language Feature #4658: OO serialization support

Greg Shah wrote:
> Marian's team is (or will be) working on testcases.
>
> However, I think you need the support ... Vladimir Tsichevski

07:55 AM Base Language Feature #4658: OO serialization support

Greg Shah wrote:
> Marian's team is (or will be) working on testcases.
>
> However, I think you need the support ... Marian Edu

07:32 AM Base Language Feature #4658: OO serialization support

Marian's team is (or will be) working on testcases.
However, I think you need the support now so you should look t... Greg Shah

06:45 AM Base Language Feature #4658: OO serialization support

We also need to provide Java serialization support for OO exceptions in order to implement unit-testing engine. See d... Vladimir Tsichevski

09:33 AM Database Feature #2137: runtime support for FIELDS/EXCEPT record phrase options

Right. I failed to notice the @field@ is updated in inner loop. Ovidiu Maxiniuc

08:07 AM Database Feature #2137: runtime support for FIELDS/EXCEPT record phrase options

Ovidiu Maxiniuc wrote:
> Review of @2137_20221114a.patch@:
> I have a single issue in the new patch, in @AbstractQu... Constantin Asofiei

06:45 AM Database Feature #6928: H2 UPDATE performance improvement

In H2, when doing an UPDATE statement,the approach is to:
* create a new row
* assign all columns not part of the U... Constantin Asofiei

03:49 AM Database Feature #6928 (Closed): H2 UPDATE performance improvement

Constantin Asofiei

05:41 AM User Interface Feature #6764: Improve trigger selection for keyboard events.

An updated patch to solve some NPE issues (thanks Tomasz for reporting it), it's made against rev #14360. Marian Edu

11/14/2022

06:37 PM Database Feature #6371: implement SAVE CACHE statement

Pushed revision 6371a/14121. Based on testing, added more mappings for column types and moved mapping to @Dialect@ pl... Boris Schegolev

03:05 PM Conversion Tools Feature #6237: OEUnit support

Greg Shah wrote:
> We need to be able to specify the bootstrap configuration path/filename for a given test run.
... Vladimir Tsichevski

01:07 PM Conversion Tools Feature #6237: OEUnit support

The latest diff @6237-215-14360.diff@. Vladimir Tsichevski

12:56 PM Conversion Tools Feature #6237: OEUnit support

Vladimir Tsichevski wrote:
> We should add support for the classroot selector in the engine. This selector is not us... Vladimir Tsichevski

11:39 AM Conversion Tools Feature #6237: OEUnit support

We should add support for the classroot selector in the engine. This selector is not used by Eclipse test launcher (E... Vladimir Tsichevski

02:03 PM Database Feature #2137: runtime support for FIELDS/EXCEPT record phrase options

Constantin Asofiei wrote:
> Ovidiu, please review attached. This adds denormalized extent for FIELDS/EXCEPT. norma... Ovidiu Maxiniuc

10:31 AM Database Feature #2137: runtime support for FIELDS/EXCEPT record phrase options

Ovidiu, please review attached. This adds denormalized extent for FIELDS/EXCEPT. normalized extent is still not sup... Constantin Asofiei

01:24 PM Database Feature #6453: temp-table features

It appears that @READ-XMLSCHEMA@ for the @DATASET@ is broken even in the situation of a single namespace (w/o externa... Igor Skornyakov

11:01 AM Database Feature #6453: temp-table features

Ovidiu Maxiniuc wrote:
> Certainly, the patch is clearly an improvement over the current revision on bzr. Please c... Igor Skornyakov

10:44 AM Database Feature #6453: temp-table features

Igor Skornyakov wrote:
> > What I meant was that a @ClassCastException@ could be thrown if code inside FWD will ca... Ovidiu Maxiniuc

10:42 AM Database Feature #6453: temp-table features

Ovidiu Maxiniuc wrote:
> Igor Skornyakov wrote:
> > Why not extend @XMLStreamWriter@ so that it will care about ind... Igor Skornyakov

10:37 AM Database Feature #6453: temp-table features

Igor Skornyakov wrote:
> Why not extend @XMLStreamWriter@ so that it will care about indentation itself? [...] What ... Ovidiu Maxiniuc

12:28 PM Database Bug #6887: improve performance of dataset/table[-handle] parameters

I've edited previous note to add @delete object hds1.@ to @dstest.p@ - with this, OE is in the 200ms range, while FWD... Constantin Asofiei

12:04 PM Database Bug #6887: improve performance of dataset/table[-handle] parameters

A starting point for a test to check the performance is this, made of two programs:
# @dstest.p@ which defines inter... Constantin Asofiei

11:14 PM Database Bug #6887: improve performance of dataset/table[-handle] parameters

Constantin, is this something you think can reasonably be reproduced with some simplified test cases, which would ill... Eric Faulhaber

11:09 AM Testing Feature #6183: design and implement (as needed) the approach for writing automated 4GL compatibil...

Marian Edu wrote:
> Vladimir Tsichevski wrote:
> > This will not work if the *conversion* of the test code is curre... Vladimir Tsichevski

10:42 AM Testing Feature #6183: design and implement (as needed) the approach for writing automated 4GL compatibil...

Vladimir Tsichevski wrote:
> This will not work if the *conversion* of the test code is currently unsupported.
You ... Marian Edu

09:59 AM Testing Feature #6183: design and implement (as needed) the approach for writing automated 4GL compatibil...

Marian Edu wrote:
> Vladimir Tsichevski wrote:
> > # #6183-5.
> > @Both have support for @Ignore.@
> > IMO ... Vladimir Tsichevski

09:54 AM Testing Feature #6183: design and implement (as needed) the approach for writing automated 4GL compatibil...

Vladimir Tsichevski wrote:
> # #6183-5.
> @Both have support for @Ignore.@
> IMO @@Ignore@ is not what we ne... Marian Edu

08:14 AM Testing Feature #6183: design and implement (as needed) the approach for writing automated 4GL compatibil...

# #6183-4.
@One thing to consider: we will need a mechanism to disable tests at runtime (e.g. those tests which w... Vladimir Tsichevski

09:07 AM Database Bug #6829: H2 forces re-parse of all prepared statements when metadata is changed

Alexandru, I have in a heap dump @UnclosablePreparedStatement@ instances with ~90KB retained heap. But in at least a... Constantin Asofiei

06:23 AM Database Bug #6829: H2 forces re-parse of all prepared statements when metadata is changed

I've done some simple debugging in Hotel GUI with @UnclosablePreparedStatement@. The @psCache@ structure is an @Expir... Alexandru Lungu

07:46 AM Database Support #6708: track/report at runtime when AdaptiveQuery shifts into dynamic mode

Committed 6708a/rev.14328. Made improvements to AdaptiveQuery method tracing.
I made changes and now it is possibl... Dănuț Filimon

11/12/2022

04:54 AM Database Feature #6453: temp-table features

In addition to the previous note. I
Why not extend @XMLStreamWriter@ so that it will care about indentation itself? ... Igor Skornyakov

03:49 AM Database Feature #6453: temp-table features

Ovidiu Maxiniuc wrote:
> > > * @TempTableResultSet@:387: you are creating an intermediary @mprops@ tree for collecti... Igor Skornyakov

11/11/2022

04:53 PM Conversion Tools Feature #6237: OEUnit support

Greg Shah wrote:
> We need to be able to specify the bootstrap configuration path/filename for a given test run. Di... Vladimir Tsichevski

04:40 PM Conversion Tools Feature #6237: OEUnit support

Greg Shah wrote:
> Unpack and rethrow it in the calling code on the client.
It works!
!6237-211.png! Vladimir Tsichevski

03:20 PM Conversion Tools Feature #6237: OEUnit support

Unpack and rethrow it in the calling code on the client. Greg Shah

02:06 PM Conversion Tools Feature #6237: OEUnit support

Vladimir Tsichevski wrote:
> My proposal is to follow the same way, and let the assertions library, implemented in... Vladimir Tsichevski

03:42 PM User Interface Bug #6925: Initially focused widget shouldn't have dotted selection.

When a widget which has dotted selection when focused (like a radio set or a button) has the initial focus in a frame... Stanislav Lomany

03:37 PM User Interface Bug #6925 (New): Initially focused widget shouldn't have dotted selection.

Stanislav Lomany

03:41 PM Database Feature #6453: temp-table features

Ovidiu Maxiniuc wrote:
> Igor Skornyakov wrote:
> > > * @TempTableResultSet@:387: you are creating an intermediary ... Igor Skornyakov

03:34 PM Database Feature #6453: temp-table features

Igor Skornyakov wrote:
> > * @TempTableResultSet@:387: you are creating an intermediary @mprops@ tree for collecting... Ovidiu Maxiniuc

01:37 PM Database Feature #6453: temp-table features

Fixed @WRITE-XML@ support for @DATASET@.
See the attached .diff file for 6129b/14320.
The only remaining thing is... Igor Skornyakov

01:34 PM Database Feature #6453: temp-table features

Fixed @WRITE-XML@ support for @DATASET@ Igor Skornyakov

07:24 AM Database Feature #6453: temp-table features

Ovidiu Maxiniuc wrote:
> Review of @marshal4.diff@
> Overall: a big update, handling multiple issues. Nice work. He... Igor Skornyakov

02:34 AM Database Feature #6453: temp-table features

Ovidiu Maxiniuc wrote:
> Igor Skornyakov wrote:
> > I work with branch 6129b. Please find the .diff for rev.14320 a... Igor Skornyakov

09:20 PM Database Feature #6453: temp-table features

Igor Skornyakov wrote:
> I work with branch 6129b. Please find the .diff for rev.14320 attached.
Review of @marsh... Ovidiu Maxiniuc

05:45 AM Testing Bug #6920: Ins and outs of Sikuli for GUI testing

> Where does the @ExclusionRegion[] excludes@ come from that gets passed to the workers?
If you need one (because ... Greg Shah

10:39 PM Testing Bug #6920: Ins and outs of Sikuli for GUI testing

I have this update. The script updates don't seem to be as easy as I thought. According to https://stackoverflow.com/... Roger Borrello

07:31 PM Testing Bug #6920: Ins and outs of Sikuli for GUI testing

Greg Shah wrote:
> Not exactly. It is important that you do not need to instantiate the @BinaryFileCompare@ instanc... Roger Borrello

11/10/2022

06:46 PM Testing Bug #6920: Ins and outs of Sikuli for GUI testing

> If I were to update the harness with interfaces for calling in from Sikuli, where would they go? For example, would... Greg Shah

04:43 PM Testing Bug #6920: Ins and outs of Sikuli for GUI testing

With this update, I was able to build Sikuli that can handle our requirements:... Roger Borrello

02:28 PM Testing Bug #6920: Ins and outs of Sikuli for GUI testing

Roger Borrello wrote:
> I'll try 2.0.5
It took searching through the issues, but I found this: https://github.com... Roger Borrello

02:17 PM Testing Bug #6920: Ins and outs of Sikuli for GUI testing

Greg Shah wrote:
> > so I registered at GitHub and pulled the code
>
> Generally, you should not have to register... Roger Borrello

02:00 PM Testing Bug #6920: Ins and outs of Sikuli for GUI testing

> so I registered at GitHub and pulled the code
Generally, you should not have to register for github to download ... Greg Shah

01:49 PM Testing Bug #6920: Ins and outs of Sikuli for GUI testing

Roger Borrello wrote:
> Yes... I was investigating the source code that was available for download (without the buil... Roger Borrello

11:43 AM Testing Bug #6920: Ins and outs of Sikuli for GUI testing

> I just can't figure out how to get results from the issuance of: @BinaryFileComparison(getLatestFile(xls_files),exp... Greg Shah

11:18 AM Testing Bug #6920: Ins and outs of Sikuli for GUI testing

Greg Shah wrote:
> Sikuli is open source and written in Java, right?
Yes... I was investigating the source code t... Roger Borrello

11:08 AM Testing Bug #6920: Ins and outs of Sikuli for GUI testing

Greg Shah wrote:
> In regard to the NPE, changes can be made to the Harness code to refactor it such that SFTP suppo... Roger Borrello

10:49 AM Testing Bug #6920: Ins and outs of Sikuli for GUI testing

Sikuli is open source and written in Java, right? Greg Shah

10:47 AM Testing Bug #6920: Ins and outs of Sikuli for GUI testing

Greg Shah wrote:
> It is important to move to a relative path for the @harness.jar@. I would copy it into the proje... Roger Borrello

06:45 AM Testing Bug #6920: Ins and outs of Sikuli for GUI testing

It is important to move to a relative path for the @harness.jar@. I would copy it into the project as part of the se... Greg Shah

07:07 PM Testing Bug #6920: Ins and outs of Sikuli for GUI testing

Committed revision 256 for hotel_gui contains a good amount of samples. They include
* Waiting for image to appear f... Roger Borrello

03:51 PM Database Feature #6453: temp-table features

Completely (as far as my tests demonstrate) fixed @WRITE-XMLSCHEMA@ for standalone tables and datasets, including ext... Igor Skornyakov

08:20 AM User Interface Feature #6764: Improve trigger selection for keyboard events.

I'm inclined to resolve #6901 sooner rather than later. Greg Shah

07:55 AM User Interface Feature #6764: Improve trigger selection for keyboard events.

Greg Shah wrote:
> Hynek: Please review.
Greg, this will kinda re-open #6195 - if conversion isn't fixed (#6901) th... Marian Edu

07:16 AM User Interface Feature #6764 (Review): Improve trigger selection for keyboard events.

Greg Shah

07:16 AM User Interface Feature #6764: Improve trigger selection for keyboard events.

Hynek: Please review. Greg Shah

07:05 AM User Interface Feature #6764: Improve trigger selection for keyboard events.

It seems I can't re-open this one but this is a patch that fixes the global anywhere in event definition, universal e... Marian Edu

06:09 AM Database Bug #6923: inner transaction block reverts too much

Update: If you replace the middle transaction block with the code below, the program works fine. It reverts only the ... Radu Apetrii

05:26 AM Database Bug #6923: inner transaction block reverts too much

Here is the code that I've been working with, on 3821c, rev.14354:... Radu Apetrii

05:25 AM Database Bug #6923 (Pending): inner transaction block reverts too much

Radu Apetrii

01:42 AM Database Feature #2137: runtime support for FIELDS/EXCEPT record phrase options

Ovidiu Maxiniuc wrote:
> * @BaseRecord@:
> ** @setDatum()@: the conditional update of @readFields@ should happen at... Constantin Asofiei

09:55 PM Database Feature #2137: runtime support for FIELDS/EXCEPT record phrase options

Constantin Asofiei wrote:
> Eric/Ovidiu, please review the attached patch.
I like the update. The boolean arrays ... Ovidiu Maxiniuc

11/09/2022

04:43 PM Database Feature #2137: runtime support for FIELDS/EXCEPT record phrase options

Constantin Asofiei wrote:
> Tijs Wickardt wrote:
> > # Give each ORM data object a ByteArray, holding the raw (unse... Tijs Wickardt

04:38 PM Database Feature #2137: runtime support for FIELDS/EXCEPT record phrase options

Tijs Wickardt wrote:
> # Give each ORM data object a ByteArray, holding the raw (unserialized) data of the last fetc... Constantin Asofiei

03:43 PM Database Feature #2137: runtime support for FIELDS/EXCEPT record phrase options

Constantin Asofiei wrote:
> Eric/Ovidiu, please review the attached patch. The details are these:
> * I couldn't f... Tijs Wickardt

02:20 PM Database Feature #2137: runtime support for FIELDS/EXCEPT record phrase options

Another note: the @orm.Loader.load@ will retrieve from the database the full records, but they will not be populated ... Constantin Asofiei

02:14 PM Database Feature #2137: runtime support for FIELDS/EXCEPT record phrase options

Eric/Ovidiu, please review the attached patch. The details are these:
* I couldn't find a good way to add support f... Constantin Asofiei

09:35 AM Database Feature #2137: runtime support for FIELDS/EXCEPT record phrase options

There is another finding: for EXCLUSIVE-LOCK, the record is always fully-fetched. In FWD, the partial record is allo... Constantin Asofiei

01:52 AM Database Feature #2137: runtime support for FIELDS/EXCEPT record phrase options

Ovidiu Maxiniuc wrote:
> Constantin Asofiei wrote:
> > I have a (minimal) set of changes to allow EXCEPT/FIELDS at ... Constantin Asofiei

08:18 PM Database Feature #2137: runtime support for FIELDS/EXCEPT record phrase options

> This is odd. I did not try it. The logical implementation is to fully fetch the respective at that moment. Is this ... Greg Shah

02:37 PM Database Feature #6453: temp-table features

It appears that we have more problems with DATASET support than I initially reported in #6453-147. The most important... Igor Skornyakov

12:49 AM Database Feature #6453: temp-table features

Ovidiu Maxiniuc wrote:
> Igor Skornyakov wrote:
> > Fixed DATASET (un)marshaling. See the attached .diff file.
> >... Igor Skornyakov

07:48 PM Database Feature #6453: temp-table features

Igor Skornyakov wrote:
> Fixed DATASET (un)marshaling. See the attached .diff file.
> Please review. There are many... Ovidiu Maxiniuc

01:45 PM Testing Bug #6920: Ins and outs of Sikuli for GUI testing

Roger Borrello wrote:
> The first thing I'll try is the below, and add @getLatestFile@ to return the latest file of ... Roger Borrello

01:11 PM Testing Bug #6920: Ins and outs of Sikuli for GUI testing

Greg Shah wrote:
> You can look at @com.goldencode.harness.TestFactory.processStepDefinition()@ to see how we load e... Roger Borrello

11:32 AM Testing Bug #6920: Ins and outs of Sikuli for GUI testing

One of the main functions in Sikuli I use is the @.targetOffset(x,y)@ modification to a @Pattern@. For example, the @... Roger Borrello

11:19 AM Testing Bug #6920: Ins and outs of Sikuli for GUI testing

I have the testcase to export guests. I am filtering the list by room, comparing the screen, then filtering by guest ... Roger Borrello

09:15 AM Testing Bug #6920: Ins and outs of Sikuli for GUI testing

> Would I just need to add harness.jar to the classpath, or all the jars in the harness's build/lib directory?
Co... Greg Shah

08:40 AM Testing Bug #6920: Ins and outs of Sikuli for GUI testing

There are situations where output from a key business process results in an exported file, mostly loaded into the bro... Roger Borrello

08:13 PM Testing Bug #6920: Ins and outs of Sikuli for GUI testing

Please post the previous discussion about calling Java from the Sikuli python scripts. Greg Shah

08:12 PM Testing Bug #6920: Ins and outs of Sikuli for GUI testing

Yes, that is fine. Greg Shah

12:47 PM Database Feature #6695: Multi-table preselect query may underperform due to repetitive fetching

I have taken into account what you said and I have made some changes that appear in this new patch. They were tested ... Radu Apetrii

07:46 AM Conversion Tools Feature #6237: OEUnit support

We need to be able to specify the bootstrap configuration path/filename for a given test run. Different test runs in... Greg Shah

06:41 AM Conversion Tools Feature #6237: OEUnit support

Greg Shah wrote:
> Some questions:
>
> * How do we register our test engine with these launchers?
> ** Eclipse
... Vladimir Tsichevski

06:12 AM Conversion Tools Feature #6237: OEUnit support

Some questions:
* How do we register our test engine with these launchers?
** Eclipse
** ant
** gradle
** JUni... Greg Shah

07:36 AM Database Bug #5307 (WIP): AdaptiveQuery goes into dynamic mode too aggressively

I've been trying to reproduce the behavior mentioned in #5307-1 using the example provided and failed. When debugging... Dănuț Filimon

06:58 AM Runtime Infrastructure Feature #6692: move FWD to Java 17

I've tried to move a bit and have done initial migration to gradle 7.5.1 and tried to build FWD with Java 17.
Just ... Tomasz Domin

03:13 AM Database Support #6712: check generated dynamic temp-table caching to ensure that all cache keys work when...

IIRC, the problem was that we rely on @P2JField.computeHash@, and the @name@ field can vary, depending on the call pa... Eric Faulhaber

11/08/2022

06:06 PM Conversion Tools Feature #6237: OEUnit support

Greg Shah wrote:
> Are you saying there is absolutely no way to ever pass configuration from some launcher to our ... Vladimir Tsichevski

04:16 PM Conversion Tools Feature #6237: OEUnit support

> There is no such thing as "direct JUnit invocation".
I'm talking about command line launching of JUnit.
> The... Greg Shah

04:07 PM Conversion Tools Feature #6237: OEUnit support

Greg Shah wrote:
> From #6237-61 above:
>
> I want to reuse our existing approaches to configuration (e.g. using ... Vladimir Tsichevski

02:32 PM Conversion Tools Feature #6237: OEUnit support

From #6237-61 above:
> Gather the necessary configuration (a @BootstrapConfig@ instance) to pass to the @ClientCor... Greg Shah

01:13 PM Conversion Tools Feature #6237: OEUnit support

I see some potential problem: the test engine has no access to the command-line parameters, since these parameters ar... Vladimir Tsichevski

12:35 PM Conversion Tools Feature #6237: OEUnit support

The problem with referencing Java class names in test suite Java sources resolved in @6237-200-14353.diff@.
Now th... Vladimir Tsichevski

05:46 PM Testing Bug #6920: Ins and outs of Sikuli for GUI testing

For now:... Roger Borrello

05:12 PM Testing Bug #6920: Ins and outs of Sikuli for GUI testing

I have some Sikuli scripts to check into the hotel_gui project. However, I am unsure of the location in the directory... Roger Borrello

01:02 PM Testing Bug #6920 (New): Ins and outs of Sikuli for GUI testing

Roger Borrello

05:23 PM Database Feature #2137: runtime support for FIELDS/EXCEPT record phrase options

Constantin Asofiei wrote:
> I have a (minimal) set of changes to allow EXCEPT/FIELDS at a query, with these notes:
... Ovidiu Maxiniuc

11:14 AM Database Feature #2137: runtime support for FIELDS/EXCEPT record phrase options

Things get tricky when you have an ignored field and you update that field - this is allowed, and OE will save the re... Constantin Asofiei

09:53 AM Database Feature #2137: runtime support for FIELDS/EXCEPT record phrase options

Another issue is that the records which are partially hydrated can not be cached (@FastFindCache@ or @orm.Session.cac... Constantin Asofiei

08:38 AM Database Feature #2137: runtime support for FIELDS/EXCEPT record phrase options

I have a (minimal) set of changes to allow EXCEPT/FIELDS at a query, with these notes:
* temp-tables do not support ... Constantin Asofiei

02:04 PM Runtime Infrastructure Support #5567: move FWD to Java 11

Roger Borrello wrote:
> Roger Borrello wrote:
> > I checked out @hotel_gui@, ran the prepare for linux (and H2), an... Tomasz Domin

01:02 PM Runtime Infrastructure Support #5567: move FWD to Java 11

Roger Borrello wrote:
> Roger Borrello wrote:
> > I checked out @hotel_gui@, ran the prepare for linux (and H2), an... Tomasz Domin

01:00 PM Runtime Infrastructure Support #5567: move FWD to Java 11

Roger Borrello wrote:
> I checked out @hotel_gui@, ran the prepare for linux (and H2), and I get this when I try to ... Roger Borrello

12:12 PM Runtime Infrastructure Support #5567: move FWD to Java 11

I checked out @hotel_gui@, ran the prepare for linux (and H2), and I get this when I try to import:... Roger Borrello

01:04 PM Testing Feature #3704: enable automated testing for GUI (Swing and web clients)

For ins and outs of Sikuli, please refer to #6920 which will focus purely on Sikuli Roger Borrello

12:46 PM Base Language Bug #5761: replace ErrorManager.displayError with recordOrThrowError and fix recordOrShowError to...

Added #6919 for the TempTableBuilder/AbstractTempTable cases. Constantin Asofiei

12:43 PM Database Bug #6919: fix ErrorManager.displayError in TempTableBuilder

FWD uses @ErrorManager.displayError@ instead of going through @recordOrShowError@, in i.e. @TempTableBuilder.tempTabl... Constantin Asofiei

12:36 PM Database Bug #6919 (Review): fix ErrorManager.displayError in TempTableBuilder

Constantin Asofiei

08:29 AM Runtime Infrastructure Feature #6692: move FWD to Java 17

I would guess the second is preferable, but this is really Eric's call. Greg Shah

06:10 AM Runtime Infrastructure Feature #6692: move FWD to Java 17

Greg, there is a name collision due to Java14+ @java.lang.Record@.
What is preferred way to solve this issue ?
* re... Tomasz Domin

06:28 AM Database Feature #6453: temp-table features

Igor Skornyakov wrote:
> Constantin Asofiei wrote:
> > Igor, you need to use @ErrorManager.recordOrThrow@ most like... Igor Skornyakov

05:10 AM Database Feature #6453: temp-table features

Fixed DATASET (un)marshaling. See the attached .diff file.
Please review. There are many pended changes. I would pre... Igor Skornyakov