Project

General

Profile

Activity

From 11/17/2022 to 12/16/2022

12/16/2022

02:59 PM Database Feature #6444: dataset improvements
Something is wrong in the @BufferImpl.fill()@ logic regarding child relations. In the @data_relation/recursive_relati... Igor Skornyakov
03:48 AM Database Feature #6444: dataset improvements
I need to iterate over a DATA-SOURCE twice - first with the original QUERY and then with the 'relaxed' one. What is t... Igor Skornyakov
10:59 AM Database Support #6709: track nested FIND inside a related FOR loop
I'm OK with the @6709-20221216.patch@.
You've tested conversion for both the large customer application and also H...
Greg Shah
09:53 AM Database Support #6709: track nested FIND inside a related FOR loop
Greg Shah wrote:
> Please post an updated patch for review.
> We emit the getter or the @FieldReference@ in @conv...
Dănuț Filimon
08:30 AM Database Support #6709: track nested FIND inside a related FOR loop
> The bug is fixed and the conversion was successful. Should I commit the changes?
Please post an updated patch fo...
Greg Shah
03:31 AM Database Support #6709: track nested FIND inside a related FOR loop
Greg Shah wrote:
> Danut, please address the bug and make sure to test conversion with that application.
The bug is...
Dănuț Filimon
09:50 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Greg Shah wrote:
> We need both server side and client side logging. I think most of the time the server side appro...
Galya B
09:33 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
> > We are at a point where we are still heavily modifying our implementation and that includes our external API.
> ...
Greg Shah
09:33 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Yes, @LogHelper@ can be changed. Greg Shah
09:32 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Greg Shah wrote:
> We are at a point where we are still heavily modifying our implementation and that includes our e...
Galya B
09:31 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
Greg Shah wrote:
> At this time, I don't see how our 4GL-compatibility needs to change for this task, but I may be m...
Galya B
09:29 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
> If some FWD users want to develop their new Java code extending their app functionality, do they import / integrate... Greg Shah
09:25 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
> * Each system process should have a separate log file.
Yes
> * Screen / client drivers output on the screen e...
Greg Shah
06:49 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
A question: If some FWD users want to develop their new Java code extending their app functionality, do they import /... Galya B
08:50 AM User Interface Feature #6764: Improve trigger selection for keyboard events.
Hynek Cihlar wrote:
> Hynek Cihlar wrote:
> > 6764.07.patch checked in to 3821c revision 14417.
>
> I reverted t...
Marian Edu
08:06 AM Database Support #6714: check if there is an optimization opportunity when copying temp-tables based on mu...
I've made a mistake and used the wrong patch when testing previously. The second @removeRecords@ call didn't execute ... Dănuț Filimon
07:24 AM Runtime Infrastructure Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...
Please focus on #5703 first and pause work on this task. Greg Shah
05:48 AM Runtime Infrastructure Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...
Galya Bogdanova wrote:
> The Windows spawner creates the new process with all the needed attributes as it is now, bu...
Galya B
03:01 AM Runtime Infrastructure Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...
Galya Bogdanova wrote:
> That's where we set a @stdout@ handler to the properly renamed filename and execute the @cm...
Galya B
02:52 AM Runtime Infrastructure Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...
I have another idea of how to solve the pid issue on Windows.
The Windows spawner creates the new process with all...
Galya B
02:30 AM Runtime Infrastructure Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...
Greg Shah wrote:
> I think you can try any 4GL code which uses @DISPLAY@, @PUT@ or similar output statement without ...
Galya B
03:31 AM Base Language Bug #6999: OO methods/properties used in direct Java calls
Consider this type:... Constantin Asofiei
03:27 AM Base Language Bug #6999 (New): OO methods/properties used in direct Java calls
Constantin Asofiei

12/15/2022

02:56 PM Runtime Infrastructure Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...
> I need an ABL procedure that outputs to outputToFile to test it out.
I think you can try any 4GL code which uses...
Greg Shah
01:17 PM Runtime Infrastructure Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...
I'm attaching a diff for a demo implementation of how @%pid%@ replace and @stdout@ redirect can work in Java for back... Galya B
09:00 AM Runtime Infrastructure Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...
> Run the cmd in the spawner process itself. This looks like a more dangerous exercise, since I don't fully understan... Greg Shah
07:26 AM Runtime Infrastructure Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...
My proposal cannot actually work for Windows where @CreateProcess@ creates an independent new process without any ref... Galya B
02:11 PM Database Bug #6997: OUTPUT BY-REFERENCE records are not cleared
I returned to this testcase. I altered the original code a bit and I found more evidences in favour of confirming the... Ovidiu Maxiniuc
11:02 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
I'll use this comment to summarize the types of log files we ultimately need (it'll be updated additionally).
---...
Galya B
09:01 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
A related issue to be addressed by the change, as described in #4331:
> Standalone clients (confirmed for gui_swin...
Galya B
09:49 AM Testing Support #6858: rework existing testcases to use ABLUnit
Greg Shah wrote:
> Yes. At any given point in our development, new testcases are written for features we have no im...
Vladimir Tsichevski
08:23 AM Testing Support #6858: rework existing testcases to use ABLUnit
Yes. At any given point in our development, new testcases are written for features we have no implemented yet. It i... Greg Shah
08:21 AM Testing Support #6858: rework existing testcases to use ABLUnit
Multiple files in the @testcases@ project do not convert with FWD. Is this expected? Vladimir Tsichevski
09:28 AM Base Language Feature #6827 (WIP): reduce the memory footprint of WrappedResource implementations: replace BDTs...
Sorry, guys, I think I've reviewed all FWD classes implemening @WrappedResource@ but there're no usages of BDT. I've ... Stanislav Lomany
08:36 AM Database Feature #6816: improve PreselectQuery.assembleHQL
Another update: after the last post I started working on a Factory design pattern for @SortCriterion@. This patch inc... Radu Apetrii

12/14/2022

02:07 PM Database Feature #6444: dataset improvements
I've realized that we do not really need an auxiliary temporary table to use recursive CTE instead of iteration (see ... Igor Skornyakov
02:31 AM Database Feature #6444: dataset improvements
Ovidiu Maxiniuc wrote:
> The FILL operation is QUERY driven. And that happens for each buffer affected (that is, aft...
Igor Skornyakov
01:26 PM Base Language Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection
The lambdas will created like this:... Constantin Asofiei
11:46 AM Database Bug #6997: OUTPUT BY-REFERENCE records are not cleared
It does not make full sense. The BY-REFERENCE should be bound to the target table temporarily, hiding that table. As ... Ovidiu Maxiniuc
05:46 AM Database Bug #6997: OUTPUT BY-REFERENCE records are not cleared
In start.p, a temporary table @main@ is created which is assigned 1 element, then that table is used as an output par... Dănuț Filimon
05:44 AM Database Bug #6997 (New): OUTPUT BY-REFERENCE records are not cleared
Dănuț Filimon
10:01 AM Database Support #6709: track nested FIND inside a related FOR loop
Looks like the problem was caused by a @FOR FIRST table@ statement. Fixed by checking if the previous sibling of the ... Dănuț Filimon
09:23 AM Database Feature #6995: possibly support NO-UNDO temporary tables directly in H2
I am aware of the @force-no-undo@ setting which forces all tables into @no-undo@. If this flag is set, no @SavepointM... Alexandru Lungu
09:15 AM Base Language Feature #6410: implement additional built-in OO classes/interfaces
Yes, please use @PROVERSION@ and preprocessing to conditionally implement logic by OE version. Greg Shah
09:09 AM Base Language Feature #6410: implement additional built-in OO classes/interfaces
Greg Shah wrote:
> OE 11.7.x is in use right now. They can't move to OE 12 without facing serious issues which have...
Marian Edu
07:42 AM Base Language Bug #6993: OO: incorrect field names in DataTypeEnum.java
Greg Shah wrote:
> Can you do something low effort to work around this issue until we have 6129b changes ready?
I...
Vladimir Tsichevski
07:32 AM Base Language Bug #6993: OO: incorrect field names in DataTypeEnum.java
Can you do something low effort to work around this issue until we have 6129b changes ready? Greg Shah
06:27 AM Database Feature #6582: implement multi-table AdaptiveQuery
I've wrapped my head around this topic (@ProgressiveResults@ vs @ScrollingResults@) for a while now, so I can provide... Alexandru Lungu
05:55 AM Database Support #6714: check if there is an optimization opportunity when copying temp-tables based on mu...
Originally, my intention was to delete the records from a table based on the @targetMultiplex@ when the @outputParame... Dănuț Filimon
04:22 AM Database Feature #6816: improve PreselectQuery.assembleHQL
Update: I noticed that @SortCriterion.toString@ gets called quite often so I had a look in that function to see if so... Radu Apetrii

12/13/2022

06:48 PM Database Feature #6444: dataset improvements
Igor Skornyakov wrote:
> BTW: it looks that @FILL@ for recursive dataset can be very expensive since it can require ...
Ovidiu Maxiniuc
04:54 PM Base Language Bug #6993: OO: incorrect field names in DataTypeEnum.java
Greg Shah wrote:
> Vladimir: Please check your failing scenario in 6129b and let us know what you find.
Yes, in...
Vladimir Tsichevski
04:53 PM Base Language Bug #6993: OO: incorrect field names in DataTypeEnum.java
Constantin Asofiei wrote:
> Check your classpath. ConvertedClassName no longer exists in 6129b.
Yes, I forgot to ...
Vladimir Tsichevski
04:29 PM Base Language Bug #6993: OO: incorrect field names in DataTypeEnum.java
Check your classpath. ConvertedClassName no longer exists in 6129b. Constantin Asofiei
03:43 PM Base Language Bug #6993: OO: incorrect field names in DataTypeEnum.java
Greg Shah wrote:
> Vladimir: Please check your failing scenario in 6129b and let us know what you find.
I canno...
Vladimir Tsichevski
02:04 PM Base Language Bug #6993: OO: incorrect field names in DataTypeEnum.java
Our OO implementation is much more advanced in vranch 6129b than in 3821c. In 6129b, at this time we only use @Legac... Greg Shah
07:30 AM Base Language Bug #6993: OO: incorrect field names in DataTypeEnum.java
Vladimir Tsichevski wrote:
> No, it is the Java sources which will not compile.
> Note: the name if the field ref...
Marian Edu
07:24 AM Base Language Bug #6993: OO: incorrect field names in DataTypeEnum.java
Marian Edu wrote:
> All classes in @OpenEdge@ and @Progress@ packages were created *manually*, this is the expecte...
Vladimir Tsichevski
07:13 AM Base Language Bug #6993: OO: incorrect field names in DataTypeEnum.java
Vladimir Tsichevski wrote:
> The fields in @OpenEdge.Core.DataTypeEnum@ are named after the corresponding Progress b...
Marian Edu
06:59 AM Base Language Bug #6993 (Review): OO: incorrect field names in DataTypeEnum.java
Fixed in 3821c rev. 14438. Vladimir Tsichevski
06:45 AM Base Language Bug #6993 (WIP): OO: incorrect field names in DataTypeEnum.java
Vladimir Tsichevski
06:42 AM Base Language Bug #6993: OO: incorrect field names in DataTypeEnum.java
Please do fix this. Greg Shah
06:31 AM Base Language Bug #6993: OO: incorrect field names in DataTypeEnum.java
The fields in @OpenEdge.Core.DataTypeEnum@ are named after the corresponding Progress base data types, like @characte... Vladimir Tsichevski
06:24 AM Base Language Bug #6993 (Closed): OO: incorrect field names in DataTypeEnum.java
Vladimir Tsichevski
03:19 PM User Interface Feature #6996: WebGUI: Analyze the effect of willReadFrequently option on the 2D renderer perform...
According to this article https://html.spec.whatwg.org/multipage/canvas.html#concept-canvas-will-read-frequently @wil... Hynek Cihlar
03:13 PM User Interface Feature #6996 (New): WebGUI: Analyze the effect of willReadFrequently option on the 2D renderer p...
Hynek Cihlar
11:56 AM Database Feature #6995: possibly support NO-UNDO temporary tables directly in H2
I think @Session.log@ is responsible for logging the sub(tx) details needed for savepoints or rollback. This is enab... Constantin Asofiei
11:13 AM Database Feature #6995: possibly support NO-UNDO temporary tables directly in H2
I guess a simple first step is to profile typical flows in real applications and see if we can associate any bottlene... Eric Faulhaber
11:08 AM Database Feature #6995: possibly support NO-UNDO temporary tables directly in H2
NO-UNDO temp-tables are used heavily in many 4GL applications. Typically, regular temp-tables are used as well, such ... Eric Faulhaber
10:41 AM Database Feature #6995 (Closed): possibly support NO-UNDO temporary tables directly in H2
Eric Faulhaber
10:37 AM Database Feature #6582: implement multi-table AdaptiveQuery
Greg Shah wrote:
> > consider way stronger optimizations directly in the H2 engine: this involves some extended work...
Eric Faulhaber
09:10 AM User Interface Bug #6994: session:set-wait-state("general") must mimic UI responsiveness and UI mouse pointer be...
See testcase below.
# At @hBtnWaitstate@ of the (default-) window , the UI is irresponsive. At the @hBtnWaitstate@...
Tijs Wickardt
09:06 AM User Interface Bug #6994 (New): session:set-wait-state("general") must mimic UI responsiveness and UI mouse poin...
Tijs Wickardt
07:47 AM Database Feature #6928: H2 UPDATE performance improvement
Alexandru Lungu wrote:
> As a side question, I see some changes from for-each structure into index based iteration: ...
Constantin Asofiei
06:58 AM Database Feature #6928: H2 UPDATE performance improvement
I got deep in most of the changes in rev. 8 - they seem reasonable. As a side question, I see some changes from for-e... Alexandru Lungu

12/12/2022

04:34 PM Runtime Infrastructure Bug #5699 (Closed): broken logfile name on Windows appserver clients (and probably other cases on...
Greg Shah
01:28 PM Runtime Infrastructure Bug #5699: broken logfile name on Windows appserver clients (and probably other cases on Windows)
I ran the server on Windows with a batch process and was able to confirm the new behavior of the spawner of properly ... Galya B
02:29 PM Database Feature #6444: dataset improvements
Based on my tests the @FILL@ for recursive DATA-RELATION add records which are not in the DATA-SOURCE QUERY only if b... Igor Skornyakov
01:29 PM Runtime Infrastructure Feature #6939: improve proxy performance by hard-coding method invocation
Some additional notes:
* having both consumer and function lambdas doesn't really have a functional benefit, only fu...
Constantin Asofiei
10:32 AM Runtime Infrastructure Feature #6939: improve proxy performance by hard-coding method invocation
Eric, please review attached patch - it adds a invocation handler like this:... Constantin Asofiei
12:19 PM Database Feature #6928 (Review): H2 UPDATE performance improvement
The changes are in fwd-h2 project rev 8.
Alexandru: please review.
Constantin Asofiei
08:17 AM Database Support #6709: track nested FIND inside a related FOR loop
I've uncommitted 3821c rev 14436. It causes the following regression in conversion for a large customer application.... Greg Shah
04:29 AM Database Support #6709: track nested FIND inside a related FOR loop
Greg Shah wrote:
> You can just do this:
> ...
Dănuț Filimon

12/10/2022

11:52 PM Database Support #6714: check if there is an optimization opportunity when copying temp-tables based on mu...
Dănuț,
I am sorry for the delay, somehow the notification emails got lost at the bottom of the list and I only saw...
Ovidiu Maxiniuc

12/09/2022

10:30 AM Database Bug #6767: Possible name clashes in DMO classes
Eric: This is still waiting for review. Greg Shah
08:39 AM Database Feature #6444: dataset improvements
Marian Edu wrote:
> Igor Skornyakov wrote:
> > What puzzles me is the logic for 'relaxing' the @qEmp@ conditions to...
Igor Skornyakov
08:19 AM Database Feature #6444: dataset improvements
Igor Skornyakov wrote:
> What puzzles me is the logic for 'relaxing' the @qEmp@ conditions to find the parent record...
Marian Edu
07:45 AM Database Feature #6444: dataset improvements
Marian Edu wrote:
> Please not that while the recursive relation does load the FK parent in the parent temp-table (s...
Igor Skornyakov
05:32 AM Database Feature #6444: dataset improvements
The @data_relation/recursive_relation_fill.p@ test fails with FWD with @Cannot run GET methods on query qEmp until it... Igor Skornyakov
04:51 AM Database Feature #6444: dataset improvements
Marian Edu wrote:
> Ovidiu Maxiniuc wrote:
> >
> > > Marian,
> > > Is it correct that the DATA-SOURCE query shou...
Igor Skornyakov
04:46 AM Database Feature #6444: dataset improvements
Ovidiu Maxiniuc wrote:
>
> > Marian,
> > Is it correct that the DATA-SOURCE query should select a subset of a sin...
Marian Edu
08:16 AM Database Feature #6371: implement SAVE CACHE statement
Regression is fixed, current revision number is 14434. Boris Schegolev
05:41 AM Runtime Infrastructure Bug #5699: broken logfile name on Windows appserver clients (and probably other cases on Windows)
Greg Shah wrote:
> In your current setup, you are just using a local copy *bound to* the central repo. Any local co...
Galya B
05:38 AM Runtime Infrastructure Bug #5699 (Test): broken logfile name on Windows appserver clients (and probably other cases on W...
When you believe that all functional requirements of the task are complete, please set the % Done to 100%. Greg Shah
05:37 AM Runtime Infrastructure Bug #5699: broken logfile name on Windows appserver clients (and probably other cases on Windows)
> I messed up the branch creation / co and pushed from the local branch directly to 3821c. I'll be more careful next ... Greg Shah
05:32 AM Runtime Infrastructure Bug #5699: broken logfile name on Windows appserver clients (and probably other cases on Windows)
Greg Shah wrote:
> Code Review Task Branch 3821c Revision 14429
>
> The change is good, however you are missing t...
Galya B
05:30 AM Runtime Infrastructure Bug #5699: broken logfile name on Windows appserver clients (and probably other cases on Windows)
Code Review Task Branch 3821c Revision 14429
The change is good, however you are missing the history entry.
Greg Shah
05:20 AM Runtime Infrastructure Bug #5699 (Review): broken logfile name on Windows appserver clients (and probably other cases on...
Greg Shah wrote:
> Is @string@ not a pointer to @WCHAR@? If the contents of @string@ are not wide characters, then ...
Galya B

12/08/2022

06:44 PM Testing Bug #6920: Ins and outs of Sikuli for GUI testing
Today I had an very challenging issue related to using masks. There are times when the Chrome warning for a non-priva... Roger Borrello
04:40 PM Database Support #6709: track nested FIND inside a related FOR loop
> > 1. I don't think we should limit the for each processing to only match temp-tables and buffers. All record phrase... Greg Shah
04:32 PM Database Support #6709: track nested FIND inside a related FOR loop
I think @FieldReference@ is less clean looking and it will be slower. In #4928, we do have some ideas to improve it ... Greg Shah
08:45 AM Database Support #6709: track nested FIND inside a related FOR loop
... Dănuț Filimon
03:24 AM Database Support #6709: track nested FIND inside a related FOR loop
Greg Shah wrote:
> 1. I don't think we should limit the for each processing to only match temp-tables and buffers. A...
Dănuț Filimon
04:33 PM Database Feature #6371: implement SAVE CACHE statement
Boris, if you have a fix for the conversion regression, please commit it. Eric Faulhaber
01:06 PM Database Feature #6371: implement SAVE CACHE statement
Revision 6371a/14431 fixes some issues, including the following with the DMO interface assembly:
* a package path ...
Eric Faulhaber
04:23 PM Runtime Infrastructure Bug #5699: broken logfile name on Windows appserver clients (and probably other cases on Windows)
Is @string@ not a pointer to @WCHAR@? If the contents of @string@ are not wide characters, then that explains the re... Greg Shah
11:42 AM Runtime Infrastructure Bug #5699 (WIP): broken logfile name on Windows appserver clients (and probably other cases on Wi...
I was able to reproduce it. The problem is in @replace_str@ function. I've added to the code a few comments to show v... Galya B
03:45 PM Database Feature #6444: dataset improvements
Ovidiu Maxiniuc wrote:
>More than that, I understand that you aim for a 'fast-copy' mechanism where the rows are cop...
Igor Skornyakov
03:27 PM Database Feature #6444: dataset improvements
Ovidiu Maxiniuc wrote:
> Igor Skornyakov wrote:
> > > Oh, I see. Indeed, in this case we cannot be sure which versi...
Igor Skornyakov
03:02 PM Database Feature #6444: dataset improvements
Igor Skornyakov wrote:
> > Oh, I see. Indeed, in this case we cannot be sure which version of the CTE syntax to use....
Ovidiu Maxiniuc
05:59 AM Database Feature #6444: dataset improvements
Igor Skornyakov wrote:
> Oh, I see. Indeed, in this case we cannot be sure which version of the CTE syntax to use.
...
Igor Skornyakov
01:31 AM Database Feature #6444: dataset improvements
Ovidiu Maxiniuc wrote:
> Igor Skornyakov wrote:
> > It appears that DATASET:FILL() is not working at all for RECURS...
Igor Skornyakov
03:13 PM Base Language Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection
Yes. I assume the proxy case is being worked on in #6939. Greg Shah
02:42 PM Base Language Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection
Greg, the 8 million iterations chosen for the MthdTest was because this is the number of Utils.invoke for a large app... Constantin Asofiei
01:52 PM Base Language Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection
> How will it pass the parameters?
We can handle this with a bit of "standardization" in the registration or via a...
Greg Shah
01:41 PM Base Language Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection
I've tested something like this (for my original MthdTest):... Constantin Asofiei
12:52 PM Base Language Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection
Constantin Asofiei wrote:
> Greg Shah wrote:
> > We can generate Java code to register lambdas with CFO during an i...
Constantin Asofiei
12:41 PM Base Language Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection
Greg Shah wrote:
> We can generate Java code to register lambdas with CFO during an initializer. It could be an arr...
Constantin Asofiei
11:24 AM Base Language Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection
We can generate Java code to register lambdas with CFO during an initializer. It could be an array where each elemen... Greg Shah
11:20 AM Base Language Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection
Greg, for ControlFlowOps, this lambda method approach can't be easily used - because we will have to generate 'on the... Constantin Asofiei
10:13 AM Base Language Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection
> For this, we need to change the FWD proxy impl to send the lambda beside the Method to the handler.
Eric's idea ...
Greg Shah
10:03 AM Base Language Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection
Greg Shah wrote:
> I'm especially excited to see how this improves the @ControlFlowOps@ usage since we could elimina...
Constantin Asofiei
08:02 AM Base Language Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection
I'm especially excited to see how this improves the @ControlFlowOps@ usage since we could eliminate the dispatching c... Greg Shah
09:04 PM Base Language Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection
I've been working on a different approach to this problem. The original problem noted above is that ReflectASM and J... Greg Shah
01:55 PM Runtime Infrastructure Feature #6939: improve proxy performance by hard-coding method invocation
In the lambda approach, the target instance is already captured, so changing the array also changes the target. Greg Shah
01:43 PM Runtime Infrastructure Feature #6939: improve proxy performance by hard-coding method invocation
Greg Shah wrote:
> If we need the ability to temporarily replace the target methods for an implementation,
I don't ...
Constantin Asofiei
01:29 PM Runtime Infrastructure Feature #6939: improve proxy performance by hard-coding method invocation
If we need the ability to temporarily replace the target methods for an implementation, we should consider a kind of ... Greg Shah
01:10 PM Runtime Infrastructure Feature #6939: improve proxy performance by hard-coding method invocation
Constantin Asofiei wrote:
> ... directly from the bytecode of the i.e. DMO Implementation class setter/getter.
wh...
Constantin Asofiei
01:07 PM Runtime Infrastructure Feature #6939: improve proxy performance by hard-coding method invocation
Eric, the main issue of the interceptor flavor of the @InvocationHandler@ is that in some cases the target instance o... Constantin Asofiei
05:57 AM Database Support #6708 (Review): track/report at runtime when AdaptiveQuery shifts into dynamic mode
Committed 3821c/rev.14425. Small fix. The number of invalidated queries displayed in the Overview was wrong when @OUT... Dănuț Filimon

12/07/2022

04:42 PM Database Feature #6444: dataset improvements
Igor Skornyakov wrote:
> It appears that DATASET:FILL() is not working at all for RECURSIVE DATA-RELATION (the @Data...
Ovidiu Maxiniuc
11:56 AM Database Feature #6444: dataset improvements
Igor Skornyakov wrote:
> I'm thinking about adding support for a RECURSIVE DATA-RELATION by re-writing the DATA-SOUR...
Igor Skornyakov
10:45 AM Database Feature #6444: dataset improvements
The @BufferImpl.fill()@ method is pretty long (400 lines of code) and complicated.
I'm thinking about adding support...
Igor Skornyakov
12:25 PM User Interface Feature #3931: single sign-on for virtual desktop mode
Support for @<customers_large_gui_application>@ user name replacing OS account name in log files (as requested in #43... Galya B
07:07 AM Runtime Infrastructure Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...
From Galya, via email:
> I haven't looked at the Java classes instantiated by the spawner, so let me ask if there ...
Greg Shah
03:33 AM User Interface Feature #6764: Improve trigger selection for keyboard events.
Hynek Cihlar wrote:
> 6764.07.patch checked in to 3821c revision 14417.
I reverted the patch in 3821c revision 14...
Hynek Cihlar

12/06/2022

07:21 AM User Interface Feature #6764: Improve trigger selection for keyboard events.
6764.07.patch checked in to 3821c revision 14417. Hynek Cihlar
07:00 AM User Interface Feature #6764: Improve trigger selection for keyboard events.
Hynek Cihlar wrote:
>
> Marian, please add a file history entry to @ThinClient.java@ and also fix the one in @Even...
Marian Edu
03:48 AM User Interface Feature #6764: Improve trigger selection for keyboard events.
Marian Edu wrote:
> Greg Shah wrote:
> > > I'd like to get 6764.06.patch in 3821c. Any objection?
> >
> > No ob...
Hynek Cihlar

12/05/2022

03:01 PM Database Feature #6444: dataset improvements
It appears that DATASET:FILL() is not working at all for RECURSIVE DATA-RELATION (the @DataSet.getTopBufferList()@ re... Igor Skornyakov
02:47 PM User Interface Feature #6764: Improve trigger selection for keyboard events.
Greg Shah wrote:
> > I'd like to get 6764.06.patch in 3821c. Any objection?
>
> No objection from me.
None fr...
Marian Edu
02:34 PM User Interface Feature #6764: Improve trigger selection for keyboard events.
> I'd like to get 6764.06.patch in 3821c. Any objection?
No objection from me.
Greg Shah
02:33 PM User Interface Feature #6764: Improve trigger selection for keyboard events.
Hi
What is the status of this issue ?
I'd like to move on with Regression Tests fix and events/triggers are next bi...
Tomasz Domin
02:16 PM User Interface Feature #6764: Improve trigger selection for keyboard events.
Marian, Greg, I'd like to get @6764.06.patch@ in 3821c. Any objection? Hynek Cihlar
01:54 PM User Interface Feature #6978 (WIP): Editor widget performance optimization
Eugenie Lyzenko
09:42 AM User Interface Feature #6978: Editor widget performance optimization
From #6899-95:
Greg Shah wrote:
> Perhaps we can simplify things a bit. We store an array of lines. When we mak...
Hynek Cihlar
09:12 AM User Interface Feature #6978: Editor widget performance optimization
The remaining work discussion can be found in #6899.
In short when the editor content become big enough sending fu...
Eugenie Lyzenko
09:09 AM User Interface Feature #6978 (WIP): Editor widget performance optimization
Eugenie Lyzenko
09:29 AM Runtime Infrastructure Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...
Greg Shah wrote:
> The approach seems reasonable.
>
> Eugenie: Do you have any thoughts, questions or concerns?
...
Eugenie Lyzenko
09:11 AM Runtime Infrastructure Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...
The approach seems reasonable.
Eugenie: Do you have any thoughts, questions or concerns?
Greg Shah
06:18 AM Runtime Infrastructure Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...
The Windows spawner is a lot more simple than the UNIX one in the process creation part (more complicated in the secu... Galya B
04:41 AM Runtime Infrastructure Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...
Greg Shah wrote:
> The test code doesn't help me understand the process tree/pid list/redirected output log name for...
Galya B
07:34 AM Database Support #6709: track nested FIND inside a related FOR loop
Code Review 6709-rpt-20221205.diff
Good, it is getting closer.
1. I don't think we should limit the for each pr...
Greg Shah
03:51 AM Database Support #6709: track nested FIND inside a related FOR loop
Greg Shah wrote:
> 1. Please switch out the use of a @Stack@ for the @ScopedSymbolDictionary@.
I made the @FOR EACH...
Dănuț Filimon
06:07 AM Database Feature #6371: implement SAVE CACHE statement
My suspicion is the logical change in @XmlHelper.setAttribute()@ - I added a check for @value.isEmpty()@ and it proba... Boris Schegolev
12:51 AM Database Feature #6371: implement SAVE CACHE statement
Eric Faulhaber wrote:
> I found that I was unable to convert test cases using 6371a/14119, with an error during anno...
Eric Faulhaber
02:50 AM Database Feature #6816: improve PreselectQuery.assembleHQL
After I did some investigation upon the @PreselectQuery.assembleHQL@ function, two types of optimization occurred to ... Radu Apetrii
02:13 AM Database Feature #6928: H2 UPDATE performance improvement
|_. version |_. server run |_. client run |_. indexed (ms) |_. unindexed(ms) |
|h2-1.4.200.jar | 1...
Alexandru Lungu

12/02/2022

04:52 PM Database Feature #6928: H2 UPDATE performance improvement
Here are the results for two server runs, each with 5 client connection:
|\3=. First Run |/9. |\3=. Second Run |
|_...
Ovidiu Maxiniuc
02:32 PM Database Feature #6928: H2 UPDATE performance improvement
Alexandru/Ovidiu: previously I uploaded the wrong jar (it was the rev 7 one, not the patched one). Please try with t... Constantin Asofiei
11:17 AM Runtime Infrastructure Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...
The test code doesn't help me understand the process tree/pid list/redirected output log name for the FWD client. Ca... Greg Shah
09:09 AM Database Support #6708: track/report at runtime when AdaptiveQuery shifts into dynamic mode
Committed 3821c/rev.14409. Made a change in order to display the parent methods in the 4GL code by the number of call... Dănuț Filimon
08:44 AM Database Feature #6444: dataset improvements
Igor Skornyakov wrote:
> However, FWD in this case generates no row data at all.
It appears that this is the prob...
Igor Skornyakov

12/01/2022

10:49 AM Runtime Infrastructure Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...
I created a simple test to verify @execvp@ behaviour and uploaded it as zip. The test function in @C@ prints the pid ... Galya B
09:12 AM Runtime Infrastructure Bug #5701 (WIP): logfile names for -O outputToFile use the spawner pid instead of the Java (FWD c...
Constantin Asofiei wrote:
> The spawner will use @NativeSecureConnection.command@ to determine the launch command fo...
Galya B
07:08 AM Runtime Infrastructure Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...
Galya Bogdanova wrote:
> ... running in background where no client driver seems to be instantiated in the Java code,...
Constantin Asofiei
06:51 AM Runtime Infrastructure Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...
This is how I read the logic for the spawner (I'll be going with the Unix example):
@ClientBuilder#localStart()@ b...
Galya B
10:46 AM Database Feature #6444: dataset improvements
When PK and a FK are specified in an incorrect order in the @relation-fields@ clause (see #6444-23), 4GL does not com... Igor Skornyakov
10:30 AM Database Feature #6444: dataset improvements
Igor Skornyakov wrote:
> I've noticed an intersting thing. In the absense of the @nsPrefix@ 4GL @WRITE-XML@ creates ...
Igor Skornyakov
05:29 AM Database Feature #6444: dataset improvements
I've noticed an intersting thing. In the absense of the @nsPrefix@ 4GL @WRITE-XML@ creates "html-style" output. See a... Igor Skornyakov
04:46 AM Database Feature #6444: dataset improvements
Marian Edu wrote:
> Igor Skornyakov wrote:
> > What about navigation& I mean the following statement:
> > [...]
>...
Igor Skornyakov
04:44 AM Database Feature #6444: dataset improvements
Igor Skornyakov wrote:
> What about navigation& I mean the following statement:
> [...]
> How @a recursive ABL pro...
Marian Edu
04:35 AM Database Feature #6444: dataset improvements
Marian Edu wrote:
> Igor Skornyakov wrote:
> > What I'm doing wrong?
> By looking at the records created the 'cE' ...
Igor Skornyakov
04:34 AM Database Feature #6444: dataset improvements
Igor Skornyakov wrote:
> What I'm doing wrong?
By looking at the records created the 'cE' is the PK and 'cM' is the...
Marian Edu
04:27 AM Database Feature #6444: dataset improvements
Marian Edu wrote:
> This is mostly used by the 'tree-like' .NET UI components, as far as 4GL is concerned the effec...
Igor Skornyakov
04:09 AM Database Feature #6444: dataset improvements
Marian Edu wrote:
> Eric Faulhaber wrote:
> > Marian, can you shed any light on the RECURSIVE feature?
>
> This ...
Igor Skornyakov
03:34 AM Database Feature #6444: dataset improvements
Eric Faulhaber wrote:
> Marian, can you shed any light on the RECURSIVE feature?
This is mostly used by the 'tree...
Marian Edu
02:54 AM Database Feature #6444: dataset improvements
Found a number of incompatibilities in @(READ|WRITE)-XML(SCHEMA)?@ support for RECURSIVE DATASET.
Fixing them in 6129b.
Igor Skornyakov
01:00 AM Database Feature #6444: dataset improvements
Ovidiu Maxiniuc wrote:
> Igor,
>
> You cannot have the same table to be both the source and destination for a @fi...
Igor Skornyakov
07:52 AM Base Language Bug #6974: NPE at OpenEdge.Core.Class.IsInterface
The test code (@isinterface.p@):... Vladimir Tsichevski
07:46 AM Base Language Bug #6974 (New): NPE at OpenEdge.Core.Class.IsInterface
Vladimir Tsichevski
01:10 AM Database Feature #6371 (WIP): implement SAVE CACHE statement
I found that I was unable to convert test cases using 6371a/14119, with an error during annotations:... Eric Faulhaber

11/30/2022

06:31 PM Database Feature #6444: dataset improvements
Igor,
You cannot have the same table to be both the source and destination for a @fill@ operation (we do not suppo...
Ovidiu Maxiniuc
12:28 PM Database Feature #6444: dataset improvements
Another problem with @RECURSIVE@.
I'm trying to write a test for @FILL@ (see the attachment).
When I run it I get...
Igor Skornyakov
12:23 PM Database Feature #6444: dataset improvements
Marian, can you shed any light on the RECURSIVE feature? Eric Faulhaber
11:20 AM Database Feature #6444: dataset improvements
The OE documentation about @RECURSIVE@ Data-Relation object I see the following statement about such realtions:
<pre...
Igor Skornyakov
04:07 PM Database Feature #6371 (Review): implement SAVE CACHE statement
Boris Schegolev
02:18 AM Database Feature #6454 (Review): database informational features
Eric Faulhaber wrote:
> Igor, other than requiring review for the patch in #6454-11 and for 6129b/14335, is this tas...
Igor Skornyakov
02:04 AM Database Feature #6454: database informational features
Igor, other than requiring review for the patch in #6454-11 and for 6129b/14335, is this task finished from your poin... Eric Faulhaber

11/29/2022

01:06 PM Database Feature #6444: dataset improvements
Ovidiu Maxiniuc wrote:
> I assume you talk about the recent serialization updates for temp-tables and FOREIGN-KEY-HI...
Igor Skornyakov
12:37 PM Database Feature #6444: dataset improvements
I assume you talk about the recent serialization updates for temp-tables and FOREIGN-KEY-HIDDEN attribute. I do not t... Ovidiu Maxiniuc
10:16 AM Database Feature #6444: dataset improvements
Ovidiu Maxiniuc wrote:
> Eric Faulhaber wrote:
> > Ovidiu, thank you for the summary of status. I am reassigning to...
Igor Skornyakov
07:50 AM Database Feature #6454: database informational features
Greg Shah wrote:
> > I understand that this is because we do not have even stubs for RCODE-INFO:CRC-VALUE and RCODE-...
Igor Skornyakov
04:24 AM Database Feature #6454: database informational features
Constantin Asofiei wrote:
> Igor Skornyakov wrote:
> > Strangely enough I have found no @@DatabaseReferences@ annot...
Igor Skornyakov
03:09 AM Database Feature #6454: database informational features
Igor Skornyakov wrote:
> Strangely enough I have found no @@DatabaseReferences@ annotation in a converted large cust...
Constantin Asofiei
05:59 AM Database Feature #6928: H2 UPDATE performance improvement
|_. version |_. server run |_. client run |_. indexed (ms) |_. unindexed(ms) |
|fwd-h2-1.4.200-6.jar| 1...
Alexandru Lungu
05:34 AM Database Feature #6928: H2 UPDATE performance improvement
I am doing the stress tests right now.
> I've been running the H2 unit tests, too, and this showed some problems w...
Alexandru Lungu
04:16 AM Database Feature #6928: H2 UPDATE performance improvement
Thanks, Ovidiu, I'll profile some more and see what happens. Constantin Asofiei

11/28/2022

06:42 PM Database Bug #6919 (Review): fix ErrorManager.displayError in TempTableBuilder
Ovidiu Maxiniuc wrote:
> I see you added static import for @ErrorManager@. There are very few places where this is d...
Boris Schegolev
04:57 PM Base Language Bug #6963: Incorrect conversion of legacy class constructors with an unknown argument of object type
If an unknown value is passed an an argument to a class constructor, the conversion produces an correct call.
The ...
Vladimir Tsichevski
04:44 PM Base Language Bug #6963 (New): Incorrect conversion of legacy class constructors with an unknown argument of ob...
Vladimir Tsichevski
04:15 PM Database Feature #6444: dataset improvements
Eric Faulhaber wrote:
> Ovidiu, thank you for the summary of status. I am reassigning to Igor for implementation. Pl...
Ovidiu Maxiniuc
04:01 PM Database Feature #6444: dataset improvements
Greg Shah wrote:
> > Greg, Constantin, 3821c or 6129b for these changes? They most likely will be needed in 6129b fi...
Igor Skornyakov
03:52 PM Database Feature #6444: dataset improvements
> Greg, Constantin, 3821c or 6129b for these changes? They most likely will be needed in 6129b first, but we should d... Greg Shah
01:29 PM Database Feature #6444 (WIP): dataset improvements
Igor Skornyakov
01:25 PM Database Feature #6444: dataset improvements
Ovidiu, thank you for the summary of status. I am reassigning to Igor for implementation. Please assist him if he has... Eric Faulhaber
03:15 PM Database Feature #6928: H2 UPDATE performance improvement
With attached @h2-1.4.200.jar@, 1st run:
|_. n |_. indexed |_. non-indexed |
| 1 | 799 ms | 453 ms |
| 2 | 302 ms ...
Ovidiu Maxiniuc
10:18 AM Database Feature #6928: H2 UPDATE performance improvement
Attached is the second version of the patch and a stress-test for the UPDATE statement (10k field setters). The 'in-... Constantin Asofiei
09:51 AM Database Feature #6928 (WIP): H2 UPDATE performance improvement
Constantin Asofiei
02:52 PM Database Feature #6454: database informational features
Greg Shah wrote:
> > I understand that this is because we do not have even stubs for RCODE-INFO:CRC-VALUE and RCODE-...
Igor Skornyakov
02:50 PM Database Feature #6454: database informational features
> I understand that this is because we do not have even stubs for RCODE-INFO:CRC-VALUE and RCODE-INFO:LANGUAGES.
> D...
Greg Shah
02:30 PM Database Feature #6454: database informational features
As far as I can see, @RCODE-INFO:TABLE-LIST@ inplementation in FWD uses the value of the @tables@ attribute of the @@... Igor Skornyakov
12:23 PM Database Feature #6454: database informational features
I've noticed the following problem.
The statement...
Igor Skornyakov
11:37 AM Database Feature #6454: database informational features
Igor Skornyakov wrote:
> * It looks that the only database restriction we have to support is @READ-ONLY@. Should be ...
Igor Skornyakov
10:04 AM Database Feature #6454: database informational features
Constantin Asofiei wrote:
> Igor Skornyakov wrote:
> > Constantin Asofiei wrote:
> > > Igor, RCODE-INFO:TABLE-LIST...
Igor Skornyakov
09:59 AM Database Feature #6454: database informational features
Igor Skornyakov wrote:
> Constantin Asofiei wrote:
> > Igor, RCODE-INFO:TABLE-LIST is already added in 6129b.
>
...
Constantin Asofiei
09:18 AM Database Feature #6454: database informational features
Constantin Asofiei wrote:
> Igor, RCODE-INFO:TABLE-LIST is already added in 6129b.
Constantin,
I see only @Rcode...
Igor Skornyakov
02:49 AM Database Feature #6454: database informational features
Igor, RCODE-INFO:TABLE-LIST is already added in 6129b. Constantin Asofiei
08:59 AM Conversion Tools Feature #6237: OEUnit support
Marian Edu wrote:
> Vladimir Tsichevski wrote:
> > This does not compile for me, or at least displays warning messa...
Vladimir Tsichevski
08:48 AM Conversion Tools Feature #6237: OEUnit support
Vladimir Tsichevski wrote:
> This does not compile for me, or at least displays warning messages. Which OE version d...
Marian Edu
04:47 AM Database Support #6708: track/report at runtime when AdaptiveQuery shifts into dynamic mode
Committed 3821c/rev.14395. Made the changes mentioned in #6708-12 and fixed a problem where preselect and dynamic cal... Dănuț Filimon

11/27/2022

01:06 PM Database Feature #6454: database informational features
* As I can see from the code @DBPARAM@ reports *all* parameters supported by FWD for @CONNECT@
* It looks that the o...
Igor Skornyakov

11/26/2022

02:09 AM Database Feature #6448: make location of LOB files configurable for import
Ovidiu Maxiniuc wrote:
> Review of @lobs.diff@:
>
> Good job! Implemented as requested in #6448-2.
> Please do t...
Igor Skornyakov
10:21 PM Database Feature #6448: make location of LOB files configurable for import
Review of @lobs.diff@:
Good job! Implemented as requested in #6448-2.
Please do the cleanup (fix indentation of l...
Ovidiu Maxiniuc

11/25/2022

05:40 PM Database Feature #6459: query features
Eric Faulhaber wrote:
> Igor, I'm looking into the history of this part of the code. I don't think it's as simple as...
Greg Shah
01:35 PM Database Feature #6459: query features
Eric Faulhaber wrote:
> Igor, I'm looking into the history of this part of the code. I don't think it's as simple as...
Igor Skornyakov
11:08 AM Database Feature #6459: query features
Igor, I'm looking into the history of this part of the code. I don't think it's as simple as releasing the record unc... Eric Faulhaber
05:59 AM Database Feature #6459: query features
Constantin Asofiei wrote:
> What's the stacktrace where #6459-5 calls @throwOffend()@?
Here it is:...
Igor Skornyakov
05:24 AM Database Feature #6459: query features
Igor Skornyakov wrote:
> According to my tests, both forms of @FIRST-OF@/@LAST-OF@ are fully supported.
>
> I've...
Constantin Asofiei
05:31 PM Database Support #6709: track nested FIND inside a related FOR loop
OK, this is close to correct.
1. Please switch out the use of a @Stack@ for the @ScopedSymbolDictionary@. The i...
Greg Shah
07:11 AM Database Support #6709: track nested FIND inside a related FOR loop
I made the changes for the report. Now, it can track FIND statements that reference the same buffer as the FOR EACH i... Dănuț Filimon
05:30 PM Database Bug #6919: fix ErrorManager.displayError in TempTableBuilder
Review of @6919.diff@.
Good job! There were a lot of methods to check.
Interesting findings. I was not expectin...
Ovidiu Maxiniuc
05:12 PM Conversion Tools Feature #6237: OEUnit support
Marian Edu wrote:
> Vladimir Tsichevski wrote:
> > Seems, OE does not support multiple @ABLUnit@ life cycle unit te...
Vladimir Tsichevski
09:15 AM Conversion Tools Feature #6237: OEUnit support
Vladimir Tsichevski wrote:
> Seems, OE does not support multiple @ABLUnit@ life cycle unit test procedures, like @JU...
Marian Edu
08:55 AM Conversion Tools Feature #6237: OEUnit support
Or perhaps it makes more sense to implement the 4GL-compatible versions as annotation names which more clearly mappin... Greg Shah
08:52 AM Conversion Tools Feature #6237: OEUnit support
> Currently FWD supports this, and I wonder whether we should do unsupport :-)
We definitely need to implement in ...
Greg Shah
06:41 AM Conversion Tools Feature #6237: OEUnit support
Vladimir Tsichevski wrote:
> Seems, OE does not support multiple @ABLUnit@ life cycle unit test procedures.
This ho...
Vladimir Tsichevski
12:51 PM Database Feature #6454 (WIP): database informational features
Igor Skornyakov
12:50 PM Database Feature #6448: make location of LOB files configurable for import
Implemented as described in #6448-2.
The attached .diff file is for 6129b/14333.
Please review.
Thank you.
Igor Skornyakov
10:19 AM Database Feature #6448: make location of LOB files configurable for import
Igor Skornyakov wrote:
> I've got the following exception on the database import with 6129b/14333.
> [...]
> Is it...
Igor Skornyakov
10:01 AM Database Feature #6448: make location of LOB files configurable for import
I've got the following exception on the database import with 6129b/14333.... Igor Skornyakov
08:04 AM Database Support #6708: track/report at runtime when AdaptiveQuery shifts into dynamic mode
Nice work! I could generate insightful reports using customer applications. I will suggest only some fine tuning here... Alexandru Lungu

11/24/2022

11:56 AM Conversion Tools Feature #6237: OEUnit support
Seems, OE does not support multiple @ABLUnit@ life cycle unit test procedures, like @JUnit5@ supports. That means we ... Vladimir Tsichevski
10:57 AM Database Feature #6582: implement multi-table AdaptiveQuery
> consider way stronger optimizations directly in the H2 engine: this involves some extended work into the H2 optimiz... Greg Shah
10:56 AM Database Feature #6582: implement multi-table AdaptiveQuery
*CHECKPOINT*
I am pending the work here as I can't find any more consistent optimizations to motivate that multi-t...
Alexandru Lungu
10:24 AM Database Support #6709: track nested FIND inside a related FOR loop
> This is my intent, but I wanted to share my work until now.
Understood. No worries.
> Also, I guess you mean...
Greg Shah
05:00 AM Database Support #6709: track nested FIND inside a related FOR loop
Greg Shah wrote:
> Neither annotations/annotations.xml and annotations/annotations_prep.xml can't be used for the ne...
Dănuț Filimon
10:05 AM Database Feature #6453: temp-table features
> Eric, what should we do: remove this list or expose this as a enhanced feature with a method in SESSION handle?
...
Greg Shah
01:15 AM Database Feature #6453: temp-table features
Ovidiu Maxiniuc wrote:
> > Actually, if we replace throwing @XmlStreamException@ with @return false@ this will resul...
Igor Skornyakov
08:13 PM Database Feature #6453: temp-table features
Igor Skornyakov wrote:
> In fact, I do not understand why we add @TempTableBuilder@ to the @HandleChain@. I have not...
Ovidiu Maxiniuc
09:43 AM Database Feature #6448 (WIP): make location of LOB files configurable for import
Igor Skornyakov
09:42 AM Database Feature #6459: query features
I do not see how we can reliably figure out how the @CACHE@ attribute value affects the performance. Such things usua... Igor Skornyakov
09:39 AM Database Support #6708: track/report at runtime when AdaptiveQuery shifts into dynamic mode
Committed 3821c/rev.14384. I applied all the suggestions mentioned by Alexandru in #6708-7 and moved all the changes ... Dănuț Filimon
09:06 AM Database Support #6708: track/report at runtime when AdaptiveQuery shifts into dynamic mode
I rebased 6708a with 3821c. Danut, you can now move the changes from 6708a to 3821c. Alexandru Lungu

11/23/2022

01:39 PM Database Feature #6453: temp-table features
Igor Skornyakov wrote:
> In fact, the caller of this method just returns @false@ on @XmlStreamException@. Since this...
Igor Skornyakov
06:52 AM Database Feature #6453: temp-table features
Ovidiu Maxiniuc wrote:
> This class is unique in the fact that we have control of the short lifetime of the @TempTab...
Igor Skornyakov
11:16 AM Database Support #6709: track nested FIND inside a related FOR loop
Code Review 6709-rpt.diff
Neither @annotations/annotations.xml@ and @annotations/annotations_prep.xml@ can't be us...
Greg Shah
07:40 AM Database Support #6709: track nested FIND inside a related FOR loop
I took a different approach after taking a look at #3194 and modified how the report is made. I created a new rule se... Dănuț Filimon
06:20 AM Database Bug #6923: inner transaction block reverts too much
I attached a patch with some changes that, in my opinion, make more sense than the current implementation. Mainly, th... Radu Apetrii

11/22/2022

01:52 PM Database Feature #6453: temp-table features
Igor Skornyakov wrote:
> Sorry, but I'm confused. We create a new @TempTableBuilder@ instance e.g. in the @readTable...
Ovidiu Maxiniuc
12:41 PM Database Feature #6453: temp-table features
Ovidiu Maxiniuc wrote:
> The problem is that @TempTableBuilder@ -s are @HandleChain@ objects which are kept in a lin...
Igor Skornyakov
08:41 AM Database Feature #6459: query features
According to my tests, both forms of @FIRST-OF@/@LAST-OF@ are fully supported.
I've also fixed the problem with @...
Igor Skornyakov

11/21/2022

05:58 PM Database Bug #6919 (WIP): fix ErrorManager.displayError in TempTableBuilder
I am attaching my changes for review. This should be the complete implementation, I will do more testing tomorrow. Boris Schegolev
02:57 PM Database Feature #6453: temp-table features
Ovidiu Maxiniuc wrote:
> Related to 6129b/14329: after @ErrorManager.recordOrShowError@ do not @throw@ a new excepti...
Igor Skornyakov
02:21 PM Database Feature #6453: temp-table features
Igor,
Related to 6129b/14329: after @ErrorManager.recordOrShowError@ do not @throw@ a new exception. After the 4GL...
Ovidiu Maxiniuc
09:52 AM Database Feature #6453: temp-table features
Greg Shah wrote:
> >> how safe is to abend here?
> > I think that it is safe because actually, it should never happ...
Igor Skornyakov
07:30 AM Database Feature #6453: temp-table features
>> how safe is to abend here?
> I think that it is safe because actually, it should never happen if the schema is co...
Greg Shah
02:21 PM Testing Support #6858: rework existing testcases to use ABLUnit
Vladimir Tsichevski wrote:
> # Bugs: the @abl_unit/procedure_annotations/test_suite_no_explicit_errors.p@ refers t...
Marian Edu
02:09 PM Testing Support #6858: rework existing testcases to use ABLUnit
Greg Shah wrote:
> Vladimir is only working on the ablunit parts. He is adding some tests at a minimum. One can th...
Vladimir Tsichevski
02:04 PM Testing Support #6858: rework existing testcases to use ABLUnit
Marian Edu wrote:
> Vladimir Tsichevski wrote:
> > I've started reworking the sources @abl_unit/@ subdirectory into...
Vladimir Tsichevski
01:40 PM Testing Support #6858: rework existing testcases to use ABLUnit
Vladimir is only working on the ablunit parts. He is adding some tests at a minimum. One can think of that work as ... Greg Shah
01:37 PM Testing Support #6858: rework existing testcases to use ABLUnit
Vladimir Tsichevski wrote:
> I've started reworking the sources @abl_unit/@ subdirectory into a "pure ABLUnit". Also...
Marian Edu
01:25 PM Testing Support #6858: rework existing testcases to use ABLUnit
I've started reworking the sources @abl_unit/@ subdirectory into a "pure ABLUnit". Also I found some obvious bugs in ... Vladimir Tsichevski
09:30 AM Testing Support #6858: rework existing testcases to use ABLUnit
Just to remind everyone: the "master plan" for testing can be found in [[p2j:Testing Process]] and those pages/tasks ... Greg Shah
09:13 AM Testing Support #6858: rework existing testcases to use ABLUnit
Greg Shah wrote:
> I prefer to migrate these "in place". It is already confusing to have multiple testcase projects...
Marian Edu
08:40 AM Testing Support #6858: rework existing testcases to use ABLUnit
I prefer to migrate these "in place". It is already confusing to have multiple testcase projects (old and busted vs ... Greg Shah
06:22 AM Testing Support #6858 (WIP): rework existing testcases to use ABLUnit
We're working on this one and migrate existing unit tests (no user interaction) to new ones using ABLUnit, is there a... Marian Edu
01:06 PM Conversion Tools Bug #6901 (Test): Event handling - ON ANYWHERE
Greg Shah
10:48 AM Conversion Tools Bug #6901: Event handling - ON ANYWHERE
Greg Shah wrote:
> Hynek: Please commit the patch to 3821c.
Patch 6901.patch checked in 3821c revision 14378.
Hynek Cihlar
08:24 AM Conversion Tools Bug #6901: Event handling - ON ANYWHERE
Hynek: Please commit the patch to 3821c. Greg Shah
06:42 AM Conversion Tools Bug #6901: Event handling - ON ANYWHERE
Marian Edu wrote:
> Hynek Cihlar wrote:
>
> > I find helpful to turn on rules tracing, this helps to pinpoint the...
Marian Edu
06:36 AM Conversion Tools Bug #6901: Event handling - ON ANYWHERE
Hynek Cihlar wrote:
> I find helpful to turn on rules tracing, this helps to pinpoint the exact place where a part...
Marian Edu
06:32 AM Conversion Tools Bug #6901: Event handling - ON ANYWHERE
Marian Edu wrote:
> It took me a while to get along understanding xml code in those rules and where/what exactly nee...
Hynek Cihlar
06:17 AM Conversion Tools Bug #6901 (Review): Event handling - ON ANYWHERE
It took me a while to get along understanding xml code in those rules and where/what exactly needs to change... this ... Marian Edu
06:15 AM Conversion Tools Bug #6901 (WIP): Event handling - ON ANYWHERE
Marian Edu
07:40 AM Database Bug #6940 (Test): unqualified field name resolution when there is an explicit buffer defined in a...
Code Review Task Branch 6129b Revision 14327
The concept of the change is sound. Combined with the fact that it d...
Greg Shah
07:38 AM Database Bug #6940: unqualified field name resolution when there is an explicit buffer defined in an inter...
In the end there was no information in email, @testcases/uast/@, Redmine or @bzr@ that could lead be back to the orig... Greg Shah

11/19/2022

08:16 AM Database Bug #6940: unqualified field name resolution when there is an explicit buffer defined in an inter...
There is no change in the application used for task #346. In the customer's app, all changes look 'expected', the pa... Constantin Asofiei
08:00 AM Database Feature #6453: temp-table features
Constantin Asofiei wrote:
> Review for 6129b/14326:
> * how safe is to abend here?
> [...]
I think that it is saf...
Igor Skornyakov
07:41 AM Database Feature #6453: temp-table features
Review for 6129b/14326:
* how safe is to abend here?...
Constantin Asofiei

11/18/2022

05:51 PM Database Feature #6450 (Closed): buffer/buffer-field features
Eric Faulhaber
01:59 PM Database Feature #6450: buffer/buffer-field features
Yes, I think so.
Note that, unlike #6444 (where the changes were committed to 3821c), this task uses 6129a/b.
Ovidiu Maxiniuc
10:50 AM Database Feature #6450: buffer/buffer-field features
Can this be closed? Eric Faulhaber
02:44 PM Testing Feature #6183: design and implement (as needed) the approach for writing automated 4GL compatibil...
A problem with @skeleton/oo4gl/OpenEdge/DataAdmin/Internal/Util/CdcTablePolicyInstanceEnum.cls@:... Vladimir Tsichevski
01:57 PM Testing Bug #6920: Ins and outs of Sikuli for GUI testing
This chunk of code will show monitor information:... Roger Borrello
01:50 PM Database Feature #6444: dataset improvements
Eric Faulhaber wrote:
> Ovidiu, could you please review the list above and indicate what the actual support is curre...
Ovidiu Maxiniuc
01:14 PM Database Bug #6940: unqualified field name resolution when there is an explicit buffer defined in an inter...
The change was introduced in trunk revision 4785:... Greg Shah
12:56 PM Database Bug #6940: unqualified field name resolution when there is an explicit buffer defined in an inter...
I think the intent was to promote the parameter buffer, and not the 'source' for the parameter buffer. For example, ... Constantin Asofiei
12:22 PM Conversion Tools Feature #6237: OEUnit support
Vladimir Tsichevski wrote:
> Just found, that @@TestSuite@ annotation is not recognized and converted in procedures....
Vladimir Tsichevski
12:13 PM Database Feature #6459: query features
Greg Shah wrote:
> There are 2 forms of these: built-in function and handle-based method.
>
> Built-In Function f...
Igor Skornyakov
11:42 AM Database Feature #6459: query features
There are 2 forms of these: built-in function and handle-based method.
Built-In Function form:...
Greg Shah
10:21 AM Database Feature #6459: query features
Eric Faulhaber wrote:
> Igor Skornyakov wrote:
>
> > In 6129b both @FIRST-OF@ and @LAST-OF@ are set to @rw.cvt_l...
Igor Skornyakov
10:20 AM Database Feature #6459: query features
The @convert/methods_attributes.rules@ has support for both methods. Subclasses of @P2JQuery@ like @Persorter@ have ... Greg Shah
10:05 AM Database Feature #6459: query features
Igor Skornyakov wrote:
> In 6129b both @FIRST-OF@ and @LAST-OF@ are set to @rw.cvt_lvl_full | rw.rt_lvl_full@
...
Eric Faulhaber
09:42 AM Database Feature #6459: query features
Greg Shah wrote:
> > As far as I can see from my test, @FIRST-OF@, @LAST-OF@ methods are fully supported.
>
> At ...
Igor Skornyakov
09:17 AM Database Feature #6459: query features
> As far as I can see from my test, @FIRST-OF@, @LAST-OF@ methods are fully supported.
At a minimum, the gap marki...
Greg Shah
08:37 AM Database Feature #6459: query features
As far as I can see from my test, @FIRST-OF@, @LAST-OF@ methods are fully supported.
However, I see the following is...
Igor Skornyakov
09:56 AM Database Feature #6453 (Closed): temp-table features
Eric Faulhaber
01:36 AM Database Feature #6453: temp-table features
Ovidiu Maxiniuc wrote:
> Only one change before the commit, please: in @XmlImport.java@, instead of [...]use[...]
>...
Igor Skornyakov
08:24 AM Database Bug #6923: inner transaction block reverts too much
Thank you for the explanations!
I've taken them on board and I have seen that the bug is in fact about the restorati...
Radu Apetrii
08:01 AM Database Support #6709: track nested FIND inside a related FOR loop
Nice! Please post the diff so I can review the approach. It can be tricky to do this kind of static analysis becaus... Greg Shah
05:51 AM Database Support #6709: track nested FIND inside a related FOR loop
Greg Shah wrote:
> We are trying to evaluate how often in real 4GL code does this condition occur? Getting a measure...
Dănuț Filimon

11/17/2022

06:39 PM Database Bug #6940: unqualified field name resolution when there is an explicit buffer defined in an inter...
FYI, I'm digging back through the history on this one. I'll pick it back up in the morning. Greg Shah
08:02 AM Database Bug #6940: unqualified field name resolution when there is an explicit buffer defined in an inter...
The patch is built on top of 6129b/14324. Constantin Asofiei
08:01 AM Database Bug #6940: unqualified field name resolution when there is an explicit buffer defined in an inter...
Greg, the problem is that for a @DEF PARAM BUFFER ... FOR some-buf@ statement, @some-buf@ gets promoted because @def_... Constantin Asofiei
02:52 AM Database Bug #6940: unqualified field name resolution when there is an explicit buffer defined in an inter...
The problem is when a buffer is defined explicitly as a parameter - FWD doesn't resolve the unqualified field properl... Constantin Asofiei
02:46 AM Database Bug #6940 (Test): unqualified field name resolution when there is an explicit buffer defined in a...
Constantin Asofiei
03:18 PM Database Feature #6453: temp-table features
Only one change before the commit, please: in @XmlImport.java@, instead of ... Ovidiu Maxiniuc
02:20 PM Database Feature #6453 (Review): temp-table features
Igor Skornyakov wrote:
> Ovidiu Maxiniuc wrote:
> > Review of @read-xmlschema.diff@:
> [...]
> Can I commit the c...
Eric Faulhaber
05:03 AM Database Feature #6453: temp-table features
Tests used for this task committed to @xfer.goldencode.com/opt/testcases/temp-table-marshal@. rev. 1300.
Igor Skornyakov
01:58 AM Database Feature #6453: temp-table features
Ovidiu Maxiniuc wrote:
> Review of @read-xmlschema.diff@:
> * @AbstractTempTable@: the new method lacks the javadoc...
Igor Skornyakov
02:32 PM Database Feature #6371: implement SAVE CACHE statement
FYI, I am re-working the class unloading, which will not work currently in "real" use scenarios. When we create a DMO... Eric Faulhaber
02:21 PM Conversion Tools Feature #6237: OEUnit support
Just found, that @@TestSuite@ annotation is not recognized and converted in procedures. Will fix this... Vladimir Tsichevski
02:19 PM Base Language Feature #4658: OO serialization support
Greg Shah wrote:
> If a repo exists on both @devsrv01@ and on @xfer@, then the @devsrv01@ version is authoritative a...
Vladimir Tsichevski
11:29 AM Base Language Feature #4658: OO serialization support
If a repo exists on both @devsrv01@ and on @xfer@, then the @devsrv01@ version is authoritative and the @xfer@ versio... Greg Shah
11:27 AM Base Language Feature #4658: OO serialization support
Greg Shah wrote:
> Are you using @~/secure/code/p2j_repo/skeleton@? You should have full commit access to that repo...
Vladimir Tsichevski
09:03 AM Base Language Feature #4658: OO serialization support
Are you using @~/secure/code/p2j_repo/skeleton@? You should have full commit access to that repo. It is OK to commi... Greg Shah
07:21 AM Base Language Feature #4658: OO serialization support
Vladimir Tsichevski wrote:
> I think, I found an error in skeleton: class @DataAdminError@ has wrong class names in ...
Vladimir Tsichevski
02:02 PM Database Bug #6923: inner transaction block reverts too much
Eric Faulhaber wrote:
> ...the fact that the results are different in your first test case between temp-table and pe...
Eric Faulhaber
01:52 PM Database Bug #6923: inner transaction block reverts too much
When you nest transactions like:... Eric Faulhaber
06:50 AM Database Bug #6923 (WIP): inner transaction block reverts too much
An update to this issue:
I narrowed down the code, in order to describe what I have found until this moment. This is...
Radu Apetrii
12:02 PM Database Feature #6418: represent extent fields as arrays
Alexandru Lungu wrote:
> Eric, is there any prior partial implementation/discussion into the array fields?
There ...
Eric Faulhaber
03:29 AM Database Feature #6418: represent extent fields as arrays
Eric, is there any prior partial implementation/discussion into the array fields? If no, this task can be the lead ef... Alexandru Lungu
09:26 AM Testing Bug #6920: Ins and outs of Sikuli for GUI testing
After working for a few days on the customer testcases, and making sure I was able to get the @Region(x,y,w,h)@ value... Roger Borrello
09:07 AM Testing Feature #6183: design and implement (as needed) the approach for writing automated 4GL compatibil...
In the "new" [[p2j:Testcases]] project, there is the @abl_unit/@ directory with the existing testcases. I think you'... Greg Shah
07:27 AM Testing Feature #6183 (WIP): design and implement (as needed) the approach for writing automated 4GL comp...
I've created an @ABLUnit@ test for creating and sending all built-in errors implemented in FWD, which can be created ... Vladimir Tsichevski
07:41 AM Runtime Infrastructure Feature #6939: improve proxy performance by hard-coding method invocation
Eric Faulhaber wrote:
> But, recently we discovered that @ReflectASM@ actually can perform worse than reflection on ...
Constantin Asofiei
07:35 AM Database Feature #2137: runtime support for FIELDS/EXCEPT record phrase options
The @2137_20221114a.patch@ patch was committed to 3821c/14369, with these notes:
* only NO-LOCK records are loaded a...
Constantin Asofiei
07:34 AM Database Bug #6941: conversion issue when using undo in do transaction
There is a problem when converting examples that contain an @undo@ statement inside a @do transaction@.
For example,...
Radu Apetrii
07:20 AM Database Bug #6941 (Rejected): conversion issue when using undo in do transaction
Radu Apetrii
05:40 AM Database Feature #6816: improve PreselectQuery.assembleHQL
For an initial check, I recommend implementing a very small suite of performance tests (~6) for @PreselectQuery@ to t... Alexandru Lungu
03:33 AM Database Feature #6816 (WIP): improve PreselectQuery.assembleHQL
Alexandru Lungu
 

Also available in: Atom