Activity
From 01/31/2023 to 03/01/2023
03/01/2023
- 03:39 PM Base Language Bug #7135: NPE in conversion of OO looking for oldtype annotation
- Constantin Asofiei wrote:
> The patch is permanent.
Thanks... I will pursue the customer checking the patched ver... - 03:15 PM Base Language Bug #7135: NPE in conversion of OO looking for oldtype annotation
- Roger Borrello wrote:
> Opened task #7146 for the other runtime issue.
>
> Is the patching of the customer app pr... - 03:13 PM Base Language Bug #7135: NPE in conversion of OO looking for oldtype annotation
- Opened task #7146 for the other runtime issue.
Is the patching of the customer app procedures as noted in #7135-34... - 01:31 PM Database Feature #6444: dataset improvements
- Added support for the RESTART-ROW attribute.
Committed to 6444a/14499. - 10:50 AM Base Language Feature #6425: SESSION handle features
- It doesn't matter.
- 10:26 AM Base Language Feature #6425: SESSION handle features
- The code @message session:local-version-info@ prints @Progress.Lang.OEVersionInfo...1000@ using FWD and @Progress.Lan...
- 05:19 AM Database Feature #7061: Enable the use of lazy result sets in H2
- This is not the way to do it. @AdaptiveQuery.open@ is called only by explicit queries, usually dynamic (@QUERY-OPEN@ ...
- 03:46 AM Database Feature #7061: Enable the use of lazy result sets in H2
- Alexandru Lungu wrote:
> Further in my tests, I've got a crash when checking the dialect of the buffer in @AdaptiveQ... - 02:12 AM Database Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries
- Thanks, I was thinking of something else and I recalled in the wrong way; in a customer app, buffer names are generat...
02/28/2023
- 06:50 PM Database Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries
- Constantin, we are already doing this. After the query is parsed, the constants are extracted as variables. Each time...
- 05:33 PM Database Feature #6371: implement SAVE CACHE statement
- Pushed initial implementation of @DTTZ@ support in @SchemaCheck@ as revision 6371b/14486. I am just not sure where th...
- 10:46 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- And about the rest of the classes with main methods: Can I try to move all tools to a separate package, so that we kn...
- 10:23 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- It seems that some of the main methods are used by Harness for tests.
1. Can we get them out to the test directory... - 07:06 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Also @System.err@ can be found in ignored classes:...
- 06:10 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- ⚠ Which entry points are NOT used with p2j classpath?
List of all entry points in [[internal-documentation... - 07:23 AM Database Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns
- > One of the problems I have right now is that the rows are missing parameters when comparing in H2 and I am looking ...
- 04:00 AM User Interface Bug #7148: Differences between 4GL and FWD Swing/Web clients keystokes management for Dutch syste...
- This is @testcases/uast/keyboards/test-editor-keys.p@ 4GL testcase to reproduce differences in keys management.
- 03:54 AM User Interface Bug #7148: Differences between 4GL and FWD Swing/Web clients keystokes management for Dutch syste...
- This is the common task for all differences in behavior of the original 4GL client and the swing and web clients for ...
- 03:53 AM User Interface Bug #7148 (New): Differences between 4GL and FWD Swing/Web clients keystokes management for Dutch...
- 02:49 AM Database Feature #7062: Direct access to H2 internals to solve basic queries
- Committed 7026a/14507 removing some tracing variables - missed them on my first check.
02/27/2023
- 05:41 PM Base Language Feature #6425 (WIP): SESSION handle features
- 05:05 PM Database Feature #6371: implement SAVE CACHE statement
- Tested and pushed Sequences and validations as revision 6371b/14485. Proceeding with timezone support.
- 01:29 PM Conversion Tools Feature #6237: OEUnit support
- Yes, we need to implement this now.
- 01:29 PM Conversion Tools Feature #6237: OEUnit support
- > @OEUnit@ *assertion library*: converts, compiles, all unit tests included on @OEUnit@ package pass. Add it the the ...
- 09:58 AM Conversion Tools Feature #6237: OEUnit support
- Greg Shah wrote:
> Assume that we must include all support directly in FWD, just like with ABLUnit.
Should we do ... - 09:33 AM Conversion Tools Feature #6237: OEUnit support
- Assume that we must include all support directly in FWD, just like with ABLUnit.
- 09:29 AM Conversion Tools Feature #6237: OEUnit support
- Features unimplementation status:
# @OEUnit@ *assertion library*: converts, compiles, all unit tests included on @... - 01:25 PM Runtime Infrastructure Feature #7147: Make FWD log outputs consistent
- Galya Bogdanova wrote:
> Hynek, there are many issues with the current logging, formatting and init points are just ... - 10:40 AM Runtime Infrastructure Feature #7147: Make FWD log outputs consistent
- Hynek, there are many issues with the current logging, formatting and init points are just some of them. Most of it i...
- 08:39 AM Runtime Infrastructure Feature #7147: Make FWD log outputs consistent
- Galya has been working on a complete rewrite of our logging support. I suspect there is some duplication of effort h...
- 09:24 AM Database Feature #7062: Direct access to H2 internals to solve basic queries
- Done, committed 7026a/rev. 14506.
- 08:04 AM Database Feature #7062: Direct access to H2 internals to solve basic queries
- Alexandru Lungu wrote:
> [...]
> I will also allow such optimization for queries without client-where, joins and ex... - 08:01 AM Database Feature #7062: Direct access to H2 internals to solve basic queries
- ...
- 07:58 AM Database Feature #7062: Direct access to H2 internals to solve basic queries
- This was a last minute modification and the @LOCK_MODE 0@ from H2 was stuck in my head. It struck me at some point th...
- 07:47 AM Database Feature #7062: Direct access to H2 internals to solve basic queries
- Alexandru, the changes in RandomAccessQuery will not set the lock properly on a record found in the cache:...
- 08:53 AM Database Feature #6995: possibly support NO-UNDO temporary tables directly in H2
- Integrated the patch into 7062a. Also, the H2 changes made it to trunk.
I've reviewed the changes again and I have... - 08:45 AM Database Bug #7132: Eliminate for-each loops and lambda in FWD-H2 code
- Done several testing iterations with 7132a_h2/rev. 15 and the issue is solved. The bad news are that I couldn't notic...
- 07:36 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- @TransformDriver@ (ProgressTransformDriver / ConversionDriver) are used as standalone apps and if I'm not wrong they ...
- 04:58 AM Database Feature #6444: dataset improvements
- Tested the (de)serialization of recursive data relation for the remote calls.
Works OK. - 03:56 AM Database Feature #6582: implement multi-table AdaptiveQuery
- #7061 is mostly finished and now we have a @lazy@ keyword in FWD-H2 which works as a H2 database-cursor allowing us t...
- 03:15 AM Database Feature #7061: Enable the use of lazy result sets in H2
- Radu, I merged your changes from 7061a to 7026a. Note that 7026a is frozen right now.
First of all, I moved @suppo...
02/26/2023
- 09:31 AM Runtime Infrastructure Feature #7147: Make FWD log outputs consistent
- The attached diff improves the @CleanFormatter@ to shorten the qualified names to only include first letters for the ...
- 09:11 AM Runtime Infrastructure Feature #7147: Make FWD log outputs consistent
- The above points are resolved with the attached diff. Please review.
- 09:10 AM Runtime Infrastructure Feature #7147: Make FWD log outputs consistent
- There are multiple issues with FWD log outputs for both server and client processes.
* During server bootstrap dif... - 09:03 AM Runtime Infrastructure Feature #7147 (New): Make FWD log outputs consistent
02/25/2023
- 07:16 AM Database Feature #6444: dataset improvements
- Finished re-testing fixes for this task and #6453 after rebasing 6444a branch to the new trunk is finished.
Committe...
02/24/2023
- 03:12 PM Database Bug #6812 (WIP): fix FastFindCache to use a shared instance per persistent database
- I converted the code to use @Database@ object directly and reverted changes I made initially to visibility modifiers....
- 09:18 AM Database Bug #6812: fix FastFindCache to use a shared instance per persistent database
- I pushed the patch as revision 6812a/14485, working on better implementation (@Database@ object as key, cleanup, etc.)
- 12:52 PM Base Language Feature #4382: implement configurable directory override for PROGRESS global variable
- ...
- 11:06 AM Database Feature #6813: analyze and improve performance of dynamic conversion of temp-tables and queries
- Another point related to #6813-9 with query predicates which differ just with inlined literals. After the predicate ...
- 10:43 AM Base Language Bug #7135 (Review): NPE in conversion of OO looking for oldtype annotation
- Opened task #7145 to handle the first of the runtime errors.
- 05:57 AM Base Language Bug #7135: NPE in conversion of OO looking for oldtype annotation
- Open bugs for these runtime issues. If conversion works now, we move on and close this task.
- 10:06 AM Base Language Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection
- Greg Shah wrote:
> > With this in mind, I think it shouldn't take too long to change the invocation handler to recei... - 10:03 AM Base Language Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection
- > With this in mind, I think it shouldn't take too long to change the invocation handler to receive the info for Refl...
- 06:30 AM Base Language Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection
- I've changed the original #6819-3 test so that a new @Object[]@ (for the varargs) is not created on each call (so a s...
- 08:20 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- > > Use this as the default level. I don't see a good reason for implementing a minimum level.
>
> Then we should... - 08:02 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Greg Shah wrote:
> Use this as the default level. I don't see a good reason for implementing a minimum level.
Th... - 07:11 AM Base Language Feature #6821: java collection performance
- Constantin Asofiei wrote:
> Yes, this was from profiling a customer's application.
Great. Review complete, approved.
- 07:10 AM Base Language Feature #6821: java collection performance
- Tijs Wickardt wrote:
> Did you profile this? (I see #6821-55 but it seems high level).
Yes, this was from profiling... - 07:09 AM Base Language Feature #6821: java collection performance
- Constantin Asofiei wrote:
> The overhead is seen when this code is executed millions of times - I agree that using a... - 07:04 AM Base Language Feature #6821: java collection performance
- Tijs Wickardt wrote:
> Reviewed @p2j 7026a -r14497..14499@ .
> The changes are good.
> Remark on @Avoid the overhe... - 07:01 AM Base Language Feature #6821 (WIP): java collection performance
- 07:00 AM Base Language Feature #6821: java collection performance
- Reviewed @p2j 7026a -r14497..14499@ .
The changes are good.
Remark on @Avoid the overhead of calculating an empty m... - 05:03 AM Base Language Feature #6821 (Review): java collection performance
- Reviewing.
- 07:08 AM User Interface Bug #7144: Entering multibyte characters in a FILL-IN causes client to abend
- Entering multibyte characters in FWD causes the client to abend. To reproduce, enter any character that doesn't fit i...
- 07:06 AM User Interface Bug #7144 (New): Entering multibyte characters in a FILL-IN causes client to abend
- 06:58 AM Database Feature #7062: Direct access to H2 internals to solve basic queries
- I merged the changes from 7062a into 7026a - the branch names are quite confusing :)
I have good results, similar ... - 06:02 AM Database Feature #7061: Enable the use of lazy result sets in H2
- > I'll wait for a final decision on this.
Well, it definitely looks like it really depends on the converted code. I ... - 05:46 AM Database Feature #7061: Enable the use of lazy result sets in H2
- Alexandru Lungu wrote:
> Alexandru Lungu wrote:
> > ** Count how many actual lazy queries are there in a large appl... - 04:21 AM Database Feature #7061: Enable the use of lazy result sets in H2
- Alexandru Lungu wrote:
> ** Count how many actual lazy queries are there in a large application: static vs dynamic, ... - 04:42 AM Database Bug #7132: Eliminate for-each loops and lambda in FWD-H2 code
- Alexandru Lungu wrote:
> Please make a new commit which reverts the changes for that less used classes. I would like... - 04:30 AM Base Language Feature #6410: implement additional built-in OO classes/interfaces
- Greg Shah wrote:
> 6129b which is now in trunk revision 14484 does have all my previous work on method overloading. ...
02/23/2023
- 05:30 PM Base Language Bug #7135: NPE in conversion of OO looking for oldtype annotation
- There's a lot of issues. Noted one for the GUI application in #6851-203. The ChUI app gets @** LABEL is not a setable...
- 04:35 PM Base Language Bug #7135: NPE in conversion of OO looking for oldtype annotation
- So the incremental build completed, including the compilation. I will need to do some testing, but this is committed ...
- 02:31 PM Base Language Bug #7135: NPE in conversion of OO looking for oldtype annotation
- Constantin Asofiei wrote:
> Only the ToString which has an argument as @java.util.Map@ needs to change. Do not touc... - 02:16 PM Base Language Bug #7135: NPE in conversion of OO looking for oldtype annotation
- I've just noticed something in your patch - I mean to change:
> METHOD PUBLIC CHARACTER ToString (INPUT pChartHash A... - 02:15 PM Base Language Bug #7135: NPE in conversion of OO looking for oldtype annotation
- Roger, thanks, that confirms what you posted. Just change the 4GL method definitions in these classes to be @asStrin...
- 02:13 PM Base Language Bug #7135: NPE in conversion of OO looking for oldtype annotation
- I see this:...
- 02:09 PM Base Language Bug #7135: NPE in conversion of OO looking for oldtype annotation
- FYI, officially we do not support subclassing 4GL code from Java parent classes or implementing Java interfaces in 4G...
- 02:01 PM Base Language Bug #7135: NPE in conversion of OO looking for oldtype annotation
- I think @LabelRenderer@ is part of the FWD's @ChartWidget.labelHash@, which is not implemented at this time.
- 01:58 PM Base Language Bug #7135: NPE in conversion of OO looking for oldtype annotation
- Something like this, and @ToString (INPUT pChartHash AS java.util.Map): @ needs to be @asString (INPUT pChartHash AS ...
- 01:39 PM Base Language Bug #7135: NPE in conversion of OO looking for oldtype annotation
- So the five 4GL procedures that had issues with @LabelRenderer.toLegacyString@:
# app_7135a-14486_20230215a/src/.../... - 01:19 PM Base Language Bug #7135: NPE in conversion of OO looking for oldtype annotation
- Roger, as a fast way to solve it: in the 4GL code, can we change all @RenderLabelData.ToString(INPUT pChartHash AS ja...
- 01:08 PM Base Language Bug #7135: NPE in conversion of OO looking for oldtype annotation
- Roger, is a little more tricky than this, @NameConverter@ will automatically append an underscore because @toString@ ...
- 12:53 PM Base Language Bug #7135: NPE in conversion of OO looking for oldtype annotation
- Constantin Asofiei wrote:
> Roger, sorry, in this case rename toLegacyString in the Java class to toString. That na... - 12:44 PM Base Language Bug #7135: NPE in conversion of OO looking for oldtype annotation
- Roger, sorry, in this case rename toLegacyString in the Java class to toString. That name was chosen because of the ...
- 12:40 PM Base Language Bug #7135: NPE in conversion of OO looking for oldtype annotation
- Yes
- 12:36 PM Base Language Bug #7135: NPE in conversion of OO looking for oldtype annotation
- So the 4GL would need to be patched to have @toString@ become @toLegacyString@:...
- 12:31 PM Base Language Bug #7135: NPE in conversion of OO looking for oldtype annotation
- Greg Shah wrote:
> You are proposing that we just hand-edit the 4GL source code to change the names?
Correct. If a... - 12:31 PM Base Language Bug #7135: NPE in conversion of OO looking for oldtype annotation
- You are proposing that we just hand-edit the 4GL source code to change the names?
- 10:39 AM Base Language Bug #7135: NPE in conversion of OO looking for oldtype annotation
- Greg, adding the @LegacySignature@ at a Java interface method will not work.
Before 6129c, @toString@ I think had ... - 10:35 AM Base Language Bug #7135: NPE in conversion of OO looking for oldtype annotation
- Look at anything in @com.goldencode.p2j.oo@.
- 10:29 AM Base Language Bug #7135: NPE in conversion of OO looking for oldtype annotation
- Greg Shah wrote:
> The @com.goldencode.p2j.ui.chart.LabelRenderer@ does not include the normal legacy signature anno... - 09:25 AM Base Language Bug #7135: NPE in conversion of OO looking for oldtype annotation
- We are choosing to emit @toString_()@ name instead of @toLegacyString()@ in the child classes.
The @com.goldencode... - 09:18 AM Base Language Bug #7135: NPE in conversion of OO looking for oldtype annotation
- For this class:...
- 08:11 AM Base Language Bug #7135: NPE in conversion of OO looking for oldtype annotation
- This is probably something different. The @toLegacyString(jobject<? extends Map>)@ is our replacement name for @toSt...
- 05:17 PM Database Bug #6812: fix FastFindCache to use a shared instance per persistent database
- Please create a 6812a branch from trunk and apply the diff. This will make it easier to review in context.
I've on... - 04:40 PM Database Bug #6812: fix FastFindCache to use a shared instance per persistent database
- I am attaching a suggested solution. It's somewhat raw (I had to make some elements public), but I can fix that for t...
- 03:00 PM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Use this as the default level. I don't see a good reason for implementing a minimum level.
- 09:09 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- How do we want to treat the logging level from configs? It could be the min level for all loggers or the default leve...
- 07:22 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- > At the moment it doesn't work exactly as in Progress where it outputs to the console, as well as to a file with re...
- 02:16 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- I agree with everything said. Let me just explain about batch. At the moment it doesn't work exactly as in Progress w...
- 07:26 PM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- > up till now FWD logs were written to the console by System.err and redirected to a file, so in practice console log...
- 12:35 PM Database Feature #6444: dataset improvements
- I'm re-testing temp-table ans data-set changes from #6453 and this task with 6444a rebased to the trunk.
After fixin... - 12:28 PM Base Language Feature #6821: java collection performance
- 7026a/14499 contains some other improvements:
* Avoid the @LinkedList@ overhead, use @ArrayDeque@ instead, for @Nam... - 11:08 AM Database Bug #7132 (WIP): Eliminate for-each loops and lambda in FWD-H2 code
- *This is a review for 7132a_h2, rev. 14*
There are many changes in several files, so I've done a skim review of th... - 09:24 AM Database Bug #7132: Eliminate for-each loops and lambda in FWD-H2 code
- Alexandru Lungu wrote:
> Lastly, I think there may be an overhead by using @synchronized@ even in single-user H2 ins... - 09:39 AM Database Bug #7138: Short circuit fake-update (update with a new value eqaul to the old value) in H2
- I recall a scenario in which some records were updated in a for-loop and their new values were the same as the old va...
- 08:13 PM Database Bug #7138: Short circuit fake-update (update with a new value eqaul to the old value) in H2
- These should not occur since we create the @SET@ part of statement based only on changed properties (@BaseRecord.dirt...
- 04:53 AM Database Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns
- Ovidiu Maxiniuc wrote:
> I altered your tests and remove the index for both tables: in this case we have the more lo...
02/22/2023
- 04:56 PM Base Language Bug #7135 (WIP): NPE in conversion of OO looking for oldtype annotation
- The app converted successfully with both changes in place!
But there were compilation errors:... - 04:34 PM Database Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns
- I am really puzzled about this fact. I found the article in a parallel investigation. It really shocked my understand...
- 07:00 AM Database Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns
- Alexandru Lungu wrote:
> Danut, please extract this into a separate 4GL test: CI database field with CS query parame... - 03:33 AM Database Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns
- Ovidiu Maxiniuc wrote:
> Yes, this could be an improvement if the strings are really different at their beginning. T... - 11:23 AM Database Feature #7061: Enable the use of lazy result sets in H2
- I reverted your latest changes to H2 because I wanted to merge a tested, profiled version (rev. 15).
* The null che... - 03:44 AM Database Feature #7061: Enable the use of lazy result sets in H2
- Alexandru Lungu wrote:
> > If the dependency is the H2 dialect on its own, then I think the condition should be some... - 11:23 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Greg Shah wrote:
> I'm not sure we can eliminate the command line use of @>@ because customers may have 4GL code use... - 11:10 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- P.S. Actually not even a redirect. For batch there is a certain method in @ErrorWriterBatch@ that should be reworked ...
- 11:07 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Greg Shah wrote:
> Can you help me understand what you mean by "rework it to reuse the same method"? In this case, ... - 11:04 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Galya Bogdanova wrote:
> Greg, when you wrote:
> > I think we need to implement the following:
> > standard redire... - 10:58 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- I have no objection to the name.
- 10:55 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Let me also raise the question about the new logger name.
I've ended up with a few new classes:
* CentralLogger -... - 10:37 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Greg, when you wrote:
> I think we need to implement the following:
> standard redirections
did you have in mind... - 03:44 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- An important question - up till now FWD logs were written to the console by @System.err@ and redirected to a file, so...
- 08:57 AM Database Bug #7138: Short circuit fake-update (update with a new value eqaul to the old value) in H2
- I encountered several fake-updates in large customer applications. A fake-update is something like @UPDATE tt SET f1 ...
- 08:50 AM Database Bug #7138 (Closed): Short circuit fake-update (update with a new value eqaul to the old value) in H2
- 08:27 AM Runtime Infrastructure Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...
- It won't be until some time next week. We have many performance changes and some regression fixes that need to go fi...
- 08:10 AM Runtime Infrastructure Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...
- Greg, I merged the changes to an up-to-date branch 5701b and there were no conflicts (r14485). When do I merge?
02/21/2023
- 03:40 PM Database Feature #6371: implement SAVE CACHE statement
- Please create a 6371b branch from trunk for this patch and the other remaining features. Thanks.
- 02:36 PM Database Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns
- Alexandru Lungu wrote:
> I agree that we still need to use the @Collator@, but maybe we could have done something li... - 05:17 AM Database Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns
- Ovidiu Maxiniuc wrote:
> I looked again at your results in #7108-8. They do not seem alright. There are several case... - 05:04 AM Database Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns
- Ovidiu Maxiniuc wrote:
> Yes, I think we need that. I do not have an exact example (when I was working with these I ... - 02:34 PM Base Language Bug #7135 (Review): NPE in conversion of OO looking for oldtype annotation
- Committed revision 7135a_14486. Re-running customer app conversion.
- 02:10 PM Base Language Bug #7135: NPE in conversion of OO looking for oldtype annotation
- It is fine for now.
- 02:06 PM Base Language Bug #7135: NPE in conversion of OO looking for oldtype annotation
- Roger, please try this patch:...
- 01:55 PM Base Language Bug #7135: NPE in conversion of OO looking for oldtype annotation
- This testcase:...
- 11:49 AM Base Language Bug #7135: NPE in conversion of OO looking for oldtype annotation
- Constantin Asofiei wrote:
> Please work on a standalone test and lets use this task for the customer's app issues wi... - 10:50 AM Base Language Bug #7135: NPE in conversion of OO looking for oldtype annotation
- Please work on a standalone test and lets use this task for the customer's app issues with trunk (conversion or runti...
- 10:40 AM Base Language Bug #7135: NPE in conversion of OO looking for oldtype annotation
- Roger Borrello wrote:
> I will see if it is related to the change, versus a different issue.
I see that issue whe... - 09:27 AM Base Language Bug #7135 (WIP): NPE in conversion of OO looking for oldtype annotation
- Greg Shah wrote:
> If this passes testing, we will merge it to trunk.
There was an issue later in the conversion ... - 07:13 AM Base Language Bug #7135: NPE in conversion of OO looking for oldtype annotation
- If this passes testing, we will merge it to trunk.
- 07:13 AM Base Language Bug #7135 (Test): NPE in conversion of OO looking for oldtype annotation
- Code Review Task Branch 7135a Revision 14485
No objections. - 12:26 PM Database Bug #7113 (Review): Problem with nested CAN-FIND conversion
- Fixed SQL generation.
Committed to 7113a/14896.
Please review.
Thank you. - 11:57 AM Database Bug #7047: Problem with AdaptiveQuery and ScrollableResults
- Alexandru Lungu wrote:
> I can't say why PostgreSQL behaves differently, but logically all non-scrolling 4GL queri... - 09:34 AM Database Bug #7047: Problem with AdaptiveQuery and ScrollableResults
- As a side investigation which may help here:
@AdaptiveQuery@ is not considering @recid@ index as a sorting index. ... - 10:05 AM Base Language Feature #6410: implement additional built-in OO classes/interfaces
- > For ctor's this doesn't seem to work at all
6129b which is now in trunk revision 14484 does have all my previous... - 09:46 AM Base Language Feature #6410: implement additional built-in OO classes/interfaces
- Greg Shah wrote:
> Are you working off of trunk rev 14484?
Conversion was ran with trunk #14483, working on 6129b... - 09:36 AM Base Language Feature #6410: implement additional built-in OO classes/interfaces
- > is there any update on method/ctor resolution during conversion in regard with Java erasure issue caused by the `ob...
- 09:13 AM Base Language Feature #6410: implement additional built-in OO classes/interfaces
- Greg, is there any update on method/ctor resolution during conversion in regard with Java erasure issue caused by the...
- 10:00 AM Database Bug #7132: Eliminate for-each loops and lambda in FWD-H2 code
- Committed rev. 13 finishing replacements from for-each loops to classical for loops. I've done some tests, but there ...
- 07:14 AM Database Bug #7132: Eliminate for-each loops and lambda in FWD-H2 code
- Created 7132a_h2 from trunk rev. 11. Committed rev. 12 including lots of replacements from for-each loops to classica...
- 09:56 AM Base Language Feature #6818: analyze the performance of the FWD open client proxy client support
- 7026a/14497 contains changes for the legacy JavaOpenClient:
* Encapsulated the field and relation metadata in their... - 08:26 PM Database Feature #7020 (Review): always use "expanded" extent fields
- I attempted to rebase 7020a to trunk, but that proved to be a very time consuming task, practically duplicating Const...
02/20/2023
- 06:54 PM Base Language Bug #7135 (Review): NPE in conversion of OO looking for oldtype annotation
- Branch 7135a rev 14485 ready for review.
- 04:05 PM Base Language Bug #7135: NPE in conversion of OO looking for oldtype annotation
- Yes
- 02:44 PM Base Language Bug #7135 (WIP): NPE in conversion of OO looking for oldtype annotation
- Running conversion. Should I create a branch 7135a?
- 02:17 PM Base Language Bug #7135: NPE in conversion of OO looking for oldtype annotation
- Roger Borrello wrote:
> Is this a fix I should try against the customer's code?
Yes.
- 02:12 PM Base Language Bug #7135: NPE in conversion of OO looking for oldtype annotation
- That results in a successful conversion. So those warnings are just red-herrings?
Is this a fix I should try again... - 01:47 PM Base Language Bug #7135: NPE in conversion of OO looking for oldtype annotation
- Roger, please try this patch (on top of trunk rev 14484):...
- 01:32 PM Base Language Bug #7135: NPE in conversion of OO looking for oldtype annotation
- The AST is attached:
- 01:30 PM Base Language Bug #7135: NPE in conversion of OO looking for oldtype annotation
- Using this testcase (placed in @uast/oo@:...
- 01:26 PM Base Language Bug #7135 (Closed): NPE in conversion of OO looking for oldtype annotation
- 04:10 PM Base Language Feature #6426 (Closed): implement ERROR-STATUS:CLEAR()
- In the short term it is fine. In the longer term we will probably need to fix it.
- 12:12 PM Base Language Feature #6426: implement ERROR-STATUS:CLEAR()
- Greg, IMO, I think we are OK with 'doing nothing'. Otherwise, we can treat these cases of invalid attribute/method r...
- 10:21 AM Base Language Feature #6426: implement ERROR-STATUS:CLEAR()
- Yes, I noticed it. Do I need to make any changes (e.g. show a warning)?
- 08:40 AM Base Language Feature #6426: implement ERROR-STATUS:CLEAR()
- There is nothing emitted by conversion in @error-status:clear().@, see the standalone @;@ char on a single line.
- 03:45 PM Database Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns
- Alexandru Lungu wrote:
> I am facing a hot-spot in my profiling that may actual affect #7108 effort as well. It is r... - 02:24 PM Database Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns
- Dănuț Filimon wrote:
> The tests from #7108-8 were done *without any patch applied*. I retested with the patch appli... - 08:48 AM Database Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns
- Ovidiu, I recall that you had done some work with locale at some point. Please let me know if you can help me on this...
- 02:28 PM Database Bug #7113: Problem with nested CAN-FIND conversion
- The only remaining issue is that generated SQL statement contains extra closing brackets @)@ at the end of the WHERE ...
- 11:20 AM Database Bug #7113: Problem with nested CAN-FIND conversion
- Committed fix for the nested CAN-FIND to 7113a/14485.
- 10:55 AM Database Bug #7113: Problem with nested CAN-FIND conversion
- Created task branch 7113a.
- 09:48 AM Database Bug #7113: Problem with nested CAN-FIND conversion
- Igor Skornyakov wrote:
> Igor Skornyakov wrote:
> > Fixed nested CAN-FIND conversion (see attached .diff).
> > Ple... - 08:52 AM Database Bug #7113: Problem with nested CAN-FIND conversion
- Igor Skornyakov wrote:
> Fixed nested CAN-FIND conversion (see attached .diff).
> Please review.
> Thank you.
>
... - 08:40 AM Database Bug #7113: Problem with nested CAN-FIND conversion
- Fixed nested CAN-FIND conversion (see attached .diff).
Please review.
Thank you.
Working on runtime issue (#7113... - 08:56 AM Database Bug #7132: Eliminate for-each loops and lambda in FWD-H2 code
- Alexandru Lungu wrote:
> Second, there is an overhead with using lambdas, especially the ones which reference local ... - 04:10 AM Database Bug #7132: Eliminate for-each loops and lambda in FWD-H2 code
- There is an overhead in using foreach loops: @for (Object obj : objs)@. This is because an iterator object is generat...
- 03:47 AM Database Bug #7132 (WIP): Eliminate for-each loops and lambda in FWD-H2 code
- 03:32 AM Database Feature #7061: Enable the use of lazy result sets in H2
- Radu:
* I've created 7061a branched from trunk to commit your changes to.
* Please notify me once you address the r...
02/17/2023
- 02:27 PM Base Language Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection
- Constantin Asofiei wrote:
> Greg: we need to consider if we want to make it a policy to discourage Java lambda, th... - 12:53 PM Base Language Feature #6426: implement ERROR-STATUS:CLEAR()
- Post here the .java file for your converted program.
- 12:53 PM Base Language Feature #6426: implement ERROR-STATUS:CLEAR()
- I am not sure. I compiled and ran the app using the testcases project without any issues.
- 12:00 PM Base Language Feature #6426: implement ERROR-STATUS:CLEAR()
- I'm confused, how does FWD convert @error-status:clear().@?
- 11:58 AM Base Language Feature #6426: implement ERROR-STATUS:CLEAR()
- Yes, the error occurs at runtime...
- 10:16 AM Base Language Feature #6426: implement ERROR-STATUS:CLEAR()
- Hmm, we must have done something special for this case (or for @ERROR-STATUS@ in general).
To confirm, the error... - 06:05 AM Base Language Feature #6426: implement ERROR-STATUS:CLEAR()
- No, FWD does not fail during conversion. FWD and OE both have the same output. The only difference is that OE pops up...
- 05:41 AM Base Language Feature #6426: implement ERROR-STATUS:CLEAR()
- I need to discuss this with the customer.
FWD fails during conversion of this testcase, right? - 04:10 AM Base Language Feature #6426: implement ERROR-STATUS:CLEAR()
- Do I need to do something more for this ticket now?
- 09:49 AM Database Feature #7061: Enable the use of lazy result sets in H2
- Alexandru Lungu wrote:
> As the patch and H2 modifications are mostly complete, in the sense that I have no obvious ... - 08:43 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Good
- 08:40 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Greg Shah wrote:
> If possible. Of course, a network failure while something is pending will be a problem.
I've ... - 08:32 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Whether it is recursion or deadlock, the state synch approach should work.
- 08:31 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- If possible. Of course, a network failure while something is pending will be a problem.
- 08:31 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Greg Shah wrote:
> I think this is also the solution to this current deadlock issue since there will be no calls to ... - 08:31 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- > The only concern would be if some logs will be discarded at the end of the application run.
Agreed, we should t... - 08:26 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Greg Shah wrote:
> We've previously noted that making an up (client to server) or down (server to client) call to wr... - 08:21 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- We've previously noted that making an up (client to server) or down (server to client) call to write the log output w...
- 08:10 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Greg, the classes @BlockingSSL@ and @NetSocket@ (@LoggingNetSocket@ / @NIOSslSocket@) log low level details of the rp...
- 06:58 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- I made a breakthrough. I was thinking the issues with the freezing client and no exceptions thrown is in the line of ...
- 06:11 AM Base Language Feature #4382: implement configurable directory override for PROGRESS global variable
- Can you please elaborate more?
- 05:58 AM Base Language Feature #4382: implement configurable directory override for PROGRESS global variable
- No, this is a reference to the @directory.xml@ used as the configuration source for the FWD application server.
- 05:57 AM Base Language Feature #4382: implement configurable directory override for PROGRESS global variable
- I would like to ask for some help. Directory override means changing the working directory on runtime or does it mean...
02/16/2023
- 05:36 PM Database Bug #6887: improve performance of dataset/table[-handle] parameters
- The methods/attributes implemented by #6444 are not related to parameters. They perform the same regardless the datas...
- 04:31 PM Database Bug #6887: improve performance of dataset/table[-handle] parameters
- I didn't make any changes for this task. Not sure if there are any relevant changes coming from #6444.
- 03:23 PM Database Bug #6887: improve performance of dataset/table[-handle] parameters
- Has any of this implementation been touched by the recent waves of performance work in 3821c and 6129c, or are we ess...
- 03:26 PM Database Bug #6812: fix FastFindCache to use a shared instance per persistent database
- Boris, please look at the @FastFindCache@ implementation and ask any questions you may have as it pertains to this task.
- 03:19 PM Database Bug #6919: fix ErrorManager.displayError in TempTableBuilder
- Is there anything left to do on this task, or can we close it?
- 01:54 PM Base Language Feature #6426: implement ERROR-STATUS:CLEAR()
- True, though we will eventually be implementing a pure handle approach to everything. For example, I expect an @ERRO...
- 01:44 PM Base Language Feature #6426: implement ERROR-STATUS:CLEAR()
- In OE 11.6.3 this attribute is not part of the ERROR-STATUS handle.
OE does not do any compile-time strong-type ch... - 01:40 PM Base Language Feature #6426: implement ERROR-STATUS:CLEAR()
- I think it is 11.7.
Perhaps this is just broken code (at runtime) but it compiles. Or perhaps it is a newer (undo... - 11:28 AM Base Language Feature #6426: implement ERROR-STATUS:CLEAR()
- Greg, do you recall which OE version the customer's code was running?
- 10:45 AM Base Language Feature #6426 (WIP): implement ERROR-STATUS:CLEAR()
- I read a bit about the @error-status@ but I couldn't find anything online regarding @error-status:clear()@. I tried t...
- 09:34 AM Database Feature #7061: Enable the use of lazy result sets in H2
- Eric Faulhaber wrote:
> One clarification to this point. It is not so much the fact that the new lazy mode should be... - 09:11 AM Database Support #7058: get the FWD fork of the H2 code base under version control
- *UPDATE*: regression testing passed; merged 7062a_h2 to FWD-H2 trunk including support for direct access to internal ...
- 06:18 AM Database Support #7058: get the FWD fork of the H2 code base under version control
- Eric Faulhaber wrote:
> Alexandru, if there is any change to the build process, beyond just checking out the trunk F... - 09:07 AM Database Feature #7062 (Review): Direct access to H2 internals to solve basic queries
- Merged 7062a_h2 into trunk after adding support for some extra data-types from FWD (object as resourceId and decimal ...
- 08:31 AM Conversion Tools Feature #1757: update ANTLR to latest version
- Areas that will cause some problems in ANTLRv4:
* Actions in lexers have been removed except for at the end of the... - 07:48 AM Database Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns
- The tests from #7108-8 were done *without any patch applied*. I retested with the patch applied and there is no diffe...
- 07:36 AM Base Language Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection
- Constantin Asofiei wrote:
> Review for 7026/rev. 14495. In @NanoTimer@, @UnclosablePreparedStatement@, @ContextLoca... - 06:34 AM Base Language Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection
- Review for 7026/rev. 14495. In @NanoTimer@, @UnclosablePreparedStatement@, @ContextLocal@, please add history number...
- 06:08 AM Base Language Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection
- Constantin Asofiei wrote:
> Alexandru Lungu wrote:
> > Done!
> Great! Make sure to add history numbers to any chan... - 05:48 AM Base Language Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection
- Status of the #6819-37 issues:
* @ContextLocal.get()@ - 16.5mm calls, related to JMX, tested with the JMX timer remo... - 05:32 AM Base Language Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection
- Alexandru Lungu wrote:
> Done!
Great! Make sure to add history numbers to any changed file (just a reminder, histor... - 05:28 AM Base Language Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection
- Done!
- 05:16 AM Base Language Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection
- Alexandru, please create a patch to fix the ContextLocal.get ( the @Object[] res@) first. This is something we can s...
- 05:09 AM Base Language Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection
- Constantin Asofiei wrote:
> I'll look at the patch, but I don't think allocated a vararg is a good approach. I'll t... - 07:17 AM Base Language Feature #6421 (Test): finish GENERATE-RANDOM-KEY support
- 03:25 AM Base Language Feature #6421: finish GENERATE-RANDOM-KEY support
- > 1. Didn't you have other changes needed to make the error handling correct?
In the beginning I modified the meth... - 07:15 AM Base Language Bug #6399 (Closed): ENCRYPT/DECRYPT built-in function results different than 4GL when IV is short...
- 04:56 AM Base Language Bug #6399: ENCRYPT/DECRYPT built-in function results different than 4GL when IV is shorter than r...
- Thank you Igor for your help regarding the test. I modified it a bit and added it under @testcases/security/security_...
- 06:05 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Is there something I need to know about FWD RPC, threads and Conversation thread?
02/15/2023
- 03:01 PM Database Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns
- Alexandru Lungu wrote:
> Do you mean the case where the field is case-insensitive and the field is case-sensitive, b... - 09:04 AM Database Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns
- I found several mismatched between FWD and 4GL. All of the tests are done in the following manner:...
- 03:53 AM Database Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns
- Danut, please make a complete set of independent *4GL tests* for each of these cases - or *search the testcases proje...
- 03:28 AM Database Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns
- Ovidiu Maxiniuc wrote:
> The problem is I do not think forcing the character substitutions to be case-sensitive is t... - 02:21 PM Base Language Feature #6421: finish GENERATE-RANDOM-KEY support
- Greg Shah wrote:
> Igor: Please review.
The changes look good. - 01:45 PM Base Language Feature #6421: finish GENERATE-RANDOM-KEY support
- Code Review Task Branch 6421a Revision 14485
1. Didn't you have other changes needed to make the error handling co... - 01:44 PM Base Language Feature #6421 (Review): finish GENERATE-RANDOM-KEY support
- Igor: Please review.
- 10:42 AM Base Language Feature #6421: finish GENERATE-RANDOM-KEY support
- I have recreated the branch 6421a after the branch 6129c was merged to trunk and committed all changes. Please review...
- 01:54 PM Database Feature #7061: Enable the use of lazy result sets in H2
- Radu Apetrii wrote:
> I modified the patch from the last post a bit, because the change with the removal of @Prog... - 08:51 AM Database Feature #7061: Enable the use of lazy result sets in H2
- Update: I've committed a fix to 7061a_h2, rev. 12. *I no longer have issues when testing a large customer application...
- 01:03 PM Base Language Feature #7126: replace 'new unknown()' with 'unknown.INSTANCE' in FWD conversion and runtime
- Renamed @unknown.INSTANCE@ to @unknown.UNKNOWN@ in 7026a/14493.
- 08:47 AM Base Language Feature #7126: replace 'new unknown()' with 'unknown.INSTANCE' in FWD conversion and runtime
- Greg Shah wrote:
> How about if we add @import static com.goldencode.p2j.util.unknown.UNKNOWN;@ and then simply refe... - 08:44 AM Base Language Feature #7126: replace 'new unknown()' with 'unknown.INSTANCE' in FWD conversion and runtime
- Good idea. My only critique is that I want to find a different name than @unknown.INSTANCE@. I think this is a bit ...
- 08:11 AM Base Language Feature #7126: replace 'new unknown()' with 'unknown.INSTANCE' in FWD conversion and runtime
- In 7026a rev 14488, @new unknown()@ was replaced with @unknown.INSTANCE@ in parts of FWD runtime which showed up in p...
- 08:09 AM Base Language Feature #7126 (New): replace 'new unknown()' with 'unknown.INSTANCE' in FWD conversion and runtime
- 12:58 PM Database Support #7058: get the FWD fork of the H2 code base under version control
- Alexandru Lungu wrote:
> Once we have the pending branches merged into the FWD-H2 trunk, we will have a new build ... - 06:08 AM Database Support #7058: get the FWD fork of the H2 code base under version control
- For H2, Eric will push this when it is ready.
- 03:56 AM Database Support #7058: get the FWD fork of the H2 code base under version control
- *UPDATE*: regression testing passed; merged 6829a_h2 to FWD-H2 trunk including performance improvements regarding les...
- 12:01 PM Database Feature #7037: remove dirty share manager
- Guys, I want to commit the dirty sharing changes, but I want to know what dirty share state should be for the existin...
- 11:51 AM Base Language Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection
- Alexandru Lungu wrote:
> From the "statically extract lambda as class member" point of view...
My analysis seems to... - 11:46 AM Base Language Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection
- I've done a patch, but in a bit of a rush.
There are several complex JMX which need rethinking, as there are > 5 ... - 11:39 AM Base Language Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection
- Constantin Asofiei wrote:
> Now, after I looked again at the generated lambda code for this task, the lambdas are al... - 11:19 AM Base Language Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection
- Actually, the inlined lambda Eden space allocations is because of the @Object[] res = new Object[1];@ array. Alexand...
- 11:11 AM Base Language Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection
- I've tried this idea with something like this in @LambdaPerf@:...
- 10:15 AM Base Language Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection
- Greg, if Alexandru's idea is proven successful, then I think the bytecode can be changed from:...
- 09:08 AM Base Language Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection
- Alexandru Lungu wrote:
> Unless my times are due to a Java compilation optimization, cutting down the code altogethe... - 09:04 AM Base Language Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection
- I've run @LambdaPerf.java@ and I've got similar results. On my computer however, I get Lambda Call time (132.047478) ...
- 11:21 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- I'm stuck on a hurdle I have no clue about. The new network interface (sending logs from the client to the server) wo...
- 10:52 AM Database Feature #6444: dataset improvements
- Branch 6444a was rebased to the trunk rev. 14484.
Pushed up to revision 14493. - 09:13 AM Database Feature #6628: port PostgreSQL native user defined functions to MariaDB
- Error handler support for MariaDB committed to 6628a/14485
See also #6628-175.
Please review.
Thank you. - 08:24 AM Database Feature #6628: port PostgreSQL native user defined functions to MariaDB
- Created task branch 6628a from the trunk rev.14484
- 06:53 AM Database Feature #7062: Direct access to H2 internals to solve basic queries
- Alexandru Lungu wrote:
> I am planning to make some final changes to 7062a (javadoc and small performance changes), ... - 05:47 AM Base Language Feature #7122: convert default getter/setter as plain Java methods
- For default object property getter and setters, emit a plain Java method with a @return prop.duplicate();@ for a gett...
- 05:21 AM Base Language Bug #7089: sanitize p2j.oo method signature
- The current changes are in 7026a rev 14814.
- 04:46 AM Base Language Feature #6826: reduce the BDT usage in FWD runtime
- 7826a/14811 fixes other cases to reduce BDT usage from within FWD runtime.
- 04:17 AM Base Language Feature #6820: reduce String.toLowerCase and toUpperCase usage and String instances
- Committed to 7026a rev 14810.
- 03:59 AM Database Bug #6829 (Review): H2 forces re-parse of all prepared statements when metadata is changed
- Merged 6829a_h2 to FWD-H2 trunk including performance improvements regarding less recompiling of prepared statements ...
- 03:35 AM Database Bug #6829: H2 forces re-parse of all prepared statements when metadata is changed
- There are no problems with rev.11. I checked @psCache@ hit/miss with rev.6 and rev.11 and didn't get very different r...
- 03:58 AM Database Bug #7120 (Test): NO-UNDO dynamic temp-table does not set the NO-UNDO at the .schema
- Changes look good. Thanks.
02/14/2023
- 06:29 PM Database Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns
- Review of @ffCache-20230214.patch@.
Nice detective work. Indeed, there seems to be a key collision which causes th... - 06:18 AM Database Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns
- I've done some changes to how strings are compared in H2. I included a @rtrim@ parameter that, if set to true (by def...
- 04:08 PM Database Bug #7120 (WIP): NO-UNDO dynamic temp-table does not set the NO-UNDO at the .schema
- Good analysis!
Actually, the value of the @undo@ table attribute is not copied from the source table. It is by defau... - 07:00 AM Database Bug #7120: NO-UNDO dynamic temp-table does not set the NO-UNDO at the .schema
- This test:...
- 06:58 AM Database Bug #7120 (Test): NO-UNDO dynamic temp-table does not set the NO-UNDO at the .schema
- 02:22 PM Base Language Feature #7122 (WIP): convert default getter/setter as plain Java methods
- 09:35 AM Base Language Feature #7122: convert default getter/setter as plain Java methods
- I don't see any reason to have the @BlockManager.function/procedure@ wrappers for default scalar getter/setter Java m...
- 09:34 AM Base Language Feature #7122 (WIP): convert default getter/setter as plain Java methods
- 12:29 PM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- The problem with the new interface was missing directory.xml configs. Fixed.
- 12:28 PM Database Feature #6628: port PostgreSQL native user defined functions to MariaDB
- Igor Skornyakov wrote:
> Finished with error Handler support for MariaDB.
> Because of #7113 it was tested with a s... - 09:59 AM Base Language Bug #6399: ENCRYPT/DECRYPT built-in function results different than 4GL when IV is shorter than r...
- I've used the attached program for testing cryptography.
May be it can be useful. - 08:57 AM Base Language Bug #6399: ENCRYPT/DECRYPT built-in function results different than 4GL when IV is shorter than r...
- I'm OK with closing this task. Before we do that, please do/consider the following:
* Gather all of your various ... - 08:38 AM Base Language Bug #6399: ENCRYPT/DECRYPT built-in function results different than 4GL when IV is shorter than r...
- I tried many combinations with @AES_CBC_256@. Some of them can be found below. I keep getting identical results with ...
- 08:12 AM Database Bug #6829: H2 forces re-parse of all prepared statements when metadata is changed
- Dănuț Filimon wrote:
> Committed 6829a_h2/rev.7. Stopped forced re-parsing for prepared statements.
>
> Each SELE... - 07:10 AM Database Support #7058: get the FWD fork of the H2 code base under version control
- Will pre-built FWD-H2 revisions jars be uploaded into GCD repository ?
- 07:00 AM Database Support #7058: get the FWD fork of the H2 code base under version control
- *UPDATE*: regression testing passed; merged 6928a_h2 to FWD-H2 trunk including performance improvements for UPDATE st...
- 07:01 AM Database Feature #6928 (Test): H2 UPDATE performance improvement
- Merged 6928a_h2 to FWD-H2 trunk including performance improvements for UPDATE statement, with in-memory and PageStore...
- 06:52 AM Database Feature #6928: H2 UPDATE performance improvement
- Thanks, the change is OK. It can be merged to trunk.
- 06:26 AM Database Feature #6928: H2 UPDATE performance improvement
- Constantin Asofiei wrote:
> Was the branch bound? I don't see rev 11 for 6928a_h2.
What a quick response! My bzr ... - 06:23 AM Database Feature #6928: H2 UPDATE performance improvement
- Alexandru Lungu wrote:
> Tested 6928a_h2/rev. 10 and found a regression: the old-row stored by @deltaChangeCollector... - 06:20 AM Database Feature #6928: H2 UPDATE performance improvement
- Tested 6928a_h2/rev. 10 and found a regression: the old-row stored by @deltaChangeCollector@ inside the H2 update sta...
- 06:48 AM Database Feature #7061: Enable the use of lazy result sets in H2
- I've added the option to execute queries in a lazy manner. Alongside this change, @AdaptiveQuery@ now uses only @Scro...
- 01:22 AM Database Bug #7113: Problem with nested CAN-FIND conversion
- Ovidiu Maxiniuc wrote:
> The nested CAN-FIND is an old issue. There were some fixes in time (see #3040, #3465, #3771... - 09:22 PM Database Feature #7037: remove dirty share manager
- Review of @7037b.diff@.
A clean implementation. Nice job. The patch should work as described in note #7037-35.
Pl...
02/13/2023
- 06:17 PM Database Feature #6371: implement SAVE CACHE statement
- Attaching a working version of sequences support in @SchemaCheck@ and @SchemaValidator@ for review.
- 05:20 PM Database Bug #7113: Problem with nested CAN-FIND conversion
- The nested CAN-FIND is an old issue. There were some fixes in time (see #3040, #3465, #3771, and others) and the issu...
- 09:13 AM Database Bug #7113 (WIP): Problem with nested CAN-FIND conversion
- 05:19 AM Database Bug #7113: Problem with nested CAN-FIND conversion
- Thank you for checking, you can continue with your normal tasks.
- 05:03 AM Database Bug #7113: Problem with nested CAN-FIND conversion
- Igor Skornyakov wrote:
> Constantin Asofiei wrote:
> > One more thing: is this a regression in 6129c compared to tr... - 05:02 AM Database Bug #7113: Problem with nested CAN-FIND conversion
- Constantin Asofiei wrote:
> One more thing: is this a regression in 6129c compared to trunk?
No, I get the same e... - 04:54 AM Database Bug #7113: Problem with nested CAN-FIND conversion
- One more thing: is this a regression in 6129c compared to trunk?
- 04:52 AM Database Bug #7113: Problem with nested CAN-FIND conversion
- Constantin Asofiei wrote:
> So instead of @?@ it should be @Order.OrderNum@ and @OrderLine.ItemNum@, respectively? I... - 04:25 AM Database Bug #7113: Problem with nested CAN-FIND conversion
- Igor Skornyakov wrote:
> Constantin Asofiei wrote:
> > What's the problem with the query? What would be the correct... - 04:23 AM Database Bug #7113: Problem with nested CAN-FIND conversion
- Constantin Asofiei wrote:
> What's the problem with the query? What would be the correct variant? If you change the ... - 04:16 AM Database Bug #7113: Problem with nested CAN-FIND conversion
- What's the problem with the query? What would be the correct variant? If you change the FQL manually to the correct v...
- 03:02 AM Database Bug #7113: Problem with nested CAN-FIND conversion
- The problem is at the program conversion (not only runtime).
The query from the previous noye is converted to... - 02:26 PM Base Language Bug #6399: ENCRYPT/DECRYPT built-in function results different than 4GL when IV is shorter than r...
- As far as I rememeber after the Constantin's fix we are 100% binary compatible with 4GL with respect to the encryptio...
- 02:21 PM Base Language Bug #6399: ENCRYPT/DECRYPT built-in function results different than 4GL when IV is shorter than r...
- From #5915-40:
>The problem is with @generate-pbe-key@, where @AES_CBC_256@ is used for this key (32 length). There... - 01:45 PM Base Language Bug #6399: ENCRYPT/DECRYPT built-in function results different than 4GL when IV is shorter than r...
- I have read some existing tests under @testcases/security/security_policy@ and I tried to understand them. I tried ma...
- 10:48 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- I need assistance with FWD RPC. I'm trying to use a new interface for clients to send data to the server, but the cal...
- 08:13 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- I'm currently working on a new logger class that encapsulates the previously used Java Logger and handles a lot of th...
- 09:28 AM Base Language Feature #6820: reduce String.toLowerCase and toUpperCase usage and String instances
- Hynek Cihlar wrote:
> And some cleanup:
Great, I'll test this and include it in my larger changes. - 09:12 AM Base Language Feature #6820: reduce String.toLowerCase and toUpperCase usage and String instances
- And some cleanup:...
- 09:09 AM Base Language Feature #6820: reduce String.toLowerCase and toUpperCase usage and String instances
- Constantin Asofiei wrote:
> Hynek, what times do you get for @StringHelper.hashCodeCaseInsensitive@ test? Please te... - 08:52 AM Base Language Feature #6820: reduce String.toLowerCase and toUpperCase usage and String instances
- Hynek, what times do you get for @StringHelper.hashCodeCaseInsensitive@ test? Please test what happens if you use so...
- 09:14 AM Database Feature #6628: port PostgreSQL native user defined functions to MariaDB
- Greg Shah wrote:
> > Because of #7113 it was tested with a simple test only
>
> Go ahead and fix this now.
OK... - 08:48 AM Database Feature #6628: port PostgreSQL native user defined functions to MariaDB
- > Because of #7113 it was tested with a simple test only
Go ahead and fix this now. - 08:42 AM Base Language Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection
- Greg Shah wrote:
> How many JMX instrumentation locations are there? I'd like to run some non-trivial application c... - 08:39 AM Base Language Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection
- Try attached testcase in command-line. On devsrv01, the times are these:...
- 08:17 AM Base Language Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection
- How many JMX instrumentation locations are there? I'd like to run some non-trivial application code with and without...
- 08:06 AM Base Language Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection
- Greg Shah wrote:
> > I think we need to add a JVM flag to enable or disable the JMX code, so for production mode it ... - 08:04 AM Base Language Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection
- > I think we need to add a JVM flag to enable or disable the JMX code, so for production mode it will go via the dire...
02/12/2023
- 11:03 AM Database Feature #6628 (Review): port PostgreSQL native user defined functions to MariaDB
- 11:03 AM Database Feature #6628: port PostgreSQL native user defined functions to MariaDB
- Finished with error Handler support for MariaDB.
Because of #7113 it was tested with a simple test only
Please rev... - 07:45 AM Database Feature #6628: port PostgreSQL native user defined functions to MariaDB
- Igor Skornyakov wrote:
> I've encoutered a weird problem with MariaDB that makes the error handling based on @initEr... - 07:01 AM Database Feature #6628: port PostgreSQL native user defined functions to MariaDB
- I've encoutered a weird problem with MariaDB that makes the error handling based on @initError@/@checkError@ impossib...
- 04:25 AM Database Bug #7113: Problem with nested CAN-FIND conversion
- Consider the following statement:...
- 04:18 AM Database Bug #7113 (Review): Problem with nested CAN-FIND conversion
- 03:14 AM Base Language Feature #6819: refactor FWD proxy implementation to use ReflectASM instead of Java Method reflection
- I've did more testing and profiling of lambda calls. Even a simple lambda call as we have in @ContextLocal.get(boole...
02/11/2023
- 10:59 AM Database Feature #6928: H2 UPDATE performance improvement
- Rebased 6928a_h2 rev 8 from fwd-h2.trunk rev 8 - new rev 10.
- 09:38 PM Database Feature #6628: port PostgreSQL native user defined functions to MariaDB
- I tried using the call stack you provided but it seems different from 6129c/14808. The code at @FqlToSqlConverter.jav...
02/10/2023
- 12:54 PM Base Language Feature #4065: server-side processing of client platform dependencies
- > With respect to the anticipated use cases does it make sense to replace these with the managed file system resource...
- 11:39 AM Base Language Feature #4065: server-side processing of client platform dependencies
- Greg, I found several places in the client UI where file IO is performed directly. An example is a button widget load...
- 10:56 AM Database Feature #6628: port PostgreSQL native user defined functions to MariaDB
- I've experienced problem with CAN-FIND (6129c/14808).
When creating the query from the attached test I get the follo... - 09:54 AM Database Feature #7062: Direct access to H2 internals to solve basic queries
- I committed 7062a_h2/rev. 9 the changes to H2 to allow direct access.
There is a patch here on the changes required ... - 08:22 AM Database Feature #7062: Direct access to H2 internals to solve basic queries
- I've redone the tests with direct access:
* Computed columns are now marked as invisible in H2.
* Before returning ... - 09:34 AM Conversion Tools Feature #3883: eclipse plug for developing 4GL code using FWD including editing, syntax checks, r...
- See #1757-9 for some analysis of how auto-completion may require a move to ANTLRv4.
- 09:34 AM Conversion Tools Feature #6319: IntelliJ plugin
- See #1757-9 for some analysis of how auto-completion may require a move to ANTLRv4.
- 09:33 AM Conversion Tools Feature #1757: update ANTLR to latest version
- Our IDE support will need features such as auto-completion and syntax checking. These features are not suited to bat...
- 05:08 AM Database Feature #7037: remove dirty share manager
- Ovidiu: Please review.
02/09/2023
- 01:49 PM Base Language Feature #4065: server-side processing of client platform dependencies
- Hynek Cihlar wrote:
> Greg, do we want to interpolate the file paths with a set of known variables? Like logged in u... - 01:06 PM Base Language Feature #4065: server-side processing of client platform dependencies
- Greg, do we want to interpolate the file paths with a set of known variables? Like logged in user, application name, ...
- 11:19 AM Base Language Feature #4065: server-side processing of client platform dependencies
- Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > I created task branch 4065a based on trunk revision 14477.
> F... - 11:16 AM Base Language Feature #4065: server-side processing of client platform dependencies
- Hynek Cihlar wrote:
> I created task branch 4065a based on trunk revision 14477.
FYI, trunk is on rev 14483. - 10:20 AM Base Language Feature #4065: server-side processing of client platform dependencies
- > > > Should we pursue some kind of EXECUTE permissions on the OS-COMMAND statement?
> >
> > It is a really good i... - 10:11 AM Base Language Feature #4065: server-side processing of client platform dependencies
- Greg Shah wrote:
> > Should we pursue some kind of EXECUTE permissions on the OS-COMMAND statement?
>
> It is a r... - 09:49 AM Base Language Feature #4065: server-side processing of client platform dependencies
- I think you can add this @EXECUTE@ extra bit into the @BitFlagsResource@ directory.
- 09:48 AM Base Language Feature #4065: server-side processing of client platform dependencies
- > Except I think we should implicitly deny access when no permission rule is matched.
Agreed. We always should a... - 08:55 AM Base Language Feature #4065: server-side processing of client platform dependencies
- Hynek Cihlar wrote:
> Also we should introduce the EXECUTE permission.
I will rephrase this to a question. Shoul... - 08:49 AM Base Language Feature #4065: server-side processing of client platform dependencies
- Greg Shah wrote:
> > The actual file-system security model will be based on the Linux file-system security model.
>... - 08:32 AM Base Language Feature #4065: server-side processing of client platform dependencies
- > Current FWD security model doesn't have primitives for file-system resources, this will have to be extended.
> The... - 08:04 AM Base Language Feature #4065: server-side processing of client platform dependencies
- I created task branch 4065a based on trunk revision 14477.
- 07:34 AM Base Language Feature #4065: server-side processing of client platform dependencies
- I'm currently working on the file-system server-side processing. Here are a few notables:
* Current FWD security m... - 12:53 PM Database Bug #7108: Simulate upper/rtrim directly in H2 using case specific columns
- Please test how the right-padding spaces are handled. An important element in the expressions above is the @rtrim@ fu...
- 10:49 AM Database Bug #7108 (WIP): Simulate upper/rtrim directly in H2 using case specific columns
- Consider supporting case specific operators directly in H2 for character fields. For case-insensitive character field...
- 10:42 AM Database Bug #7108 (Closed): Simulate upper/rtrim directly in H2 using case specific columns
- 12:38 PM Conversion Tools Bug #6627 (Review): improve conversion memory footprint for AstKey persistent maps
- In #7079, customer reported again this issue and a more stable recreate could be found. 6129b/14391 fixes performanc...
- 10:54 AM Database Feature #6995 (Review): possibly support NO-UNDO temporary tables directly in H2
- Rebased from trunk and merged 6995a_h2 to FWD-H2 trunk: includes the addition of a NO-UNDO keyword being natively sup...
- 10:53 AM Database Support #7058: get the FWD fork of the H2 code base under version control
- *UPDATE*: regression testing passed; merged 6995a_h2 to FWD-H2 trunk including the addition of a NO-UNDO keyword bein...
- 10:42 AM Database Feature #7062: Direct access to H2 internals to solve basic queries
- Alexandru Lungu wrote:
> > In the absence of a SQL option to SELECT * EXCEPT __ifield1, __sfield2 FROM... I think we... - 09:55 AM Base Language Feature #6421 (Feedback): finish GENERATE-RANDOM-KEY support
- 04:01 AM Base Language Feature #6421: finish GENERATE-RANDOM-KEY support
- > Did you add the unknown value test code?
I added this:... - 09:54 AM Base Language Bug #6399 (WIP): ENCRYPT/DECRYPT built-in function results different than 4GL when IV is shorter ...
- 06:55 AM Database Bug #7035: Extract query parameters from statically converted FQL
- Alexandru Lungu wrote:
> I get a NPE in com.goldencode.p2j.persist.ParameterDiff.getSubstParameters(ParameterDiff.ja...
02/08/2023
- 02:08 PM Base Language Bug #7089 (WIP): sanitize p2j.oo method signature
- I have the changes to solve the signature inconsistencies in @p2j.oo@, but I'll wait to create a branch after 6129c i...
- 02:01 PM Base Language Feature #6818 (WIP): analyze the performance of the FWD open client proxy client support
- I have changes force "schema marshall" to NONE in case of TABLE/DATASET parameters (although I need somehow to force ...
- 01:06 PM Base Language Feature #6421: finish GENERATE-RANDOM-KEY support
- Yes. At this time we don't branch testcases, so we have no trunk concept there. Instead of saying pushing to trunk ...
- 12:33 PM Base Language Feature #6421: finish GENERATE-RANDOM-KEY support
- > > @sed ...@
>
> These changes should actually be the default in Hotel GUI. Please make the edits and commit the... - 10:56 AM Database Bug #6829: H2 forces re-parse of all prepared statements when metadata is changed
- Eric Faulhaber wrote:
> Has anyone who has looked inside H2 gotten a sense of how that cache interacts with our prep... - 10:09 AM Database Bug #6829: H2 forces re-parse of all prepared statements when metadata is changed
- Dănuț Filimon wrote:
> Committed 6829a_h2/rev.7. Stopped forced re-parsing for prepared statements.
>
> Each SELE... - 09:46 AM Database Feature #6995: possibly support NO-UNDO temporary tables directly in H2
- Alexandru Lungu wrote:
> Radu, please redo the FWD patch considering my first comment in #6995-16 regarding @getCrea... - 03:41 AM Database Feature #6995: possibly support NO-UNDO temporary tables directly in H2
- Code review @6995-6129b.patch@ and @fwd-h2-6995.patch@:
Nice work, Radu!
I agree with Alexandru's comments in #... - 08:48 AM Database Support #7058: get the FWD fork of the H2 code base under version control
- Alexandru Lungu wrote:
> I am planning to merge 7046_h2 to the FWD-H2 trunk after handling #7085-3 (test suite segre... - 04:00 AM Database Bug #6837: prevent unnecessary upper/rtrim injection in queries if the data type doesn't require it
- Ovidiu Maxiniuc wrote:
> Unless this can be configured somewhere else. Or if there is another data type for this?
...
02/07/2023
- 11:51 AM Base Language Feature #6421: finish GENERATE-RANDOM-KEY support
- > @rm -rf ~/projects/hotel_gui/abl/*@
I think you should not do this, in general. Try @ant clean.all@ instead.
... - 10:33 AM Base Language Feature #6421: finish GENERATE-RANDOM-KEY support
- I need help running the test with FWD. I tried some things but it didn't work. My project tree is:...
- 08:04 AM Base Language Feature #6421: finish GENERATE-RANDOM-KEY support
- No, I am referring to the Progress 4GL concept of unknown value (which can be represented with the literal constant @...
- 02:33 AM Base Language Feature #6421: finish GENERATE-RANDOM-KEY support
- By unknown value, you mean non-ASCII characters? I wasn't able to run the test with FWD yet. I will try to run it tod...
- 08:31 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- > Client and server are different processes
This is only because of how we implement in FWD. The equivalent syste... - 06:11 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Back to question 1: clients are separate processes started with different process ids and user ids - do we want their...
- 03:02 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Greg Shah wrote:
> 2. In regard to "File names are not configurable to make file identification and sorting easier, ... - 02:49 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Greg Shah wrote:
> 1. I don't think we want a separate client and server logging infrastructure. The fact that we h... - 06:44 AM Database Bug #6829: H2 forces re-parse of all prepared statements when metadata is changed
- Committed 6829a_h2/rev.7. Stopped forced re-parsing for prepared statements.
Each SELECT/DELETE/UPDATE/INSERT quer... - 06:34 AM Database Feature #6995: possibly support NO-UNDO temporary tables directly in H2
- Radu, please redo the FWD patch considering my first comment in #6995-16 regarding @getCreateTemporaryTablePostfix@ o...
- 06:33 AM Database Support #7058: get the FWD fork of the H2 code base under version control
- I am planning to merge 7046_h2 to the FWD-H2 trunk after handling #7085-3 (test suite segregation). There are still s...
02/06/2023
- 06:45 PM Database Feature #7037: remove dirty share manager
- Please review the diff (for the trunk 14478) which adds the following directory configuration parameters:
# In addit... - 04:46 PM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Galya Bogdanova wrote:
> Please review my proposal for standardization of the logging: [[internal-documentation:Logs... - 07:37 AM Runtime Infrastructure Bug #5703: rationalize, standardize and simplify the client-side log file name configuration
- Please review my proposal for standardization of the logging: [[internal-documentation:Logs#Future-Improvements|Logs#...
- 03:50 PM Database Feature #6371: implement SAVE CACHE statement
- Boris Schegolev wrote:
> Currently, my best option is adding SQLs to retrieve sequence information into individual... - 02:50 PM Database Feature #6371: implement SAVE CACHE statement
- I am working on support for sequences in @SchemaCheck@ for use in validations and I wanted to have a confirmation tha...
- 09:56 AM Base Language Feature #6421: finish GENERATE-RANDOM-KEY support
- I think it is good. Just add a test for unknown value. You can't do that one with a preprocessor define, so just ha...
- 09:30 AM Base Language Feature #6421: finish GENERATE-RANDOM-KEY support
- Please review the following test. The rest was developed and run on the AWS VM. I also included encryption/decryption...
- 04:43 AM Database Feature #7062: Direct access to H2 internals to solve basic queries
- > Actually the prefixes for the computed columns in H2 dialect are __i and __s (for i gnore casing and case- s ensiti...
02/04/2023
- 07:32 PM Database Feature #7062: Direct access to H2 internals to solve basic queries
- Eric Faulhaber wrote:
> Ultimately, we create the SQL forms of the column names. So, we can use whatever we want as ...
02/03/2023
- 06:53 PM Database Bug #6837: prevent unnecessary upper/rtrim injection in queries if the data type doesn't require it
- Thank you. I tried it now and it worked. I was able to create a table and execute a quick select statement over a cou...
- 06:17 PM Database Bug #6837: prevent unnecessary upper/rtrim injection in queries if the data type doesn't require it
- I'm pretty sure @citext@ existed as an extension before PostgreSQL 11. I thought it was one of the core data types af...
- 05:25 PM Database Bug #6837: prevent unnecessary upper/rtrim injection in queries if the data type doesn't require it
- The changes are necessary only if/when we decide to switch from case-sensitive character data types to case-insensiti...
- 10:51 AM Database Bug #6837: prevent unnecessary upper/rtrim injection in queries if the data type doesn't require it
- It seems like note 11 is suggesting some changes to encode the logic in the dialects and fix the DDL generation.
- 10:49 AM Database Bug #6837: prevent unnecessary upper/rtrim injection in queries if the data type doesn't require it
- It sounds like this task can be closed, then, correct?
- 05:17 PM Database Feature #7062: Direct access to H2 internals to solve basic queries
- Ultimately, we create the SQL forms of the column names. So, we can use whatever we want as an identifier, if we find...
- 04:20 PM Database Feature #7062: Direct access to H2 internals to solve basic queries
- Actually the prefixes for the computed columns in H2 dialect are @__i@ and @__s@ (for *i* gnore casing and case- *s* ...
- 10:34 AM Database Feature #7062: Direct access to H2 internals to solve basic queries
- I extended my solution to cover all unique indexes. Most of the processing is done in @FQLPreprocessor@ to identify w...
- 10:50 AM Database Feature #6348: implement support for MariaDB
- Ovidiu Maxiniuc wrote:
> Committed revision 14396 / 6129b.
The change looks good. Can we close this task? - 08:35 AM Runtime Infrastructure Bug #5703 (WIP): rationalize, standardize and simplify the client-side log file name configuration
- I'm trying to figure out what is part of our OpenEdge replica implementation and what is our invention.
* @outputT...
02/02/2023
- 03:47 PM Database Feature #7062: Direct access to H2 internals to solve basic queries
- Greg Shah wrote:
> You're saying that in the 4GL these have separate @recid@ values when a temp-table is passed as a... - 11:56 AM Database Feature #7062: Direct access to H2 internals to solve basic queries
- Alexandru Lungu wrote:
> I may have misinterpreted FWD's behavior. I have seen multiple fields like "some_field" a... - 11:46 AM Database Feature #7062: Direct access to H2 internals to solve basic queries
- Greg Shah wrote:
> > I only consider tables without computed-columns (date-time, extent or case-insensitive char fie... - 09:54 AM Database Feature #7062: Direct access to H2 internals to solve basic queries
- > I only consider tables without computed-columns (date-time, extent or case-insensitive char fields)
In regard to... - 05:51 AM Database Feature #7062: Direct access to H2 internals to solve basic queries
- > Please also consider #6720; I don't yet know if lazy hydration should be applied to H2 embedded databases. I have t...
- 03:26 PM Database Feature #7037: remove dirty share manager
- Stanislav Lomany wrote:
> FYI I've found @uast/shared-dirty-records/p*.p@ and @uast/shared-dirty-records/leaking*.p@... - 03:24 PM Database Feature #7037: remove dirty share manager
- FYI I've found @uast/shared-dirty-records/p*.p@ and @uast/shared-dirty-records/leaking*.p@ testcases which "demonstra...
- 01:18 PM Database Feature #6371: implement SAVE CACHE statement
- Boris Schegolev wrote:
> Branch 6129b is frozen for now, so, let's take a look at what we know was not implemented b... - 08:27 AM Database Feature #6371: implement SAVE CACHE statement
- > EXTENT support (currently, expanded mode only...
I think we only need expanded mode support. The old "denormali... - 12:05 PM Runtime Infrastructure Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...
- At this point, we need to pause because of the freeze on trunk. We will rebase and merge when the "thaw" occurs.
- 12:05 PM Runtime Infrastructure Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...
- Code Review Task Branch 5701a Revisions 14485 and 14486
The changes are good. - 04:18 AM Runtime Infrastructure Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...
- Thank you for the explanation. Actually I was able to figure out the first part by reading the documentation for the ...
- 11:15 AM Base Language Feature #6421: finish GENERATE-RANDOM-KEY support
- Theodoros Theodorou wrote:
> Is this test below a good test? Should I store it at @testcases/security/security-polic... - 11:10 AM Base Language Feature #6421: finish GENERATE-RANDOM-KEY support
- Do you have test code for the error cases that I mentioned in #6421-16?
In your testcase #6421-21, you should avoi... - 10:41 AM Base Language Feature #6421: finish GENERATE-RANDOM-KEY support
- Hello Igor and thank you for your review.
I replaced @getAlgKeyLen()@ with @SecurityPlicyManager.getSymmetricCiper... - 09:58 AM Base Language Feature #6410: implement additional built-in OO classes/interfaces
- > we can then keep OE11.7 as main target and OE12.2 'extensions/fixes' are only nice to have?
Correct. If there a... - 09:41 AM Base Language Feature #6410: implement additional built-in OO classes/interfaces
- Greg Shah wrote:
> I prefer not to have different FWD branches for different OE versions.
Understood, then only... - 09:25 AM Base Language Feature #6410: implement additional built-in OO classes/interfaces
- 11.7 and 12.2 is fine.
> Now, this only has effect at compile time - for FWD will be when the conversion is execut... - 03:12 AM Base Language Feature #6410: implement additional built-in OO classes/interfaces
- Greg Shah wrote:
> Yes, please use @PROVERSION@ and preprocessing to conditionally implement logic by OE version.
... - 06:40 AM Database Bug #7088: Lazily initialize activeBundle inside RandomAccessQuery
- I've done a slim test with ~40,000 find queries. ~13.000 of them used @ffCache@. The total time spent on activation w...
02/01/2023
- 06:11 PM Database Feature #6371: implement SAVE CACHE statement
- Branch 6129b is frozen for now, so, let's take a look at what we know was not implemented by now:
* more validatio... - 04:28 PM Database Feature #6348: implement support for MariaDB
- The update I was talking in #6348-54 was committed the next day in revision 14308 (see @MariaDbSequenceHandler.java@)...
- 02:34 PM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
- Does @SourceNameMapper.convertName()@ often get called with the same @legacyProgName@ and @lookup@ function? If so, ...
- 02:34 PM Base Language Feature #6649: improve the performance or SourceNameMapper runtime
- Code Review Task Branch 6129b Revision 14394
The changes look good. - 01:29 PM Database Feature #7062: Direct access to H2 internals to solve basic queries
- > A copy in a separate logical or physical temp-table should have a distinct primary key (recid) value. This is the i...
- 01:26 PM Database Feature #7062: Direct access to H2 internals to solve basic queries
- Eric Faulhaber wrote:
> Alexandru, one other thing to consider, which I suppose you've already noticed: we don't act... - 01:25 PM Database Feature #7062: Direct access to H2 internals to solve basic queries
- Greg Shah wrote:
> > I empirically discovered that (recid) is always the primary key of our temp-tables in H2; multi... - 01:15 PM Database Feature #7062: Direct access to H2 internals to solve basic queries
- Alexandru, one other thing to consider, which I suppose you've already noticed: we don't actually create unique indic...
- 01:09 PM Database Feature #7062: Direct access to H2 internals to solve basic queries
- > I empirically discovered that (recid) is always the primary key of our temp-tables in H2; multiplex is irrelevant. ...
- 12:54 PM Database Feature #7062: Direct access to H2 internals to solve basic queries
- Alexandru Lungu wrote:
> I've finished implementing a simple mean of H2 direct access for @RAQ@ with simple @recid@ ... - 10:54 AM Database Feature #7062: Direct access to H2 internals to solve basic queries
- I've finished implementing a simple mean of H2 direct access for @RAQ@ with simple @recid@ look-up. The results are f...
- 01:26 PM Base Language Feature #6421: finish GENERATE-RANDOM-KEY support
- Theodoros Theodorou wrote:
> I read the encryption algorithm by using @SecurityPolicyManager.getSymmetricEncryptionA... - 12:55 PM Base Language Feature #6421: finish GENERATE-RANDOM-KEY support
- Greg Shah wrote:
> The original code in @SecurityOps.generateRandomKey()@ was forced to @AES_CBC_128@. Take a look... - 12:47 PM Base Language Feature #6421: finish GENERATE-RANDOM-KEY support
- The original code in @SecurityOps.generateRandomKey()@ was forced to @AES_CBC_128@. Take a look at trunk.
- 12:45 PM Base Language Feature #6421: finish GENERATE-RANDOM-KEY support
- Greg Shah wrote:
> Igor: Please review.
Sorry, I do not understand. As far as I remember and can see from the cod... - 12:26 PM Base Language Feature #6421: finish GENERATE-RANDOM-KEY support
- > Do I need to checkout 6421a from the testcases project or use the main branch?
I'm not exactly sure what you are... - 08:45 AM Base Language Feature #6421: finish GENERATE-RANDOM-KEY support
- Do I need to checkout 6421a from the testcases project or use the main branch?
Then I should include my @test-genr... - 01:00 PM Database Bug #7088: Lazily initialize activeBundle inside RandomAccessQuery
- This makes sense. Although the cost currently is mitigated to some degree by caching in @FQLHelper@, there is still w...
- 04:23 AM Database Bug #7088: Lazily initialize activeBundle inside RandomAccessQuery
- There is relevant activity when building an @activeBundle@ in general, mostly related to FQL composition (@createBund...
- 04:09 AM Database Bug #7088 (New): Lazily initialize activeBundle inside RandomAccessQuery
- 11:40 AM Runtime Infrastructure Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...
- Lets consider this code from @spawn.c@:...
- 10:17 AM Runtime Infrastructure Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...
- Galya Bogdanova wrote:
> Eugenie Lyzenko wrote:
> > Yes, I did. @src/native/spawn.c@ has neither history nor year u... - 09:43 AM Runtime Infrastructure Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...
- Eugenie Lyzenko wrote:
> Yes, I did. @src/native/spawn.c@ has neither history nor year update. @src/native/winspawn.... - 09:25 AM Runtime Infrastructure Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...
- Galya Bogdanova wrote:
> Eugenie Lyzenko wrote:
> > When you add new history entry with date (@2023MMDD@), and you ... - 06:04 AM Runtime Infrastructure Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...
- Eugenie Lyzenko wrote:
> When you add new history entry with date (@2023MMDD@), and you should mark your change the ... - 06:01 AM Runtime Infrastructure Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...
- Galya Bogdanova wrote:
> Eugenie Lyzenko wrote:
> > I have no objections, in addition to history entries it is requ... - 03:02 AM Runtime Infrastructure Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...
- Eugenie Lyzenko wrote:
> I have no objections, in addition to history entries it is required to change Year to @2023... - 02:43 AM Runtime Infrastructure Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...
- Greg Shah wrote:
> Code Review Task Branch 5701a Revisions 14484 and 14485
>
> 1. In @spawn.c:launchP2JClient@, t... - 10:11 AM Database Feature #6444: dataset improvements
- Rebased task branch 6444a to the trunk rev.14483.
Suspended working on this task while the trunk and 6129b are frozen. - 09:49 AM Database Feature #6995: possibly support NO-UNDO temporary tables directly in H2
- Eric Faulhaber wrote:
> I have not yet reviewed the changes in detail, but my opinion is that removing all SQL redo ... - 09:40 AM Database Support #7058: get the FWD fork of the H2 code base under version control
- Greg Shah wrote:
> See if you can just do some limited edits to Source Code Management to explain branching for FWD ... - 09:39 AM Base Language Bug #7089: sanitize p2j.oo method signature
- In incremental conversion, it was found that a @RequestBuilder.put@ method's LegacySignature was inconsistent with th...
- 09:27 AM Base Language Bug #7089 (WIP): sanitize p2j.oo method signature
- 09:38 AM Database Bug #7035: Extract query parameters from statically converted FQL
- *Review for patch #7035-9*
There is consistent work going on with this extraction and I am pleased with this new @Pa... - 04:23 AM Database Bug #7035: Extract query parameters from statically converted FQL
- Eric Faulhaber wrote:
> Please add a test with such an extent field reference, and make sure it still works, both in... - 08:52 AM Base Language Feature #6410 (WIP): implement additional built-in OO classes/interfaces
01/31/2023
- 05:11 PM Database Feature #6348: implement support for MariaDB
- Ovidiu, are all the sequence features working now? Based on #6348-54 and the entries leading up to it, it seemed this...
- 04:12 PM Database Feature #6348: implement support for MariaDB
- Committed revision 14396 / 6129b.
- 01:35 AM Database Feature #6348: implement support for MariaDB
- Ovidiu Maxiniuc wrote:
> ... there are a few methods which still use @UnimplementedFeature@ to report missing featur... - 04:46 PM Runtime Infrastructure Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...
- Greg Shah wrote:
> Eugenie: Please review branch 5701a.
I have no objections, in addition to history entries it i... - 03:54 PM Runtime Infrastructure Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...
- Eugenie: Please review branch 5701a.
- 03:53 PM Runtime Infrastructure Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...
- Code Review Task Branch 5701a Revisions 14484 and 14485
1. In @spawn.c:launchP2JClient@, the @memset(arguments[len... - 04:47 AM Runtime Infrastructure Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...
- I've tested both Linux and Windows spawner. Here are the final changes in the .diff file, also committed to @5701a@.
... - 03:56 AM Runtime Infrastructure Bug #5701: logfile names for -O outputToFile use the spawner pid instead of the Java (FWD client ...
- Constantin Asofiei wrote:
> Galya, please describe how you are running a program on the appserver. A batch program ... - 03:59 PM Database Bug #6837: prevent unnecessary upper/rtrim injection in queries if the data type doesn't require it
- The current implementation injects the upper/rtrim into FQLs of the queries at conversion time because it assumes at ...
- 01:59 AM Database Bug #6837: prevent unnecessary upper/rtrim injection in queries if the data type doesn't require it
- What is left to do on the MariaDB side for:
* lenient mode?
* strict mode? - 03:55 PM Database Feature #6371: implement SAVE CACHE statement
- I pushed revision 6129b/14395 with comment cleaning procedure and some JavaDoc that was missing.
- 02:13 AM Database Feature #6371: implement SAVE CACHE statement
- Boris, please continue implementing the remaining items in #6371-119.
I've also noticed in the code that the colum... - 11:25 AM Database Feature #6995: possibly support NO-UNDO temporary tables directly in H2
- I have not yet reviewed the changes in detail, but my opinion is that removing all SQL redo code from FWD is OK as lo...
- 08:59 AM Database Feature #6995: possibly support NO-UNDO temporary tables directly in H2
- > I am not necessarily sensitive with huge chunks of code being removed (less is faster), but should we keep some of ...
- 08:36 AM Database Feature #6995: possibly support NO-UNDO temporary tables directly in H2
- Eric, I added you as a watcher now.
- 08:27 AM Database Feature #6995: possibly support NO-UNDO temporary tables directly in H2
- I tested 6995a_h2 with your FWD patch against a large customer application and there was no regression.
The performa... - 05:06 AM Database Feature #6995: possibly support NO-UNDO temporary tables directly in H2
- I committed to 6995a_h2, rev.7 the changes that you asked for.
Also, when running @build.sh test@, the errors were ... - 03:49 AM Database Feature #6995: possibly support NO-UNDO temporary tables directly in H2
- Radu, based on our new FWD-H2 branching system #7058, I've created 6995a_h2 to hold your patch from #6995-13. However...
- 09:30 AM Base Language Feature #6421: finish GENERATE-RANDOM-KEY support
- Yes, except it would be useful to put slightly more detail in the comment. Something like this seems appropriate:
... - 09:18 AM Base Language Feature #6421: finish GENERATE-RANDOM-KEY support
- History entry means to add a comment in the beginning of the file?
Like the following?... - 09:12 AM Base Language Feature #6421: finish GENERATE-RANDOM-KEY support
- Theodoros Theodorou wrote:
> How to write test cases?
[[p2j:Writing 4GL Testcases]]
[[p2j:Testing_Process#Proje... - 09:03 AM Base Language Feature #6421: finish GENERATE-RANDOM-KEY support
- How to write test cases? I thought that the p2j test cases do not run.
- 06:20 AM Base Language Feature #6421: finish GENERATE-RANDOM-KEY support
- Code Review Task Branch 6421a Revision 14484
1. @generateRandomKey()@ needs complete error handling. Please write... - 05:41 AM Base Language Feature #6421: finish GENERATE-RANDOM-KEY support
- Igor: Please review.
- 02:06 AM Base Language Feature #6421 (Review): finish GENERATE-RANDOM-KEY support
- I have committed my changes and the task is ready for review
- 02:05 AM Base Language Feature #6421: finish GENERATE-RANDOM-KEY support
- I have created the branch 6421a
- 09:08 AM Database Support #7058: get the FWD fork of the H2 code base under version control
- See if you can just do some limited edits to Source Code Management to explain branching for FWD vs H2.
- 05:09 AM Database Support #7058: get the FWD fork of the H2 code base under version control
- Greg, I've done only one documentation change to "Patching and Building Customized 3rd Party Libraries":/projects/p2j...
- 08:50 AM Build and Source Control Bug #7083: P2J Native Build Cannot Find -ljvm Under Windows
- h2. Environment
Windows VirtualBox VM is set up by following the steps in [[p2j:Windows 11 Virtual Machine Setup w... - 03:05 AM Build and Source Control Bug #7083 (Rejected): P2J Native Build Cannot Find -ljvm Under Windows
- 08:25 AM Database Feature #7037: remove dirty share manager
- Greg Shah wrote:
> > Cross-session use for the small set of tables (currently, only one I know of) which needs it.
... - 05:38 AM Database Feature #7037: remove dirty share manager
- > Cross-session use for the small set of tables (currently, only one I know of) which needs it.
Tomasz may have fo... - 01:56 AM Database Feature #6628: port PostgreSQL native user defined functions to MariaDB
- Eric Faulhaber wrote:
> Igor Skornyakov wrote:
>
> > I think that error handling can be finished in 2-3 days.
>... - 01:32 AM Database Feature #6628: port PostgreSQL native user defined functions to MariaDB
- Igor Skornyakov wrote:
> I think that error handling can be finished in 2-3 days.
Please finish this when you ...
Also available in: Atom