Project

General

Profile

Activity

From 08/03/2023 to 09/01/2023

09/02/2023

10:48 PM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
Greg Shah wrote:
> Ovidiu: What additional testing is needed?
I meant testing whether the @ScriptRunner@ could be u...
Ovidiu Maxiniuc

09/01/2023

07:01 PM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
In revisiting getting the postgres image augmented to be able to run the data import internally, we have to install J... Roger Borrello
01:27 PM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
Roger Borrello wrote:
> If you are using the latest @hotel_gui@ project, and the latest @4722a@, you should be able ...
Igor Skornyakov
01:25 PM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
Greg Shah wrote:
> Igor Skornyakov wrote:
> > I see the following message on the database import fron the @holel-gu...
Igor Skornyakov
01:24 PM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
Greg Shah wrote:
> > Please note also that at this moment @ScriptRunner@ works only with @PostgreSQL@ and @MariaDB@ ...
Igor Skornyakov
12:55 PM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
If you are using the latest @hotel_gui@ project, and the latest @4722a@, you should be able to run: @./p2j/import.sh ... Roger Borrello
12:28 PM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
Igor Skornyakov wrote:
> I see the following message on the database import fron the @holel-gui@:
> [...]
> It see...
Greg Shah
12:27 PM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
> Please note also that at this moment @ScriptRunner@ works only with @PostgreSQL@ and @MariaDB@ since @H2@ UDFs are ... Greg Shah
11:20 AM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
I see the following message on the database import fron the @holel-gui@:... Igor Skornyakov
11:04 AM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
Some changes in the @ScriptRunner@ configuration logic are required.
Working on this.
Please note also that at this...
Igor Skornyakov
09:42 AM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
Greg Shah wrote:
> Application-specific DDL (for creating databases and indices) will be found in the application ja...
Igor Skornyakov
09:41 AM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
Application-specific DDL (for creating databases and indices) will be found in the application jar.
All changes go...
Greg Shah
09:33 AM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
One more questions.
Should I use 4722a branch for this task?
Thank you.
Igor Skornyakov
09:27 AM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
Greg Shah wrote:
> Igor: Please go ahead with this change. Assume that the DDL is available in the jar in a known l...
Igor Skornyakov
09:09 AM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
Igor: Please go ahead with this change. Assume that the DDL is available in the jar in a known location. Greg Shah
09:01 AM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
Greg Shah wrote:
> > Even if there were an enhancement to have ScriptRunner be able to execute the DDL,
>
> The D...
Igor Skornyakov
08:40 AM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
> Even if there were an enhancement to have ScriptRunner be able to execute the DDL,
The DDL definitely should be ...
Greg Shah
08:38 AM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
Greg Shah wrote:
> Roger: Based on your testing, there anything else needed in this task?
From my perspective, no...
Roger Borrello
08:34 AM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
Eric: This is still waiting for review.
Ovidiu: What additional testing is needed?
Roger: Based on your testing...
Greg Shah
09:14 PM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
I've replaced the @hotel-import.sh@ with @import@ that now utilizes the *p2j.jar* and *app.jar*. There is a new requi... Roger Borrello
09:17 AM User Interface Feature #3931: single sign-on for virtual desktop mode
r14758 adds support for @/webres@ context for base virtual desktop and embedded resources (style.css, login page, fav... Galya B
02:10 AM Database Bug #7488: Slow fast-copy with before tables in H2
Alexandru Lungu wrote:
> Danut, did you had some correctness tests with fast-copy at some point? Can you share them ...
Dănuț Filimon

08/31/2023

11:15 AM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
> Branch was rebased to trunk_14721 and is at revision 14722. I noticed there were many spelling/formatting updates i... Greg Shah
11:07 AM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
Branch was rebased to trunk_14721 and is at revision 14722. I noticed there were many spelling/formatting updates in ... Roger Borrello
09:05 AM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
Any objections to me rebase-ing to the latest trunk? My checkout is at revision 14663. No pending changes to commit t... Roger Borrello
10:56 AM Base Language Bug #7656: investigate performance of context-local helpers (e.g. TransactionManager.TransactionH...
Agreed. Greg Shah
10:49 AM Base Language Bug #7656: investigate performance of context-local helpers (e.g. TransactionManager.TransactionH...
Greg Shah wrote:
> Full changes.
OK, then I think we need this:
* for all inner classes which have fields accessed...
Constantin Asofiei
10:43 AM Base Language Bug #7656: investigate performance of context-local helpers (e.g. TransactionManager.TransactionH...
Full changes. Greg Shah
10:30 AM Base Language Bug #7656: investigate performance of context-local helpers (e.g. TransactionManager.TransactionH...
Thank you, Alexandru.
Greg: how do you want to proceed? Get the full changes or just the critical classes?
Constantin Asofiei
10:22 AM Base Language Bug #7656: investigate performance of context-local helpers (e.g. TransactionManager.TransactionH...
I tested with 7156b/rev. 14732 (which was on 8.193s) patched with 7656a / rev. 14722 + 14723 and got 8.158ms. This me... Alexandru Lungu
04:51 AM Base Language Bug #7656: investigate performance of context-local helpers (e.g. TransactionManager.TransactionH...
Alexandru, in 7656a rev 14723 I have the automated changes to modify 'private' to 'package private' fields/methods wh... Constantin Asofiei
09:58 AM Database Bug #7488: Slow fast-copy with before tables in H2
The changes are very close to state-of-the-art in 7404a. Very good job, Radu!
* Please rename @PK__MAPPING@ into @...
Alexandru Lungu
09:47 AM Database Bug #7535: Temporary tables require trailing recid component even for unique indexes
Alexandru Lungu wrote:
> * You call @if (!isUndoable()) { reclaimKeys();}@ Note that this will reclaim all keys acro...
Dănuț Filimon
07:17 AM Database Bug #7496: finish support for query:forward-only attribute
Personal tests and customer application were tested previously. I've retested them just to make sure, but I was not s... Dănuț Filimon
06:34 AM Base Language Support #4032: block/transaction processing context-local and other performance improvements
4032b was rebased from trunk rev 14721.
4032b rev 14722 contains a small batch of performance improvements related...
Constantin Asofiei
04:22 AM Database Bug #7731: performance improvements for FQLPreprocessor
Alexandru, I think this can help - can you take a look at it? Constantin Asofiei

08/30/2023

09:39 AM Database Bug #7535 (Review): Temporary tables require trailing recid component even for unique indexes
Danut, I am mostly OK with the changes in 7535c.
* You call @if (!isUndoable()) { reclaimKeys();}@ Note that this ...
Alexandru Lungu
08:09 AM Database Bug #7488: Slow fast-copy with before tables in H2
I applied the bullets from #7488-28 and committed to 7404a, rev. 14660. In addition to that, I also merged the two @p... Radu Apetrii
04:19 AM Database Bug #7488: Slow fast-copy with before tables in H2
Radu Apetrii wrote:
> The only relevant purpose at the moment for @isBefore@ would be bullet 2 from the list above. ...
Alexandru Lungu
04:06 AM Database Bug #7488: Slow fast-copy with before tables in H2
Alexandru Lungu wrote:
> * There is quite some logic around @isBefore@ inside @executeCopy@. Can you summarize it he...
Radu Apetrii
07:27 AM Runtime Infrastructure Bug #7635: RemoteObject defaults to 'tracing' mode
Constantin, I see you often merge branches. Can you make those small updates to logs, you're most well familiar with,... Galya B
07:24 AM Runtime Infrastructure Bug #7635: RemoteObject defaults to 'tracing' mode
The same fix needs to be done at @Dispatcher.tracing@. Constantin Asofiei
05:12 AM Database Bug #7567: use Session.PK instead of DatabaseManager.PRIMARY_KEY wherever possible
*Committed 7567a/rev.14714 and 7567a_h2/rev.27*. Removed DatabaseManager.PRIMARY_KEY and replaced it's usage with Ses... Dănuț Filimon
04:31 AM Database Bug #7496 (Review): finish support for query:forward-only attribute
Danut, please let me know if there is something left in this task.
Please do a full round of testing with this:
*...
Alexandru Lungu
04:22 AM User Interface Feature #3931: single sign-on for virtual desktop mode
A few minor fixes pushed to r14757. Galya B
04:18 AM User Interface Feature #3931: single sign-on for virtual desktop mode
Here is what needs to be done to hotel_gui to run with 3931a:
Add the @SsoAuthenticator@ implementation (dummy as ...
Galya B
04:00 AM Database Bug #7641: Lower the number of Map.get() calls in the persistence layer
Committed refactoring the code on 7641a revision 14715.
Eduard Soltan
03:29 AM Testing Support #7760: Testcases - server error on database initialisation
*Sorry for the late response; I will shed some light on this*:
@RTRIM@ is a new connection option we introduced wi...
Alexandru Lungu

08/29/2023

05:01 PM Base Language Bug #7759: improve CASE statement for integer type
Constantin,
I was not aware of the 64 bit limitation of Java @switch@ statement. Probably we will need to use the...
Ovidiu Maxiniuc
06:59 AM Base Language Bug #7759: improve CASE statement for integer type
What I had in mind (for integer type, as Java switch AFAIK works with 32 bit values, not 64, at least for Java 8), is... Constantin Asofiei
06:56 AM Base Language Bug #7759: improve CASE statement for integer type
From an email discussion:
Constantin Asofiei wrote:
> Quick question, I don't recall if this is how it is suppose...
Constantin Asofiei
06:54 AM Base Language Bug #7759 (New): improve CASE statement for integer type
Constantin Asofiei
03:20 PM Testing Support #7760: Testcases - server error on database initialisation
Constantin Asofiei wrote:
> Marian, please check that you have a single @fwd-h2*.jar@ in your deploy/lib folder.
...
Marian Edu
03:05 PM Testing Support #7760: Testcases - server error on database initialisation
Marian, please check that you have a single @fwd-h2*.jar@ in your deploy/lib folder. Constantin Asofiei
03:04 PM Testing Support #7760: Testcases - server error on database initialisation
The @URL@ in @TempTableDataSourceProvider@ is this `jdbc:h2:mem:_temp;db_close_delay=-1;mv_store=false;rtrim=true;que... Marian Edu
02:34 PM Testing Support #7760: Testcases - server error on database initialisation
Eric Faulhaber wrote:
> Please try removing the @database@ node in its entirety (the parent of @tstcasedata@) and se...
Marian Edu
02:08 PM Testing Support #7760: Testcases - server error on database initialisation
Alexandru, Ovidiu, any idea where the @Unsupported connection setting "RTRIM"@ error would be coming from? Where woul... Eric Faulhaber
02:04 PM Testing Support #7760: Testcases - server error on database initialisation
Marian Edu wrote:
> At this point I really don't need any database connection, is there a way to start without one...
Eric Faulhaber
12:59 PM Testing Support #7760: Testcases - server error on database initialisation
Greg Shah wrote:
> You've imported the @tstcasedata@ into an H2 database in the @db/@ directory?
I've initially c...
Marian Edu
10:18 AM Testing Support #7760: Testcases - server error on database initialisation
You've imported the @tstcasedata@ into an H2 database in the @db/@ directory? Greg Shah
08:43 AM Testing Support #7760: Testcases - server error on database initialisation
Greg Shah wrote:
> Please post you directory here.
It's basically the copy of the template and I've updated @os-u...
Marian Edu
08:11 AM Testing Support #7760: Testcases - server error on database initialisation
Please post you directory here. Greg Shah
08:02 AM Testing Support #7760: Testcases - server error on database initialisation
Trying to get the testcases project up and running, preferably with the @abl-unit@ support but it turns out it doesn'... Marian Edu
08:01 AM Testing Support #7760 (New): Testcases - server error on database initialisation
Marian Edu
10:45 AM Database Bug #7488: Slow fast-copy with before tables in H2
*Review of 7404a*
* You don't actually need @FastCopyContext.newInstance@ - you can call the constructor directly....
Alexandru Lungu
07:46 AM Base Language Feature #6410: implement additional built-in OO classes/interfaces
Marian Edu wrote:
> Constantin Asofiei wrote:
>
> > Thanks, so we need what I mentioned before, we need to fix @B...
Constantin Asofiei
07:45 AM Base Language Feature #6410: implement additional built-in OO classes/interfaces
Constantin Asofiei wrote:
> Thanks, so we need what I mentioned before, we need to fix @BaseObject.getNextSibling@...
Marian Edu
07:45 AM Base Language Feature #6410: implement additional built-in OO classes/interfaces
Marian Edu wrote:
> Constantin Asofiei wrote:
> > Please check also what @Progress.Reflect.Method:next-sibling@ ret...
Marian Edu
07:44 AM Base Language Feature #6410: implement additional built-in OO classes/interfaces
Marian Edu wrote:
> Constantin Asofiei wrote:
> > Please check also what @Progress.Reflect.Method:next-sibling@ ret...
Constantin Asofiei
07:43 AM Base Language Feature #6410: implement additional built-in OO classes/interfaces
Constantin Asofiei wrote:
> Please check also what @Progress.Reflect.Method:next-sibling@ returns - is it always unk...
Marian Edu
07:39 AM Base Language Feature #6410: implement additional built-in OO classes/interfaces
Please check also what @Progress.Reflect.Method:next-sibling@ returns - is it always unknown? If yes, maybe this (and... Constantin Asofiei
07:37 AM Base Language Feature #6410: implement additional built-in OO classes/interfaces
Constantin Asofiei wrote:
> Marian, can these be created outside of FWD runtime (i.e. by the application?) If these...
Marian Edu
07:25 AM Base Language Feature #6410: implement additional built-in OO classes/interfaces
Marian, can these be created outside of FWD runtime (i.e. by the application?) If these can only be created by FWD r... Constantin Asofiei
07:19 AM Base Language Feature #6410: implement additional built-in OO classes/interfaces
From Marian Edu:
> think I've stumbled upon the same problem before but can't remember exactly the use case nor the ...
Constantin Asofiei
06:57 AM Database Feature #7447 (Closed): Compare ValueString and ValueStringIgnoreCase faster in FWD-H2
Greg Shah
03:32 AM Database Feature #7447 (Review): Compare ValueString and ValueStringIgnoreCase faster in FWD-H2
Ok, this can be closed then - let me know if there is something left here to discuss Alexandru Lungu
03:29 AM Database Feature #7447: Compare ValueString and ValueStringIgnoreCase faster in FWD-H2
Great news! I retested the customer application using a different approach which allowed me to test it a lot faster a... Dănuț Filimon

08/28/2023

02:27 PM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
@ScriptRunner@ currently only accepts the commands:
* @udf.install@
* @udf.install.search_path@
It would need ...
Eric Faulhaber
01:58 PM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
Ovidiu Maxiniuc wrote:
> I think the @build.xml@ is only modified to allow the packaging of the @ddl@ scripts inside...
Roger Borrello
01:52 PM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
I think the @build.xml@ is only modified to allow the packaging of the @ddl@ scripts inside the app's jar file.
On...
Ovidiu Maxiniuc
01:40 PM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
That is all understood... and @import.sh@ allows you to perform an import with only the @p2j.jar@, the @app.jar@ and ... Roger Borrello
01:04 PM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
Customers need to be able to deploy without a project installation. Optimally, the solution would only require the F... Greg Shah
12:02 PM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
If this tool cuts the muster, should it be part of FWD versus something given to the customers for use in their appli... Roger Borrello
10:24 AM Database Bug #7641: Lower the number of Map.get() calls in the persistence layer
Rebased 7641a to trunk. 14711. Alexandru Lungu
09:36 AM Database Feature #7447: Compare ValueString and ValueStringIgnoreCase faster in FWD-H2
Alexandru Lungu wrote:
> Danut, please check if this is still happening after your changes in #7454. Of course, befo...
Dănuț Filimon
09:05 AM User Interface Feature #6438 (Closed): frame attributes, methods and options
Greg Shah
08:35 AM User Interface Feature #6438: frame attributes, methods and options
Branch @6438b@ was merged to trunk as revno @14711@ then it was archived. Eugenie Lyzenko
08:26 AM User Interface Feature #6438: frame attributes, methods and options
Greg Shah wrote:
> You can merge to trunk after 7589a.
OK. I'm starting.
Eugenie Lyzenko
08:17 AM Database Bug #7488: Slow fast-copy with before tables in H2
Alexandru Lungu wrote:
> Radu Apetrii wrote:
> > The problem with this is that @TemporaryBuffer.copyAllRows@ is a *...
Radu Apetrii
08:07 AM Database Bug #7488: Slow fast-copy with before tables in H2
Radu Apetrii wrote:
> The problem with this is that @TemporaryBuffer.copyAllRows@ is a *static* method, so I don't h...
Alexandru Lungu
06:03 AM Database Bug #7488: Slow fast-copy with before tables in H2
I've applied the suggestions from the last post (except one) and committed to 7404a, rev. 14658.
Alexandru Lungu w...
Radu Apetrii
08:05 AM Database Bug #7535: Temporary tables require trailing recid component even for unique indexes
Alexandru Lungu wrote:
> Danut, please push on 7535c (newly created) a sound solution. Most important is to allow re...
Dănuț Filimon
07:16 AM Database Feature #7064 (Rejected): Analyze the performance impact of the implicit meta schema in H2
Greg Shah
03:56 AM Database Feature #7064: Analyze the performance impact of the implicit meta schema in H2
* When you open a session and create a database, you reach @Database.open@, which calls @Database.addDatabaseObject@.... Alexandru Lungu
01:58 AM Runtime Infrastructure Bug #7589 (Test): org.slf4j.impl.StaticLoggerBinder when deploying p2j.jar in tomcat
Task branch 7589a was merged to trunk as rev 14710 and archived. Galya B

08/27/2023

05:58 PM User Interface Feature #6438: frame attributes, methods and options
You can merge to trunk after 7589a. Greg Shah
05:53 PM User Interface Feature #6438: frame attributes, methods and options
Code Review Task Branch 6438b Revision 14710
The changes are good.
Greg Shah

08/26/2023

06:25 AM Runtime Infrastructure Bug #7589: org.slf4j.impl.StaticLoggerBinder when deploying p2j.jar in tomcat
You can merge now. Greg Shah

08/25/2023

01:20 PM Runtime Infrastructure Bug #7589: org.slf4j.impl.StaticLoggerBinder when deploying p2j.jar in tomcat
Hynek Cihlar wrote:
> Greg Shah wrote:
> > Hynek/Constantin: Any objection to the merge?
>
> No objection here.
...
Constantin Asofiei
12:49 PM Runtime Infrastructure Bug #7589: org.slf4j.impl.StaticLoggerBinder when deploying p2j.jar in tomcat
Greg Shah wrote:
> Hynek/Constantin: Any objection to the merge?
No objection here.
Hynek Cihlar
09:38 AM Runtime Infrastructure Bug #7589: org.slf4j.impl.StaticLoggerBinder when deploying p2j.jar in tomcat
Thanks! I was struggling badly with that possessive 's :) It's good. Galya B
09:36 AM Runtime Infrastructure Bug #7589: org.slf4j.impl.StaticLoggerBinder when deploying p2j.jar in tomcat
> Check the new Logging section [[p2j:Logging#Interference-with-External-Java-Application-Logging|Interference with c... Greg Shah
09:24 AM Runtime Infrastructure Bug #7589: org.slf4j.impl.StaticLoggerBinder when deploying p2j.jar in tomcat
Check the new Logging section [[p2j:Logging#Interference-with-External-Java-Application-Logging|Interference with cus... Galya B
08:59 AM Runtime Infrastructure Bug #7589: org.slf4j.impl.StaticLoggerBinder when deploying p2j.jar in tomcat
Yep, yep, I forgot we have relevant documentation... Working on it. Galya B
08:59 AM Runtime Infrastructure Bug #7589: org.slf4j.impl.StaticLoggerBinder when deploying p2j.jar in tomcat
Since we add our own slf4j override implementation, it can affect many customers. This would be unexpected. Adding ... Greg Shah
08:56 AM Runtime Infrastructure Bug #7589: org.slf4j.impl.StaticLoggerBinder when deploying p2j.jar in tomcat
> There is no change for customers who don't experience problems with their own Java logging. If they have their own ... Greg Shah
08:50 AM Runtime Infrastructure Bug #7589: org.slf4j.impl.StaticLoggerBinder when deploying p2j.jar in tomcat
There is no change for customers who don't experience problems with their own Java logging. If they have their own Ja... Galya B
08:48 AM Runtime Infrastructure Bug #7589: org.slf4j.impl.StaticLoggerBinder when deploying p2j.jar in tomcat
Hynek/Constantin: Any objection to the merge?
Galya: What documentation do we need to explain this?
Greg Shah
08:37 AM Runtime Infrastructure Bug #7589: org.slf4j.impl.StaticLoggerBinder when deploying p2j.jar in tomcat
Right. It has to be merged. It separates slf4j implementation in its own jar, but builds in the same way. Can be remo... Galya B
08:33 AM Runtime Infrastructure Bug #7589: org.slf4j.impl.StaticLoggerBinder when deploying p2j.jar in tomcat
Don't we need to do something with 7589a? Greg Shah
07:45 AM Runtime Infrastructure Bug #7589 (Review): org.slf4j.impl.StaticLoggerBinder when deploying p2j.jar in tomcat
This should be considered resolved. Allowing the customer to include in the classpath their slf4j implementation and ... Galya B
11:04 AM User Interface Feature #6438: frame attributes, methods and options
Rebased @6438b@ with recent trunk @14709@. New revision is @14710@. Eugenie Lyzenko
10:46 AM Database Bug #7535: Temporary tables require trailing recid component even for unique indexes
> It is not completely clear to me what your conclusions are regarding persistent tables. I would like to avoid attem... Alexandru Lungu
10:20 AM Database Bug #7535: Temporary tables require trailing recid component even for unique indexes
Alexandru Lungu wrote:
> In the last 2 examples, in practice, there are other recids (1491 instead of 1488, etc.)....
Eric Faulhaber
10:38 AM Database Bug #6941 (Rejected): conversion issue when using undo in do transaction
Greg Shah
10:31 AM Database Bug #6941 (WIP): conversion issue when using undo in do transaction
This can be closed / rejected. Alexandru Lungu
10:02 AM Database Bug #6941: conversion issue when using undo in do transaction
It seems that this has been solved in the meantime. I tested with trunk, rev. 14709 and everything worked fine. No is... Radu Apetrii
10:29 AM Database Bug #7641: Lower the number of Map.get() calls in the persistence layer
I am OK with most of the changes; there seemed to be quite some places which needed refactoring.
Eduard, please co...
Alexandru Lungu
09:56 AM Database Bug #7496: finish support for query:forward-only attribute
*Committed 7496a/rev.14705*. After fixing #7737 (#7737-12) and investigating @TRANSACTION_COMMITTING@, I managed to f... Dănuț Filimon
07:35 AM User Interface Feature #3931: single sign-on for virtual desktop mode
Final touch-ups in r14756: CertificateUtil removed, file headers added to AccountExtUtil and SecurityUtil.
Galya B
06:12 AM User Interface Feature #3931: single sign-on for virtual desktop mode
r14755 with file headers.
Constantin, if you can, check it out. It will be helpful. There are a bunch of files upd...
Galya B
05:57 AM User Interface Feature #3931: single sign-on for virtual desktop mode
I'm reviewing 3931a. Constantin Asofiei
03:19 AM User Interface Feature #3931: single sign-on for virtual desktop mode
P.S. File headers in the making. Galya B
03:18 AM User Interface Feature #3931 (Review): single sign-on for virtual desktop mode
3931a rebased on trunk r14707. Ready for review. Galya B
06:36 AM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
Roger Borrello wrote:
> I made some upgrades to the program to:
> # Handle multiple database imports
> # Retrieve ...
Greg Shah
03:57 AM Database Bug #7488: Slow fast-copy with before tables in H2
*Review of 7404a, rev. 14656*
The changes are quite good now and look pretty stable. However, there are still some...
Alexandru Lungu

08/24/2023

04:46 PM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
I made some upgrades to the program to:
# Handle multiple database imports
# Retrieve DDL from the application jar
...
Roger Borrello
11:57 AM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
I do notice that my application jar file does *not* include the ddl necessary to create the table structure. I can ea... Roger Borrello
10:07 AM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
This is an update on 7045b:
* I didn't faced any conversion issues in the meantime. Everything is good with #7045 ...
Alexandru Lungu
09:30 AM User Interface Feature #3931: single sign-on for virtual desktop mode
Ah, this makes sense. Up in r14683. Galya B
09:28 AM User Interface Feature #3931: single sign-on for virtual desktop mode
I was thinking of a default method in the interface. Greg Shah
09:15 AM User Interface Feature #3931: single sign-on for virtual desktop mode
Also the hotel gui SsoAuthenticator implementation (I still haven't uploaded) returns null. Galya B
09:14 AM User Interface Feature #3931: single sign-on for virtual desktop mode
Greg Shah wrote:
> > To enable auto-login they need to implement two methods of the @SsoAuthenticator@: @getAuthCook...
Galya B
09:12 AM User Interface Feature #3931: single sign-on for virtual desktop mode
Galya B wrote:
> Greg Shah wrote:
> > > With allowing auto-login, as I've said in the past, new clients will be way...
Greg Shah
09:11 AM User Interface Feature #3931: single sign-on for virtual desktop mode
Greg Shah wrote:
> > With allowing auto-login, as I've said in the past, new clients will be way easier to get spawn...
Galya B
09:07 AM User Interface Feature #3931: single sign-on for virtual desktop mode
> The abuser is someone with valid username and password, so it's very much in the hands of the customers to keep tha... Greg Shah
08:59 AM User Interface Feature #3931: single sign-on for virtual desktop mode
I get:... Galya B
07:42 AM User Interface Feature #3931: single sign-on for virtual desktop mode
We can further expand the args passed in to the @SsoAuthenticator@ to allow licensing management, but that with next ... Galya B
07:40 AM User Interface Feature #3931: single sign-on for virtual desktop mode
I was thinking how to protect better the expensive resource of spawning a new web client process. And I was thinking ... Galya B
08:27 AM Database Feature #7323: Implement soft unique index in FWD-H2
Committed 7323a_h2 as FWD-H2 rev. 26 and archived.
The FWD changes will be merged once we upgrade to the latest FW...
Alexandru Lungu
03:18 AM Database Feature #7323: Implement soft unique index in FWD-H2
Alexandru Lungu wrote:
> Please focus on identifying any changes that may cause regressions when VALIDATE mode is no...
Radu Apetrii
07:45 AM Base Language Bug #7722: improve performance of equals/not equals when used with character/longchar
Constantin Asofiei wrote:
> Alexandru, there is a concern; if we compare case-insensitive, there is no guarantee th...
Alexandru Lungu
06:00 AM Base Language Bug #7722: improve performance of equals/not equals when used with character/longchar
Alexandru, there is a concern; if we compare case-insensitive, there is no guarantee that a lowercase and an upperca... Constantin Asofiei
05:10 AM Base Language Bug #7722: improve performance of equals/not equals when used with character/longchar
Alexandru Lungu wrote:
> Danut, please get this done *asap*. I am planning to do a set of regression tests + profili...
Dănuț Filimon
03:46 AM Base Language Bug #7722 (WIP): improve performance of equals/not equals when used with character/longchar
Alexandru Lungu
03:46 AM Base Language Bug #7722: improve performance of equals/not equals when used with character/longchar
Danut, please get this done *asap*. I am planning to do a set of regression tests + profiling. I am keen on getting t... Alexandru Lungu
03:42 AM Database Bug #7535: Temporary tables require trailing recid component even for unique indexes
I was using @COMPILE test.p LISTING test.lst@ at some point, but this is informative only when working with a persist... Alexandru Lungu

08/23/2023

03:59 PM Database Bug #7535: Temporary tables require trailing recid component even for unique indexes
Constantin Asofiei wrote:
> Alexandru, you can use @COMPILE test.p LISTING test.lst@ to check the transaction behavi...
Tijs Wickardt
10:23 AM Database Bug #7535: Temporary tables require trailing recid component even for unique indexes
Alexandru, you can use @COMPILE test.p LISTING test.lst@ to check the transaction behavior in 4GL. Keep in mind that... Constantin Asofiei
10:07 AM Database Bug #7535: Temporary tables require trailing recid component even for unique indexes
The test-cases you found are quite interesting. I've done some testing myself with nested transactions.
In 95% of...
Alexandru Lungu
01:11 PM User Interface Bug #7742 (WIP): NPE on LinuxKeyboardReader when pressing Escape in ChUI Swing application
Hynek Cihlar
01:11 PM User Interface Bug #7742: NPE on LinuxKeyboardReader when pressing Escape in ChUI Swing application
Vladimir Tsichevski wrote:
> Hynek Cihlar wrote:
> > Vladimir Tsichevski wrote:
> > > I see no differences.
> > >...
Hynek Cihlar
01:05 PM User Interface Bug #7742: NPE on LinuxKeyboardReader when pressing Escape in ChUI Swing application
Hynek Cihlar wrote:
> Vladimir Tsichevski wrote:
> > I see no differences.
> >
> > Also: after the @Escape@ was ...
Vladimir Tsichevski
01:01 PM User Interface Bug #7742: NPE on LinuxKeyboardReader when pressing Escape in ChUI Swing application
Vladimir Tsichevski wrote:
> I see no differences.
>
> Also: after the @Escape@ was pressed, the new key press is...
Hynek Cihlar
12:53 PM User Interface Bug #7742: NPE on LinuxKeyboardReader when pressing Escape in ChUI Swing application
Vladimir Tsichevski wrote:
> Hynek Cihlar wrote:
> > Vladimir Tsichevski wrote:
> > > Hynek Cihlar wrote:
> > > >...
Vladimir Tsichevski
12:46 PM User Interface Bug #7742: NPE on LinuxKeyboardReader when pressing Escape in ChUI Swing application
Hynek Cihlar wrote:
> Vladimir Tsichevski wrote:
> > Hynek Cihlar wrote:
> > > Vladimir, please also retest.
> > ...
Vladimir Tsichevski
12:43 PM User Interface Bug #7742: NPE on LinuxKeyboardReader when pressing Escape in ChUI Swing application
Vladimir Tsichevski wrote:
> Hynek Cihlar wrote:
> > Vladimir, please also retest.
>
> The NPE disappeared now, ...
Hynek Cihlar
12:36 PM User Interface Bug #7742: NPE on LinuxKeyboardReader when pressing Escape in ChUI Swing application
Hynek Cihlar wrote:
> Vladimir, please also retest.
The NPE disappeared now, but it seems the code works incorrec...
Vladimir Tsichevski
12:12 PM User Interface Bug #7742: NPE on LinuxKeyboardReader when pressing Escape in ChUI Swing application
I added missing code comments in 7742a revision 14708. Hynek Cihlar
11:52 AM User Interface Bug #7742: NPE on LinuxKeyboardReader when pressing Escape in ChUI Swing application
Greg Shah wrote:
> Are we sure we need to add a @null@ keyboard event to the queue?
>
> Tomasz: Have you encounte...
Tomasz Domin
11:28 AM User Interface Bug #7742: NPE on LinuxKeyboardReader when pressing Escape in ChUI Swing application
Vladimir, please also retest. Hynek Cihlar
11:26 AM User Interface Bug #7742 (Review): NPE on LinuxKeyboardReader when pressing Escape in ChUI Swing application
Hynek Cihlar
11:25 AM User Interface Bug #7742: NPE on LinuxKeyboardReader when pressing Escape in ChUI Swing application
The issue is fixed in 7742a revision 14707. The problem only showed in Swing ChUI client. Please review. Hynek Cihlar
11:14 AM User Interface Bug #7742: NPE on LinuxKeyboardReader when pressing Escape in ChUI Swing application
Hynek Cihlar wrote:
> Greg Shah wrote:
> > Are we sure we need to add a @null@ keyboard event to the queue?
>
> ...
Vladimir Tsichevski
10:32 AM User Interface Bug #7742: NPE on LinuxKeyboardReader when pressing Escape in ChUI Swing application
Greg Shah wrote:
> Are we sure we need to add a @null@ keyboard event to the queue?
Yes, it is used to signal a m...
Hynek Cihlar
10:00 AM User Interface Bug #7742: NPE on LinuxKeyboardReader when pressing Escape in ChUI Swing application
Are we sure we need to add a @null@ keyboard event to the queue?
Tomasz: Have you encountered this issue in @<larg...
Greg Shah
09:26 AM User Interface Bug #7742: NPE on LinuxKeyboardReader when pressing Escape in ChUI Swing application
ChUI Swing: when I press @Escape@, the client crashes with NPE here:... Vladimir Tsichevski
09:15 AM User Interface Bug #7742 (WIP): NPE on LinuxKeyboardReader when pressing Escape in ChUI Swing application
Vladimir Tsichevski
11:10 AM User Interface Feature #6438: frame attributes, methods and options
Rebased @6438b@ with recent trunk @14707@. New revision is @14708@.
Greg,
I have no plans to add new changes he...
Eugenie Lyzenko
10:28 AM Testing Feature #3704: enable automated testing for GUI (Swing and web clients)
> > And we can provide even more access with our our custom 4GL attributes if we need them. All of that can be writt... Greg Shah
05:15 AM Testing Feature #3704: enable automated testing for GUI (Swing and web clients)
Vladimir Tsichevski wrote:
> The Sikuli-related stuff can be learned in one day, it is not much to learn.
Vladimir,...
Marian Edu
10:16 AM Database Feature #7064: Analyze the performance impact of the implicit meta schema in H2
Radu Apetrii wrote:
> Can/should this task be rejected? IMO, there is nothing left to investigate/implement here.
...
Alexandru Lungu
09:16 AM Database Feature #7064: Analyze the performance impact of the implicit meta schema in H2
Can/should this task be rejected? IMO, there is nothing left to investigate/implement here. Radu Apetrii
10:15 AM User Interface Feature #7709: ABLUnit support for web clients
Yes, it is a good point. There is a benefit to testing the spawning process itself.
On the other hand, spawning i...
Greg Shah
08:56 AM User Interface Feature #3931: single sign-on for virtual desktop mode
Greg Shah wrote:
> > What I'm trying to say is the major flaw with launching before auth is fixed.
>
> Yes, I un...
Galya B
08:50 AM User Interface Feature #3931: single sign-on for virtual desktop mode
> The question is if @auth-mode/ssoplugin@ is defined, but can't be instantiated (some typo in the package, class nam... Greg Shah
08:49 AM User Interface Feature #3931: single sign-on for virtual desktop mode
> What I'm trying to say is the major flaw with launching before auth is fixed.
Yes, I understand. My discussion...
Greg Shah
08:18 AM User Interface Feature #3931: single sign-on for virtual desktop mode
A question about configs: currently if @auth-mode/ssoplugin@ is defined and can be instantiated, then SSO is enabled.... Galya B
07:24 AM User Interface Feature #3931: single sign-on for virtual desktop mode
But I think it's fine. "works without SSO" means it directly checks the user / pass against the DB, where the in-app ... Galya B
07:19 AM User Interface Feature #3931: single sign-on for virtual desktop mode
Greg Shah wrote:
> To be clear: in #3770-81 I noted that our current login approach with embedded mode does need ser...
Galya B
07:16 AM User Interface Feature #3931: single sign-on for virtual desktop mode
The hotel gui js and the embedded driver js (intertwined with it) are very particular. I'm sure we don't have a guide... Galya B
07:16 AM User Interface Feature #3931: single sign-on for virtual desktop mode
To be clear: in #3770-81 I noted that our current login approach with embedded mode does need serious changes. Spawn... Greg Shah
07:09 AM User Interface Feature #3931: single sign-on for virtual desktop mode
Galya: Along with other objectives, Hotel GUI is intended to be an example of how to implement Embedded Mode for a GU... Greg Shah
04:51 AM User Interface Feature #3931: single sign-on for virtual desktop mode
So @setuserid@ does DB auth, which is a valid approach. I haven't uploaded anything to hotel_gui, but there are certa... Galya B
08:42 AM Database Bug #7737: QueryWrapper should either show or throw errors depending on the query type
*Committed 7496a/rev.14704*. Fixed 4 errors in @QueryWrapper@.
I've created a test suite to test how errors are hand...
Dănuț Filimon
07:13 AM Database Bug #7737: QueryWrapper should either show or throw errors depending on the query type
Danut, please fix the cases where errors behave different for static / dynamic queries. That is, change @QueryWrapper... Alexandru Lungu
07:07 AM Database Bug #7737: QueryWrapper should either show or throw errors depending on the query type
Alexandru Lungu wrote:
> Can you extend your testing for other kind of errors thrown by @QueryWrapper@? For instance...
Dănuț Filimon
08:31 AM Database Feature #7404: Trasform replace-mode into append-mode when target table is empty
Radu Apetrii wrote:
> While testing something for #7488, I noticed a regression on a test with @copy-temp-table with...
Radu Apetrii
06:50 AM Database Bug #7488: Slow fast-copy with before tables in H2
I added some more changes to @FastCopyHelper@ on 7404a, rev. 14656:
* Merged the master/before methods, meaning that...
Radu Apetrii
03:33 AM Database Bug #7403: Copy-temp-table with replace-mode should replace already inserted records
Radu, please note that fast-copy with REPLACE happens *only if* the destination is empty. This way, append is used in... Alexandru Lungu
03:06 AM Database Bug #7403: Copy-temp-table with replace-mode should replace already inserted records
Alexandru Lungu wrote:
> Radu, please check if this fixes your issue in #7404-32. After, please extract the changes ...
Radu Apetrii

08/22/2023

07:13 PM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
OK... I see it isn't merged to trunk. What is left to do? I updated:... Roger Borrello
06:24 PM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
Has this been merged to trunk yet? I have a new @import.sh@ script that should work with this usage:... Roger Borrello
12:30 PM User Interface Bug #7515: FILL-IN: editing dates issues
All fixes were tested for the following date formats: @9999/99/99@, @99/99/99@, @99999999@, @999999@.
The component ...
Vladimir Tsichevski
12:28 PM User Interface Bug #7515: FILL-IN: editing dates issues
The 7019a revision 14691 contains the following fixes:
# #7515-1 bullet 1: missing feature implemented
# #7515-1 ...
Vladimir Tsichevski
09:18 AM User Interface Bug #7515: FILL-IN: editing dates issues
Yet another issue: the empty screen value for the @99/99/99@ format must be @ / /@, in trunk it is @ / / @ (the ... Vladimir Tsichevski
12:17 PM Testing Feature #3704: enable automated testing for GUI (Swing and web clients)
Greg Shah wrote:
> > > For the interactive tests, we need to use Sikuli (or something like it). Sikuli seems to be ...
Vladimir Tsichevski
10:26 AM Testing Feature #3704: enable automated testing for GUI (Swing and web clients)
> > For the interactive tests, we need to use Sikuli (or something like it). Sikuli seems to be the best option but:... Greg Shah
09:42 AM Testing Feature #3704: enable automated testing for GUI (Swing and web clients)
Greg Shah wrote:
> For the interactive tests, we need to use Sikuli (or something like it). Sikuli seems to be th...
Vladimir Tsichevski
11:03 AM User Interface Feature #6438: frame attributes, methods and options
Rebased @6438b@ with recent trunk @14706@. New revision is @14707@.
Guys,
Can I merge this into trunk?
Eugenie Lyzenko
10:50 AM User Interface Feature #3931: single sign-on for virtual desktop mode
Hotel gui works well in a parent frame with login form validated by @SsoAuthenticator@. Even the CORS error (a non-cr... Galya B
08:36 AM User Interface Feature #3931: single sign-on for virtual desktop mode
It works, it's just that the CORS error is actually present in the console and some DB configs are missing in directo... Galya B
07:27 AM User Interface Feature #3931: single sign-on for virtual desktop mode
Embedded mode with Hotel GUI rev 271 and FWD trunk rev 14703 works fine. Constantin Asofiei
05:50 AM User Interface Feature #3931: single sign-on for virtual desktop mode
Constantin, do you know if hotel_gui's embedded works? With latest trunk + latest hotel_gui I get a very weird behavi... Galya B
09:34 AM Database Bug #7737: QueryWrapper should either show or throw errors depending on the query type
I see. It is weird that we don't have any similar use-case implemented in FWD: throw error if static, just show error... Alexandru Lungu
09:19 AM Database Bug #7737: QueryWrapper should either show or throw errors depending on the query type
Alexandru Lungu wrote:
> Is the fact that in the second example the query is scrolling?
It doesn't matter if the q...
Dănuț Filimon
09:11 AM Database Bug #7737: QueryWrapper should either show or throw errors depending on the query type
Danut, can you attempt making the query forward-only *after* you prepare it, but *before* opening? Is there any diffe... Alexandru Lungu
09:08 AM Database Bug #7737 (WIP): QueryWrapper should either show or throw errors depending on the query type
Is the fact that in the second example the query is scrolling? Or maybe because the second query is dynamic? Or maybe... Alexandru Lungu
08:54 AM Database Bug #7737: QueryWrapper should either show or throw errors depending on the query type
Alexandru Lungu wrote:
> Is there a problem in changing @recordOrShowError@ into @recordOrThrowError@?
>
> Danut,...
Dănuț Filimon
08:37 AM Database Bug #7737: QueryWrapper should either show or throw errors depending on the query type
Is there a problem in changing @recordOrShowError@ into @recordOrThrowError@?
Danut, do you have an example in whi...
Alexandru Lungu
08:23 AM Database Bug #7737: QueryWrapper should either show or throw errors depending on the query type
Another simpler test:... Dănuț Filimon
08:14 AM Database Bug #7737: QueryWrapper should either show or throw errors depending on the query type
This test fails for *7496a/rev.14703* and *trunk/rev.14704*. ... Dănuț Filimon
07:51 AM Database Bug #7737 (Test): QueryWrapper should either show or throw errors depending on the query type
Dănuț Filimon
09:32 AM Database Bug #5452 (Closed): eliminate use of ResultSet.CONCUR_UPDATABLE?
Greg Shah
07:50 AM Database Bug #5452 (Test): eliminate use of ResultSet.CONCUR_UPDATABLE?
Branch 5452a was merged to trunk as rev 14704 and archived.
This can be closed.
Alexandru Lungu
07:28 AM Database Bug #5452: eliminate use of ResultSet.CONCUR_UPDATABLE?
I am OK with the changes.
I also committed 5452a rev. 14563 removing @readOnly@ from share manager and multiplexer c...
Alexandru Lungu
09:22 AM Database Bug #7412 (Closed): PresortQuery ORDER BY has to many clauses
Greg Shah
05:15 AM Database Bug #7412: PresortQuery ORDER BY has to many clauses
This can be closed. Alexandru Lungu
09:02 AM Database Bug #7489: Lazily initialize DMO signature
On a server start-up with 2251 DMO loaded, I got 40ms spent in quick signature building, 50ms spent in explicit signa... Alexandru Lungu
08:27 AM Base Language Bug #7722: improve performance of equals/not equals when used with character/longchar
*Review of 7722a/rev.14704*
* Use Override annotation for @equals@ in @Text@. Make it return false if the paramete...
Alexandru Lungu
06:58 AM Base Language Bug #7722: improve performance of equals/not equals when used with character/longchar
*Committed 7722a/rev.14704*. Added Text.equals() method which uses @regionMatches@. The method is called in @CompareO... Dănuț Filimon
05:22 AM Base Language Bug #7722: improve performance of equals/not equals when used with character/longchar
Created 7722a. Alexandru Lungu
03:27 AM Base Language Bug #7722: improve performance of equals/not equals when used with character/longchar
Constantin Asofiei wrote:
> This only works with intern'ed strings, right?
Right. In FWD-H2 this short-circuit ha...
Alexandru Lungu
07:28 AM Base Language Bug #5538: fix readByte() for DirStream, ProcessStream, and others
How has it been tested? Greg Shah
05:17 AM Database Feature #7404: Trasform replace-mode into append-mode when target table is empty
Radu, this task was mostly fixed, but it is still open for review. As you do a major refactoring of @FastCopyHelper@,... Alexandru Lungu
05:12 AM Database Feature #7320: Extend H2 tester from Hotel GUI
There are lots of insightful tests generated for FWD-H2 right from the H2 tester. However, these are unusable in FWD ... Alexandru Lungu
05:01 AM Database Bug #7403 (Review): Copy-temp-table with replace-mode should replace already inserted records
*I reviewed the changes in 7403a and they are OK.*
Radu, please check if this fixes your issue in #7404-32. After,...
Alexandru Lungu
04:10 AM Database Bug #7535: Temporary tables require trailing recid component even for unique indexes
I retested after making a change to @Commitable@, but I am still left with two tests that end up in an infinite loop.... Dănuț Filimon

08/21/2023

07:23 PM User Interface Feature #6438 (Review): frame attributes, methods and options
The @6438b@ updated for review to revision @14704@.
Added basic support for @STREAM-IO@/@SCREEN-IO@ frame option. ...
Eugenie Lyzenko
06:50 PM User Interface Feature #6438: frame attributes, methods and options
Created task branch @6438b@ from trunk revision @14703@. Eugenie Lyzenko
02:54 PM User Interface Feature #6438: frame attributes, methods and options
Constantin Asofiei wrote:
>
> About @GET-ITERATION@ - does this convert/compile properly in FWD?
> [...]
Yes i...
Eugenie Lyzenko
02:39 PM User Interface Feature #6438: frame attributes, methods and options
Eugenie, the priority of these attributes is for ChUI, although if any missing GUI support can be added easily to be ... Constantin Asofiei
02:02 PM User Interface Feature #6438: frame attributes, methods and options
Go ahead with these changes.
Constantin: What do you think?
Greg Shah
01:10 PM User Interface Feature #6438: frame attributes, methods and options
Greg Shah wrote:
> > The other thing to be happen is setting USE-TEXT frame option to true. But it is already implem...
Eugenie Lyzenko
01:05 PM User Interface Feature #6438: frame attributes, methods and options
> The other thing to be happen is setting USE-TEXT frame option to true. But it is already implemented.
You mean t...
Greg Shah
12:17 PM User Interface Feature #6438: frame attributes, methods and options
Greg Shah wrote:
> Is forcing the use of the fixed width font really the only thing that needs to happen to support ...
Eugenie Lyzenko
12:05 PM User Interface Feature #6438: frame attributes, methods and options
Is forcing the use of the fixed width font really the only thing that needs to happen to support @STREAM-IO@? Greg Shah
03:13 PM Base Language Bug #5538: fix readByte() for DirStream, ProcessStream, and others
Can I get into the queue for merging this branch? Theodoros Theodorou
02:09 PM Database Bug #7731: performance improvements for FQLPreprocessor
When something is inlined, the @FQLPreprocessor@ does not use the cache at all. What I noticed is that @FQLPreproces... Constantin Asofiei
02:03 PM Database Bug #7731 (Closed): performance improvements for FQLPreprocessor
Constantin Asofiei
12:54 PM Runtime Infrastructure Bug #7649 (Closed): logging level for ScanDriver's "Failure in file" must be sever to log the sta...
Greg Shah
09:16 AM Runtime Infrastructure Bug #7649: logging level for ScanDriver's "Failure in file" must be sever to log the stacktrace
Branch 7649a was merged to trunk rev 14703. Constantin Asofiei
09:10 AM Runtime Infrastructure Bug #7649: logging level for ScanDriver's "Failure in file" must be sever to log the stacktrace
Yes Greg Shah
11:10 AM Base Language Bug #7722: improve performance of equals/not equals when used with character/longchar
Alexandru Lungu wrote:
> This makes sense. We have some recent implementation in FWD-H2 that was targeting this exac...
Constantin Asofiei
08:46 AM Base Language Bug #7722: improve performance of equals/not equals when used with character/longchar
This makes sense. We have some recent implementation in FWD-H2 that was targeting this exact issue. We can even compa... Alexandru Lungu
06:20 AM Base Language Bug #7722: improve performance of equals/not equals when used with character/longchar
In a large app, there are ~350k calls of @Text.compareTo@ which originate from equals/not-equals operators (via @Comp... Constantin Asofiei
06:14 AM Base Language Bug #7722 (WIP): improve performance of equals/not equals when used with character/longchar
Constantin Asofiei
10:01 AM Database Feature #7404: Trasform replace-mode into append-mode when target table is empty
While testing something for #7488, I noticed a regression on a test with @copy-temp-table with REPLACE@, introduced i... Radu Apetrii
08:47 AM User Interface Feature #7709: ABLUnit support for web clients
Greg Shah wrote:
> I was thinking that we already have a client process so we don't need to spawn. I'd prefer to av...
Hynek Cihlar
08:01 AM Database Bug #7535: Temporary tables require trailing recid component even for unique indexes
Alexandru Lungu wrote:
> What about a 7535b?
Yes, please create 7535b so that I can start working on @Commitable@.
Dănuț Filimon
07:56 AM Database Bug #7535: Temporary tables require trailing recid component even for unique indexes
What about a 7535b? Alexandru Lungu
07:48 AM Database Bug #7535: Temporary tables require trailing recid component even for unique indexes
Alexandru Lungu wrote:
> Can you post the third example here to discuss why the recid is never reclaimed? Mayb is be...
Dănuț Filimon
07:40 AM Database Bug #7535: Temporary tables require trailing recid component even for unique indexes
Dănuț Filimon wrote:
> I did 3 tests where records are deleted and then created in a loop (first test - no delete ob...
Alexandru Lungu
07:36 AM Database Bug #7535: Temporary tables require trailing recid component even for unique indexes
Alexandru Lungu wrote:
> Create a dynamic buffer with @CREATE BUFFER buf@. Do similar work you've done in your tests...
Dănuț Filimon
07:13 AM Database Feature #7323 (Review): Implement soft unique index in FWD-H2
Radu, I am planning to merge *7323a_h2* to FWD-H2. Please double check that everything is alright.
Please focus on...
Alexandru Lungu
05:32 AM Database Bug #7454: Make ValueStringIgnoreCase the default generated value for setString in FWD-H2
Alexandru Lungu wrote:
> Note that the conversion *always* adds @UPPER@ for character fields because it is independe...
Dănuț Filimon
05:20 AM Database Bug #7454: Make ValueStringIgnoreCase the default generated value for setString in FWD-H2
> This test case covers all the current problems with upper. The converted query looks like this:
Note that the co...
Alexandru Lungu
05:16 AM Database Bug #7454: Make ValueStringIgnoreCase the default generated value for setString in FWD-H2
Alexandru Lungu wrote:
> Danut, please update [[internal-documentation:H2_Database_Fork]] with @DEFAULT_IGNORE_CASE@...
Dănuț Filimon
04:45 AM Database Bug #7454: Make ValueStringIgnoreCase the default generated value for setString in FWD-H2
Dănuț Filimon wrote:
> @tt.f1 != "a"@ generates the expected @tt.f1 is null@ but without the @upper@ call. I am stil...
Alexandru Lungu
03:59 AM Database Bug #7454: Make ValueStringIgnoreCase the default generated value for setString in FWD-H2
Alexandru Lungu wrote:
> Not really; @upper(tt.f1) is null@ is generated each time you do something like @tt.f1 != "...
Dănuț Filimon
03:32 AM Database Bug #7454: Make ValueStringIgnoreCase the default generated value for setString in FWD-H2
*Committed 7454a_h2 to FWD_H2 trunk as rev. 25. Archived 7454a_h2.*
Danut, please update [[internal-documentation:...
Alexandru Lungu

08/19/2023

08:53 PM User Interface Feature #6438: frame attributes, methods and options
Further investigations shows the following:
1. Seems like the @SCROLL@ option is currently supported at runtime. At ...
Eugenie Lyzenko

08/18/2023

05:38 PM Base Language Feature #6431: implement support to allow CPINTERNAL set to UTF-8 and CP936
I think this task will drive me crazy.... Theodoros Theodorou
12:33 PM User Interface Feature #6438: frame attributes, methods and options
Branch @6438a@ was merged to trunk as revno @14699@ then it was archived. Eugenie Lyzenko
12:22 PM User Interface Feature #6438: frame attributes, methods and options
Greg Shah wrote:
> Code Review Task Branch 6438a Revision 14700
>
> The change is fine. I've edited the comments...
Eugenie Lyzenko
12:14 PM User Interface Feature #6438: frame attributes, methods and options
Code Review Task Branch 6438a Revision 14700
The change is fine. I've edited the comments and history in revision...
Greg Shah
11:35 AM User Interface Feature #6438: frame attributes, methods and options
Greg Shah wrote:
> Code Review Task Branch 6438a Revision 14699
>
> Overall the changes are good. The only probl...
Eugenie Lyzenko
10:51 AM User Interface Feature #6438: frame attributes, methods and options
> Also @GET-ITERATION()@ method for @Buffer@ object has only stub at runtime. I think we need to ask the persistence ... Greg Shah
10:50 AM User Interface Feature #6438: frame attributes, methods and options
Code Review Task Branch 6438a Revision 14699
Overall the changes are good. The only problem I see is with the imp...
Greg Shah
09:13 AM User Interface Feature #6438: frame attributes, methods and options
The @6438a@ rebased with recent trunk @14698@. The new revision is @14699@. Eugenie Lyzenko
10:53 AM Database Bug #7454: Make ValueStringIgnoreCase the default generated value for setString in FWD-H2
Dănuț Filimon wrote:
> upper(tt.f1) in ('A', 'B') and upper(tt.f1) is null look to be very specific.
Not really;...
Alexandru Lungu
09:49 AM Database Bug #7454: Make ValueStringIgnoreCase the default generated value for setString in FWD-H2
Alexandru Lungu wrote:
> Danut, please let me know if there is anything left to be worked on this task. If everythin...
Dănuț Filimon
09:39 AM Database Bug #7454 (Review): Make ValueStringIgnoreCase the default generated value for setString in FWD-H2
*Review of 7454a and 7454a_h2*
* I am OK with the changes.
* Regression tests passed.
* I am *no* longer hitting...
Alexandru Lungu
04:15 AM Database Bug #7454: Make ValueStringIgnoreCase the default generated value for setString in FWD-H2
I've looked into the problem and @upper@ methods are not reintroduced later in @FQLPreprocessor.mainWalk()@. It was a... Dănuț Filimon
07:22 AM Database Bug #7535: Temporary tables require trailing recid component even for unique indexes
Dănuț Filimon wrote:
> Can you please elaborate?
Create a dynamic buffer with @CREATE BUFFER buf@. Do similar wor...
Alexandru Lungu
06:48 AM Database Bug #7535: Temporary tables require trailing recid component even for unique indexes
Alexandru Lungu wrote:
> What happens to the other buffers (on other tables / other multiplex)? What if we iterate w...
Dănuț Filimon
04:24 AM Database Bug #7535: Temporary tables require trailing recid component even for unique indexes
*Review of 7535a*
* Doing a reclaim on @iterate@ looks right. However, I think @iterate@ is called only for the bu...
Alexandru Lungu
02:28 AM Database Bug #7535: Temporary tables require trailing recid component even for unique indexes
Eric Faulhaber wrote:
> I wouldn't expect @BY RECID DESC@ to work. That doesn't look like valid 4GL code.
>
> Tha...
Dănuț Filimon
04:26 AM Runtime Infrastructure Bug #7649: logging level for ScanDriver's "Failure in file" must be sever to log the stacktrace
Can we merge this to trunk? Constantin Asofiei
04:08 AM User Interface Feature #3931: single sign-on for virtual desktop mode
Embedded doesn't have a face, because it's supposed to be shaped by the customer, but can I summarize what it is with... Galya B

08/17/2023

07:56 PM User Interface Feature #6438 (WIP): frame attributes, methods and options
Eugenie Lyzenko
07:26 PM User Interface Feature #6438: frame attributes, methods and options
Also @GET-ITERATION()@ method for @Buffer@ object has only stub at runtime. I think we need to ask the persistence ex... Eugenie Lyzenko
05:12 PM User Interface Feature #6438: frame attributes, methods and options
The @6438a@ updated for review to revision @14697@.
This change adds conversion support and partial runtime suppor...
Eugenie Lyzenko
11:47 AM User Interface Feature #6438: frame attributes, methods and options
Greg Shah wrote:
> * @STREAM-IO@ option
> * @SCROLL@ option
> * @NO-ATTR-SPACE@ option
All of these options to ...
Eugenie Lyzenko
08:25 AM User Interface Feature #6438: frame attributes, methods and options
Created task branch @6438a@ from trunk revision @14696@. Eugenie Lyzenko
05:19 PM User Interface Bug #7515: FILL-IN: editing dates issues
Greg, I need help.
It seems, OE uses different methods for date validation and date conversion:
Both @3010124@ ...
Vladimir Tsichevski
04:42 PM User Interface Bug #7515: FILL-IN: editing dates issues
The behavior of OE I cannot explain:
# I use the @99999999@ format, and @ymd@ component order.
# I use the followin...
Vladimir Tsichevski
04:03 PM User Interface Bug #7515: FILL-IN: editing dates issues
Vladimir Tsichevski wrote:
> Vladimir Tsichevski wrote:
> > Another (anti?)issue: date validation for date format @...
Vladimir Tsichevski
04:49 PM Base Language Feature #6431: implement support to allow CPINTERNAL set to UTF-8 and CP936
... Theodoros Theodorou
07:36 AM Base Language Feature #6431: implement support to allow CPINTERNAL set to UTF-8 and CP936
Look at statements like @PUT@, @EXPORT@, @IMPORT@, @INPUT FROM@, @OUTPUT TO@. I/O in different character sets is the... Greg Shah
07:32 AM Base Language Feature #6431: implement support to allow CPINTERNAL set to UTF-8 and CP936
Can you please help me by giving me a 4GL code to do I/O in different charsets? (UTF-8 / CP936) Theodoros Theodorou
12:09 PM Database Bug #7535: Temporary tables require trailing recid component even for unique indexes
Dănuț Filimon wrote:
> When running the @test01.i with tt01 BY RECID DESC@ test, I end up with this select statement...
Eric Faulhaber
07:37 AM Database Bug #7535: Temporary tables require trailing recid component even for unique indexes
Alexandru Lungu wrote:
> Danut, can you paste here the testcase which causes the issue in #7535-35? Thank you.
The ...
Dănuț Filimon
07:07 AM Database Bug #7535: Temporary tables require trailing recid component even for unique indexes
Danut, can you paste here the testcase which causes the issue in #7535-35? Thank you. Alexandru Lungu
04:20 AM Database Bug #7535: Temporary tables require trailing recid component even for unique indexes
I also found @CompoundQuery.cleaner@ which is also a @Finalizable@ instance, it's a similar situation to @PreselectQu... Dănuț Filimon
03:58 AM Database Bug #7535: Temporary tables require trailing recid component even for unique indexes
*Committed 7535a/rev.14673*. This is a necessary change that I mentioned in #7535-29 about the @PrelectQuery.cleaner@... Dănuț Filimon
03:46 AM Database Bug #7535: Temporary tables require trailing recid component even for unique indexes
Alexandru Lungu wrote:
> Danut, regarding the recid mismatch, please refer to #7647-2. Use Ovidiu's patch just to cl...
Dănuț Filimon
03:23 AM Database Bug #7535: Temporary tables require trailing recid component even for unique indexes
> Currently I can't test this assumption because of an ongoing issue with jboss repository resource which stops the p... Alexandru Lungu
03:20 AM Database Bug #7535: Temporary tables require trailing recid component even for unique indexes
Danut, regarding the recid mismatch, please refer to #7647-2. Use Ovidiu's patch just to clear up *some* mismatches. ... Alexandru Lungu
11:15 AM Database Bug #7488: Slow fast-copy with before tables in H2
*Review of 7404a*
This is a good start, but it is still far from ideal at this point. Radu, please consider doing ...
Alexandru Lungu
06:26 AM Database Bug #7488: Slow fast-copy with before tables in H2
I've done some refactoring to @FastCopyHelper@:
* Added a cache that stores the instances of @FastCopyHelper@ based ...
Radu Apetrii
09:42 AM Database Feature #7504: Export data tool from FWD into .d files
Another configuration option to consider is to allow a dump of only a subset of tables (perhaps an inclusive or exclu... Eric Faulhaber
08:21 AM Database Feature #7504: Export data tool from FWD into .d files
Greg Shah wrote:
> We might want to consider reading the configuration from the directory. In that case it will req...
Alexandru Lungu
07:41 AM Database Feature #7504: Export data tool from FWD into .d files
Also I should point out that export will be used on production systems that won't have the standard application cfg p... Greg Shah
07:33 AM Database Feature #7504: Export data tool from FWD into .d files
We might want to consider reading the configuration from the directory. In that case it will require little or no pa... Greg Shah
07:19 AM Database Feature #7504: Export data tool from FWD into .d files
> Yes, any such utilities will often have some requirement for configuration. But we don't want them to be hard coded... Alexandru Lungu
07:11 AM Database Feature #7504: Export data tool from FWD into .d files
> Greg, by stored metadata dynamically you mean the beans we can find in the @dmo@ package (read annotations, hydrate... Greg Shah
06:49 AM Database Feature #7504: Export data tool from FWD into .d files
> I actually would like to move away from the current ant import.db and ImportWorker approach. These rely upon TRPL a... Alexandru Lungu
08:58 AM Database Bug #7454: Make ValueStringIgnoreCase the default generated value for setString in FWD-H2
Alexandru Lungu wrote:
> I still have a concern with indexOf function. It takes two strings as parameters. It attemp...
Dănuț Filimon
06:51 AM Database Bug #7454: Make ValueStringIgnoreCase the default generated value for setString in FWD-H2
Regression tests passed.
Profiling tests shown -0.3% improvement (without temporary sequences). This is modest, but ...
Alexandru Lungu
08:24 AM Conversion Tools Bug #7714: basepath cannot have trailing backslash (/)
If the @basepath@ (in @cfg/p2j.cfg.xml@) ends in a backslash (e.g. @<parameter name="basepath" value="./abl/"... Greg Shah
08:22 AM Conversion Tools Bug #7714 (New): basepath cannot have trailing backslash (/)
Greg Shah
07:20 AM Database Bug #7496: finish support for query:forward-only attribute
*Committed 7496a/rev.14656*. I brought the changes made by Stefan in #7241 (7241b) to 7496a.
I've done tests with ...
Dănuț Filimon
04:57 AM User Interface Feature #7709: ABLUnit support for web clients
> but what I've described can be achieved with Cypress: the go-to nowadays, very solid web UI testing framework with ... Greg Shah
04:54 AM User Interface Feature #7709: ABLUnit support for web clients
I was thinking that we already have a client process so we don't need to spawn. I'd prefer to avoid the spawning unl... Greg Shah
03:37 AM User Interface Feature #7709: ABLUnit support for web clients
Greg Shah wrote:
> * Rework the login/spawning approach to work from ABLUnit. [..]
> * We need to be able to launch...
Galya B

08/16/2023

03:38 PM User Interface Feature #7709: ABLUnit support for web clients
Our UI tests being written in #6856 need to be executed in both Swing and the web client. Today, the architecture of... Greg Shah
03:33 PM User Interface Feature #7709 (New): ABLUnit support for web clients
Greg Shah
03:31 PM Testing Feature #3704: enable automated testing for GUI (Swing and web clients)
I've spoken with Marian, whose team is leading the effort to write tests for the full range of UI processing. This w... Greg Shah
03:19 PM User Interface Bug #7515: FILL-IN: editing dates issues
Vladimir Tsichevski wrote:
> Another (anti?)issue: date validation for date format @99999999@:
>
> In OE, any scr...
Vladimir Tsichevski
01:37 PM User Interface Bug #7515: FILL-IN: editing dates issues
Another (anti?)issue: date validation for date format @99999999@:
In OE, any screen value, which includes a space,...
Vladimir Tsichevski
10:40 AM User Interface Bug #7515: FILL-IN: editing dates issues
Another issue to check: for the @99999999@ format, the screen values shall never be auto-completed.
Note: in trunk...
Vladimir Tsichevski
10:01 AM User Interface Bug #7515: FILL-IN: editing dates issues
Another thing I do not understand in in @date.parseWorker(..)@:... Vladimir Tsichevski
09:53 AM User Interface Bug #7515: FILL-IN: editing dates issues
Vladimir Tsichevski wrote:
> Another issue: setting the date @FILL-IN@ screen value to @///1@ crashes the client wit...
Vladimir Tsichevski
08:51 AM User Interface Bug #7515: FILL-IN: editing dates issues
Another issue: setting the date @FILL-IN@ screen value to @///1@ crashes the client with @NumberFormatException@:
...
Vladimir Tsichevski
09:00 AM Base Language Bug #5538: fix readByte() for DirStream, ProcessStream, and others
The branch 5538a has been rebased to trunk with rev no 14697. Theodoros Theodorou
06:20 AM Base Language Bug #5538: fix readByte() for DirStream, ProcessStream, and others
Since the indeterminate order of input is an existing issue, we will ignore it here. Greg Shah
06:19 AM Base Language Bug #5538: fix readByte() for DirStream, ProcessStream, and others
Anything using @INPUT THROUGH@, @INPUT-OUTPUT THROUGH@ or @OUTPUT THROUGH@ creates a child process and uses that as a... Greg Shah
06:18 AM Base Language Bug #5538: fix readByte() for DirStream, ProcessStream, and others
... Greg Shah
06:52 AM Database Bug #7535: Temporary tables require trailing recid component even for unique indexes
When running the @test01.i with tt01 BY RECID DESC@ test, I end up with this select statement: ... Dănuț Filimon
03:44 AM Database Bug #7535: Temporary tables require trailing recid component even for unique indexes
I mentioned that keys are not reclaimed in simple @FOR EACH@ blocks and after making the necessary changes to reclaim... Dănuț Filimon
06:48 AM User Interface Feature #3931: single sign-on for virtual desktop mode
OK, I'll be digging deeper. Galya B
06:48 AM User Interface Feature #3931: single sign-on for virtual desktop mode
To be clear: I'm OK with reworking things now to achieve more common code and a consistent approach. Greg Shah
06:46 AM User Interface Feature #3931: single sign-on for virtual desktop mode
Yes, that makes sense. Greg Shah
06:41 AM User Interface Feature #3931: single sign-on for virtual desktop mode
I'm not sure how these two evolved and ended up being so different. I guess they can be unified further, but I'm not ... Galya B
06:27 AM User Interface Feature #3931: single sign-on for virtual desktop mode
Greg Shah wrote:
> The key point here is that the logins can be the same.
Embedded includes all the driver resour...
Galya B
06:25 AM User Interface Feature #3931: single sign-on for virtual desktop mode
The key point here is that the logins can be the same. Greg Shah
06:25 AM User Interface Feature #3931: single sign-on for virtual desktop mode
This selector is a convenience only. It is not strictly needed in any mode, however it is just as useful in both mod... Greg Shah
06:23 AM User Interface Feature #3931: single sign-on for virtual desktop mode
Is the theme selector needed for embedded? Are there themes in embedded? Currently only virtual desktop sets the option. Galya B
05:45 AM User Interface Feature #3931: single sign-on for virtual desktop mode
> Do we want to support a default login page for embedded when the customer doesn't provide one? Currently we don't.
...
Greg Shah
05:20 AM User Interface Feature #3931: single sign-on for virtual desktop mode
If there is no FWD login page it's the same as with the custom VD login - some features won't be available before sta... Galya B
04:37 AM User Interface Feature #3931: single sign-on for virtual desktop mode
Do we want to support a default login page for embedded when the customer doesn't provide one? Currently we don't. Galya B

08/15/2023

05:16 PM Base Language Bug #5538: fix readByte() for DirStream, ProcessStream, and others
It looks like the developer who implemented the @ProcessStream@ was aware of the issue. I found in the javadoc (@Proc... Theodoros Theodorou
02:07 PM User Interface Bug #7515: FILL-IN: editing dates issues
*ISSUE* Another issue regarding @SESSION:DATE-FORMAT@ and existing date formats.
For all object types, compiled fo...
Vladimir Tsichevski
12:52 PM User Interface Feature #3931: single sign-on for virtual desktop mode
These embedded resources are really confusing, but I think I start understanding what is going on.
The FWD server ...
Galya B
11:45 AM User Interface Feature #3931: single sign-on for virtual desktop mode
Galya, the FWD analytics (which I assume you mean by 'report') is managed by @p2j/report/server/ReportWebServer@. Al... Constantin Asofiei
11:27 AM User Interface Feature #3931: single sign-on for virtual desktop mode
Constantin, can you tell if these handlers are actually used by any embedded index.html or only by report in @p2j/rep... Galya B
10:13 AM User Interface Feature #3931: single sign-on for virtual desktop mode
Greg Shah wrote:
> > The other way of spawning embedded needs some sort of authentication. Do we tackle this?
>
>...
Galya B
09:18 AM User Interface Feature #3931: single sign-on for virtual desktop mode
In directory we have the following configs related to embedded:
* @embeddedWebApp/enabled@ (boolean) used in @Standa...
Galya B
03:45 AM Database Feature #7382: Check performance of delete from vs drop table in H2
Constantin Asofiei wrote:
> What I meant in FWD-H2 is to check if the number of selected records which are to be del...
Dănuț Filimon
03:20 AM Database Bug #7641: Lower the number of Map.get() calls in the persistence layer
Made @fieldInfo@ a simple Java array, also added to @getMutableInfo@ a new parameter @fieldCount@, those meaning is n... Eduard Soltan
01:14 AM User Interface Bug #7674: FILL-IN for a character variable: cannot delete an unknown value
Vladimir Tsichevski wrote:
> The variable is first assigned the @?@ character value, then is unconditionally reset t...
Hynek Cihlar

08/14/2023

05:41 PM Base Language Bug #5538: fix readByte() for DirStream, ProcessStream, and others
In these situations we do our testcases and run them against 4GL to see the actual behaviour. Along the years we enco... Ovidiu Maxiniuc
04:13 PM Base Language Bug #5538: fix readByte() for DirStream, ProcessStream, and others
Ovidiu Maxiniuc wrote:
> My point is that, instead of @WhileBlack@ the result would be @WBlackhite@. If I am right, ...
Theodoros Theodorou
01:01 PM Base Language Bug #5538: fix readByte() for DirStream, ProcessStream, and others
I had some thought about the implementation of this issue over the weekend. The current implementation scans both @ou... Ovidiu Maxiniuc
11:20 AM Base Language Bug #5538: fix readByte() for DirStream, ProcessStream, and others
As with most of what we do, it makes most sense to implement 4GL code that can test this. Pure Java unit tests don't... Greg Shah
10:09 AM Base Language Bug #5538: fix readByte() for DirStream, ProcessStream, and others
Ovidiu Maxiniuc wrote:
> Review of 5538a/14681.
>
> I agree with the code. Just two notes about code:
> * please...
Theodoros Theodorou
05:07 PM User Interface Bug #7674: FILL-IN for a character variable: cannot delete an unknown value
Hynek Cihlar wrote:
> To me the change looks suspicious. The change addresses an issue, which is related to the @scr...
Vladimir Tsichevski
04:51 PM User Interface Bug #7674: FILL-IN for a character variable: cannot delete an unknown value
To me the change looks suspicious. The change addresses an issue, which is related to the @screen-value@ use case. Bu... Hynek Cihlar
04:46 PM User Interface Bug #7515: FILL-IN: editing dates issues
A date validation issue: the year value @001-@ is raises error 85 in OE, but is successfully parsed into value @1@ in... Vladimir Tsichevski
03:12 PM Base Language Feature #6425: SESSION handle features
Greg Shah wrote:
> Theodoros: Please list those things that are complete and those things (other than the items in #...
Theodoros Theodorou
03:09 PM User Interface Feature #3931: single sign-on for virtual desktop mode
> It's more secure, but more complicated. I can't think of a reason to remove it, since it's already there, but it ma... Greg Shah
12:07 PM User Interface Feature #3931: single sign-on for virtual desktop mode
The other way of spawning embedded needs some sort of authentication. Do we tackle this? Galya B
11:54 AM User Interface Feature #3931: single sign-on for virtual desktop mode
It's more secure, but more complicated. I can't think of a reason to remove it, since it's already there, but it may ... Galya B
11:47 AM User Interface Feature #3931: single sign-on for virtual desktop mode
> Do we support remote network interface for launching clients only for embedded? Currently it's enabled for any web ... Greg Shah
10:57 AM User Interface Feature #3931: single sign-on for virtual desktop mode
Do we support remote network interface for launching clients only for embedded? Currently it's enabled for any web cl... Galya B
01:55 PM User Interface Bug #7685: LEAVE/ENTRY events are raised before MOUSE-UP event.
See the attached testcase. You'll see wrong order of events.
As an initial discussion see #7048 entries 71 thru 74.
Stanislav Lomany
01:43 PM User Interface Bug #7685 (New): LEAVE/ENTRY events are raised before MOUSE-UP event.
Stanislav Lomany
01:27 PM User Interface Bug #7684: ENTRY event is emitted twice
See the attached testcase. ENTRY event is raised twice for all (?) widgets. Stanislav Lomany
01:15 PM User Interface Bug #7684 (Closed): ENTRY event is emitted twice
Stanislav Lomany
06:26 AM Base Language Support #4032: block/transaction processing context-local and other performance improvements
Branch 4032a was merged to trunk rev 14689 and archived.
I've created 4032b from trunk rev 14689 where there will ...
Constantin Asofiei
06:12 AM Base Language Support #4032: block/transaction processing context-local and other performance improvements
Please merge 4032a to trunk. Greg Shah
02:46 AM Database Bug #7641: Lower the number of Map.get() calls in the persistence layer
Eduard, fieldInfo (and other structures related to fields) can be 'frozen' as a Java array once this table info was b... Constantin Asofiei
02:40 AM Database Feature #7382: Check performance of delete from vs drop table in H2
Alexandru, I didn't mean to change the DELETE SQL. What I meant in FWD-H2 is to check if the number of selected reco... Constantin Asofiei

08/11/2023

10:56 AM Base Language Bug #5538 (Review): fix readByte() for DirStream, ProcessStream, and others
Greg Shah
10:56 AM Base Language Bug #5538: fix readByte() for DirStream, ProcessStream, and others
Once these items are addressed, what testing is needed before this can be merged? Greg Shah
10:55 AM Base Language Feature #6422: implement auditing support including AUDIT-POLICY and AUDIT-CONTROL
Eric: This needs your code review. Greg Shah
10:55 AM Base Language Feature #6420: implement the AUDIT-ENABLED() built-in function
Eric: This needs your code review. Greg Shah
10:53 AM Base Language Feature #6425: SESSION handle features
Some changes for this task were written in branch 4938b and were merged into trunk as revision 14688. Runtime suppor... Greg Shah
10:52 AM Base Language Feature #4391 (Closed): enhance existing SESSION:STARTUP-PARAMETERS support to honor -H -db -S -l...
The changes for this task were written in branch 4938b and were merged into trunk as revision 14688. Runtime support... Greg Shah
10:51 AM Base Language Feature #6497 (Closed): add equivalent support for the -T command line option
The changes for this task were written in branch 4938b and were merged into trunk as revision 14688. Greg Shah
10:50 AM Runtime Infrastructure Feature #7675: add missing runtime support for 4GL command line parameters
Some of the 4GL command line parameters which we can specify (in either the directory or as a bootstrap config value)... Greg Shah
10:02 AM Runtime Infrastructure Feature #7675 (New): add missing runtime support for 4GL command line parameters
Greg Shah
10:24 AM User Interface Bug #7674: FILL-IN for a character variable: cannot delete an unknown value
Greg Shah wrote:
> Eugenie/Hynek: Please review.
I have no objections.
Eugenie Lyzenko
09:56 AM User Interface Bug #7674: FILL-IN for a character variable: cannot delete an unknown value
Eugenie/Hynek: Please review. Greg Shah
09:36 AM User Interface Bug #7674: FILL-IN for a character variable: cannot delete an unknown value
Greg Shah wrote:
> Is this task related to an existing customer bug? If so, please link them.
This issue prevent...
Vladimir Tsichevski
09:27 AM User Interface Bug #7674: FILL-IN for a character variable: cannot delete an unknown value
Is this task related to an existing customer bug? If so, please link them. Greg Shah
06:46 AM User Interface Bug #7674 (Review): FILL-IN for a character variable: cannot delete an unknown value
Please, review the fix. Vladimir Tsichevski
06:44 AM User Interface Bug #7674 (WIP): FILL-IN for a character variable: cannot delete an unknown value
The fix: set the @unknownValueDisplayed@ value in the @StringFormat.CharBuf@ constructor in case an unknown variable ... Vladimir Tsichevski
09:27 AM User Interface Feature #3931: single sign-on for virtual desktop mode
Galya B wrote:
> Greg Shah wrote:
> > By #30 do you mean #3931-30?
>
> Nope, #30. This was mentioned by Constant...
Greg Shah
07:46 AM User Interface Feature #3931: single sign-on for virtual desktop mode
Greg Shah wrote:
> By #30 do you mean #3931-30?
Nope, #30. This was mentioned by Constantin in response to my ema...
Galya B
07:44 AM User Interface Feature #3931: single sign-on for virtual desktop mode
By #30 do you mean #3931-30? Greg Shah
07:20 AM User Interface Feature #3931: single sign-on for virtual desktop mode
I think #30 can be resolved with #3931. If the customer wants to prevent this type of DOS, they can replace their 4GL... Galya B
05:27 AM Database Bug #7535: Temporary tables require trailing recid component even for unique indexes
*Committed 7535a/rev.14672*. Applied the patch from #7535-26 after making another small change.
* Added reclaimKeys ...
Dănuț Filimon

08/10/2023

06:42 PM User Interface Bug #7674: FILL-IN for a character variable: cannot delete an unknown value
The boolean @StringFormat:unknownValueDisplayed@ field should handle the situation then no screen buffer is allocated... Vladimir Tsichevski
06:31 PM User Interface Bug #7674: FILL-IN for a character variable: cannot delete an unknown value
@FILL-IN@ for a character variable: if the @screen-value@ is set to an unknown value, the screen value is replaced by... Vladimir Tsichevski
06:28 PM User Interface Bug #7674 (WIP): FILL-IN for a character variable: cannot delete an unknown value
Vladimir Tsichevski
03:45 PM User Interface Bug #7673: FILL-IN for a character variable: pressing Shift+Delete inserts a dot
@FILL-IN@ for a character variable: pressing @Shift+Delete@ inserts a dot character. In OE this key combination perfo... Vladimir Tsichevski
03:43 PM User Interface Bug #7673 (New): FILL-IN for a character variable: pressing Shift+Delete inserts a dot
Vladimir Tsichevski
08:05 AM User Interface Bug #7671: View statement does not work on o not visible frame
Consider the following scenario, you have a @main-frame@, inside this there is @secondary-frame@ that has @button1@ a... Eduard Soltan
07:54 AM User Interface Bug #7671 (New): View statement does not work on o not visible frame
Eduard Soltan

08/09/2023

05:47 PM User Interface Bug #7515: FILL-IN: editing dates issues
Yet another issue:
# set @SESSION:DATE-FORMAT = "ymd".@
# create an editor for a date variable with the @9999/99/...
Vladimir Tsichevski
04:56 AM Database Bug #7535: Temporary tables require trailing recid component even for unique indexes
Using the patch posted in #7535-26, I've done similar tests to #7535-15 on 7535a using FWD-22 and all the previous pa... Dănuț Filimon

08/08/2023

08:39 AM Database Feature #7504: Export data tool from FWD into .d files
From Stefan via email:
> I created an ExportWorker class for #7504 and now I am trying to understand @ant import.d...
Greg Shah
07:35 AM User Interface Feature #3931: single sign-on for virtual desktop mode
OS passwords can't be stored in directory.xml the same way as FWD user passwords. FWD passwords are encrypted with SH... Galya B
07:03 AM Database Bug #7667: Support OUTER-JOIN with PRESELECT at conversion
Andrei, please address #7667-2. Also, please make some tests with @CAN-FIND@ for that matter. Alexandru Lungu
05:32 AM Database Bug #7667: Support OUTER-JOIN with PRESELECT at conversion
Please note that the conversion of the @CompoundQuery@ to the @PreselectQuery@ should not be applied if one of the co... Igor Skornyakov
04:15 AM Database Bug #7667 (WIP): Support OUTER-JOIN with PRESELECT at conversion
This is a continuation of the #6196 effort of optimizing @CompoundQuery@ to merge components that have OUTER-JOIN. In... Alexandru Lungu
04:06 AM Database Bug #7667 (Test): Support OUTER-JOIN with PRESELECT at conversion
Alexandru Lungu
04:40 AM Database Feature #7323: Implement soft unique index in FWD-H2
I retested with the latest changes in 7323a and got -1% improvement now. This starts looking good. At this point I am... Alexandru Lungu
03:53 AM Database Bug #7496: finish support for query:forward-only attribute
There are a few things wrong with the patch from #7496-22 which I just found out while testing.
# TemporaryBuffer do...
Dănuț Filimon
03:27 AM Database Bug #7496: finish support for query:forward-only attribute
Danut, please find a concrete example where 7496a (together with 7241b) is failing before @SessionListener.Event.TRAN... Alexandru Lungu

08/07/2023

07:01 PM Base Language Bug #5538 (Test): fix readByte() for DirStream, ProcessStream, and others
Review of 5538a/14681.
I agree with the code. Just two notes about code:
* please move comments from lines 462 an...
Ovidiu Maxiniuc
05:33 PM Base Language Feature #6425 (WIP): SESSION handle features
Theodoros Theodorou
10:19 AM Testing Support #6856: user interface tests
Vladimir Tsichevski wrote:
> > * Should we use ABLUnit for tests that also need Sikuli to handle the interactive par...
Marian Edu
09:50 AM Testing Support #6856: user interface tests
Greg Shah wrote:
> Additional items to discuss:
>
> * Should we use ABLUnit for tests that also need Sikuli to ha...
Vladimir Tsichevski
10:12 AM Database Bug #7641: Lower the number of Map.get() calls in the persistence layer
Committed on 7641a revision 14683.
@fieldInfo@ in @AbstractTempTable@ became an @ArrayList@, instead of @HashMap@....
Eduard Soltan
04:01 AM Database Bug #7641: Lower the number of Map.get() calls in the persistence layer
Created 7641a. Alexandru Lungu
10:01 AM Database Bug #7496: finish support for query:forward-only attribute
I previously tested a large customer application using the changes from 7241b/rev.14655, 7496a/rev.14655 and a few ch... Dănuț Filimon
08:40 AM Testing Feature #3704: enable automated testing for GUI (Swing and web clients)
In #6856, we already have a suite of editing tests planned for all widgets (not just FILL-IN). These will be 4GL tes... Greg Shah
04:37 AM Testing Feature #3704: enable automated testing for GUI (Swing and web clients)
Greg Shah wrote:
> What is the purpose of the project?
The short-term purpose of the project is to create automat...
Vladimir Tsichevski
05:23 AM Database Bug #7334: Reclaim used sessions to improve performance
Session reclaiming couldn't be disabled since most values either default to a set value or only disable the managing ... Dănuț Filimon

08/04/2023

05:48 PM Base Language Bug #5538 (Review): fix readByte() for DirStream, ProcessStream, and others
The implementations of the abstract @Stream.readByte()@ are the following:
ClipboardStream:...
Theodoros Theodorou
08:30 PM Base Language Bug #5538 (WIP): fix readByte() for DirStream, ProcessStream, and others
Theodoros Theodorou
02:09 PM Base Language Bug #7656: investigate performance of context-local helpers (e.g. TransactionManager.TransactionH...
Agreed! It is a really good find. Greg Shah
01:13 PM Base Language Bug #7656: investigate performance of context-local helpers (e.g. TransactionManager.TransactionH...
Greg, this looks promising.
The @access@ synthetic methods are a pitfall of using inner classes and assuming a pri...
Constantin Asofiei
10:42 AM Base Language Bug #7656: investigate performance of context-local helpers (e.g. TransactionManager.TransactionH...
I've done the test. The results are quite good. I tested with 7156b/rev. 14663 and your changes are close to -0.5%. Alexandru Lungu
10:08 AM Database Bug #7641: Lower the number of Map.get() calls in the persistence layer
In @TempTableMapper@ there is a @private final Map<TempTable, LegacyTableInfo> p2j = new HashMap<>();@ which should b... Eduard Soltan
09:18 AM User Interface Feature #3931: single sign-on for virtual desktop mode
Greg Shah wrote:
> The fact that you are in a context now and spawn another context is what I am calling "forking". ...
Galya B
09:06 AM User Interface Feature #3931: single sign-on for virtual desktop mode
Greg Shah wrote:
> > > That is why we have a complex pipe approach used to deliver the password to the spawner, beca...
Galya B
09:02 AM User Interface Feature #3931: single sign-on for virtual desktop mode
> > That is why we have a complex pipe approach used to deliver the password to the spawner, because pipes are privat... Greg Shah
09:00 AM User Interface Feature #3931: single sign-on for virtual desktop mode
Greg Shah wrote:
> The more conditions we add, the more we have to think about how we use it and the more likely a r...
Galya B
08:53 AM User Interface Feature #3931: single sign-on for virtual desktop mode
Greg Shah wrote:
> In regard to the proposed UI changes, I think 1 and 3 are good to go. For 2, I would prefer if i...
Galya B
08:52 AM User Interface Feature #3931: single sign-on for virtual desktop mode
Greg Shah wrote:
> That is why we have a complex pipe approach used to deliver the password to the spawner, because ...
Galya B
08:48 AM User Interface Feature #3931: single sign-on for virtual desktop mode
In regard to the proposed UI changes, I think 1 and 3 are good to go. For 2, I would prefer if it is more obvious th... Greg Shah
08:47 AM User Interface Feature #3931: single sign-on for virtual desktop mode
Greg Shah wrote:
> > > The current use of @trustedspawner@ is a kind of "forking" because it enables spawning from a...
Galya B
08:43 AM User Interface Feature #3931: single sign-on for virtual desktop mode
> The default os user password will have to be stored as env var, it can't be entered as plain text in @webClient@ co... Greg Shah
08:41 AM User Interface Feature #3931: single sign-on for virtual desktop mode
> > > @remotelaunchoption@ checks to be executed only for remote spawns (using @WebClientLauncher@ network interface)... Greg Shah
05:19 AM User Interface Feature #3931: single sign-on for virtual desktop mode
The default os user password will have to be stored as env var, it can't be entered as plain text in @webClient@ conf... Galya B
04:15 AM User Interface Feature #3931: single sign-on for virtual desktop mode
Here are the mockups for the Admin UI: 1. OS users (new page) 2. OS user password update (new dialog), 3. FWD user ed... Galya B
01:29 AM User Interface Feature #3931: single sign-on for virtual desktop mode
Greg Shah wrote:
> The current use of @trustedspawner@ is a kind of "forking" because it enables spawning from an ex...
Galya B
01:12 AM User Interface Feature #3931: single sign-on for virtual desktop mode
Greg Shah wrote:
> > @remotelaunchoption@ checks to be executed only for remote spawns (using @WebClientLauncher@ ne...
Galya B
06:51 AM Database Feature #7382: Check performance of delete from vs drop table in H2
From Constantin's solution, I think we can just generate @delete from tt1@ when we know this as the last multiplex is... Alexandru Lungu

08/03/2023

04:05 PM User Interface Feature #3931: single sign-on for virtual desktop mode
Galya B wrote:
> Greg Shah wrote:
> > > > > RPC WebClientLauncher.spawn with SSO
> > What you are proposing is not...
Greg Shah
04:02 PM User Interface Feature #3931: single sign-on for virtual desktop mode
> @remotelaunchoption@ checks to be executed only for remote spawns (using @WebClientLauncher@ network interface). Ot... Greg Shah
03:50 PM User Interface Feature #3931: single sign-on for virtual desktop mode
> 1. @ssopluginoption@ is enough to support a default fwd user.
This is what I suggested previously, so I tend to ...
Greg Shah
10:21 AM User Interface Feature #3931: single sign-on for virtual desktop mode
Can you share client configs for @<security>@ and @<access>@ for a broker running against testcases server? Galya B
01:43 AM User Interface Feature #3931: single sign-on for virtual desktop mode
Greg Shah wrote:
> > > > RPC WebClientLauncher.spawn with SSO
> What you are proposing is not clear to me. I espec...
Galya B
01:38 AM User Interface Feature #3931: single sign-on for virtual desktop mode
I need confirmation that:
1. @ssopluginoption@ is enough to support a default fwd user.
2. @webClient/defaultAccoun...
Galya B
12:18 PM User Interface Bug #7657: 8-bit character entry problem in ChUI
As reported by one of our customers:
> I did notice one other thing. It occurs both in the Hotel sample app as wel...
Greg Shah
12:18 PM User Interface Bug #7657 (Review): 8-bit character entry problem in ChUI
Greg Shah
11:57 AM Base Language Bug #7656: investigate performance of context-local helpers (e.g. TransactionManager.TransactionH...
I've tested with ControlFlowOps, ProcedureManager and TransactionManager. I don't see a definite improvement, the ti... Constantin Asofiei
08:23 AM Base Language Bug #7656: investigate performance of context-local helpers (e.g. TransactionManager.TransactionH...
Greg Shah wrote:
> Is it worth it to manually try the changes to TM so we know the benefit?
Yes, I think so. There...
Constantin Asofiei
08:19 AM Base Language Bug #7656: investigate performance of context-local helpers (e.g. TransactionManager.TransactionH...
Is it worth it to manually try the changes to TM so we know the benefit? Greg Shah
08:13 AM Base Language Bug #7656: investigate performance of context-local helpers (e.g. TransactionManager.TransactionH...
Greg Shah wrote:
> Did you test the change for the TM to see what the performance difference is?
Not yet. I'm work...
Constantin Asofiei
08:11 AM Base Language Bug #7656: investigate performance of context-local helpers (e.g. TransactionManager.TransactionH...
The lesson here is that compiler generated helpers are often costly. Greg Shah
08:10 AM Base Language Bug #7656: investigate performance of context-local helpers (e.g. TransactionManager.TransactionH...
Good find. This seems like it should have good potential.
Did you test the change for the TM to see what the perf...
Greg Shah
08:10 AM Base Language Bug #7656: investigate performance of context-local helpers (e.g. TransactionManager.TransactionH...
The same happens when accessing a private field: access to a private field from a non-defining class will be done via... Constantin Asofiei
06:38 AM Base Language Bug #7656: investigate performance of context-local helpers (e.g. TransactionManager.TransactionH...
In the profiler, I noticed that for i.e. @TransactionManager$TransactionHelper.deregisterOutputParameterAssigner@, th... Constantin Asofiei
06:22 AM Base Language Bug #7656 (New): investigate performance of context-local helpers (e.g. TransactionManager.Transa...
Constantin Asofiei
11:17 AM Base Language Feature #6493: add equivalent support for the command line parameters -ucc and -utf8intatchar
If this support requires "wide character" support in ncurses, then we may need some changes to ensure our support mat... Greg Shah
10:10 AM Base Language Feature #6431: implement support to allow CPINTERNAL set to UTF-8 and CP936
> As I understand, we are trying to emulate a keyboard based on the -cpinternal?
Not exactly. In the 4GL, the @C...
Greg Shah
08:05 AM Database Feature #7323: Implement soft unique index in FWD-H2
I've committed to 7323a, rev. 14690 and 7323a_h2, rev. 23. I added support for the @DirectAccess@ idea mentioned in #... Radu Apetrii
05:05 AM Database Feature #7323: Implement soft unique index in FWD-H2
Alexandru Lungu wrote:
> *Radu, what is your input on this idea?*
I will investigate the aspects mentioned and I wi...
Radu Apetrii
05:00 AM Database Feature #7323: Implement soft unique index in FWD-H2
I don't expect a miracle from @VALIDATE@, but 30k SELECT statements are in fact a lot (from my POV). I agree that the... Alexandru Lungu
04:28 AM Database Feature #7323: Implement soft unique index in FWD-H2
Alexandru Lungu wrote:
> Clearly we should see better improvement as now we have ~28k less SELECT statements, right?...
Radu Apetrii
03:26 AM Database Bug #7488: Slow fast-copy with before tables in H2
Radu, there is some work in #7404 regarding the moving of most of the copy-temp-table operations to fast-copy using h... Alexandru Lungu
 

Also available in: Atom