Project

General

Profile

Activity

From 12/29/2023 to 01/27/2024

01/27/2024

03:21 PM User Interface Bug #8213 (Review): Browse: NPE when pressing Shift-TAB in the first column cell
Stanislav Lomany
03:21 PM User Interface Bug #8213 (WIP): Browse: NPE when pressing Shift-TAB in the first column cell
The arrow keys issue was moved to #8226.
Shift-tab NPE will be fixed in #8225.
This task can be closed.
Stanislav Lomany
01:27 PM User Interface Bug #8213: Browse: NPE when pressing Shift-TAB in the first column cell
All arrow keys (up, down, left, right) do not work for any widget, so I'll create a separate issue for it. Stanislav Lomany
01:01 PM User Interface Bug #8213: Browse: NPE when pressing Shift-TAB in the first column cell
Meanwhile all other numpad buttons (@PgUp@, @PgDown@, @Home@, @End@) work the same as their non-numpad analogs. Vladimir Tsichevski
12:59 PM User Interface Bug #8213: Browse: NPE when pressing Shift-TAB in the first column cell
Stanislav Lomany wrote:
> > Also, navigation with @Down-Arrow@ and @Up-Arrow@ does not work in FWD.
>
> Vladimir,...
Vladimir Tsichevski
12:27 PM User Interface Bug #8213: Browse: NPE when pressing Shift-TAB in the first column cell
> Also, navigation with @Down-Arrow@ and @Up-Arrow@ does not work in FWD.
Vladimir, could you give a reproduction ...
Stanislav Lomany
03:11 PM User Interface Bug #8226: Arrow keys on numpad do not work in FWD
All numpad arrow keys (Up, Down, Left, Right) do not work for any widget in FWD.
Meanwhile all other numpad buttons ...
Stanislav Lomany
02:53 PM User Interface Bug #8226 (New): Arrow keys on numpad do not work in FWD
Stanislav Lomany

01/26/2024

10:50 AM Database Feature #6628: port PostgreSQL native user defined functions to MariaDB
Can we merge this to trunk? Greg Shah
10:06 AM Database Bug #7999: FWD does not honor FIELDS/EXCEPT at dynamic queries
Eduard, please address the review to get this done. Alexandru Lungu
09:27 AM User Interface Bug #8204: REGRESSION: separator should not show in a new date editing browse shell for unknown v...
Greg Shah wrote:
> What testing is needed?
I'd like to run Majic suite with 6667i, but the repo should be rebased...
Vladimir Tsichevski
09:07 AM User Interface Bug #8204 (Internal Test): REGRESSION: separator should not show in a new date editing browse she...
What testing is needed? Greg Shah
08:41 AM User Interface Bug #8204: REGRESSION: separator should not show in a new date editing browse shell for unknown v...
Stanislav Lomany wrote:
> I'm OK with the changes. One minor typo correction: @our fill-in has to know it belong so ...
Vladimir Tsichevski
08:40 AM User Interface Bug #8204: REGRESSION: separator should not show in a new date editing browse shell for unknown v...
Greg Shah wrote:
> Stanislav/Hynek: Please review ASAP.
The changes look good.
Hynek Cihlar
08:28 AM User Interface Bug #8204: REGRESSION: separator should not show in a new date editing browse shell for unknown v...
I'm OK with the changes. One minor typo correction: @our fill-in has to know it belong so a browse *before* at the ti... Stanislav Lomany
07:48 AM User Interface Bug #8204: REGRESSION: separator should not show in a new date editing browse shell for unknown v...
Stanislav/Hynek: Please review ASAP.
I'd like to get this change into trunk quickly.
Greg Shah
07:34 AM User Interface Bug #8204 (Review): REGRESSION: separator should not show in a new date editing browse shell for ...
Another fixes are required:
# in @Browse.createEditingFillIn@ the browse column must be set in the connected @FILL...
Vladimir Tsichevski
09:17 AM Runtime Infrastructure Feature #6692: move FWD to Java 17
While regression testing I found another IllegalAccessException:... Tomasz Domin
08:35 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
Galya B wrote:
> Greg Shah wrote:
> > In case 1, the presence of a valid @theme/name@ means there should be no drop...
Greg Shah
08:32 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
Greg Shah wrote:
> In case 1, the presence of a valid @theme/name@ means there should be no drop-down present in the...
Galya B
08:30 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
In case 1, the presence of a valid @theme/name@ means there should be no drop-down present in the UI. This changes y... Greg Shah
08:22 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
This is the test plan I'll be executing:
Case 1
Conditions:
* @theme/name@ is configured with a valid theme, dif...
Galya B
07:28 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
Galya B wrote:
> Greg Shah wrote:
> > > The empty option was there exactly to provide a user in a hurry to have the...
Greg Shah
01:38 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
Greg Shah wrote:
> > The empty option was there exactly to provide a user in a hurry to have their previously select...
Galya B
05:38 AM Database Support #6714: check if there is an optimization opportunity when copying temp-tables based on mu...
I retested the changes (the patch from #6714-14) but had to make two small adjustments:
* The usage of the @Procedur...
Dănuț Filimon
05:31 AM Runtime Infrastructure Bug #7443: performance of CentralLogger
Tomasz Domin wrote:
> Galya B wrote:
> > Tomasz Domin wrote:
> > > Galya B wrote:
> > > I was considering that op...
Galya B
05:28 AM Runtime Infrastructure Bug #7443: performance of CentralLogger
Galya B wrote:
> Tomasz Domin wrote:
> > Galya B wrote:
> > I was considering that option but it seems @java.util....
Tomasz Domin
05:12 AM Runtime Infrastructure Bug #7443: performance of CentralLogger
Tomasz Domin wrote:
> Galya B wrote:
> I was considering that option but it seems @java.util.logging.LogRecord@ was...
Galya B
03:51 AM Runtime Infrastructure Bug #7443: performance of CentralLogger
Galya B wrote:
> The new class should in be in the package @com.goldencode.p2j.util.logging@. As for the name (since...
Tomasz Domin

01/25/2024

03:36 PM Database Bug #8214: Split Persister into SQLPersister and InMemoryPersister
Eric Faulhaber wrote:
> In the absence of the @force-no-undo-temp-tables@ configuration option being set to @true@, ...
Alexandru Lungu
01:23 PM Database Bug #8214: Split Persister into SQLPersister and InMemoryPersister
In the absence of the @force-no-undo-temp-tables@ configuration option being set to @true@, any transaction on the @_... Eric Faulhaber
06:39 AM Database Bug #8214 (WIP): Split Persister into SQLPersister and InMemoryPersister
Comitted 8214a_h2 the changes in FWD-H2 to do update on a single column using direct-access.
I also have the FWD cha...
Alexandru Lungu
10:59 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
> Greg, are you on board that the previously selected theme will not be restored on the login screen?
Yes.
> Th...
Greg Shah
08:57 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
Greg, are you on board that the previously selected theme will not be restored on the login screen? Galya B
08:26 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
That's why I said:
> The now presented requirements would mean that theme is restored from client storage only wit...
Galya B
08:24 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
The empty option was there exactly to provide a user in a hurry to have their previously selected theme restored afte... Galya B
08:21 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
Greg Shah wrote:
> Here is what to select by default, in order of higher to lower precedence:
>
> a. If there is ...
Galya B
07:51 AM Database Support #6714: check if there is an optimization opportunity when copying temp-tables based on mu...
Eric Faulhaber wrote:
> Can this be closed? Is there anything to be reviewed and used from this task, or has it been...
Dănuț Filimon
05:54 AM Database Feature #7382 (Review): Check performance of delete from vs drop table in H2
With the changes you mentioned, the amount of time spent iterating in 100 runs of the performance tests went down fro... Alexandru Donica
05:10 AM Database Bug #7252 (WIP): Use direct-access to support for-each queries without WHERE and BY clauses
I'll move this back to WIP because I encounter a NPE in @DataSetSDOHelper.getDataObjects@ in a test. I'm looking into... Radu Apetrii
04:06 AM Database Feature #6496 (Review): add equivalent support for -trig command line option
Commited to branch 6496b rev 14943. Alexandru Donica
03:57 AM Runtime Infrastructure Bug #7443: performance of CentralLogger
The new class should in be in the package @com.goldencode.p2j.util.logging@. As for the name (since @CentralLogRecord... Galya B
03:52 AM Runtime Infrastructure Bug #7443: performance of CentralLogger
#7143-253, #7143-255.
Instead of replacing @java.util.logging.LogRecord@ there could be another option, extend it ...
Galya B
03:20 AM Runtime Infrastructure Bug #7443: performance of CentralLogger
Galya B wrote:
> Tomasz Domin wrote:
> > Galya B wrote:
> > > r14634: Fixed Java (@java.util.logging.LogRecord#nee...
Tomasz Domin
03:11 AM Runtime Infrastructure Bug #7443: performance of CentralLogger
Tomasz Domin wrote:
> Galya B wrote:
> > r14634: Fixed Java (@java.util.logging.LogRecord#needToInferCaller@ set wi...
Galya B
03:05 AM Runtime Infrastructure Bug #7443: performance of CentralLogger
Galya B wrote:
> r14634: Fixed Java (@java.util.logging.LogRecord#needToInferCaller@ set with reflection to stop hea...
Tomasz Domin
03:54 AM Base Language Feature #6417: cleanup some known items in appserver support
The SOAP envelop is different.
SoapUI:...
Galya B
09:28 PM Database Feature #7020: always use "expanded" extent fields
Constantin, besides me taking forever to review 7020b, we still have the issue with the Client Proxy generation block... Eric Faulhaber

01/24/2024

04:17 PM Runtime Infrastructure Feature #6692: move FWD to Java 17
Tomasz Domin wrote:
> Tomasz Domin wrote:
> After starting regression tests which is more or less the real applicat...
Tomasz Domin
09:50 AM Runtime Infrastructure Feature #6692: move FWD to Java 17
Tomasz Domin wrote:
> Regarding Java 17 and modules - there are few places I need to add @--add-opens@ JVM option to...
Tomasz Domin
01:56 PM User Interface Bug #8204: REGRESSION: separator should not show in a new date editing browse shell for unknown v...
Greg Shah wrote:
> What testing is needed?
Running Majic tests is the only tests I can think of for now.
Vladimir Tsichevski
01:43 PM User Interface Bug #8204 (Internal Test): REGRESSION: separator should not show in a new date editing browse she...
What testing is needed? Greg Shah
11:33 AM User Interface Bug #8204: REGRESSION: separator should not show in a new date editing browse shell for unknown v...
I'm OK with the changes. Stanislav Lomany
10:34 AM User Interface Bug #8204: REGRESSION: separator should not show in a new date editing browse shell for unknown v...
Stanislav: Please review. Greg Shah
07:06 AM User Interface Bug #8204 (Review): REGRESSION: separator should not show in a new date editing browse shell for ...
Stanislav Lomany wrote:
> > if (var == null || var.isUnknown())
>
> Vladimir, your change should be limited to @d...
Vladimir Tsichevski
11:35 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
Greg Shah wrote:
> > If I haven't made changes, forked session and auto-logged users would have never even had the c...
Eugenie Lyzenko
10:55 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
Greg Shah wrote:
> Or because it is added, a stored preference will become visible. My point is that it does not ma...
Galya B
10:25 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
Or because it is added, a stored preference will become visible. My point is that it does not matter. We don't need... Greg Shah
09:57 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
Greg Shah wrote:
> > > The only thing I can think of that is not explicitly specified there is how to treat the pref...
Galya B
09:53 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
Eugenie, I'll be waiting for your confirmation that you don't find an issue with the requirements in #8074-101, if so. Galya B
09:46 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
> 1. Well, this is how client storage works more or less (especially Win registry) and this behavior was described in... Greg Shah
09:22 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
I want to get closure, but I also want to make sure every false or troublesome statement has been addressed.
Eugen...
Galya B
09:02 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
> If I haven't made changes, forked session and auto-logged users would have never even had the chance of seeing anyt... Greg Shah
01:47 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
Eugenie, I wasn't the person implementing UI themes and noone nowhere has documented how insignificant the feature is... Galya B
11:15 AM Base Language Feature #6417: cleanup some known items in appserver support
... Galya B
02:16 AM Base Language Feature #6417: cleanup some known items in appserver support
Galya B wrote:
> Do we expect it to be some kind of misconfiguration in testcases, since prod apps are working fine?...
Constantin Asofiei
02:15 AM Base Language Feature #6417: cleanup some known items in appserver support
I was thinking about redirect, but I was expecting @301@ instead, so didn't dig deeper. In Jetty logs on the server n... Galya B
10:07 AM Database Bug #8214: Split Persister into SQLPersister and InMemoryPersister
I agree with you Greg, @.batch@ itself is a very useful construct if you want to update a single record on multiple f... Alexandru Lungu
09:12 AM Database Bug #8214: Split Persister into SQLPersister and InMemoryPersister
Long ago, the 4GL was changed to implement the @ASSIGN@ statement. One important reason (maybe *the* important reaso... Greg Shah
02:22 AM Database Bug #8214: Split Persister into SQLPersister and InMemoryPersister
I constantly see @Proxy.set...@ in the top bottlenecks we have in the FWD API. This is not because they are really sl... Alexandru Lungu
02:12 AM Database Bug #8214 (WIP): Split Persister into SQLPersister and InMemoryPersister
Alexandru Lungu
05:30 AM User Interface Bug #8213: Browse: NPE when pressing Shift-TAB in the first column cell
Also, navigation with @Down-Arrow@ and @Up-Arrow@ does not work in FWD. Vladimir Tsichevski
02:06 AM Database Support #6679 (Internal Test): H2 general performance tuning
This task didn't have quite a well-define purpose. It was mostly "do your best improving H2". I can't appreciate a pr... Alexandru Lungu

01/23/2024

04:44 PM Database Bug #6829 (Closed): H2 forces re-parse of all prepared statements when metadata is changed
There is no customer-specific testing for this improvement; any bugs will be dealt with separately. Accordingly, I'm ... Eric Faulhaber
04:38 PM Database Feature #6830 (Closed): find and fix all SQL SELECT statements with inlined literal arguments, an...
Eric Faulhaber
04:36 PM Database Support #6714: check if there is an optimization opportunity when copying temp-tables based on mu...
Can this be closed? Is there anything to be reviewed and used from this task, or has it been absorbed/superseded by s... Eric Faulhaber
04:33 PM Database Support #4702 (Closed): write temp-table performance test cases
I think this task has served its purpose in guiding our performance work with H2. Eric Faulhaber
04:31 PM Database Bug #4057: h2 performance degradation
Can we close this task? Eric Faulhaber
04:29 PM Database Support #6679: H2 general performance tuning
We have long since decided not to move ahead with MVStore, and we have made a significant investment in improving H2 ... Eric Faulhaber
04:01 PM User Interface Bug #8213: Browse: NPE when pressing Shift-TAB in the first column cell
# Open a @BROWSE@ widget with at least one cell. Set focus to any cell in the first column from the left.
# Press @S...
Vladimir Tsichevski
03:55 PM User Interface Bug #8213 (Closed): Browse: NPE when pressing Shift-TAB in the first column cell
Vladimir Tsichevski
02:19 PM User Interface Bug #8204 (WIP): REGRESSION: separator should not show in a new date editing browse shell for unk...
Stanislav Lomany wrote:
> > if (var == null || var.isUnknown())
>
> Vladimir, your change should be limited to @d...
Vladimir Tsichevski
02:16 PM User Interface Bug #8204: REGRESSION: separator should not show in a new date editing browse shell for unknown v...
> if (var == null || var.isUnknown())
Vladimir, your change should be limited to @date@, @datetime@ and @datetime-...
Stanislav Lomany
09:48 AM User Interface Bug #8204 (Review): REGRESSION: separator should not show in a new date editing browse shell for ...
Greg Shah wrote:
> Stanislav: Please review.
>
> Vladimir: Please put the change in a branch. What remains in th...
Vladimir Tsichevski
08:01 AM User Interface Bug #8204: REGRESSION: separator should not show in a new date editing browse shell for unknown v...
Stanislav: Please review.
Vladimir: Please put the change in a branch. What remains in this task?
Greg Shah
02:08 PM Database Bug #8212: FILL operations do not work correctly with active dataset relations
While working on #8178 I noticed some differences in the way FWD populates the database when there are active dataset... Ovidiu Maxiniuc
01:59 PM Database Bug #8212 (New): FILL operations do not work correctly with active dataset relations
Ovidiu Maxiniuc
02:04 PM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
Let me share my generic thoughts here. Just my vision.
Every application has it's commonly used life cycle. And we...
Eugenie Lyzenko
01:02 PM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
> Even if you repeat 100 times now that it's "always to be used" it needs something more to be true.
You asked for...
Greg Shah
10:12 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
I believe we need to invent the @dev@ flag in our configurations (it disables all features not meant for production i... Galya B
09:38 AM User Interface Bug #8074 (WIP): Preferred UI Theme not selected in web with auto-login and forked sessions
Greg Shah
09:38 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
As mentioned previously, exposing the theme to the end user was never intended to be an important feature. It was im... Greg Shah
08:30 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
Eugenie Lyzenko wrote:
> Some weird addition.
>
> If web client application explicitly loads some theme (@Windows...
Galya B
07:17 PM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
Eugenie Lyzenko wrote:
> Greg Shah wrote:
> > > It should not be an issue to delay the review, since the proper co...
Eugenie Lyzenko
01:54 PM Runtime Infrastructure Feature #6692: move FWD to Java 17
I've cleaned @6692@ from compiler warnings by updating FWD code.
There were two cases where I had to add @deprecated...
Tomasz Domin
12:41 PM Runtime Infrastructure Feature #6692: move FWD to Java 17
> Greg, are there any broader guidelines regarding FWD and Java Modules (JPMS) ?
Not yet. I am open to recommenda...
Greg Shah
10:04 AM Runtime Infrastructure Feature #6692: move FWD to Java 17
Regarding Java 17 and modules - there are few places I need to add @--add-opens@ JVM option to allow access of base m... Tomasz Domin
10:00 AM Runtime Infrastructure Feature #6692: move FWD to Java 17

There are 27 warnings mainly related with code deprecation. I will check them one by one and try to clear them mini...
Tomasz Domin
12:32 PM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
Eric: Please review. Greg Shah
06:46 AM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
Created 7045c and committed a changed regarding the removal of @.next@ calls inside the @BlockManager.forEach@ body. ... Alexandru Lungu
12:28 PM Database Feature #4722 (Test): data import should be able to run with only the converted application jar f...
Roger Borrello
09:16 AM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
Branch 4722c was merged to trunk at revision 14942 and was archived. Roger Borrello
09:01 AM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
You can merge to trunk now. Greg Shah
08:56 AM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
Branch 4722c was rebased to trunk_14941 and is at revision 14942.
I believe this is ready for merge.
Roger Borrello
12:22 PM Database Bug #7448 (Rejected): Optimize FWD-H2 ValueTimestampTimeZone and maybe avoid caching
Greg Shah
08:32 AM Database Bug #7448: Optimize FWD-H2 ValueTimestampTimeZone and maybe avoid caching
I am ok with rejecting this task. Alexandru Donica
03:59 AM Database Bug #7448: Optimize FWD-H2 ValueTimestampTimeZone and maybe avoid caching
According to your findings, I think we can reject this task. The improvement is too small to tackle this. T
If Ale...
Alexandru Lungu
11:24 AM Base Language Feature #6417: cleanup some known items in appserver support
Galya, I have an explanation for the 302 problem. The reason is the trailing '/' char in the request URL; it is not ... Constantin Asofiei
09:51 AM Base Language Feature #6417: cleanup some known items in appserver support
Constantin Asofiei wrote:
> Galya, did you find a way to make @-nohostverify@ work again?
SOAP requests seem to be ...
Galya B
09:46 AM Base Language Feature #6417: cleanup some known items in appserver support
Galya, did you find a way to make @-nohostverify@ work again?
Otherwise, AFAIK FWD server sockets bind to all host...
Constantin Asofiei
09:27 AM Base Language Feature #6417: cleanup some known items in appserver support
Constantin Asofiei wrote:
> There is also a @file-cvt-list.txt.rest_and_appserver@, to run the plain appserver clien...
Galya B
10:43 AM Database Feature #6496: add equivalent support for -trig command line option
Alexandru [ad], 7156b is mostly like a fast-paced trunk. We periodically rebase it. We only commit hot patches there.... Alexandru Lungu
09:32 AM Database Feature #6496: add equivalent support for -trig command line option
I tested large app and performance tests with and without changes. The performance tests did not seem to have many tr... Alexandru Donica
10:03 AM Database Bug #7252 (Review): Use direct-access to support for-each queries without WHERE and BY clauses
I've committed to both 7252b and 7252b_h2 the following things:
* 7252b *rev. 14933* - Added attempt to solve a Sele...
Radu Apetrii
09:36 AM User Interface Bug #8210: REGRESSION: separator should not show in date editing FILL-IN in ChUI when FILL-IN is ...
Greg Shah wrote:
> When did we fix that? As far as I know, #7019 is still open to resolve that auto-zap issue.
S...
Vladimir Tsichevski
08:56 AM User Interface Bug #8210: REGRESSION: separator should not show in date editing FILL-IN in ChUI when FILL-IN is ...
When did we fix that? As far as I know, #7019 is still open to resolve that auto-zap issue. Greg Shah
08:08 AM User Interface Bug #8210: REGRESSION: separator should not show in date editing FILL-IN in ChUI when FILL-IN is ...
Greg Shah wrote:
> Is this related to the auto-zap regression reported by Stanislav in #7143-583?
This issue is o...
Vladimir Tsichevski
08:03 AM User Interface Bug #8210: REGRESSION: separator should not show in date editing FILL-IN in ChUI when FILL-IN is ...
Is this related to the auto-zap regression reported by Stanislav in #7143-583? Greg Shah
09:22 AM Database Feature #7382: Check performance of delete from vs drop table in H2
7382a is branched for trunk, ready to be merged. If you want to test, you need to manually port the changes to 7156b.... Alexandru Lungu
08:36 AM Database Feature #7382: Check performance of delete from vs drop table in H2
Very well I will try to improve @Update@, but before that, should the branch 7382a be a copy of the trunk, or of bran... Alexandru Donica
06:29 AM Database Feature #7382: Check performance of delete from vs drop table in H2
Alexandru [ad], I also notices a slight performance improvement possibility in @Update@. There is a @setClauseCols@ b... Alexandru Lungu
03:58 AM Database Feature #7382: Check performance of delete from vs drop table in H2
I think we can go ahead with this improvement. Even if it is small, it looks like it is quite risk free and easy to i... Alexandru Lungu
08:23 AM Base Language Feature #4392: add -pf support for appserver CONNECT() method
Ovidiu Maxiniuc wrote:
> * @ConnectionManager.java@:
> ** line 685 and next: the values of @@param@, @@return@, and...
Galya B
03:35 AM Database Feature #6628: port PostgreSQL native user defined functions to MariaDB
I fixed the history entries in *6628a/rev.14937*. Dănuț Filimon
03:19 AM Database Feature #6628: port PostgreSQL native user defined functions to MariaDB
I've looked at 6628a rev 14936 and I think we need to solve this before merging into 7156b/trunk:
* @FWDPostgreSQLCo...
Constantin Asofiei
03:00 AM Database Feature #6628: port PostgreSQL native user defined functions to MariaDB
There is no difference. Dănuț Filimon
02:06 AM Database Feature #6628: port PostgreSQL native user defined functions to MariaDB
Danut, can you make a diff between the DDL without 6628a and the ones with 6628a? Alexandru Lungu
02:05 AM Database Feature #6628: port PostgreSQL native user defined functions to MariaDB
Constantin Asofiei wrote:
> Danut, did you re-generate the DDLs for the #7156 POC app, when you did the tests?
I on...
Dănuț Filimon
02:04 AM Database Feature #7020: always use "expanded" extent fields
Ovidiu, can you rebase 7020b? I will like to pick it up and do some review / tests / profiling with it. Alexandru Lungu

01/22/2024

04:43 PM Base Language Feature #4392 (Internal Test): add -pf support for appserver CONNECT() method
I did a review of all changes since 14864 (since it was branched from trunk). I found no severe issues, more like cod... Ovidiu Maxiniuc
04:26 PM User Interface Bug #8204: REGRESSION: separator should not show in a new date editing browse shell for unknown v...
Vladimir Tsichevski wrote:
> The proposed solution is to change the line:
This change fixes the browse date cell ...
Vladimir Tsichevski
03:51 PM User Interface Bug #8210: REGRESSION: separator should not show in date editing FILL-IN in ChUI when FILL-IN is ...
In ChUI @FILL-IN@ is cleared with @Ctrl-Z@, this should reset date editor screen value to empty string. Currently, th... Vladimir Tsichevski
03:33 PM User Interface Bug #8210 (Test): REGRESSION: separator should not show in date editing FILL-IN in ChUI when FILL...
Vladimir Tsichevski
10:40 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
Also, let me note that a customer using a custom login page is responsible for sending the selected theme the same wa... Galya B
10:16 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
Greg Shah wrote:
> > It should not be an issue to delay the review, since the proper configuration in directory cur...
Eugenie Lyzenko
10:14 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
Greg Shah wrote:
> > It should not be an issue to delay the review, since the proper configuration in directory cur...
Galya B
10:05 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
> It should not be an issue to delay the review, since the proper configuration in directory currently does the work... Greg Shah
09:54 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
Greg, I'll be waiting for clarification to the question in #8074-92. Galya B
09:53 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
Eugenie Lyzenko wrote:
> Greg Shah wrote:
> > Eugenie: Please review the fix.
>
> I have no objections for chang...
Eugenie Lyzenko
09:26 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
I will need a day or so to completely implement the new requirement. It involves two server-side login endpoints and ... Galya B
09:10 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
> This is yet another new requirement that never existed in the original code.
OK, then that was a bug.
> So wh...
Greg Shah
08:58 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
Greg Shah wrote:
> If the customer has configured a specific theme in the directory, that should always take precede...
Galya B
08:56 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
If the customer has configured a specific theme in the directory, that should always take precedence. An end user sh... Greg Shah
08:54 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
Eugenie Lyzenko wrote:
> Greg Shah wrote:
> > Eugenie: Please review the fix.
>
> I have no objections for chang...
Galya B
08:45 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
Greg Shah wrote:
> Eugenie: Please review the fix.
I have no objections for changes in rev @14917@.
But I thin...
Eugenie Lyzenko
07:32 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
Eugenie: Please review the fix. Greg Shah
02:28 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
Eugenie Lyzenko wrote:
> Galya,
>
> The problem is the preferred theme should be loaded from:
> [...]
>
> Cur...
Galya B
10:35 AM Database Feature #6628: port PostgreSQL native user defined functions to MariaDB
Danut, did you re-generate the DDLs for the #7156 POC app, when you did the tests? Constantin Asofiei
03:01 AM Database Feature #6628: port PostgreSQL native user defined functions to MariaDB
Rebased *6628a* with *trunk/rev.14934*. *6628a* is now at revision *14936*. Dănuț Filimon
09:05 AM Database Bug #6829 (Test): H2 forces re-parse of all prepared statements when metadata is changed
*6829a* was merged intro trunk as revision *14939* and archived. Dănuț Filimon
08:54 AM Database Bug #6829 (Merge Pending): H2 forces re-parse of all prepared statements when metadata is changed
OK Greg Shah
08:52 AM Database Bug #6829: H2 forces re-parse of all prepared statements when metadata is changed
I am merging 6829a right now. Dănuț Filimon
08:46 AM Database Bug #6829: H2 forces re-parse of all prepared statements when metadata is changed
It can be merged quickly if the testing is complete. Greg Shah
08:44 AM Database Bug #6829: H2 forces re-parse of all prepared statements when metadata is changed
I am OK with the changes. As long as they are well-tested, we can do the merge. Alexandru Lungu
06:57 AM Database Bug #6829: H2 forces re-parse of all prepared statements when metadata is changed
Alexandru Lungu wrote:
> Lets go ahead with the change. Please create a FWD branch and commit the change only for te...
Dănuț Filimon
05:59 AM Database Bug #6829: H2 forces re-parse of all prepared statements when metadata is changed
Lets go ahead with the change. Please create a FWD branch and commit the change only for temporary H2 database. Alexandru Lungu
05:49 AM Database Bug #6829: H2 forces re-parse of all prepared statements when metadata is changed
I ran POC regression tests, smoke tested a large customer application and also ran ChUI regression tests. There are n... Dănuț Filimon
09:03 AM User Interface Bug #8209 (New): FieldGroup tabItems out of sync after widget is dynamically deleted

Issue was first discovered in #8000-38, when the field groups from the client contained deleted widgets. It occurre...
Andrei Iacob
08:50 AM Database Bug #8196 (Review): Reduce number of AbstractTempTable._hasRecords calls to avoid BufferManager.a...
*Committed 8196a/rev.14936*. Removed the call to @activeBuffers@ from @AbstractTempTable._hasRecords@ and integrated ... Dănuț Filimon
07:21 AM Database Bug #8196: Reduce number of AbstractTempTable._hasRecords calls to avoid BufferManager.activeBuffers
Created 8196a. Dănuț Filimon
07:42 AM Base Language Feature #6417: cleanup some known items in appserver support
I'm getting 302 with all SOAP endpoints, when executed from a FWD client (converted procedure). When the endpoints ar... Galya B
04:15 AM Base Language Feature #6417: cleanup some known items in appserver support
The client sends a request to the SOAP endpoint corresponding to the function to be executed on the appserver (e.g. @... Galya B
02:53 AM Runtime Infrastructure Bug #8206: Logging manager issues
Theodoros, the change was introduced for #7732. The two parameters in concern are only used in @LegacyLogManagerImpl@... Galya B
02:48 AM Runtime Infrastructure Bug #8206: Logging manager issues
Vladimir Tsichevski wrote:
> Error reporting:
>
> # 1-2 dots are forcedly appended to error messages, there no do...
Galya B
02:46 AM Runtime Infrastructure Bug #8206: Logging manager issues
There is a change introduced in r14848 that deletes a substantial portion of the integer parameters parsing logic in ... Galya B

01/20/2024

05:02 PM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
Galya,
The problem is the preferred theme should be loaded from:...
Eugenie Lyzenko
03:40 PM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
Galya,
We have serious regression with this change. The theme defined in:...
Eugenie Lyzenko

01/19/2024

06:54 PM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
The Docker implementation is the most stringent user of this data import feature, so while this is partially docker r... Roger Borrello
06:54 PM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
Greg Shah wrote:
> Please test in a non-Docker environment.
It works in a normal environment.
Roger Borrello
05:46 PM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
Please test in a non-Docker environment. Greg Shah
05:36 PM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
My testing is complete. There is now a multi-container configuration (server/client and postgres) for hotel_gui. Ther... Roger Borrello
04:52 PM Database Feature #4722: data import should be able to run with only the converted application jar file (an...
Greg Shah wrote:
> What testing is needed?
I've built some docker images using the branch, and I'm working on the...
Roger Borrello
04:13 PM Database Feature #4722 (Internal Test): data import should be able to run with only the converted applicat...
Code Review Task Branch 4722c Revision 14935
The changes seem fine. What testing is needed?
Greg Shah
03:50 PM Database Feature #4722 (Review): data import should be able to run with only the converted application jar...
Revision 14935 is ready for review. This holds up the ability to use a multi-container environment. Roger Borrello
03:41 PM Database Feature #4722 (WIP): data import should be able to run with only the converted application jar fi...
I created a new branch *4722c* due to an issue when attempting to run @import.sh@ in a container. The *createdb* is n... Roger Borrello
01:47 PM Runtime Infrastructure Bug #8206: Logging manager issues
As of trunk rev 14926, the following issues are known, which relate to legacy logging:
Parse *integer* logging con...
Vladimir Tsichevski
01:17 PM Runtime Infrastructure Bug #8206 (Internal Test): Logging manager issues
Vladimir Tsichevski
10:54 AM User Interface Bug #8204: REGRESSION: separator should not show in a new date editing browse shell for unknown v...
The proposed solution is to change the line:... Vladimir Tsichevski
10:38 AM User Interface Bug #8204 (WIP): REGRESSION: separator should not show in a new date editing browse shell for unk...
If a browse cell is of date type, and date format includes date component separators (e.g. @9999/99/99@), and an unkn... Vladimir Tsichevski
09:40 AM User Interface Bug #8204 (Test): REGRESSION: separator should not show in a new date editing browse shell for un...
Vladimir Tsichevski
10:49 AM Database Support #4701 (Closed): try to improve H2 transaction commit performance
Eric Faulhaber
03:22 AM Database Support #4701: try to improve H2 transaction commit performance
This can be closed. Alexandru Lungu
01:23 AM Database Support #4701: try to improve H2 transaction commit performance
Is there anything left to do on this task, or can we consider the goals met? Eric Faulhaber
10:40 AM Base Language Feature #4392: add -pf support for appserver CONNECT() method
Ovidiu: Please do a final review of the latest changes (14874). Greg Shah
10:10 AM Database Feature #6628: port PostgreSQL native user defined functions to MariaDB
Thank you! Please rebase 6628a or port over the latest trunk, whichever is easier. We will need to regression test th... Eric Faulhaber
05:26 AM Database Feature #6628: port PostgreSQL native user defined functions to MariaDB
Added the changes from *6628a/rev.14614-14615* on top of *7156b/rev.14933*. I ran the regression tests and got betwee... Dănuț Filimon
02:07 AM Database Feature #6628: port PostgreSQL native user defined functions to MariaDB
Alexandru Lungu wrote:
> Danut already has the large application set-up with MariaDB lenient and can do the regressi...
Dănuț Filimon
02:04 AM Database Feature #6628: port PostgreSQL native user defined functions to MariaDB
There are runtime changes and SQL UDF changes in this branch. Since the UDFs have changed, they need to be (re-)insta... Eric Faulhaber
02:00 AM Database Feature #6628: port PostgreSQL native user defined functions to MariaDB
Sure!
Danut already has the large application set-up with MariaDB lenient and can do the regression tests. Priorit...
Alexandru Lungu
01:54 AM Database Feature #6628: port PostgreSQL native user defined functions to MariaDB
Alexandru, can you please assign this to someone on your team who has set up (or can) the large application environme... Eric Faulhaber
09:53 AM Database Feature #6496: add equivalent support for -trig command line option
I made a copy of 7156b and put my changes there, merged the changes to @SourceNameMapper@ that interfered with my cha... Alexandru Donica
02:11 AM Database Feature #6496 (Internal Test): add equivalent support for -trig command line option
Alexandru, please test the large application with this parameter you introduced:
* check there are no regressions wi...
Alexandru Lungu
01:13 AM Database Feature #6496: add equivalent support for -trig command line option
Alexandru [either one ;)]: what is left to do to push this task over the finish line? Eric Faulhaber
09:02 AM Database Bug #7252: Use direct-access to support for-each queries without WHERE and BY clauses
I've created branches 7252b and 7252b_h2 for the experiment with the @SelectAll@ class. Radu Apetrii
07:58 AM Database Bug #6829: H2 forces re-parse of all prepared statements when metadata is changed
These are great news. Please do extensive testing: focus on smoke testing another customer application and regression... Alexandru Lungu
07:51 AM Database Bug #6829: H2 forces re-parse of all prepared statements when metadata is changed
Alexandru Lungu wrote:
> Danut, please analyze performance with NEVER_RECOMPILE. I don't recall if we have something...
Dănuț Filimon
02:14 AM Database Bug #6829 (Internal Test): H2 forces re-parse of all prepared statements when metadata is changed
Recently, we done some changes that prevented us from using a "NEVER_RECOMPILE" kind of option. Back in #6829-1, it w... Alexandru Lungu
01:22 AM Database Bug #6829: H2 forces re-parse of all prepared statements when metadata is changed
Can this task be closed? Eric Faulhaber
05:15 AM Database Feature #6816 (Internal Test): improve PreselectQuery.assembleHQL
Alexandru Lungu
05:15 AM Database Feature #6816: improve PreselectQuery.assembleHQL
I am dumping some statistics with LTW right now. I will let you know if I continue seeing something obvious here. Alexandru Lungu
05:05 AM Database Feature #6816: improve PreselectQuery.assembleHQL
Give me a bit of time to check @PreselectQuery.assembleFQL@, maybe I can notice something else. I'm not sure if Alex ... Radu Apetrii
01:37 AM Database Feature #6816: improve PreselectQuery.assembleHQL
The changes implemented for this task have long since made their way into trunk. It is still marked 40% done. Is ther... Eric Faulhaber
03:33 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
Ovidiu Maxiniuc wrote:
> * at line 23: if there are no databases with @load_at_startup@ attribute set to @true@ in d...
Galya B
02:58 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
The requested changes are in r14844 and they don't work, because there is no @SecurityContext@ on the Jetty thread:
...
Galya B
02:47 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
Ovidiu Maxiniuc wrote:
> The only condition here is that the @DatabaseManager.dialects@ to contain the dialect for y...
Galya B
03:21 AM Database Feature #6720: lazy hydration
On the POC, it regresses and crashes. I didn't attempt the tests on the new test suite. Alexandru Lungu
01:29 AM Database Feature #6720: lazy hydration
Is this far enough along that we can measure performance, or are the regressions blocking testing? We need to underst... Eric Faulhaber
02:43 AM Database Bug #6887: improve performance of dataset/table[-handle] parameters
Constantin, does it makes sense to do one more pass with JMX to see what the 3 cases which stood out earlier look lik... Eric Faulhaber
02:06 AM Database Feature #6414 (Closed): ERROR attribute for buffer, dataset and temp-table
Eric Faulhaber
01:43 AM Database Bug #7138 (Closed): Short circuit fake-update (update with a new value eqaul to the old value) in H2
I am closing this. Let me know if there is a reason it should remain open. We have done our internal testing and ther... Eric Faulhaber
01:26 AM Database Feature #6928 (Closed): H2 UPDATE performance improvement
I am closing this. I think 11 months of testing is probably sufficient :) Eric Faulhaber

01/18/2024

11:22 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
Sorry, I do not know what you mean. That is, indeed, the code from @PersistenceFactory.getInstance(Database database)... Ovidiu Maxiniuc
09:32 AM Database Feature #7382: Check performance of delete from vs drop table in H2
1. @8591 ms@ for @939_203@ deletes (classic execution, all deletes)
5. @7672 ms@ for @935_965@ deletes (optimized ex...
Alexandru Donica
04:05 AM Database Feature #7382: Check performance of delete from vs drop table in H2
well 5 = 4 + 3. and 1 = 2 + 3.
(don't read this out of context)
Alexandru Donica
03:40 AM Database Feature #7382: Check performance of delete from vs drop table in H2
Lets presume that A is the set of *all* deletes and C is the set of "candidate" deletes (the ones that *can* be optim... Alexandru Lungu
03:25 AM Database Feature #7382: Check performance of delete from vs drop table in H2
Alexandru Lungu wrote:
> * Total and Avg. time for classic deletes
> * Total and Avg. time for fast deletes
> * To...
Alexandru Donica
09:30 AM Base Language Feature #6417: cleanup some known items in appserver support
Constantin Asofiei wrote:
> Doesn't localhost work instead of your IP?
The IP of eth0 is automatically prepended to...
Galya B

01/17/2024

02:37 PM Runtime Infrastructure Feature #6692: move FWD to Java 17
Restarting the tasks.
After rebasing to latest @trunk@ refreshing @gradle@ configuration.
Tomasz Domin
11:43 AM Database Feature #7382: Check performance of delete from vs drop table in H2
I really think this ratio will go up once we use expanded extents. There are many temp tables with extent fields. As ... Alexandru Lungu
09:59 AM Database Feature #7382: Check performance of delete from vs drop table in H2
I modified the code, now I only check for referential constraints, as they are the ones causing problems (Some tables... Alexandru Donica
09:34 AM Database Feature #7382: Check performance of delete from vs drop table in H2
As far as I know, the only cascading deletes that we would encounter would be for the non-expanded extents (which hav... Greg Shah
09:30 AM Database Feature #7382: Check performance of delete from vs drop table in H2
After some debugging, I found an error that I didn't know was thrown, which was happening because, when the classic d... Alexandru Donica
09:59 AM Base Language Feature #6417: cleanup some known items in appserver support
Doesn't localhost work instead of your IP? Constantin Asofiei
09:57 AM Base Language Feature #6417: cleanup some known items in appserver support
Without VPN the same bummer, different IP... the local networking one. What do I do, what do I do... Fix the network ... Galya B
08:44 AM Base Language Feature #6417: cleanup some known items in appserver support
Finally to the next issue @Host does not match certificate.@:... Galya B
07:44 AM Base Language Feature #6417: cleanup some known items in appserver support
Galya, this is a regression from back when I rewrote to emit InvokeConfig instead of ControlFlowOps. Please look int... Constantin Asofiei
07:14 AM Base Language Feature #6417: cleanup some known items in appserver support
I continue to struggle with the SOAP tests.
Procedure to reproduce the issue (pretty much the connect.i):...
Galya B
02:40 AM Base Language Feature #6417: cleanup some known items in appserver support
Galya B wrote:
> The only way to run @appsrv/test/pipe/test_pipe_raw.p@ is as Marian suggested from the root of test...
Marian Edu
01:32 AM Base Language Feature #6417: cleanup some known items in appserver support
The only way to run @appsrv/test/pipe/test_pipe_raw.p@ is as Marian suggested from the root of testcases. I would app... Galya B
09:45 AM Database Bug #7496: finish support for query:forward-only attribute
I managed to solve all the regressions from the adaptive-scrolling test set and identify other problems in the POC wh... Dănuț Filimon

01/16/2024

04:01 PM Base Language Feature #6410: implement additional built-in OO classes/interfaces
What is the status of this work? Are we close to being able to merge it? Greg Shah
10:13 AM Database Feature #7382: Check performance of delete from vs drop table in H2
This is quite strange - there are many "one time" temp-tables used in the large POC (or this is what I recall). Pleas... Alexandru Lungu
09:43 AM Database Feature #7382: Check performance of delete from vs drop table in H2
Scratch that, there was a little bug, but one that would show a weird error related to db because it was happening in... Alexandru Donica
09:23 AM Base Language Feature #6417: cleanup some known items in appserver support
Constantin Asofiei wrote:
> Galya B wrote:
> > Is there no option to add the original location to a client propath?...
Galya B
08:26 AM Base Language Feature #6417: cleanup some known items in appserver support
Galya B wrote:
> Is there no option to add the original location to a client propath?
You can add the full path for...
Constantin Asofiei
08:25 AM Base Language Feature #6417: cleanup some known items in appserver support
Constantin Asofiei wrote:
> That's because of this statements:
> [...]
>
> This file needs to be made available ...
Galya B
08:23 AM Base Language Feature #6417: cleanup some known items in appserver support
That's because of this statements:... Constantin Asofiei
08:20 AM Base Language Feature #6417: cleanup some known items in appserver support
Constantin Asofiei wrote:
> Galya B wrote:
> > I'm executing it from @deploy/client-chui@, where the client.xml con...
Galya B
08:16 AM Base Language Feature #6417: cleanup some known items in appserver support
Galya B wrote:
> I'm executing it from @deploy/client-chui@, where the client.xml config is: @startup-procedure="../...
Constantin Asofiei
08:14 AM Base Language Feature #6417: cleanup some known items in appserver support
Constantin, I'm debugging @ControlFlowOps@, but it's too weird. Any hint will be appreciated.
There is execution o...
Galya B
07:46 AM Base Language Feature #6417: cleanup some known items in appserver support
Marian Edu wrote:
> The path of the test procedure you're converting looks a bit odd (`../../appsrv/test/pipe/test_p...
Galya B
07:34 AM Base Language Feature #6417: cleanup some known items in appserver support
Galya B wrote:
> It probably is the propath then. I have only:
> [...]
>
> @appsrv/test@ is not in. Do you think...
Marian Edu
07:18 AM Base Language Feature #6417: cleanup some known items in appserver support
It probably is the propath then. I have only:... Galya B
07:14 AM Base Language Feature #6417: cleanup some known items in appserver support
Marian Edu wrote:
> Galya B wrote:
> > Now there is another one: @(Procedure: '../../appsrv/test/pipe/test_pipe_raw...
Galya B
07:12 AM Base Language Feature #6417: cleanup some known items in appserver support
Galya B wrote:
> Now there is another one: @(Procedure: '../../appsrv/test/pipe/test_pipe_raw.p') ** "appsrv/test/pi...
Marian Edu
08:26 AM Database Bug #7138 (Test): Short circuit fake-update (update with a new value eqaul to the old value) in H2
*Committed 7138a_h2 to FWD_H2 trunk as rev.39. Archived 7138a_h2.* Dănuț Filimon
07:54 AM Database Bug #8200: Explicit buffer used instead of the implicit one for a persistent table
Assuming we have a persistent table called @t1@ with only 1 field, @f1@, which is an integer.
For the following te...
Andrei Bălteanu
07:53 AM Database Bug #8200 (Test): Explicit buffer used instead of the implicit one for a persistent table
Andrei Bălteanu
05:59 AM Database Bug #7448: Optimize FWD-H2 ValueTimestampTimeZone and maybe avoid caching
The improvement from removing the caching for this method is very small, 5 milliseconds faster, so a total of ~241 mi... Alexandru Donica
05:11 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
Hynek Cihlar wrote:
> Galya B wrote:
> > > No, I want explicit, readable and obvious dependencies. Dependencies tha...
Galya B
05:11 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
Galya B wrote:
> > No, I want explicit, readable and obvious dependencies. Dependencies that will not break with fut...
Hynek Cihlar
04:45 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
Hynek Cihlar wrote:
> Galya B wrote:
> > So you want to refactor FWD to not use @DirectoryService.getInstance()@ an...
Galya B
04:44 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
Galya B wrote:
> So you want to refactor FWD to not use @DirectoryService.getInstance()@ anywhere, but instead @Dire...
Hynek Cihlar
04:23 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
Hynek Cihlar wrote:
> No, my argument is that someone references @LogicalTerminal@ even before the conditions are sa...
Galya B
04:01 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
Galya B wrote:
> Hynek Cihlar wrote:
> > Galya B wrote:
> > > If in the future there is a misuse of @LogicalTermin...
Hynek Cihlar
03:48 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
Hynek Cihlar wrote:
> Galya B wrote:
> > If in the future there is a misuse of @LogicalTerminal@ it will have to be...
Galya B
03:45 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
Galya B wrote:
> If in the future there is a misuse of @LogicalTerminal@ it will have to be fixed.
You cannot ass...
Hynek Cihlar
03:28 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
Hynek Cihlar wrote:
> Galya B wrote:
> > Hynek Cihlar wrote:
> > > Code review 8074b revision 14917.
> > >
> > ...
Galya B
02:58 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
Galya B wrote:
> Hynek Cihlar wrote:
> > Code review 8074b revision 14917.
> >
> > The only concern I have is th...
Hynek Cihlar
02:45 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
Hynek Cihlar wrote:
> Code review 8074b revision 14917.
>
> The only concern I have is the init of themes in the ...
Galya B
04:46 AM Database Bug #7252: Use direct-access to support for-each queries without WHERE and BY clauses
There are a lot of H2 queries that were replaced with direct-access. Is not that the "select all records" increased, ... Alexandru Lungu

01/15/2024

12:44 PM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
Code review 8074b revision 14917.
The only concern I have is the init of themes in the static ctor of @LogicalTerm...
Hynek Cihlar
07:13 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
Hynek/Sergey: Please review. Greg Shah
06:28 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
r14917: Change to default theme resolvement. Login screen theme select shows up only with 2 or more configured direct... Galya B
12:42 PM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
See #6667-823 for the needed changes for hand coded Java in the ChUI regression test application. Greg Shah
11:11 AM Base Language Feature #6417: cleanup some known items in appserver support
Something is still off.
@ControlFlowOps@ is throwing errors:...
Galya B
10:20 AM Base Language Feature #6417: cleanup some known items in appserver support
Marian Edu wrote:
> Galya B wrote:
> > Marian, can you help with #6417-19. Something seems wrong with the paths to ...
Galya B
10:02 AM Base Language Feature #6417: cleanup some known items in appserver support
The problem is that @WebServiceImpl.connect@ expects explicit service name or binding name, while there is only a por... Galya B
09:21 AM Base Language Feature #6417: cleanup some known items in appserver support
Please look into how @getImplicitSoapPort@ calculates the implicit port and also compare fwd.wsdl from @src/@ with @.... Constantin Asofiei
09:19 AM Base Language Feature #6417: cleanup some known items in appserver support
P.S. The screenshot can be slightly confusing. Actually the highlighted breakpoint is not hit. Instead the one on lin... Galya B
09:17 AM Base Language Feature #6417: cleanup some known items in appserver support
This is executed instead:... Galya B
09:16 AM Base Language Feature #6417: cleanup some known items in appserver support
Constantin Asofiei wrote:
> I think this code should be executed, as the @-Port@ from @connect@ is set:
> [...]
...
Galya B
09:08 AM Base Language Feature #6417: cleanup some known items in appserver support
I think this code should be executed, as the @-Port@ from @connect@ is set:... Constantin Asofiei
09:04 AM Base Language Feature #6417: cleanup some known items in appserver support
Constantin Asofiei wrote:
> Galya B wrote:
> > > Galya, the point here is to use @ssl-socket:truststore@ to refer t...
Galya B
08:47 AM Base Language Feature #6417: cleanup some known items in appserver support
Galya B wrote:
> > Galya, the point here is to use @ssl-socket:truststore@ to refer to srv-certs.store with the FWD ...
Constantin Asofiei
08:45 AM Base Language Feature #6417: cleanup some known items in appserver support
Constantin, so you don't get the ssl issue in the output file or in the clientlog @<cmd-line-option clientlog="file.l... Galya B
08:42 AM Base Language Feature #6417: cleanup some known items in appserver support
Constantin Asofiei wrote:
> Galya B wrote:
> > Otherwise the document opens fine in the browser.
> Does it open wi...
Galya B
08:40 AM Base Language Feature #6417: cleanup some known items in appserver support
Galya B wrote:
> Otherwise the document opens fine in the browser.
Does it open with both @wsdl/?...@ and @wsdl?......
Constantin Asofiei
08:39 AM Base Language Feature #6417: cleanup some known items in appserver support
Galya, the point here is to use @ssl-socket:truststore@ to refer to srv-certs.store with the FWD server's certificate... Constantin Asofiei
08:37 AM Base Language Feature #6417: cleanup some known items in appserver support
Constantin Asofiei wrote:
> Thanks. There are a couple of issues:
> # @https://localhost:9443/ws/wsa/wsafwd/wsdl/?...
Galya B
07:32 AM Base Language Feature #6417: cleanup some known items in appserver support
Constantin Asofiei wrote:
> Galya B wrote:
> > Constantin Asofiei wrote:
> > > Galya, @http://localhost:9443/wsa/w...
Marian Edu
07:11 AM Base Language Feature #6417: cleanup some known items in appserver support
Galya B wrote:
> Marian, can you help with #6417-19. Something seems wrong with the paths to procedures for @appsrv/...
Marian Edu
05:57 AM Base Language Feature #6417: cleanup some known items in appserver support
Thanks. There are a couple of issues:
# @https://localhost:9443/ws/wsa/wsafwd/wsdl/?targetURI=urn:tempuri-org@ does...
Constantin Asofiei
05:47 AM Base Language Feature #6417: cleanup some known items in appserver support
@appsrv/test/test_raise_stop.p@ is the legacy appserver test. Try:... Galya B
05:19 AM Base Language Feature #6417: cleanup some known items in appserver support
While in @deploy/client-chui@, I've ran this and I don't get the certificate issue:... Constantin Asofiei
10:17 AM Database Feature #7382: Check performance of delete from vs drop table in H2
There is a bug/regression somewhere regarding the patch I posted above. When I try to smoke test on another large app... Alexandru Donica
09:28 AM Database Bug #8196: Reduce number of AbstractTempTable._hasRecords calls to avoid BufferManager.activeBuffers
I wasn't aware this could be called directly from the converted code. Alexandru Lungu
09:24 AM Database Bug #8196: Reduce number of AbstractTempTable._hasRecords calls to avoid BufferManager.activeBuffers
Alexandru Lungu wrote:
> This can be improved in two ways:
> * Check if we really need to check the transient recor...
Dănuț Filimon
09:04 AM Database Bug #8196 (WIP): Reduce number of AbstractTempTable._hasRecords calls to avoid BufferManager.acti...
Dănuț Filimon
09:03 AM Database Bug #8196: Reduce number of AbstractTempTable._hasRecords calls to avoid BufferManager.activeBuffers
The POC application calls @AbstractTempTable.hasRecords@ and @clear@/@setCanUndo@ are not called at all. I noticed th... Dănuț Filimon
08:38 AM Database Bug #8196: Reduce number of AbstractTempTable._hasRecords calls to avoid BufferManager.activeBuffers
Danut, the code using @allBuffers@ is meant to check records that were not yet flushed to the database (transient) an... Alexandru Lungu
08:04 AM Database Bug #8196: Reduce number of AbstractTempTable._hasRecords calls to avoid BufferManager.activeBuffers
After a fix involving going over the buffers from @AbstractTempTable.allBuffers@ and execute the same logic from @act... Dănuț Filimon
04:25 AM Database Bug #8196: Reduce number of AbstractTempTable._hasRecords calls to avoid BufferManager.activeBuffers
While retesting different session reclaiming lifespans for #7167, it was noted that there is almost no difference bet... Dănuț Filimon
04:18 AM Database Bug #8196 (Closed): Reduce number of AbstractTempTable._hasRecords calls to avoid BufferManager.a...
Dănuț Filimon
09:27 AM Database Bug #7138: Short circuit fake-update (update with a new value eqaul to the old value) in H2
Danut, please go ahead and merge to FWD-H2 trunk.
Greg, this will reach FWD on the next H2 upgrade.
Alexandru Lungu
08:54 AM Database Bug #7138: Short circuit fake-update (update with a new value eqaul to the old value) in H2
Alexandru: If you are OK with this, it can merge now. Greg Shah
08:48 AM Database Bug #7138: Short circuit fake-update (update with a new value eqaul to the old value) in H2
I retested POC on the original device and obtained a performance improvement for both the average of the last 20 runs... Dănuț Filimon
02:29 AM Database Bug #7138: Short circuit fake-update (update with a new value eqaul to the old value) in H2
Danut, this is a common pattern: in different days and on different platforms to see different results. The only way ... Alexandru Lungu
08:50 AM Database Bug #7448: Optimize FWD-H2 ValueTimestampTimeZone and maybe avoid caching
I was thinking of more than just avoiding the cache and maybe remote it entirely :) However, the timing is not that c... Alexandru Lungu
06:42 AM Database Bug #7448: Optimize FWD-H2 ValueTimestampTimeZone and maybe avoid caching
The average of 3 baseline runs for me was 14.665 seconds (so a total of 1_466_500 milliseconds for 100 iterations), a... Alexandru Donica
08:37 AM Database Bug #7252: Use direct-access to support for-each queries without WHERE and BY clauses
Alexandru Lungu wrote:
> First and foremost:
> See how many such queries are on POC. I just want to confirm my init...
Radu Apetrii
03:56 AM Database Bug #7167: Associating records from opened buffers to new sessions is slow
I've got the results of how often is @activeBuffers@ hit from @AbstractTempTable._hasRecords@, and how often it is hi... Dănuț Filimon
02:44 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
Ovidiu Maxiniuc wrote:
> Please +try+ the following: use @PersistenceFactory.getInstance(database)@ to obtain a @Per...
Galya B

01/13/2024

09:06 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
> OK, then if only one theme is added to @available-themes@, it will be set as a default even if it's not defined in ... Greg Shah

01/12/2024

12:43 PM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
Galya B wrote:
> Eric Faulhaber wrote:
> > In terms of retrieving @Dialect@ information, the @Dialect.knownDialects...
Eric Faulhaber
03:02 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
Eric Faulhaber wrote:
> In terms of retrieving @Dialect@ information, the @Dialect.knownDialects@ should be populate...
Galya B
09:49 AM Database Bug #7138: Short circuit fake-update (update with a new value eqaul to the old value) in H2
I tested POC with 7156b/rev.14933 (which uses FWD-H2/rev.38) and 7138a_h2/rev.45. From 5 runs each (baseline and 7156... Dănuț Filimon
09:41 AM Base Language Feature #6417: cleanup some known items in appserver support
Galya B wrote:
> > * argument translation to remote definition type I think is done the same as the CALL statement d...
Galya B
09:28 AM Base Language Feature #6417: cleanup some known items in appserver support
Galya B wrote:
> Are you sure it should be https?
Yes.
Constantin Asofiei
09:26 AM Base Language Feature #6417: cleanup some known items in appserver support
Are you sure it should be https? Galya B
09:09 AM Base Language Feature #6417: cleanup some known items in appserver support
No, this is about the HTTPS conection. I'm looking at it now. Constantin Asofiei
09:06 AM Base Language Feature #6417: cleanup some known items in appserver support
The batch client I run points to:... Galya B
09:03 AM Base Language Feature #6417: cleanup some known items in appserver support
Constantin Asofiei wrote:
> Galya B wrote:
> > Constantin Asofiei wrote:
> > > Galya, @http://localhost:9443/wsa/w...
Galya B
08:50 AM Base Language Feature #6417: cleanup some known items in appserver support
r14916 Adds conditions for @unknown@ @CURRENT-RESPONSE-INFO@ / @CURRENT-REQUEST-INFO@. Galya B
08:32 AM Base Language Feature #6417: cleanup some known items in appserver support
Galya B wrote:
> Constantin Asofiei wrote:
> > Galya, @http://localhost:9443/wsa/wsafwd/wsdl/?targetURI=urn:tempuri...
Constantin Asofiei
08:30 AM Base Language Feature #6417: cleanup some known items in appserver support
Constantin Asofiei wrote:
> Galya, @http://localhost:9443/wsa/wsafwd/wsdl/?targetURI=urn:tempuri-org@ needs to use @...
Galya B
08:22 AM Base Language Feature #6417: cleanup some known items in appserver support
Galya, @http://localhost:9443/wsa/wsafwd/wsdl/?targetURI=urn:tempuri-org@ needs to use @https@ and also the full URL ... Constantin Asofiei
07:54 AM Base Language Feature #6417: cleanup some known items in appserver support
All tests fail on all clients with different errors.
The FWD client shows:...
Galya B
07:09 AM Base Language Feature #6417: cleanup some known items in appserver support
Galya B wrote:
> @appsrv/soap/test/4glws.connect.i@ has the port @8980@ hardcoded and soap tests ran from testcases ...
Constantin Asofiei
07:07 AM Base Language Feature #6417: cleanup some known items in appserver support
@appsrv/soap/test/4glws.connect.i@ has the port @8980@ hardcoded and soap tests ran from testcases are looking for th... Galya B
07:05 AM Base Language Feature #6417: cleanup some known items in appserver support
Galya B wrote:
> What is this port @8980@? Something is off, but I can't tell what.
These files need to be changed ...
Constantin Asofiei
08:39 AM Database Bug #7448: Optimize FWD-H2 ValueTimestampTimeZone and maybe avoid caching
Alexandru, please keep the same profiling infrastructure you have and test with 7156b and the large POC. Please make ... Alexandru Lungu
08:13 AM Database Bug #7448: Optimize FWD-H2 ValueTimestampTimeZone and maybe avoid caching
I changed the @CurrentTimestamp.get@ method to keep track of the metrics you mentioned, and roamed around the menus o... Alexandru Donica
08:23 AM Base Language Feature #6424: fill gaps in Java Open Client replacement (appserver client support)
I have a Java project which shows how to execute OpenClient calls in both FWD and OE, I'll make it available in the n... Constantin Asofiei
06:29 AM Base Language Feature #6424: fill gaps in Java Open Client replacement (appserver client support)
Are there any examples how to setup a java client in FWD and in OE? Galya B
05:29 AM Database Feature #6815 (Review): configure all cache sizes in the directory, and create documentation for ...
*Committed 6815a/rev.14919*. Reduced the number of instrumented methods (based on results from a large application, t... Dănuț Filimon
04:04 AM Database Feature #6815: configure all cache sizes in the directory, and create documentation for them
Danut, please merge some of the statistics in one: get, getOrDefault can be merged. The same as put, putAll and putIf... Alexandru Lungu
04:01 AM Database Feature #6815: configure all cache sizes in the directory, and create documentation for them
Alexandru Lungu wrote:
> Why is it too big? Shouldn't it be similar to #6815-11, but with some extra columns?
> Any...
Dănuț Filimon
03:50 AM Database Feature #6815: configure all cache sizes in the directory, and create documentation for them
Dănuț Filimon wrote:
> I added monitoring for the configured and the in use cache size (latest size of the cache), G...
Alexandru Lungu
03:15 AM Database Feature #6815: configure all cache sizes in the directory, and create documentation for them
I added monitoring for the configured and the in use cache size (latest size of the cache), GET hit/miss and modified... Dănuț Filimon
04:54 AM Base Language Feature #4065: server-side processing of client platform dependencies
Galya B wrote:
> This configuration is not enough. For example, to enable server-side filesystem, you also need:
> ...
Hynek Cihlar
04:21 AM Base Language Feature #4065: server-side processing of client platform dependencies
This configuration is not enough. For example, to enable server-side filesystem, you also need:... Galya B
04:08 AM Base Language Feature #4392: add -pf support for appserver CONNECT() method
Ovidiu Maxiniuc wrote:
> * @ConnectionManager.java@:
> ** the @iter.next();@ at line 4926 may throw @NoSuchElementE...
Galya B
12:00 AM Base Language Feature #4392: add -pf support for appserver CONNECT() method
Review of 4392a, 14869-14873 (from the previous review):
* @ConnectionManager.java@:
** I like you cleaned up the...
Ovidiu Maxiniuc
02:40 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
OK, then if only one theme is added to @available-themes@, it will be set as a default even if it's not defined in @t... Galya B

01/11/2024

06:11 PM Database Bug #8183: debugging database module
Code review 8183a/14914:
The changes look useful, but there is a security concern, in that these public methods ca...
Eric Faulhaber
01:31 PM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
> That's how it's been working always. Do you want to change it somehow?
I understand this is not new. It is just...
Greg Shah
07:54 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
Greg Shah wrote:
> Why even have the dropdown when there is only 1 choice? Shouldn't the dropdown only exist if the...
Galya B
07:33 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
Why even have the dropdown when there is only 1 choice? Shouldn't the dropdown only exist if there are more than 1 c... Greg Shah
03:25 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
8074b r14916 adding empty option to UI theme selector only when one or more themes are configured in directory. Galya B
01:44 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
Greg Shah wrote:
> The theme drop down was originally implemented to make it easy for GCD developers to test differe...
Galya B
12:34 PM Base Language Feature #4065: server-side processing of client platform dependencies
This feature is not properly documented yet. As noted in #6075-25 and #4065-18, it can configured with a server-side... Greg Shah
12:05 PM Base Language Feature #4392: add -pf support for appserver CONNECT() method
Constantin/Ovidiu: Please review. Greg Shah
03:37 AM Base Language Feature #4392: add -pf support for appserver CONNECT() method
The tests in @copy_lob@ give the same results in both cases. I changed the flag @hasDuplicatedLastLine@ to false ever... Galya B
10:46 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
For most use cases of the @Database@ object, the @socketAddress@ will be @null@. However, FWD supports a mode where m... Eric Faulhaber
08:23 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
Eric, Ovidiu, in case you've missed #7884-64, it still waits for your opinion. You both asked me to use @Database@ ob... Galya B
09:50 AM Base Language Feature #6417: cleanup some known items in appserver support
What is this port @8980@? Something is off, but I can't tell what.... Galya B
09:12 AM Runtime Infrastructure Bug #7589 (Test): org.slf4j.impl.StaticLoggerBinder when deploying p2j.jar in tomcat
Greg Shah
09:09 AM Runtime Infrastructure Bug #7589: org.slf4j.impl.StaticLoggerBinder when deploying p2j.jar in tomcat
Branch 7589c was rebased to trunk_14916 and is at revision 14918.
Branch 7589c was merged to trunk as revision 149...
Roger Borrello
05:51 AM Database Bug #7667: Support OUTER-JOIN with PRESELECT at conversion
Branch 7667b was merged to trunk revision 14916 and archived. Alexandru Lungu
05:48 AM Database Feature #6815 (WIP): configure all cache sizes in the directory, and create documentation for them
Alexandru Lungu wrote:
> What other statistics can be achieved? I suspect the ratio is the most important one, so le...
Dănuț Filimon
05:39 AM Database Feature #6815: configure all cache sizes in the directory, and create documentation for them
What other statistics can be achieved? I suspect the ratio is the most important one, so lets get it done. Also, we n... Alexandru Lungu
05:28 AM Database Feature #6815: configure all cache sizes in the directory, and create documentation for them
*Committed 6815a/rev.14917*. Removed unnecessary methods and changes the container accessed for the @instrumentation@... Dănuț Filimon
03:52 AM Database Bug #7138: Short circuit fake-update (update with a new value eqaul to the old value) in H2
There are currently problems with the POC project and the performance tests will be put on *hold* until further notic... Dănuț Filimon

01/10/2024

03:49 PM Base Language Feature #4392: add -pf support for appserver CONNECT() method
Greg Shah wrote:
> > Note that #4392-30 was left unanswered and is not addressed.
> Ovidiu: This is for you, I thin...
Ovidiu Maxiniuc
10:53 AM Base Language Feature #4392: add -pf support for appserver CONNECT() method
Ovidiu: What is the list of testcases Galya can check? Greg Shah
10:48 AM Base Language Feature #4392: add -pf support for appserver CONNECT() method
Greg Shah wrote:
> > Note that #4392-30 was left unanswered and is not addressed.
>
> Ovidiu: This is for you, I ...
Galya B
10:45 AM Base Language Feature #4392: add -pf support for appserver CONNECT() method
> Note that #4392-30 was left unanswered and is not addressed.
Ovidiu: This is for you, I think.
Greg Shah
10:42 AM Base Language Feature #4392: add -pf support for appserver CONNECT() method
Ready for second review.
Note that #4392-30 was left unanswered and is not addressed.
Galya B
10:40 AM Base Language Feature #4392: add -pf support for appserver CONNECT() method
r14870 & 14871: Resolving DB @CONNECT@ @-pf@ file from the configured file system. Galya B
11:42 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
The theme drop down was originally implemented to make it easy for GCD developers to test different themes. It was n... Greg Shah
09:06 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
Roger Borrello wrote:
> Galya B wrote:
> > Yes, it still works properly with the default Windows 10. It's just a UI...
Galya B
09:05 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
Nevermind... easy find.... Roger Borrello
09:03 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
Galya B wrote:
> Yes, it still works properly with the default Windows 10. It's just a UI issue of showing an empty ...
Roger Borrello
09:00 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
Roger Borrello wrote:
> it would have a dropdown with only *Windows 10* available for selection. I removed it so tha...
Galya B
08:58 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
I just wanted to clarify my post #7143-639 where I mentioned the UI Theme dropdown is appearing when it wasn't before... Roger Borrello
11:07 AM Runtime Infrastructure Bug #7589: org.slf4j.impl.StaticLoggerBinder when deploying p2j.jar in tomcat
Greg Shah wrote:
> You can merge after 7667b.
I'll rebase and merge as soon as I see it hits.
Roger Borrello
11:02 AM Runtime Infrastructure Bug #7589: org.slf4j.impl.StaticLoggerBinder when deploying p2j.jar in tomcat
You can merge after 7667b. Greg Shah
08:40 AM Runtime Infrastructure Bug #7589: org.slf4j.impl.StaticLoggerBinder when deploying p2j.jar in tomcat
Roger Borrello wrote:
> Great feedback... committed revision 14917.
Greg, it's good for merge.
Galya B
08:37 AM Runtime Infrastructure Bug #7589: org.slf4j.impl.StaticLoggerBinder when deploying p2j.jar in tomcat
Galya B wrote:
> Two conditions are introduced, that can be merged together: @[ -f "$SLF4J_IMPL" ] && cp -f $SLF4J_I...
Roger Borrello
07:20 AM Runtime Infrastructure Bug #7589: org.slf4j.impl.StaticLoggerBinder when deploying p2j.jar in tomcat
Two conditions are introduced, that can be merged together: @[ -f "$SLF4J_IMPL" ] && cp -f $SLF4J_IMPL ${spawn_dir}/s... Galya B
07:12 AM Database Feature #6815 (Review): configure all cache sizes in the directory, and create documentation for ...
Created *6815a* and committed *rev.14916*. As suggested by Alexandru in #6815-9, I've created a way to instrument cac... Dănuț Filimon

01/09/2024

05:56 PM Runtime Infrastructure Bug #7589: org.slf4j.impl.StaticLoggerBinder when deploying p2j.jar in tomcat
Branch *7589c* was rebased to trunk_14915 and is at revision 14916. Roger Borrello
11:17 PM Runtime Infrastructure Bug #7589: org.slf4j.impl.StaticLoggerBinder when deploying p2j.jar in tomcat
Galya B wrote:
> Roger, did you create 7589b? 7589b is merged. It should have been 7589c.
Oops... I've correct it...
Roger Borrello
11:31 AM Base Language Feature #6417: cleanup some known items in appserver support
Until we are done with our work with #6853, we only run specific sets of tests manually to check functionality. Once... Greg Shah
10:53 AM Base Language Feature #6417: cleanup some known items in appserver support
Constantin Asofiei wrote:
> There is also a @file-cvt-list.txt.rest_and_appserver@, to run the plain appserver clien...
Galya B
10:49 AM Base Language Feature #6417: cleanup some known items in appserver support
r14914 Fixes legacy appserver throw / return error.
Related tests @appsrv/test/test_throw_error.p@ & @appsrv/test...
Galya B
09:21 AM Deployment Support #3303: make the automated deployment process fully production ready
Greg Shah wrote:
> > Note how easily it is to setup FWD so it can be made available:
> > [...]
> > Then it's just ...
Roger Borrello
08:54 AM Deployment Support #3303: make the automated deployment process fully production ready
> May I suggest Docker should be the main basis for the build and runtime roles?
I do want to leverage Docker to ...
Greg Shah
08:16 AM Database Bug #7454 (Closed): Make ValueStringIgnoreCase the default generated value for setString in FWD-H2
Greg Shah
08:04 AM Database Bug #7454: Make ValueStringIgnoreCase the default generated value for setString in FWD-H2
This can be closed. Alexandru Lungu
08:16 AM Database Feature #7404 (Closed): Trasform replace-mode into append-mode when target table is empty
Greg Shah
08:04 AM Database Feature #7404: Trasform replace-mode into append-mode when target table is empty
This can be closed. Alexandru Lungu
08:16 AM Database Bug #7389 (Closed): Make fast-copy statements cachable
Greg Shah
08:03 AM Database Bug #7389: Make fast-copy statements cachable
This can be closed. Alexandru Lungu
08:03 AM Database Bug #7252: Use direct-access to support for-each queries without WHERE and BY clauses
Radu, lets see how we can "resurrect" this task. I think the initial statistic of *lots* of @SELECT@ statements that ... Alexandru Lungu
07:37 AM Database Bug #8183: debugging database module
This task should include an easy way to see a temp-table or permanent table's contents without having to do complex m... Greg Shah
05:06 AM Database Feature #7382: Check performance of delete from vs drop table in H2
Alexandru [ad], please refer to [[internal-documentation:H2_Database_Fork]] for further insights. Alexandru Lungu
04:38 AM Database Feature #7382: Check performance of delete from vs drop table in H2
> This is a patch of what I wrote so far. So from what I understand, instead of having a delete from tt where _multip... Alexandru Lungu
04:24 AM Database Feature #7382: Check performance of delete from vs drop table in H2
This is a patch of what I wrote so far. So from what I understand, instead of having a @delete from tt where _multipl... Alexandru Donica
04:20 AM Database Bug #7138: Short circuit fake-update (update with a new value eqaul to the old value) in H2
An update on the current test status:
* Rebased *7138a_h2* with *fwd-h2/rev.38*. *7138a_h2* is now at revision *45*;...
Dănuț Filimon

01/08/2024

05:55 PM Database Bug #8183 (WIP): debugging database module
I created task branch 8183a and committed some of my code I have maintained for some time (r14914). It was designed n... Ovidiu Maxiniuc
04:57 PM Database Bug #8183: debugging database module
This task is the place for discussions on how to do database debugging and develop tools for doing this optimally.
Ovidiu Maxiniuc
04:53 PM Database Bug #8183 (WIP): debugging database module
Ovidiu Maxiniuc
04:08 PM Base Language Feature #4392: add -pf support for appserver CONNECT() method
> > * we need to fix the ConnectionManager part where it uses 'new File'
> It sounds a related task, but in actual f...
Greg Shah
09:55 AM Base Language Feature #6417: cleanup some known items in appserver support
> agentId, sessionId, threadId: these are 'plugged in' but the Agent doesn't set the to anything (remain unknown).
...
Galya B
08:35 AM Base Language Feature #6417: cleanup some known items in appserver support
Marian, can you help with #6417-19. Something seems wrong with the paths to procedures for @appsrv/runall.p@. Galya B
08:28 AM Base Language Feature #6417: cleanup some known items in appserver support
> > * OO instance serialization and transmission to remote side (GES: are we already handling this in #4658?)
> I gu...
Greg Shah
08:20 AM Base Language Feature #6417: cleanup some known items in appserver support
Greg Shah wrote:
> * OO instance serialization and transmission to remote side (GES: are we already handling this in...
Galya B
08:02 AM Base Language Feature #6417: cleanup some known items in appserver support
@file-cvt-list.txt.soap.rest.webhandler@ (138 procedures) is a subset of @file-cvt-list.txt.rest_and_appserver@ (988 ... Galya B
07:09 AM Base Language Feature #6417: cleanup some known items in appserver support
Galya B wrote:
> Constantin Asofiei wrote:
> > * for SOAP, make sure 'soap:address' is set to '/wsa/wsafwd' in fwd....
Constantin Asofiei
05:16 AM Base Language Feature #6417: cleanup some known items in appserver support
Constantin Asofiei wrote:
> * for SOAP, make sure 'soap:address' is set to '/wsa/wsafwd' in fwd.wsdl. After that, r...
Galya B
03:26 AM Base Language Feature #6417: cleanup some known items in appserver support
> * agentId, sessionId, threadId: these are 'plugged in' but the Agent doesn't set the to anything (remain unknown).
...
Galya B
02:43 AM Base Language Feature #6417: cleanup some known items in appserver support
> * oerequestinfo: adapterType requires enum, which is not supported by FWD yet
I reworked @com.goldencode.p2j.oo.ap...
Galya B
09:13 AM Database Bug #7138: Short circuit fake-update (update with a new value eqaul to the old value) in H2
Alexandru Lungu wrote:
> Please let the application convert over night. After, we can go ahead with proper testing.
...
Dănuț Filimon
09:10 AM Database Bug #7138: Short circuit fake-update (update with a new value eqaul to the old value) in H2
Please let the application convert over night. After, we can go ahead with proper testing. Alexandru Lungu
08:45 AM Database Bug #7138: Short circuit fake-update (update with a new value eqaul to the old value) in H2
I updated the sources for the customer applications but there are some regressions/files missing which I'll need to l... Dănuț Filimon
01:34 AM Runtime Infrastructure Bug #7589: org.slf4j.impl.StaticLoggerBinder when deploying p2j.jar in tomcat
Roger, did you create 7589b? 7589b is merged. It should have been 7589c. Galya B

01/06/2024

10:29 PM Base Language Feature #6422: implement auditing support including AUDIT-POLICY and AUDIT-CONTROL
It seems like you code is a bit different than the trunk. But it still should work:
In @putConnected()@, there is ...
Ovidiu Maxiniuc

01/05/2024

03:09 PM Base Language Feature #6422: implement auditing support including AUDIT-POLICY and AUDIT-CONTROL
I did some debugging and I found that the lookup is happening inside @ConnectionManager.java@ at @Map<String, String>... Theodoros Theodorou
02:48 PM Base Language Feature #6422: implement auditing support including AUDIT-POLICY and AUDIT-CONTROL
Ovidiu Maxiniuc wrote:
> Please check whether the @hotel@ database is connected at the moment @USERID()@ function is...
Theodoros Theodorou
12:56 PM Base Language Feature #6422: implement auditing support including AUDIT-POLICY and AUDIT-CONTROL
I remember we have full support here. IIRC, there were some differences between Linux and Windows and whether the @_U... Ovidiu Maxiniuc
10:18 AM Base Language Feature #6422: implement auditing support including AUDIT-POLICY and AUDIT-CONTROL
Ovidiu: Do you recall the status of our @userid@ implementation? What should be happening here? Greg Shah
08:06 AM Base Language Feature #6422: implement auditing support including AUDIT-POLICY and AUDIT-CONTROL
Greg Shah wrote:
> > Ok. There is @/security/accounts/osusers/osuser@ and @webClient/defaultOsUser@ in @hotel_gui@. ...
Theodoros Theodorou
12:08 PM Runtime Infrastructure Bug #7589: org.slf4j.impl.StaticLoggerBinder when deploying p2j.jar in tomcat
Branch 7589b was rebased to trunk_14912 and is at revision 14914. Roger Borrello
10:50 AM Runtime Infrastructure Bug #7589 (Review): org.slf4j.impl.StaticLoggerBinder when deploying p2j.jar in tomcat
Galya: Please review. Greg Shah
10:41 AM Runtime Infrastructure Bug #7589: org.slf4j.impl.StaticLoggerBinder when deploying p2j.jar in tomcat
I tested @postbuild.sh@ with a bogus file, such that I would be able to test my dockerfile's ability to handle a @bui... Roger Borrello
09:14 AM Database Bug #7776 (Closed): Previous regression on FWD-H2 lazy mode
Greg Shah
04:07 AM Database Bug #7776 (Test): Previous regression on FWD-H2 lazy mode
This can be closed. Alexandru Lungu
09:14 AM Database Bug #8032 (Closed): Deleted records are returned by a preselect query
Greg Shah
04:06 AM Database Bug #8032: Deleted records are returned by a preselect query
5768a was merged to trunk. This task can be Closed. Alexandru Lungu
08:56 AM Base Language Feature #6417: cleanup some known items in appserver support
Constantin Asofiei wrote:
> Import these in SoapUI and see if these work. There is also a @file-cvt-list.txt.rest_a...
Galya B
08:03 AM Base Language Feature #6417: cleanup some known items in appserver support
> * versioninfo fields are read-only, but writing them is a runtime error and not compile error in FWD.
Solved in ...
Galya B
04:14 AM Base Language Feature #6417: cleanup some known items in appserver support
Greg Shah wrote:
> * a QUIT on the remote side quits the client
Solved in r14910. @appsrv/test/test_raise_quit.p@...
Galya B
08:05 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
Galya B wrote:
> Ovidiu Maxiniuc wrote:
> > At any rate, I think @Pair@ and @StringUtils@ are the only class from t...
Greg Shah
02:42 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
Ovidiu Maxiniuc wrote:
> At any rate, I think @Pair@ and @StringUtils@ are the only class from that package/library ...
Galya B
02:39 AM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
We've started discussing how to access the DB configs in #7572-134 and I mentioned an issue noone paid attention to, ... Galya B
05:12 AM Database Feature #6720: lazy hydration
Eduard, please assist the regression hunting here. I am aware that you have a more suitable environment for regressio... Alexandru Lungu
05:08 AM Database Feature #7382: Check performance of delete from vs drop table in H2
Alexandru [ad], please provide a prototype for this task asap. Alexandru Lungu
04:04 AM Database Feature #7416 (Test): Reiterate DatabaseStatistics and leverage to other database profling tools
Alexandru Lungu
04:01 AM Database Bug #7138 (Internal Test): Short circuit fake-update (update with a new value eqaul to the old va...
Greg Shah wrote:
> What is the status of 7138a_h2? Does it need more review? More testing? It seems to provide a ...
Alexandru Lungu
03:56 AM Database Bug #7167: Associating records from opened buffers to new sessions is slow
Danut, I don't think that the shift to 10s looks OK with these statistics. Mind that we "lock" a connection from the ... Alexandru Lungu
03:48 AM Database Feature #6825 (WIP): improve table meta runtime (TableMapper and other)
Alexandru [ad], please attempt to continue profiling and optimization of @TableMapper@. The recent changes shifted a ... Alexandru Lungu

01/04/2024

03:56 PM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
I had a look over 7884a/14843. I see it already uses some of the ideas I wrote above. I have only a few notes:
* I...
Ovidiu Maxiniuc
03:27 PM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
Eric Faulhaber wrote:
> Greg Shah wrote:
> > Eric: Is @org.apache.commons.lang3.tuple.*@ a supported/approved libra...
Ovidiu Maxiniuc
03:01 PM User Interface Feature #7884: Standard 4GL methods used for login screen authentication to be exposed in session...
In #7884-32 Galya B wrote:
> Ovidiu Maxiniuc wrote:
> > For the second part. Provided the @ldbname@, the database c...
Ovidiu Maxiniuc
12:26 PM Runtime Infrastructure Bug #7589: org.slf4j.impl.StaticLoggerBinder when deploying p2j.jar in tomcat
Galya B wrote:
> Roger Borrello wrote:
> > In order to achieve a level of flexibility in the Docker versions of pro...
Roger Borrello
03:36 AM Runtime Infrastructure Bug #7589: org.slf4j.impl.StaticLoggerBinder when deploying p2j.jar in tomcat
Roger Borrello wrote:
> In order to achieve a level of flexibility in the Docker versions of projects, the Dockerfil...
Galya B
08:46 AM User Interface Bug #8074 (Closed): Preferred UI Theme not selected in web with auto-login and forked sessions
Greg Shah
08:42 AM User Interface Bug #8074 (Test): Preferred UI Theme not selected in web with auto-login and forked sessions
8074a was merged to trunk as rev. 14911 and archived. Galya B
08:30 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
It can be merged to trunk now. Greg Shah
07:52 AM User Interface Bug #8074 (Merge Pending): Preferred UI Theme not selected in web with auto-login and forked sess...
Galya B wrote:
> It's been tested before the review and now I've tested the newly introduced changes - @UserPreferen...
Hynek Cihlar
07:18 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
It's been tested before the review and now I've tested the newly introduced changes - @UserPreferences@ needed some m... Galya B
03:45 AM User Interface Bug #8074 (Internal Test): Preferred UI Theme not selected in web with auto-login and forked sess...
Code review 8074a revisions 14865 and 14866. The changes are good, I have no more concerns. Do you plan any more test... Hynek Cihlar
02:20 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
r14866 Theme without value in directory to use class name in the dropdown Galya B
02:09 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
Hynek Cihlar wrote:
> Galya B wrote:
> > Hynek Cihlar wrote:
> > > Code review 8074a.
> > >
> > > @WebDriverHan...
Galya B

01/03/2024

01:29 PM Runtime Infrastructure Bug #7589: org.slf4j.impl.StaticLoggerBinder when deploying p2j.jar in tomcat
Thanks for the explanation. In order to achieve a level of flexibility in the Docker versions of projects, the Docker... Roger Borrello
08:24 AM Runtime Infrastructure Bug #7589: org.slf4j.impl.StaticLoggerBinder when deploying p2j.jar in tomcat
Roger Borrello wrote:
> Galya B wrote:
> > If you want to introduce a related change, please take into consideratio...
Galya B
08:17 AM Runtime Infrastructure Bug #7589: org.slf4j.impl.StaticLoggerBinder when deploying p2j.jar in tomcat
Galya B wrote:
> If you want to introduce a related change, please take into consideration that with 7589b @postbuil...
Roger Borrello
02:25 AM Runtime Infrastructure Bug #7589: org.slf4j.impl.StaticLoggerBinder when deploying p2j.jar in tomcat
Roger Borrello wrote:
> Happy New Year!
Happy New Year!
> There were also a couple of oversights with this bra...
Galya B
12:10 PM User Interface Bug #7515: FILL-IN: editing dates issues
Another minor issue:
OE: when the cursor points to a delimiter, and the user inputs the *same* delimiter character...
Vladimir Tsichevski
11:25 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
Galya B wrote:
> Hynek Cihlar wrote:
> > Code review 8074a.
> >
> > @WebDriverHandler.getAvailableThemes@ should...
Hynek Cihlar
10:55 AM Base Language Feature #6417: cleanup some known items in appserver support
Galya B wrote:
> It won't help with #6417-5 that is to make clear the requirement (do we want a runtime or compile e...
Constantin Asofiei
09:30 AM Base Language Feature #6417: cleanup some known items in appserver support
Constantin Asofiei wrote:
> Import these in SoapUI and see if these work. There is also a @file-cvt-list.txt.rest_a...
Galya B
09:11 AM Base Language Feature #6417: cleanup some known items in appserver support
> * some errors throw by SERVER:CONNECT are not the same
Tests in @testcases/appsrv/test/connect_errors/@ are now ...
Galya B
06:47 AM Base Language Feature #6417: cleanup some known items in appserver support
Galya, these are the steps to run the web tests from xfer testcases; some info is at [[p2j:Testcases#Running-Web-test... Constantin Asofiei
03:00 AM Base Language Feature #6422: implement auditing support including AUDIT-POLICY and AUDIT-CONTROL
Theodoros Theodorou wrote:
> > * @AuditDbOps@
> > ** is @meta_aud_audit_data@ hard-coded SQL name valid for all sup...
Constantin Asofiei

01/02/2024

01:54 PM Runtime Infrastructure Bug #7589: org.slf4j.impl.StaticLoggerBinder when deploying p2j.jar in tomcat
Happy New Year!
I just wanted to post a "public service announcement" as this update to @postbuild.sh@ creates a ...
Roger Borrello
08:12 AM Runtime Infrastructure Bug #7589 (Test): org.slf4j.impl.StaticLoggerBinder when deploying p2j.jar in tomcat
7589b was merged to trunk as rev. 14908 and archived. Galya B
07:55 AM Runtime Infrastructure Bug #7589: org.slf4j.impl.StaticLoggerBinder when deploying p2j.jar in tomcat
You can merge now. Greg Shah
08:52 AM Base Language Feature #6422: implement auditing support including AUDIT-POLICY and AUDIT-CONTROL
> Ok. There is @/security/accounts/osusers/osuser@ and @webClient/defaultOsUser@ in @hotel_gui@. Which one should I u... Greg Shah
08:28 AM Base Language Bug #8119 (Closed): JavaDoc build task produces more warnings in Windows in comparison to Linux
Greg Shah
08:23 AM Base Language Bug #8119: JavaDoc build task produces more warnings in Windows in comparison to Linux
New param @javadoc.verbose@ added to [[p2j:Building_FWD_From_Source#Build-Properties]]. Galya B
08:11 AM Base Language Bug #8119: JavaDoc build task produces more warnings in Windows in comparison to Linux
Please add this new property to "Build Properties":/projects/p2j:Building_FWD_From_Source#Build-Properties. Greg Shah
08:05 AM Base Language Bug #8119 (Test): JavaDoc build task produces more warnings in Windows in comparison to Linux
8119a was merged to trunk as rev. 14907 and archived. Galya B
07:56 AM Base Language Bug #8119: JavaDoc build task produces more warnings in Windows in comparison to Linux
You can merge now. Greg Shah
08:09 AM Deployment Support #3303: make the automated deployment process fully production ready
Branch 3303a was merged into trunk revision 14898 and archived. Roger Borrello

01/01/2024

05:55 PM Base Language Feature #6422: implement auditing support including AUDIT-POLICY and AUDIT-CONTROL
> * @AuditDbOps@
> ** is @meta_aud_audit_data@ hard-coded SQL name valid for all supported dialects? *Eric:* here I ...
Theodoros Theodorou
09:09 AM Base Language Feature #4392: add -pf support for appserver CONNECT() method
Constantin Asofiei wrote:
> Review of 4392a rev 14868:
> * ConnectHelper - is it possible to go into an infinite re...
Galya B
04:09 AM Base Language Feature #4392: add -pf support for appserver CONNECT() method
Ovidiu Maxiniuc wrote:
> Constantin Asofiei wrote:
> > * FileStream - *Ovidiu*: I understand the purpose of 'hasDup...
Galya B
04:05 AM Base Language Feature #4392: add -pf support for appserver CONNECT() method
Constantin Asofiei wrote:
> * we need to fix the ConnectionManager part where it uses 'new File'
It sounds a relate...
Galya B
03:57 AM User Interface Bug #8074: Preferred UI Theme not selected in web with auto-login and forked sessions
Hynek Cihlar wrote:
> Code review 8074a.
>
> @WebDriverHandler.getAvailableThemes@ should somehow handle a theme ...
Galya B
03:00 AM Base Language Bug #8119: JavaDoc build task produces more warnings in Windows in comparison to Linux
Greg Shah wrote:
> Code Review Task Branch 8119a Revisions 14874 and 14875
>
> The changes are good.
>
> Pleas...
Galya B
02:55 AM Runtime Infrastructure Bug #7589: org.slf4j.impl.StaticLoggerBinder when deploying p2j.jar in tomcat
Greg Shah wrote:
> Code Review Task Branch 7589b Revision 14868
>
> The changes look good. If suitable testing h...
Galya B
 

Also available in: Atom