FWD

06/27/2024

04:30 PM User Interface Bug #8809: Incorrect next enabled widget calculation

Greg Shah wrote:
> 6667g is based on a recent trunk.
6667g is based on trunk rev. 15270 of 2024-06-05, while the ... Vladimir Tsichevski

01:05 PM User Interface Bug #8809: Incorrect next enabled widget calculation

6667g is based on a recent trunk. It can't be migrated back to 6667i because GSO 440 fails (some regression caused b... Greg Shah

11:42 AM User Interface Bug #8809: Incorrect next enabled widget calculation

Hynek Cihlar wrote:
> Code review 8809a. The changes look good, but it will require good amount of regression testin... Vladimir Tsichevski

11:41 AM User Interface Bug #8770: ENTRY event is not sent for a frame when window receives focus

To complete this change testing, the change in 8809a must be also applied. Vladimir Tsichevski

11:21 AM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'

8593d passed ETF testing. Constantin Asofiei

09:06 AM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'

Alexandru, I've rebased 8593d from trunk rev 15311 . In 8593d/15314 there are several changes:
* during FILL will a... Constantin Asofiei

06/26/2024

02:27 PM User Interface Bug #8872: WAIT-FOR with FOCUS explicitly specified: NO-APPLY return from ENTRY trigger must be i...

One mode difference for the following modification of the original example:... Vladimir Tsichevski

02:18 PM User Interface Bug #8872: WAIT-FOR with FOCUS explicitly specified: NO-APPLY return from ENTRY trigger must be i...

An additional issue related to @WAIT-FOR@ with explicit focus discovered:
In the following modified version of @8770... Vladimir Tsichevski

08:43 AM Base Language Bug #8643: ErrorManager not handling caught errors and error-status:error attribute properly

The change mentioned in #8643-15 is not ok, the method called is @RecordBuffer.validate()@ which calls @flush(true)@ ... Dănuț Filimon

05:51 AM Base Language Bug #8643: ErrorManager not handling caught errors and error-status:error attribute properly

It's caused by the revalidation of the record in @BlockManager.processForBody()@:... Dănuț Filimon

05:38 AM Base Language Bug #8643: ErrorManager not handling caught errors and error-status:error attribute properly

*8643a* changes fail this test where the error is shown into a modal instead of being caught by the catch block:
<pr... Dănuț Filimon

04:57 AM Base Language Bug #8643: ErrorManager not handling caught errors and error-status:error attribute properly

I've posted my results in #8308-403 where I compared the previously made changes from 8308e with the new changes from... Dănuț Filimon

03:52 AM Base Language Bug #8643: ErrorManager not handling caught errors and error-status:error attribute properly

I'll be testing with the attached patch, let me know if it's not correct.
*EDIT*: the patch does not contain the *... Dănuț Filimon

03:47 AM Base Language Bug #8643: ErrorManager not handling caught errors and error-status:error attribute properly

Constantin, patching ErrorManager for 7156b is a bit hard to understand as there are no @ServerErrorDataAccessor@ and... Dănuț Filimon

07:57 AM Base Language Feature #6417: cleanup some known items in appserver support

The documentation for the original implementation in FWD is at [[p2j:Appserver_Support]] and [[p2j:Setup_and_Configur... Constantin Asofiei

07:44 AM Base Language Feature #4347: add runtime support for STOP-AFTER block option

Are all of your testcases meeting the following criteria?
* Checked into xfer [[p2j:Testcases]] project.
* Implem... Greg Shah

04:36 AM Base Language Feature #4347 (Test): add runtime support for STOP-AFTER block option

Alexandru Lungu

04:34 AM Base Language Feature #4347: add runtime support for STOP-AFTER block option

4347a was merged into trunk revision 15310, and archived. Eduard Soltan

02:33 AM Base Language Feature #4347 (Merge Pending): add runtime support for STOP-AFTER block option

ChUI regression passed. One test failed (time-out) when running all tests automatically, but I re-run it manually and... Alexandru Lungu

07:41 AM Base Language Feature #8904: implement -catchStop and the integration/conversion of STOP conditions into except...

See #4347-19 and following for a discussion about how @STOP@ conditions can be converted into @Progress.Lang.Stop@ ex... Greg Shah

07:38 AM Base Language Feature #8904 (Closed): implement -catchStop and the integration/conversion of STOP conditions in...

Greg Shah

06:53 AM Conversion Tools Feature #8849: Automatic dependencies conversion

Found one issue with internal procedures which aren't really external dependencies so attempting to convert those was... Marian Edu

02:50 AM Database Bug #8878 (Internal Test): Jumble sort dictates a full preselect

Should I do some more testing for 8878a? Artur Școlnic

06/25/2024

11:24 AM User Interface Bug #8770: ENTRY event is not sent for a frame when window receives focus

After the initial patch the @ENTRY@ event is sent twice to the @innerFrame@ in the example.
The sending code remov... Vladimir Tsichevski

10:28 AM Base Language Bug #8643: ErrorManager not handling caught errors and error-status:error attribute properly

I've rebased 7643a from trunk rev 15308.
The changes are in rev 15311. With this, the tests in #8308-397, #8308-3... Constantin Asofiei

03:12 AM Base Language Bug #8643: ErrorManager not handling caught errors and error-status:error attribute properly

Constantin Asofiei wrote:
> Dănuț Filimon wrote:
> > Committed *8643a/rev.15307* which contains the 15272 and 15273... Dănuț Filimon

10:22 AM Runtime Infrastructure Feature #8900: memory management for FWD contexts

All FWD clients run in the same FWD server JVM. This includes Web/ChUI clients, batch processes and also appserver a... Constantin Asofiei

10:15 AM Runtime Infrastructure Feature #8900 (New): memory management for FWD contexts

Constantin Asofiei

08:46 AM Base Language Feature #6417: cleanup some known items in appserver support

Just a quick note to inform you the tests for consuming WS from 4GL (FWD) client were converted to ABLUnit - availabl... Marian Edu

08:15 AM Base Language Feature #6417: cleanup some known items in appserver support

Greg Shah wrote:
> > I think I should implement it and wait for the review to discuss it further, as per usual.
>
... Galya B

08:14 AM Base Language Feature #6417: cleanup some known items in appserver support

> I think I should implement it and wait for the review to discuss it further, as per usual.
Does this really have... Greg Shah

07:45 AM Base Language Feature #6417: cleanup some known items in appserver support

Marian, thanks for the references.
I've read the Progress documentation, so my question was if we do Progress-like... Galya B

07:39 AM Base Language Feature #6417: cleanup some known items in appserver support

Galya B wrote:
> Greg Shah wrote:
> > Aren't we simulating the nameserver lookup with our services configuration in... Marian Edu

06:58 AM Base Language Feature #6417: cleanup some known items in appserver support

Greg Shah wrote:
> If I understand correctly, we are just trying to bypass the nameserver nonsense and use the servi... Galya B

06:48 AM Base Language Feature #6417: cleanup some known items in appserver support

Constantin: Please provide some details about how this is supposed to work and why we have it.
Consider that appli... Greg Shah

06:29 AM Base Language Feature #6417: cleanup some known items in appserver support

Greg Shah wrote:
> Aren't we simulating the nameserver lookup with our services configuration in the directory?
We ... Galya B

06:23 AM Base Language Feature #6417: cleanup some known items in appserver support

Aren't we simulating the nameserver lookup with our services configuration in the directory? Greg Shah

03:33 AM Base Language Feature #6417: cleanup some known items in appserver support

Galya B wrote:
> Greg Shah wrote:
> > We have no need for the nameserver. We don't plan to implement a replacement... Galya B

01:58 AM Base Language Feature #6417: cleanup some known items in appserver support

Greg Shah wrote:
> We have no need for the nameserver. We don't plan to implement a replacement for it. Any functi... Galya B

08:08 AM User Interface Bug #8872: WAIT-FOR with FOCUS explicitly specified: NO-APPLY return from ENTRY trigger must be i...

Greg Shah wrote:
> You might as well resolve it here.
I did. Now the change causes addition failed tests in the C... Vladimir Tsichevski

07:33 AM Runtime Infrastructure Feature #7279: Enhance CentralLogger to support configurable LogFormatter

It is possible that a customer's slf4j implementation will cause dependency conflicts with FWD. This will be an issu... Greg Shah

07:21 AM Runtime Infrastructure Feature #7279: Enhance CentralLogger to support configurable LogFormatter

Full flexibility in log formats can be achieved by using a well-established @slf4j@ implementation. Many customers al... Galya B

07:07 AM User Interface Bug #7824: Simplify idle connection settings and apply the default configuration for the web clie...

Galya B wrote:
> Sergey Ivanovskiy wrote:
> > These two timeout parameters of @webClient@
> > [...]
> > define t... Sergey Ivanovskiy

06:35 AM User Interface Bug #7824: Simplify idle connection settings and apply the default configuration for the web clie...

Sergey Ivanovskiy wrote:
> These two timeout parameters of @webClient@
> ... Galya B

02:50 AM Database Bug #7924 (Internal Test): add support for creating an empty database

Ovidiu Maxiniuc wrote:
> Review of 7924a, rev.15307-15311.
> I saw no problem in the new code except for:
>
> * ... Dănuț Filimon

06/24/2024

09:55 AM Base Language Feature #6417: cleanup some known items in appserver support

We have no need for the nameserver. We don't plan to implement a replacement for it. Any functionality choices shou... Greg Shah

09:44 AM Base Language Feature #6417: cleanup some known items in appserver support

What's different in FWD is that appserver connect works without nameserver and without @-DirectConnect@. In Progress ... Galya B

08:47 AM Base Language Feature #6417: cleanup some known items in appserver support

Greg Shah wrote:
> Galya B wrote:
> > Constantin, I don't understand what is the function of the appserver config @... Galya B

08:43 AM Base Language Feature #6417: cleanup some known items in appserver support

Galya B wrote:
> Constantin, I don't understand what is the function of the appserver config @services@ in the conte... Greg Shah

08:40 AM Base Language Feature #6417: cleanup some known items in appserver support

> > Where to find the 'TCP/IP services file' in Progress, where the IP <-> service name is configured for appserver c... Greg Shah

06:21 AM Base Language Feature #6417: cleanup some known items in appserver support

Another question: How to configure a default appserver for Progress nameserver? There is no such config in the web ma... Galya B

05:49 AM Base Language Feature #6417: cleanup some known items in appserver support

Constantin, I don't understand what is the function of the appserver config @services@ in the context of the finding ... Galya B

05:28 AM Base Language Feature #6417: cleanup some known items in appserver support

Galya B wrote:
> Where to find the 'TCP/IP services file' in Progress, where the IP <-> service name is configured f... Galya B

04:03 AM Base Language Feature #6417: cleanup some known items in appserver support

Where to find the 'TCP/IP services file' in Progress, where the IP <-> service name is configured for appserver connect? Galya B

02:03 AM Base Language Feature #6417 (WIP): cleanup some known items in appserver support

6417d was merged to trunk as rev. 15307 and archived. Galya B

01:55 AM Base Language Feature #6417 (Merge Pending): cleanup some known items in appserver support

Galya, please merge 6417d Constantin Asofiei

06/22/2024

08:11 PM Database Bug #7924: add support for creating an empty database

Review of 7924a, rev.15307-15311.
Good job!
The majority of the changes are required for carrying along the manda... Ovidiu Maxiniuc

06/21/2024

02:30 PM Base Language Bug #8643: ErrorManager not handling caught errors and error-status:error attribute properly

Dănuț Filimon wrote:
> Committed *8643a/rev.15307* which contains the 15272 and 15273 revisions from *8308e*. (see #... Constantin Asofiei

10:29 AM Base Language Bug #8643: ErrorManager not handling caught errors and error-status:error attribute properly

Committed *8643a/rev.15307* which contains the 15272 and 15273 revisions from *8308e*. (see #8308-397) Dănuț Filimon

10:12 AM Base Language Bug #8643: ErrorManager not handling caught errors and error-status:error attribute properly

Created *8643a*. Dănuț Filimon

02:28 PM Base Language Feature #4347: add runtime support for STOP-AFTER block option

Alexandru Lungu wrote:
> > ETF or some other appserver application testing to confirm that we haven't affected anyth... Constantin Asofiei

10:24 AM Base Language Feature #4347: add runtime support for STOP-AFTER block option

Smoke tests for a customer GUI application passed. Șerban Bursuc

10:13 AM Base Language Feature #4347: add runtime support for STOP-AFTER block option

Rebased 4347a to latest trunk. It is now at rev. 15315. Alexandru Lungu

09:59 AM Base Language Feature #4347: add runtime support for STOP-AFTER block option

I am rebasing this now. Alexandru Lungu

09:58 AM Base Language Feature #4347: add runtime support for STOP-AFTER block option

> ChUI regression testing. It uses virtual sessions and more than one FWD server which is definitely affected by thes... Alexandru Lungu

09:42 AM Base Language Feature #4347: add runtime support for STOP-AFTER block option

Additional testing:
* ChUI regression testing. It uses virtual sessions and more than one FWD server which is def... Greg Shah

09:08 AM Base Language Feature #4347: add runtime support for STOP-AFTER block option

Committed on 4347a, revision 15212. Eduard Soltan

09:02 AM Base Language Feature #4347 (Internal Test): add runtime support for STOP-AFTER block option

Eduard, please assess #4347-68 for 4347a.
This should be ready to be merged, right? Greg, other testing you sugges... Alexandru Lungu

08:56 AM Base Language Feature #4347: add runtime support for STOP-AFTER block option

I tested Ctrl-C tests, with 4347a changes. And haven't got any regressions.
Also tested customer scenario, and it ... Eduard Soltan

12:09 PM Base Language Feature #6417: cleanup some known items in appserver support

No, no, I'm reverting, sorry, this is safer. Reverted in r15312. Galya B

12:08 PM Base Language Feature #6417: cleanup some known items in appserver support

Or at least I need to add one @if (port == 0)@ before the filter. Galya B

12:04 PM Base Language Feature #6417: cleanup some known items in appserver support

I think we should revert the @serviceName@ check. Less errors thrown, better. I think it's not correct now. What if i... Galya B

12:02 PM Base Language Feature #6417: cleanup some known items in appserver support

Galya B wrote:
> Constantin Asofiei wrote:
> > So you can have both port and serviceName. More, serviceName for UR... Constantin Asofiei

11:59 AM Base Language Feature #6417: cleanup some known items in appserver support

Constantin Asofiei wrote:
> So you can have both port and serviceName. More, serviceName for URL connections is con... Galya B

11:46 AM Base Language Feature #6417: cleanup some known items in appserver support

See r15311. I'm committing the test without the if, it works well now. Galya B

11:40 AM Base Language Feature #6417: cleanup some known items in appserver support

Constantin Asofiei wrote:
> > @appsrv/test/connect_errors/service_name.p@ is successful. Is it not?
> It's a 'false... Galya B

11:38 AM Base Language Feature #6417: cleanup some known items in appserver support

Galya B wrote:
> Constantin Asofiei wrote:
> > > Constantin Asofiei wrote:
> > > > There is also an issue with @(s... Constantin Asofiei

11:37 AM Base Language Feature #6417: cleanup some known items in appserver support

Constantin Asofiei wrote:
> > Constantin Asofiei wrote:
> > > There is also an issue with @(serviceName == null || ... Galya B

11:20 AM Base Language Feature #6417: cleanup some known items in appserver support

Galya B wrote:
> Our @-S@ is both @serviceName@ and @port@. So the port can be declared @0@ in the connect string, w... Constantin Asofiei

10:56 AM Base Language Feature #6417: cleanup some known items in appserver support

Note #6417-283 edited. Galya B

10:54 AM Base Language Feature #6417: cleanup some known items in appserver support

Galya B wrote:
> Constantin Asofiei wrote:
> > Galya, please add back the @if (port != 0)@ test - this is required ... Galya B

10:33 AM Base Language Feature #6417: cleanup some known items in appserver support

Constantin Asofiei wrote:
> Galya, please add back the @if (port != 0)@ test - this is required for connection strin... Galya B

10:29 AM Base Language Feature #6417: cleanup some known items in appserver support

Galya, please add back the @if (port != 0)@ test - this is required for connection strings like @-AppService app_serv... Constantin Asofiei

10:01 AM Base Language Feature #6417: cleanup some known items in appserver support

Constantin: Please review. Greg Shah

09:32 AM Base Language Feature #6417: cleanup some known items in appserver support

The fix for #7143-1017 is on 6417d. Galya B

08:56 AM Base Language Feature #6417: cleanup some known items in appserver support

This is a list of all testcases/appsrv/test procedures. Before they were converting / compiling fine, now not.
Galya B

05:36 AM Base Language Feature #6417: cleanup some known items in appserver support

Constantin Asofiei wrote:
> There is also an issue with @(serviceName == null || data.services.contains(serviceName)... Galya B

05:29 AM Base Language Feature #6417: cleanup some known items in appserver support

Constantin Asofiei wrote:
> Galya, please let me know when 6417d is available.
6417d is created from trunk r15306 a... Galya B

04:00 AM Base Language Feature #6417: cleanup some known items in appserver support

This is the async test:
* @appsrv/test/test_raise_quit2.p@... Constantin Asofiei

12:09 PM User Interface Bug #7657: 8-bit character entry problem in ChUI

The @7657a@ updated to revision @15287@, rebased with recent trunk @15306@, new revision is @15309@.
The changes t... Eugenie Lyzenko

10:48 AM Database Bug #7924: add support for creating an empty database

Ovidiu: Please review. Greg Shah

06:54 AM Database Bug #7924: add support for creating an empty database

Rebased *7924a* to latest *trunk/rev.15306*, now the branch is at revision *15311*. Dănuț Filimon

04:57 AM Database Feature #8893: Make DDL code generated by FWD matching the SQL dump for respective dialect

Ovidiu Maxiniuc wrote:
> | @primary key (recid)@ | - | This puzzles me a bit. Does PSQL assume the first column (rec... Ovidiu Maxiniuc

06/20/2024

05:19 PM Base Language Feature #4347: add runtime support for STOP-AFTER block option

Code Review Task Branch 4347a Revision 15211
It looks good.
Minor issue: please remove the @import com.goldenco... Greg Shah

03:22 PM Base Language Feature #4347: add runtime support for STOP-AFTER block option

Eduard reported in today's meeting that he was working to get Ctrl+C testing running. Greg, FYI, there is a 4347a/152... Eric Faulhaber

04:46 PM Database Feature #8893: Make DDL code generated by FWD matching the SQL dump for respective dialect

The idea is to generate the code as much as possible identical with the DDLs generated by the RDBMSs. The main reason... Ovidiu Maxiniuc

03:48 PM Database Feature #8893 (New): Make DDL code generated by FWD matching the SQL dump for respective dialect

Ovidiu Maxiniuc

03:36 PM Database Bug #8878: Jumble sort dictates a full preselect

ETF conversion shows no changes with 8878a Constantin Asofiei

03:09 AM Database Bug #8878: Jumble sort dictates a full preselect

I addressed the formatting issues and committed 8878a/15286, awaiting further instructions for testing. Artur Școlnic

10:17 AM Base Language Feature #6417: cleanup some known items in appserver support

Branch 6417c was merged to trunk rev 15305 and archived.
Constantin Asofiei

10:11 AM Base Language Feature #6417: cleanup some known items in appserver support

There is also an issue with the socket connection and 'nohostverify' - I've found when trying to run some reports in ... Constantin Asofiei

08:59 AM Base Language Feature #6417: cleanup some known items in appserver support

Constantin Asofiei wrote:
> * the test does not match the comment, I assume it was meant to be 'not equal':
> [...]... Galya B

08:56 AM Base Language Feature #6417: cleanup some known items in appserver support

Go ahead and merge 6417c. Greg Shah

08:54 AM Base Language Feature #6417: cleanup some known items in appserver support

I've checked @test_raise_stop.p@, @test_raise_quit.p@, @test_return_value.p@ and these work with 6417c and a change i... Constantin Asofiei

08:41 AM Base Language Feature #6417: cleanup some known items in appserver support

Greg Shah wrote:
> > 'Time' doesn't close old tasks by itself. My assessment is that this functionality should not b... Galya B

08:40 AM Base Language Feature #6417: cleanup some known items in appserver support

> 'Time' doesn't close old tasks by itself. My assessment is that this functionality should not be reverted.
That... Greg Shah

08:38 AM Base Language Feature #6417: cleanup some known items in appserver support

Greg Shah wrote:
> > > No one is saying everything is your fault. And who really cares about blame when we simply n... Galya B

08:36 AM Base Language Feature #6417: cleanup some known items in appserver support

> > No one is saying everything is your fault. And who really cares about blame when we simply need to help a custom... Greg Shah

08:33 AM Base Language Feature #6417: cleanup some known items in appserver support

Constantin found the issue early today. If he spoke with me, we might have had already found the proper solution. If ... Galya B

08:31 AM Base Language Feature #6417: cleanup some known items in appserver support

Greg Shah wrote:
> No one is saying everything is your fault. And who really cares about blame when we simply need ... Galya B

08:29 AM Base Language Feature #6417: cleanup some known items in appserver support

Greg Shah wrote:
> runtime issue in converison issue with @FileSystemOps.initFileInfo@ fixed in 15299
This is not i... Galya B

08:28 AM Base Language Feature #6417: cleanup some known items in appserver support

No one is saying everything is your fault. And who really cares about blame when we simply need to help a customer w... Greg Shah

08:27 AM Base Language Feature #6417: cleanup some known items in appserver support

# runtime issue in @FileSystemOps.initFileInfo@ fixed in 15299
# conversion issue in @control_flow.rules@ fixed in 1... Greg Shah

08:25 AM Base Language Feature #6417: cleanup some known items in appserver support

I wondered how I get so many black points in the register. Now I see. All issues in FWD are on my account. Galya B

08:22 AM Base Language Feature #6417: cleanup some known items in appserver support

Greg Shah wrote:
> This is the 3rd regression from 6417a and if the solution Constantin proposes is not obviously sa... Galya B

08:20 AM Base Language Feature #6417: cleanup some known items in appserver support

> > Are you saying it is better to back out 6417a completely?
> I'm obviously saying that a hotfix takes some time a... Greg Shah

08:20 AM Base Language Feature #6417: cleanup some known items in appserver support

Greg Shah wrote:
> Across all of our customers, SOAP is much less used than appserver. For this customer, it is clo... Galya B

08:19 AM Base Language Feature #6417: cleanup some known items in appserver support

Across all of our customers, SOAP is much less used than appserver. For this customer, it is close to a production i... Greg Shah

08:17 AM Base Language Feature #6417: cleanup some known items in appserver support

Greg Shah wrote:
> Are you saying it is better to back out 6417a completely?
I'm obviously saying that a hotfix tak... Galya B

08:15 AM Base Language Feature #6417: cleanup some known items in appserver support

I mean when SOAP wasn't working for days after java 17 related changes merge it wasn't urgent. Galya B

08:15 AM Base Language Feature #6417: cleanup some known items in appserver support

Are you saying it is better to back out 6417a completely? Greg Shah

08:15 AM Base Language Feature #6417: cleanup some known items in appserver support

I'm generally surprised by the urgency of an issue not on production. Even issues on production usually take a day or... Galya B

08:13 AM Base Language Feature #6417: cleanup some known items in appserver support

Greg Shah wrote:
> Galya: Please split this discussion into 2 parts. The first, urgent part is to ensure that 6417c... Galya B

08:10 AM Base Language Feature #6417: cleanup some known items in appserver support

Also don't expect me to remember just like that what a change done months ago involves. That's what automation is about. Galya B

08:07 AM Base Language Feature #6417: cleanup some known items in appserver support

Greg Shah wrote:
> This regression is holding back a customer's testing. While it exists in trunk, they are blocked... Galya B

07:49 AM Base Language Feature #6417: cleanup some known items in appserver support

This regression is holding back a customer's testing. While it exists in trunk, they are blocked. It is urgent to g... Greg Shah

06:19 AM Base Language Feature #6417: cleanup some known items in appserver support

Constantin Asofiei wrote:
> Galya B wrote:
> > Constantin Asofiei wrote:
> > > Galya B wrote:
> > > > Can you exp... Galya B

06:17 AM Base Language Feature #6417: cleanup some known items in appserver support

Galya B wrote:
> Constantin Asofiei wrote:
> > Galya B wrote:
> > > Can you explain why you back it out? What are ... Constantin Asofiei

06:10 AM Base Language Feature #6417: cleanup some known items in appserver support

Constantin Asofiei wrote:
> Galya B wrote:
> > Can you explain why you back it out? What are the steps for reproduc... Galya B

06:07 AM Base Language Feature #6417: cleanup some known items in appserver support

Galya B wrote:
> Can you explain why you back it out? What are the steps for reproducing an issue?
The root cause i... Constantin Asofiei

05:40 AM Base Language Feature #6417: cleanup some known items in appserver support

Can you explain why you back it out? What are the steps for reproducing an issue? Galya B

05:39 AM Base Language Feature #6417: cleanup some known items in appserver support

Constantin Asofiei wrote:
> 6417c rev 15304 backed out part of trunk rev 15287 in AppServerManager - the client need... Galya B

05:37 AM Base Language Feature #6417: cleanup some known items in appserver support

Constantin Asofiei wrote:
> 6417c rev 15304 backed out part of trunk rev 15287 in AppServerManager - the client need... Galya B

05:34 AM Base Language Feature #6417: cleanup some known items in appserver support

Created task branch 6417c from trunk rev 15303.
6417c rev 15304 backed out part of trunk rev 15287 in AppServerMan... Constantin Asofiei

03:12 AM Base Language Feature #6417: cleanup some known items in appserver support

Also the revert in #6417-235 breaks a core functionality of SOAP, so we should address it somehow. Galya B

03:10 AM Base Language Feature #6417: cleanup some known items in appserver support

Constantin, give me more information on #7143-1012. Galya B

07:24 AM Runtime Infrastructure Bug #8624 (Closed): Stream should detect whether it is being used from the client or the server

Greg Shah

04:50 AM Runtime Infrastructure Bug #8624: Stream should detect whether it is being used from the client or the server

Alexandru Lungu wrote:
> 8368b was merged to trunk. Any need to have this #8624 still opened, Serban? If not, lets R... Șerban Bursuc

04:41 AM Runtime Infrastructure Bug #8624: Stream should detect whether it is being used from the client or the server

8368b was merged to trunk. Any need to have this #8624 still opened, Serban? If not, lets Reject it. Alexandru Lungu

06/19/2024

02:43 PM User Interface Bug #8586 (Test): Fields are not in FIELD-GROUP until they are enabled

Greg Shah

02:38 PM User Interface Bug #8586: Fields are not in FIELD-GROUP until they are enabled

Greg Shah wrote:
> This can merge to trunk now.
Done. Trunk rev. 15302. Vladimir Tsichevski

12:07 PM User Interface Bug #8586 (Merge Pending): Fields are not in FIELD-GROUP until they are enabled

This can merge to trunk now. Greg Shah

11:32 AM User Interface Bug #8586: Fields are not in FIELD-GROUP until they are enabled

Vladimir Tsichevski wrote:
> Greg Shah wrote:
> > Have you completed the ChUI regression testing?
>
> Not yet.
... Vladimir Tsichevski

05:33 AM User Interface Bug #8586: Fields are not in FIELD-GROUP until they are enabled

Greg Shah wrote:
> Have you completed the ChUI regression testing?
Not yet. Vladimir Tsichevski

05:32 AM User Interface Bug #8586: Fields are not in FIELD-GROUP until they are enabled

Have you completed the ChUI regression testing? Greg Shah

12:56 PM Base Language Feature #4347: add runtime support for STOP-AFTER block option

After making these changes, please work with Tomasz to run all the CTRL-C tests using this branch. Greg Shah

12:55 PM Base Language Feature #4347: add runtime support for STOP-AFTER block option

Code Review Task Branch 4347a Revision 15210
This is good. It is very close.
1. I'm worried about the use of @... Greg Shah

11:00 AM Base Language Feature #4347: add runtime support for STOP-AFTER block option

Committed on 4347a, revision 15210.
Changed implementation to insert Ctrl-C into TypeAhead queue.
Added as spec... Eduard Soltan

08:39 AM Database Support #8889: evaluate and test the potential for SQL injection attacks

I posted the following in #8667-18:
> My concern here about SQL injection is that these text values can be used to... Greg Shah

08:33 AM Database Support #8889 (New): evaluate and test the potential for SQL injection attacks

Greg Shah

07:55 AM Base Language Feature #6417: cleanup some known items in appserver support

Just a quick note to let you know the tests for calling appsrv from 4GL client (RPC style) were converted to AblUnit ... Marian Edu

04:46 AM Base Language Feature #6417: cleanup some known items in appserver support

Created task branch 6417b from trunk rev 15298 to fix an existing bug exposed by the changes in 6417a.
The fix is ... Constantin Asofiei

03:53 AM Database Bug #8648 (Closed): Recheck ACTIVATE and DEACTIVATE procedures on appserver calls

Branch 8785a was merged to trunk rev 15297 and archived.
I don't think there are other cases where activate/deacti... Constantin Asofiei

06/18/2024

03:35 PM Base Language Feature #4347: add runtime support for STOP-AFTER block option

> > > Perhaps we need to down-call to cause this to occur. But I don't think it is as simple as making a downcall, s... Greg Shah

01:46 PM Base Language Feature #4347: add runtime support for STOP-AFTER block option

Code Review Task Branch 4347a Revision 15209
1. The changes to rewrite the @Control@ synchronization are extensive... Greg Shah

01:29 PM Base Language Feature #4347: add runtime support for STOP-AFTER block option

> >I think we might have to insert @CTRL-C@ into the type ahead queue. Interestingly, that should even work when the... Greg Shah

11:01 AM Base Language Feature #4347: add runtime support for STOP-AFTER block option

Committed on 4347a, revision 15209.
I implemented a mechanism to interrupt a Conversation thread and synchronize the... Eduard Soltan

07:21 AM Database Bug #8878: Jumble sort dictates a full preselect

Review of 8878a/15285.
The only modified file is @preselect_prep.rules@:
* lines 64-65: there are some hard-tabs ... Ovidiu Maxiniuc

03:49 AM Database Bug #8878 (Review): Jumble sort dictates a full preselect

Eric/Ovidiu: please review. Alexandru Lungu

06:40 AM Base Language Feature #6417 (WIP): cleanup some known items in appserver support

Greg Shah

05:31 AM Base Language Feature #6417: cleanup some known items in appserver support

6417a was merged to trunk as rev. 15287 and archived.
Galya B

03:04 AM Base Language Feature #6417: cleanup some known items in appserver support

Constantin Asofiei wrote:
> Galya B wrote:
> > Let me know about 7994a and merge.
> Lets get 6417a to trunk first ... Galya B

03:01 AM Base Language Feature #6417: cleanup some known items in appserver support

Galya B wrote:
> Let me know about 7994a and merge.
Lets get 6417a to trunk first and after that we'll check #7994 ... Constantin Asofiei

02:59 AM Base Language Feature #6417 (Merge Pending): cleanup some known items in appserver support

This can be merged after 8848a Constantin Asofiei

01:36 AM Base Language Feature #6417: cleanup some known items in appserver support

Galya B wrote:
> > Galya, this must be from the Jetty upgrade - we need a @baseRequest.setHandled(true);@ being call... Galya B

12:38 AM Base Language Feature #6417: cleanup some known items in appserver support

Greg Shah wrote:
> Did 6417a pass its testing? If so, I'd like to get it merged.
It passed, but my concern is th... Galya B

06/17/2024

03:31 PM User Interface Bug #7657: 8-bit character entry problem in ChUI

To be clear: we have existing customers that use hardware terminals and we must continue to support their use cases. ... Greg Shah

03:27 PM User Interface Bug #7657: 8-bit character entry problem in ChUI

> Also all Cyrillic letters(just for test, not sure we need this in production).
These were previously working at ... Greg Shah

03:26 PM User Interface Bug #7657: 8-bit character entry problem in ChUI

> Another question. Do we really need to support @UTF-8@ for interactive *ChUI* client? I see in a Progress DOC only ... Greg Shah

03:21 PM User Interface Bug #7657: 8-bit character entry problem in ChUI

> Another word we need to be able to enter the Euro sign(and other possible chars from alternative layout) from keybo... Greg Shah

03:20 PM User Interface Bug #7657: 8-bit character entry problem in ChUI

> We @<company_name>@ support customers all over the world. 255 characters are not enough.
>
> But for now, the cu... Greg Shah

03:18 PM User Interface Bug #7657: 8-bit character entry problem in ChUI

> The @UTF-8@ config issue resolved. So the note #7657-35 can be dropped.
Just to be clear: #7657-19 and #7657-10 ... Greg Shah

03:05 PM Base Language Feature #6417: cleanup some known items in appserver support

Did 6417a pass its testing? If so, I'd like to get it merged. Greg Shah

02:39 PM Base Language Feature #6417: cleanup some known items in appserver support

> Greg/Tomasz: is it worth it to integrate the #7994 work from 6667i into 6417a, so we can merge it to trunk?
Yes,... Greg Shah

02:30 PM Base Language Feature #6417: cleanup some known items in appserver support

Galya, this must be from the Jetty upgrade - we need a @baseRequest.setHandled(true);@ being called always in @SoapHa... Constantin Asofiei

03:29 AM Base Language Feature #6417: cleanup some known items in appserver support

There is something wrong with SOAP on +trunk+. Jetty returns 404, although the @SoapHandler@ handles the requests suc... Galya B

11:05 AM User Interface Bug #6074 (Closed): Movable widget problem

Greg Shah

03:41 AM User Interface Bug #6074 (Test): Movable widget problem

This was fully fixed in 3821c, which was merged to trunk in the meantime. Thus, it can be closed. Alexandru Lungu

08:33 AM Database Bug #8883: ensure FWD data import always creates indexes even if no dump file exists for a table

If there is no data dump file for a table, FWD import process should re-index that table; currently only tables which... Constantin Asofiei

08:25 AM Database Bug #8883 (New): ensure FWD data import always creates indexes even if no dump file exists for a ...

Constantin Asofiei

05:43 AM Database Bug #8878: Jumble sort dictates a full preselect

I committed the changes for jumble sort rule to 8878a/15285. Artur Școlnic

03:46 AM Database Bug #8878: Jumble sort dictates a full preselect

Then we can consider that only the @first@/@last@ queries are converted incorrectly for now. Artur Școlnic

03:44 AM Database Bug #8878: Jumble sort dictates a full preselect

I suppose that the BY affects only the first two table sorting, whereas the third component does not have an imposed ... Alexandru Lungu

03:42 AM Database Bug #8878: Jumble sort dictates a full preselect

I have done some more testing using various queries and I think you are right, however I found a case that I want to ... Artur Școlnic

03:39 AM Database Bug #8878 (WIP): Jumble sort dictates a full preselect

Created 8878a. Please commit your changes to fix this on 8878a. Alexandru Lungu

03:38 AM Database Bug #8878: Jumble sort dictates a full preselect

Artur, you found recently that using EACH for each component is also generating a @PreselectQuery@. I think that this... Alexandru Lungu

02:41 AM Database Bug #8878: Jumble sort dictates a full preselect

... Artur Școlnic

06/15/2024

06:31 PM User Interface Bug #7657: 8-bit character entry problem in ChUI

Fixed the output in wide char mode issue. So now we have at least Euro sign in @ChUI@ terminal session. Also all Cyri... Eugenie Lyzenko

09:50 PM User Interface Bug #7657: 8-bit character entry problem in ChUI

The @7657a@ rebased with recent trunk @15284@, new revision is @15286@. Eugenie Lyzenko

06/14/2024

06:16 PM User Interface Bug #7657: 8-bit character entry problem in ChUI

Another question. Do we really need to support @UTF-8@ for interactive *ChUI* client? I see in a Progress DOC only @G... Eugenie Lyzenko

03:30 PM User Interface Bug #7657: 8-bit character entry problem in ChUI

Robert Jensen wrote:
> We @<company_name>@ support customers all over the world. 255 characters are not enough.
>
... Eugenie Lyzenko

03:11 PM User Interface Bug #7657: 8-bit character entry problem in ChUI

We @<company_name>@ support customers all over the world. 255 characters are not enough.
But for now, the current ... Robert Jensen

02:38 PM User Interface Bug #7657: 8-bit character entry problem in ChUI

The @UTF-8@ config issue resolved. So the note #7657-35 can be dropped.
The other issue here is the input handling... Eugenie Lyzenko

09:07 AM User Interface Bug #7657: 8-bit character entry problem in ChUI

What I have done in the past is put various characters into MAriaDB, then display them. The encoding is UTF-8.
1) 8 ... Robert Jensen

08:38 AM User Interface Bug #7657: 8-bit character entry problem in ChUI

The addition issue here is not clear how to set up @UTF-8@ as @cpinternal@ or @charset@. I have tried 3 ways:
1. @di... Eugenie Lyzenko

10:26 AM Database Bug #8878: Jumble sort dictates a full preselect

Original report:
---
When jumble sort is detected, all queries in a joined query are converted as @PreselectQue... Eric Faulhaber

10:03 AM Database Bug #8878 (Internal Test): Jumble sort dictates a full preselect

Artur Școlnic

10:25 AM Base Language Feature #4347: add runtime support for STOP-AFTER block option

Greg Shah wrote:
>I think we might have to insert @CTRL-C@ into the type ahead queue. Interestingly, that should ev... Eduard Soltan

04:37 AM Database Bug #8868: Fix "Can't normalize FWD value to use it with direct access." error for FieldReference...

Eric Faulhaber wrote:
> Greg Shah wrote:
> > Eric: Please review.
>
> Code review 8868a/15280:
>
> Are there a... Dănuț Filimon

06/13/2024

06:39 PM User Interface Bug #7657: 8-bit character entry problem in ChUI

Robert,
Currently I'm working on the Java part for @UTF-8@ support in @ChUI@. And I need some assistance.
The c... Eugenie Lyzenko

08:54 PM User Interface Bug #7657: 8-bit character entry problem in ChUI

The @7657a@ rebased with recent trunk @15277@, updated to revision @15282@.
With this change the flag to use wide ... Eugenie Lyzenko

11:10 AM Database Bug #8868: Fix "Can't normalize FWD value to use it with direct access." error for FieldReference...

Greg Shah wrote:
> Eric: Please review.
Code review 8868a/15280:
H2 direct access is not an area of the code I... Eric Faulhaber

09:26 AM User Interface Bug #8872: WAIT-FOR with FOCUS explicitly specified: NO-APPLY return from ENTRY trigger must be i...

You might as well resolve it here. Greg Shah

09:17 AM User Interface Bug #8872: WAIT-FOR with FOCUS explicitly specified: NO-APPLY return from ENTRY trigger must be i...

Greg Shah wrote:
> Is this seen in customer code?
>
> > the focus is set to @focusable2@
>
I do not know.
>... Vladimir Tsichevski

09:15 AM User Interface Bug #8872: WAIT-FOR with FOCUS explicitly specified: NO-APPLY return from ENTRY trigger must be i...

Is this seen in customer code?
> the focus is set to @focusable2@
Are you referring to the @FOCUS@ system handle? Greg Shah

09:08 AM User Interface Bug #8872: WAIT-FOR with FOCUS explicitly specified: NO-APPLY return from ENTRY trigger must be i...

Other difference, which can be seen after the main issue fixed:
# OE: before the @ENTRY@ is sent to the @focusable... Vladimir Tsichevski

09:03 AM User Interface Bug #8872 (WIP): WAIT-FOR with FOCUS explicitly specified: NO-APPLY return from ENTRY trigger mus...

The following change fixes this very issue:... Vladimir Tsichevski

07:42 AM Base Language Feature #4347: add runtime support for STOP-AFTER block option

Eduard Soltan wrote:
> Imagine an situation.
> If I am in timer thread and control is on the client side, I send a ... Greg Shah

04:02 AM Base Language Feature #4347: add runtime support for STOP-AFTER block option

Imagine an situation.
If I am in timer thread and control is on the client side, I send a interrupt message to the c... Eduard Soltan

01:30 AM Base Language Feature #6417: cleanup some known items in appserver support

Constantin Asofiei wrote:
> Galya B wrote:
> > Since the tests are up to date, how do I solve #6417-149?
> This is... Galya B

06/12/2024

04:26 PM User Interface Bug #8872: WAIT-FOR with FOCUS explicitly specified: NO-APPLY return from ENTRY trigger must be i...

The @WAIT-FOR@ statement can include the @FOCUS@ option. The initial focus must be set to the widget, specified as th... Vladimir Tsichevski

04:16 PM User Interface Bug #8872 (WIP): WAIT-FOR with FOCUS explicitly specified: NO-APPLY return from ENTRY trigger mus...

Vladimir Tsichevski

11:58 AM User Interface Bug #7684 (Closed): ENTRY event is emitted twice

Stanislav Lomany

11:57 AM User Interface Bug #7684 (Internal Test): ENTRY event is emitted twice

Yes, looks like it is fixed. Stanislav Lomany

09:02 AM User Interface Bug #7684 (Feedback): ENTRY event is emitted twice

Stanislav,
I cannot reproduce the problem you describe. Switching focus to @st2@ with TAB or mouse click generates... Vladimir Tsichevski

11:11 AM Base Language Feature #4347: add runtime support for STOP-AFTER block option

OK, go ahead with that idea. Greg Shah

04:51 AM Base Language Feature #4347: add runtime support for STOP-AFTER block option

Greg Shah wrote:
> Perhaps we need to down-call to cause this to occur. But I don't think it is as simple as making... Eduard Soltan

10:16 AM Base Language Feature #6417: cleanup some known items in appserver support

Galya B wrote:
> Since the tests are up to date, how do I solve #6417-149?
This is tricky; on a first glance, decim... Constantin Asofiei

09:11 AM Base Language Feature #6417: cleanup some known items in appserver support

Constantin Asofiei wrote:
> Galya, I don't think you need to setup OpenEdge to run the REST/SOAP tests.
>
> @webt... Galya B

09:54 AM Runtime Infrastructure Bug #7635 (Closed): RemoteObject defaults to 'tracing' mode

You can dead-archive 7635c. Any work to optimize @isLoggable()@ usage will happen when we get to the work in #1848. Greg Shah

09:49 AM Runtime Infrastructure Bug #7635: RemoteObject defaults to 'tracing' mode

7635b was merged to trunk as rev. 15280 and archived.
7635c created based on trunk r15280. Galya B

09:05 AM Runtime Infrastructure Bug #7635 (WIP): RemoteObject defaults to 'tracing' mode

I'll merge when the great performance issue is fixed properly. Galya B

08:59 AM Runtime Infrastructure Bug #7635: RemoteObject defaults to 'tracing' mode

Greg Shah wrote:
> > Do we consider comparison of two integers heavy computing?
>
> It is the 3 virtual method ca... Galya B

08:54 AM Runtime Infrastructure Bug #7635 (Merge Pending): RemoteObject defaults to 'tracing' mode

You can merge to trunk. Greg Shah

08:53 AM Runtime Infrastructure Bug #7635: RemoteObject defaults to 'tracing' mode

> Do we consider comparison of two integers heavy computing?
It is the 3 virtual method calls that I don't like. ... Greg Shah

03:04 AM Runtime Infrastructure Bug #7635: RemoteObject defaults to 'tracing' mode

Let me know if 7635b needs to be merged. Galya B

03:03 AM Runtime Infrastructure Bug #7635: RemoteObject defaults to 'tracing' mode

Greg Shah wrote:
> Code Review Task Branch 7635b Revision 14275
>
> In the short term, the change is OK. Long te... Galya B

03:11 AM Base Language Bug #8799: ON ERROR UNDO, THROW problems leading to infinite loops

Greg Shah wrote:
> Do you think that 40% is accurate for %Done?
We need to run the tests from xfer - we'll now more... Constantin Asofiei

02:45 AM Base Language Bug #8799: ON ERROR UNDO, THROW problems leading to infinite loops

Constantin Asofiei wrote:
> * Once a structured exception is re-thrown, mark it as explicit, so it can be re-thrown ... Galya B

02:21 AM Database Bug #8868: Fix "Can't normalize FWD value to use it with direct access." error for FieldReference...

Created *8868a* and committed the patch from #8868-1 to *8868a/rev.15280*. Dănuț Filimon

06/11/2024

06:32 PM User Interface Bug #8673: Deduce the logic behind OE focus management and implement in FWD

A strange thing in OE.
The test application:
# Defines a frame @outerFrame@ with a button @focusable4@.
# The ... Vladimir Tsichevski

05:44 PM Base Language Bug #8799 (Test): ON ERROR UNDO, THROW problems leading to infinite loops

Do you think that 40% is accurate for %Done? Greg Shah

05:37 PM Base Language Bug #8799: ON ERROR UNDO, THROW problems leading to infinite loops

Branch 8799a was merged to trunk rev 15279 and archived. Constantin Asofiei

05:16 PM Base Language Bug #8799 (Merge Pending): ON ERROR UNDO, THROW problems leading to infinite loops

You can merge to trunk now. Greg Shah

04:59 PM Base Language Bug #8799: ON ERROR UNDO, THROW problems leading to infinite loops

8799a passed #7156 customer testing and other unit tests. Constantin Asofiei

09:19 AM Base Language Bug #8799: ON ERROR UNDO, THROW problems leading to infinite loops

Code Review Task Branch 8799a Revision 15277
I'm good with the changes. Greg Shah

08:15 AM Base Language Bug #8799 (Internal Test): ON ERROR UNDO, THROW problems leading to infinite loops

Constantin Asofiei

04:12 PM Base Language Feature #4347: add runtime support for STOP-AFTER block option

Eduard Soltan wrote:
> Greg Shah wrote:
> >7. Help me understand why the implementation of Control.setControl() is ... Greg Shah

07:27 AM Base Language Feature #4347: add runtime support for STOP-AFTER block option

Greg Shah wrote:
> 8. In @StopAfterTimer.addTimeOut()@, directly raising @NumberedException@ seems to be incorrect. ... Eduard Soltan

07:22 AM Base Language Feature #4347: add runtime support for STOP-AFTER block option

Greg Shah wrote:
>7. Help me understand why the implementation of Control.setControl() is correct. In particular, do... Eduard Soltan

08:04 PM Base Language Feature #4347: add runtime support for STOP-AFTER block option

Code Review 4347a Revisions 15205 through 15208
1. The @BlockManager.LOG@ should not be initialized using @ErrorMa... Greg Shah

10:55 AM Runtime Infrastructure Bug #7635: RemoteObject defaults to 'tracing' mode

Code Review Task Branch 7635b Revision 14275
In the short term, the change is OK. Long term, I would still prefer... Greg Shah

09:47 AM Database Bug #8868: Fix "Can't normalize FWD value to use it with direct access." error for FieldReference...

Eric: Please review. Greg Shah

08:29 AM Database Bug #8868 (Review): Fix "Can't normalize FWD value to use it with direct access." error for Field...

Dănuț Filimon

08:29 AM Database Bug #8868 (WIP): Fix "Can't normalize FWD value to use it with direct access." error for FieldRef...

Dănuț Filimon

02:56 AM Database Bug #8868: Fix "Can't normalize FWD value to use it with direct access." error for FieldReference...

While testing the unit tests of a customer, I noticed that there are a few instances of @FieldReference@ arguments th... Dănuț Filimon

02:50 AM Database Bug #8868 (Rejected): Fix "Can't normalize FWD value to use it with direct access." error for Fie...

Dănuț Filimon

05:39 AM Base Language Feature #6417: cleanup some known items in appserver support

Galya B wrote:
> Can you check r15302.
The changes look good. I was trying to get a standalone test with FWD clien... Constantin Asofiei

04:18 AM Base Language Feature #6417: cleanup some known items in appserver support

Can you check r15302. Galya B

04:09 AM Base Language Feature #6417: cleanup some known items in appserver support

Galya B wrote:
> Constantin Asofiei wrote:
> > Also, the @server@ handle can also be assigned to @SESSION@ - in thi... Constantin Asofiei

04:00 AM Base Language Feature #6417: cleanup some known items in appserver support

Constantin Asofiei wrote:
> Also, the @server@ handle can also be assigned to @SESSION@ - in this case, @if (serverH... Galya B

03:18 AM Base Language Feature #6417: cleanup some known items in appserver support

Constantin Asofiei wrote:
> by @throw on the Conversion thread@ you meant @throw on the Conversation thread@?
Yes. ... Galya B

02:41 AM Base Language Feature #6417: cleanup some known items in appserver support

Galya B wrote:
> Client type is not done. It will have to be reviewed and tested further. It's way more complicated ... Constantin Asofiei

01:36 AM Base Language Feature #6417: cleanup some known items in appserver support

Constantin Asofiei wrote:
> Review for 6417a/15301 built on trunk rev 15276:
> * @src/com/goldencode/p2j/oo/lang/Oe... Galya B

06/10/2024

02:41 PM Runtime Infrastructure Feature #6692: move FWD to Java 17

I plan on updating the standard workstation build to have both Java's in the same manner as I have currently setup fo... Roger Borrello

11:57 AM Base Language Feature #6417: cleanup some known items in appserver support

Review for 6417a/15301 built on trunk rev 15276:
* @src/com/goldencode/p2j/oo/lang/OeversionInfo.java@
** in the ja... Constantin Asofiei

07:45 AM Base Language Feature #6417: cleanup some known items in appserver support

Constantin Asofiei wrote:
> The runtime needs to be regression tested with ChUI and other unit testing for customer ... Galya B

07:44 AM Base Language Feature #6417: cleanup some known items in appserver support

New r15301 of 6417a based on trunk r15276 ready for review. Galya B

07:29 AM Base Language Feature #6417: cleanup some known items in appserver support

Galya B wrote:
> Other cases need to be fixed by calling a new server exported method, which I forgot and left in TO... Galya B

07:26 AM Base Language Feature #6417: cleanup some known items in appserver support

Constantin Asofiei wrote:
> ** @recordOrThrowError@ can be called from FWD client, too - why @if (serverSide) { thro... Galya B

07:01 AM Base Language Feature #6417: cleanup some known items in appserver support

Constantin Asofiei wrote:
> * @src/com/goldencode/p2j/util/SessionUtils.java@
> ** for @getClientType@, the value o... Galya B

06:46 AM Base Language Feature #6417: cleanup some known items in appserver support

Galya B wrote:
> It fixes a startup procedure being configured without startup params.
OK, just for clarification: ... Constantin Asofiei

06:43 AM Base Language Feature #6417: cleanup some known items in appserver support

Constantin Asofiei wrote:
> Galya B wrote:
> > The last example doesn't work. If you want me to revert the change, ... Galya B

06:40 AM Base Language Feature #6417: cleanup some known items in appserver support

Galya B wrote:
> The last example doesn't work. If you want me to revert the change, it will continue to fail agents... Constantin Asofiei

06:33 AM Base Language Feature #6417: cleanup some known items in appserver support

Constantin Asofiei wrote:
> I'm talking about this code in @Agent.listen@:
> [...]
>
> This is executed when the... Galya B

06:28 AM Base Language Feature #6417: cleanup some known items in appserver support

I'm talking about this code in @Agent.listen@:... Constantin Asofiei

06:22 AM Base Language Feature #6417: cleanup some known items in appserver support

Constantin Asofiei wrote:
> I don't understand - startup procedure defines an input parameter, always. FWD must pas... Galya B

06:16 AM Base Language Feature #6417: cleanup some known items in appserver support

I don't understand - startup procedure defines an input parameter, always. FWD must pass this argument, otherwise th... Constantin Asofiei

06:14 AM Base Language Feature #6417: cleanup some known items in appserver support

Constantin Asofiei wrote:
> * @src/com/goldencode/p2j/util/Agent.java@
> ** Agent's startup-procedure signature alw... Galya B

05:19 AM Base Language Feature #6417: cleanup some known items in appserver support

Comment this line, at the time this was written I think there was a problem with the log:
> // generateRestTests(RES... Constantin Asofiei

02:51 AM Base Language Feature #6417: cleanup some known items in appserver support

@SoapUILog2Harness@ doesn't compile. Galya B

02:44 AM Base Language Feature #6417: cleanup some known items in appserver support

Constantin Asofiei wrote:
> Galya, I don't think you need to setup OpenEdge to run the REST/SOAP tests.
>
> @webt... Galya B

02:37 AM Base Language Feature #6417: cleanup some known items in appserver support

Marian Edu wrote:
> Galya B wrote:
> > I need confirmation if I got it right: I need to figure out by myself how to... Galya B

04:30 AM User Interface Bug #8586: Fields are not in FIELD-GROUP until they are enabled

Alexandru Lungu wrote:
> Vladimir, are the changes in 8586a going to fix #8068 as well. If so, what testing do you t... Vladimir Tsichevski

03:22 AM User Interface Bug #8586: Fields are not in FIELD-GROUP until they are enabled

Vladimir, are the changes in 8586a going to fix #8068 as well. If so, what testing do you think are required for this? Alexandru Lungu

06/09/2024

10:46 AM Base Language Feature #6417: cleanup some known items in appserver support

Review for 6417a/15226 built on trunk rev 15202:
* branch needs rebase
* files with missing history entry:... Constantin Asofiei

02:39 AM Base Language Bug #8799: ON ERROR UNDO, THROW problems leading to infinite loops

Created task branch 8799a from trunk rev 15266. Rev 15277 has:
* Once a structured exception is re-thrown, mark it ... Constantin Asofiei

06/07/2024

09:27 AM Base Language Feature #6417: cleanup some known items in appserver support

Galya, I don't think you need to setup OpenEdge to run the REST/SOAP tests.
@webtests_from_logs@ is meant to autom... Constantin Asofiei

09:19 AM Base Language Feature #6417: cleanup some known items in appserver support

Galya B wrote:
> I need confirmation if I got it right: I need to figure out by myself how to setup Progress classic... Marian Edu

08:46 AM Base Language Feature #6417: cleanup some known items in appserver support

I need confirmation if I got it right: I need to figure out by myself how to setup Progress classic appserver with RE... Galya B

08:21 AM Base Language Feature #6417: cleanup some known items in appserver support

Greg Shah wrote:
> > The comment also says run all SoapUI tests. Am I supposed to set SOAP and REST api in Progress ... Galya B

08:14 AM Base Language Feature #6417: cleanup some known items in appserver support

> The comment also says run all SoapUI tests. Am I supposed to set SOAP and REST api in Progress corresponding to wha... Greg Shah

07:58 AM Base Language Feature #6417: cleanup some known items in appserver support

Greg Shah wrote:
> Is this not what was documented in #6417-8 and following discussion?
The "documentation" is ex... Galya B

07:40 AM Base Language Feature #6417: cleanup some known items in appserver support

Is this not what was documented in #6417-8 and following discussion? Greg Shah

07:33 AM Base Language Feature #6417: cleanup some known items in appserver support

Greg Shah wrote:
> Setup equivalent testing environments in both OE and FWD.
Hasn't this already been done / docume... Galya B

07:29 AM Base Language Feature #6417: cleanup some known items in appserver support

Can you start with this:
# Setup equivalent testing environments in both OE and FWD.
# Run the tests in both envi... Greg Shah

07:25 AM Base Language Feature #6417: cleanup some known items in appserver support

I can't proceed with fixing all tests or related issues in FWD appservers without clear documentation what has been d... Galya B

07:24 AM Base Language Feature #6417: cleanup some known items in appserver support

We should separate our artifacts from OE and FWD. Either by more specific name or by separate directories. Greg Shah

07:19 AM Base Language Feature #6417: cleanup some known items in appserver support

Constantin Asofiei wrote:
> Galya B wrote:
> > So @webtests_from_logs/results/20211112_201954_soap_classic/test_set... Galya B

07:17 AM Base Language Feature #6417: cleanup some known items in appserver support

Galya B wrote:
> Constantin Asofiei wrote:
> > Galya, the @errorCode@ text from the @Error in SOAP parameter: error... Constantin Asofiei

06:27 AM Base Language Feature #6417: cleanup some known items in appserver support

Constantin Asofiei wrote:
> Galya, the @errorCode@ text from the @Error in SOAP parameter: errorCode@ message is the... Galya B

06:22 AM Base Language Feature #6417: cleanup some known items in appserver support

Galya, the @errorCode@ text from the @Error in SOAP parameter: errorCode@ message is the first argument from @new App... Constantin Asofiei

06:12 AM Base Language Feature #6417: cleanup some known items in appserver support

I'm puzzled by @webtests_from_logs/results/20211112_201954_soap_classic/test_set_2_exceptions/test_5_throw_error_1.ht... Galya B

08:04 AM Runtime Infrastructure Feature #8863: Add tenantName logic related to sec_authentication_domain in FWD

The purpose of this task is to add the @tenantName@ logic that is related to the @sec_authentication_domain@ table in... Radu Apetrii

07:44 AM Runtime Infrastructure Feature #8863 (Closed): Add tenantName logic related to sec_authentication_domain in FWD

Radu Apetrii

08:01 AM Base Language Bug #8643: ErrorManager not handling caught errors and error-status:error attribute properly

In #8308, it was discovered that errors related to the database are handled differently when a CATCH block is present... Dănuț Filimon

07:12 AM Runtime Infrastructure Bug #7635: RemoteObject defaults to 'tracing' mode

Constantin Asofiei wrote:
> The same fix needs to be done at @Dispatcher.tracing@.
7635b r15275 based on trunk r1... Galya B

06:39 AM Conversion Tools Feature #8849: Automatic dependencies conversion

Basically if @config-deps@ is not set to @true@ in configuration everything works just like before albeit there are s... Marian Edu

06:34 AM Conversion Tools Feature #8849: Automatic dependencies conversion

Attached a patch done against trunk rev#15266.
Marian Edu

06/06/2024

10:07 AM Runtime Infrastructure Feature #7799: automated vulnerability scanning

You're right. It is good. All that remains is to scan nightly on an automated basis and have someone review/resolve... Greg Shah

09:31 AM Runtime Infrastructure Feature #7799: automated vulnerability scanning

Greg Shah wrote:
> This is a good start but we will need to refine the results as noted in #7799-9. We must make it... Tomasz Domin

06/05/2024

03:10 PM Base Language Bug #8799: ON ERROR UNDO, THROW problems leading to infinite loops

For this test:... Constantin Asofiei

09:13 AM Conversion Tools Feature #8849: Automatic dependencies conversion

Great! Yes, please post the patch here. Creating the patch from trunk is best. Greg Shah

09:04 AM Conversion Tools Feature #8849: Automatic dependencies conversion

When trying to convert testcases for specific subject we found it difficult to find all dependencies used in those te... Marian Edu

08:50 AM Conversion Tools Feature #8849 (New): Automatic dependencies conversion

Marian Edu

09:09 AM Base Language Feature #6417: cleanup some known items in appserver support

Marian may just be referencing your comment from #6417-160 where you said "I'm not testing OE.". Greg Shah

08:51 AM Base Language Feature #6417: cleanup some known items in appserver support

Marian Edu wrote:
> I still don't understand how do you plan to fix those tests without testing against a real Progr... Galya B

08:48 AM Base Language Feature #6417: cleanup some known items in appserver support

Greg Shah wrote:
> Marian: Can you please list them here so that Galya knows not to touch those without discussing... Marian Edu

08:45 AM Base Language Feature #6417: cleanup some known items in appserver support

Galya B wrote:
> Marian, the work on the tests seems disjointed. I'm trying to help the team coordinate their versio... Marian Edu

08:42 AM Base Language Feature #6417: cleanup some known items in appserver support

> > Galya: The failures you mention in #6417-162 are from the harness, probably something written by Constantin. The... Greg Shah

08:14 AM Base Language Feature #6417: cleanup some known items in appserver support

Greg Shah wrote:
> Galya: The failures you mention in #6417-162 are from the harness, probably something written by ... Galya B

08:06 AM Base Language Feature #6417: cleanup some known items in appserver support

Galya: The failures you mention in #6417-162 are from the harness, probably something written by Constantin. These w... Greg Shah

08:05 AM Base Language Feature #6417: cleanup some known items in appserver support

Marian, I believe acorn.ro is familiar not only with the @*.log@ files, but also with the SoapUI tests:... Galya B

07:57 AM Base Language Feature #6417: cleanup some known items in appserver support

Marian, let me help you understand what I'm working on here:
Greg Shah wrote:
> These are items that can be found... Galya B

07:53 AM Base Language Feature #6417: cleanup some known items in appserver support

Marian, the work on the tests seems disjointed. I'm trying to help the team coordinate their versions to achieve a st... Galya B

07:30 AM Base Language Feature #6417: cleanup some known items in appserver support

Galya B wrote:
> Well said. The asserts in the SoapUI tests indeed match those from the Progress runs, i.e. are fa... Marian Edu

07:02 AM Base Language Feature #6417: cleanup some known items in appserver support

Marian Edu wrote:
> Galya B wrote:
> > The SoapUI tests in @testcases/appsrv/soap/test/web/fwd-soapui-project.xml@ ... Galya B

06:44 AM Base Language Feature #6417: cleanup some known items in appserver support

Greg Shah wrote:
> > Greg please let me know if we should move those to ABLUnit as well.
>
> Yes
>
> > Not sur... Marian Edu

06:42 AM Base Language Feature #6417: cleanup some known items in appserver support

Galya B wrote:
> The SoapUI tests in @testcases/appsrv/soap/test/web/fwd-soapui-project.xml@ are based on the OE res... Marian Edu

06:28 AM Base Language Feature #6417: cleanup some known items in appserver support

> Greg please let me know if we should move those to ABLUnit as well.
Yes
> Not sure if FWD supports this (RPC,... Greg Shah

06:26 AM Base Language Feature #6417: cleanup some known items in appserver support

> > > I find it very weird that so many tests were failing in OE, but not fixed,
> >
> > Please be more specific ... Greg Shah

05:57 AM Base Language Feature #6417: cleanup some known items in appserver support

The SoapUI tests in @testcases/appsrv/soap/test/web/fwd-soapui-project.xml@ are based on the OE results in @testcases... Galya B

05:18 AM Base Language Feature #6417: cleanup some known items in appserver support

Galya B wrote:
> I'm not testing OE.
Maybe we've got confused by your previous statement then... "I find it very... Marian Edu

12:43 AM Base Language Feature #6417: cleanup some known items in appserver support

Greg Shah wrote:
> > I find it very weird that so many tests were failing in OE, but not fixed,
>
> Please be mo... Galya B

06:51 AM Database Feature #7382 (Closed): Check performance of delete from vs drop table in H2

Greg Shah

04:01 AM Database Feature #7382: Check performance of delete from vs drop table in H2

This can be closed as the changes reached FWD-H2 already. Alexandru Lungu

06/04/2024

06:14 PM Runtime Infrastructure Feature #6692: move FWD to Java 17

Here is the current list:... Roger Borrello

06:11 PM Runtime Infrastructure Feature #6692: move FWD to Java 17

Tomasz Domin wrote:
> Roger Borrello wrote:
> > I have updated the @container@ project so that base images are crea... Roger Borrello

04:54 PM Base Language Feature #6417: cleanup some known items in appserver support

> I find it very weird that so many tests were failing in OE, but not fixed,
Please be more specific about this. ... Greg Shah

04:43 PM Runtime Infrastructure Feature #7799 (WIP): automated vulnerability scanning

This is a good start but we will need to refine the results as noted in #7799-9. We must make it very easy to evalua... Greg Shah

04:40 PM Runtime Infrastructure Feature #7799: automated vulnerability scanning

NIST (National Institute for Standards and Technology) is an agency of the US government. It creates standards, runs... Greg Shah

04:33 PM Runtime Infrastructure Feature #7799: automated vulnerability scanning

You can lookup details of a @CVE-2011-4969@ using https://nvd.nist.gov/vuln/detail/cve-2011-4969 Greg Shah

04:24 PM Runtime Infrastructure Feature #7799: automated vulnerability scanning

If you run @cat <scan_output> | grep -o "CVE-[0-9]*-[0-9]*" | sort | uniq@, you get:... Greg Shah

04:11 PM Runtime Infrastructure Feature #7799: automated vulnerability scanning

I just ran it, here is the output:... Greg Shah

10:15 AM Database Feature #7363 (Closed): Improve H2 Value caching, hashing and equals

Greg Shah

09:46 AM Database Feature #7363: Improve H2 Value caching, hashing and equals

FWD-H2 is not at rev. 48 in trunk. This can be closed. Alexandru Lungu

10:15 AM Database Feature #7062 (Closed): Direct access to H2 internals to solve basic queries

Greg Shah

09:45 AM Database Feature #7062: Direct access to H2 internals to solve basic queries

FWD-H2 is now at rev. 48 in trunk. This can be closed. Alexandru Lungu

09:39 AM Base Language Feature #4347: add runtime support for STOP-AFTER block option

We don't want a timer thread to exist if there is no @STOP-AFTER@ active. Greg Shah

08:51 AM Base Language Feature #4347: add runtime support for STOP-AFTER block option

Committed on 4347a, revision 15208. Eduard Soltan

08:14 AM Base Language Feature #4347: add runtime support for STOP-AFTER block option

Constantin Asofiei wrote:
> * StopAfterTimer
> ** in the constructor, the @if (timer == null)@ is not needed - you ... Eduard Soltan

06/03/2024

01:48 PM Database Feature #7020: always use "expanded" extent fields

> but I think it is time to change it now. Permanent and temp-tables should be expanded by default
For temp-tables... Greg Shah

12:52 PM Database Feature #7020: always use "expanded" extent fields

Code review 7020c/15089-15090 (long overdue, sorry):
This update seems to support both @denormalized@ and a new @e... Eric Faulhaber

10:45 AM Runtime Infrastructure Feature #6692: move FWD to Java 17

Pushed @hotel_gui@ revision 326 updated to support Java 17.
Tomasz Domin

08:33 AM Runtime Infrastructure Feature #6692 (Test): move FWD to Java 17

Greg Shah

08:20 AM Runtime Infrastructure Feature #6692: move FWD to Java 17

Merged into trunk revision 15265. Tomasz Domin

06:26 AM Runtime Infrastructure Feature #6692: move FWD to Java 17

Rebased to current @trunk/15264@
Pushed with overwrite @6692a/15304@
Preparing to merge to trunk. Tomasz Domin

10:09 AM Runtime Infrastructure Feature #7799 (Review): automated vulnerability scanning

The feature has been merged into trunk with #6692
In order to check
@./gradlew dependencyCheckAnalyze@
After ... Tomasz Domin

08:12 AM Base Language Feature #6417: cleanup some known items in appserver support

I find it very weird that so many tests were failing in OE, but not fixed, instead directly ported to testcases and s... Galya B

07:39 AM Database Bug #7258 (Closed): Optimize INDEX-INFORMATION with closed dynamic queries

Greg Shah

02:33 AM Database Bug #7258: Optimize INDEX-INFORMATION with closed dynamic queries

This can be closed. Alexandru Lungu

07:39 AM Database Bug #7174 (Closed): Resolve simple CAN-FIND statements faster

Greg Shah

02:33 AM Database Bug #7174: Resolve simple CAN-FIND statements faster

This can be closed. Alexandru Lungu

07:39 AM Database Bug #7165 (Closed): Close multiplex scope using prepared statement

Greg Shah

02:32 AM Database Bug #7165: Close multiplex scope using prepared statement

This can be closed. Alexandru Lungu

07:38 AM Database Bug #5306 (Closed): AdaptiveQuery sets a found record into the buffer twice in dynamic mode

Greg Shah

02:31 AM Database Bug #5306: AdaptiveQuery sets a found record into the buffer twice in dynamic mode

This can be closed. Alexandru Lungu

07:38 AM Database Feature #7060 (Closed): Consider using wildcard selection to reduce SQL size

Greg Shah

02:31 AM Database Feature #7060: Consider using wildcard selection to reduce SQL size

This can be closed. Alexandru Lungu

07:38 AM Database Support #7058 (Closed): get the FWD fork of the H2 code base under version control

Greg Shah

02:29 AM Database Support #7058 (Test): get the FWD fork of the H2 code base under version control

Alexandru Lungu

02:28 AM Database Support #7058 (Internal Test): get the FWD fork of the H2 code base under version control

The goal of this task was reached. #7061 was fully fixed and part of FWD-H2. This can be closed. Alexandru Lungu

03:13 AM Base Language Feature #4347: add runtime support for STOP-AFTER block option

Review for 4347a rev 15206:
* StandardServer
** only change is a 'bad import', revert this file to rev 15203.
* Bl... Constantin Asofiei

05/31/2024

03:39 PM Runtime Infrastructure Feature #6692 (Merge Pending): move FWD to Java 17

OK, all the applications have reached a minimum level of support for 6692a.
Please merge 6692a to trunk, after 812... Greg Shah

10:52 AM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'

The change is not OK - I get this:... Constantin Asofiei

05:55 AM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'

Rebased 8593d/rev. 15263.
Tested this with a customer unit tests and everything went fine. Although, I think the t... Alexandru Lungu

02:20 AM Database Feature #8834: add bootstrap configuration support for -db OE command line parameter (and related...

Are @-H@, @-S@ and @-P@ used only for the db? If so, it's best to have an array of custom objects with all the config... Galya B

05/30/2024

05:02 PM Database Feature #8834: add bootstrap configuration support for -db OE command line parameter (and related...

The current code provides two ways to make a database connection in FWD:
* Using the session based auto-connect (#... Greg Shah

04:45 PM Database Feature #8834 (Closed): add bootstrap configuration support for -db OE command line parameter (an...

Greg Shah

04:43 PM Database Feature #8833: eliminate legacy load on startup support

This is leftover work that should have been finished in #3930. The objective is to remove the old style load on star... Greg Shah

04:33 PM Database Feature #8833 (New): eliminate legacy load on startup support

Greg Shah

12:30 PM Runtime Infrastructure Feature #6692: move FWD to Java 17

Rebased to current @trunk/15259@
Pushed @6692a/15299@
Tomasz Domin

12:26 PM Runtime Infrastructure Feature #6692: move FWD to Java 17

Roger Borrello wrote:
> I have updated the @container@ project so that base images are created that contain JDK 17. ... Tomasz Domin

11:35 AM Runtime Infrastructure Feature #6692: move FWD to Java 17

Tomasz Domin wrote:
> 6692a rev 15244 - Reverted @mariadb-java-client@ to @FWD@ compatible version: "3.1.2"
>
> ... Greg Shah

11:21 AM Runtime Infrastructure Feature #6692: move FWD to Java 17

6692a rev 15244 - Reverted @mariadb-java-client@ to @FWD@ compatible version: "3.1.2"
Greg - please let me know w... Tomasz Domin

12:03 PM User Interface Bug #8586 (Internal Test): Fields are not in FIELD-GROUP until they are enabled

8586a revision 15256,
Nice simplification of @nextTabItem@!
The changes also affect other use cases like @ENABL... Hynek Cihlar

08:02 AM User Interface Bug #8586: Fields are not in FIELD-GROUP until they are enabled

Hynek: Please review. Greg Shah

08:46 AM Base Language Bug #8799: ON ERROR UNDO, THROW problems leading to infinite loops

Marian Edu wrote:
> Marian Edu wrote:
> > Some of them are just caused by the conversion when unknown (?) is passed... Greg Shah

08:45 AM Base Language Bug #8799: ON ERROR UNDO, THROW problems leading to infinite loops

Artur: Please make all of these testcases work properly, including the conversion fixes. Constantin, Marian and I wi... Greg Shah

04:35 AM Base Language Bug #8799: ON ERROR UNDO, THROW problems leading to infinite loops

Marian Edu wrote:
> Some of them are just caused by the conversion when unknown (?) is passed directly as parameter ... Marian Edu

04:22 AM Base Language Bug #8799: ON ERROR UNDO, THROW problems leading to infinite loops

Marian Edu wrote:
> @undoReturnErrorTopLevel@ doesn't have an override using @ProError@.
This is for the @return ... Marian Edu

03:47 AM Base Language Bug #8799: ON ERROR UNDO, THROW problems leading to infinite loops

Greg Shah wrote:
> > I do not think we have tests for default error handling for all blocks but we can maybe add tho... Marian Edu

08:19 AM Base Language Feature #4347: add runtime support for STOP-AFTER block option

Constantin Asofiei wrote:
> * I think if we need to have a way to disable @STOP-AFTER@, via a directory configuratio... Eduard Soltan

05/29/2024

04:58 PM Runtime Infrastructure Feature #6692: move FWD to Java 17

I have updated the @container@ project so that base images are created that contain JDK 17. After a complete build of... Roger Borrello

05:27 AM Runtime Infrastructure Feature #6692: move FWD to Java 17

6692a rev 15244 - Removed unneeded @janusgraph@ dependency: @metrics-graphite@ and transitive @amqp-client@ Tomasz Domin

04:11 PM User Interface Bug #8586 (Review): Fields are not in FIELD-GROUP until they are enabled

I fixed the @private FieldGroup.nextTabItem()@ in similar way.
Now the complete tab ring can be traversed from 4gl f... Vladimir Tsichevski

10:44 AM User Interface Bug #8586 (WIP): Fields are not in FIELD-GROUP until they are enabled

The problem seems to be in @FieldGroup.getExtremeTabItem()@ method, where only *realized* items are selected:... Vladimir Tsichevski

02:18 PM Base Language Bug #8799: ON ERROR UNDO, THROW problems leading to infinite loops

> I do not think we have tests for default error handling for all blocks but we can maybe add those to somewhere if n... Greg Shah

04:16 AM Base Language Bug #8799: ON ERROR UNDO, THROW problems leading to infinite loops

Greg Shah wrote:
> Marian: Where are we with testcases for @ON ERROR UNDO, THROW@?
We have tests for error handling... Marian Edu