General

Profile

Greg Shah's activity

From 10/24/2025 to 11/22/2025

11/21/2025

06:20 PM Base Language Feature #8138: ABLUnit configuration using environment variables
My suggestion was in #8138-7. Greg Shah
03:39 PM Conversion Tools Bug #10919: the source/AST view is broken in the Analytics web UI
The @.cache@ and @.p.ast@ files do exist, but they are in @./cvt/@ instead of @./abl/@ which is probably the issue. Greg Shah
03:38 PM Conversion Tools Bug #10919: the source/AST view is broken in the Analytics web UI
I suspect this is a bug from our recent #5586 changes.
Running reports in Hotel GUI completes properly. You can l...
Greg Shah
03:30 PM Conversion Tools Bug #10919 (Test): the source/AST view is broken in the Analytics web UI
Greg Shah
03:12 PM User Interface Bug #10830: Search filter field on Guests screen of Hotel GUI does not work.
I can recreate the bug. Greg Shah
02:58 PM User Interface Bug #10918: Swing client PDF loading does not work
!hotel_gui_swing_guests_tab.png!
When you click on the Export button, you get this failure:
!hotel_gui_swing_ex...
Greg Shah
02:52 PM User Interface Bug #10918 (New): Swing client PDF loading does not work
Greg Shah
02:26 PM User Interface Bug #10915: ugly dialogs
I agree the dialog probably should not be there. But if it does show, it should be much smaller. Greg Shah
02:01 PM User Interface Bug #10915: ugly dialogs
I've asked for our dialogs to be sized without a lot of unnecessary space.
Somehow, we still have dialogs loading ...
Greg Shah
01:58 PM User Interface Bug #10915 (Test): ugly dialogs
Greg Shah
02:25 PM User Interface Bug #10914: clicking browse hyperlinked cells does not load its content into a browser tab
No, I already have that setting turned on.
Please note that when I use the Guests tab and use the "Export" button,...
Greg Shah
01:55 PM User Interface Bug #10914: clicking browse hyperlinked cells does not load its content into a browser tab
Hotel GUI is designed to showcase a range of techniques to display generated output like PDFs. The intention was alw... Greg Shah
01:29 PM User Interface Bug #10914 (Review): clicking browse hyperlinked cells does not load its content into a browser tab
Greg Shah
02:10 PM User Interface Bug #10917: Hotel GUI embedded mode selected tab indicator
In Hotel GUI embedded mode, you can select any of the tabs (top right). The selection works (it changes what is in t... Greg Shah
02:08 PM User Interface Bug #10917 (Closed): Hotel GUI embedded mode selected tab indicator
Greg Shah
02:07 PM User Interface Bug #10916: ESC key in Hotel GUI exits the client
This occurs in both embedded mode and in virtual desktop mode. If you enter the ESC key while the legacy 4GL window ... Greg Shah
02:02 PM User Interface Bug #10916 (Closed): ESC key in Hotel GUI exits the client
Greg Shah
01:26 PM User Interface Bug #10913: multiple tabs draw labels highlighted at the same time
In Hotel GUI, both virtual desktop mode and Swing, you can cause multiple tab labels to simultaneously draw in a high... Greg Shah
01:20 PM User Interface Bug #10913 (Test): multiple tabs draw labels highlighted at the same time
Greg Shah
10:02 AM Conversion Tools Bug #6889: rollback the files as 'unconverted' if (incremental) conversion fails.
Code Review Task Branch 6889a Revisions 16267 and 16268
1. Shouldn't @cleanSources()@ be called at the end of @pro...
Greg Shah
08:09 AM Database Feature #4369: implement stateless FWD server clustering
The tables we could expect to be used frequently are not the same tables that are editable. @_file@, @_field@, @_ind... Greg Shah
08:03 AM Conversion Tools Feature #10804: create replacement AST implementation for use with ANTLR 4
Paula Păstrăguș wrote:
> My suggestion is to wait until the end of the day, so I can finish covering most of the met...
Greg Shah
07:56 AM Conversion Tools Feature #10804: create replacement AST implementation for use with ANTLR 4
Paula Păstrăguș wrote:
> I think creating a table will help clarify things for both of us. At this point, I’ve gone ...
Greg Shah
07:48 AM Conversion Tools Bug #4867 (Merge Pending): Incremental conversion: change detection algorithm ignores .hints and ...
Merge after 10695a. Greg Shah
07:45 AM Base Language Feature #3853: implement LOG-MANAGER runtime
> But it may be needed to make conversion changes or a new AspectJ rules.
Conversion changes, if really needed, ar...
Greg Shah
07:42 AM Deployment Support #10727: implement a docker image that supports the full range of development processes wi...
> Is it possible to just narrow down the documentation to what is different about running in the environment?
No. ...
Greg Shah

11/20/2025

04:44 PM User Interface Bug #10910: tree control arrow keys don't work
This is a regression that can be seen in Hotel GUI. It can be recreated in Virtual Desktop Mode, Embedded Mode and i... Greg Shah
04:42 PM User Interface Bug #10910 (New): tree control arrow keys don't work
Greg Shah
01:55 PM Database Feature #4369: implement stateless FWD server clustering
> In the end, it all comes down to the number of queries executed for the metadata tables for the current and future ... Greg Shah
11:27 AM User Interface Bug #10751 (Test): Beep Sound Playback Causing Client Abend
Greg Shah
08:14 AM Deployment Support #10727: implement a docker image that supports the full range of development processes wi...
> We have to draw the line somewhere with this task intended to make sure we have a Docker image that can support all... Greg Shah

11/19/2025

05:05 PM Deployment Support #10727: implement a docker image that supports the full range of development processes wi...
> When you start VisualVM, it is going to show you all the local JVMs. You have to add the JVM you want to attach to ... Greg Shah
05:01 PM Deployment Support #10727: implement a docker image that supports the full range of development processes wi...
You are not just building the image, you are building processes and needed cfg/scripting to implement all of these pr... Greg Shah
04:19 PM Deployment Support #10727: implement a docker image that supports the full range of development processes wi...
> Some of the requests are really beyond the scope of this task. For example, if you want to attach VisualVM to the W... Greg Shah
03:56 PM Deployment Support #10727: implement a docker image that supports the full range of development processes wi...
> Central to the process is @dbash.sh@, which is part of the *container* project. How should the documentation approa... Greg Shah
04:56 PM Conversion Tools Feature #10804: create replacement AST implementation for use with ANTLR 4
> I’m not sure how this translates to the Progress grammar for example, since the grafting logic there depends much ... Greg Shah
02:07 PM Database Feature #4369: implement stateless FWD server clustering
> Over the solution presented by you, this has the advantage that the tables don't need to be recreated before each q... Greg Shah
11:02 AM Database Feature #4369: implement stateless FWD server clustering
> Greg, just to be clear, do you suggest to give up on the H2 metadata tables all together?
No. There is value i...
Greg Shah
11:08 AM Deployment Support #10905: Questions for an end user when something unexpected happens
#10451 is more low level that we are thinking here.
The customer at issue is worried more about asking the end use...
Greg Shah
10:51 AM Base Language Feature #3853: implement LOG-MANAGER runtime
> Is there a standard way of resolving (as a reverse lookup) of current procedure name, line and method ?
> I've fou...
Greg Shah

11/18/2025

05:36 PM Database Feature #4369: implement stateless FWD server clustering
I repeat my points of #4369-46 and #4369-54. The existing approach to metadata is overcomplicated and causes unneces... Greg Shah
04:08 PM Deployment Support #10727: implement a docker image that supports the full range of development processes wi...
Documentation should be written in [[p2j:Development Using a Docker Container]] Greg Shah
11:11 AM Deployment Support #10727: implement a docker image that supports the full range of development processes wi...
> Give the addition of a carefully constructed @archive.runtime@ target to the @build.xml@, it would be fairly straig... Greg Shah
06:22 AM Conversion Tools Bug #4867: Incremental conversion: change detection algorithm ignores .hints and .ext-hints files
Please test at least one of the large customer GUI applications. As Vladimir notes, the @.ext-hints@ are used there ... Greg Shah

11/17/2025

04:03 PM User Interface Bug #10751: Beep Sound Playback Causing Client Abend
We would have to @catch (AssertionError ae)@ in that case. Greg Shah
03:51 PM User Interface Bug #10751: Beep Sound Playback Causing Client Abend
Hynek Cihlar wrote:
> Greg, I know we've had a debate about the use of assertions in our code base. Was the conclusi...
Greg Shah
08:52 AM Conversion Tools Bug #4867 (Internal Test): Incremental conversion: change detection algorithm ignores .hints and ...
Code Review Task branch 4867a Revision 16236
The changes are good.
In @mustConvertFile()@, before line 818 (@if...
Greg Shah
07:12 AM Base Language Feature #6506: implement CGI WebSpeed support and the standard web-disp.p dispatch functionality
If an @.htm@ or @.html@ file is changed, then we must run the embedded 4GL preprocessor on that file. Running the E4... Greg Shah

11/14/2025

03:11 PM Runtime Infrastructure Feature #9687: drop support for Java 8 and Java 11
> And the fact Java 8/11 will not be supported anymore in trunk.
We'll do a final check on customers early next we...
Greg Shah
09:07 AM Runtime Infrastructure Feature #9687: drop support for Java 8 and Java 11
Are we just needing the spreadsheet to be tested before we can merge?
Tomasz: Is there any documentation needed fo...
Greg Shah

11/13/2025

06:53 AM Runtime Infrastructure Bug #10858: Replace capturing with non-capturing lambdas in getters and setters
This is an easy win. It is functionally the same and faster. There is good discussion of capturing/non-capturing la... Greg Shah

11/12/2025

04:23 PM Runtime Infrastructure Feature #9687: drop support for Java 8 and Java 11
> > * Multi session app server (@MultiSessionAppserver@)
> Isnt this setup by the customer requesting this change.
...
Greg Shah
11:05 AM User Interface Feature #10848: custom theme improvements
> I realize the proposed DOM mode might be too ambitious for the current project scope or schedule, but I believe it’... Greg Shah
09:11 AM User Interface Feature #10848: custom theme improvements
Alex, these are interesting ideas.
The theme classes today include the full implementation of drawing operations...
Greg Shah
09:02 AM User Interface Feature #10848: custom theme improvements
> DOM mode and DOM driver. Currently we have ChUI and GUI modes, we could as well introduce another one - a DOM mode.... Greg Shah
10:56 AM Database Feature #4369: implement stateless FWD server clustering
> if there are 1k requests at a time and 10 servers, it is completely valid to balance 100 across these 10 servers?
...
Greg Shah
10:54 AM Database Feature #4369: implement stateless FWD server clustering
I don't think we need the @RemoteLockManager@ if we have proper clustering. Greg Shah

11/11/2025

04:03 PM Documentation Support #10849: improve documentation on implementation of custom themes
The existing documentation is in [[p2j:Themes]]. We need to fill in gaps and extend it to be comprehensive. Greg Shah
04:03 PM Documentation Support #10849 (New): improve documentation on implementation of custom themes
Greg Shah
03:59 PM User Interface Feature #10848: custom theme improvements
In embedded mode, the CSS for the web portions has no connection to the theming in the legacy screens. I can see a s... Greg Shah
03:59 PM User Interface Feature #10848 (New): custom theme improvements
Greg Shah

11/10/2025

03:32 PM Runtime Infrastructure Feature #9687: drop support for Java 8 and Java 11
Good, thanks. Greg Shah
03:30 PM Runtime Infrastructure Feature #9687: drop support for Java 8 and Java 11
Constantin/Hynek: What other testing do we need? Greg Shah
09:37 AM User Interface Feature #5784: multi-factor authentication
A clean way to enable MFA/2FA as well as to allow 3rd party authentication providers would be to implement "OpenID":h... Greg Shah
08:33 AM Database Feature #4369 (Review): implement stateless FWD server clustering
Eric/Alex: Please do this first review. Greg Shah
08:04 PM TRPL Feature #3211: implement multi-threaded pattern engine and rework the ConversionDriver to leverag...
Octavian Adrian Gavril wrote:
> I tested the callgraph with *1752a*. There were some issues related to reports gener...
Greg Shah

11/07/2025

12:37 AM Base Language Feature #3853: implement LOG-MANAGER runtime
> In order to pass one of tests I had to make FILE-INFO:FILE-SIZE to reread file size.
> Was it static on purpose (...
Greg Shah
12:27 AM Conversion Tools Feature #10190 (Internal Test): Prototype the changes to the build to add ANTLR v4
Code Review Task Branch 10190a Revision 16003
The changes look good.
Greg Shah
12:16 AM Deployment Support #10727: implement a docker image that supports the full range of development processes wi...
Roger Borrello wrote:
> Constantin Asofiei wrote:
> > Regarding @-n -q@ for unzip: how do you know which files to o...
Greg Shah
12:14 AM Deployment Support #10727: implement a docker image that supports the full range of development processes wi...
> So if I read this correctly, what we have in the deploy (minus what is already in the project) would be this set? T... Greg Shah

11/06/2025

08:48 AM Deployment Support #10727: implement a docker image that supports the full range of development processes wi...
> > # Uses the individual source archives etc... to initialize a fresh project that can be used to convert or whateve... Greg Shah
03:43 AM Deployment Support #10727: implement a docker image that supports the full range of development processes wi...
I agree with Constantin that the cfg project must be the single source of truth. From inside the container, we shoul... Greg Shah
07:54 AM Base Language Bug #9906 (Closed): Incorrect date parsing in FWD DATE(CHARACTER) implementation
Greg Shah
04:06 AM Base Language Bug #9906 (Merge Pending): Incorrect date parsing in FWD DATE(CHARACTER) implementation
Greg Shah
04:06 AM Base Language Bug #9906: Incorrect date parsing in FWD DATE(CHARACTER) implementation
Vladimir: Please post the commit message here and we can close the task. Greg Shah
02:53 AM Base Language Bug #9906: Incorrect date parsing in FWD DATE(CHARACTER) implementation
There is no active 9906b branch to review. Greg Shah
03:29 AM Conversion Tools Feature #10190: Prototype the changes to the build to add ANTLR v4
> There seems to be a small typo, when the grammar is not up to date, the log message displays two consecutive 'not' ... Greg Shah
02:48 AM Conversion Tools Feature #10804: create replacement AST implementation for use with ANTLR 4
> In ANTLR 4 there’s no @CommonAST@. The parser only produces a @ParseTree@, so if we want an AST-like structure, we’... Greg Shah
02:34 AM Database Support #10664: Develop a multi session test suite in harness
Artur Școlnic wrote:
> The tests that are not running properly have this pattern:
> [...]
>
> The test relies on...
Greg Shah

11/03/2025

12:26 PM Database Support #10664: Develop a multi session test suite in harness
Are the tests checked in? Eric/Alex should do a code review on the tests. Greg Shah
07:30 PM Conversion Tools Feature #10804: create replacement AST implementation for use with ANTLR 4
We must replace our @AnnotatedAst@ class with a new implementation that does not derive from @antlr.CommonAST@. In A... Greg Shah
07:13 PM Conversion Tools Feature #10804 (Review): create replacement AST implementation for use with ANTLR 4
Greg Shah
07:21 PM Conversion Tools Feature #1757: update ANTLR to latest version
We will continue to discuss and consider this issue of how we handle the IDE (from the parse tree or the AST...) but ... Greg Shah
07:10 PM Conversion Tools Feature #1757: update ANTLR to latest version
> If we compare the two images, we can see that the tree generated by ANTLR v4 is deeper (depth 4) and more detailed ... Greg Shah
07:00 PM Conversion Tools Feature #1757: update ANTLR to latest version
Alexandru Lungu wrote:
> > the adapter will simply take the ANTLR 4 parse tree and convert it into the annotated AST...
Greg Shah

11/02/2025

06:45 PM Conversion Tools Feature #1757: update ANTLR to latest version
Let me provide some additional context about our work here.
1. Our requirements will likely be set by the 4GL pr...
Greg Shah
05:10 PM Conversion Tools Feature #1757: update ANTLR to latest version
> I had an in-depth discussion with Alex,
I appreciate this, but please note that I am leading this effort directl...
Greg Shah

10/31/2025

07:30 AM Database Support #10664: Develop a multi session test suite in harness
Sorry, I still need to catch up here. Are you saying that in OE, the ABLUnit test code in #10664-86 fails to compile... Greg Shah
08:37 PM Database Support #10664: Develop a multi session test suite in harness
> there were some hard limits with abl unit and nested explicit transactions
Please provide more details. What ar...
Greg Shah
08:42 PM Runtime Infrastructure Bug #10733: evaluate and document mandatory configuration required when deploying FWD in production
I don't have an issue with changing @fwd_create_pg_cluster.sh@. I'm saying we need other changes too, to deal with th... Greg Shah

10/30/2025

04:25 AM Conversion Tools Bug #10784: FWD Analytics - Visualize Call Graph can't be used due to broken file paths
Octavian Adrian Gavril wrote:
> I found as a quick fix that
Clever. Let's consider this a temporary workaround.
Greg Shah
04:24 AM Runtime Infrastructure Bug #10733: evaluate and document mandatory configuration required when deploying FWD in production
Roger Borrello wrote:
> Greg Shah wrote:
> > As Constantin noted, we also need to be able to configure this as part...
Greg Shah
08:02 PM Runtime Infrastructure Bug #10733: evaluate and document mandatory configuration required when deploying FWD in production
As Constantin noted, we also need to be able to configure this as part of the project json file, since it affects cfg... Greg Shah

10/29/2025

11:04 AM Conversion Tools Bug #6629: incremental conversion for OpenClient proxy programs
> Greg, should soap/rest/web/proxy files be checked right at the start of the conversion or should we wait until the ... Greg Shah

10/28/2025

12:40 PM Conversion Tools Bug #6629: incremental conversion for OpenClient proxy programs
Dănuț Filimon wrote:
> Constantin Asofiei wrote:
> > Otherwise, a question: if there are changes in the SOAP, REST,...
Greg Shah
09:57 AM Base Language Bug #10391: Comparisons methods not returning the correct result in poly cases
+Eugenie
Paul: Please update [[regression:Open Regressions in FWD v4]] to add a entry for this issue.
Greg Shah

10/27/2025

11:06 AM TRPL Feature #3211: implement multi-threaded pattern engine and rework the ConversionDriver to leverag...
If the problem is not caused by 1752a then it can be split off. Greg Shah
10:20 AM TRPL Feature #3211: implement multi-threaded pattern engine and rework the ConversionDriver to leverag...
> Indeed, those are not marked hidden during the callgraph but the simple running of ant callgraph use the ASTs from ... Greg Shah
09:40 AM TRPL Feature #3211: implement multi-threaded pattern engine and rework the ConversionDriver to leverag...
Octavian Adrian Gavril wrote:
> I think the root cause with the callgraph generation is that the @PROCEDURE@ ASTs ar...
Greg Shah

10/24/2025

09:24 AM TRPL Feature #3211: implement multi-threaded pattern engine and rework the ConversionDriver to leverag...
I have no objection. It can be put the change into the current changes.
Constantin?
Greg Shah
08:06 AM Base Language Bug #4766: fix CHR and ASC
That is a fair point, Ovidiu. I've been thinking about a similar solution. As you note, we would not want to change... Greg Shah
 

Also available in: Atom