Project

General

Profile

Activity

From 03/09/2024 to 04/07/2024

04/08/2024

08:34 PM Database Bug #8554 (Test): resolving temp-tables in a class hierarchy
Greg Shah

04/06/2024

01:41 PM Database Bug #8554: resolving temp-tables in a class hierarchy
Branch 8554a was merged into trunk as rev. 15125 and archived. Constantin Asofiei
12:40 PM Database Bug #8554: resolving temp-tables in a class hierarchy
You can merge to trunk now.
Hynek: 8152a can merge after 8554a.
Greg Shah
03:15 AM Database Bug #8554 (Merge Pending): resolving temp-tables in a class hierarchy
Ovidiu, I've fixed the visibility in rev 15127 (after rebase).
ETF testing passed. It can be merged to trunk.
Constantin Asofiei

04/05/2024

06:11 PM Database Bug #8589: Deprecate the shared temporary database completely
Unless there is a _significant_ memory savings or some other substantial advantage of shared mode, I think we should ... Eric Faulhaber
03:45 AM Database Bug #8589: Deprecate the shared temporary database completely
In the original support for _temp database, one single in-memory database was created. All sessions used that single ... Alexandru Lungu
03:05 AM Database Bug #8589 (New): Deprecate the shared temporary database completely
Alexandru Lungu

04/04/2024

06:39 PM Database Bug #8554: resolving temp-tables in a class hierarchy
Review of 8554a, r15120-15122.
I am OK with the code. I'm sorry I made a mess with condition codes which do and do...
Ovidiu Maxiniuc
04:21 PM Database Bug #8554: resolving temp-tables in a class hierarchy
Ovidiu, please review this, I'll get ETF testing tomorrow and if is OK, I'd like to merge this tomorrow. Constantin Asofiei
07:41 AM Database Bug #8554 (Review): resolving temp-tables in a class hierarchy
15122 fixes some issues, javadocs and some errors which must not set ERROR-STATUS:ERROR. This can be reviewed.
I'...
Constantin Asofiei
05:31 AM Database Bug #8554 (WIP): resolving temp-tables in a class hierarchy
Created task branch 8554a from trunk rev 15119.
15120 and 15121 has a rough fix for this - need to validate it.
Constantin Asofiei
05:26 PM Base Language Bug #8579 (Test): Unit and OEUnit conversion: ignore annotations from other framework
Greg Shah
05:21 PM Base Language Bug #8579: Unit and OEUnit conversion: ignore annotations from other framework
Greg Shah wrote:
> You can merge 8579a to trunk now.
Done. Rev. 15123.
Vladimir Tsichevski
04:23 PM Base Language Bug #8579 (Merge Pending): Unit and OEUnit conversion: ignore annotations from other framework
You can merge 8579a to trunk now. Greg Shah
01:14 PM Base Language Bug #8579: Unit and OEUnit conversion: ignore annotations from other framework
Greg Shah wrote:
> Code Review Task Branch 8579a Revision 15121
>
> The change is good.
>
> What additional te...
Vladimir Tsichevski
12:58 PM Base Language Bug #8579: Unit and OEUnit conversion: ignore annotations from other framework
Code Review Task Branch 8579a Revision 15121
The change is good.
What additional testing is needed?
Greg Shah
11:20 AM Base Language Bug #8579: Unit and OEUnit conversion: ignore annotations from other framework
Greg Shah wrote:
> Code Review Task Branch 8579a Revision 15120
>
> I think the code would be simpler and easier ...
Vladimir Tsichevski
12:12 PM Base Language Feature #6407: name_map.xml improvements
I did replace the @Set@ with @List@ in r15108.
Tomorrow I'm testing again in testcases. A good list of different p...
Galya B
11:45 AM Base Language Feature #6407: name_map.xml improvements
@MultiClassLoader@:... Galya B
11:43 AM Base Language Feature #6407: name_map.xml improvements
So what I'm saying is that there is no classpath order in my humble opinion. Iterating HashMap is not ordered. Galya B
11:39 AM Base Language Feature #6407: name_map.xml improvements
Greg Shah wrote:
> > > @MultiClassLoader@ finds the class by iterating @HashSet@.
> > Actually it's a collection, ...
Galya B
11:32 AM Base Language Feature #6407: name_map.xml improvements
> > @MultiClassLoader@ finds the class by iterating @HashSet@.
> Actually it's a collection, backed by the @HashMap...
Greg Shah
11:20 AM Base Language Feature #6407 (Review): name_map.xml improvements
6407a r15107 based on trunk r15101 ready for review: adds support for reading mappings from multiple name_map.xml fil... Galya B
09:57 AM Base Language Feature #6407: name_map.xml improvements
Galya B wrote:
> @MultiClassLoader@ finds the class by iterating @HashSet@.
Actually it's a collection, backed by ...
Galya B
09:42 AM Base Language Feature #6407: name_map.xml improvements
We can rework it to iterate jars alphabetically. Galya B
09:39 AM Base Language Feature #6407: name_map.xml improvements
Constantin Asofiei wrote:
> My understanding is that JVM keeps the same order of jars as defined in classpath (it do...
Galya B
09:37 AM Base Language Feature #6407: name_map.xml improvements
Galya B wrote:
> Greg Shah wrote:
> > Do we really need an explicit list of precedence order? Why not implicitly t...
Constantin Asofiei
09:29 AM Base Language Feature #6407: name_map.xml improvements
Greg Shah wrote:
> Do we really need an explicit list of precedence order? Why not implicitly take it from the clas...
Galya B
09:28 AM Base Language Feature #6407: name_map.xml improvements
Do we really need an explicit list of precedence order? Why not implicitly take it from the classpath and honor the ... Greg Shah
09:21 AM Base Language Feature #6407: name_map.xml improvements
Constantin Asofiei wrote:
> From what you posted in #6407-56, only one concern: the granularity for the precedence o...
Galya B
05:45 AM Base Language Feature #6407: name_map.xml improvements
From what you posted in #6407-56, only one concern: the granularity for the precedence order I think needs to be "thi... Constantin Asofiei
04:39 AM Base Language Feature #6407: name_map.xml improvements
P.S. The previous comment got updated. Galya B
04:36 AM Base Language Feature #6407: name_map.xml improvements
Constantin Asofiei wrote:
> And I think I understand now Greg's point about the .r and folder deploy in OpenEdge:
>...
Galya B
09:09 AM User Interface Bug #8586: Fields are not in FIELD-GROUP until they are enabled
The program:... Vladimir Tsichevski
09:02 AM User Interface Bug #8586 (Test): Fields are not in FIELD-GROUP until they are enabled
Vladimir Tsichevski

04/03/2024

06:05 PM Base Language Bug #8579 (Internal Test): Unit and OEUnit conversion: ignore annotations from other framework
Code Review Task Branch 8579a Revision 15120
I think the code would be simpler and easier to read if you create a ...
Greg Shah
03:11 PM Base Language Bug #8579 (Review): Unit and OEUnit conversion: ignore annotations from other framework
Fixed in 8579a rev. 15120. Please, review. Vladimir Tsichevski
03:10 PM Base Language Bug #8579 (WIP): Unit and OEUnit conversion: ignore annotations from other framework
Vladimir Tsichevski
02:51 PM Base Language Bug #8579: Unit and OEUnit conversion: ignore annotations from other framework
Currently, if a test 4gl source includes both ABLUnit annotations and OEUnit annotations, all these annotations are c... Vladimir Tsichevski
02:46 PM Base Language Bug #8579 (Test): Unit and OEUnit conversion: ignore annotations from other framework
Vladimir Tsichevski
04:52 PM User Interface Bug #8353: Fully support stanza INI LOAD/USE/UNLOAD scenarios
The failure was because I didn't include @support/test/AssertExt.cls@ in the conversion file. Now I get:... Roger Borrello
03:08 PM Base Language Feature #6407: name_map.xml improvements
And I think I understand now Greg's point about the .r and folder deploy in OpenEdge:
* in FWD, you would convert th...
Constantin Asofiei
02:34 PM Base Language Feature #6407: name_map.xml improvements
Greg Shah wrote:
> > But, in practice, I think .pl archives are used more - and depending on the PROPATH, runtime co...
Constantin Asofiei
02:29 PM Base Language Feature #6407: name_map.xml improvements
> But, in practice, I think .pl archives are used more - and depending on the PROPATH, runtime could use a .p from di... Greg Shah
02:26 PM Base Language Feature #6407: name_map.xml improvements
We had cases of the same OE qualified class name used in different modules. The qualified legacy name can't be chang... Constantin Asofiei
01:28 PM Base Language Feature #6407: name_map.xml improvements
To solve case 2. we need the precedence order to be fed to the jmv via startup args, so that the classloader can take... Galya B
01:09 PM Base Language Feature #6407: name_map.xml improvements
Galya B wrote:
> I speak about case 3: different maps for different files with different attributes. Obviously if yo...
Galya B
01:08 PM Base Language Feature #6407: name_map.xml improvements
I speak about case 3: different maps for different files with different attributes, but same path. Obviously if you l... Galya B
01:02 PM Base Language Feature #6407: name_map.xml improvements
> This is not something we can decide even with configs and Constantin was right that it is a major issue.
Case 1 ...
Greg Shah
12:58 PM Base Language Feature #6407: name_map.xml improvements
One pname corresponds to only one jname, because that's how conversion seems to work. The question is if the other at... Galya B
11:36 AM Base Language Feature #6407: name_map.xml improvements
Galya B wrote:
> Other than that the jar can have a completely different package for the actual classes.
Actually n...
Galya B
11:34 AM Base Language Feature #6407: name_map.xml improvements
If we need to load the jars in a specific order, we'll need explicit instructions, probably new config in directory. Galya B
11:32 AM Base Language Feature #6407: name_map.xml improvements
Case 2 is the same as java and can cause malfunctioning programs like in java, this is what I meant.
Case 1 is fine ...
Galya B
11:20 AM Base Language Feature #6407: name_map.xml improvements
> In java this is the same as having multiple versions of the same dependency in the classpath.
Not exactly. In...
Greg Shah
11:14 AM Base Language Feature #6407: name_map.xml improvements
> If you are saying that module M1 has a program foo/bar/F.p and module M2 has a program foo/bar/F.p. which are compl... Greg Shah
11:12 AM Base Language Feature #6407: name_map.xml improvements
This is actually more complicated than it looked at first. We're trying to combine different apps coming possibly fro... Galya B
11:03 AM Base Language Feature #6407: name_map.xml improvements
Greg Shah wrote:
> Let's consider this from the perspective of how it works for this multi-app case in OE. If both ...
Constantin Asofiei
10:55 AM Base Language Feature #6407: name_map.xml improvements
Originally (currently) if multiple paths are found for the same filename when resolving the name map, the paths end u... Galya B
10:45 AM Base Language Feature #6407: name_map.xml improvements
> The 'pname' in @class-mapping@ is the full path relative to the @abl/@ folder
Yes, this is why I called them rel...
Greg Shah
10:30 AM Base Language Feature #6407: name_map.xml improvements
Greg Shah wrote:
> > > And all of this just for a warning log? I would say it's more reasonable to log the warning a...
Constantin Asofiei
10:26 AM Base Language Feature #6407: name_map.xml improvements
I don't have an actual example though. Not sure if the path is supposed to be the same in two different jars. Galya B
10:25 AM Base Language Feature #6407: name_map.xml improvements
Greg Shah wrote:
> > > And all of this just for a warning log? I would say it's more reasonable to log the warning a...
Galya B
10:23 AM Base Language Feature #6407: name_map.xml improvements
> > And all of this just for a warning log? I would say it's more reasonable to log the warning always when a second ... Greg Shah
06:16 AM Base Language Feature #6407: name_map.xml improvements
> REST services written directly in Java can be configured via the 'rest-service' element.
So these nodes are not ...
Constantin Asofiei
06:06 AM Base Language Feature #6407: name_map.xml improvements
OK, then I need one more clarification. Since there is a separate container @rest-service@, where programs get resolv... Galya B
06:00 AM Base Language Feature #6407: name_map.xml improvements
Yes. Constantin Asofiei
05:57 AM Base Language Feature #6407: name_map.xml improvements
Constantin Asofiei wrote:
> Galya B wrote:
> > And all of this just for a warning log? I would say it's more reason...
Galya B
05:57 AM Base Language Feature #6407: name_map.xml improvements
Galya B wrote:
> And all of this just for a warning log? I would say it's more reasonable to log the warning always ...
Constantin Asofiei
05:53 AM Base Language Feature #6407: name_map.xml improvements
Constantin Asofiei wrote:
> Galya B wrote:
> > Constantin, maybe you've missed why I'm assigned to the task, that i...
Galya B
05:49 AM Base Language Feature #6407: name_map.xml improvements
Galya B wrote:
> Constantin, maybe you've missed why I'm assigned to the task, that is in #6407-4.
OK, thanks for t...
Constantin Asofiei
05:49 AM Base Language Feature #6407: name_map.xml improvements
Constantin Asofiei wrote:
> The point was to move to annotations/other structures inside the .java
Constantin, ...
Galya B
05:43 AM Base Language Feature #6407: name_map.xml improvements
The point was to move to annotations/other structures inside the .java, here I mean all info from name_map.xml; ideal... Constantin Asofiei
05:33 AM Base Language Feature #6407: name_map.xml improvements
Constantin Asofiei wrote:
> I don't mean the annotations in the .class - I mean the state from name_map.xml must mat...
Galya B
05:22 AM Base Language Feature #6407: name_map.xml improvements
I don't mean the annotations in the .class - I mean the state from name_map.xml must match if there is an existing en... Constantin Asofiei
03:55 AM Base Language Feature #6407: name_map.xml improvements
Constantin Asofiei wrote:
> * load them into @SourceNameMapper@, one by one, and address conflicts - if there are co...
Galya B
05:26 AM Base Language Bug #8510: replace all 'new logical' in FWD runtime with logical.of or logical.UNKNOWN
8150a was merged to trunk rev 15116 and archived. Constantin Asofiei
05:26 AM Base Language Bug #8510: replace all 'new logical' in FWD runtime with logical.of or logical.UNKNOWN
Created task branch 8510a from trunk rev 15115. In rev 15116 I removed the @logical.of@ and @logical.UNKNOWN@ from R... Constantin Asofiei

04/02/2024

05:15 PM User Interface Bug #8260: treelist sorting column with null and empty string values does not produce correct result
Șerban Bursuc wrote:
> As for issue 2, I don't understand whether OE just refuses to sort the column, or it doesn'...
Vladimir Tsichevski
10:30 AM User Interface Bug #8260: treelist sorting column with null and empty string values does not produce correct result
Sorry for the random assignment, it was **not** intentional. Șerban Bursuc
10:27 AM User Interface Bug #8260: treelist sorting column with null and empty string values does not produce correct result
Vladimir Tsichevski wrote:
> As I see this:
>
> # If a string tree column has non-empty values, empty string valu...
Șerban Bursuc
10:11 AM User Interface Bug #8260: treelist sorting column with null and empty string values does not produce correct result
As I see this:
# If a string tree column has non-empty values, empty string values and unknown values, when expect...
Vladimir Tsichevski
09:57 AM User Interface Bug #8260: treelist sorting column with null and empty string values does not produce correct result
Vladimir Tsichevski wrote:
> Șerban Bursuc wrote:
>
> > As for what's different, it's a bit more apparent from th...
Șerban Bursuc
09:56 AM User Interface Bug #8260: treelist sorting column with null and empty string values does not produce correct result
Șerban Bursuc wrote:
> As for what's different, it's a bit more apparent from the screenshots in #8039-39
There i...
Vladimir Tsichevski
09:28 AM User Interface Bug #8260: treelist sorting column with null and empty string values does not produce correct result
Vladimir Tsichevski wrote:
> I reproduced the situation using @5084.p@, and I found no difference between OE and FWD...
Șerban Bursuc
08:23 AM User Interface Bug #8260 (Feedback): treelist sorting column with null and empty string values does not produce ...
I reproduced the situation using @5084.p@, and I found no difference between OE and FWD. What is wrong with FWD? Vladimir Tsichevski

04/01/2024

06:41 PM Base Language Bug #8154: refactor scopeable stacks
Code Review Task Branch 8154a Revision 15109
The changes look promising. There is clearly quite a bit more that c...
Greg Shah
12:51 PM Base Language Bug #8154 (WIP): refactor scopeable stacks
Created task branch 8154a from trunk rev 15108.
Rev 15109 contains first pass at moving scoped stacks into (TopLev...
Constantin Asofiei
06:41 PM User Interface Bug #8260: treelist sorting column with null and empty string values does not produce correct result
Șerban Bursuc wrote:
> Using the @TreeList@ testcase:
>
> We add nodes with the following cell values
>
> [......
Vladimir Tsichevski
01:46 PM User Interface Bug #8556: Incorrect frame layout
The issue exists at least since the trunk rev. 14857, so it is not a recent regression. Vladimir Tsichevski
01:26 PM User Interface Bug #8556: Incorrect frame layout
The following example:... Vladimir Tsichevski
01:21 PM User Interface Bug #8556 (New): Incorrect frame layout
Vladimir Tsichevski
08:49 AM Database Bug #8554: resolving temp-tables in a class hierarchy
@DATASET:CREATE-LIKE("<dataset-name>")@ needs to be checked, too. Constantin Asofiei
08:02 AM Runtime Infrastructure Bug #8383: Some JsonObject methods create a LOG-MANAGER record in silent
Constantin Asofiei wrote:
> * in OE, SysError is used for internal errors (via ErrorManager for FWD). But, there is...
Galya B
05:21 AM Runtime Infrastructure Bug #8383 (WIP): Some JsonObject methods create a LOG-MANAGER record in silent
Constantin Asofiei wrote:
> * in OE, SysError is used for internal errors (via ErrorManager for FWD). But, there is...
Galya B
05:09 AM Runtime Infrastructure Bug #8383: Some JsonObject methods create a LOG-MANAGER record in silent
Galya, some notes:
* we need to be careful with naming FWD internal methods added to skeleton classes/interfaces (in...
Constantin Asofiei
04:00 AM Base Language Feature #6424: fill gaps in Java Open Client replacement (appserver client support)
Galya, I've placed the project under @devsrv01:/tmp/open_client_example.zip@. There is a small readme.txt in the pro... Constantin Asofiei

03/31/2024

10:35 AM Database Bug #8554: resolving temp-tables in a class hierarchy
There are some problems when resolving temp-tables in a hierarchy.
* @oo.Test1@:...
Constantin Asofiei
10:28 AM Database Bug #8554 (Test): resolving temp-tables in a class hierarchy
Constantin Asofiei

03/29/2024

01:23 PM User Interface Bug #7657: 8-bit character entry problem in ChUI
I am open to trying out and testing any FWD changes here on my end. Let me know if I can help in any way. I have work... Robert Jensen
06:39 AM User Interface Bug #7657: 8-bit character entry problem in ChUI
Robert Jensen wrote:
> The comand line is actually:
> ./client-terminal.sh client:cmd-line-option:startup-procedure...
Greg Shah
06:26 AM User Interface Bug #7657: 8-bit character entry problem in ChUI
> I may have missed a step here. I am running from Intellij, which I did restart after the changes to .bashrd But may... Greg Shah
06:17 AM User Interface Bug #7657: 8-bit character entry problem in ChUI
In #7657-5, I mentioned some changes that were needed. Let me make it more clear: these changes that are needed are ... Greg Shah
10:57 AM Base Language Feature #6407: name_map.xml improvements
Galya B wrote:
> @SourceNameMapper.initMappingData@ seems to be executed only once for the lifespan of the runtime m...
Constantin Asofiei
10:20 AM Base Language Feature #6407 (WIP): name_map.xml improvements
6407a created from trunk r15101. Galya B
10:03 AM Base Language Feature #6407: name_map.xml improvements
@SourceNameMapper.initMappingData@ seems to be executed only once for the lifespan of the runtime machine with a serv... Galya B
09:46 AM Base Language Feature #6407: name_map.xml improvements
Constantin Asofiei wrote:
> Also, SourceNameMapper will not load the .class and annotations when the entry in @name_...
Galya B
09:45 AM Base Language Feature #6407: name_map.xml improvements
Constantin Asofiei wrote:
> Java has tools to read an archive.
If you mean the custom FWD's @JarClassLoader@, then ...
Galya B
09:38 AM Base Language Feature #6407: name_map.xml improvements
You don't need to unzip the jar - Java has tools to read an archive. This just means we can't rely on @Class.getReso... Constantin Asofiei
09:37 AM Base Language Feature #6407: name_map.xml improvements
Why can't we use the same technique from @Utils.searchResourceJars()@? We don't need the propath part but we definit... Greg Shah
09:29 AM Base Language Feature #6407: name_map.xml improvements
That is of course if the check for the file listed by @jar tvf filename.jar@ gives positive. Galya B
09:27 AM Base Language Feature #6407: name_map.xml improvements
Constantin Asofiei wrote:
> Galya, what package would you use for looking into multiple jars? Look everywhere? The ...
Galya B
08:41 AM Base Language Feature #6407: name_map.xml improvements
Galya, what package would you use for looking into multiple jars? Look everywhere? The problem with @name_map.xml@ i... Constantin Asofiei
08:31 AM Base Language Feature #6407: name_map.xml improvements
> @MultiClassLoader@ has a list of all jars in the classpath. It can look for @name_map.xml@ in each jar (with @jar t... Greg Shah
07:08 AM Base Language Feature #6407: name_map.xml improvements
@MultiClassLoader@ has a list of all jars in the classpath. It can look for @name_map.xml@ in each jar (with @jar tvf... Galya B
08:50 AM Support #8547 (Review): Fix documentation for Non-Standard Save Cache Implementation
Changes to wiki completed.
Eric, please review.
Tijs Wickardt
08:16 AM Support #8547 (WIP): Fix documentation for Non-Standard Save Cache Implementation
Tijs Wickardt
08:16 AM Support #8547: Fix documentation for Non-Standard Save Cache Implementation
This task is about [[p2j:Non-Standard Save Cache Implementation]] .
Tijs will do the required changes, Eric needs to...
Tijs Wickardt
08:13 AM Support #8547 (Review): Fix documentation for Non-Standard Save Cache Implementation
Tijs Wickardt
07:42 AM Runtime Infrastructure Feature #6692: move FWD to Java 17
Greg Shah wrote:
> Did you test both embedded mode and virtual desktop in Hotel GUI?
>
Yes, I did
> Did you test...
Tomasz Domin
04:44 AM Runtime Infrastructure Feature #6692: move FWD to Java 17
It would be interesting to profile a test case with both Java 8 and Java 17 and see where the times differ. Having mo... Hynek Cihlar
06:16 AM Base Language Feature #6431: implement support to allow CPINTERNAL set to UTF-8 and CP936
I know some work has happened to explore I18N testcases. Having proper testcases will be very important.
I want t...
Greg Shah
03:16 AM Runtime Infrastructure Feature #8544: Move spawner code to JNI
The spawner executable exists as a separate deployment with the sole purpose of providing admin rights only to a stri... Galya B
02:51 AM Runtime Infrastructure Feature #8544 (New): Move spawner code to JNI
Galya B

03/28/2024

06:49 PM User Interface Bug #7657: 8-bit character entry problem in ChUI
The comand line is actually:
./client-terminal.sh client:cmd-line-option:startup-procedure=com/<app_path>/ClientBoot...
Robert Jensen
05:45 PM User Interface Bug #7657: 8-bit character entry problem in ChUI
I fianally got around to trying the ncurses update. No change. The setup_ncurses6x.sh script did appear to work corre... Robert Jensen
05:13 PM Runtime Infrastructure Feature #6692: move FWD to Java 17
Yes, this can be found in #8208-18. A summary for those that can't access that task:
> * Java 8 is faster than Ja...
Greg Shah
04:05 PM Runtime Infrastructure Feature #6692: move FWD to Java 17
Guys,
Regarding possible migration I have a question. Will we have performance degradation with @Java 8 -> Java 17...
Eugenie Lyzenko
03:46 PM Runtime Infrastructure Feature #6692: move FWD to Java 17
Did you test both embedded mode and virtual desktop in Hotel GUI?
Did you test call graph in Hotel GUI?
We need...
Greg Shah
02:43 PM Runtime Infrastructure Feature #6692: move FWD to Java 17
Greg Shah wrote:
> I know you've been doing some amount of testing on this. As far as I know, we only have testing ...
Tomasz Domin
02:07 PM Runtime Infrastructure Feature #6692 (Internal Test): move FWD to Java 17
I know you've been doing some amount of testing on this. As far as I know, we only have testing and any fixes that a... Greg Shah
05:09 PM Base Language Feature #6407: name_map.xml improvements
> We had this discussion before - moving *everything* to annotations will mean the entire converted .class code needs... Greg Shah
03:58 PM Base Language Feature #6407: name_map.xml improvements
Greg Shah wrote:
> > another improvement would be to emit some kind of special constructs for the virtual functions/...
Constantin Asofiei
03:50 PM Base Language Feature #6407: name_map.xml improvements
> another improvement would be to emit some kind of special constructs for the virtual functions/internal procedures ... Greg Shah
01:47 PM User Interface Feature #4517 (Closed): optionally back the 4GL features for Registry access with the user-specif...
Greg Shah
11:29 AM User Interface Bug #8541: Fill-In widget incorrectly resets cursor position to 0 when DISPLAY is in VALUE-CHANGE...
Updated previous message to hide customer info. Eugenie Lyzenko
11:27 AM User Interface Bug #8541: Fill-In widget incorrectly resets cursor position to 0 when DISPLAY is in VALUE-CHANGE...
The branch @8508a@ already created to accept the fixes. It has some fix candidate to review/test.
The samples to r...
Eugenie Lyzenko
11:23 AM User Interface Bug #8541 (New): Fill-In widget incorrectly resets cursor position to 0 when DISPLAY is in VALUE-...
Eugenie Lyzenko
09:49 AM Base Language Feature #6417 (WIP): cleanup some known items in appserver support
Galya B
09:44 AM Base Language Feature #6417: cleanup some known items in appserver support
Test in OE for client type:
Procedure running in batch client:...
Galya B

03/27/2024

07:46 PM Base Language Feature #6422: implement auditing support including AUDIT-POLICY and AUDIT-CONTROL
How can I access @TxWrapper$TransactionHelper.maybeActivateTxWrapper@? I currently have the following code (branch 64... Theodoros Theodorou
05:07 PM Base Language Feature #6410: implement additional built-in OO classes/interfaces
> It's probably useless to implement that as I don't expect those to be extended in the first place but the possibili... Greg Shah
05:06 PM Base Language Feature #6410: implement additional built-in OO classes/interfaces
Some notes from Marian:
> We had constantly issues with conversion when classes extended/implemented built-in cla...
Greg Shah
11:39 AM Database Bug #8249: Introduce a fast fill method to optimize Dataset.fill
With 8363f where @DATASET:FILL@ is optimized to use @hintFullResults@, this test fails if @AdaptiveQuery.hintFullResu... Constantin Asofiei

03/26/2024

10:53 AM Conversion Tools Feature #8525: eliminate the runtime dependency on registry.xml
We have to include @registry.xml@ from the conversion into the application jar. It contains the AST IDs for the @.p2... Greg Shah
10:50 AM Conversion Tools Feature #8525 (New): eliminate the runtime dependency on registry.xml
Greg Shah
04:09 AM Base Language Feature #6410: implement additional built-in OO classes/interfaces
@Constantin, are there any changes in trunk pertaining conversion especially for classes extending/implementing skele... Marian Edu

03/25/2024

09:05 AM Base Language Feature #6417: cleanup some known items in appserver support
> I'm not sure if my reasoning is correct, but it looks like the same appserver agent can execute all types of appser... Greg Shah
06:40 AM Base Language Feature #6417: cleanup some known items in appserver support
Actually there several places where appserver tasks are executed in a different way. I've found these:
* @Agent.Agen...
Galya B
06:32 AM Base Language Feature #6417: cleanup some known items in appserver support
I'm not sure if my reasoning is correct, but it looks like the same appserver agent can execute all types of appserve... Galya B
08:37 AM Base Language Feature #6826: reduce the BDT usage in FWD runtime
There are many cases where a BDT is used as a short-lived constant value. The most of case are @logical@ and @interge... Ovidiu Maxiniuc
02:53 AM Database Bug #8459: investigate changing H2 to allow NULL to equal NULL (and the impact on the other compa...
There should be a distinction between equality check when updating/inserting and the equality check when querying. We... Alexandru Lungu

03/24/2024

08:47 AM Conversion Tools Bug #8511: replace string annotation with numeric annotations
In 8363f rev 15094, annotation for runtime JAST interpreter (dynamic query conversion) are stored using an integer ID... Constantin Asofiei
08:43 AM Conversion Tools Bug #8511 (New): replace string annotation with numeric annotations
Constantin Asofiei
05:17 AM Base Language Bug #8510 (New): replace all 'new logical' in FWD runtime with logical.of or logical.UNKNOWN
Constantin Asofiei

03/22/2024

01:36 PM Database Bug #8459: investigate changing H2 to allow NULL to equal NULL (and the impact on the other compa...
Well, this is pretty bad in my opinion. I don't really have a solution for this, I need to think this through a bit m... Radu Apetrii
05:07 AM Database Bug #8459: investigate changing H2 to allow NULL to equal NULL (and the impact on the other compa...
Radu Apetrii wrote:
> Constantin Asofiei wrote:
> > The problem is this happens only when we do a unique validation...
Alexandru Lungu
04:22 AM Database Bug #8459: investigate changing H2 to allow NULL to equal NULL (and the impact on the other compa...
Alexandru Lungu wrote:
> Merged to trunk as rev. 15085.
Please post to #7847 also.
Constantin Asofiei
04:16 AM Database Bug #8459: investigate changing H2 to allow NULL to equal NULL (and the impact on the other compa...
Constantin Asofiei wrote:
> The problem is this happens only when we do a unique validation using SELECT, and not on...
Radu Apetrii
04:10 AM Database Bug #8459: investigate changing H2 to allow NULL to equal NULL (and the impact on the other compa...
Merged to trunk as rev. 15085. Alexandru Lungu
04:04 AM Database Bug #8459: investigate changing H2 to allow NULL to equal NULL (and the impact on the other compa...
Created 8459b and committed the disable for USE_NULL_EQUALITY.
Preparing for merge with trunk.
Alexandru Lungu
03:55 AM Database Bug #8459: investigate changing H2 to allow NULL to equal NULL (and the impact on the other compa...
... Constantin Asofiei
03:52 AM Database Bug #8459 (WIP): investigate changing H2 to allow NULL to equal NULL (and the impact on the other...
There is a regression in #7143-784 related to the NULL changes in H2. If I comment @use_null_equality=true;@, then t... Constantin Asofiei
09:37 AM Base Language Feature #6424: fill gaps in Java Open Client replacement (appserver client support)
This will need a guide - how to use gradle cache to run and debug a Java client project.
Galya B
09:24 AM Base Language Feature #6424: fill gaps in Java Open Client replacement (appserver client support)
Nevermind, it was on devsrv01: @scp devsrv01:/tmp/gradle-skylab.zip .@ . Galya B
09:22 AM Base Language Feature #6424: fill gaps in Java Open Client replacement (appserver client support)
Constantin, where is the project on the shared drives? I remember you gave me a path, I can't find now. Galya B
09:37 AM Database Bug #8496: investigate if a 'batch insert with deactivated index' in H2 is possible
Constantin Asofiei wrote:
> The idea is to have a mode in H2 where indexes are not *updated(?) after each insert*. ...
Ovidiu Maxiniuc
07:44 AM Database Bug #8496: investigate if a 'batch insert with deactivated index' in H2 is possible
Constantin, for FILL we do 50k independent inserts. Can we maybe bulk them? Or do we actually need the intermediate s... Alexandru Lungu
09:27 AM Database Bug #8500 (Test): dataset:set-buffers must use default-buffer-handle if a temp-table handle is used
Constantin Asofiei
09:27 AM Database Bug #8500: dataset:set-buffers must use default-buffer-handle if a temp-table handle is used
Branch 8500a was merged into trunk as rev. 15086 and archived. Constantin Asofiei
09:23 AM Database Bug #8500: dataset:set-buffers must use default-buffer-handle if a temp-table handle is used
Cor, please use this archive. Constantin Asofiei
09:19 AM Database Bug #8500 (Merge Pending): dataset:set-buffers must use default-buffer-handle if a temp-table han...
Created task branch 8500a from trunk rev 15085.
Ref 15086 fixes:
* @SET-BUFFERS(handle...)@ must use the DEFAULT...
Constantin Asofiei
09:13 AM Database Bug #8500 (Test): dataset:set-buffers must use default-buffer-handle if a temp-table handle is used
Constantin Asofiei

03/21/2024

03:32 PM Database Feature #7366: improve performance of buffer.fill
Idea of improvements:
* the data-source query may or may not use all record fields, depending on the mapping. We ca...
Constantin Asofiei
02:55 PM Database Bug #8496: investigate if a 'batch insert with deactivated index' in H2 is possible
Above 're-balance' actually means re-building the index... so this may be expensive on its own. Constantin Asofiei
02:52 PM Database Bug #8496: investigate if a 'batch insert with deactivated index' in H2 is possible
There are operations where we do lots of inserts. In some case, in a FILL operation, some 50k temp-table records are... Constantin Asofiei
02:43 PM Database Bug #8496 (New): investigate if a 'batch insert with deactivated index' in H2 is possible
Constantin Asofiei
02:47 PM Database Bug #8451 (Test): improve performance of H2 String column comparison
Greg Shah
02:23 PM Database Bug #8451: improve performance of H2 String column comparison
Branch 8451a was created from trunk rev 15082. Rev 15083 contains the FWD-H2 build.gradle upgrade to rev 1.43.
Br...
Constantin Asofiei
02:13 PM Database Bug #8451 (Merge Pending): improve performance of H2 String column comparison
ETF testing passed, starting merge. Constantin Asofiei
07:58 AM Database Bug #8451: improve performance of H2 String column comparison
Greg Shah wrote:
> Is more testing needed?
I'm doing ETF testing with it.
Constantin Asofiei
02:27 PM Database Bug #8488 (Test): improve performance of WRITE-JSON
Branch 8488a was merged into trunk as rev. 15084 and archived. Constantin Asofiei
02:24 PM Database Bug #8488 (Merge Pending): improve performance of WRITE-JSON
Merging now. Constantin Asofiei
12:42 PM Database Bug #8488: improve performance of WRITE-JSON
I have re-review the 8488a up to r15080 and I am OK with the changes.
The branch can be merged to trunk.
Ovidiu Maxiniuc
11:08 AM Database Bug #8488: improve performance of WRITE-JSON
I'm good with that plan. Greg Shah
10:59 AM Database Bug #8488 (Internal Test): improve performance of WRITE-JSON
There are regressions related to AdaptiveFind (from #8490), otherwise 8488a and #8451 passed.
I'm testing #8459 ne...
Constantin Asofiei
07:57 AM Database Bug #8488 (Review): improve performance of WRITE-JSON
Constantin Asofiei
07:42 AM Database Bug #8488: improve performance of WRITE-JSON
Ovidiu, in rev 15080 I have the review fixes. See bellow for notes:
> * In @P2JQuery.java@, you added @public defau...
Constantin Asofiei
02:12 PM Database Bug #8459 (Test): investigate changing H2 to allow NULL to equal NULL (and the impact on the othe...
Branch 8459a was merged into trunk as rev. 15082 and archived. Constantin Asofiei
02:04 PM Database Bug #8459: investigate changing H2 to allow NULL to equal NULL (and the impact on the other compa...
I've started merge of 8459a. Constantin Asofiei
06:29 AM Database Bug #8459: investigate changing H2 to allow NULL to equal NULL (and the impact on the other compa...
fwd-h2 1.42 is on projsrv01. Constantin Asofiei
05:42 AM Database Bug #8459: investigate changing H2 to allow NULL to equal NULL (and the impact on the other compa...
Constantin Asofiei wrote:
> Alexandru, I'm good.
>
> Radu: if unit tests/standalone tests are OK, please build fw...
Radu Apetrii
05:20 AM Database Bug #8459: investigate changing H2 to allow NULL to equal NULL (and the impact on the other compa...
Alexandru, I'm good.
Radu: if unit tests/standalone tests are OK, please build fwd-h2 and upload it to @devsrv01:/...
Constantin Asofiei
03:48 AM Database Bug #8459 (Internal Test): investigate changing H2 to allow NULL to equal NULL (and the impact on...
The unit tests in H2 suffice. I think you are good to go with the merge of 8459a_h2.
Constantin, anything to add h...
Alexandru Lungu
03:43 AM Database Bug #8459: investigate changing H2 to allow NULL to equal NULL (and the impact on the other compa...
Alexandru Lungu wrote:
> What about simple comparison with @EQUAL@ (instead of 0) and @NON_EQUAL@ (instead of 5)? Am...
Radu Apetrii
03:35 AM Database Bug #8459: investigate changing H2 to allow NULL to equal NULL (and the impact on the other compa...
What about simple comparison with @EQUAL@ (instead of 0) and @NON_EQUAL@ (instead of 5)? Am I missing something? Alexandru Lungu
09:30 AM Database Feature #8494: rework XmlExport with the performance improvements from JsonExport
Implement the same performance improvements as were done in #8488. Greg Shah
09:29 AM Database Feature #8494 (New): rework XmlExport with the performance improvements from JsonExport
Greg Shah
08:43 AM Database Feature #7323 (Test): Implement soft unique index in FWD-H2
Got it! Alexandru Lungu
08:43 AM Database Feature #7323: Implement soft unique index in FWD-H2
Branch 7323b was merged into trunk as rev. 15075 and archived. Constantin Asofiei
08:41 AM Database Feature #7323: Implement soft unique index in FWD-H2
Constantin, unless you started the process, I will prepare for merge in ~10 mins. Alexandru Lungu
04:26 AM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
Branch 7045f was created from trunk rev 15077 - in rev 15078 re-fixed the regression in 7045d/e. Merged to trunk rev... Constantin Asofiei

03/20/2024

06:51 PM Database Bug #8488: improve performance of WRITE-JSON
Constantin Asofiei wrote:
> Ovidiu, an early review is appreciated - I still need to regression test in standalone t...
Ovidiu Maxiniuc
03:52 PM Database Bug #8488 (WIP): improve performance of WRITE-JSON
Created branch 8488a from trunk rev 15077. In rev 15088 there are performance improvements for WRITE-JSON:
* Avoid ...
Constantin Asofiei
12:25 PM Database Bug #8488 (Test): improve performance of WRITE-JSON
Constantin Asofiei
04:54 PM Database Bug #8459: investigate changing H2 to allow NULL to equal NULL (and the impact on the other compa...
Alexandru Lungu wrote:
> Can we replace these with something more suggestive. Are these EQUAL and NON_EQUAL, or some...
Radu Apetrii
03:24 PM Database Bug #8459: investigate changing H2 to allow NULL to equal NULL (and the impact on the other compa...
I am OK with 8459a_h2 changes. Good addition with the unit test!
The @getValue@ looks right to me. The only concer...
Alexandru Lungu
01:00 PM Base Language Feature #7045 (Test): re-implement "normal" (non-abend) stack unwinding to avoid throwing an exce...
Branch 7045e was merged into trunk as rev. 15077 and archived. Constantin Asofiei
12:45 PM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
If you are confident it is safe, it can be merged now. Greg Shah
12:44 PM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
Greg, can this be merged? It affects a customer's app. Constantin Asofiei
07:34 AM Base Language Feature #7045 (Internal Test): re-implement "normal" (non-abend) stack unwinding to avoid throwin...
Code Review Task Branch 7045e Revision 15074
I'm OK with the change.
Greg Shah
02:54 AM Base Language Feature #7045 (Review): re-implement "normal" (non-abend) stack unwinding to avoid throwing an ex...
Created task branch 7045e from trunk rev 15073. In rev 15074 fixes "RETURN statements from within a CASE statement a... Constantin Asofiei
11:05 AM Database Feature #7323 (Merge Pending): Implement soft unique index in FWD-H2
You can merge to trunk now. Greg Shah
10:50 AM Database Feature #7323: Implement soft unique index in FWD-H2
Greg Shah wrote:
> What testing is needed?
I've tested with the #8363 app and there is no regression in performance...
Constantin Asofiei
07:36 AM Database Feature #7323 (Internal Test): Implement soft unique index in FWD-H2
What testing is needed? Greg Shah
06:47 AM Database Feature #7323: Implement soft unique index in FWD-H2
Alexandru, I agree, the change is in 7323b rev 15075. Constantin Asofiei
05:30 AM Database Feature #7323: Implement soft unique index in FWD-H2
Then I agree with Constantin's changes. Before, the 7323a changes, the flush (so the DB validation0 was done only if ... Alexandru Lungu
04:48 AM Database Feature #7323: Implement soft unique index in FWD-H2
Alexandru Lungu wrote:
> Radu/Constantin: can you share how the condition looked like before the 7323a changes?
Thi...
Radu Apetrii
04:40 AM Database Feature #7323: Implement soft unique index in FWD-H2
AFAIK, the condition there was rewritten to consider DBUniqueCheck, but remain equivalent to what was before. I prefe... Alexandru Lungu
02:58 AM Database Feature #7323 (Review): Implement soft unique index in FWD-H2
Created task 7323b from trunk rev 15073. The fix in previous note is in rev 15074. Please review. Constantin Asofiei
08:52 AM Database Bug #8451 (Internal Test): improve performance of H2 String column comparison
Is more testing needed? Greg Shah
07:53 AM Database Bug #8451: improve performance of H2 String column comparison
The changes are good:
* Good job in leveraging the @collationKeys@ caches with this @ValueString@ ci/cs keys.
* I...
Alexandru Lungu
07:43 AM Database Bug #8451: improve performance of H2 String column comparison
Checking out now. Alexandru Lungu
07:15 AM Database Bug #8451: improve performance of H2 String column comparison
Alexandru: can you review this today?
Greg: if review is OK, I'd like to get this merged.
Constantin Asofiei
08:43 PM Database Bug #7645: Simplify _meta database initialization by removing <schema>.meta.xml resource
The hotel project built without any issues, without any additional changes. The @.meta.xml@ files had been generated ... Ovidiu Maxiniuc

03/19/2024

06:58 PM Database Bug #8459: investigate changing H2 to allow NULL to equal NULL (and the impact on the other compa...
I've committed to 8459a_h2 rev. 43 changes that include:
* Added a case for handling equality between a null compone...
Radu Apetrii
04:03 PM Database Bug #8459: investigate changing H2 to allow NULL to equal NULL (and the impact on the other compa...
Also, one more thing. In @Comparison.getValue@, depending on the @compareType@ value, things should be treated for bo... Radu Apetrii
03:11 PM Database Bug #8459: investigate changing H2 to allow NULL to equal NULL (and the impact on the other compa...
I am OK with the changes in 8459a (FWD branch).
For FWD-H2:
* In @compare@, you need to also explicitly handle th...
Alexandru Lungu
01:19 PM Database Bug #8459: investigate changing H2 to allow NULL to equal NULL (and the impact on the other compa...
Radu Apetrii wrote:
> Constantin Asofiei wrote:
> > Please rebase both 8459a_h2 and 8459a.
> On it.
Done. 8459a r...
Radu Apetrii
01:16 PM Database Bug #8459: investigate changing H2 to allow NULL to equal NULL (and the impact on the other compa...
Who should be doing the review? Greg Shah
12:57 PM Database Bug #8459: investigate changing H2 to allow NULL to equal NULL (and the impact on the other compa...
Constantin Asofiei wrote:
> Please rebase both 8459a_h2 and 8459a.
On it.
Radu Apetrii
12:56 PM Database Bug #8459: investigate changing H2 to allow NULL to equal NULL (and the impact on the other compa...
Please rebase both 8459a_h2 and 8459a. Constantin Asofiei
12:50 PM Database Bug #8459 (Review): investigate changing H2 to allow NULL to equal NULL (and the impact on the ot...
Constantin Asofiei wrote:
> Radu, do you have the FWD and H2 changes, for some early testing?
Yes, sorry for the de...
Radu Apetrii
12:20 PM Database Bug #8459: investigate changing H2 to allow NULL to equal NULL (and the impact on the other compa...
Radu, do you have the FWD and H2 changes, for some early testing? Constantin Asofiei
04:09 AM Database Bug #8459: investigate changing H2 to allow NULL to equal NULL (and the impact on the other compa...
Radu Apetrii wrote:
> Alexandru Lungu wrote:
> > Create a flag like in the [[internal-documentation:H2_Database_For...
Constantin Asofiei
04:05 AM Database Bug #8459: investigate changing H2 to allow NULL to equal NULL (and the impact on the other compa...
Alexandru Lungu wrote:
> Create a flag like in the [[internal-documentation:H2_Database_Fork]] Wiki and use it to di...
Radu Apetrii
04:09 PM Database Bug #7645: Simplify _meta database initialization by removing <schema>.meta.xml resource
Eugenie Lyzenko wrote:
> Ovidiu Maxiniuc wrote:
> > Branch 7645a was merged into trunk as rev. 15070 and archived.
...
Eric Faulhaber
03:06 PM Database Bug #7645: Simplify _meta database initialization by removing <schema>.meta.xml resource
Ovidiu Maxiniuc wrote:
> Branch 7645a was merged into trunk as rev. 15070 and archived.
>
> Reconversion is not m...
Eugenie Lyzenko
02:01 PM Database Bug #7645 (Test): Simplify _meta database initialization by removing <schema>.meta.xml resource
Branch 7645a was merged into trunk as rev. 15070 and archived.
Reconversion is not mandatory. But if done the @<db...
Ovidiu Maxiniuc
01:52 PM Database Feature #7323: Implement soft unique index in FWD-H2
Found a regression in 7323a changes:... Constantin Asofiei
10:31 AM Database Feature #7323 (Test): Implement soft unique index in FWD-H2
Branch 7323a was merged into trunk as rev. 15065 and archived.
7323b_h2 was merged into FWD-H2 trunk rev 41 and ar...
Constantin Asofiei
10:11 AM Database Feature #7323: Implement soft unique index in FWD-H2
Yes, working on it. Constantin Asofiei
09:52 AM Database Feature #7323: Implement soft unique index in FWD-H2
Constantin, you need to merge H2 first, build, upload the FWD binary, commit to the FWD branch the upgrade and *after... Alexandru Lungu
09:27 AM Database Feature #7323 (Merge Pending): Implement soft unique index in FWD-H2
You can merge now. Greg Shah
04:18 AM Database Feature #7323: Implement soft unique index in FWD-H2
*Review of 7323b_h2*
* I reviewed Radu's changes in the past and they were OK.
* Recent changes are fine to me. I...
Alexandru Lungu
12:36 AM Database Feature #7323: Implement soft unique index in FWD-H2
Code review 7323a/15068:
The changes look ok to me, though it is a little confusing that the SOFT_INDEX keyword is...
Eric Faulhaber
12:15 PM Database Bug #8451 (Review): improve performance of H2 String column comparison
Created 8451a_h2 from fwd-h2 trunk rev 41. In rev 42, I've implemented the idea in #8451-5 - cache the collation key... Constantin Asofiei
11:04 AM Base Language Feature #7045 (Test): re-implement "normal" (non-abend) stack unwinding to avoid throwing an exce...

Branch 7045d was merged into trunk as rev. 15068 and archived.
Constantin Asofiei
11:02 AM Base Language Feature #7045 (Merge Pending): re-implement "normal" (non-abend) stack unwinding to avoid throwin...
Merging this now. Constantin Asofiei

03/18/2024

09:08 AM Base Language Feature #6417 (Review): cleanup some known items in appserver support
> * versioninfo fields are read-only, but writing them is a runtime error and not compile error in FWD.
* @session/l...
Galya B
06:35 AM Database Bug #8451: improve performance of H2 String column comparison
Please go ahead. I am quite -stuck- working with some heap dumps and #8380 at the moment. Alexandru Lungu
06:09 AM Database Bug #8451: improve performance of H2 String column comparison
Alexandru, the idea sounds promising - I can make the changes if you are busy with something else. Constantin Asofiei
06:00 AM Database Bug #8451: improve performance of H2 String column comparison
The idea I have for this task:
* As most of the (string) comparisons involve 1 or even 2 database fields, I sugges...
Alexandru Lungu
05:35 AM Database Bug #8459: investigate changing H2 to allow NULL to equal NULL (and the impact on the other compa...
Radu, I think we should restrict this with a flag. H2 is used with other goals in FWD and I don't what to make this c... Alexandru Lungu
05:34 AM Database Bug #8459: investigate changing H2 to allow NULL to equal NULL (and the impact on the other compa...
Radu Apetrii wrote:
> Alex/Constantin: Was the phrase @tt1.f1 is null@ added just for the H2 dialect, or is this nul...
Constantin Asofiei
04:45 AM Database Bug #8459: investigate changing H2 to allow NULL to equal NULL (and the impact on the other compa...
Alex/Constantin: Was the phrase @tt1.f1 is null@ added just for the H2 dialect, or is this null equality an issue in ... Radu Apetrii
03:50 AM Database Bug #8459: investigate changing H2 to allow NULL to equal NULL (and the impact on the other compa...
I've attached a patch for H2 in order to allow null equality. It certainly needs a review and a set of performance te... Radu Apetrii

03/17/2024

03:04 PM Database Feature #7323: Implement soft unique index in FWD-H2
Constantin Asofiei wrote:
> I'm regression testing this with ETF.
ETF testing passed.
As a side note: we may wan...
Constantin Asofiei
12:22 PM Database Feature #7323: Implement soft unique index in FWD-H2
Created task branch 7323b_h2 from fwd-h2 trunk rev 40.
In rev 41, it adds a "soft_unique" option for index column...
Constantin Asofiei

03/16/2024

07:11 AM Database Feature #7323: Implement soft unique index in FWD-H2
What we need is to mark the @recid@ trailing component of a 'soft-unique' index as @soft-unique@, too - so this can b... Constantin Asofiei
08:47 PM Database Feature #7323: Implement soft unique index in FWD-H2
I committed to 7323a rev. 15067 a rebase fix for classes @Persistence@, @Persister@, and @Validation@. It seemed that... Radu Apetrii

03/15/2024

03:23 PM Database Feature #7323: Implement soft unique index in FWD-H2
I've placed on @devsrv01:/tmp/7323a_rev_14805_trunk_14789.7z@ the pre-rebase branch, in case you need it. Constantin Asofiei
01:06 PM Database Feature #7323: Implement soft unique index in FWD-H2
Constantin Asofiei wrote:
> @validateUniqueByQuery@ is still called for temp-tables. Why is that?
This shouldn't b...
Radu Apetrii
12:30 PM Database Feature #7323: Implement soft unique index in FWD-H2
I've discussed this morning with Radu what this task is meant to do and I think I understand it: let H2 throw an exce... Constantin Asofiei
01:30 PM Database Bug #7474: FindQuery provides the wrong result because the record is not updated in the database
I think I've implemented a fix on this.
The issue was related with a fact, that @RecordNursery@ was only involved in...
Tomasz Domin
08:29 AM Database Bug #8459: investigate changing H2 to allow NULL to equal NULL (and the impact on the other compa...
This test shows the 'unknown equality' in OpenEdge:... Constantin Asofiei
07:38 AM Database Bug #8459: investigate changing H2 to allow NULL to equal NULL (and the impact on the other compa...
If you have two big tables and none have indexes, on join, it should do scan on both tables (nested join - N * M comp... Alexandru Lungu
07:36 AM Database Bug #8459: investigate changing H2 to allow NULL to equal NULL (and the impact on the other compa...
Constantin Asofiei wrote:
> will make H2 use the scan index.
Constantin, is there a chance that you can point me to...
Radu Apetrii
07:03 AM Database Bug #8459: investigate changing H2 to allow NULL to equal NULL (and the impact on the other compa...
I created branch 8459a_h2 for this matter. Radu Apetrii
04:12 AM Database Bug #8459 (WIP): investigate changing H2 to allow NULL to equal NULL (and the impact on the other...
With #8363, FWD now has a MANDATORY option allowed at temp-table fields. When using joins, this can have a huge impa... Constantin Asofiei
04:08 AM Database Bug #8459 (WIP): investigate changing H2 to allow NULL to equal NULL (and the impact on the other...
Constantin Asofiei
08:05 AM Runtime Infrastructure Bug #8383 (Review): Some JsonObject methods create a LOG-MANAGER record in silent
8383a based on trunk r15055.
8383a r15058 ready for review.
I've decided on an imperfect solution that will hop...
Galya B
07:18 AM Runtime Infrastructure Bug #8383: Some JsonObject methods create a LOG-MANAGER record in silent
To run tests:
* @oo/progress/lang/test_apperror.p@
* @oo/json/object/get_json_object.p@
Galya B

03/14/2024

03:48 PM Database Bug #8044: Fix "Failed direct-access due to Error direct accessing for finding record by unique i...
Just to notify - I am still getting a lot of "Failed direct-access due to Error direct accessing for finding record b... Tomasz Domin
03:41 PM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
Sounds good. Greg Shah
03:03 PM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
Greg Shah wrote:
> Code Review Task Branch 7045d Revision 15042
>
> In @return_stmts.rules@, the @type == prog.pr...
Constantin Asofiei
02:58 PM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
Code Review Task Branch 7045d Revision 15042
In @return_stmts.rules@, the @type == prog.procedure ...
Greg Shah
02:46 PM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
Greg, please review 7045d - I'd like to get this into trunk, it doesn't hurt. Constantin Asofiei
03:17 PM Base Language Feature #7122: convert default getter/setter as plain Java methods
In 8363d, a property getter with only a 'return <literal>.' body will convert to a Java return which will wrap the li... Constantin Asofiei
10:46 AM Database Feature #7323: Implement soft unique index in FWD-H2
Alexandru/Radu, I think we may need a call to discuss the soft index approach.
Radu: I took a look again at 7323a ...
Constantin Asofiei
10:43 AM Database Bug #8451: improve performance of H2 String column comparison
When executing the #8363 scenarios, there are ~20 million calls of @CompareModeDefault.comapreString@. This relies o... Constantin Asofiei
10:37 AM Database Bug #8451 (Test): improve performance of H2 String column comparison
Constantin Asofiei
06:52 AM Runtime Infrastructure Bug #8383: Some JsonObject methods create a LOG-MANAGER record in silent
There is another issue: The error is logged twice (no matter if silent or not). That is because @BlockManager.process... Galya B
05:29 AM Runtime Infrastructure Bug #8383: Some JsonObject methods create a LOG-MANAGER record in silent
I'll have to try and find examples of code to test the different branches of @processLegacyError@ to be able to 100% ... Galya B
05:28 AM Runtime Infrastructure Bug #8383: Some JsonObject methods create a LOG-MANAGER record in silent
@TransactionManager@ does a trick that is not taken into consideration in @BlockManager.processLegacyError@, when log... Galya B
04:49 AM Runtime Infrastructure Bug #8383 (WIP): Some JsonObject methods create a LOG-MANAGER record in silent
Galya B

03/13/2024

07:56 PM User Interface Bug #8446 (Test): REGRESSION: incorrect return value in ThinClient.waitForEvent
Greg Shah
06:22 PM User Interface Bug #8446: REGRESSION: incorrect return value in ThinClient.waitForEvent
Greg Shah wrote:
> Vladimir: You can merge to trunk now.
Done. Trunk rev. 15055.
Vladimir Tsichevski
06:18 PM User Interface Bug #8446: REGRESSION: incorrect return value in ThinClient.waitForEvent
Vladimir: You can merge to trunk now. Greg Shah
05:49 PM User Interface Bug #8446 (Merge Pending): REGRESSION: incorrect return value in ThinClient.waitForEvent
Code review 8446a revision 15055. The change looks good. Hynek Cihlar
05:29 PM User Interface Bug #8446: REGRESSION: incorrect return value in ThinClient.waitForEvent
Greg Shah wrote:
> Do you have the fix in a branch?
>
> Hynek: Any objections to the fix?
>
> Vladimir: This s...
Vladimir Tsichevski
05:19 PM User Interface Bug #8446 (Review): REGRESSION: incorrect return value in ThinClient.waitForEvent
Fixed in 8446a rev. 15055. Please, review. Vladimir Tsichevski
04:56 PM User Interface Bug #8446: REGRESSION: incorrect return value in ThinClient.waitForEvent
Do you have the fix in a branch?
Hynek: Any objections to the fix?
Vladimir: This seems pretty safe. I think so...
Greg Shah
04:45 PM User Interface Bug #8446 (WIP): REGRESSION: incorrect return value in ThinClient.waitForEvent
This issue was the result of change in 8068a (trunk rev. 15032) and incomplete regression fix in 8419a (trunk rev. 15... Vladimir Tsichevski
04:39 PM User Interface Bug #8446 (Test): REGRESSION: incorrect return value in ThinClient.waitForEvent
Vladimir Tsichevski
12:43 PM Database Feature #7323: Implement soft unique index in FWD-H2
I've tested with #8363 and there is no impact or makes things slightly worse in some cases. Constantin Asofiei
06:45 AM Database Feature #7323: Implement soft unique index in FWD-H2
Radu Apetrii wrote:
> Constantin Asofiei wrote:
> > Radu Apetrii wrote:
> > > Done. Rebased 7323a with trunk rev.1...
Constantin Asofiei
06:42 AM Database Feature #7323: Implement soft unique index in FWD-H2
Constantin Asofiei wrote:
> Radu Apetrii wrote:
> > Done. Rebased 7323a with trunk rev.15051, meaning that 7323a is...
Radu Apetrii
06:36 AM Database Feature #7323: Implement soft unique index in FWD-H2
Radu Apetrii wrote:
> Done. Rebased 7323a with trunk rev.15051, meaning that 7323a is now at rev. 15066.
Please che...
Constantin Asofiei
06:34 AM Database Feature #7323: Implement soft unique index in FWD-H2
Done. Rebased 7323a with trunk rev.15051, meaning that 7323a is now at rev. 15066. Radu Apetrii
05:14 AM Database Feature #7323: Implement soft unique index in FWD-H2
OK, I'll handle this now since I'm waiting for an import anyways. Radu Apetrii
05:10 AM Database Feature #7323: Implement soft unique index in FWD-H2
Constantin Asofiei wrote:
> I'm rebasing 7323a and 7323a_h2 to check them with #8363.
7323a_h2 was already merged t...
Constantin Asofiei
04:56 AM Database Feature #7323: Implement soft unique index in FWD-H2
I'm rebasing 7323a and 7323a_h2 to check them with #8363. Constantin Asofiei
08:58 AM User Interface Feature #4853: implement support for reporting a device-id which is meant to identify a unique cl...
Galya B wrote:
> You can find the device id with @SESSION:DEVICE-ID@ and the code needs to be converted with FWD r15...
Robin Harris
08:52 AM User Interface Feature #4853: implement support for reporting a device-id which is meant to identify a unique cl...
You can find the device id with @SESSION:DEVICE-ID@ and the code needs to be converted with FWD r15017 or later. Galya B
08:41 AM User Interface Feature #4853: implement support for reporting a device-id which is meant to identify a unique cl...
Whatcha,
Glorious news that this is in "test"! what 4GL code changes do we need to do to make use of this functio...
Robin Harris
05:08 AM Base Language Bug #8427 (Closed): LOG-MANAER:CLOSE-LOG does not reset the enabled state
8237a was merged to trunk revision 15044 and archived. Galya B
09:22 PM Database Bug #7645 (Review): Simplify _meta database initialization by removing <schema>.meta.xml resource
The fixes are done. I also did a bit of cleanup and code maintenance.
Here is a bit of code which dumps the metadata...
Ovidiu Maxiniuc

03/12/2024

05:41 PM Base Language Feature #6407: name_map.xml improvements
We need to implement something soon due to some customer deadlines. I don't think we have time to implement the full... Greg Shah
03:57 AM Database Bug #8249: Introduce a fast fill method to optimize Dataset.fill
The changes in the patch were committed to trunk via 8363a, which was merged to trunk as revision 15049.
Constantin Asofiei
03:50 AM Database Bug #7645: Simplify _meta database initialization by removing <schema>.meta.xml resource
Committed on 7645a, revision 15018.
In this commit I addressed most of the review issues, however I was investigat...
Eduard Soltan

03/11/2024

02:16 PM Database Bug #6997: OUTPUT BY-REFERENCE records are not cleared
The problem in this task still exists. Constantin Asofiei
03:46 AM Base Language Bug #8427 (Merge Pending): LOG-MANAER:CLOSE-LOG does not reset the enabled state
This is fixed in 8237a rev 15043. Constantin Asofiei
03:31 AM Base Language Bug #8427: LOG-MANAER:CLOSE-LOG does not reset the enabled state
You're right, put it after that. Galya B
03:28 AM Base Language Bug #8427: LOG-MANAER:CLOSE-LOG does not reset the enabled state
I think @isEnabled.set(false);@ needs to be after @if (isAppserver && isProcedureCall)@, correct? I'll use 8237a. Constantin Asofiei
03:21 AM Base Language Bug #8427: LOG-MANAER:CLOSE-LOG does not reset the enabled state
I've tested it and it works fine with the change. Galya B
03:21 AM Base Language Bug #8427: LOG-MANAER:CLOSE-LOG does not reset the enabled state
I've missed that @close@ modifies @logFile@ and @isEnabled@ should be updated. Can you add this new line @isEnabled.s... Galya B

03/10/2024

01:41 PM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
Constantin Asofiei wrote:
> Alexandru, is 7045c still needed after we refactored the query management to be inside B...
Alexandru Lungu
07:29 AM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception
Alexandru, is 7045c still needed after we refactored the query management to be inside BlockManager? If not, please a... Constantin Asofiei
 

Also available in: Atom