FWD

04/18/2024

06:07 PM Support #8547: Fix documentation for Non-Standard Save Cache Implementation

Tijs, while I was in the doc for #8653, I reviewed your changes. I updated the UDFs section to point to the existing ... Eric Faulhaber

06:44 AM Base Language Feature #6424: fill gaps in Java Open Client replacement (appserver client support)

This is the server log of errors. Galya B

06:11 AM Runtime Infrastructure Feature #6692: move FWD to Java 17

Tomasz Domin wrote:
> Galya B wrote:
> > The libraries in concern in r15171 are used only by custom front-ends in t... Galya B

05:47 AM Runtime Infrastructure Feature #6692: move FWD to Java 17

Tomasz Domin wrote:
> Galya B wrote:
> > Greg Shah wrote:
> > > Galya: Please review 6692a revision 15171.
> >
... Galya B

05:28 AM Runtime Infrastructure Feature #6692: move FWD to Java 17

Greg Shah wrote:
> Code Review Task Branch 6692a Revision 15171
>
> Although I do like managing the dependencies ... Tomasz Domin

04:53 AM Runtime Infrastructure Feature #6692: move FWD to Java 17

Galya B wrote:
> I think this is not related to the current upgrade to java 17. Do you mind to create a new task for... Hynek Cihlar

04:38 AM Runtime Infrastructure Feature #6692: move FWD to Java 17

Hynek Cihlar wrote:
> Galya B wrote:
> > Hynek Cihlar wrote:
> > > I agree with the comments from Greg and Galya. ... Galya B

04:37 AM Runtime Infrastructure Feature #6692: move FWD to Java 17

Galya B wrote:
> Hynek Cihlar wrote:
> > I agree with the comments from Greg and Galya. Still it makes sense to put... Hynek Cihlar

04:23 AM Runtime Infrastructure Feature #6692: move FWD to Java 17

Hynek Cihlar wrote:
> I agree with the comments from Greg and Galya. Still it makes sense to put the dependencies th... Galya B

04:15 AM Runtime Infrastructure Feature #6692: move FWD to Java 17

I agree with the comments from Greg and Galya. Still it makes sense to put the dependencies that are integral part of... Hynek Cihlar

03:28 AM Runtime Infrastructure Feature #6692: move FWD to Java 17

Greg Shah wrote:
> Galya: Please review 6692a revision 15171.
@fwd_sdk.js@ is not the right place to load the lib... Galya B

04:53 AM Runtime Infrastructure Feature #8651: Centralize inclusion of JS dependencies

There are specific Java Script dependencies needed for FWD to run in embedded mode. If they are included in a single ... Hynek Cihlar

04:50 AM Runtime Infrastructure Feature #8651 (New): Centralize inclusion of JS dependencies

Hynek Cihlar

04/17/2024

05:24 PM Runtime Infrastructure Feature #6692: move FWD to Java 17

Galya: Please review 6692a revision 15171. Greg Shah

05:23 PM Runtime Infrastructure Feature #6692: move FWD to Java 17

Code Review Task Branch 6692a Revision 15171
Although I do like managing the dependencies explicitly in our JS cod... Greg Shah

03:42 PM Runtime Infrastructure Feature #6692: move FWD to Java 17

Roger Borrello wrote:
> Tomasz Domin wrote:
> > I work with separate images for each supported java version if you... Tomasz Domin

03:34 PM Runtime Infrastructure Feature #6692: move FWD to Java 17

Tomasz Domin wrote:
> I work with separate images for each supported java version if you remember thats why I neede... Roger Borrello

01:02 PM Runtime Infrastructure Feature #6692: move FWD to Java 17

Roger Borrello wrote:
> I have some basic questions, since this task is moving steadily towards implementation. Grea... Tomasz Domin

11:38 AM Runtime Infrastructure Feature #6692: move FWD to Java 17

Greg Shah wrote:
> > Do we need Docker images based off both
>
> Yes
>
> > or do we make a wholesale changeov... Roger Borrello

10:41 AM Runtime Infrastructure Feature #6692: move FWD to Java 17

Greg Shah wrote:
> > OpenJDK or Oracle?
>
> In the code we should not have dependencies on either one.
>
> In ... Roger Borrello

10:23 AM Runtime Infrastructure Feature #6692: move FWD to Java 17

> OpenJDK or Oracle?
In the code we should not have dependencies on either one.
In practive, we tend to use Ope... Greg Shah

10:11 AM Runtime Infrastructure Feature #6692: move FWD to Java 17

I have some basic questions, since this task is moving steadily towards implementation. Great job! These come from my... Roger Borrello

09:01 AM Runtime Infrastructure Feature #6692: move FWD to Java 17

Code review 6692a revision 15171. The changes look good. Hynek Cihlar

05:07 AM Runtime Infrastructure Feature #6692: move FWD to Java 17

Hynek Cihlar wrote:
> Greg Shah wrote:
> > Hynek: What would you estimate for the effort?
>
> I would say up to ... Tomasz Domin

02:04 PM Runtime Infrastructure Feature #7799: automated vulnerability scanning

A report for FWD @6692a/15172@, there should be less vulnerabilities, but in meantime a new ones has been discovered ... Tomasz Domin

01:49 PM Database Bug #8648: Recheck ACTIVATE and DEACTIVATE procedures on appserver calls

This task is a continuation of 8444d (merged to trunk as rev. 15153) to investigate all @invoke*@ methods from the @A... Alexandru Lungu

01:48 PM Database Bug #8648 (Closed): Recheck ACTIVATE and DEACTIVATE procedures on appserver calls

Alexandru Lungu

09:36 AM Base Language Feature #6424: fill gaps in Java Open Client replacement (appserver client support)

There are some failing tests. Is it the deployment or it's fine? Galya B

09:00 AM Base Language Bug #8643: ErrorManager not handling caught errors and error-status:error attribute properly

This issue is a continuation of #8614 that involves two problems that need to be solved. I've attached 4 files:
* ra... Dănuț Filimon

08:54 AM Base Language Bug #8643 (Test): ErrorManager not handling caught errors and error-status:error attribute properly

Dănuț Filimon

04/16/2024

11:43 AM Runtime Infrastructure Feature #6692: move FWD to Java 17

Hynek Cihlar wrote:
> Greg Shah wrote:
> > Hynek: What would you estimate for the effort?
>
> I would say up to ... Tomasz Domin

08:06 AM Runtime Infrastructure Feature #6692: move FWD to Java 17

Greg Shah wrote:
> Hynek: What would you estimate for the effort?
I would say up to two days. The JS dependencies... Hynek Cihlar

07:38 AM Runtime Infrastructure Feature #6692: move FWD to Java 17

Hynek: What would you estimate for the effort? Greg Shah

07:28 AM Runtime Infrastructure Feature #6692: move FWD to Java 17

Greg Shah wrote:
> I prefer not to leave old dependencies in the code. On the other hand, I don't want to delay thi... Tomasz Domin

02:05 AM Runtime Infrastructure Feature #6692: move FWD to Java 17

Greg Shah wrote:
> Hynek: What do you think?
I like the idea of having the dependencies in @fwd_sdk.js@. Moving t... Hynek Cihlar

04/15/2024

05:47 PM Runtime Infrastructure Feature #6692: move FWD to Java 17

I prefer not to leave old dependencies in the code. On the other hand, I don't want to delay this branch since many ... Greg Shah

03:06 PM Runtime Infrastructure Feature #6692: move FWD to Java 17

Rebased 6692a to trunk/15146 and pushed 6692a/15146.
I started to work on JS updates, upgraded with webjars versio... Tomasz Domin

07:03 AM Base Language Feature #6407: name_map.xml improvements

6407a rebased on trunk r15146.
New r15156 with a minor fix for #8166-151. Galya B

02:19 AM Base Language Feature #6407: name_map.xml improvements

Reminder: The branch needs a review (at r15110). It also has minor changes for #8166-145 and #8166-150. Galya B

03:45 AM Runtime Infrastructure Bug #8383 (Review): Some JsonObject methods create a LOG-MANAGER record in silent

Constantin Asofiei wrote:
> Galya, some notes:
> * we need to be careful with naming FWD internal methods added to ... Galya B

04/12/2024

01:51 PM Testing Support #7850: questions and answers about ABLUnit support in FWD

I get this when the converted test suite (1 test) tries to compile:... Roger Borrello

01:45 PM User Interface Bug #7657: 8-bit character entry problem in ChUI

Greg Shah wrote:
> Good work!
>
> Some thoughts:
>
> * We should add a build-time option to control whether th... Eugenie Lyzenko

06:47 AM User Interface Bug #7657: 8-bit character entry problem in ChUI

Good work!
Some thoughts:
* We should add a build-time option to control whether the native module will use wid... Greg Shah

09:33 AM Runtime Infrastructure Bug #8624: Stream should detect whether it is being used from the client or the server

@Stream@ is "dual mode" and is used as a base class for @RemoteStream@ which is used from converted code on the serve... Greg Shah

08:55 AM Runtime Infrastructure Bug #8624: Stream should detect whether it is being used from the client or the server

@Stream.java@ is being used by both the server and the client, however some functions are OS dependent and this is no... Șerban Bursuc

08:47 AM Runtime Infrastructure Bug #8624 (Closed): Stream should detect whether it is being used from the client or the server

Șerban Bursuc

04/11/2024

04:46 PM User Interface Bug #7657: 8-bit character entry problem in ChUI

The news so far.
After experimenting I would like to share some finding at this time. For minimal usage we need to... Eugenie Lyzenko

01:06 PM User Interface Bug #7657: 8-bit character entry problem in ChUI

Greg Shah wrote:
> It must be something pulled over from the Hotel GUI directory. In October 2023, Galya implemente... Eugenie Lyzenko

12:23 PM User Interface Bug #7657: 8-bit character entry problem in ChUI

It must be something pulled over from the Hotel GUI directory. In October 2023, Galya implemented single signon for ... Greg Shah

12:16 PM User Interface Bug #7657: 8-bit character entry problem in ChUI

Guys,
During testing Hotel ChUI with wide chars environment I'm getting the following warning when starting server... Eugenie Lyzenko

03:56 PM Database Bug #8621: better resolution of ambiguous constructors/methods in RuntimeJastInterpreter

The caching mechanism is in place since the early implementation. Since the structure of the JAST in which the constr... Ovidiu Maxiniuc

01:07 PM Database Bug #8621: better resolution of ambiguous constructors/methods in RuntimeJastInterpreter

What we need to implement for method/constructor matching is actually the Java compiler's algorithm for linking the c... Constantin Asofiei

12:59 PM Database Bug #8621: better resolution of ambiguous constructors/methods in RuntimeJastInterpreter

@RuntimeJastInterpreter.findMatchingConstructor@ currently returns @null@ when it finds more than one c'tor whose sig... Eric Faulhaber

12:26 PM Database Bug #8621 (New): better resolution of ambiguous constructors/methods in RuntimeJastInterpreter

Eric Faulhaber

08:47 AM Runtime Infrastructure Feature #6692: move FWD to Java 17

Rebased to trunk/15136, pushed into repository 6692/15156
Working on JS libraries updates.
Tomasz Domin

04/10/2024

02:38 PM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'

Just a thing that was on my mind and wanted to have it here as well:
For NO-UNDO cases, we used to rollback (trans... Alexandru Lungu

01:25 PM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'

Alexandru Lungu wrote:
> Eric, even for a sub-transaction. We can simply delete and rollback to savepoint, right?
... Eric Faulhaber

12:04 PM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'

Eric, even for a sub-transaction. We can simply delete and rollback to savepoint, right? Alexandru Lungu

11:29 AM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'

Greg Shah wrote:
> Seems like a long-standing leak of records. If that built up to a large number, it might be both... Eric Faulhaber

08:52 AM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'

Seems like a long-standing leak of records. If that built up to a large number, it might be both a memory leak and a... Greg Shah

07:59 AM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'

Alexandru Lungu wrote:
> Still, why are we updating with a @<delete-multiplex>@ instead of actually deleting them? I... Eric Faulhaber

07:30 AM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'

> For MultiplexedScanIndex, the target batch in setRow(key, row) is calculated from the record's key (which is not ch... Alexandru Lungu

06:46 AM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'

No, the @empty-temp-table@ is the problem, while executing in a transaction, for an undoable temp-table - this does n... Constantin Asofiei

06:41 AM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'

Constantin Asofiei wrote:
> For an undoable temp-table, a @EMPTY-TEMP-TABLE@ results in a @UPDATE tt1 SET _multiplex... Alexandru Lungu

05:11 AM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'

The recreate is this:
* @mpid1.p@... Constantin Asofiei

03:59 AM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'

Constantin Asofiei wrote:
> Alexandru, the assumption was that the @MultiplexedBatchIndex$Batch@ holds data *only fo... Alexandru Lungu

04/09/2024

01:07 PM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'

Alexandru, the assumption was that the @MultiplexedBatchIndex$Batch@ holds data *only for a certain multiplex*. This... Constantin Asofiei

10:26 AM Runtime Infrastructure Bug #8607: Incorrect parsing of URI string.

Given the investigation conducted in #8367-15, current implementation of URI parsing should be reconsidered. Eduard Soltan

10:23 AM Runtime Infrastructure Bug #8607 (New): Incorrect parsing of URI string.

Eduard Soltan

04/08/2024

03:40 PM Database Bug #7473: rewrite toString() implementation for Dataset, StaticTempTable and TempTableBuilder to...

@WRITE-JSON@ will always leave the current/working buffer empty when it is finished, causing it content to be eventua... Ovidiu Maxiniuc

02:48 PM Database Bug #7473 (WIP): rewrite toString() implementation for Dataset, StaticTempTable and TempTableBuil...

Ovidiu, are you aware if the @WRITE-JSON@ was finally rewritten without side-effects? Otherwise, Eduard B. can pick i... Alexandru Lungu

10:04 AM User Interface Bug #8598: Frame has no scrollbars

Example:... Vladimir Tsichevski

10:02 AM User Interface Bug #8598 (New): Frame has no scrollbars

Vladimir Tsichevski

05:19 AM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'

Constantin Asofiei wrote:
> You mean the Row.key is not the same as the internal PK?
I mean Row.key to be the same ... Constantin Asofiei

05:15 AM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'

You mean the Row.key is not the same as the internal PK?
Also, there is 'recid' index (with just this column) in H... Constantin Asofiei

04:45 AM Database Bug #8593: H2 performance improvement for table 'truncate by multiplex'

> Created task branch 8593a_h2 which improves the @DELETE FROM tt1 WHERE tt1._multiplex = ?@. The reasoning is this:... Alexandru Lungu

03:08 AM Database Bug #8593 (Review): H2 performance improvement for table 'truncate by multiplex'

Created task branch 8593a_h2 which improves the @DELETE FROM tt1 WHERE tt1._multiplex = ?@. The reasoning is this:
... Constantin Asofiei

02:56 AM Database Bug #8593 (Test): H2 performance improvement for table 'truncate by multiplex'

Constantin Asofiei

08:34 PM Database Bug #8554 (Test): resolving temp-tables in a class hierarchy

Greg Shah

04/06/2024

01:41 PM Database Bug #8554: resolving temp-tables in a class hierarchy

Branch 8554a was merged into trunk as rev. 15125 and archived. Constantin Asofiei

12:40 PM Database Bug #8554: resolving temp-tables in a class hierarchy

You can merge to trunk now.
Hynek: 8152a can merge after 8554a. Greg Shah

03:15 AM Database Bug #8554 (Merge Pending): resolving temp-tables in a class hierarchy

Ovidiu, I've fixed the visibility in rev 15127 (after rebase).
ETF testing passed. It can be merged to trunk. Constantin Asofiei

04/05/2024

06:11 PM Database Bug #8589: Deprecate the shared temporary database completely

Unless there is a _significant_ memory savings or some other substantial advantage of shared mode, I think we should ... Eric Faulhaber

03:45 AM Database Bug #8589: Deprecate the shared temporary database completely

In the original support for _temp database, one single in-memory database was created. All sessions used that single ... Alexandru Lungu

03:05 AM Database Bug #8589 (New): Deprecate the shared temporary database completely

Alexandru Lungu

04/04/2024

06:39 PM Database Bug #8554: resolving temp-tables in a class hierarchy

Review of 8554a, r15120-15122.
I am OK with the code. I'm sorry I made a mess with condition codes which do and do... Ovidiu Maxiniuc

04:21 PM Database Bug #8554: resolving temp-tables in a class hierarchy

Ovidiu, please review this, I'll get ETF testing tomorrow and if is OK, I'd like to merge this tomorrow. Constantin Asofiei

07:41 AM Database Bug #8554 (Review): resolving temp-tables in a class hierarchy

15122 fixes some issues, javadocs and some errors which must not set ERROR-STATUS:ERROR. This can be reviewed.
I'... Constantin Asofiei

05:31 AM Database Bug #8554 (WIP): resolving temp-tables in a class hierarchy

Created task branch 8554a from trunk rev 15119.
15120 and 15121 has a rough fix for this - need to validate it. Constantin Asofiei

05:26 PM Base Language Bug #8579 (Test): Unit and OEUnit conversion: ignore annotations from other framework

Greg Shah

05:21 PM Base Language Bug #8579: Unit and OEUnit conversion: ignore annotations from other framework

Greg Shah wrote:
> You can merge 8579a to trunk now.
Done. Rev. 15123. Vladimir Tsichevski

04:23 PM Base Language Bug #8579 (Merge Pending): Unit and OEUnit conversion: ignore annotations from other framework

You can merge 8579a to trunk now. Greg Shah

01:14 PM Base Language Bug #8579: Unit and OEUnit conversion: ignore annotations from other framework

Greg Shah wrote:
> Code Review Task Branch 8579a Revision 15121
>
> The change is good.
>
> What additional te... Vladimir Tsichevski

12:58 PM Base Language Bug #8579: Unit and OEUnit conversion: ignore annotations from other framework

Code Review Task Branch 8579a Revision 15121
The change is good.
What additional testing is needed? Greg Shah

11:20 AM Base Language Bug #8579: Unit and OEUnit conversion: ignore annotations from other framework

Greg Shah wrote:
> Code Review Task Branch 8579a Revision 15120
>
> I think the code would be simpler and easier ... Vladimir Tsichevski

12:12 PM Base Language Feature #6407: name_map.xml improvements

I did replace the @Set@ with @List@ in r15108.
Tomorrow I'm testing again in testcases. A good list of different p... Galya B

11:45 AM Base Language Feature #6407: name_map.xml improvements

@MultiClassLoader@:... Galya B

11:43 AM Base Language Feature #6407: name_map.xml improvements

So what I'm saying is that there is no classpath order in my humble opinion. Iterating HashMap is not ordered. Galya B

11:39 AM Base Language Feature #6407: name_map.xml improvements

Greg Shah wrote:
> > > @MultiClassLoader@ finds the class by iterating @HashSet@.
> > Actually it's a collection, ... Galya B

11:32 AM Base Language Feature #6407: name_map.xml improvements

> > @MultiClassLoader@ finds the class by iterating @HashSet@.
> Actually it's a collection, backed by the @HashMap... Greg Shah

11:20 AM Base Language Feature #6407 (Review): name_map.xml improvements

6407a r15107 based on trunk r15101 ready for review: adds support for reading mappings from multiple name_map.xml fil... Galya B

09:57 AM Base Language Feature #6407: name_map.xml improvements

Galya B wrote:
> @MultiClassLoader@ finds the class by iterating @HashSet@.
Actually it's a collection, backed by ... Galya B

09:42 AM Base Language Feature #6407: name_map.xml improvements

We can rework it to iterate jars alphabetically. Galya B

09:39 AM Base Language Feature #6407: name_map.xml improvements

Constantin Asofiei wrote:
> My understanding is that JVM keeps the same order of jars as defined in classpath (it do... Galya B

09:37 AM Base Language Feature #6407: name_map.xml improvements

Galya B wrote:
> Greg Shah wrote:
> > Do we really need an explicit list of precedence order? Why not implicitly t... Constantin Asofiei

09:29 AM Base Language Feature #6407: name_map.xml improvements

Greg Shah wrote:
> Do we really need an explicit list of precedence order? Why not implicitly take it from the clas... Galya B

09:28 AM Base Language Feature #6407: name_map.xml improvements

Do we really need an explicit list of precedence order? Why not implicitly take it from the classpath and honor the ... Greg Shah

09:21 AM Base Language Feature #6407: name_map.xml improvements

Constantin Asofiei wrote:
> From what you posted in #6407-56, only one concern: the granularity for the precedence o... Galya B

05:45 AM Base Language Feature #6407: name_map.xml improvements

From what you posted in #6407-56, only one concern: the granularity for the precedence order I think needs to be "thi... Constantin Asofiei

04:39 AM Base Language Feature #6407: name_map.xml improvements

P.S. The previous comment got updated. Galya B

04:36 AM Base Language Feature #6407: name_map.xml improvements

Constantin Asofiei wrote:
> And I think I understand now Greg's point about the .r and folder deploy in OpenEdge:
>... Galya B

09:09 AM User Interface Bug #8586: Fields are not in FIELD-GROUP until they are enabled

The program:... Vladimir Tsichevski

09:02 AM User Interface Bug #8586 (Test): Fields are not in FIELD-GROUP until they are enabled

Vladimir Tsichevski

04/03/2024

06:05 PM Base Language Bug #8579 (Internal Test): Unit and OEUnit conversion: ignore annotations from other framework

Code Review Task Branch 8579a Revision 15120
I think the code would be simpler and easier to read if you create a ... Greg Shah

03:11 PM Base Language Bug #8579 (Review): Unit and OEUnit conversion: ignore annotations from other framework

Fixed in 8579a rev. 15120. Please, review. Vladimir Tsichevski

03:10 PM Base Language Bug #8579 (WIP): Unit and OEUnit conversion: ignore annotations from other framework

Vladimir Tsichevski

02:51 PM Base Language Bug #8579: Unit and OEUnit conversion: ignore annotations from other framework

Currently, if a test 4gl source includes both ABLUnit annotations and OEUnit annotations, all these annotations are c... Vladimir Tsichevski

02:46 PM Base Language Bug #8579 (Test): Unit and OEUnit conversion: ignore annotations from other framework

Vladimir Tsichevski

04:52 PM User Interface Bug #8353: Fully support stanza INI LOAD/USE/UNLOAD scenarios

The failure was because I didn't include @support/test/AssertExt.cls@ in the conversion file. Now I get:... Roger Borrello

03:08 PM Base Language Feature #6407: name_map.xml improvements

And I think I understand now Greg's point about the .r and folder deploy in OpenEdge:
* in FWD, you would convert th... Constantin Asofiei

02:34 PM Base Language Feature #6407: name_map.xml improvements

Greg Shah wrote:
> > But, in practice, I think .pl archives are used more - and depending on the PROPATH, runtime co... Constantin Asofiei

02:29 PM Base Language Feature #6407: name_map.xml improvements

> But, in practice, I think .pl archives are used more - and depending on the PROPATH, runtime could use a .p from di... Greg Shah

02:26 PM Base Language Feature #6407: name_map.xml improvements

We had cases of the same OE qualified class name used in different modules. The qualified legacy name can't be chang... Constantin Asofiei

01:28 PM Base Language Feature #6407: name_map.xml improvements

To solve case 2. we need the precedence order to be fed to the jmv via startup args, so that the classloader can take... Galya B

01:09 PM Base Language Feature #6407: name_map.xml improvements

Galya B wrote:
> I speak about case 3: different maps for different files with different attributes. Obviously if yo... Galya B

01:08 PM Base Language Feature #6407: name_map.xml improvements

I speak about case 3: different maps for different files with different attributes, but same path. Obviously if you l... Galya B

01:02 PM Base Language Feature #6407: name_map.xml improvements

> This is not something we can decide even with configs and Constantin was right that it is a major issue.
Case 1 ... Greg Shah

12:58 PM Base Language Feature #6407: name_map.xml improvements

One pname corresponds to only one jname, because that's how conversion seems to work. The question is if the other at... Galya B

11:36 AM Base Language Feature #6407: name_map.xml improvements

Galya B wrote:
> Other than that the jar can have a completely different package for the actual classes.
Actually n... Galya B

11:34 AM Base Language Feature #6407: name_map.xml improvements

If we need to load the jars in a specific order, we'll need explicit instructions, probably new config in directory. Galya B

11:32 AM Base Language Feature #6407: name_map.xml improvements

Case 2 is the same as java and can cause malfunctioning programs like in java, this is what I meant.
Case 1 is fine ... Galya B

11:20 AM Base Language Feature #6407: name_map.xml improvements

> In java this is the same as having multiple versions of the same dependency in the classpath.
Not exactly. In... Greg Shah

11:14 AM Base Language Feature #6407: name_map.xml improvements

> If you are saying that module M1 has a program foo/bar/F.p and module M2 has a program foo/bar/F.p. which are compl... Greg Shah

11:12 AM Base Language Feature #6407: name_map.xml improvements

This is actually more complicated than it looked at first. We're trying to combine different apps coming possibly fro... Galya B

11:03 AM Base Language Feature #6407: name_map.xml improvements

Greg Shah wrote:
> Let's consider this from the perspective of how it works for this multi-app case in OE. If both ... Constantin Asofiei

10:55 AM Base Language Feature #6407: name_map.xml improvements

Originally (currently) if multiple paths are found for the same filename when resolving the name map, the paths end u... Galya B

10:45 AM Base Language Feature #6407: name_map.xml improvements

> The 'pname' in @class-mapping@ is the full path relative to the @abl/@ folder
Yes, this is why I called them rel... Greg Shah

10:30 AM Base Language Feature #6407: name_map.xml improvements

Greg Shah wrote:
> > > And all of this just for a warning log? I would say it's more reasonable to log the warning a... Constantin Asofiei

10:26 AM Base Language Feature #6407: name_map.xml improvements

I don't have an actual example though. Not sure if the path is supposed to be the same in two different jars. Galya B

10:25 AM Base Language Feature #6407: name_map.xml improvements

Greg Shah wrote:
> > > And all of this just for a warning log? I would say it's more reasonable to log the warning a... Galya B

10:23 AM Base Language Feature #6407: name_map.xml improvements

> > And all of this just for a warning log? I would say it's more reasonable to log the warning always when a second ... Greg Shah

06:16 AM Base Language Feature #6407: name_map.xml improvements

> REST services written directly in Java can be configured via the 'rest-service' element.
So these nodes are not ... Constantin Asofiei

06:06 AM Base Language Feature #6407: name_map.xml improvements

OK, then I need one more clarification. Since there is a separate container @rest-service@, where programs get resolv... Galya B

06:00 AM Base Language Feature #6407: name_map.xml improvements

Yes. Constantin Asofiei

05:57 AM Base Language Feature #6407: name_map.xml improvements

Constantin Asofiei wrote:
> Galya B wrote:
> > And all of this just for a warning log? I would say it's more reason... Galya B

05:57 AM Base Language Feature #6407: name_map.xml improvements

Galya B wrote:
> And all of this just for a warning log? I would say it's more reasonable to log the warning always ... Constantin Asofiei

05:53 AM Base Language Feature #6407: name_map.xml improvements

Constantin Asofiei wrote:
> Galya B wrote:
> > Constantin, maybe you've missed why I'm assigned to the task, that i... Galya B

05:49 AM Base Language Feature #6407: name_map.xml improvements

Galya B wrote:
> Constantin, maybe you've missed why I'm assigned to the task, that is in #6407-4.
OK, thanks for t... Constantin Asofiei

05:49 AM Base Language Feature #6407: name_map.xml improvements

Constantin Asofiei wrote:
> The point was to move to annotations/other structures inside the .java
Constantin, ... Galya B

05:43 AM Base Language Feature #6407: name_map.xml improvements

The point was to move to annotations/other structures inside the .java, here I mean all info from name_map.xml; ideal... Constantin Asofiei

05:33 AM Base Language Feature #6407: name_map.xml improvements

Constantin Asofiei wrote:
> I don't mean the annotations in the .class - I mean the state from name_map.xml must mat... Galya B

05:22 AM Base Language Feature #6407: name_map.xml improvements

I don't mean the annotations in the .class - I mean the state from name_map.xml must match if there is an existing en... Constantin Asofiei

03:55 AM Base Language Feature #6407: name_map.xml improvements

Constantin Asofiei wrote:
> * load them into @SourceNameMapper@, one by one, and address conflicts - if there are co... Galya B

05:26 AM Base Language Bug #8510: replace all 'new logical' in FWD runtime with logical.of or logical.UNKNOWN

8150a was merged to trunk rev 15116 and archived. Constantin Asofiei

05:26 AM Base Language Bug #8510: replace all 'new logical' in FWD runtime with logical.of or logical.UNKNOWN

Created task branch 8510a from trunk rev 15115. In rev 15116 I removed the @logical.of@ and @logical.UNKNOWN@ from R... Constantin Asofiei

04/02/2024

05:15 PM User Interface Bug #8260: treelist sorting column with null and empty string values does not produce correct result

Șerban Bursuc wrote:
> As for issue 2, I don't understand whether OE just refuses to sort the column, or it doesn'... Vladimir Tsichevski

10:30 AM User Interface Bug #8260: treelist sorting column with null and empty string values does not produce correct result

Sorry for the random assignment, it was **not** intentional. Șerban Bursuc

10:27 AM User Interface Bug #8260: treelist sorting column with null and empty string values does not produce correct result

Vladimir Tsichevski wrote:
> As I see this:
>
> # If a string tree column has non-empty values, empty string valu... Șerban Bursuc

10:11 AM User Interface Bug #8260: treelist sorting column with null and empty string values does not produce correct result

As I see this:
# If a string tree column has non-empty values, empty string values and unknown values, when expect... Vladimir Tsichevski

09:57 AM User Interface Bug #8260: treelist sorting column with null and empty string values does not produce correct result

Vladimir Tsichevski wrote:
> Șerban Bursuc wrote:
>
> > As for what's different, it's a bit more apparent from th... Șerban Bursuc

09:56 AM User Interface Bug #8260: treelist sorting column with null and empty string values does not produce correct result

Șerban Bursuc wrote:
> As for what's different, it's a bit more apparent from the screenshots in #8039-39
There i... Vladimir Tsichevski

09:28 AM User Interface Bug #8260: treelist sorting column with null and empty string values does not produce correct result

Vladimir Tsichevski wrote:
> I reproduced the situation using @5084.p@, and I found no difference between OE and FWD... Șerban Bursuc

08:23 AM User Interface Bug #8260 (Feedback): treelist sorting column with null and empty string values does not produce ...

I reproduced the situation using @5084.p@, and I found no difference between OE and FWD. What is wrong with FWD? Vladimir Tsichevski

04/01/2024

06:41 PM Base Language Bug #8154: refactor scopeable stacks

Code Review Task Branch 8154a Revision 15109
The changes look promising. There is clearly quite a bit more that c... Greg Shah

12:51 PM Base Language Bug #8154 (WIP): refactor scopeable stacks

Created task branch 8154a from trunk rev 15108.
Rev 15109 contains first pass at moving scoped stacks into (TopLev... Constantin Asofiei

06:41 PM User Interface Bug #8260: treelist sorting column with null and empty string values does not produce correct result

Șerban Bursuc wrote:
> Using the @TreeList@ testcase:
>
> We add nodes with the following cell values
>
> [...... Vladimir Tsichevski

01:46 PM User Interface Bug #8556: Incorrect frame layout

The issue exists at least since the trunk rev. 14857, so it is not a recent regression. Vladimir Tsichevski

01:26 PM User Interface Bug #8556: Incorrect frame layout

The following example:... Vladimir Tsichevski

01:21 PM User Interface Bug #8556 (New): Incorrect frame layout

Vladimir Tsichevski

08:49 AM Database Bug #8554: resolving temp-tables in a class hierarchy

@DATASET:CREATE-LIKE("<dataset-name>")@ needs to be checked, too. Constantin Asofiei

08:02 AM Runtime Infrastructure Bug #8383: Some JsonObject methods create a LOG-MANAGER record in silent

Constantin Asofiei wrote:
> * in OE, SysError is used for internal errors (via ErrorManager for FWD). But, there is... Galya B

05:21 AM Runtime Infrastructure Bug #8383 (WIP): Some JsonObject methods create a LOG-MANAGER record in silent

Constantin Asofiei wrote:
> * in OE, SysError is used for internal errors (via ErrorManager for FWD). But, there is... Galya B

05:09 AM Runtime Infrastructure Bug #8383: Some JsonObject methods create a LOG-MANAGER record in silent

Galya, some notes:
* we need to be careful with naming FWD internal methods added to skeleton classes/interfaces (in... Constantin Asofiei

04:00 AM Base Language Feature #6424: fill gaps in Java Open Client replacement (appserver client support)

Galya, I've placed the project under @devsrv01:/tmp/open_client_example.zip@. There is a small readme.txt in the pro... Constantin Asofiei

03/31/2024

10:35 AM Database Bug #8554: resolving temp-tables in a class hierarchy

There are some problems when resolving temp-tables in a hierarchy.
* @oo.Test1@:... Constantin Asofiei

10:28 AM Database Bug #8554 (Test): resolving temp-tables in a class hierarchy

Constantin Asofiei

03/29/2024

01:23 PM User Interface Bug #7657: 8-bit character entry problem in ChUI

I am open to trying out and testing any FWD changes here on my end. Let me know if I can help in any way. I have work... Robert Jensen

06:39 AM User Interface Bug #7657: 8-bit character entry problem in ChUI

Robert Jensen wrote:
> The comand line is actually:
> ./client-terminal.sh client:cmd-line-option:startup-procedure... Greg Shah

06:26 AM User Interface Bug #7657: 8-bit character entry problem in ChUI

> I may have missed a step here. I am running from Intellij, which I did restart after the changes to .bashrd But may... Greg Shah

06:17 AM User Interface Bug #7657: 8-bit character entry problem in ChUI

In #7657-5, I mentioned some changes that were needed. Let me make it more clear: these changes that are needed are ... Greg Shah

10:57 AM Base Language Feature #6407: name_map.xml improvements

Galya B wrote:
> @SourceNameMapper.initMappingData@ seems to be executed only once for the lifespan of the runtime m... Constantin Asofiei

10:20 AM Base Language Feature #6407 (WIP): name_map.xml improvements

6407a created from trunk r15101. Galya B

10:03 AM Base Language Feature #6407: name_map.xml improvements

@SourceNameMapper.initMappingData@ seems to be executed only once for the lifespan of the runtime machine with a serv... Galya B

09:46 AM Base Language Feature #6407: name_map.xml improvements

Constantin Asofiei wrote:
> Also, SourceNameMapper will not load the .class and annotations when the entry in @name_... Galya B

09:45 AM Base Language Feature #6407: name_map.xml improvements

Constantin Asofiei wrote:
> Java has tools to read an archive.
If you mean the custom FWD's @JarClassLoader@, then ... Galya B

09:38 AM Base Language Feature #6407: name_map.xml improvements

You don't need to unzip the jar - Java has tools to read an archive. This just means we can't rely on @Class.getReso... Constantin Asofiei

09:37 AM Base Language Feature #6407: name_map.xml improvements

Why can't we use the same technique from @Utils.searchResourceJars()@? We don't need the propath part but we definit... Greg Shah

09:29 AM Base Language Feature #6407: name_map.xml improvements

That is of course if the check for the file listed by @jar tvf filename.jar@ gives positive. Galya B

09:27 AM Base Language Feature #6407: name_map.xml improvements

Constantin Asofiei wrote:
> Galya, what package would you use for looking into multiple jars? Look everywhere? The ... Galya B

08:41 AM Base Language Feature #6407: name_map.xml improvements

Galya, what package would you use for looking into multiple jars? Look everywhere? The problem with @name_map.xml@ i... Constantin Asofiei

08:31 AM Base Language Feature #6407: name_map.xml improvements

> @MultiClassLoader@ has a list of all jars in the classpath. It can look for @name_map.xml@ in each jar (with @jar t... Greg Shah

07:08 AM Base Language Feature #6407: name_map.xml improvements

@MultiClassLoader@ has a list of all jars in the classpath. It can look for @name_map.xml@ in each jar (with @jar tvf... Galya B

08:50 AM Support #8547 (Review): Fix documentation for Non-Standard Save Cache Implementation

Changes to wiki completed.
Eric, please review.
Tijs Wickardt

08:16 AM Support #8547 (WIP): Fix documentation for Non-Standard Save Cache Implementation

Tijs Wickardt

08:16 AM Support #8547: Fix documentation for Non-Standard Save Cache Implementation

This task is about [[p2j:Non-Standard Save Cache Implementation]] .
Tijs will do the required changes, Eric needs to... Tijs Wickardt

08:13 AM Support #8547 (Review): Fix documentation for Non-Standard Save Cache Implementation

Tijs Wickardt

07:42 AM Runtime Infrastructure Feature #6692: move FWD to Java 17

Greg Shah wrote:
> Did you test both embedded mode and virtual desktop in Hotel GUI?
>
Yes, I did
> Did you test... Tomasz Domin

04:44 AM Runtime Infrastructure Feature #6692: move FWD to Java 17

It would be interesting to profile a test case with both Java 8 and Java 17 and see where the times differ. Having mo... Hynek Cihlar

06:16 AM Base Language Feature #6431: implement support to allow CPINTERNAL set to UTF-8 and CP936

I know some work has happened to explore I18N testcases. Having proper testcases will be very important.
I want t... Greg Shah

03:16 AM Runtime Infrastructure Feature #8544: Move spawner code to JNI

The spawner executable exists as a separate deployment with the sole purpose of providing admin rights only to a stri... Galya B

02:51 AM Runtime Infrastructure Feature #8544 (New): Move spawner code to JNI

Galya B

03/28/2024

06:49 PM User Interface Bug #7657: 8-bit character entry problem in ChUI

The comand line is actually:
./client-terminal.sh client:cmd-line-option:startup-procedure=com/<app_path>/ClientBoot... Robert Jensen

05:45 PM User Interface Bug #7657: 8-bit character entry problem in ChUI

I fianally got around to trying the ncurses update. No change. The setup_ncurses6x.sh script did appear to work corre... Robert Jensen

05:13 PM Runtime Infrastructure Feature #6692: move FWD to Java 17

Yes, this can be found in #8208-18. A summary for those that can't access that task:
> * Java 8 is faster than Ja... Greg Shah

04:05 PM Runtime Infrastructure Feature #6692: move FWD to Java 17

Guys,
Regarding possible migration I have a question. Will we have performance degradation with @Java 8 -> Java 17... Eugenie Lyzenko

03:46 PM Runtime Infrastructure Feature #6692: move FWD to Java 17

Did you test both embedded mode and virtual desktop in Hotel GUI?
Did you test call graph in Hotel GUI?
We need... Greg Shah

02:43 PM Runtime Infrastructure Feature #6692: move FWD to Java 17

Greg Shah wrote:
> I know you've been doing some amount of testing on this. As far as I know, we only have testing ... Tomasz Domin

02:07 PM Runtime Infrastructure Feature #6692 (Internal Test): move FWD to Java 17

I know you've been doing some amount of testing on this. As far as I know, we only have testing and any fixes that a... Greg Shah

05:09 PM Base Language Feature #6407: name_map.xml improvements

> We had this discussion before - moving *everything* to annotations will mean the entire converted .class code needs... Greg Shah

03:58 PM Base Language Feature #6407: name_map.xml improvements

Greg Shah wrote:
> > another improvement would be to emit some kind of special constructs for the virtual functions/... Constantin Asofiei

03:50 PM Base Language Feature #6407: name_map.xml improvements

> another improvement would be to emit some kind of special constructs for the virtual functions/internal procedures ... Greg Shah

01:47 PM User Interface Feature #4517 (Closed): optionally back the 4GL features for Registry access with the user-specif...

Greg Shah

11:29 AM User Interface Bug #8541: Fill-In widget incorrectly resets cursor position to 0 when DISPLAY is in VALUE-CHANGE...

Updated previous message to hide customer info. Eugenie Lyzenko

11:27 AM User Interface Bug #8541: Fill-In widget incorrectly resets cursor position to 0 when DISPLAY is in VALUE-CHANGE...

The branch @8508a@ already created to accept the fixes. It has some fix candidate to review/test.
The samples to r... Eugenie Lyzenko

11:23 AM User Interface Bug #8541 (New): Fill-In widget incorrectly resets cursor position to 0 when DISPLAY is in VALUE-...

Eugenie Lyzenko

09:49 AM Base Language Feature #6417 (WIP): cleanup some known items in appserver support

Galya B

09:44 AM Base Language Feature #6417: cleanup some known items in appserver support

Test in OE for client type:
Procedure running in batch client:... Galya B

03/27/2024

07:46 PM Base Language Feature #6422: implement auditing support including AUDIT-POLICY and AUDIT-CONTROL

How can I access @TxWrapper$TransactionHelper.maybeActivateTxWrapper@? I currently have the following code (branch 64... Theodoros Theodorou

05:07 PM Base Language Feature #6410: implement additional built-in OO classes/interfaces

> It's probably useless to implement that as I don't expect those to be extended in the first place but the possibili... Greg Shah

05:06 PM Base Language Feature #6410: implement additional built-in OO classes/interfaces

Some notes from Marian:
> We had constantly issues with conversion when classes extended/implemented built-in cla... Greg Shah

11:39 AM Database Bug #8249: Introduce a fast fill method to optimize Dataset.fill

With 8363f where @DATASET:FILL@ is optimized to use @hintFullResults@, this test fails if @AdaptiveQuery.hintFullResu... Constantin Asofiei

03/26/2024

10:53 AM Conversion Tools Feature #8525: eliminate the runtime dependency on registry.xml

We have to include @registry.xml@ from the conversion into the application jar. It contains the AST IDs for the @.p2... Greg Shah

10:50 AM Conversion Tools Feature #8525 (New): eliminate the runtime dependency on registry.xml

Greg Shah

04:09 AM Base Language Feature #6410: implement additional built-in OO classes/interfaces

@Constantin, are there any changes in trunk pertaining conversion especially for classes extending/implementing skele... Marian Edu

03/25/2024

09:05 AM Base Language Feature #6417: cleanup some known items in appserver support

> I'm not sure if my reasoning is correct, but it looks like the same appserver agent can execute all types of appser... Greg Shah

06:40 AM Base Language Feature #6417: cleanup some known items in appserver support

Actually there several places where appserver tasks are executed in a different way. I've found these:
* @Agent.Agen... Galya B

06:32 AM Base Language Feature #6417: cleanup some known items in appserver support

I'm not sure if my reasoning is correct, but it looks like the same appserver agent can execute all types of appserve... Galya B

08:37 AM Base Language Feature #6826: reduce the BDT usage in FWD runtime

There are many cases where a BDT is used as a short-lived constant value. The most of case are @logical@ and @interge... Ovidiu Maxiniuc

02:53 AM Database Bug #8459: investigate changing H2 to allow NULL to equal NULL (and the impact on the other compa...

There should be a distinction between equality check when updating/inserting and the equality check when querying. We... Alexandru Lungu

03/24/2024

08:47 AM Conversion Tools Bug #8511: replace string annotation with numeric annotations

In 8363f rev 15094, annotation for runtime JAST interpreter (dynamic query conversion) are stored using an integer ID... Constantin Asofiei

08:43 AM Conversion Tools Bug #8511 (New): replace string annotation with numeric annotations

Constantin Asofiei

05:17 AM Base Language Bug #8510 (New): replace all 'new logical' in FWD runtime with logical.of or logical.UNKNOWN

Constantin Asofiei

03/22/2024

01:36 PM Database Bug #8459: investigate changing H2 to allow NULL to equal NULL (and the impact on the other compa...

Well, this is pretty bad in my opinion. I don't really have a solution for this, I need to think this through a bit m... Radu Apetrii

05:07 AM Database Bug #8459: investigate changing H2 to allow NULL to equal NULL (and the impact on the other compa...

Radu Apetrii wrote:
> Constantin Asofiei wrote:
> > The problem is this happens only when we do a unique validation... Alexandru Lungu

04:22 AM Database Bug #8459: investigate changing H2 to allow NULL to equal NULL (and the impact on the other compa...

Alexandru Lungu wrote:
> Merged to trunk as rev. 15085.
Please post to #7847 also. Constantin Asofiei

04:16 AM Database Bug #8459: investigate changing H2 to allow NULL to equal NULL (and the impact on the other compa...

Constantin Asofiei wrote:
> The problem is this happens only when we do a unique validation using SELECT, and not on... Radu Apetrii

04:10 AM Database Bug #8459: investigate changing H2 to allow NULL to equal NULL (and the impact on the other compa...

Merged to trunk as rev. 15085. Alexandru Lungu

04:04 AM Database Bug #8459: investigate changing H2 to allow NULL to equal NULL (and the impact on the other compa...

Created 8459b and committed the disable for USE_NULL_EQUALITY.
Preparing for merge with trunk. Alexandru Lungu

03:55 AM Database Bug #8459: investigate changing H2 to allow NULL to equal NULL (and the impact on the other compa...

... Constantin Asofiei

03:52 AM Database Bug #8459 (WIP): investigate changing H2 to allow NULL to equal NULL (and the impact on the other...

There is a regression in #7143-784 related to the NULL changes in H2. If I comment @use_null_equality=true;@, then t... Constantin Asofiei

09:37 AM Base Language Feature #6424: fill gaps in Java Open Client replacement (appserver client support)

This will need a guide - how to use gradle cache to run and debug a Java client project.
Galya B

09:24 AM Base Language Feature #6424: fill gaps in Java Open Client replacement (appserver client support)

Nevermind, it was on devsrv01: @scp devsrv01:/tmp/gradle-skylab.zip .@ . Galya B

09:22 AM Base Language Feature #6424: fill gaps in Java Open Client replacement (appserver client support)

Constantin, where is the project on the shared drives? I remember you gave me a path, I can't find now. Galya B

09:37 AM Database Bug #8496: investigate if a 'batch insert with deactivated index' in H2 is possible

Constantin Asofiei wrote:
> The idea is to have a mode in H2 where indexes are not *updated(?) after each insert*. ... Ovidiu Maxiniuc

07:44 AM Database Bug #8496: investigate if a 'batch insert with deactivated index' in H2 is possible

Constantin, for FILL we do 50k independent inserts. Can we maybe bulk them? Or do we actually need the intermediate s... Alexandru Lungu

09:27 AM Database Bug #8500 (Test): dataset:set-buffers must use default-buffer-handle if a temp-table handle is used

Constantin Asofiei

09:27 AM Database Bug #8500: dataset:set-buffers must use default-buffer-handle if a temp-table handle is used

Branch 8500a was merged into trunk as rev. 15086 and archived. Constantin Asofiei

09:23 AM Database Bug #8500: dataset:set-buffers must use default-buffer-handle if a temp-table handle is used

Cor, please use this archive. Constantin Asofiei

09:19 AM Database Bug #8500 (Merge Pending): dataset:set-buffers must use default-buffer-handle if a temp-table han...

Created task branch 8500a from trunk rev 15085.
Ref 15086 fixes:
* @SET-BUFFERS(handle...)@ must use the DEFAULT... Constantin Asofiei

09:13 AM Database Bug #8500 (Test): dataset:set-buffers must use default-buffer-handle if a temp-table handle is used

Constantin Asofiei

03/21/2024

03:32 PM Database Feature #7366: improve performance of buffer.fill

Idea of improvements:
* the data-source query may or may not use all record fields, depending on the mapping. We ca... Constantin Asofiei

02:55 PM Database Bug #8496: investigate if a 'batch insert with deactivated index' in H2 is possible

Above 're-balance' actually means re-building the index... so this may be expensive on its own. Constantin Asofiei

02:52 PM Database Bug #8496: investigate if a 'batch insert with deactivated index' in H2 is possible

There are operations where we do lots of inserts. In some case, in a FILL operation, some 50k temp-table records are... Constantin Asofiei

02:43 PM Database Bug #8496 (New): investigate if a 'batch insert with deactivated index' in H2 is possible

Constantin Asofiei

02:47 PM Database Bug #8451 (Test): improve performance of H2 String column comparison

Greg Shah

02:23 PM Database Bug #8451: improve performance of H2 String column comparison

Branch 8451a was created from trunk rev 15082. Rev 15083 contains the FWD-H2 build.gradle upgrade to rev 1.43.
Br... Constantin Asofiei

02:13 PM Database Bug #8451 (Merge Pending): improve performance of H2 String column comparison

ETF testing passed, starting merge. Constantin Asofiei

07:58 AM Database Bug #8451: improve performance of H2 String column comparison

Greg Shah wrote:
> Is more testing needed?
I'm doing ETF testing with it. Constantin Asofiei

02:27 PM Database Bug #8488 (Test): improve performance of WRITE-JSON

Branch 8488a was merged into trunk as rev. 15084 and archived. Constantin Asofiei

02:24 PM Database Bug #8488 (Merge Pending): improve performance of WRITE-JSON

Merging now. Constantin Asofiei

12:42 PM Database Bug #8488: improve performance of WRITE-JSON

I have re-review the 8488a up to r15080 and I am OK with the changes.
The branch can be merged to trunk. Ovidiu Maxiniuc

11:08 AM Database Bug #8488: improve performance of WRITE-JSON

I'm good with that plan. Greg Shah

10:59 AM Database Bug #8488 (Internal Test): improve performance of WRITE-JSON

There are regressions related to AdaptiveFind (from #8490), otherwise 8488a and #8451 passed.
I'm testing #8459 ne... Constantin Asofiei

07:57 AM Database Bug #8488 (Review): improve performance of WRITE-JSON

Constantin Asofiei

07:42 AM Database Bug #8488: improve performance of WRITE-JSON

Ovidiu, in rev 15080 I have the review fixes. See bellow for notes:
> * In @P2JQuery.java@, you added @public defau... Constantin Asofiei

02:12 PM Database Bug #8459 (Test): investigate changing H2 to allow NULL to equal NULL (and the impact on the othe...

Branch 8459a was merged into trunk as rev. 15082 and archived. Constantin Asofiei

02:04 PM Database Bug #8459: investigate changing H2 to allow NULL to equal NULL (and the impact on the other compa...

I've started merge of 8459a. Constantin Asofiei

06:29 AM Database Bug #8459: investigate changing H2 to allow NULL to equal NULL (and the impact on the other compa...

fwd-h2 1.42 is on projsrv01. Constantin Asofiei

05:42 AM Database Bug #8459: investigate changing H2 to allow NULL to equal NULL (and the impact on the other compa...

Constantin Asofiei wrote:
> Alexandru, I'm good.
>
> Radu: if unit tests/standalone tests are OK, please build fw... Radu Apetrii

05:20 AM Database Bug #8459: investigate changing H2 to allow NULL to equal NULL (and the impact on the other compa...

Alexandru, I'm good.
Radu: if unit tests/standalone tests are OK, please build fwd-h2 and upload it to @devsrv01:/... Constantin Asofiei

03:48 AM Database Bug #8459 (Internal Test): investigate changing H2 to allow NULL to equal NULL (and the impact on...

The unit tests in H2 suffice. I think you are good to go with the merge of 8459a_h2.
Constantin, anything to add h... Alexandru Lungu

03:43 AM Database Bug #8459: investigate changing H2 to allow NULL to equal NULL (and the impact on the other compa...

Alexandru Lungu wrote:
> What about simple comparison with @EQUAL@ (instead of 0) and @NON_EQUAL@ (instead of 5)? Am... Radu Apetrii

03:35 AM Database Bug #8459: investigate changing H2 to allow NULL to equal NULL (and the impact on the other compa...

What about simple comparison with @EQUAL@ (instead of 0) and @NON_EQUAL@ (instead of 5)? Am I missing something? Alexandru Lungu

09:30 AM Database Feature #8494: rework XmlExport with the performance improvements from JsonExport

Implement the same performance improvements as were done in #8488. Greg Shah

09:29 AM Database Feature #8494 (New): rework XmlExport with the performance improvements from JsonExport

Greg Shah

08:43 AM Database Feature #7323 (Test): Implement soft unique index in FWD-H2

Got it! Alexandru Lungu

08:43 AM Database Feature #7323: Implement soft unique index in FWD-H2

Branch 7323b was merged into trunk as rev. 15075 and archived. Constantin Asofiei

08:41 AM Database Feature #7323: Implement soft unique index in FWD-H2

Constantin, unless you started the process, I will prepare for merge in ~10 mins. Alexandru Lungu

04:26 AM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception

Branch 7045f was created from trunk rev 15077 - in rev 15078 re-fixed the regression in 7045d/e. Merged to trunk rev... Constantin Asofiei

03/20/2024

06:51 PM Database Bug #8488: improve performance of WRITE-JSON

Constantin Asofiei wrote:
> Ovidiu, an early review is appreciated - I still need to regression test in standalone t... Ovidiu Maxiniuc

03:52 PM Database Bug #8488 (WIP): improve performance of WRITE-JSON

Created branch 8488a from trunk rev 15077. In rev 15088 there are performance improvements for WRITE-JSON:
* Avoid ... Constantin Asofiei

12:25 PM Database Bug #8488 (Test): improve performance of WRITE-JSON

Constantin Asofiei

04:54 PM Database Bug #8459: investigate changing H2 to allow NULL to equal NULL (and the impact on the other compa...

Alexandru Lungu wrote:
> Can we replace these with something more suggestive. Are these EQUAL and NON_EQUAL, or some... Radu Apetrii

03:24 PM Database Bug #8459: investigate changing H2 to allow NULL to equal NULL (and the impact on the other compa...

I am OK with 8459a_h2 changes. Good addition with the unit test!
The @getValue@ looks right to me. The only concer... Alexandru Lungu

01:00 PM Base Language Feature #7045 (Test): re-implement "normal" (non-abend) stack unwinding to avoid throwing an exce...

Branch 7045e was merged into trunk as rev. 15077 and archived. Constantin Asofiei

12:45 PM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception

If you are confident it is safe, it can be merged now. Greg Shah

12:44 PM Base Language Feature #7045: re-implement "normal" (non-abend) stack unwinding to avoid throwing an exception

Greg, can this be merged? It affects a customer's app. Constantin Asofiei

07:34 AM Base Language Feature #7045 (Internal Test): re-implement "normal" (non-abend) stack unwinding to avoid throwin...

Code Review Task Branch 7045e Revision 15074
I'm OK with the change. Greg Shah

02:54 AM Base Language Feature #7045 (Review): re-implement "normal" (non-abend) stack unwinding to avoid throwing an ex...

Created task branch 7045e from trunk rev 15073. In rev 15074 fixes "RETURN statements from within a CASE statement a... Constantin Asofiei

11:05 AM Database Feature #7323 (Merge Pending): Implement soft unique index in FWD-H2

You can merge to trunk now. Greg Shah

10:50 AM Database Feature #7323: Implement soft unique index in FWD-H2

Greg Shah wrote:
> What testing is needed?
I've tested with the #8363 app and there is no regression in performance... Constantin Asofiei

07:36 AM Database Feature #7323 (Internal Test): Implement soft unique index in FWD-H2

What testing is needed? Greg Shah

06:47 AM Database Feature #7323: Implement soft unique index in FWD-H2

Alexandru, I agree, the change is in 7323b rev 15075. Constantin Asofiei

05:30 AM Database Feature #7323: Implement soft unique index in FWD-H2

Then I agree with Constantin's changes. Before, the 7323a changes, the flush (so the DB validation0 was done only if ... Alexandru Lungu

04:48 AM Database Feature #7323: Implement soft unique index in FWD-H2

Alexandru Lungu wrote:
> Radu/Constantin: can you share how the condition looked like before the 7323a changes?
Thi... Radu Apetrii

04:40 AM Database Feature #7323: Implement soft unique index in FWD-H2

AFAIK, the condition there was rewritten to consider DBUniqueCheck, but remain equivalent to what was before. I prefe... Alexandru Lungu

02:58 AM Database Feature #7323 (Review): Implement soft unique index in FWD-H2

Created task 7323b from trunk rev 15073. The fix in previous note is in rev 15074. Please review. Constantin Asofiei

08:52 AM Database Bug #8451 (Internal Test): improve performance of H2 String column comparison

Is more testing needed? Greg Shah

07:53 AM Database Bug #8451: improve performance of H2 String column comparison

The changes are good:
* Good job in leveraging the @collationKeys@ caches with this @ValueString@ ci/cs keys.
* I... Alexandru Lungu

07:43 AM Database Bug #8451: improve performance of H2 String column comparison

Checking out now. Alexandru Lungu

07:15 AM Database Bug #8451: improve performance of H2 String column comparison

Alexandru: can you review this today?
Greg: if review is OK, I'd like to get this merged. Constantin Asofiei